source stringclasses 1
value | protocol stringclasses 17
values | title stringlengths 4 24 | severity_raw stringclasses 8
values | severity stringclasses 8
values | description stringlengths 198 2k | vulnerable_code stringlengths 0 2k | fixed_code stringlengths 0 2k | recommendation stringclasses 1
value | category stringclasses 12
values | report_url stringlengths 71 98 | collected_at stringlengths 32 32 | source_hash stringlengths 64 64 | code_block_count int64 0 10 | solidity_block_count int64 0 10 | total_code_chars int64 0 1.73k | github_ref_count int64 0 26 | vulnerable_code_is_url bool 2
classes | fixed_code_is_url bool 2
classes | has_code_in_description bool 2
classes | has_recommendation bool 1
class | quality_estimate stringclasses 2
values | primary_code stringlengths 0 1.72k | primary_code_language stringclasses 19
values | primary_code_char_count int64 0 1.72k | all_code_blocks stringlengths 0 1.87k | all_code_blocks_count int64 0 10 | has_diff_blocks bool 2
classes | diff_code stringclasses 71
values | solidity_code stringlengths 0 1.68k | github_refs_formatted stringlengths 0 562 | github_files_list stringlengths 0 203 | github_refs_count int64 0 26 | vulnerable_code_actual stringlengths 0 2k | has_vulnerable_code_snippet bool 2
classes | fixed_code_actual stringlengths 0 2k | has_fixed_code_snippet bool 2
classes | has_vuln_fix_pair bool 2
classes | content_richness_score float64 2.4 15 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
c4 | 08-dopex | 0x11singh99 Analysis | High | high | ### RdpxV2Core.sol
It is the main contract of the system which is handling bonding and maintaining peg of `DpxEth` price with `weth` price. After analysis this contract i have some suggestions for it.
1. To maintain data of reserve assets in this Core contract. We can change it's layout to remove 1 extra mapping `re... | https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/IRdpxV2Core.sol#L43C2-L48C1
| https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/RdpxV2Core.sol#L61C1-L73C51
It will simplify the accessing of reserve assets. Because contract is using symbol as the key to search asset, so it can also be done with it. By this change same goal can be achieved with many advantages. eg: Lesser state... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0x11singh99-Analysis.md | 2026-01-02T18:24:08.304331+00:00 | 00006e9fc18a8e03fa3cb1a162be98ab358027c14204782e7df45664158488bf | 2 | 2 | 621 | 2 | true | false | true | false | high | File : /contracts/core/IRdpxV2Core.sol
//@audit this is defined inside IRdpxV2Core
struct ReserveAsset {
address tokenAddress;
uint256 tokenBalance;
- string tokenSymbol;
} | diff | 224 | // Code block 1 (diff):
File : /contracts/core/IRdpxV2Core.sol
//@audit this is defined inside IRdpxV2Core
struct ReserveAsset {
address tokenAddress;
uint256 tokenBalance;
- string tokenSymbol;
}
// Code block 2 (diff):
File: /contracts/core/RdpxV2Core.sol
- Res... | 2 | true | File : /contracts/core/IRdpxV2Core.sol
//@audit this is defined inside IRdpxV2Core
struct ReserveAsset {
address tokenAddress;
uint256 tokenBalance;
- string tokenSymbol;
}
File: /contracts/core/RdpxV2Core.sol
- ReserveAsset[] public reserveAsset;
- s... | IRdpxV2Core.sol#L43-L2, RdpxV2Core.sol#L61-L1 | RdpxV2Core.sol, IRdpxV2Core.sol | 2 | false | https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/RdpxV2Core.sol#L61C1-L73C51
It will simplify the accessing of reserve assets. Because contract is using symbol as the key to search asset, so it can also be done with it. By this change same goal can be achieved with many advantages. eg: Lesser state... | true | false | 9 | |||
c4 | 02-ethos | GalloDaSballo Q | Critical | critical | # Executive Summary
The following QA Report is an aggregate of smaller reports divided by contract / topic
The following criteria are used for suggested severity
L - Low Severity -> Some risk
R - Refactoring -> Suggested changes for improvements
NC - Non-Critical / Informational -> Minor suggestions
# List of al... | uint256 public withdrawMaxLoss = 1;
| function _atLeastRole(bytes32 _role) internal view {
bytes32[] memory cascadingAccessRoles = _cascadingAccessRoles();
uint256 numRoles = cascadingAccessRoles.length;
bool specifiedRoleFound = false;
bool senderHighestRoleFound = false;
// {_role} must be found in the {cascad... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/GalloDaSballo-Q.md | 2026-01-02T18:16:12.532910+00:00 | 002a99aeb152e11d44f40ea0c3c5e6e74773e719f238e173ee0854806632159f | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | uint256 public withdrawMaxLoss = 1;
| true | function _atLeastRole(bytes32 _role) internal view {
bytes32[] memory cascadingAccessRoles = _cascadingAccessRoles();
uint256 numRoles = cascadingAccessRoles.length;
bool specifiedRoleFound = false;
bool senderHighestRoleFound = false;
// {_role} must be found in the {cascad... | true | true | 5 | ||||||||
c4 | 02-ethos | 0x007 G | Gas | gas | ## Reduce the size of error messages (Long revert Strings)
Shortening revert strings to fit in 32 bytes will decrease deployment time gas and will decrease runtime gas when the revert condition is met.
Cases can be found in `find . -name "*.sol" |xargs grep -n -E 'require.*".{36,}"'`
## Use multiple require statement ... | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | oracle | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/0x007-G.md | 2026-01-02T18:15:40.626529+00:00 | 002c6021d44956e92a1ee9701025b0c43934dbe330de2bc133c22655752648b8 | 1 | 1 | 284 | 1 | false | true | true | false | medium | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | sol | 284 | // Code block 1 (sol):
struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | 1 | false | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | PriceFeed.sol#L58-L71 | PriceFeed.sol | 1 | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | true | false | false | 4.94 | ||||
c4 | 01-salty | K42 G | High | high | ## Gas Optimization Report for [Salty.IO](https://github.com/code-423n4/2024-01-salty) by K42
- Note: I made sure these optimizations are unique in relation to the Bot Report and 4Analy3er Report.
### Possible Optimizations in [ArbitrageSearch.sol](https://github.com/code-423n4/2024-01-salty/blob/main/src/arbitrage/... | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | function _rightMoreProfitable(...) internal pure returns (bool) {
// ... [existing calculations]
return int256(amountOutRight) - int256(midpoint + MIDPOINT_PRECISION) > profitMidpoint;
} | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/K42-G.md | 2026-01-02T19:01:22.378584+00:00 | 00346fb83aaeb3174399c40495e624cd688420afa7d08a9e673b95f875fcea88 | 2 | 2 | 519 | 4 | false | false | true | false | high | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | solidity | 325 | // Code block 1 (solidity):
function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct ref... | 2 | false | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | ArbitrageSearch.sol, ArbitrageSearch.sol#L31-L1, ArbitrageSearch.sol#L63-L2, ArbitrageSearch.sol#L101-L2 | ArbitrageSearch.sol | 4 | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | true | function _rightMoreProfitable(...) internal pure returns (bool) {
// ... [existing calculations]
return int256(amountOutRight) - int256(midpoint + MIDPOINT_PRECISION) > profitMidpoint;
} | true | true | 8 | ||
c4 | 08-dopex | Kaysoft Q | Low | low | ## [NC-01] `approveContractToSpend` will return wrong error message when `_amount` does not pass the validation check.
File: https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/core/RdpxV2Core.sol#L410
- Wrong error code was supplied to the third validation in this code.... | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
IERC20WithBurn(_token).ap... | // ERROR CODES
// E1: "Insufficient bond amount",
// E2: "Bond has expired",
// E3: "Invalid parameters",
// E4: "Invalid amount",
// E5: "Not enough ETH available from the delegate",
// E6: "Invalid bond ID",
// E7: "Bond has not matured",
// E8: "Fee cannot be more than 100",
// E9: "msg.sender is not the owner",
// ... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Kaysoft-Q.md | 2026-01-02T18:24:46.584559+00:00 | 0049135df58dc2121ea1a2df2ec7847962a83d93a58acc16f84ff81d6ce062bd | 3 | 0 | 1,420 | 1 | false | false | true | false | high | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
IERC20WithBurn(_token).ap... | unknown | 349 | // Code block 1 (unknown):
function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
... | 3 | false | RdpxV2Core.sol#L410 | RdpxV2Core.sol | 1 | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
IERC20WithBurn(_token).ap... | true | // ERROR CODES
// E1: "Insufficient bond amount",
// E2: "Bond has expired",
// E3: "Invalid parameters",
// E4: "Invalid amount",
// E5: "Not enough ETH available from the delegate",
// E6: "Invalid bond ID",
// E7: "Bond has not matured",
// E8: "Fee cannot be more than 100",
// E9: "msg.sender is not the owner",
// ... | true | true | 9 | |||
c4 | 07-amphora | wahedtalash77 G | High | high | ## [G-01] For uint use != 0 instead of > 0
558: `if (_fee > 0) usda.vaultControllerMint(owner(), _fee);`
https://github.com/code-423n4/2023-07-amphora/blob/main/core/solidity/contracts/core/VaultController.sol#L558
660: ` if (_tokenAmount > 0) _tokensToLiquidate = _tokenAmount;`
https://github.com/code-423n4/2023-07-a... | 223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | //f(x) is a low gas cost operation
//g(y) is a high gas cost operation
//Sort operations with different gas costs as follows
f(x) || g(y)
f(x) && g(y) | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/wahedtalash77-G.md | 2026-01-02T18:24:04.914642+00:00 | 006cd7fee2876c8d4033f26b53b5f916cced62539a55a075b58ffd5fad89330e | 1 | 0 | 149 | 6 | false | false | true | false | high | 223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | unknown | 149 | // Code block 1 (unknown):
223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | 1 | false | VaultController.sol#L558, VaultController.sol#L660, Vault.sol#L206, Vault.sol#L223-L6, GovernorCharlie.sol#L259, GovernorCharlie.sol#L382 | GovernorCharlie.sol, VaultController.sol, Vault.sol | 6 | 223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | true | //f(x) is a low gas cost operation
//g(y) is a high gas cost operation
//Sort operations with different gas costs as follows
f(x) || g(y)
f(x) && g(y) | true | true | 7 | |||
c4 | 03-asymmetry | DadeKuma Q | Critical | critical |
## Summary
---
### Low Risk Findings
|Id|Title|Instances|
|:--:|:-------|:--:|
|[L-01]| No limits to max slippage | 1 |
|[L-02]| Missing safe limits in `setMinAmount` and `setMaxAmount` | 1 |
|[L-03]| Owner can renounce ownership | 17 |
|[L-04]| Lack of two-step Ownership | 4 |
Total: 23 instances over 4 issues.
#... | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | File: contracts/SafEth/SafEth.sol
214: function setMinAmount(uint256 _minAmount) external onlyOwner {
215: minAmount = _minAmount;
216: emit ChangeMinAmount(minAmount);
217: }
223: function setMaxAmount(uint256 _maxAmount) external onlyOwner {
224: maxAmount = _maxAmount... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/DadeKuma-Q.md | 2026-01-02T18:17:59.767058+00:00 | 00acaef05b698847bfefa32055c8cba710d00377fa0c07ff7d9c5d14fe28d1ba | 2 | 2 | 704 | 0 | false | false | true | false | high | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | solidity | 322 | // Code block 1 (solidity):
File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeI... | 2 | false | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | 0 | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | true | File: contracts/SafEth/SafEth.sol
214: function setMinAmount(uint256 _minAmount) external onlyOwner {
215: minAmount = _minAmount;
216: emit ChangeMinAmount(minAmount);
217: }
223: function setMaxAmount(uint256 _maxAmount) external onlyOwner {
224: maxAmount = _maxAmount... | true | true | 7 | ||||
c4 | 09-ondo | catwhiskeys Q | Unknown | unknown | # 1) Function with wrong functionality
The `_mul` function wasn't coded well. It should return multiplication of 2 numbers, but the function might return nothing.
Instance:
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/rwaOracles/RWADynamicOracle.sol#L405
PoC
For example, x=1, y=2. In this case, func... | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
} | - function pauseOracle() external onlyRole(PAUSER_ROLE) {
+ function pauseOracle() external onlyRole(DEFAULT_ADMIN_ROLE) {
_pause();
} | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/catwhiskeys-Q.md | 2026-01-02T18:25:52.035771+00:00 | 00b28b7de051f0271d24e95a420e719e0534b51a71c304fa4d5e7ec782cefb08 | 2 | 0 | 245 | 2 | false | false | true | false | high | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
} | unknown | 107 | // Code block 1 (unknown):
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
}
// Code block 2 (unknown):
- function pauseOracle() external onlyRole(PAUSER_ROLE) {
+ function pauseOracle() external onlyRole(DEFAULT_ADMIN_ROLE) {
_pause();
} | 2 | false | RWADynamicOracle.sol#L405, RWADynamicOracle.sol#L241 | RWADynamicOracle.sol | 2 | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
} | true | - function pauseOracle() external onlyRole(PAUSER_ROLE) {
+ function pauseOracle() external onlyRole(DEFAULT_ADMIN_ROLE) {
_pause();
} | true | true | 7.65 | |||
c4 | 01-biconomy | W0RR1O G | Medium | medium | Use ++i instead of i++ to save gas
===============
this gas optimization can be done in the following lines:
`https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/aa-4337/core/EntryPoint.sol#L74`
`https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/... | pragma solidity ^0.8.12;
//Not optimized contract
contract TestA{
uint private num;
function testA() public{
num += 1;
}
}
//Optimized contract
contract TestB{
uint private num;
function testB() public{
num = num + 1;
}
} | contract TestA = 50027gas
contract TestB = 50012gas | upgrade | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/W0RR1O-G.md | 2026-01-02T18:13:26.530549+00:00 | 00e2fa3e965f168636430d93059c3f91fd8d428192c2a5fef9874ca7ae813b67 | 0 | 0 | 0 | 8 | false | false | false | false | medium | 0 | 0 | false | EntryPoint.sol#L74, EntryPoint.sol#L80, EntryPoint.sol#L99, EntryPoint.sol#L112, EntryPoint.sol#L128, EntryPoint.sol#L134, Executor.sol#L28, Proxy.sol#L16 | Executor.sol, Proxy.sol, EntryPoint.sol | 8 | pragma solidity ^0.8.12;
//Not optimized contract
contract TestA{
uint private num;
function testA() public{
num += 1;
}
}
//Optimized contract
contract TestB{
uint private num;
function testB() public{
num = num + 1;
}
} | true | contract TestA = 50027gas
contract TestB = 50012gas | true | true | 6 | ||||||
c4 | 11-kelp | 0xhex G | Low | low | # Gas-Optimization
## [G-01] Use do while loops instead of for loops
```solidity
File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) {
```
https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTOracle.sol#L66
```solidity
File: src/LRTDepositPool.sol
82 for (uint... | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) { | File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) { | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/0xhex-G.md | 2026-01-02T18:27:15.511639+00:00 | 01246ab8601ca24ef3d737df26bc1883dede0e8c82fe48c4677f6faed634a8ab | 9 | 9 | 882 | 8 | false | false | true | false | high | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) { | solidity | 93 | // Code block 1 (solidity):
File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) {
// Code block 2 (solidity):
File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) {
// Code block 3 (solidity):
File: src/NodeDelegator... | 9 | false | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) {
File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) {
File: src/NodeDelegator.sol
109 for (uint256 i = 0; i < strategiesLength;) {
File: src/LRTDepositP... | LRTOracle.sol#L66, LRTDepositPool.sol#L82, NodeDelegator.sol#L109, LRTDepositPool.sol#L22, LRTConfig.sol#L19, RSETH.sol#L21, LRTDepositPool.sol#L20, LRTConfigRoleChecker.sol#L14 | LRTConfigRoleChecker.sol, LRTOracle.sol, RSETH.sol, NodeDelegator.sol, LRTConfig.sol, LRTDepositPool.sol | 8 | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) { | true | File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) { | true | true | 15 | ||
c4 | 11-kelp | spark Q | Low | low | # 1. Potential Data Inconsistency between `tokenMap` and `isSupportedAsset`
In contract `LRTConfig`, the token info is split into two storage:
- ``tokenMap``
- `isSupportedAsset`.
And each storage will be updated by the different role:
- ``tokenMap`` -> admin
- `isSupportedAsset` -> manager
As a result, there ... | rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/spark-Q.md | 2026-01-02T18:28:28.630091+00:00 | 015cb04f97aad19d479bce89363eee5ac2f3b01a2563218ebb72a04e95c768cf | 1 | 0 | 90 | 0 | false | true | true | false | medium | rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | unknown | 90 | // Code block 1 (unknown):
rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | 1 | false | 0 | rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | true | false | false | 3.85 | |||||||
c4 | 11-kelp | phoenixV110 Q | Low | low | # [L-01] Modifier `onlySupportedAsset()` is missing in `getAssetBalance()`
https://github.com/code-423n4/2023-11-kelp/blob/main/src/NodeDelegator.sol#L121-L124
## Description
The method `getAssetBalance()` doesn't check if the asset is a supportedAsset or not. Which can revert or will return wrong values if **assetSt... | - function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strategy).userUnderlyingView(add... | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | oracle | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/phoenixV110-Q.md | 2026-01-02T18:28:22.844057+00:00 | 01693b230f9534497016992ffe1c5fe8df0a5d38ccd5cd325aa16a02cf109112 | 2 | 0 | 516 | 3 | false | false | true | false | high | - function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strategy).userUnderlyingView(add... | unknown | 339 | // Code block 1 (unknown):
- function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strat... | 2 | false | NodeDelegator.sol#L121-L124, LRTOracle.sol#L45-L47, LRTDepositPool.sol#L151-L157 | NodeDelegator.sol, LRTDepositPool.sol, LRTOracle.sol | 3 | - function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strategy).userUnderlyingView(add... | true | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | true | true | 8 | |||
c4 | 05-ajna | codeslide Q | Critical | critical | ### Low Risk Issues List
| Number | Issue | Instances |
| :----: | :---------------------- | :-------: |
| [L-01] | Unsafe casting of uints | 7 |
#### [L-01] Unsafe casting of uints
Downcasting from uint256 in Solidity does not revert on overflow. This can result in undesired exploitation o... | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | // Yes
x = 1;
y = 2;
longVariable = 3;
// No
x = 1;
y = 2;
longVariable = 3; | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/codeslide-Q.md | 2026-01-02T18:21:24.387068+00:00 | 01cb0f4b0d1ac42068ff43574adf0b1def5662dcd738b80578731d16d012323d | 1 | 1 | 762 | 0 | false | false | true | false | high | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | solidity | 762 | // Code block 1 (solidity):
File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch)... | 1 | false | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | 0 | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | true | // Yes
x = 1;
y = 2;
longVariable = 3;
// No
x = 1;
y = 2;
longVariable = 3; | true | true | 6 | ||||
c4 | 08-dopex | Aymen0909 Q | Critical | critical | # QA Report
## Summary
| | Issue | Risk | Instances |
| :-------------: |:-------------|:-------------:|:-------------:|
| 1 | Potential underflow in `RdpxV2Core.calculateBondCost` will cause DOS of bond operations | Low | 1 |
| 2 | Missing `sync()` after transferring funds to `RdpxV2Cor... | rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | function calculateBondCost(
uint256 _amount,
uint256 _rdpxBondId
) public view returns (uint256 rdpxRequired, uint256 wethRequired) {
uint256 rdpxPrice = getRdpxPrice();
if (_rdpxBondId == 0) {
uint256 bondDiscount = (bondDiscountFactor *
Math.sqrt(IRdpxReserve(addresses.rdpxReserve)... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Aymen0909-Q.md | 2026-01-02T18:24:30.378248+00:00 | 01d558201cd0629413c725a041a2c7d44ec8d438bb433d14328dc9fb1f274fe3 | 1 | 0 | 156 | 0 | false | false | true | false | high | rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | unknown | 156 | // Code block 1 (unknown):
rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | 1 | false | 0 | rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | true | function calculateBondCost(
uint256 _amount,
uint256 _rdpxBondId
) public view returns (uint256 rdpxRequired, uint256 wethRequired) {
uint256 rdpxPrice = getRdpxPrice();
if (_rdpxBondId == 0) {
uint256 bondDiscount = (bondDiscountFactor *
Math.sqrt(IRdpxReserve(addresses.rdpxReserve)... | true | true | 6 | |||||
c4 | 05-ajna | rbserver Q | Critical | critical | ## QA REPORT
| |Issue|
|-|:-|
| [01] | `CHALLENGE_PERIOD_LENGTH`, `DISTRIBUTION_PERIOD_LENGTH`, `FUNDING_PERIOD_LENGTH`, AND `MAX_EFM_PROPOSAL_LENGTH` ARE HARDCODED BASED ON 7200 BLOCKS PER DAY |
| [02] | AMBIGUITY IN `StandardFunding._standardProposalState` FUNCTION |
| [03] | `ExtraordinaryFundingProposal.votesRecei... | /**
* @notice Length of the challengephase of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 7 days.
* @dev The period in which funded proposal slates can be checked in updateSlate.
*/
uint256 internal constant CHALLENGE_PERIOD_LENGTH = 50400; | /**
* @notice Length of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 90 days.
*/
uint48 internal constant DISTRIBUTION_PERIOD_LENGTH = 648000; | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/rbserver-Q.md | 2026-01-02T18:21:44.964488+00:00 | 020204fc263ca1de1aa20e69d328e7ab101bcfe68411350f6cfb4d47def4bc67 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | /**
* @notice Length of the challengephase of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 7 days.
* @dev The period in which funded proposal slates can be checked in updateSlate.
*/
uint256 internal constant CHALLENGE_PERIOD_LENGTH = 50400; | true | /**
* @notice Length of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 90 days.
*/
uint48 internal constant DISTRIBUTION_PERIOD_LENGTH = 648000; | true | true | 5 | ||||||||
c4 | 02-ethos | LethL Q | Critical | critical | ## Low Issues
| | Issue | Instances |
|---|---|---|
| Low-1 | Lack of checks-effects-interactions | 1 |
| Low-2 | Loss of precision due to rounding | 1 |
| Low-3 | Outdated Compiler Version | 8 |
### [Low-1] Lack of checks-effects-interactions
External calls should be executed after state changes to avoid reetrancy b... | File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance")); | File: Ethos-Vault/contracts/ReaperVaultV2.sol
463: uint256 performanceFee = (gain * strategies[strategy].feeBPS) / PERCENT_DIVISOR; | slippage | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/LethL-Q.md | 2026-01-02T18:16:19.793349+00:00 | 021c777991438066d83b490bb5fabcffbd39ff2bc4af35d9810759440aa9c8be | 2 | 0 | 361 | 7 | false | false | true | false | high | File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance")); | unknown | 222 | // Code block 1 (unknown):
File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance"));
// Code block 2 (unknown):
File: Ethos-Vault/contracts/ReaperVaultV2.... | 2 | false | LUSDToken.sol#L237-L238, ReaperVaultV2.sol#L463, CollateralConfig.sol#L3, BorrowerOperations.sol#L3, TroveManager.sol#L3, ActivePool.sol#L3, StabilityPool.sol#L3 | StabilityPool.sol, TroveManager.sol, BorrowerOperations.sol, ReaperVaultV2.sol, LUSDToken.sol, ActivePool.sol, CollateralConfig.sol | 7 | File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance")); | true | File: Ethos-Vault/contracts/ReaperVaultV2.sol
463: uint256 performanceFee = (gain * strategies[strategy].feeBPS) / PERCENT_DIVISOR; | true | true | 8 | |||
c4 | 09-ondo | zigtur Q | Unknown | unknown | # Unused code should be deleted and not commented out
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/bridge/MintRateLimiter.sol#L56-L64
MintRateLimiter.sol constructor has some commented out code.
This code should be deleted if not used in production. Here is the fixed constructor:
```solidity
cons... | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | other | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/zigtur-Q.md | 2026-01-02T18:26:23.876288+00:00 | 0270e83c30f0531078084990070eded176ed8c6bcfdcf3aa3fcc9b94f36b85a6 | 1 | 1 | 262 | 3 | false | true | true | false | medium | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | solidity | 262 | // Code block 1 (solidity):
constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | 1 | false | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | MintRateLimiter.sol#L56-L64, rUSDY.sol#L586-L592, rUSDY.sol#L172-L177 | rUSDY.sol, MintRateLimiter.sol | 3 | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | true | false | false | 6 | ||||
c4 | 03-revert-lend | slvDev G | High | high | ## Gas Findings
| | Issue | Instances | Total Gas Saved |
|----|-------|:---------:|:---------:|
| [G-01] | Optimize Storage Layout in Structs | 5 | 100000 |
| [G-02] | Optimize Storage with Byte Truncation for Time Related State Variables | 1 | 20000 |
| [G-03] | Contract storage can use fewer slots by changing th... | File: src/V3Oracle.sol
/// @audit - Struct used 6 storage slots, but can be packed to 4 storage slots.
// struct TokenConfig {
// Mode mode;
// IUniswapV3Pool pool;
// AggregatorV3Interface feed;
// uint32 twapSeconds;
// uint32 maxFeedAge;
// uint16 maxDifference;
// uint8 tokenDecimals;
/... | File: src/automators/AutoExit.sol
/// @audit - Struct used 7 storage slots, but can be packed to 6 storage slots.
// struct ExecuteParams {
// uint256 deadline;
// uint256 amountRemoveMin1;
// uint256 amountRemoveMin0;
// bytes swapData;
// uint256 tokenId;
// uint128 liquidity;
// uint64 r... | reentrancy | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/slvDev-G.md | 2026-01-02T19:03:17.736684+00:00 | 027a908a2f124e1fe4e34524ccf0ad4c179f7b7685261d2de053edcd8bce6464 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: src/V3Oracle.sol
/// @audit - Struct used 6 storage slots, but can be packed to 4 storage slots.
// struct TokenConfig {
// Mode mode;
// IUniswapV3Pool pool;
// AggregatorV3Interface feed;
// uint32 twapSeconds;
// uint32 maxFeedAge;
// uint16 maxDifference;
// uint8 tokenDecimals;
/... | true | File: src/automators/AutoExit.sol
/// @audit - Struct used 7 storage slots, but can be packed to 6 storage slots.
// struct ExecuteParams {
// uint256 deadline;
// uint256 amountRemoveMin1;
// uint256 amountRemoveMin0;
// bytes swapData;
// uint256 tokenId;
// uint128 liquidity;
// uint64 r... | true | true | 5 | ||||||||
c4 | 06-lybra | DavidGiladi G | High | high | # Report: Identified 12 Distinct Gas Optimization Opportunities
- [Multiplication and Division by 2 Should use in Bit Shifting](#multiplication-and-division-by-2-should-use-in-bit-shifting) (2 results) (Gas Optimization)
- [Modulus operations that could be unchecked](#modulus-operations-that-could-be-unchecked) (1 r... | Line: 17 abstract contract LybraEUSDVaultBase | Line: 159 require(assetAmount * 2 <= depositedAsset[onBehalfOf], "a max of 50% collateral can be liquidated");
| access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/DavidGiladi-G.md | 2026-01-02T18:22:16.401600+00:00 | 02ef14b7b45ee43de23aa9b2270b2853f3c798647a91c4881b5c0c4580009294 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | Line: 17 abstract contract LybraEUSDVaultBase | true | Line: 159 require(assetAmount * 2 <= depositedAsset[onBehalfOf], "a max of 50% collateral can be liquidated");
| true | true | 5 | ||||||||
c4 | 06-lybra | Chandr Q | Low | low | L[1]: The depositEtherToMint function does not follow a standard pattern for total balance calculation
code: https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/pools/LybraWstETHVault.sol#L29-L46
```
function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.... | function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(collateralAsset), msg.value... | other | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/Chandr-Q.md | 2026-01-02T18:22:13.462518+00:00 | 0355aa725ebd413a5c86e3d07d1177a14365bf9cb00b4440b2adc15243918017 | 1 | 0 | 685 | 1 | false | true | true | false | medium | function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(collateralAsset), msg.value);
... | unknown | 685 | // Code block 1 (unknown):
function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(coll... | 1 | false | LybraWstETHVault.sol#L29-L46 | LybraWstETHVault.sol | 1 | function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(collateralAsset), msg.value... | true | false | false | 5.05 | |||||
c4 | 08-dopex | Strausses Q | Medium | medium | L1 - Create an error when the first value is bigger than the second one.
Add this piece of code.
```
_validate(delegate.amount - delegate.activeCollateral, 15);
```
Otherwise tx could just revert without any error message
https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contrac... | _validate(delegate.amount - delegate.activeCollateral, 15); | validation | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Strausses-Q.md | 2026-01-02T18:25:07.210115+00:00 | 03c0ab52a3d681ac089f909d6999b79e07cb9e24745252fde2d9d0d996b785ba | 1 | 0 | 59 | 8 | false | true | true | false | medium | _validate(delegate.amount - delegate.activeCollateral, 15); | unknown | 59 | // Code block 1 (unknown):
_validate(delegate.amount - delegate.activeCollateral, 15); | 1 | false | RdpxV2Core.sol#L983, PerpetualAtlanticVaultLP.sol#L120-L13, RdpxV2Core.sol#L1018, PerpetualAtlanticVaultLP.sol#L286, PerpetualAtlanticVaultLP.sol#L156, UniV2LiquidityAmo.sol#L74-L102, RdpxV2Core.sol#L305, ReLPContract.sol#L115 | ReLPContract.sol, RdpxV2Core.sol, UniV2LiquidityAmo.sol, PerpetualAtlanticVaultLP.sol | 8 | _validate(delegate.amount - delegate.activeCollateral, 15); | true | false | false | 6 | |||||
c4 | 01-biconomy | __141345__ G | Low | low | #### Update value order can be adjusted to simplify the code and save gas
For example, to update the `val` variable with `newVal`, the current way is as following:
```solidity
uint oldVal = val;
val = newVal;
emit update(oldVal, newVal);
```
If the execution order is adjusted, some operations can be save... | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal); | emit update(val, newVal);
val = newVal; | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/__141345__-G.md | 2026-01-02T18:13:27.901398+00:00 | 03d0c89b090e0b5cfab4c3d8140366fb923e48ca5357fe87a0c957906db3c35e | 3 | 2 | 140 | 1 | false | false | true | false | high | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal); | solidity | 69 | // Code block 1 (solidity):
uint oldVal = val;
val = newVal;
emit update(oldVal, newVal);
// Code block 2 (solidity):
emit update(val, newVal);
val = newVal;
// Code block 3 (unknown):
The above can be changed to: | 3 | false | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal);
emit update(val, newVal);
val = newVal; | oldnew.sol | oldnew.sol | 1 | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal); | true | emit update(val, newVal);
val = newVal; | true | true | 9 | ||
c4 | 11-kelp | bronze_pickaxe Q | Low | low | # 1. maxNodeDelegatorCount does not get enforced
### Impact
There are a few problems with the usage of `maxNodeDelegatorCount` in `LRTDepositPool.sol`.
First problem, consider the following:
- `maxNodeDelegatorCount = 10`
- 10 `NodeDelegators` have been added using `LRTDepositPool.addNodeDelegatorContractToQueue`
- ... | uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecked {
++i; | address nodeDelegator = nodeDelegatorQueue[ndcIndex];
if (!IERC20(asset).transfer(nodeDelegator, amount)) {
revert TokenTransferFailed(); | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/bronze_pickaxe-Q.md | 2026-01-02T18:27:51.537433+00:00 | 04218453c20e98518e966220c7707a07e11c32fb8bde5ad5ee5167ec665d3a3d | 2 | 0 | 471 | 2 | false | false | true | false | high | uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecked {
++i; | javascript | 314 | // Code block 1 (javascript):
uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecke... | 2 | false | LRTDepositPool.sol#L81-L86, LRTDepositPool.sol#L193-L195 | LRTDepositPool.sol | 2 | uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecked {
++i; | true | address nodeDelegator = nodeDelegatorQueue[ndcIndex];
if (!IERC20(asset).transfer(nodeDelegator, amount)) {
revert TokenTransferFailed(); | true | true | 8 | |||
c4 | 11-kelp | 0xAnah G | High | high | # KELP PROTOCOL GAS OPTIMISATIONS
## INTRODUCTION
Some of optimizations underwent benchmarking using the protocol's tests, specifically employing the following configuration: `solc version 0.8.21`, `optimizer enabled,` and `10_000` runs. For optimizations that were not subjected to benchmarking, their rationale is e... | file: src/LRTConfig.sol
15: mapping(address token => bool isSupported) public isSupportedAsset;
16: mapping(address token => uint256 amount) public depositLimitByAsset;
17: mapping(address token => address strategy) public override assetStrategy; | ```
Estimated gas saved: 60k gas units | reentrancy | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/0xAnah-G.md | 2026-01-02T18:27:09.596200+00:00 | 04b1ed0bfae3c1e7aa408e28fce8fda7d5ef82c70111f199da3723a1137375fb | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | LRTConfig.sol#L15 | LRTConfig.sol | 1 | file: src/LRTConfig.sol
15: mapping(address token => bool isSupported) public isSupportedAsset;
16: mapping(address token => uint256 amount) public depositLimitByAsset;
17: mapping(address token => address strategy) public override assetStrategy; | true | ```
Estimated gas saved: 60k gas units | true | true | 6 | ||||||
c4 | 02-ai-arena | Timenov G | Medium | medium | # AI Arena Gas report by Timenov
## Summary
| |Issue|Instances|
|-|:-|:-:|
| G-01 | Array's cached length not used optimally. | 8 |
| G-02 | Smaller uint can be used. | 1 |
| G-03 | State variable can be removed. | 1 |
| G-04 | State variable can be updated after loop. | 2 |
| G-05 | Unnecessary validation. | 1 |
| ... | https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L70-L72
| https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L96-L98
| access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/Timenov-G.md | 2026-01-02T19:02:47.423442+00:00 | 04f1027f67bac208e2ecce3eb1245ec5cbcc84723dfaf63987dc382c648a3858 | 2 | 2 | 788 | 2 | true | true | true | false | medium | function addAttributeDivisor(uint8[] memory attributeDivisors) external {
require(msg.sender == _ownerAddress);
+ uint256 attributesLength = attributes.length;
- require(attributeDivisors.length == attributes.length);
+ require(attributeDivisors.length == attributesLength);
- uint256 at... | diff | 499 | // Code block 1 (diff):
function addAttributeDivisor(uint8[] memory attributeDivisors) external {
require(msg.sender == _ownerAddress);
+ uint256 attributesLength = attributes.length;
- require(attributeDivisors.length == attributes.length);
+ require(attributeDivisors.length == attributesLeng... | 2 | true | function addAttributeDivisor(uint8[] memory attributeDivisors) external {
require(msg.sender == _ownerAddress);
+ uint256 attributesLength = attributes.length;
- require(attributeDivisors.length == attributes.length);
+ require(attributeDivisors.length == attributesLength);
- uint256 at... | AiArenaHelper.sol#L70-L72, AiArenaHelper.sol#L96-L98 | AiArenaHelper.sol | 2 | false | false | false | 8 | ||||
c4 | 03-asymmetry | PNS Q | Critical | critical | [L-1] Missing event for critical parameter change
===
```solidity
File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: }
```
Similarly in `SfrxEth.sol` and `WstEth.sol`
This method can be called directly on a der... | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: } | emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage); | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/PNS-Q.md | 2026-01-02T18:18:24.291683+00:00 | 05208d00e93b305b181822698aa3511647ff00485a4ee4dff3a7aa62c08f7ee7 | 8 | 8 | 968 | 0 | false | false | true | false | high | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: } | solidity | 162 | // Code block 1 (solidity):
File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: }
// Code block 2 (solidity):
emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage);
// Code block 3 (solidity):
File: contracts/Sa... | 8 | false | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: }
emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage);
File: contracts/SafEth/SafEth.sol
165: function adjustWeight(
166: uint256 _derivativeInde... | 0 | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: } | true | emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage); | true | true | 13 | ||||
c4 | 08-dopex | QiuhaoLi G | Gas | gas | ## We can use a put option for all delegate bonds instead of one for every option
In `bondWithDelegate` we can delecate more than once, and for every delegate we buy the option for the bond. Since all the bonds are in the same transaction, the strike price will be the same. To save gas, we can buy a single option outs... | collateralToken.safeTransfer(
addresses.perpetualAtlanticVaultLP,
(currentFundingRate * (nextFundingPaymentTimestamp() - startTime)) / // @audit-issue GAS this can be calculated only once
1e18
);
IPerpetualAtlanticVaultLP(addresses.perpetualAtlanticVaultLP)
... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/QiuhaoLi-G.md | 2026-01-02T18:24:56.450269+00:00 | 05796cce808c7135ccbb4d85d05792d96e65bf60b9cd801ff52ea9b5392861bc | 0 | 0 | 0 | 0 | false | true | false | false | medium | 0 | 0 | false | 0 | collateralToken.safeTransfer(
addresses.perpetualAtlanticVaultLP,
(currentFundingRate * (nextFundingPaymentTimestamp() - startTime)) / // @audit-issue GAS this can be calculated only once
1e18
);
IPerpetualAtlanticVaultLP(addresses.perpetualAtlanticVaultLP)
... | true | false | false | 4 | ||||||||||
c4 | 03-asymmetry | a3yip6 Q | Low | low | ## [L-01] Revert may happen if owner invoke `rebalanceToWeights` with too many tokens in derivatives
The function `rebalanceToWeights` is used by the owner to rebalence the weights of derivatives. The function would withdraw and deposit to each derivatives, which will exchange tokens with `maxSlippage`. Thus, the huge ... | File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
uint256 ethAmountAfter ... | File: /contracts/WstEth.sol
function withdraw(uint256 _amount) external onlyOwner {
// burn WStETH and withdraw stETH
IWStETH(WST_ETH).unwrap(_amount);
uint256 stEthBal = IERC20(STETH_TOKEN).balanceOf(address(this));
IERC20(STETH_TOKEN).approve(LIDO_CRV_POOL, stEthBal);
uint256 minOut = (stEthBal *... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/a3yip6-Q.md | 2026-01-02T18:18:42.301344+00:00 | 0586eb934222f280e09747dc3235562f5febbb6bc3a469e1135d7ea3fc36f3ad | 2 | 0 | 1,376 | 0 | false | false | true | false | high | File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
uint256 ethAmountAfter ... | unknown | 750 | // Code block 1 (unknown):
File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
... | 2 | false | 0 | File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
uint256 ethAmountAfter ... | true | File: /contracts/WstEth.sol
function withdraw(uint256 _amount) external onlyOwner {
// burn WStETH and withdraw stETH
IWStETH(WST_ETH).unwrap(_amount);
uint256 stEthBal = IERC20(STETH_TOKEN).balanceOf(address(this));
IERC20(STETH_TOKEN).approve(LIDO_CRV_POOL, stEthBal);
uint256 minOut = (stEthBal *... | true | true | 7 | |||||
c4 | 03-asymmetry | favelanky Q | Low | low | ## [L-1] Floating pragma
There are 5 instance of this issue:
```solidity
pragma solidity ^0.8.13;
```
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEthStorage.sol#L2
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L2
https://github.com/code-423n4/... | pragma solidity ^0.8.13; | uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) * (10 ** 18 - maxSlippage)) / 10 ** 18; | reentrancy | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/favelanky-Q.md | 2026-01-02T18:19:07.953350+00:00 | 05a3f5641d8662a84eece4af99d4aaadc604ace8a2c93c4d4e74ded54cc4eb2f | 4 | 3 | 406 | 7 | false | false | true | false | high | pragma solidity ^0.8.13; | solidity | 24 | // Code block 1 (solidity):
pragma solidity ^0.8.13;
// Code block 2 (unknown):
uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) * (10 ** 18 - maxSlippage)) / 10 ** 18;
// Code block 3 (solidity):
File: SafEth.sol
function stake() external payable {
function unstake(uint256 _safEthAmount) extern... | 4 | false | pragma solidity ^0.8.13;
File: SafEth.sol
function stake() external payable {
function unstake(uint256 _safEthAmount) external {
File: Reth.sol
IERC20(_tokenIn).approve(UNISWAP_ROUTER, _amountIn);
File: SfrxEth.sol
IsFrxEth(FRX_ETH_ADDRESS).approve(
FRX_ETH_CRV_POOL_ADDRESS,
frxEthBalance
); | SafEthStorage.sol#L2, SafEth.sol#L2, SfrxEth.sol#L2, WstEth.sol#L2, NeoTokyoStaker.sol#L1155, NeoTokyoStaker.sol#L1388, NeoTokyoStaker.sol#L1737 | SfrxEth.sol, SafEthStorage.sol, NeoTokyoStaker.sol, WstEth.sol, SafEth.sol | 7 | pragma solidity ^0.8.13; | true | uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) * (10 ** 18 - maxSlippage)) / 10 ** 18; | true | true | 10 | ||
c4 | 08-dopex | JCK G | High | high | # Gas Optimizations
| Number | Issue | Instances | Total Gas Saved |
|--------|-------|-----------|-----------------|
|[G-01]| State variables which are not modified within functions should be set as constant or immutable for values set at deployment | 7 | 70000 |
|[G-02]| create variable immutable and avoid extern... | file: contracts/perp-vault/PerpetualAtlanticVault.sol
51 string public underlyingSymbol;
60 uint256 public collateralPrecision;
| file: contracts/perp-vault/PerpetualAtlanticVaultLP.sol
49 ERC20 public collateral;
52 string public underlyingSymbol;
55 string public collateralSymbol;
67 address public rdpx;
70 address public rdpxRdpxV2Core;
| reentrancy | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/JCK-G.md | 2026-01-02T18:24:41.591957+00:00 | 05f6783602df1d888c14bb97765b3c2c59f960c0682c7d177718e522c82fe698 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | file: contracts/perp-vault/PerpetualAtlanticVault.sol
51 string public underlyingSymbol;
60 uint256 public collateralPrecision;
| true | file: contracts/perp-vault/PerpetualAtlanticVaultLP.sol
49 ERC20 public collateral;
52 string public underlyingSymbol;
55 string public collateralSymbol;
67 address public rdpx;
70 address public rdpxRdpxV2Core;
| true | true | 5 | ||||||||
c4 | 08-dopex | Giorgio Q | Gas | gas | ## Title
Consider changing variable to Constant
### Details
In the `./PerpetualAtlanticVault.sol` the `roundingPrecision` variable is initialized to 1e6, however this variable could benefit from being set to Constant for clarity since it is never changed.
#### Affected code
https://github.com/code-423n4/2023-08-do... | timeToExpiry=(genesis+(latestFundingPaymentPointer×fundingDuration))−(genesis+((latestFundingPaymentPointer−1)×fundingDuration)) | timeToExpiry =
genesis + latestFundingPaymentPointer × fundingDuration − genesis − latestFundingPaymentPointer
× fundingDuration + fundingDuration
| reentrancy | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Giorgio-Q.md | 2026-01-02T18:24:38.410538+00:00 | 06b8650bd691fbde0055e81d27315dbec833ed8fe6618a9777867d71c461b9f9 | 0 | 0 | 0 | 5 | false | false | false | false | medium | 0 | 0 | false | PerpetualAtlanticVault.sol#L103-L104, PerpetualAtlanticVault.sol#L44-L45, PerpetualAtlanticVault.sol#L127-L128, PerpetualAtlanticVault.sol#L315-L324, PerpetualAtlanticVault.sol#L372-L380 | PerpetualAtlanticVault.sol | 5 | timeToExpiry=(genesis+(latestFundingPaymentPointer×fundingDuration))−(genesis+((latestFundingPaymentPointer−1)×fundingDuration)) | true | timeToExpiry =
genesis + latestFundingPaymentPointer × fundingDuration − genesis − latestFundingPaymentPointer
× fundingDuration + fundingDuration
| true | true | 6 | ||||||
c4 | 10-badger | zabihullahazadzoi Q | Critical | critical | ## Low Issues
| |Issue|Instances|
|-|:-|:-:|
| [L-1](#L-1) | Code does not follow the best practice of check-effects-interaction | 1 |
| [L-2](#L-2) | Consider implementing two-step procedure for updating protocol addresses | 13 |
| [L-3](#L-3) | Division by zero not prevented | 19 |
| [L-4](#L-4) | Empty `receive()`... | File: packages/contracts/contracts/ActivePool.sol
/// @audit syncGlobalAccountingAndGracePeriod() prior to this assignment
398: feeRecipientAddress = _feeRecipientAddress;
| File: packages/contracts/contracts/ActivePool.sol
390: function setFeeRecipientAddress(address _feeRecipientAddress) external requiresAuth {
| reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/zabihullahazadzoi-Q.md | 2026-01-02T18:27:06.554425+00:00 | 07304e7af8df19d2031dc49a1b4fd50b7c35984ebfba9cf2dff29ac674a25614 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: packages/contracts/contracts/ActivePool.sol
/// @audit syncGlobalAccountingAndGracePeriod() prior to this assignment
398: feeRecipientAddress = _feeRecipientAddress;
| true | File: packages/contracts/contracts/ActivePool.sol
390: function setFeeRecipientAddress(address _feeRecipientAddress) external requiresAuth {
| true | true | 5 | ||||||||
c4 | 01-ondo | erictee Q | Critical | critical | ### [L-01] ```require()``` should be used instead of ```assert()```
#### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as ```require()```/```revert()``` do. ```assert()``` should be avoided even past solidity version 0.8.0... | #### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as ```require()```/```revert()``` do. ```assert()``` should be avoided even past solidity version 0.8.0 as its [documentation](https://docs.soliditylang.org/en/v0.8.14/contr... | ### [L-02] ```decimals()``` not part of ERC20 standard.
#### Impact | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/erictee-Q.md | 2026-01-02T18:15:08.309850+00:00 | 073a7289e6c1f79df0f76fe6de2120115b632b3e97269998078404b5d7641594 | 3 | 0 | 852 | 0 | false | false | true | false | high | #### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as | unknown | 149 | // Code block 1 (unknown):
#### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as
// Code block 2 (unknown):
contracts/cash/factory/CashKYCSenderFactory.sol:L106 assert(cashKYCSenderProxyAdmin.owner() == guardian);
contr... | 3 | false | 0 | #### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as ```require()```/```revert()``` do. ```assert()``` should be avoided even past solidity version 0.8.0 as its [documentation](https://docs.soliditylang.org/en/v0.8.14/contr... | true | ### [L-02] ```decimals()``` not part of ERC20 standard.
#### Impact | true | true | 8 | |||||
c4 | 07-amphora | 0xWaitress G | Informational | informational | ### [G-1] paysInterest in USDA access storage repeatedly in a loop
consider retrieve `_vaultControllers.length()` once and use it from memory in the for loop
```solidity
modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateIntere... | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
} | _gonBalances[_target] += _amount * __gonsPerFragment;
// total supply is in fragments, and so we add amount
_totalSupply += _amount;
// and totalgons of course is in gons, and so we multiply amount by gonsperfragment to get the amount of gons we must add to totalGons
_totalGons += _amount * __gonsPe... | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/0xWaitress-G.md | 2026-01-02T18:23:20.141104+00:00 | 074c684d16412908bc3a2e074e3b2613c434b917a6ffcd98220a25c4b1a2f4e9 | 2 | 2 | 535 | 0 | false | false | true | false | high | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
} | solidity | 209 | // Code block 1 (solidity):
modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
}
// Code block 2 (solidity):
_gonBalances[_target] += _amount * __gonsPerFragment;... | 2 | false | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
}
_gonBalances[_target] += _amount * __gonsPerFragment;
// total supply is in fragments, and so we add amou... | 0 | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
} | true | _gonBalances[_target] += _amount * __gonsPerFragment;
// total supply is in fragments, and so we add amount
_totalSupply += _amount;
// and totalgons of course is in gons, and so we multiply amount by gonsperfragment to get the amount of gons we must add to totalGons
_totalGons += _amount * __gonsPe... | true | true | 7 | ||||
c4 | 02-ethos | bin2chen Q | Low | low | L-1:
CollateralConfig.updateCollateralRatios() will modify the MCR and CCR, these two parameters will affect whether the user is liquidated, related to the user's collateral.
Although the administrator is a multi-signature wallet, but still need to have an effective time, to give the user sufficient time to choose whet... | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ ... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/bin2chen-Q.md | 2026-01-02T18:16:51.730460+00:00 | 074d96225c0dc17314a8af3505b669e34c6e2ef3227d61f8710f0729a23b8da4 | 1 | 1 | 392 | 0 | false | true | true | false | high | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ e... | solidity | 392 | // Code block 1 (solidity):
function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDD... | 1 | false | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ e... | 0 | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ ... | true | false | false | 5 | ||||||
c4 | 09-ondo | adriro Q | Critical | critical | # Report
## Summary
### Low Issues
Total of **10 issues**:
|ID|Issue|
|:--:|:---|
| [L-1](#l-1-confusing-semantics-for-bridged-messages-approvals) | Confusing semantics for bridged messages approvals |
| [L-2](#l-2-no-default-threshold-configuration) | No default threshold configuration |
| [L-3](#l-3-validate-numb... | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR)); | emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/adriro-Q.md | 2026-01-02T18:25:46.189325+00:00 | 0762b39b8ef2e8149cefbd48476e87ac19022a877858c3b297a2467a15a81d38 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | DestinationBridge.sol#L111 | DestinationBridge.sol | 1 | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR)); | true | emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | true | true | 6 | ||||||
c4 | 08-dopex | 0xSmartContract Q | Critical | critical | ### QA Report Issues List
- [x] **Low 01** → Role-based `PAUSER_ROLE` is incorrectly defined
- [x] **Low 02** → `swap()` function becomes unusable after 13 years
- [x] **Low 03** → getLpPrice() value is received from Oracle with External call , but doesn't check to value for unexpected return values
- [x] **Low 04** →... | contracts\reserve\RdpxReserve.sol:
22
23: constructor(address _rdpx) {
24: rdpx = _rdpx;
25: _grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
26: _grantRole(PAUSER_ROLE, msg.sender);
27: }
28:
29: /**
30: * @notice Pauses the vault for emergency cases
31: * @dev Can only be ... | ### [Low-02] swap() function becomes unusable after 13 years
`UniV3LiquidityAmo.swap() ` function is very important role in project, in line 295 also we can see , deadline is 2105300114 unixtime value , this value means ; This function becomes unusable in 13 years later
13 years not as far and this contract not upgra... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0xSmartContract-Q.md | 2026-01-02T18:24:19.561647+00:00 | 078cbbeb7d698b3951ae43f112d2c0bf6ac888bbc5b4a2d2030b36817980303a | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | contracts\reserve\RdpxReserve.sol:
22
23: constructor(address _rdpx) {
24: rdpx = _rdpx;
25: _grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
26: _grantRole(PAUSER_ROLE, msg.sender);
27: }
28:
29: /**
30: * @notice Pauses the vault for emergency cases
31: * @dev Can only be ... | true | ### [Low-02] swap() function becomes unusable after 13 years
`UniV3LiquidityAmo.swap() ` function is very important role in project, in line 295 also we can see , deadline is 2105300114 unixtime value , this value means ; This function becomes unusable in 13 years later
13 years not as far and this contract not upgra... | true | true | 5 | ||||||||
c4 | 07-amphora | Aymen0909 G | Low | low | # Gas Optimizations
## Summary
| | Issue | Instances |
| :---: |:-------------|:------------:|
| 1 | State variables should be packed to save storage slots | 3 |
| 2 | Emit events outside the for loops | 3 |
| 3 | Multiple address/IDs mappings can be combined into a single mapping of an address/id to ... | File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee; | /// @dev Percentage of rewards taken in CVX (1e18 == 100%)
uint256 public cvxRewardFee;
/// @dev Percentage of rewards taken in CRV (1e18 == 100%)
uint256 public crvRewardFee; | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/Aymen0909-G.md | 2026-01-02T18:23:22.400450+00:00 | 07b05b20259f5b7276fc1773e91ad9ad9538675c0fd7a0a2fa673e579779fecf | 5 | 0 | 761 | 0 | false | false | true | false | high | File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee; | unknown | 101 | // Code block 1 (unknown):
File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee;
// Code block 2 (unknown):
/// @dev Percentage of rewards taken in CVX (1e18 == 100%)
uint256 public cvxRewardFee;
/// @dev Percentage of rewards taken in CRV (1e18 == 100%)
uint256 public ... | 5 | false | 0 | File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee; | true | /// @dev Percentage of rewards taken in CVX (1e18 == 100%)
uint256 public cvxRewardFee;
/// @dev Percentage of rewards taken in CRV (1e18 == 100%)
uint256 public crvRewardFee; | true | true | 10 | |||||
c4 | 09-ondo | John_Femi Q | High | high | # 1
## Title
Unbounded loops used
## Impact
In the `setThresholds` function we see the function allows owner to input an unbounded length of arrays for amounts and numOfApprovers. This can lead to a long list of input which could cause the gasLimit to be hit and txn reverted with gas wasted.
## Proof of Concept
With am... | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
} | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/John_Femi-Q.md | 2026-01-02T18:25:32.662831+00:00 | 08431411cafa1ef2edda8cf4b679ff754077693e15e03486af19a30b048c0aac | 2 | 2 | 171 | 0 | false | false | true | false | high | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
} | solidity | 87 | // Code block 1 (solidity):
struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
}
// Code block 2 (solidity):
struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | 2 | false | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
}
struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | 0 | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
} | true | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | true | true | 7 |
End of preview. Expand in Data Studio
No dataset card yet
- Downloads last month
- 2