source stringclasses 1
value | protocol stringclasses 17
values | title stringlengths 4 24 | severity_raw stringclasses 8
values | severity stringclasses 8
values | description stringlengths 198 2k | vulnerable_code stringlengths 0 2k | fixed_code stringlengths 0 2k | recommendation stringclasses 1
value | category stringclasses 12
values | report_url stringlengths 71 98 | collected_at stringlengths 32 32 | source_hash stringlengths 64 64 | code_block_count int64 0 10 | solidity_block_count int64 0 10 | total_code_chars int64 0 1.73k | github_ref_count int64 0 26 | vulnerable_code_is_url bool 2
classes | fixed_code_is_url bool 2
classes | has_code_in_description bool 2
classes | has_recommendation bool 1
class | quality_estimate stringclasses 2
values | primary_code stringlengths 0 1.72k | primary_code_language stringclasses 19
values | primary_code_char_count int64 0 1.72k | all_code_blocks stringlengths 0 1.87k | all_code_blocks_count int64 0 10 | has_diff_blocks bool 2
classes | diff_code stringclasses 71
values | solidity_code stringlengths 0 1.68k | github_refs_formatted stringlengths 0 562 | github_files_list stringlengths 0 203 | github_refs_count int64 0 26 | vulnerable_code_actual stringlengths 0 2k | has_vulnerable_code_snippet bool 2
classes | fixed_code_actual stringlengths 0 2k | has_fixed_code_snippet bool 2
classes | has_vuln_fix_pair bool 2
classes | content_richness_score float64 2.4 15 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
c4 | 08-dopex | 0x11singh99 Analysis | High | high | ### RdpxV2Core.sol
It is the main contract of the system which is handling bonding and maintaining peg of `DpxEth` price with `weth` price. After analysis this contract i have some suggestions for it.
1. To maintain data of reserve assets in this Core contract. We can change it's layout to remove 1 extra mapping `re... | https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/IRdpxV2Core.sol#L43C2-L48C1
| https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/RdpxV2Core.sol#L61C1-L73C51
It will simplify the accessing of reserve assets. Because contract is using symbol as the key to search asset, so it can also be done with it. By this change same goal can be achieved with many advantages. eg: Lesser state... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0x11singh99-Analysis.md | 2026-01-02T18:24:08.304331+00:00 | 00006e9fc18a8e03fa3cb1a162be98ab358027c14204782e7df45664158488bf | 2 | 2 | 621 | 2 | true | false | true | false | high | File : /contracts/core/IRdpxV2Core.sol
//@audit this is defined inside IRdpxV2Core
struct ReserveAsset {
address tokenAddress;
uint256 tokenBalance;
- string tokenSymbol;
} | diff | 224 | // Code block 1 (diff):
File : /contracts/core/IRdpxV2Core.sol
//@audit this is defined inside IRdpxV2Core
struct ReserveAsset {
address tokenAddress;
uint256 tokenBalance;
- string tokenSymbol;
}
// Code block 2 (diff):
File: /contracts/core/RdpxV2Core.sol
- Res... | 2 | true | File : /contracts/core/IRdpxV2Core.sol
//@audit this is defined inside IRdpxV2Core
struct ReserveAsset {
address tokenAddress;
uint256 tokenBalance;
- string tokenSymbol;
}
File: /contracts/core/RdpxV2Core.sol
- ReserveAsset[] public reserveAsset;
- s... | IRdpxV2Core.sol#L43-L2, RdpxV2Core.sol#L61-L1 | RdpxV2Core.sol, IRdpxV2Core.sol | 2 | false | https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/RdpxV2Core.sol#L61C1-L73C51
It will simplify the accessing of reserve assets. Because contract is using symbol as the key to search asset, so it can also be done with it. By this change same goal can be achieved with many advantages. eg: Lesser state... | true | false | 9 | |||
c4 | 02-ethos | GalloDaSballo Q | Critical | critical | # Executive Summary
The following QA Report is an aggregate of smaller reports divided by contract / topic
The following criteria are used for suggested severity
L - Low Severity -> Some risk
R - Refactoring -> Suggested changes for improvements
NC - Non-Critical / Informational -> Minor suggestions
# List of al... | uint256 public withdrawMaxLoss = 1;
| function _atLeastRole(bytes32 _role) internal view {
bytes32[] memory cascadingAccessRoles = _cascadingAccessRoles();
uint256 numRoles = cascadingAccessRoles.length;
bool specifiedRoleFound = false;
bool senderHighestRoleFound = false;
// {_role} must be found in the {cascad... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/GalloDaSballo-Q.md | 2026-01-02T18:16:12.532910+00:00 | 002a99aeb152e11d44f40ea0c3c5e6e74773e719f238e173ee0854806632159f | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | uint256 public withdrawMaxLoss = 1;
| true | function _atLeastRole(bytes32 _role) internal view {
bytes32[] memory cascadingAccessRoles = _cascadingAccessRoles();
uint256 numRoles = cascadingAccessRoles.length;
bool specifiedRoleFound = false;
bool senderHighestRoleFound = false;
// {_role} must be found in the {cascad... | true | true | 5 | ||||||||
c4 | 02-ethos | 0x007 G | Gas | gas | ## Reduce the size of error messages (Long revert Strings)
Shortening revert strings to fit in 32 bytes will decrease deployment time gas and will decrease runtime gas when the revert condition is met.
Cases can be found in `find . -name "*.sol" |xargs grep -n -E 'require.*".{36,}"'`
## Use multiple require statement ... | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | oracle | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/0x007-G.md | 2026-01-02T18:15:40.626529+00:00 | 002c6021d44956e92a1ee9701025b0c43934dbe330de2bc133c22655752648b8 | 1 | 1 | 284 | 1 | false | true | true | false | medium | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | sol | 284 | // Code block 1 (sol):
struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | 1 | false | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | PriceFeed.sol#L58-L71 | PriceFeed.sol | 1 | struct ChainlinkResponse {
uint80 roundId;
uint8 decimals;
bool success;
int256 answer;
uint256 timestamp;
}
struct TellorResponse {
bool ifRetrieve;
bool success;
uint256 value;
uint256 timestamp;
} | true | false | false | 4.94 | ||||
c4 | 01-salty | K42 G | High | high | ## Gas Optimization Report for [Salty.IO](https://github.com/code-423n4/2024-01-salty) by K42
- Note: I made sure these optimizations are unique in relation to the Bot Report and 4Analy3er Report.
### Possible Optimizations in [ArbitrageSearch.sol](https://github.com/code-423n4/2024-01-salty/blob/main/src/arbitrage/... | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | function _rightMoreProfitable(...) internal pure returns (bool) {
// ... [existing calculations]
return int256(amountOutRight) - int256(midpoint + MIDPOINT_PRECISION) > profitMidpoint;
} | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/K42-G.md | 2026-01-02T19:01:22.378584+00:00 | 00346fb83aaeb3174399c40495e624cd688420afa7d08a9e673b95f875fcea88 | 2 | 2 | 519 | 4 | false | false | true | false | high | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | solidity | 325 | // Code block 1 (solidity):
function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct ref... | 2 | false | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | ArbitrageSearch.sol, ArbitrageSearch.sol#L31-L1, ArbitrageSearch.sol#L63-L2, ArbitrageSearch.sol#L101-L2 | ArbitrageSearch.sol | 4 | function _arbitragePath(IERC20 swapTokenIn, IERC20 swapTokenOut) internal view returns (IERC20 arbToken2, IERC20 arbToken3) {
if (address(swapTokenIn) == address(wbtc) && address(swapTokenOut) == address(weth)) {
return (wbtc, salt);
}
// Other conditions using direct references to wbtc, weth, and s... | true | function _rightMoreProfitable(...) internal pure returns (bool) {
// ... [existing calculations]
return int256(amountOutRight) - int256(midpoint + MIDPOINT_PRECISION) > profitMidpoint;
} | true | true | 8 | ||
c4 | 08-dopex | Kaysoft Q | Low | low | ## [NC-01] `approveContractToSpend` will return wrong error message when `_amount` does not pass the validation check.
File: https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/core/RdpxV2Core.sol#L410
- Wrong error code was supplied to the third validation in this code.... | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
IERC20WithBurn(_token).ap... | // ERROR CODES
// E1: "Insufficient bond amount",
// E2: "Bond has expired",
// E3: "Invalid parameters",
// E4: "Invalid amount",
// E5: "Not enough ETH available from the delegate",
// E6: "Invalid bond ID",
// E7: "Bond has not matured",
// E8: "Fee cannot be more than 100",
// E9: "msg.sender is not the owner",
// ... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Kaysoft-Q.md | 2026-01-02T18:24:46.584559+00:00 | 0049135df58dc2121ea1a2df2ec7847962a83d93a58acc16f84ff81d6ce062bd | 3 | 0 | 1,420 | 1 | false | false | true | false | high | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
IERC20WithBurn(_token).ap... | unknown | 349 | // Code block 1 (unknown):
function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
... | 3 | false | RdpxV2Core.sol#L410 | RdpxV2Core.sol | 1 | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
_validate(_token != address(0), 17);
_validate(_spender != address(0), 17);
@> _validate(_amount > 0, 17);//@audit-info 17 error code wrong.
IERC20WithBurn(_token).ap... | true | // ERROR CODES
// E1: "Insufficient bond amount",
// E2: "Bond has expired",
// E3: "Invalid parameters",
// E4: "Invalid amount",
// E5: "Not enough ETH available from the delegate",
// E6: "Invalid bond ID",
// E7: "Bond has not matured",
// E8: "Fee cannot be more than 100",
// E9: "msg.sender is not the owner",
// ... | true | true | 9 | |||
c4 | 07-amphora | wahedtalash77 G | High | high | ## [G-01] For uint use != 0 instead of > 0
558: `if (_fee > 0) usda.vaultControllerMint(owner(), _fee);`
https://github.com/code-423n4/2023-07-amphora/blob/main/core/solidity/contracts/core/VaultController.sol#L558
660: ` if (_tokenAmount > 0) _tokensToLiquidate = _tokenAmount;`
https://github.com/code-423n4/2023-07-a... | 223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | //f(x) is a low gas cost operation
//g(y) is a high gas cost operation
//Sort operations with different gas costs as follows
f(x) || g(y)
f(x) && g(y) | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/wahedtalash77-G.md | 2026-01-02T18:24:04.914642+00:00 | 006cd7fee2876c8d4033f26b53b5f916cced62539a55a075b58ffd5fad89330e | 1 | 0 | 149 | 6 | false | false | true | false | high | 223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | unknown | 149 | // Code block 1 (unknown):
223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | 1 | false | VaultController.sol#L558, VaultController.sol#L660, Vault.sol#L206, Vault.sol#L223-L6, GovernorCharlie.sol#L259, GovernorCharlie.sol#L382 | GovernorCharlie.sol, VaultController.sol, Vault.sol | 6 | 223: if (_totalCvxReward > 0) CVX.transfer(_msgSender(), _totalCvxReward);
224: if (_totalCrvReward > 0) CRV.transfer(_msgSender(), _totalCrvReward); | true | //f(x) is a low gas cost operation
//g(y) is a high gas cost operation
//Sort operations with different gas costs as follows
f(x) || g(y)
f(x) && g(y) | true | true | 7 | |||
c4 | 03-asymmetry | DadeKuma Q | Critical | critical |
## Summary
---
### Low Risk Findings
|Id|Title|Instances|
|:--:|:-------|:--:|
|[L-01]| No limits to max slippage | 1 |
|[L-02]| Missing safe limits in `setMinAmount` and `setMaxAmount` | 1 |
|[L-03]| Owner can renounce ownership | 17 |
|[L-04]| Lack of two-step Ownership | 4 |
Total: 23 instances over 4 issues.
#... | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | File: contracts/SafEth/SafEth.sol
214: function setMinAmount(uint256 _minAmount) external onlyOwner {
215: minAmount = _minAmount;
216: emit ChangeMinAmount(minAmount);
217: }
223: function setMaxAmount(uint256 _maxAmount) external onlyOwner {
224: maxAmount = _maxAmount... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/DadeKuma-Q.md | 2026-01-02T18:17:59.767058+00:00 | 00acaef05b698847bfefa32055c8cba710d00377fa0c07ff7d9c5d14fe28d1ba | 2 | 2 | 704 | 0 | false | false | true | false | high | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | solidity | 322 | // Code block 1 (solidity):
File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeI... | 2 | false | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | 0 | File: contracts/SafEth/SafEth.sol
202: function setMaxSlippage(
203: uint _derivativeIndex,
204: uint _slippage
205: ) external onlyOwner {
206: derivatives[_derivativeIndex].setMaxSlippage(_slippage);
207: emit SetMaxSlippage(_derivativeIndex, _slippage);
208: ... | true | File: contracts/SafEth/SafEth.sol
214: function setMinAmount(uint256 _minAmount) external onlyOwner {
215: minAmount = _minAmount;
216: emit ChangeMinAmount(minAmount);
217: }
223: function setMaxAmount(uint256 _maxAmount) external onlyOwner {
224: maxAmount = _maxAmount... | true | true | 7 | ||||
c4 | 09-ondo | catwhiskeys Q | Unknown | unknown | # 1) Function with wrong functionality
The `_mul` function wasn't coded well. It should return multiplication of 2 numbers, but the function might return nothing.
Instance:
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/rwaOracles/RWADynamicOracle.sol#L405
PoC
For example, x=1, y=2. In this case, func... | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
} | - function pauseOracle() external onlyRole(PAUSER_ROLE) {
+ function pauseOracle() external onlyRole(DEFAULT_ADMIN_ROLE) {
_pause();
} | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/catwhiskeys-Q.md | 2026-01-02T18:25:52.035771+00:00 | 00b28b7de051f0271d24e95a420e719e0534b51a71c304fa4d5e7ec782cefb08 | 2 | 0 | 245 | 2 | false | false | true | false | high | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
} | unknown | 107 | // Code block 1 (unknown):
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
}
// Code block 2 (unknown):
- function pauseOracle() external onlyRole(PAUSER_ROLE) {
+ function pauseOracle() external onlyRole(DEFAULT_ADMIN_ROLE) {
_pause();
} | 2 | false | RWADynamicOracle.sol#L405, RWADynamicOracle.sol#L241 | RWADynamicOracle.sol | 2 | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
if (y != 0) {
return z = x * y;
} | true | - function pauseOracle() external onlyRole(PAUSER_ROLE) {
+ function pauseOracle() external onlyRole(DEFAULT_ADMIN_ROLE) {
_pause();
} | true | true | 7.65 | |||
c4 | 01-biconomy | W0RR1O G | Medium | medium | Use ++i instead of i++ to save gas
===============
this gas optimization can be done in the following lines:
`https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/aa-4337/core/EntryPoint.sol#L74`
`https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/... | pragma solidity ^0.8.12;
//Not optimized contract
contract TestA{
uint private num;
function testA() public{
num += 1;
}
}
//Optimized contract
contract TestB{
uint private num;
function testB() public{
num = num + 1;
}
} | contract TestA = 50027gas
contract TestB = 50012gas | upgrade | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/W0RR1O-G.md | 2026-01-02T18:13:26.530549+00:00 | 00e2fa3e965f168636430d93059c3f91fd8d428192c2a5fef9874ca7ae813b67 | 0 | 0 | 0 | 8 | false | false | false | false | medium | 0 | 0 | false | EntryPoint.sol#L74, EntryPoint.sol#L80, EntryPoint.sol#L99, EntryPoint.sol#L112, EntryPoint.sol#L128, EntryPoint.sol#L134, Executor.sol#L28, Proxy.sol#L16 | Executor.sol, Proxy.sol, EntryPoint.sol | 8 | pragma solidity ^0.8.12;
//Not optimized contract
contract TestA{
uint private num;
function testA() public{
num += 1;
}
}
//Optimized contract
contract TestB{
uint private num;
function testB() public{
num = num + 1;
}
} | true | contract TestA = 50027gas
contract TestB = 50012gas | true | true | 6 | ||||||
c4 | 11-kelp | 0xhex G | Low | low | # Gas-Optimization
## [G-01] Use do while loops instead of for loops
```solidity
File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) {
```
https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTOracle.sol#L66
```solidity
File: src/LRTDepositPool.sol
82 for (uint... | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) { | File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) { | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/0xhex-G.md | 2026-01-02T18:27:15.511639+00:00 | 01246ab8601ca24ef3d737df26bc1883dede0e8c82fe48c4677f6faed634a8ab | 9 | 9 | 882 | 8 | false | false | true | false | high | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) { | solidity | 93 | // Code block 1 (solidity):
File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) {
// Code block 2 (solidity):
File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) {
// Code block 3 (solidity):
File: src/NodeDelegator... | 9 | false | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) {
File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) {
File: src/NodeDelegator.sol
109 for (uint256 i = 0; i < strategiesLength;) {
File: src/LRTDepositP... | LRTOracle.sol#L66, LRTDepositPool.sol#L82, NodeDelegator.sol#L109, LRTDepositPool.sol#L22, LRTConfig.sol#L19, RSETH.sol#L21, LRTDepositPool.sol#L20, LRTConfigRoleChecker.sol#L14 | LRTConfigRoleChecker.sol, LRTOracle.sol, RSETH.sol, NodeDelegator.sol, LRTConfig.sol, LRTDepositPool.sol | 8 | File: src/LRTOracle.sol
66 for (uint16 asset_idx; asset_idx < supportedAssetCount;) { | true | File: src/LRTDepositPool.sol
82 for (uint256 i; i < ndcsCount;) {
168 for (uint256 i; i < length;) { | true | true | 15 | ||
c4 | 11-kelp | spark Q | Low | low | # 1. Potential Data Inconsistency between `tokenMap` and `isSupportedAsset`
In contract `LRTConfig`, the token info is split into two storage:
- ``tokenMap``
- `isSupportedAsset`.
And each storage will be updated by the different role:
- ``tokenMap`` -> admin
- `isSupportedAsset` -> manager
As a result, there ... | rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/spark-Q.md | 2026-01-02T18:28:28.630091+00:00 | 015cb04f97aad19d479bce89363eee5ac2f3b01a2563218ebb72a04e95c768cf | 1 | 0 | 90 | 0 | false | true | true | false | medium | rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | unknown | 90 | // Code block 1 (unknown):
rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | 1 | false | 0 | rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice(); | true | false | false | 3.85 | |||||||
c4 | 11-kelp | phoenixV110 Q | Low | low | # [L-01] Modifier `onlySupportedAsset()` is missing in `getAssetBalance()`
https://github.com/code-423n4/2023-11-kelp/blob/main/src/NodeDelegator.sol#L121-L124
## Description
The method `getAssetBalance()` doesn't check if the asset is a supportedAsset or not. Which can revert or will return wrong values if **assetSt... | - function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strategy).userUnderlyingView(add... | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | oracle | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/phoenixV110-Q.md | 2026-01-02T18:28:22.844057+00:00 | 01693b230f9534497016992ffe1c5fe8df0a5d38ccd5cd325aa16a02cf109112 | 2 | 0 | 516 | 3 | false | false | true | false | high | - function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strategy).userUnderlyingView(add... | unknown | 339 | // Code block 1 (unknown):
- function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strat... | 2 | false | NodeDelegator.sol#L121-L124, LRTOracle.sol#L45-L47, LRTDepositPool.sol#L151-L157 | NodeDelegator.sol, LRTDepositPool.sol, LRTOracle.sol | 3 | - function getAssetBalance(address asset) external view override returns (uint256) {
+ function getAssetBalance(address asset) external view override onlySupportedAsset(asset) returns (uint256) {
address strategy = lrtConfig.assetStrategy(asset);
return IStrategy(strategy).userUnderlyingView(add... | true | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | true | true | 8 | |||
c4 | 05-ajna | codeslide Q | Critical | critical | ### Low Risk Issues List
| Number | Issue | Instances |
| :----: | :---------------------- | :-------: |
| [L-01] | Unsafe casting of uints | 7 |
#### [L-01] Unsafe casting of uints
Downcasting from uint256 in Solidity does not revert on overflow. This can result in undesired exploitation o... | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | // Yes
x = 1;
y = 2;
longVariable = 3;
// No
x = 1;
y = 2;
longVariable = 3; | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/codeslide-Q.md | 2026-01-02T18:21:24.387068+00:00 | 01cb0f4b0d1ac42068ff43574adf0b1def5662dcd738b80578731d16d012323d | 1 | 1 | 762 | 0 | false | false | true | false | high | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | solidity | 762 | // Code block 1 (solidity):
File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch)... | 1 | false | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | 0 | File: ajna-core/src/RewardsManager.sol
179: toBucket.lpsAtStakeTime = uint128(positionManager.getLP(tokenId_, toIndex));
180: toBucket.rateAtStakeTime = uint128(IPool(ajnaPool).bucketExchangeRate(toIndex));
222: stakeInfo.stakingEpoch = uint96(curBurnEpoch);
225: stakeInfo.la... | true | // Yes
x = 1;
y = 2;
longVariable = 3;
// No
x = 1;
y = 2;
longVariable = 3; | true | true | 6 | ||||
c4 | 08-dopex | Aymen0909 Q | Critical | critical | # QA Report
## Summary
| | Issue | Risk | Instances |
| :-------------: |:-------------|:-------------:|:-------------:|
| 1 | Potential underflow in `RdpxV2Core.calculateBondCost` will cause DOS of bond operations | Low | 1 |
| 2 | Missing `sync()` after transferring funds to `RdpxV2Cor... | rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | function calculateBondCost(
uint256 _amount,
uint256 _rdpxBondId
) public view returns (uint256 rdpxRequired, uint256 wethRequired) {
uint256 rdpxPrice = getRdpxPrice();
if (_rdpxBondId == 0) {
uint256 bondDiscount = (bondDiscountFactor *
Math.sqrt(IRdpxReserve(addresses.rdpxReserve)... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Aymen0909-Q.md | 2026-01-02T18:24:30.378248+00:00 | 01d558201cd0629413c725a041a2c7d44ec8d438bb433d14328dc9fb1f274fe3 | 1 | 0 | 156 | 0 | false | false | true | false | high | rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | unknown | 156 | // Code block 1 (unknown):
rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | 1 | false | 0 | rdpxRequired =
((RDPX_RATIO_PERCENTAGE - (bondDiscount / 2)) *
_amount *
DEFAULT_PRECISION) /
(DEFAULT_PRECISION * rdpxPrice * 1e2); | true | function calculateBondCost(
uint256 _amount,
uint256 _rdpxBondId
) public view returns (uint256 rdpxRequired, uint256 wethRequired) {
uint256 rdpxPrice = getRdpxPrice();
if (_rdpxBondId == 0) {
uint256 bondDiscount = (bondDiscountFactor *
Math.sqrt(IRdpxReserve(addresses.rdpxReserve)... | true | true | 6 | |||||
c4 | 05-ajna | rbserver Q | Critical | critical | ## QA REPORT
| |Issue|
|-|:-|
| [01] | `CHALLENGE_PERIOD_LENGTH`, `DISTRIBUTION_PERIOD_LENGTH`, `FUNDING_PERIOD_LENGTH`, AND `MAX_EFM_PROPOSAL_LENGTH` ARE HARDCODED BASED ON 7200 BLOCKS PER DAY |
| [02] | AMBIGUITY IN `StandardFunding._standardProposalState` FUNCTION |
| [03] | `ExtraordinaryFundingProposal.votesRecei... | /**
* @notice Length of the challengephase of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 7 days.
* @dev The period in which funded proposal slates can be checked in updateSlate.
*/
uint256 internal constant CHALLENGE_PERIOD_LENGTH = 50400; | /**
* @notice Length of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 90 days.
*/
uint48 internal constant DISTRIBUTION_PERIOD_LENGTH = 648000; | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/rbserver-Q.md | 2026-01-02T18:21:44.964488+00:00 | 020204fc263ca1de1aa20e69d328e7ab101bcfe68411350f6cfb4d47def4bc67 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | /**
* @notice Length of the challengephase of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 7 days.
* @dev The period in which funded proposal slates can be checked in updateSlate.
*/
uint256 internal constant CHALLENGE_PERIOD_LENGTH = 50400; | true | /**
* @notice Length of the distribution period in blocks.
* @dev Roughly equivalent to the number of blocks in 90 days.
*/
uint48 internal constant DISTRIBUTION_PERIOD_LENGTH = 648000; | true | true | 5 | ||||||||
c4 | 02-ethos | LethL Q | Critical | critical | ## Low Issues
| | Issue | Instances |
|---|---|---|
| Low-1 | Lack of checks-effects-interactions | 1 |
| Low-2 | Loss of precision due to rounding | 1 |
| Low-3 | Outdated Compiler Version | 8 |
### [Low-1] Lack of checks-effects-interactions
External calls should be executed after state changes to avoid reetrancy b... | File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance")); | File: Ethos-Vault/contracts/ReaperVaultV2.sol
463: uint256 performanceFee = (gain * strategies[strategy].feeBPS) / PERCENT_DIVISOR; | slippage | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/LethL-Q.md | 2026-01-02T18:16:19.793349+00:00 | 021c777991438066d83b490bb5fabcffbd39ff2bc4af35d9810759440aa9c8be | 2 | 0 | 361 | 7 | false | false | true | false | high | File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance")); | unknown | 222 | // Code block 1 (unknown):
File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance"));
// Code block 2 (unknown):
File: Ethos-Vault/contracts/ReaperVaultV2.... | 2 | false | LUSDToken.sol#L237-L238, ReaperVaultV2.sol#L463, CollateralConfig.sol#L3, BorrowerOperations.sol#L3, TroveManager.sol#L3, ActivePool.sol#L3, StabilityPool.sol#L3 | StabilityPool.sol, TroveManager.sol, BorrowerOperations.sol, ReaperVaultV2.sol, LUSDToken.sol, ActivePool.sol, CollateralConfig.sol | 7 | File: Ethos-Core/contracts/LUSDToken.sol
237: _transfer(sender, recipient, amount);
238: _approve(sender, msg.sender, _allowances[sender][msg.sender].sub(amount, "ERC20: transfer amount exceeds allowance")); | true | File: Ethos-Vault/contracts/ReaperVaultV2.sol
463: uint256 performanceFee = (gain * strategies[strategy].feeBPS) / PERCENT_DIVISOR; | true | true | 8 | |||
c4 | 09-ondo | zigtur Q | Unknown | unknown | # Unused code should be deleted and not commented out
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/bridge/MintRateLimiter.sol#L56-L64
MintRateLimiter.sol constructor has some commented out code.
This code should be deleted if not used in production. Here is the fixed constructor:
```solidity
cons... | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | other | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/zigtur-Q.md | 2026-01-02T18:26:23.876288+00:00 | 0270e83c30f0531078084990070eded176ed8c6bcfdcf3aa3fcc9b94f36b85a6 | 1 | 1 | 262 | 3 | false | true | true | false | medium | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | solidity | 262 | // Code block 1 (solidity):
constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | 1 | false | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | MintRateLimiter.sol#L56-L64, rUSDY.sol#L586-L592, rUSDY.sol#L172-L177 | rUSDY.sol, MintRateLimiter.sol | 3 | constructor(uint256 _mintResetDuration, uint256 _instantMintLimit) {
resetMintDuration = _mintResetDuration; // can be zero for per-block limit
mintLimit = _instantMintLimit; // can be zero to disable minting
lastResetMintTime = block.timestamp;
} | true | false | false | 6 | ||||
c4 | 03-revert-lend | slvDev G | High | high | ## Gas Findings
| | Issue | Instances | Total Gas Saved |
|----|-------|:---------:|:---------:|
| [G-01] | Optimize Storage Layout in Structs | 5 | 100000 |
| [G-02] | Optimize Storage with Byte Truncation for Time Related State Variables | 1 | 20000 |
| [G-03] | Contract storage can use fewer slots by changing th... | File: src/V3Oracle.sol
/// @audit - Struct used 6 storage slots, but can be packed to 4 storage slots.
// struct TokenConfig {
// Mode mode;
// IUniswapV3Pool pool;
// AggregatorV3Interface feed;
// uint32 twapSeconds;
// uint32 maxFeedAge;
// uint16 maxDifference;
// uint8 tokenDecimals;
/... | File: src/automators/AutoExit.sol
/// @audit - Struct used 7 storage slots, but can be packed to 6 storage slots.
// struct ExecuteParams {
// uint256 deadline;
// uint256 amountRemoveMin1;
// uint256 amountRemoveMin0;
// bytes swapData;
// uint256 tokenId;
// uint128 liquidity;
// uint64 r... | reentrancy | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/slvDev-G.md | 2026-01-02T19:03:17.736684+00:00 | 027a908a2f124e1fe4e34524ccf0ad4c179f7b7685261d2de053edcd8bce6464 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: src/V3Oracle.sol
/// @audit - Struct used 6 storage slots, but can be packed to 4 storage slots.
// struct TokenConfig {
// Mode mode;
// IUniswapV3Pool pool;
// AggregatorV3Interface feed;
// uint32 twapSeconds;
// uint32 maxFeedAge;
// uint16 maxDifference;
// uint8 tokenDecimals;
/... | true | File: src/automators/AutoExit.sol
/// @audit - Struct used 7 storage slots, but can be packed to 6 storage slots.
// struct ExecuteParams {
// uint256 deadline;
// uint256 amountRemoveMin1;
// uint256 amountRemoveMin0;
// bytes swapData;
// uint256 tokenId;
// uint128 liquidity;
// uint64 r... | true | true | 5 | ||||||||
c4 | 06-lybra | DavidGiladi G | High | high | # Report: Identified 12 Distinct Gas Optimization Opportunities
- [Multiplication and Division by 2 Should use in Bit Shifting](#multiplication-and-division-by-2-should-use-in-bit-shifting) (2 results) (Gas Optimization)
- [Modulus operations that could be unchecked](#modulus-operations-that-could-be-unchecked) (1 r... | Line: 17 abstract contract LybraEUSDVaultBase | Line: 159 require(assetAmount * 2 <= depositedAsset[onBehalfOf], "a max of 50% collateral can be liquidated");
| access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/DavidGiladi-G.md | 2026-01-02T18:22:16.401600+00:00 | 02ef14b7b45ee43de23aa9b2270b2853f3c798647a91c4881b5c0c4580009294 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | Line: 17 abstract contract LybraEUSDVaultBase | true | Line: 159 require(assetAmount * 2 <= depositedAsset[onBehalfOf], "a max of 50% collateral can be liquidated");
| true | true | 5 | ||||||||
c4 | 06-lybra | Chandr Q | Low | low | L[1]: The depositEtherToMint function does not follow a standard pattern for total balance calculation
code: https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/pools/LybraWstETHVault.sol#L29-L46
```
function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.... | function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(collateralAsset), msg.value... | other | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/Chandr-Q.md | 2026-01-02T18:22:13.462518+00:00 | 0355aa725ebd413a5c86e3d07d1177a14365bf9cb00b4440b2adc15243918017 | 1 | 0 | 685 | 1 | false | true | true | false | medium | function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(collateralAsset), msg.value);
... | unknown | 685 | // Code block 1 (unknown):
function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(coll... | 1 | false | LybraWstETHVault.sol#L29-L46 | LybraWstETHVault.sol | 1 | function depositEtherToMint(uint256 mintAmount) external payable override {
require(msg.value >= 1 ether, "DNL");
uint256 sharesAmount = lido.submit{value: msg.value}(address(configurator));
require(sharesAmount > 0, "ZERO_DEPOSIT");
lido.approve(address(collateralAsset), msg.value... | true | false | false | 5.05 | |||||
c4 | 08-dopex | Strausses Q | Medium | medium | L1 - Create an error when the first value is bigger than the second one.
Add this piece of code.
```
_validate(delegate.amount - delegate.activeCollateral, 15);
```
Otherwise tx could just revert without any error message
https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contrac... | _validate(delegate.amount - delegate.activeCollateral, 15); | validation | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Strausses-Q.md | 2026-01-02T18:25:07.210115+00:00 | 03c0ab52a3d681ac089f909d6999b79e07cb9e24745252fde2d9d0d996b785ba | 1 | 0 | 59 | 8 | false | true | true | false | medium | _validate(delegate.amount - delegate.activeCollateral, 15); | unknown | 59 | // Code block 1 (unknown):
_validate(delegate.amount - delegate.activeCollateral, 15); | 1 | false | RdpxV2Core.sol#L983, PerpetualAtlanticVaultLP.sol#L120-L13, RdpxV2Core.sol#L1018, PerpetualAtlanticVaultLP.sol#L286, PerpetualAtlanticVaultLP.sol#L156, UniV2LiquidityAmo.sol#L74-L102, RdpxV2Core.sol#L305, ReLPContract.sol#L115 | ReLPContract.sol, RdpxV2Core.sol, UniV2LiquidityAmo.sol, PerpetualAtlanticVaultLP.sol | 8 | _validate(delegate.amount - delegate.activeCollateral, 15); | true | false | false | 6 | |||||
c4 | 01-biconomy | __141345__ G | Low | low | #### Update value order can be adjusted to simplify the code and save gas
For example, to update the `val` variable with `newVal`, the current way is as following:
```solidity
uint oldVal = val;
val = newVal;
emit update(oldVal, newVal);
```
If the execution order is adjusted, some operations can be save... | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal); | emit update(val, newVal);
val = newVal; | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/__141345__-G.md | 2026-01-02T18:13:27.901398+00:00 | 03d0c89b090e0b5cfab4c3d8140366fb923e48ca5357fe87a0c957906db3c35e | 3 | 2 | 140 | 1 | false | false | true | false | high | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal); | solidity | 69 | // Code block 1 (solidity):
uint oldVal = val;
val = newVal;
emit update(oldVal, newVal);
// Code block 2 (solidity):
emit update(val, newVal);
val = newVal;
// Code block 3 (unknown):
The above can be changed to: | 3 | false | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal);
emit update(val, newVal);
val = newVal; | oldnew.sol | oldnew.sol | 1 | uint oldVal = val;
val = newVal;
emit update(oldVal, newVal); | true | emit update(val, newVal);
val = newVal; | true | true | 9 | ||
c4 | 11-kelp | bronze_pickaxe Q | Low | low | # 1. maxNodeDelegatorCount does not get enforced
### Impact
There are a few problems with the usage of `maxNodeDelegatorCount` in `LRTDepositPool.sol`.
First problem, consider the following:
- `maxNodeDelegatorCount = 10`
- 10 `NodeDelegators` have been added using `LRTDepositPool.addNodeDelegatorContractToQueue`
- ... | uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecked {
++i; | address nodeDelegator = nodeDelegatorQueue[ndcIndex];
if (!IERC20(asset).transfer(nodeDelegator, amount)) {
revert TokenTransferFailed(); | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/bronze_pickaxe-Q.md | 2026-01-02T18:27:51.537433+00:00 | 04218453c20e98518e966220c7707a07e11c32fb8bde5ad5ee5167ec665d3a3d | 2 | 0 | 471 | 2 | false | false | true | false | high | uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecked {
++i; | javascript | 314 | // Code block 1 (javascript):
uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecke... | 2 | false | LRTDepositPool.sol#L81-L86, LRTDepositPool.sol#L193-L195 | LRTDepositPool.sol | 2 | uint256 ndcsCount = nodeDelegatorQueue.length;
for (uint256 i; i < ndcsCount;) {
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);
unchecked {
++i; | true | address nodeDelegator = nodeDelegatorQueue[ndcIndex];
if (!IERC20(asset).transfer(nodeDelegator, amount)) {
revert TokenTransferFailed(); | true | true | 8 | |||
c4 | 11-kelp | 0xAnah G | High | high | # KELP PROTOCOL GAS OPTIMISATIONS
## INTRODUCTION
Some of optimizations underwent benchmarking using the protocol's tests, specifically employing the following configuration: `solc version 0.8.21`, `optimizer enabled,` and `10_000` runs. For optimizations that were not subjected to benchmarking, their rationale is e... | file: src/LRTConfig.sol
15: mapping(address token => bool isSupported) public isSupportedAsset;
16: mapping(address token => uint256 amount) public depositLimitByAsset;
17: mapping(address token => address strategy) public override assetStrategy; | ```
Estimated gas saved: 60k gas units | reentrancy | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/0xAnah-G.md | 2026-01-02T18:27:09.596200+00:00 | 04b1ed0bfae3c1e7aa408e28fce8fda7d5ef82c70111f199da3723a1137375fb | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | LRTConfig.sol#L15 | LRTConfig.sol | 1 | file: src/LRTConfig.sol
15: mapping(address token => bool isSupported) public isSupportedAsset;
16: mapping(address token => uint256 amount) public depositLimitByAsset;
17: mapping(address token => address strategy) public override assetStrategy; | true | ```
Estimated gas saved: 60k gas units | true | true | 6 | ||||||
c4 | 02-ai-arena | Timenov G | Medium | medium | # AI Arena Gas report by Timenov
## Summary
| |Issue|Instances|
|-|:-|:-:|
| G-01 | Array's cached length not used optimally. | 8 |
| G-02 | Smaller uint can be used. | 1 |
| G-03 | State variable can be removed. | 1 |
| G-04 | State variable can be updated after loop. | 2 |
| G-05 | Unnecessary validation. | 1 |
| ... | https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L70-L72
| https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L96-L98
| access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/Timenov-G.md | 2026-01-02T19:02:47.423442+00:00 | 04f1027f67bac208e2ecce3eb1245ec5cbcc84723dfaf63987dc382c648a3858 | 2 | 2 | 788 | 2 | true | true | true | false | medium | function addAttributeDivisor(uint8[] memory attributeDivisors) external {
require(msg.sender == _ownerAddress);
+ uint256 attributesLength = attributes.length;
- require(attributeDivisors.length == attributes.length);
+ require(attributeDivisors.length == attributesLength);
- uint256 at... | diff | 499 | // Code block 1 (diff):
function addAttributeDivisor(uint8[] memory attributeDivisors) external {
require(msg.sender == _ownerAddress);
+ uint256 attributesLength = attributes.length;
- require(attributeDivisors.length == attributes.length);
+ require(attributeDivisors.length == attributesLeng... | 2 | true | function addAttributeDivisor(uint8[] memory attributeDivisors) external {
require(msg.sender == _ownerAddress);
+ uint256 attributesLength = attributes.length;
- require(attributeDivisors.length == attributes.length);
+ require(attributeDivisors.length == attributesLength);
- uint256 at... | AiArenaHelper.sol#L70-L72, AiArenaHelper.sol#L96-L98 | AiArenaHelper.sol | 2 | false | false | false | 8 | ||||
c4 | 03-asymmetry | PNS Q | Critical | critical | [L-1] Missing event for critical parameter change
===
```solidity
File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: }
```
Similarly in `SfrxEth.sol` and `WstEth.sol`
This method can be called directly on a der... | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: } | emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage); | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/PNS-Q.md | 2026-01-02T18:18:24.291683+00:00 | 05208d00e93b305b181822698aa3511647ff00485a4ee4dff3a7aa62c08f7ee7 | 8 | 8 | 968 | 0 | false | false | true | false | high | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: } | solidity | 162 | // Code block 1 (solidity):
File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: }
// Code block 2 (solidity):
emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage);
// Code block 3 (solidity):
File: contracts/Sa... | 8 | false | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: }
emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage);
File: contracts/SafEth/SafEth.sol
165: function adjustWeight(
166: uint256 _derivativeInde... | 0 | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
59: maxSlippage = _slippage;
60: } | true | emit SetMaxSlippage(oldMaxSlippage, newMaxSlippage); | true | true | 13 | ||||
c4 | 08-dopex | QiuhaoLi G | Gas | gas | ## We can use a put option for all delegate bonds instead of one for every option
In `bondWithDelegate` we can delecate more than once, and for every delegate we buy the option for the bond. Since all the bonds are in the same transaction, the strike price will be the same. To save gas, we can buy a single option outs... | collateralToken.safeTransfer(
addresses.perpetualAtlanticVaultLP,
(currentFundingRate * (nextFundingPaymentTimestamp() - startTime)) / // @audit-issue GAS this can be calculated only once
1e18
);
IPerpetualAtlanticVaultLP(addresses.perpetualAtlanticVaultLP)
... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/QiuhaoLi-G.md | 2026-01-02T18:24:56.450269+00:00 | 05796cce808c7135ccbb4d85d05792d96e65bf60b9cd801ff52ea9b5392861bc | 0 | 0 | 0 | 0 | false | true | false | false | medium | 0 | 0 | false | 0 | collateralToken.safeTransfer(
addresses.perpetualAtlanticVaultLP,
(currentFundingRate * (nextFundingPaymentTimestamp() - startTime)) / // @audit-issue GAS this can be calculated only once
1e18
);
IPerpetualAtlanticVaultLP(addresses.perpetualAtlanticVaultLP)
... | true | false | false | 4 | ||||||||||
c4 | 03-asymmetry | a3yip6 Q | Low | low | ## [L-01] Revert may happen if owner invoke `rebalanceToWeights` with too many tokens in derivatives
The function `rebalanceToWeights` is used by the owner to rebalence the weights of derivatives. The function would withdraw and deposit to each derivatives, which will exchange tokens with `maxSlippage`. Thus, the huge ... | File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
uint256 ethAmountAfter ... | File: /contracts/WstEth.sol
function withdraw(uint256 _amount) external onlyOwner {
// burn WStETH and withdraw stETH
IWStETH(WST_ETH).unwrap(_amount);
uint256 stEthBal = IERC20(STETH_TOKEN).balanceOf(address(this));
IERC20(STETH_TOKEN).approve(LIDO_CRV_POOL, stEthBal);
uint256 minOut = (stEthBal *... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/a3yip6-Q.md | 2026-01-02T18:18:42.301344+00:00 | 0586eb934222f280e09747dc3235562f5febbb6bc3a469e1135d7ea3fc36f3ad | 2 | 0 | 1,376 | 0 | false | false | true | false | high | File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
uint256 ethAmountAfter ... | unknown | 750 | // Code block 1 (unknown):
File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
... | 2 | false | 0 | File: /contracts/SafEth.sol
function rebalanceToWeights() external onlyOwner {
uint256 ethAmountBefore = address(this).balance;
for (uint i = 0; i < derivativeCount; i++) {
if (derivatives[i].balance() > 0)
derivatives[i].withdraw(derivatives[i].balance());
}
uint256 ethAmountAfter ... | true | File: /contracts/WstEth.sol
function withdraw(uint256 _amount) external onlyOwner {
// burn WStETH and withdraw stETH
IWStETH(WST_ETH).unwrap(_amount);
uint256 stEthBal = IERC20(STETH_TOKEN).balanceOf(address(this));
IERC20(STETH_TOKEN).approve(LIDO_CRV_POOL, stEthBal);
uint256 minOut = (stEthBal *... | true | true | 7 | |||||
c4 | 03-asymmetry | favelanky Q | Low | low | ## [L-1] Floating pragma
There are 5 instance of this issue:
```solidity
pragma solidity ^0.8.13;
```
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEthStorage.sol#L2
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L2
https://github.com/code-423n4/... | pragma solidity ^0.8.13; | uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) * (10 ** 18 - maxSlippage)) / 10 ** 18; | reentrancy | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/favelanky-Q.md | 2026-01-02T18:19:07.953350+00:00 | 05a3f5641d8662a84eece4af99d4aaadc604ace8a2c93c4d4e74ded54cc4eb2f | 4 | 3 | 406 | 7 | false | false | true | false | high | pragma solidity ^0.8.13; | solidity | 24 | // Code block 1 (solidity):
pragma solidity ^0.8.13;
// Code block 2 (unknown):
uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) * (10 ** 18 - maxSlippage)) / 10 ** 18;
// Code block 3 (solidity):
File: SafEth.sol
function stake() external payable {
function unstake(uint256 _safEthAmount) extern... | 4 | false | pragma solidity ^0.8.13;
File: SafEth.sol
function stake() external payable {
function unstake(uint256 _safEthAmount) external {
File: Reth.sol
IERC20(_tokenIn).approve(UNISWAP_ROUTER, _amountIn);
File: SfrxEth.sol
IsFrxEth(FRX_ETH_ADDRESS).approve(
FRX_ETH_CRV_POOL_ADDRESS,
frxEthBalance
); | SafEthStorage.sol#L2, SafEth.sol#L2, SfrxEth.sol#L2, WstEth.sol#L2, NeoTokyoStaker.sol#L1155, NeoTokyoStaker.sol#L1388, NeoTokyoStaker.sol#L1737 | SfrxEth.sol, SafEthStorage.sol, NeoTokyoStaker.sol, WstEth.sol, SafEth.sol | 7 | pragma solidity ^0.8.13; | true | uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) * (10 ** 18 - maxSlippage)) / 10 ** 18; | true | true | 10 | ||
c4 | 08-dopex | JCK G | High | high | # Gas Optimizations
| Number | Issue | Instances | Total Gas Saved |
|--------|-------|-----------|-----------------|
|[G-01]| State variables which are not modified within functions should be set as constant or immutable for values set at deployment | 7 | 70000 |
|[G-02]| create variable immutable and avoid extern... | file: contracts/perp-vault/PerpetualAtlanticVault.sol
51 string public underlyingSymbol;
60 uint256 public collateralPrecision;
| file: contracts/perp-vault/PerpetualAtlanticVaultLP.sol
49 ERC20 public collateral;
52 string public underlyingSymbol;
55 string public collateralSymbol;
67 address public rdpx;
70 address public rdpxRdpxV2Core;
| reentrancy | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/JCK-G.md | 2026-01-02T18:24:41.591957+00:00 | 05f6783602df1d888c14bb97765b3c2c59f960c0682c7d177718e522c82fe698 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | file: contracts/perp-vault/PerpetualAtlanticVault.sol
51 string public underlyingSymbol;
60 uint256 public collateralPrecision;
| true | file: contracts/perp-vault/PerpetualAtlanticVaultLP.sol
49 ERC20 public collateral;
52 string public underlyingSymbol;
55 string public collateralSymbol;
67 address public rdpx;
70 address public rdpxRdpxV2Core;
| true | true | 5 | ||||||||
c4 | 08-dopex | Giorgio Q | Gas | gas | ## Title
Consider changing variable to Constant
### Details
In the `./PerpetualAtlanticVault.sol` the `roundingPrecision` variable is initialized to 1e6, however this variable could benefit from being set to Constant for clarity since it is never changed.
#### Affected code
https://github.com/code-423n4/2023-08-do... | timeToExpiry=(genesis+(latestFundingPaymentPointer×fundingDuration))−(genesis+((latestFundingPaymentPointer−1)×fundingDuration)) | timeToExpiry =
genesis + latestFundingPaymentPointer × fundingDuration − genesis − latestFundingPaymentPointer
× fundingDuration + fundingDuration
| reentrancy | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Giorgio-Q.md | 2026-01-02T18:24:38.410538+00:00 | 06b8650bd691fbde0055e81d27315dbec833ed8fe6618a9777867d71c461b9f9 | 0 | 0 | 0 | 5 | false | false | false | false | medium | 0 | 0 | false | PerpetualAtlanticVault.sol#L103-L104, PerpetualAtlanticVault.sol#L44-L45, PerpetualAtlanticVault.sol#L127-L128, PerpetualAtlanticVault.sol#L315-L324, PerpetualAtlanticVault.sol#L372-L380 | PerpetualAtlanticVault.sol | 5 | timeToExpiry=(genesis+(latestFundingPaymentPointer×fundingDuration))−(genesis+((latestFundingPaymentPointer−1)×fundingDuration)) | true | timeToExpiry =
genesis + latestFundingPaymentPointer × fundingDuration − genesis − latestFundingPaymentPointer
× fundingDuration + fundingDuration
| true | true | 6 | ||||||
c4 | 10-badger | zabihullahazadzoi Q | Critical | critical | ## Low Issues
| |Issue|Instances|
|-|:-|:-:|
| [L-1](#L-1) | Code does not follow the best practice of check-effects-interaction | 1 |
| [L-2](#L-2) | Consider implementing two-step procedure for updating protocol addresses | 13 |
| [L-3](#L-3) | Division by zero not prevented | 19 |
| [L-4](#L-4) | Empty `receive()`... | File: packages/contracts/contracts/ActivePool.sol
/// @audit syncGlobalAccountingAndGracePeriod() prior to this assignment
398: feeRecipientAddress = _feeRecipientAddress;
| File: packages/contracts/contracts/ActivePool.sol
390: function setFeeRecipientAddress(address _feeRecipientAddress) external requiresAuth {
| reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/zabihullahazadzoi-Q.md | 2026-01-02T18:27:06.554425+00:00 | 07304e7af8df19d2031dc49a1b4fd50b7c35984ebfba9cf2dff29ac674a25614 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: packages/contracts/contracts/ActivePool.sol
/// @audit syncGlobalAccountingAndGracePeriod() prior to this assignment
398: feeRecipientAddress = _feeRecipientAddress;
| true | File: packages/contracts/contracts/ActivePool.sol
390: function setFeeRecipientAddress(address _feeRecipientAddress) external requiresAuth {
| true | true | 5 | ||||||||
c4 | 01-ondo | erictee Q | Critical | critical | ### [L-01] ```require()``` should be used instead of ```assert()```
#### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as ```require()```/```revert()``` do. ```assert()``` should be avoided even past solidity version 0.8.0... | #### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as ```require()```/```revert()``` do. ```assert()``` should be avoided even past solidity version 0.8.0 as its [documentation](https://docs.soliditylang.org/en/v0.8.14/contr... | ### [L-02] ```decimals()``` not part of ERC20 standard.
#### Impact | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/erictee-Q.md | 2026-01-02T18:15:08.309850+00:00 | 073a7289e6c1f79df0f76fe6de2120115b632b3e97269998078404b5d7641594 | 3 | 0 | 852 | 0 | false | false | true | false | high | #### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as | unknown | 149 | // Code block 1 (unknown):
#### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as
// Code block 2 (unknown):
contracts/cash/factory/CashKYCSenderFactory.sol:L106 assert(cashKYCSenderProxyAdmin.owner() == guardian);
contr... | 3 | false | 0 | #### Impact
Prior to solidity version 0.8.0, hitting an assert consumes the remainder of the transaction’s available gas rather than returning it, as ```require()```/```revert()``` do. ```assert()``` should be avoided even past solidity version 0.8.0 as its [documentation](https://docs.soliditylang.org/en/v0.8.14/contr... | true | ### [L-02] ```decimals()``` not part of ERC20 standard.
#### Impact | true | true | 8 | |||||
c4 | 07-amphora | 0xWaitress G | Informational | informational | ### [G-1] paysInterest in USDA access storage repeatedly in a loop
consider retrieve `_vaultControllers.length()` once and use it from memory in the for loop
```solidity
modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateIntere... | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
} | _gonBalances[_target] += _amount * __gonsPerFragment;
// total supply is in fragments, and so we add amount
_totalSupply += _amount;
// and totalgons of course is in gons, and so we multiply amount by gonsperfragment to get the amount of gons we must add to totalGons
_totalGons += _amount * __gonsPe... | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/0xWaitress-G.md | 2026-01-02T18:23:20.141104+00:00 | 074c684d16412908bc3a2e074e3b2613c434b917a6ffcd98220a25c4b1a2f4e9 | 2 | 2 | 535 | 0 | false | false | true | false | high | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
} | solidity | 209 | // Code block 1 (solidity):
modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
}
// Code block 2 (solidity):
_gonBalances[_target] += _amount * __gonsPerFragment;... | 2 | false | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
}
_gonBalances[_target] += _amount * __gonsPerFragment;
// total supply is in fragments, and so we add amou... | 0 | modifier paysInterest() {
for (uint256 _i; _i < _vaultControllers.length();) {
IVaultController(_vaultControllers.at(_i)).calculateInterest();
unchecked {
_i++;
}
}
_;
} | true | _gonBalances[_target] += _amount * __gonsPerFragment;
// total supply is in fragments, and so we add amount
_totalSupply += _amount;
// and totalgons of course is in gons, and so we multiply amount by gonsperfragment to get the amount of gons we must add to totalGons
_totalGons += _amount * __gonsPe... | true | true | 7 | ||||
c4 | 02-ethos | bin2chen Q | Low | low | L-1:
CollateralConfig.updateCollateralRatios() will modify the MCR and CCR, these two parameters will affect whether the user is liquidated, related to the user's collateral.
Although the administrator is a multi-signature wallet, but still need to have an effective time, to give the user sufficient time to choose whet... | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ ... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/bin2chen-Q.md | 2026-01-02T18:16:51.730460+00:00 | 074d96225c0dc17314a8af3505b669e34c6e2ef3227d61f8710f0729a23b8da4 | 1 | 1 | 392 | 0 | false | true | true | false | high | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ e... | solidity | 392 | // Code block 1 (solidity):
function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDD... | 1 | false | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ e... | 0 | function increaseLUSDDebt(address _collateral, uint _amount) external override {
_requireValidCollateralAddress(_collateral);
_requireCallerIsBOorTroveM();
LUSDDebt[_collateral] = LUSDDebt[_collateral].add(_amount);
- ActivePoolLUSDDebtUpdated(_collateral, LUSDDebt[_collateral]);
+ ... | true | false | false | 5 | ||||||
c4 | 09-ondo | adriro Q | Critical | critical | # Report
## Summary
### Low Issues
Total of **10 issues**:
|ID|Issue|
|:--:|:---|
| [L-1](#l-1-confusing-semantics-for-bridged-messages-approvals) | Confusing semantics for bridged messages approvals |
| [L-2](#l-2-no-default-threshold-configuration) | No default threshold configuration |
| [L-3](#l-3-validate-numb... | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR)); | emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/adriro-Q.md | 2026-01-02T18:25:46.189325+00:00 | 0762b39b8ef2e8149cefbd48476e87ac19022a877858c3b297a2467a15a81d38 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | DestinationBridge.sol#L111 | DestinationBridge.sol | 1 | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR)); | true | emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | true | true | 6 | ||||||
c4 | 08-dopex | 0xSmartContract Q | Critical | critical | ### QA Report Issues List
- [x] **Low 01** → Role-based `PAUSER_ROLE` is incorrectly defined
- [x] **Low 02** → `swap()` function becomes unusable after 13 years
- [x] **Low 03** → getLpPrice() value is received from Oracle with External call , but doesn't check to value for unexpected return values
- [x] **Low 04** →... | contracts\reserve\RdpxReserve.sol:
22
23: constructor(address _rdpx) {
24: rdpx = _rdpx;
25: _grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
26: _grantRole(PAUSER_ROLE, msg.sender);
27: }
28:
29: /**
30: * @notice Pauses the vault for emergency cases
31: * @dev Can only be ... | ### [Low-02] swap() function becomes unusable after 13 years
`UniV3LiquidityAmo.swap() ` function is very important role in project, in line 295 also we can see , deadline is 2105300114 unixtime value , this value means ; This function becomes unusable in 13 years later
13 years not as far and this contract not upgra... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0xSmartContract-Q.md | 2026-01-02T18:24:19.561647+00:00 | 078cbbeb7d698b3951ae43f112d2c0bf6ac888bbc5b4a2d2030b36817980303a | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | contracts\reserve\RdpxReserve.sol:
22
23: constructor(address _rdpx) {
24: rdpx = _rdpx;
25: _grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
26: _grantRole(PAUSER_ROLE, msg.sender);
27: }
28:
29: /**
30: * @notice Pauses the vault for emergency cases
31: * @dev Can only be ... | true | ### [Low-02] swap() function becomes unusable after 13 years
`UniV3LiquidityAmo.swap() ` function is very important role in project, in line 295 also we can see , deadline is 2105300114 unixtime value , this value means ; This function becomes unusable in 13 years later
13 years not as far and this contract not upgra... | true | true | 5 | ||||||||
c4 | 07-amphora | Aymen0909 G | Low | low | # Gas Optimizations
## Summary
| | Issue | Instances |
| :---: |:-------------|:------------:|
| 1 | State variables should be packed to save storage slots | 3 |
| 2 | Emit events outside the for loops | 3 |
| 3 | Multiple address/IDs mappings can be combined into a single mapping of an address/id to ... | File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee; | /// @dev Percentage of rewards taken in CVX (1e18 == 100%)
uint256 public cvxRewardFee;
/// @dev Percentage of rewards taken in CRV (1e18 == 100%)
uint256 public crvRewardFee; | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/Aymen0909-G.md | 2026-01-02T18:23:22.400450+00:00 | 07b05b20259f5b7276fc1773e91ad9ad9538675c0fd7a0a2fa673e579779fecf | 5 | 0 | 761 | 0 | false | false | true | false | high | File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee; | unknown | 101 | // Code block 1 (unknown):
File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee;
// Code block 2 (unknown):
/// @dev Percentage of rewards taken in CVX (1e18 == 100%)
uint256 public cvxRewardFee;
/// @dev Percentage of rewards taken in CRV (1e18 == 100%)
uint256 public ... | 5 | false | 0 | File: core/AMPHClaimer.sol
45 uint256 public cvxRewardFee;
48 uint256 public crvRewardFee; | true | /// @dev Percentage of rewards taken in CVX (1e18 == 100%)
uint256 public cvxRewardFee;
/// @dev Percentage of rewards taken in CRV (1e18 == 100%)
uint256 public crvRewardFee; | true | true | 10 | |||||
c4 | 09-ondo | John_Femi Q | High | high | # 1
## Title
Unbounded loops used
## Impact
In the `setThresholds` function we see the function allows owner to input an unbounded length of arrays for amounts and numOfApprovers. This can lead to a long list of input which could cause the gasLimit to be hit and txn reverted with gas wasted.
## Proof of Concept
With am... | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
} | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/John_Femi-Q.md | 2026-01-02T18:25:32.662831+00:00 | 08431411cafa1ef2edda8cf4b679ff754077693e15e03486af19a30b048c0aac | 2 | 2 | 171 | 0 | false | false | true | false | high | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
} | solidity | 87 | // Code block 1 (solidity):
struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
}
// Code block 2 (solidity):
struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | 2 | false | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
}
struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | 0 | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address[] approvers;
} | true | struct TxnThreshold {
uint256 numberOfApprovalsNeeded;
address approver;
} | true | true | 7 | ||||
c4 | 09-ondo | Stormreckson Q | High | high | 1- The following functions in `rUSDY.sol` lack checks on the returned values of the external calls made.
Not checking the return value of an external call can result in undesired state changes within the contract. This may lead to loss of funds, incorrect calculations or balances, or unintended consequences that can ne... | usdy.transfer(msg.sender, sharesAmount / BPS_DENOMINATOR); | usdy.transfer(msg.sender, usdyAmount / BPS_DENOMINATOR); | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/Stormreckson-Q.md | 2026-01-02T18:25:41.739133+00:00 | 08a7ccabc059dd1a698bed75279861abebe31cb96cd46e3035199a2c3947a4c2 | 4 | 0 | 594 | 3 | false | false | true | false | high | usdy.transfer(msg.sender, sharesAmount / BPS_DENOMINATOR); | unknown | 58 | // Code block 1 (unknown):
usdy.transfer(msg.sender, sharesAmount / BPS_DENOMINATOR);
// Code block 2 (unknown):
usdy.transfer(msg.sender, usdyAmount / BPS_DENOMINATOR);
// Code block 3 (unknown):
usdy.transferFrom(msg.sender, address(this), _USDYAmount);
// Code block 4 (unknown):
function unwrap(uint256 _rUSDYAmou... | 4 | false | rUSDY.sol#L680-L681, rUSDY.sol#L454-L455, rUSDY.sol#L436 | rUSDY.sol | 3 | usdy.transfer(msg.sender, sharesAmount / BPS_DENOMINATOR); | true | usdy.transfer(msg.sender, usdyAmount / BPS_DENOMINATOR); | true | true | 10 | |||
c4 | 02-ethos | BanPaleo G | Low | low | (1) We can pack structs to smaller size to save storage slot
Structs containing `uint256` should be checked again if it is really necessary to use `uint256` and instead can use a lower value such as `uint128` as it is unlikely there is ever need to pass the max value of `uint128`. By using `uint128` it can save signif... | ActivePool.sol:
218
219 // Due to "stack too deep" error
220: struct LocalVariables_rebalance {
221: uint256 currentAllocated;
222: IERC4626 yieldGenerator;
223: uint256 ownedShares;
224: uint256 sharesToAssets;
225: uint256 profit;
226: uint2... | ActivePool.sol:
3: pragma solidity 0.6.11;
BorrowerOperations.sol:
3: pragma solidity 0.6.11;
CollateralConfig.sol:
3: pragma solidity 0.6.11;
LUSDToken.sol:
3: pragma solidity 0.6.11;
StabilityPool.sol:
3: pragma solidity 0.6.11;
TroveManager.sol:
3: pragma solidity 0.6.11;
CommunityIssua... | other | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/BanPaleo-G.md | 2026-01-02T18:15:58.580948+00:00 | 08ac136849f8aacbd949fd56e3336db1057c1a4653981562e31401745de14271 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | ActivePool.sol:
218
219 // Due to "stack too deep" error
220: struct LocalVariables_rebalance {
221: uint256 currentAllocated;
222: IERC4626 yieldGenerator;
223: uint256 ownedShares;
224: uint256 sharesToAssets;
225: uint256 profit;
226: uint2... | true | ActivePool.sol:
3: pragma solidity 0.6.11;
BorrowerOperations.sol:
3: pragma solidity 0.6.11;
CollateralConfig.sol:
3: pragma solidity 0.6.11;
LUSDToken.sol:
3: pragma solidity 0.6.11;
StabilityPool.sol:
3: pragma solidity 0.6.11;
TroveManager.sol:
3: pragma solidity 0.6.11;
CommunityIssua... | true | true | 5 | ||||||||
c4 | 06-lybra | report | Critical | critical | ---
sponsor: "Lybra Finance"
slug: "2023-06-lybra"
date: "2023-08-21"
title: "Lybra Finance"
findings: "https://github.com/code-423n4/2023-06-lybra-findings/issues"
contest: 254
---
# Overview
## About C4
Code4rena (C4) is an open organization consisting of security researchers, auditors, developers, and individuals... | contract GnosisSafeProxy {
// singleton always needs to be first declared variable, to ensure that it is at the same location in the contracts to which calls are delegated.
// To reduce deployment costs this variable is internal and needs to be retrieved via `getStorageAt`
address internal singleton;
/... | uint256 onBehalfOfCollateralRatio = (depositedAsset[onBehalfOf] * assetPrice * 100) / getBorrowedOf(onBehalfOf); | reentrancy | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/report.md | 2026-01-02T18:23:15.409200+00:00 | 08d21db2b12c6790c5a30893833f3e845a111a937e474be6ad30a3523b50c707 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | contract GnosisSafeProxy {
// singleton always needs to be first declared variable, to ensure that it is at the same location in the contracts to which calls are delegated.
// To reduce deployment costs this variable is internal and needs to be retrieved via `getStorageAt`
address internal singleton;
/... | true | uint256 onBehalfOfCollateralRatio = (depositedAsset[onBehalfOf] * assetPrice * 100) / getBorrowedOf(onBehalfOf); | true | true | 5 | ||||||||
c4 | 04-caviar | codeslide G | Low | low | ### Gas Optimizations
| Number | Issue | Instances |
| :----: | :---- | :-------: |
| [G-01] | Use short circuiting to save gas | 5 |
| [G-02] | Use assembly to check for address(0) | 22 |
| [G-03] | Change function visibility from public to external | 19 |
| [G-04] | State variables should be cached | 28 |
| [G-05] |... | File: src/EthRouter.sol
// before - always reading block.timestamp
102: if (block.timestamp > deadline && deadline != 0) {
// after - don't have to read block.timestamp if local variable is zero
102: if (deadline != 0 && block.timestamp > deadline) {
// same as line 102
154: if (block.timestamp > deadline &... | File: src/Factory.sol
87: if ((_baseToken == address(0) && msg.value != baseTokenAmount) || (_baseToken != address(0) && msg.value > 0)) {
110: if (_baseToken == address(0)) { | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/codeslide-G.md | 2026-01-02T18:20:22.210382+00:00 | 08ee4b401427cdf34e72ad97c6943b69aa3b3b79a9177d6ad68556c1fb35d84e | 2 | 2 | 680 | 0 | false | false | true | false | high | File: src/EthRouter.sol
// before - always reading block.timestamp
102: if (block.timestamp > deadline && deadline != 0) {
// after - don't have to read block.timestamp if local variable is zero
102: if (deadline != 0 && block.timestamp > deadline) {
// same as line 102
154: if (block.timestamp > deadline &... | solidity | 498 | // Code block 1 (solidity):
File: src/EthRouter.sol
// before - always reading block.timestamp
102: if (block.timestamp > deadline && deadline != 0) {
// after - don't have to read block.timestamp if local variable is zero
102: if (deadline != 0 && block.timestamp > deadline) {
// same as line 102
154: if (... | 2 | false | File: src/EthRouter.sol
// before - always reading block.timestamp
102: if (block.timestamp > deadline && deadline != 0) {
// after - don't have to read block.timestamp if local variable is zero
102: if (deadline != 0 && block.timestamp > deadline) {
// same as line 102
154: if (block.timestamp > deadline &... | 0 | File: src/EthRouter.sol
// before - always reading block.timestamp
102: if (block.timestamp > deadline && deadline != 0) {
// after - don't have to read block.timestamp if local variable is zero
102: if (deadline != 0 && block.timestamp > deadline) {
// same as line 102
154: if (block.timestamp > deadline &... | true | File: src/Factory.sol
87: if ((_baseToken == address(0) && msg.value != baseTokenAmount) || (_baseToken != address(0) && msg.value > 0)) {
110: if (_baseToken == address(0)) { | true | true | 7 | ||||
c4 | 04-caviar | Bauchibred Q | Critical | critical | # Caviar QA report
# Low Issues
## L-01 Solmate’s SafeTransferLib doesn’t check whether the ERC20 contract exists
### Proof of Concept
[PrivatePool.sol L30](https://github.com/code-423n4/2023-04-caviar/blob/cd8a92667bcb6657f70657183769c244d04c015c/src/PrivatePool.sol#L30)
[Factory.sol L27](https://github.com/code-... | function execute(address target, bytes memory data) public payable onlyOwner returns (bytes memory) {
// call the target with the value and data
(bool success, bytes memory returnData) = target.call{value: msg.value}(data);
// if the call succeeded return the return data
if (success... | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/Bauchibred-Q.md | 2026-01-02T18:19:31.176871+00:00 | 090fa0343d57da69d1fd9e86fd1c6bd7fd4009f408d27627b853ca71224b112a | 0 | 0 | 0 | 5 | false | true | false | false | medium | 0 | 0 | false | PrivatePool.sol#L30, Factory.sol#L27, EthRouter.sol#L32, SafeTransferLib.sol#L9, PrivatePool.sol#L459-L476 | EthRouter.sol, SafeTransferLib.sol, PrivatePool.sol, Factory.sol | 5 | function execute(address target, bytes memory data) public payable onlyOwner returns (bytes memory) {
// call the target with the value and data
(bool success, bytes memory returnData) = target.call{value: msg.value}(data);
// if the call succeeded return the return data
if (success... | true | false | false | 5 | ||||||||
c4 | 05-ajna | niki G | Unknown | unknown | ### Don't Initialize Variables with Default Value
#### Findings:
```
Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
PositionManager.sol::181 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::364 => for (uint256 i = 0; ... | Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
PositionManager.sol::181 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::364 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::474 => uint256 filteredInd... | Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
RewardsManager.sol::229 => for (uint256 i = 0; i < positionIndexes.length; ) {
RewardsManager.sol::290 => for (uint256 i = 0; i < positionIndexes.length; ) {
RewardsManager.sol::440 => for ... | upgrade | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/niki-G.md | 2026-01-02T18:21:39.510020+00:00 | 092e9441baad52c288b2c71864495c0b2492c5693f3f87e234b0c38e9413a4cd | 1 | 0 | 1,500 | 0 | false | false | true | false | high | Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
PositionManager.sol::181 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::364 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::474 => uint256 filteredInd... | unknown | 1,500 | // Code block 1 (unknown):
Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
PositionManager.sol::181 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::364 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol:... | 1 | false | 0 | Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
PositionManager.sol::181 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::364 => for (uint256 i = 0; i < indexesLength; ) {
PositionManager.sol::474 => uint256 filteredInd... | true | Funding.sol::62 => for (uint256 i = 0; i < targets_.length; ++i) {
Funding.sol::112 => for (uint256 i = 0; i < targets_.length;) {
RewardsManager.sol::229 => for (uint256 i = 0; i < positionIndexes.length; ) {
RewardsManager.sol::290 => for (uint256 i = 0; i < positionIndexes.length; ) {
RewardsManager.sol::440 => for ... | true | true | 6 | |||||
c4 | 08-dopex | LeoS G | Medium | medium | # Summary
| | Issue | Instances | Gas Saved |
|--------|-------|-----------|-----------|
|[G-01]|Use `calldata` instead of `memory`|7|-15 946|
|[G-02]| Addition to automated findings [G-07]|1|-210|
|[G-03]|Parts of the solmate library are available more efficiently|1|-104|
|[G-04]|Variables do not need to be ca... | testAdminFunctions() (gas: -12 (-0.004%))
testEmergencyWithdrawNonNative() (gas: 32 (0.030%))
testFundingAccruedForOneOption() (gas: -215 (-0.030%))
testRedeemOnBehalfOf() (gas: -396 (-0.044%))
testBondWithDelegateMintDecayRiptide() (gas: -580 (-0.045%))
testWithdraw() (gas: -685 (-0.048%))
testBondWithoutOptions() (ga... | testAddToDelegate() (gas: -210 (-0.061%))
Overall gas change: -210 (-0.001%) | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/LeoS-G.md | 2026-01-02T18:24:49.281308+00:00 | 098dd93b3560925b94c9924c3fd300dc72441b28428720dc80af4ad855e7aa31 | 0 | 0 | 0 | 6 | false | false | false | false | medium | 0 | 0 | false | RdpxV2Core.sol#L242, RdpxV2Core.sol#L271, RdpxV2Core.sol#L821, RdpxV2Core.sol#L822, RdpxV2Core.sol#L1136, PerpetualAtlanticVault.sol#L316 | PerpetualAtlanticVault.sol, RdpxV2Core.sol | 6 | testAdminFunctions() (gas: -12 (-0.004%))
testEmergencyWithdrawNonNative() (gas: 32 (0.030%))
testFundingAccruedForOneOption() (gas: -215 (-0.030%))
testRedeemOnBehalfOf() (gas: -396 (-0.044%))
testBondWithDelegateMintDecayRiptide() (gas: -580 (-0.045%))
testWithdraw() (gas: -685 (-0.048%))
testBondWithoutOptions() (ga... | true | testAddToDelegate() (gas: -210 (-0.061%))
Overall gas change: -210 (-0.001%) | true | true | 6 | ||||||
c4 | 08-dopex | Daniel526 Q | Critical | critical | A. The `mint` function in the RdpxDecayingBonds contract contains potentially duplicative access control checks, which might lead to code redundancy and confusion during maintenance. Ensuring consistency and reducing complexity in access control mechanisms is crucial to prevent vulnerabilities from creeping into the co... | function mint(address to, uint256 expiry, uint256 rdpxAmount) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = Bond(to, expiry, rdpxAmount);
emit BondMinted(to, bondId, expiry, rdp... | function lockCollateral(uint256 amount) public onlyPerpVault {
require(_activeCollateral + amount <= totalCollateral(), "Insufficient available collateral");
_activeCollateral += amount;
}
| access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Daniel526-Q.md | 2026-01-02T18:24:33.518577+00:00 | 09c994939032531ee68289589f0a4643796e0468fc697904679dd6273907b315 | 1 | 1 | 331 | 0 | false | false | true | false | high | function mint(address to, uint256 expiry, uint256 rdpxAmount) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = Bond(to, expiry, rdpxAmount);
emit BondMinted(to, bondId, expiry, rdp... | solidity | 331 | // Code block 1 (solidity):
function mint(address to, uint256 expiry, uint256 rdpxAmount) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = Bond(to, expiry, rdpxAmount);
emit BondMi... | 1 | false | function mint(address to, uint256 expiry, uint256 rdpxAmount) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = Bond(to, expiry, rdpxAmount);
emit BondMinted(to, bondId, expiry, rdp... | 0 | function mint(address to, uint256 expiry, uint256 rdpxAmount) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = Bond(to, expiry, rdpxAmount);
emit BondMinted(to, bondId, expiry, rdp... | true | function lockCollateral(uint256 amount) public onlyPerpVault {
require(_activeCollateral + amount <= totalCollateral(), "Insufficient available collateral");
_activeCollateral += amount;
}
| true | true | 6 | ||||
c4 | 03-asymmetry | Madalad G | Medium | medium | # Gas Optimizations Summary
| |Issue|Instances|
|:-:|:-|:-:|
|[G-01]|Functions guaranteed to revert when called by normal users can be marked `payable`|14|
|[G-02]|Use assembly to calculate hashes|6|
|[G-03]|Do not compare boolean expressions to boolean literals|2|
|[G-04]|Division/Multiplication by 2 should use bit sh... | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
107: function withdraw(uint256 amount) external onlyOwner {
| File: contracts/SafEth/derivatives/WstEth.sol
48: function setMaxSlippage(uint256 _slippage) external onlyOwner {
56: function withdraw(uint256 _amount) external onlyOwner {
| access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Madalad-G.md | 2026-01-02T18:18:18.450744+00:00 | 09ee2d9f612aee8aad707ea368d2984ce005440ffa73c1991420a43c83c51632 | 1 | 1 | 181 | 2 | false | false | true | false | high | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
107: function withdraw(uint256 amount) external onlyOwner { | solidity | 181 | // Code block 1 (solidity):
File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
107: function withdraw(uint256 amount) external onlyOwner { | 1 | false | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
107: function withdraw(uint256 amount) external onlyOwner { | Reth.sol#L58, Reth.sol#L107 | Reth.sol | 2 | File: contracts/SafEth/derivatives/Reth.sol
58: function setMaxSlippage(uint256 _slippage) external onlyOwner {
107: function withdraw(uint256 amount) external onlyOwner {
| true | File: contracts/SafEth/derivatives/WstEth.sol
48: function setMaxSlippage(uint256 _slippage) external onlyOwner {
56: function withdraw(uint256 _amount) external onlyOwner {
| true | true | 7 | ||
c4 | 02-ethos | MiniGlome G | High | high | ## Gas Optimizations
| |Issue|Instances|
|-|:-|:-:|
| [GAS-01] | Use custom errors rather than `revert()`/`require()` strings | 96 |
| [GAS-02] | Don't Initialize Variables with Default Value | 27 |
| [GAS-03] | Long Revert String | 36 |
| [GAS-04] | Use Shift Right/Left instead of Division/Multiplication if possibl... | File: Ethos\ActivePool.sol
85: require(!addressesSet, "Can call setAddresses only once");
93: require(_treasuryAddress != address(0), "Treasury cannot be 0 address");
107: require(numCollaterals == _erc4626vaults.length, "Vaults array length must match number of collaterals");
111: re... | File: Ethos\BorrowerOperations.sol
525: require(collateralConfig.isCollateralAllowed(_collateral), "BorrowerOps: Invalid collateral address");
529: require(IERC20(_collateral).balanceOf(_user) >= _collAmount, "BorrowerOperations: Insufficient user collateral balance");
530: require(IERC20(_collat... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/MiniGlome-G.md | 2026-01-02T18:16:21.602719+00:00 | 0a10b3865a2082eb8d5476752ebfd486d821b3bd96e9d45bf7a2da8407298d94 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: Ethos\ActivePool.sol
85: require(!addressesSet, "Can call setAddresses only once");
93: require(_treasuryAddress != address(0), "Treasury cannot be 0 address");
107: require(numCollaterals == _erc4626vaults.length, "Vaults array length must match number of collaterals");
111: re... | true | File: Ethos\BorrowerOperations.sol
525: require(collateralConfig.isCollateralAllowed(_collateral), "BorrowerOps: Invalid collateral address");
529: require(IERC20(_collateral).balanceOf(_user) >= _collAmount, "BorrowerOperations: Insufficient user collateral balance");
530: require(IERC20(_collat... | true | true | 5 | ||||||||
c4 | 09-ondo | 0xweb3boy Q | Unknown | unknown | NC-01 : incorrect naming of local variable in unwrap() in rUSDY.sol
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/usdy/rUSDY.sol#L451
```solidity
function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
uint256 usdyAmo... | function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burnShares(msg.sender, usdyAmount);
usdy.transfer(msg.se... | uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount); | other | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/0xweb3boy-Q.md | 2026-01-02T18:25:19.665053+00:00 | 0a2bd9ee3426bcfd1e9ad9072427a61aaf9d86812f98d479361d772b93534dbf | 2 | 1 | 460 | 1 | false | false | true | false | high | function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burnShares(msg.sender, usdyAmount);
usdy.transfer(msg.se... | solidity | 408 | // Code block 1 (solidity):
function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burnShares(msg.sender, usdyAmoun... | 2 | false | function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burnShares(msg.sender, usdyAmount);
usdy.transfer(msg.se... | rUSDY.sol#L451 | rUSDY.sol | 1 | function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burnShares(msg.sender, usdyAmount);
usdy.transfer(msg.se... | true | uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount); | true | true | 6.88 | ||
c4 | 02-ethos | Rickard G | High | high | # [G-01] `bytes constant` are more efficient than `string constant`
## Lines of code
[https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/ActivePool.sol#L30](https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/ActivePool.sol#L30)
[https://github.com/code-423n4/2023-02... | string constant public NAME = "ActivePool"; | string constant public NAME = "BorrowerOperations"; | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Rickard-G.md | 2026-01-02T18:16:34.170005+00:00 | 0a4174576e5594b0f99787d78a127984402bdf440cd61a7f9085919d0a2eefd1 | 1 | 1 | 43 | 6 | false | false | true | false | high | string constant public NAME = "ActivePool"; | solidity | 43 | // Code block 1 (solidity):
string constant public NAME = "ActivePool"; | 1 | false | string constant public NAME = "ActivePool"; | ActivePool.sol#L30, BorrowerOperations.sol#L21, LUSDToken.sol#L32-L34, StabilityPool.sol#L150, CommunityIssuance.sol#L19, LQTYStaking.sol#L23 | StabilityPool.sol, BorrowerOperations.sol, LQTYStaking.sol, LUSDToken.sol, ActivePool.sol, CommunityIssuance.sol | 6 | string constant public NAME = "ActivePool"; | true | string constant public NAME = "BorrowerOperations"; | true | true | 7 | ||
c4 | 03-asymmetry | dingo2077 Q | Low | low | ## [L-01] Users can't stake and unstake if owner added derivative contract with inappropriate interface.
SC: SafEth.sol
The core of lack is lying in function `addDerivative()` where any address can be added as vault.
If in new vault has not implemented IDerivative interface or even uncorrect realization of functions -... | pragma solidity ^0.8.13;
import "forge-std/Test.sol";
import "../../src/SafEth/SafEth.sol";
import "../../src/SafEth/derivatives/Reth.sol";
import "../../src/SafEth/derivatives/SfrxEth.sol";
import "../../src/SafEth/derivatives/WstEth.sol";
import "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol";
contract Sa... | uint256 maxSlip = 1e16;
function testFuzz_Slippage(uint256 ethDep) public {
vm.assume(ethDep > 1 ether && ethDep < 200 ether);
console.log("ethDep: ",ethDep);
console.log("maxSlip: ",maxSlip);
uint256 minOutSC = (ethDep * (10 ** 18 - maxSlip)) / 10 ** 18;
... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/dingo2077-Q.md | 2026-01-02T18:19:05.247902+00:00 | 0a4b7bd35dabfb7b87225f30c10a58585c046f33824eacfa289ea6cbc5b44238 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | pragma solidity ^0.8.13;
import "forge-std/Test.sol";
import "../../src/SafEth/SafEth.sol";
import "../../src/SafEth/derivatives/Reth.sol";
import "../../src/SafEth/derivatives/SfrxEth.sol";
import "../../src/SafEth/derivatives/WstEth.sol";
import "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol";
contract Sa... | true | uint256 maxSlip = 1e16;
function testFuzz_Slippage(uint256 ethDep) public {
vm.assume(ethDep > 1 ether && ethDep < 200 ether);
console.log("ethDep: ",ethDep);
console.log("maxSlip: ",maxSlip);
uint256 minOutSC = (ethDep * (10 ** 18 - maxSlip)) / 10 ** 18;
... | true | true | 5 | ||||||||
c4 | 09-ondo | 0x11singh99 G | High | high | ## Gas Optimizations
| Number |Issue|Instances|
|-|:-|:-:|
| [[G-01](#g-01-structs-can-be-packed-into-fewer-storage-slots)] | `Structs` can be packed into fewer storage slots. | 1 |
| [[G-02](#g-02-abiencode-is-less-efficient-than-abiencodepacked-to-save-gas)] | `abi.encode()` is less efficient than `abi.encodePacked(... | File : contracts/rwaOracles/RWADynamicOracle.sol
295: struct Range {
296: uint256 start;
297: uint256 end;
298: uint256 dailyInterestRate;
299: uint256 prevRangeClosePrice;
300: } | ## [G-02] abi.encode() is less efficient than abi.encodePacked() to save gas.
In Solidity, abi.encode() and abi.encodePacked() are used to encode function arguments and data into a byte array for storage or transmission. However, abi.encodePacked() is generally more gas-efficient than abi.encode() because it does not ... | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/0x11singh99-G.md | 2026-01-02T18:25:11.221480+00:00 | 0a4c447bc469cf0d6ebfebaa2faf3d17972dbf2a6f5c443ca154ddd584070f9b | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File : contracts/rwaOracles/RWADynamicOracle.sol
295: struct Range {
296: uint256 start;
297: uint256 end;
298: uint256 dailyInterestRate;
299: uint256 prevRangeClosePrice;
300: } | true | ## [G-02] abi.encode() is less efficient than abi.encodePacked() to save gas.
In Solidity, abi.encode() and abi.encodePacked() are used to encode function arguments and data into a byte array for storage or transmission. However, abi.encodePacked() is generally more gas-efficient than abi.encode() because it does not ... | true | true | 5 | ||||||||
c4 | 06-lybra | 0xAnah G | High | high | # **GAS OPTIMIZATIONS**
## [G-01] Unused Imports
The following files were imported but were not used. These files would costs gas during deployment and is a bad coding practice .
- https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/pools/LybraWbETHVault.sol#L5
- https://github.com/code-423n4/2023-... | function mint(address onBehalfOf, uint256 amount) external virtual {
require(onBehalfOf != address(0), "TZA");
require(amount > 0, "ZA");
_mintPeUSD(msg.sender, onBehalfOf, amount, getAssetPrice());
} | function mint(address onBehalfOf, uint256 amount) external virtual {
require(amount > 0, "ZA");
require(onBehalfOf != address(0), "TZA");
_mintPeUSD(msg.sender, onBehalfOf, amount, getAssetPrice());
} | access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/0xAnah-G.md | 2026-01-02T18:22:00.668916+00:00 | 0a80a8ceac6f2a8eda1b9c3e04f38a89cf6bc156128c92f5a67e2862127cf3f9 | 0 | 0 | 0 | 11 | false | false | false | false | medium | 0 | 0 | false | LybraWbETHVault.sol#L5, LybraWbETHVault.sol#L7, LybraWstETHVault.sol#L5, LybraWstETHVault.sol#L7, LybraRETHVault.sol#L5, LybraRETHVault.sol, LybraStETHVault.sol, LybraPeUSDVaultBase.sol#L130, PeUSD.sol#L46, LBR.sol#L64, PeUSDMainnetStableVision.sol#L199 | LybraWstETHVault.sol, LybraRETHVault.sol, PeUSDMainnetStableVision.sol, LybraStETHVault.sol, LybraWbETHVault.sol, PeUSD.sol, LBR.sol, LybraPeUSDVaultBase.sol | 11 | function mint(address onBehalfOf, uint256 amount) external virtual {
require(onBehalfOf != address(0), "TZA");
require(amount > 0, "ZA");
_mintPeUSD(msg.sender, onBehalfOf, amount, getAssetPrice());
} | true | function mint(address onBehalfOf, uint256 amount) external virtual {
require(amount > 0, "ZA");
require(onBehalfOf != address(0), "TZA");
_mintPeUSD(msg.sender, onBehalfOf, amount, getAssetPrice());
} | true | true | 6 | ||||||
c4 | 03-asymmetry | Kaysoft Q | Critical | critical | ## [NC-1] Import declarations should import specific identifiers, rather than the whole file
Using import declarations of the form `import {<identifier_name>} from "My/Contract.sol"` avoids polluting the symbol namespace making flattened files smaller, and speeds up compilation. Avoid import declarations of the form `i... | /**
@notice - Convert derivative into ETH
*/
function withdraw(uint256 amount) external onlyOwner {
RocketTokenRETHInterface(rethAddress()).burn(amount);
// solhint-disable-next-line
(bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
)... | pragma solidity 0.8.19; | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Kaysoft-Q.md | 2026-01-02T18:18:14.791411+00:00 | 0ab50fdc7f0df8d7c08adc1351db839f83395dac9728bcd3d6848cfb97701690 | 1 | 0 | 749 | 3 | false | false | true | false | high | /**
@notice - Convert derivative into ETH
*/
function withdraw(uint256 amount) external onlyOwner {
RocketTokenRETHInterface(rethAddress()).burn(amount);
// solhint-disable-next-line
(bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
)... | unknown | 749 | // Code block 1 (unknown):
/**
@notice - Convert derivative into ETH
*/
function withdraw(uint256 amount) external onlyOwner {
RocketTokenRETHInterface(rethAddress()).burn(amount);
// solhint-disable-next-line
(bool sent, ) = address(msg.sender).call{value: address(this).balance... | 1 | false | Reth.sol#L105, WstEth.sol#L86, WstEth.sol#L56 | Reth.sol, WstEth.sol | 3 | /**
@notice - Convert derivative into ETH
*/
function withdraw(uint256 amount) external onlyOwner {
RocketTokenRETHInterface(rethAddress()).burn(amount);
// solhint-disable-next-line
(bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
)... | true | pragma solidity 0.8.19; | true | true | 7 | |||
c4 | 02-ethos | TheSavageTeddy G | Low | low | # Using bitwise-not `~` instead of `-(i+1)` saves gas
Calculating `-(i+1)` instead of `~` costs **9 more gas**, because of the extra `ADD` , `SUB` and `PUSH`s that can be replaced by `NOT` to achieve the same result.
`startIdx = uint(-(_startIdx + 1));` => `startIdx = uint(~_startIdx);`
*There is 1 instance of this i... | File: MultiTroveGetter.sol
44: startIdx = uint(-(_startIdx + 1)); | File: ReaperBaseStrategyv4.sol
95: function withdraw(uint256 _amount) external override returns (uint256 loss) {
96: require(msg.sender == vault, "Only vault can withdraw");
97: require(_amount != 0, "Amount cannot be zero");
98: require(_amount <= balanceOf(), "Ammount must be less than bal... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/TheSavageTeddy-G.md | 2026-01-02T18:16:40.509385+00:00 | 0ac58e381b984cb15446cda6b4c6bf3978398ac2da4862667067f7063aabf1c7 | 2 | 2 | 404 | 2 | false | false | true | false | high | File: MultiTroveGetter.sol
44: startIdx = uint(-(_startIdx + 1)); | solidity | 77 | // Code block 1 (solidity):
File: MultiTroveGetter.sol
44: startIdx = uint(-(_startIdx + 1));
// Code block 2 (solidity):
File: ReaperBaseStrategyv4.sol
95: function withdraw(uint256 _amount) external override returns (uint256 loss) {
96: require(msg.sender == vault, "Only vault can withdraw");... | 2 | false | File: MultiTroveGetter.sol
44: startIdx = uint(-(_startIdx + 1));
File: ReaperBaseStrategyv4.sol
95: function withdraw(uint256 _amount) external override returns (uint256 loss) {
96: require(msg.sender == vault, "Only vault can withdraw");
97: require(_amount != 0, "Amount cannot be zer... | MultiTroveGetter.sol#L44, ReaperBaseStrategyv4.sol#L95-L98 | ReaperBaseStrategyv4.sol, MultiTroveGetter.sol | 2 | File: MultiTroveGetter.sol
44: startIdx = uint(-(_startIdx + 1)); | true | File: ReaperBaseStrategyv4.sol
95: function withdraw(uint256 _amount) external override returns (uint256 loss) {
96: require(msg.sender == vault, "Only vault can withdraw");
97: require(_amount != 0, "Amount cannot be zero");
98: require(_amount <= balanceOf(), "Ammount must be less than bal... | true | true | 8 | ||
c4 | 09-ondo | ABAIKUNANBAEV Q | Low | low | ## Finding Summary
| ID | Description | Severity |
| - | - | :-: |
| [L-01](#l-01-unnecessary-abundance-of-roles) | Unnecessary abundance of roles in `rUSDY.sol` | Low |
| [L-02](#l-02-unchecked-return-data-when-implementing-multiexcall) | Unchecked return data when implementing multiexcall in `SourceBridge.sol` | Lo... | _grantRole(DEFAULT_ADMIN_ROLE, guardian);
_grantRole(USDY_MANAGER_ROLE, guardian);
_grantRole(PAUSER_ROLE, guardian);
_grantRole(MINTER_ROLE, guardian);
_grantRole(BURNER_ROLE, guardian);
_grantRole(LIST_CONFIGURER_ROLE, guardian); | (bool success, bytes memory ret) = address(exCallData[i].target).call{
value: exCallData[i].value
}(exCallData[i].data);
require(success, "Call Failed");
results[i] = ret;
| access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/ABAIKUNANBAEV-Q.md | 2026-01-02T18:25:21.921321+00:00 | 0adbf7873c4379ae3b950fc144958cd6e43284451f313f73879a872642c0b683 | 2 | 0 | 448 | 2 | false | false | true | false | high | _grantRole(DEFAULT_ADMIN_ROLE, guardian);
_grantRole(USDY_MANAGER_ROLE, guardian);
_grantRole(PAUSER_ROLE, guardian);
_grantRole(MINTER_ROLE, guardian);
_grantRole(BURNER_ROLE, guardian);
_grantRole(LIST_CONFIGURER_ROLE, guardian); | unknown | 251 | // Code block 1 (unknown):
_grantRole(DEFAULT_ADMIN_ROLE, guardian);
_grantRole(USDY_MANAGER_ROLE, guardian);
_grantRole(PAUSER_ROLE, guardian);
_grantRole(MINTER_ROLE, guardian);
_grantRole(BURNER_ROLE, guardian);
_grantRole(LIST_CONFIGURER_ROLE, guardian);
// Code block 2 (unknown):
(bool success... | 2 | false | rUSDY.sol#L141-L146, SourceBridge.sol#L165-L169 | rUSDY.sol, SourceBridge.sol | 2 | _grantRole(DEFAULT_ADMIN_ROLE, guardian);
_grantRole(USDY_MANAGER_ROLE, guardian);
_grantRole(PAUSER_ROLE, guardian);
_grantRole(MINTER_ROLE, guardian);
_grantRole(BURNER_ROLE, guardian);
_grantRole(LIST_CONFIGURER_ROLE, guardian); | true | (bool success, bytes memory ret) = address(exCallData[i].target).call{
value: exCallData[i].value
}(exCallData[i].data);
require(success, "Call Failed");
results[i] = ret;
| true | true | 8 | |||
c4 | 02-ethos | eyexploit Q | Critical | critical | # Finding 1 : Risk of updating CR via `updateCollateralRatios()` can be minimized
https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/CollateralConfig.sol#L78-L100
There might be a scenario where you want to lower the `MCR` but keeping the `CCR` unchanged f... | // !!!PLEASE USE EXTREME CARE AND CAUTION. THIS IS IRREVERSIBLE!!!
// You probably don't want to do this unless a specific asset has proved itself through tough times.
// Doing this irresponsibly can permanently harm the protocol. | function updateMinimumCollateralRatio(address _collateral, uint256 _MCR) external onlyOwner checkCollateral(_collateral) {
Config storage config = collateralConfig[_collateral];
require(_MCR <= config.MCR, "Can only walk down the MCR");
require(_MCR >= MIN_ALLOWED_MCR, "MCR below allowed mi... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/eyexploit-Q.md | 2026-01-02T18:17:10.069509+00:00 | 0b37d3bd3415e1243adc06c9b872504d3a1b4a305a818fb109dba6bb2c972998 | 2 | 1 | 1,101 | 2 | false | false | true | false | high | // !!!PLEASE USE EXTREME CARE AND CAUTION. THIS IS IRREVERSIBLE!!!
// You probably don't want to do this unless a specific asset has proved itself through tough times.
// Doing this irresponsibly can permanently harm the protocol. | unknown | 241 | // Code block 1 (unknown):
// !!!PLEASE USE EXTREME CARE AND CAUTION. THIS IS IRREVERSIBLE!!!
// You probably don't want to do this unless a specific asset has proved itself through tough times.
// Doing this irresponsibly can permanently harm the protocol.
// Code block 2 (solidity):
function updateMinimum... | 2 | false | function updateMinimumCollateralRatio(address _collateral, uint256 _MCR) external onlyOwner checkCollateral(_collateral) {
Config storage config = collateralConfig[_collateral];
require(_MCR <= config.MCR, "Can only walk down the MCR");
require(_MCR >= MIN_ALLOWED_MCR, "MCR below allowed minimu... | CollateralConfig.sol#L78-L100, ReaperVaultV2.sol#L155 | CollateralConfig.sol, ReaperVaultV2.sol | 2 | // !!!PLEASE USE EXTREME CARE AND CAUTION. THIS IS IRREVERSIBLE!!!
// You probably don't want to do this unless a specific asset has proved itself through tough times.
// Doing this irresponsibly can permanently harm the protocol. | true | function updateMinimumCollateralRatio(address _collateral, uint256 _MCR) external onlyOwner checkCollateral(_collateral) {
Config storage config = collateralConfig[_collateral];
require(_MCR <= config.MCR, "Can only walk down the MCR");
require(_MCR >= MIN_ALLOWED_MCR, "MCR below allowed mi... | true | true | 8 | ||
c4 | 06-lybra | Iurii3 Q | High | high | 1. During initiation of tokens in LybraConfiguration.sol wrong interface is used
[LybraConfigurator.solL100](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/configuration/LybraConfigurator.sol#L100C1-L100C65)
Should use IPeUSD instead of IEUSD. However, this m... | 2. setTokenMiner function may revert due to array length discrepancies
[LybraConfigurator.solL235-240](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/configuration/LybraConfigurator.sol#L235C1-L240C6)
setTokenMiner function has two arguments - array of _cont... | 4. Vaults would be almost impossible to use with assets with decimals < 18.
[LybraEUSDVaultBase.solL73](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/pools/base/LybraEUSDVaultBase.sol#L73-L73)
[LybraPeUSDVaultBase.solL59](https://github.com/code-423n4/2023-06... | other | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/Iurii3-Q.md | 2026-01-02T18:22:21.454464+00:00 | 0b5d3264d2f6d377ac66be66379ec076fc3895ab612d958033142b69e7271714 | 1 | 0 | 459 | 8 | false | false | true | false | high | 2. setTokenMiner function may revert due to array length discrepancies
[LybraConfigurator.solL235-240](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/configuration/LybraConfigurator.sol#L235C1-L240C6)
setTokenMiner function has two arguments - array of _cont... | unknown | 459 | // Code block 1 (unknown):
2. setTokenMiner function may revert due to array length discrepancies
[LybraConfigurator.solL235-240](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/configuration/LybraConfigurator.sol#L235C1-L240C6)
setTokenMiner function has two... | 1 | false | LybraConfigurator.sol#L100-L1, LybraConfigurator.sol#L235-L1, esLBRBoost.sol#L42, LybraEUSDVaultBase.sol#L73, LybraPeUSDVaultBase.sol#L59, LybraEUSDVaultBase.sol#L109, LybraPeUSDVaultBase.sol#L80, LybraPeUSDVaultBase.sol#L123 | esLBRBoost.sol, LybraConfigurator.sol, LybraPeUSDVaultBase.sol, LybraEUSDVaultBase.sol | 8 | 2. setTokenMiner function may revert due to array length discrepancies
[LybraConfigurator.solL235-240](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/configuration/LybraConfigurator.sol#L235C1-L240C6)
setTokenMiner function has two arguments - array of _cont... | true | 4. Vaults would be almost impossible to use with assets with decimals < 18.
[LybraEUSDVaultBase.solL73](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/pools/base/LybraEUSDVaultBase.sol#L73-L73)
[LybraPeUSDVaultBase.solL59](https://github.com/code-423n4/2023-06... | true | true | 7 | |||
c4 | 03-asymmetry | 0xNorman Q | High | high | 1. Lack of input validation in setPauseStaking() and setPauseUnstaking()
https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/contracts/SafEth/SafEth.sol#L232-L244
When using the ```setPauseStaking``` and ```setPauseUnstaking``` function, it's better to check if the input param... | function setPauseStaking(bool _pause) external onlyOwner {
require(_pause != pauseStaking, " pauseStaking unchanged!");
pauseStaking = _pause;
emit StakingPaused(pauseStaking);
}
/**
@notice - Owner only function that enables/disables the unstake function
@param _pause -... | function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight
) external onlyOwner {
require(__derivativeIndex < derivativeCount, "derivative does not exist!")
weights[_derivativeIndex] = _weight;
uint256 localTotalWeight = 0;
for (uint256 i = 0; i < derivativeCoun... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/0xNorman-Q.md | 2026-01-02T18:17:35.498046+00:00 | 0b88a3337a36a32f4f1234a3a0c8ba2ca47b1c03b8b14f3057cfaab7c67f3434 | 2 | 0 | 1,070 | 2 | false | false | true | false | high | function setPauseStaking(bool _pause) external onlyOwner {
require(_pause != pauseStaking, " pauseStaking unchanged!");
pauseStaking = _pause;
emit StakingPaused(pauseStaking);
}
/**
@notice - Owner only function that enables/disables the unstake function
@param _pause -... | unknown | 599 | // Code block 1 (unknown):
function setPauseStaking(bool _pause) external onlyOwner {
require(_pause != pauseStaking, " pauseStaking unchanged!");
pauseStaking = _pause;
emit StakingPaused(pauseStaking);
}
/**
@notice - Owner only function that enables/disables the unstake funct... | 2 | false | SafEth.sol#L232-L244, SafEth.sol#L165-L175 | SafEth.sol | 2 | function setPauseStaking(bool _pause) external onlyOwner {
require(_pause != pauseStaking, " pauseStaking unchanged!");
pauseStaking = _pause;
emit StakingPaused(pauseStaking);
}
/**
@notice - Owner only function that enables/disables the unstake function
@param _pause -... | true | function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight
) external onlyOwner {
require(__derivativeIndex < derivativeCount, "derivative does not exist!")
weights[_derivativeIndex] = _weight;
uint256 localTotalWeight = 0;
for (uint256 i = 0; i < derivativeCoun... | true | true | 8 | |||
c4 | 11-kelp | rouhsamad Q | Unknown | unknown | ## rounding down error when depositing stETH tokens
The `transfer` function in stETH token first converts the amount that is being transferred to correct amount of shares using getSharesByPooledEth function:
```
function getSharesByPooledEth(uint256 _ethAmount) public view returns (uint256) {
return _ethAm... | function getSharesByPooledEth(uint256 _ethAmount) public view returns (uint256) {
return _ethAmount
.mul(_getTotalShares())
.div(_getTotalPooledEther());
} | function test_DepositSTETHFlooring() external {
uint256 amountToDeposit = 1 ether;
vm.startPrank(manager);
lrtConfig.updateAssetDepositLimit(address(stETH), amountToDeposit);
vm.stopPrank();
vm.startPrank(alice);
//approve the pool
stETH.approve(address(lrtDe... | rounding | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/rouhsamad-Q.md | 2026-01-02T18:28:25.123618+00:00 | 0ba40ac3a3d3a855f63b1520999699707d458e79e167ea74e98848b92365d8cc | 2 | 0 | 957 | 0 | false | false | true | false | high | function getSharesByPooledEth(uint256 _ethAmount) public view returns (uint256) {
return _ethAmount
.mul(_getTotalShares())
.div(_getTotalPooledEther());
} | unknown | 191 | // Code block 1 (unknown):
function getSharesByPooledEth(uint256 _ethAmount) public view returns (uint256) {
return _ethAmount
.mul(_getTotalShares())
.div(_getTotalPooledEther());
}
// Code block 2 (unknown):
function test_DepositSTETHFlooring() external {
uint256 amountToD... | 2 | false | 0 | function getSharesByPooledEth(uint256 _ethAmount) public view returns (uint256) {
return _ethAmount
.mul(_getTotalShares())
.div(_getTotalPooledEther());
} | true | function test_DepositSTETHFlooring() external {
uint256 amountToDeposit = 1 ether;
vm.startPrank(manager);
lrtConfig.updateAssetDepositLimit(address(stETH), amountToDeposit);
vm.stopPrank();
vm.startPrank(alice);
//approve the pool
stETH.approve(address(lrtDe... | true | true | 7 | |||||
c4 | 07-amphora | qpzm Q | Medium | medium | ## Unnecessary _eta check in `GovernorCharlie._queueTransaction`
`if (_eta < (_getBlockTimestamp() + _delay)) revert GovernorCharlie_DelayNotReached();` is not necessary.
https://github.com/code-423n4/2023-07-amphora/blob/5d1cea9410db5448760c834f001af04a72edf3e0/core/solidity/contracts/governance/GovernorCharlie.sol#L... | function _execute(address target, uint256 value, bytes calldata data) internal virtual {
(bool success, bytes memory returndata) = target.call{value: value}(data);
Address.verifyCallResult(success, returndata);
} | other | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/qpzm-Q.md | 2026-01-02T18:23:59.967417+00:00 | 0be042b80de1d8ed136d71a808af85c64f94246c05fcacf243b4a048008c526b | 1 | 1 | 220 | 4 | false | true | true | false | high | function _execute(address target, uint256 value, bytes calldata data) internal virtual {
(bool success, bytes memory returndata) = target.call{value: value}(data);
Address.verifyCallResult(success, returndata);
} | solidity | 220 | // Code block 1 (solidity):
function _execute(address target, uint256 value, bytes calldata data) internal virtual {
(bool success, bytes memory returndata) = target.call{value: value}(data);
Address.verifyCallResult(success, returndata);
} | 1 | false | function _execute(address target, uint256 value, bytes calldata data) internal virtual {
(bool success, bytes memory returndata) = target.call{value: value}(data);
Address.verifyCallResult(success, returndata);
} | GovernorCharlie.sol#L297, GovernorCharlie.sol#L258, TimelockController.sol#L412-L415, Address.sol#L204 | TimelockController.sol, GovernorCharlie.sol, Address.sol | 4 | function _execute(address target, uint256 value, bytes calldata data) internal virtual {
(bool success, bytes memory returndata) = target.call{value: value}(data);
Address.verifyCallResult(success, returndata);
} | true | false | false | 5.47 | ||||
c4 | 01-ondo | report | Critical | critical | ---
sponsor: "Ondo Finance"
slug: "2023-01-ondo"
date: "2023-02-28"
title: "Ondo Finance contest"
findings: "https://github.com/code-423n4/2023-01-ondo-findings/issues"
contest: 204
---
# Overview
## About C4
Code4rena (C4) is an open organization consisting of security researchers, auditors, developers, and individ... | function completeRedemptions(
address[] calldata redeemers,
address[] calldata refundees,
uint256 collateralAmountToDist,
uint256 epochToService,
uint256 fees
) external override updateEpoch onlyRole(MANAGER_ADMIN) {
_checkAddressesKYC(redeemers);
_checkAddressesKYC(refundees);
if (epochToService >= cur... | uint256 collateralAmountDue = (amountToDist * cashAmountReturned) /
quantityBurned; | reentrancy | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/report.md | 2026-01-02T18:15:39.005339+00:00 | 0bf168c4f555402132b6f5546eacfc0c763a35e18dde694d82e42cf99d0985c7 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function completeRedemptions(
address[] calldata redeemers,
address[] calldata refundees,
uint256 collateralAmountToDist,
uint256 epochToService,
uint256 fees
) external override updateEpoch onlyRole(MANAGER_ADMIN) {
_checkAddressesKYC(redeemers);
_checkAddressesKYC(refundees);
if (epochToService >= cur... | true | uint256 collateralAmountDue = (amountToDist * cashAmountReturned) /
quantityBurned; | true | true | 5 | ||||||||
c4 | 05-ajna | lfzkoala Q | High | high | #Issue: Missing Access Control (Minor)
Description of the security issue: The `fundTreasury` function does not have any access control in place. This means that any address can call this function and increase the treasury amount, which might not be the intended behavior.
Location of the security issue: ajna-grants/src... | function memorializePositions(
MemorializePositionsParams calldata params_
) external override {
address owner = ownerOf(params_.tokenId);
// Check if the sender is the owner of the token
require(msg.sender == owner, "Not token owner");
// ... rest of your code ...
} | import "@openzeppelin/contracts/utils/math/SafeMath.sol";
contract PositionManager is ERC721, PermitERC721, IPositionManager, Multicall, ReentrancyGuard {
using SafeMath for uint256;
...
function memorializePositions(MemorializePositionsParams calldata params_) external override mayInteract(poolKey[params_... | reentrancy | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/lfzkoala-Q.md | 2026-01-02T18:21:34.685209+00:00 | 0cacac0e53c5cb0178b341b58a26577d1469afd82a9267b9393a7585c6e2180e | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function memorializePositions(
MemorializePositionsParams calldata params_
) external override {
address owner = ownerOf(params_.tokenId);
// Check if the sender is the owner of the token
require(msg.sender == owner, "Not token owner");
// ... rest of your code ...
} | true | import "@openzeppelin/contracts/utils/math/SafeMath.sol";
contract PositionManager is ERC721, PermitERC721, IPositionManager, Multicall, ReentrancyGuard {
using SafeMath for uint256;
...
function memorializePositions(MemorializePositionsParams calldata params_) external override mayInteract(poolKey[params_... | true | true | 5 | ||||||||
c4 | 03-revert-lend | browep Q | Unknown | unknown | Multiple misspellings of "receive", "receives", "received".
```
$ find . -name "*.sol" | xargs grep -n recieve
./src/transformers/V3Utils.sol:633: // check if recieved correct amount of tokens
./src/V3Vault.sol:230: /// @return liquidationValue If position is liquidatable - the value of the (partial) positio... | $ find . -name "*.sol" | xargs grep -n recieve
./src/transformers/V3Utils.sol:633: // check if recieved correct amount of tokens
./src/V3Vault.sol:230: /// @return liquidationValue If position is liquidatable - the value of the (partial) position which the liquidator recieves - otherwise 0
./src/V3Vault.sol:3... | other | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/browep-Q.md | 2026-01-02T19:03:07.764894+00:00 | 0cb89a8f61af1eaf903d1681af051055fb2ffdce5e0c3681239027af5a6d7b73 | 1 | 0 | 633 | 0 | false | true | true | false | medium | $ find . -name "*.sol" | xargs grep -n recieve
./src/transformers/V3Utils.sol:633: // check if recieved correct amount of tokens
./src/V3Vault.sol:230: /// @return liquidationValue If position is liquidatable - the value of the (partial) position which the liquidator recieves - otherwise 0
./src/V3Vault.sol:3... | unknown | 633 | // Code block 1 (unknown):
$ find . -name "*.sol" | xargs grep -n recieve
./src/transformers/V3Utils.sol:633: // check if recieved correct amount of tokens
./src/V3Vault.sol:230: /// @return liquidationValue If position is liquidatable - the value of the (partial) position which the liquidator recieves - othe... | 1 | false | 0 | $ find . -name "*.sol" | xargs grep -n recieve
./src/transformers/V3Utils.sol:633: // check if recieved correct amount of tokens
./src/V3Vault.sol:230: /// @return liquidationValue If position is liquidatable - the value of the (partial) position which the liquidator recieves - otherwise 0
./src/V3Vault.sol:3... | true | false | false | 3.41 | |||||||
c4 | 03-asymmetry | carlitox477 Q | Medium | medium | # wstETH: If the protocol is meant to be multichain, then WST_ETH, LIDO_CRV_POOL and STETH_TOKEN should be immutable and the constructor modified
In order to not change the current code every time a deployment is done, the mentioned variables should be delcared as immutable and their values set in the constructor:
```... | # `WstEth.setMaxSlippage(uint256)`, `Reth.setMaxSlippage(uint256)` and `Sfrx.setMaxSlippage(uint256)` should limit their inputs values to `1e18`
Given that `1e16` is 1%, then 100% would be `1e18`. Given that the slippage should never be greater than 100%.
This would DOS function withdraw/deposit in the different cont... | # `SafETH` Stuck ETH would be freeze forever
Current `SafETH` allows receiving ETH from anyone. In case that a user/contract mistakenly sent ETH to this `SafEth` or in case that `msg.value * weight < totalWeight` in [stake](https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/co... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/carlitox477-Q.md | 2026-01-02T18:18:54.853353+00:00 | 0cb9339fbe5757ae9792c7e8f3f6fdb7537abd86ca1a5e857cd3c8edd26b5901 | 1 | 1 | 965 | 4 | false | false | true | false | high | contract WstEth is IDerivative, Initializable, OwnableUpgradeable {
- address public constant WST_ETH =
- 0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0;
+ address public immutable WST_ETH;
- address public constant LIDO_CRV_POOL =
- 0xDC24316b9AE028F1497c275EB9192a3Ea0f67022;
+ address ... | diff | 965 | // Code block 1 (diff):
contract WstEth is IDerivative, Initializable, OwnableUpgradeable {
- address public constant WST_ETH =
- 0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0;
+ address public immutable WST_ETH;
- address public constant LIDO_CRV_POOL =
- 0xDC24316b9AE028F1497c275EB9192a3Ea... | 1 | true | contract WstEth is IDerivative, Initializable, OwnableUpgradeable {
- address public constant WST_ETH =
- 0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0;
+ address public immutable WST_ETH;
- address public constant LIDO_CRV_POOL =
- 0xDC24316b9AE028F1497c275EB9192a3Ea0f67022;
+ address ... | WstEth.sol#L60, Reth.sol#L173-L174, SfrxEth.sol#L74-L75, SafEth.sol#L88 | SfrxEth.sol, Reth.sol, WstEth.sol, SafEth.sol | 4 | # `WstEth.setMaxSlippage(uint256)`, `Reth.setMaxSlippage(uint256)` and `Sfrx.setMaxSlippage(uint256)` should limit their inputs values to `1e18`
Given that `1e16` is 1%, then 100% would be `1e18`. Given that the slippage should never be greater than 100%.
This would DOS function withdraw/deposit in the different cont... | true | # `SafETH` Stuck ETH would be freeze forever
Current `SafETH` allows receiving ETH from anyone. In case that a user/contract mistakenly sent ETH to this `SafEth` or in case that `msg.value * weight < totalWeight` in [stake](https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/co... | true | true | 9 | ||
c4 | 05-ajna | descharre G | High | high | # Summary
|ID | Finding| Gas saved | Instances|
|:----: | :--- | :----: |:----: |
|G-01 |Do budget check at the end of the for loop| - | 1 |
|G-02 |Use constants instead of type(uintx).max| 20 | 1 |
|G-03 |Remove block.number from events| 20 | 2 |
|G-04 |Use double... | ## [G-02] Use constants instead of type(uintx).max
It's more gas efficiënt to use a constant instead of a max from a type. The constant won't be pretty if it's a high value but it will save around 20 gas everytime the function gets called.
[StandardFunding.sol#L659](https://github.com/code-423n4/2023-05-ajna/blob/main... | ## [G-03] Remove block.number from events
block.number is added by default to event information. Around 300 gas can be saved if you remove block.number when emitting events. | overflow | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/descharre-G.md | 2026-01-02T18:21:24.906494+00:00 | 0d232714fab676bf0839ced60279a81f0301b7925d7a18162fc2d12ccb3749e8 | 0 | 0 | 0 | 2 | false | false | false | false | medium | 0 | 0 | false | StandardFunding.sol#L421-L454, StandardFunding.sol#L659 | StandardFunding.sol | 2 | ## [G-02] Use constants instead of type(uintx).max
It's more gas efficiënt to use a constant instead of a max from a type. The constant won't be pretty if it's a high value but it will save around 20 gas everytime the function gets called.
[StandardFunding.sol#L659](https://github.com/code-423n4/2023-05-ajna/blob/main... | true | ## [G-03] Remove block.number from events
block.number is added by default to event information. Around 300 gas can be saved if you remove block.number when emitting events. | true | true | 6 | ||||||
c4 | 11-kelp | chaduke Q | Low | low | QA1. It might overwrite an existing key:
https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/LRTConfig.sol#L156-L163
Mitigation:
```diff
function _setToken(bytes32 key, address val) private {
UtilLib.checkNonZeroAddress(val);
- if (tokenMap[key] == val) {
+ ... | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/chaduke-Q.md | 2026-01-02T18:27:52.888706+00:00 | 0d3dc98c6313d97b49920774e80c3baad0796271838662dc7cf47175083e795e | 1 | 1 | 296 | 3 | true | true | true | false | medium | function _setToken(bytes32 key, address val) private {
UtilLib.checkNonZeroAddress(val);
- if (tokenMap[key] == val) {
+ if (tokenMap[key] != address(0)) {
revert ValueAlreadyInUse();
}
tokenMap[key] = val;
emit SetToken(key, val);
} | diff | 296 | // Code block 1 (diff):
function _setToken(bytes32 key, address val) private {
UtilLib.checkNonZeroAddress(val);
- if (tokenMap[key] == val) {
+ if (tokenMap[key] != address(0)) {
revert ValueAlreadyInUse();
}
tokenMap[key] = val;
emit SetToken(key, val);
} | 1 | true | function _setToken(bytes32 key, address val) private {
UtilLib.checkNonZeroAddress(val);
- if (tokenMap[key] == val) {
+ if (tokenMap[key] != address(0)) {
revert ValueAlreadyInUse();
}
tokenMap[key] = val;
emit SetToken(key, val);
} | LRTConfig.sol#L156-L163, LRTConfigRoleChecker.sol#L47-L50, LRTDepositPool.sol#L162-L176 | LRTConfig.sol, LRTDepositPool.sol, LRTConfigRoleChecker.sol | 3 | false | false | false | 7 | ||||||
c4 | 02-ethos | chrisdior4 Q | Critical | critical | # QA report
## Low Risk
| L-N |Issue|
|:------:|:----|
| [L‑01] | Single-step ownership transfer pattern is dangerous | 9 |
| [L‑02] | Decimals() not part of ERC20 standard | 1 |
| [L‑03] | Open TODO in the code | 2 |
| [L‑04] | Using vulnerable dependency of OpenZeppelin | 2 |
| [L ... | import "./Dependencies/Ownable.sol"; | uint256 decimals = IERC20(collateral).decimals(); | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/chrisdior4-Q.md | 2026-01-02T18:16:57.100264+00:00 | 0dca1dd483650c56cecf15b26615b1d927548ad21bec4be4015f46e6d3409f22 | 1 | 1 | 36 | 1 | false | false | true | false | high | import "./Dependencies/Ownable.sol"; | solidity | 36 | // Code block 1 (solidity):
import "./Dependencies/Ownable.sol"; | 1 | false | import "./Dependencies/Ownable.sol"; | CollateralConfig.sol#L6 | CollateralConfig.sol | 1 | import "./Dependencies/Ownable.sol"; | true | uint256 decimals = IERC20(collateral).decimals(); | true | true | 7 | ||
c4 | 09-ondo | lokacho G | Gas | gas | # Gas Report
## Summary
### Gas Optimizations
| | Issue | Instances |
| --- | --- | --- |
| [G‑01] | preRebaseTokenAmount & postRebaseTokenAmount are same | 1 |
Note: The table above as well as its gas numbers are created by considering the **automatic findings** which are not included.
---
## Gas Optimizations
... | uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | other | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/lokacho-G.md | 2026-01-02T18:26:03.231292+00:00 | 0dcd0fc95f02565ffab7b2e7846a823f7ffafd0bbd913c3e9735bdb4fc6d29cf | 2 | 2 | 126 | 2 | false | false | true | false | high | uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | solidity | 63 | // Code block 1 (solidity):
uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount);
// Code block 2 (solidity):
uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | 2 | false | uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount);
uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | rUSDY.sol#L586, rUSDY.sol#L592 | rUSDY.sol | 2 | uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | true | uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); | true | true | 6.71 | ||
c4 | 07-amphora | 8olidity Q | Unknown | unknown | ## The return value of AddressSet is not checked
In the EnumerableSet.AddressSet library, both success and failure of adding will have a return value. But all calls do not check the return value, even if the addition fails or the deletion fails. functions can be executed normally
```solidity
function add(AddressSet s... | function add(AddressSet storage set, address value) internal returns (bool) {
return _add(set._inner, bytes32(uint256(uint160(value))));
}
function remove(AddressSet storage set, address value) internal returns (bool) {
return _remove(set._inner, bytes32(uint256(uint160(value))));
} | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/8olidity-Q.md | 2026-01-02T18:23:21.520318+00:00 | 0dd007d576718fe2ac1e817b51d970c74c281a004a4cf5c3faa83f7eff1149ba | 2 | 1 | 933 | 0 | false | true | true | false | medium | function add(AddressSet storage set, address value) internal returns (bool) {
return _add(set._inner, bytes32(uint256(uint160(value))));
}
function remove(AddressSet storage set, address value) internal returns (bool) {
return _remove(set._inner, bytes32(uint256(uint160(value))));
} | solidity | 291 | // Code block 1 (solidity):
function add(AddressSet storage set, address value) internal returns (bool) {
return _add(set._inner, bytes32(uint256(uint160(value))));
}
function remove(AddressSet storage set, address value) internal returns (bool) {
return _remove(set._inner, bytes32(uint256(uint160(value))));
}
... | 2 | false | function add(AddressSet storage set, address value) internal returns (bool) {
return _add(set._inner, bytes32(uint256(uint160(value))));
}
function remove(AddressSet storage set, address value) internal returns (bool) {
return _remove(set._inner, bytes32(uint256(uint160(value))));
} | 0 | function add(AddressSet storage set, address value) internal returns (bool) {
return _add(set._inner, bytes32(uint256(uint160(value))));
}
function remove(AddressSet storage set, address value) internal returns (bool) {
return _remove(set._inner, bytes32(uint256(uint160(value))));
} | true | false | false | 5.67 | ||||||
c4 | 04-caviar | W0RR1O Q | Critical | critical | ## QA Report(low/non-critical)
[L-01] Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from uint256
================================================================================================================
In the function `buy()` and `sell()` of the contract `PrivatePo... | warning[2072]: Warning: Unused local variable.
--> test/PrivatePool/Quotes.t.sol:115:37:
|
115 | (uint256 returnedFeeAmount, uint256 protocolFeeAmount) = privatePool.changeFeeQuote(inputAmount);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ | oracle | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/W0RR1O-Q.md | 2026-01-02T18:20:11.726294+00:00 | 0df175301f8d1ed4b4916a9fb22663029a12038c3cdc12b55f7b1ff1595a7960 | 0 | 0 | 0 | 6 | false | true | false | false | medium | 0 | 0 | false | PrivatePool.sol#L211, PrivatePool.sol#L301, EthRouter.sol#L101, EthRouter.sol#L154, EthRouter.sol#L228, EthRouter.sol#L256 | EthRouter.sol, PrivatePool.sol | 6 | warning[2072]: Warning: Unused local variable.
--> test/PrivatePool/Quotes.t.sol:115:37:
|
115 | (uint256 returnedFeeAmount, uint256 protocolFeeAmount) = privatePool.changeFeeQuote(inputAmount);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ | true | false | false | 5 | ||||||||
c4 | 05-ajna | j4ld1na G | High | high | | | Issues | Instances |
| :--- | :---------------------------------------------------------------------------------------------- | --------: |
| G-01 | Default value initialization. ... | [ajna-core/src/PositionManager.sol#L364](https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/PositionManager.sol#L364)
| [ajna-core/src/PositionManager.sol#L474](https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/PositionManager.sol#L474)
| reentrancy | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/j4ld1na-G.md | 2026-01-02T18:21:31.297205+00:00 | 0e3d08cc2a79ef1bb4891e842ebfd4bfb56591948d4fdb42ad2dc160f8cfc741 | 2 | 0 | 84 | 3 | false | false | true | false | high | for (uint256 i = 0; i < indexesLength; ) { | java | 42 | // Code block 1 (java):
for (uint256 i = 0; i < indexesLength; ) {
// Code block 2 (java):
for (uint256 i = 0; i < indexesLength; ) { | 2 | false | PositionManager.sol#L181, PositionManager.sol#L364, PositionManager.sol#L474 | PositionManager.sol | 3 | [ajna-core/src/PositionManager.sol#L364](https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/PositionManager.sol#L364)
| true | [ajna-core/src/PositionManager.sol#L474](https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/PositionManager.sol#L474)
| true | true | 8 | |||
c4 | 01-ondo | yongskiws Q | Medium | medium | ### [LOW-1] require() should be used instead of assert()
``` solidity
File: cash\factory\CashFactory.sol
97: assert(cashProxyAdmin.owner() == guardian);
File: cash\factory\CashKYCSenderFactory.sol
106: assert(cashKYCSenderProxyAdmin.owner() == guardian);
File: cash\factory\CashKYCSenderReceiverFactory.sol
106... | ### [LOW-2] Lack of zero address check | ### [LOW-3] function onlyOwner doesn't have strict validation consider use multisig | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/yongskiws-Q.md | 2026-01-02T18:15:38.067469+00:00 | 0e576257b864b2b49a30668eeaf0f5a49d756b04b7be60a923f964ddc352bc00 | 2 | 0 | 121 | 0 | false | false | true | false | high | ### [LOW-2] Lack of zero address check | unknown | 38 | // Code block 1 (unknown):
### [LOW-2] Lack of zero address check
// Code block 2 (unknown):
### [LOW-3] function onlyOwner doesn't have strict validation consider use multisig | 2 | false | 0 | ### [LOW-2] Lack of zero address check | true | ### [LOW-3] function onlyOwner doesn't have strict validation consider use multisig | true | true | 7 | |||||
c4 | 01-biconomy | sorrynotsorry Q | Critical | critical | # QA (LOW & NON-CRITICAL)
## [L-01] Wrong visibility in SmartAccount contract
SmartAccount contract implements `mixedAuth` modifier to validate the caller is the `owner` OR the contract itself. The functions implementing this modifier have `external` visibility which the contract itself can't call due to visibility. ... | modifier mixedAuth {
require(msg.sender == owner || msg.sender == address(this),"Only owner or self");
_;
} | function deployCounterFactualWallet(address _owner, address _entryPoint, address _handler, uint _index) public returns(address proxy){
bytes32 salt = keccak256(abi.encodePacked(_owner, address(uint160(_index))));
bytes memory deploymentData = abi.encodePacked(type(Proxy).creationCode, uint(uint160(_... | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/sorrynotsorry-Q.md | 2026-01-02T18:14:12.793412+00:00 | 0e5d80742b2c831ae1cbd4f1c6b1e9061b4f0feadf32a0bd08b4f7f3796c1e5e | 1 | 1 | 126 | 4 | false | false | true | false | high | modifier mixedAuth {
require(msg.sender == owner || msg.sender == address(this),"Only owner or self");
_;
} | solidity | 126 | // Code block 1 (solidity):
modifier mixedAuth {
require(msg.sender == owner || msg.sender == address(this),"Only owner or self");
_;
} | 1 | false | modifier mixedAuth {
require(msg.sender == owner || msg.sender == address(this),"Only owner or self");
_;
} | SmartAccount.sol#L82-L85, SmartAccount.sol#L109, SmartAccount.sol#L120, SmartAccount.sol#L127 | SmartAccount.sol | 4 | modifier mixedAuth {
require(msg.sender == owner || msg.sender == address(this),"Only owner or self");
_;
} | true | function deployCounterFactualWallet(address _owner, address _entryPoint, address _handler, uint _index) public returns(address proxy){
bytes32 salt = keccak256(abi.encodePacked(_owner, address(uint160(_index))));
bytes memory deploymentData = abi.encodePacked(type(Proxy).creationCode, uint(uint160(_... | true | true | 7 | ||
c4 | 03-asymmetry | 0xhacksmithh Q | Critical | critical | ### [Low-01] User may lost his ```ETH``` due to precision loss
Inside ```stake()``` User deposited ```ETH``` sent to different derivative contracts according to their weights.
Now the amount of eth will sent to those each derivative contract is decided by following
```solidity
for (uint i = 0; i < derivativeCount; i++)... | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
......
...... | File: contracts/SafEth/SafEth.sol
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L84-L88 | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/0xhacksmithh-Q.md | 2026-01-02T18:17:42.712205+00:00 | 0eb7f185ec8b98fca87e46527b0783cf34fb1573d29ff572038631fcb4c29f3d | 2 | 1 | 414 | 5 | false | false | true | false | high | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
......
...... | solidity | 287 | // Code block 1 (solidity):
for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
......
......
// ... | 2 | false | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
......
...... | SafEth.sol#L84-L88, SafEth.sol#L2, Reth.sol#L2, SfrxEth.sol#L2, WstEth.sol#L2 | SfrxEth.sol, Reth.sol, WstEth.sol, SafEth.sol | 5 | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
......
...... | true | File: contracts/SafEth/SafEth.sol
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L84-L88 | true | true | 8 | ||
c4 | 03-asymmetry | Madalad Q | Critical | critical | # Low Summary
| |Issue|Instances|
|:-:|:-|:-:|
|[L-01]|Use two-step ownership transfers|4|
|[L-02]|Sanitise inputs for critical parameter changes|9|
|[L-03]|Use timelock for critical parameter changes|8|
Total Issues: 3
Total instances: 21
# Non-Critical Summary
| |Issue|Instances|
|:-:|:-|:-:|
|[N-01]|Use `i... | File: contracts/SafEth/derivatives/Reth.sol
19: contract Reth is IDerivative, Initializable, OwnableUpgradeable {
| File: contracts/SafEth/derivatives/WstEth.sol
12: contract WstEth is IDerivative, Initializable, OwnableUpgradeable {
| access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Madalad-Q.md | 2026-01-02T18:18:18.907776+00:00 | 0efb1a672e0530e4acf76d390d7bb383f481e75a4d3265e49a32d24514241d7e | 2 | 2 | 232 | 1 | false | false | true | false | high | File: contracts/SafEth/derivatives/Reth.sol
19: contract Reth is IDerivative, Initializable, OwnableUpgradeable { | solidity | 114 | // Code block 1 (solidity):
File: contracts/SafEth/derivatives/Reth.sol
19: contract Reth is IDerivative, Initializable, OwnableUpgradeable {
// Code block 2 (solidity):
File: contracts/SafEth/derivatives/WstEth.sol
12: contract WstEth is IDerivative, Initializable, OwnableUpgradeable { | 2 | false | File: contracts/SafEth/derivatives/Reth.sol
19: contract Reth is IDerivative, Initializable, OwnableUpgradeable {
File: contracts/SafEth/derivatives/WstEth.sol
12: contract WstEth is IDerivative, Initializable, OwnableUpgradeable { | Reth.sol#L19 | Reth.sol | 1 | File: contracts/SafEth/derivatives/Reth.sol
19: contract Reth is IDerivative, Initializable, OwnableUpgradeable {
| true | File: contracts/SafEth/derivatives/WstEth.sol
12: contract WstEth is IDerivative, Initializable, OwnableUpgradeable {
| true | true | 8 | ||
c4 | 01-biconomy | gz627 Q | Critical | critical | # QA Report
## Non-Critical Issues
C4 checked:
| | Issue | Instances |
| ---- |:----------------------------------------------------------- |:---------:|
| NC-1 | Emit event when receiving ETH | 1 |
| NC-2 | Missing check... | File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
event ReceivedETH(address indexed from, address indexed to, uint256 indexed amount);
receive() external payable {
emit ReceivedETH(msg.sender, address(this), msg.value);
}
| File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
477: function _call(address target, uint256 value, bytes memory data) internal {
478: (bool success, bytes memory result) = target.call{value : value}(data);
if (!success)... | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/gz627-Q.md | 2026-01-02T18:13:47.256399+00:00 | 0f4365af3e9ea5ef46744ee4112aa328ab0bd0cf23677464cc8334009301f539 | 2 | 2 | 769 | 2 | false | false | true | false | high | File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
event ReceivedETH(address indexed from, address indexed to, uint256 indexed amount);
receive() external payable {
emit ReceivedETH(msg.sender, address(this), msg.value);
} | solidity | 319 | // Code block 1 (solidity):
File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
event ReceivedETH(address indexed from, address indexed to, uint256 indexed amount);
receive() external payable {
emit ReceivedETH(msg.sender, addre... | 2 | false | File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
event ReceivedETH(address indexed from, address indexed to, uint256 indexed amount);
receive() external payable {
emit ReceivedETH(msg.sender, address(this), msg.value);
}
... | SmartAccount.sol, SmartAccount.sol#L477-L484 | SmartAccount.sol | 2 | File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
event ReceivedETH(address indexed from, address indexed to, uint256 indexed amount);
receive() external payable {
emit ReceivedETH(msg.sender, address(this), msg.value);
}
| true | File: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
477: function _call(address target, uint256 value, bytes memory data) internal {
478: (bool success, bytes memory result) = target.call{value : value}(data);
if (!success)... | true | true | 8 | ||
c4 | 06-lybra | dharma09 G | Low | low | **Table of contents**
- [The result of a function call should be cached rather than re-calling the function](#The-result-of-a-function-call-should-be-cached-rather-than-re-calling-the-function)
- [ProtocolRewardsPool.sol.notifyRewardAmount() : Results of `totalStaked()` should be cached](#protocolrewardspool.sol.n... | File: contracts/lybra/miner/ProtocolRewardsPool.sol
227: function notifyRewardAmount(uint amount, uint tokenType) external {
228: require(msg.sender == address(configurator));
229: if (totalStaked() == 0) return; //@audit: Initial call
230: require(amount > 0, "amount = 0");
231: if(tok... | # `EUSDMiningIncentives.sol.rewardPerToken()` : Result of `totalStaled()` should be cached
---
- https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/miner/EUSDMiningIncentives.sol#L163C4-L169C6
| access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/dharma09-G.md | 2026-01-02T18:22:55.676924+00:00 | 0f831cfeb0eef54b88b6007beda47dcf93769ad44a199ea3ee65fdd84c2cd08e | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | EUSDMiningIncentives.sol#L163-L4 | EUSDMiningIncentives.sol | 1 | File: contracts/lybra/miner/ProtocolRewardsPool.sol
227: function notifyRewardAmount(uint amount, uint tokenType) external {
228: require(msg.sender == address(configurator));
229: if (totalStaked() == 0) return; //@audit: Initial call
230: require(amount > 0, "amount = 0");
231: if(tok... | true | # `EUSDMiningIncentives.sol.rewardPerToken()` : Result of `totalStaled()` should be cached
---
- https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/miner/EUSDMiningIncentives.sol#L163C4-L169C6
| true | true | 6 | ||||||
c4 | 03-asymmetry | adriro G | Medium | medium | # `SafEth` contract:
- `derivatives[i].balance()` is called twice in the `stake` function. Consider caching the first result to avoid an extra call and read from storage.
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L73-L74
- `derivatives[i].balance()` is called twice in... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/adriro-G.md | 2026-01-02T18:18:44.082572+00:00 | 0fbc2b9ed60c3dc8607279370484926e11dbbd99556c48b1eb260c0e59a7e291 | 2 | 2 | 659 | 4 | true | true | true | false | medium | function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight
) external onlyOwner {
uint256 currentWeight = weights[_derivativeIndex];
weights[_derivativeIndex] = _weight;
totalWeight = totalWeight - currentWeight + _weight;
emit WeightChange(_derivativeIndex, _weight);
} | solidity | 316 | // Code block 1 (solidity):
function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight
) external onlyOwner {
uint256 currentWeight = weights[_derivativeIndex];
weights[_derivativeIndex] = _weight;
totalWeight = totalWeight - currentWeight + _weight;
emit WeightChange(_deriva... | 2 | false | function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight
) external onlyOwner {
uint256 currentWeight = weights[_derivativeIndex];
weights[_derivativeIndex] = _weight;
totalWeight = totalWeight - currentWeight + _weight;
emit WeightChange(_derivativeIndex, _weight);
}
fu... | SafEth.sol#L73-L74, SafEth.sol#L141-L142, SafEth.sol#L171-L173, SafEth.sol#L190-L193 | SafEth.sol | 4 | false | false | false | 6 | ||||||
c4 | 04-caviar | favelanky G | Medium | medium | ## [G-1] Move checks to the top
Checks, effects, interactions is a general best practice and can be applicable to more than just reentrancy concerns. When one of the following error scenarios applies, users pay gas for all statements executed up until the revert itself. By performing checks such as these as early as p... | File: /src/PrivatePool.sol
225: if (baseToken != address(0) && msg.value > 0) revert InvalidEthAmount();
| File: /src/PrivatePool.sol
277: if (royaltyFee > 0 && recipient != address(0)) {
if (baseToken != address(0)) {
ERC20(baseToken).safeTransfer(recipient, royaltyFee);
} else {
recipient.safeTransferETH(royaltyFee);
}
}
| reentrancy | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/favelanky-G.md | 2026-01-02T18:20:31.431302+00:00 | 0fbea96316726ea81e71d8eba375c38ae8e77706e0a0b3d693411884e163be35 | 3 | 3 | 487 | 3 | false | false | true | false | high | File: /src/PrivatePool.sol
225: if (baseToken != address(0) && msg.value > 0) revert InvalidEthAmount(); | solidity | 106 | // Code block 1 (solidity):
File: /src/PrivatePool.sol
225: if (baseToken != address(0) && msg.value > 0) revert InvalidEthAmount();
// Code block 2 (solidity):
File: /src/PrivatePool.sol
277: if (royaltyFee > 0 && recipient != address(0)) {
if (baseToken != address(0)) {
ERC20(baseToken).safeTransfer(rec... | 3 | false | File: /src/PrivatePool.sol
225: if (baseToken != address(0) && msg.value > 0) revert InvalidEthAmount();
File: /src/PrivatePool.sol
277: if (royaltyFee > 0 && recipient != address(0)) {
if (baseToken != address(0)) {
ERC20(baseToken).safeTransfer(recipient, royaltyFee);
} else {
recipient.safeTrans... | PrivatePool.sol#L225, PrivatePool.sol#L277-L283, Factory.sol#L87 | PrivatePool.sol, Factory.sol | 3 | File: /src/PrivatePool.sol
225: if (baseToken != address(0) && msg.value > 0) revert InvalidEthAmount();
| true | File: /src/PrivatePool.sol
277: if (royaltyFee > 0 && recipient != address(0)) {
if (baseToken != address(0)) {
ERC20(baseToken).safeTransfer(recipient, royaltyFee);
} else {
recipient.safeTransferETH(royaltyFee);
}
}
| true | true | 9 | ||
c4 | 01-ondo | ch0bu Q | Low | low | ## 1. Use a more recent version of Solidity, and avoid floating pragma statements
- Use a solidity version of at least 0.8.4 to get `bytes.concat()` instead of `abi.encodePacked(<bytes>,<bytes>)`
- Use a solidity version of at least 0.8.12 to get `string.concat()` instead of `abi.encodePacked(<str>,<str>)`
- Use a so... | require(msg.sender == admin, "Only admin can set KYC registry"); | 97 assert(cashProxyAdmin.owner() == guardian); | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/ch0bu-Q.md | 2026-01-02T18:14:59.172389+00:00 | 0fde033259f3c8405d43966c59739b9c45a063bf0576e28be5f310df06b7711e | 1 | 0 | 64 | 2 | false | false | true | false | high | require(msg.sender == admin, "Only admin can set KYC registry"); | unknown | 64 | // Code block 1 (unknown):
require(msg.sender == admin, "Only admin can set KYC registry"); | 1 | false | cErc20ModifiedDelegator.sol, JumpRateModelV2.sol | JumpRateModelV2.sol, cErc20ModifiedDelegator.sol | 2 | require(msg.sender == admin, "Only admin can set KYC registry"); | true | 97 assert(cashProxyAdmin.owner() == guardian); | true | true | 7 | |||
c4 | 01-ondo | 0xjuicer G | Low | low | ## Gas - Creating a old variable isn't necessary.
The following pathern can be seen in multiples places in the code.
```solidity
uint256 oldPriceCap = fTokenToUnderlyingPriceCap[fToken];
fTokenToUnderlyingPriceCap[fToken] = value;
emit PriceCapSet(fToken, oldPriceCap, value);
```
It can be replaced by:
... | uint256 oldPriceCap = fTokenToUnderlyingPriceCap[fToken];
fTokenToUnderlyingPriceCap[fToken] = value;
emit PriceCapSet(fToken, oldPriceCap, value); | emit PriceCapSet(fToken, fTokenToUnderlyingPriceCap[fToken], value);
fTokenToUnderlyingPriceCap[fToken] = value; | oracle | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/0xjuicer-G.md | 2026-01-02T18:14:22.989020+00:00 | 0fe6d27ec226f870aefcb9f09b5b0a7608b6d6df74632454588475c8fc915e1a | 2 | 2 | 271 | 1 | false | false | true | false | high | uint256 oldPriceCap = fTokenToUnderlyingPriceCap[fToken];
fTokenToUnderlyingPriceCap[fToken] = value;
emit PriceCapSet(fToken, oldPriceCap, value); | solidity | 155 | // Code block 1 (solidity):
uint256 oldPriceCap = fTokenToUnderlyingPriceCap[fToken];
fTokenToUnderlyingPriceCap[fToken] = value;
emit PriceCapSet(fToken, oldPriceCap, value);
// Code block 2 (solidity):
emit PriceCapSet(fToken, fTokenToUnderlyingPriceCap[fToken], value);
fTokenToUnderlyingPriceCap[fToken]... | 2 | false | uint256 oldPriceCap = fTokenToUnderlyingPriceCap[fToken];
fTokenToUnderlyingPriceCap[fToken] = value;
emit PriceCapSet(fToken, oldPriceCap, value);
emit PriceCapSet(fToken, fTokenToUnderlyingPriceCap[fToken], value);
fTokenToUnderlyingPriceCap[fToken] = value; | CashManager.sol#L708-L709 | CashManager.sol | 1 | uint256 oldPriceCap = fTokenToUnderlyingPriceCap[fToken];
fTokenToUnderlyingPriceCap[fToken] = value;
emit PriceCapSet(fToken, oldPriceCap, value); | true | emit PriceCapSet(fToken, fTokenToUnderlyingPriceCap[fToken], value);
fTokenToUnderlyingPriceCap[fToken] = value; | true | true | 7.04 | ||
c4 | 07-amphora | BRONZEDISC Q | Medium | medium | ## QA
---
### Layout Order [1]
- The best-practices for layout within a contract is the following order: state variables, events, modifiers, constructor and functions.
https://github.com/code-423n4/2023-07-amphora/blob/main/core/solidity/contracts/governance/GovernorCharlie.sol
```solidity
// place this modifier be... | // place this modifier before the constructor
106: modifier onlyGov() { | // place this internal function after all the others
19: function _setUnderlying(address _underlying) internal { | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/BRONZEDISC-Q.md | 2026-01-02T18:23:22.847922+00:00 | 0fe7e691e9283f2582644aa6ac568318bf423e6ebd537b13aee6d095d74d138c | 5 | 5 | 519 | 6 | false | false | true | false | high | // place this modifier before the constructor
106: modifier onlyGov() { | solidity | 72 | // Code block 1 (solidity):
// place this modifier before the constructor
106: modifier onlyGov() {
// Code block 2 (solidity):
// place this internal function after all the others
19: function _setUnderlying(address _underlying) internal {
// Code block 3 (solidity):
// place this external function right after the... | 5 | false | // place this modifier before the constructor
106: modifier onlyGov() {
// place this internal function after all the others
19: function _setUnderlying(address _underlying) internal {
// place this external function right after the constructor
40: function isStale() external view returns (bool _stale) {
// place... | GovernorCharlie.sol, OracleRelay.sol, ChainlinkTokenOracleRelay.sol, EthSafeStableCurveOracle.sol, CTokenOracle.sol, ChainlinkOracleRelay.sol | EthSafeStableCurveOracle.sol, GovernorCharlie.sol, ChainlinkTokenOracleRelay.sol, OracleRelay.sol, ChainlinkOracleRelay.sol, CTokenOracle.sol | 6 | // place this modifier before the constructor
106: modifier onlyGov() { | true | // place this internal function after all the others
19: function _setUnderlying(address _underlying) internal { | true | true | 11 | ||
c4 | 10-badger | oualidpro G | High | high | ## Summary
### Gas Optimizations
| |Issue|Instances|Total Gas Saved|
|-|:-|:-:|:-:|
| [[GAS‑1](#gas1-multiple-accesses-of-a-mapping-array-should-use-a-local-variable-cache)] | Multiple accesses of a mapping/array should use a local variable cache | 4 | 168 |
| [[GAS‑2](#gas2-use-assembly-to-calculate-h... | File: packages/contracts/contracts/CdpManagerStorage.sol
// @audit Cdps[_cdpId]
272: Cdps[_cdpId].coll = 0;
| File: packages/contracts/contracts/Dependencies/RolesAuthority.sol
// @audit capabilityFlag[target]
98: capabilityFlag[target][functionSig] = CapabilityFlag.None;
// @audit getRolesWithCapability[target]
113: getRolesWithCapability[target][functionSig] |= bytes32(1 << role);
// @audit enabled... | reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/oualidpro-G.md | 2026-01-02T18:26:58.772441+00:00 | 0fec0bed9107f419be85db233875382f0043e3a5e598393f438c340abc4d4a1c | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: packages/contracts/contracts/CdpManagerStorage.sol
// @audit Cdps[_cdpId]
272: Cdps[_cdpId].coll = 0;
| true | File: packages/contracts/contracts/Dependencies/RolesAuthority.sol
// @audit capabilityFlag[target]
98: capabilityFlag[target][functionSig] = CapabilityFlag.None;
// @audit getRolesWithCapability[target]
113: getRolesWithCapability[target][functionSig] |= bytes32(1 << role);
// @audit enabled... | true | true | 5 | ||||||||
c4 | 10-badger | naszam G | Medium | medium | # Gas Optimization: consider removing redundant checks in SortedCdps.reInsert()
**Context:** [SortedCdps.sol#L506-L508](https://github.com/code-423n4/2023-10-badger/blob/main/packages/contracts/contracts/SortedCdps.sol#L506-L508)
**Description:**
`reInsert` currently uses a check to ensure `contains(_id)` (the List c... | - Tests PASS
`yarn && forge build && forge test`
`Ran 39 test suites: 229 tests passed, 0 failed, 0 skipped (229 total tests)`
`yarn test` | - Gas Report:
**Before** | other | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/naszam-G.md | 2026-01-02T18:26:56.937559+00:00 | 103b6781281c9749ad61311d93dd7a416d37fff7e94d3f59b5e8766cf0dc2235 | 2 | 1 | 710 | 1 | false | false | true | false | high | diff --git a/packages/contracts/contracts/SortedCdps.sol b/packages/contracts/contracts/SortedCdps.sol
index 0fd34e7..1e3b413 100644
--- a/packages/contracts/contracts/SortedCdps.sol
+++ b/packages/contracts/contracts/SortedCdps.sol
@@ -502,10 +502,6 @@ contract SortedCdps is ISortedCdps {
bytes32 _nextId
... | diff | 661 | // Code block 1 (diff):
diff --git a/packages/contracts/contracts/SortedCdps.sol b/packages/contracts/contracts/SortedCdps.sol
index 0fd34e7..1e3b413 100644
--- a/packages/contracts/contracts/SortedCdps.sol
+++ b/packages/contracts/contracts/SortedCdps.sol
@@ -502,10 +502,6 @@ contract SortedCdps is ISortedCdps {
... | 2 | true | diff --git a/packages/contracts/contracts/SortedCdps.sol b/packages/contracts/contracts/SortedCdps.sol
index 0fd34e7..1e3b413 100644
--- a/packages/contracts/contracts/SortedCdps.sol
+++ b/packages/contracts/contracts/SortedCdps.sol
@@ -502,10 +502,6 @@ contract SortedCdps is ISortedCdps {
bytes32 _nextId
... | SortedCdps.sol#L506-L508 | SortedCdps.sol | 1 | - Tests PASS
`yarn && forge build && forge test`
`Ran 39 test suites: 229 tests passed, 0 failed, 0 skipped (229 total tests)`
`yarn test` | true | - Gas Report:
**Before** | true | true | 10 | ||
c4 | 02-ethos | btk Q | Critical | critical | | Total Low issues |
|------------------|
| Risk | Issues Details | Number |
|--------|-----------------------------------------------------------------------------------------|---------------|
| [L-01] | Low level calls with solidity ve... | function _chainID() private pure returns (uint256 chainID) {
assembly {
chainID := chainid()
}
} | /**
* @dev This empty reserved space is put in place to allow future versions to add new
* variables without shifting down storage in the inheritance chain.
* See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps
*/
uint256[50] private __gap; | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/btk-Q.md | 2026-01-02T18:16:53.080775+00:00 | 106b2f95e9e1bc1f000e6b9e09ae647363484e583057895121a16b98e5377a9e | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function _chainID() private pure returns (uint256 chainID) {
assembly {
chainID := chainid()
}
} | true | /**
* @dev This empty reserved space is put in place to allow future versions to add new
* variables without shifting down storage in the inheritance chain.
* See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps
*/
uint256[50] private __gap; | true | true | 5 | ||||||||
c4 | 07-amphora | VIELITE Q | Unknown | unknown | Repeated or Identical functions in the `WUSDA.sol` contract
```solidity
function burnAll() external override returns (uint256 _usdaAmount) {
uint256 _wusdaAmount = balanceOf(_msgSender());
_usdaAmount = _wUSDAToUSDA(_wusdaAmount, _usdaSupply());
_withdraw(_msgSender(), _msgSender(), _usdaAmount, _wusdaAmo... | function burnAll() external override returns (uint256 _usdaAmount) {
uint256 _wusdaAmount = balanceOf(_msgSender());
_usdaAmount = _wUSDAToUSDA(_wusdaAmount, _usdaSupply());
_withdraw(_msgSender(), _msgSender(), _usdaAmount, _wusdaAmount);
}
function withdrawAll() external override returns (uint256 _wus... | other | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/VIELITE-Q.md | 2026-01-02T18:23:38.107091+00:00 | 108acbd03817a499b50ee26931507133deb7e8f62739eb1d922f4be95f2c659b | 1 | 1 | 518 | 0 | false | true | true | false | medium | function burnAll() external override returns (uint256 _usdaAmount) {
uint256 _wusdaAmount = balanceOf(_msgSender());
_usdaAmount = _wUSDAToUSDA(_wusdaAmount, _usdaSupply());
_withdraw(_msgSender(), _msgSender(), _usdaAmount, _wusdaAmount);
}
function withdrawAll() external override returns (uint256 _wus... | solidity | 518 | // Code block 1 (solidity):
function burnAll() external override returns (uint256 _usdaAmount) {
uint256 _wusdaAmount = balanceOf(_msgSender());
_usdaAmount = _wUSDAToUSDA(_wusdaAmount, _usdaSupply());
_withdraw(_msgSender(), _msgSender(), _usdaAmount, _wusdaAmount);
}
function withdrawAll() external ov... | 1 | false | function burnAll() external override returns (uint256 _usdaAmount) {
uint256 _wusdaAmount = balanceOf(_msgSender());
_usdaAmount = _wUSDAToUSDA(_wusdaAmount, _usdaSupply());
_withdraw(_msgSender(), _msgSender(), _usdaAmount, _wusdaAmount);
}
function withdrawAll() external override returns (uint256 _wus... | 0 | function burnAll() external override returns (uint256 _usdaAmount) {
uint256 _wusdaAmount = balanceOf(_msgSender());
_usdaAmount = _wUSDAToUSDA(_wusdaAmount, _usdaSupply());
_withdraw(_msgSender(), _msgSender(), _usdaAmount, _wusdaAmount);
}
function withdrawAll() external override returns (uint256 _wus... | true | false | false | 3.3 | ||||||
c4 | 08-dopex | Baki G | Low | low | ## G-01 Calculate minOut only if minAmount == 0
## Details
https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/core/RdpxV2Core.sol#L545
If `minAmount` is > 0 , then we should not calculate `minOut` as it is a gas wastage.
so instead what we can do is
```solidity
... | if (minAmount == 0) {
minAmount = _ethToDpxEth
? (((_amount * getDpxEthPrice()) / 1e8) -
(((_amount * getDpxEthPrice()) * slippageTolerance) / 1e16))
: (((_amount * getEthPrice()) / 1e8) -
(((_amount * getEthPrice()) * slippageTolerance) / 1e16));
}
// Swap the tokens
a... | if (putOptionsRequired) {
uint256 timeToExpiry = IPerpetualAtlanticVault(
addresses.perpetualAtlanticVault
).nextFundingPaymentTimestamp() - block.timestamp;
uint256 strike = IPerpetualAtlanticVault(addresses.perpetualAtlanticVault)
.roundUp(rdpxPrice - (rdpxPrice / 4)); // 25% below ... | slippage | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Baki-G.md | 2026-01-02T18:24:31.727654+00:00 | 108c1b397cca143de7d705646a57b06695f823de528332994e27bfe620f540bd | 2 | 2 | 996 | 4 | false | false | true | false | high | if (minAmount == 0) {
minAmount = _ethToDpxEth
? (((_amount * getDpxEthPrice()) / 1e8) -
(((_amount * getDpxEthPrice()) * slippageTolerance) / 1e16))
: (((_amount * getEthPrice()) / 1e8) -
(((_amount * getEthPrice()) * slippageTolerance) / 1e16));
}
// Swap the tokens
amoun... | solidity | 510 | // Code block 1 (solidity):
if (minAmount == 0) {
minAmount = _ethToDpxEth
? (((_amount * getDpxEthPrice()) / 1e8) -
(((_amount * getDpxEthPrice()) * slippageTolerance) / 1e16))
: (((_amount * getEthPrice()) / 1e8) -
(((_amount * getEthPrice()) * slippageTolerance) / 1e16));
}
... | 2 | false | if (minAmount == 0) {
minAmount = _ethToDpxEth
? (((_amount * getDpxEthPrice()) / 1e8) -
(((_amount * getDpxEthPrice()) * slippageTolerance) / 1e16))
: (((_amount * getEthPrice()) / 1e8) -
(((_amount * getEthPrice()) * slippageTolerance) / 1e16));
}
// Swap the tokens
amoun... | RdpxV2Core.sol#L545, RdpxV2Core.sol#L1189, UniV2LiquidityAmo.sol#L54, IRdpxV2Core.sol#L45 | RdpxV2Core.sol, IRdpxV2Core.sol, UniV2LiquidityAmo.sol | 4 | if (minAmount == 0) {
minAmount = _ethToDpxEth
? (((_amount * getDpxEthPrice()) / 1e8) -
(((_amount * getDpxEthPrice()) * slippageTolerance) / 1e16))
: (((_amount * getEthPrice()) / 1e8) -
(((_amount * getEthPrice()) * slippageTolerance) / 1e16));
}
// Swap the tokens
a... | true | if (putOptionsRequired) {
uint256 timeToExpiry = IPerpetualAtlanticVault(
addresses.perpetualAtlanticVault
).nextFundingPaymentTimestamp() - block.timestamp;
uint256 strike = IPerpetualAtlanticVault(addresses.perpetualAtlanticVault)
.roundUp(rdpxPrice - (rdpxPrice / 4)); // 25% below ... | true | true | 8 | ||
c4 | 02-ai-arena | MrPotatoMagic Q | Critical | critical | # Quality Assurance
| ID | Issues |
|--------|------------------------------------------------------------------------------------------------------------------------------------------... | File: VoltageManager.sol
109: function spendVoltage(address spender, uint8 voltageSpent) public {
110: require(spender == msg.sender || allowedVoltageSpenders[msg.sender]);
111: if (ownerVoltageReplenishTime[spender] <= block.timestamp) {
112: _replenishVoltage(spender);
113: }
1... | File: Neuron.sol
147: function claim(uint256 amount) external {
148:
149: require(
150: allowance(treasuryAddress, msg.sender) >= amount,
151: "ERC20: claim amount exceeds allowance"
152: );
153:
154: transferFrom(treasuryAddress, msg.sender, amount... | access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/MrPotatoMagic-Q.md | 2026-01-02T19:02:35.392532+00:00 | 1091cd3c8621e2abcc601354dec4c9e857e353d49cd2039e8ffe336b630a02e5 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: VoltageManager.sol
109: function spendVoltage(address spender, uint8 voltageSpent) public {
110: require(spender == msg.sender || allowedVoltageSpenders[msg.sender]);
111: if (ownerVoltageReplenishTime[spender] <= block.timestamp) {
112: _replenishVoltage(spender);
113: }
1... | true | File: Neuron.sol
147: function claim(uint256 amount) external {
148:
149: require(
150: allowance(treasuryAddress, msg.sender) >= amount,
151: "ERC20: claim amount exceeds allowance"
152: );
153:
154: transferFrom(treasuryAddress, msg.sender, amount... | true | true | 5 | ||||||||
c4 | 01-biconomy | darkbluedot Q | High | high | Quality Assurance -
Simple Account -
1 - The function call in the modifier is not necessary, we can also use this in the modifier and achieve the same results. The use of the modifier is suggested as that makes the code clean and readable. Also, it saves some gas on the way as well. So, instead of writing the modi... | modifier onlyOwner(){
require(msg.sender == address(this) || owner == msg.sender , "Only Owner");
_;
} | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/darkbluedot-Q.md | 2026-01-02T18:13:41.409895+00:00 | 109630da12da0fbf8a7ab5d62391fd5c0bf9d8cc6652296ebc0732e8e94c479a | 1 | 0 | 123 | 0 | false | true | true | false | medium | modifier onlyOwner(){
require(msg.sender == address(this) || owner == msg.sender , "Only Owner");
_;
} | unknown | 123 | // Code block 1 (unknown):
modifier onlyOwner(){
require(msg.sender == address(this) || owner == msg.sender , "Only Owner");
_;
} | 1 | false | 0 | modifier onlyOwner(){
require(msg.sender == address(this) || owner == msg.sender , "Only Owner");
_;
} | true | false | false | 4.09 | |||||||
c4 | 03-asymmetry | Shubham G | Medium | medium | ## Gas Optimizations
| |Issue|Instances|
|-|:-|:-:|
| [GAS-01](#GAS-01) | With assembly, `.call (bool sent)` transfer can be done to optimize gas | 5 |
| [GAS-02](#GAS-02) | Setting the constructor to `payable`| 4 |
| [GAS-03](#GAS-03) | Make for loop unchecked | 7 |
| [GAS-04](#GAS-04) | Unnecessary check in `if` co... | File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/Reth.sol
60: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
); | File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/SfrxEth.sol
84: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
);
| access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Shubham-G.md | 2026-01-02T18:18:34.170445+00:00 | 10d9bbbaa9aa855a81f689b4aa57fa4913893d71b705d329de061e884d029755 | 2 | 2 | 366 | 0 | false | false | true | false | high | File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/Reth.sol
60: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
); | solidity | 181 | // Code block 1 (solidity):
File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/Reth.sol
60: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
);
// Code block 2 (solidity):
File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/SfrxEth.sol
84: ... | 2 | false | File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/Reth.sol
60: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
);
File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/SfrxEth.sol
84: (bool sent, ) = address(msg.sender).call{value: a... | 0 | File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/Reth.sol
60: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
); | true | File: 2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/SfrxEth.sol
84: (bool sent, ) = address(msg.sender).call{value: address(this).balance}(
""
);
| true | true | 7 | ||||
c4 | 03-revert-lend | dharma09 G | High | high |
## REVRT LEND GAS OPTIMIZATIONS
## INTRODUCTION
Highlighted below are optimizations exclusively targeting state-mutating functions and view/pure functions invoked by state-mutating functions. In the discussion that follows, only runtime gas is emphasized, given its inevitable dominance over deployment gas costs thro... | File: src/V3Oracle.sol
25: uint16 public constant MIN_PRICE_DIFFERENCE = 200; //2% /@audit pack
uint256 private constant Q96 = 2 ** 96;
uint256 private constant Q128 = 2 ** 128; | ### Instances 2
We can re-arrange the order of V3vault.sol to save 1 storage slot (~2000 Gas) pack emergencyAdmin address with MIN_RESERVE_PROTECTION_FACTOR_X32address
### Proof of Code
- [V3Vault.sol#L167](https://github.com/code-423n4/2024-03-revert-lend/blob/main/src/V3Vault.sol#L167) | reentrancy | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/dharma09-G.md | 2026-01-02T19:03:10.495436+00:00 | 113730268553a5bc5e1bd6b5f1592d2d89fdaaed97e43a5a16cbc943d1342c48 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | V3Vault.sol#L167 | V3Vault.sol | 1 | File: src/V3Oracle.sol
25: uint16 public constant MIN_PRICE_DIFFERENCE = 200; //2% /@audit pack
uint256 private constant Q96 = 2 ** 96;
uint256 private constant Q128 = 2 ** 128; | true | ### Instances 2
We can re-arrange the order of V3vault.sol to save 1 storage slot (~2000 Gas) pack emergencyAdmin address with MIN_RESERVE_PROTECTION_FACTOR_X32address
### Proof of Code
- [V3Vault.sol#L167](https://github.com/code-423n4/2024-03-revert-lend/blob/main/src/V3Vault.sol#L167) | true | true | 6 | ||||||
c4 | 09-ondo | Raihan Q | Critical | critical | # [L-01] Reentrancy Vulnerability in DestinationBridge._mintIfThresholdMet Function
The function _mintIfThresholdMet(bytes32) in the DestinationBridge contract is vulnerable to a reentrancy attack. This is due to external calls being made before state variables are updated.
Details
The _mintIfThresholdMet(bytes32) fu... | 337: function _mintIfThresholdMet(bytes32 txnHash) internal {
338: bool thresholdMet = _checkThresholdMet(txnHash);
339: Transaction memory txn = txnHashToTransaction[txnHash];
340: if (thresholdMet) {
341: _checkAndUpdateInstantMintLimit(txn.amount);
342: if (!ALLOWLIST.isAllowed(txn.sender... | 60: constructor(
61: address _token,
62: address _axelarGateway,
63: address _allowlist,
64: address _ondoApprover,
65: address _owner,
66: uint256 _mintLimit,
67: uint256 _mintDuration
68: ) | reentrancy | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/Raihan-Q.md | 2026-01-02T18:25:38.538962+00:00 | 113a2fab6363a79e7dd331b8db7cdd06e743d940d56e7dd107fa1bd93c69d4aa | 1 | 1 | 691 | 1 | false | false | true | false | high | 337: function _mintIfThresholdMet(bytes32 txnHash) internal {
338: bool thresholdMet = _checkThresholdMet(txnHash);
339: Transaction memory txn = txnHashToTransaction[txnHash];
340: if (thresholdMet) {
341: _checkAndUpdateInstantMintLimit(txn.amount);
342: if (!ALLOWLIST.isAllowed(txn.sender... | solidity | 691 | // Code block 1 (solidity):
337: function _mintIfThresholdMet(bytes32 txnHash) internal {
338: bool thresholdMet = _checkThresholdMet(txnHash);
339: Transaction memory txn = txnHashToTransaction[txnHash];
340: if (thresholdMet) {
341: _checkAndUpdateInstantMintLimit(txn.amount);
342: if (!AL... | 1 | false | 337: function _mintIfThresholdMet(bytes32 txnHash) internal {
338: bool thresholdMet = _checkThresholdMet(txnHash);
339: Transaction memory txn = txnHashToTransaction[txnHash];
340: if (thresholdMet) {
341: _checkAndUpdateInstantMintLimit(txn.amount);
342: if (!ALLOWLIST.isAllowed(txn.sender... | DestinationBridge.sol#L337-L353 | DestinationBridge.sol | 1 | 337: function _mintIfThresholdMet(bytes32 txnHash) internal {
338: bool thresholdMet = _checkThresholdMet(txnHash);
339: Transaction memory txn = txnHashToTransaction[txnHash];
340: if (thresholdMet) {
341: _checkAndUpdateInstantMintLimit(txn.amount);
342: if (!ALLOWLIST.isAllowed(txn.sender... | true | 60: constructor(
61: address _token,
62: address _axelarGateway,
63: address _allowlist,
64: address _ondoApprover,
65: address _owner,
66: uint256 _mintLimit,
67: uint256 _mintDuration
68: ) | true | true | 7 | ||
c4 | 06-lybra | Co0nan Q | QA | qa | 1. setPools will reset the pools array if it's called with an empty array.
https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/miner/EUSDMiningIncentives.sol#L93
```
function setPools(address[] memory _pools) external onlyOwner {
for (uint i = 0; i < _pools.length; i++) {
require(... | function setPools(address[] memory _pools) external onlyOwner {
for (uint i = 0; i < _pools.length; i++) {
require(configurator.mintVault(_pools[i]), "NOT_VAULT");
}
//@audit-qa if the function called with 0 array length. it will resetr the pools. Must check it's > 0
pools =... | function notifyRewardAmount(uint amount, uint tokenType) external { // @audit-qa bot can fornt-run and stake large amount to before ditrbuiteRewards
require(msg.sender == address(configurator));
if (totalStaked() == 0) return;
require(amount > 0, "amount = 0");
if(tokenType == 0) {
... | access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/Co0nan-Q.md | 2026-01-02T18:22:14.682050+00:00 | 11661a22d3530ff85facc514241b542078de293f24f6d78ee397ced648748331 | 2 | 0 | 1,164 | 3 | false | false | true | false | high | function setPools(address[] memory _pools) external onlyOwner {
for (uint i = 0; i < _pools.length; i++) {
require(configurator.mintVault(_pools[i]), "NOT_VAULT");
}
//@audit-qa if the function called with 0 array length. it will resetr the pools. Must check it's > 0
pools = ... | unknown | 333 | // Code block 1 (unknown):
function setPools(address[] memory _pools) external onlyOwner {
for (uint i = 0; i < _pools.length; i++) {
require(configurator.mintVault(_pools[i]), "NOT_VAULT");
}
//@audit-qa if the function called with 0 array length. it will resetr the pools. Must chec... | 2 | false | EUSDMiningIncentives.sol#L93, ProtocolRewardsPool.sol#L227, PeUSDMainnetStableVision.sol#L129 | EUSDMiningIncentives.sol, ProtocolRewardsPool.sol, PeUSDMainnetStableVision.sol | 3 | function setPools(address[] memory _pools) external onlyOwner {
for (uint i = 0; i < _pools.length; i++) {
require(configurator.mintVault(_pools[i]), "NOT_VAULT");
}
//@audit-qa if the function called with 0 array length. it will resetr the pools. Must check it's > 0
pools =... | true | function notifyRewardAmount(uint amount, uint tokenType) external { // @audit-qa bot can fornt-run and stake large amount to before ditrbuiteRewards
require(msg.sender == address(configurator));
if (totalStaked() == 0) return;
require(amount > 0, "amount = 0");
if(tokenType == 0) {
... | true | true | 8 | |||
c4 | 10-badger | petrichor G | High | high | # GAS OPTIMIZATION
# SUMMARY
| | issue | instance |
|------|---------|------------|
|[G‑01]|Optimize External Calls with Assembly for Memory Efficiency|115|
|[G‑02]|Use assembly to validate msg.sender |22|
|[G‑03]|Avoid contract existence checks by using low level calls|19|
|[G‑04]| >= costs less gas than >|1... | File: packages/contracts/contracts/HintHelpers.sol
72 vars.currentCdpId = sortedCdps.getPrev(vars.currentCdpId);
vars.currentCdpUser = sortedCdps.getOwnerAddress(vars.currentCdpId);
90 uint256 currentCdpDebt = cdpManager.getSyncedCdpDebt(vars.currentCdpId);
116 vars.curren... | File: packages/contracts/contracts/LeverageMacroBase.sol
143 initialCdpIndex = sortedCdps.cdpCountOf(address(this));
148 IERC3156FlashLender(address(borrowerOperations)).flashLoan(
155 IERC3156FlashLender(address(activePool)).flashLoan(
173 bytes32 cdpId = sortedCdps.cdpOfOwnerByIndex(address(this), initialCdpI... | reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/petrichor-G.md | 2026-01-02T18:27:00.364171+00:00 | 1187e7c17f4ffb735af673a8c2314cc3e9dcc29bf5cb5cc280a6c76752a6dff6 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: packages/contracts/contracts/HintHelpers.sol
72 vars.currentCdpId = sortedCdps.getPrev(vars.currentCdpId);
vars.currentCdpUser = sortedCdps.getOwnerAddress(vars.currentCdpId);
90 uint256 currentCdpDebt = cdpManager.getSyncedCdpDebt(vars.currentCdpId);
116 vars.curren... | true | File: packages/contracts/contracts/LeverageMacroBase.sol
143 initialCdpIndex = sortedCdps.cdpCountOf(address(this));
148 IERC3156FlashLender(address(borrowerOperations)).flashLoan(
155 IERC3156FlashLender(address(activePool)).flashLoan(
173 bytes32 cdpId = sortedCdps.cdpOfOwnerByIndex(address(this), initialCdpI... | true | true | 5 | ||||||||
c4 | 01-salty | Sathish9098 Analysis | Critical | critical | # Salty.IO Analysis
## Overview
Salty.IO is a Decentralized Exchange (DEX) built on the Ethereum blockchain, featuring an innovative Automatic Atomic Arbitrage (AAA) mechanism. This mechanism seeks to capitalize on market inefficiencies during token swaps, generating profits which are then distributed among liquidity ... | function changeBootstrappingRewards(bool increase) external onlyOwner
function changePercentPolRewardsBurned(bool increase) external onlyOwner
function changeBaseBallotQuorumPercent(bool increase) external onlyOwner
function changeBallotDuration(bool increase) external onlyOwner
function changeRequiredProposalPercentSt... | function step1() public onlySameContract
function step2(address receiver) public onlySameContract
function step3() public onlySameContract
function step4() public onlySameContract
function step5() public onlySameContract
function step6() public onlySameContract
function step7() public onlySameContract
function step8() ... | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/Sathish9098-Analysis.md | 2026-01-02T19:01:29.108624+00:00 | 119c485f249bcb472941212acb912d7a33b39f8b4fc5ebeddf473e7c27504414 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function changeBootstrappingRewards(bool increase) external onlyOwner
function changePercentPolRewardsBurned(bool increase) external onlyOwner
function changeBaseBallotQuorumPercent(bool increase) external onlyOwner
function changeBallotDuration(bool increase) external onlyOwner
function changeRequiredProposalPercentSt... | true | function step1() public onlySameContract
function step2(address receiver) public onlySameContract
function step3() public onlySameContract
function step4() public onlySameContract
function step5() public onlySameContract
function step6() public onlySameContract
function step7() public onlySameContract
function step8() ... | true | true | 5 | ||||||||
c4 | 07-amphora | twcctop Q | Unknown | unknown | https://github.com/code-423n4/2023-07-amphora/blob/5d1cea9410db5448760c834f001af04a72edf3e0/core/solidity/contracts/core/VaultController.sol#L561
```solidity
if (_isUSDA) {
// now send usda to the target, equal to the amount they are owed
usda.vaultControllerMint(_target, _amount);
} else {
... | if (_isUSDA) {
// now send usda to the target, equal to the amount they are owed
usda.vaultControllerMint(_target, _amount);
} else {
// send sUSD to the target from reserve instead of mint
usda.vaultControllerTransfer(_target, _amount);
}
// emit the event
emit BorrowUSDA(_id, addr... | other | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/twcctop-Q.md | 2026-01-02T18:24:04.032075+00:00 | 11a1c015a34b0ab65f522c53ff77c32ad2cae05c659bde71f8fe113d0e97aeeb | 1 | 1 | 348 | 1 | false | true | true | false | medium | if (_isUSDA) {
// now send usda to the target, equal to the amount they are owed
usda.vaultControllerMint(_target, _amount);
} else {
// send sUSD to the target from reserve instead of mint
usda.vaultControllerTransfer(_target, _amount);
}
// emit the event
emit BorrowUSDA(_id, addr... | solidity | 348 | // Code block 1 (solidity):
if (_isUSDA) {
// now send usda to the target, equal to the amount they are owed
usda.vaultControllerMint(_target, _amount);
} else {
// send sUSD to the target from reserve instead of mint
usda.vaultControllerTransfer(_target, _amount);
}
// emit the event
... | 1 | false | if (_isUSDA) {
// now send usda to the target, equal to the amount they are owed
usda.vaultControllerMint(_target, _amount);
} else {
// send sUSD to the target from reserve instead of mint
usda.vaultControllerTransfer(_target, _amount);
}
// emit the event
emit BorrowUSDA(_id, addr... | VaultController.sol#L561 | VaultController.sol | 1 | if (_isUSDA) {
// now send usda to the target, equal to the amount they are owed
usda.vaultControllerMint(_target, _amount);
} else {
// send sUSD to the target from reserve instead of mint
usda.vaultControllerTransfer(_target, _amount);
}
// emit the event
emit BorrowUSDA(_id, addr... | true | false | false | 4.19 | ||||
c4 | 09-ondo | mrudenko Q | Medium | medium | QA report
RWADynamicOracle
1) While the variable names are mostly descriptive, there are places where they could be clearer. For instance, dailyIR could be renamed to dailyInterestRate for clarity.
2) Allow Deletion of Ranges:
```
function deleteRange(uint256 indexToDelete) external onlyRole(DEFAULT_ADMIN_ROLE) {
r... | function deleteRange(uint256 indexToDelete) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(indexToDelete < ranges.length, "Invalid index");
for (uint256 i = indexToDelete; i < ranges.length - 1; i++) {
ranges[i] = ranges[i + 1];
}
ranges.pop();
}
| function removeDestinationChain(string memory destinationChain) external onlyOwner {
require(bytes(destChainToContractAddr[destinationChain]).length != 0, "Chain not found");
delete destChainToContractAddr[destinationChain];
emit DestinationChainRemoved(destinationChain);
}
| access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/mrudenko-Q.md | 2026-01-02T18:26:08.145982+00:00 | 11c246793290aa3b21cf7020c2c31d21a2143ef6d5d075b69f76f1de7c3434a5 | 5 | 0 | 907 | 0 | false | false | true | false | high | function deleteRange(uint256 indexToDelete) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(indexToDelete < ranges.length, "Invalid index");
for (uint256 i = indexToDelete; i < ranges.length - 1; i++) {
ranges[i] = ranges[i + 1];
}
ranges.pop();
} | unknown | 271 | // Code block 1 (unknown):
function deleteRange(uint256 indexToDelete) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(indexToDelete < ranges.length, "Invalid index");
for (uint256 i = indexToDelete; i < ranges.length - 1; i++) {
ranges[i] = ranges[i + 1];
}
ranges.pop();
}
// Code block 2 (unk... | 5 | false | 0 | function deleteRange(uint256 indexToDelete) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(indexToDelete < ranges.length, "Invalid index");
for (uint256 i = indexToDelete; i < ranges.length - 1; i++) {
ranges[i] = ranges[i + 1];
}
ranges.pop();
}
| true | function removeDestinationChain(string memory destinationChain) external onlyOwner {
require(bytes(destChainToContractAddr[destinationChain]).length != 0, "Chain not found");
delete destChainToContractAddr[destinationChain];
emit DestinationChainRemoved(destinationChain);
}
| true | true | 10 | |||||
c4 | 03-revert-lend | lightoasis Q | High | high | ## 1. There are no min and max values set for the reserve factor.
The reserve factor is the percentage difference between debt and lend interest. There are currently no max and min values for the reserve factor. This could impact the borrowers and the lenders it is set too high or too low.
[V3Vault.sol#L838](https://g... | function setReserveFactor(uint32 _reserveFactorX32) external onlyOwner {
reserveFactorX32 = _reserveFactorX32;
emit SetReserveFactor(_reserveFactorX32);
} | function create(uint256 tokenId, address recipient) external override {
nonfungiblePositionManager.safeTransferFrom(msg.sender, address(this), tokenId, abi.encode(recipient));
} | reentrancy | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/lightoasis-Q.md | 2026-01-02T19:03:14.566763+00:00 | 11eca9746cf7ae00e17900ffc7ba520713b1bc416c0582b6443a6e095d427af3 | 2 | 0 | 363 | 2 | false | false | true | false | high | function setReserveFactor(uint32 _reserveFactorX32) external onlyOwner {
reserveFactorX32 = _reserveFactorX32;
emit SetReserveFactor(_reserveFactorX32);
} | unknown | 174 | // Code block 1 (unknown):
function setReserveFactor(uint32 _reserveFactorX32) external onlyOwner {
reserveFactorX32 = _reserveFactorX32;
emit SetReserveFactor(_reserveFactorX32);
}
// Code block 2 (unknown):
function create(uint256 tokenId, address recipient) external override {
nonfungibl... | 2 | false | V3Vault.sol#L838, V3Vault.sol#L401-L36 | V3Vault.sol | 2 | function setReserveFactor(uint32 _reserveFactorX32) external onlyOwner {
reserveFactorX32 = _reserveFactorX32;
emit SetReserveFactor(_reserveFactorX32);
} | true | function create(uint256 tokenId, address recipient) external override {
nonfungiblePositionManager.safeTransferFrom(msg.sender, address(this), tokenId, abi.encode(recipient));
} | true | true | 8 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.