source stringclasses 1
value | protocol stringclasses 17
values | title stringlengths 4 24 | severity_raw stringclasses 8
values | severity stringclasses 8
values | description stringlengths 198 2k | vulnerable_code stringlengths 0 2k | fixed_code stringlengths 0 2k | recommendation stringclasses 1
value | category stringclasses 12
values | report_url stringlengths 71 98 | collected_at stringlengths 32 32 | source_hash stringlengths 64 64 | code_block_count int64 0 10 | solidity_block_count int64 0 10 | total_code_chars int64 0 1.73k | github_ref_count int64 0 26 | vulnerable_code_is_url bool 2
classes | fixed_code_is_url bool 2
classes | has_code_in_description bool 2
classes | has_recommendation bool 1
class | quality_estimate stringclasses 2
values | primary_code stringlengths 0 1.72k | primary_code_language stringclasses 19
values | primary_code_char_count int64 0 1.72k | all_code_blocks stringlengths 0 1.87k | all_code_blocks_count int64 0 10 | has_diff_blocks bool 2
classes | diff_code stringclasses 71
values | solidity_code stringlengths 0 1.68k | github_refs_formatted stringlengths 0 562 | github_files_list stringlengths 0 203 | github_refs_count int64 0 26 | vulnerable_code_actual stringlengths 0 2k | has_vulnerable_code_snippet bool 2
classes | fixed_code_actual stringlengths 0 2k | has_fixed_code_snippet bool 2
classes | has_vuln_fix_pair bool 2
classes | content_richness_score float64 2.4 15 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
c4 | 01-ondo | 0xSmartContract G | High | high | ### Gas Optimizations List
| Number | Optimization Details | Context |
|:--:|:-------| :-----:|
| [G-01] | Remove the `initializer` modifier |28 |
| [G-02] |Use hardcode address instead ``address(this)``| 50 |
| [G-03] |Duplicated require()/if() checks should be refactored to a modifier or function |17 |
| [G-04] | Usi... | contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/0xSmartContract-G.md | 2026-01-02T18:14:21.627113+00:00 | 23031ffdff0ccf4a37304c854fd10f3c787c169616028b4e3704b99f88b396b9 | 1 | 1 | 106 | 1 | false | false | true | false | high | contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | solidity | 106 | // Code block 1 (solidity):
contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | 1 | false | contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | CashKYCSender.sol#L46 | CashKYCSender.sol | 1 | contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | true | contracts\cash\token\CashKYCSenderReceiver.sol:
46: function initialize(
51 ) public initializer { | true | true | 7 | ||
c4 | 03-asymmetry | 4lulz G | Gas | gas | ## Max approval
All derivative contracts could pre-approve maximum value `type(uint256).max` to reduce `CALL` operations for each transaction.
### `Reth.sol`
Add maximum approval in [`initialize`](https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/contracts/SafEth/derivati... | IERC20(W_ETH_ADDRESS).approve(UNISWAP_ROUTER, type(uint256).max); | IsFrxEth(FRX_ETH_ADDRESS).approve(FRX_ETH_CRV_POOL_ADDRESS, type(uint256).max); | upgrade | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/4lulz-G.md | 2026-01-02T18:17:47.687425+00:00 | 233e5ffa911c927f6181f2fba8b7a139ca380a535b05f18843164f9446d38abd | 3 | 0 | 206 | 8 | false | false | true | false | high | IERC20(W_ETH_ADDRESS).approve(UNISWAP_ROUTER, type(uint256).max); | Solidity | 65 | // Code block 1 (Solidity):
IERC20(W_ETH_ADDRESS).approve(UNISWAP_ROUTER, type(uint256).max);
// Code block 2 (Solidity):
IsFrxEth(FRX_ETH_ADDRESS).approve(FRX_ETH_CRV_POOL_ADDRESS, type(uint256).max);
// Code block 3 (Solidity):
IERC20(STETH_TOKEN).approve(LIDO_CRV_POOL, type(uint256).max); | 3 | false | IERC20(W_ETH_ADDRESS).approve(UNISWAP_ROUTER, type(uint256).max);
IsFrxEth(FRX_ETH_ADDRESS).approve(FRX_ETH_CRV_POOL_ADDRESS, type(uint256).max);
IERC20(STETH_TOKEN).approve(LIDO_CRV_POOL, type(uint256).max); | Reth.sol#L42, Reth.sol#L83, SfrxEth.sol#L36, SfrxEth.sol#L60, WstEth.sol#L33, WstEth.sol#L56, SafEth.sol#L165, SafEth.sol#L182 | SfrxEth.sol, Reth.sol, WstEth.sol, SafEth.sol | 8 | IERC20(W_ETH_ADDRESS).approve(UNISWAP_ROUTER, type(uint256).max); | true | IsFrxEth(FRX_ETH_ADDRESS).approve(FRX_ETH_CRV_POOL_ADDRESS, type(uint256).max); | true | true | 9 | ||
c4 | 07-amphora | DavidGiladi G | High | high |
### Gas Optimization Issues
|Title|Issue|Instances|Total Gas Saved|
|-|:-|:-:|:-:|
|[G-1] Inefficient use of abi.encode() | [Inefficient use of abi.encode()](#inefficient-use-of-abiencode) | 7 | 700 |
|[G-2] Avoid unnecessary storage updates | [Avoid unnecessary storage updates](#avoid-unnecessary-storage-updates) | ... | Line: 261 queuedTransactions[keccak256(
abi.encode(
_proposal.targets[_i], _proposal.values[_i], _proposal.signatures[_i], _proposal.calldatas[_i], _eta
)
)] | Line: 299 _txHash = keccak256(abi.encode(_target, _value, _signature, _data, _eta)) | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/DavidGiladi-G.md | 2026-01-02T18:23:24.625452+00:00 | 23584409e0c12b920901ed97ba75106163a13b42f08366f737f4b6c1e040fc1c | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | Line: 261 queuedTransactions[keccak256(
abi.encode(
_proposal.targets[_i], _proposal.values[_i], _proposal.signatures[_i], _proposal.calldatas[_i], _eta
)
)] | true | Line: 299 _txHash = keccak256(abi.encode(_target, _value, _signature, _data, _eta)) | true | true | 5 | ||||||||
c4 | 10-badger | shaka Q | Critical | critical | # Low Risk Issues
| ID |Title|Instances|
|:--:|:-------|:--:|
|[L-01]| Misleading comments for protocol integrations | 1 |
## [L-01] Misleading comments for protocol integrations
```solidity
File: SortedCdps.sol
134: /// @notice Find a specific CDP for a given owner, indexed by it's place in the linked list rela... | File: SortedCdps.sol
134: /// @notice Find a specific CDP for a given owner, indexed by it's place in the linked list relative to other Cdps owned by the same address
135: /// @notice Reverts if the index exceeds the number of active Cdps owned by the given owner 👈
136: /// @dev Intended for off-chain use,... | File: CdpManager.sol
244: function _closeCdpByRedemption(
245: bytes32 _cdpId,
246: uint256 _EBTC, 👈 always 0
247: uint256 _collSurplus,
248: uint256 _liquidatorRewardShares,
249: address _borrower
250: ) internal { | reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/shaka-Q.md | 2026-01-02T18:27:01.734508+00:00 | 23994bd4aee25b61beaf4cec2af1b69537c70bf9007ec4bc07cb45b3d4a8a818 | 2 | 2 | 862 | 0 | false | false | true | false | high | File: SortedCdps.sol
134: /// @notice Find a specific CDP for a given owner, indexed by it's place in the linked list relative to other Cdps owned by the same address
135: /// @notice Reverts if the index exceeds the number of active Cdps owned by the given owner 👈
136: /// @dev Intended for off-chain use,... | solidity | 599 | // Code block 1 (solidity):
File: SortedCdps.sol
134: /// @notice Find a specific CDP for a given owner, indexed by it's place in the linked list relative to other Cdps owned by the same address
135: /// @notice Reverts if the index exceeds the number of active Cdps owned by the given owner 👈
136: /// @dev... | 2 | false | File: SortedCdps.sol
134: /// @notice Find a specific CDP for a given owner, indexed by it's place in the linked list relative to other Cdps owned by the same address
135: /// @notice Reverts if the index exceeds the number of active Cdps owned by the given owner 👈
136: /// @dev Intended for off-chain use,... | 0 | File: SortedCdps.sol
134: /// @notice Find a specific CDP for a given owner, indexed by it's place in the linked list relative to other Cdps owned by the same address
135: /// @notice Reverts if the index exceeds the number of active Cdps owned by the given owner 👈
136: /// @dev Intended for off-chain use,... | true | File: CdpManager.sol
244: function _closeCdpByRedemption(
245: bytes32 _cdpId,
246: uint256 _EBTC, 👈 always 0
247: uint256 _collSurplus,
248: uint256 _liquidatorRewardShares,
249: address _borrower
250: ) internal { | true | true | 7 | ||||
c4 | 08-dopex | MohammedRizwan G | Medium | medium | ## Summary
### Gas Optimizations
| |Issue|Instances| |
|-|:-|:-:|:-:|
| [G‑01] | Use assembly to emit events | 15 |
| [G‑02] | Use assembly to write address storage values | 4 |
| [G‑03] | Use custom errors instead of require/assert | 21 |
| [G‑04] | Avoid double access control checking in ... | File: contracts/decaying-bonds/RdpxDecayingBonds.sol
function mint(
address to,
uint256 expiry,
uint256 rdpxAmount
) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = B... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/MohammedRizwan-G.md | 2026-01-02T18:24:54.670651+00:00 | 23aa2d40bb8fffd00259de5b1b2a5e46c43196dda4a80e2dc7ab7e13d7c1ef69 | 0 | 0 | 0 | 4 | false | true | false | false | medium | 0 | 0 | false | UniV2LiquidityAmo.sol#L74-L102, RdpxV2Core.sol#L304-L350, PerpetualAtlanticVault.sol#L181-L212, ReLPContract.sol#L115-L148 | ReLPContract.sol, PerpetualAtlanticVault.sol, UniV2LiquidityAmo.sol, RdpxV2Core.sol | 4 | File: contracts/decaying-bonds/RdpxDecayingBonds.sol
function mint(
address to,
uint256 expiry,
uint256 rdpxAmount
) external onlyRole(MINTER_ROLE) {
_whenNotPaused();
require(hasRole(MINTER_ROLE, msg.sender), "Caller is not a minter");
uint256 bondId = _mintToken(to);
bonds[bondId] = B... | true | false | false | 5 | ||||||||
c4 | 08-dopex | 0xCiphky Q | Low | low | ## Restriction for zero approvals can lead to a loss of funds if contract gets compromised
### **Relevant GitHub Links:**
https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/amo/UniV2LiquidityAmo.sol#L133
https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75d... | function removeLiquidity(uint256 positionIndex, uint256 minAmount0, uint256 minAmount1)
public
onlyRole(DEFAULT_ADMIN_ROLE)
{
// rest of the code
positions_array[positionIndex] = positions_array[positions_array.length - 1];
positions_array.pop();
delete positions... | function removeLiquidity(uint256 positionIndex, uint256 minAmount0, uint256 minAmount1)
public
onlyRole(DEFAULT_ADMIN_ROLE)
{
// rest of the code
positions_array[positionIndex] = positions_array[positions_array.length - 1];
positions_array.pop();
uint256 tokenId = posit... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0xCiphky-Q.md | 2026-01-02T18:24:14.122108+00:00 | 23ca6e1c794e112447edc8bb54fea735ffd91d7d4d40298c768bd16d066716ed | 0 | 0 | 0 | 3 | false | false | false | false | medium | 0 | 0 | false | UniV2LiquidityAmo.sol#L133, RdpxV2Core.sol#L410, UniV3LiquidityAmo.sol#L269 | UniV3LiquidityAmo.sol, UniV2LiquidityAmo.sol, RdpxV2Core.sol | 3 | function removeLiquidity(uint256 positionIndex, uint256 minAmount0, uint256 minAmount1)
public
onlyRole(DEFAULT_ADMIN_ROLE)
{
// rest of the code
positions_array[positionIndex] = positions_array[positions_array.length - 1];
positions_array.pop();
delete positions... | true | function removeLiquidity(uint256 positionIndex, uint256 minAmount0, uint256 minAmount1)
public
onlyRole(DEFAULT_ADMIN_ROLE)
{
// rest of the code
positions_array[positionIndex] = positions_array[positions_array.length - 1];
positions_array.pop();
uint256 tokenId = posit... | true | true | 6 | ||||||
c4 | 01-biconomy | zaskoh Q | Critical | critical | ## Summary
### Low Risk Issues
| |Issue|Instances|
|-|:-|:-:|
| L-01 | Unneccessary if condition for a check that is always true | 1 |
| L-02 | Function deployWallet can be removed as it is not possible to check for deployed addresses | 1 |
| L-03 | Always check important state vars before update | 2 |
| L-04 | Deviat... | File: contracts/smart-contract-wallet/SmartAccount.sol
166: function init(address _owner, address _entryPointAddress, address _handler) public override initializer {
167: require(owner == address(0), "Already initialized");
168: require(address(_entryPoint) == address(0), "Already initialized");
16... | File: contracts/smart-contract-wallet/SmartAccountFactory.sol
53: function deployWallet(address _owner, address _entryPoint, address _handler) public returns(address proxy){
54: bytes memory deploymentData = abi.encodePacked(type(Proxy).creationCode, uint(uint160(_defaultImpl)));
55: // solhint-disa... | reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/zaskoh-Q.md | 2026-01-02T18:14:16.895693+00:00 | 2433ae7e097ad087bea5cbcbf5dbe20dc388714f8fbf35dc9add42dfadfcde18 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: contracts/smart-contract-wallet/SmartAccount.sol
166: function init(address _owner, address _entryPointAddress, address _handler) public override initializer {
167: require(owner == address(0), "Already initialized");
168: require(address(_entryPoint) == address(0), "Already initialized");
16... | true | File: contracts/smart-contract-wallet/SmartAccountFactory.sol
53: function deployWallet(address _owner, address _entryPoint, address _handler) public returns(address proxy){
54: bytes memory deploymentData = abi.encodePacked(type(Proxy).creationCode, uint(uint160(_defaultImpl)));
55: // solhint-disa... | true | true | 5 | ||||||||
c4 | 09-ondo | report | Critical | critical | ---
sponsor: "Ondo Finance"
slug: "2023-09-ondo"
date: "2023-10-12"
title: "Ondo Finance"
findings: "https://github.com/code-423n4/2023-09-ondo-findings/issues"
contest: 281
---
# Overview
## About C4
Code4rena (C4) is an open organization consisting of security researchers, auditors, developers, and individuals wit... | 121: function setDestinationChainContractAddress(
122: string memory destinationChain,
123: address contractAddress
124: ) external onlyOwner {
125: destChainToContractAddr[destinationChain] = AddressToString.toString(
126: contractAddress
127: );
128: emit DestinationChainContractAddressS... | 234: function addChainSupport(
235: string calldata srcChain,
236: string calldata srcContractAddress
237: ) external onlyOwner {
238: chainToApprovedSender[srcChain] = keccak256(abi.encode(srcContractAddress));
239: emit ChainIdSupported(srcChain, srcContractAddress);
240: } | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/report.md | 2026-01-02T18:26:24.344299+00:00 | 243f9cf41144954d17c44dc03844906668f00d942c417ac06229fa123755dd86 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | 121: function setDestinationChainContractAddress(
122: string memory destinationChain,
123: address contractAddress
124: ) external onlyOwner {
125: destChainToContractAddr[destinationChain] = AddressToString.toString(
126: contractAddress
127: );
128: emit DestinationChainContractAddressS... | true | 234: function addChainSupport(
235: string calldata srcChain,
236: string calldata srcContractAddress
237: ) external onlyOwner {
238: chainToApprovedSender[srcChain] = keccak256(abi.encode(srcContractAddress));
239: emit ChainIdSupported(srcChain, srcContractAddress);
240: } | true | true | 5 | ||||||||
c4 | 05-ajna | kodyvim Q | Medium | medium | # Approved NFT users can not stake in RewardsManager.
if a user has approved his/her nft to someone or any protocol building on top of ajna they would not be able to stake on behave of the user, since the stake function only allows the owner.
https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/RewardsMan... | address owner = IERC721(address(positionManager)).ownerOf(tokenId_);
address approved = IERC721(address(positionManager)).getApproved(tokenId_);
if (owner != msg.sender && approved != msg.sender) revert NotOwnerOfDeposit(); | vars.depositTime = fromPosition.depositTime;
// handle the case where owner attempts to move liquidity after they've already done so
if (vars.depositTime == 0) revert RemovePositionFailed(); | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/kodyvim-Q.md | 2026-01-02T18:21:33.703859+00:00 | 24a1d7caee218c60027fe0f4cf6a2906295e4fbe4e360ee115ef2a0d82ad803a | 3 | 3 | 587 | 4 | false | false | true | false | high | address owner = IERC721(address(positionManager)).ownerOf(tokenId_);
address approved = IERC721(address(positionManager)).getApproved(tokenId_);
if (owner != msg.sender && approved != msg.sender) revert NotOwnerOfDeposit(); | solidity | 223 | // Code block 1 (solidity):
address owner = IERC721(address(positionManager)).ownerOf(tokenId_);
address approved = IERC721(address(positionManager)).getApproved(tokenId_);
if (owner != msg.sender && approved != msg.sender) revert NotOwnerOfDeposit();
// Code block 2 (solidity):
vars.depositTime = fromPosition.deposit... | 3 | true | - * @param values_ The amounts of ETH to send to each target.
+ * @param values_ The amounts of ETH to send to each target should always be zero. | address owner = IERC721(address(positionManager)).ownerOf(tokenId_);
address approved = IERC721(address(positionManager)).getApproved(tokenId_);
if (owner != msg.sender && approved != msg.sender) revert NotOwnerOfDeposit();
vars.depositTime = fromPosition.depositTime;
// handle the case where owner attempts to move... | RewardsManager.sol#L213, PositionManager.sol#L268-L271, Funding.sol#L99, Funding.sol#L21 | RewardsManager.sol, Funding.sol, PositionManager.sol | 4 | address owner = IERC721(address(positionManager)).ownerOf(tokenId_);
address approved = IERC721(address(positionManager)).getApproved(tokenId_);
if (owner != msg.sender && approved != msg.sender) revert NotOwnerOfDeposit(); | true | vars.depositTime = fromPosition.depositTime;
// handle the case where owner attempts to move liquidity after they've already done so
if (vars.depositTime == 0) revert RemovePositionFailed(); | true | true | 11 | |
c4 | 04-caviar | dingo2077 Q | Low | low | ## [L-01] Users can't create pools while setPrivatePoolImplementation() didn't called by owner.
SC: Factory.sol
## Proof of Concept
Users can't create pools while setPrivatePoolImplementation() didn't called by owner.
https://github.com/code-423n4/2023-04-caviar/blob/cd8a92667bcb6657f70657183769c244d04c015c/src/Factor... | uint256 inputAmount = FixedPointMathLib.mulDivUp(
outputAmount,
virtualBaseTokenReserves,
(virtualNftReserves - outputAmount) //<<-here
); | // SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;
import "forge-std/Test.sol";
import "../../src/Factory.sol";
import "../../src/EthRouter.sol";
import "../../src/PrivatePool.sol";
import "../shared/Milady.sol";
contract MyLive is Test {
address public nftArtist = vm.addr(123);
address public royaltyReg... | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/dingo2077-Q.md | 2026-01-02T18:20:29.597891+00:00 | 24f4da10cf91e67f3aaeceaca069a8d88e1a0dac858f242217bfeffbbe92984a | 1 | 1 | 182 | 1 | false | false | true | false | high | uint256 inputAmount = FixedPointMathLib.mulDivUp(
outputAmount,
virtualBaseTokenReserves,
(virtualNftReserves - outputAmount) //<<-here
); | solidity | 182 | // Code block 1 (solidity):
uint256 inputAmount = FixedPointMathLib.mulDivUp(
outputAmount,
virtualBaseTokenReserves,
(virtualNftReserves - outputAmount) //<<-here
); | 1 | false | uint256 inputAmount = FixedPointMathLib.mulDivUp(
outputAmount,
virtualBaseTokenReserves,
(virtualNftReserves - outputAmount) //<<-here
); | Factory.sol#L135 | Factory.sol | 1 | uint256 inputAmount = FixedPointMathLib.mulDivUp(
outputAmount,
virtualBaseTokenReserves,
(virtualNftReserves - outputAmount) //<<-here
); | true | // SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;
import "forge-std/Test.sol";
import "../../src/Factory.sol";
import "../../src/EthRouter.sol";
import "../../src/PrivatePool.sol";
import "../shared/Milady.sol";
contract MyLive is Test {
address public nftArtist = vm.addr(123);
address public royaltyReg... | true | true | 7 | ||
c4 | 02-ethos | c3phas G | High | high | ### Table of contents
- [FINDINGS](#findings)
- [Tighly pack storage variables/optimize the order of variable declaration(Total Gas saved: 16K gas )](#tighly-pack-storage-variablesoptimize-the-order-of-variable-declarationtotal-gas-saved-16k-gas-)
- [LUSDToken.sol: Pack bool mintingPaused with address troveManagerAdd... | File: /Ethos-Core/contracts/LUSDToken.sol
37: bool public mintingPaused = false;
51: bytes32 private immutable _HASHED_NAME;
52: bytes32 private immutable _HASHED_VERSION;
54: mapping (address => uint256) private _nonces;
67: address public troveManagerAddress; | https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Vault/contracts/ReaperVaultV2.sol#L46-L78
### ReaperVaultV2.sol: pack treasury with emergencyShutdown and lastReport(4k gas)
**lastReport being a timestamp we can get away with using uint64 - should be safe for around 530 ye... | reentrancy | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/c3phas-G.md | 2026-01-02T18:16:53.998734+00:00 | 254ba2d66f5c51a61d8efd99516750cc06c403e2231c0c7c4c3f2cccffc9bfeb | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | ReaperVaultV2.sol#L46-L78 | ReaperVaultV2.sol | 1 | File: /Ethos-Core/contracts/LUSDToken.sol
37: bool public mintingPaused = false;
51: bytes32 private immutable _HASHED_NAME;
52: bytes32 private immutable _HASHED_VERSION;
54: mapping (address => uint256) private _nonces;
67: address public troveManagerAddress; | true | https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Vault/contracts/ReaperVaultV2.sol#L46-L78
### ReaperVaultV2.sol: pack treasury with emergencyShutdown and lastReport(4k gas)
**lastReport being a timestamp we can get away with using uint64 - should be safe for around 530 ye... | true | true | 6 | ||||||
c4 | 08-dopex | 0x3b Q | Low | low | | *Issue* | *Description* |
|------------|------------------------------------------------------------------------------------------------... | ### **[L-02]** Bond discount needs to be change every so often to avoid issues
Under [calculateBondCost](https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/RdpxV2Core.sol#L1163-L1165) `bondDiscount` is counted for with static value against movable `rdpxReserves` which means that with market turns up a... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0x3b-Q.md | 2026-01-02T18:24:10.987737+00:00 | 2568e2f6762acf3a837f6de432088ffac46a37956d09a55faa7f459edf6f5ad1 | 1 | 0 | 200 | 6 | false | true | true | false | medium | /**
* @notice Lets users mint DpxEth at a 1:1 ratio when DpxEth pegs above 1.01 of the ETH token
*/
function upperDepeg() external onlyRole(DEFAULT_ADMIN_ROLE) returns (uint256 wethReceived) { | jsx | 200 | // Code block 1 (jsx):
/**
* @notice Lets users mint DpxEth at a 1:1 ratio when DpxEth pegs above 1.01 of the ETH token
*/
function upperDepeg() external onlyRole(DEFAULT_ADMIN_ROLE) returns (uint256 wethReceived) { | 1 | false | RdpxV2Core.sol#L1051-L1070, RdpxV2Core.sol#L566-L583, RdpxV2Core.sol, RdpxV2Core.sol#L1163-L1165, RdpxV2Core.sol#L1169-L1173, RdpxV2Core.sol#L88 | RdpxV2Core.sol | 6 | ### **[L-02]** Bond discount needs to be change every so often to avoid issues
Under [calculateBondCost](https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/core/RdpxV2Core.sol#L1163-L1165) `bondDiscount` is counted for with static value against movable `rdpxReserves` which means that with market turns up a... | true | false | false | 6 | |||||
c4 | 01-ondo | martin G | High | high | # Ondo Finance
## Gas Optimizations Report
### G-01 Splitting `require()` statements that use `&&` saves gas
_There are **3** instances of this issue:_
Instead of using `&&` on single require check using two require checks can save gas
```solidity
292: require(
(answeredInRound >= roundId) &&
(update... | 292: require(
(answeredInRound >= roundId) &&
(updatedAt >= block.timestamp - maxChainlinkOracleTimeDelay),
"Chainlink oracle price is stale"
); | 45: require(
accrualBlockNumber == 0 && borrowIndex == 0,
"market may only be initialized once"
); | oracle | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/martin-G.md | 2026-01-02T18:15:20.119949+00:00 | 2584f3cf7233ba033c50fe355ccd968b3425929e05a0a45703ecf54c7d238622 | 6 | 6 | 628 | 5 | false | false | true | false | high | 292: require(
(answeredInRound >= roundId) &&
(updatedAt >= block.timestamp - maxChainlinkOracleTimeDelay),
"Chainlink oracle price is stale"
); | solidity | 168 | // Code block 1 (solidity):
292: require(
(answeredInRound >= roundId) &&
(updatedAt >= block.timestamp - maxChainlinkOracleTimeDelay),
"Chainlink oracle price is stale"
);
// Code block 2 (solidity):
45: require(
accrualBlockNumber == 0 && borrowIndex == 0,
"market may only be init... | 6 | false | 292: require(
(answeredInRound >= roundId) &&
(updatedAt >= block.timestamp - maxChainlinkOracleTimeDelay),
"Chainlink oracle price is stale"
);
45: require(
accrualBlockNumber == 0 && borrowIndex == 0,
"market may only be initialized once"
);
45: require(
accrualBlockNum... | OndoPriceOracleV2.sol, CCash.sol, CTokenModified.sol, KYCRegistry.sol, CTokenCash.sol | CTokenCash.sol, CTokenModified.sol, KYCRegistry.sol, OndoPriceOracleV2.sol, CCash.sol | 5 | 292: require(
(answeredInRound >= roundId) &&
(updatedAt >= block.timestamp - maxChainlinkOracleTimeDelay),
"Chainlink oracle price is stale"
); | true | 45: require(
accrualBlockNumber == 0 && borrowIndex == 0,
"market may only be initialized once"
); | true | true | 12 | ||
c4 | 01-biconomy | Rickard G | Low | low | # STATE VARIABLES CAN BE PACKED INTO FEWER STORAGE SLOTS
BaseSmartAccount.sol
```
struct Transaction {
address to;
- uint256 value;
bytes data;
Enum.Operation operation;
+ uint256 value;
uint256 targetTxGas;
}
```
```
struct FeeRefund {
+ address gasToken;
... | struct Transaction {
address to;
- uint256 value;
bytes data;
Enum.Operation operation;
+ uint256 value;
uint256 targetTxGas;
}
| struct FeeRefund {
+ address gasToken;
uint256 baseGas;
uint256 gasPrice; //gasPrice or tokenGasPrice
uint256 tokenGasPriceFactor;
- address gasToken;
address payable refundReceiver;
}
| reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/Rickard-G.md | 2026-01-02T18:13:16.107234+00:00 | 25dffddb9c8823ba74c38ad9154a49a10a1ffc5566dfc5dc7ec5f31ddd1d3555 | 6 | 0 | 1,021 | 3 | false | false | true | false | high | struct Transaction {
address to;
- uint256 value;
bytes data;
Enum.Operation operation;
+ uint256 value;
uint256 targetTxGas;
} | unknown | 180 | // Code block 1 (unknown):
struct Transaction {
address to;
- uint256 value;
bytes data;
Enum.Operation operation;
+ uint256 value;
uint256 targetTxGas;
}
// Code block 2 (unknown):
struct FeeRefund {
+ address gasToken;
uint256 baseGas;
uint... | 6 | false | SmartAccount.sol#L36, SmartAccountFactory.sol#L11, DefaultCallbackHandler.sol#L12 | DefaultCallbackHandler.sol, SmartAccount.sol, SmartAccountFactory.sol | 3 | struct Transaction {
address to;
- uint256 value;
bytes data;
Enum.Operation operation;
+ uint256 value;
uint256 targetTxGas;
}
| true | struct FeeRefund {
+ address gasToken;
uint256 baseGas;
uint256 gasPrice; //gasPrice or tokenGasPrice
uint256 tokenGasPriceFactor;
- address gasToken;
address payable refundReceiver;
}
| true | true | 12 | |||
c4 | 02-ethos | Rolezn Q | Critical | critical | ## Summary<a name="Summary">
### Low Risk Issues
| |Issue|Contexts|
|-|:-|:-:|
| [LOW‑1](#LOW‑1) | `decimals()` not part of ERC20 standard | 1 |
| [LOW‑2](#LOW‑2) | Event is missing parameters | 2 |
| [LOW‑3](#LOW‑3) | Function can risk gas exhaustion on large receipt calls du... | 63: uint256 decimals = IERC20(collateral).decimals() | function pullCollateralFromBorrowerOperationsOrDefaultPool(address _collateral, uint _amount) external override {
...
emit ActivePoolCollateralBalanceUpdated(_collateral, collAmount[_collateral]);
...
}
| reentrancy | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Rolezn-Q.md | 2026-01-02T18:16:35.577174+00:00 | 25fc73e5224c30ebbad3028d0aaeec37bb18c655a231ba6e14718fdaa63fe1aa | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | 63: uint256 decimals = IERC20(collateral).decimals() | true | function pullCollateralFromBorrowerOperationsOrDefaultPool(address _collateral, uint _amount) external override {
...
emit ActivePoolCollateralBalanceUpdated(_collateral, collAmount[_collateral]);
...
}
| true | true | 5 | ||||||||
c4 | 06-lybra | OpeOginni G | Low | low | ## 1. IF’s/require() statements that check input arguments should be at the top of the function
***Checks that involve constants should come before checks that involve state variables, function calls, and calculations. By doing these checks first, the function is able to revert before wasting a Gas in a function that ... | File: contracts/lybra/pools/base/LybraEUSDVaultBase.sol
192: require(assetAmount <= depositedAsset[onBehalfOf], "total of collateral can be liquidated at most"); | File: contracts/lybra/pools/base/LybraPeUSDVaultBase.sol
130: require(assetAmount * 2 <= depositedAsset[onBehalfOf], "a max of 50% collateral can be liquidated");
require(PeUSD.allowance(provider, address(this)) > 0, "provider should authorize to provide liquidation EUSD"); | access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/OpeOginni-G.md | 2026-01-02T18:22:33.277700+00:00 | 2656af2644688425bb66363100c82e6630d16b80b85636df2296585d75dd1b24 | 1 | 0 | 453 | 0 | false | false | true | false | high | This require statement only checks the values from the parameters of the Function `superLiquidation(address provider, address onBehalfOf, uint256 assetAmount)`, but is put below some other function calls that might waste gas if this Require statement ends up failing the whole function. Therefore it the require statemen... | unknown | 453 | // Code block 1 (unknown):
This require statement only checks the values from the parameters of the Function `superLiquidation(address provider, address onBehalfOf, uint256 assetAmount)`, but is put below some other function calls that might waste gas if this Require statement ends up failing the whole function. Theref... | 1 | false | 0 | File: contracts/lybra/pools/base/LybraEUSDVaultBase.sol
192: require(assetAmount <= depositedAsset[onBehalfOf], "total of collateral can be liquidated at most"); | true | File: contracts/lybra/pools/base/LybraPeUSDVaultBase.sol
130: require(assetAmount * 2 <= depositedAsset[onBehalfOf], "a max of 50% collateral can be liquidated");
require(PeUSD.allowance(provider, address(this)) > 0, "provider should authorize to provide liquidation EUSD"); | true | true | 5.6 | |||||
c4 | 01-biconomy | cyberinn G | Medium | medium | # Gas Optimizations Report
## G-01 Splitting `require()` statements that use `&&` saves gas
### Impact
When using `&&` in a `require()` statement, the entire statement will be evaluated before the transaction reverts. If the first condition is false, the second condition will not be evaluated. This means that if the... | 68: require(msg.sender != SENTINEL_MODULES && modules[msg.sender] != address(0), "BSA104"); | 34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101"); | other | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/cyberinn-G.md | 2026-01-02T18:13:40.045478+00:00 | 26b7275411e974274e416bcffbdeb8a761b71b5af3204ff501f578a39e45c4ba | 4 | 4 | 300 | 4 | false | false | true | false | high | 68: require(msg.sender != SENTINEL_MODULES && modules[msg.sender] != address(0), "BSA104"); | solidity | 94 | // Code block 1 (solidity):
68: require(msg.sender != SENTINEL_MODULES && modules[msg.sender] != address(0), "BSA104");
// Code block 2 (solidity):
34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
// Code block 3 (solidity):
49: require(module != address(0) && module != SENTINEL_MOD... | 4 | false | 68: require(msg.sender != SENTINEL_MODULES && modules[msg.sender] != address(0), "BSA104");
34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
49: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
486: uint256 maxFeePerGas = mUserOp.maxFeePerGas; | ModuleManager.sol#L68, ModuleManager.sol#L34, ModuleManager.sol#L49, EntryPoint.sol#L486 | ModuleManager.sol, EntryPoint.sol | 4 | 68: require(msg.sender != SENTINEL_MODULES && modules[msg.sender] != address(0), "BSA104"); | true | 34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101"); | true | true | 10 | ||
c4 | 11-kelp | adam idarrha Q | Medium | medium | Title: depositors might not be able to deposit even if deposit limit is not reached
## Lines of code:
https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/oracles/ChainlinkPriceOracle.sol#L37-L39
## Vulnerability details:
### Details:
the protocol has a deposit limit per asse... | the amount Deposited in EigenLayer is calculated with the function `userUnderlyingView` which returns how much asset the user has in the pool, based on how many shares he has. which takes into account amount deposited + any rewards accrued from the strategy.
`NodeDelegator`
| `StrategyBase.sol` out of scope:
| oracle | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/adam-idarrha-Q.md | 2026-01-02T18:27:46.604524+00:00 | 26cbb1d8dddf6e14e310b113942818f306336bdf588e97673c841ec2b7370039 | 3 | 0 | 514 | 1 | false | false | true | false | high | the amount Deposited in EigenLayer is calculated with the function `userUnderlyingView` which returns how much asset the user has in the pool, based on how many shares he has. which takes into account amount deposited + any rewards accrued from the strategy.
`NodeDelegator` | unknown | 275 | // Code block 1 (unknown):
the amount Deposited in EigenLayer is calculated with the function `userUnderlyingView` which returns how much asset the user has in the pool, based on how many shares he has. which takes into account amount deposited + any rewards accrued from the strategy.
`NodeDelegator`
// Code block 2 ... | 3 | false | ChainlinkPriceOracle.sol#L37-L39 | ChainlinkPriceOracle.sol | 1 | the amount Deposited in EigenLayer is calculated with the function `userUnderlyingView` which returns how much asset the user has in the pool, based on how many shares he has. which takes into account amount deposited + any rewards accrued from the strategy.
`NodeDelegator`
| true | `StrategyBase.sol` out of scope:
| true | true | 9 | |||
c4 | 01-biconomy | 0xSmartContract Q | Critical | critical | ## Summary
### Low Risk Issues List
| Number |Issues Details|Context|
|:--:|:-------|:--:|
|[L-01]| Prevent division by 0| 1 |
|[L-02]| Use of EIP 4337, which is likely to change, not recommended for general use or application | 1 |
|[L-03]| Consider using OpenZeppelin's SafeCast library to prevent unexpected overflow... | 2 results - 1 file
contracts/smart-contract-wallet/SmartAccount.sol:
264: payment = (gasUsed + baseGas) * (gasPrice) / (tokenGasPriceFactor);
288: payment = (gasUsed + baseGas) * (gasPrice) / (tokenGasPriceFactor); | contracts/smart-contract-wallet/SmartAccount.sol:
246
247: function handlePayment(
248: uint256 gasUsed,
249: uint256 baseGas,
250: uint256 gasPrice,
251: uint256 tokenGasPriceFactor,
252: address gasToken,
253: address payable refundReceiver
254: ... | reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/0xSmartContract-Q.md | 2026-01-02T18:12:47.698176+00:00 | 26fbd1330b2c5b47719a2ca177841381acb1dc6db5ef7ea2460fb6d6f1ec6b0c | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | 2 results - 1 file
contracts/smart-contract-wallet/SmartAccount.sol:
264: payment = (gasUsed + baseGas) * (gasPrice) / (tokenGasPriceFactor);
288: payment = (gasUsed + baseGas) * (gasPrice) / (tokenGasPriceFactor); | true | contracts/smart-contract-wallet/SmartAccount.sol:
246
247: function handlePayment(
248: uint256 gasUsed,
249: uint256 baseGas,
250: uint256 gasPrice,
251: uint256 tokenGasPriceFactor,
252: address gasToken,
253: address payable refundReceiver
254: ... | true | true | 5 | ||||||||
c4 | 01-ondo | AkshaySrivastav Q | Unknown | unknown | - `KYCRegistryClientConstructable` contains double import statements.
```solidity
import "contracts/cash/kyc/KYCRegistryClient.sol";
import "contracts/cash/kyc/KYCRegistryClient.sol";
```
- In CashManager contract more input validations should be added for privileged access restricted functions.
Like:
... | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/AkshaySrivastav-Q.md | 2026-01-02T18:14:26.588907+00:00 | 275d1cb672de9edb677a0ab29c98b446292d7c681d164dc847794975b47cd360 | 3 | 3 | 977 | 0 | true | true | true | false | medium | import "contracts/cash/kyc/KYCRegistryClient.sol";
import "contracts/cash/kyc/KYCRegistryClient.sol"; | solidity | 105 | // Code block 1 (solidity):
import "contracts/cash/kyc/KYCRegistryClient.sol";
import "contracts/cash/kyc/KYCRegistryClient.sol";
// Code block 2 (solidity):
address private pendingOwnerAddr;
// Code block 3 (solidity):
/**
* @notice Retrieve the price of the provided fToken
* contract's und... | 3 | false | import "contracts/cash/kyc/KYCRegistryClient.sol";
import "contracts/cash/kyc/KYCRegistryClient.sol";
address private pendingOwnerAddr;
/**
* @notice Retrieve the price of the provided fToken
* contract's underlying asset
* @param fToken fToken contract address
* @dev This func... | 0 | false | false | false | 6 | ||||||||
c4 | 02-ethos | Aymen0909 Q | Critical | critical | # QA Report
## Summary
| | Issue | Risk | Instances |
| :-------------: |:-------------|:-------------:|:-------------:|
| 1 | `delegateBySig` doesn't revert when `signer` is `address(0)` | Low | 1 |
| 2 | Front-runable `initialize` function | Low | 1 |
| 3 | Mistake in the `feeBPS` chec... | function permit
(
address owner,
address spender,
uint amount,
uint deadline,
uint8 v,
bytes32 r,
bytes32 s
)
external
override
{
// EIP-2 still allows signature malleability for ecrecover(). Remove this possibility and make the signature
// unique. Appendix F in the... | function initialize(
address _vault,
address[] memory _strategists,
address[] memory _multisigRoles,
IAToken _gWant
) public initializer | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Aymen0909-Q.md | 2026-01-02T18:15:57.672668+00:00 | 27c7e51a43eb80021ff807ee962f7bacf3b8f0b83c599bec6ed40e5041cf6c76 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | LUSDToken.sol#L262-L294 | LUSDToken.sol | 1 | function permit
(
address owner,
address spender,
uint amount,
uint deadline,
uint8 v,
bytes32 r,
bytes32 s
)
external
override
{
// EIP-2 still allows signature malleability for ecrecover(). Remove this possibility and make the signature
// unique. Appendix F in the... | true | function initialize(
address _vault,
address[] memory _strategists,
address[] memory _multisigRoles,
IAToken _gWant
) public initializer | true | true | 6 | ||||||
c4 | 03-asymmetry | Jerry0x Q | Low | low | Confirm the derivative address to avoid incorrectly setting weight.
```
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L165-L175
function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight,
address _checkDerivative
) external onlyOwner {
... | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L165-L175
function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight,
address _checkDerivative
) external onlyOwner {
require(_checkDerivative == address(derivatives[_derivativeIndex]), "... | function removeDerivative(
uint256 _derivativeIndex,
address _checkDerivative
) external onlyOwner {
require(_checkDerivative != address(0), "invalid address");
require(_checkDerivative == address(derivatives[_derivativeIndex]), "wrong derivative");
adjustWeight(_derivati... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Jerry0x-Q.md | 2026-01-02T18:18:12.467928+00:00 | 27d691b738b20e765fb4e71bcc80d9687c10441141b3275853918286ebe7b063 | 3 | 0 | 1,544 | 2 | false | false | true | false | high | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L165-L175
function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight,
address _checkDerivative
) external onlyOwner {
require(_checkDerivative == address(derivatives[_derivativeIndex]), "... | unknown | 885 | // Code block 1 (unknown):
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L165-L175
function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight,
address _checkDerivative
) external onlyOwner {
require(_checkDerivative == address(deriva... | 3 | false | SafEth.sol#L165-L175, SafEth.sol#L83-L96 | SafEth.sol | 2 | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L165-L175
function adjustWeight(
uint256 _derivativeIndex,
uint256 _weight,
address _checkDerivative
) external onlyOwner {
require(_checkDerivative == address(derivatives[_derivativeIndex]), "... | true | function removeDerivative(
uint256 _derivativeIndex,
address _checkDerivative
) external onlyOwner {
require(_checkDerivative != address(0), "invalid address");
require(_checkDerivative == address(derivatives[_derivativeIndex]), "wrong derivative");
adjustWeight(_derivati... | true | true | 9 | |||
c4 | 01-biconomy | shark G | Low | low | ## 1. Splitting `require` statements that use `&&` saves gas
Instead of using the `&&` operator to check multiple conditions, use multiple `require()` statements. This will save approximately 3 gas per `&&`.
Here is an example of this issue:
File: `ModuleManager.sol` [Line 34](https://github.com/code-423n4/2023-01-b... | require(module != address(0) && module != SENTINEL_MODULES, "BSA101"); | require(module != address(0), "BSA101");
require(module != SENTINEL_MODULES, "BSA101"); | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/shark-G.md | 2026-01-02T18:14:09.640429+00:00 | 27e1b44875ab811239a729e9f57b368a808204b49b7231a634f25954af0cbb2c | 4 | 4 | 308 | 5 | false | false | true | false | high | require(module != address(0) && module != SENTINEL_MODULES, "BSA101"); | solidity | 70 | // Code block 1 (solidity):
require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
// Code block 2 (solidity):
require(module != address(0), "BSA101");
require(module != SENTINEL_MODULES, "BSA101");
// Code block 3 (solidity):
require(paymasterAndData.length >= 20, "AA93 invalid paymasterAndDa... | 4 | false | require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
require(module != address(0), "BSA101");
require(module != SENTINEL_MODULES, "BSA101");
require(paymasterAndData.length >= 20, "AA93 invalid paymasterAndData");
require(paymasterAndData.length > 19, "AA93 invalid paymasterAndData"); | ModuleManager.sol#L34, ModuleManager.sol#L49, ModuleManager.sol#L68, EntryPoint.sol#L213, StakeManager.sol#L41 | ModuleManager.sol, StakeManager.sol, EntryPoint.sol | 5 | require(module != address(0) && module != SENTINEL_MODULES, "BSA101"); | true | require(module != address(0), "BSA101");
require(module != SENTINEL_MODULES, "BSA101"); | true | true | 10 | ||
c4 | 09-ondo | MohammedRizwan G | Medium | medium | ## Summary
### Gas Optimizations
| |Issue|Instances| |
|-|:-|:-:|:-:|
| [G‑01] | `_rmul()` can gas optimized by removing extra lines of code | 1 |
| [G‑02] | Use assembly to emit events | 1 |
| [G‑03] | Catch arguments as local variables in `simulateRange()` | 1 |
| [G‑04] | Catch `value... | File: contracts/rwaOracles/RWADynamicOracle.sol
function _rmul(uint256 x, uint256 y) internal pure returns (uint256 z) {
z = _mul(x, y) / ONE;
}
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
require(y == 0 || (z = x * y) / y == x);
} | ### [G‑02] Use assembly to emit events
Assembly can be used to emit events efficiently by utilizing scratch space and the free memory pointer. This will allow us to potentially avoid memory expansion costs.
Note: In order to do this optimization safely, we will need to cache and restore the free memory pointer.... | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/MohammedRizwan-G.md | 2026-01-02T18:25:37.190883+00:00 | 27f642952282d65871e671f35239d39759f5d2fc6048bceebb50eb8c22e8e8f9 | 2 | 1 | 580 | 1 | false | false | true | false | high | File: contracts/rwaOracles/RWADynamicOracle.sol
function _rmul(uint256 x, uint256 y) internal pure returns (uint256 z) {
z = _mul(x, y) / ONE;
}
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
require(y == 0 || (z = x * y) / y == x);
} | Solidity | 277 | // Code block 1 (Solidity):
File: contracts/rwaOracles/RWADynamicOracle.sol
function _rmul(uint256 x, uint256 y) internal pure returns (uint256 z) {
z = _mul(x, y) / ONE;
}
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
require(y == 0 || (z = x * y) / y == x);
}
// Code block... | 2 | true | function _rmul(uint256 x, uint256 y) internal pure returns (uint256 z) {
- z = _mul(x, y) / ONE;
+ z = x * y;
+ require(y == 0 || z / y == x);
+ z = z / ONE;
}
- function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
- require(y == 0 || (z = x * y) / y == x);
- } | File: contracts/rwaOracles/RWADynamicOracle.sol
function _rmul(uint256 x, uint256 y) internal pure returns (uint256 z) {
z = _mul(x, y) / ONE;
}
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
require(y == 0 || (z = x * y) / y == x);
} | RWADynamicOracle.sol#L400-L406 | RWADynamicOracle.sol | 1 | File: contracts/rwaOracles/RWADynamicOracle.sol
function _rmul(uint256 x, uint256 y) internal pure returns (uint256 z) {
z = _mul(x, y) / ONE;
}
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
require(y == 0 || (z = x * y) / y == x);
} | true | ### [G‑02] Use assembly to emit events
Assembly can be used to emit events efficiently by utilizing scratch space and the free memory pointer. This will allow us to potentially avoid memory expansion costs.
Note: In order to do this optimization safely, we will need to cache and restore the free memory pointer.... | true | true | 10 | |
c4 | 01-salty | IceBear Q | Medium | medium | ## [L-01] Hardcoding EXPECTED_SIGNER reduces future scalability.
https://github.com/code-423n4/2024-01-salty/blob/main/src/SigningTools.sol#L7
```
address constant public EXPECTED_SIGNER = 0x1234519DCA2ef23207E1CA7fd70b96f281893bAa;
```
## [L-02] No mechanism for blacklisting.
Once a user has been granted permission, ... | address constant public EXPECTED_SIGNER = 0x1234519DCA2ef23207E1CA7fd70b96f281893bAa; | // Grant access to the sender for the given geoVersion.
// Requires the accompanying correct message signature from the offchain verifier.
function grantAccess(bytes calldata signature) external
{
require( _verifyAccess(msg.sender, signature), "Incorrect AccessManager.grantAccess signatory" );
_wal... | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/IceBear-Q.md | 2026-01-02T19:01:17.892645+00:00 | 28355889afd134341d5751190c121a95af7b16e547b1e82a627f56c0b3d5a742 | 5 | 0 | 839 | 5 | false | false | true | false | high | address constant public EXPECTED_SIGNER = 0x1234519DCA2ef23207E1CA7fd70b96f281893bAa; | unknown | 85 | // Code block 1 (unknown):
address constant public EXPECTED_SIGNER = 0x1234519DCA2ef23207E1CA7fd70b96f281893bAa;
// Code block 2 (unknown):
// Grant access to the sender for the given geoVersion.
// Requires the accompanying correct message signature from the offchain verifier.
function grantAccess(bytes calldata sign... | 5 | false | SigningTools.sol#L7, AccessManager.sol#L65, Airdrop.sol#L64, Airdrop.sol#L67, Airdrop.sol#L81-L82 | Airdrop.sol, SigningTools.sol, AccessManager.sol | 5 | address constant public EXPECTED_SIGNER = 0x1234519DCA2ef23207E1CA7fd70b96f281893bAa; | true | // Grant access to the sender for the given geoVersion.
// Requires the accompanying correct message signature from the offchain verifier.
function grantAccess(bytes calldata signature) external
{
require( _verifyAccess(msg.sender, signature), "Incorrect AccessManager.grantAccess signatory" );
_wal... | true | true | 11 | |||
c4 | 06-lybra | KKat7531 Q | Critical | critical | # Findings Summary
| ID | Title | Severity |
| ------ | ---------------------------------------------------------------------------------- | ------------- |
| [L-01] | Missing zero address & pausable checks in `EUSD.sol` ... | * Requirements:
*
* - `_recipient` cannot be the zero address.
* - the caller must have at least `_sharesAmount` shares.
* - the contract must not be paused.
*
* @dev The `_sharesAmount` argument is the amount of shares, not tokens.
*/
function transferShares(address _recipie... | function clock() public override view returns (uint48){
return SafeCast.toUint48(block.number); | access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/KKat7531-Q.md | 2026-01-02T18:22:24.489908+00:00 | 283689ec7b7ae1894a71bac382f33fabdbccad94e4727fd91b76f9b2b7522e93 | 1 | 1 | 688 | 0 | false | false | true | false | high | * Requirements:
*
* - `_recipient` cannot be the zero address.
* - the caller must have at least `_sharesAmount` shares.
* - the contract must not be paused.
*
* @dev The `_sharesAmount` argument is the amount of shares, not tokens.
*/
function transferShares(address _recipient, u... | solidity | 688 | // Code block 1 (solidity):
* Requirements:
*
* - `_recipient` cannot be the zero address.
* - the caller must have at least `_sharesAmount` shares.
* - the contract must not be paused.
*
* @dev The `_sharesAmount` argument is the amount of shares, not tokens.
*/
function transfer... | 1 | false | * Requirements:
*
* - `_recipient` cannot be the zero address.
* - the caller must have at least `_sharesAmount` shares.
* - the contract must not be paused.
*
* @dev The `_sharesAmount` argument is the amount of shares, not tokens.
*/
function transferShares(address _recipient, u... | 0 | * Requirements:
*
* - `_recipient` cannot be the zero address.
* - the caller must have at least `_sharesAmount` shares.
* - the contract must not be paused.
*
* @dev The `_sharesAmount` argument is the amount of shares, not tokens.
*/
function transferShares(address _recipie... | true | function clock() public override view returns (uint48){
return SafeCast.toUint48(block.number); | true | true | 6 | ||||
c4 | 03-asymmetry | d3tonator Q | Low | low | # [L-01] Outdated Compiler 0.8.13 Used by the Contracts
#### Description:
During the analysis it was observed that the contracts code written in Solidity uses an outdated compiler version 0.8.13. The use of an outdated compiler version 0.8.13 poses several security risks that can compromise the security and stability... | // SPDX-License-Identifier: MIT
pragma solidity ^0.8.13; | 99 _mint(msg.sender, mintAmount);
| access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/d3tonator-Q.md | 2026-01-02T18:19:02.539577+00:00 | 283c9c914d1563599353cfb56e5ff484eefe69c3019b7cb0d42ee1a36080a346 | 1 | 0 | 56 | 1 | false | false | true | false | high | // SPDX-License-Identifier: MIT
pragma solidity ^0.8.13; | unknown | 56 | // Code block 1 (unknown):
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.13; | 1 | false | IDerivative.sol#L2 | IDerivative.sol | 1 | // SPDX-License-Identifier: MIT
pragma solidity ^0.8.13; | true | 99 _mint(msg.sender, mintAmount);
| true | true | 7 | |||
c4 | 01-biconomy | sayan G | Low | low | ## 1. X = X + Y IS CHEAPER THAN X += Y
File: [EntryPoint.sol](https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/aa-4337/core/EntryPoint.sol)
line:[81](https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529ee... | collected += _executeUserOp(i, ops[i], opInfos[i]); | totalOps += opsPerAggregator[i].userOps.length; | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/sayan-G.md | 2026-01-02T18:14:06.970098+00:00 | 287b1b67ad9bbca103137cddf37259fb481ec006cbe393069fed8f8d9fc4a8b3 | 4 | 0 | 207 | 7 | false | false | true | false | high | collected += _executeUserOp(i, ops[i], opInfos[i]); | unknown | 51 | // Code block 1 (unknown):
collected += _executeUserOp(i, ops[i], opInfos[i]);
// Code block 2 (unknown):
totalOps += opsPerAggregator[i].userOps.length;
// Code block 3 (unknown):
collected += _executeUserOp(opIndex, ops[i], opInfos[opIndex]);
// Code block 4 (unknown):
paymasterIdBalances[paymasterId] += msg.value... | 4 | false | EntryPoint.sol, EntryPoint.sol#L81, EntryPoint.sol#L101, EntryPoint.sol#L135, VerifyingSingletonPaymaster.sol, VerifyingSingletonPaymaster.sol#L51, Math.sol | Math.sol, VerifyingSingletonPaymaster.sol, EntryPoint.sol | 7 | collected += _executeUserOp(i, ops[i], opInfos[i]); | true | totalOps += opsPerAggregator[i].userOps.length; | true | true | 10 | |||
c4 | 02-ethos | 0xnev G | High | high | ### Gas Optimization Template
| Count | Title | Instances |
|:--:|:-------|:--:|
| [G-01] | Usage of `uint` smaller than 32 bytes (256 bits) incurs overhead | 7 |
| [G-02] | Splitting `require()` statements that uses `&&` saves gas | 5 |
| [G-03] | internal/private functions only called once can be inlined to save gas ... | 7 results - 3 files
/TroveManager.sol
82: uint128 arrayIndex;
1321: uint128 index // dont need to downcast from uint256 to uint128
/StabilityPool.sol
247: uint128 _epoch, uint128 _scale
248: uint128 _epoch, uint128 _scale
249: uint128 _currentEpoch
250: uint128 _currentScale
/ReaperStrategyGranarySupplyOnly.s... | 1321: function _addTroveOwnerToArray(address _borrower, address _collateral) internal returns (uint256 index) {
1325: // Push the Troveowner to the array
1326: TroveOwners[_collateral].push(_borrower);
1327:
1328: // Record the index of the new Troveowner on their Trove struct
1329: index ... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/0xnev-G.md | 2026-01-02T18:15:52.755392+00:00 | 289d2f12dff50e84149d8cee909122fb38a405b3e90ad826ff70ac9d180f924e | 1 | 1 | 378 | 0 | false | false | true | false | high | 7 results - 3 files
/TroveManager.sol
82: uint128 arrayIndex;
1321: uint128 index // dont need to downcast from uint256 to uint128
/StabilityPool.sol
247: uint128 _epoch, uint128 _scale
248: uint128 _epoch, uint128 _scale
249: uint128 _currentEpoch
250: uint128 _currentScale
/ReaperStrategyGranarySupplyOnly.s... | solidity | 378 | // Code block 1 (solidity):
7 results - 3 files
/TroveManager.sol
82: uint128 arrayIndex;
1321: uint128 index // dont need to downcast from uint256 to uint128
/StabilityPool.sol
247: uint128 _epoch, uint128 _scale
248: uint128 _epoch, uint128 _scale
249: uint128 _currentEpoch
250: uint128 _currentScale
/Reape... | 1 | false | 7 results - 3 files
/TroveManager.sol
82: uint128 arrayIndex;
1321: uint128 index // dont need to downcast from uint256 to uint128
/StabilityPool.sol
247: uint128 _epoch, uint128 _scale
248: uint128 _epoch, uint128 _scale
249: uint128 _currentEpoch
250: uint128 _currentScale
/ReaperStrategyGranarySupplyOnly.s... | 0 | 7 results - 3 files
/TroveManager.sol
82: uint128 arrayIndex;
1321: uint128 index // dont need to downcast from uint256 to uint128
/StabilityPool.sol
247: uint128 _epoch, uint128 _scale
248: uint128 _epoch, uint128 _scale
249: uint128 _currentEpoch
250: uint128 _currentScale
/ReaperStrategyGranarySupplyOnly.s... | true | 1321: function _addTroveOwnerToArray(address _borrower, address _collateral) internal returns (uint256 index) {
1325: // Push the Troveowner to the array
1326: TroveOwners[_collateral].push(_borrower);
1327:
1328: // Record the index of the new Troveowner on their Trove struct
1329: index ... | true | true | 6 | ||||
c4 | 11-kelp | Pechenite Q | Critical | critical | # QA Report - Kelp DAO Audit Contest | 10 Nov 2023 - 15 Nov 2023
---
# Executive summary
### Overview
| | |
| :----------- | :----------------------------------------------------------------------- |
| Project Name | Kelp DAO ... | function addNodeDelegatorContractToQueue(
address[] calldata nodeDelegatorContracts
) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();
}
for (uint256 i; i < le... | // Deploy LRTDepositPool contract
// ...
// Repeatedly add NodeDelegator contract addresses to the queue
for (uint256 i = 0; i < 1000; i++) {
lrtDepositPool.addNodeDelegatorContractToQueue([nodeDelegatorAddress]);
} | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/Pechenite-Q.md | 2026-01-02T18:27:34.052706+00:00 | 291b76fec56f5061ea9ae52a823c936419322c6a8e7789fe8ff2afb35f13376a | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function addNodeDelegatorContractToQueue(
address[] calldata nodeDelegatorContracts
) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();
}
for (uint256 i; i < le... | true | // Deploy LRTDepositPool contract
// ...
// Repeatedly add NodeDelegator contract addresses to the queue
for (uint256 i = 0; i < 1000; i++) {
lrtDepositPool.addNodeDelegatorContractToQueue([nodeDelegatorAddress]);
} | true | true | 5 | ||||||||
c4 | 03-asymmetry | arialblack14 Q | Critical | critical | # QA REPORT
### Summary of low risk issues
| Number | Issue details | Instances |
|---|---|:---:|
| [L-1](#L1) | Lock pragmas to specific compiler version. | 4
| [L-2](#L2) | It is not checked if `derivativeCount > 0` which can cause a Panic Error if something happens during deployment. | 1
| [L-3](#L3) | No input val... | 2: pragma solidity ^0.8.13; | 2: pragma solidity ^0.8.13; | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/arialblack14-Q.md | 2026-01-02T18:18:48.581474+00:00 | 291bc3a52a0a1a6bae107482a53721f6123c70762fac368e157e3d406ad259f3 | 2 | 2 | 54 | 2 | false | false | true | false | high | 2: pragma solidity ^0.8.13; | solidity | 27 | // Code block 1 (solidity):
2: pragma solidity ^0.8.13;
// Code block 2 (solidity):
2: pragma solidity ^0.8.13; | 2 | false | 2: pragma solidity ^0.8.13;
2: pragma solidity ^0.8.13; | SafEth.sol#L2, Reth.sol#L2 | Reth.sol, SafEth.sol | 2 | 2: pragma solidity ^0.8.13; | true | 2: pragma solidity ^0.8.13; | true | true | 8 | ||
c4 | 11-kelp | 0xLeveler Q | Unknown | unknown | ## Title
`nodeDelegator` and `LRTDepositPoolContract` do not have any mechanism to remove node delegators from the queue when needed
## Proof of Concept
contract has a mechanism to add node delegators, but none to validate if they're valid contracts and remove them if they're added by mistake.
```solidity
function ad... | function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();
}
for (uin... | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/0xLeveler-Q.md | 2026-01-02T18:27:10.057212+00:00 | 293f6acef374598c8acdb6fad3853f13e2523e12d3bc11fb82afee0b610e65ff | 1 | 1 | 620 | 0 | false | true | true | false | medium | function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();
}
for (uin... | solidity | 620 | // Code block 1 (solidity):
function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();... | 1 | false | function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();
}
for (uin... | 0 | function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nodeDelegatorContracts.length;
if (nodeDelegatorQueue.length + length > maxNodeDelegatorCount) {
revert MaximumNodeDelegatorCountReached();
}
for (uin... | true | false | false | 4.14 | ||||||
c4 | 01-biconomy | 0xdeadbeef0x Q | Unknown | unknown | ## `executeBatch` will revert if single transaction fails
If an owner or EntryPoint (according to `_requireFromEntryPointOrOwner`) calls `executeBatch` with one transaction out of a batch that will fail, all other transactions in the batch will fail.
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175ae... | function executeBatch(address[] calldata dest, bytes[] calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
--------
for (uint i = 0; i < dest.length;) {
_call(dest[i], 0, func[i]);
--------
}
}
function _call(address target, uint256 value, bytes memory data) ... | function execute(address dest, uint value, bytes calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
------
}
function executeBatch(address[] calldata dest, bytes[] calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
------
} | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/0xdeadbeef0x-Q.md | 2026-01-02T18:12:49.056389+00:00 | 2943299f113fa2874cf692adfb2868cc8afe714ae3a9dc618315e0e05e13596a | 2 | 0 | 832 | 2 | false | false | true | false | high | function executeBatch(address[] calldata dest, bytes[] calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
--------
for (uint i = 0; i < dest.length;) {
_call(dest[i], 0, func[i]);
--------
}
}
function _call(address target, uint256 value, bytes memory data) ... | unknown | 542 | // Code block 1 (unknown):
function executeBatch(address[] calldata dest, bytes[] calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
--------
for (uint i = 0; i < dest.length;) {
_call(dest[i], 0, func[i]);
--------
}
}
function _call(address target, uint256... | 2 | false | SmartAccount.sol#L469, SmartAccount.sol#L461 | SmartAccount.sol | 2 | function executeBatch(address[] calldata dest, bytes[] calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
--------
for (uint i = 0; i < dest.length;) {
_call(dest[i], 0, func[i]);
--------
}
}
function _call(address target, uint256 value, bytes memory data) ... | true | function execute(address dest, uint value, bytes calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
------
}
function executeBatch(address[] calldata dest, bytes[] calldata func) external onlyOwner{
_requireFromEntryPointOrOwner();
------
} | true | true | 8 | |||
c4 | 03-asymmetry | Ignite G | Gas | gas | # Code4rena - Assymetic Gas
## Gas Optimizations
| | Issue | Instances |
|---|---|---|
| Gas-1 | Emitting events with variables from memory rather than state variables can help reduce gas costs | 4 |
| Gas-2 | Declare local variables as part of the function instead of inside the function | 1 |
### [Gas-1] Emitting ... | emit ChangeMinAmount(minAmount); | emit ChangeMaxAmount(maxAmount); | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Ignite-G.md | 2026-01-02T18:18:08.360827+00:00 | 297214ea11b6e9ee07cc1443750bc9cf5d6346de971f3cf37deb572a5ba76fd0 | 5 | 4 | 199 | 5 | false | false | true | false | high | emit ChangeMinAmount(minAmount); | solidity | 32 | // Code block 1 (solidity):
emit ChangeMinAmount(minAmount);
// Code block 2 (solidity):
emit ChangeMaxAmount(maxAmount);
// Code block 3 (solidity):
emit StakingPaused(pauseStaking);
// Code block 4 (solidity):
emit UnstakingPaused(pauseUnstaking);
// Code block 5 (unknown):
function deposit() external payable onl... | 5 | false | emit ChangeMinAmount(minAmount);
emit ChangeMaxAmount(maxAmount);
emit StakingPaused(pauseStaking);
emit UnstakingPaused(pauseUnstaking); | SafEth.sol#L216, SafEth.sol#L225, SafEth.sol#L234, SafEth.sol#L243, WstEth.sol#L73 | WstEth.sol, SafEth.sol | 5 | emit ChangeMinAmount(minAmount); | true | emit ChangeMaxAmount(maxAmount); | true | true | 11 | ||
c4 | 05-ajna | JCN G | High | high | # Summary
A majority of the optimizations were benchmarked via the protocol's tests, i.e. using the following config for `ajna-core`: `solc version 0.8.14`, `optimizer on`, `500 runs` and the following config for `ajna-grants`: `solc version 0.8.16`, `optimizer on`, `1000000 runs`. Optimizations that were not benchmark... | File: ajna-core/src/RewardsManager.sol
135: function moveStakedLiquidity(
136: uint256 tokenId_,
137: uint256[] memory fromBuckets_,
138: uint256[] memory toBuckets_,
139: uint256 expiry_
140: ) external nonReentrant override { | https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/base/StandardFunding.sol#L519-L521
https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/base/StandardFunding.sol#L612-L618
*Gas Savings for `GrantFund.fundingVote`, obtained via protocol's tests: Avg 1589 gas*
| ... | reentrancy | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/JCN-G.md | 2026-01-02T18:20:59.863093+00:00 | 297fdc9c751a8bd95210f81534aeb14e5e955c919eda20acda22f8b82c63b61c | 0 | 0 | 0 | 2 | false | false | false | false | medium | 0 | 0 | false | StandardFunding.sol#L519-L521, StandardFunding.sol#L612-L618 | StandardFunding.sol | 2 | File: ajna-core/src/RewardsManager.sol
135: function moveStakedLiquidity(
136: uint256 tokenId_,
137: uint256[] memory fromBuckets_,
138: uint256[] memory toBuckets_,
139: uint256 expiry_
140: ) external nonReentrant override { | true | https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/base/StandardFunding.sol#L519-L521
https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/base/StandardFunding.sol#L612-L618
*Gas Savings for `GrantFund.fundingVote`, obtained via protocol's tests: Avg 1589 gas*
| ... | true | true | 6 | ||||||
c4 | 03-asymmetry | Diana G | Gas | gas |
---------------------------
**Gas Optimization**
----------
| S No. | Issue | Instances | Gas Savings (from provided tests) |
|-----|-----|-----|-----|
| [G-01] | x += y costs more gas than x = x + y for state variables | 4 | 452
| [G-02] | Don't compare boolean expressions to boolean literals | 2 | 110
--------... | File: SafEth/SafEth.sol
72-75: underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18;
95: totalStakeValueEth += derivativeReceivedEthValue;
172: localTotalWeight += weights[i];
192: localTotalWeight += we... | File: SafEth/SafEth.sol
64: require(pauseStaking == false, "staking is paused");
109: require(pauseUnstaking == false, "unstaking is paused"); | other | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Diana-G.md | 2026-01-02T18:18:02.017249+00:00 | 29af425bca33f32621afc4d7332ec667269f5ac57311f3b3892df17d297208e9 | 2 | 0 | 472 | 1 | false | false | true | false | high | File: SafEth/SafEth.sol
72-75: underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18;
95: totalStakeValueEth += derivativeReceivedEthValue;
172: localTotalWeight += weights[i];
192: localTotalWeight += we... | unknown | 329 | // Code block 1 (unknown):
File: SafEth/SafEth.sol
72-75: underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18;
95: totalStakeValueEth += derivativeReceivedEthValue;
172: localTotalWeight += weights[i];
... | 2 | false | SafEth.sol | SafEth.sol | 1 | File: SafEth/SafEth.sol
72-75: underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18;
95: totalStakeValueEth += derivativeReceivedEthValue;
172: localTotalWeight += weights[i];
192: localTotalWeight += we... | true | File: SafEth/SafEth.sol
64: require(pauseStaking == false, "staking is paused");
109: require(pauseUnstaking == false, "unstaking is paused"); | true | true | 8 | |||
c4 | 06-lybra | nadin Q | Critical | critical | # QA Report
## Summary
Total 04 Low and 09 Non-Critical
### Low Risk Issues
[L-01] getAssetPrice() SHOULD BE TURNED INTO A VIEW FUNCTION
[L-02] REFACTORING TO SUPPORT UINT256 AMOUNT
[L-03] ROUNDING ERROR IN `purchaseOtherEarnings()` MIGHT RESULT IN `biddingFee`
[L-04] MAY LEAD TO DOS IF `curvePool.exchange_underlying` ... | File: LybraRETHVault
46: function getAssetPrice() public override returns (uint256) {
File: LybraWbETHVault.sol
34: function getAssetPrice() public override returns (uint256) { // @audit change to view function
File: LybraWstETHVault.sol
48: function getAssetPrice() public override returns (uint256) {
File: Ly... | The scope of this PR:
Remove type(uint64).max limit for amount from OFTV2Core, ProxyOFTV2 and ProxyOFTWithFee
Introduce OFTV2Aptos, ProxyOFTV2Aptos, ProxyOFTWithFeeAptos that allow no more than 6 shared decimals and have type(uint64).max limit for amount
Replace abi.encodePacked with abi.encode in OFTV2Core and derive... | reentrancy | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/nadin-Q.md | 2026-01-02T18:23:11.799662+00:00 | 29d00837a27c6770f3bef904942b6b6a3b6e9f5b5f6d79146842d6764305fccd | 1 | 0 | 504 | 5 | false | false | true | false | high | File: LybraRETHVault
46: function getAssetPrice() public override returns (uint256) {
File: LybraWbETHVault.sol
34: function getAssetPrice() public override returns (uint256) { // @audit change to view function
File: LybraWstETHVault.sol
48: function getAssetPrice() public override returns (uint256) {
File: Ly... | unknown | 504 | // Code block 1 (unknown):
File: LybraRETHVault
46: function getAssetPrice() public override returns (uint256) {
File: LybraWbETHVault.sol
34: function getAssetPrice() public override returns (uint256) { // @audit change to view function
File: LybraWstETHVault.sol
48: function getAssetPrice() public override r... | 1 | false | LybraRETHVault.sol#L46, LybraWstETHVault.sol#L48, LybraWbETHVault.sol#L34, LybraEUSDVaultBase.sol#L327, LybraPeUSDVaultBase.sol#L269 | LybraEUSDVaultBase.sol, LybraWstETHVault.sol, LybraRETHVault.sol, LybraWbETHVault.sol, LybraPeUSDVaultBase.sol | 5 | File: LybraRETHVault
46: function getAssetPrice() public override returns (uint256) {
File: LybraWbETHVault.sol
34: function getAssetPrice() public override returns (uint256) { // @audit change to view function
File: LybraWstETHVault.sol
48: function getAssetPrice() public override returns (uint256) {
File: Ly... | true | The scope of this PR:
Remove type(uint64).max limit for amount from OFTV2Core, ProxyOFTV2 and ProxyOFTWithFee
Introduce OFTV2Aptos, ProxyOFTV2Aptos, ProxyOFTWithFeeAptos that allow no more than 6 shared decimals and have type(uint64).max limit for amount
Replace abi.encodePacked with abi.encode in OFTV2Core and derive... | true | true | 7 | |||
c4 | 09-ondo | 0xStalin Q | Low | low | ## [L-01] Number of approvers can be set to be greather than the existing approvers in the DestinatinationBridge contract
When [setting the tresholds](https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/bridge/DestinationBridge.sol#L255-L279) in the DestinationBridge, there is no checks to validate if the n... | function setThresholds(
string calldata srcChain,
uint256[] calldata amounts,
uint256[] calldata numOfApprovers
) external onlyOwner {
if (amounts.length != numOfApprovers.length) {
revert ArrayLengthMismatch();
}
delete chainToThresholds[srcChain];
for (uint256 i = 0; i < amounts.length; ++i) {
i... | function _attachThreshold(
uint256 amount,
bytes32 txnHash,
string memory srcChain
) internal {
Threshold[] memory thresholds = chainToThresholds[srcChain];
for (uint256 i = 0; i < thresholds.length; ++i) {
Threshold memory t = thresholds[i];
if (amount <= t.amount) {
txnToThresholdSet[txnHash] ... | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/0xStalin-Q.md | 2026-01-02T18:25:14.393941+00:00 | 29e4fd671d432b7aaaadb0b19debf53f23af7e5657f88f66f16ee860be988bb2 | 1 | 1 | 843 | 1 | false | false | true | false | high | function setThresholds(
string calldata srcChain,
uint256[] calldata amounts,
uint256[] calldata numOfApprovers
) external onlyOwner {
if (amounts.length != numOfApprovers.length) {
revert ArrayLengthMismatch();
}
delete chainToThresholds[srcChain];
for (uint256 i = 0; i < amounts.length; ++i) {
i... | solidity | 843 | // Code block 1 (solidity):
function setThresholds(
string calldata srcChain,
uint256[] calldata amounts,
uint256[] calldata numOfApprovers
) external onlyOwner {
if (amounts.length != numOfApprovers.length) {
revert ArrayLengthMismatch();
}
delete chainToThresholds[srcChain];
for (uint256 i = 0; i < ... | 1 | false | function setThresholds(
string calldata srcChain,
uint256[] calldata amounts,
uint256[] calldata numOfApprovers
) external onlyOwner {
if (amounts.length != numOfApprovers.length) {
revert ArrayLengthMismatch();
}
delete chainToThresholds[srcChain];
for (uint256 i = 0; i < amounts.length; ++i) {
i... | DestinationBridge.sol#L255-L279 | DestinationBridge.sol | 1 | function setThresholds(
string calldata srcChain,
uint256[] calldata amounts,
uint256[] calldata numOfApprovers
) external onlyOwner {
if (amounts.length != numOfApprovers.length) {
revert ArrayLengthMismatch();
}
delete chainToThresholds[srcChain];
for (uint256 i = 0; i < amounts.length; ++i) {
i... | true | function _attachThreshold(
uint256 amount,
bytes32 txnHash,
string memory srcChain
) internal {
Threshold[] memory thresholds = chainToThresholds[srcChain];
for (uint256 i = 0; i < thresholds.length; ++i) {
Threshold memory t = thresholds[i];
if (amount <= t.amount) {
txnToThresholdSet[txnHash] ... | true | true | 7 | ||
c4 | 01-salty | Raihan G | Critical | critical | # GAS OPTIMIZATION
# SUMMARY
| | issue | instance |
| ------ | ----------------------------------------------------------------------------------- | -------- |
| [G‑01] | Gas Optimization: Declare Variables Outside the Loop ... | contract MyContract {
function sum(uint256[] memory values) public pure returns (uint256) {
for (uint256 i = 0; i < values.length; i++) {
uint256 total; // This declaration is inside the loop and not initialized
total += values[i];
}
return total; // This line will r... | contract MyContract {
function sum(uint256[] memory values) public pure returns (uint256) {
uint256 total; // Declare the variable outside the loop without initializing
for (uint256 i = 0; i < values.length; i++) {
total += values[i];
}
return total;
}
} | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/Raihan-G.md | 2026-01-02T19:01:26.421600+00:00 | 2a625659e3576800a7cbecdbee556ceedf2bf17ac0a2fe522665a19bce3136c7 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | contract MyContract {
function sum(uint256[] memory values) public pure returns (uint256) {
for (uint256 i = 0; i < values.length; i++) {
uint256 total; // This declaration is inside the loop and not initialized
total += values[i];
}
return total; // This line will r... | true | contract MyContract {
function sum(uint256[] memory values) public pure returns (uint256) {
uint256 total; // Declare the variable outside the loop without initializing
for (uint256 i = 0; i < values.length; i++) {
total += values[i];
}
return total;
}
} | true | true | 5 | ||||||||
c4 | 05-ajna | TS Q | Unknown | unknown | #title
Lack of verification if NFT destination address handles ERC721
#Description
The ``unstake`` of the ``RewardsManager`` contract does not verify if the NFT recipient is capable of receiving ERC721. The caller is responsible to confirm that the recipient is capable of receiving ERC721 or else they may be permanent... | function unstake(
uint256 tokenId_
) external override {
...omitted for brevity...
IERC721(address(positionManager)).transferFrom(address(this), msg.sender, tokenId_);
} | upgrade | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/TS-Q.md | 2026-01-02T18:21:16.387824+00:00 | 2a8c8524ca283e24121af0343acad85ed21ecc95bfc7b0bbe9d26bd499c0f525 | 1 | 0 | 201 | 1 | false | true | true | false | medium | function unstake(
uint256 tokenId_
) external override {
...omitted for brevity...
IERC721(address(positionManager)).transferFrom(address(this), msg.sender, tokenId_);
} | unknown | 201 | // Code block 1 (unknown):
function unstake(
uint256 tokenId_
) external override {
...omitted for brevity...
IERC721(address(positionManager)).transferFrom(address(this), msg.sender, tokenId_);
} | 1 | false | RewardsManager.sol#L250 | RewardsManager.sol | 1 | function unstake(
uint256 tokenId_
) external override {
...omitted for brevity...
IERC721(address(positionManager)).transferFrom(address(this), msg.sender, tokenId_);
} | true | false | false | 5.23 | |||||
c4 | 04-caviar | 0xWaitress Q | Unknown | unknown | In the function PrivatePool::buy, tokenIds are looped twice, in the second loop the important task is to transfer royalty fee to the recipient, but the result of _getRoyalty can actually be skipped since it was called in the earlier loop
https://github.com/code-423n4/2023-04-caviar/blob/main/src/PrivatePool.sol#L271-L... | if (payRoyalties) {
for (uint256 i = 0; i < tokenIds.length; i++) {
// get the royalty fee for the NFT
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice); @> audit
// transfer the royalty fee to the recipient if it's greater... | +++ uint256[] memory royaltyFees;
+++ address[] memory recipients;
for (uint256 i = 0; i < tokenIds.length; i++) {
// transfer the NFT to the caller
ERC721(nft).safeTransferFrom(address(this), msg.sender, tokenIds[i]);
if (payRoyalties) {
// get the royalty fee for t... | other | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/0xWaitress-Q.md | 2026-01-02T18:19:21.234233+00:00 | 2a98994d3323dad743ea2624fe46cce5417948939ca3968d0d57ed7349242e88 | 2 | 2 | 1,299 | 2 | false | false | true | false | high | if (payRoyalties) {
for (uint256 i = 0; i < tokenIds.length; i++) {
// get the royalty fee for the NFT
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice); @> audit
// transfer the royalty fee to the recipient if it's greater than 0
... | solidity | 645 | // Code block 1 (solidity):
if (payRoyalties) {
for (uint256 i = 0; i < tokenIds.length; i++) {
// get the royalty fee for the NFT
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice); @> audit
// transfer the royalty fee to the recip... | 2 | false | if (payRoyalties) {
for (uint256 i = 0; i < tokenIds.length; i++) {
// get the royalty fee for the NFT
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice); @> audit
// transfer the royalty fee to the recipient if it's greater than 0
... | PrivatePool.sol#L271-L283, PrivatePool.sol#L238-L249 | PrivatePool.sol | 2 | if (payRoyalties) {
for (uint256 i = 0; i < tokenIds.length; i++) {
// get the royalty fee for the NFT
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice); @> audit
// transfer the royalty fee to the recipient if it's greater... | true | +++ uint256[] memory royaltyFees;
+++ address[] memory recipients;
for (uint256 i = 0; i < tokenIds.length; i++) {
// transfer the NFT to the caller
ERC721(nft).safeTransferFrom(address(this), msg.sender, tokenIds[i]);
if (payRoyalties) {
// get the royalty fee for t... | true | true | 8 | ||
c4 | 01-salty | BioMatriX Analysis | Critical | critical | ### [H-1] Unauthorized Access in InitialDistribution.sol (External Function Accessibility)
**Description:**
The `distributionApproved` function is external and can be called by anyone. It's crucial to ensure that the `BootstrapBallot` contract itself has the proper access control to prevent unauthorized execution.
*... | `require( msg.sender == address(bootstrapBallot), "InitialDistribution.distributionApproved can only be called from the BootstrapBallot contract" );` | require( msg.sender == address(exchangeConfig.initialDistribution().bootstrapBallot()), "Only the BootstrapBallot can call Airdrop.authorizeWallet" );
require( ! claimingAllowed, "Cannot authorize after claiming is allowed" ); | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/BioMatriX-Analysis.md | 2026-01-02T19:01:14.647782+00:00 | 2aa036d7b9a575a0be326569cc8be61077ae05e52859b3d25d18b8569672e92a | 2 | 0 | 375 | 0 | false | false | true | false | high | `require( msg.sender == address(bootstrapBallot), "InitialDistribution.distributionApproved can only be called from the BootstrapBallot contract" );` | unknown | 149 | // Code block 1 (unknown):
`require( msg.sender == address(bootstrapBallot), "InitialDistribution.distributionApproved can only be called from the BootstrapBallot contract" );`
// Code block 2 (unknown):
require( msg.sender == address(exchangeConfig.initialDistribution().bootstrapBallot()), "Only the BootstrapBallot c... | 2 | false | 0 | `require( msg.sender == address(bootstrapBallot), "InitialDistribution.distributionApproved can only be called from the BootstrapBallot contract" );` | true | require( msg.sender == address(exchangeConfig.initialDistribution().bootstrapBallot()), "Only the BootstrapBallot can call Airdrop.authorizeWallet" );
require( ! claimingAllowed, "Cannot authorize after claiming is allowed" ); | true | true | 7 | |||||
c4 | 09-ondo | JP_Courses Q | Low | low | 0. QA/LOW: Lack of address(0) checks, relying solely on trusting that the privileged/admin access users will not accidentally pass zero addresses as function parameters.
1. QA: lack of input validation for `_amount`, possible to pass zero value. Possible to send zero rUSDY tokens to another user.
https://github.com/c... | function transfer(address _recipient, uint256 _amount) public returns (bool) {
++ require(_amount != 0);
_transfer(msg.sender, _recipient, _amount);
return true;
} | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/JP_Courses-Q.md | 2026-01-02T18:25:31.309570+00:00 | 2ab03368c3a6eaa91d114d5c3307f7c2b750535b1daa82acfa006c947cf589b2 | 1 | 1 | 176 | 4 | false | true | true | false | high | function transfer(address _recipient, uint256 _amount) public returns (bool) {
++ require(_amount != 0);
_transfer(msg.sender, _recipient, _amount);
return true;
} | solidity | 176 | // Code block 1 (solidity):
function transfer(address _recipient, uint256 _amount) public returns (bool) {
++ require(_amount != 0);
_transfer(msg.sender, _recipient, _amount);
return true;
} | 1 | false | function transfer(address _recipient, uint256 _amount) public returns (bool) {
++ require(_amount != 0);
_transfer(msg.sender, _recipient, _amount);
return true;
} | rUSDY.sol#L246, rUSDY.sol#L276, rUSDY.sol#L330, rUSDY.sol#L437 | rUSDY.sol | 4 | function transfer(address _recipient, uint256 _amount) public returns (bool) {
++ require(_amount != 0);
_transfer(msg.sender, _recipient, _amount);
return true;
} | true | false | false | 5.61 | ||||
c4 | 01-biconomy | chrisdior4 Q | Critical | critical | # QA report
## Low Risk
| L-R |Issue|Instances|
|:------:|:----|:-------:|
| [L‑01] | Use the latest version of OpenZeppelin | 1 |
| [L‑02] | Unused/empty receive()/fallback() function | 1 |
| [L‑03] | Avoid the use of tx.origin | 1 |
Total: 3 instances over 3 issues
## Non-critical
| N-C ... | "@openzeppelin/contracts": "^4.7.3", | receive() external payable {} | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/chrisdior4-Q.md | 2026-01-02T18:13:37.797329+00:00 | 2ac2f795ce4d038e4b31900fa1f47fa9ffe342663478b14d869dcef0e68ea871 | 2 | 2 | 65 | 1 | false | false | true | false | high | "@openzeppelin/contracts": "^4.7.3", | solidity | 36 | // Code block 1 (solidity):
"@openzeppelin/contracts": "^4.7.3",
// Code block 2 (solidity):
receive() external payable {} | 2 | false | "@openzeppelin/contracts": "^4.7.3",
receive() external payable {} | SmartAccount.sol#L550 | SmartAccount.sol | 1 | "@openzeppelin/contracts": "^4.7.3", | true | receive() external payable {} | true | true | 8 | ||
c4 | 04-caviar | abiih G | High | high | # Report
---
## Gas Optimizations
---
| | Issue |
| --- | ----------------------------------------------------------------------------------------------... | 2. ### Use external instead of public where possible
Functions with the public visibility modifier are costlier than external. Default to using the external modifier until you need to expose it to other functions within your contract.
- https://github.com/code-423n4/2023-04-caviar/blob/main/src/PrivatePool.sol#L157... | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/abiih-G.md | 2026-01-02T18:20:12.864424+00:00 | 2adfcf8f4aa947dcda0698951cba3176d502bfa4e8c13c1ccdb23263c7e00667 | 1 | 1 | 73 | 10 | false | true | true | false | high | - uint16 public protocolFeeRate;
+ uint16 public protocolFeeRate; | diff | 73 | // Code block 1 (diff):
- uint16 public protocolFeeRate;
+ uint16 public protocolFeeRate; | 1 | true | - uint16 public protocolFeeRate;
+ uint16 public protocolFeeRate; | Factory.sol#L51, PrivatePool.sol#L88, PrivatePool.sol#L91, PrivatePool.sol#L157, PrivatePool.sol#L211, PrivatePool.sol#L301, PrivatePool.sol#L385, PrivatePool.sol#L459, PrivatePool.sol#L484, PrivatePool.sol#L602 | PrivatePool.sol, Factory.sol | 10 | 2. ### Use external instead of public where possible
Functions with the public visibility modifier are costlier than external. Default to using the external modifier until you need to expose it to other functions within your contract.
- https://github.com/code-423n4/2023-04-caviar/blob/main/src/PrivatePool.sol#L157... | true | false | false | 8 | ||||
c4 | 08-dopex | report | Critical | critical | ---
sponsor: "Dopex"
slug: "2023-08-dopex"
date: "2023-12-29"
title: "Dopex "
findings: "https://github.com/code-423n4/2023-08-dopex-findings/issues"
contest: 278
---
# Overview
## About C4
Code4rena (C4) is an open organization consisting of security researchers, auditors, developers, and individuals with domain ex... | function bond(
uint256 _amount,
uint256 rdpxBondId,
address _to
) public returns (uint256 receiptTokenAmount) {
_whenNotPaused();
// Validate amount
_validate(_amount > 0, 4);
// Compute the bond cost
(uint256 rdpxRequired, uint256 wethRequired) = calculateBondCost(
_amount,
rdpxBondId
);
.... | function calculateBondCost(
uint256 _amount,
uint256 _rdpxBondId
) public view returns (uint256 rdpxRequired, uint256 wethRequired) {
uint256 rdpxPrice = getRdpxPrice();
...
uint256 strike = IPerpetualAtlanticVault(addresses.perpetualAtlanticVault)
.roundUp(rdpxPrice - (rdpxPrice / 4)); // 25% below the... | reentrancy | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/report.md | 2026-01-02T18:25:09.501072+00:00 | 2b27b3bac7c747ce517b3d3de123a4e27d522376b7636e5dbbeeb4917b7fe769 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function bond(
uint256 _amount,
uint256 rdpxBondId,
address _to
) public returns (uint256 receiptTokenAmount) {
_whenNotPaused();
// Validate amount
_validate(_amount > 0, 4);
// Compute the bond cost
(uint256 rdpxRequired, uint256 wethRequired) = calculateBondCost(
_amount,
rdpxBondId
);
.... | true | function calculateBondCost(
uint256 _amount,
uint256 _rdpxBondId
) public view returns (uint256 rdpxRequired, uint256 wethRequired) {
uint256 rdpxPrice = getRdpxPrice();
...
uint256 strike = IPerpetualAtlanticVault(addresses.perpetualAtlanticVault)
.roundUp(rdpxPrice - (rdpxPrice / 4)); // 25% below the... | true | true | 5 | ||||||||
c4 | 11-kelp | Rickard G | Medium | medium | ## [G-01] Remove the `initializer` modifier
If we can just ensure that the `initialize()` function can only be called from within the constructor, we shouldn’t need to worry about it getting called again.
````solidity
src/LRTConfig.sol
41: function initialize(
42: address admin,
43: address stETH,
44: ... | src/LRTConfig.sol
41: function initialize(
42: address admin,
43: address stETH,
44: address rETH,
45: address cbETH,
46: address rsETH_
47: )
48: external
49: initializer
50: { | src/LRTDepositPool.sol
31: function initialize(address lrtConfigAddr) external initializer { | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/Rickard-G.md | 2026-01-02T18:27:36.302906+00:00 | 2b42b073f4e55b07ac6abcb2e858cb194541114e40d94d4d28f4838179046f3b | 5 | 5 | 615 | 5 | false | false | true | false | high | src/LRTConfig.sol
41: function initialize(
42: address admin,
43: address stETH,
44: address rETH,
45: address cbETH,
46: address rsETH_
47: )
48: external
49: initializer
50: { | solidity | 235 | // Code block 1 (solidity):
src/LRTConfig.sol
41: function initialize(
42: address admin,
43: address stETH,
44: address rETH,
45: address cbETH,
46: address rsETH_
47: )
48: external
49: initializer
50: {
// Code block 2 (solidity):
src/LRTDepositPool.sol
31: ... | 5 | false | src/LRTConfig.sol
41: function initialize(
42: address admin,
43: address stETH,
44: address rETH,
45: address cbETH,
46: address rsETH_
47: )
48: external
49: initializer
50: {
src/LRTDepositPool.sol
31: function initialize(address lrtConfigAddr) external i... | LRTConfig.sol#L41-L50, LRTDepositPool.sol#L31, LRTOracle.sol#L29, NodeDelegator.sol#L26, RSETH.sol#L32 | LRTOracle.sol, RSETH.sol, NodeDelegator.sol, LRTConfig.sol, LRTDepositPool.sol | 5 | src/LRTConfig.sol
41: function initialize(
42: address admin,
43: address stETH,
44: address rETH,
45: address cbETH,
46: address rsETH_
47: )
48: external
49: initializer
50: { | true | src/LRTDepositPool.sol
31: function initialize(address lrtConfigAddr) external initializer { | true | true | 11 | ||
c4 | 02-ethos | descharre G | High | high | # Summary
|ID | Finding| Gas saved | Instances|
|:----: | :--- | :----: |:----: |
|G-01 |Make for loops unchecked| - | 12 |
|G-02 |Add unchecked block when operands can't under/overflow| 536 | 15 |
|G-03 |Don't write to memory when variable is only used once| 10 | 1 |
|G-... | ## [G-02] Add unchecked block when operands can't under/overflow
When operands can't underflow/overflow because of a previous require() or if statement, you can use an unchecked block.
The default "checked" behavior costs more gas when calculating, because under-the-hood the EVM does extra checks for over/underflow.
|C... | Can be changed to: | reentrancy | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/descharre-G.md | 2026-01-02T18:17:05.125830+00:00 | 2b96c1151e7caec8daec3d83f1b0a6a2e0c8f19081bf08505daa5ae85f4c62b8 | 0 | 0 | 0 | 9 | false | false | false | false | medium | 0 | 0 | false | ActivePool.sol#L108-L113, CollateralConfig.sol#L56-L73, StabilityPool.sol#L351-L356, ReaperVaultV2.sol#L194, ReaperVaultV2.sol#L391, ReaperVaultV2.sol#L396, ReaperVaultV2.sol#L330, ReaperStrategyGranarySupplyOnly.sol#L93, ReaperStrategyGranarySupplyOnly.sol#L100 | StabilityPool.sol, ReaperStrategyGranarySupplyOnly.sol, ReaperVaultV2.sol, ActivePool.sol, CollateralConfig.sol | 9 | ## [G-02] Add unchecked block when operands can't under/overflow
When operands can't underflow/overflow because of a previous require() or if statement, you can use an unchecked block.
The default "checked" behavior costs more gas when calculating, because under-the-hood the EVM does extra checks for over/underflow.
|C... | true | Can be changed to: | true | true | 6 | ||||||
c4 | 04-caviar | ACai G | Gas | gas | # verifing `public` to `external` for saving gas
Suggest to verify the function visibility quantifiers from `public` to `external` for saving gas.
- Factory.setPrivatePoolMetadata, Line 129
- Factory.setPrivatePoolImplementation, Line 135
- Factory.setProtocolFeeRate, Line 141
- Factory.withdraw, Line 148
# verifing... | constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
factory = payable(_factory);
royaltyRegistry = _royaltyRegistry;
stolenNftOracle = _stolenNftOracle;
} | oracle | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/ACai-G.md | 2026-01-02T18:19:26.230435+00:00 | 2b9c5813cd767856c21eab19ac399198c34e9254b849e658a051220be3f36451 | 1 | 1 | 214 | 0 | false | true | true | false | medium | constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
factory = payable(_factory);
royaltyRegistry = _royaltyRegistry;
stolenNftOracle = _stolenNftOracle;
} | solidity | 214 | // Code block 1 (solidity):
constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
factory = payable(_factory);
royaltyRegistry = _royaltyRegistry;
stolenNftOracle = _stolenNftOracle;
} | 1 | false | constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
factory = payable(_factory);
royaltyRegistry = _royaltyRegistry;
stolenNftOracle = _stolenNftOracle;
} | 0 | constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
factory = payable(_factory);
royaltyRegistry = _royaltyRegistry;
stolenNftOracle = _stolenNftOracle;
} | true | false | false | 3.6 | ||||||
c4 | 11-kelp | report | Critical | critical | ---
sponsor: "Kelp DAO"
slug: "2023-11-kelp"
date: "2023-12-11"
title: "Kelp DAO | rsETH"
findings: "https://github.com/code-423n4/2023-11-kelp-findings/issues"
contest: 305
---
# Overview
## About C4
Code4rena (C4) is an open organization consisting of security researchers, auditors, developers, and individuals wit... | contract LRTOracleMock {
uint256 public price;
constructor(uint256 _price) {
price = _price;
}
function getAssetPrice(address) external view returns (uint256) {
return price;
}
functio... | There is long chain of calls:
| reentrancy | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/report.md | 2026-01-02T18:28:31.501320+00:00 | 2bf63e52c8da8b83a0a36edaa50d860832015f580d0b7a12254e554b9e807778 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | contract LRTOracleMock {
uint256 public price;
constructor(uint256 _price) {
price = _price;
}
function getAssetPrice(address) external view returns (uint256) {
return price;
}
functio... | true | There is long chain of calls:
| true | true | 5 | ||||||||
c4 | 10-badger | ladboy233 Q | Critical | critical | | Issue Number | Description | Suggested Action |
|--------------|---------------------------------------------------------------------|----------------------------------------------|
| 1 | Function `flashFee` in `ActivePool`... | function _transferShares(address _sender, address _recipient, uint256 _sharesAmount) internal {
require(_sender != address(0), "TRANSFER_FROM_ZERO_ADDR");
require(_recipient != address(0), "TRANSFER_TO_ZERO_ADDR");
require(_recipient != address(this), "TRANSFER_TO_STETH_CONTRACT");
_whe... | function flashFee(address token, uint256 amount) public view override returns (uint256) {
require(token == address(collateral), "ActivePool: collateral Only");
require(!flashLoansPaused, "ActivePool: Flash Loans Paused");
require(ACTIVE_FLAG_POSITION.getStorageBool(), "collateral paused") // ... | access-control | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/ladboy233-Q.md | 2026-01-02T18:26:53.808055+00:00 | 2bf743be0cbbaabcc8411c09617fdb1bc0070265775059ea26a7292a28757e9f | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function _transferShares(address _sender, address _recipient, uint256 _sharesAmount) internal {
require(_sender != address(0), "TRANSFER_FROM_ZERO_ADDR");
require(_recipient != address(0), "TRANSFER_TO_ZERO_ADDR");
require(_recipient != address(this), "TRANSFER_TO_STETH_CONTRACT");
_whe... | true | function flashFee(address token, uint256 amount) public view override returns (uint256) {
require(token == address(collateral), "ActivePool: collateral Only");
require(!flashLoansPaused, "ActivePool: Flash Loans Paused");
require(ACTIVE_FLAG_POSITION.getStorageBool(), "collateral paused") // ... | true | true | 5 | ||||||||
c4 | 09-ondo | jnrlouis G | Low | low | # Report
## Gas Optimization
| | Issue | Instances |
| ---------------------- | ------------ | -------------- |
| [GAS-1] | Cache array length outside of loop | 5 |
| [GAS-2] | Don't initialize variables with default value | 8 |
| [GAS-3] | Functions guaranteed to rever... | File: SourceBridge.sol
for (uint256 i = 0; i < exCallData.length; ++i)
| File: DesinationBridge.sol
134 for (uint256 i = 0; i < thresholds.length; ++i)
160 for (uint256 i = 0; i < t.approvers.length; ++i)
264 for (uint256 i = 0; i < amounts.length; ++i)
| access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/jnrlouis-G.md | 2026-01-02T18:26:00.536186+00:00 | 2c089c8fd9a0b279ecb6371663897c135d84fa995d6573a6ae02ee0ae7381a2e | 7 | 0 | 860 | 0 | false | false | true | false | high | File: SourceBridge.sol
for (uint256 i = 0; i < exCallData.length; ++i) | unknown | 75 | // Code block 1 (unknown):
File: SourceBridge.sol
for (uint256 i = 0; i < exCallData.length; ++i)
// Code block 2 (unknown):
File: DesinationBridge.sol
134 for (uint256 i = 0; i < thresholds.length; ++i)
160 for (uint256 i = 0; i < t.approvers.length; ++i)
264 for (uint256 i = 0; i < amounts.length... | 7 | false | 0 | File: SourceBridge.sol
for (uint256 i = 0; i < exCallData.length; ++i)
| true | File: DesinationBridge.sol
134 for (uint256 i = 0; i < thresholds.length; ++i)
160 for (uint256 i = 0; i < t.approvers.length; ++i)
264 for (uint256 i = 0; i < amounts.length; ++i)
| true | true | 12 | |||||
c4 | 05-ajna | ayden Q | Medium | medium | 1.The initial value of rewards is 0, so there is no need to use the += operator. We can simply use the = operator to assign the value
https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/RewardsManager.sol#L801
```solidity
// skip reward calculation if update at the previous epoch was missed and if e... | // skip reward calculation if update at the previous epoch was missed and if exchange rate decreased due to bad debt
// prevents excess rewards from being provided from using a 0 value as an input to the interestFactor calculation below.
if (prevBucketExchangeRate != 0 && prevBucketExchangeRate < curBucketE... | function claimRewards(
uint256 tokenId_,
uint256 epochToClaim_
) external override {
StakeInfo storage stakeInfo = stakes[tokenId_];
if (msg.sender != stakeInfo.owner) revert NotOwnerOfDeposit();
_ if (isEpochClaimed[tokenId_][epochToClaim_]) revert AlreadyClaimed();
+ ... | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/ayden-Q.md | 2026-01-02T18:21:21.582044+00:00 | 2c3357d8b3b1b6bd4eb974557f017a5af8e2566d860110b8ce9e5bd9d19f0d37 | 1 | 1 | 994 | 2 | false | false | true | false | high | // skip reward calculation if update at the previous epoch was missed and if exchange rate decreased due to bad debt
// prevents excess rewards from being provided from using a 0 value as an input to the interestFactor calculation below.
if (prevBucketExchangeRate != 0 && prevBucketExchangeRate < curBucketExcha... | solidity | 994 | // Code block 1 (solidity):
// skip reward calculation if update at the previous epoch was missed and if exchange rate decreased due to bad debt
// prevents excess rewards from being provided from using a 0 value as an input to the interestFactor calculation below.
if (prevBucketExchangeRate != 0 && prevBucketE... | 1 | false | // skip reward calculation if update at the previous epoch was missed and if exchange rate decreased due to bad debt
// prevents excess rewards from being provided from using a 0 value as an input to the interestFactor calculation below.
if (prevBucketExchangeRate != 0 && prevBucketExchangeRate < curBucketExcha... | RewardsManager.sol#L801, RewardsManager.sol#L114 | RewardsManager.sol | 2 | // skip reward calculation if update at the previous epoch was missed and if exchange rate decreased due to bad debt
// prevents excess rewards from being provided from using a 0 value as an input to the interestFactor calculation below.
if (prevBucketExchangeRate != 0 && prevBucketExchangeRate < curBucketE... | true | function claimRewards(
uint256 tokenId_,
uint256 epochToClaim_
) external override {
StakeInfo storage stakeInfo = stakes[tokenId_];
if (msg.sender != stakeInfo.owner) revert NotOwnerOfDeposit();
_ if (isEpochClaimed[tokenId_][epochToClaim_]) revert AlreadyClaimed();
+ ... | true | true | 7 | ||
c4 | 11-kelp | kerdakov Q | Low | low | The use of `unchecked` in the for loop in [NodeDelegator](https://github.com/code-423n4/2023-11-kelp/blob/c5fdc2e62c5e1d78769f44d6e34a6fb9e40c00f0/src/NodeDelegator.sol#L109C8-L115C10) seems unnecessary and could potentially lead to unintended consequences. The loop itself doesn't involve arithmetic operations that cou... | for (uint256 i = 0; i < strategiesLength;) {
assets[i] = address(IStrategy(strategies[i]).underlyingToken());
assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));
unchecked {
++i;
}
} | for (uint256 i = 0; i < strategiesLength; i++) {
assets[i] = address(IStrategy(strategies[i]).underlyingToken());
assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));
} | overflow | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/kerdakov-Q.md | 2026-01-02T18:28:11.798257+00:00 | 2cdc1008d7986ce57bbb337942783ebe9b18cb04452e7c902fbd722099ba5453 | 2 | 0 | 435 | 1 | false | false | true | false | high | for (uint256 i = 0; i < strategiesLength;) {
assets[i] = address(IStrategy(strategies[i]).underlyingToken());
assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));
unchecked {
++i;
}
} | unknown | 233 | // Code block 1 (unknown):
for (uint256 i = 0; i < strategiesLength;) {
assets[i] = address(IStrategy(strategies[i]).underlyingToken());
assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));
unchecked {
++i;
}
}
// Code block 2 (unknown):
for (uint256 i = 0; i < strateg... | 2 | false | NodeDelegator.sol#L109-L8 | NodeDelegator.sol | 1 | for (uint256 i = 0; i < strategiesLength;) {
assets[i] = address(IStrategy(strategies[i]).underlyingToken());
assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));
unchecked {
++i;
}
} | true | for (uint256 i = 0; i < strategiesLength; i++) {
assets[i] = address(IStrategy(strategies[i]).underlyingToken());
assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));
} | true | true | 6.85 | |||
c4 | 06-lybra | mahyar G | Low | low | ## Caching in local variable
Solidity by default checks underflow/overflow when doing any calculation, this uses some gas and calculating same values multiple times is not good approach. In [ProtocolRewardsPool](https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/m... | return totalMintedEUSD == 0 ? 0 : _EUSDAmount.mul(_totalShares).div(totalMintedEUSD); | return _totalShares == 0 ? 0 : _sharesAmount.mul(_totalSupply).div(_totalShares); | overflow | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/mahyar-G.md | 2026-01-02T18:23:07.783971+00:00 | 2d15b44ed734eb862175170c16008a63a91ade3b46bbaa9464aaccd8669c1e4c | 0 | 0 | 0 | 7 | false | false | false | false | medium | 0 | 0 | false | ProtocolRewardsPool.sol#L190, esLBR.sol#L20, LBR.sol#L15, LybraConfigurator.sol#L50, EUSDMiningIncentives.sol#L55, LybraGovernance.sol#L11-L19, LybraGovernance.sol#L12 | EUSDMiningIncentives.sol, LybraConfigurator.sol, ProtocolRewardsPool.sol, esLBR.sol, LBR.sol, LybraGovernance.sol | 7 | return totalMintedEUSD == 0 ? 0 : _EUSDAmount.mul(_totalShares).div(totalMintedEUSD); | true | return _totalShares == 0 ? 0 : _sharesAmount.mul(_totalSupply).div(_totalShares); | true | true | 6 | ||||||
c4 | 01-ondo | Bnke0x0 G | High | high |
### [G01] State variables only set in the constructor should be declared `immutable`
#### Impact
Avoids a Gusset (20000 gas)
#### Findings:
```
2023-01-ondo/contracts/cash/CashManager.sol::47 => address public assetRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::50 => address public feeRecipient;
2023-01-on... | 2023-01-ondo/contracts/cash/CashManager.sol::47 => address public assetRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::50 => address public feeRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::53 => address public assetSender;
2023-01-ondo/contracts/cash/CashManager.sol::97 => uint256 public currentEpoch;... | 2023-01-ondo/contracts/cash/CashManager.sol::47 => address public assetRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::50 => address public feeRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::53 => address public assetSender;
2023-01-ondo/contracts/lending/JumpRateModelV2.sol::24 => address public owner;... | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/Bnke0x0-G.md | 2026-01-02T18:14:31.968371+00:00 | 2d1c7601a6b7b1d87cf8f05dbff4f5da9d31ae57420c0a9cf9f66c2660566db2 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | 2023-01-ondo/contracts/cash/CashManager.sol::47 => address public assetRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::50 => address public feeRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::53 => address public assetSender;
2023-01-ondo/contracts/cash/CashManager.sol::97 => uint256 public currentEpoch;... | true | 2023-01-ondo/contracts/cash/CashManager.sol::47 => address public assetRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::50 => address public feeRecipient;
2023-01-ondo/contracts/cash/CashManager.sol::53 => address public assetSender;
2023-01-ondo/contracts/lending/JumpRateModelV2.sol::24 => address public owner;... | true | true | 5 | ||||||||
c4 | 06-lybra | ayo_dev G | Medium | medium | ### 1. Use Uint256 to store Constants instead of Bytes32
Instead of using a bytes32 to store keccack256 hash as state variable, we can instead use a uint256 to store the state variables examples can be found in solady contract https://github.com/Vectorized/solady/blob/8c751db06e614e26e6acb9b385b463feef5e3a9f/src/tokens... | contract test {//deployment cost 113364 gas,
uint256 public constant _TRANSFER_EVENT_SIGNATURE =
0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef; //
}
contract test {//deployment cost 121071 gas,
bytes32 public constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(... | contract test { //Deployment cost: 77126 gas
bytes32 private constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(address,address,uint256)"));
}
contract test { //Deployment cost: 121071 gas
bytes32 public constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(address,address,... | overflow | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/ayo_dev-G.md | 2026-01-02T18:22:51.672775+00:00 | 2d896efad034b77831c5ffa17a7f7252249567810a1edc9bcf6430add1009ea0 | 1 | 0 | 350 | 6 | false | false | true | false | high | contract test {//deployment cost 113364 gas,
uint256 public constant _TRANSFER_EVENT_SIGNATURE =
0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef; //
}
contract test {//deployment cost 121071 gas,
bytes32 public constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(... | unknown | 350 | // Code block 1 (unknown):
contract test {//deployment cost 113364 gas,
uint256 public constant _TRANSFER_EVENT_SIGNATURE =
0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef; //
}
contract test {//deployment cost 121071 gas,
bytes32 public constant _TRANSFER_EVENT_SIGNATURE =
... | 1 | false | ERC20.sol#L51, LybraConfigurator.sol#L76, LybraConfigurator.sol#L77, LybraConfigurator.sol#L78, GovernanceTimelock.sol#L10, GovernanceTimelock.sol#L11 | ERC20.sol, LybraConfigurator.sol, GovernanceTimelock.sol | 6 | contract test {//deployment cost 113364 gas,
uint256 public constant _TRANSFER_EVENT_SIGNATURE =
0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef; //
}
contract test {//deployment cost 121071 gas,
bytes32 public constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(... | true | contract test { //Deployment cost: 77126 gas
bytes32 private constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(address,address,uint256)"));
}
contract test { //Deployment cost: 121071 gas
bytes32 public constant _TRANSFER_EVENT_SIGNATURE =
keccak256(bytes("Transfer(address,address,... | true | true | 7 | |||
c4 | 05-ajna | Kenshin Q | Critical | critical | # Low/QA
## Summary
| **Risk** | **Number of findings** |
| :---: | :---: |
| Low | 2 |
| Non Critical | 1 |
## Low Risk Issues
| **#** | **Findings** | **Instances** |
| :---: | :--- | :---: |
| [L-01](#l-01-executeextraordinary-could-be-prevented-by-startnewdi... | File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
222: function _getSliceOfNonTreasury(
223: uint256 percentage_
224: ) internal view returns (uint256) {
225: uint256 totalAjnaSupply = IERC20(ajnaTokenAddress).totalSupply();
// @audit treasury can be decreased from `startNewDis... | File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
234: function _getSliceOfTreasury(
235: uint256 percentage_
236: ) internal view returns (uint256) {
// @audit treasury can be decreased from `startNewDistributionPeriod()`
237: return Maths.wmul(treasury, percentage_);
238: ... | other | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/Kenshin-Q.md | 2026-01-02T18:21:03.231548+00:00 | 2dcbad0802121bac5094a580d3f034bf23e382b105272ba4fcba3b615b930dc9 | 2 | 2 | 741 | 2 | false | false | true | false | high | File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
222: function _getSliceOfNonTreasury(
223: uint256 percentage_
224: ) internal view returns (uint256) {
225: uint256 totalAjnaSupply = IERC20(ajnaTokenAddress).totalSupply();
// @audit treasury can be decreased from `startNewDis... | solidity | 420 | // Code block 1 (solidity):
File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
222: function _getSliceOfNonTreasury(
223: uint256 percentage_
224: ) internal view returns (uint256) {
225: uint256 totalAjnaSupply = IERC20(ajnaTokenAddress).totalSupply();
// @audit treasury can be... | 2 | false | File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
222: function _getSliceOfNonTreasury(
223: uint256 percentage_
224: ) internal view returns (uint256) {
225: uint256 totalAjnaSupply = IERC20(ajnaTokenAddress).totalSupply();
// @audit treasury can be decreased from `startNewDis... | ExtraordinaryFunding.sol#L226, ExtraordinaryFunding.sol#L237 | ExtraordinaryFunding.sol | 2 | File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
222: function _getSliceOfNonTreasury(
223: uint256 percentage_
224: ) internal view returns (uint256) {
225: uint256 totalAjnaSupply = IERC20(ajnaTokenAddress).totalSupply();
// @audit treasury can be decreased from `startNewDis... | true | File: ajna-grants/src/grants/base/ExtraordinaryFunding.sol
234: function _getSliceOfTreasury(
235: uint256 percentage_
236: ) internal view returns (uint256) {
// @audit treasury can be decreased from `startNewDistributionPeriod()`
237: return Maths.wmul(treasury, percentage_);
238: ... | true | true | 8 | ||
c4 | 11-kelp | Sathish9098 Analysis | Critical | critical | # Analysis- Kelp DAO
## Overiew
A collective DAO designed to unlock liquidity, DeFi and higher rewards for restaked assets through liquid restaking.
#### LRTConfig
This contract is used to manage the configuration of the LRT (Lido Rocket Pool) protocol. It stores the addresses of the core contracts, the list of suppo... | function _addNewSupportedAsset(address asset, uint256 depositLimit) private {
UtilLib.checkNonZeroAddress(asset);
if (isSupportedAsset[asset]) {
revert AssetAlreadySupported();
}
isSupportedAsset[asset] = true;
supportedAssetList.push(asset);
depositLimitByAss... | /// @dev private function to remove a supported asset
/// @param asset Asset address
function _removeSupportedAsset(address asset) private {
require(isSupportedAsset[asset], "Asset not supported");
isSupportedAsset[asset] = false;
_removeAssetFromList(asset);
delete depositLimitByAsset[asset];
emi... | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/Sathish9098-Analysis.md | 2026-01-02T18:27:39.410974+00:00 | 2debd4160d7c9cb0de40538b52aa867fbf0bf533dd3ba0d6da4b07d934c65eed | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function _addNewSupportedAsset(address asset, uint256 depositLimit) private {
UtilLib.checkNonZeroAddress(asset);
if (isSupportedAsset[asset]) {
revert AssetAlreadySupported();
}
isSupportedAsset[asset] = true;
supportedAssetList.push(asset);
depositLimitByAss... | true | /// @dev private function to remove a supported asset
/// @param asset Asset address
function _removeSupportedAsset(address asset) private {
require(isSupportedAsset[asset], "Asset not supported");
isSupportedAsset[asset] = false;
_removeAssetFromList(asset);
delete depositLimitByAsset[asset];
emi... | true | true | 5 | ||||||||
c4 | 03-asymmetry | JCN G | High | high | # Summary
All optimizations (*with the exception of issue [G-10](#adding-a-derivative-will-increase-gas-costs-for-users-staking-and-unstaking-even-after-the-derivative-is-removed)*) were benchmarked via the protocol's tests, i.e. using the following config: `solc version 0.8.13`, `optimizer on`, and `100_000 runs`.
Be... | File: contracts/SafEth/SafEth.sol
63: function stake() external payable {
64: require(pauseStaking == false, "staking is paused");
65: require(msg.value >= minAmount, "amount too low");
66: require(msg.value <= maxAmount, "amount too high");
67:
68: uint256 underlyingValue = 0;
69:
70: ... | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L108-L119
### Cache `derivativeCount` and `derivatives[i]` to save ~ 3 SLOADs
*More SLOADs would actually be saved since storage slot access is occuring within a loop.* | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/JCN-G.md | 2026-01-02T18:18:11.118912+00:00 | 2dfa823445c0182669941b9f6fc0c0da2474c6e8c146c0940b310ad186a365e5 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | SafEth.sol#L108-L119 | SafEth.sol | 1 | File: contracts/SafEth/SafEth.sol
63: function stake() external payable {
64: require(pauseStaking == false, "staking is paused");
65: require(msg.value >= minAmount, "amount too low");
66: require(msg.value <= maxAmount, "amount too high");
67:
68: uint256 underlyingValue = 0;
69:
70: ... | true | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L108-L119
### Cache `derivativeCount` and `derivatives[i]` to save ~ 3 SLOADs
*More SLOADs would actually be saved since storage slot access is occuring within a loop.* | true | true | 6 | ||||||
c4 | 11-kelp | KeyKiril Q | Low | low | # Essential Early Checks
Key checks should be placed at the beginning part of a function logic where possible:
```solidity
function getRSETHPrice() external view returns (uint256 rsETHPrice) {
+ if (rsEthSupply == 0) {
+ return 1 ether;
+ }
address rsETHTokenAddress = lrtConfig.rsET... | function getRSETHPrice() external view returns (uint256 rsETHPrice) {
+ if (rsEthSupply == 0) {
+ return 1 ether;
+ }
address rsETHTokenAddress = lrtConfig.rsETH();
uint256 rsEthSupply = IRSETH(rsETHTokenAddress).totalSupply();
- if (rsEthSupply == 0) {
- re... | other | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/KeyKiril-Q.md | 2026-01-02T18:27:30.479041+00:00 | 2e74962cc16845dbffb80c90d3cc2c0adf6b4eff848eb477a94302bece2ab5ff | 1 | 1 | 1,074 | 0 | false | true | true | false | high | function getRSETHPrice() external view returns (uint256 rsETHPrice) {
+ if (rsEthSupply == 0) {
+ return 1 ether;
+ }
address rsETHTokenAddress = lrtConfig.rsETH();
uint256 rsEthSupply = IRSETH(rsETHTokenAddress).totalSupply();
- if (rsEthSupply == 0) {
- return... | solidity | 1,074 | // Code block 1 (solidity):
function getRSETHPrice() external view returns (uint256 rsETHPrice) {
+ if (rsEthSupply == 0) {
+ return 1 ether;
+ }
address rsETHTokenAddress = lrtConfig.rsETH();
uint256 rsEthSupply = IRSETH(rsETHTokenAddress).totalSupply();
- if (rsEthSuppl... | 1 | false | function getRSETHPrice() external view returns (uint256 rsETHPrice) {
+ if (rsEthSupply == 0) {
+ return 1 ether;
+ }
address rsETHTokenAddress = lrtConfig.rsETH();
uint256 rsEthSupply = IRSETH(rsETHTokenAddress).totalSupply();
- if (rsEthSupply == 0) {
- return... | 0 | function getRSETHPrice() external view returns (uint256 rsETHPrice) {
+ if (rsEthSupply == 0) {
+ return 1 ether;
+ }
address rsETHTokenAddress = lrtConfig.rsETH();
uint256 rsEthSupply = IRSETH(rsETHTokenAddress).totalSupply();
- if (rsEthSupply == 0) {
- re... | true | false | false | 4.41 | ||||||
c4 | 09-ondo | Topmark Q | Unknown | unknown | ### Issue 1:
Using same name to represent different variables could cause conflict of interest and misrepresentations when dealing with Threshold and TxnThreshold struct in the DestinationBridge.sol contract. Variable Names should be adjusted accordingly.
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/b... | struct Threshold {
uint256 amount;
---> uint256 numberOfApprovalsNeeded;
}
struct TxnThreshold {
---> uint256 numberOfApprovalsNeeded;
address[] approvers;
} | other | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/Topmark-Q.md | 2026-01-02T18:25:43.527940+00:00 | 2ee5afb4cd589933012eb00fbde2b3ca56fe158fd315aba4e711c73eb8fffb6e | 1 | 1 | 178 | 1 | false | true | true | false | medium | struct Threshold {
uint256 amount;
---> uint256 numberOfApprovalsNeeded;
}
struct TxnThreshold {
---> uint256 numberOfApprovalsNeeded;
address[] approvers;
} | solidity | 178 | // Code block 1 (solidity):
struct Threshold {
uint256 amount;
---> uint256 numberOfApprovalsNeeded;
}
struct TxnThreshold {
---> uint256 numberOfApprovalsNeeded;
address[] approvers;
} | 1 | false | struct Threshold {
uint256 amount;
---> uint256 numberOfApprovalsNeeded;
}
struct TxnThreshold {
---> uint256 numberOfApprovalsNeeded;
address[] approvers;
} | DestinationBridge.sol#L369-L377 | DestinationBridge.sol | 1 | struct Threshold {
uint256 amount;
---> uint256 numberOfApprovalsNeeded;
}
struct TxnThreshold {
---> uint256 numberOfApprovalsNeeded;
address[] approvers;
} | true | false | false | 4.11 | ||||
c4 | 01-ondo | oyc_109 Q | Critical | critical |
## [L-01] Unspecific Compiler Version Pragma
Avoid floating pragmas for non-library contracts.
While floating pragmas make sense for libraries to allow them to be included with multiple different versions of applications, it may be a security risk for application implementations.
A known vulnerable compiler versio... | 2023-01-ondo/contracts/lending/CompoundLens.sol::1 => pragma solidity ^0.5.16;
2023-01-ondo/contracts/lending/JumpRateModelV2.sol::1 => pragma solidity ^0.5.16;
2023-01-ondo/contracts/lending/ondo/ondo-token/IOndo.sol::2 => pragma solidity >=0.8.3;
2023-01-ondo/contracts/lending/ondo/ondo-token/LinearTimelock.sol::2 =>... | 2023-01-ondo/contracts/cash/CashManager.sol::175 => block.timestamp -
2023-01-ondo/contracts/cash/CashManager.sol::176 => (block.timestamp % epochDuration);
2023-01-ondo/contracts/cash/CashManager.sol::577 => uint256 epochDifference = (block.timestamp - currentEpochStartTimestamp) /
2023-01-ondo/contracts/cash/CashMana... | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/oyc_109-Q.md | 2026-01-02T18:15:26.383143+00:00 | 2f0fef41a49f4e468423b0dfd6b909e6a8a1e8df036d752c21d500eae00f1818 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | 2023-01-ondo/contracts/lending/CompoundLens.sol::1 => pragma solidity ^0.5.16;
2023-01-ondo/contracts/lending/JumpRateModelV2.sol::1 => pragma solidity ^0.5.16;
2023-01-ondo/contracts/lending/ondo/ondo-token/IOndo.sol::2 => pragma solidity >=0.8.3;
2023-01-ondo/contracts/lending/ondo/ondo-token/LinearTimelock.sol::2 =>... | true | 2023-01-ondo/contracts/cash/CashManager.sol::175 => block.timestamp -
2023-01-ondo/contracts/cash/CashManager.sol::176 => (block.timestamp % epochDuration);
2023-01-ondo/contracts/cash/CashManager.sol::577 => uint256 epochDifference = (block.timestamp - currentEpochStartTimestamp) /
2023-01-ondo/contracts/cash/CashMana... | true | true | 5 | ||||||||
c4 | 02-ethos | 0xNazgul Q | Low | low | ## [NAZ-L1] `removeTvlCap()` doesn't remove TVL cap
**Severity**: Low
**Context**: [`ReaperVaultV2.sol#L587`](https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Vault/contracts/ReaperVaultV2.sol#L587)
**Description**:
`removeTvlCap()` doesn't completely remove TVL cap. Although it does so effectively, it can ... | function updateTvlCap(uint256 _newTvlCap) public {
_atLeastRole(ADMIN);
if (tvlCap != type(uint256).max) {
tvlCap = _newTvlCap;
emit TvlCapUpdated(tvlCap);
}
} | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/0xNazgul-Q.md | 2026-01-02T18:15:46.001799+00:00 | 2f43c78a097f89a1570c8164b3dcf2742dce6e361db612b02e5f648a32527413 | 1 | 0 | 187 | 1 | false | true | true | false | medium | function updateTvlCap(uint256 _newTvlCap) public {
_atLeastRole(ADMIN);
if (tvlCap != type(uint256).max) {
tvlCap = _newTvlCap;
emit TvlCapUpdated(tvlCap);
}
} | Solidity | 187 | // Code block 1 (Solidity):
function updateTvlCap(uint256 _newTvlCap) public {
_atLeastRole(ADMIN);
if (tvlCap != type(uint256).max) {
tvlCap = _newTvlCap;
emit TvlCapUpdated(tvlCap);
}
} | 1 | false | function updateTvlCap(uint256 _newTvlCap) public {
_atLeastRole(ADMIN);
if (tvlCap != type(uint256).max) {
tvlCap = _newTvlCap;
emit TvlCapUpdated(tvlCap);
}
} | ReaperVaultV2.sol#L587 | ReaperVaultV2.sol | 1 | function updateTvlCap(uint256 _newTvlCap) public {
_atLeastRole(ADMIN);
if (tvlCap != type(uint256).max) {
tvlCap = _newTvlCap;
emit TvlCapUpdated(tvlCap);
}
} | true | false | false | 4.29 | ||||
c4 | 07-amphora | Eeyore Q | Low | low | ## [L-01] Absence of duplicate address validation in `_tokenAddresses` array in `VaultController#_migrateCollateralsFrom` function
### Description
The `VaultController` contract offers the option to migrate token collateral data from an old contract during the `constructor` call.
However, if the `_migrateCollateral... | ## [L-02] `USDA` contract address should be registered only once in `VaultController` contract
### Description
In the `registerUSDA` function, no check is present that prevents changing an already registered `USDA` address.
There should never be a need to alter a set `USDA` address, as such a change could disrupt t... | ## [L-03] Incorrect check in `VaultController#changeInitialBorrowingFee` function
### Description
In the `changeInitialBorrowingFee` function, the conditional check used to verify the new borrowing fee against `MAX_INIT_BORROWING_FEE` is flawed. The condition `_newBorrowingFee >= MAX_INIT_BORROWING_FEE` should be `_n... | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/Eeyore-Q.md | 2026-01-02T18:23:25.984327+00:00 | 2f7e525fcf975546650b070943ce08df48e865772570505d2c7536c07794d2cf | 2 | 2 | 386 | 0 | false | false | true | false | high | if (_tokenId == 0) revert VaultController_WrongCollateralAddress();
+ if (tokenAddressCollateralInfo[_tokenAddress].tokenId != 0) revert VaultController_TokenAlreadyRegistered();
_tokensRegistered++; | diff | 205 | // Code block 1 (diff):
if (_tokenId == 0) revert VaultController_WrongCollateralAddress();
+ if (tokenAddressCollateralInfo[_tokenAddress].tokenId != 0) revert VaultController_TokenAlreadyRegistered();
_tokensRegistered++;
// Code block 2 (diff):
function registerUSDA(address _usdaAddress) external override onl... | 2 | true | if (_tokenId == 0) revert VaultController_WrongCollateralAddress();
+ if (tokenAddressCollateralInfo[_tokenAddress].tokenId != 0) revert VaultController_TokenAlreadyRegistered();
_tokensRegistered++;
function registerUSDA(address _usdaAddress) external override onlyOwner {
+ if (usda != address(0)) revert Vaul... | 0 | ## [L-02] `USDA` contract address should be registered only once in `VaultController` contract
### Description
In the `registerUSDA` function, no check is present that prevents changing an already registered `USDA` address.
There should never be a need to alter a set `USDA` address, as such a change could disrupt t... | true | ## [L-03] Incorrect check in `VaultController#changeInitialBorrowingFee` function
### Description
In the `changeInitialBorrowingFee` function, the conditional check used to verify the new borrowing fee against `MAX_INIT_BORROWING_FEE` is flawed. The condition `_newBorrowingFee >= MAX_INIT_BORROWING_FEE` should be `_n... | true | true | 9 | ||||
c4 | 05-ajna | REACH Q | High | high | ## [L-01] NFTs may be minted without a liquidity pool position
https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-core/src/PositionManager.sol#L227-L241
Within `PositionManager.sol`, the mint function does not check for liquidity pool positions. This could lead to future vulnerabilities if improvements are mad... | /**
* @notice Maximum percentage of tokens that can be distributed by the treasury in a quarter.
* @dev Stored as a Wad percentage.
*/
uint256 internal constant GLOBAL_BUDGET_CONSTRAINT = 0.03 * 1e18; | upgrade | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/REACH-Q.md | 2026-01-02T18:21:07.983145+00:00 | 2f85b5ba2d23b2dfe7be50f68e8779d9d7d874223ff0a74d8ef8529a92fadac4 | 0 | 0 | 0 | 4 | false | true | false | false | medium | 0 | 0 | false | PositionManager.sol#L227-L241, RewardsManager.sol#L207-L245, StandardFunding.sol#L29-L46, StandardFunding.sol#L27 | RewardsManager.sol, PositionManager.sol, StandardFunding.sol | 4 | /**
* @notice Maximum percentage of tokens that can be distributed by the treasury in a quarter.
* @dev Stored as a Wad percentage.
*/
uint256 internal constant GLOBAL_BUDGET_CONSTRAINT = 0.03 * 1e18; | true | false | false | 5 | ||||||||
c4 | 02-ethos | 0xSmartContract Q | Critical | critical | ## Summary
### Low Risk Issues List
| Number |Issues Details|Context|
|:--:|:-------|:--:|
|[L-01]|Use ERC-5143: Slippage Protection for Tokenized Vault| 1 |
|[L-02]|Head Overflow Bug in Calldata Tuple ABI-Reencoding| 1 |
|[L-03]|`uint` type argument was use instead `uint256` for `permit`function , this will cause the ... | Ethos-Vault/contracts/ReaperStrategyGranarySupplyOnly.sol:
159 */
160: function setHarvestSteps(address[2][] calldata _newSteps) external {
161: _atLeastRole(ADMIN);
162: delete steps;
163:
164: uint256 numSteps = _newSteps.length;
165: for (uint256 i = 0; i < nu... | Ethos-Core/contracts/LUSDToken.sol:
261
262: function permit
263: (
264: address owner,
265: address spender,
266: uint amount,
267: uint deadline,
268: uint8 v,
269: bytes32 r,
270: bytes32 s
271: )
272: extern... | reentrancy | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/0xSmartContract-Q.md | 2026-01-02T18:15:46.916005+00:00 | 2f8c475c751583768c7fe2f931aa0a17b8ee27ecfa7e9b39258d6391bced1245 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | Ethos-Vault/contracts/ReaperStrategyGranarySupplyOnly.sol:
159 */
160: function setHarvestSteps(address[2][] calldata _newSteps) external {
161: _atLeastRole(ADMIN);
162: delete steps;
163:
164: uint256 numSteps = _newSteps.length;
165: for (uint256 i = 0; i < nu... | true | Ethos-Core/contracts/LUSDToken.sol:
261
262: function permit
263: (
264: address owner,
265: address spender,
266: uint amount,
267: uint deadline,
268: uint8 v,
269: bytes32 r,
270: bytes32 s
271: )
272: extern... | true | true | 5 | ||||||||
c4 | 03-revert-lend | sil3th Q | High | high | ## DOS due to blacklisted addresses
Tokens such as USDC which is supported by the protocol allow for address blacklisting. Add a check at the withdraw function to check whether the address to withdraw the shares to is blacklisted.
```@solidity
function withdraw(uint256 assets, address receiver, address owner) externa... | [_withdraw](https://github.com/code-423n4/2024-03-revert-lend/blob/435b054f9ad2404173f36f0f74a5096c894b12b7/src/V3Vault.sol#L920-L952)
## No check whether `SetVault` is active
Autocompound transformer adjusts tokens which are in the vault via transform mode. The vault is set and or changed by the operator and can be i... | access-control | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/sil3th-Q.md | 2026-01-02T19:03:17.265569+00:00 | 2ff7837e1e0742e4ef20ace901f00974af5a8c3c6e5a3770921a28dfee5c721b | 1 | 0 | 1,033 | 3 | false | true | true | false | medium | [_withdraw](https://github.com/code-423n4/2024-03-revert-lend/blob/435b054f9ad2404173f36f0f74a5096c894b12b7/src/V3Vault.sol#L920-L952)
## No check whether `SetVault` is active
Autocompound transformer adjusts tokens which are in the vault via transform mode. The vault is set and or changed by the operator and can be i... | unknown | 1,033 | // Code block 1 (unknown):
[_withdraw](https://github.com/code-423n4/2024-03-revert-lend/blob/435b054f9ad2404173f36f0f74a5096c894b12b7/src/V3Vault.sol#L920-L952)
## No check whether `SetVault` is active
Autocompound transformer adjusts tokens which are in the vault via transform mode. The vault is set and or changed b... | 1 | false | V3Vault.sol#L920-L952, AutoCompound.sol#L87-L96, AutoRange.sol#L97-L104 | V3Vault.sol, AutoCompound.sol, AutoRange.sol | 3 | [_withdraw](https://github.com/code-423n4/2024-03-revert-lend/blob/435b054f9ad2404173f36f0f74a5096c894b12b7/src/V3Vault.sol#L920-L952)
## No check whether `SetVault` is active
Autocompound transformer adjusts tokens which are in the vault via transform mode. The vault is set and or changed by the operator and can be i... | true | false | false | 6 | |||||
c4 | 02-ai-arena | 0xAkira Q | Critical | critical | ## 1. Non-Critical-01. Using dynamic arrays
### Relevant GitHub Links
https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L17
https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L20
## Summary
Dynamic arrays are used instead of fixed size arrays
## Vulnerabili... | ---
## 2. Non-Critical-02. Two identical actions in the constructor
### Relevant GitHub Links
https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L41-L52
## Summary
There are two identical actions in the constructor.
## Vulnerability Details
In the constructor there is a function `addA... | - function `addAttributeProbabilities`
| access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/0xAkira-Q.md | 2026-01-02T19:01:58.361399+00:00 | 300d3967264af827790bedfdcea81080e4f18ca4861245751cd5aad9623a23b2 | 2 | 2 | 394 | 3 | false | false | true | false | high | - string[] public attributes = [
"head",
"eyes",
"mouth",
"body",
"hands",
"feet"
];
+ string[6] public attributes = [
"head",
"eyes",
"mouth",
"body",
"hands",
"feet"
]; | diff | 186 | // Code block 1 (diff):
- string[] public attributes = [
"head",
"eyes",
"mouth",
"body",
"hands",
"feet"
];
+ string[6] public attributes = [
"head",
"eyes",
"mouth",
"body",
"hands",
"feet"
];
// Code block 2 (solidity):
for (uint8 i = 0; i < attributesLength; i++) {
attributeProbabilitie... | 2 | true | - string[] public attributes = [
"head",
"eyes",
"mouth",
"body",
"hands",
"feet"
];
+ string[6] public attributes = [
"head",
"eyes",
"mouth",
"body",
"hands",
"feet"
]; | for (uint8 i = 0; i < attributesLength; i++) {
attributeProbabilities[0][attributes[i]] = probabilities[i];
attributeToDnaDivisor[attributes[i]] = defaultAttributeDivisor[i];
} | AiArenaHelper.sol#L17, AiArenaHelper.sol#L20, AiArenaHelper.sol#L41-L52 | AiArenaHelper.sol | 3 | ---
## 2. Non-Critical-02. Two identical actions in the constructor
### Relevant GitHub Links
https://github.com/code-423n4/2024-02-ai-arena/blob/main/src/AiArenaHelper.sol#L41-L52
## Summary
There are two identical actions in the constructor.
## Vulnerability Details
In the constructor there is a function `addA... | true | - function `addAttributeProbabilities`
| true | true | 10 | |
c4 | 01-ondo | SleepingBugs G | Medium | medium | ## Use of `safeMath` in `pragma ^0.8.0`
### Summary
`SafeMath` is used but it's not needed anymore
### Github Permalinks
https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70//contracts/lending/JumpRateModelV2.sol#L4
`import "./compound/SafeMath.sol";`
https://github.com/code-423n4/... | ### Github Permalinks
https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70//contracts/cash/factory/CashFactory.sol#L127
`for (uint256 i = 0; i < exCallData.length; ++i) {`
https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70//contracts/cash/factor... | - - -
All indexes are `fToken`
https://github.com/code-423n4/2023-01-ondo/blob/12537cc94f4b0e9b213d53906aa2f95e425dd899/contracts/lending/OndoPriceOracleV2.sol#L54-L62
| access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/SleepingBugs-G.md | 2026-01-02T18:14:48.461929+00:00 | 30a70a0562369e08325b98ce2d300fd4c2a79cf2cb3f5176de1e73773b38b17c | 1 | 1 | 196 | 12 | false | false | true | false | high | - for (uint256 i; i < numIterations; i++) {
+ for (uint256 i; i < numIterations;) {
// ...
+ unchecked { ++i; }
// The risk of overflow is inexistent for a uint256 here.
} | diff | 196 | // Code block 1 (diff):
- for (uint256 i; i < numIterations; i++) {
+ for (uint256 i; i < numIterations;) {
// ...
+ unchecked { ++i; }
// The risk of overflow is inexistent for a uint256 here.
} | 1 | true | - for (uint256 i; i < numIterations; i++) {
+ for (uint256 i; i < numIterations;) {
// ...
+ unchecked { ++i; }
// The risk of overflow is inexistent for a uint256 here.
} | JumpRateModelV2.sol#L4, JumpRateModelV2.sol#L12, CashFactory.sol#L127, CashKYCSenderFactory.sol#L137, CashKYCSenderReceiverFactory.sol#L137, KYCRegistry.sol#L163, KYCRegistry.sol#L180, CashManager.sol#L750, CashManager.sol#L786, CashManager.sol#L933, CashManager.sol#L961, OndoPriceOracleV2.sol#L54-L62 | CashManager.sol, CashKYCSenderFactory.sol, CashFactory.sol, JumpRateModelV2.sol, OndoPriceOracleV2.sol, KYCRegistry.sol, CashKYCSenderReceiverFactory.sol | 12 | ### Github Permalinks
https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70//contracts/cash/factory/CashFactory.sol#L127
`for (uint256 i = 0; i < exCallData.length; ++i) {`
https://github.com/code-423n4/2023-01-ondo/blob/f3426e5b6b4561e09460b2e6471eb694efdd6c70//contracts/cash/factor... | true | - - -
All indexes are `fToken`
https://github.com/code-423n4/2023-01-ondo/blob/12537cc94f4b0e9b213d53906aa2f95e425dd899/contracts/lending/OndoPriceOracleV2.sol#L54-L62
| true | true | 9 | ||
c4 | 07-amphora | twcctop G | Medium | medium | https://github.com/code-423n4/2023-07-amphora/blob/5d1cea9410db5448760c834f001af04a72edf3e0/core/solidity/contracts/core/Vault.sol#L188-L200
```solidity
for (uint256 _j; _j < _extraRewards;) {
IVirtualBalanceRewardPool _virtualReward = _rewardsContract.extraRewards(_j);
IERC20 _rewardToken = _virtual... | for (uint256 _j; _j < _extraRewards;) {
IVirtualBalanceRewardPool _virtualReward = _rewardsContract.extraRewards(_j);
IERC20 _rewardToken = _virtualReward.rewardToken();
uint256 _earnedReward = _virtualReward.earned(address(this));
if (_earnedReward != 0) {
_virtualReward.get... | other | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/twcctop-G.md | 2026-01-02T18:24:03.574191+00:00 | 30a7e8404d3d72ecd12724f66a5a8fd90fcc9e4ef2fd2ffa2940fe84f1df0607 | 1 | 1 | 521 | 1 | false | true | true | false | medium | for (uint256 _j; _j < _extraRewards;) {
IVirtualBalanceRewardPool _virtualReward = _rewardsContract.extraRewards(_j);
IERC20 _rewardToken = _virtualReward.rewardToken();
uint256 _earnedReward = _virtualReward.earned(address(this));
if (_earnedReward != 0) {
_virtualReward.getRe... | solidity | 521 | // Code block 1 (solidity):
for (uint256 _j; _j < _extraRewards;) {
IVirtualBalanceRewardPool _virtualReward = _rewardsContract.extraRewards(_j);
IERC20 _rewardToken = _virtualReward.rewardToken();
uint256 _earnedReward = _virtualReward.earned(address(this));
if (_earnedReward != 0) {
... | 1 | false | for (uint256 _j; _j < _extraRewards;) {
IVirtualBalanceRewardPool _virtualReward = _rewardsContract.extraRewards(_j);
IERC20 _rewardToken = _virtualReward.rewardToken();
uint256 _earnedReward = _virtualReward.earned(address(this));
if (_earnedReward != 0) {
_virtualReward.getRe... | Vault.sol#L188-L200 | Vault.sol | 1 | for (uint256 _j; _j < _extraRewards;) {
IVirtualBalanceRewardPool _virtualReward = _rewardsContract.extraRewards(_j);
IERC20 _rewardToken = _virtualReward.rewardToken();
uint256 _earnedReward = _virtualReward.earned(address(this));
if (_earnedReward != 0) {
_virtualReward.get... | true | false | false | 4.51 | ||||
c4 | 02-ethos | 0x6980 Q | Low | low | # 1. for modern and more readable code; update import usages
Context:
```js
//File: Ethos-Core/contracts/CollateralConfig.sol
import "./Dependencies/CheckContract.sol";
import "./Dependencies/Ownable.sol";
import "./Dependencies/SafeERC20.sol";
import "./Interfaces/ICollateralConfig.sol";
//File: Ethos-Core/contracts/... | //File: Ethos-Core/contracts/CollateralConfig.sol
import "./Dependencies/CheckContract.sol";
import "./Dependencies/Ownable.sol";
import "./Dependencies/SafeERC20.sol";
import "./Interfaces/ICollateralConfig.sol";
//File: Ethos-Core/contracts/BorrowerOperations.sol
import "./Interfaces/IBorrowerOperations.sol";
import... | # 2. Use underscores for number literals.
- [TroveManager.sol#L54](https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/TroveManager.sol#L54)
- [ReaperVaultV2.sol#L41](https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Etho... | reentrancy | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/0x6980-Q.md | 2026-01-02T18:15:42.878508+00:00 | 30debc659df96f268cebbb2ff20739e54ddbc9857f34ae5c1a32e1e8f50c6e74 | 0 | 0 | 0 | 4 | false | false | false | false | medium | 0 | 0 | false | TroveManager.sol#L54, ReaperVaultV2.sol#L41, ReaperBaseStrategyv4.sol#L24, ReaperBaseStrategyv4.sol#L25 | TroveManager.sol, ReaperBaseStrategyv4.sol, ReaperVaultV2.sol | 4 | //File: Ethos-Core/contracts/CollateralConfig.sol
import "./Dependencies/CheckContract.sol";
import "./Dependencies/Ownable.sol";
import "./Dependencies/SafeERC20.sol";
import "./Interfaces/ICollateralConfig.sol";
//File: Ethos-Core/contracts/BorrowerOperations.sol
import "./Interfaces/IBorrowerOperations.sol";
import... | true | # 2. Use underscores for number literals.
- [TroveManager.sol#L54](https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/TroveManager.sol#L54)
- [ReaperVaultV2.sol#L41](https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Etho... | true | true | 6 | ||||||
c4 | 10-badger | ZanyBonzy G | Low | low | ### 1. It is cheaper to emit only once after the loop has finished.
SortedCdps.sol [L451](https://github.com/code-423n4/2023-10-badger/blob/f2f2e2cf9965a1020661d179af46cb49e993cb7e/packages/contracts/contracts/SortedCdps.sol#L451)
```
for (uint i = 0; i < _len; ++i) {
delete data.nodes[_ids[i... | for (uint i = 0; i < _len; ++i) {
delete data.nodes[_ids[i]];
emit NodeRemoved(_ids[i]); //@gas
}
```
### 2. Multiple address/ID mappings can be combined into a single mapping of an address/ID to a struct, where appropriate
EBTCtoken.sol [L50](https://github.com/code-4... | RolesAuthority.sol [L32](https://github.com/code-423n4/2023-10-badger/blob/f2f2e2cf9965a1020661d179af46cb49e993cb7e/packages/contracts/contracts/Dependencies/RolesAuthority.sol#L32) | access-control | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/ZanyBonzy-G.md | 2026-01-02T18:26:40.594555+00:00 | 31404b9ccfad4af4af55cb15db92d301274862784be91b4b0d298ba52584b74c | 4 | 0 | 727 | 5 | false | false | true | false | high | for (uint i = 0; i < _len; ++i) {
delete data.nodes[_ids[i]];
emit NodeRemoved(_ids[i]); //@gas
} | unknown | 139 | // Code block 1 (unknown):
for (uint i = 0; i < _len; ++i) {
delete data.nodes[_ids[i]];
emit NodeRemoved(_ids[i]); //@gas
}
// Code block 2 (unknown):
// User data for EBTC token
mapping(address => uint256) private _balances;
mapping(address => mapping(address => uint... | 4 | false | SortedCdps.sol#L451, EBTCToken.sol#L50, RolesAuthority.sol#L32, IPriceFeed.sol#L17, IPriceFeed.sol#L26 | SortedCdps.sol, RolesAuthority.sol, IPriceFeed.sol, EBTCToken.sol | 5 | for (uint i = 0; i < _len; ++i) {
delete data.nodes[_ids[i]];
emit NodeRemoved(_ids[i]); //@gas
}
```
### 2. Multiple address/ID mappings can be combined into a single mapping of an address/ID to a struct, where appropriate
EBTCtoken.sol [L50](https://github.com/code-4... | true | RolesAuthority.sol [L32](https://github.com/code-423n4/2023-10-badger/blob/f2f2e2cf9965a1020661d179af46cb49e993cb7e/packages/contracts/contracts/Dependencies/RolesAuthority.sol#L32) | true | true | 10 | |||
c4 | 02-ai-arena | BenasVol Q | Low | low | # AI Arena QA Audit Report
Lead Auditors:
- [Benas Volkovas](https://github.com/BenasVolkovas)
# Table of Contents
- [AI Arena QA Audit Report](#ai-arena-qa-audit-report)
- [Table of Contents](#table-of-contents)
- [Disclaimer](#disclaimer)
- [Issues found](#issues-found)
- [Findings](#findings)
# Disc... | function getFighterPoints(uint256 maxId) public view returns(uint256[] memory) {
@> uint256[] memory points = new uint256[](1);
@> for (uint256 i = 0; i < maxId; i++) {
points[i] = fighterPoints[i];
}
return points;
} | function test_audit_RevertsIfTryingToGet2FighterPoints() public {
// owner mints a fighter by claiming
_mintFromMergingPool(_ownerAddress);
_mintFromMergingPool(_ownerAddress);
assertEq(_fighterFarmContract.ownerOf(0), _ownerAddress);
assertEq(_fighterFarmContract.ownerOf(1), _ownerAddress);
//... | access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/BenasVol-Q.md | 2026-01-02T19:02:16.125186+00:00 | 31525349988dcf4e10a13fb9c10d90fb5bc5207acdcaa16cad9ef7c9acc9f973 | 1 | 0 | 259 | 0 | false | false | true | false | high | function getFighterPoints(uint256 maxId) public view returns(uint256[] memory) {
@> uint256[] memory points = new uint256[](1);
@> for (uint256 i = 0; i < maxId; i++) {
points[i] = fighterPoints[i];
}
return points;
} | javascript | 259 | // Code block 1 (javascript):
function getFighterPoints(uint256 maxId) public view returns(uint256[] memory) {
@> uint256[] memory points = new uint256[](1);
@> for (uint256 i = 0; i < maxId; i++) {
points[i] = fighterPoints[i];
}
return points;
} | 1 | false | 0 | function getFighterPoints(uint256 maxId) public view returns(uint256[] memory) {
@> uint256[] memory points = new uint256[](1);
@> for (uint256 i = 0; i < maxId; i++) {
points[i] = fighterPoints[i];
}
return points;
} | true | function test_audit_RevertsIfTryingToGet2FighterPoints() public {
// owner mints a fighter by claiming
_mintFromMergingPool(_ownerAddress);
_mintFromMergingPool(_ownerAddress);
assertEq(_fighterFarmContract.ownerOf(0), _ownerAddress);
assertEq(_fighterFarmContract.ownerOf(1), _ownerAddress);
//... | true | true | 6 | |||||
c4 | 04-caviar | mariodev G | Gas | gas | For all `for` loops, use prefix increment `++i` notation instead of postfix `i++`.
Although minimal difference is observed, it is good practice to reduce as much as possible the amount of gas used if achieving the same functionality.
### POC
```solidity
contract One{
uint256 public number;
//Gas used : 43634
... | contract One{
uint256 public number;
//Gas used : 43634
function incrementByOne() public returns (uint256){
return number++;
}
}
contract Two{
uint256 public number;
//Gas used : 43628
function incrementByOne() public returns (uint256){
return ++number;
}
} | other | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/mariodev-G.md | 2026-01-02T18:20:39.171458+00:00 | 317b4d8fae685739b18e5b892034a76e9cae4b99a3419db42b76846fe7621329 | 1 | 1 | 296 | 0 | false | true | true | false | medium | contract One{
uint256 public number;
//Gas used : 43634
function incrementByOne() public returns (uint256){
return number++;
}
}
contract Two{
uint256 public number;
//Gas used : 43628
function incrementByOne() public returns (uint256){
return ++number;
}
} | solidity | 296 | // Code block 1 (solidity):
contract One{
uint256 public number;
//Gas used : 43634
function incrementByOne() public returns (uint256){
return number++;
}
}
contract Two{
uint256 public number;
//Gas used : 43628
function incrementByOne() public returns (uint256){
return ++number;
... | 1 | false | contract One{
uint256 public number;
//Gas used : 43634
function incrementByOne() public returns (uint256){
return number++;
}
}
contract Two{
uint256 public number;
//Gas used : 43628
function incrementByOne() public returns (uint256){
return ++number;
}
} | 0 | contract One{
uint256 public number;
//Gas used : 43634
function incrementByOne() public returns (uint256){
return number++;
}
}
contract Two{
uint256 public number;
//Gas used : 43628
function incrementByOne() public returns (uint256){
return ++number;
}
} | true | false | false | 3.31 | ||||||
c4 | 03-asymmetry | Haipls Q | Low | low | ## Haven't require for add duplicate Derivative
The situation is aggravated by the fact that it is not possible to remove the derivative, only to exclude it from the calculations
https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/contracts/SafEth/SafEth.sol#L182
## Using the ... | contracts\SafEth\SafEth.sol
53: _transferOwnership(msg.sender); | __Ownable_init() | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Haipls-Q.md | 2026-01-02T18:18:06.986314+00:00 | 31c4852c3fe74d5875d061e954ace5c05cbad383d709c961b9dfb249b5f74bee | 3 | 3 | 448 | 1 | false | false | true | false | high | contracts\SafEth\SafEth.sol
53: _transferOwnership(msg.sender); | solidity | 71 | // Code block 1 (solidity):
contracts\SafEth\SafEth.sol
53: _transferOwnership(msg.sender);
// Code block 2 (solidity):
__Ownable_init()
// Code block 3 (solidity):
contracts\SafEth\SafEth.sol
214: function setMinAmount(uint256 _minAmount) external onlyOwner {
215: minAmount = _minAmount;
216: ... | 3 | false | contracts\SafEth\SafEth.sol
53: _transferOwnership(msg.sender);
__Ownable_init()
contracts\SafEth\SafEth.sol
214: function setMinAmount(uint256 _minAmount) external onlyOwner {
215: minAmount = _minAmount;
216: emit ChangeMinAmount(minAmount);
217: }
223: function setMaxAmount(ui... | SafEth.sol#L182 | SafEth.sol | 1 | contracts\SafEth\SafEth.sol
53: _transferOwnership(msg.sender); | true | __Ownable_init() | true | true | 9 | ||
c4 | 09-ondo | TomJ Q | Low | low | ## Table of Contents
### Low Risk Issues
- Consider adding checks of _sender and _recipient being different address for _transferShares()
- BURNER_ROLE cannot burn when contract paused or cannot burn blocked user's share
 
## Low Risk Issues
### Consider adding checks of _sender and _recipient being different ad... | require(_sender != _recipient, "SAME_ADDRESS"); | validation | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/TomJ-Q.md | 2026-01-02T18:25:42.639716+00:00 | 320f05828c3da824714fc5f791dbc043d050d53b03eb02bdfa16773c46bf7fcc | 1 | 1 | 47 | 2 | false | true | true | false | high | require(_sender != _recipient, "SAME_ADDRESS"); | solidity | 47 | // Code block 1 (solidity):
require(_sender != _recipient, "SAME_ADDRESS"); | 1 | false | require(_sender != _recipient, "SAME_ADDRESS"); | rUSDY.sol#L514-L532, rUSDY.sol#L626-L655 | rUSDY.sol | 2 | require(_sender != _recipient, "SAME_ADDRESS"); | true | false | false | 6 | ||||
c4 | 03-revert-lend | hunter_w3b Q | Medium | medium | ### L-1. In the `V3Oracle::getValue()` function, the `priceTokenX96` variable is calculated based on the `token` parameter passed to the function. However, when calculating the `value` and `feeValue` variables, the `priceTokenX96` variable is used regardless of whether the `token` parameter is `token0`, `token1`, or ne... | function getValue(uint256 tokenId, address token)
external
view
override
returns (uint256 value, uint256 feeValue, uint256 price0X96, uint256 price1X96)
{
(address token0, address token1, uint24 fee,, uint256 amount0, uint256 amount1, uint256 fees0, uint256 fees1) =
... | function _checkPoolPrice(address token0, address token1, uint24 fee, uint256 derivedPoolPriceX96) internal view {
IUniswapV3Pool pool = _getPool(token0, token1, fee);
uint256 priceX96 = _getReferencePoolPriceX96(pool, 0);
_requireMaxDifference(priceX96, derivedPoolPriceX96, maxPoolPriceDiffe... | access-control | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/hunter_w3b-Q.md | 2026-01-02T19:03:12.325863+00:00 | 3212bc7750047b47e1219f96797cc67db5ea66709eecd31361cda06d450b3550 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | V3Oracle.sol#L95-L131 | V3Oracle.sol | 1 | function getValue(uint256 tokenId, address token)
external
view
override
returns (uint256 value, uint256 feeValue, uint256 price0X96, uint256 price1X96)
{
(address token0, address token1, uint24 fee,, uint256 amount0, uint256 amount1, uint256 fees0, uint256 fees1) =
... | true | function _checkPoolPrice(address token0, address token1, uint24 fee, uint256 derivedPoolPriceX96) internal view {
IUniswapV3Pool pool = _getPool(token0, token1, fee);
uint256 priceX96 = _getReferencePoolPriceX96(pool, 0);
_requireMaxDifference(priceX96, derivedPoolPriceX96, maxPoolPriceDiffe... | true | true | 6 | ||||||
c4 | 02-ethos | MohammedRizwan Q | Critical | critical | ## Summary
### Low Risk Issues
|Number|Issue|Instances| |
|-|:-|:-:|:-:|
| [L‑01] | should change decimal type to uint8 | 1 |
| [L‑02] | Zero address and Zero msg.value(zero amount) checks are missing | 1 |
| [L‑03] | Internal functions only called once can be inlined, code restructuring. | 1 |
... | File: Ethos-Core/contracts/CollateralConfig.sol
27 struct Config {
28 bool allowed;
29 uint256 decimals;
30 uint256 MCR;
31 uint256 CCR;
32 }
---
110 function getCollateralDecimals(
111 address _collateral
112 ) external override view checkCollateral(_collateral) returns... | File: Ethos-Core/contracts/CollateralConfig.sol
63 uint256 decimals = IERC20(collateral).decimals(); | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/MohammedRizwan-Q.md | 2026-01-02T18:16:22.501476+00:00 | 322f30b19bd64459e3b47d62a75381e1fa6421916235148422892865e9ea30b3 | 1 | 1 | 399 | 1 | false | false | true | false | high | File: Ethos-Core/contracts/CollateralConfig.sol
27 struct Config {
28 bool allowed;
29 uint256 decimals;
30 uint256 MCR;
31 uint256 CCR;
32 }
---
110 function getCollateralDecimals(
111 address _collateral
112 ) external override view checkCollateral(_collateral) returns... | solidity | 399 | // Code block 1 (solidity):
File: Ethos-Core/contracts/CollateralConfig.sol
27 struct Config {
28 bool allowed;
29 uint256 decimals;
30 uint256 MCR;
31 uint256 CCR;
32 }
---
110 function getCollateralDecimals(
111 address _collateral
112 ) external override view checkCol... | 1 | false | File: Ethos-Core/contracts/CollateralConfig.sol
27 struct Config {
28 bool allowed;
29 uint256 decimals;
30 uint256 MCR;
31 uint256 CCR;
32 }
---
110 function getCollateralDecimals(
111 address _collateral
112 ) external override view checkCollateral(_collateral) returns... | CollateralConfig.sol | CollateralConfig.sol | 1 | File: Ethos-Core/contracts/CollateralConfig.sol
27 struct Config {
28 bool allowed;
29 uint256 decimals;
30 uint256 MCR;
31 uint256 CCR;
32 }
---
110 function getCollateralDecimals(
111 address _collateral
112 ) external override view checkCollateral(_collateral) returns... | true | File: Ethos-Core/contracts/CollateralConfig.sol
63 uint256 decimals = IERC20(collateral).decimals(); | true | true | 7 | ||
c4 | 02-ethos | parsely Q | Medium | medium | # [N-01] Consider in certain instances only importing only what is needed rather than using global imports.
### Context
All contracts
### Description
Importing only what is necessary is preferred above global imports
### Recommendation
```import {contractName} from "theContractFile.sol";```
# [N-02] NatSpec comments... | # [N-02] NatSpec comments should be added to public contracts
### Context
All public contracts eg. BorrowerOperations
### Description
According to the Solidity documentation it is recommended for all public contracts to have NatSpec comments added.
### Recommendation
Add NatSpec comments to the contracts that may be i... | ### Description
It does not seem that the logging function is used within the code.
### Recommendation
Remove unused imports.
# [N-05] Once the setAddresses function is called there is no way to correct any incorrect addresses
### Context | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/parsely-Q.md | 2026-01-02T18:17:27.997795+00:00 | 324afe99d7bcdb61f2bee7ec3f6abaa2fb64718a2a21ed1eb6b4f9b701806192 | 2 | 0 | 1,033 | 2 | false | false | true | false | high | # [N-02] NatSpec comments should be added to public contracts
### Context
All public contracts eg. BorrowerOperations
### Description
According to the Solidity documentation it is recommended for all public contracts to have NatSpec comments added.
### Recommendation
Add NatSpec comments to the contracts that may be i... | unknown | 794 | // Code block 1 (unknown):
# [N-02] NatSpec comments should be added to public contracts
### Context
All public contracts eg. BorrowerOperations
### Description
According to the Solidity documentation it is recommended for all public contracts to have NatSpec comments added.
### Recommendation
Add NatSpec comments to ... | 2 | false | TroveManager.sol#L14, TroveManager.sol#L18 | TroveManager.sol | 2 | # [N-02] NatSpec comments should be added to public contracts
### Context
All public contracts eg. BorrowerOperations
### Description
According to the Solidity documentation it is recommended for all public contracts to have NatSpec comments added.
### Recommendation
Add NatSpec comments to the contracts that may be i... | true | ### Description
It does not seem that the logging function is used within the code.
### Recommendation
Remove unused imports.
# [N-05] Once the setAddresses function is called there is no way to correct any incorrect addresses
### Context | true | true | 8 | |||
c4 | 04-caviar | PNS Q | Critical | critical | # Low Risk
## Missing checks for `address(0x0)` when assigning values to address state variables
```solidity
File: src/EthRouter.sol
90: constructor(address _royaltyRegistry) {
91: royaltyRegistry = _royaltyRegistry;
92: }
```
```solidity
File: src/PrivatePool.sol
143: constructor(address _factory... | File: src/EthRouter.sol
90: constructor(address _royaltyRegistry) {
91: royaltyRegistry = _royaltyRegistry;
92: } | File: src/PrivatePool.sol
143: constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
144: factory = payable(_factory);
145: royaltyRegistry = _royaltyRegistry;
146: stolenNftOracle = _stolenNftOracle;
147: } | oracle | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/PNS-Q.md | 2026-01-02T18:19:56.627880+00:00 | 325800dc0a8fcfdf83eb848629f9f0f5431309c378e87c74b03b94c44c9c8205 | 5 | 5 | 883 | 1 | false | false | true | false | high | File: src/EthRouter.sol
90: constructor(address _royaltyRegistry) {
91: royaltyRegistry = _royaltyRegistry;
92: } | solidity | 129 | // Code block 1 (solidity):
File: src/EthRouter.sol
90: constructor(address _royaltyRegistry) {
91: royaltyRegistry = _royaltyRegistry;
92: }
// Code block 2 (solidity):
File: src/PrivatePool.sol
143: constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
144: f... | 5 | false | File: src/EthRouter.sol
90: constructor(address _royaltyRegistry) {
91: royaltyRegistry = _royaltyRegistry;
92: }
File: src/PrivatePool.sol
143: constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
144: factory = payable(_factory);
145: royaltyRegistry... | Address.sol#L40 | Address.sol | 1 | File: src/EthRouter.sol
90: constructor(address _royaltyRegistry) {
91: royaltyRegistry = _royaltyRegistry;
92: } | true | File: src/PrivatePool.sol
143: constructor(address _factory, address _royaltyRegistry, address _stolenNftOracle) {
144: factory = payable(_factory);
145: royaltyRegistry = _royaltyRegistry;
146: stolenNftOracle = _stolenNftOracle;
147: } | true | true | 11 | ||
c4 | 06-lybra | BRONZEDISC Q | Medium | medium | ## QA
---
### Layout Order [1]
- The best-practices for layout within a contract is the following order: state variables, events, modifiers, constructor and functions.
https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/miner/EUSDMiningIncentives.sol
```solidity
72: modifier updateReward(addres... | 72: modifier updateReward(address _account) { | // modifier should come before constructor
178: modifier updateReward(address account) { | access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/BRONZEDISC-Q.md | 2026-01-02T18:22:12.299724+00:00 | 326817af0de2e45d336d3f7c3a8ccad84d43183392d98092b8c638323714cd7a | 3 | 3 | 224 | 4 | false | false | true | false | high | 72: modifier updateReward(address _account) { | solidity | 48 | // Code block 1 (solidity):
72: modifier updateReward(address _account) {
// Code block 2 (solidity):
// modifier should come before constructor
178: modifier updateReward(address account) {
// Code block 3 (solidity):
// modifier coming after constructor
56: modifier updateReward(address _account) { | 3 | false | 72: modifier updateReward(address _account) {
// modifier should come before constructor
178: modifier updateReward(address account) {
// modifier coming after constructor
56: modifier updateReward(address _account) { | EUSDMiningIncentives.sol, ProtocolRewardsPool.sol, stakerewardV2pool.sol, LybraPeUSDVaultBase.sol | EUSDMiningIncentives.sol, LybraPeUSDVaultBase.sol, ProtocolRewardsPool.sol, stakerewardV2pool.sol | 4 | 72: modifier updateReward(address _account) { | true | // modifier should come before constructor
178: modifier updateReward(address account) { | true | true | 9 | ||
c4 | 01-biconomy | IllIllI Q | Critical | critical |
## Summary
### Low Risk Issues
| |Issue|Instances|
|-|:-|:-:|
| [L‑01] | Upgradeable contract not initialized | 1 |
| [L‑02] | Not all parent contracts are upgradeable | 4 |
| [L‑03] | Loss of precision | 1 |
| [L‑04] | Signatures vulnerable | 1 |
| [L‑05] | Empty `receive()`/`... | File: scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
/// @audit missing __ReentrancyGuard_init()
18: contract SmartAccount is
| File: scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
/// @audit ModuleManager
/// @audit SignatureDecoder
/// @audit SecuredTokenTransfer
/// @audit FallbackManager
18: contract SmartAccount is
| reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/IllIllI-Q.md | 2026-01-02T18:13:07.127872+00:00 | 328aca61c9f60984c0b74dbc57a3aa35fe2991ff26c5cba6c8e7106b3f82d7db | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
/// @audit missing __ReentrancyGuard_init()
18: contract SmartAccount is
| true | File: scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol
/// @audit ModuleManager
/// @audit SignatureDecoder
/// @audit SecuredTokenTransfer
/// @audit FallbackManager
18: contract SmartAccount is
| true | true | 5 | ||||||||
c4 | 02-ai-arena | 0xblackskull Q | Low | low | ### `_setupRole` is deprecated in favor of `_grantRole` in `Neuron.sol`
- addMinter()
- addStaker()
- addSpender()
### No check for 0 or 1 in FighterFarm::incrementGeneration
```
/// @param fighterType Type of fighter either 0 or 1 (champion or dendroid).
```
```solidity
function incrementGeneration(uint8 fighterTyp... | /// @param fighterType Type of fighter either 0 or 1 (champion or dendroid). | function incrementGeneration(uint8 fighterType) external returns (uint8) {
require(msg.sender == _ownerAddress);
generation[fighterType] += 1;
maxRerollsAllowed[fighterType] += 1;
return generation[fighterType];
} | access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/0xblackskull-Q.md | 2026-01-02T19:02:07.367958+00:00 | 3328ccaf99d178c6430164a39adc88df63e7b9107520835b319e9bad5f138984 | 3 | 1 | 371 | 0 | false | false | true | false | high | /// @param fighterType Type of fighter either 0 or 1 (champion or dendroid). | unknown | 76 | // Code block 1 (unknown):
/// @param fighterType Type of fighter either 0 or 1 (champion or dendroid).
// Code block 2 (solidity):
function incrementGeneration(uint8 fighterType) external returns (uint8) {
require(msg.sender == _ownerAddress);
generation[fighterType] += 1;
maxRerollsAllowed[fi... | 3 | false | function incrementGeneration(uint8 fighterType) external returns (uint8) {
require(msg.sender == _ownerAddress);
generation[fighterType] += 1;
maxRerollsAllowed[fighterType] += 1;
return generation[fighterType];
} | 0 | /// @param fighterType Type of fighter either 0 or 1 (champion or dendroid). | true | function incrementGeneration(uint8 fighterType) external returns (uint8) {
require(msg.sender == _ownerAddress);
generation[fighterType] += 1;
maxRerollsAllowed[fighterType] += 1;
return generation[fighterType];
} | true | true | 6.47 | ||||
c4 | 10-badger | cheatc0d3 Q | Low | low | #### `transferSystemCollShares` function can be more optimized
https://github.com/code-423n4/2023-10-badger/blob/main/packages/contracts/contracts/ActivePool.sol#L100
```solidity
function transferSystemCollShares(address _account, uint256 _shares) public override {
require(_account != address(0), "Zero account ad... | function transferSystemCollShares(address _account, uint256 _shares) public override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function code
} | function transferSystemCollSharesAndLiquidatorReward(
address _account,
uint256 _shares,
uint256 _liquidatorRewardShares
) external override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function cod... | reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/cheatc0d3-Q.md | 2026-01-02T18:26:44.619482+00:00 | 33363720cd56690d07304513f8fc9ed885fafca0db5b55a50e1bc6b5b0a92e96 | 4 | 4 | 953 | 5 | false | false | true | false | high | function transferSystemCollShares(address _account, uint256 _shares) public override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function code
} | solidity | 255 | // Code block 1 (solidity):
function transferSystemCollShares(address _account, uint256 _shares) public override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function code
}
// Code block 2 (solidity):
functio... | 4 | false | function transferSystemCollShares(address _account, uint256 _shares) public override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function code
}
function transferSystemCollSharesAndLiquidatorReward(
addre... | ActivePool.sol#L100, ActivePool.sol#L129, ActivePool.sol#L157, ActivePool.sol#L194, ActivePool.sol#L207 | ActivePool.sol | 5 | function transferSystemCollShares(address _account, uint256 _shares) public override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function code
} | true | function transferSystemCollSharesAndLiquidatorReward(
address _account,
uint256 _shares,
uint256 _liquidatorRewardShares
) external override {
require(_account != address(0), "Zero account address");
require(_shares > 0, "Zero shares");
_requireCallerIsBOorCdpM();
// Rest of the function cod... | true | true | 10 | ||
c4 | 03-asymmetry | Ignite Q | Critical | critical | # Low Issues
| | Issues Details | Instances |
|---|---|---|
| [Low-1] | Loss of Precision due to rounding | 1 |
| [Low-2] | Function Parameters Without Bounds | 1 |
| [Low-3] | Missing deadline checks in `swapExactInputSingleHop()` function | 1 |
| [Low-4] | Lack of zero address checks | 4 |
| [Low-5] | Pragma Floa... | In this scenario, the `ethAmount` values would be `33`, `66`, and `99` for the three iterations of the loop, respectively. Therefore, there would be small wei left in the `SafETH` contract since `200 - (33 + 66 + 99) = 2` (without slippage).
### Recommendation
Transfer the remaining wei back to the sender.
Otherwise,... | ### Recommendation
Define limits or constraints on function parameters to prevent unintended consequences.
## [Low-3] Missing deadline checks in `swapExactInputSingleHop()` function
The `swapExactInputSingleHop()` function lacks a deadline for its actions that execute swaps on the `deposit()` function. This missing f... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Ignite-Q.md | 2026-01-02T18:18:08.820738+00:00 | 33a33110b5d6e579169242be1bad9671bc66d4ecd101bba4de8f143e804e62ce | 0 | 0 | 0 | 3 | false | false | false | false | medium | 0 | 0 | false | SafEth.sol#L84-L88, SafEth.sol#L202-L208, Reth.sol#L83-L89 | Reth.sol, SafEth.sol | 3 | In this scenario, the `ethAmount` values would be `33`, `66`, and `99` for the three iterations of the loop, respectively. Therefore, there would be small wei left in the `SafETH` contract since `200 - (33 + 66 + 99) = 2` (without slippage).
### Recommendation
Transfer the remaining wei back to the sender.
Otherwise,... | true | ### Recommendation
Define limits or constraints on function parameters to prevent unintended consequences.
## [Low-3] Missing deadline checks in `swapExactInputSingleHop()` function
The `swapExactInputSingleHop()` function lacks a deadline for its actions that execute swaps on the `deposit()` function. This missing f... | true | true | 6 | ||||||
c4 | 01-biconomy | arialblack14 G | High | high | # GAS OPTIMIZATION REPORT ⛽
## [G-1] `require()`/`revert()` strings longer than 32 bytes cost extras gas.
### Description
Each extra chunk of bytes past the original 32 incurs an MSTORE which costs 3 gas
### ✅ Recommendation
Consider the following require statement:
```Solidity
// condition is boolean
// str is a st... | // condition is boolean
// str is a string
require(condition, str) | for (uint i = 0; i < length; i++) {
// do something that doesn't change the value of i
} | reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/arialblack14-G.md | 2026-01-02T18:13:30.571663+00:00 | 33fb6fe0ccf1bd1a876f2dc24ea602a66ca54f8cd1b11a86757d040814bff628 | 1 | 0 | 66 | 1 | false | false | true | false | high | // condition is boolean
// str is a string
require(condition, str) | Solidity | 66 | // Code block 1 (Solidity):
// condition is boolean
// str is a string
require(condition, str) | 1 | false | // condition is boolean
// str is a string
require(condition, str) | SmartAccount.sol#L77 | SmartAccount.sol | 1 | // condition is boolean
// str is a string
require(condition, str) | true | for (uint i = 0; i < length; i++) {
// do something that doesn't change the value of i
} | true | true | 7 | ||
c4 | 05-ajna | yongskiws G | High | high | ### Gas Optimizations Issues List
| Number |Issues Details|Instance|
|:--:|:-------|:--:|
|[G-01]| Using unchecked blocks to save gas | 9 |
|[G-02]| Use calldata instead of memory for function parameters | 4 |
|[G-03]| Use hardcode address instead address(this) | 1 |
|[G-04]| Sort Solidity operations using short-circui... | ## [G-02] Use calldata instead of memory for function parameters
In some cases, having function arguments in calldata instead of memory is more optimal.
Consider the following generic example:
| In the above example, the dynamic array arr has the storage location memory. When the function gets called externally, the array values are kept in calldata and copied to memory during ABI decoding (using the opcode calldataload and mstore). And during the for loop, arr[i] accesses the value in memory using a mload. Ho... | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/yongskiws-G.md | 2026-01-02T18:21:53.828504+00:00 | 3413de07689dd69b675ca68fadb7d49bed358d2d6629e1cb1a113be7d4dc9f73 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | ## [G-02] Use calldata instead of memory for function parameters
In some cases, having function arguments in calldata instead of memory is more optimal.
Consider the following generic example:
| true | In the above example, the dynamic array arr has the storage location memory. When the function gets called externally, the array values are kept in calldata and copied to memory during ABI decoding (using the opcode calldataload and mstore). And during the for loop, arr[i] accesses the value in memory using a mload. Ho... | true | true | 5 | ||||||||
c4 | 08-dopex | 0xrafaelnicolau Q | Low | low | # [L-01] Insufficient input validation let's users mint a free bond
If a user calls the `bondWithDelegate` function with empty arrays for both `_amounts` and `_delegateIds`, unintendedly, a Bond with zero amount will be minted to the user.
## PoC
```solidity
contract Exploit is Setup {
function testBondWithDelegat... | contract Exploit is Setup {
function testBondWithDelegateEmptyArrays() external {
// create empty arrays to pass as arguments
uint256[] memory _amounts = new uint256[](0);
uint256[] memory _delegateIds = new uint256[](0);
// calls bondWithDelegate
rdpxV2Core.bondWithDelegate... | function bondWithDelegate(
address _to,
uint256[] memory _amounts,
uint256[] memory _delegateIds,
uint256 rdpxBondId
) public returns (uint256 receiptTokenAmount, uint256[] memory) {
_whenNotPaused();
// Validate amount
_validate(_amounts.length == _delegateIds.length, 3);
+ _validate(_a... | validation | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/0xrafaelnicolau-Q.md | 2026-01-02T18:24:26.788133+00:00 | 34241cae45b9a5f3a1cf642874ce69009db9d312af245cd31b2ef24b189fe7ca | 2 | 2 | 876 | 0 | false | false | true | false | high | contract Exploit is Setup {
function testBondWithDelegateEmptyArrays() external {
// create empty arrays to pass as arguments
uint256[] memory _amounts = new uint256[](0);
uint256[] memory _delegateIds = new uint256[](0);
// calls bondWithDelegate
rdpxV2Core.bondWithDelegate... | solidity | 520 | // Code block 1 (solidity):
contract Exploit is Setup {
function testBondWithDelegateEmptyArrays() external {
// create empty arrays to pass as arguments
uint256[] memory _amounts = new uint256[](0);
uint256[] memory _delegateIds = new uint256[](0);
// calls bondWithDelegate
... | 2 | false | contract Exploit is Setup {
function testBondWithDelegateEmptyArrays() external {
// create empty arrays to pass as arguments
uint256[] memory _amounts = new uint256[](0);
uint256[] memory _delegateIds = new uint256[](0);
// calls bondWithDelegate
rdpxV2Core.bondWithDelegate... | 0 | contract Exploit is Setup {
function testBondWithDelegateEmptyArrays() external {
// create empty arrays to pass as arguments
uint256[] memory _amounts = new uint256[](0);
uint256[] memory _delegateIds = new uint256[](0);
// calls bondWithDelegate
rdpxV2Core.bondWithDelegate... | true | function bondWithDelegate(
address _to,
uint256[] memory _amounts,
uint256[] memory _delegateIds,
uint256 rdpxBondId
) public returns (uint256 receiptTokenAmount, uint256[] memory) {
_whenNotPaused();
// Validate amount
_validate(_amounts.length == _delegateIds.length, 3);
+ _validate(_a... | true | true | 6.77 | ||||
c4 | 01-ondo | CodingNameKiki Q | Critical | critical | ### Issues Template
| Letter | Name | Description |
|:--:|:-------:|:-------:|
| L | Low risk | Potential risk |
| NC | Non-critical | Non risky findings |
| R | Refactor | Changing the code |
| O | Ordinary | Often found issues |
| Total Found Issues | 33 |
|:--:|:--:|
### Low Risk Template
| Count | Explanation ... | contracts/lending/tokens/cCash/CCash.sol
121: function repayBorrowBehalf(
122: address borrower,
123: uint repayAmount
124: ) external override returns (uint) {
125: repayBorrowBehalfInternal(borrower, repayAmount);
126: return NO_ERROR;
127: }
contracts/lending/tokens/cCash/CTokenCash.sol
767: functi... | function _acceptAdmin() external override returns (uint) {
// Check caller is pendingAdmin and pendingAdmin ≠ address(0)
if (msg.sender != pendingAdmin || msg.sender == address(0)) {
revert AcceptAdminPendingAdminCheck();
}
// Save current values for inclusion in log
address oldAdmin = admin;... | reentrancy | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/CodingNameKiki-Q.md | 2026-01-02T18:14:33.770141+00:00 | 344e5e02d6d0f832ff8ffb009dc9eaad6f2a9e96093756acf33edc58548ed70a | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | contracts/lending/tokens/cCash/CCash.sol
121: function repayBorrowBehalf(
122: address borrower,
123: uint repayAmount
124: ) external override returns (uint) {
125: repayBorrowBehalfInternal(borrower, repayAmount);
126: return NO_ERROR;
127: }
contracts/lending/tokens/cCash/CTokenCash.sol
767: functi... | true | function _acceptAdmin() external override returns (uint) {
// Check caller is pendingAdmin and pendingAdmin ≠ address(0)
if (msg.sender != pendingAdmin || msg.sender == address(0)) {
revert AcceptAdminPendingAdminCheck();
}
// Save current values for inclusion in log
address oldAdmin = admin;... | true | true | 5 | ||||||||
c4 | 09-ondo | Breeje Q | High | high | QA Report
## Low Risk Issues
| Count | Explanation |
|:--:|:-------|
| [L-01] | No checks to confirm that the gas paid by user is enough |
| [L-02] | In case `DestinationBridge` is paused before `SourceBridge`, User can lose funds |
| [L-03] | No incentive for approvers to approve can lead to issues in long term ... | function burnAndCallAxelar(
uint256 amount,
string calldata destinationChain
) external payable whenNotPaused {
string memory destContract = destChainToContractAddr[destinationChain];
if (bytes(destContract).length == 0) {
revert DestinationNotSupported();
}
if (msg.value == 0) {
... | File: rUSDYFactory.sol
function deployrUSDY(
address blocklist,
address allowlist,
address sanctionsList,
address usdy,
address oracle
) external onlyGuardian returns (address, address, address) {
rUSDYImplementation = new rUSDY();
rUSDYProxyAdmin = new ProxyAdmin();
rUSDYProxy = ne... | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/Breeje-Q.md | 2026-01-02T18:25:25.059404+00:00 | 345e1d45807ab81ecb9552decc740e3567f2e56577e05122aed590cd3a67edf2 | 1 | 1 | 935 | 0 | false | false | true | false | high | function burnAndCallAxelar(
uint256 amount,
string calldata destinationChain
) external payable whenNotPaused {
string memory destContract = destChainToContractAddr[destinationChain];
if (bytes(destContract).length == 0) {
revert DestinationNotSupported();
}
if (msg.value == 0) {
... | solidity | 935 | // Code block 1 (solidity):
function burnAndCallAxelar(
uint256 amount,
string calldata destinationChain
) external payable whenNotPaused {
string memory destContract = destChainToContractAddr[destinationChain];
if (bytes(destContract).length == 0) {
revert DestinationNotSupported();
}
... | 1 | false | function burnAndCallAxelar(
uint256 amount,
string calldata destinationChain
) external payable whenNotPaused {
string memory destContract = destChainToContractAddr[destinationChain];
if (bytes(destContract).length == 0) {
revert DestinationNotSupported();
}
if (msg.value == 0) {
... | 0 | function burnAndCallAxelar(
uint256 amount,
string calldata destinationChain
) external payable whenNotPaused {
string memory destContract = destChainToContractAddr[destinationChain];
if (bytes(destContract).length == 0) {
revert DestinationNotSupported();
}
if (msg.value == 0) {
... | true | File: rUSDYFactory.sol
function deployrUSDY(
address blocklist,
address allowlist,
address sanctionsList,
address usdy,
address oracle
) external onlyGuardian returns (address, address, address) {
rUSDYImplementation = new rUSDY();
rUSDYProxyAdmin = new ProxyAdmin();
rUSDYProxy = ne... | true | true | 6 | ||||
c4 | 06-lybra | hunter_w3b Q | Medium | medium | ## [L-01] DO NOT PERFORM `ARITHMETIC` OPERATION INSIDE THE emit OF AN event
It is not recommended to perform arithmetic operations inside the emit of an event. The emits are placed to log the function results for the use of the off-chain tools and not to perform arithmetic operations. The arithmetic opeations should b... | File: lybra/pools/LybraWbETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
31 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp);
| File: lybra/pools/LybraRETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
38 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp);
| access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/hunter_w3b-Q.md | 2026-01-02T18:23:01.066226+00:00 | 348c5feed3866873191bbeb3fefc1f6984916a4aaeeb7022fd338f9b3e571a7c | 3 | 3 | 643 | 3 | false | false | true | false | high | File: lybra/pools/LybraWbETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
31 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp); | solidity | 213 | // Code block 1 (solidity):
File: lybra/pools/LybraWbETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
31 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp);
// Code block 2 (solidity):
File: lybra/pools/LybraRETHVault.sol
/// @audit ... | 3 | false | File: lybra/pools/LybraWbETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
31 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp);
File: lybra/pools/LybraRETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
38 ... | LybraWbETHVault.sol#L31, LybraRETHVault.sol#L38, ProtocolRewardsPool.sol#L203 | ProtocolRewardsPool.sol, LybraWbETHVault.sol, LybraRETHVault.sol | 3 | File: lybra/pools/LybraWbETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
31 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp);
| true | File: lybra/pools/LybraRETHVault.sol
/// @audit balance - preBalance don't perfrom arithmetic
38 emit DepositEther(msg.sender, address(collateralAsset), msg.value,balance - preBalance, block.timestamp);
| true | true | 9 | ||
c4 | 01-salty | J4X Q | Critical | critical | # Low
## [L-01] Reserves Above DUST Incorrectly Enforced
[Pools Line 270](https://github.com/code-423n4/2024-01-salty/blob/main/src/pools/Pools.sol#L271)
**Issue Description:**
In the Salty protocol's `_adjustReservesForSwap()` function, the intention, as per the accompanying comment ("// Make sure that the reserves... | require( (reserve0 >= PoolUtils.DUST) && (reserve1 >= PoolUtils.DUST), "Insufficient reserves after swap"); | require( (reserve0 > PoolUtils.DUST) && (reserve1 > PoolUtils.DUST), "Insufficient reserves after swap"); | access-control | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/J4X-Q.md | 2026-01-02T19:01:19.682280+00:00 | 34983da5651e89aacba4bafc08b57ffb32641a565fb6fde0da8504a5abdd9dc4 | 2 | 2 | 212 | 2 | false | false | true | false | high | require( (reserve0 >= PoolUtils.DUST) && (reserve1 >= PoolUtils.DUST), "Insufficient reserves after swap"); | solidity | 107 | // Code block 1 (solidity):
require( (reserve0 >= PoolUtils.DUST) && (reserve1 >= PoolUtils.DUST), "Insufficient reserves after swap");
// Code block 2 (solidity):
require( (reserve0 > PoolUtils.DUST) && (reserve1 > PoolUtils.DUST), "Insufficient reserves after swap"); | 2 | false | require( (reserve0 >= PoolUtils.DUST) && (reserve1 >= PoolUtils.DUST), "Insufficient reserves after swap");
require( (reserve0 > PoolUtils.DUST) && (reserve1 > PoolUtils.DUST), "Insufficient reserves after swap"); | Pools.sol#L271, Pools.sol#L146-L147 | Pools.sol | 2 | require( (reserve0 >= PoolUtils.DUST) && (reserve1 >= PoolUtils.DUST), "Insufficient reserves after swap"); | true | require( (reserve0 > PoolUtils.DUST) && (reserve1 > PoolUtils.DUST), "Insufficient reserves after swap"); | true | true | 8 | ||
c4 | 01-biconomy | 0x1f8b Q | Critical | critical | - [Low](#low)
- [**1. Use abstract for base contracts**](#1-use-abstract-for-base-contracts)
- [**2. Mixing and Outdated compiler**](#2-mixing-and-outdated-compiler)
- [**3. Wrong logic in paymasterContext**](#3-wrong-logic-in-paymastercontext)
- [**4. Lack of checks**](#4-lack-of-checks)
- [**5. Ce... | pragma solidity 0.8.12; | /**
* @dev Encodes the paymaster context: sender, token, rate, and fee
*/
function paymasterContext(
UserOperation calldata op,
PaymasterData memory data
) internal pure returns (bytes memory context) {
return abi.encode(data.paymasterId);
} | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/0x1f8b-Q.md | 2026-01-02T18:12:45.418982+00:00 | 349d29131e981c202b012d5369599d098d516335157726fcf86786ec62790664 | 0 | 0 | 0 | 4 | false | false | false | false | medium | 0 | 0 | false | Enum.sol#L5, MultiSend.sol#L9, MultiSendCallOnly.sol#L8, Executor.sol#L7 | Enum.sol, Executor.sol, MultiSendCallOnly.sol, MultiSend.sol | 4 | pragma solidity 0.8.12; | true | /**
* @dev Encodes the paymaster context: sender, token, rate, and fee
*/
function paymasterContext(
UserOperation calldata op,
PaymasterData memory data
) internal pure returns (bytes memory context) {
return abi.encode(data.paymasterId);
} | true | true | 6 | ||||||
c4 | 04-caviar | bin2chen Q | High | high | L-01:EthRouter#buy/sell does not determine whether royaltyRecipient is address(0)
If `getRoyalty()` returns royaltyFee>0, but `royaltyRecipient==address(0)` this will transfer the funds to address(0)
Suggest adding judgment:
```solidity
function buy(Buy[] calldata buys, uint256 deadline, bool payRoyalties) public ... | function buy(Buy[] calldata buys, uint256 deadline, bool payRoyalties) public payable {
...
if (payRoyalties) {
uint256 salePrice = inputAmount / buys[i].tokenIds.length;
for (uint256 j = 0; j < buys[i].tokenIds.length; j++) {
// get th... | contract Factory is ERC721, Owned {
...
function setProtocolFeeRate(uint16 _protocolFeeRate) public onlyOwner {
+ if (_protocolFeeRate > 5_000) revert FeeRateTooHigh();
protocolFeeRate = _protocolFeeRate;
} | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/bin2chen-Q.md | 2026-01-02T18:20:18.209858+00:00 | 35b0cf0b068a2657231b50121076e16e978ad9d0b948206e6f6112931257dd09 | 2 | 2 | 1,077 | 0 | false | false | true | false | high | function buy(Buy[] calldata buys, uint256 deadline, bool payRoyalties) public payable {
...
if (payRoyalties) {
uint256 salePrice = inputAmount / buys[i].tokenIds.length;
for (uint256 j = 0; j < buys[i].tokenIds.length; j++) {
// get the ro... | solidity | 847 | // Code block 1 (solidity):
function buy(Buy[] calldata buys, uint256 deadline, bool payRoyalties) public payable {
...
if (payRoyalties) {
uint256 salePrice = inputAmount / buys[i].tokenIds.length;
for (uint256 j = 0; j < buys[i].tokenIds.length; j++) {
... | 2 | false | function buy(Buy[] calldata buys, uint256 deadline, bool payRoyalties) public payable {
...
if (payRoyalties) {
uint256 salePrice = inputAmount / buys[i].tokenIds.length;
for (uint256 j = 0; j < buys[i].tokenIds.length; j++) {
// get the ro... | 0 | function buy(Buy[] calldata buys, uint256 deadline, bool payRoyalties) public payable {
...
if (payRoyalties) {
uint256 salePrice = inputAmount / buys[i].tokenIds.length;
for (uint256 j = 0; j < buys[i].tokenIds.length; j++) {
// get th... | true | contract Factory is ERC721, Owned {
...
function setProtocolFeeRate(uint16 _protocolFeeRate) public onlyOwner {
+ if (_protocolFeeRate > 5_000) revert FeeRateTooHigh();
protocolFeeRate = _protocolFeeRate;
} | true | true | 7 | ||||
c4 | 03-asymmetry | catellatech Q | Critical | critical | ### Issues
| Letter | Name | Description |
|:--:|:-------:|:-------:|
| L | Low risk | Potential risk |
| NC | Non-critical | Non risky findings |
| R | Refactor | Changing the code |
| O | Ordinary | Often found issues |
| Total Found Issues | 21 |
|:--:|:--:|
### Low Risk
| Count | Explanation | Instances |
|:-... | ## [L-02] CRITICAL CHANGES SHOULD USE TWO-STEP PROCEDURE
Handle ownership transfers with two steps and two transactions. First, allow the current owner to propose a new owner address. Second, allow the proposed owner (and only the proposed owner) to accept ownership, and update the contract owner internally
### PROOF ... | ### MITIGATION
Implement zero address check and consider implementing a two step process where the owner nominates an account and the nominated account needs to call an acceptOwnership() function for the transfer of ownership to fully succeed. This ensures the nominated EOA account is a valid and active account.
## [L... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/catellatech-Q.md | 2026-01-02T18:18:55.327681+00:00 | 35bd7ef850a21929bd368d1d633f5a38c086cee24d74939b17c5a45026e0c67c | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | ## [L-02] CRITICAL CHANGES SHOULD USE TWO-STEP PROCEDURE
Handle ownership transfers with two steps and two transactions. First, allow the current owner to propose a new owner address. Second, allow the proposed owner (and only the proposed owner) to accept ownership, and update the contract owner internally
### PROOF ... | true | ### MITIGATION
Implement zero address check and consider implementing a two step process where the owner nominates an account and the nominated account needs to call an acceptOwnership() function for the transfer of ownership to fully succeed. This ensures the nominated EOA account is a valid and active account.
## [L... | true | true | 5 | ||||||||
c4 | 03-revert-lend | SAQ G | High | high | ## Summary
### Gas Optimization
no | Issue |Instances||
|-|:-|:-:|:-:|
| [G-01] | Can make the variable outside the loop to save gas | 1 | - |
| [G-02] | Don't initialize variables with default value | 12 | - |
| [G-03] | Using storage instead of memory for structs/arrays saves gas | 3 | - |
| [G-04] | Duplicated req... | file: /src/automators/Automator.sol
112 uint256 balance = IERC20(tokens[i]).balanceOf(address(this));
| file: /src/V3Vault.so
118 uint32 public reserveFactorX32 = 0;
124 uint256 public debtSharesTotal = 0;
127 uint256 public lastExchangeRateUpdate = 0;
131 uint256 public globalDebtLimit = 0;
132 uint256 public globalLendLimit = 0;
135 uint256 public minLoanSize = 0;
138 uint256 public dailyLen... | access-control | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/SAQ-G.md | 2026-01-02T19:03:03.737640+00:00 | 36381739e7b59c539224973102dee1a6f589747f8d82754ba164a75126917987 | 2 | 2 | 735 | 1 | false | false | true | false | high | file: /src/automators/Automator.sol
112 uint256 balance = IERC20(tokens[i]).balanceOf(address(this)); | solidity | 113 | // Code block 1 (solidity):
file: /src/automators/Automator.sol
112 uint256 balance = IERC20(tokens[i]).balanceOf(address(this));
// Code block 2 (solidity):
file: /src/V3Vault.so
118 uint32 public reserveFactorX32 = 0;
124 uint256 public debtSharesTotal = 0;
127 uint256 public lastExchangeRate... | 2 | false | file: /src/automators/Automator.sol
112 uint256 balance = IERC20(tokens[i]).balanceOf(address(this));
file: /src/V3Vault.so
118 uint32 public reserveFactorX32 = 0;
124 uint256 public debtSharesTotal = 0;
127 uint256 public lastExchangeRateUpdate = 0;
131 uint256 public globalDebtLimit = 0;
... | Automator.sol#L112-L1 | Automator.sol | 1 | file: /src/automators/Automator.sol
112 uint256 balance = IERC20(tokens[i]).balanceOf(address(this));
| true | file: /src/V3Vault.so
118 uint32 public reserveFactorX32 = 0;
124 uint256 public debtSharesTotal = 0;
127 uint256 public lastExchangeRateUpdate = 0;
131 uint256 public globalDebtLimit = 0;
132 uint256 public globalLendLimit = 0;
135 uint256 public minLoanSize = 0;
138 uint256 public dailyLen... | true | true | 8 | ||
c4 | 04-caviar | Sathish9098 G | High | high | ## GAS OPTIMIZATIONS
| Gas Count | Issues | Instances | Gas Saved|
| --------------- | --------------- | --------------- | --------------- |
| [G-1] | Structs can be packed into fewer storage slots | 2 | 40000 |
| [G-2] | Optimize names to save gas | 38 | - |
| [G-3] | Functions guaranteed to revert when called ... | FILE: 2023-04-caviar/src/EthRouter.sol
/// @audit Variable ordering with 6 slots instead of the current 7 :
/// address(20):pool,address(20):nft,bool(1):isPublicPool,uint256(dynamic):tokenIds,uint256(dynamic):tokenWeights, PrivatePool(32):proof,uint256(32):baseTokenAmount
48: struct Buy {
49: address payable... | /// @audit Variable ordering with 7 slots instead of the current 8 :
///
58: struct Sell {
59: address payable pool;
60: address nft;
+65: bool isPublicPool;
61: uint256[] tokenIds;
62: uint256[] tokenWeights;
63: PrivatePool.MerkleMultiProof proof;
64: IStolenNftOrac... | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/Sathish9098-G.md | 2026-01-02T18:20:06.064942+00:00 | 363aab3937be8d4cdc9003698f1490e84d36c31893266322c3bd6ee6d4cd00ce | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | FILE: 2023-04-caviar/src/EthRouter.sol
/// @audit Variable ordering with 6 slots instead of the current 7 :
/// address(20):pool,address(20):nft,bool(1):isPublicPool,uint256(dynamic):tokenIds,uint256(dynamic):tokenWeights, PrivatePool(32):proof,uint256(32):baseTokenAmount
48: struct Buy {
49: address payable... | true | /// @audit Variable ordering with 7 slots instead of the current 8 :
///
58: struct Sell {
59: address payable pool;
60: address nft;
+65: bool isPublicPool;
61: uint256[] tokenIds;
62: uint256[] tokenWeights;
63: PrivatePool.MerkleMultiProof proof;
64: IStolenNftOrac... | true | true | 5 | ||||||||
c4 | 09-ondo | mojito_auditor Q | Medium | medium | # Summary
| Id | Title |
| --- | --- |
| L-1 | Function `_mul()` does not work with Solidity 0.8 |
| L-2 | Incorrect naming variable in `unwrap()` function |
| L-3 | Pre and post rebase amount will always be equal |
# L-1. Function `_mul()` does not work with Solidity 0.8
https://github.com/code-423n4/2023-09-ondo/b... | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
// @audit Solidity 0.8 will revert when doing `x * y`
require(y == 0 || (z = x * y) / y == x);
} | function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
// @audit Should be `shareAmount` instead of `usdyAmount`
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burn... | oracle | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/mojito_auditor-Q.md | 2026-01-02T18:26:07.258503+00:00 | 3640227d7de858f88bf5d5957259855dd6a70573c49f8fe6e2c9706ca6478b31 | 2 | 2 | 631 | 2 | false | false | true | false | high | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
// @audit Solidity 0.8 will revert when doing `x * y`
require(y == 0 || (z = x * y) / y == x);
} | solidity | 173 | // Code block 1 (solidity):
function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
// @audit Solidity 0.8 will revert when doing `x * y`
require(y == 0 || (z = x * y) / y == x);
}
// Code block 2 (solidity):
function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0... | 2 | false | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
// @audit Solidity 0.8 will revert when doing `x * y`
require(y == 0 || (z = x * y) / y == x);
}
function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
// @aud... | RWADynamicOracle.sol#L405, rUSDY.sol#L451 | rUSDY.sol, RWADynamicOracle.sol | 2 | function _mul(uint256 x, uint256 y) internal pure returns (uint256 z) {
// @audit Solidity 0.8 will revert when doing `x * y`
require(y == 0 || (z = x * y) / y == x);
} | true | function unwrap(uint256 _rUSDYAmount) external whenNotPaused {
require(_rUSDYAmount > 0, "rUSDY: can't unwrap zero rUSDY tokens");
// @audit Should be `shareAmount` instead of `usdyAmount`
uint256 usdyAmount = getSharesByRUSDY(_rUSDYAmount);
if (usdyAmount < BPS_DENOMINATOR) revert UnwrapTooSmall();
_burn... | true | true | 8 | ||
c4 | 11-kelp | Stormreckson Q | Low | low | https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68daeb0661e43ee3/src/RSETH.sol#L14-L20
1- contract does inherit it's own interface
`RSETH.SOL` is not inheriting `IRSETH.SOL`
Contract implementations should inherit their interfaces. Extending an interface ensures that all function signatures ... | contract RSETH is
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
AccessControlUpgradeable | contract RSETH is IRSETH
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
AccessControlUpgradeable | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/Stormreckson-Q.md | 2026-01-02T18:27:41.211826+00:00 | 3646da4f7cb9dd8e452a3898b9843d4789050610ea35b27c94b0cbfbe13bd29b | 2 | 0 | 283 | 3 | false | false | true | false | high | contract RSETH is
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
AccessControlUpgradeable | unknown | 138 | // Code block 1 (unknown):
contract RSETH is
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
AccessControlUpgradeable
// Code block 2 (unknown):
contract RSETH is IRSETH
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
Acces... | 2 | false | RSETH.sol#L14-L20, join.sol#L321, LRTConfig.sol#L80-L81 | LRTConfig.sol, RSETH.sol, join.sol | 3 | contract RSETH is
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
AccessControlUpgradeable | true | contract RSETH is IRSETH
Initializable,
LRTConfigRoleChecker,
ERC20Upgradeable,
PausableUpgradeable,
AccessControlUpgradeable | true | true | 8 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.