source stringclasses 1
value | protocol stringclasses 17
values | title stringlengths 4 24 | severity_raw stringclasses 8
values | severity stringclasses 8
values | description stringlengths 198 2k | vulnerable_code stringlengths 0 2k | fixed_code stringlengths 0 2k | recommendation stringclasses 1
value | category stringclasses 12
values | report_url stringlengths 71 98 | collected_at stringlengths 32 32 | source_hash stringlengths 64 64 | code_block_count int64 0 10 | solidity_block_count int64 0 10 | total_code_chars int64 0 1.73k | github_ref_count int64 0 26 | vulnerable_code_is_url bool 2
classes | fixed_code_is_url bool 2
classes | has_code_in_description bool 2
classes | has_recommendation bool 1
class | quality_estimate stringclasses 2
values | primary_code stringlengths 0 1.72k | primary_code_language stringclasses 19
values | primary_code_char_count int64 0 1.72k | all_code_blocks stringlengths 0 1.87k | all_code_blocks_count int64 0 10 | has_diff_blocks bool 2
classes | diff_code stringclasses 71
values | solidity_code stringlengths 0 1.68k | github_refs_formatted stringlengths 0 562 | github_files_list stringlengths 0 203 | github_refs_count int64 0 26 | vulnerable_code_actual stringlengths 0 2k | has_vulnerable_code_snippet bool 2
classes | fixed_code_actual stringlengths 0 2k | has_fixed_code_snippet bool 2
classes | has_vuln_fix_pair bool 2
classes | content_richness_score float64 2.4 15 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
c4 | 11-kelp | hals Q | Low | low | # Findings Summary
| ID | Title | Severity |
| ------------- | -----------------------------------------------------------------------------------------------------------------------... | function maxApproveToEigenStrategyManager(address asset)
external
override
onlySupportedAsset(asset)
onlyLRTManager
{
address eigenlayerStrategyManagerAddress = lrtConfig.getContract(LRTConstants.EIGEN_STRATEGY_MANAGER);
IERC20(asset).approve(eigenlayerStrategyMana... | ```diff
- function maxApproveToEigenStrategyManager(address asset)
- external
- override
- onlySupportedAsset(asset)
- onlyLRTManager
- {
- address eigenlayerStrategyManagerAddress = lrtConfig.getContract(LRTConstants.EIGEN_STRATEGY_MANAGER);
- IERC20(asset).approve(eigenl... | reentrancy | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/hals-Q.md | 2026-01-02T18:28:05.491227+00:00 | 8fe1a5e3783a3e547c0e516cf24d166cb11de6fa95fd0ddf0f9bd84ae662029f | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function maxApproveToEigenStrategyManager(address asset)
external
override
onlySupportedAsset(asset)
onlyLRTManager
{
address eigenlayerStrategyManagerAddress = lrtConfig.getContract(LRTConstants.EIGEN_STRATEGY_MANAGER);
IERC20(asset).approve(eigenlayerStrategyMana... | true | ```diff
- function maxApproveToEigenStrategyManager(address asset)
- external
- override
- onlySupportedAsset(asset)
- onlyLRTManager
- {
- address eigenlayerStrategyManagerAddress = lrtConfig.getContract(LRTConstants.EIGEN_STRATEGY_MANAGER);
- IERC20(asset).approve(eigenl... | true | true | 5 | ||||||||
c4 | 02-ethos | abiih G | High | high | # Report
---
## Gas Optimizations
---
| | Findings |
| --- | -----------------------------------------------------------------------------------------------------------------------... | 2. ### Increments/Decrements Can Be Unchecked In For-Loops
Consider wrapping with an unchecked block here (around 25 gas saved per instance): The change would be:
- https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/CollateralConfig.sol#L56
- https://github.com/code-423n4/2023-02-ethos/blob/... | 3. ### Use Named Returns For Local Variables Where It Is Possible
---
- https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/BorrowerOperations.sol#L419
| other | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/abiih-G.md | 2026-01-02T18:16:45.453992+00:00 | 900b00cfd62ee98fb8c25a73718dace2039b044a885f5ca8f2b3df82df886443 | 0 | 0 | 0 | 5 | false | false | false | false | medium | 0 | 0 | false | CollateralConfig.sol#L56, TroveManager.sol#L608, TroveManager.sol#L690, TroveManager.sol#L882, BorrowerOperations.sol#L419 | TroveManager.sol, BorrowerOperations.sol, CollateralConfig.sol | 5 | 2. ### Increments/Decrements Can Be Unchecked In For-Loops
Consider wrapping with an unchecked block here (around 25 gas saved per instance): The change would be:
- https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/CollateralConfig.sol#L56
- https://github.com/code-423n4/2023-02-ethos/blob/... | true | 3. ### Use Named Returns For Local Variables Where It Is Possible
---
- https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/BorrowerOperations.sol#L419
| true | true | 6 | ||||||
c4 | 01-ondo | 0xSmartContract Q | Critical | critical | ## Summary
### Low Risk Issues List
| Number |Issues Details|Context|
|:--:|:-------|:--:|
|[L-01]| Project has NPM Dependency which uses a vulnerable version : `axios`| 1 |
|[L-02]| Project has NPM Dependency which uses a vulnerable version : `node-fetch`| 1 |
|[L-03]| Loss of precision due to rounding| 1 |
|[L-04]| M... | package.json:
28 "deploy": "hardhat --network ethereum deploy"
29: },
30: "dependencies": {
35: "axios": "0.21.1", | package.json:
29 },
30: "dependencies": {
52: "node-fetch": "2.6.1",
| reentrancy | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/0xSmartContract-Q.md | 2026-01-02T18:14:22.094256+00:00 | 90101765b38058c8fcdcb229df72fc30db74c430925858979c5e281138943aa2 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | package.json:
28 "deploy": "hardhat --network ethereum deploy"
29: },
30: "dependencies": {
35: "axios": "0.21.1", | true | package.json:
29 },
30: "dependencies": {
52: "node-fetch": "2.6.1",
| true | true | 5 | ||||||||
c4 | 06-lybra | SanketKogekar Q | Low | low |
1. There are multiple cases when transfer can fail silently as returned value is unchecked, one of the example would be in `LybraConfiguration.distributeRewards()`
```
peUSD.transfer(address(lybraProtocolRewardsPool), peUSDBalance);
```
It is recommended to prefer using `safeTransfer` / `safeApprove` functions from O... | peUSD.transfer(address(lybraProtocolRewardsPool), peUSDBalance); | require(_ratio > 0, "Ratio should be greater than 0"); | other | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/SanketKogekar-Q.md | 2026-01-02T18:22:43.098271+00:00 | 90532c143494cf74929ff72a8628bc4c49059d23aac8a250e22ee89fea0d7ada | 5 | 0 | 294 | 4 | false | false | true | false | high | peUSD.transfer(address(lybraProtocolRewardsPool), peUSDBalance); | unknown | 64 | // Code block 1 (unknown):
peUSD.transfer(address(lybraProtocolRewardsPool), peUSDBalance);
// Code block 2 (unknown):
require(_ratio > 0, "Ratio should be greater than 0");
// Code block 3 (unknown):
require(newRatio <= 5, "Max Keeper reward is 5%");
// Code block 4 (unknown):
* @param newRatio The new reward ratio... | 5 | false | LybraConfigurator.sol#L292-L293, LybraConfigurator.sol#L246-L249, LybraConfigurator.sol#L235-L240, LybraConfigurator.sol#L224-L228 | LybraConfigurator.sol | 4 | peUSD.transfer(address(lybraProtocolRewardsPool), peUSDBalance); | true | require(_ratio > 0, "Ratio should be greater than 0"); | true | true | 11 | |||
c4 | 04-caviar | Rolezn Q | Critical | critical | ## Summary<a name="Summary">
### Low Risk Issues
| |Issue|Contexts|
|-|:-|:-:|
| [LOW‑1](#LOW‑1) | Add to `blacklist` function | 1 |
| [LOW‑2](#LOW‑2) | Do not allow fees to be set to `100%` | 2 |
| [LOW‑3](#LOW‑3) | `decimals()` not part of ERC20 standard | 2 |
| [LOW‑... | modifier nonBlacklistRequired(address extension) {
require(!_blacklistedExtensions.contains(extension), "Extension blacklisted");
_;
} | function setProtocolFeeRate(uint16 _protocolFeeRate) public onlyOwner {
protocolFeeRate = _protocolFeeRate;
}
| reentrancy | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/Rolezn-Q.md | 2026-01-02T18:20:03.216350+00:00 | 90eb6c61490d039a732b23ed75770577602d9e3412d3b868da2776f707df64df | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | modifier nonBlacklistRequired(address extension) {
require(!_blacklistedExtensions.contains(extension), "Extension blacklisted");
_;
} | true | function setProtocolFeeRate(uint16 _protocolFeeRate) public onlyOwner {
protocolFeeRate = _protocolFeeRate;
}
| true | true | 5 | ||||||||
c4 | 09-ondo | mrudenko G | Gas | gas | RWADynamicOracle
1) Storage is one of the most expensive operations in terms of gas. Reducing storage writes can save a significant amount of gas.
For example, in the overrideRange function:
```
ranges[indexToModify] = Range(
newStart,
newEnd,
newDailyIR,
newPrevRangeClosePrice
);... | ranges[indexToModify] = Range(
newStart,
newEnd,
newDailyIR,
newPrevRangeClosePrice
);
| ranges[indexToModify].start = newStart;
ranges[indexToModify].end = newEnd;
ranges[indexToModify].dailyInterestRate = newDailyIR;
ranges[indexToModify].prevRangeClosePrice = newPrevRangeClosePrice; | oracle | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/mrudenko-G.md | 2026-01-02T18:26:07.706242+00:00 | 90f99fbe38c04497da47c4d443571fdd4497447a391c639418c1c3bdacf24e6d | 3 | 0 | 426 | 0 | false | false | true | false | high | ranges[indexToModify] = Range(
newStart,
newEnd,
newDailyIR,
newPrevRangeClosePrice
); | unknown | 124 | // Code block 1 (unknown):
ranges[indexToModify] = Range(
newStart,
newEnd,
newDailyIR,
newPrevRangeClosePrice
);
// Code block 2 (unknown):
ranges[indexToModify].start = newStart;
ranges[indexToModify].end = newEnd;
ranges[indexToModify].dailyInterestRate = newDailyIR;
ranges[ind... | 3 | false | 0 | ranges[indexToModify] = Range(
newStart,
newEnd,
newDailyIR,
newPrevRangeClosePrice
);
| true | ranges[indexToModify].start = newStart;
ranges[indexToModify].end = newEnd;
ranges[indexToModify].dailyInterestRate = newDailyIR;
ranges[indexToModify].prevRangeClosePrice = newPrevRangeClosePrice; | true | true | 7.25 | |||||
c4 | 05-ajna | nzm_ Q | Medium | medium | ### Events should have `msg.sender`'s indexed address as an argument
When a transaction is triggered based on a user's action, not being able to filter based on who triggered the action makes event processing a lot more cumbersome. Including `msg.sender` in the events will make events much more useful.
9 Instances f... | newTopSlate_ = currentSlateHash == 0 ||
(currentSlateHash != 0 && sum > _sumProposalFundingVotes(_fundedProposalSlates[currentSlateHash])); | modifier mayInteract(address pool_, uint256 tokenId_) {
// revert if token id is not a valid / minted id
_requireMinted(tokenId_);
// revert if sender is not owner of or entitled to operate on token id
if (!_isApprovedOrOwner(msg.sender, tokenId_)) revert NoAuth();
// reve... | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/nzm_-Q.md | 2026-01-02T18:21:41.022129+00:00 | 912a38a6d49feff5be3a70021d472877c802e9d834b28bb5f902dc0f737efd42 | 0 | 0 | 0 | 12 | false | false | false | false | medium | 0 | 0 | false | IFunding.sol#L49, IStandardFunding.sol#L74-L77, IStandardFunding.sol#L85-L89, IGrantFund.sol#L24, IPositionManagerEvents.sol#L25-L29, IPositionManagerEvents.sol#L37-L41, IPositionManagerEvents.sol#L52-L59, IPositionManagerEvents.sol#L66-L70, IRewardsManagerEvents.sol#L32-L36, StandardFunding.sol#L63, StandardFunding.so... | IStandardFunding.sol, IPositionManagerEvents.sol, IRewardsManagerEvents.sol, StandardFunding.sol, IGrantFund.sol, IFunding.sol | 12 | newTopSlate_ = currentSlateHash == 0 ||
(currentSlateHash != 0 && sum > _sumProposalFundingVotes(_fundedProposalSlates[currentSlateHash])); | true | modifier mayInteract(address pool_, uint256 tokenId_) {
// revert if token id is not a valid / minted id
_requireMinted(tokenId_);
// revert if sender is not owner of or entitled to operate on token id
if (!_isApprovedOrOwner(msg.sender, tokenId_)) revert NoAuth();
// reve... | true | true | 6 | ||||||
c4 | 03-asymmetry | MiniGlome G | High | high | ## Gas Optimizations
| |Issue|Instances|
|-|:-|:-:|
| [GAS-01] | The result of function calls should be cached rather than re-calling the function | 2 |
| [GAS-02] | For loop can be replace by simple addition | 1 |
| [GAS-03] | Check should be done before For loop | 1 |
| [GAS-04] | Check should be done beforehand | ... | File: contracts/SafEth/SafEth.sol
74: derivatives[i].balance()
142: derivatives[i].withdraw(derivatives[i].balance());
| File: contracts/SafEth/SafEth.sol
190: uint256 localTotalWeight = 0;
for (uint256 i = 0; i < derivativeCount; i++)
localTotalWeight += weights[i];
totalWeight = localTotalWeight;
| access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/MiniGlome-G.md | 2026-01-02T18:18:21.153885+00:00 | 912fc8a145f081732140b70230d8b8523d844bbe31c8bbbd72b7577447ed5b15 | 3 | 3 | 347 | 0 | false | false | true | false | high | File: contracts/SafEth/SafEth.sol
74: derivatives[i].balance()
142: derivatives[i].withdraw(derivatives[i].balance()); | solidity | 126 | // Code block 1 (solidity):
File: contracts/SafEth/SafEth.sol
74: derivatives[i].balance()
142: derivatives[i].withdraw(derivatives[i].balance());
// Code block 2 (solidity):
File: contracts/SafEth/SafEth.sol
190: uint256 localTotalWeight = 0;
for (uint256 i = 0; i < derivativeCount; i++)
localTotalWeight... | 3 | false | File: contracts/SafEth/SafEth.sol
74: derivatives[i].balance()
142: derivatives[i].withdraw(derivatives[i].balance());
File: contracts/SafEth/SafEth.sol
190: uint256 localTotalWeight = 0;
for (uint256 i = 0; i < derivativeCount; i++)
localTotalWeight += weights[i];
totalWeight = localTotalWeight;
total... | 0 | File: contracts/SafEth/SafEth.sol
74: derivatives[i].balance()
142: derivatives[i].withdraw(derivatives[i].balance());
| true | File: contracts/SafEth/SafEth.sol
190: uint256 localTotalWeight = 0;
for (uint256 i = 0; i < derivativeCount; i++)
localTotalWeight += weights[i];
totalWeight = localTotalWeight;
| true | true | 8 | ||||
c4 | 09-ondo | 0xanmol G | Medium | medium | ## [G-1] In the ```_rpow``` function the n is never gonna be 0 so it is useless to run the switch case to check if n==0
### Code line
https://github.com/code-423n4/2023-09-ondo/blob/47d34d6d4a5303af5f46e907ac2292e6a7745f6c/contracts/rwaOracles/RWADynamicOracle.sol#L354
### Details
In ```_rpow``` there is a switch ... | oracle | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/0xanmol-G.md | 2026-01-02T18:25:14.845307+00:00 | 9132288c0a5cfd849521385c8f58de1f55aeb33cbed3e385b2876926b76613d4 | 1 | 1 | 148 | 1 | true | true | true | false | medium | - case 0 {
- switch n
- case 0 { z := base }
- default { z := 0 }
}
+ case 0 {
+ s := 0
+ } | diff | 148 | // Code block 1 (diff):
- case 0 {
- switch n
- case 0 { z := base }
- default { z := 0 }
}
+ case 0 {
+ s := 0
+ } | 1 | true | - case 0 {
- switch n
- case 0 { z := base }
- default { z := 0 }
}
+ case 0 {
+ s := 0
+ } | RWADynamicOracle.sol#L354 | RWADynamicOracle.sol | 1 | false | false | false | 5.66 | ||||||
c4 | 08-dopex | Stryder Q | Unknown | unknown | # [NC-01] Missing Validation Checks for tokenA and tokenB in **approveContractToSpend** function
Since the contract is only dealing with weth and rdpx tokens , so all the transactions that happen must involve those tokens only. Please consider adding a check for checking if the token address passed is either tokenA o... | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(_token == addresses.tokenA || _token ==addresses.tokenB )
require(_token != address(0), "reLPContract: token cannot be 0");
require(_spender != address(0), "reLP... | require(_amount0Min!=0 && _amount1Min!=0); | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Stryder-Q.md | 2026-01-02T18:25:08.567489+00:00 | 913729a81da68fc16a73c4e55725324569c7d02cda595d00d27e50fcd8fecaec | 1 | 0 | 855 | 3 | false | false | true | false | high | Link : https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/amo/UniV2LiquidityAmo.sol#L126-L135
# [NC-02] Consider using addLiquidityETH instead of addLiquidity
Since the contract is dealing with weth , its suggested to use addLiquidityETH instead of using addLiquidity . Its also given in the uniswap docs... | unknown | 855 | // Code block 1 (unknown):
Link : https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/amo/UniV2LiquidityAmo.sol#L126-L135
# [NC-02] Consider using addLiquidityETH instead of addLiquidity
Since the contract is dealing with weth , its suggested to use addLiquidityETH instead of using addLiquidity . Its als... | 1 | false | UniV2LiquidityAmo.sol#L126-L135, UniV2LiquidityAmo.sol#L223, UniV3LiquidityAmo.sol#L178-L191 | UniV2LiquidityAmo.sol, UniV3LiquidityAmo.sol | 3 | function approveContractToSpend(
address _token,
address _spender,
uint256 _amount
) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(_token == addresses.tokenA || _token ==addresses.tokenB )
require(_token != address(0), "reLPContract: token cannot be 0");
require(_spender != address(0), "reLP... | true | require(_amount0Min!=0 && _amount1Min!=0); | true | true | 7 | |||
c4 | 09-ondo | Arz Q | Low | low | ### Low risk issues
| |Issue|Instances|
|-|:-|:-:|
| [L‑01] | The admin wont be able to burn rUSDY if the address is blacklisted/sanctioned and not on the allowlist | 1 |
| [L‑02] | When overriding a range the prevRangeClosePrice of the next range is not updated | 1 |
| [L‑03] | If a user wrap... | File: usdy/rUSDY.sol
672: function burn(
673: address _account,
674: uint256 _amount
675: ) external onlyRole(BURNER_ROLE) {
676: uint256 sharesAmount = getSharesByRUSDY(_amount);
677:
678: _burnShares(_account, sharesAmount); | File: rwaOracles/RWADynamicOracle.sol
218: if (indexToModify == 0) {
219: uint256 trueStart = (newPrevRangeClosePrice * ONE) / newDailyIR;
220: ranges[indexToModify] = Range(newStart, newEnd, newDailyIR, trueStart);
221: } else {
222: ranges[indexToModify] = Range(
223: newStart,
224: newEn... | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/Arz-Q.md | 2026-01-02T18:25:23.265968+00:00 | 913bc7a2a115ac6de319bc06729587fb0ca446cfae30e880df831183cc0bb0dc | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: usdy/rUSDY.sol
672: function burn(
673: address _account,
674: uint256 _amount
675: ) external onlyRole(BURNER_ROLE) {
676: uint256 sharesAmount = getSharesByRUSDY(_amount);
677:
678: _burnShares(_account, sharesAmount); | true | File: rwaOracles/RWADynamicOracle.sol
218: if (indexToModify == 0) {
219: uint256 trueStart = (newPrevRangeClosePrice * ONE) / newDailyIR;
220: ranges[indexToModify] = Range(newStart, newEnd, newDailyIR, trueStart);
221: } else {
222: ranges[indexToModify] = Range(
223: newStart,
224: newEn... | true | true | 5 | ||||||||
c4 | 09-ondo | zabihullahazadzoi G | High | high | # Ondo Finance - Gas Optimizations Report
**Notes**:
- For Gas estimates I’ve tried to give the exact amount of gas being saved from running the included tests. Whenever the function is within the test coverage, the average, before and after will be included, and often a diff of the code will also accompany this.
Som... | File: contracts/bridge/SourceBridge.sol
122 string memory destinationChain, | https://github.com/code-423n4/2023-09-ondo/blob/47d34d6d4a5303af5f46e907ac2292e6a7745f6c/contracts/bridge/SourceBridge.sol#L122
| access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/zabihullahazadzoi-G.md | 2026-01-02T18:26:22.500806+00:00 | 917d9fb577feb8beb0602a993fd508161171635a00b14ab68f1b48ba765b4c6b | 0 | 0 | 0 | 1 | false | true | false | false | medium | 0 | 0 | false | SourceBridge.sol#L122 | SourceBridge.sol | 1 | File: contracts/bridge/SourceBridge.sol
122 string memory destinationChain, | true | false | false | 5 | |||||||
c4 | 03-asymmetry | Jerry0x G | High | high | ```
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L79-L81
if (totalSupply != 0)
preDepositPrice = (10 ** 18 * underlyingValue) / totalSupply;
else
preDepositPrice = 10 ** 18; // initializes with a price of 1
```
```
https://github.com/co... | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L79-L81
if (totalSupply != 0)
preDepositPrice = (10 ** 18 * underlyingValue) / totalSupply;
else
preDepositPrice = 10 ** 18; // initializes with a price of 1 | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L72-L75
for (uint i = 0; i < derivativeCount; i++){
IDerivative derivative = derivatives[i];
underlyingValue +=
(derivative.ethPerDerivative(derivative.balance()) *
... | upgrade | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Jerry0x-G.md | 2026-01-02T18:18:12.019979+00:00 | 9186cde7ff36091b344fbe525b178f947d750cd242be905cd37b559ab28a40e0 | 4 | 0 | 1,228 | 4 | false | false | true | false | high | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L79-L81
if (totalSupply != 0)
preDepositPrice = (10 ** 18 * underlyingValue) / totalSupply;
else
preDepositPrice = 10 ** 18; // initializes with a price of 1 | unknown | 285 | // Code block 1 (unknown):
https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L79-L81
if (totalSupply != 0)
preDepositPrice = (10 ** 18 * underlyingValue) / totalSupply;
else
preDepositPrice = 10 ** 18; // initializes with a price of 1
// Cod... | 4 | false | SafEth.sol#L79-L81, SafEth.sol#L72-L75, SafEth.sol#L65-L66, Reth.sol#L215 | Reth.sol, SafEth.sol | 4 | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L79-L81
if (totalSupply != 0)
preDepositPrice = (10 ** 18 * underlyingValue) / totalSupply;
else
preDepositPrice = 10 ** 18; // initializes with a price of 1 | true | https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/SafEth.sol#L72-L75
for (uint i = 0; i < derivativeCount; i++){
IDerivative derivative = derivatives[i];
underlyingValue +=
(derivative.ethPerDerivative(derivative.balance()) *
... | true | true | 9.53 | |||
c4 | 07-amphora | foxb868 G | High | high | ## GAS-01 - Large Loop in _calculate Function
In the `_calculate` function, the loop is used to calculate the amount of AMPH to mint based on the input token amount `(_tempAmountReceived)`. The loop iterates to determine how much AMPH should be minted for a given amount of input tokens (CRV) based on certain conditions... | while (_tempAmountReceived > 0) {
// ... loop body ...
} | _amphForThisTurn = ((_rate * _tempAmountReceived) / 1e12) / 1e6; // 1e6 | dos | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/foxb868-G.md | 2026-01-02T18:23:47.916115+00:00 | 91bf5d746534db76b6dae866f7537d09275457975dd8b8155d6fa754827ac56e | 1 | 1 | 58 | 2 | false | false | true | false | high | while (_tempAmountReceived > 0) {
// ... loop body ...
} | solidity | 58 | // Code block 1 (solidity):
while (_tempAmountReceived > 0) {
// ... loop body ...
} | 1 | false | while (_tempAmountReceived > 0) {
// ... loop body ...
} | AMPHClaimer.sol#L210, AMPHClaimer.sol#L222 | AMPHClaimer.sol | 2 | while (_tempAmountReceived > 0) {
// ... loop body ...
} | true | _amphForThisTurn = ((_rate * _tempAmountReceived) / 1e12) / 1e6; // 1e6 | true | true | 7 | ||
c4 | 08-dopex | HHK Q | Low | low | ### INFO1: Natspec return values are inversed for [`_calculateAmounts()`](https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/core/RdpxV2Core.sol#L598).
#### Technical Details
In the function `_calculateAmounts()` the `amount1` returned is the amount received by the del... | other | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/HHK-Q.md | 2026-01-02T18:24:39.293075+00:00 | 91f5e7915c577f0128326201ce5671edb63a5c45b218a080e6d412e8cbcbc92d | 1 | 1 | 225 | 3 | true | true | true | false | medium | - * @return amount1 The amount received by the delegate
- * @return amount2 The amount received by the delegatee
+ * @return amount1 The amount received by the delegatee
+ * @return amount2 The amount received by the delegate | diff | 225 | // Code block 1 (diff):
- * @return amount1 The amount received by the delegate
- * @return amount2 The amount received by the delegatee
+ * @return amount1 The amount received by the delegatee
+ * @return amount2 The amount received by the delegate | 1 | true | - * @return amount1 The amount received by the delegate
- * @return amount2 The amount received by the delegatee
+ * @return amount1 The amount received by the delegatee
+ * @return amount2 The amount received by the delegate | RdpxV2Core.sol#L598, RdpxV2Core.sol#L1016, UniV3LiquidityAmo.sol#L94 | RdpxV2Core.sol, UniV3LiquidityAmo.sol | 3 | false | false | false | 7 | ||||||
c4 | 02-ethos | cryptostellar5 G | High | high |
|Sno.|Issue|Instances|Gas Savings|
|---|---|---|---|
|[G-01]|++I or I++ SHOULD BE UNCHECKED{++I} or UNCHECKED{I++} WHEN IT IS NOT POSSIBLE FOR THEM TO OVERFLOW, AS IS THE CASE WHEN USED IN FOR- AND WHILE-LOOPS|15|600
|[G-02]|REQUIRE or REVERT STRINGS LONGER THAN 32 BYTES COST EXTRA GAS|47|141
|[G-03]|SPLITTING REQUIR... | 108: for(uint256 i = 0; i < numCollaterals; i++) { | 56: for(uint256 i = 0; i < _collaterals.length; i++) { | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/cryptostellar5-G.md | 2026-01-02T18:17:00.674317+00:00 | 91f74f7be617381077d52910c74f43eacd3058b77a16ef95f0843e3cfd291bb5 | 3 | 0 | 404 | 3 | false | false | true | false | high | 108: for(uint256 i = 0; i < numCollaterals; i++) { | unknown | 50 | // Code block 1 (unknown):
108: for(uint256 i = 0; i < numCollaterals; i++) {
// Code block 2 (unknown):
56: for(uint256 i = 0; i < _collaterals.length; i++) {
// Code block 3 (unknown):
351: for (uint i = 0; i < numCollaterals; i++) {
397: for (uint i = 0; i < numCollaterals; i++) {
640: for (uint i = 0; i < assets.... | 3 | false | ActivePool.sol, CollateralConfig.sol, StabilityPool.sol | CollateralConfig.sol, ActivePool.sol, StabilityPool.sol | 3 | 108: for(uint256 i = 0; i < numCollaterals; i++) { | true | 56: for(uint256 i = 0; i < _collaterals.length; i++) { | true | true | 9 | |||
c4 | 07-amphora | 0xSmartContract Analysis | Critical | critical | # Analysis -🏺Amphora Project 🏺
### Summary
| List |Head |Details|
|:--|:----------------|:------|
|a) |The approach I followed when reviewing the code | Stages in my code review and analysis |
|b) |Analysis of the code base | What is unique? How are the existing patterns used? |
|c) |Test analysis | Test scope of th... | core\solidity\test\invariant\USDA.t.sol:
40 /// @dev the sum of all deposits minus the withdrawals, minus the donated amount should be equal to the total supply of USDA
41: function invariant_theSumOfDepositedMinusWithdrawnShouldBeEqualToTotalSupply() public view {
42: uint256 _sUSDInTheSystem = usdaHand... | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/0xSmartContract-Analysis.md | 2026-01-02T18:23:18.822960+00:00 | 91f8fc36442d36e236fa4356b1b882860c1ea8e4275e3e29cb9062abbc579884 | 0 | 0 | 0 | 0 | false | true | false | false | medium | 0 | 0 | false | 0 | core\solidity\test\invariant\USDA.t.sol:
40 /// @dev the sum of all deposits minus the withdrawals, minus the donated amount should be equal to the total supply of USDA
41: function invariant_theSumOfDepositedMinusWithdrawnShouldBeEqualToTotalSupply() public view {
42: uint256 _sUSDInTheSystem = usdaHand... | true | false | false | 4 | ||||||||||
c4 | 02-ethos | Kamil Chmielewski Q | Critical | critical | # QA Report
### Non-Critical Issues
| # | Title | Type | Instances |
| :--: | --- | :---: | :---: |
| N-01 | Use named import syntax | Code Quality | All contracts in scope |
### [N-01] Use named import syntax
Instead of importing entire files, use named import syntax. As the repository grows, static analyzers like ... | other | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Kamil-Chmielewski-Q.md | 2026-01-02T18:16:17.538884+00:00 | 91fe04827e1e3c9a5a6898da292f5b149025d6728739edf8058e0155a5cfe08f | 1 | 1 | 564 | 0 | true | true | true | false | medium | --- a/Ethos-Core/contracts/CollateralConfig.sol
+++ b/Ethos-Core/contracts/CollateralConfig.sol
@@ -2,10 +2,10 @@
pragma solidity 0.6.11;
-import "./Dependencies/CheckContract.sol";
-import "./Dependencies/Ownable.sol";
-import "./Dependencies/SafeERC20.sol";
-import "./Interfaces/ICollateralConfig.sol";
+import {... | diff | 564 | // Code block 1 (diff):
--- a/Ethos-Core/contracts/CollateralConfig.sol
+++ b/Ethos-Core/contracts/CollateralConfig.sol
@@ -2,10 +2,10 @@
pragma solidity 0.6.11;
-import "./Dependencies/CheckContract.sol";
-import "./Dependencies/Ownable.sol";
-import "./Dependencies/SafeERC20.sol";
-import "./Interfaces/ICollater... | 1 | true | --- a/Ethos-Core/contracts/CollateralConfig.sol
+++ b/Ethos-Core/contracts/CollateralConfig.sol
@@ -2,10 +2,10 @@
pragma solidity 0.6.11;
-import "./Dependencies/CheckContract.sol";
-import "./Dependencies/Ownable.sol";
-import "./Dependencies/SafeERC20.sol";
-import "./Interfaces/ICollateralConfig.sol";
+import {... | 0 | false | false | false | 5.55 | ||||||||
c4 | 03-revert-lend | cryptothemex G | Medium | medium | ### Gas Risk Issues
Already reported issues have been removed from report and only new issues are being reported.
### [G-01]<a name="g-01"></a> `a = a + b` is more gas effective than `a += b` for state variables (excluding arrays and mappings)
This saves **16 gas per instance.**
*There are 10 instance(s) of this is... | File: src/V3Oracle.sol
440: fees0 += state.tokensOwed0;
441: fees1 += state.tokensOwed1;
| File: src/transformers/LeverageTransformer.sol
62: amount0 += amountOut;
74: amount1 += amountOut;
153: amount += amountOut;
162: amount += amountOut;
| reentrancy | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/cryptothemex-G.md | 2026-01-02T19:03:09.546123+00:00 | 926d0e24345bbb8a7da1875cc962184fb69d34623e3554250ac6ca2e862b70af | 3 | 3 | 544 | 10 | false | false | true | false | high | File: src/V3Oracle.sol
440: fees0 += state.tokensOwed0;
441: fees1 += state.tokensOwed1; | solidity | 106 | // Code block 1 (solidity):
File: src/V3Oracle.sol
440: fees0 += state.tokensOwed0;
441: fees1 += state.tokensOwed1;
// Code block 2 (solidity):
File: src/transformers/LeverageTransformer.sol
62: amount0 += amountOut;
74: amount1 += amountOut;
153: amount += amo... | 3 | false | File: src/V3Oracle.sol
440: fees0 += state.tokensOwed0;
441: fees1 += state.tokensOwed1;
File: src/transformers/LeverageTransformer.sol
62: amount0 += amountOut;
74: amount1 += amountOut;
153: amount += amountOut;
162: amount += amountOut;
File: sr... | V3Oracle.sol#L440, V3Oracle.sol#L441, LeverageTransformer.sol#L62, LeverageTransformer.sol#L74, LeverageTransformer.sol#L153, LeverageTransformer.sol#L162, V3Utils.sol#L319, V3Utils.sol#L321, V3Utils.sol#L336, V3Utils.sol#L338 | LeverageTransformer.sol, V3Oracle.sol, V3Utils.sol | 10 | File: src/V3Oracle.sol
440: fees0 += state.tokensOwed0;
441: fees1 += state.tokensOwed1;
| true | File: src/transformers/LeverageTransformer.sol
62: amount0 += amountOut;
74: amount1 += amountOut;
153: amount += amountOut;
162: amount += amountOut;
| true | true | 9 | ||
c4 | 03-revert-lend | emerald7017 Analysis | Critical | critical | # Revert Lend Smart Contract Analysis Report
## 1. Introduction
Revert Lend is a decentralized lending protocol designed for Uniswap V3 liquidity providers (LPs). It allows LPs to collateralize their Uniswap V3 positions (NFTs) to borrow assets while retaining control over their LP positions. This report provides an i... | function deposit(uint256 assets, address receiver) external override returns (uint256) {
(, uint256 shares) = _deposit(receiver, assets, false, "");
return shares;
} | function execute(ExecuteParams calldata params) external nonReentrant {
// ...
(state.amount0, state.amount1) = nonfungiblePositionManager.collect(
INonfungiblePositionManager.CollectParams(
params.tokenId, address(this), type(uint128).max, type(uint128).max
)
);
// ...
} | reentrancy | https://github.com/code-423n4/2024-03-revert-lend-findings/blob/main/data/emerald7017-Analysis.md | 2026-01-02T19:03:10.960759+00:00 | 928b4129f75a4b87d72719d2eb3b94f9d2913e8ab2c981a6e17398a149f32e03 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | function deposit(uint256 assets, address receiver) external override returns (uint256) {
(, uint256 shares) = _deposit(receiver, assets, false, "");
return shares;
} | true | function execute(ExecuteParams calldata params) external nonReentrant {
// ...
(state.amount0, state.amount1) = nonfungiblePositionManager.collect(
INonfungiblePositionManager.CollectParams(
params.tokenId, address(this), type(uint128).max, type(uint128).max
)
);
// ...
} | true | true | 5 | ||||||||
c4 | 02-ai-arena | Surfer_05 G | Low | low | File name: src/AiArenaHelper.sol
The constructor can be optimised. We are initialising the attributeProbabilities. Firstly calling the function and then manually.
```solidity
constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
@... | constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
@==> addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (uint8 i = 0; i < attributesLength; i++) {
@==> att... | constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
// commenting out the next line as not needed
@==> // addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (... | access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/Surfer_05-G.md | 2026-01-02T19:02:46.541372+00:00 | 9292d59b06a350a11d3eceba2361bef13b175310db3b301712c29cc05138401a | 2 | 1 | 1,001 | 0 | false | false | true | false | high | constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
@==> addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (uint8 i = 0; i < attributesLength; i++) {
@==> att... | solidity | 472 | // Code block 1 (solidity):
constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
@==> addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (uint8 i = 0; i < attributesLe... | 2 | false | constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
@==> addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (uint8 i = 0; i < attributesLength; i++) {
@==> att... | 0 | constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
@==> addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (uint8 i = 0; i < attributesLength; i++) {
@==> att... | true | constructor(uint8[][] memory probabilities) {
_ownerAddress = msg.sender;
// Initialize the probabilities for each attribute
// commenting out the next line as not needed
@==> // addAttributeProbabilities(0, probabilities);
uint256 attributesLength = attributes.length;
for (... | true | true | 7 | ||||
c4 | 06-lybra | MohammedRizwan Q | Medium | medium | ## Summary
### Low Risk Issues
|Number|Issue|Instances| |
|-|:-|:-:|:-:|
| [L‑01] | Violation of checks, Effects, Interaction Pattern in stakerewardV2pool.stake() | 1 |
| [L‑02] | Prevent reward ratio from rounding to 0 in stakerewardV2pool.notifyRewardAmount() | 1 |
| [L‑03] | Avoid self transfer... | function stake(uint256 _amount) external updateReward(msg.sender) {
require(_amount > 0, "amount = 0"); // checks
- bool success = stakingToken.transferFrom(msg.sender, address(this), _amount);
- require(success, "TF");
balanceOf[msg.sender] +... | File: contracts/lybra/miner/stakerewardV2pool.sol
function notifyRewardAmount(uint256 _amount) external onlyOwner updateReward(address(0)) {
+ require(_amount != 0, "invalid amount");
if (block.timestamp >= finishAt) {
rewardRatio = _amount / duration;
} else {
uint256... | reentrancy | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/MohammedRizwan-Q.md | 2026-01-02T18:22:28.623513+00:00 | 92c599dbfea06a40f04f8ec52f78fa27055fc11fc143ac71a029a46787ff0fc3 | 1 | 0 | 623 | 2 | false | false | true | false | high | function stake(uint256 _amount) external updateReward(msg.sender) {
require(_amount > 0, "amount = 0"); // checks
- bool success = stakingToken.transferFrom(msg.sender, address(this), _amount);
- require(success, "TF");
balanceOf[msg.sender] += _a... | Solidity | 623 | // Code block 1 (Solidity):
function stake(uint256 _amount) external updateReward(msg.sender) {
require(_amount > 0, "amount = 0"); // checks
- bool success = stakingToken.transferFrom(msg.sender, address(this), _amount);
- require(success, "TF");
... | 1 | false | function stake(uint256 _amount) external updateReward(msg.sender) {
require(_amount > 0, "amount = 0"); // checks
- bool success = stakingToken.transferFrom(msg.sender, address(this), _amount);
- require(success, "TF");
balanceOf[msg.sender] += _a... | stakerewardV2pool.sol#L83-L90, stakerewardV2pool.sol#L132-L145 | stakerewardV2pool.sol | 2 | function stake(uint256 _amount) external updateReward(msg.sender) {
require(_amount > 0, "amount = 0"); // checks
- bool success = stakingToken.transferFrom(msg.sender, address(this), _amount);
- require(success, "TF");
balanceOf[msg.sender] +... | true | File: contracts/lybra/miner/stakerewardV2pool.sol
function notifyRewardAmount(uint256 _amount) external onlyOwner updateReward(address(0)) {
+ require(_amount != 0, "invalid amount");
if (block.timestamp >= finishAt) {
rewardRatio = _amount / duration;
} else {
uint256... | true | true | 7 | ||
c4 | 01-biconomy | damoklov G | Medium | medium | ## Biconomy Audit Report
## Gas Optimizations
### Increments should be unchecked
In Solidity 0.8+, there’s a default overflow check on unsigned integers. It’s possible to uncheck this in for-loops and save some gas at each iteration, but at the cost of some code readability, as this uncheck cannot be made inline.
A... | EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opasLen; i++);
EntryPoint.handleAggregatedOps(): for (uint256 a = 0; a < opasLen; a++);
EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opslen; i++); | for (uint256 i; i < numIterations; i++) {
// ...
} | overflow | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/damoklov-G.md | 2026-01-02T18:13:40.492738+00:00 | 92cd57f41d4ef727c86038397136288e1946f9d61b0b01889e353acf340921b7 | 6 | 6 | 535 | 0 | false | false | true | false | high | EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opasLen; i++);
EntryPoint.handleAggregatedOps(): for (uint256 a = 0; a < opasLen; a++);
EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opslen; i++); | solidity | 217 | // Code block 1 (solidity):
EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opasLen; i++);
EntryPoint.handleAggregatedOps(): for (uint256 a = 0; a < opasLen; a++);
EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opslen; i++);
// Code block 2 (solidity):
for (uint256 i; i < numIterations; i++) {
... | 6 | false | EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opasLen; i++);
EntryPoint.handleAggregatedOps(): for (uint256 a = 0; a < opasLen; a++);
EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opslen; i++);
for (uint256 i; i < numIterations; i++) {
// ...
}
for (uint256 i; i < numIterations;) {
// ... | 0 | EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opasLen; i++);
EntryPoint.handleAggregatedOps(): for (uint256 a = 0; a < opasLen; a++);
EntryPoint.handleAggregatedOps(): for (uint256 i = 0; i < opslen; i++); | true | for (uint256 i; i < numIterations; i++) {
// ...
} | true | true | 11 | ||||
c4 | 03-asymmetry | aga7hokakological Q | Low | low | 1. User is unable withdraw eth if a derivative is added afterwards and adjustWeight() is called
Say there are 2 derivatives with 50/50 adjusted weight
Then user stakes
the another derivative is added and weight adjusted is 33/33/33
then another user stakes.
If the first user tries to unstake it gives error. The user sh... | it.only("Check what happens if a derivative is added afterwards", async () => {
const accounts = await ethers.getSigners();
const derivativeCount = (await safEthProxy.derivativeCount()).toNumber();
const initialWeight = BigNumber.from("1000000000000000000");
const initialDeposit = ... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/aga7hokakological-Q.md | 2026-01-02T18:18:44.983227+00:00 | 92d0271e5f31cf9d96c218be2ce63edcfcd44214797d86c5e112f7f2b38a4595 | 0 | 0 | 0 | 0 | false | true | false | false | medium | 0 | 0 | false | 0 | it.only("Check what happens if a derivative is added afterwards", async () => {
const accounts = await ethers.getSigners();
const derivativeCount = (await safEthProxy.derivativeCount()).toNumber();
const initialWeight = BigNumber.from("1000000000000000000");
const initialDeposit = ... | true | false | false | 4 | ||||||||||
c4 | 11-kelp | ni8mare Q | Low | low | ## LOW-RISK ISSUES
1. `addNodeDelegatorContractToQueue` is supposed to be called by LRTManager, but it is being called by LRTAdmin. `onlyLRTAdmin` is used, which is not the correct modifier. This can be seen from the comments below. Correct modifier needs to be used.
```
/// @notice add new node delegator contrac... | /// @notice add new node delegator contract addresses
/// @dev only callable by LRT manager
/// @param nodeDelegatorContracts Array of NodeDelegator contract addresses
function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nod... | /// @notice transfers asset lying in this DepositPool to node delegator contract
/// @dev only callable by LRT manager
/// @param ndcIndex Index of NodeDelegator contract address in nodeDelegatorQueue
/// @param asset Asset address
/// @param amount Asset amount to transfer
function transferAsse... | reentrancy | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/ni8mare-Q.md | 2026-01-02T18:28:17.750106+00:00 | 92d9b1aae4c338bd1419e084e99622b25ae5c57651bcf5ea0beee315e688bff9 | 1 | 0 | 800 | 0 | false | false | true | false | high | /// @notice add new node delegator contract addresses
/// @dev only callable by LRT manager
/// @param nodeDelegatorContracts Array of NodeDelegator contract addresses
function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nodeDel... | unknown | 800 | // Code block 1 (unknown):
/// @notice add new node delegator contract addresses
/// @dev only callable by LRT manager
/// @param nodeDelegatorContracts Array of NodeDelegator contract addresses
function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
... | 1 | false | 0 | /// @notice add new node delegator contract addresses
/// @dev only callable by LRT manager
/// @param nodeDelegatorContracts Array of NodeDelegator contract addresses
function addNodeDelegatorContractToQueue(address[] calldata nodeDelegatorContracts) external onlyLRTAdmin {
uint256 length = nod... | true | /// @notice transfers asset lying in this DepositPool to node delegator contract
/// @dev only callable by LRT manager
/// @param ndcIndex Index of NodeDelegator contract address in nodeDelegatorQueue
/// @param asset Asset address
/// @param amount Asset amount to transfer
function transferAsse... | true | true | 6 | |||||
c4 | 04-caviar | SanketKogekar Q | High | high | ### EthRouter.sol
1. In EthRouter.sol, the `buy()` function does not check if array is too large to be executed in a single transaction. This may result in an out-of-gas error if the array is large.
[Link to code](https://github.com/code-423n4/2023-04-caviar/blob/cd8a92667bcb6657f70657183769c244d04c015c/src/EthRou... | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/SanketKogekar-Q.md | 2026-01-02T18:20:05.490723+00:00 | 92eb5fe28c20c7e934ae3e728110c94c62c326cf0adcc69a7d90448e0e764161 | 1 | 0 | 92 | 4 | true | true | true | false | medium | require(salePrice >= royaltyFee, "Sale price must be greater than or equal to royalty fee"); | unknown | 92 | // Code block 1 (unknown):
require(salePrice >= royaltyFee, "Sale price must be greater than or equal to royalty fee"); | 1 | false | EthRouter.sol#L99, EthRouter.sol#L109, EthRouter.sol#L116, EthRouter.sol#L121 | EthRouter.sol | 4 | false | false | false | 5 | |||||||
c4 | 02-ethos | erictee G | Gas | gas | ### [G-01] Splitting ```require()``` statements that use && saves gas.
#### Impact
Consider splitting the ```require()``` statements to save gas.
#### Findings:
```
Ethos-Core/contracts/BorrowerOperations.sol:L653 require(_maxFeePercentage >= BORROWING_FEE_FLOOR && _maxFeePercentage <= DECIMAL_PRECISION,... | Ethos-Core/contracts/BorrowerOperations.sol:L653 require(_maxFeePercentage >= BORROWING_FEE_FLOOR && _maxFeePercentage <= DECIMAL_PRECISION,
| rounding | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/erictee-G.md | 2026-01-02T18:17:08.724840+00:00 | 930409d800bb701876d973673c20840856ed6acfdd915f20949fb272358464d9 | 1 | 0 | 151 | 0 | false | true | true | false | medium | Ethos-Core/contracts/BorrowerOperations.sol:L653 require(_maxFeePercentage >= BORROWING_FEE_FLOOR && _maxFeePercentage <= DECIMAL_PRECISION, | unknown | 151 | // Code block 1 (unknown):
Ethos-Core/contracts/BorrowerOperations.sol:L653 require(_maxFeePercentage >= BORROWING_FEE_FLOOR && _maxFeePercentage <= DECIMAL_PRECISION, | 1 | false | 0 | Ethos-Core/contracts/BorrowerOperations.sol:L653 require(_maxFeePercentage >= BORROWING_FEE_FLOOR && _maxFeePercentage <= DECIMAL_PRECISION,
| true | false | false | 2.65 | |||||||
c4 | 02-ethos | Bnke0x0 G | High | high |
### [G01] State variables only set in the constructor should be declared `immutable`
#### Impact
Avoids a Gusset (20000 gas)
#### Findings:
```
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::33 => address public collateralConfigAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::34 => address pu... | 2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::33 => address public collateralConfigAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::34 => address public borrowerOperationsAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::35 => address public troveManagerAddress;
2023-02-ethos-ma... | 2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::33 => address public collateralConfigAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::34 => address public borrowerOperationsAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::35 => address public troveManagerAddress;
2023-02-ethos-ma... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Bnke0x0-G.md | 2026-01-02T18:15:59.477629+00:00 | 930b590cdde03fcd96dd6b69201007c585de76fddf4da4e7400c0e85f0824024 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | 2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::33 => address public collateralConfigAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::34 => address public borrowerOperationsAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::35 => address public troveManagerAddress;
2023-02-ethos-ma... | true | 2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::33 => address public collateralConfigAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::34 => address public borrowerOperationsAddress;
2023-02-ethos-main/Ethos-Core/contracts/ActivePool.sol::35 => address public troveManagerAddress;
2023-02-ethos-ma... | true | true | 5 | ||||||||
c4 | 04-caviar | bshramin Q | Low | low | # L1 - The pool takes more royalty fee than it spends
In sending the royalty fees the pool checks if the recipient address is zero and won't send it any tokens.
```solidity
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice);
if (royaltyFee > 0 && recipient != address(0)) {
```
https://github.... | (uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice);
if (royaltyFee > 0 && recipient != address(0)) { | (uint256 royaltyFee,) = _getRoyalty(tokenIds[i], salePrice);
royaltyFeeAmount += royaltyFee; | flash-loan | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/bshramin-Q.md | 2026-01-02T18:20:19.186218+00:00 | 932073f4139fe62194ac9f387c130927e82a34cb8321b8436a171eea793a7153 | 3 | 3 | 307 | 3 | false | false | true | false | high | (uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice);
if (royaltyFee > 0 && recipient != address(0)) { | solidity | 127 | // Code block 1 (solidity):
(uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice);
if (royaltyFee > 0 && recipient != address(0)) {
// Code block 2 (solidity):
(uint256 royaltyFee,) = _getRoyalty(tokenIds[i], salePrice);
royaltyFeeAmount += royaltyFee;
// Code block 3 (solidity):
uint256 saleP... | 3 | false | (uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice);
if (royaltyFee > 0 && recipient != address(0)) {
(uint256 royaltyFee,) = _getRoyalty(tokenIds[i], salePrice);
royaltyFeeAmount += royaltyFee;
uint256 salePrice = (netOutputAmount + feeAmount + protocolFeeAmount) / tokenIds.length; | PrivatePool.sol#L274, PrivatePool.sol#L244, PrivatePool.sol#L335 | PrivatePool.sol | 3 | (uint256 royaltyFee, address recipient) = _getRoyalty(tokenIds[i], salePrice);
if (royaltyFee > 0 && recipient != address(0)) { | true | (uint256 royaltyFee,) = _getRoyalty(tokenIds[i], salePrice);
royaltyFeeAmount += royaltyFee; | true | true | 9 | ||
c4 | 05-ajna | BGSecurity Q | Critical | critical | ## Introduction
Ajna QA report was done by martin and anonresercher, with a main focus on the low severity and non-critical security aspects of the implementaion and logic of the project.
## Findings Summary
The following issues were found, categorized by their severity:
## Findings Summary
| ID | Title ... | 21: address public immutable ajnaTokenAddress = 0x9a96ec9B57Fb64FbC60B423d1f4da7691Bd35079; | 458: * @dev Only iterates through a maximum of 10 proposals that made it through the screening round. | other | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/BGSecurity-Q.md | 2026-01-02T18:20:55.116264+00:00 | 93247be7a1e3d662aaa58aa4e75db2f228f4027099f30a7a646aaa9e7175901e | 2 | 2 | 195 | 1 | false | false | true | false | high | 21: address public immutable ajnaTokenAddress = 0x9a96ec9B57Fb64FbC60B423d1f4da7691Bd35079; | solidity | 91 | // Code block 1 (solidity):
21: address public immutable ajnaTokenAddress = 0x9a96ec9B57Fb64FbC60B423d1f4da7691Bd35079;
// Code block 2 (solidity):
458: * @dev Only iterates through a maximum of 10 proposals that made it through the screening round. | 2 | false | 21: address public immutable ajnaTokenAddress = 0x9a96ec9B57Fb64FbC60B423d1f4da7691Bd35079;
458: * @dev Only iterates through a maximum of 10 proposals that made it through the screening round. | Funding.sol | Funding.sol | 1 | 21: address public immutable ajnaTokenAddress = 0x9a96ec9B57Fb64FbC60B423d1f4da7691Bd35079; | true | 458: * @dev Only iterates through a maximum of 10 proposals that made it through the screening round. | true | true | 8 | ||
c4 | 03-asymmetry | HHK G | Low | low | ### Custom errors instead of requires
```require(pauseStaking == false, "staking is paused");```
```if(pauseStaking == false) revert StakingPaused();```
### In SafETH Stake() can have everything in the same loop.
### Line 88 of SafEth.sol, ```if (weight == 0) continue``` should be one line above
This would save a s... | other | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/HHK-G.md | 2026-01-02T18:18:06.089503+00:00 | 932fb6724dede45b036d2c7efc54f83f389cd8d762f74444fbaad3d60fb772f5 | 1 | 0 | 87 | 2 | true | true | true | false | medium | ### In SafETH Stake() can have everything in the same loop.
### Line 88 of SafEth.sol, | unknown | 87 | // Code block 1 (unknown):
### In SafETH Stake() can have everything in the same loop.
### Line 88 of SafEth.sol, | 1 | false | SafEth.sol#L84, Reth.sol#L215 | Reth.sol, SafEth.sol | 2 | false | false | false | 5 | |||||||
c4 | 01-ondo | fs0c Q | Medium | medium | ## [QA-01] lack of storage `_gap` in upgradable contracts.
For upgradeable contracts, there must be storage gap to “allow developers to freely add new state variables in the future without compromising the storage compatibility with existing deployments”. Otherwise it may be very difficult to write new implementation ... | uint256[50] private __gap; | function pause() external onlyRole(PAUSER_ADMIN) {
_pause();
}
/**
* @notice Will unpause minting functionality of this contract
*/
function unpause() external onlyRole(MANAGER_ADMIN) {
_unpause();
} | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/fs0c-Q.md | 2026-01-02T18:15:10.191784+00:00 | 9334b643b699d706482412d08053d3a28ceda2d15863538764868750bfbc2696 | 1 | 1 | 26 | 3 | false | false | true | false | high | uint256[50] private __gap; | solidity | 26 | // Code block 1 (solidity):
uint256[50] private __gap; | 1 | false | uint256[50] private __gap; | Cash.sol, CashKYCSender.sol, CashKYCSenderReceiver.sol | CashKYCSender.sol, Cash.sol, CashKYCSenderReceiver.sol | 3 | uint256[50] private __gap; | true | function pause() external onlyRole(PAUSER_ADMIN) {
_pause();
}
/**
* @notice Will unpause minting functionality of this contract
*/
function unpause() external onlyRole(MANAGER_ADMIN) {
_unpause();
} | true | true | 7 | ||
c4 | 11-kelp | ABAIKUNANBAEV G | Gas | gas | ### Gas Optimizations List
| Number | Optimization Details | Instances |
| :----: | :----------------------------------------------------------------------------------------------------------------------- | :-------: |
... | function depositAsset(
address asset,
uint256 depositAmount
)
external
whenNotPaused
nonReentrant
onlySupportedAsset(asset)
} | assetLyingInDepositPool = IERC20(asset).balanceOf(address(this)); | reentrancy | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/ABAIKUNANBAEV-G.md | 2026-01-02T18:27:18.251849+00:00 | 944635ab86ef34318bbb37aecc65d414c22ec76c4ff4d37445fb47973c8055f6 | 2 | 0 | 246 | 1 | false | false | true | false | high | function depositAsset(
address asset,
uint256 depositAmount
)
external
whenNotPaused
nonReentrant
onlySupportedAsset(asset)
} | unknown | 181 | // Code block 1 (unknown):
function depositAsset(
address asset,
uint256 depositAmount
)
external
whenNotPaused
nonReentrant
onlySupportedAsset(asset)
}
// Code block 2 (unknown):
assetLyingInDepositPool = IERC20(asset).balanceOf(address(this)); | 2 | false | LRTDepositPool.sol#L125 | LRTDepositPool.sol | 1 | function depositAsset(
address asset,
uint256 depositAmount
)
external
whenNotPaused
nonReentrant
onlySupportedAsset(asset)
} | true | assetLyingInDepositPool = IERC20(asset).balanceOf(address(this)); | true | true | 8 | |||
c4 | 04-caviar | Madalad G | High | high | # Gas Optimizations Summary
| |Issue|Instances|
|:-:|:-|:-:|
|[G-01]|`abi.encodePacked` is more gas efficient than `abi.encode`|2|
|[G-02]|Functions guaranteed to revert when called by normal users can be marked `payable`|10|
|[G-03]|Use assembly to calculate hashes|2|
|[G-04]|Use `indexed` to save gas|11|
|[G-05]|Refa... | File: src/EthRouter.sol
177: abi.decode(abi.encode(sells[i].stolenNftProofs), (ReservoirOracle.Message[]))
| File: src/PrivatePool.sol
675: leafs[i] = keccak256(bytes.concat(keccak256(abi.encode(tokenIds[i], tokenWeights[i]))));
| access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/Madalad-G.md | 2026-01-02T18:19:50.012477+00:00 | 94c545761a6727c04ce451d9ab197dd6b055e43581fe36e579f61ed086d2d74f | 2 | 2 | 259 | 2 | false | false | true | false | high | File: src/EthRouter.sol
177: abi.decode(abi.encode(sells[i].stolenNftProofs), (ReservoirOracle.Message[])) | solidity | 127 | // Code block 1 (solidity):
File: src/EthRouter.sol
177: abi.decode(abi.encode(sells[i].stolenNftProofs), (ReservoirOracle.Message[]))
// Code block 2 (solidity):
File: src/PrivatePool.sol
675: leafs[i] = keccak256(bytes.concat(keccak256(abi.encode(tokenIds[i], tokenWeights[i])))); | 2 | false | File: src/EthRouter.sol
177: abi.decode(abi.encode(sells[i].stolenNftProofs), (ReservoirOracle.Message[]))
File: src/PrivatePool.sol
675: leafs[i] = keccak256(bytes.concat(keccak256(abi.encode(tokenIds[i], tokenWeights[i])))); | EthRouter.sol#L177, PrivatePool.sol#L675 | EthRouter.sol, PrivatePool.sol | 2 | File: src/EthRouter.sol
177: abi.decode(abi.encode(sells[i].stolenNftProofs), (ReservoirOracle.Message[]))
| true | File: src/PrivatePool.sol
675: leafs[i] = keccak256(bytes.concat(keccak256(abi.encode(tokenIds[i], tokenWeights[i]))));
| true | true | 8 | ||
c4 | 10-badger | hihen Q | Critical | critical | # QA Report
## Summary
### Low Issues
Total **176 instances** over **24 issues**:
|ID|Issue|Instances|
|:--:|:---|:--:|
| [[L‑01]](#l01-variables-shadowing-other-definitions) | Variables shadowing other definitions | 3 |
| [[L‑02]](#l02-missing-zero-address-check-in-constructor) | Missing zero address... | /// @audit Shadows `function version()`
680: bytes32 version | /// @audit Shadows `function name()`
237: bytes32 name,
/// @audit Shadows `function version()`
238: bytes32 version | reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/hihen-Q.md | 2026-01-02T18:26:50.192353+00:00 | 94c86448354f61d5a142649802bd845dce0d04022149c0edd413b35f9e51b206 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | /// @audit Shadows `function version()`
680: bytes32 version | true | /// @audit Shadows `function name()`
237: bytes32 name,
/// @audit Shadows `function version()`
238: bytes32 version | true | true | 5 | ||||||||
c4 | 11-kelp | SandNallani Q | Low | low | ### [QA-1] Inconsistent use of the `whenNotPaused` modifier in the Oracle and Deposit pool contracts
The Oracle contract inherits and implements functions to pause and unpause. However, the `whenNotPaused` modifier is not applied to any of the functions in this contract.
In the node delegator contract, when paused, ... | NodeDelegator::depositAssetIntoStrategy()
//NodeDelegator.sol
function depositAssetIntoStrategy(address asset){
...
emit AssetDepositIntoStrategy(asset, strategy, balance);
IEigenStrategyManager(eigenlayerStrategyManagerAddress).depositIntoStrategy(IStrategy(strategy), token, balance);
...
} | function getRsETHAmountToMint(
address asset,
uint256 amount
)
public
view
override
returns (uint256 rsethAmountToMint) {
...
rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice();
} | oracle | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/SandNallani-Q.md | 2026-01-02T18:27:38.972409+00:00 | 94eebd5e8e262617d8ac221f306ffac2db22e282a97332e7a04ae8364534412b | 1 | 0 | 298 | 0 | false | false | true | false | high | NodeDelegator::depositAssetIntoStrategy()
//NodeDelegator.sol
function depositAssetIntoStrategy(address asset){
...
emit AssetDepositIntoStrategy(asset, strategy, balance);
IEigenStrategyManager(eigenlayerStrategyManagerAddress).depositIntoStrategy(IStrategy(strategy), token, balance);
...
} | unknown | 298 | // Code block 1 (unknown):
NodeDelegator::depositAssetIntoStrategy()
//NodeDelegator.sol
function depositAssetIntoStrategy(address asset){
...
emit AssetDepositIntoStrategy(asset, strategy, balance);
IEigenStrategyManager(eigenlayerStrategyManagerAddress).depositIntoStrategy(IStrategy(strategy), token, balance);
... ... | 1 | false | 0 | NodeDelegator::depositAssetIntoStrategy()
//NodeDelegator.sol
function depositAssetIntoStrategy(address asset){
...
emit AssetDepositIntoStrategy(asset, strategy, balance);
IEigenStrategyManager(eigenlayerStrategyManagerAddress).depositIntoStrategy(IStrategy(strategy), token, balance);
...
} | true | function getRsETHAmountToMint(
address asset,
uint256 amount
)
public
view
override
returns (uint256 rsethAmountToMint) {
...
rsethAmountToMint = (amount * lrtOracle.getAssetPrice(asset)) / lrtOracle.getRSETHPrice();
} | true | true | 6 | |||||
c4 | 03-asymmetry | CodeFoxInc Q | Critical | critical | # Low-risk and Non-critical issues
## ****Codebase Impressions & Summary****
The protocol is built on several other projects and the the enhanced way created by the team to stake Ether is quite interesting.
The protocol’s contracts are well structured and quite simplified and the Natspec documentation is quite well... | ## L-02 The `addDerivative()`, `adjustWeight()` and `rebalanceToWeights()` functions can be used to steal funds
### **Vulnerability details**
There are quite a lot of `onlyOwner` functions and specifically speaking, the `adjustWeight`, `addDerivative` and `rebalanceToWeights` function can be used to drain funds. So t... | and put them into an array:
| reentrancy | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/CodeFoxInc-Q.md | 2026-01-02T18:17:57.964716+00:00 | 94f28579642a30f19ac8679cca8a82be6a9b20dbc3ce7a6cd839f49f89ba9d66 | 0 | 0 | 0 | 6 | false | false | false | false | medium | 0 | 0 | false | SafEth.sol#L108-L129, ReentrancyGuardUpgradeable.sol, SafEth.sol#L165-L175, SafEth.sol#L182-L195, SafEth.sol#L138-L155, SafEthStorage.sol#L18 | SafEthStorage.sol, SafEth.sol, ReentrancyGuardUpgradeable.sol | 6 | ## L-02 The `addDerivative()`, `adjustWeight()` and `rebalanceToWeights()` functions can be used to steal funds
### **Vulnerability details**
There are quite a lot of `onlyOwner` functions and specifically speaking, the `adjustWeight`, `addDerivative` and `rebalanceToWeights` function can be used to drain funds. So t... | true | and put them into an array:
| true | true | 6 | ||||||
c4 | 05-ajna | Polaris_tow G | Gas | gas | ## USING FIXED BYTES IS CHEAPER THAN USING STRING
As a rule of thumb, use bytes for arbitrary-length raw byte data and string for arbitrary-length string (UTF-8) data. If you can limit the length to a certain number of bytes, always use one of bytes1 to bytes32 because they are much cheaper.
https://github.com/code-42... | for (uint256 i = 0; i < targets_.length;) {
// check targets and values params are valid
if (targets_[i] != ajnaTokenAddress || values_[i] != 0) revert InvalidProposal();
// check calldata function selector is transfer()
bytes memory selDataWithSig = calldatas_[... | other | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/Polaris_tow-G.md | 2026-01-02T18:21:07.029094+00:00 | 951a697e1acbfe76294e8609a67491c9c4da3416185d5f1f3d4ea5ebb83716ad | 0 | 0 | 0 | 3 | false | true | false | false | medium | 0 | 0 | false | Funding.sol#L61, Funding.sol#L112-L141, StandardFunding.sol#L582-L596 | Funding.sol, StandardFunding.sol | 3 | for (uint256 i = 0; i < targets_.length;) {
// check targets and values params are valid
if (targets_[i] != ajnaTokenAddress || values_[i] != 0) revert InvalidProposal();
// check calldata function selector is transfer()
bytes memory selDataWithSig = calldatas_[... | true | false | false | 5 | ||||||||
c4 | 02-ethos | Buck Q | Low | low | Ethos-Core
------------
In the AccessControl, there are cases where the comments do not reflect exactly what the code is doing. Not major issues, but not totally accurate.
-------------
https://github.com/code-423n4/2023-02-ethos/blob/main/Ethos-Core/contracts/TroveManager.sol
contracts/TroveManager.sol
line 1077 - in ... | _requireCallerIsBorrowerOperationsOrRedemptionHelper();
// _updateTroveRewardSnapshots calls _requireCallerIsBorrowerOperations() internally, so allowing RedemptionHelper is useless
// _updateTroveRewardSnapshots is called by _applyPendingRewards(...) | _requireCallerIsBorrowerOperations(); | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Buck-Q.md | 2026-01-02T18:16:02.650299+00:00 | 9521fd28bca140e863d8cd6c47802c6870c6c646dc8bb7f0e069bf4812e6e979 | 7 | 0 | 904 | 2 | false | false | true | false | high | _requireCallerIsBorrowerOperationsOrRedemptionHelper();
// _updateTroveRewardSnapshots calls _requireCallerIsBorrowerOperations() internally, so allowing RedemptionHelper is useless
// _updateTroveRewardSnapshots is called by _applyPendingRewards(...) | unknown | 267 | // Code block 1 (unknown):
_requireCallerIsBorrowerOperationsOrRedemptionHelper();
// _updateTroveRewardSnapshots calls _requireCallerIsBorrowerOperations() internally, so allowing RedemptionHelper is useless
// _updateTroveRewardSnapshots is called by _applyPendingRewards(...)
// Code block 2 (unknown... | 7 | false | TroveManager.sol, ActivePool.sol | TroveManager.sol, ActivePool.sol | 2 | _requireCallerIsBorrowerOperationsOrRedemptionHelper();
// _updateTroveRewardSnapshots calls _requireCallerIsBorrowerOperations() internally, so allowing RedemptionHelper is useless
// _updateTroveRewardSnapshots is called by _applyPendingRewards(...) | true | _requireCallerIsBorrowerOperations(); | true | true | 13 | |||
c4 | 06-lybra | koxuan G | Medium | medium | # Report
## Gas Optimizations
| |Issue|Instances|
|-|:-|:-:|
| [GAS-1](#GAS-1) | Using bools for storage incurs overhead | 10 |
| [GAS-2](#GAS-2) | Cache array length outside of loop | 4 |
| [GAS-3](#GAS-3) | State variables should be cached in stack variables rather than re-reading them from storage | 6 |
| [GAS-4... | File: OFT/OFTCoreV2.sol
22: bool public useCustomAdapterParams;
23: mapping(uint16 => mapping(bytes => mapping(uint64 => bool))) public creditedPackets;
| File: lybra/configuration/LybraConfigurator.sol
38: mapping(address => bool) public mintVault;
40: mapping(address => bool) public vaultMintPaused;
41: mapping(address => bool) public vaultBurnPaused;
46: mapping(address => bool) redemptionProvider;
47: mapping(address => bool) public tokenMine... | reentrancy | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/koxuan-G.md | 2026-01-02T18:23:04.666513+00:00 | 952f2184c6eefd9070e586613de102fcc21d825260df7790afdd8b30fc3fc47d | 1 | 1 | 162 | 1 | false | false | true | false | high | File: OFT/OFTCoreV2.sol
22: bool public useCustomAdapterParams;
23: mapping(uint16 => mapping(bytes => mapping(uint64 => bool))) public creditedPackets; | solidity | 162 | // Code block 1 (solidity):
File: OFT/OFTCoreV2.sol
22: bool public useCustomAdapterParams;
23: mapping(uint16 => mapping(bytes => mapping(uint64 => bool))) public creditedPackets; | 1 | false | File: OFT/OFTCoreV2.sol
22: bool public useCustomAdapterParams;
23: mapping(uint16 => mapping(bytes => mapping(uint64 => bool))) public creditedPackets; | ReentrancyGuard.sol#L23-L27 | ReentrancyGuard.sol | 1 | File: OFT/OFTCoreV2.sol
22: bool public useCustomAdapterParams;
23: mapping(uint16 => mapping(bytes => mapping(uint64 => bool))) public creditedPackets;
| true | File: lybra/configuration/LybraConfigurator.sol
38: mapping(address => bool) public mintVault;
40: mapping(address => bool) public vaultMintPaused;
41: mapping(address => bool) public vaultBurnPaused;
46: mapping(address => bool) redemptionProvider;
47: mapping(address => bool) public tokenMine... | true | true | 7 | ||
c4 | 02-ethos | dontonka G | Low | low | Some reported issues here are just added as a comment, but most have been applied the suggested corrections already, you can see all the final diffs. Take note that the code compile and all test pass with those too.
```diff
diff --git a/Ethos-Core/contracts/ActivePool.sol b/Ethos-Core/contracts/ActivePool.sol
index 75... | ```diff
diff --git a/Ethos-Vault/contracts/ReaperVaultV2.sol b/Ethos-Vault/contracts/ReaperVaultV2.sol
index 2be0b81..a60c162 100644
--- a/Ethos-Vault/contracts/ReaperVaultV2.sol
+++ b/Ethos-Vault/contracts/ReaperVaultV2.sol
@@ -266,7 +266,7 @@ contract ReaperVaultV2 is ReaperAccessControl, ERC20, IERC4626Events, Acces... | ```diff
diff --git a/Ethos-Core/contracts/StabilityPool.sol b/Ethos-Core/contracts/StabilityPool.sol
index a33d8c3..5f8fac6 100644
--- a/Ethos-Core/contracts/StabilityPool.sol
+++ b/Ethos-Core/contracts/StabilityPool.sol
@@ -807,13 +807,14 @@ contract StabilityPool is LiquityBase, Ownable, CheckContract, IStabilityPool... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/dontonka-G.md | 2026-01-02T18:17:06.491421+00:00 | 954422e9a7eb6e1032b748ed2b34c5835418e3dcbeb4f83ccebd33d39ab50594 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | ```diff
diff --git a/Ethos-Vault/contracts/ReaperVaultV2.sol b/Ethos-Vault/contracts/ReaperVaultV2.sol
index 2be0b81..a60c162 100644
--- a/Ethos-Vault/contracts/ReaperVaultV2.sol
+++ b/Ethos-Vault/contracts/ReaperVaultV2.sol
@@ -266,7 +266,7 @@ contract ReaperVaultV2 is ReaperAccessControl, ERC20, IERC4626Events, Acces... | true | ```diff
diff --git a/Ethos-Core/contracts/StabilityPool.sol b/Ethos-Core/contracts/StabilityPool.sol
index a33d8c3..5f8fac6 100644
--- a/Ethos-Core/contracts/StabilityPool.sol
+++ b/Ethos-Core/contracts/StabilityPool.sol
@@ -807,13 +807,14 @@ contract StabilityPool is LiquityBase, Ownable, CheckContract, IStabilityPool... | true | true | 5 | ||||||||
c4 | 01-ondo | tsvetanovv G | Medium | medium | ## [GAS-01] STATE VARIABLES ONLY SET IN THE CONSTRUCTOR SHOULD BE DECLARED IMMUTABLE.
It allows setting contract-level variables at construction time which gets stored in code rather than storage.
```
JumpRateModelV2.sol
24: address public owner;
cErc20ModifiedDelegator.sol
218: ddress payable public admin;
```
***
... | JumpRateModelV2.sol
24: address public owner;
cErc20ModifiedDelegator.sol
218: ddress payable public admin; | KYCRegistry.sol:
93: bytes32 structHash = keccak256(
abi.encode(_APPROVAL_TYPEHASH, kycRequirementGroup, user, deadline) | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/tsvetanovv-G.md | 2026-01-02T18:15:37.179705+00:00 | 95544284380cf10de85473df2b46a01018b6ba3d8a93cd05427012845897c4f0 | 4 | 0 | 820 | 0 | false | false | true | false | high | JumpRateModelV2.sol
24: address public owner;
cErc20ModifiedDelegator.sol
218: ddress payable public admin; | unknown | 108 | // Code block 1 (unknown):
JumpRateModelV2.sol
24: address public owner;
cErc20ModifiedDelegator.sol
218: ddress payable public admin;
// Code block 2 (unknown):
KYCRegistry.sol:
93: bytes32 structHash = keccak256(
abi.encode(_APPROVAL_TYPEHASH, kycRequirementGroup, user, deadline)
// Code block 3 (unknown):
C... | 4 | false | 0 | JumpRateModelV2.sol
24: address public owner;
cErc20ModifiedDelegator.sol
218: ddress payable public admin; | true | KYCRegistry.sol:
93: bytes32 structHash = keccak256(
abi.encode(_APPROVAL_TYPEHASH, kycRequirementGroup, user, deadline) | true | true | 9 | |||||
c4 | 08-dopex | Jorgect Q | Low | low | # LOW REPORT
## [L-01] The slippageTolerance is no used in UniV2LiquidityAmo.sol contract
The slippageTolerance variable is declared in the contract, even have a function to modify it but is never used in the uniswap releted function, the related uniswap functions has his own input value where the admin set the slip... | uint256 public slippageTolerance = 5e5; // 0.5%
...
file: contracts/amo/UniV2LiquidityAmo.sol
function setSlippageTolerance(
uint256 _slippageTolerance
) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(
_slippageTolerance > 0,
"reLPContract: slippage tolerance must be greater than 0"
);
... | function addLiquidity(
AddLiquidityParams memory params
) public onlyRole(DEFAULT_ADMIN_ROLE) {
...
INonfungiblePositionManager.MintParams
memory mintParams = INonfungiblePositionManager.MintParams(
params._tokenA,
params._tokenB,
params._fee,
params._tickLower,
... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/Jorgect-Q.md | 2026-01-02T18:24:44.806294+00:00 | 95dc326c4c0b36d0b65e5740eb8a285fa3c52db2a5506a55cfe0117d08fb22fa | 2 | 0 | 892 | 2 | false | false | true | false | high | uint256 public slippageTolerance = 5e5; // 0.5%
...
file: contracts/amo/UniV2LiquidityAmo.sol
function setSlippageTolerance(
uint256 _slippageTolerance
) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(
_slippageTolerance > 0,
"reLPContract: slippage tolerance must be greater than 0"
);
... | unknown | 363 | // Code block 1 (unknown):
uint256 public slippageTolerance = 5e5; // 0.5%
...
file: contracts/amo/UniV2LiquidityAmo.sol
function setSlippageTolerance(
uint256 _slippageTolerance
) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(
_slippageTolerance > 0,
"reLPContract: slippage tolerance must be ... | 2 | false | UniV2LiquidityAmo.sol#L109-L3, UniV3LiquidityAmo.sol#L155-L1 | UniV2LiquidityAmo.sol, UniV3LiquidityAmo.sol | 2 | uint256 public slippageTolerance = 5e5; // 0.5%
...
file: contracts/amo/UniV2LiquidityAmo.sol
function setSlippageTolerance(
uint256 _slippageTolerance
) external onlyRole(DEFAULT_ADMIN_ROLE) {
require(
_slippageTolerance > 0,
"reLPContract: slippage tolerance must be greater than 0"
);
... | true | function addLiquidity(
AddLiquidityParams memory params
) public onlyRole(DEFAULT_ADMIN_ROLE) {
...
INonfungiblePositionManager.MintParams
memory mintParams = INonfungiblePositionManager.MintParams(
params._tokenA,
params._tokenB,
params._fee,
params._tickLower,
... | true | true | 8 | |||
c4 | 10-badger | codeslide Q | Critical | critical | ## <a id="summary"></a> Summary
### <a id="summary-low-risk-issues"></a> Low Risk Issues
There are 80 instances over 14 issues.
| ID | Description | Count |
| :-----------: | :--------------------------------------------------------... | File: packages/contracts/contracts/EBTCToken.sol
95: function burn(address _account, uint256 _amount) external override {
104: function burn(uint256 _amount) external { | File: packages/contracts/contracts/CdpManagerStorage.sol
53: lastGracePeriodStartTimestamp = uint128(block.timestamp); | reentrancy | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/codeslide-Q.md | 2026-01-02T18:26:45.622074+00:00 | 95f687526c6580314e364f138edf678bd528e1723d95d74f3da4b2723157747f | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: packages/contracts/contracts/EBTCToken.sol
95: function burn(address _account, uint256 _amount) external override {
104: function burn(uint256 _amount) external { | true | File: packages/contracts/contracts/CdpManagerStorage.sol
53: lastGracePeriodStartTimestamp = uint128(block.timestamp); | true | true | 5 | ||||||||
c4 | 04-caviar | 0xbepresent Q | Medium | medium | 1 - There is a discrepancy between the documentation and the code in the ```PrivatePool.change()``` function
==
The documentaion about the [change()](https://docs.caviar.sh/technical-reference/custom-pools/smart-contract-api/privatepool#change) function says: *The sum of the caller's NFT weights must be less than or e... | if (inputWeightSum < outputWeightSum) revert InsufficientInputWeight(); | if (baseToken != address(0)) ERC20(baseToken).transferFrom(msg.sender, address(this), fee); | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/0xbepresent-Q.md | 2026-01-02T18:19:21.675892+00:00 | 95fefdfd08da2ba0d261274db496b720cd06e41ce5d9fdafce39eb82ba03292c | 3 | 2 | 404 | 5 | false | false | true | false | high | if (inputWeightSum < outputWeightSum) revert InsufficientInputWeight(); | solidity | 71 | // Code block 1 (solidity):
if (inputWeightSum < outputWeightSum) revert InsufficientInputWeight();
// Code block 2 (solidity):
if (baseToken != address(0)) ERC20(baseToken).transferFrom(msg.sender, address(this), fee);
// Code block 3 (unknown):
==
The [changeFee](https://github.com/code-423n4/2023-04-caviar/blob/c... | 3 | false | if (inputWeightSum < outputWeightSum) revert InsufficientInputWeight();
if (baseToken != address(0)) ERC20(baseToken).transferFrom(msg.sender, address(this), fee); | PrivatePool.sol#L376, PrivatePool.sol#L413, PrivatePool.sol#L651, PrivatePool.sol#L755, PrivatePool.sol#L179 | PrivatePool.sol | 5 | if (inputWeightSum < outputWeightSum) revert InsufficientInputWeight(); | true | if (baseToken != address(0)) ERC20(baseToken).transferFrom(msg.sender, address(this), fee); | true | true | 9 | ||
c4 | 01-ondo | Awesome Q | Low | low | # 1. Improve the Readability by following modularity principles
To make your Solidity code more modern and readable, it is recommended to update your import statements to only include the specific contracts or objects that you need.
This practice, known as modular programming, helps to keep the code cleaner and more ... | import {contract1, contract2} from "filename.sol"; | Line 181: delete kycState[kycRequirementGroup][addresses[i]]; | upgrade | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/Awesome-Q.md | 2026-01-02T18:14:27.486249+00:00 | 961dd5fbf2b68418ee17f904d1120de84210d47581761fbdf9e1dc682c79e973 | 1 | 1 | 50 | 5 | false | false | true | false | high | import {contract1, contract2} from "filename.sol"; | solidity | 50 | // Code block 1 (solidity):
import {contract1, contract2} from "filename.sol"; | 1 | false | import {contract1, contract2} from "filename.sol"; | CashKYCSender.sol#L18-L19, Proxy.sol, Cash.sol, CashKYCSender.sol, CashKYCSenderReceiver.sol | CashKYCSender.sol, Cash.sol, Proxy.sol, CashKYCSenderReceiver.sol | 5 | import {contract1, contract2} from "filename.sol"; | true | Line 181: delete kycState[kycRequirementGroup][addresses[i]]; | true | true | 7 | ||
c4 | 11-kelp | kinggvd Q | Unknown | unknown | ```
function maxApproveToEigenStrategyManager(address asset)
function depositAssetIntoStrategy(address asset)
function transferBackToLRTDepositPool(
address asset,
uint256 amount
)
```
Alle the functions above rely on lrtConfig.getContract(CONSTANT) which may return a 0 address if it has not yet been set. ... | function maxApproveToEigenStrategyManager(address asset)
function depositAssetIntoStrategy(address asset)
function transferBackToLRTDepositPool(
address asset,
uint256 amount
) | IERC20(asset).approve(eigenlayerStrategyManagerAddress, type(uint256).max);
IEigenStrategyManager(eigenlayerStrategyManagerAddress).depositIntoStrategy(IStrategy(strategy), token, balance);
if (!IERC20(asset).transfer(lrtDepositPool, amount)) {
revert TokenTransferFailed();
} | other | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/kinggvd-Q.md | 2026-01-02T18:28:12.251057+00:00 | 961f1e3ce3daaf62f0c982485001ddd646b89f3d93cd777d6849b354b6cd6a83 | 2 | 0 | 471 | 0 | false | false | true | false | medium | function maxApproveToEigenStrategyManager(address asset)
function depositAssetIntoStrategy(address asset)
function transferBackToLRTDepositPool(
address asset,
uint256 amount
) | unknown | 188 | // Code block 1 (unknown):
function maxApproveToEigenStrategyManager(address asset)
function depositAssetIntoStrategy(address asset)
function transferBackToLRTDepositPool(
address asset,
uint256 amount
)
// Code block 2 (unknown):
IERC20(asset).approve(eigenlayerStrategyManagerAddress, type(uint256).max);
... | 2 | false | 0 | function maxApproveToEigenStrategyManager(address asset)
function depositAssetIntoStrategy(address asset)
function transferBackToLRTDepositPool(
address asset,
uint256 amount
) | true | IERC20(asset).approve(eigenlayerStrategyManagerAddress, type(uint256).max);
IEigenStrategyManager(eigenlayerStrategyManagerAddress).depositIntoStrategy(IStrategy(strategy), token, balance);
if (!IERC20(asset).transfer(lrtDepositPool, amount)) {
revert TokenTransferFailed();
} | true | true | 5.58 | |||||
c4 | 01-biconomy | shark Q | Low | low | ## 1. `Math.sol` function not being used
In `Math.sol`, the function [`max()`](https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/libs/Math.sol#L19-L21) is found to be re-implemented in a contract.
The following contract is re-implementing `max()` from `Math.sol` ra... | delete info.staked; | 449: function transfer(address payable dest, uint amount) external nonReentrant onlyOwner {
450: require(dest != address(0), "this action will burn your funds");
451: (bool success,) = dest.call{value:amount}("");
452: require(success,"transfer failed");
453: } | reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/shark-Q.md | 2026-01-02T18:14:10.078816+00:00 | 9620835b9c674918c0ce2da6572137abb4753e7a76bc9b94d94d953f951034cb | 1 | 1 | 19 | 6 | false | false | true | false | high | delete info.staked; | solidity | 19 | // Code block 1 (solidity):
delete info.staked; | 1 | false | delete info.staked; | Math.sol#L19-L21, SmartAccount.sol#L181-L183, SmartAccount.sol#L449, SmartAccount.sol#L468, SmartAccountFactory.sol#L72, StakeManager.sol#L86 | Math.sol, SmartAccount.sol, StakeManager.sol, SmartAccountFactory.sol | 6 | delete info.staked; | true | 449: function transfer(address payable dest, uint amount) external nonReentrant onlyOwner {
450: require(dest != address(0), "this action will burn your funds");
451: (bool success,) = dest.call{value:amount}("");
452: require(success,"transfer failed");
453: } | true | true | 7 | ||
c4 | 01-salty | LinKenji Q | Gas | gas | GAS 01 Use caching to avoid repetitive storage reads
## Impact
Several contracts like [Pools.sol](https://github.com/code-423n4/2024-01-salty/blob/main/src/pools/Pools.sol) and [Proposals.sol](https://github.com/code-423n4/2024-01-salty/blob/main/src/dao/Proposals.sol) could cache frequently used parameters and address... | function addLiquidity( IERC20 tokenA, IERC20 tokenB, uint256 maxAmountA, uint256 maxAmountB, uint256 minLiquidityReceived, uint256 totalLiquidity ) external nonReentrant returns (uint256 addedAmountA, uint256 addedAmountB, uint256 addedLiquidity)
{
require( msg.sender == address(collateralAndLiquidity), "Pools.addLiqui... | 10 function calls * 200 gas per read = 2,000 gas spent | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/LinKenji-Q.md | 2026-01-02T19:01:25.082564+00:00 | 966119c0a2226b2f7b4fe3e2aa9303f9406fb7cb3add898fd7aaf876437fef3c | 0 | 0 | 0 | 3 | false | false | false | false | medium | 0 | 0 | false | Pools.sol, Proposals.sol, Pools.sol#L140-L165 | Proposals.sol, Pools.sol | 3 | function addLiquidity( IERC20 tokenA, IERC20 tokenB, uint256 maxAmountA, uint256 maxAmountB, uint256 minLiquidityReceived, uint256 totalLiquidity ) external nonReentrant returns (uint256 addedAmountA, uint256 addedAmountB, uint256 addedLiquidity)
{
require( msg.sender == address(collateralAndLiquidity), "Pools.addLiqui... | true | 10 function calls * 200 gas per read = 2,000 gas spent | true | true | 6 | ||||||
c4 | 01-biconomy | Awesome G | Low | low |
# 1. Save gas with `payable` functions
Marking functions as `payable` will be cheaper (by ~20 gas) than using non-`payable` functions because the Solidity compiler inserts a check into non-`payable` functions that requires `msg.value` to be zero.
For instance, the code at [SmartAccount.sol#L449](https://github.com/c... | Line 449: function transfer(address payable dest, uint amount) external payable nonReentrant onlyOwner { | contracts/smart-contract-wallet/SmartAccount.sol
Line 461: _requireFromEntryPointOrOwner();
Line 466: _requireFromEntryPointOrOwner();
Line 494: function _requireFromEntryPointOrOwner() internal view {
Line 495: require(msg.sender == address(entryPoint()) || msg.sender == owner, "account: not Owner or ... | reentrancy | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/Awesome-G.md | 2026-01-02T18:12:54.002995+00:00 | 967d219825820d43fe02551993ce1caf820c9ebc6d29b88e494d619b997073b1 | 1 | 1 | 107 | 4 | false | false | true | false | high | Line 449: function transfer(address payable dest, uint amount) external payable nonReentrant onlyOwner { | solidity | 107 | // Code block 1 (solidity):
Line 449: function transfer(address payable dest, uint amount) external payable nonReentrant onlyOwner { | 1 | false | Line 449: function transfer(address payable dest, uint amount) external payable nonReentrant onlyOwner { | SmartAccount.sol#L449, ModuleManager.sol#L34, ModuleManager.sol#L49, ModuleManager.sol#L68 | ModuleManager.sol, SmartAccount.sol | 4 | Line 449: function transfer(address payable dest, uint amount) external payable nonReentrant onlyOwner { | true | contracts/smart-contract-wallet/SmartAccount.sol
Line 461: _requireFromEntryPointOrOwner();
Line 466: _requireFromEntryPointOrOwner();
Line 494: function _requireFromEntryPointOrOwner() internal view {
Line 495: require(msg.sender == address(entryPoint()) || msg.sender == owner, "account: not Owner or ... | true | true | 7 | ||
c4 | 01-salty | Infect3d Q | High | high | # [L-01] - It is possible to call `borrowUSDS` with a very low amount
## Vulnerability details
Nothing prevents a user to borrow a very low amount of USDS (for example 1 wei)
The issue is that everytime a user borrow some USDS, an element is added to `_walletsWithBorrowedUSDS`
```soldiity
function borrowUSDS( uin... | This can cause an issue for liquidator who want to find liquidable users, as to high value `numberOfUsersWithBorrowedUSDS` will make the gas cost of the loop to high, possibly causing a revert
| ```solidity
File: src\stable\CollateralAndLiquidity.sol311: function findLiquidatableUsers( uint256 startIndex, uint256 endIndex ) public view returns (address[] memory) //..?@audit compare with canUserBeLiquidated
312: {
313: address[] memory liquidatableUsers = new address[](endIndex - startIndex + 1);
314: ui... | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/Infect3d-Q.md | 2026-01-02T19:01:19.241173+00:00 | 9682d83f8ad17fd1c242c3d345d6b3fe5395ec34d83980957a01e3304531c225 | 2 | 1 | 1,110 | 0 | false | false | true | false | high | function borrowUSDS( uint256 amountBorrowed ) external nonReentrant
{
require( exchangeConfig.walletHasAccess(msg.sender), "Sender does not have exchange access" );
require( userShareForPool( msg.sender, collateralPoolID ) > 0, "User does not have any collateral" );
require( amountBorrowed <= maxBorrowableUSDS(... | soldiity | 792 | // Code block 1 (soldiity):
function borrowUSDS( uint256 amountBorrowed ) external nonReentrant
{
require( exchangeConfig.walletHasAccess(msg.sender), "Sender does not have exchange access" );
require( userShareForPool( msg.sender, collateralPoolID ) > 0, "User does not have any collateral" );
require( amountBo... | 2 | false | File: src\stable\CollateralAndLiquidity.sol
345: function findLiquidatableUsers() external view returns (address[] memory)
346: {
347: if ( numberOfUsersWithBorrowedUSDS() == 0 )
348: return new address[](0);
349:
350: return findLiquidatableUsers( 0, numberOfUsersWithBorrowedUSDS() - 1 );
351: }
352: } | 0 | This can cause an issue for liquidator who want to find liquidable users, as to high value `numberOfUsersWithBorrowedUSDS` will make the gas cost of the loop to high, possibly causing a revert
| true | ```solidity
File: src\stable\CollateralAndLiquidity.sol311: function findLiquidatableUsers( uint256 startIndex, uint256 endIndex ) public view returns (address[] memory) //..?@audit compare with canUserBeLiquidated
312: {
313: address[] memory liquidatableUsers = new address[](endIndex - startIndex + 1);
314: ui... | true | true | 7 | ||||
c4 | 02-ethos | kodyvim G | Critical | critical | # Gas Optimization and QA report
## Use require to save gas
Replace `assert` with `require` to return unused gas on failure.
instances:
```
Ethos-Core/contracts/BorrowerOperations.sol#L128 assert(MIN_NET_DEBT > 0)
Ethos-Core/contracts/BorrowerOperations.sol#L197 assert(vars.compositeDebt > 0);
Ethos-Core/contra... | Ethos-Core/contracts/BorrowerOperations.sol#L128 assert(MIN_NET_DEBT > 0)
Ethos-Core/contracts/BorrowerOperations.sol#L197 assert(vars.compositeDebt > 0);
Ethos-Core/contracts/BorrowerOperations.sol#L301 assert(msg.sender == _borrower || (msg.sender == stabilityPoolAddress && _collTopUp > 0 && _LUSDChange == ... | Ethos-Core/contracts/BorrowerOperations.sol#301 assert(msg.sender == _borrower || (msg.sender == stabilityPoolAddress && _collTopUp > 0 && _LUSDChange == 0)) | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/kodyvim-G.md | 2026-01-02T18:17:20.830008+00:00 | 96c47452cf9e03d67083ae07a065e75d595c7db4dc73743ea9b790a13621f17a | 1 | 0 | 1,716 | 0 | false | false | true | false | high | Ethos-Core/contracts/BorrowerOperations.sol#L128 assert(MIN_NET_DEBT > 0)
Ethos-Core/contracts/BorrowerOperations.sol#L197 assert(vars.compositeDebt > 0);
Ethos-Core/contracts/BorrowerOperations.sol#L301 assert(msg.sender == _borrower || (msg.sender == stabilityPoolAddress && _collTopUp > 0 && _LUSDChange == ... | unknown | 1,716 | // Code block 1 (unknown):
Ethos-Core/contracts/BorrowerOperations.sol#L128 assert(MIN_NET_DEBT > 0)
Ethos-Core/contracts/BorrowerOperations.sol#L197 assert(vars.compositeDebt > 0);
Ethos-Core/contracts/BorrowerOperations.sol#L301 assert(msg.sender == _borrower || (msg.sender == stabilityPoolAddress && _collT... | 1 | false | 0 | Ethos-Core/contracts/BorrowerOperations.sol#L128 assert(MIN_NET_DEBT > 0)
Ethos-Core/contracts/BorrowerOperations.sol#L197 assert(vars.compositeDebt > 0);
Ethos-Core/contracts/BorrowerOperations.sol#L301 assert(msg.sender == _borrower || (msg.sender == stabilityPoolAddress && _collTopUp > 0 && _LUSDChange == ... | true | Ethos-Core/contracts/BorrowerOperations.sol#301 assert(msg.sender == _borrower || (msg.sender == stabilityPoolAddress && _collTopUp > 0 && _LUSDChange == 0)) | true | true | 6 | |||||
c4 | 01-biconomy | apostle0x01 G | Gas | gas | ## [G-01] Splitting require() statements that use && saves gas
### IMPACT
Require statements including conditions with the && operator can be broken down in
multiple require statements to save gas.
### POC
```
contracts/smart-contract-wallet/base/ModuleManager.sol:34: require(module != address(0) && module... | contracts/smart-contract-wallet/base/ModuleManager.sol:34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleManager.sol:49: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleMan... | other | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/apostle0x01-G.md | 2026-01-02T18:13:29.690932+00:00 | 96c5dda7a1f5a89c7cc47fdee9744c1e258da41be2d53f44de6e04b622e04e24 | 2 | 0 | 514 | 0 | false | true | true | false | medium | contracts/smart-contract-wallet/base/ModuleManager.sol:34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleManager.sol:49: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleMan... | unknown | 427 | // Code block 1 (unknown):
contracts/smart-contract-wallet/base/ModuleManager.sol:34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleManager.sol:49: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-con... | 2 | false | 0 | contracts/smart-contract-wallet/base/ModuleManager.sol:34: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleManager.sol:49: require(module != address(0) && module != SENTINEL_MODULES, "BSA101");
contracts/smart-contract-wallet/base/ModuleMan... | true | false | false | 4.63 | |||||||
c4 | 01-biconomy | 2997ms G | Gas | gas | ## Gas Optimazition Summary
### Issues
| | Issue | Contexts |
| ----- | :--------------------------------------- | :------: |
| GAS-1 | Revert directly if the length of returndata is 0 | 3 |
| GAS-2 | <x> += <y> costs more gas than <x> = <x> + <y> for state variable... | if (!success) {
assembly {
revert(add(result, 32), mload(result))
}
} | if (returndata.length == 0) {
revert();
}
assembly {
revert(add(32, returndata), mload(returndata))
} | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/2997ms-G.md | 2026-01-02T18:12:52.220424+00:00 | 96cf896318520e325999413e2782399bab19550cec1ea7f33a8450b45d0f98fc | 2 | 0 | 220 | 5 | false | false | true | false | high | if (!success) {
assembly {
revert(add(result, 32), mload(result))
}
} | unknown | 117 | // Code block 1 (unknown):
if (!success) {
assembly {
revert(add(result, 32), mload(result))
}
}
// Code block 2 (unknown):
if (returndata.length == 0) {
revert();
}
assembly {
revert(add(32, returndata), mload(returndata))
} | 2 | false | SmartAccountNoAuth.sol#L469, SmartAccount.sol#L479, SimpleAccount.sol#L119, Math.sol#L148, Math.sol#L261-L286 | Math.sol, SmartAccount.sol, SimpleAccount.sol, SmartAccountNoAuth.sol | 5 | if (!success) {
assembly {
revert(add(result, 32), mload(result))
}
} | true | if (returndata.length == 0) {
revert();
}
assembly {
revert(add(32, returndata), mload(returndata))
} | true | true | 8 | |||
c4 | 05-ajna | Kose Q | Critical | critical | # QA Report
## Summary
| | Issue | Risk | Instances |
| :-------------: |:-------------|:-------------:|:-------------:|
| 1 | If/validation statements should be on the top of the function | NC | 1 |
| 2 | Immutables should be uppercase to distinguish from regular variables | NC | 3 |
#... | function mint(
MintParams calldata params_
) external override nonReentrant returns (uint256 tokenId_) {
tokenId_ = _nextId++;
// revert if the address is not a valid Ajna pool
if (!_isAjnaPool(params_.pool, params_.poolSubsetHash)) revert NotAjnaPool(); | /// @dev The `ERC20` pools factory contract, used to check if address is an `Ajna` pool.
ERC20PoolFactory private immutable erc20PoolFactory;
/// @dev The `ERC721` pools factory contract, used to check if address is an `Ajna` pool.
ERC721PoolFactory private immutable erc721PoolFactory; | reentrancy | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/Kose-Q.md | 2026-01-02T18:21:04.177429+00:00 | 97089db5e7478441978fee6bc034f69622323d63e8e2c6da94b8637310e82b9d | 3 | 0 | 766 | 4 | false | false | true | false | high | function mint(
MintParams calldata params_
) external override nonReentrant returns (uint256 tokenId_) {
tokenId_ = _nextId++;
// revert if the address is not a valid Ajna pool
if (!_isAjnaPool(params_.pool, params_.poolSubsetHash)) revert NotAjnaPool(); | unknown | 291 | // Code block 1 (unknown):
function mint(
MintParams calldata params_
) external override nonReentrant returns (uint256 tokenId_) {
tokenId_ = _nextId++;
// revert if the address is not a valid Ajna pool
if (!_isAjnaPool(params_.pool, params_.poolSubsetHash)) revert NotAjnaPool();
... | 3 | false | PositionManager.sol, PositionManager.sol#L68-L71, RewardsManager.sol#L86-L89, Funding.sol#L20-L21 | RewardsManager.sol, Funding.sol, PositionManager.sol | 4 | function mint(
MintParams calldata params_
) external override nonReentrant returns (uint256 tokenId_) {
tokenId_ = _nextId++;
// revert if the address is not a valid Ajna pool
if (!_isAjnaPool(params_.pool, params_.poolSubsetHash)) revert NotAjnaPool(); | true | /// @dev The `ERC20` pools factory contract, used to check if address is an `Ajna` pool.
ERC20PoolFactory private immutable erc20PoolFactory;
/// @dev The `ERC721` pools factory contract, used to check if address is an `Ajna` pool.
ERC721PoolFactory private immutable erc721PoolFactory; | true | true | 9 | |||
c4 | 06-lybra | j4ld1na G | Gas | gas | | | Issues | Instances |
| :--- | :-------------------------------------- | --------: |
| G-01 | Remove `SafeMath` library. | 1 |
| G-02 | Use assembly to check for `address(0)`. | 6 |
## G-01 - Remove `SafeMath` library.
_Gas saved: 2.1k for each tx ... | ```ts
function assemblyOwnerNotZero(address _addr) public pure {
assembly {
if iszero(_addr) {
mstore(0x00, "zero address")
revert(0x00, 0x20)
}
}
}
// Gas: 252 | - [contracts/lybra/pools/base/LybraPeUSDVaultBase.sol#L97](https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/pools/base/LybraPeUSDVaultBase.sol#L97)
| access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/j4ld1na-G.md | 2026-01-02T18:23:01.978614+00:00 | 97253983e8199a7364059a9c5347e186e02954406a981e8cc41687c25f55d62e | 4 | 0 | 401 | 3 | false | false | true | false | high | function ownerNotZero(address _addr) public pure {
require(_addr != address(0), "zero address)");
}
// Gas: 258 | ts | 116 | // Code block 1 (ts):
function ownerNotZero(address _addr) public pure {
require(_addr != address(0), "zero address)");
}
// Gas: 258
// Code block 2 (ts):
function assemblyOwnerNotZero(address _addr) public pure {
assembly {
if iszero(_addr) {
mstore(0x00, "zero address")
reve... | 4 | false | EUSD.sol#L5, LybraPeUSDVaultBase.sol#L83, LybraPeUSDVaultBase.sol#L97 | LybraPeUSDVaultBase.sol, EUSD.sol | 3 | ```ts
function assemblyOwnerNotZero(address _addr) public pure {
assembly {
if iszero(_addr) {
mstore(0x00, "zero address")
revert(0x00, 0x20)
}
}
}
// Gas: 252 | true | - [contracts/lybra/pools/base/LybraPeUSDVaultBase.sol#L97](https://github.com/code-423n4/2023-06-lybra/blob/main/contracts/lybra/pools/base/LybraPeUSDVaultBase.sol#L97)
| true | true | 10 | |||
c4 | 08-dopex | MohammedRizwan Q | Medium | medium | ## Summary
### Low Risk Issues
|Number|Issue|Instances| |
|-|:-|:-:|:-:|
| [L‑01] | openzeppelin's `setupRole()` is deprecated | 7 |
| [L‑02] | set max limit of `slippageTolerance` in `setSlippageTolerance()` | 2 |
| [L‑03] | Calls inside loops that may address DoS | 1 |
| [L‑04] | Admin ma... | File: contracts/amo/UniV2LiquidityAmo.sol
function emergencyWithdraw(
address[] calldata tokens
) external onlyRole(DEFAULT_ADMIN_ROLE) {
IERC20WithBurn token;
for (uint256 i = 0; i < tokens.length; i++) {
token = IERC20WithBurn(tokens[i]);
>> token.safeTransfer(msg.sender, token.balanceOf(ad... | File: contracts/amo/UniV2LiquidityAmo.sol
function emergencyWithdraw(
address[] calldata tokens
) external onlyRole(DEFAULT_ADMIN_ROLE) {
IERC20WithBurn token;
for (uint256 i = 0; i < tokens.length; i++) {
token = IERC20WithBurn(tokens[i]);
token.safeTransfer(msg.sender, token.balanceOf(ad... | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/MohammedRizwan-Q.md | 2026-01-02T18:24:55.114899+00:00 | 97c1843287049e47742f272e00e0992681ead8c1b19b6c51aefff3ac6a996a62 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: contracts/amo/UniV2LiquidityAmo.sol
function emergencyWithdraw(
address[] calldata tokens
) external onlyRole(DEFAULT_ADMIN_ROLE) {
IERC20WithBurn token;
for (uint256 i = 0; i < tokens.length; i++) {
token = IERC20WithBurn(tokens[i]);
>> token.safeTransfer(msg.sender, token.balanceOf(ad... | true | File: contracts/amo/UniV2LiquidityAmo.sol
function emergencyWithdraw(
address[] calldata tokens
) external onlyRole(DEFAULT_ADMIN_ROLE) {
IERC20WithBurn token;
for (uint256 i = 0; i < tokens.length; i++) {
token = IERC20WithBurn(tokens[i]);
token.safeTransfer(msg.sender, token.balanceOf(ad... | true | true | 5 | ||||||||
c4 | 01-ondo | descharre G | Low | low | ## Summary
|ID | Finding| Gas saved| Instances |
|:----: | :--- | :----: | :----: |
|1 |Make for loops unchecked| 414 | 1 |
| 2 |Save storage variable to memory when it's used more than once in a function | 296| 3 |
| 3 |Don't write old value to memory | 500| 25 |... | It can also be done on every other for loop in the project. The larger the array the more gas you will save.
## 2 Save storage variable to memory when it's used more than once in a function
When a storage variable is read for the second time from storage it costs 100 gas. When it's read from memory it only costs 3 gas... | [CashManager.sol#L576-L587](https://github.com/code-423n4/2023-01-ondo/blob/main/contracts/cash/CashManager.sol#L576-L587)
transitionEpoch function avg gas saved: 89 | reentrancy | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/descharre-G.md | 2026-01-02T18:15:05.460581+00:00 | 97c1b39cd68b3b60bb972a68ebb7b0c39c988bff2314cebcd1145abc79b56985 | 1 | 1 | 173 | 3 | false | false | true | false | high | L163
+ uint256 i;
- for (uint256 i = 0; i < length; i++) {
+ for (; i < lenght; ){
kycState[kycRequirementGroup][addresses[i]] = true;
+ unchecked {
+ i++;
+ }
} | diff | 173 | // Code block 1 (diff):
L163
+ uint256 i;
- for (uint256 i = 0; i < length; i++) {
+ for (; i < lenght; ){
kycState[kycRequirementGroup][addresses[i]] = true;
+ unchecked {
+ i++;
+ }
} | 1 | true | L163
+ uint256 i;
- for (uint256 i = 0; i < length; i++) {
+ for (; i < lenght; ){
kycState[kycRequirementGroup][addresses[i]] = true;
+ unchecked {
+ i++;
+ }
} | KYCRegistry.sol#L163-L165, CashManager.sol#L241-L269, CashManager.sol#L576-L587 | CashManager.sol, KYCRegistry.sol | 3 | It can also be done on every other for loop in the project. The larger the array the more gas you will save.
## 2 Save storage variable to memory when it's used more than once in a function
When a storage variable is read for the second time from storage it costs 100 gas. When it's read from memory it only costs 3 gas... | true | [CashManager.sol#L576-L587](https://github.com/code-423n4/2023-01-ondo/blob/main/contracts/cash/CashManager.sol#L576-L587)
transitionEpoch function avg gas saved: 89 | true | true | 9 | ||
c4 | 07-amphora | eeshenggoh Q | High | high | ## Summary
Unsafe ERC20 Operation(s)
## Vulnerability Details
ERC20 operations can be unsafe due to different implementations and vulnerabilities in the standard.
It is therefore recommended to always either use OpenZeppelin's SafeERC20 library or at least to wrap each operation in a require statement.
To circumve... | File: core\solidity\contracts\core\AMPHClaimer.sol
128: function recoverDust(address _token, uint256 _amount) external override onlyOwner {
129: IERC20(_token).transfer(owner(), _amount);
130:
131: emit RecoveredDust(_token, owner(), _amount);
132: } | File: core\solidity\contracts\core\USDA.sol
101: function _deposit(uint256 _susdAmount, address _target) internal paysInterest whenNotPaused {
102: if (_susdAmount == 0) revert USDA_ZeroAmount();
103: sUSD.transferFrom(_msgSender(), address(this), _susdAmount);
104: _mint(_target, _susdAmount);
105: /... | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/eeshenggoh-Q.md | 2026-01-02T18:23:44.376559+00:00 | 983465c00c2bc2d074231337b03460c4b42560e3d3965bbafe2767d3a28470b2 | 3 | 0 | 1,298 | 0 | false | false | true | false | high | File: core\solidity\contracts\core\AMPHClaimer.sol
128: function recoverDust(address _token, uint256 _amount) external override onlyOwner {
129: IERC20(_token).transfer(owner(), _amount);
130:
131: emit RecoveredDust(_token, owner(), _amount);
132: } | unknown | 263 | // Code block 1 (unknown):
File: core\solidity\contracts\core\AMPHClaimer.sol
128: function recoverDust(address _token, uint256 _amount) external override onlyOwner {
129: IERC20(_token).transfer(owner(), _amount);
130:
131: emit RecoveredDust(_token, owner(), _amount);
132: }
// Code block 2 (unknown):
F... | 3 | false | 0 | File: core\solidity\contracts\core\AMPHClaimer.sol
128: function recoverDust(address _token, uint256 _amount) external override onlyOwner {
129: IERC20(_token).transfer(owner(), _amount);
130:
131: emit RecoveredDust(_token, owner(), _amount);
132: } | true | File: core\solidity\contracts\core\USDA.sol
101: function _deposit(uint256 _susdAmount, address _target) internal paysInterest whenNotPaused {
102: if (_susdAmount == 0) revert USDA_ZeroAmount();
103: sUSD.transferFrom(_msgSender(), address(this), _susdAmount);
104: _mint(_target, _susdAmount);
105: /... | true | true | 8 | |||||
c4 | 02-ethos | lukris02 Q | Critical | critical | # QA Report for Ethos Reserve contest
## Overview
During the audit, 2 low and 12 non-critical issues were found.
№ | Title | Risk Rating | Instance Count
--- | --- | --- | ---
L-1 | Check multisigRoles.length in ReaperVaultV2 | Low | 1
L-2 | Some events could be more informative | Low | 4
NC-1 | Order of Functions | ... | require(_multisigRoles.length == 3, "Invalid number of multisig roles");
_grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
_grantRole(DEFAULT_ADMIN_ROLE, _multisigRoles[0]);
_grantRole(ADMIN, _multisigRoles[1]);
_grantRole(GUARDIAN, _multisigRoles[2]); | require(_multisigRoles.length == 3, "Invalid number of multisig roles"); | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/lukris02-Q.md | 2026-01-02T18:17:22.159867+00:00 | 98783aa077dff90b31a7a21adcfb34dadc32617f97e211db434363448008426b | 1 | 0 | 278 | 4 | false | false | true | false | high | require(_multisigRoles.length == 3, "Invalid number of multisig roles");
_grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
_grantRole(DEFAULT_ADMIN_ROLE, _multisigRoles[0]);
_grantRole(ADMIN, _multisigRoles[1]);
_grantRole(GUARDIAN, _multisigRoles[2]); | unknown | 278 | // Code block 1 (unknown):
require(_multisigRoles.length == 3, "Invalid number of multisig roles");
_grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
_grantRole(DEFAULT_ADMIN_ROLE, _multisigRoles[0]);
_grantRole(ADMIN, _multisigRoles[1]);
_grantRole(GUARDIAN, _multisigRoles[2]); | 1 | false | ReaperBaseStrategyv4.sol#L63-L88, ReaperVaultV2.sol#L111-L136, ReaperVaultV2.sol#L132-L135, ReaperBaseStrategyv4.sol#L81-L85 | ReaperBaseStrategyv4.sol, ReaperVaultV2.sol | 4 | require(_multisigRoles.length == 3, "Invalid number of multisig roles");
_grantRole(DEFAULT_ADMIN_ROLE, msg.sender);
_grantRole(DEFAULT_ADMIN_ROLE, _multisigRoles[0]);
_grantRole(ADMIN, _multisigRoles[1]);
_grantRole(GUARDIAN, _multisigRoles[2]); | true | require(_multisigRoles.length == 3, "Invalid number of multisig roles"); | true | true | 7 | |||
c4 | 01-biconomy | apostle0x01 Q | Low | low | ## \[L-01\] NO TRANSFER OWNERSHIP PATTERN
Recommend considering implementing a two step process where the owner or admin nominates an account and the nominated account needs to call an acceptOwnership() function for the transfer of ownership to fully succeed. This ensures the nominated EOA account is a valid and activ... | 109: function setOwner(address _newOwner) external mixedAuth {
110: require(_newOwner != address(0), "Smart Account:: new Signatory address cannot be zero");
111: address oldOwner = owner;
112: owner = _newOwner;
113: emit EOAChanged(address(this), oldOwner, _newOwner);
114: }
| access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/apostle0x01-Q.md | 2026-01-02T18:13:30.131460+00:00 | 98c5334484870666f50b3f65961ec4a6963b40b039ef527a27df1c5a20951b20 | 1 | 1 | 311 | 1 | false | true | true | false | medium | 109: function setOwner(address _newOwner) external mixedAuth {
110: require(_newOwner != address(0), "Smart Account:: new Signatory address cannot be zero");
111: address oldOwner = owner;
112: owner = _newOwner;
113: emit EOAChanged(address(this), oldOwner, _newOwner);
114: } | solidity | 311 | // Code block 1 (solidity):
109: function setOwner(address _newOwner) external mixedAuth {
110: require(_newOwner != address(0), "Smart Account:: new Signatory address cannot be zero");
111: address oldOwner = owner;
112: owner = _newOwner;
113: emit EOAChanged(address(this), oldOwner, _n... | 1 | false | 109: function setOwner(address _newOwner) external mixedAuth {
110: require(_newOwner != address(0), "Smart Account:: new Signatory address cannot be zero");
111: address oldOwner = owner;
112: owner = _newOwner;
113: emit EOAChanged(address(this), oldOwner, _newOwner);
114: } | SmartAccount.sol#L109-L114 | SmartAccount.sol | 1 | 109: function setOwner(address _newOwner) external mixedAuth {
110: require(_newOwner != address(0), "Smart Account:: new Signatory address cannot be zero");
111: address oldOwner = owner;
112: owner = _newOwner;
113: emit EOAChanged(address(this), oldOwner, _newOwner);
114: }
| true | false | false | 4.77 | ||||
c4 | 01-ondo | Diana Q | Critical | critical |
## 01 Require() should be used instead of assert()
Assert should not be used except for tests, `require` should be used
Prior to Solidity 0.8.0, pressing a confirm consumes the remainder of the process’s available gas instead of returning it, as request()/revert() did.
Assertion() should be avoided even after solid... | File: contracts/cash/factory/CashFactory.sol
97: assert(cashProxyAdmin.owner() == guardian); | File: contracts/cash/factory/CashKYCSenderFactory.sol
106: assert(cashKYCSenderProxyAdmin.owner() == guardian); | access-control | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/Diana-Q.md | 2026-01-02T18:14:35.581481+00:00 | 9942b6dd32168a2ae1834a4ff0ff0a73d65acf238a0d26f1262bb9e46e817414 | 4 | 0 | 480 | 4 | false | false | true | false | high | File: contracts/cash/factory/CashFactory.sol
97: assert(cashProxyAdmin.owner() == guardian); | unknown | 93 | // Code block 1 (unknown):
File: contracts/cash/factory/CashFactory.sol
97: assert(cashProxyAdmin.owner() == guardian);
// Code block 2 (unknown):
File: contracts/cash/factory/CashKYCSenderFactory.sol
106: assert(cashKYCSenderProxyAdmin.owner() == guardian);
// Code block 3 (unknown):
File: contracts/cash/factory/C... | 4 | false | CashFactory.sol, CashKYCSenderFactory.sol, CashKYCSenderReceiverFactory.sol, Proxy.sol | CashFactory.sol, CashKYCSenderFactory.sol, Proxy.sol, CashKYCSenderReceiverFactory.sol | 4 | File: contracts/cash/factory/CashFactory.sol
97: assert(cashProxyAdmin.owner() == guardian); | true | File: contracts/cash/factory/CashKYCSenderFactory.sol
106: assert(cashKYCSenderProxyAdmin.owner() == guardian); | true | true | 10 | |||
c4 | 01-salty | Tigerfrake G | Low | low | # [G-01] Switching between 1 and 2 instead of 0 and 1 (or false and true) is more gas efficient.
### Description:
`SSTORE` from 0 to 1 (or any non-zero value) costs 20000 gas. `SSTORE` from 1 to 2 (or any other non-zero value) costs 5000 gas.
By storing the original value once again, a refund is triggered ( https://e... | function proposeWallets( address _proposedMainWallet, address _proposedConfirmationWallet ) external
//... require statements
proposedMainWallet = _proposedMainWallet;
proposedConfirmationWallet = _proposedConfirmationWallet;
emit WalletPropos... | emit WalletProposal(proposedMainWallet, proposedConfirmationWallet); | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/Tigerfrake-G.md | 2026-01-02T19:01:30.464144+00:00 | 99671bcf12e19542f6111ead6f168caac21d4c682bb6a2263dfe710d6fb8dcd0 | 2 | 0 | 449 | 4 | false | false | true | false | high | function proposeWallets( address _proposedMainWallet, address _proposedConfirmationWallet ) external
//... require statements
proposedMainWallet = _proposedMainWallet;
proposedConfirmationWallet = _proposedConfirmationWallet;
emit WalletProposal(propo... | Solidity | 381 | // Code block 1 (Solidity):
function proposeWallets( address _proposedMainWallet, address _proposedConfirmationWallet ) external
//... require statements
proposedMainWallet = _proposedMainWallet;
proposedConfirmationWallet = _proposedConfirmationWallet;
... | 2 | false | function proposeWallets( address _proposedMainWallet, address _proposedConfirmationWallet ) external
//... require statements
proposedMainWallet = _proposedMainWallet;
proposedConfirmationWallet = _proposedConfirmationWallet;
emit WalletProposal(propo... | ReentrancyGuard.sol#L29-L33, src%2Fdao%2FDAO.sol#L187, src%2Fdao%2FDAO.sol#L194, src%2FManagedWallet.sol#L42-L55 | src%2FManagedWallet.sol, src%2Fdao%2FDAO.sol, ReentrancyGuard.sol | 4 | function proposeWallets( address _proposedMainWallet, address _proposedConfirmationWallet ) external
//... require statements
proposedMainWallet = _proposedMainWallet;
proposedConfirmationWallet = _proposedConfirmationWallet;
emit WalletPropos... | true | emit WalletProposal(proposedMainWallet, proposedConfirmationWallet); | true | true | 8 | ||
c4 | 07-amphora | VIELITE Analysis | Unknown | unknown | There are no checks for address(0) in the `_burn()` function in the USDA.sol contract which can lead to unnecessary reverts
```solidity
function _burn(address _target, uint256 _amount) internal {
uint256 __gonsPerFragment = _gonsPerFragment;
// modify the gonbalances of the sender, subtracting the amount of g... | function _burn(address _target, uint256 _amount) internal {
uint256 __gonsPerFragment = _gonsPerFragment;
// modify the gonbalances of the sender, subtracting the amount of gons, therefore amount * gonsperfragment
_gonBalances[_target] -= (_amount * __gonsPerFragment);
// modify totalSupply and totalGon... | other | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/VIELITE-Analysis.md | 2026-01-02T18:23:37.659965+00:00 | 99ac64a5dae6ff8eb3ab416551a444078af24ef8f02361ffa963048556986ebf | 1 | 1 | 528 | 0 | false | true | true | false | medium | function _burn(address _target, uint256 _amount) internal {
uint256 __gonsPerFragment = _gonsPerFragment;
// modify the gonbalances of the sender, subtracting the amount of gons, therefore amount * gonsperfragment
_gonBalances[_target] -= (_amount * __gonsPerFragment);
// modify totalSupply and totalGon... | solidity | 528 | // Code block 1 (solidity):
function _burn(address _target, uint256 _amount) internal {
uint256 __gonsPerFragment = _gonsPerFragment;
// modify the gonbalances of the sender, subtracting the amount of gons, therefore amount * gonsperfragment
_gonBalances[_target] -= (_amount * __gonsPerFragment);
// mod... | 1 | false | function _burn(address _target, uint256 _amount) internal {
uint256 __gonsPerFragment = _gonsPerFragment;
// modify the gonbalances of the sender, subtracting the amount of gons, therefore amount * gonsperfragment
_gonBalances[_target] -= (_amount * __gonsPerFragment);
// modify totalSupply and totalGon... | 0 | function _burn(address _target, uint256 _amount) internal {
uint256 __gonsPerFragment = _gonsPerFragment;
// modify the gonbalances of the sender, subtracting the amount of gons, therefore amount * gonsperfragment
_gonBalances[_target] -= (_amount * __gonsPerFragment);
// modify totalSupply and totalGon... | true | false | false | 3.51 | ||||||
c4 | 11-kelp | 0x_Scar Q | Low | low | The `NodeDelegator` contract and the `RSETH` contract allows for pausing and unpausing via the `pause ()` and `unpause` function. The contract code on the `pause ()` function reads as `Only callable by LRT config manager. Contract must NOT be paused.` and `unpause ()` reads as `Only callable by the rsETH admin. Contrac... | function pause() external onlyLRTManager whenNotPaused {
_pause();
}
/// @notice Returns to normal state.
/// @dev Only callable by the rsETH admin. Contract must be paused
function unpause() external onlyRole(DEFAULT_ADMIN_ROLE) whenPaused {
_unpause();
} | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/0x_Scar-Q.md | 2026-01-02T18:27:12.308700+00:00 | 99b5394c724f5d104402e58c93a8048d61197e1fa88040463a093e3cd395b6d1 | 1 | 0 | 293 | 0 | false | true | true | false | medium | function pause() external onlyLRTManager whenNotPaused {
_pause();
}
/// @notice Returns to normal state.
/// @dev Only callable by the rsETH admin. Contract must be paused
function unpause() external onlyRole(DEFAULT_ADMIN_ROLE) whenPaused {
_unpause();
} | unknown | 293 | // Code block 1 (unknown):
function pause() external onlyLRTManager whenNotPaused {
_pause();
}
/// @notice Returns to normal state.
/// @dev Only callable by the rsETH admin. Contract must be paused
function unpause() external onlyRole(DEFAULT_ADMIN_ROLE) whenPaused {
_unpause();
} | 1 | false | 0 | function pause() external onlyLRTManager whenNotPaused {
_pause();
}
/// @notice Returns to normal state.
/// @dev Only callable by the rsETH admin. Contract must be paused
function unpause() external onlyRole(DEFAULT_ADMIN_ROLE) whenPaused {
_unpause();
} | true | false | false | 3.88 | |||||||
c4 | 02-ethos | chaduke Q | Low | low | QA1. The ``updateDistributionPeriod()`` function has no range check for the input ``_newDistributionPeriod``. As a result, it might cause an overflow for L112 of function ``fund()``:
[https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/LQTY/CommunityIssuance... | QA3. The ``permit()`` function fails to check v ∈ {27, 28}, so it might be subject to signature malleability.
https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/LUSDToken.sol#L262-L290
Mitigation:
Use Zeppelin's ECDSA: https://github.com/OpenZeppelin/openze... | QA7. ``updateGovernance()`` and ``updateGuardian()`` use only one step to change address.
[https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/LUSDToken.sol#L146-L158](https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/chaduke-Q.md | 2026-01-02T18:16:56.221456+00:00 | 99bc7570d3b78bb65486ed67d1c69929ffee5cdfcba6e45e3fc909f4993a907a | 0 | 0 | 0 | 8 | false | false | false | false | medium | 0 | 0 | false | CommunityIssuance.sol#L101-L117, CommunityIssuance.sol#L84-L110, LUSDToken.sol#L262-L290, ECDSA.sol, BorrowerOperations.sol#L476-L502, LiquityMath.sol#L97-L106, LUSDToken.sol#L146-L158, Ownable2Step.sol | BorrowerOperations.sol, LUSDToken.sol, Ownable2Step.sol, CommunityIssuance.sol, LiquityMath.sol, ECDSA.sol | 8 | QA3. The ``permit()`` function fails to check v ∈ {27, 28}, so it might be subject to signature malleability.
https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/LUSDToken.sol#L262-L290
Mitigation:
Use Zeppelin's ECDSA: https://github.com/OpenZeppelin/openze... | true | QA7. ``updateGovernance()`` and ``updateGuardian()`` use only one step to change address.
[https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/Ethos-Core/contracts/LUSDToken.sol#L146-L158](https://github.com/code-423n4/2023-02-ethos/blob/73687f32b934c9d697b97745356cdf8a1f264955/... | true | true | 6 | ||||||
c4 | 05-ajna | nadin Q | Critical | critical | # QA Report
## Summary
Total 04 Low and 06 Non-Critical
### Low Risk Issues
- [L-01] EXPIRED PROPOSALS ARE NOT CHECKED
- [L-02] Consider using OpenZeppelin’s SafeCast library to prevent unexpected overflows when casting from uint256
- [L-03] Hard coding MAX_EFM_PROPOSAL_LENGTH can lead to a revert in ExtraordinaryFund... | function state(
uint256 proposalId_
) external view override returns (ProposalState) {
FundingMechanism mechanism = findMechanismOfProposal(proposalId_);
return mechanism == FundingMechanism.Standard ? _standardProposalState(proposalId_) : _getExtraordinaryProposalState(proposalId_);
... | [_getExtraordinaryProposalState(proposalId_)](https://github.com/code-423n4/2023-05-ajna/blob/276942bc2f97488d07b887c8edceaaab7a5c3964/ajna-grants/src/grants/base/ExtraordinaryFunding.sol#L190-L199) | reentrancy | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/nadin-Q.md | 2026-01-02T18:21:37.603745+00:00 | 99c937f770e8a5793d8b961e278fe99896c68e8aacb411f4f592f2963ff1288c | 1 | 0 | 320 | 3 | false | false | true | false | high | function state(
uint256 proposalId_
) external view override returns (ProposalState) {
FundingMechanism mechanism = findMechanismOfProposal(proposalId_);
return mechanism == FundingMechanism.Standard ? _standardProposalState(proposalId_) : _getExtraordinaryProposalState(proposalId_);
} | unknown | 320 | // Code block 1 (unknown):
function state(
uint256 proposalId_
) external view override returns (ProposalState) {
FundingMechanism mechanism = findMechanismOfProposal(proposalId_);
return mechanism == FundingMechanism.Standard ? _standardProposalState(proposalId_) : _getExtraordinaryPropos... | 1 | false | GrantFund.sol#L45-L51, StandardFunding.sol#L505-L512, ExtraordinaryFunding.sol#L190-L199 | StandardFunding.sol, ExtraordinaryFunding.sol, GrantFund.sol | 3 | function state(
uint256 proposalId_
) external view override returns (ProposalState) {
FundingMechanism mechanism = findMechanismOfProposal(proposalId_);
return mechanism == FundingMechanism.Standard ? _standardProposalState(proposalId_) : _getExtraordinaryProposalState(proposalId_);
... | true | [_getExtraordinaryProposalState(proposalId_)](https://github.com/code-423n4/2023-05-ajna/blob/276942bc2f97488d07b887c8edceaaab7a5c3964/ajna-grants/src/grants/base/ExtraordinaryFunding.sol#L190-L199) | true | true | 7 | |||
c4 | 07-amphora | wahedtalash77 Q | Low | low | # Low Risk Findings
## [L‑01] Use Ownable2Step rather than Ownable
`Ownable2Step` and `Ownable2StepUpgradeable` prevent the contract ownership from mistakenly being transferred to an address that cannot handle it (e.g. due to a typo in the address), by requiring that the recipient of the owner permissions actively acc... | 23: contract VaultController is Pausable, IVaultController, ExponentialNoError, Ownable { | 20: contract UFragments is Ownable, IERC20Metadata {
` | access-control | https://github.com/code-423n4/2023-07-amphora-findings/blob/main/data/wahedtalash77-Q.md | 2026-01-02T18:24:05.366640+00:00 | 99e7e755e38dace2a2e75daf00cfc09e574988068384887fe5b2bab1b86bca67 | 4 | 0 | 245 | 5 | false | false | true | false | high | 23: contract VaultController is Pausable, IVaultController, ExponentialNoError, Ownable { | unknown | 89 | // Code block 1 (unknown):
23: contract VaultController is Pausable, IVaultController, ExponentialNoError, Ownable {
// Code block 2 (unknown):
20: contract UFragments is Ownable, IERC20Metadata {
`
// Code block 3 (unknown):
contract ChainlinkOracleRelay is OracleRelay, Ownable {
// Code block 4 (unknown):
contract... | 4 | false | UFragments.sol#L20, ChainlinkOracleRelay.sol#L11, CTokenOracle.sol#L10, UniswapV3OracleRelay.sol#L2-L1, WUSDA.sol#L35-L3 | WUSDA.sol, UniswapV3OracleRelay.sol, UFragments.sol, ChainlinkOracleRelay.sol, CTokenOracle.sol | 5 | 23: contract VaultController is Pausable, IVaultController, ExponentialNoError, Ownable { | true | 20: contract UFragments is Ownable, IERC20Metadata {
` | true | true | 10 | |||
c4 | 10-badger | nonseodion G | Low | low | G-1 `_formatClAggregateAnswer` can be completely replaced to save gas
The function `_formatClAggregateAnswer` can be completely replaced with:
```
function _formatClAggregateAnswer(
int256 _ethBtcAnswer,
int256 _stEthEthAnswer,
uint8 _ethBtcDecimals,
uint8 _stEthEthDecimals
) i... | function _formatClAggregateAnswer(
int256 _ethBtcAnswer,
int256 _stEthEthAnswer,
uint8 _ethBtcDecimals,
uint8 _stEthEthDecimals
) internal view returns (uint256) {
return
(
uint256(_ethBtcAnswer) *
uint256(_stEthEthAnswer) *
... | function _getPrevChainlinkResponse(
uint80 _currentRoundEthBtcId,
uint80 _currentRoundStEthEthId
) internal view returns (ChainlinkResponse memory prevChainlinkResponse) {
// If first round, early return
// Handles revert from underflow in _currentRoundEthBtcId - 1
// and... | oracle | https://github.com/code-423n4/2023-10-badger-findings/blob/main/data/nonseodion-G.md | 2026-01-02T18:26:57.828661+00:00 | 9a0817dbe4cf2133a355cdf4eccf1618354d8da8e093aa784fbf9cd689c9558f | 1 | 0 | 410 | 0 | false | false | true | false | high | function _formatClAggregateAnswer(
int256 _ethBtcAnswer,
int256 _stEthEthAnswer,
uint8 _ethBtcDecimals,
uint8 _stEthEthDecimals
) internal view returns (uint256) {
return
(
uint256(_ethBtcAnswer) *
uint256(_stEthEthAnswer) *
... | unknown | 410 | // Code block 1 (unknown):
function _formatClAggregateAnswer(
int256 _ethBtcAnswer,
int256 _stEthEthAnswer,
uint8 _ethBtcDecimals,
uint8 _stEthEthDecimals
) internal view returns (uint256) {
return
(
uint256(_ethBtcAnswer) *
uint25... | 1 | false | 0 | function _formatClAggregateAnswer(
int256 _ethBtcAnswer,
int256 _stEthEthAnswer,
uint8 _ethBtcDecimals,
uint8 _stEthEthDecimals
) internal view returns (uint256) {
return
(
uint256(_ethBtcAnswer) *
uint256(_stEthEthAnswer) *
... | true | function _getPrevChainlinkResponse(
uint80 _currentRoundEthBtcId,
uint80 _currentRoundStEthEthId
) internal view returns (ChainlinkResponse memory prevChainlinkResponse) {
// If first round, early return
// Handles revert from underflow in _currentRoundEthBtcId - 1
// and... | true | true | 6 | |||||
c4 | 01-salty | hassanshakeel13 Analysis | Critical | critical | ### Project Overview:
The decentralized financial ecosystem under analysis demonstrates a robust and intricate structure designed to facilitate transparent governance, decentralized decision-making, and comprehensive token reward mechanisms. At its core lies the DAO, DAO.sol, governing the entire ecosystem through a s... | // Example Multi-Signature Implementation
function executeMultiSig(address[] memory signers, bytes memory transaction) external {
require(validateSignatures(signers, transaction), "Invalid signatures");
// Execute the transaction
} | // Example Parameterized Timelock Implementation
function proposeTimelock(uint256 newTimelock) external onlyAdmin {
// Additional checks and validations
activeTimelock = block.timestamp + newTimelock;
} | reentrancy | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/hassanshakeel13-Analysis.md | 2026-01-02T19:01:42.599807+00:00 | 9a3089ae22492b203c4d98f78364dad33d5d5bfbc092d038177abf0d4803d32f | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | // Example Multi-Signature Implementation
function executeMultiSig(address[] memory signers, bytes memory transaction) external {
require(validateSignatures(signers, transaction), "Invalid signatures");
// Execute the transaction
} | true | // Example Parameterized Timelock Implementation
function proposeTimelock(uint256 newTimelock) external onlyAdmin {
// Additional checks and validations
activeTimelock = block.timestamp + newTimelock;
} | true | true | 5 | ||||||||
c4 | 01-biconomy | Rickard Q | Low | low | # USE A MORE RECENT VERSION OF SOLIDITY
Use a solidity version of at least 0.8.2 to get simple compiler automatic inclining.
Use a solidity version of at least 0.8.3 to get better struct packing and cheaper multiple storage reads.
Use a solidity version of at least 0.8.4 to get custom errors, which are cheaper than rev... | pragma solidity 0.8.12; | 10 - import "./common/Enum.sol";
10 + import {Enum} from "./common/Enum.sol"; | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/Rickard-Q.md | 2026-01-02T18:13:16.551220+00:00 | 9abe31e19589bf7eac0a7f537ce6b910e35ad69d298110688bc45ef15f227d6c | 2 | 0 | 100 | 0 | false | false | true | false | high | pragma solidity 0.8.12; | unknown | 23 | // Code block 1 (unknown):
pragma solidity 0.8.12;
// Code block 2 (unknown):
10 - import "./common/Enum.sol";
10 + import {Enum} from "./common/Enum.sol"; | 2 | false | 0 | pragma solidity 0.8.12; | true | 10 - import "./common/Enum.sol";
10 + import {Enum} from "./common/Enum.sol"; | true | true | 7 | |||||
c4 | 09-ondo | gkrastenov Q | Critical | critical | # Low issues
## [L-01] Elapsed time should be % day == 0
### Impact
When setting a new range, the elapsed time between the start and end of the period should be % DAY == 0 to minimize precision errors in the calculation of elapsed days.
### Recommended Mitigation Steps
Add an additional check for `(lastRange.end - e... | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR));
emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | f (amounts.length == 0) {
revert ArrayLengthIsZero();
} | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/gkrastenov-Q.md | 2026-01-02T18:25:56.489756+00:00 | 9b4a54c92dc497179a5226a241a64f6ddab4507182f0e4e07deb73d66545a92a | 3 | 1 | 289 | 0 | false | false | true | false | high | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR));
emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | solidity | 164 | // Code block 1 (solidity):
emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR));
emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR);
// Code block 2 (unknown):
f (amounts.length == 0) {
revert ArrayLengthIsZero();
}
// Code block 3 (unknown):
if(nu... | 3 | false | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR));
emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | 0 | emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDYAmount * BPS_DENOMINATOR));
emit TransferShares(address(0), msg.sender, _USDYAmount * BPS_DENOMINATOR); | true | f (amounts.length == 0) {
revert ArrayLengthIsZero();
} | true | true | 8 | ||||
c4 | 03-asymmetry | CodeFoxInc G | Low | low | # Gas Optimization
## Gas-01 The `onlyOwner` functions can be set as `payable` to save gas
### Context
[https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/contracts/SafEth/SafEth.sol#L165-L244](https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f68... | ### Proof of Concept
Before:
| After:
| reentrancy | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/CodeFoxInc-G.md | 2026-01-02T18:17:57.514885+00:00 | 9b66143789d578b191bcc877fed0406a03522b2bea45504c4272965f4b328600 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | SafEth.sol#L165-L244 | SafEth.sol | 1 | ### Proof of Concept
Before:
| true | After:
| true | true | 6 | ||||||
c4 | 03-asymmetry | bin2chen Q | Low | low | L-01:`maxSlippage` Slippage does not provide real protection
Currently individual `derivatives` are protected against slippage when exchanging, but the estimated prices are all from the `pool price` of the same transaction
When the price drops sharply, the estimated price also drops sharply, and `minOut` also drops sha... | contract SfrxEth is IDerivative, Initializable, OwnableUpgradeable {
function withdraw(uint256 _amount) external onlyOwner {
...
- uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) *
- (10 ** 18 - maxSlippage)) / 10 ** 18;
+ uint256 minOut = (_amount / 10 ** 18 *
+ ... | contract Reth is IDerivative, Initializable, OwnableUpgradeable {
...
function deposit() external payable onlyOwner returns (uint256) {
- uint256 minOut = ((((rethPerEth * msg.value) / 10 ** 18) *
+ uint256 minOut = (((msg.value / 10 ** 18) *
((10 ** 18 - maxSlippage))) / 10 ** 1... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/bin2chen-Q.md | 2026-01-02T18:18:51.274974+00:00 | 9b6beac1cf49867d89b922e021febe8ad397134e714bd99f977d675d2f2e04f8 | 2 | 2 | 689 | 0 | false | false | true | false | high | contract SfrxEth is IDerivative, Initializable, OwnableUpgradeable {
function withdraw(uint256 _amount) external onlyOwner {
...
- uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) *
- (10 ** 18 - maxSlippage)) / 10 ** 18;
+ uint256 minOut = (_amount / 10 ** 18 *
+ ... | solidity | 366 | // Code block 1 (solidity):
contract SfrxEth is IDerivative, Initializable, OwnableUpgradeable {
function withdraw(uint256 _amount) external onlyOwner {
...
- uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) *
- (10 ** 18 - maxSlippage)) / 10 ** 18;
+ uint256 minOut ... | 2 | false | contract SfrxEth is IDerivative, Initializable, OwnableUpgradeable {
function withdraw(uint256 _amount) external onlyOwner {
...
- uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) *
- (10 ** 18 - maxSlippage)) / 10 ** 18;
+ uint256 minOut = (_amount / 10 ** 18 *
+ ... | 0 | contract SfrxEth is IDerivative, Initializable, OwnableUpgradeable {
function withdraw(uint256 _amount) external onlyOwner {
...
- uint256 minOut = (((ethPerDerivative(_amount) * _amount) / 10 ** 18) *
- (10 ** 18 - maxSlippage)) / 10 ** 18;
+ uint256 minOut = (_amount / 10 ** 18 *
+ ... | true | contract Reth is IDerivative, Initializable, OwnableUpgradeable {
...
function deposit() external payable onlyOwner returns (uint256) {
- uint256 minOut = ((((rethPerEth * msg.value) / 10 ** 18) *
+ uint256 minOut = (((msg.value / 10 ** 18) *
((10 ** 18 - maxSlippage))) / 10 ** 1... | true | true | 7 | ||||
c4 | 01-salty | lilizhu G | Unknown | unknown | Duplicated require()/revert() checks should be refactored to a modifier or function。
**Saves deployment costs**
***There are 4 instances of this issue:***
```jsx
require( userShareForPool( msg.sender, collateralPoolID ) > 0, "User does not have any collateral" );
```
[https://github.com/code-423n4/2024-01-salty/blo... | [https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/stable/CollateralAndLiquidity.sol#L83](https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/stable/CollateralAndLiquidity.sol#L83C12-L83C28)
https://github.com/code-423n4/2024-01-salt... | https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/rewards/SaltRewards.sol#L60
https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/rewards/SaltRewards.sol#L120
| other | https://github.com/code-423n4/2024-01-salty-findings/blob/main/data/lilizhu-G.md | 2026-01-02T19:01:50.707451+00:00 | 9bd55e9652f3a99a6502dc5dab0671597aed825f1605fb4296f25ffc9875ac0f | 4 | 0 | 359 | 8 | false | true | true | false | medium | require( userShareForPool( msg.sender, collateralPoolID ) > 0, "User does not have any collateral" ); | jsx | 101 | // Code block 1 (jsx):
require( userShareForPool( msg.sender, collateralPoolID ) > 0, "User does not have any collateral" );
// Code block 2 (jsx):
require( poolIDs.length == profitsForPools.length, "Incompatible array lengths" );
// Code block 3 (jsx):
require( bytes(country).length == 2, "Country must be an ISO 316... | 4 | false | CollateralAndLiquidity.sol#L83, CollateralAndLiquidity.sol#L98, SaltRewards.sol#L60, SaltRewards.sol#L120, Proposals.sol#L224, Proposals.sol#L233, StakingRewards.sol#L67, StakingRewards.sol#L107 | CollateralAndLiquidity.sol, StakingRewards.sol, Proposals.sol, SaltRewards.sol | 8 | [https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/stable/CollateralAndLiquidity.sol#L83](https://github.com/code-423n4/2024-01-salty/blob/53516c2cdfdfacb662cdea6417c52f23c94d5b5b/src/stable/CollateralAndLiquidity.sol#L83C12-L83C28)
https://github.com/code-423n4/2024-01-salt... | true | false | false | 9 | ||||
c4 | 08-dopex | SBSecurity Q | Critical | critical | ### [Low Risk](#low-risk)
| Count | Title |
| --- | --- |
| [L-01] | When contract is not paused `emergencywithdraw` is not possible |
| Total Low Risk Issues | 1 |
| --- | --- |
### [Non-Critical](#non-critical)
| Count | Title |
| --- | --- |
| [NC-01] | Typos |
| [NC-02] | Place commonly used strings in constant... | File: contracts/amo/UniV3LiquidityAmo.sol
/// @audit Uniswap
11: // Uniswamp V3 | access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/SBSecurity-Q.md | 2026-01-02T18:25:02.712344+00:00 | 9c13ab7bd46abae8397d7e2de5610d4305569a23fd11047155bfa7b15a5e3d41 | 1 | 1 | 84 | 4 | false | true | true | false | high | File: contracts/amo/UniV3LiquidityAmo.sol
/// @audit Uniswap
11: // Uniswamp V3 | solidity | 84 | // Code block 1 (solidity):
File: contracts/amo/UniV3LiquidityAmo.sol
/// @audit Uniswap
11: // Uniswamp V3 | 1 | false | File: contracts/amo/UniV3LiquidityAmo.sol
/// @audit Uniswap
11: // Uniswamp V3 | RdpxReserve.sol#L67, RdpxDecayingBonds.sol#L96, PerpetualAtlanticVault.sol#L222, RdpxV2Core.sol#L164 | PerpetualAtlanticVault.sol, RdpxV2Core.sol, RdpxDecayingBonds.sol, RdpxReserve.sol | 4 | File: contracts/amo/UniV3LiquidityAmo.sol
/// @audit Uniswap
11: // Uniswamp V3 | true | false | false | 6 | ||||
c4 | 11-kelp | shaflow2 Q | Low | low | ## [01]Avoid using deprecated methods
ChainlinkPriceOracle used the latestAnswer() function when requesting a price. But this method has already been enabled, consider using latestRoundData instead.
File:ChainlinkPriceOracle.sol
GitHub:[[37](https://github.com/code-423n4/2023-11-kelp/blob/f751d7594051c0766c7ecd1e68da... | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | oracle | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/shaflow2-Q.md | 2026-01-02T18:28:27.431715+00:00 | 9c289380be142f4a8a74c6bb58272126099b7d2c8c000e601afbe9ed8cbdeb7e | 3 | 3 | 495 | 2 | false | false | true | false | high | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | solidity | 177 | // Code block 1 (solidity):
function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
}
// Code block 2 (solidity):
function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns... | 3 | false | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
}
function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPri... | ChainlinkPriceOracle.sol#L37, AggregatorProxy.sol#L41-L15 | ChainlinkPriceOracle.sol, AggregatorProxy.sol | 2 | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | true | function getAssetPrice(address asset) external view onlySupportedAsset(asset) returns (uint256) {
return AggregatorInterface(assetPriceFeed[asset]).latestAnswer();
} | true | true | 9 | ||
c4 | 03-asymmetry | ArbitraryExecution G | Low | low | ### Redundant external `balanceOf` call
Gas savings in the [`deposit`](https://github.com/code-423n4/2023-03-asymmetry/blob/main/contracts/SafEth/derivatives/SfrxEth.sol#L94) function in `SfrxEth.sol` can be had by returning the return value from the [`submitAndDeposit`](https://github.com/code-423n4/2023-03-asymmetry... | for (uint i = 0; i < derivativeCount; i++)
underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18; | other | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/ArbitraryExecution-G.md | 2026-01-02T18:17:50.369430+00:00 | 9ce2c46a6fa5e91bbe731cd95d61172ed8e6283c559f74c4c9f8a1897cc95d08 | 1 | 0 | 208 | 6 | false | true | true | false | medium | for (uint i = 0; i < derivativeCount; i++)
underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18; | unknown | 208 | // Code block 1 (unknown):
for (uint i = 0; i < derivativeCount; i++)
underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18; | 1 | false | SfrxEth.sol#L94, SfrxEth.sol#L101, SfrxEth.sol#L105, WstEth.sol#L56, WstEth.sol#L57, WstEth.sol#L58 | SfrxEth.sol, WstEth.sol | 6 | for (uint i = 0; i < derivativeCount; i++)
underlyingValue +=
(derivatives[i].ethPerDerivative(derivatives[i].balance()) *
derivatives[i].balance()) /
10 ** 18; | true | false | false | 6 | |||||
c4 | 04-caviar | IceBear Q | Critical | critical | ## Non Critical Issues
| |Issue|Instances|
|-|:-|:-:|
| [N-1](#N-1) | Missing checks for `address(0)` when assigning values to address state variables | 2 |
| [N-2](#N-2) | Use of block.timestamp | 4 |
| [N-3](#N-3) | Maximum Line Length | 103 |
| [N-4](#N-4) | `require()` / `revert()` statements should have descri... | File: Factory.sol
130: privatePoolMetadata = _privatePoolMetadata;
136: privatePoolImplementation = _privatePoolImplementation;
| File: EthRouter.sol
101: if (block.timestamp > deadline && deadline != 0) {
154: if (block.timestamp > deadline && deadline != 0) {
228: if (block.timestamp > deadline && deadline != 0) {
256: if (block.timestamp > deadline && deadline != 0) {
| access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/IceBear-Q.md | 2026-01-02T18:19:41.911175+00:00 | 9ce3d06cc34ca1a2acfc4c68ddd019fbc9b75d6af05175d056849d9c9b96af22 | 1 | 1 | 145 | 1 | false | false | true | false | high | File: Factory.sol
130: privatePoolMetadata = _privatePoolMetadata;
136: privatePoolImplementation = _privatePoolImplementation; | solidity | 145 | // Code block 1 (solidity):
File: Factory.sol
130: privatePoolMetadata = _privatePoolMetadata;
136: privatePoolImplementation = _privatePoolImplementation; | 1 | false | File: Factory.sol
130: privatePoolMetadata = _privatePoolMetadata;
136: privatePoolImplementation = _privatePoolImplementation; | Factory.sol | Factory.sol | 1 | File: Factory.sol
130: privatePoolMetadata = _privatePoolMetadata;
136: privatePoolImplementation = _privatePoolImplementation;
| true | File: EthRouter.sol
101: if (block.timestamp > deadline && deadline != 0) {
154: if (block.timestamp > deadline && deadline != 0) {
228: if (block.timestamp > deadline && deadline != 0) {
256: if (block.timestamp > deadline && deadline != 0) {
| true | true | 7 | ||
c4 | 03-asymmetry | ayden Q | Unknown | unknown | 1.When there is no limit to the range when setting the maxSlippage, if the slippage set exceeds a reasonable range, it may cause losses to the investor's funds
Recommended setting range：maxSlippage %0.5 ~ %2
2.When the weights are set improperly, it may cause losses to investors. Improper weightings can cause the val... | + require(balanceOf(msg.sender)>=_safEthAmount, "insufficient balance"); | slippage | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/ayden-Q.md | 2026-01-02T18:18:50.382410+00:00 | 9cecd40ac622fc5e0a6049e1a2d27c410c024859617543a4c46c46678c013e0e | 1 | 1 | 72 | 1 | false | true | true | false | medium | + require(balanceOf(msg.sender)>=_safEthAmount, "insufficient balance"); | solidity | 72 | // Code block 1 (solidity):
+ require(balanceOf(msg.sender)>=_safEthAmount, "insufficient balance"); | 1 | false | + require(balanceOf(msg.sender)>=_safEthAmount, "insufficient balance"); | SafEth.sol#L108 | SafEth.sol | 1 | + require(balanceOf(msg.sender)>=_safEthAmount, "insufficient balance"); | true | false | false | 5.01 | ||||
c4 | 08-dopex | SAQ G | High | high | ## Summary
### Gas Optimization
no | Issue |Instances||
|-|:-|:-:|:-:|
| [G-01] | Add unchecked{} for subtractions where the operands cannot underflow because of a previous require() or if statement | 2 | - |
| [G-02] | keccak256() should only need to be called on a specific string literal once | 2 | - |
| [G-03] | U... | file: /contracts/core/RdpxV2Core.sol
670 uint256 discountReceivedInWeth = _bondAmount -
671 _wethAmount -
672 rdpxAmountInWeth;
1002 balance = balance - totalWethDelegated;
| file: /contracts/perp-vault/PerpetualAtlanticVault.sol
467 uint256 startTime = lastUpdateTime == 0
? (nextFundingPaymentTimestamp() - fundingDuration)
469 : lastUpdateTime;
| access-control | https://github.com/code-423n4/2023-08-dopex-findings/blob/main/data/SAQ-G.md | 2026-01-02T18:25:01.828769+00:00 | 9d4abe5a5f0c5216a990a233fd5a9fe2536d5fb1d1a634fc97fb0522afd1eb50 | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | file: /contracts/core/RdpxV2Core.sol
670 uint256 discountReceivedInWeth = _bondAmount -
671 _wethAmount -
672 rdpxAmountInWeth;
1002 balance = balance - totalWethDelegated;
| true | file: /contracts/perp-vault/PerpetualAtlanticVault.sol
467 uint256 startTime = lastUpdateTime == 0
? (nextFundingPaymentTimestamp() - fundingDuration)
469 : lastUpdateTime;
| true | true | 5 | ||||||||
c4 | 03-asymmetry | Dewaxindo Q | High | high | ## Potential Impact
This exploit allowed an attacker to “double exercise” ETH value and steal the collateral posted by certain users.
## Proof of Concept
1. In `SafEth.sol` Contract allows anyone to stake their ETH.
https://github.com/code-423n4/2023-03-asymmetry/blob/44b5cd94ebedc187a08884a7f685e950e987261c/contracts... | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
// This is slightly less than ethAmount because slippage
... | uint256 ethAmount = (msg.value * weight) / totalWeight; | slippage | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/Dewaxindo-Q.md | 2026-01-02T18:18:01.567511+00:00 | 9d61637e938df7b0ae623649cb02a021ae22bb7f65d02455bb8fdb57fd179511 | 2 | 0 | 667 | 1 | false | false | true | false | high | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
// This is slightly less than ethAmount because slippage
... | Solidity | 612 | // Code block 1 (Solidity):
for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
// This is slightly less than eth... | 2 | false | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
// This is slightly less than ethAmount because slippage
... | SafEth.sol#L63-L101 | SafEth.sol | 1 | for (uint i = 0; i < derivativeCount; i++) {
uint256 weight = weights[i];
IDerivative derivative = derivatives[i];
if (weight == 0) continue;
uint256 ethAmount = (msg.value * weight) / totalWeight;
// This is slightly less than ethAmount because slippage
... | true | uint256 ethAmount = (msg.value * weight) / totalWeight; | true | true | 8 | ||
c4 | 01-biconomy | Josiah Q | Critical | critical | ## UNUTILIZED LIBRARY
Throughout the code bases, there are instances where functions in Math.sol are re-implemented instead of getting them utilized via library import.
[Math.sol](https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/libs/Math.sol)
```
19: function ... | 19: function max(uint256 a, uint256 b) internal pure returns (uint256) {
26: function min(uint256 a, uint256 b) internal pure returns (uint256) { | 181: function max(uint256 a, uint256 b) internal pure returns (uint256) {
224: require(gasleft() >= max((_tx.targetTxGas * 64) / 63,_tx.targetTxGas + 2500) + 500, "BSA010"); | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/Josiah-Q.md | 2026-01-02T18:13:07.587220+00:00 | 9d76e9f00099a8e262bdd8a3a10b6a658e2ace956e3b01ffb9733efcbbafacff | 4 | 0 | 639 | 5 | false | false | true | false | high | 19: function max(uint256 a, uint256 b) internal pure returns (uint256) {
26: function min(uint256 a, uint256 b) internal pure returns (uint256) { | unknown | 152 | // Code block 1 (unknown):
19: function max(uint256 a, uint256 b) internal pure returns (uint256) {
26: function min(uint256 a, uint256 b) internal pure returns (uint256) {
// Code block 2 (unknown):
181: function max(uint256 a, uint256 b) internal pure returns (uint256) {
224: require(gasleft() >= m... | 4 | false | Math.sol, SmartAccount.sol, UserOperation.sol, EntryPoint.sol, VerifyingSingletonPaymaster.sol#L65 | VerifyingSingletonPaymaster.sol, EntryPoint.sol, Math.sol, SmartAccount.sol, UserOperation.sol | 5 | 19: function max(uint256 a, uint256 b) internal pure returns (uint256) {
26: function min(uint256 a, uint256 b) internal pure returns (uint256) { | true | 181: function max(uint256 a, uint256 b) internal pure returns (uint256) {
224: require(gasleft() >= max((_tx.targetTxGas * 64) / 63,_tx.targetTxGas + 2500) + 500, "BSA010"); | true | true | 10 | |||
c4 | 09-ondo | 2997ms Q | Gas | gas | # 1. Check the ```_amount == 0``` before executing
There are multiple places just checking address but not checking the _amount == 0 in rUSDY.sol file. If we check the amount == 0 first, it can save some gas and no need to execute then next steps.
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/usdy/... | if (t.numberOfApprovalsNeeded <= t.approvers.length) {
return true;
} else {
return false;
} | # 3. Refactor the codes
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/bridge/DestinationBridge.sol#L159 | other | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/2997ms-Q.md | 2026-01-02T18:25:20.099040+00:00 | 9dbfeb50e3cb1867465c0439b52eece58723f74ac94d2ebf3db7420c452661aa | 3 | 0 | 250 | 6 | false | false | true | false | high | if (t.numberOfApprovalsNeeded <= t.approvers.length) {
return true;
} else {
return false;
} | unknown | 112 | // Code block 1 (unknown):
if (t.numberOfApprovalsNeeded <= t.approvers.length) {
return true;
} else {
return false;
}
// Code block 2 (unknown):
# 3. Refactor the codes
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/bridge/DestinationBridge.sol#L159
// Code block 3 (unknown):
Rem... | 3 | false | rUSDY.sol#L245, rUSDY.sol#L277, rUSDY.sol#L304, rUSDY.sol#L488, DestinationBridge.sol#L179-L183, DestinationBridge.sol#L159 | rUSDY.sol, DestinationBridge.sol | 6 | if (t.numberOfApprovalsNeeded <= t.approvers.length) {
return true;
} else {
return false;
} | true | # 3. Refactor the codes
https://github.com/code-423n4/2023-09-ondo/blob/main/contracts/bridge/DestinationBridge.sol#L159 | true | true | 8.68 | |||
c4 | 06-lybra | MrPotatoMagic Q | Critical | critical | ## [N-01] Missing event emission for critical state changes
https://github.com/code-423n4/2023-06-lybra/blob/7b73ef2fbb542b569e182d9abf79be643ca883ee/contracts/lybra/miner/EUSDMiningIncentives.sol#L84
All functions from Line 84-130 do not have events and their emissions even though they change state variables.
```so... | File: contracts/lybra/miner/EUSDMiningIncentives.sol
84: function setToken(address _lbr, address _eslbr) external onlyOwner {
85: LBR = _lbr;
86: esLBR = _eslbr;
87: }
88:
89: function setLBROracle(address _lbrOracle) external onlyOwner {
90: lbrPriceFeed = AggregatorV3Interface(_lbr... | File: contracts/lybra/configuration/LybraConfigurator.sol
98: function initToken(address _eusd, address _peusd) external onlyRole(DAO) {
99: if (address(EUSD) == address(0)) EUSD = IEUSD(_eusd);
100: if (address(peUSD) == address(0)) peUSD = IEUSD(_peusd);
101: }
109: function setMintVault(address ... | access-control | https://github.com/code-423n4/2023-06-lybra-findings/blob/main/data/MrPotatoMagic-Q.md | 2026-01-02T18:22:30.060421+00:00 | 9de7f5d716ef8403ab3516184aec016f7be0fcd8ed81e8bdd614a7f91dfd5390 | 0 | 0 | 0 | 1 | false | false | false | false | medium | 0 | 0 | false | EUSDMiningIncentives.sol#L84 | EUSDMiningIncentives.sol | 1 | File: contracts/lybra/miner/EUSDMiningIncentives.sol
84: function setToken(address _lbr, address _eslbr) external onlyOwner {
85: LBR = _lbr;
86: esLBR = _eslbr;
87: }
88:
89: function setLBROracle(address _lbrOracle) external onlyOwner {
90: lbrPriceFeed = AggregatorV3Interface(_lbr... | true | File: contracts/lybra/configuration/LybraConfigurator.sol
98: function initToken(address _eusd, address _peusd) external onlyRole(DAO) {
99: if (address(EUSD) == address(0)) EUSD = IEUSD(_eusd);
100: if (address(peUSD) == address(0)) peUSD = IEUSD(_peusd);
101: }
109: function setMintVault(address ... | true | true | 6 | ||||||
c4 | 01-ondo | Dinesh11G Q | Low | low |
### 1st BUG
Unsafe ERC20 Operation(s)
#### Impact
Issue Information: [L001](https://github.com/byterocket/c4-common-issues/blob/main/2-Low-Risk.md#l001---unsafe-erc20-operations)
#### Findings:
```
2023-01-ondo/contracts/lending/compound/Comptroller.sol::1695 => comp.transfer(user, amount);
```
#### Tools used
Manua... | 2023-01-ondo/contracts/lending/compound/Comptroller.sol::1695 => comp.transfer(user, amount); | 2023-01-ondo/contracts/cash/external/openzeppelin/contracts/access/AccessControl.sol::4 => pragma solidity ^0.8.0;
2023-01-ondo/contracts/cash/external/openzeppelin/contracts/access/AccessControlEnumerable.sol::4 => pragma solidity ^0.8.0;
2023-01-ondo/contracts/cash/external/openzeppelin/contracts/access/IAccessContro... | reentrancy | https://github.com/code-423n4/2023-01-ondo-findings/blob/main/data/Dinesh11G-Q.md | 2026-01-02T18:14:36.905005+00:00 | 9e094d47ac9c61fff94b8bc83642f8a4df8f5f48193eb0734f38ed305a3536cc | 1 | 0 | 93 | 0 | false | false | true | false | high | 2023-01-ondo/contracts/lending/compound/Comptroller.sol::1695 => comp.transfer(user, amount); | unknown | 93 | // Code block 1 (unknown):
2023-01-ondo/contracts/lending/compound/Comptroller.sol::1695 => comp.transfer(user, amount); | 1 | false | 0 | 2023-01-ondo/contracts/lending/compound/Comptroller.sol::1695 => comp.transfer(user, amount); | true | 2023-01-ondo/contracts/cash/external/openzeppelin/contracts/access/AccessControl.sol::4 => pragma solidity ^0.8.0;
2023-01-ondo/contracts/cash/external/openzeppelin/contracts/access/AccessControlEnumerable.sol::4 => pragma solidity ^0.8.0;
2023-01-ondo/contracts/cash/external/openzeppelin/contracts/access/IAccessContro... | true | true | 6 | |||||
c4 | 02-ethos | Diana Q | Medium | medium | | S No. | Issue | Instances |
|-----|-----|-----|
| [01] | Best practice is to prevent signature malleability | 1
| [02] | Large multiples of ten should use scientific notation | 6
| [03] | Require() should be used instead of assert() | 20
| [04] | Upgradeable contract is missing a \_\_gap[50] storage variable to allow... | File: Ethos-Core/contracts/LUSDToken.sol
287: address recoveredAddress = ecrecover(digest, v, r, s); | File: Ethos-Core/contracts/ActivePool.sol
127: require(_bps <= 10_000, "Invalid BPS value");
145: require(_treasurySplit + _SPSplit + _stakingSplit == 10_000, "Splits must add up to 10000 BPS");
258: vars.percentOfFinalBal = vars.finalBalance == 0 ? uint256(-1) : vars.currentAllocated.mul(10_000).div(vars.finalBalance... | access-control | https://github.com/code-423n4/2023-02-ethos-findings/blob/main/data/Diana-Q.md | 2026-01-02T18:16:09.851084+00:00 | 9e33db528f09bd6e62bd8b1710dbd1d9fc7df898656315bc3f7cb42d59b5b356 | 2 | 0 | 663 | 2 | false | false | true | false | high | File: Ethos-Core/contracts/LUSDToken.sol
287: address recoveredAddress = ecrecover(digest, v, r, s); | unknown | 101 | // Code block 1 (unknown):
File: Ethos-Core/contracts/LUSDToken.sol
287: address recoveredAddress = ecrecover(digest, v, r, s);
// Code block 2 (unknown):
File: Ethos-Core/contracts/ActivePool.sol
127: require(_bps <= 10_000, "Invalid BPS value");
145: require(_treasurySplit + _SPSplit + _stakingSplit == 10_000, "Sp... | 2 | false | LUSDToken.sol, ActivePool.sol | LUSDToken.sol, ActivePool.sol | 2 | File: Ethos-Core/contracts/LUSDToken.sol
287: address recoveredAddress = ecrecover(digest, v, r, s); | true | File: Ethos-Core/contracts/ActivePool.sol
127: require(_bps <= 10_000, "Invalid BPS value");
145: require(_treasurySplit + _SPSplit + _stakingSplit == 10_000, "Splits must add up to 10000 BPS");
258: vars.percentOfFinalBal = vars.finalBalance == 0 ? uint256(-1) : vars.currentAllocated.mul(10_000).div(vars.finalBalance... | true | true | 8 | |||
c4 | 03-asymmetry | IceBear Q | Critical | critical | ## Non Critical Issues
| |Issue|Instances|
|-|:-|:-:|
| [N-1](#N-1) | Large multiples of ten should use scientific notation rather than decimal literals, for readability | 21 |
| [N-2](#N-2) | Unused imports | 6 |
| [N-3](#N-3) | Unused parameters | 2 |
| [N-4](#N-4) | For modern and more readable code; update import ... | File: SafEth/SafEth.sol
54: minAmount = 5 * 10 ** 17; // initializing with .5 ETH as minimum
55: maxAmount = 200 * 10 ** 18; // initializing with 200 ETH as maximum
75: 10 ** 18;
80: preDepositPrice = 10 ** 18; // initializes with a price of 1
81: else preDeposit... | File: SafEth/derivatives/Reth.sol
44: maxSlippage = (1 * 10 ** 16); // 1%
171: uint rethPerEth = (10 ** 36) / poolPrice();
173: uint256 minOut = ((((rethPerEth * msg.value) / 10 ** 18) *
174: ((10 ** 18 - maxSlippage))) / 10 ** 18);
214: RocketTokenRE... | access-control | https://github.com/code-423n4/2023-03-asymmetry-findings/blob/main/data/IceBear-Q.md | 2026-01-02T18:18:07.897507+00:00 | 9e49d91cc5c7071624832fc7adfca85024d168f74df4b01c293eb7098b9101a0 | 1 | 1 | 504 | 1 | false | false | true | false | high | File: SafEth/SafEth.sol
54: minAmount = 5 * 10 ** 17; // initializing with .5 ETH as minimum
55: maxAmount = 200 * 10 ** 18; // initializing with 200 ETH as maximum
75: 10 ** 18;
80: preDepositPrice = 10 ** 18; // initializes with a price of 1
81: else preDeposit... | solidity | 504 | // Code block 1 (solidity):
File: SafEth/SafEth.sol
54: minAmount = 5 * 10 ** 17; // initializing with .5 ETH as minimum
55: maxAmount = 200 * 10 ** 18; // initializing with 200 ETH as maximum
75: 10 ** 18;
80: preDepositPrice = 10 ** 18; // initializes with a price of 1
... | 1 | false | File: SafEth/SafEth.sol
54: minAmount = 5 * 10 ** 17; // initializing with .5 ETH as minimum
55: maxAmount = 200 * 10 ** 18; // initializing with 200 ETH as maximum
75: 10 ** 18;
80: preDepositPrice = 10 ** 18; // initializes with a price of 1
81: else preDeposit... | SafEth.sol | SafEth.sol | 1 | File: SafEth/SafEth.sol
54: minAmount = 5 * 10 ** 17; // initializing with .5 ETH as minimum
55: maxAmount = 200 * 10 ** 18; // initializing with 200 ETH as maximum
75: 10 ** 18;
80: preDepositPrice = 10 ** 18; // initializes with a price of 1
81: else preDeposit... | true | File: SafEth/derivatives/Reth.sol
44: maxSlippage = (1 * 10 ** 16); // 1%
171: uint rethPerEth = (10 ** 36) / poolPrice();
173: uint256 minOut = ((((rethPerEth * msg.value) / 10 ** 18) *
174: ((10 ** 18 - maxSlippage))) / 10 ** 18);
214: RocketTokenRE... | true | true | 7 | ||
c4 | 11-kelp | LinKenji Q | Low | low | ## Titlte: Suboptimal Inheritance in `ChainlinkPriceOracle`.
## Impact
The `ChainlinkPriceOracle` contract inherits from `IPriceFetcher` instead of directly implementing the `ILRTOracle` interface. This is confusing and doesn't fully capture the intent that this is an oracle implementation.
## Proof of Concept
**[C... | /// @title ChainlinkPriceOracle Contract
/// @notice contract that fetches the exchange rate of assets from chainlink price feeds
contract ChainlinkPriceOracle is IPriceFetcher, LRTConfigRoleChecker, Initializable {
// ...
} | contract ChainlinkPriceOracle is ILRTOracle, LRTConfigRoleChecker, Initializable {
// ...
} | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/LinKenji-Q.md | 2026-01-02T18:27:30.915844+00:00 | 9e6c0943e7ad9426ac360cf2db6d99f2a5e7b0ce263fd7e2efe3b674ecc9f5d1 | 2 | 2 | 324 | 1 | false | false | true | false | high | /// @title ChainlinkPriceOracle Contract
/// @notice contract that fetches the exchange rate of assets from chainlink price feeds
contract ChainlinkPriceOracle is IPriceFetcher, LRTConfigRoleChecker, Initializable {
// ...
} | solidity | 229 | // Code block 1 (solidity):
/// @title ChainlinkPriceOracle Contract
/// @notice contract that fetches the exchange rate of assets from chainlink price feeds
contract ChainlinkPriceOracle is IPriceFetcher, LRTConfigRoleChecker, Initializable {
// ...
}
// Code block 2 (solidity):
contract ChainlinkPriceOracle is ... | 2 | false | /// @title ChainlinkPriceOracle Contract
/// @notice contract that fetches the exchange rate of assets from chainlink price feeds
contract ChainlinkPriceOracle is IPriceFetcher, LRTConfigRoleChecker, Initializable {
// ...
}
contract ChainlinkPriceOracle is ILRTOracle, LRTConfigRoleChecker, Initializable {
// ... | ChainlinkPriceOracle.sol#L15-L19 | ChainlinkPriceOracle.sol | 1 | /// @title ChainlinkPriceOracle Contract
/// @notice contract that fetches the exchange rate of assets from chainlink price feeds
contract ChainlinkPriceOracle is IPriceFetcher, LRTConfigRoleChecker, Initializable {
// ...
} | true | contract ChainlinkPriceOracle is ILRTOracle, LRTConfigRoleChecker, Initializable {
// ...
} | true | true | 8 | ||
c4 | 04-caviar | Jorgect G | Low | low | # GAS REPORT
## G-1 Use internal functions insted of public function.
internal functions are likely to be less gas expensive than public functions. This is because internal functions can only be called from within the same contract and do not need to go through the EVM's message-passing system, which can add additio... | contract Factory.sol line 136
function setPrivatePoolImplementation(address _privatePoolImplementation) public onlyOwner {
privatePoolImplementation = _privatePoolImplementation;
} | contract PrivateFacotry.sol line 877
function sumWeightsAndValidateProof(
uint256[] memory tokenIds,
uint256[] memory tokenWeights,
MerkleMultiProof memory proof
) public view returns (uint256) | access-control | https://github.com/code-423n4/2023-04-caviar-findings/blob/main/data/Jorgect-G.md | 2026-01-02T18:19:44.135774+00:00 | 9e889eb6598b1d75912e7ddf8f0ed23815059a7ace6b18b9b07b357327a30828 | 4 | 0 | 831 | 0 | false | false | true | false | high | contract Factory.sol line 136
function setPrivatePoolImplementation(address _privatePoolImplementation) public onlyOwner {
privatePoolImplementation = _privatePoolImplementation;
} | unknown | 192 | // Code block 1 (unknown):
contract Factory.sol line 136
function setPrivatePoolImplementation(address _privatePoolImplementation) public onlyOwner {
privatePoolImplementation = _privatePoolImplementation;
}
// Code block 2 (unknown):
contract PrivateFacotry.sol line 877
function sumWeightsAndValidateProo... | 4 | false | 0 | contract Factory.sol line 136
function setPrivatePoolImplementation(address _privatePoolImplementation) public onlyOwner {
privatePoolImplementation = _privatePoolImplementation;
} | true | contract PrivateFacotry.sol line 877
function sumWeightsAndValidateProof(
uint256[] memory tokenIds,
uint256[] memory tokenWeights,
MerkleMultiProof memory proof
) public view returns (uint256) | true | true | 9 | |||||
c4 | 05-ajna | Audit_Avengers G | Medium | medium | ## Gas Optimizations
```markdown
| | Issue | Instances | Gas |
| :-------------: | :-----------------------------------------------------------: | :-------: | :-----: |
| [GAS-1](#GAS-1) | Variable can be left undeclared in memory ... | <a name="GAS-1"></a>
### [GAS-1] Variable can be left undeclared in memory
_Instances (1)_:
| [Link to code](https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/GrantFund.sol#L48)
_Recommended: As `findMechanismOfProposal()` returns a struct of FundingMechanism
It is better to directly compare `mechanism == findMechanismOfProposal(proposalId_)` instead.
<hr/>
<a name="GAS-2"></a>
###... | access-control | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/Audit_Avengers-G.md | 2026-01-02T18:20:53.129575+00:00 | 9e9a128715d25161e880bf6e34b157a7eef735f76373b982659cb1a36d869039 | 3 | 2 | 1,326 | 1 | false | false | true | false | high | | | Issue | Instances | Gas |
| :-------------: | :-----------------------------------------------------------: | :-------: | :-----: |
| [GAS-1](#GAS-1) | Variable can be left undeclared in memory | 1 | 3 |
| ... | markdown | 741 | // Code block 1 (markdown):
| | Issue | Instances | Gas |
| :-------------: | :-----------------------------------------------------------: | :-------: | :-----: |
| [GAS-1](#GAS-1) | Variable can be left undeclared in memory ... | 3 | false | File: /ajna-grants/src/grants/GrantFund.sol
45: function state(uint256 proposalId_)
external
view
override
returns (ProposalState)
{
FundingMechanism mechanism = findMechanismOfProposal(proposalId_);
return
mechanism == FundingMechani... | GrantFund.sol#L48 | GrantFund.sol | 1 | <a name="GAS-1"></a>
### [GAS-1] Variable can be left undeclared in memory
_Instances (1)_:
| true | [Link to code](https://github.com/code-423n4/2023-05-ajna/blob/main/ajna-grants/src/grants/GrantFund.sol#L48)
_Recommended: As `findMechanismOfProposal()` returns a struct of FundingMechanism
It is better to directly compare `mechanism == findMechanismOfProposal(proposalId_)` instead.
<hr/>
<a name="GAS-2"></a>
###... | true | true | 9 | ||
c4 | 11-kelp | leegh Q | High | high | # [N-01] Incorrect variable comment.
The comment should be "rsETH address" instead of "cbETH address".
```solidity
File: src/LRTConfig.sol
40: /// @param rsETH_ cbETH address
```
[L40](https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTConfig.sol#L40)
# [N-02] Use same role limit for update asset informat... | File: src/LRTConfig.sol
40: /// @param rsETH_ cbETH address | File: src/LRTConfig.sol
109: function updateAssetStrategy(
110: address asset,
111: address strategy
112: )
113: external
114: onlyRole(DEFAULT_ADMIN_ROLE) | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/leegh-Q.md | 2026-01-02T18:28:13.173915+00:00 | 9ebcf889c0efd9bb41a5c3473bb6e6d0cdcdccf5259f9210a6160ab467037612 | 2 | 2 | 252 | 2 | false | false | true | false | high | File: src/LRTConfig.sol
40: /// @param rsETH_ cbETH address | solidity | 63 | // Code block 1 (solidity):
File: src/LRTConfig.sol
40: /// @param rsETH_ cbETH address
// Code block 2 (solidity):
File: src/LRTConfig.sol
109: function updateAssetStrategy(
110: address asset,
111: address strategy
112: )
113: external
114: onlyRole(DEFAULT_ADMIN_ROLE) | 2 | false | File: src/LRTConfig.sol
40: /// @param rsETH_ cbETH address
File: src/LRTConfig.sol
109: function updateAssetStrategy(
110: address asset,
111: address strategy
112: )
113: external
114: onlyRole(DEFAULT_ADMIN_ROLE) | LRTConfig.sol#L40, LRTConfig.sol#L109-L114 | LRTConfig.sol | 2 | File: src/LRTConfig.sol
40: /// @param rsETH_ cbETH address | true | File: src/LRTConfig.sol
109: function updateAssetStrategy(
110: address asset,
111: address strategy
112: )
113: external
114: onlyRole(DEFAULT_ADMIN_ROLE) | true | true | 6.67 | ||
c4 | 11-kelp | hihen G | High | high | # Gas Report
## Summary
Total **27 instances** over **5 issues**with **27395** gas saved:
|ID|Issue|Instances|Gas|
|:--:|:---|:--:|:--:|
| [[G-01]](#g-01-using-private-for-constants-saves-gas) | Using `private` for constants saves gas | 8 | 27248 |
| [[G-02]](#g-02-do-not-cache-state-variables-that-are-used-only-onc... | 21: bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE"); | 7: bytes32 public constant R_ETH_TOKEN = keccak256("R_ETH_TOKEN");
9: bytes32 public constant ST_ETH_TOKEN = keccak256("ST_ETH_TOKEN");
11: bytes32 public constant CB_ETH_TOKEN = keccak256("CB_ETH_TOKEN");
14: bytes32 public constant LRT_ORACLE = keccak256("LRT_ORACLE");
15: bytes32 public const... | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/hihen-G.md | 2026-01-02T18:28:05.939026+00:00 | 9ec478a5e84e27682119e79ae6f96a696ec98d260fa390987ba404238a603f57 | 1 | 1 | 71 | 4 | false | false | true | false | high | 21: bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE"); | solidity | 71 | // Code block 1 (solidity):
21: bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE"); | 1 | false | 21: bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE"); | FraxlendPair.sol#L156-L178, RSETH.sol#L21, LRTConstants.sol#L7, LRTConstants.sol#L9 | FraxlendPair.sol, RSETH.sol, LRTConstants.sol | 4 | 21: bytes32 public constant MINTER_ROLE = keccak256("MINTER_ROLE"); | true | 7: bytes32 public constant R_ETH_TOKEN = keccak256("R_ETH_TOKEN");
9: bytes32 public constant ST_ETH_TOKEN = keccak256("ST_ETH_TOKEN");
11: bytes32 public constant CB_ETH_TOKEN = keccak256("CB_ETH_TOKEN");
14: bytes32 public constant LRT_ORACLE = keccak256("LRT_ORACLE");
15: bytes32 public const... | true | true | 7 | ||
c4 | 05-ajna | Praise Q | Low | low | [L-01] ## _hashProposal() doesn't check to ensure the amounts of Eth to send and calldata to send equals the number of addresses to call
```
function _hashProposal(
address[] memory targets_,
uint256[] memory values_,
bytes[] memory calldatas_,
bytes32 descriptionHash_
) internal... | function _hashProposal(
address[] memory targets_,
uint256[] memory values_,
bytes[] memory calldatas_,
bytes32 descriptionHash_
) internal pure returns (uint256 proposalId_) {
proposalId_ = uint256(keccak256(abi.encode(targets_, values_, calldatas_, descriptionHash_)));
... | other | https://github.com/code-423n4/2023-05-ajna-findings/blob/main/data/Praise-Q.md | 2026-01-02T18:21:07.508923+00:00 | 9f773bb0c09c2c94367d0abd12d0c375823cc4163fd3243ed89ae2699b774547 | 1 | 0 | 321 | 1 | false | true | true | false | medium | function _hashProposal(
address[] memory targets_,
uint256[] memory values_,
bytes[] memory calldatas_,
bytes32 descriptionHash_
) internal pure returns (uint256 proposalId_) {
proposalId_ = uint256(keccak256(abi.encode(targets_, values_, calldatas_, descriptionHash_)));
... | unknown | 321 | // Code block 1 (unknown):
function _hashProposal(
address[] memory targets_,
uint256[] memory values_,
bytes[] memory calldatas_,
bytes32 descriptionHash_
) internal pure returns (uint256 proposalId_) {
proposalId_ = uint256(keccak256(abi.encode(targets_, values_, calldatas_... | 1 | false | Funding.sol#L152-L159 | Funding.sol | 1 | function _hashProposal(
address[] memory targets_,
uint256[] memory values_,
bytes[] memory calldatas_,
bytes32 descriptionHash_
) internal pure returns (uint256 proposalId_) {
proposalId_ = uint256(keccak256(abi.encode(targets_, values_, calldatas_, descriptionHash_)));
... | true | false | false | 4.22 | |||||
c4 | 01-biconomy | saneryee G | Medium | medium | # Gas Optimizations Report
| | Issue | Instances |
| ------- | :--------------------------------------------------------------------------------------------------------------------------... | 222: result += 16; | 271: result += 16; | access-control | https://github.com/code-423n4/2023-01-biconomy-findings/blob/main/data/saneryee-G.md | 2026-01-02T18:14:06.527246+00:00 | 9f977880d6579ff2fee9c0f0544707a7fccddd6044370bbe88c00561a6127ab5 | 2 | 2 | 42 | 2 | false | false | true | false | high | 222: result += 16; | solidity | 21 | // Code block 1 (solidity):
222: result += 16;
// Code block 2 (solidity):
271: result += 16; | 2 | false | 222: result += 16;
271: result += 16; | Math.sol#L222, Math.sol#L271 | Math.sol | 2 | 222: result += 16; | true | 271: result += 16; | true | true | 8 | ||
c4 | 09-ondo | twcctop Q | QA | qa | 1:
wrap:error emit message
```solidity
function wrap(uint256 _USDYAmount) external whenNotPaused {
require(_USDYAmount > 0, "rUSDY: can't wrap zero USDY tokens");
_mintShares(msg.sender, _USDYAmount * BPS_DENOMINATOR);
usdy.transferFrom(msg.sender, address(this), _USDYAmount);
@> emit Transfer(a... | function wrap(uint256 _USDYAmount) external whenNotPaused {
require(_USDYAmount > 0, "rUSDY: can't wrap zero USDY tokens");
_mintShares(msg.sender, _USDYAmount * BPS_DENOMINATOR);
usdy.transferFrom(msg.sender, address(this), _USDYAmount);
@> emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDY... | emit Transfer(msg.sender,address(this) , getRUSDYByShares(_USDYAmount)); | dos | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/twcctop-Q.md | 2026-01-02T18:26:19.817786+00:00 | 9fb0b6b7d6112e257da8722c0b8c5fd12b34980259b4e3b4bcb708f9a1fcc695 | 2 | 0 | 197 | 1 | false | false | true | false | high | shouldn't transfer from zero,should be | unknown | 38 | // Code block 1 (unknown):
shouldn't transfer from zero,should be
// Code block 2 (unknown):
2.
_burnShares:error emit message
https://github.com/code-423n4/2023-09-ondo/blob/3362e1252f3a54943e2517460e5a7988388bc821/contracts/usdy/rUSDY.sol#L575-L610 | 2 | false | rUSDY.sol#L575-L610 | rUSDY.sol | 1 | function wrap(uint256 _USDYAmount) external whenNotPaused {
require(_USDYAmount > 0, "rUSDY: can't wrap zero USDY tokens");
_mintShares(msg.sender, _USDYAmount * BPS_DENOMINATOR);
usdy.transferFrom(msg.sender, address(this), _USDYAmount);
@> emit Transfer(address(0), msg.sender, getRUSDYByShares(_USDY... | true | emit Transfer(msg.sender,address(this) , getRUSDYByShares(_USDYAmount)); | true | true | 8 | |||
c4 | 02-ai-arena | Benterkiii Q | Informational | informational | # Public functions that hasn't used internally can be external
Instances (4)
https://github.com/code-423n4/2024-02-ai-arena/blob/cd1a0e6d1b40168657d1aaee8223dc050e15f8cc/src/AAMintPass.sol#L145
```solidity
function totalSupply() public view returns (uint256) {
return numTokensOutstanding;
}
```
https:... | function totalSupply() public view returns (uint256) {
return numTokensOutstanding;
} | function contractURI() public pure returns (string memory) {
return "ipfs://bafybeifdvzwsjpxrkbyhqpz3y57j7nwm3eyyc3feqppqggslea3g5kk3jq";
} | other | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/Benterkiii-Q.md | 2026-01-02T19:02:17.045253+00:00 | 9fbd9723d407f95ef5983b281c752b88ee181666310f0732be3889ad96d8e0f6 | 4 | 4 | 304 | 4 | false | false | true | false | high | function totalSupply() public view returns (uint256) {
return numTokensOutstanding;
} | solidity | 97 | // Code block 1 (solidity):
function totalSupply() public view returns (uint256) {
return numTokensOutstanding;
}
// Code block 2 (solidity):
function contractURI() public pure returns (string memory) {
return "ipfs://bafybeifdvzwsjpxrkbyhqpz3y57j7nwm3eyyc3feqppqggslea3g5kk3jq";
}
// Code bloc... | 4 | false | function totalSupply() public view returns (uint256) {
return numTokensOutstanding;
}
function contractURI() public pure returns (string memory) {
return "ipfs://bafybeifdvzwsjpxrkbyhqpz3y57j7nwm3eyyc3feqppqggslea3g5kk3jq";
}
function fighterCreatedEmitter(
function viewFighterInfo( | AAMintPass.sol#L145, AAMintPass.sol#L150, FighterOps.sol#L53, FighterOps.sol#L79 | AAMintPass.sol, FighterOps.sol | 4 | function totalSupply() public view returns (uint256) {
return numTokensOutstanding;
} | true | function contractURI() public pure returns (string memory) {
return "ipfs://bafybeifdvzwsjpxrkbyhqpz3y57j7nwm3eyyc3feqppqggslea3g5kk3jq";
} | true | true | 8.86 | ||
c4 | 02-ai-arena | Rolezn Q | High | high | ### QA Issues
| # |Issue|
|-|-|
| [QA‑1](#QA‑1) | Max rerolls can be increased until max `uint8`
| [QA‑2](#QA‑2) | Fighter generation is limited to max `uint8`
| [QA‑3](#QA‑3) | It is not possible to remove staker after calling `FighterFarm.addStaker()`
| [QA‑4](#QA ... | /// @notice The maximum amount of rerolls for each fighter.
uint8[2] public maxRerollsAllowed = [3, 3]; | 132: maxRerollsAllowed[fighterType] += 1;
| access-control | https://github.com/code-423n4/2024-02-ai-arena-findings/blob/main/data/Rolezn-Q.md | 2026-01-02T19:02:41.604228+00:00 | 9ff6df5537febb3faf48e45b9a1cbc7c75e0324a94cb3a2e4505f6a088bed9fc | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | /// @notice The maximum amount of rerolls for each fighter.
uint8[2] public maxRerollsAllowed = [3, 3]; | true | 132: maxRerollsAllowed[fighterType] += 1;
| true | true | 5 | ||||||||
c4 | 09-ondo | 0xta G | Medium | medium | # Gas Optimization
# Summary
| Number | Gas Optimization | Context |
| :----: | :------------------------------------------------------------------------------------------------------- | :-----: |
| [G-01] | Use assembly to perfor... | File: contracts/bridge/DestinationBridge.sol
323 uint256 balance = IRWALike(_token).balanceOf(address(this));
324 IRWALike(_token).transfer(owner(), balance); | File: contracts/bridge/DestinationBridge.sol
210 function addApprover(address approver) external onlyOwner {
220 function removeApprover(address approver) external onlyOwner {
234 function addChainSupport(
string calldata srcChain,
string calldata srcContractAddress
) external onlyOwner {
255 fun... | access-control | https://github.com/code-423n4/2023-09-ondo-findings/blob/main/data/0xta-G.md | 2026-01-02T18:25:19.207027+00:00 | a024dbacae1bfb125cc38448800643c2dd356c8eb8efe6dfbb917ce1fc32b78b | 0 | 0 | 0 | 0 | false | false | false | false | medium | 0 | 0 | false | 0 | File: contracts/bridge/DestinationBridge.sol
323 uint256 balance = IRWALike(_token).balanceOf(address(this));
324 IRWALike(_token).transfer(owner(), balance); | true | File: contracts/bridge/DestinationBridge.sol
210 function addApprover(address approver) external onlyOwner {
220 function removeApprover(address approver) external onlyOwner {
234 function addChainSupport(
string calldata srcChain,
string calldata srcContractAddress
) external onlyOwner {
255 fun... | true | true | 5 | ||||||||
c4 | 11-kelp | tala7985 G | High | high | ## \[G‑1\] Newer versions of solidity are more gas efficient
The solidity language continues to pursue more efficient gas optimization schemes. Adopting a <ins>newer version of solidity</ins> can be more gas efficient.
```
pragma solidity 0.8.21;
```
https://github.com/code-423n4/2023-11-kelp/blob/main/src/LRTConfig... | pragma solidity 0.8.21; | function initialize( | access-control | https://github.com/code-423n4/2023-11-kelp-findings/blob/main/data/tala7985-G.md | 2026-01-02T18:28:30.341483+00:00 | a02d9ecaf195ca4eec3bc218c4892c52f2c533b865c45cffc0aeeba5804e4294 | 6 | 0 | 318 | 11 | false | false | true | false | high | pragma solidity 0.8.21; | unknown | 23 | // Code block 1 (unknown):
pragma solidity 0.8.21;
// Code block 2 (unknown):
function initialize(
// Code block 3 (unknown):
function initialize(address lrtConfigAddr) external initializer {
// Code block 4 (unknown):
function initialize(address lrtConfigAddr) external initializer {
// Code block 5 (unknown):
func... | 6 | false | LRTConfig.sol#L2, LRTDepositPool.sol#L2, NodeDelegator.sol#L2, LRTOracle.sol#L2, RSETH.sol#L2, ChainlinkPriceOracle.sol#L2, LRTConfigRoleChecker.sol#L2, UtilLib.sol#L2, LRTConfig.sol#L41, LRTDepositPool.sol#L31, LRTOracle.sol#L29 | LRTConfigRoleChecker.sol, LRTOracle.sol, RSETH.sol, NodeDelegator.sol, ChainlinkPriceOracle.sol, UtilLib.sol, LRTConfig.sol, LRTDepositPool.sol | 11 | pragma solidity 0.8.21; | true | function initialize( | true | true | 12 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.