Upscaling produces silent output due to silent failure on limited storage buffer support

#1
by alecccdd - opened

Setup: i9-14900HX, RTX 4080 mobile, Win 11, Chrome 141
Error in console: The number of storage buffers (27) in the Compute stage exceeds the maximum per-stage limit (10).

Haven't looked too deep into the code yet, but I'd guess that somehow around lines 374-405 the CPU is only choosen if no GPU-backend is available, otherwise the GPU is always used. However in i.e. my setup, a maximum of 10 storage buffers is set, so it silently fails rather than showing some error or falling back to CPU. My suggestion would be to either check adapter.limits.maxStorageBuffersPerShaderStagemanually or to explicitly request the amount of buffers the model needs to make the entire backend-creation fail on purpose on unsupported gpu-backends.

Both approaches worked in my limited local testing - happy to write a PR or provide further information :)

Hey, thanks! You're absolutely welcome to make a PR.

Sign up or log in to comment