Hugging Face's logo

jinaai
/
jina-embeddings-v3

Feature Extraction
Transformers
PyTorch
ONNX
Safetensors
sentence-transformers
sentence-similarity
mteb
custom_code
Eval Results (legacy)
Eval Results
🇪🇺 Region: EU
Model card Files
xet
 Community
138

Add compatibility with Sentence Transformers v3.2.0

#45
by tomaarsen HF Staff - opened
base: refs/heads/main
←
from: refs/pr/45
Discussion Files changed
+9
-0
tomaarsen
•
edited Oct 11, 2024

Hello!

Pull Request overview

  • Add **kwargs to Transformer to avoid issues when ST adds new arguments

Details

The Sentence Transformers v3.2.0 release added a backend keyword to its Transformer module, which your custom module didn't expect. I've added **kwargs to avoid future issues.

Solves #44, cc @botkop

  • Tom Aarsen
Add **kwargs to Transformer to avoid issues when ST adds new arguments40df5888
botkop

wow lightning Tom
thank you!
bwang0911

thanks @tomaarsen ! will you publish this branch and make it ready to review?

bwang0911 changed pull request status to open
tomaarsen

Apologies, I didn't realise that I didn't already publish it. It should be ready for review.
bwang0911

merged, thanks @tomaarsen and thanks @botkop for reporting! I'll close both discussions!

bwang0911 changed pull request status to merged
botkop

fastest fix I ever came across
cheers to both!

Sign up or log in to comment