Integrate with Sentence Transformers v5.4
#60
by tomaarsen HF Staff - opened
Hello!
Pull Request overview
- Ensure compatibility with the upcoming Sentence Transformers version
Details
Sentence Transformers v5.4 will release soon, and it will distribute the cache_dir parameter in the model_kwargs, config_kwargs, etc. This breaks with your custom Sentence Transformers module, as cache_dir=cache_dir, **model_kwargs results in 2 parameters being passed for cache_dir:
TypeError: __init__() got multiple values for keyword argument 'cache_dir'
This PR prevents this issue, while also preserving functionality for older versions. Feel free to merge this PR already, so it works immediately on day-0 when the new Sentence Transformers version releases.
- Tom Aarsen
tomaarsen changed pull request status to open
michael-guenther changed pull request status to merged