repo
stringclasses
17 values
instance_id
stringlengths
10
43
base_commit
stringlengths
40
40
patch
stringlengths
530
154k
test_patch
stringlengths
377
76.4k
problem_statement
stringlengths
97
33k
hints_text
stringlengths
3
18.4k
created_at
stringdate
2020-06-16 21:09:47
2025-04-20 13:41:07
version
stringclasses
4 values
FAIL_TO_PASS
stringlengths
2
3.71k
PASS_TO_PASS
stringlengths
2
5.8k
AvaloniaUI/Avalonia
avaloniaui__avalonia-16575
4c2d9fcda7bb703600e4146cefb790c5cbbb3bb6
diff --git a/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs b/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs index 0edc7984949..f0dde6925d5 100644 --- a/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs +++ b/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs @@ -479,7 +479,7 @@ protected virtual void ...
diff --git a/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs b/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs index 24f246d188d..10139be0d45 100644 --- a/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs +++ b/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs @@ -62,6 +62,24 @@ public void ...
NumericUpDown - Changes to FormatString are not reflected immediately ### Describe the bug When FormatString binding value is changed, the new format is applied only after focusing or interacting with the control. ### To Reproduce 1. Create NumericUpDown with binding to FormatString. 2. Change bound value 3....
null
2024-08-02T08:41:45Z
0.1
['Avalonia.Controls.UnitTests.NumericUpDownTests.FormatString_Is_Applied_Immediately']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-16564
b1489aaca28d3f35cb69c33f1202a62a08c3f70a
diff --git a/src/Avalonia.Controls/ToolTipService.cs b/src/Avalonia.Controls/ToolTipService.cs index d01114be6fb..d99d185bedc 100644 --- a/src/Avalonia.Controls/ToolTipService.cs +++ b/src/Avalonia.Controls/ToolTipService.cs @@ -78,7 +78,7 @@ public void Update(IInputRoot root, Visual? candidateToolTipHost) { ...
diff --git a/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs b/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs index 6199a208720..12ecbb0c68f 100644 --- a/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs @@ -1,9 +1,12 @@ using System; using System.Collectio...
The ToolTip Popup not close when pointer exit the control,Is that a feature or bug? I have a new problem when set 'OverlayPopups =true',the ToolTip Popup not close when pointer exit the control,Is that a feature or bug? ![tooltip](https://github.com/user-attachments/assets/5035f341-8a81-4c46-99b6-ddcb89e03f21) @maxk...
null
2024-08-01T12:24:10Z
0.1
['Avalonia.Controls.UnitTests.ToolTipTests_Popup.Should_Close_When_Control_Detaches', 'Avalonia.Controls.UnitTests.ToolTipTests_Popup.Should_Close_When_Tip_Is_Opened_And_Detached_From_Visual_Tree', 'Avalonia.Controls.UnitTests.ToolTipTests_Popup.Should_Open_On_Pointer_Enter', 'Avalonia.Controls.UnitTests.ToolTipTests_P...
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-16557
98e60e89c7d49c7b2d2028953e95d3ac56503930
diff --git a/src/Avalonia.Base/Input/Navigation/XYFocus.Impl.cs b/src/Avalonia.Base/Input/Navigation/XYFocus.Impl.cs index 867e80f1762..b2a79aa3b96 100644 --- a/src/Avalonia.Base/Input/Navigation/XYFocus.Impl.cs +++ b/src/Avalonia.Base/Input/Navigation/XYFocus.Impl.cs @@ -92,6 +92,11 @@ internal void UpdateManifolds( ...
diff --git a/tests/Avalonia.Base.UnitTests/Input/KeyboardNavigationTests_XY.cs b/tests/Avalonia.Base.UnitTests/Input/KeyboardNavigationTests_XY.cs index 2ea3a51908f..fa5286a8d80 100644 --- a/tests/Avalonia.Base.UnitTests/Input/KeyboardNavigationTests_XY.cs +++ b/tests/Avalonia.Base.UnitTests/Input/KeyboardNavigationTes...
XYFocus cannot easily be restricted to branches of the visual tree. ### Describe the bug At present when using XYFocus, the search for valid candidate controls to focus next always starts at the TopLevel. While the search does restrict its results to controls that allow XYFocus, there's no simple way for a developer ...
One more idea for me actually, implement ICustomKeyboardNavigation somewhere appropriate and use that to trap XYFocus within a tree. EDIT: Won't work. None of the XYFocus methods that would be needed are public. They're all internal / private. https://learn.microsoft.com/en-us/windows/apps/design/input/focus-navig...
2024-07-31T23:43:32Z
0.1
['Avalonia.Base.UnitTests.Input.KeyboardNavigationTests_XY.Cannot_Focus_Across_XYFocus_Boundaries']
['Avalonia.Base.UnitTests.Input.KeyboardNavigationTests_XY.RectilinearDistance_Focus_Depending_On_Direction', 'Avalonia.Base.UnitTests.Input.KeyboardNavigationTests_XY.NavigationDirectionDistance_Focus_Depending_On_Direction', 'Avalonia.Base.UnitTests.Input.KeyboardNavigationTests_XY.Clipped_Element_Should_Not_Be_Focus...
AvaloniaUI/Avalonia
avaloniaui__avalonia-16214
6ea50d95fb725c726fa8dfa38282457144be1bb0
diff --git a/src/Avalonia.Base/Data/BindingOperations.cs b/src/Avalonia.Base/Data/BindingOperations.cs index 9170fbfaa06..b0a97e5c000 100644 --- a/src/Avalonia.Base/Data/BindingOperations.cs +++ b/src/Avalonia.Base/Data/BindingOperations.cs @@ -101,6 +101,25 @@ public static IDisposable Apply( return Apply...
diff --git a/tests/Avalonia.Base.UnitTests/Data/BindingOperationsTests.cs b/tests/Avalonia.Base.UnitTests/Data/BindingOperationsTests.cs new file mode 100644 index 00000000000..ac39e2b56d3 --- /dev/null +++ b/tests/Avalonia.Base.UnitTests/Data/BindingOperationsTests.cs @@ -0,0 +1,147 @@ +using Avalonia.Controls; +usin...
Allow accessing BindingExpressions to make proper use of `UpdateSourceTrigger=Explicit` ### Is your feature request related to a problem? Please describe. I'm trying to use the new `UpdateSourceTrigger=Explicit` parameter for some bindings. At the moment, I can't seem to find a way to access BindingExpressions f...
@ThePBone which version did you test? 11.1 beta may have that API now I tested 11.1 beta-1. `UpdateSourceTrigger.Explicit` and `BindingExpressionBase.UpdateSource` are available as mentioned in PR #13970. However, I don't think there is currently a way to obtain a reference to a BindingExpressionBase for an existing...
2024-07-03T09:54:01Z
0.1
['Avalonia.Base.UnitTests.Data.BindingOperationsTests.GetBindingExpressionBase_Returns_Binding_When_Bound_Via_ControlTheme_TemplateBinding', 'Avalonia.Base.UnitTests.Data.BindingOperationsTests.GetBindingExpressionBase_Returns_Null_When_Not_Bound', 'Avalonia.Base.UnitTests.Data.BindingOperationsTests.GetBindingExpressi...
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-16168
3b235f9aa82dbcae024c0e75486e7d91df1be13d
diff --git a/src/Avalonia.Controls/Utils/RealizedStackElements.cs b/src/Avalonia.Controls/Utils/RealizedStackElements.cs index b8f088f0909..fab10b0ad96 100644 --- a/src/Avalonia.Controls/Utils/RealizedStackElements.cs +++ b/src/Avalonia.Controls/Utils/RealizedStackElements.cs @@ -1,5 +1,6 @@ using System; using Syst...
diff --git a/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs b/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs index 37d0f2ced45..d1ee1662f05 100644 --- a/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs +++ b/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTest...
Listbox virtualized with zoom in/out (using LayoutTransformControl) issues ### Describe the bug If we use a ListBox with a LayoutTransformControl in the ListBoxItem to be able to zoom in/out, there are some issues : 1) If I slide to an item, then zoom out and scroll to the first item, there are a space left before ...
Do you have any clue (to make a PR) for the resolution of this bug ?
2024-06-29T11:22:15Z
0.1
['Avalonia.Controls.UnitTests.VirtualizingStackPanelTests.Extent_And_Offset_Should_Be_Updated_When_Containers_Resize', 'Avalonia.Controls.UnitTests.VirtualizingStackPanelTests.Focused_Container_Is_Positioned_Correctly_when_Container_Size_Change_Causes_It_To_Be_Moved_Out_Of_Visible_Viewport', 'Avalonia.Controls.UnitTest...
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-16102
143399f65abc8b97b479b1f8ed9d74b1a6a65303
diff --git a/src/Avalonia.Base/Data/Core/UntypedObservableBindingExpression.cs b/src/Avalonia.Base/Data/Core/UntypedObservableBindingExpression.cs index 1e26caa0512..df529d8675e 100644 --- a/src/Avalonia.Base/Data/Core/UntypedObservableBindingExpression.cs +++ b/src/Avalonia.Base/Data/Core/UntypedObservableBindingExpre...
diff --git a/tests/Avalonia.Markup.UnitTests/Data/MultiBindingTests.cs b/tests/Avalonia.Markup.UnitTests/Data/MultiBindingTests.cs index f6a4437a9ef..0a20c25b15f 100644 --- a/tests/Avalonia.Markup.UnitTests/Data/MultiBindingTests.cs +++ b/tests/Avalonia.Markup.UnitTests/Data/MultiBindingTests.cs @@ -180,6 +180,28 @@ pu...
Regression in 11.1: MultiValueConverter returning BindingNotification throws InvalidCastException ### Describe the bug In my application I have several `IMultiValueConverter`s that return a `BindingNotification` when values can't be converted. The [documentation](https://docs.avaloniaui.net/docs/guides/data-binding/ho...
Definitely looks like a regression introduced by the binding system refactor, will investigate. Not sure if this is a showstopper and needs to be fixed for 11.1.0 or whether it can wait for 11.1.1 though. > Definitely looks like a regression introduced by the binding system refactor, will investigate. > > Not sur...
2024-06-24T13:15:19Z
0.1
['Avalonia.Markup.UnitTests.Data.MultiBindingTests.Converter_Can_Return_BindingNotification']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-16090
34558f25e0489e4c231c6217dfcf0c949b9ac5c6
diff --git a/native/Avalonia.Native/src/OSX/Avalonia.Native.OSX.xcodeproj/project.pbxproj b/native/Avalonia.Native/src/OSX/Avalonia.Native.OSX.xcodeproj/project.pbxproj index 734f126a1b2..9a67ee0161e 100644 --- a/native/Avalonia.Native/src/OSX/Avalonia.Native.OSX.xcodeproj/project.pbxproj +++ b/native/Avalonia.Native/s...
diff --git a/tests/Avalonia.Base.UnitTests/Utilities/UriExtensionsTests.cs b/tests/Avalonia.Base.UnitTests/Utilities/UriExtensionsTests.cs index b648b0d1782..83380bf6a02 100644 --- a/tests/Avalonia.Base.UnitTests/Utilities/UriExtensionsTests.cs +++ b/tests/Avalonia.Base.UnitTests/Utilities/UriExtensionsTests.cs @@ -36,...
Mac App Store SandBox File Access with Bookmarks feature **Is your feature request related to a problem? Please describe.** OSX native lib can have support for managing file access bookmarks in sandbox. **What is sandbox bookmarks?** By default your app in sandbox have no access to any file in the system. You ca...
I've found wtf is `.idl` and how to edit COM API between OSX native lib and Avalonia.Native. So I've started to implementing this feature. This PR #6540 already contains COM API changes.
2024-06-23T00:55:39Z
0.1
[]
['Avalonia.Base.UnitTests.Utilities.UriExtensionsTests.Assembly_Name_From_Empty_Query_Not_Parsed', 'Avalonia.Base.UnitTests.Utilities.UriExtensionsTests.Assembly_Name_From_Query_Parsed', 'Avalonia.Base.UnitTests.Utilities.UriExtensionsTests.Should_Convert_File_Path_To_Uri_And_Back']
AvaloniaUI/Avalonia
avaloniaui__avalonia-15726
38d810b36f9f3f914e4b3f03908729f1a76ebd0f
diff --git a/src/Avalonia.Base/Animation/Animators/Animator`1.cs b/src/Avalonia.Base/Animation/Animators/Animator`1.cs index 8a4469d0209..954b62f9bca 100644 --- a/src/Avalonia.Base/Animation/Animators/Animator`1.cs +++ b/src/Avalonia.Base/Animation/Animators/Animator`1.cs @@ -28,57 +28,70 @@ protected T InterpolationHa...
diff --git a/tests/Avalonia.Base.UnitTests/Animation/KeySplineTests.cs b/tests/Avalonia.Base.UnitTests/Animation/KeySplineTests.cs index 61e8103bd59..8af1f7ec020 100644 --- a/tests/Avalonia.Base.UnitTests/Animation/KeySplineTests.cs +++ b/tests/Avalonia.Base.UnitTests/Animation/KeySplineTests.cs @@ -213,5 +213,109 @@ p...
Translate animation flickers control visibility when using certain easings as of v11.0.6 ### Describe the bug We originally built a feature into our user prompt dialog overlay where if the user clicked into an area outside of the dialog, we would visually "shake" the dialog with a quick animation to indicate the opera...
null
2024-05-14T17:52:20Z
0.1
['Avalonia.Base.UnitTests.Animation.KeySplineTests.KeySpline_Progress_Less_Than_Zero_Or_Greater_Than_One_Works_With_Single_KeyFrame', 'Avalonia.Base.UnitTests.Animation.KeySplineTests.KeySpline_Progress_Less_Than_Zero_Or_Greater_Than_One_Works']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-15722
a60c59083d2e451f076afee020b2aefdb93d4d90
diff --git a/src/Avalonia.Base/Data/BindingNotification.cs b/src/Avalonia.Base/Data/BindingNotification.cs index 0c940a14610..a3a2e0c2b05 100644 --- a/src/Avalonia.Base/Data/BindingNotification.cs +++ b/src/Avalonia.Base/Data/BindingNotification.cs @@ -57,7 +57,6 @@ public class BindingNotification /// <param ...
diff --git a/tests/Avalonia.Base.UnitTests/Data/Core/BindingExpressionTests.DataValidation.cs b/tests/Avalonia.Base.UnitTests/Data/Core/BindingExpressionTests.DataValidation.cs index bedf24bd6d7..8e1865f2092 100644 --- a/tests/Avalonia.Base.UnitTests/Data/Core/BindingExpressionTests.DataValidation.cs +++ b/tests/Avalon...
11.1.0-beta1 stackoverflow on property set (SetProperty), works in 11.0.10 ### Describe the bug This code below is stack overflowing on 11.1.0-beta1. If I roll back to 11.0.10 the code works fine. ``` CSharp [Required(ErrorMessage = "Name is required!")] public string Name { get => _name; set => SetProperty(...
Stacktrace (of stackoverflow) and SetProperty implementation are required to help here. Or minimal repro project. @BobbyCannon I have the same issue, check if your App.axaml.cs's `OnFrameworkInitializationCompleted()` has following code: ```csharp BindingPlugins.DataValidators.RemoveAt(0); ``` @maxkatz6 May...
2024-05-14T13:41:27Z
0.1
['Avalonia.Base.UnitTests.Data.Core.BindingExpressionTests+Reflection.Updates_Data_Validation_For_Required_DataAnnotation', 'Avalonia.Base.UnitTests.Data.Core.BindingExpressionTests+Compiled.Handles_Indei_And_DataAnnotations_On_Same_Class']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-15667
d1cdb29ba019f16f98dc44821bb51b24abc5d93c
diff --git a/api/Avalonia.nupkg.xml b/api/Avalonia.nupkg.xml index 6b79f6f33b0..13b9724778f 100644 --- a/api/Avalonia.nupkg.xml +++ b/api/Avalonia.nupkg.xml @@ -19,6 +19,12 @@ <Left>baseline/netstandard2.0/Avalonia.Base.dll</Left> <Right>target/netstandard2.0/Avalonia.Base.dll</Right> </Suppression> + <Su...
diff --git a/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs b/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs index fb88c983436..38bbc875c50 100644 --- a/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs +++ b/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs @@ ...
Add CustomPopupPlacementCallback support ### Is your feature request related to a problem? Please describe. WPF has a [CustomPopupPlacementCallback](https://learn.microsoft.com/en-us/dotnet/api/system.windows.controls.primitives.custompopupplacementcallback?view=windowsdesktop-8.0) delegate that can be assigned to the...
The API is designed to be Wayland-compatible and is designed against `xdg_positioner` object from `xdg-shell` protocol. Any placement API that requires access to global screen coordinates won't be Wayland-compatible. To position your popup relative to the top-left corner of a control use OffsetX/OffsetY properti...
2024-05-09T13:46:13Z
0.1
['Avalonia.Controls.UnitTests.Primitives.PopupTestsWithPopupRoot.Popup_Attached_To_Adorner_Respects_Adorner_Position']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-15640
0d4fbe1880c201adb773c57c02ed5d7e81e7e653
diff --git a/src/Avalonia.Base/Data/Core/TargetTypeConverter.cs b/src/Avalonia.Base/Data/Core/TargetTypeConverter.cs index 2efc5b42bdc..57018bff55e 100644 --- a/src/Avalonia.Base/Data/Core/TargetTypeConverter.cs +++ b/src/Avalonia.Base/Data/Core/TargetTypeConverter.cs @@ -76,16 +76,32 @@ public override bool TryConvert...
diff --git a/tests/Avalonia.Controls.UnitTests/TextBoxTests_DataValidation.cs b/tests/Avalonia.Controls.UnitTests/TextBoxTests_DataValidation.cs index 295fc192d76..0eaa3092e98 100644 --- a/tests/Avalonia.Controls.UnitTests/TextBoxTests_DataValidation.cs +++ b/tests/Avalonia.Controls.UnitTests/TextBoxTests_DataValidatio...
Regression: Exceptions thrown in TargetTypeConverter crash the app instead of going to the controls DataValidation ### Describe the bug Exceptions thrown in TargetTypeConverter crash the whole app, instead of being caught into control's Data Validation. ### To Reproduce ``` <TextBox Text="{CompiledBinding Value}" /...
null
2024-05-07T09:11:37Z
0.1
['Avalonia.Controls.UnitTests.TextBoxTests_DataValidation.CompiledBindings_TypeConverter_Exceptions_Should_Set_DataValidationErrors_HasErrors']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-15423
d5ca06ff2432dcc4671a4ed795a5ce6a5cdadddc
diff --git a/src/Avalonia.ReactiveUI/ReactiveUserControl.cs b/src/Avalonia.ReactiveUI/ReactiveUserControl.cs index 94090f26141..76a4f29b161 100644 --- a/src/Avalonia.ReactiveUI/ReactiveUserControl.cs +++ b/src/Avalonia.ReactiveUI/ReactiveUserControl.cs @@ -48,14 +48,15 @@ protected override void OnPropertyChanged(Avalo...
diff --git a/tests/Avalonia.ReactiveUI.UnitTests/ReactiveUserControlTest.cs b/tests/Avalonia.ReactiveUI.UnitTests/ReactiveUserControlTest.cs index 4bf999bed01..67790789e31 100644 --- a/tests/Avalonia.ReactiveUI.UnitTests/ReactiveUserControlTest.cs +++ b/tests/Avalonia.ReactiveUI.UnitTests/ReactiveUserControlTest.cs @@ ...
Using ReactiveUserControl in XAML crashes the application ### Describe the bug Using any control that inherits from `ReactiveUsercontrol<T>` in XAML or code behind immediately crashes the application if `DataContext` is set on a parent control and the data object cannot be cast to `T`. <details> <summary>Stack tra...
Adding `&& typeof(TViewModel).IsAssignableFrom(change.NewValue)` here should fix it: https://github.com/AvaloniaUI/Avalonia/blob/bad2e8dbdcd3bd4ffd75a35fe94c20ff8ca2b880/src/Avalonia.ReactiveUI/ReactiveUserControl.cs#L51 The same fix should be applied to `ReactiveWindow`. It won't pass through converters, but ...
2024-04-18T01:19:23Z
0.1
['Avalonia.ReactiveUI.UnitTests.ReactiveUserControlTest.Should_Not_Inherit_DataContext_Of_Wrong_Type']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-14928
0b72cdb512187c8a4eded47e864e1194111e621f
diff --git a/samples/ControlCatalog/Pages/ToolTipPage.xaml b/samples/ControlCatalog/Pages/ToolTipPage.xaml index 013c176bca5..fa40bc1a0fa 100644 --- a/samples/ControlCatalog/Pages/ToolTipPage.xaml +++ b/samples/ControlCatalog/Pages/ToolTipPage.xaml @@ -5,10 +5,14 @@ Spacing="4"> <TextBlock Cla...
diff --git a/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs b/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs index 98a131752a4..ddfc2b7b722 100644 --- a/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs +++ b/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs @@ -1,45 +1,26 @@ using System; -using System.Reactive...
Display ToolTip on Control with IsEnabled=False Right now it seems impossible to display a ToolTip properly if the control it's attached to isn't enabled. WPF has [ToolTipService.ShowOnDisabled](https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.tooltipservice.showondisabled?view=netcore-3.1) cibuil...
A little more complicated than it might seem because we rely on `PointerEnter` to show tooltips and that event isn't fired when a control is disabled. WPF hooks into the [global `InputManager`](https://github.com/dotnet/wpf/blob/4a3c96a6c6548c4d37ccdcbb44712ef3c147b58f/src/Microsoft.DotNet.Wpf/src/PresentationFramework...
2024-03-12T12:45:39Z
0.1
[]
['Avalonia.Controls.UnitTests.ToolTipTests.Should_Close_When_Control_Detaches', 'Avalonia.Controls.UnitTests.ToolTipTests.Should_Close_When_Tip_Is_Opened_And_Detached_From_Visual_Tree', 'Avalonia.Controls.UnitTests.ToolTipTests.Should_Open_On_Pointer_Enter', 'Avalonia.Controls.UnitTests.ToolTipTests.Content_Should_Upda...
AvaloniaUI/Avalonia
avaloniaui__avalonia-14913
86bfc26aceeb3000f47e3a67c39daa78deb0acda
diff --git a/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs b/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs index 04f6b1d8a12..aa62eaaf065 100644 --- a/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs +++ b/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs @@ -285,8 +285,12 @...
diff --git a/tests/Avalonia.Controls.UnitTests/Presenters/ScrollContentPresenterTests.cs b/tests/Avalonia.Controls.UnitTests/Presenters/ScrollContentPresenterTests.cs index 274bee15284..e70ab520439 100644 --- a/tests/Avalonia.Controls.UnitTests/Presenters/ScrollContentPresenterTests.cs +++ b/tests/Avalonia.Controls.Uni...
Rendering artifacts in ListView ## Describe the bug I am experiencing strange rendering artefacts when using a `ListView`. ## To Reproduce Steps to reproduce the behavior: See attached minimal example. [ListViewAutoScrollBug.zip](https://github.com/AvaloniaUI/Avalonia/files/13349670/ListViewAutoScrollBug.zip) ...
Seems same as [#12744](https://github.com/AvaloniaUI/Avalonia/issues/12744). consider using TreeDataGrid > consider using TreeDataGrid I can‘t say for sure but I think I had basically the same issue with TreeDataGrid. That‘s was one of two reasons to go with this approach. I can also confirm TreeDataGrid has virtual...
2024-03-11T10:44:01Z
0.1
['Avalonia.Controls.UnitTests.Presenters.ScrollContentPresenterTests.Nested_Presenters_Should_Scroll_Outer_When_Viewports_Are_Close']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-14900
27c49a8b2200e00efb744b7132c2774edf2ea366
diff --git a/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs b/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs index 4a54c1b35c8..04f6b1d8a12 100644 --- a/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs +++ b/src/Avalonia.Controls/Presenters/ScrollContentPresenter.cs @@ -259,38 +259,34 ...
diff --git a/tests/Avalonia.Controls.UnitTests/Presenters/ScrollContentPresenterTests.cs b/tests/Avalonia.Controls.UnitTests/Presenters/ScrollContentPresenterTests.cs index 30628b1af85..274bee15284 100644 --- a/tests/Avalonia.Controls.UnitTests/Presenters/ScrollContentPresenterTests.cs +++ b/tests/Avalonia.Controls.Uni...
Rendering artifacts in ListView ## Describe the bug I am experiencing strange rendering artefacts when using a `ListView`. ## To Reproduce Steps to reproduce the behavior: See attached minimal example. [ListViewAutoScrollBug.zip](https://github.com/AvaloniaUI/Avalonia/files/13349670/ListViewAutoScrollBug.zip) ...
Seems same as [#12744](https://github.com/AvaloniaUI/Avalonia/issues/12744). consider using TreeDataGrid > consider using TreeDataGrid I can‘t say for sure but I think I had basically the same issue with TreeDataGrid. That‘s was one of two reasons to go with this approach. I can also confirm TreeDataGrid has virtual...
2024-03-10T01:14:05Z
0.1
['Avalonia.Controls.UnitTests.Presenters.ScrollContentPresenterTests.Nested_Presenters_Should_Scroll_Outer_When_Content_Exceeds_Viewport']
['Avalonia.Controls.UnitTests.Presenters.ScrollContentPresenterTests.BringDescendantIntoView_Should_Update_Offset', 'Avalonia.Controls.UnitTests.Presenters.ScrollContentPresenterTests.BringDescendantIntoView_Should_Handle_Child_Margin']
AvaloniaUI/Avalonia
avaloniaui__avalonia-14838
3e51397884a6a2b9f7bb474668bdf28e22e136d8
diff --git a/src/Markup/Avalonia.Markup/Markup/Parsers/BindingExpressionGrammar.cs b/src/Markup/Avalonia.Markup/Markup/Parsers/BindingExpressionGrammar.cs index 5a4a56b7469..179ba009c02 100644 --- a/src/Markup/Avalonia.Markup/Markup/Parsers/BindingExpressionGrammar.cs +++ b/src/Markup/Avalonia.Markup/Markup/Parsers/Bin...
diff --git a/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_AttachedProperty.cs b/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_AttachedProperty.cs index 4c9333c42b3..cc2dc35f0bf 100644 --- a/tests/Avalonia.Markup.UnitTests/Parsers/ExpressionObserverBuilderTests_Attached...
Parsing binding expression with type cast of attached property fails ## Describe the bug I'm attempting to bind to a property of the adorned element in a template set to the adorner property. To do this with compiled bindings a type cast is required but that fails to parse. ## To Reproduce ```xml <TextBox> ...
@appel1 great findings and I like that you also directly added a unit test. If you want to, you may try to make a PR out of it. This may help: - https://github.com/AvaloniaUI/Avalonia/wiki/Debugging-the-XAML-compiler - https://github.com/AvaloniaUI/Avalonia/blob/master/Documentation/build.md
2024-03-06T07:23:05Z
0.1
['Avalonia.Markup.UnitTests.Parsers.ExpressionObserverBuilderTests_AttachedProperty.Should_Get_Chained_Attached_Property_Value_With_TypeCast']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-14439
499e09efc9288d2dc6b9b674c9fedd3d6e5243ec
diff --git a/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs b/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs index 4029782772b..c0ea14037cd 100644 --- a/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs +++ b/src/Avalonia.Controls/Primitives/PopupPositio...
diff --git a/tests/Avalonia.Controls.UnitTests/Primitives/PopupTests.cs b/tests/Avalonia.Controls.UnitTests/Primitives/PopupTests.cs index 5a0c60dff68..8398da59a5c 100644 --- a/tests/Avalonia.Controls.UnitTests/Primitives/PopupTests.cs +++ b/tests/Avalonia.Controls.UnitTests/Primitives/PopupTests.cs @@ -1143,6 +1143,53...
Popup with a placement target pops up in a wrong position with compositor in adorner layer **Describe the bug** Popups are displayed in a wrong position, with compositor enabled, with Placement Target specified (pointer position works) when the parent control is an adorner layer. **To Reproduce** Open a popup (i.e...
I've checked this again in latest stable Avalonia 11.0.0, but sadly it is still bugged. Sorry for the ping, but let me ping @kekekeks as I believe if anybody might have an idea where the problem is, that's Nikita. I've debugged the code and I was able to find the offending line: in Avalonia 0.10 the bounds here were...
2024-02-01T13:01:51Z
0.1
['Avalonia.Controls.UnitTests.Primitives.PopupTests.Popup_Attached_To_Adorner_Respects_Adorner_Position']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-14048
0bde86b4577fbf2580dbffc3892de2e06e74b95d
diff --git a/samples/ControlCatalog/Pages/BorderPage.xaml b/samples/ControlCatalog/Pages/BorderPage.xaml index 7ec7e81e805..4c2384d6869 100644 --- a/samples/ControlCatalog/Pages/BorderPage.xaml +++ b/samples/ControlCatalog/Pages/BorderPage.xaml @@ -5,6 +5,9 @@ d:DesignWidth="400" x:Class="Co...
diff --git a/tests/Avalonia.Base.UnitTests/Media/GeometryBuilderTests.cs b/tests/Avalonia.Base.UnitTests/Media/GeometryBuilderTests.cs new file mode 100644 index 00000000000..a7d390bffea --- /dev/null +++ b/tests/Avalonia.Base.UnitTests/Media/GeometryBuilderTests.cs @@ -0,0 +1,61 @@ +using Avalonia.Media; +using Xunit...
Add RadiusX/RadiusY to RectangleGeometry In WPF RectangleGeometry has `RadiusX` and `RadiusY` properties to get rounded corners. I'd like to use a rounded rectangle as a clipping to a control in Avalonia. In [WPF](https://learn.microsoft.com/en-us/dotnet/desktop/wpf/graphics-multimedia/how-to-round-the-corners-of...
I might get to this over the holidays along with the BackgroundSizing work. What is required here is also similar to what I did for Rectangle itself and I can use it there too. This is coming in with BackgroundSizing. It's sharing the same code a few other places. I think this is not quite a bug but something that can ...
2023-12-27T21:02:32Z
0.2
['Avalonia.Base.UnitTests.Media.GeometryBuilderTests.CalculateRoundedCornersRectangleWinUI_InnerBorderEdge_Borders_Larger_Than_Corners_Test', 'Avalonia.Base.UnitTests.Media.GeometryBuilderTests.CalculateRoundedCornersRectangleWinUI_OuterBorderEdge_Borders_Larger_Than_Corners_Test']
[]
AvaloniaUI/Avalonia
avaloniaui__avalonia-14013
2a7b5568b7f61fe6df9c46a05bf1c9d474c9290e
diff --git a/src/Avalonia.Base/Media/PathMarkupParser.cs b/src/Avalonia.Base/Media/PathMarkupParser.cs index 7b9fdf9330d..fa790c17c00 100644 --- a/src/Avalonia.Base/Media/PathMarkupParser.cs +++ b/src/Avalonia.Base/Media/PathMarkupParser.cs @@ -259,7 +259,7 @@ private void AddLine(ref ReadOnlySpan<char> span, bool rela...
diff --git a/tests/Avalonia.Base.UnitTests/Media/PathMarkupParserTests.cs b/tests/Avalonia.Base.UnitTests/Media/PathMarkupParserTests.cs index c829690eb4a..755ab7ff25a 100644 --- a/tests/Avalonia.Base.UnitTests/Media/PathMarkupParserTests.cs +++ b/tests/Avalonia.Base.UnitTests/Media/PathMarkupParserTests.cs @@ -319,5 +...
Text alignment mismatch when using icon fonts ## Describe the bug Text alignment mismatch when using icon fonts such as SegoeFluentIcons. ## To Reproduce Check out `icon-font-err` branch for both repo: [Avalonia Test](https://github.com/laolarou726/TypesettingErrorDemo) [WPF Test](https://github.com/laolar...
Two notes here: 1. This may be a Skia issue 2. I recall UWP/WinUI has a similar problem that remains unfixed: https://github.com/microsoft/microsoft-ui-xaml/issues/3077. This was not for fonts though, just paths. I saw this issue as well with a piece of art I made myself. It almost seemed like it was using rela...
2023-12-21T18:06:39Z
0.2
['Avalonia.Base.UnitTests.Media.PathMarkupParserTests.Should_Handle_StartPoint_After_Empty_Figure']
['Avalonia.Base.UnitTests.Media.PathMarkupParserTests.Parsed_Geometry_ToString_Should_Produce_Valid_Value', 'Avalonia.Base.UnitTests.Media.PathMarkupParserTests.Parses_Implicit_Line_Command_After_Move', 'Avalonia.Base.UnitTests.Media.PathMarkupParserTests.Should_AlwaysEndFigure', 'Avalonia.Base.UnitTests.Media.PathMark...
AvaloniaUI/Avalonia
avaloniaui__avalonia-13969
79b79bbc707f4172ffe7d92d84211cf4a6195d58
diff --git a/src/Avalonia.Base/Styling/ControlTheme.cs b/src/Avalonia.Base/Styling/ControlTheme.cs index 75a3beb9078..6cd09e18081 100644 --- a/src/Avalonia.Base/Styling/ControlTheme.cs +++ b/src/Avalonia.Base/Styling/ControlTheme.cs @@ -48,7 +48,7 @@ internal SelectorMatchResult TryAttach(StyledElement target, FrameTyp...
diff --git a/tests/Avalonia.Base.UnitTests/Styling/StyleTests.cs b/tests/Avalonia.Base.UnitTests/Styling/StyleTests.cs index 52bee42d9d9..b44078caeb5 100644 --- a/tests/Avalonia.Base.UnitTests/Styling/StyleTests.cs +++ b/tests/Avalonia.Base.UnitTests/Styling/StyleTests.cs @@ -1029,6 +1029,28 @@ public void Animations_W...
Styles are mistakenly activated when multiple selectors (with and without activators) are combined on the same Style instance ### Discussed in https://github.com/AvaloniaUI/Avalonia/discussions/13908 Having complex and mixed selector like `Button.SingleLineButton, ToggleButton.SingleLineButton, ComboBox.SingleLineCo...
Workaround: create separated styles with and without activators (with and without classes/pseudoclasses/properties selectors).
2023-12-15T17:08:54Z
0.2
['Avalonia.Base.UnitTests.Styling.StyleTests.Should_Not_Share_Instance_When_Or_Selector_Is_Present']
['Avalonia.Base.UnitTests.Styling.StyleTests.Animations_Should_Be_Activated', 'Avalonia.Base.UnitTests.Styling.StyleTests.Inactive_Bindings_Should_Not_Be_Made_Active_During_Style_Attach', 'Avalonia.Base.UnitTests.Styling.StyleTests.Style_With_Only_Type_Selector_Should_Update_Value', 'Avalonia.Base.UnitTests.Styling.Sty...
AvaloniaUI/Avalonia
avaloniaui__avalonia-13188
b83a5eb8b737f5c9239fadce7860264ea736a4b0
diff --git a/src/Avalonia.Base/Layout/LayoutManager.cs b/src/Avalonia.Base/Layout/LayoutManager.cs index dee16191d69..cffda3e84c7 100644 --- a/src/Avalonia.Base/Layout/LayoutManager.cs +++ b/src/Avalonia.Base/Layout/LayoutManager.cs @@ -423,12 +423,16 @@ private void CalculateEffectiveViewport(Visual target, Visual con...
diff --git a/tests/Avalonia.Base.UnitTests/Layout/LayoutableTests_EffectiveViewportChanged.cs b/tests/Avalonia.Base.UnitTests/Layout/LayoutableTests_EffectiveViewportChanged.cs index 5a493cb741a..63eb6589ca1 100644 --- a/tests/Avalonia.Base.UnitTests/Layout/LayoutableTests_EffectiveViewportChanged.cs +++ b/tests/Avalon...
VirtualizingStackPanel with animated ScaleTransform starting from 0 crashes the renderer **Describe the bug** When we add ListBox with VirtualizingStackPanel and animation for ScaleTransform (which starting from 0) to visual tree, it will crash the renderer. But with the ListBox'es, which initially in the content (...
null
2023-10-09T20:46:56Z
0.3
['Avalonia.Base.UnitTests.Layout.LayoutableTests_EffectiveViewportChanged.Zero_ScaleTransform_Sets_Empty_EffectiveViewport']
['Avalonia.Base.UnitTests.Layout.LayoutableTests_EffectiveViewportChanged.Invalidating_In_Handler_Causes_Layout_To_Be_Rerun_Before_LayoutUpdated_Raised', 'Avalonia.Base.UnitTests.Layout.LayoutableTests_EffectiveViewportChanged.Rotate_Transform_On_Parent_Affects_EffectiveViewport', 'Avalonia.Base.UnitTests.Layout.Layout...
AvaloniaUI/Avalonia
avaloniaui__avalonia-13185
bbe4ad875515aa69b916f654d0046251fcba5a05
diff --git a/src/Avalonia.Base/Input/AccessKeyHandler.cs b/src/Avalonia.Base/Input/AccessKeyHandler.cs index 38692d8b77d..fe5e2c46a21 100644 --- a/src/Avalonia.Base/Input/AccessKeyHandler.cs +++ b/src/Avalonia.Base/Input/AccessKeyHandler.cs @@ -183,7 +183,8 @@ protected virtual void OnKeyDown(object? sender, KeyEventAr...
diff --git a/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs b/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs index 4d8ece4ddaa..ed1061e85a9 100644 --- a/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs +++ b/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs @@ -165,6 +...
AccessKeyHandler should not match on disabled elements ## Describe the bug Multiple input elements can be registered with the same access key. When the `AccessKeyHandler` attempts to locate the element associated with a key, the logic does not consider the enabled state of the element and will return the first match e...
null
2023-10-09T19:04:42Z
0.3
['Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Not_Raise_AccessKeyPressed_For_Registered_Access_Key_When_Not_Effectively_Enabled']
['Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Raise_Key_Events_For_Alt_Key_With_MainMenu', 'Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Raise_Key_Events_For_Unregistered_Access_Key_With_MainMenu', 'Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Open_MainMenu_On_Alt_KeyUp', 'Ava...
AvaloniaUI/Avalonia
avaloniaui__avalonia-12666
f6809ad4e6b1f68d7cb1d797e5bd0d147910ce36
diff --git a/src/Avalonia.Base/Input/GestureRecognizers/GestureRecognizerCollection.cs b/src/Avalonia.Base/Input/GestureRecognizers/GestureRecognizerCollection.cs index 05dce8214b1..74e8061292e 100644 --- a/src/Avalonia.Base/Input/GestureRecognizers/GestureRecognizerCollection.cs +++ b/src/Avalonia.Base/Input/GestureRe...
diff --git a/tests/Avalonia.Base.UnitTests/Input/GesturesTests.cs b/tests/Avalonia.Base.UnitTests/Input/GesturesTests.cs index 14fa242146f..a2afdd0af27 100644 --- a/tests/Avalonia.Base.UnitTests/Input/GesturesTests.cs +++ b/tests/Avalonia.Base.UnitTests/Input/GesturesTests.cs @@ -487,6 +487,40 @@ public void Pinched_Sh...
[11.0.0] Android touch control breaks after swiping back **Describe the bug** When using the "swipe back" function on modern android devices (see here: [Image](https://image.winudf.com/v2/image1/dGhyZWVkcm9pZC5nZXN0dXJlLmNvbnRyb2xfc2NyZWVuXzBfMTU1NTk1NTYwNV8wODk/screen-0.webp?fakeurl=1&type=.webp)) the device detects ...
null
2023-08-25T14:07:31Z
0.3
['Avalonia.Base.UnitTests.Input.GesturesTests.Gestures_Should_Be_Cancelled_When_Pointer_Capture_Is_Lost']
['Avalonia.Base.UnitTests.Input.GesturesTests.Hold_Should_Be_Raised_After_Hold_Duration', 'Avalonia.Base.UnitTests.Input.GesturesTests.Tapped_Should_Follow_Pointer_Pressed_Released', 'Avalonia.Base.UnitTests.Input.GesturesTests.RightTapped_Should_Be_Raised_For_Right_Button', 'Avalonia.Base.UnitTests.Input.GesturesTests...
restsharp/RestSharp
restsharp__restsharp-2241
dd52ff6cd18cce2a74475f97374d431280ac10cf
diff --git a/Directory.Packages.props b/Directory.Packages.props index 64df33b50..61c85f4c3 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -16,8 +16,8 @@ <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" /> <PackageVersion Include="CsvHelper" Version="33.0.1" /> <Package...
diff --git a/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs b/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs index 6d5618283..559c6435a 100644 --- a/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs +++ b/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs @@ -50,8 +50,7 @@ public async Task Should_use_both...
Unexpected behavoir when upgrading to 111.3.0 Hi Upgraded a little internal tool which uses restsharp to use version 111.3.0 instead 110.2.0 and started to get the following error : ```` A default parameters with the same name has already been added ```` After quick check i found that the following code is...
null
2024-07-11T12:04:51Z
0.1
['RestSharp.Tests.RequestHeaderTests.Should_not_allow_null_header_value', 'RestSharp.Tests.RequestHeaderTests.Should_not_allow_null_header_name', 'RestSharp.Tests.RequestHeaderTests.Should_not_allow_empty_header_name']
['RestSharp.Tests.Integrated.HttpHeadersTests.Should_use_both_default_and_request_headers', 'RestSharp.Tests.RequestHeaderTests.AddHeaders_SameCaseDuplicatesExist_ThrowsException', 'RestSharp.Tests.RequestHeaderTests.AddHeaders_DifferentCaseDuplicatesExist_ThrowsException', 'RestSharp.Tests.RequestHeaderTests.AddOrUpda...
restsharp/RestSharp
restsharp__restsharp-2021
620a5576525ac9eab70bcc00337a15aa2750716c
diff --git a/src/RestSharp/Request/RequestContent.cs b/src/RestSharp/Request/RequestContent.cs index bf900be82..7064b5854 100644 --- a/src/RestSharp/Request/RequestContent.cs +++ b/src/RestSharp/Request/RequestContent.cs @@ -23,20 +23,22 @@ namespace RestSharp; class RequestContent : IDisposable { - readonly Res...
diff --git a/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs b/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs index 0e19c5d38..d5714eadd 100644 --- a/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs +++ b/test/RestSharp.Tests.Integrated/HttpHeadersTests.cs @@ -1,24 +1,26 @@ +using System.Net; using RestSha...
Adding a DefaultParameter on a RestClient and use it in a Post request doesn't work **Describe the bug** Adding a DefaultParameter on a RestClient and use it in a Post request doesn't work anymore in version 108.0.2. The parameter is ignored and not send in the request. This did work in version 106. **To Reproduce*...
I've created a workaround: ``` private RestResponse ExecuteWithDefaults(RestRequest request) { foreach (Parameter parameter in CurrentRestClient.DefaultParameters) { request.AddParameter(parameter); } return CurrentRestClient.Execute(request, Method.Post); } ``` This issue has been autom...
2023-03-12T17:07:33Z
0.1
['RestSharp.Tests.Integrated.HttpHeadersTests.Should_use_both_default_and_request_headers', 'RestSharp.Tests.Integrated.PostTests.Should_post_both_default_and_request_parameters']
['RestSharp.Tests.Integrated.HttpHeadersTests.Ensure_headers_correctly_set_in_the_hook', 'RestSharp.Tests.Integrated.PostTests.Should_post_large_form_data']
restsharp/RestSharp
restsharp__restsharp-2020
620a5576525ac9eab70bcc00337a15aa2750716c
diff --git a/src/RestSharp/Request/RequestContent.cs b/src/RestSharp/Request/RequestContent.cs index bf900be82..1b3db3c9c 100644 --- a/src/RestSharp/Request/RequestContent.cs +++ b/src/RestSharp/Request/RequestContent.cs @@ -47,7 +47,7 @@ public HttpContent BuildContent() { void AddFiles() { if (!_request...
diff --git a/test/RestSharp.Tests.Integrated/MultipartFormDataTests.cs b/test/RestSharp.Tests.Integrated/MultipartFormDataTests.cs index 4ea0e3c8b..6e4a995e9 100644 --- a/test/RestSharp.Tests.Integrated/MultipartFormDataTests.cs +++ b/test/RestSharp.Tests.Integrated/MultipartFormDataTests.cs @@ -32,13 +32,13 @@ public ...
Double quotes option for multipart/form-data boundary I tried migration 104 to 108. But since version 107, System.net.http is used for Http Request. It makes difference. When upload file using multipart/form-data, `AddFiles` called. And it makes MultipartFormDataContent and pass boundary to parameter. https...
null
2023-03-12T16:13:36Z
0.1
['RestSharp.Tests.Integrated.MultipartFormDataTests.MultipartFormData_NoBoundaryQuotes', 'RestSharp.Tests.Integrated.MultipartFormDataTests.MultipartFormData']
['RestSharp.Tests.Integrated.MultipartFormDataTests.AlwaysMultipartFormData_WithParameter_Execute']
restsharp/RestSharp
restsharp__restsharp-1962
e636ab4579e2bedf47391da062166a9d64f9a7a2
diff --git a/src/RestSharp/Extensions/HttpResponseExtensions.cs b/src/RestSharp/Extensions/HttpResponseExtensions.cs new file mode 100644 index 000000000..53b873e6c --- /dev/null +++ b/src/RestSharp/Extensions/HttpResponseExtensions.cs @@ -0,0 +1,27 @@ +// Copyright (c) .NET Foundation and Contributors +// +// License...
diff --git a/test/RestSharp.Tests.Integrated/DownloadFileTests.cs b/test/RestSharp.Tests.Integrated/DownloadFileTests.cs index fe7a2fde3..aa30a158e 100644 --- a/test/RestSharp.Tests.Integrated/DownloadFileTests.cs +++ b/test/RestSharp.Tests.Integrated/DownloadFileTests.cs @@ -7,7 +7,8 @@ namespace RestSharp.Tests.Integ...
DownloadStreamAsync does not handle 404 pages? **DO NOT USE ISSUES FOR QUESTIONS** **Describe the bug** As it stands currently, DownloadStreamAsync executes the request and blindly downloads whatever response it gets back regardless of whether the request was successful on or. So if you have someone rendering a fan...
Yeah, that's a miss. I will add a test, and then we can decide what to do with it. If the client is set to throw, I can accommodate that. However, 404 isn't currently considered as an error. Maybe returning nothing would be a good solution? I already have a fix in my own branch, so you could pull that over for the 404 ...
2022-11-08T09:52:13Z
0.1
['RestSharp.Tests.Integrated.DownloadFileTests.Handles_File_Download_Failure']
['RestSharp.Tests.Integrated.DownloadFileTests.AdvancedResponseWriter_without_ResponseWriter_reads_stream', 'RestSharp.Tests.Integrated.DownloadFileTests.Handles_Binary_File_Download', 'RestSharp.Tests.Integrated.DownloadFileTests.Writes_Response_To_Stream']
restsharp/RestSharp
restsharp__restsharp-1676
49ce0280cf54e6dde45d3753846e547473f0c59a
diff --git a/src/RestSharp/Response/RestResponse.cs b/src/RestSharp/Response/RestResponse.cs index dafd9b3d8..eed4b500d 100644 --- a/src/RestSharp/Response/RestResponse.cs +++ b/src/RestSharp/Response/RestResponse.cs @@ -42,6 +42,7 @@ public static RestResponse<T> FromResponse(RestResponse response) ErrorM...
diff --git a/test/RestSharp.IntegrationTests/StatusCodeTests.cs b/test/RestSharp.IntegrationTests/StatusCodeTests.cs index ff035f47f..af4f44ed3 100644 --- a/test/RestSharp.IntegrationTests/StatusCodeTests.cs +++ b/test/RestSharp.IntegrationTests/StatusCodeTests.cs @@ -36,6 +36,7 @@ public async Task ContentType_Additio...
IsSuccessful always false when using RestResponse<T> When using the latest RestSharp version, the property `IsSuccessful` of `RestReponse<T>` is always `false`. When using `RestResponse`, `IsSuccessful` is set to `true` whenever the request was successful. ## Expected Behavior The value of `IsSuccessful` does not...
null
2021-12-23T12:49:50Z
0.1
['RestSharp.IntegrationTests.StatusCodeTests.ContentType_Additional_Information']
[]
ThreeMammals/Ocelot
threemammals__ocelot-2170
41fc9bd5b183f6e5e6a710f46400f32a58113347
diff --git a/src/Ocelot/Configuration/Creator/ISecurityOptionsCreator.cs b/src/Ocelot/Configuration/Creator/ISecurityOptionsCreator.cs index 5f5f727f3..f85acf510 100644 --- a/src/Ocelot/Configuration/Creator/ISecurityOptionsCreator.cs +++ b/src/Ocelot/Configuration/Creator/ISecurityOptionsCreator.cs @@ -1,9 +1,8 @@ u...
diff --git a/test/Ocelot.AcceptanceTests/Security/SecurityOptionsTests.cs b/test/Ocelot.AcceptanceTests/Security/SecurityOptionsTests.cs new file mode 100644 index 000000000..7a33207b7 --- /dev/null +++ b/test/Ocelot.AcceptanceTests/Security/SecurityOptionsTests.cs @@ -0,0 +1,162 @@ +using Microsoft.AspNetCore.Http; +...
Issue with IP Blocking and Allowing in global configuration I configured IP blocking and allowing in Ocelot using SecurityOptions, but it's not working. ``` { "GlobalConfiguration": { "BaseUrl": "http://localhost:5000", "SecurityOptions": { "IPBlockedList": ["192.168.0.23"] } } } ...
Hello, Cavid! It seems we lack support for global settings. The potential solutions could be: 1. Solely using `ocelot.json`. Define the options for each route individually. 2. Utilizing C# coding. Replace the `ISecurityOptionsCreator` service in the DI container by redeveloping the `SecurityOptionsCreator` class to...
2024-10-11T06:47:50Z
0.1
['Ocelot.UnitTests.Security.IPSecurityPolicyTests.Should_exludeAllowedFromBlocked_moreBlocked_clientIp_block', 'Ocelot.UnitTests.Security.IPSecurityPolicyTests.Should_blockedIp_clientIp_Not_block', 'Ocelot.UnitTests.Security.IPSecurityPolicyTests.Should_shortRange_allowed_clientIp_not_block', 'Ocelot.UnitTests.Security...
[]
dotnet/efcore
dotnet__efcore-33106
42e6cfbd0c5b431a89b1923e7b73296705cf7ddf
diff --git a/EFCore.sln.DotSettings b/EFCore.sln.DotSettings index 1b4974fd608..d1ddc281f56 100644 --- a/EFCore.sln.DotSettings +++ b/EFCore.sln.DotSettings @@ -291,14 +291,21 @@ The .NET Foundation licenses this file to you under the MIT license.&#xD; <s:Boolean x:Key="/Default/UserDictionary/Words/=Comparers/@Entry...
diff --git a/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindMiscellaneousQueryCosmosTest.cs b/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindMiscellaneousQueryCosmosTest.cs index 91f66c225f4..6fdef18e57c 100644 --- a/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindMiscellaneousQueryCosmosTest.cs +++ b/test/EFCo...
`Select` projection with an (uncorrelated) subquery produces two separate SQL queries A `Select` projection with an (uncorrelated) subquery seems to produce two separate SQL queries, which is not what I expect as a developer. For example: ```csharp IQueryable<Employee> allEmployees = context .Employees .Where(x...
null
2024-02-15T15:59:53Z
0.1
['Microsoft.EntityFrameworkCore.Query.NorthwindMiscellaneousQueryCosmosTest.Select_take_long_count']
[]
dotnet/efcore
dotnet__efcore-32613
b01ea2fa816afba9834229b3b12bfceacde2f15c
diff --git a/src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs b/src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs index bbeb7ff3724..49dc290f878 100644 --- a/src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs +++ b/src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs @@ -320,7 +320,7 @@ private IEnumerable<sqlite3_stmt> GetStatem...
diff --git a/test/Microsoft.Data.Sqlite.Tests/SqliteCommandTest.cs b/test/Microsoft.Data.Sqlite.Tests/SqliteCommandTest.cs index 02a7951defe..aab6d37a187 100644 --- a/test/Microsoft.Data.Sqlite.Tests/SqliteCommandTest.cs +++ b/test/Microsoft.Data.Sqlite.Tests/SqliteCommandTest.cs @@ -15,6 +15,62 @@ namespace Microsoft....
Wrong ErrorCode reported by SqliteException When using `sqlite3_limit` to limit length of string or blob (`SQLITE_LIMIT_LENGTH` from https://www.sqlite.org/c3ref/c_limit_attached.html) and running an insert statement with value larger than the limit, the `SqliteException` has wrong `SqliteErrorCode` and `SqliteExtended...
Also, if I explicitly set the parameter size to zero I get the `SQLITE_TOOBIG` error: ```csharp command.CommandText = @"INSERT INTO ""Products"" (""Name"") VALUES (@p0);"; command.Parameters.Add("@p0", SqliteType.Text, 0); command.Parameters[0].Value = new string('A', 15); ``` The error code is `SQLITE_CONSTRAI...
2023-12-14T11:39:24Z
0.1
['Microsoft.Data.Sqlite.SqliteCommandTest.Correct_error_code_is_returned_when_parameter_is_too_long']
['Microsoft.Data.Sqlite.SqliteCommandTest.Prepare_throws_when_command_text_contains_dependent_commands', 'Microsoft.Data.Sqlite.SqliteCommandTest.ExecuteReader_throws_when_connection_closed', 'Microsoft.Data.Sqlite.SqliteCommandTest.ExecuteNonQuery_throws_when_busy_with_returning', 'Microsoft.Data.Sqlite.SqliteCommandT...
dotnet/efcore
dotnet__efcore-27291
8a8105d31879d435271848a595d5b7ec31ef6ce5
diff --git a/src/Microsoft.Data.Sqlite.Core/SqliteParameter.cs b/src/Microsoft.Data.Sqlite.Core/SqliteParameter.cs index 265634b0100..e71073b8300 100644 --- a/src/Microsoft.Data.Sqlite.Core/SqliteParameter.cs +++ b/src/Microsoft.Data.Sqlite.Core/SqliteParameter.cs @@ -200,7 +200,7 @@ public override void ResetDbType() ...
diff --git a/test/Microsoft.Data.Sqlite.Tests/SqliteParameterTest.cs b/test/Microsoft.Data.Sqlite.Tests/SqliteParameterTest.cs index 1779cad3e0b..e7758f21dac 100644 --- a/test/Microsoft.Data.Sqlite.Tests/SqliteParameterTest.cs +++ b/test/Microsoft.Data.Sqlite.Tests/SqliteParameterTest.cs @@ -2,6 +2,7 @@ // The .NET Fo...
Correct SqliteType inference from string, DateOnly, TimeOnly Microsoft.Data.Sqlite 6.0.1 TargetFramework net6.0-windows 当我创建一个字符串类型的SqliteParameter时,我查询它的类型,得到的类型信息是 “SqliteType.Integer” ```C# var p = new Microsoft.Data.Sqlite.SqliteParameter("Name","123"); ``` 后来我在源码中定位到了以下位置,这就有点不合适了吧 https://githu...
Google Translate: ``` When I create a SqliteParameter of type string, I query its type, and the type info I get is "SqliteType.Integer" ... Later, I located the following location in the source code, which is a bit inappropriate. ``` /cc @bricelam
2022-01-26T23:05:50Z
0.2
['Microsoft.Data.Sqlite.SqliteParameterTest.SqliteType_is_inferred_from_value', 'Microsoft.Data.Sqlite.SqliteParameterTest.SqliteType_overrides_inferred_value', 'Microsoft.Data.Sqlite.SqliteParameterTest.ResetSqliteType_works_when_value']
['Microsoft.Data.Sqlite.SqliteParameterTest.Add_range_of_parameters_using_DbCommand_base_class', 'Microsoft.Data.Sqlite.SqliteParameterTest.Bind_works_when_Guid_with_SqliteType_Blob', 'Microsoft.Data.Sqlite.SqliteParameterTest.Bind_works_when_DateOnly', 'Microsoft.Data.Sqlite.SqliteParameterTest.Bind_does_not_require_p...
dotnet/efcore
dotnet__efcore-27210
cf46ae0ed95c5564676ea25f7083d710552bae55
diff --git a/src/EFCore.Abstractions/IndexAttribute.cs b/src/EFCore.Abstractions/IndexAttribute.cs index c60caefcb14..4b93178c115 100644 --- a/src/EFCore.Abstractions/IndexAttribute.cs +++ b/src/EFCore.Abstractions/IndexAttribute.cs @@ -15,8 +15,9 @@ namespace Microsoft.EntityFrameworkCore; [AttributeUsage(AttributeTa...
diff --git a/test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationOperationGeneratorTest.cs b/test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationOperationGeneratorTest.cs index 22778a022c3..9bae3036bc4 100644 --- a/test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationOperationGeneratorTest.cs +++ b/tes...
Support for index ordering (ASC/DESC) After discussion on #11846, we decided that the way to handle this is to allow multiple named indexes to be created over columns, while still preserving the current semantics (i.e. addressing by ordered property set) for unnamed indexes. Original issue: Add support for column s...
Is this going to happen anytime soon? Using EfCore.Shaman to workaround this issue and others at the moment... @jjxtra This issue is in the Backlog milestone. This means that it is not going to happen for the 2.1 release. We will re-assess the backlog following the 2.1 release and consider this item at that time. Howev...
2022-01-19T00:16:41Z
0.2
['Microsoft.EntityFrameworkCore.Migrations.Operations.CreateIndexOperationTest.IsDescending_count_matches_column_count']
[]
dotnet/efcore
dotnet__efcore-27128
bbbd2c88778ec693bd0e857dd770093f32a2f8a4
diff --git a/src/EFCore.Design/Migrations/Design/MigrationsBundle.cs b/src/EFCore.Design/Migrations/Design/MigrationsBundle.cs index 4a2b63721b5..814ea482535 100644 --- a/src/EFCore.Design/Migrations/Design/MigrationsBundle.cs +++ b/src/EFCore.Design/Migrations/Design/MigrationsBundle.cs @@ -40,11 +40,8 @@ public stati...
diff --git a/test/EFCore.Design.Tests/Migrations/Design/MigrationsBundleTest.cs b/test/EFCore.Design.Tests/Migrations/Design/MigrationsBundleTest.cs index cf4a7e5fa74..ade059f6ef5 100644 --- a/test/EFCore.Design.Tests/Migrations/Design/MigrationsBundleTest.cs +++ b/test/EFCore.Design.Tests/Migrations/Design/MigrationsB...
EF Core Migration Bundles: no way to passthrough custom args to generated efbundle I use IDesignTimeDbContextFactory and custom args in CreateDbContext(string[] args) Then it is possible to apply update like so `dotnet ef database update -- --environment TEST It is expected to do the same with bundles ` .\efbu...
Note for triage: repros for me. ``` PS C:\local\code\AllTogetherNow\SixOh> dotnet ef database update -- --environment TEST Build started... Build succeeded. --environment TEST Applying migration '20211217110035_One'. Done. PS C:\local\code\AllTogetherNow\SixOh> dotnet ef migrations bundle Build started... ...
2022-01-06T18:40:04Z
0.2
['Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundleTest.HandleResponseFiles_is_true', 'Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundleTest.AllowArgumentSeparator_is_true']
['Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundleTest.Short_names_are_unique', 'Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundleTest.Long_names_are_unique']
serilog/serilog
serilog__serilog-2116
68881e15fde7f977ff472fff61f042ad47c5b098
diff --git a/src/Serilog/Log.cs b/src/Serilog/Log.cs index 3258d852a..a5b1d8d67 100644 --- a/src/Serilog/Log.cs +++ b/src/Serilog/Log.cs @@ -59,11 +59,18 @@ public static void CloseAndFlush() /// <summary> /// Resets <see cref="Logger"/> to the default and disposes the original if possible /// </summary>...
diff --git a/test/Serilog.Tests/Core/BatchingSinkTests.cs b/test/Serilog.Tests/Core/BatchingSinkTests.cs index 2f3efe7d6..7022cae1b 100644 --- a/test/Serilog.Tests/Core/BatchingSinkTests.cs +++ b/test/Serilog.Tests/Core/BatchingSinkTests.cs @@ -15,9 +15,9 @@ public void WhenAnEventIsEnqueuedItIsWrittenToABatchOnDispose...
CloseAndFlushAsync doesn't work with ReloadableLogger **Description** Calling Log.CloseAndFlushAsync() when using ReloadableLogger as a static logger silently fails and does nothing. **Reproduction** 1. Set the static logger to a ReloadableLogger. 2. Call Log.CloseAndFlushAsync(). **Expected behavior** The Re...
That's an awful bug, thanks for the report, will PR a patch now.
2024-09-26T06:49:02Z
0.1
['Serilog.Tests.LogTests.CloseAndFlushAsyncDisposesTheLoggerEvenWhenItIsNotAsyncDisposable']
['Serilog.Core.Tests.BatchingSinkTests.WhenAnEventIsEnqueuedItIsWrittenToABatchOnDispose', 'Serilog.Core.Tests.BatchingSinkTests.WhenAnEventIsEnqueuedItIsWrittenToABatchOnDisposeAsync', 'Serilog.Tests.LogTests.CloseAndFlushAsyncDisposesTheLogger']
serilog/serilog
serilog__serilog-2103
3f6d855a9a3b3cfab8f756b739d8120f9f398e04
diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs index f113680b6..642fa736b 100644 --- a/src/Serilog/Capturing/PropertyValueConverter.cs +++ b/src/Serilog/Capturing/PropertyValueConverter.cs @@ -397,7 +397,7 @@ internal StructureValue CreateStructureValue(ob...
diff --git a/test/Serilog.Tests/Capturing/PropertyValueConverterTests.cs b/test/Serilog.Tests/Capturing/PropertyValueConverterTests.cs index b0c73ac62..b863df7a9 100644 --- a/test/Serilog.Tests/Capturing/PropertyValueConverterTests.cs +++ b/test/Serilog.Tests/Capturing/PropertyValueConverterTests.cs @@ -488,4 +488,18 @...
Destructuring behaviour of objects with private getter has changed **Description** With the latest version of Serilog it appears that the behaviour of what properties are logged has changed from an earlier version (2.12) Here's the old output: `2024-08-20 09:12:09 [Information] Testing of destructing! OuterObjec...
null
2024-08-21T00:19:19Z
0.1
['Serilog.Tests.Capturing.PropertyValueConverterTests.PrivateGettersAreIgnoredWhenCapturing']
[]
serilog/serilog
serilog__serilog-2083
fdf4a4872b4effd02dcd7d788e45b6b8ffdfa2fc
diff --git a/src/Serilog/Serilog.csproj b/src/Serilog/Serilog.csproj index cafe30469..8a5a3d4f8 100644 --- a/src/Serilog/Serilog.csproj +++ b/src/Serilog/Serilog.csproj @@ -2,6 +2,7 @@ <PropertyGroup> <Description>Simple .NET logging with fully-structured events</Description> <VersionPrefix>4.0.1</VersionP...
diff --git a/test/Serilog.Tests/MethodOverloadConventionTests.cs b/test/Serilog.Tests/MethodOverloadConventionTests.cs index a2fedb014..9e2d1750b 100644 --- a/test/Serilog.Tests/MethodOverloadConventionTests.cs +++ b/test/Serilog.Tests/MethodOverloadConventionTests.cs @@ -35,7 +35,7 @@ public class MethodOverloadConven...
Consider using `Major.0.0.0` or `Major.Minor.0.0` assembly versioning Since Serilog 4.0.0 uses an assembly version 4.0.0.0, we've still got some wiggle-room to tweak the assembly versioning policy. Because new features _do_ cause issues when assembly versions are mismatched, `Major.Minor.0.0` is the most general versio...
null
2024-07-10T04:00:37Z
0.1
['Serilog.Tests.VersioningTests.AssemblySubordinateVersionPartsAreZero']
['Serilog.Tests.MethodOverloadConventionTests.ValidateIsEnabledMethods', 'Serilog.Tests.MethodOverloadConventionTests.ILoggerValidateConventions', 'Serilog.Tests.MethodOverloadConventionTests.ValidateWriteEventLogMethods', 'Serilog.Tests.MethodOverloadConventionTests.ValidateBindPropertyMethods', 'Serilog.Tests.MethodO...
serilog/serilog
serilog__serilog-2055
a7eb5a75640319a0791d2e3afc3497fbe7edcf7a
diff --git a/Serilog.sln.DotSettings b/Serilog.sln.DotSettings index b9aebc18f..26729a031 100644 --- a/Serilog.sln.DotSettings +++ b/Serilog.sln.DotSettings @@ -171,6 +171,21 @@ <s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=StaticReadonly/@EntryIndexedValue">&lt;Policy Inspect="True" ...
diff --git a/test/Serilog.ApprovalTests/Serilog.approved.txt b/test/Serilog.ApprovalTests/Serilog.approved.txt index 71a596147..0613a5fa3 100644 --- a/test/Serilog.ApprovalTests/Serilog.approved.txt +++ b/test/Serilog.ApprovalTests/Serilog.approved.txt @@ -75,8 +75,11 @@ namespace Serilog.Configuration public ...
`WriteTo.Batched()` and `IBatchedLogEventSink` _Serilog.Sinks.PeriodicBatching_ is used by many, many publicly-available Serilog sinks. Although currently managed as a separate package, it's a fundamental part of the ecosystem. Over the past two years we've been trying to update _Serilog.Sinks.PeriodicBatching_ to w...
null
2024-05-02T00:13:27Z
0.1
['Serilog.Core.Tests.BatchingSinkTests.WhenAnEventIsEnqueuedItIsWrittenToABatchOnDisposeAsync', 'Serilog.Core.Tests.BatchingSinkTests.WhenAnEventIsEnqueuedItIsWrittenToABatchOnDispose', 'Serilog.Core.Tests.BatchingSinkTests.WhenAnEventIsEnqueuedItIsWrittenToABatchOnTimer', 'Serilog.Core.Tests.FailureAwareBatchScheduler...
[]
serilog/serilog
serilog__serilog-1955
63bff1e93f8141b1ffa9f1632d05f90c72c42f65
diff --git a/Serilog.sln b/Serilog.sln index 066faba06..7e847867e 100644 --- a/Serilog.sln +++ b/Serilog.sln @@ -8,7 +8,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "assets", "assets", "{E9D1B5 appveyor.yml = appveyor.yml Build.ps1 = Build.ps1 build.sh = build.sh - CHANGES.md = CHANGES.md Direc...
diff --git a/test/Serilog.ApprovalTests/Serilog.approved.txt b/test/Serilog.ApprovalTests/Serilog.approved.txt index 4aba4ae9a..1824ecc72 100644 --- a/test/Serilog.ApprovalTests/Serilog.approved.txt +++ b/test/Serilog.ApprovalTests/Serilog.approved.txt @@ -358,11 +358,17 @@ namespace Serilog.Events public class Lo...
Discussion: built-in trace and span ids Trace and span correlation has become a widespread feature of diagnostics in .NET and elsewhere. If Serilog was designed today, it's more than likely that trace and span ids would be on an equal footing with levels, messages, and exceptions, as first-class attributes of log event...
Hey folks! I'm increasingly of the opinion that this will turn out to be important in Serilog's future; starting to look at spiking it out, but wondering whether anyone has any reservations/points against going in this direction? Will keep you posted here with updates :-) I find myself wondering if there's a significan...
2023-09-19T01:19:41Z
0.1
['Serilog.Tests.Events.LogEventTests.CopiedLogEventsPropagateTraceAndSpan', 'Serilog.Tests.Core.LoggerTests.CurrentActivityIsCapturedAtLogEventCreation', 'Serilog.Tests.Formatting.Display.MessageTemplateTextFormatterTests.TraceAndSpanAreEmptyWhenAbsent', 'Serilog.Tests.Formatting.Display.MessageTemplateTextFormatterTes...
[]
serilog/serilog
serilog__serilog-1927
7c395b66be91a772dccb5ad553d60bf8a116db33
diff --git a/src/Serilog/Formatting/Json/JsonFormatter.cs b/src/Serilog/Formatting/Json/JsonFormatter.cs index 3ea6b3836..fab5e95e7 100644 --- a/src/Serilog/Formatting/Json/JsonFormatter.cs +++ b/src/Serilog/Formatting/Json/JsonFormatter.cs @@ -66,7 +66,7 @@ public void Format(LogEvent logEvent, TextWriter output) ...
diff --git a/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs b/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs index 39c76d285..006255a34 100644 --- a/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs +++ b/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs @@ -274,4 +274,20 @@ public voi...
JsonFormatter RenderedMessage writes invalid output **Description** When using JsonFormatter with renderMessage enabled to write console output, the JSON output is not created correctly and results in invalid JSON. **Reproduction** 1. Configure a default logger with a sinkConfiguration that uses the JsonFormatter ...
null
2023-06-21T21:22:56Z
0.1
['Serilog.Tests.Formatting.Json.JsonFormatterTests.SequencesOfSequencesAreSerialized', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.RenderedMessageIsIncludedCorrectlyWhenRequired']
['Serilog.Tests.Formatting.Json.JsonFormatterTests.ReadonlyDictionariesAreDestructuredViaDictionaryValue', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.JsonFormattedEventsIncludeTimestamp', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.ASequencePropertySerializesAsArrayValue', 'Serilog.Tests.Formatting.Json.Js...
serilog/serilog
serilog__serilog-1926
2424cae597d19b12ea0b5e0b033a74810dc8bbbe
diff --git a/src/Serilog/Formatting/Json/JsonFormatter.cs b/src/Serilog/Formatting/Json/JsonFormatter.cs index 3ea6b3836..fab5e95e7 100644 --- a/src/Serilog/Formatting/Json/JsonFormatter.cs +++ b/src/Serilog/Formatting/Json/JsonFormatter.cs @@ -66,7 +66,7 @@ public void Format(LogEvent logEvent, TextWriter output) ...
diff --git a/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs b/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs index 39c76d285..006255a34 100644 --- a/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs +++ b/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs @@ -274,4 +274,20 @@ public voi...
JsonFormatter RenderedMessage writes invalid output **Description** When using JsonFormatter with renderMessage enabled to write console output, the JSON output is not created correctly and results in invalid JSON. **Reproduction** 1. Configure a default logger with a sinkConfiguration that uses the JsonFormatter ...
null
2023-06-21T21:08:21Z
0.1
['Serilog.Tests.Formatting.Json.JsonFormatterTests.RenderedMessageIsIncludedCorrectlyWhenRequired']
['Serilog.Tests.Formatting.Json.JsonFormatterTests.ReadonlyDictionariesAreDestructuredViaDictionaryValue', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.JsonFormattedEventsIncludeTimestamp', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.ASequencePropertySerializesAsArrayValue', 'Serilog.Tests.Formatting.Json.Js...
serilog/serilog
serilog__serilog-1908
2994fabb55549d4a681f573c5a8196b6b15d882d
diff --git a/src/Serilog/Core/LoggingLevelSwitch.cs b/src/Serilog/Core/LoggingLevelSwitch.cs index 08c5db432..847bdc293 100644 --- a/src/Serilog/Core/LoggingLevelSwitch.cs +++ b/src/Serilog/Core/LoggingLevelSwitch.cs @@ -20,6 +20,7 @@ namespace Serilog.Core; public class LoggingLevelSwitch { volatile LogEventLev...
diff --git a/test/Serilog.ApprovalTests/Serilog.approved.txt b/test/Serilog.ApprovalTests/Serilog.approved.txt index ecb422542..fece82d1f 100644 --- a/test/Serilog.ApprovalTests/Serilog.approved.txt +++ b/test/Serilog.ApprovalTests/Serilog.approved.txt @@ -280,6 +280,13 @@ namespace Serilog.Core { public ...
Allow developers to react to changes in the MinimumLevel of a LoggingLevelSwitch **Is your feature request related to a problem? Please describe.** There's currently no easy way of detecting when the `MinimumLevel` of a `LoggingLevelSwitch` changes, and the recommended workaround is monitoring its value on a timer, wh...
That's an awesome idea! :+1: .... disappointed now that I didn't come up with it :sweat_smile: Scenario-wise, having support for multiple listeners, dynamically added, would make it easier for code to interact with a `LoggingLevelSwitch` that it doesn't "own". We could follow `ChangeToken`'s registration style,...
2023-05-08T07:05:00Z
0.1
['Serilog.Tests.Core.LoggingLevekSwitchTests.MinimumLevelChanged_Should_Work']
[]
serilog/serilog
serilog__serilog-1906
2994fabb55549d4a681f573c5a8196b6b15d882d
diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs index 6f5167283..3b62b5206 100644 --- a/src/Serilog/Capturing/PropertyValueConverter.cs +++ b/src/Serilog/Capturing/PropertyValueConverter.cs @@ -35,6 +35,7 @@ partial class PropertyValueConverter : ILogEventP...
diff --git a/test/Serilog.ApprovalTests/Serilog.approved.txt b/test/Serilog.ApprovalTests/Serilog.approved.txt index ecb422542..c42f5f578 100644 --- a/test/Serilog.ApprovalTests/Serilog.approved.txt +++ b/test/Serilog.ApprovalTests/Serilog.approved.txt @@ -14,6 +14,8 @@ namespace Serilog.Configuration } publi...
Destructure.AsDictionary<T>() to override default dictionaries-are-enumerables behavior ### Description Instances of `Dictionary<string, T>` are destructured as objects, this is also [documented](https://github.com/serilog/serilog/wiki/Structured-Data#collections). But it's inheritors does not behave the same. I un...
Thanks for the note - this is by design, subclassing/inheritance isn't taken into account by destructuring rules. There are some APIs for getting around this, but `Destructure.AsDictionary<MyDictionary>()` also might be worth considering as an addition. @nblumhardt thanks for the reply. I don't understand the reasonin...
2023-05-07T07:57:20Z
0.1
['Serilog.Tests.Formatting.Json.JsonFormatterTests.CustomDictionariesAreDestructuredViaDictionaryValue_When_AsDictionary_Applied']
[]
serilog/serilog
serilog__serilog-1903
33de1c86d93e655298e6863f7720f5b6afc49833
diff --git a/src/Serilog/Capturing/PropertyBinder.cs b/src/Serilog/Capturing/PropertyBinder.cs index da6a0cbd6..1799a40bb 100644 --- a/src/Serilog/Capturing/PropertyBinder.cs +++ b/src/Serilog/Capturing/PropertyBinder.cs @@ -52,9 +52,6 @@ public EventProperty[] ConstructProperties(MessageTemplate messageTemplate, obje ...
diff --git a/test/Serilog.Tests/Capturing/GetablePropertyFinderTests.cs b/test/Serilog.Tests/Capturing/GettablePropertyFinderTests.cs similarity index 98% rename from test/Serilog.Tests/Capturing/GetablePropertyFinderTests.cs rename to test/Serilog.Tests/Capturing/GettablePropertyFinderTests.cs index 8ec43d58b..38a3a09...
Repeated placeholders within a message template cause selfLog to incorrectly log a message **Description** When passing a placeholder into a message template more than once, it updates a sink correctly but selfLog writes the line 'Positional property count does not match parameter count'. **Reproduction** Log.Info...
Thanks for the note 👍 I think the check here is deliberately simplistic for performance reasons, but if we do the more expensive check only when the parameter count differs, we could at least reduce the false-positive rate, and hopefully won't incur any additional overhead in the hot path. If anyone's intereste...
2023-05-03T01:32:09Z
0.1
['Serilog.Tests.Debugging.SelfLogTests.SelfLogReportsErrorWhenPositionalParameterCountIsMismatched', 'Serilog.Tests.Capturing.GettablePropertyFinderTests.GetPropertiesRecursiveIntegerTypeYieldNoResult', 'Serilog.Tests.Debugging.SelfLogTests.SelfLogDoesNotReportErrorWhenPositionalParameterIsRepeated']
[]
serilog/serilog
serilog__serilog-1897
883e20895c83a3a3a1eeac9356d9056c06371bf5
diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs index 52afdd36c..b1024c434 100644 --- a/src/Serilog/Capturing/PropertyValueConverter.cs +++ b/src/Serilog/Capturing/PropertyValueConverter.cs @@ -346,12 +346,15 @@ string TruncateIfNecessary(string text) ...
diff --git a/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs b/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs index 5138276b1..2584bf84a 100644 --- a/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs +++ b/test/Serilog.Tests/Formatting/Json/JsonFormatterTests.cs @@ -1,4 +1,5 @@ using Newtonso...
Destructure `IReadOnlyDictionary<...>` the same way as `IDictionary<...>` **Is your feature request related to a problem? Please describe.** `IReadOnlyDictionary` is destructured as a collection of `KeyValuePair`, which, at least from my point of view, is unwanted. **Describe the solution you'd like** `IReadOnlyDi...
Hi @pavel-faltynek - thanks for the note. The destructuring mechanism works on implementation type, not through interfaces, so this is deliberate though tricky. Does the `AsReadOnly()` method have a well-known concrete implementation type?
2023-04-29T05:43:26Z
0.1
['Serilog.Tests.Formatting.Json.JsonFormatterTests.ReadonlyDictionariesAreDestructuredViaDictionaryValue']
['Serilog.Tests.Formatting.Json.JsonFormatterTests.JsonFormattedEventsIncludeTimestamp', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.ASequencePropertySerializesAsArrayValue', 'Serilog.Tests.Formatting.Json.JsonFormatterTests.ABooleanPropertySerializesAsBooleanValue', 'Serilog.Tests.Formatting.Json.JsonFormatterTe...
serilog/serilog
serilog__serilog-1890
883e20895c83a3a3a1eeac9356d9056c06371bf5
diff --git a/src/Serilog/Configuration/LoggerSinkConfiguration.cs b/src/Serilog/Configuration/LoggerSinkConfiguration.cs index ff6a71852..a1d043d60 100644 --- a/src/Serilog/Configuration/LoggerSinkConfiguration.cs +++ b/src/Serilog/Configuration/LoggerSinkConfiguration.cs @@ -142,8 +142,28 @@ public LoggerConfiguration...
diff --git a/test/Serilog.ApprovalTests/Serilog.approved.txt b/test/Serilog.ApprovalTests/Serilog.approved.txt index 088733f46..7910898ec 100644 --- a/test/Serilog.ApprovalTests/Serilog.approved.txt +++ b/test/Serilog.ApprovalTests/Serilog.approved.txt @@ -68,7 +68,8 @@ namespace Serilog.Configuration public class...
An ability to dispose nested loggers **Is your feature request related to a problem? Please describe.** I have a quite complex logging pipeline having at least two levels of nesting via `configuration.WriteTo.Logger(nestedLogger)`. The problem is, I can't dispose all of it in one go, because nested loggers are _not_ d...
I think I can take this one myself, but I'd like to get an approval for the approach beforehand. Thanks for the suggestion, will need to loop back around and give it some thought :+1: I think the approach is sound; if anyone's interested in picking this up please jump in, otherwise given the lack of activity this sho...
2023-04-08T14:19:28Z
0.1
['Serilog.Tests.Core.ChildLoggerDisposalTests.ByDefaultChildLoggerIsNotDisposedOnOuterDisposal', 'Serilog.Tests.Core.ChildLoggerDisposalTests.ViaLegacyOverloadChildLoggerIsNotDisposedOnOuterDisposal', 'Serilog.Tests.Core.ChildLoggerDisposalTests.WhenExplicitlyConfiguredChildLoggerShouldBeDisposedAccordingToConfiguratio...
[]
dotnet/efcore
dotnet__efcore-27428
9d513828ea6d57fd7f9fa3cedeca131f79ae6989
diff --git a/src/Microsoft.Data.Sqlite.Core/SqliteConnectionPool.cs b/src/Microsoft.Data.Sqlite.Core/SqliteConnectionPool.cs index e4dd55a2566..9f78f7f7162 100644 --- a/src/Microsoft.Data.Sqlite.Core/SqliteConnectionPool.cs +++ b/src/Microsoft.Data.Sqlite.Core/SqliteConnectionPool.cs @@ -5,6 +5,7 @@ using System.Colle...
diff --git a/test/Microsoft.Data.Sqlite.Tests/SqliteConnectionFactoryTest.cs b/test/Microsoft.Data.Sqlite.Tests/SqliteConnectionFactoryTest.cs index 764f5766b23..ddb65e0edab 100644 --- a/test/Microsoft.Data.Sqlite.Tests/SqliteConnectionFactoryTest.cs +++ b/test/Microsoft.Data.Sqlite.Tests/SqliteConnectionFactoryTest.cs...
Exception from SQLite provider when application is shutting down I hope I'm posting this in the right location. I have been running this problem down for several days now and I'm not sure what is going on. I've checked all my various libraries and 3rd party packages to see if there might be an issue there. The probl...
Some more investigation... I started working on commenting anything out that I thought might be an issue, working my way back up the main program loop...so to speak. Something strange: ``` //- Check the command line arguments to see if we need to process anything string[]? args = Environment.Ge...
2022-02-10T18:46:32Z
0.2
['Microsoft.Data.Sqlite.SqliteConnectionFactoryTest.Clear_works_when_connection_leaked']
['Microsoft.Data.Sqlite.SqliteConnectionFactoryTest.Internal_connections_are_reused_across_connections', 'Microsoft.Data.Sqlite.SqliteConnectionFactoryTest.EnableExtensions_doesnt_bleed_across_connections', 'Microsoft.Data.Sqlite.SqliteConnectionFactoryTest.ReadUncommitted_doesnt_bleed_across_connections', 'Microsoft.D...
dotnet/efcore
dotnet__efcore-28261
e62e76779de4a44d24a7c0b15f9946ce76bfba83
diff --git a/src/EFCore.Cosmos/Query/Internal/CosmosRegexTranslator.cs b/src/EFCore.Cosmos/Query/Internal/CosmosRegexTranslator.cs index 51e735e7681..bf765963620 100644 --- a/src/EFCore.Cosmos/Query/Internal/CosmosRegexTranslator.cs +++ b/src/EFCore.Cosmos/Query/Internal/CosmosRegexTranslator.cs @@ -19,8 +19,6 @@ publi...
diff --git a/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindFunctionsQueryCosmosTest.cs b/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindFunctionsQueryCosmosTest.cs index 7529b91fa3d..a67e1e4ced6 100644 --- a/test/EFCore.Cosmos.FunctionalTests/Query/NorthwindFunctionsQueryCosmosTest.cs +++ b/test/EFCore.Cosmos.Fu...
Cosmos: Fixup to Regex.IsMatch translation Fixup to https://github.com/dotnet/efcore/pull/28121 * ~Throw a detailed exception for unsupported options when translating Regex.IsMatch (see discussion below)~ * "Constantize" regex options via EvaluatableFilter (https://github.com/dotnet/efcore/pull/28121#discussion_r88...
Depend on #26410, right? Not really blocked, the method translator should throw exception from itself. Don't we avoid doing that since it would block client eval? Depends if we want to do client eval of certain things. OK, I'll bring this up in design, possibly with a proposal for #26410. If you think we would need #2...
2022-06-17T16:47:08Z
0.2
[]
['Microsoft.EntityFrameworkCore.Query.NorthwindFunctionsQueryCosmosTest.Regex_IsMatch_MethodCall_With_Unsupported_Option', 'Microsoft.EntityFrameworkCore.Query.NorthwindFunctionsQueryCosmosTest.Regex_IsMatch_MethodCall_With_Any_Unsupported_Option']
dotnet/efcore
dotnet__efcore-34832
67254af14db19dbf17f04b0b3cae3881d09ccee0
diff --git a/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs b/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs index 2cd011ba677..5bdf3af9087 100644 --- a/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs +++ b/src/EFCore.SqlServer/Scaffoldi...
diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindMiscellaneousQuerySqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindMiscellaneousQuerySqlServerTest.cs index 9cec3c4e613..766a1a61654 100644 --- a/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindMiscellaneousQuerySqlServerTest....
Scaffolding against Azure Data Explorer with SQL Server emulation doesn't work using connection string of kusto like mention here trying to scaffold via dotnet ef dbcontext scaffold got this error looks like OBJECT_SCHEMA_NAME method is not supported in kusto integration https://learn.microsoft.com/en-us/az...
null
2024-10-06T10:50:47Z
0.1
[]
[]
dotnet/efcore
dotnet__efcore-34052
41e511f4affc20b5ef16ce1c9999e796d3ba8db9
diff --git a/src/EFCore.SqlServer/Extensions/SqlServerDbContextOptionsBuilderExtensions.cs b/src/EFCore.SqlServer/Extensions/SqlServerDbContextOptionsBuilderExtensions.cs index 7214fd81382..5e5ecf8127d 100644 --- a/src/EFCore.SqlServer/Extensions/SqlServerDbContextOptionsBuilderExtensions.cs +++ b/src/EFCore.SqlServer/...
diff --git a/test/EFCore.Design.Tests/Design/Internal/DbContextOperationsTest.cs b/test/EFCore.Design.Tests/Design/Internal/DbContextOperationsTest.cs index 23375b644a6..68e7662ccef 100644 --- a/test/EFCore.Design.Tests/Design/Internal/DbContextOperationsTest.cs +++ b/test/EFCore.Design.Tests/Design/Internal/DbContextO...
Introduce UseAzureSql/UseAzureSynapse as alternatives to UseSqlServer We're increasingly seeing T-SQL divergence, where certain features are not available e.g. on Azure Synapse (e.g. #33555), and some features are only available Azure SQL (e.g. the new JSON type, the new vector search capabilities). To account for this...
So given the following engine editions: 2 = Standard (For Standard, Web, and Business Intelligence.) 3 = Enterprise (For Evaluation, Developer, and Enterprise editions.) 4 = Express (For Express, Express with Tools, and Express with Advanced Services) 5 = SQL Database 6 = Azure Synapse Analytics 8 = Azure SQL M...
2024-06-21T11:53:29Z
0.1
[]
[]