repo stringclasses 17
values | instance_id stringlengths 10 43 | base_commit stringlengths 40 40 | patch stringlengths 530 154k | test_patch stringlengths 377 76.4k ⌀ | problem_statement stringlengths 97 33k | hints_text stringlengths 3 18.4k ⌀ | created_at stringdate 2020-06-16 21:09:47 2025-04-20 13:41:07 | version stringclasses 4
values | FAIL_TO_PASS stringlengths 2 3.71k | PASS_TO_PASS stringlengths 2 5.8k |
|---|---|---|---|---|---|---|---|---|---|---|
ardalis/CleanArchitecture | ardalis__cleanarchitecture-546 | 8073cf3eb58654d67baeab966e530ae69e4a9378 | diff --git a/src/Clean.Architecture.Web/ApiModels/ProjectDTO.cs b/src/Clean.Architecture.Web/ApiModels/ProjectDTO.cs
index 373e25fdb..c5342328c 100644
--- a/src/Clean.Architecture.Web/ApiModels/ProjectDTO.cs
+++ b/src/Clean.Architecture.Web/ApiModels/ProjectDTO.cs
@@ -15,7 +15,7 @@ public ProjectDTO(int id, string name... | diff --git a/tests/Clean.Architecture.FunctionalTests/ControllerApis/ApiProjectsControllerList.cs b/tests/Clean.Architecture.FunctionalTests/ControllerApis/ApiProjectsControllerList.cs
index f8d5de85c..df65af509 100644
--- a/tests/Clean.Architecture.FunctionalTests/ControllerApis/ApiProjectsControllerList.cs
+++ b/test... | Attempting to create a new project through the API results in an error regarding the 'CreateProjectDTO' interface.
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
It's not possible to create a new project using the endpoint `[POST]/api/Projects... | null | 2023-05-01T16:18:24Z | 0.1 | ['Clean.Architecture.FunctionalTests.ControllerApis.ProjectCreate.CreateProject'] | ['Clean.Architecture.FunctionalTests.ControllerApis.ProjectCreate.ReturnsOneProject'] |
ardalis/CleanArchitecture | ardalis__cleanarchitecture-530 | f041a4e1eee6438a7249e4ff687969b5ce728c62 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 402b2d6ab..a4e72e15f 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -16,6 +16,7 @@
<PackageVersion Include="FastEndpoints.ApiExplorer" Version="2.0.1" />
<PackageVersion Include="FastEndpoints.Swagger" Version="5.5... | diff --git a/tests/Clean.Architecture.FunctionalTests/ApiEndpoints/ProjectCreate.cs b/tests/Clean.Architecture.FunctionalTests/ApiEndpoints/ProjectCreate.cs
new file mode 100644
index 000000000..e122bbfac
--- /dev/null
+++ b/tests/Clean.Architecture.FunctionalTests/ApiEndpoints/ProjectCreate.cs
@@ -0,0 +1,68 @@
+using... | Please show how you would create new ToDoItems
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
In this template, you aggregate ToDoItems within the ProjectAggregate. However, you also stop s... | null | 2023-04-09T15:39:56Z | 0.1 | ['Clean.Architecture.FunctionalTests.ApiEndpoints.ProjectAddToDoItem.AddsItemAndReturnsRouteToProject', 'Clean.Architecture.FunctionalTests.ApiEndpoints.ProjectCreate.ReturnsOneProject'] | [] |
jellyfin/jellyfin | jellyfin__jellyfin-12621 | 987dbe98c8ab55c5c8eb563820e54453c835cdde | diff --git a/Emby.Naming/Video/VideoListResolver.cs b/Emby.Naming/Video/VideoListResolver.cs
index 51f29cf0887..12bc22a6ac0 100644
--- a/Emby.Naming/Video/VideoListResolver.cs
+++ b/Emby.Naming/Video/VideoListResolver.cs
@@ -141,7 +141,9 @@ private static List<VideoInfo> GetVideosGroupedByVersion(List<VideoInfo> videos... | diff --git a/tests/Jellyfin.Naming.Tests/Video/MultiVersionTests.cs b/tests/Jellyfin.Naming.Tests/Video/MultiVersionTests.cs
index 183ec898485..3005a4416c0 100644
--- a/tests/Jellyfin.Naming.Tests/Video/MultiVersionTests.cs
+++ b/tests/Jellyfin.Naming.Tests/Video/MultiVersionTests.cs
@@ -356,6 +356,45 @@ public void Te... | Sort versions in ascending order when resolution is the same
Change movie version to sort in ascending order when resolution is the same
**Issues**
Fixes #12618
Versions are sorted in reverse alphabetical order when filename includes resolution
When multiple files share the same resolution in their filenames, they ar... |
Please provide the media info of all 3 files
Those were all the same file, just renamed. I'll also upload with different resolutions in a bit.
```
General
Unique ID : 34727860135091814094139690058492232674 (0x1A2057B2EBC11E00F924498B258D43E2)
Complete name :... | 2024-09-09T20:27:19Z | 0.1 | ['Jellyfin.Naming.Tests.Video.MultiVersionTests.TestMultiVersion13'] | ['Jellyfin.Naming.Tests.Video.MultiVersionTests.TestMultiVersion4', 'Jellyfin.Naming.Tests.Video.MultiVersionTests.TestMultiVersion10', 'Jellyfin.Naming.Tests.Video.MultiVersionTests.TestMultiVersion11', 'Jellyfin.Naming.Tests.Video.MultiVersionTests.TestMultiVersion5', 'Jellyfin.Naming.Tests.Video.MultiVersionTests.Re... |
jellyfin/jellyfin | jellyfin__jellyfin-12558 | 2fe13f54eaf87eefefd27f4ccb2ace1371f5e886 | diff --git a/MediaBrowser.Controller/Entities/BaseItem.cs b/MediaBrowser.Controller/Entities/BaseItem.cs
index 8bd4fb4f382..f16558d1e7c 100644
--- a/MediaBrowser.Controller/Entities/BaseItem.cs
+++ b/MediaBrowser.Controller/Entities/BaseItem.cs
@@ -1180,28 +1180,29 @@ private MediaSourceInfo GetVersionInfo(bool enableP... | diff --git a/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs b/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs
index f3ada59dbcd..6171f12e472 100644
--- a/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs
+++ b/tests/Jellyfin.Controller.Tests/Entities/BaseItemTests.cs
@@ -1,4 +1,7 @@
using ... | Movie Version Name Changes Based on Title of Movie
### This issue respects the following points:
- [X] This is a **bug**, not a question or a configuration issue; Please visit our forum or chat rooms first to troubleshoot with volunteers, before creating a report. The links can be found [here](https://jellyfin.org/con... | null | 2024-08-31T12:02:58Z | 0.1 | ['Jellyfin.Controller.Tests.Entities.BaseItemTests.GetMediaSourceName_Valid'] | ['Jellyfin.Controller.Tests.Entities.BaseItemTests.BaseItem_ModifySortChunks_Valid'] |
jellyfin/jellyfin | jellyfin__jellyfin-12550 | 2fe13f54eaf87eefefd27f4ccb2ace1371f5e886 | diff --git a/MediaBrowser.Controller/Entities/TV/Episode.cs b/MediaBrowser.Controller/Entities/TV/Episode.cs
index 37e24141429..76bc4f49d83 100644
--- a/MediaBrowser.Controller/Entities/TV/Episode.cs
+++ b/MediaBrowser.Controller/Entities/TV/Episode.cs
@@ -180,10 +180,7 @@ public override List<string> GetUserDataKeys()... | diff --git a/tests/Jellyfin.Extensions.Tests/FormattingStreamWriterTests.cs b/tests/Jellyfin.Extensions.Tests/FormattingStreamWriterTests.cs
new file mode 100644
index 00000000000..06e3c272130
--- /dev/null
+++ b/tests/Jellyfin.Extensions.Tests/FormattingStreamWriterTests.cs
@@ -0,0 +1,23 @@
+using System.Globalization... | Error processing request. FfmpegException
### This issue respects the following points:
- [X] This is a **bug**, not a question or a configuration issue; Please visit our forum or chat rooms first to troubleshoot with volunteers, before creating a report. The links can be found [here](https://jellyfin.org/contact/).
-... | So the tdlr is the concat file writes the duration float wrong due to internationalization.
Down there is the detailed issue description + fix:
### Please describe your bug
All DVD structured folders aka VIDEO_TS aren't played because ffmpeg exits before.
This is because of wrong generated concat files in C:\Users\X... | 2024-08-30T15:19:39Z | 0.1 | ['Jellyfin.Extensions.Tests.FormattingStreamWriterTests.Shuffle_Valid_Correct'] | [] |
gui-cs/Terminal.Gui | gui-cs__terminal-gui-3195 | c8e54bba099763a593a3dd3427b795ab5b22dd0f | diff --git a/Terminal.Gui/Views/Button.cs b/Terminal.Gui/Views/Button.cs
index c5995f838d..0c90c13b8e 100644
--- a/Terminal.Gui/Views/Button.cs
+++ b/Terminal.Gui/Views/Button.cs
@@ -129,6 +129,10 @@ void Initialize (ustring text, bool is_default)
/// Gets or sets whether the <see cref="Button"/> is the default acti... | diff --git a/testenvironments.json b/testenvironments.json
index 898ac827de..25324739d6 100644
--- a/testenvironments.json
+++ b/testenvironments.json
@@ -10,6 +10,11 @@
"type": "wsl",
"wslDistribution": "Ubuntu"
},
+ {
+ "name": "WSL-Ubuntu-20.04",
+ "type": "wsl",
+ "wslDistribution": "Ubuntu-20.04"... | Pressing the ENTER key in a TextField should not move the focus
**Describe the bug**
Pressing the ENTER key in a TextField should not move the focus away from the TextField.
**To Reproduce**
Steps to reproduce the behavior:
1. Use the example at https://github.com/gui-cs/Terminal.Gui#sample-usage-in-c
2. Press the ... | That is the expected behavior if the button is set as default. If you set `IsDefault = false`, then the `Textfield` wouldn't loss the focus.
With `IsDefault = false`, pressing the ENTER key in the `TextField` would still trigger the default button action? If not, I do not want to do that, as that looses the ability to ... | 2024-01-20T01:40:39Z | 0.1 | ['Terminal.Gui.ViewTests.ButtonTests.IsDefault_True_Does_Not_Get_The_Focus_On_Enter_Key'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1552 | 0e2ed511a5cfa303ba99c97ebb3f36c50cfa526f | diff --git a/src/Spectre.Console.Cli/Internal/Configuration/TemplateParser.cs b/src/Spectre.Console.Cli/Internal/Configuration/TemplateParser.cs
index d7eef9b05..125947280 100644
--- a/src/Spectre.Console.Cli/Internal/Configuration/TemplateParser.cs
+++ b/src/Spectre.Console.Cli/Internal/Configuration/TemplateParser.cs... | diff --git a/test/Spectre.Console.Cli.Tests/Expectations/Help/Root.QuestionMark.verified.txt b/test/Spectre.Console.Cli.Tests/Expectations/Help/Root.QuestionMark.verified.txt
new file mode 100644
index 000000000..0432fe41a
--- /dev/null
+++ b/test/Spectre.Console.Cli.Tests/Expectations/Help/Root.QuestionMark.verified.t... | Add '-?' as an additional alias for '-h' and '--help', just like 'dotnet -?'
It's second nature for me to just type `-?` to get help on stuff. Even in the GitHub CLI, typing `gh -?` (although not an official option to get help) gets you the default help :).
I'd say it's a common enough shorthand for help that it deser... | Sounds like a reasonable thing to add 👍 | 2024-05-17T21:10:33Z | 0.1 | ['Spectre.Console.Tests.Unit.Cli.CommandAppTests+Help.Should_Output_Root_Correctly_QuestionMark', 'Spectre.Console.Tests.Unit.Cli.CommandAppTests+Help.Should_Output_Root_Command_Correctly_QuestionMark'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1531 | c5e11626b521c47c45339d90ae7dcebc736a3224 | diff --git a/dotnet-tools.json b/dotnet-tools.json
index b0036d859..a7f9d036b 100644
--- a/dotnet-tools.json
+++ b/dotnet-tools.json
@@ -13,6 +13,12 @@
"commands": [
"dotnet-example"
]
+ },
+ "verify.tool": {
+ "version": "0.6.0",
+ "commands": [
+ "dotnet-verify"
+ ]
... | diff --git a/test/Spectre.Console.Cli.Tests/Expectations/Help/ArgumentOrder.Output.verified.txt b/test/Spectre.Console.Cli.Tests/Expectations/Help/ArgumentOrder.Output.verified.txt
index 6e29ed297..9a82776df 100644
--- a/test/Spectre.Console.Cli.Tests/Expectations/Help/ArgumentOrder.Output.verified.txt
+++ b/test/Spect... | Built-in parameter `--version` conflicts with existing one
**Information**
- OS: `Windows`
- Version: `Spectre.Console.Cli` v0.49.0
- Terminal: `Windows Terminal / Oh My Posh`
**Describe the bug**
Recent `Spectre.Console.Cli` versions fixed the issue with the new built-in `--version` parameter when _running_ the a... | That’s unfortunate. We should make the ʼ-—versionʼ option completely opt-in and ensure it’s easy to override the behaviour if wanted.
I’m not super familiar with the changes that went into this specific addition, but I will take a look tonight and see if we can’t push a 0.49.1 version out that fixes this.
Thank you @p... | 2024-04-25T17:54:55Z | 0.1 | ['Spectre.Console.Tests.Unit.Cli.CommandAppTests+Help.Should_Not_Include_Application_Version_If_Not_Set', 'Spectre.Console.Tests.Unit.Cli.CommandAppTests+Help.Should_Include_Application_Version_If_Set', 'Spectre.Console.Tests.Unit.Cli.CommandAppTests+Version.Should_Not_Display_Version_If_Not_Specified'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1513 | eb38f76a6a988acbda3c955a8f6b72083a622bfb | diff --git a/src/Spectre.Console/Widgets/Table/TableRenderer.cs b/src/Spectre.Console/Widgets/Table/TableRenderer.cs
index 23bff61cd..0d1716685 100644
--- a/src/Spectre.Console/Widgets/Table/TableRenderer.cs
+++ b/src/Spectre.Console/Widgets/Table/TableRenderer.cs
@@ -150,9 +150,9 @@ public static List<Segment> Render(... | diff --git a/test/Spectre.Console.Tests/Expectations/Widgets/Table/Render_Row_Separators_No_Header.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Widgets/Table/Render_Row_Separators_No_Header.Output.verified.txt
new file mode 100644
index 000000000..e296413d0
--- /dev/null
+++ b/test/Spectre.Console.Test... | Table line separators not showing for the first line when table headers are hidden
**Information**
- OS: Windows 11 23H2 (OS Build 22631.2506)
- Version: Spectre.Console 0.48.0
- Terminal: Windows Terminal 1.19.3172.0
**Describe the bug**
When table headers are hidden, the first row separator is not drawn.
**To Re... | null | 2024-04-13T15:28:08Z | 0.1 | ['Spectre.Console.Tests.Unit.TableTests.Should_Render_Table_With_Row_Separators_No_Header_Correctly'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1504 | 1a3249cdaea9efa06c25d5e55e4bb53e2a65bedc | diff --git a/src/Spectre.Console/Live/LiveRenderable.cs b/src/Spectre.Console/Live/LiveRenderable.cs
index a681d2405..40107f9cd 100644
--- a/src/Spectre.Console/Live/LiveRenderable.cs
+++ b/src/Spectre.Console/Live/LiveRenderable.cs
@@ -49,7 +49,7 @@ public IRenderable PositionCursor()
}
var... | diff --git a/test/Spectre.Console.Tests/Expectations/Live/Status/Render.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Live/Status/Render.Output.verified.txt
index cd5fed942..debe2399d 100644
--- a/test/Spectre.Console.Tests/Expectations/Live/Status/Render.Output.verified.txt
+++ b/test/Spectre.Console.T... | Blatant flickering
**Information**
- OS: Windows 10/11
- Version: 0.48.0
- Terminal: Dos Prompt, Powershell and Windows Terminal
**Describe the bug**
Displaying a task list with spinners causes the whole task list to flicker. Apparently, see below, this is a regression introduced in 0.48.0
**To Reproduce**
The fol... | This is also happening for other widget types in `0.48` including up to at least `0.48.1-preview.0.32` in Windows terminal
https://github.com/spectreconsole/spectre.console/assets/13159458/f2783bb7-08c5-49cd-a097-4bc06e78bea5
This happens in progress displays without spinners as well.
Can confirm what @yenneferofvenge... | 2024-04-01T15:38:29Z | 0.1 | [] | ['Spectre.Console.Tests.Unit.StatusTests.Should_Render_Status_Correctly'] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1503 | 43f9ae92adf36dd5cb96add90d74f867690c3ed3 | diff --git a/src/Spectre.Console.Cli/Internal/Commands/XmlDocCommand.cs b/src/Spectre.Console.Cli/Internal/Commands/XmlDocCommand.cs
index 807251833..7b7592ca8 100644
--- a/src/Spectre.Console.Cli/Internal/Commands/XmlDocCommand.cs
+++ b/src/Spectre.Console.Cli/Internal/Commands/XmlDocCommand.cs
@@ -84,6 +84,13 @@ priv... | diff --git a/test/Spectre.Console.Cli.Tests/Expectations/Xml/Test_1.Output.verified.txt b/test/Spectre.Console.Cli.Tests/Expectations/Xml/Test_1.Output.verified.txt
index 998a89b3a..e92f683de 100644
--- a/test/Spectre.Console.Cli.Tests/Expectations/Xml/Test_1.Output.verified.txt
+++ b/test/Spectre.Console.Cli.Tests/Exp... | Export for Documentation
I'm currently manually creating the documentation to put on my site for the CLI usage. Which gave me a thought...
Would it be possible to do some sort of export of the the documentation.
If I have branch commands I have to go into each command and call `-h` to get the output for that command... | A little hidden gem of Spectre.Console.Cli is that you can export XML structure with a hidden command.
Try passing `cli xmldoc` to your application and it should give you the XML structure:
<img width="776" alt="image" src="https://user-images.githubusercontent.com/357872/208904802-44228d2a-1dd1-4cf7-b7a2-47d298ddce7f... | 2024-03-29T19:09:10Z | 0.1 | ['Spectre.Console.Tests.Unit.Cli.CommandAppTests+Xml.Should_Dump_Correct_Model_For_Case_6'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1458 | 72704529c5ac45401eee0b61ddd6cbaba9baab22 | diff --git a/src/Spectre.Console/Extensions/AnsiConsoleExtensions.Input.cs b/src/Spectre.Console/Extensions/AnsiConsoleExtensions.Input.cs
index f5299adde..7769e33a5 100644
--- a/src/Spectre.Console/Extensions/AnsiConsoleExtensions.Input.cs
+++ b/src/Spectre.Console/Extensions/AnsiConsoleExtensions.Input.cs
@@ -53,7 +5... | diff --git a/test/Spectre.Console.Tests/Expectations/Prompts/Text/SecretValueBackspaceNullMask.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Prompts/Text/SecretValueBackspaceNullMask.Output.verified.txt
new file mode 100644
index 000000000..473c6d87b
--- /dev/null
+++ b/test/Spectre.Console.Tests/Expect... | Prompt text is erased upon backspace when the prompt text is a secret and its mask is null.
**Describe the bug**
Prompt text is erased upon backspace when the prompt text is a secret and its mask is null.
**To Reproduce**
Create secret Prompt with a null mask. Show the Prompt. Enter a few characters, then backspace. T... | null | 2024-02-12T20:05:19Z | 0.1 | ['Spectre.Console.Tests.Unit.TextPromptTests.Should_Not_Erase_Prompt_Text_On_Backspace_If_Prompt_Is_Secret_And_Mask_Is_Null'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1338 | e2a674815dcbe9589cc87723dd6410f64aaff682 | diff --git a/src/Spectre.Console/Widgets/Rows.cs b/src/Spectre.Console/Widgets/Rows.cs
index 8e3e59576..91c963f03 100644
--- a/src/Spectre.Console/Widgets/Rows.cs
+++ b/src/Spectre.Console/Widgets/Rows.cs
@@ -41,8 +41,8 @@ protected override Measurement Measure(RenderOptions options, int maxWidth)
if (meas... | diff --git a/test/Spectre.Console.Tests/Expectations/Widgets/Rows/GH-1188-Rows.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Widgets/Rows/GH-1188-Rows.Output.verified.txt
new file mode 100644
index 000000000..ed5efe628
--- /dev/null
+++ b/test/Spectre.Console.Tests/Expectations/Widgets/Rows/GH-1188-Rows... | Rows sizing is inconsistent
**Information**
- OS: Windows
- Version: 0.46
- Terminal: Powershell, Windows Rider Integrated Terminal
**Describe the bug**
Sizing of `Panel` is confusing and buggy:
- There's no way to make the panel fit its contents. Instead, it expands the full width of the terminal (which looks ug... | null | 2023-10-19T06:01:54Z | 0.1 | ['Spectre.Console.Tests.Unit.RowsTests.Should_Render_Rows_In_Panel_Without_Breaking_Lines'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1308 | 2af3f7faeb0f5b89e48670af1b15619b3693388f | diff --git a/src/Spectre.Console/Widgets/TextPath.cs b/src/Spectre.Console/Widgets/TextPath.cs
index db5eafc7e..fafafb7b1 100644
--- a/src/Spectre.Console/Widgets/TextPath.cs
+++ b/src/Spectre.Console/Widgets/TextPath.cs
@@ -74,7 +74,7 @@ public Measurement Measure(RenderOptions options, int maxWidth)
return... | diff --git a/test/Spectre.Console.Tests/Expectations/Widgets/TextPath/GH-1307.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Widgets/TextPath/GH-1307.Output.verified.txt
new file mode 100644
index 000000000..06cfb5f27
--- /dev/null
+++ b/test/Spectre.Console.Tests/Expectations/Widgets/TextPath/GH-1307.Ou... | TextPath behaves strange together with columns
**Information**
- OS: Windows
- Version: 0.47.0
- Terminal: Windows Terminal
**Describe the bug**
TextPath seems to add a new line and/or being greedy about the max size.
**To Reproduce**
```csharp
// Works as expected
AnsiConsole.Write(
new Columns(
new ... | null | 2023-09-17T22:08:56Z | 0.1 | ['Spectre.Console.Tests.Unit.TextPathTests.Should_Behave_As_Expected_When_Rendering_Inside_Panel_Columns'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1304 | 037e109699f1e4465ffa112d1a5f19c9ad5d2233 | diff --git a/examples/Console/Borders/Program.cs b/examples/Console/Borders/Program.cs
index 0dca10135..2b755ae82 100644
--- a/examples/Console/Borders/Program.cs
+++ b/examples/Console/Borders/Program.cs
@@ -20,21 +20,22 @@ private static void PanelBorders()
{
static IRenderable CreatePanel(string name, ... | diff --git a/test/Spectre.Console.Tests/Expectations/Rendering/Borders/Box/NoBorder.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Rendering/Borders/Box/NoBorder.Output.verified.txt
index 0d3e931ff..a254250d8 100644
--- a/test/Spectre.Console.Tests/Expectations/Rendering/Borders/Box/NoBorder.Output.verif... | Add option to show separators between rows
**Is your feature request related to a problem? Please describe.**
It would be nice if there was a way to show separators between table rows.
**Additional context**
This should be opt-in
| null | 2023-09-16T15:13:47Z | 0.1 | ['Spectre.Console.Tests.Unit.TableTests.Should_Render_Table_With_Row_Separators_Correctly'] | [] |
spectreconsole/spectre.console | spectreconsole__spectre-console-1303 | 037e109699f1e4465ffa112d1a5f19c9ad5d2233 | diff --git a/examples/Console/Charts/Program.cs b/examples/Console/Charts/Program.cs
index b107f6b24..5aadfa8a0 100644
--- a/examples/Console/Charts/Program.cs
+++ b/examples/Console/Charts/Program.cs
@@ -23,6 +23,7 @@ public static void Main()
.FullSize()
.Width(60)
.ShowPercenta... | diff --git a/test/Spectre.Console.Tests/Expectations/Widgets/BreakdownChart/ValueColor.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Widgets/BreakdownChart/ValueColor.Output.verified.txt
new file mode 100644
index 000000000..5b95b8b27
--- /dev/null
+++ b/test/Spectre.Console.Tests/Expectations/Widgets/B... | Grey hard-coded in BreakdownTags
**Information**
- OS: Windows
- Version: 0.43.0
- Terminal: cmd.exe
**Describe the bug**
I noticed that there is a hard-coded `grey` color inside the breakdown chart tag format: https://github.com/spectreconsole/spectre.console/blob/main/src/Spectre.Console/Widgets/Charts/Breakdown... | null | 2023-09-15T18:12:46Z | 0.1 | ['Spectre.Console.Tests.Unit.BreakdownChartTests.Should_Render_Correct_ValueColor'] | [] |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2491 | 41b23b7dc8037cec7c05c0ca0bac0db1e767954b | diff --git a/src/BenchmarkDotNet/Characteristics/CharacteristicObject.cs b/src/BenchmarkDotNet/Characteristics/CharacteristicObject.cs
index a6d7b37b81..6cb4a983c3 100644
--- a/src/BenchmarkDotNet/Characteristics/CharacteristicObject.cs
+++ b/src/BenchmarkDotNet/Characteristics/CharacteristicObject.cs
@@ -402,6 +402,12... | diff --git a/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs b/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
index 896f93925b..64e3889fcf 100644
--- a/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
+++ b/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
@@ -233,7 +233,7 @@ public void UserCanSpecifyMultipleCoreRun... | Custom `SimpleJob` Id ignored when the `MinIterationTime` attribute is used.
Hello, just identified the issue that causes all Jobs declared as attributes to have their Id's replaced with random Job names in the summary table if the `MinIterationTime `attribute is used.
Steps to reproduce:
Create benchmark class and a... | Leaving some findings here to (hopefully) help the next person.
I noticed that I can recreate the issue with other attributes like [IterationTime(100)] or [MinInvokeCount(2)] as long as it has .IsMutator set to true.
The ResolvedId is set in the Job class `public string ResolvedId => HasValue(IdCharacteristic) ? Id... | 2024-01-02T03:41:37Z | 0.1 | ['BenchmarkDotNet.Tests.Configs.JobTests.UnfreezeCopy_PreservesIdCharacteristic'] | ['BenchmarkDotNet.Tests.ConfigParserTests.UsersCanSpecifyWithoutOverheadEvalution', 'BenchmarkDotNet.Tests.ConfigParserTests.UserCanSpecifyNoForceGCs', 'BenchmarkDotNet.Tests.ConfigParserTests.InvalidHardwareCounterNameMeansFailure', 'BenchmarkDotNet.Tests.ConfigParserTests.UserCanEasilyRequestToRunTheBenchmarkOncePerI... |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2453 | e170684208103ca5ba4212ad8dc7c2aad5cf02d4 | diff --git a/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs b/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
index af12d018b5..eaf1da4683 100644
--- a/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
+++ b/src/BenchmarkDotNet/Toolchains/CsProj/CsProjGenerator.cs
@@ -34,7 +34,8 @@ public clas... | diff --git a/tests/BenchmarkDotNet.Tests/CsProjGeneratorTests.cs b/tests/BenchmarkDotNet.Tests/CsProjGeneratorTests.cs
index 715d7dad64..323da8ddba 100644
--- a/tests/BenchmarkDotNet.Tests/CsProjGeneratorTests.cs
+++ b/tests/BenchmarkDotNet.Tests/CsProjGeneratorTests.cs
@@ -18,6 +18,11 @@ namespace BenchmarkDotNet.Test... | Add support for `runtimeconfig.template.json`
If I add RuntimeHostConfigurationOption to the benchmark project like this:
```xml
<ItemGroup>
<RuntimeHostConfigurationOption Include="System.Runtime.Loader.UseRidGraph" Value="true" />
</ItemGroup>
```
The built project will have this added to [appname].runtimeconfi... | null | 2023-10-26T15:49:07Z | 0.1 | ['BenchmarkDotNet.Tests.CsProjGeneratorTests.RuntimeHostConfigurationOptionIsCopied'] | ['BenchmarkDotNet.Tests.CsProjGeneratorTests.TestAssemblyFilePathIsUsedWhenTheAssemblyLocationIsNotEmpty', 'BenchmarkDotNet.Tests.CsProjGeneratorTests.ItsPossibleToCustomizeProjectSdkForNetCoreAppsBasedOnTheImportOfSdk', 'BenchmarkDotNet.Tests.CsProjGeneratorTests.UseWpfSettingGetsCopied', 'BenchmarkDotNet.Tests.CsProj... |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2395 | 2c999b9a2396a2c8138fa6e5ec093c6f35326b6a | diff --git a/src/BenchmarkDotNet/Configs/ImmutableConfigBuilder.cs b/src/BenchmarkDotNet/Configs/ImmutableConfigBuilder.cs
index f5d857df1d..0540dd1426 100644
--- a/src/BenchmarkDotNet/Configs/ImmutableConfigBuilder.cs
+++ b/src/BenchmarkDotNet/Configs/ImmutableConfigBuilder.cs
@@ -109,28 +109,28 @@ void AddWarning(str... | diff --git a/tests/BenchmarkDotNet.Tests/Configs/ImmutableConfigTests.cs b/tests/BenchmarkDotNet.Tests/Configs/ImmutableConfigTests.cs
index 82c01d3b81..2eae58c7c1 100644
--- a/tests/BenchmarkDotNet.Tests/Configs/ImmutableConfigTests.cs
+++ b/tests/BenchmarkDotNet.Tests/Configs/ImmutableConfigTests.cs
@@ -143,6 +143,19... | Multiple MarkdownExporters not possible
I'm testing BenchmarkDotNet and would like to have the benchmark results exported to both GitHub markdown and Atlassian markdown. But I get the error
```
The exporter BenchmarkDotNet.Exporters.MarkdownExporter is already present in configuration. There may be unexpected results.... | > Is that by intention
I really doubt that, it's most likely a bug on our side.
The issue is as far as I can see in the `ImmutableConfigBuilder.GetExporters` method. It makes a mergeDictionary by the System.Type - and that will be the same for both the GitHub MarkdownExporter and the Atlassian MarkdownExporter.
If t... | 2023-08-09T13:43:49Z | 0.1 | ['BenchmarkDotNet.Tests.Configs.ImmutableConfigTests.MultipleExportersOfSameTypeWithDifferentNamesAreAccepted'] | ['BenchmarkDotNet.Tests.Configs.ImmutableConfigTests.GenerateWarningWhenExporterDependencyAlreadyExistInConfig', 'BenchmarkDotNet.Tests.Configs.ImmutableConfigTests.DuplicateExportersAreExcluded', 'BenchmarkDotNet.Tests.Configs.ImmutableConfigTests.DuplicateDiagnosersAreExcludedBasedOnType', 'BenchmarkDotNet.Tests.Conf... |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2368 | 8a7caa7acd6a2b2f5e49b57f225ccbabd268029b | diff --git a/src/BenchmarkDotNet/Parameters/ParameterComparer.cs b/src/BenchmarkDotNet/Parameters/ParameterComparer.cs
index a1363de073..6cadf6a946 100644
--- a/src/BenchmarkDotNet/Parameters/ParameterComparer.cs
+++ b/src/BenchmarkDotNet/Parameters/ParameterComparer.cs
@@ -28,7 +28,16 @@ private int CompareValues(obje... | diff --git a/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs b/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs
index 0f01045b5c..2ef1bc8891 100644
--- a/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs
+++ b/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs
@@ -157,6 +157,70 @@ public void ICompara... | Can't use latest version of BenchmarkDotNet
I tried to use the latest bdn master (dotnet/BenchmarkDotNet@73f8fd1dc49f34b79afa4ef16e0204b1369fdd1a) here, but trying to run benchmarks fails with:
```
Unhandled exception. System.InvalidOperationException: Failed to compare two elements in the array.
---> System.Argumen... | Should this be in dotnet/BenchmarkDotNet instead?
The following reproduces the problem:
```cs
var t1 = (new CultureInfo("en-US"), CompareOptions.Ordinal, false);
var t2 = (new CultureInfo("pl-PL"), CompareOptions.None, false);
Assert.IsTrue(typeof(IComparable).IsAssignableFrom(t1.GetType())); // Succeeds
var result ... | 2023-07-13T09:08:20Z | 0.1 | ['BenchmarkDotNet.Tests.ParameterComparerTests.TupleWithNonIComparableInnerTypesComparisionTest', 'BenchmarkDotNet.Tests.ParameterComparerTests.ValueTupleWithNonIComparableInnerTypesComparisionTest'] | ['BenchmarkDotNet.Tests.ParameterComparerTests.IComparableComparisionTest', 'BenchmarkDotNet.Tests.ParameterComparerTests.BasicComparisionTest', 'BenchmarkDotNet.Tests.ParameterComparerTests.AlphaNumericComparisionTest', 'BenchmarkDotNet.Tests.ParameterComparerTests.MultiParameterComparisionTest'] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2057 | 44f79c1f3e23ff16ecadc22e8c135c449a1890ae | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
index 0ed26db03..067853098 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
@@ -190,7 +... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs b/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs
index a0191b047..d39d74ef9 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzer... | Code analysis and fix don't work for Nullable and generics in 3.0 prerelease
#### Bug description
1. Code fix doesn't add `MessagePackObjectAttribute` and `KeyAttribute` to `A`
```cs
public struct A
{
public int Id;
}
[MessagePackObject]
public class B
{
[Key(0)]
public A? Member;
}
```
2. Code analysis ... | null | 2024-11-09T13:25:39Z | 0.1 | ['MsgPack00xAnalyzerTests.AddAttributeToType_Nullable', 'MsgPack00xAnalyzerTests.AddAttributeToType_Generic'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2056 | 44f79c1f3e23ff16ecadc22e8c135c449a1890ae | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/GenericTypeParameterInfo.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/GenericTypeParameterInfo.cs
index 361959503..c35fe171a 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/GenericTypeParameterInfo.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnal... | diff --git a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
index 61a152b25..cb5d73b51 100644
--- a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
@@ -947,4 +947,38 @@ pu... | MessagePackAssumesFormattable, MessagePackKnownFormatter not resolving MsgPack003 for type with source-generated formatter
#### Bug description
In assembly Utilities, there is a custom generic struct: MyStruct<T>. I cannot change this assembly.
In the assembly I'm working in, Internal, I have a serializable record ty... | I encontered this issue today. After some investigation, I found it's caused by `GenericTypeParameterInfo.ConstraintTypes`, which doesn't have value equality.
When `ConstraintTypes.Length` is zero (like the code above), this issue can only be reproduced in Visual Studio 2022, but not in unit test project (MessagePack.... | 2024-11-09T11:53:53Z | 0.1 | ['GenerationTests.CustomFormatterForGenericWithConstraints'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2045 | c54ab0abeeeb71415a924fa784d9b56db4efec3b | diff --git a/README.md b/README.md
index 2751b4ba1..fdc288e84 100644
--- a/README.md
+++ b/README.md
@@ -665,16 +665,11 @@ Untrusted data might come from over the network from an untrusted source (e.g. a
Please be very mindful of these attack scenarios; many projects and companies, and serialization library users in... | diff --git a/tests/MessagePack.Tests/MessagePackSerializerOptionsTests.cs b/tests/MessagePack.Tests/MessagePackSerializerOptionsTests.cs
index 5b995f7b5..0db5157c0 100644
--- a/tests/MessagePack.Tests/MessagePackSerializerOptionsTests.cs
+++ b/tests/MessagePack.Tests/MessagePackSerializerOptionsTests.cs
@@ -75,8 +75,8 ... | TypeAccessException error from non-hash-safe key used in UntrustedData mode
Thank you for your hard work.
After checking the fix in #2034, deserialization failed.
```
TypeAccessException: No hash-resistant equality comparer available for type: Localization.Runtime.LocalizeKey
MessagePack.MessagePackSecurity.GetHashCo... | This is by design because v3 now runs in UntrustedData mode by default. Learn more [in our readme file](https://github.com/MessagePack-CSharp/MessagePack-CSharp/tree/develop?tab=readme-ov-file#security). You can resolve this either by switching back to TrustedData or providing your own secure hash function as documente... | 2024-10-29T14:32:31Z | 0.1 | ['MessagePackSerializerOptionsTests.Security'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2037 | ab4a3bb5302a5467bba99d6de4b22fb8cee196a6 | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
index 50565ad91..0ed26db03 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
@@ -541,7 +... | diff --git a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
index 857bbf193..61a152b25 100644
--- a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
@@ -929,4 +929,22 @@ pu... | v3: MsgPack003 Analyzer triggering on System.Collections.ObjectModel.Collection
#### Bug description
The MsgPack003 Analyzer triggers on `System.Collections.ObjectModel.Collection<>` even though it can be handled through `IList<>` etc.
#### Repro steps
Create the following program
```csharp
using MessagePack;
using S... | null | 2024-10-23T14:28:43Z | v3.0.238-rc.1 | ['GenerationTests.SystemCollectionsObjectModelCollection'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2036 | 168179ef9aba18a16a12df932a9cb818cc545377 | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/CodeAnalysisUtilities.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/CodeAnalysisUtilities.cs
index b08594f66..94033e030 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/CodeAnalysisUtilities.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/Code... | diff --git a/tests/MessagePack.SourceGenerator.Tests/GenericsFormatterTests.cs b/tests/MessagePack.SourceGenerator.Tests/GenericsFormatterTests.cs
index 57ae40582..283622c59 100644
--- a/tests/MessagePack.SourceGenerator.Tests/GenericsFormatterTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/GenericsFormatterTest... | SourceGenerator recursion crash from recursive generic type constraints
Thank you for your hard work.
The fix for #2005 was fixed in v3.0.233-rc.1,
so I updated it with NgetForUnity,
but I got the following compile error:
```
Stack overflow.
at System.Runtime.CompilerServices.CastHelpers.ChkCastAny(Void*, System.O... | Thanks for reporting.
Here is the repro I contrived from the callstack:
```cs
using System;
using MessagePack;
[MessagePackObject]
public class A<T>
where T : IEquatable<A<T>>
{
}
``` | 2024-10-23T13:38:48Z | 0.1 | ['GenericsFormatterTests.RecursiveGenerics_Direct'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2031 | 4a804d22b6f608fcb04a0dc9a1b51fbd0a52c874 | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs
index 4832023ec..f117ee557 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs
@@ ... | diff --git a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
index fd305d5a7..ab53b8de5 100644
--- a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
@@ -865,4 +865,37 @@ pu... | custom formatters code source generator error
Thank you for your hard work.
I was using 2.5.172 originally, but when I upgraded to 3.0.134-beta,
the parts using custom formatters stopped working.
I thought it might be a problem with how I was using it, so I tried using the sample built-in formatters as shown below, ... | > the parts using custom formatters stopped working.
Can you please provide more detail? What "stopped working"? Did you get a compile error? Runtime error? Did it run but serialize as something unexpected? Please provide any error messages you see.
> I thought it might be a problem with how I was using it, so I trie... | 2024-10-22T14:58:12Z | 0.1 | ['GenerationTests.GenericCustomFormatter'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2023 | e88df8a75dcfe186e31a9217192d93f667d720b8 | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
index 861720149..e077e5999 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
@@ -936,7 +... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs b/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs
index b35682b7a..3a421f7bf 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzer... | MsgPack004 Analyzer triggering on not attributed private property on base class eventhough source generator shouldn't include private properties
#### Bug description
When using non-partial classes forcing the source generator to only include public fields and removing the need to place attributes on non-public propert... | null | 2024-10-18T23:14:30Z | 0.1 | ['MsgPack00xAnalyzerTests.PrivateMembersInBaseClassNeedNoAttribution'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2022 | f5e104eec56d53df064126de8dd5bd4e533e7ea8 | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs
index 4d8567fef..4832023ec 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/AnalyzerOptions.cs
@@ ... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs b/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs
index 54d8dda01..b35682b7a 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzerTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/MsgPack00xAnalyzer... | MsgPack013 should not report diagnostics on abstract classes
The following class declaration produced an MsgPack013 diagnostic:
```cs
public abstract class Deserializer : IMessagePackFormatter<object?>
```
This doesn't make sense though because as an abstract type, the resolver could never use it anyway.
`MsgPack009... | null | 2024-10-18T23:00:15Z | 0.1 | ['MsgPack00xAnalyzerTests.AbstractFormatterDoesNotAttractAttention'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-2002 | 85c44d648799d6ccaee10489136ec504754f9a10 | diff --git a/src/MessagePack.SourceGenerator/Analyzers/MsgPack00xMessagePackAnalyzer.cs b/src/MessagePack.SourceGenerator/Analyzers/MsgPack00xMessagePackAnalyzer.cs
index 0db4bbda0..f22b5f18f 100644
--- a/src/MessagePack.SourceGenerator/Analyzers/MsgPack00xMessagePackAnalyzer.cs
+++ b/src/MessagePack.SourceGenerator/An... | diff --git a/tests/MessagePack.SourceGenerator.ExecutionTests/DeserializingConstructorStartsWithIdx1.cs b/tests/MessagePack.SourceGenerator.ExecutionTests/DeserializingConstructorStartsWithIdx1.cs
new file mode 100644
index 000000000..d0f0857b9
--- /dev/null
+++ b/tests/MessagePack.SourceGenerator.ExecutionTests/Deseri... | Analyzers (and possibly AOT) adds requirement for Key/ctor ordering
I have tried MessagePack `3.0.134-beta` on my project. So far new analyzer detections force a very strict style that requires a lot of refactoring to get it going. This might be not the best code, but on large code base refactoring is always a matter o... | Thanks for trying out the beta and sharing your feedback. This is great to hear as we're closing down v3 and we want to identify adoption blockers.
> Test1 - Why are we forced to start with 0 for constructor params? For me it is not always the case and I cannot change that.
I don't recall intentionally changing this ... | 2024-10-15T18:05:41Z | 0.1 | ['ExecutionTests.DeserializingConstructorStartsWithIdx1', 'GenerationTests.NoPrivateAccessNeeded'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1962 | b0e770756434993da40e722102833e4029f9c623 | diff --git a/src/MessagePack.Annotations/Attributes.cs b/src/MessagePack.Annotations/Attributes.cs
index 0d5ad5d2d..5072776fd 100644
--- a/src/MessagePack.Annotations/Attributes.cs
+++ b/src/MessagePack.Annotations/Attributes.cs
@@ -14,7 +14,7 @@ public class MessagePackObjectAttribute : Attribute
/// <summary... | diff --git a/tests/MessagePack.SourceGenerator.MapModeExecutionTests/StringKeyOverrideTests.cs b/tests/MessagePack.SourceGenerator.MapModeExecutionTests/StringKeyOverrideTests.cs
new file mode 100644
index 000000000..48858e4d3
--- /dev/null
+++ b/tests/MessagePack.SourceGenerator.MapModeExecutionTests/StringKeyOverride... | Array of arrays member in MessagePackObject-annotated class causes build failure with NuGet package version >=v3.0.111-alpha
#### Bug description
Trying to build a project that has a class with an array of arrays member fails when the >=v3.0.111-alpha NuGet package is used. v3.0.54-alpha is the last working v3 version... | This seems to repro on 3.0.54-alpha too, for me. | 2024-09-25T15:06:37Z | 0.1 | ['StringKeyOverrideTests.KeyOnSettableProperty', 'StringKeyOverrideTests.KeyOnReadOnlyProperty', 'StringKeyOverrideTests.KeyOnReadOnlyField', 'StringKeyOverrideTests.KeyOnSettableField'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1910 | 2b3779b5d3a6032c372dc6fd1b7e85c6efe4bf27 | diff --git a/src/MessagePack.Analyzers.CodeFixes/CodeFixes/FormatterCodeFixProvider.cs b/src/MessagePack.Analyzers.CodeFixes/CodeFixes/FormatterCodeFixProvider.cs
index 3c52fa540..9e37611da 100644
--- a/src/MessagePack.Analyzers.CodeFixes/CodeFixes/FormatterCodeFixProvider.cs
+++ b/src/MessagePack.Analyzers.CodeFixes/C... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MsgPack011PartialTypeRequiredTests.cs b/tests/MessagePack.SourceGenerator.Tests/MsgPack011PartialTypeRequiredTests.cs
index 258bbdc1e..82f94ea3a 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MsgPack011PartialTypeRequiredTests.cs
+++ b/tests/MessagePack.SourceG... | MsgPack011 issues when flagging nesting types
When MsgPack011 reports a diagnostic on a nest_ing_ type, it works at the command line. But in the IDE, the error tends to disappear from the error list, and the code fix isn't offered in the quick actions menu.
A unit test to reproduce the problem throws with "Code fix is... | null | 2024-07-29T21:56:46Z | 0.1 | ['MsgPack011PartialTypeRequiredTests.NestedPartialTypeRequiresPartialSelfAndDeclaringType', 'MsgPack011PartialTypeRequiredTests.NestedPartialTypeRequiresPartialDeclaringType'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1907 | 4788d1af88f2e8b3054fafd6e155a723bed53bba | diff --git a/sandbox/DynamicCodeDumper/DynamicCodeDumper.csproj b/sandbox/DynamicCodeDumper/DynamicCodeDumper.csproj
index 9a73030a9..ed83e60a6 100644
--- a/sandbox/DynamicCodeDumper/DynamicCodeDumper.csproj
+++ b/sandbox/DynamicCodeDumper/DynamicCodeDumper.csproj
@@ -10,6 +10,9 @@
<Compile Include="..\..\src\Mess... | diff --git a/tests/MessagePack.SourceGenerator.Tests/ImplicitResolverForCustomFormattersTests.cs b/tests/MessagePack.SourceGenerator.Tests/ImplicitResolverForCustomFormattersTests.cs
index 494d73122..26de2da45 100644
--- a/tests/MessagePack.SourceGenerator.Tests/ImplicitResolverForCustomFormattersTests.cs
+++ b/tests/M... | MsgPack013 should not fire for formatters with ExcludeFormatterFromSourceGeneratedResolver
A formatter that must be created with a particular configuration and thus cannot have a default constructor will use the `[ExcludeFormatterFromSourceGeneratedResolver]` attribute to exclude itself from the source generated resolv... | null | 2024-07-29T16:58:27Z | 0.1 | ['ImplicitResolverForCustomFormattersTests.MultipleFunctionalCustomFormattersForType_OnlyOneNonExcluded', 'ImplicitResolverForCustomFormattersTests.CustomFormatterWithoutDefaultConstructor_Excluded'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1905 | 6522b9ea066a0b5bb62e8f5a4d7796c1ddaca026 | diff --git a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
index cc38d870d..587545fd1 100644
--- a/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
+++ b/src/MessagePack.SourceGenerator/CodeAnalysis/TypeCollector.cs
@@ -9,6 +9,... | diff --git a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
index 9f17cc324..3ce8fdf53 100644
--- a/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/GenerationTests.cs
@@ -3,6 +3,7 @@
usin... | Generated code expects data type to have default ctor despite having `[SerializationConstructor]` attribute
When migrating the vs-mef repo to v3, the `PropertyRef`, `MethodRef`, `FieldRef` and `DiscoveredParts` classes all have non-default constructors and the `[SerializationConstructor]` attribute on a non-default con... | 2024-07-26T23:38:00Z | 0.1 | ['GenerationTests.NonDefaultDeserializingConstructor_Private', 'GenerationTests.DeserializingConstructorParameterMemberTypeAssignability_MemberAssignsToParamType', 'GenerationTests.DeserializingConstructorParameterMemberTypeAssignability_Incompatible'] | [] | |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1898 | dcb2801d561f0b7c896b7f93eccf86c77b39c7e8 | diff --git a/src/MessagePack.Analyzers.CodeFixes/CodeFixes/MessagePackCodeFixProvider.cs b/src/MessagePack.Analyzers.CodeFixes/CodeFixes/MessagePackCodeFixProvider.cs
index a0491a2e4..90c0e83e4 100644
--- a/src/MessagePack.Analyzers.CodeFixes/CodeFixes/MessagePackCodeFixProvider.cs
+++ b/src/MessagePack.Analyzers.CodeF... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs b/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs
index e356fe63a..91cca522c 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/MessagePackAnal... | Offer code fix for MsgPack004: attribute all members
As folks migrate to v3, non-public fields and properties on all data types will be flagged as requiring a `Key` or `IgnoreMember` attribute.
A bulk code fix should be offered that adds `IgnoreMember` everywhere necessary to ease the migration.
| null | 2024-07-22T21:51:31Z | 0.1 | ['MessagePackAnalyzerTests.AddIgnoreAttributesToMembers'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1859 | ceab2d78ccc76e11a361c7e2c4358d4aff52154d | diff --git a/src/MessagePack.SourceGenerator/Analyzers/MsgPack00xMessagePackAnalyzer.cs b/src/MessagePack.SourceGenerator/Analyzers/MsgPack00xMessagePackAnalyzer.cs
index 63a7851f8..eb915c795 100644
--- a/src/MessagePack.SourceGenerator/Analyzers/MsgPack00xMessagePackAnalyzer.cs
+++ b/src/MessagePack.SourceGenerator/An... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs b/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs
index c77bb52ab..e356fe63a 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/MessagePackAnal... | MsgPack003 is not reported on generic typed members
#### Bug description
The Analyzer does not detect properly missing attributes on generic types.
#### Repro steps
```csharp
public class Foo<T>
{
public T Member { get; set; }
}
[MessagePack.MessagePackObject]
public class Bar
{
[MessagePack.Key(0)]
pub... | null | 2024-06-26T14:11:14Z | 0.1 | ['MessagePackAnalyzerTests.AddAttributeToGenericType'] | [] |
MessagePack-CSharp/MessagePack-CSharp | messagepack-csharp__messagepack-csharp-1842 | 7280ce1aa61ca0c8309df6c10dfe96e6f6107b48 | diff --git a/src/MessagePack.Analyzers.CodeFixes/CodeFixes/MessagePackCodeFixProvider.cs b/src/MessagePack.Analyzers.CodeFixes/CodeFixes/MessagePackCodeFixProvider.cs
index 428f711aa..0e9d0bb96 100644
--- a/src/MessagePack.Analyzers.CodeFixes/CodeFixes/MessagePackCodeFixProvider.cs
+++ b/src/MessagePack.Analyzers.CodeF... | diff --git a/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs b/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs
index c8b3bab9f..c77bb52ab 100644
--- a/tests/MessagePack.SourceGenerator.Tests/MessagePackAnalyzerTests.cs
+++ b/tests/MessagePack.SourceGenerator.Tests/MessagePackAnal... | MessagePackAnalyzer MessagePackCodeFix Will overwrite comments
#### Bug description
Using Message PackCodeFix to fix code may result in missing comments
#### Repro steps
Execute Message PackCodeFix
#### Expected behavior
Just adding new attributes without affecting comments
#### Actual behavior
Code comments are... | 
Actual behavior：
Expected behavior：
 for record with one primary constructor. Only when string used as a key, with int everything works as expected.
#### Repro steps
just to use this to generate the code.
```c#
[... | Thanks for your report and your proposed fix. Would you please try our `develop` branch? `mpc` is gone, replaced with a proper C# source generator. Much of the code is the same, but a lot of refactoring has taken place.
If it repros in `develop` and you're interested, we'd be delighted if you'd add a test and a pull r... | 2024-04-13T05:22:50Z | 0.1 | ['CustomStringKeyFormatterTests.RecordWithPrimaryConstructor', 'CustomStringKeyFormatterTests.RecordWithWithInitOnlyProps'] | [] |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2307 | f32a2e753251afa7efb67f57fdbda1b18d5869fb | diff --git a/docs/articles/samples/IntroCategoryDiscoverer.md b/docs/articles/samples/IntroCategoryDiscoverer.md
new file mode 100644
index 0000000000..0f268ac913
--- /dev/null
+++ b/docs/articles/samples/IntroCategoryDiscoverer.md
@@ -0,0 +1,26 @@
+---
+uid: BenchmarkDotNet.Samples.IntroCategoryDiscoverer
+---
+
+## S... | diff --git a/tests/BenchmarkDotNet.Tests/Configs/CategoriesTests.cs b/tests/BenchmarkDotNet.Tests/Configs/CategoriesTests.cs
new file mode 100644
index 0000000000..28b0310a34
--- /dev/null
+++ b/tests/BenchmarkDotNet.Tests/Configs/CategoriesTests.cs
@@ -0,0 +1,136 @@
+using System;
+using System.Linq;
+using System.Ref... | Allow for benchmark categories composition using inheritance
I am writing some benchmarks over generic classes, and to do so I created base generic benchmark, something along these lines
```cs
[BenchmarkCategory("Number")]
public class MyBenchmark<T> where T : unmanaged, INumberBase<T>
{
public T V1;
public T V... | null | 2023-05-14T10:30:20Z | 0.2 | ['BenchmarkDotNet.Tests.Configs.CategoriesTests.CategoryInheritanceTest', 'BenchmarkDotNet.Tests.Configs.CategoriesTests.CategoryNoInheritanceTest', 'BenchmarkDotNet.Tests.Configs.CategoriesTests.CustomCategoryDiscovererTest'] | [] |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2304 | 492e58eb6f1e66ecc7d5b97f0aed6d78a20bccaa | diff --git a/docs/articles/samples/IntroComparableComplexParam.md b/docs/articles/samples/IntroComparableComplexParam.md
new file mode 100644
index 0000000000..16319bab9c
--- /dev/null
+++ b/docs/articles/samples/IntroComparableComplexParam.md
@@ -0,0 +1,20 @@
+---
+uid: BenchmarkDotNet.Samples.IntroComparableComplexPa... | diff --git a/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs b/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs
index f67e6b3d30..0f01045b5c 100644
--- a/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs
+++ b/tests/BenchmarkDotNet.Tests/ParameterComparerTests.cs
@@ -122,5 +122,82 @@ public void AlphaNum... | Custom order of parameters when using complex types
I originally had the following `int` parameter:
```cs
[Params(1_000, 10_000, 100_000, 1_000_000, 10_000_000)]
public int N;
```
This sorted properly using the natural order of the `int`.
I then wanted to customize the value names (1K, 1M, etc instead), so I had to w... | > where complex params are tested if they're IComparable, and then simply use that interface to provide the order behavior.
It's a great idea, thanks for the suggestion!
> I'm willing to work on this, as I feel it's a must have feature.
PR is welcome!
Great! Will work on a PR soon. | 2023-05-09T20:12:32Z | 0.2 | ['BenchmarkDotNet.Tests.ParameterComparerTests.IComparableComparisionTest'] | ['BenchmarkDotNet.Tests.ParameterComparerTests.BasicComparisionTest', 'BenchmarkDotNet.Tests.ParameterComparerTests.AlphaNumericComparisionTest', 'BenchmarkDotNet.Tests.ParameterComparerTests.MultiParameterComparisionTest'] |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2280 | 0772ce21aa32914050ccf4339514e9bc05563ec0 | diff --git a/src/BenchmarkDotNet/Configs/DefaultConfig.cs b/src/BenchmarkDotNet/Configs/DefaultConfig.cs
index 2ee08c8169..9a8f0345f0 100644
--- a/src/BenchmarkDotNet/Configs/DefaultConfig.cs
+++ b/src/BenchmarkDotNet/Configs/DefaultConfig.cs
@@ -68,6 +68,7 @@ public IEnumerable<IValidator> GetValidators()
... | diff --git a/tests/BenchmarkDotNet.Tests/Validators/ParamsValidatorTests.cs b/tests/BenchmarkDotNet.Tests/Validators/ParamsValidatorTests.cs
new file mode 100644
index 0000000000..c33c0625e6
--- /dev/null
+++ b/tests/BenchmarkDotNet.Tests/Validators/ParamsValidatorTests.cs
@@ -0,0 +1,206 @@
+using System.Collections.G... | Any combination of Params/ParamsSource/ParamsAllValues is broken
```C#
[DryJob]
public class Benchmarks
{
[Params("a", "b", "c")]
[ParamsSource(nameof(Source))]
public string Input { get; set; }
[Benchmark]
public void Test()
{
if(Input is "ddd" or "eee") Thread.Sleep(700);
}
p... | Hi @YegorStepanov
I am surprised that BDN is trying to make it work instead of just failing the benchmark validation.
@AndreyAkinshin what is your opinion on this? Should we add a mandatory validator that says it's not supported? Or try to make it work? | 2023-03-02T13:40:09Z | 0.2 | ['BenchmarkDotNet.Tests.Validators.ParamsValidatorTests.Const1Test', 'BenchmarkDotNet.Tests.Validators.ParamsValidatorTests.Const2Test', 'BenchmarkDotNet.Tests.Validators.ParamsValidatorTests.Const3Test', 'BenchmarkDotNet.Tests.Validators.ParamsValidatorTests.StaticReadonly1Test', 'BenchmarkDotNet.Tests.Validators.Para... | [] |
dotnet/BenchmarkDotNet | dotnet__benchmarkdotnet-2254 | 512413ceb24077154bdf6d6306138accffe64c7a | diff --git a/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs b/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
index e4b730aca3..17a01e87d5 100644
--- a/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
+++ b/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
@@ -250,6 +250,9 @@ private static IConfig Cr... | diff --git a/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs b/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
index a0d5c57c3a..427b7d00ce 100644
--- a/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
+++ b/tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
@@ -291,7 +291,7 @@ public void DotNetCliParsedCorrectly(stri... | msbuild binlog for the benchmark projects gets cleaned up too, making diagnosis of build impossible
If you use `--generateBinLog` for wasm benchmarks, you get:
```
/home/helixbot/work/B78C09A9/p/dotnet/dotnet restore --packages "/home/helixbot/work/B78C09A9/w/BCE609B9/e/performance/artifacts/packages" /p:UseSharedCom... | And related to that, a command line parameter to skip the cleanup would be useful too. | 2023-01-20T08:27:52Z | 0.2 | [] | ['BenchmarkDotNet.Tests.ConfigParserTests.UsersCanSpecifyWithoutOverheadEvalution', 'BenchmarkDotNet.Tests.ConfigParserTests.UserCanSpecifyNoForceGCs', 'BenchmarkDotNet.Tests.ConfigParserTests.InvalidHardwareCounterNameMeansFailure', 'BenchmarkDotNet.Tests.ConfigParserTests.UserCanEasilyRequestToRunTheBenchmarkOncePerI... |
App-vNext/Polly | polly-2164 | 5d81f99ef5f523032c17b6b59b32d575ec9dfb06 | diff --git a/src/Polly.Core/Retry/RetryHelper.cs b/src/Polly.Core/Retry/RetryHelper.cs
index 35d3e5825eb..1acbbf8f6cc 100644
--- a/src/Polly.Core/Retry/RetryHelper.cs
+++ b/src/Polly.Core/Retry/RetryHelper.cs
@@ -6,6 +6,11 @@ internal static class RetryHelper
private const double ExponentialFactor = 2.0;
+ ... | diff --git a/test/Polly.Core.Tests/Issues/IssuesTests.InfiniteRetry_2163.cs b/test/Polly.Core.Tests/Issues/IssuesTests.InfiniteRetry_2163.cs
new file mode 100644
index 00000000000..518e47549fc
--- /dev/null
+++ b/test/Polly.Core.Tests/Issues/IssuesTests.InfiniteRetry_2163.cs
@@ -0,0 +1,59 @@
+using Microsoft.Extensions... | [Bug]: `GetRetryDelay` goes NEGATIVE after 1025 attempts [High Risk Issue]
### Describe the bug
Retry delay goes negative after 1025 retries causing instant retries for all subsequent retry attempts.
The issue stems from the following line which tends to infinity:
```
double next = Math.Pow(ExponentialFactor, t) * ... | Example of run away behaviour; logged output from a test server:
```
2024-06-22T00:45:07.3018022+00:00 [WRN] SignalRClient connection attempt 1021 failed. Retrying in 30 secs.
2024-06-22T00:45:37.3171715+00:00 [WRN] SignalRClient connection attempt 1022 failed. Retrying in 30 secs.
2024-06-22T00:46:07.3226994+00:00 [W... | 2024-06-25T09:40:07Z | 0.1 | ['Polly.Core.Tests.Issues.IssuesTests.InfiniteRetry_Delay_Does_Not_Overflow_2163', 'Polly.Core.Tests.Retry.RetryHelperTests.GetRetryDelay_Exponential_Is_Positive_When_No_Maximum_Delay', 'Polly.Core.Tests.Retry.RetryHelperTests.GetRetryDelay_Exponential_Does_Not_Exceed_MaxDelay', 'Polly.Core.Tests.Retry.RetryHelperTests... | [] |
App-vNext/Polly | polly-2068 | ef8459480e003e5eb97be8f05218cfdafde9e28a | diff --git a/src/Polly.Core/PublicAPI.Unshipped.txt b/src/Polly.Core/PublicAPI.Unshipped.txt
index ab058de62d4..e49c0f73fd7 100644
--- a/src/Polly.Core/PublicAPI.Unshipped.txt
+++ b/src/Polly.Core/PublicAPI.Unshipped.txt
@@ -1,1 +1,4 @@
#nullable enable
+static Polly.ResiliencePipelineBuilderExtensions.AddStrategy(th... | diff --git a/test/Polly.Core.Tests/GenericResiliencePipelineBuilderTests.cs b/test/Polly.Core.Tests/GenericResiliencePipelineBuilderTests.cs
index 5a7a166eec2..62bad5fef7d 100644
--- a/test/Polly.Core.Tests/GenericResiliencePipelineBuilderTests.cs
+++ b/test/Polly.Core.Tests/GenericResiliencePipelineBuilderTests.cs
@@ ... | [Feature request]: Add AddStrategy API with no options
### Is your feature request related to a specific problem? Or an existing feature?
The `AddStrategy` extension methods take a `ResilienceStrategyOptions options` argument, which gets validated using DataAnnotations. This makes the method incompatible with trimming... | Seems reasonable to me, plus would make the API easier to use even without wanting to use AoT.
This seems to be actually a bug, at least in the documentation. The `options` parameter in the `ResiliencePipelineBuilderExtensions.AddStrategy` methods is described like this:
> The options associated with the strategy. If ... | 2024-04-22T00:24:21Z | 0.1 | ['Polly.Core.Tests.GenericResiliencePipelineBuilderTests.AddStrategy_ExplicitInstance_Ok'] | ['Polly.Core.Tests.GenericResiliencePipelineBuilderTests.AddGenericStrategy_Ok', 'Polly.Core.Tests.GenericResiliencePipelineBuilderTests.Ctor_EnsureDefaults', 'Polly.Core.Tests.GenericResiliencePipelineBuilderTests.Properties_GetSet_Ok', 'Polly.Core.Tests.GenericResiliencePipelineBuilderTests.Build_Ok'] |
App-vNext/Polly | polly-1898 | ce95e7427ad17bab8add9da93014c4c606238373 | diff --git a/src/Polly.Core/CircuitBreaker/BreakDurationGeneratorArguments.cs b/src/Polly.Core/CircuitBreaker/BreakDurationGeneratorArguments.cs
index 6b10a0e8d9d..8883f6dd774 100644
--- a/src/Polly.Core/CircuitBreaker/BreakDurationGeneratorArguments.cs
+++ b/src/Polly.Core/CircuitBreaker/BreakDurationGeneratorArgument... | diff --git a/test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs b/test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs
index 5afa53fe6ae..7b0e5378559 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs
+++ b/test/Polly.Core.Tests/Ci... | [Question]: Circuit Breaker: Using BreakDurationGenerator to implement exponential backoff of open to half-open state
### What are you wanting to achieve?
I'd like to be able to have exponential back-off of break duration via the `BreakDurationGenerator`. For example, when the circuit goes from Closed to Open, I'd lik... | > Would it be possible to add the "half-open" attempts to the BreakDurationGeneratorArguments?
Yes, the new design allows us to do these kind of changes quite easily. :) | 2024-01-13T16:03:26Z | 0.1 | ['Polly.Core.Tests.CircuitBreaker.BreakDurationGeneratorArgumentsTests.Constructor_Old_Ok'] | [] |
App-vNext/Polly | polly-1852 | 9e42b0ce80154fa6412d475530a0633b3c9ae7af | diff --git a/src/Polly.Core/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderExtensions.cs b/src/Polly.Core/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderExtensions.cs
index 189d3c5c886..37df92bb498 100644
--- a/src/Polly.Core/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderExtensions.cs
+++ b/src/Po... | diff --git a/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderTests.cs b/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderTests.cs
index 51c75f9e424..5cee0687360 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResiliencePipelineBuilderTests.cs
+++ b/... | BreakDurationGenerator not passed to CircuitStateController
There is an issue with this. When you call AddCircuitBreaker(options), having specified BreakDurationGenerator. It does not pass the generate to the CircuitStateController. So the resulting circuitbreaker will use the default 5 seconds fixed dura... | Not sure what more to add, the BreakDurationGenerator does not get passed to the controller.
So if you do:
```
ResiliencePipeline = new ResiliencePipelineBuilder()
.AddCircuitBreaker(new CircuitBreakerStrategyOptions
{
BreakDurationGenerator = args => ValueTask.FromResult(... | 2023-12-12T12:19:51Z | 0.1 | ['Polly.Core.Tests.CircuitBreaker.CircuitBreakerResiliencePipelineBuilderTests.AddCircuitBreaker_IntegrationTest_WithBreakDurationGenerator'] | ['Polly.Core.Tests.CircuitBreaker.CircuitBreakerResiliencePipelineBuilderTests.AddCircuitBreakers_WithIsolatedManualControl_ShouldBeIsolated', 'Polly.Core.Tests.CircuitBreaker.CircuitBreakerResiliencePipelineBuilderTests.AddCircuitBreaker_IntegrationTest', 'Polly.Core.Tests.CircuitBreaker.CircuitBreakerResiliencePipeli... |
App-vNext/Polly | polly-1620 | 7144f68ab418a9a2e76b2dfda12956dc8cdf7923 | diff --git a/src/Polly.Core/PublicAPI.Unshipped.txt b/src/Polly.Core/PublicAPI.Unshipped.txt
index 74c19f8c4ed..96906d8113d 100644
--- a/src/Polly.Core/PublicAPI.Unshipped.txt
+++ b/src/Polly.Core/PublicAPI.Unshipped.txt
@@ -309,6 +309,8 @@ Polly.Retry.RetryStrategyOptions<TResult>.Delay.get -> System.TimeSpan
Polly.R... | diff --git a/test/Polly.Core.Tests/Retry/RetryHelperTests.cs b/test/Polly.Core.Tests/Retry/RetryHelperTests.cs
index f5d78eac08e..0deb85d2f7c 100644
--- a/test/Polly.Core.Tests/Retry/RetryHelperTests.cs
+++ b/test/Polly.Core.Tests/Retry/RetryHelperTests.cs
@@ -28,57 +28,108 @@ public void UnsupportedRetryBackoffType_Th... | Limiting max retry delay when using standard backoff types
With current API it's not possible to limit max retry delay while using built-in backoff types.
We have a scenario where we infinitely retry failing background operations until recovery. Once the failures start, we want to backoff exponentially using the built... | I think this is a valid scenario. The changes should be relatively small so we can still squeeze this into v8.
Minor comments only:
- `MaxRetryDelay` should be `MaxDelay` - because we have the `Delay` property
- Maybe not apply the cap on external generators? (as the generation is fully under their control)
cc @mar... | 2023-09-22T08:25:48Z | 0.2 | ['Polly.Core.Tests.Retry.RetryHelperTests.MaxDelay_Ok', 'Polly.Core.Tests.Retry.RetryHelperTests.Linear_Jitter_Ok', 'Polly.Core.Tests.Retry.RetryHelperTests.MaxDelay_DelayLessThanMaxDelay_Respected', 'Polly.Core.Tests.Retry.RetryHelperTests.Constant_Jitter_Ok'] | ['Polly.Core.Tests.Retry.RetryHelperTests.Exponential_Ok', 'Polly.Core.Tests.Retry.RetryHelperTests.ExponentialWithJitter_Ok', 'Polly.Core.Tests.Retry.RetryHelperTests.IsValidDelay_Ok', 'Polly.Core.Tests.Retry.RetryHelperTests.Linear_Ok', 'Polly.Core.Tests.Retry.RetryHelperTests.Constant_Ok', 'Polly.Core.Tests.Retry.Re... |
App-vNext/Polly | polly-1579 | 6999e7c9ab0df7afe45a448d57e519f66b470d87 | diff --git a/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs b/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
index e29c89560da..4493631f8cd 100644
--- a/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
+++ b/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
@@ -57,14 +57,1... | diff --git a/test/Polly.Core.Tests/CircuitBreaker/Controller/ScheduledTaskExecutorTests.cs b/test/Polly.Core.Tests/CircuitBreaker/Controller/ScheduledTaskExecutorTests.cs
index 4b85dd4fc99..f24b8791324 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/Controller/ScheduledTaskExecutorTests.cs
+++ b/test/Polly.Core.Tests... | ObjectDisposedException thrown if a request is inflight when configuration is reloaded
Testing out Polly `8.0.0-beta.1` in an internal production application, we have observed the following exception thrown when using a resilience strategy occur if the application's configuration is reloaded while the policy is in use.... | Just found a second cluster of 3 of the same exception in another environment with a similar load and number of instances in service.
I was worried this might happen. The solution is to keep track of active executions in circuit breaker and delay the disposal until the pipeline serves no more executions. | 2023-09-08T12:41:06Z | 0.2 | ['Polly.Core.Tests.Utils.Pipeline.ExecutionTrackingComponentTests.DisposeAsync_Timeout_Ok', 'Polly.Core.Tests.Utils.Pipeline.ExecutionTrackingComponentTests.HasPendingExecutions_Ok', 'Polly.Core.Tests.Utils.Pipeline.ExecutionTrackingComponentTests.DisposeAsync_PendingOperations_Delayed', 'Polly.Core.Tests.Utils.Pipelin... | ['Polly.Core.Tests.CircuitBreaker.Controller.ScheduledTaskExecutorTests.Dispose_WhenScheduledTaskExecuting', 'Polly.Core.Tests.CircuitBreaker.Controller.ScheduledTaskExecutorTests.ScheduleTask_OperationCanceledException_EnsureExecuted', 'Polly.Core.Tests.CircuitBreaker.Controller.ScheduledTaskExecutorTests.ScheduleTask... |
App-vNext/Polly | polly-1555 | 3f1b4355bb76724e26644df09dd11729162756cd | diff --git a/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs b/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
index a40552b7b8c..e29c89560da 100644
--- a/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
+++ b/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
@@ -33,10 +33,6... | diff --git a/test/Polly.Core.Tests/Utils/Pipeline/ReloadablePipelineComponentTests.cs b/test/Polly.Core.Tests/Utils/Pipeline/ReloadablePipelineComponentTests.cs
index 6eeca2a04df..371e4d88219 100644
--- a/test/Polly.Core.Tests/Utils/Pipeline/ReloadablePipelineComponentTests.cs
+++ b/test/Polly.Core.Tests/Utils/Pipeline... | Default logging behaviour when using InstanceName is unintuitive
If a user chooses to set a `InstanceName` on a strategy/pipeline, its value is never passed through to telemetry and is always null.
This is because by default the `InstanceNameFormatter` is null, so any value is always formatted to be `null`:
https://g... | I am not sure whether this is a bur or feature. Let me explain the behavior/thinking about the instance name.
Instance name is meant as an additional dimension in case there are multiple pipeline instances with the same name. It's advanced feature in case composite pipeline keys are used.
For example:
https://github.... | 2023-09-06T13:24:15Z | 0.2 | [] | ['Polly.Core.Tests.Utils.Pipeline.ReloadablePipelineComponentTests.ChangeTriggered_FactoryError_LastStrategyUsedAndErrorReported', 'Polly.Core.Tests.Utils.Pipeline.ReloadablePipelineComponentTests.DisposeError_EnsureReported', 'Polly.Core.Tests.Utils.Pipeline.ReloadablePipelineComponentTests.DisposeAsync_ComponentDispo... |
App-vNext/Polly | polly-1528 | a0be5612f1144ed13278b14b7e7e0b72071ab617 | diff --git a/bench/Polly.Core.Benchmarks/CreationBenchmark.cs b/bench/Polly.Core.Benchmarks/CreationBenchmark.cs
index ac3e507b2bf..52c44f037e2 100644
--- a/bench/Polly.Core.Benchmarks/CreationBenchmark.cs
+++ b/bench/Polly.Core.Benchmarks/CreationBenchmark.cs
@@ -18,7 +18,7 @@ public static void Fallback_V8()
... | diff --git a/test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs b/test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs
index 075e04b55f1..3fb989e7a59 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitExceptionTests.cs
+++ b/test/Polly.Core.Tests/CircuitBreaker/BrokenCircuitE... | Finalize the V8 API
We should finalize the V8 API:
- Based on the alpha release feedback.
- Address or close any comments in #1233
| null | 2023-08-30T14:23:27Z | 0.2 | [] | ['Polly.Core.Tests.CircuitBreaker.BrokenCircuitExceptionTests.Ctor_Ok'] |
App-vNext/Polly | polly-1472 | 9674b6b2fee25db24e770ad5d9056be68ddbda73 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 3a5e431dfd0..ce5b24e4b09 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -22,7 +22,7 @@
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Vers... | null | Replace Moq
Given recent developments with Moq as of version 4.20.0, we should remove it and replace with another library.
[NSubstitue](https://nsubstitute.github.io/) seems like a good _substitue_.
I'm going to work on this today unless someone has any strong opinions about an alternative library to use in its place... | Are there any plans to fork the Moq?
Maybe in the meantime, we can freeze the versions and wait for some "official forked package".
I have not used NSubstitute personally, so I can't comment on that. It seems some folks find it cleaner compared to Moq.
If the switch is straightforward, we can get away with that.
... | 2023-08-09T11:54:12Z | 0.2 | [] | ['Polly.Core.Tests.CircuitBreaker.CircuitBreakerResilienceStrategyTests.Execute_HandledException_OnFailureCalled', 'Polly.Core.Tests.CircuitBreaker.CircuitBreakerResilienceStrategyTests.Ctor_StateProvider_EnsureAttached', 'Polly.Core.Tests.CircuitBreaker.CircuitBreakerResilienceStrategyTests.Execute_UnhandledException_... |
App-vNext/Polly | polly-1436 | b38e6c43bd4647a6e34b4e636f62c674139a22f5 | diff --git a/src/Polly.Extensions/Telemetry/Log.cs b/src/Polly.Extensions/Telemetry/Log.cs
index 3ca6726db82..0765a6081cd 100644
--- a/src/Polly.Extensions/Telemetry/Log.cs
+++ b/src/Polly.Extensions/Telemetry/Log.cs
@@ -12,7 +12,7 @@ internal static partial class Log
EventId = 0,
Message = "Resilienc... | diff --git a/test/Polly.Extensions.Tests/Telemetry/ResilienceTelemetryDiagnosticSourceTests.cs b/test/Polly.Extensions.Tests/Telemetry/ResilienceTelemetryDiagnosticSourceTests.cs
index 111da9d94dd..5df7c1bd9d3 100644
--- a/test/Polly.Extensions.Tests/Telemetry/ResilienceTelemetryDiagnosticSourceTests.cs
+++ b/test/Poll... | Confusing log entries when builder instance name not set
Using Polly 8.0.0-alpha.7 where a builder has no name set, slightly confusing log messages are emitted. Messages are emitted with empty pairs of square brackets (e.g. `Retry[]`) which look like arrays, but aren't, and it isn't clear what they signify.
For exampl... | > When elements of the log message are null, should be maybe replace them with a constant like (unset) or similar?
Possibly or just use the common `(null)` marker.
`(null)[(null)]/MyStrategy` or maybe use `/(null)/(null)/MyStrategy` format. Wdyt?
> Or should we change the format of the source to emit empty parts and ... | 2023-07-26T12:23:15Z | 0.2 | [] | ['Polly.Extensions.Tests.Telemetry.ResilienceTelemetryDiagnosticSourceTests.WriteEvent_LoggingWithoutInstanceName_Ok', 'Polly.Extensions.Tests.Telemetry.ResilienceTelemetryDiagnosticSourceTests.Meter_Ok', 'Polly.Extensions.Tests.Telemetry.ResilienceTelemetryDiagnosticSourceTests.WriteEvent_MeteringWithoutEnrichers_Ok',... |
App-vNext/Polly | polly-1361 | 190f096a8b7094dd387fba93ec0826c187baa4d8 | diff --git a/bench/Polly.Core.Benchmarks/TelemetryBenchmark.cs b/bench/Polly.Core.Benchmarks/TelemetryBenchmark.cs
index ab0e2048f24..fcd217b220c 100644
--- a/bench/Polly.Core.Benchmarks/TelemetryBenchmark.cs
+++ b/bench/Polly.Core.Benchmarks/TelemetryBenchmark.cs
@@ -78,7 +78,7 @@ protected override ValueTask<Outcome<... | diff --git a/test/Polly.Core.Tests/CircuitBreaker/Controller/CircuitStateControllerTests.cs b/test/Polly.Core.Tests/CircuitBreaker/Controller/CircuitStateControllerTests.cs
index b91f2fb830b..65460d9b9e6 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/Controller/CircuitStateControllerTests.cs
+++ b/test/Polly.Core.Te... | Expand the `ResilienceEvent` with the `Severity`
This allows us to report `Informational` events and use the common-infra.
Changes:
- Add/Modify methods on `ResilienceStrategyTelemetry` to accept the serverity.
- Make sure that `TelemetryResilienceStrategy` strategy reports unhealthy status only for events with high s... | null | 2023-06-27T12:00:50Z | 0.2 | [] | ['Polly.Core.Tests.CircuitBreaker.Controller.CircuitStateControllerTests.Flow_Closed_HalfOpen_Closed', 'Polly.Core.Tests.CircuitBreaker.Controller.CircuitStateControllerTests.Disposed_EnsureThrows', 'Polly.Core.Tests.CircuitBreaker.Controller.CircuitStateControllerTests.BreakAsync_Ok', 'Polly.Core.Tests.CircuitBreaker.... |
App-vNext/Polly | polly-1326 | 91e5384b8a77bf19d618587e4929bc687658f8ed | diff --git a/bench/BenchmarkDotNet.Artifacts/results/Polly.Core.Benchmarks.MultipleStrategiesBenchmark-report-github.md b/bench/BenchmarkDotNet.Artifacts/results/Polly.Core.Benchmarks.MultipleStrategiesBenchmark-report-github.md
index 56839c5e0a1..f4743763425 100644
--- a/bench/BenchmarkDotNet.Artifacts/results/Polly.C... | diff --git a/test/Polly.Core.Tests/Hedging/Controller/HedgingControllerTests.cs b/test/Polly.Core.Tests/Hedging/Controller/HedgingControllerTests.cs
index 77455c3b6e1..0fca74985fe 100644
--- a/test/Polly.Core.Tests/Hedging/Controller/HedgingControllerTests.cs
+++ b/test/Polly.Core.Tests/Hedging/Controller/HedgingContro... | Track execution time for retries and hedging attempts
We need to extend `OnHedgingArguments` and `OnRetryArguments` with the `ExecutionTime` property that allows tracking how long each attempt took.
Additionally, we should also introduce `ExecutionAttemptArguments` that tracks the execution info for both hedging and ... | null | 2023-06-19T13:06:14Z | 0.2 | ['Polly.Extensions.Tests.Telemetry.ExecutionAttemptArgumentsTests.Get_Ok', 'Polly.Extensions.Tests.Utils.TelemetryUtilTests.AsBoxedInt_Ok', 'Polly.Extensions.Tests.Telemetry.ExecutionAttemptArgumentsTests.Ctor_Ok', 'Polly.Extensions.Tests.Utils.TelemetryUtilTests.AsBoxedPool_Ok', 'Polly.Extensions.Tests.Telemetry.Execu... | ['Polly.Core.Tests.Hedging.Controller.HedgingControllerTests.Pooling_Ok'] |
App-vNext/Polly | polly-1321 | 6fcf0f68a116868f18d5be97e32d7a442d85f140 | diff --git a/bench/BenchmarkDotNet.Artifacts/results/Polly.Core.Benchmarks.MultipleStrategiesBenchmark-report-github.md b/bench/BenchmarkDotNet.Artifacts/results/Polly.Core.Benchmarks.MultipleStrategiesBenchmark-report-github.md
index 761ed6b8320..56839c5e0a1 100644
--- a/bench/BenchmarkDotNet.Artifacts/results/Polly.C... | diff --git a/test/Polly.Core.Tests/Telemetry/TelemetryEventArgumentsTests.cs b/test/Polly.Core.Tests/Telemetry/TelemetryEventArgumentsTests.cs
new file mode 100644
index 00000000000..a75aa1cdb01
--- /dev/null
+++ b/test/Polly.Core.Tests/Telemetry/TelemetryEventArgumentsTests.cs
@@ -0,0 +1,39 @@
+using System;
+using P... | Reduce allocations in telemetry
Revealed in #1311
- Use pooling for `TelemetryEventArguments`
| null | 2023-06-19T09:04:24Z | 0.2 | ['Polly.Extensions.Tests.Telemetry.TelemetryEventArgumentsTests.Return_EnsurePropertiesCleared', 'Polly.Extensions.Tests.Telemetry.TelemetryEventArgumentsTests.Get_Ok'] | [] |
App-vNext/Polly | polly-1316 | 488bc103fb6f8126aa528a52efd904f19c0d0183 | diff --git a/src/Polly.Core/CircuitBreaker/CircuitBreakerStrategyOptions.cs b/src/Polly.Core/CircuitBreaker/CircuitBreakerStrategyOptions.cs
index 10fd7e77888..4c0c539fe96 100644
--- a/src/Polly.Core/CircuitBreaker/CircuitBreakerStrategyOptions.cs
+++ b/src/Polly.Core/CircuitBreaker/CircuitBreakerStrategyOptions.cs
@@ ... | diff --git a/test/Polly.Core.Tests/CircuitBreaker/AdvancedCircuitBreakerOptionsTests.cs b/test/Polly.Core.Tests/CircuitBreaker/AdvancedCircuitBreakerOptionsTests.cs
index d6b5d99d791..2859a9c0887 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/AdvancedCircuitBreakerOptionsTests.cs
+++ b/test/Polly.Core.Tests/CircuitB... | [V8] ShouldHandle, ShouldRetry etc. predicates should have reasonable defaults
Currently when using the new API, it is required to specify `ShouldHandle` predicate for CircuitBreaker, `ShouldRetry` predicate for Retry and probably more.
I think it would be beneficial to have some reasonable default predicates so that ... | Yeah, I agree here, let's address this in alpha2. Would provide a nice out-of-box experience. | 2023-06-16T14:01:05Z | 0.2 | ['Polly.Core.Tests.CircuitBreaker.AdvancedCircuitBreakerOptionsTests.ShouldHandle_EnsureDefaults'] | ['Polly.Core.Tests.CircuitBreaker.AdvancedCircuitBreakerOptionsTests.Ctor_Defaults', 'Polly.Core.Tests.CircuitBreaker.AdvancedCircuitBreakerOptionsTests.InvalidOptions_Validate', 'Polly.Core.Tests.CircuitBreaker.AdvancedCircuitBreakerOptionsTests.Ctor_Generic_Defaults'] |
autofac/Autofac | autofac__autofac-1428 | b222d0f635442dde23e219f14b2132932b028e81 | diff --git a/src/Autofac/Core/NamedPropertyParameter.cs b/src/Autofac/Core/NamedPropertyParameter.cs
index f94c74a7c..1723fad32 100644
--- a/src/Autofac/Core/NamedPropertyParameter.cs
+++ b/src/Autofac/Core/NamedPropertyParameter.cs
@@ -22,7 +22,7 @@ public class NamedPropertyParameter : ConstantParameter
/// </su... | diff --git a/test/Autofac.Specification.Test/Features/PropertyInjectionTests.cs b/test/Autofac.Specification.Test/Features/PropertyInjectionTests.cs
index 0165a495f..b95b74bc8 100644
--- a/test/Autofac.Specification.Test/Features/PropertyInjectionTests.cs
+++ b/test/Autofac.Specification.Test/Features/PropertyInjection... | Inconsistent behavior of different RegistrationExtensions.WithProperty overloads regarding nullable properties
## Describe the Bug
The `WithProperty(Expression<Func<TLimit, TProperty>> propertyExpression, TProperty propertyValue)` throws when `propertyValue` is null, regardless whether `TProperty` is nullable. Nullabl... | This is sort of an interesting thing where I'm not entirely sure what the right answer is.
The reason I say that is that, generally speaking, we don't allow Autofac to "resolve null values." For example, you can't do this:
```csharp
builder.RegisterInstance<IService>(null);
```
And if you have property injection ena... | 2024-09-15T23:15:01Z | 0.1 | ['Autofac.Specification.Test.Features.PropertyInjectionTests.WithPropertyNamedAllowsNullValue', 'Autofac.Specification.Test.Features.PropertyInjectionTests.WithPropertyDelegateAllowsNullValue', 'Autofac.Specification.Test.Features.PropertyInjectionTests.WithPropertyTypedAllowsNullValue'] | ['Autofac.Specification.Test.Features.PropertyInjectionTests.ParameterForConstructorShouldNotAttachToProperty', 'Autofac.Specification.Test.Features.PropertyInjectionTests.InjectPropertiesOverwritesSetProperties', 'Autofac.Specification.Test.Features.PropertyInjectionTests.PropertiesAutowiredCanSetBaseClassProperties',... |
autofac/Autofac | autofac__autofac-1424 | 488294e8eab11ff1381f70aa9018b18fe06dd6ac | diff --git a/src/Autofac/Features/Decorators/DecoratorMiddleware.cs b/src/Autofac/Features/Decorators/DecoratorMiddleware.cs
index 4521c8d05..ef0c398c1 100644
--- a/src/Autofac/Features/Decorators/DecoratorMiddleware.cs
+++ b/src/Autofac/Features/Decorators/DecoratorMiddleware.cs
@@ -77,7 +77,15 @@ public void Execute(... | diff --git a/test/Autofac.Test/Features/Decorators/OpenGenericDecoratorTests.cs b/test/Autofac.Test/Features/Decorators/OpenGenericDecoratorTests.cs
index b64e07910..d9391c012 100644
--- a/test/Autofac.Test/Features/Decorators/OpenGenericDecoratorTests.cs
+++ b/test/Autofac.Test/Features/Decorators/OpenGenericDecorator... | [Autofac 6.4.0]: RegisterGenericDecorator() resolves incorrect instance for the decorated type
## Describe the Bug
When I register a generic decorator for my command handlers with `RegisterGenericDecorator()` and then try to resolve all command handlers by `container.Resolve(IEnumerable<IHandler<Command>>)`, the retu... | While I've not had the time to repro this or anything, it seems like the important aspect here is the `IEnumerable<T>` part. It's not that the decorator isn't decorating the right type _all the time_, it's that if you resolve _a list of all the handlers_ (`IEnumerable<T>`), that's when you see the behavior.
It also me... | 2024-08-14T21:53:18Z | 0.1 | ['Autofac.Test.Features.Decorators.OpenGenericDecoratorTests.ResolvesMultipleDecoratedServicesWhenResolvedByOtherServices'] | [] |
autofac/Autofac | autofac__autofac-1364 | d166b2c2e575f6e0fddfab54f38c46f24f43839d | diff --git a/bench/Autofac.BenchmarkProfiling/Autofac.BenchmarkProfiling.csproj b/bench/Autofac.BenchmarkProfiling/Autofac.BenchmarkProfiling.csproj
index 248ba87d6..165a5eac8 100644
--- a/bench/Autofac.BenchmarkProfiling/Autofac.BenchmarkProfiling.csproj
+++ b/bench/Autofac.BenchmarkProfiling/Autofac.BenchmarkProfilin... | diff --git a/test/Autofac.Specification.Test/Features/RequiredPropertyTests.cs b/test/Autofac.Specification.Test/Features/RequiredPropertyTests.cs
new file mode 100644
index 000000000..00dfe07b9
--- /dev/null
+++ b/test/Autofac.Specification.Test/Features/RequiredPropertyTests.cs
@@ -0,0 +1,355 @@
+// Copyright (c) Au... | Support for ```required``` properties
## Problem Statement
Traditionally, Autofac creates objects by calling one of their constructors. The constructor accepts dependencies and then assigns/initializes values.
Starting in C#11, dependencies can also be expressed using the ```required``` keyword. When a property is `... | Generally in favour of the feature to reduce user confusion when combined with the NRT analyser, I'm guessing it will determine that any required properties are non-null.
Got some random questions/thoughts though of the top of my head...
- Currently you have to invoke `PropertiesAutowired` on a registration to apply ... | 2023-01-28T10:34:13Z | 0.1 | ['Autofac.Specification.Test.Features.RequiredPropertyTests.CanResolveOpenGenericComponentRequiredProperties', 'Autofac.Specification.Test.Features.RequiredPropertyTests.PositionalParametersIgnoredForRequiredProperties', 'Autofac.Specification.Test.Features.RequiredPropertyTests.GeneralTypeParameterCanTakePlaceOfRegist... | [] |
autofac/Autofac | autofac__autofac-1362 | 0c79d7bce06173e358c748a0a3f64f311a901f7f | diff --git a/bench/Autofac.BenchmarkProfiling/Program.cs b/bench/Autofac.BenchmarkProfiling/Program.cs
index 007338158..0bf1280ad 100644
--- a/bench/Autofac.BenchmarkProfiling/Program.cs
+++ b/bench/Autofac.BenchmarkProfiling/Program.cs
@@ -84,14 +84,14 @@ static void Main(string[] args)
// Workload method i... | diff --git a/test/Autofac.Test/Core/Activators/Reflection/DefaultConstructorFinderTests.cs b/test/Autofac.Test/Core/Activators/Reflection/DefaultConstructorFinderTests.cs
index 18c3f812c..ca21ab499 100644
--- a/test/Autofac.Test/Core/Activators/Reflection/DefaultConstructorFinderTests.cs
+++ b/test/Autofac.Test/Core/Ac... | Inconsistent error reporting when no constructors are found
## Describe the Bug
I was in the process of writing documentation to explain what to do when the set `IConstructorFinder` is unable to find any constructors on a component type and noticed we have multiple potential reporting mechanisms for the issue:
- If u... | null | 2023-01-04T20:22:31Z | 0.1 | ['Autofac.Test.Core.Activators.Reflection.DefaultConstructorFinderTests.SupportsZeroPublicConstructorTypes'] | ['Autofac.Test.Core.Activators.Reflection.DefaultConstructorFinderTests.FindsPublicConstructorsOnlyByDefault', 'Autofac.Test.Core.Activators.Reflection.DefaultConstructorFinderTests.CanFindNonPublicConstructorsUsingFinderFunction'] |
autofac/Autofac | autofac__autofac-1352 | 3465490bfa192512e3db61a1d9a2441d7c10171f | diff --git a/src/Autofac/Features/Decorators/DecoratorContext.cs b/src/Autofac/Features/Decorators/DecoratorContext.cs
index 3929fbdbd..d674814a8 100644
--- a/src/Autofac/Features/Decorators/DecoratorContext.cs
+++ b/src/Autofac/Features/Decorators/DecoratorContext.cs
@@ -1,6 +1,8 @@
// Copyright (c) Autofac Project.... | diff --git a/test/Autofac.Specification.Test/Features/DecoratorTests.cs b/test/Autofac.Specification.Test/Features/DecoratorTests.cs
index 87382fa0b..77e1cc4c0 100644
--- a/test/Autofac.Specification.Test/Features/DecoratorTests.cs
+++ b/test/Autofac.Specification.Test/Features/DecoratorTests.cs
@@ -1,6 +1,7 @@
// Co... | Allow access to constructed container when deciding whether or not a decorator should be applied
## Problem Statement
There is support today for conditionally applying decorators by providing a lambda on the `RegisterDecorator` call. However, only information about the instance being decorated is provided there, so it... | OK, I can see the benefit of being able to resolve services inside the condition callback.
Might I propose though that instead of adding `IContainer` or a similar scope to the callback signature, we make `IDecoratorContext` derive from `IComponentContext`?
That means the decorator context would provide all the res... | 2022-10-02T18:06:01Z | 0.1 | [] | ['Autofac.Specification.Test.Features.DecoratorTests.DecoratorRegistrationsGetAppliedInOrderAdded', 'Autofac.Specification.Test.Features.DecoratorTests.ResolvesDecoratedServiceWhenSingleDecoratorRegistered', 'Autofac.Specification.Test.Features.DecoratorTests.StartableTypesCanBeDecorated', 'Autofac.Specification.Test.F... |
StackExchange/StackExchange.Redis | stackexchange__stackexchangeredis-2397 | 1364ef83fedb2e09035cc77ae2ac9b1b9c0ebc90 | diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
index d1cd9e7cb..dd5d92f83 100644
--- a/docs/ReleaseNotes.md
+++ b/docs/ReleaseNotes.md
@@ -8,6 +8,7 @@ Current package versions:
## Unreleased
+- Fix [#2392](https://github.com/StackExchange/StackExchange.Redis/issues/2392): Dequeue *all* timed out messages... | diff --git a/tests/StackExchange.Redis.Tests/Issues/Issue2392Tests.cs b/tests/StackExchange.Redis.Tests/Issues/Issue2392Tests.cs
new file mode 100644
index 000000000..fe3e9673d
--- /dev/null
+++ b/tests/StackExchange.Redis.Tests/Issues/Issue2392Tests.cs
@@ -0,0 +1,46 @@
+using System;
+using System.Threading.Tasks;
+u... | [FireAndForget, Timeouts] Redis won't timeout requests if there is connection issue and FireAnfForget request is queued
Hi, recently we observed that when Redis is not accessible to our microservices than they stop responding to requests. This was quite a shock as we always relayed on Redis as on service that is not g... | This seems odd; I agree that this isn't intentional but a quick glance at the code doesn't show any obvious smoking guns - the timeout detection code doesn't check for F+F, it just checks the write time - and the write time is written regardless. Will need to look.
I've forgot to mention it hangs on .NET6 and .NET7. A... | 2023-03-10T19:09:15Z | 0.1 | ['StackExchange.Redis.Tests.Issues.Issue2392Tests.Execute'] | [] |
StackExchange/StackExchange.Redis | stackexchange__stackexchangeredis-2480 | ae6419a164600b4b54dd7ce8a699efe8e98d8f1c | diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
index f60adc161..70b49d1b6 100644
--- a/docs/ReleaseNotes.md
+++ b/docs/ReleaseNotes.md
@@ -8,6 +8,8 @@ Current package versions:
## Unreleased
+- Fix [#2479](https://github.com/StackExchange/StackExchange.Redis/issues/2479): Add `RedisChannel.UseImplicitAut... | diff --git a/tests/ConsoleTest/Program.cs b/tests/ConsoleTest/Program.cs
index 1d33a968e..0d6fa7e13 100644
--- a/tests/ConsoleTest/Program.cs
+++ b/tests/ConsoleTest/Program.cs
@@ -110,7 +110,7 @@ static void ParallelRun(int taskId, ConnectionMultiplexer connection)
static void MassPublish(ConnectionMultiplexer connec... | Suggested analyzer re channel subscribe
scenario; application takes user-supplied channels, and they were using subscribe; they expected discreet channels, but a user-entered channel used a wildcard, and SE.Redis dutifully does a `PSUBSCRIBE` via the default / implicit behaviour ; bad things and possible infosec
I don... | null | 2023-06-13T13:24:46Z | 0.1 | ['StackExchange.Redis.Tests.ChannelTests.ValidateAutoPatternModeString', 'StackExchange.Redis.Tests.ChannelTests.ValidateLiteralPatternMode', 'StackExchange.Redis.Tests.ChannelTests.ValidateModeSpecifiedIgnoresGlobalSetting', 'StackExchange.Redis.Tests.ChannelTests.UseImplicitAutoPattern_OnByDefault', 'StackExchange.Re... | [] |
StackExchange/StackExchange.Redis | stackexchange__stackexchangeredis-2654 | e4cdd905480d21cd3d7ee1a65017d4aac5b6a7f5 | diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md
index 4a4b1c3fc..2098349e2 100644
--- a/docs/ReleaseNotes.md
+++ b/docs/ReleaseNotes.md
@@ -7,7 +7,8 @@ Current package versions:
| [](https://www.nuget.org/packages/StackExchange.Redi... | diff --git a/tests/StackExchange.Redis.Tests/Issues/Issue2653.cs b/tests/StackExchange.Redis.Tests/Issues/Issue2653.cs
new file mode 100644
index 000000000..973a01da5
--- /dev/null
+++ b/tests/StackExchange.Redis.Tests/Issues/Issue2653.cs
@@ -0,0 +1,16 @@
+using Xunit;
+
+namespace StackExchange.Redis.Tests.Issues;
+
... | client library metadata should validate contents
The `client setinfo lib-name` and `client setinfo lib-ver` sub-commands are picky:
``` txt
127.0.0.1:6379> client setinfo lib-name "a b"
(error) ERR lib-name cannot contain spaces, newlines or special characters.
127.0.0.1:6379> client setinfo lib-name "a-b"
OK
```
and... | null | 2024-02-23T16:34:39Z | 0.1 | ['StackExchange.Redis.Tests.Issues.Issue2653.CheckLibraySanitization'] | [] |
SixLabors/ImageSharp | sixlabors__imagesharp-2618 | ad1b0e6dadba957fa924d500900a7213bee717d3 | diff --git a/src/ImageSharp/Formats/Png/Filters/PaethFilter.cs b/src/ImageSharp/Formats/Png/Filters/PaethFilter.cs
index b8324a0809..59c903c1dd 100644
--- a/src/ImageSharp/Formats/Png/Filters/PaethFilter.cs
+++ b/src/ImageSharp/Formats/Png/Filters/PaethFilter.cs
@@ -35,9 +35,9 @@ public static void Decode(Span<byte> sc... | diff --git a/tests/ImageSharp.Tests/Formats/Png/PngDecoderFilterTests.cs b/tests/ImageSharp.Tests/Formats/Png/PngDecoderFilterTests.cs
index ec6de0dfab..f5c42c734b 100644
--- a/tests/ImageSharp.Tests/Formats/Png/PngDecoderFilterTests.cs
+++ b/tests/ImageSharp.Tests/Formats/Png/PngDecoderFilterTests.cs
@@ -170,6 +170,9 ... | PlatformNotSupportedException from Image.Load on server
### Prerequisites
- [X] I have written a descriptive issue title
- [X] I have verified that I am running the latest version of ImageSharp
- [X] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode
- [X] I have searched [open](https://github.com... | I don’t think this is a regression. There have been no changes to the scan line decoding code across those versions.
As mentioned, using the trivial repro, it works when referencing 3.0.2 and does not work when referencing 3.1.0 or 3.1.1. Isn't that the definition of a regression?
Actually, you're correct. I broke it 7... | 2023-12-12T12:57:28Z | 0.1 | ['SixLabors.ImageSharp.Tests.Formats.Png.PngDecoderFilterTests.PaethFilter_WithoutSsse3_Works'] | [] |
SixLabors/ImageSharp | sixlabors__imagesharp-2543 | 8bd273f3932f44eb664b2a217fd92f7a8e84d392 | diff --git a/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.Rational.cs b/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.Rational.cs
index 96603b182a..e4fe13fe57 100644
--- a/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.Rational.cs
+++ b/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.Rational.cs
@@ -1... | diff --git a/tests/ImageSharp.Tests/Metadata/Profiles/Exif/Values/ExifValuesTests.cs b/tests/ImageSharp.Tests/Metadata/Profiles/Exif/Values/ExifValuesTests.cs
index bf1ef1a9b0..99cafa8960 100644
--- a/tests/ImageSharp.Tests/Metadata/Profiles/Exif/Values/ExifValuesTests.cs
+++ b/tests/ImageSharp.Tests/Metadata/Profiles/... | Support for GPSHPositioningError tag?
### Prerequisites
- [X] I have written a descriptive issue title
- [X] I have verified that I am running the latest version of ImageSharp
- [X] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode
- [X] I have searched [open](https://github.com/SixLabors/ImageSh... | Hi @prabhavmehra
Just a heads up, feature requests should be made via Discussion channels not raised as issues.
You're more than welcome to submit a PR if you feel like adding the missing tag. The relevant information about the tags backing structure is here.
https://exiftool.org/TagNames/GPS.html
I can have a l... | 2023-10-05T07:04:34Z | 0.1 | [] | ['SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifLongArrayTests', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifSignedShortArrayTests', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifUndefinedTests', 'SixLabors.ImageSharp.Tests... |
SixLabors/ImageSharp | sixlabors__imagesharp-2541 | e905b0a330b4ff69ea2eb7adffa46aa676a11b7d | diff --git a/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.LongArray.cs b/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.LongArray.cs
index 741df50f2d..4767ca852e 100644
--- a/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.LongArray.cs
+++ b/src/ImageSharp/Metadata/Profiles/Exif/Tags/ExifTag.LongArray.cs
@... | diff --git a/tests/ImageSharp.Tests/Metadata/Profiles/Exif/Values/ExifValuesTests.cs b/tests/ImageSharp.Tests/Metadata/Profiles/Exif/Values/ExifValuesTests.cs
index 1adb7bd556..bf1ef1a9b0 100644
--- a/tests/ImageSharp.Tests/Metadata/Profiles/Exif/Values/ExifValuesTests.cs
+++ b/tests/ImageSharp.Tests/Metadata/Profiles/... | ExifTag.TimeZoneOffset is defined as uint[], but the TIFF spec defines it as signed short
### Prerequisites
- [X] I have written a descriptive issue title
- [X] I have verified that I am running the latest version of ImageSharp
- [X] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode
- [X] I have ... | That looks like a mistake indeed but changing this would introduce a breaking change. But I do wonder if anyone is using this since we implemented this incorrectly. Maybe we could patch this in a minor release and make a note about this minor breaking change in the release notes?
To avoid a breaking change you could at... | 2023-10-03T19:04:25Z | 0.1 | ['SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifSignedShortArrayTests'] | ['SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifLongArrayTests', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifUndefinedTests', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.Values.ExifValuesTests.ExifSignedRationalTests', 'SixLabors.ImageSharp.Tests.M... |
SixLabors/ImageSharp | sixlabors__imagesharp-2488 | 2738b3ab5793bddb96f3a5317d46afa0529220ce | diff --git a/src/ImageSharp/IO/IFileSystem.cs b/src/ImageSharp/IO/IFileSystem.cs
index 96a9b5ba01..0f5113eff4 100644
--- a/src/ImageSharp/IO/IFileSystem.cs
+++ b/src/ImageSharp/IO/IFileSystem.cs
@@ -1,4 +1,4 @@
-// Copyright (c) Six Labors.
+// Copyright (c) Six Labors.
// Licensed under the Six Labors Split License.... | diff --git a/tests/ImageSharp.Tests/IO/LocalFileSystemTests.cs b/tests/ImageSharp.Tests/IO/LocalFileSystemTests.cs
index 3d512b7d27..a1eeb25976 100644
--- a/tests/ImageSharp.Tests/IO/LocalFileSystemTests.cs
+++ b/tests/ImageSharp.Tests/IO/LocalFileSystemTests.cs
@@ -1,4 +1,4 @@
-// Copyright (c) Six Labors.
+// Copyri... | Async IO methods should use `FileOptions.Asynchronous`
### Prerequisites
- [X] I have written a descriptive issue title
- [X] I have verified that I am running the latest version of ImageSharp
- [X] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode
- [X] I have searched [open](https://github.com/... | This makes sense, here is what BCL is doing for `File.ReadAllTextAsync`:
https://github.com/dotnet/runtime/blob/2f208128f257b2390a8edefa0a19e0eaad6bd419/src/libraries/System.Private.CoreLib/src/System/IO/File.cs#L853-L856
I guess `SequentialScan` would make things worse in our case, because `BufferedReadStream` does ... | 2023-06-30T11:19:28Z | 0.1 | ['SixLabors.ImageSharp.Tests.IO.LocalFileSystemTests.CreateAsynchronous', 'SixLabors.ImageSharp.Tests.IO.LocalFileSystemTests.OpenReadAsynchronous'] | ['SixLabors.ImageSharp.Tests.IO.LocalFileSystemTests.Create', 'SixLabors.ImageSharp.Tests.IO.LocalFileSystemTests.OpenRead'] |
SixLabors/ImageSharp | sixlabors__imagesharp-2322 | df13097b46b2389d29e0af92802045a38ab7fe1c | diff --git a/src/ImageSharp/Processing/Extensions/Drawing/DrawImageExtensions.cs b/src/ImageSharp/Processing/Extensions/Drawing/DrawImageExtensions.cs
index 2cb8dc3211..ad93d6f167 100644
--- a/src/ImageSharp/Processing/Extensions/Drawing/DrawImageExtensions.cs
+++ b/src/ImageSharp/Processing/Extensions/Drawing/DrawImag... | diff --git a/tests/ImageSharp.Tests/Drawing/DrawImageTests.cs b/tests/ImageSharp.Tests/Drawing/DrawImageTests.cs
index 0dcb961f84..d017e5ad42 100644
--- a/tests/ImageSharp.Tests/Drawing/DrawImageTests.cs
+++ b/tests/ImageSharp.Tests/Drawing/DrawImageTests.cs
@@ -119,9 +119,7 @@ public void DrawImageOfDifferentPixelType... | Add DrawImage(Image, Point, Rectangle) method to the DrawImage processor
Shouldn't be hard to implement and would have better performance than `Clone -> Crop -> Draw` path.
From discussion by @TheBoneJarmer in https://github.com/SixLabors/ImageSharp/discussions/2102
| null | 2023-01-22T12:35:44Z | 0.1 | [] | ['SixLabors.ImageSharp.Tests.Drawing.DrawImageTests.NonOverlappingImageThrows'] |
SixLabors/ImageSharp | sixlabors__imagesharp-2298 | 4a618a04e7287c0fbbe92fc8f6d8267e58478240 | diff --git a/src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs b/src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs
index 2013377ed6..94c2253d18 100644
--- a/src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs
+++ b/src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs
@@ -244,6 +244,12 @@ private long WriteFrame<TPixel>(
entrie... | diff --git a/tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs b/tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs
index 7b55c1c5d0..2c30cc3d05 100644
--- a/tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs
+++ b/tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs
@@ -246,6 +246,25 @@ public void ... | created/overwritten/copied TIFF images are invalid for Adobe Premiere Pro
### Prerequisites
- [X] I have written a descriptive issue title
- [X] I have verified that I am running the latest version of ImageSharp
- [X] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode
- [X] I have searched [open](... | What is the memory stream used for in your repro? Seems unnecessary.
The following should be enough:
```
using Image<Rgba32> image = new(1920, 1080);
image.SaveAsTiff("output.tiff");
```
I kind of doubt that there is an issue with "the file header" of ImageSharp tiff's.
`tiffinfo` from `libtiff` does not report any ... | 2022-11-19T15:36:50Z | 0.1 | ['SixLabors.ImageSharp.Tests.Formats.Tiff.TiffEncoderTests.TiffEncoder_WritesIfdOffsetAtWordBoundary'] | ['SixLabors.ImageSharp.Tests.Formats.Tiff.TiffEncoderTests.EncoderOptions_SetBitPerPixel_Works', 'SixLabors.ImageSharp.Tests.Formats.Tiff.TiffEncoderTests.EncoderOptions_SetPhotometricInterpretationAndCompression_Works', 'SixLabors.ImageSharp.Tests.Formats.Tiff.TiffEncoderTests.EncoderOptions_UnsupportedBitPerPixel_Def... |
SixLabors/ImageSharp | sixlabors__imagesharp-2066 | 2bedf205277887b1d411597244cf4b0ea0d864b5 | diff --git a/src/ImageSharp/Metadata/Profiles/Exif/ExifProfile.cs b/src/ImageSharp/Metadata/Profiles/Exif/ExifProfile.cs
index e0ab8ecf95..665e4753a7 100644
--- a/src/ImageSharp/Metadata/Profiles/Exif/ExifProfile.cs
+++ b/src/ImageSharp/Metadata/Profiles/Exif/ExifProfile.cs
@@ -121,6 +121,14 @@ public IReadOnlyList<IEx... | diff --git a/tests/ImageSharp.Tests/Metadata/Profiles/Exif/ExifProfileTests.cs b/tests/ImageSharp.Tests/Metadata/Profiles/Exif/ExifProfileTests.cs
index a859852279..1668b7a125 100644
--- a/tests/ImageSharp.Tests/Metadata/Profiles/Exif/ExifProfileTests.cs
+++ b/tests/ImageSharp.Tests/Metadata/Profiles/Exif/ExifProfileTe... | Missing API : `ExifProfile.CreateThumbnail<TPixel>()`
### ImageSharp version
2.0.0
### Other ImageSharp packages and versions
na
### Environment (Operating system, version and so on)
na
### .NET Framework version
na
### Description
`ExifProfile.CreateThumbnail<TPixel>()` is missing its non-generic overload fo... | null | 2022-03-16T00:11:05Z | 0.1 | [] | ['SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.ExifProfileTests.Syncs', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.ExifProfileTests.ReadWriteLargeProfileJpg', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.ExifProfileTests.IfdStructure', 'SixLabors.ImageSharp.Tests.Metadata.Profiles.Exif.ExifProfileTes... |
SixLabors/ImageSharp | sixlabors__imagesharp-1234 | 7a538d454e535a52e2101554f11fd61f267d78c1 | diff --git a/src/ImageSharp/Configuration.cs b/src/ImageSharp/Configuration.cs
index 03e59d34b2..067257132f 100644
--- a/src/ImageSharp/Configuration.cs
+++ b/src/ImageSharp/Configuration.cs
@@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0.
using System;
+using System.Collections.Concurrent;
using... | diff --git a/tests/ImageSharp.Tests/GraphicOptionsDefaultsExtensionsTests.cs b/tests/ImageSharp.Tests/GraphicOptionsDefaultsExtensionsTests.cs
index 72ec355385..21f26cd01c 100644
--- a/tests/ImageSharp.Tests/GraphicOptionsDefaultsExtensionsTests.cs
+++ b/tests/ImageSharp.Tests/GraphicOptionsDefaultsExtensionsTests.cs
@... | context.BackgroundColor throws Object reference not set to an instance of an object.
### Prerequisites
- [x] I have written a descriptive issue title
- [x] I have verified that I am running the latest version of ImageSharp
- [x] I have verified if the problem exist in both `DEBUG` and `RELEASE` mode
- [x] I have ... | > It happens sometimes when I compile & run this code.
What do you mean by this, Is the issue intermittent? What environmental factors trigger a difference in result.
Are you running this in multiple threads? | 2020-06-16T21:09:47Z | 0.1 | ['SixLabors.ImageSharp.Tests.GraphicOptionsDefaultsExtensionsTests.CanGetGraphicsOptionsMultiThreaded'] | [] |
devlooped/moq | devlooped__moq-1081 | 5077cec3ff2a493fe8713541dd925f751bffdb2e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index eb4b92aad..129245883 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1
#### Fixed
* `SetupProperty` fails if property getter and setter are not both defined in mocked type (@s... | diff --git a/tests/Moq.Tests/Regressions/IssueReportsFixture.cs b/tests/Moq.Tests/Regressions/IssueReportsFixture.cs
index 0416c4bad..337376404 100644
--- a/tests/Moq.Tests/Regressions/IssueReportsFixture.cs
+++ b/tests/Moq.Tests/Regressions/IssueReportsFixture.cs
@@ -3451,6 +3451,52 @@ public class DatabaseOptions
... | Issue comparing Expressions when one value is a constant
I have discovered an issue when using Expressions in a Setup on a mock object.
It seems using a simple comparison Expression fails to match properly when comparing to a string constant.
The below code should reproduce it:
```
[Test]
public async Task Exp... | For now I can work around by simply assigning a local variable in the test from the constant and using that instead.
Referencing a constant vs. a variable results in slightly different LINQ expression trees: in the former case, the string value gets embedded as a constant, while in the latter case, the variable gets ca... | 2020-10-26T21:46:00Z | 0.1 | ['Moq.Tests.Regressions.IssueReportsFixture+Issue1054.String_constant', 'Moq.Tests.Regressions.IssueReportsFixture+Issue1054.String_variable'] | [] |
devlooped/moq | devlooped__moq-1079 | 53231362ec8e8d70af4fc63de2eacfa97cd9b6a3 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f6cbe09c3..eb4b92aad 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,10 @@ The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1
* New method overloads for `It.Is`, `It.IsIn`, and `It.IsNotIn` that compare values using a custom `IEqual... | diff --git a/tests/Moq.Tests/StubExtensionsFixture.cs b/tests/Moq.Tests/StubExtensionsFixture.cs
index 7e109a5b5..982dbc207 100644
--- a/tests/Moq.Tests/StubExtensionsFixture.cs
+++ b/tests/Moq.Tests/StubExtensionsFixture.cs
@@ -276,6 +276,15 @@ public void SetupProperty_retains_value_of_derived_read_write_property_tha... | `SetupProperty` fails if property getter and setter are not both defined in mocked type
This is basically #886 again, which was fixed for `SetupAllProperties` but not for `SetupProperty`.
### Reproduction code:
```csharp
public class Base
{
public virtual object P { get; set; }
}
public class Derived :... | null | 2020-10-22T20:20:34Z | 0.1 | ['Moq.Tests.StubExtensionsFixture.SetupProperty_retains_value_of_derived_read_write_property_that_overrides_only_getter'] | [] |
devlooped/moq | devlooped__moq-1077 | 531974cb32f71af38a48559fc912ab42ec0b80c2 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d50a10327..f6cbe09c3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,7 +10,7 @@ The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1
#### Added
* New method overloads for `It.Is`, `It.IsIn`, and `It.IsNotIn` that compare values using a c... | diff --git a/tests/Moq.Tests/InvocationsFixture.cs b/tests/Moq.Tests/InvocationsFixture.cs
index d67258d30..8e4558a4f 100644
--- a/tests/Moq.Tests/InvocationsFixture.cs
+++ b/tests/Moq.Tests/InvocationsFixture.cs
@@ -2,6 +2,8 @@
// All rights reserved. Licensed under the BSD 3-Clause License; see License.txt.
using... | `IInvocation` should expose `Exception` along with `ReturnValue`
#921 which just got merged added a `ReturnValue` property to `IInvocation`, which allows user code to find out what got returned from a mocked invocation. The author of that PR (@MaStr11) suggested that an `Exception` property also be added for similar re... | > P.S. @MaStr11: In case you were wondering where we stand regarding thrown exceptions, I didn't forget about it, but thought it would be cleaner to do that in a separate PR, to keep this one as straightforward as it was.
> If you would like to submit a PR that adds an Exception Exception { get; } property to IInvoc... | 2020-10-14T16:22:53Z | 0.1 | ['Moq.Tests.InvocationsFixture.MockInvocationsIncludeReturnValue_NoSetup', 'Moq.Tests.InvocationsFixture.MockInvocationsIncludeReturnValue_Setup', 'Moq.Tests.InvocationsFixture.MockInvocationsIncludeReturnValue_BaseCall', 'Moq.Tests.InvocationsFixture.MockInvocationsIncludeReturnValue_ReturnsException', 'Moq.Tests.Invo... | [] |
devlooped/moq | devlooped__moq-1076 | 5b8fbc477a67fc36415e3114cb4a4a4492a91e4c | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6a29c291e..e5124dc4d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,7 @@ The format is loosely based on [Keep a Changelog](http://keepachangelog.com/en/1
* Setup not triggered due to VB.NET transparently inserting superfluous type conversions into a setup expre... | diff --git a/tests/Moq.Tests/ComCompatibilityFixture.cs b/tests/Moq.Tests/ComCompatibilityFixture.cs
index a6f07a6b7..43234ccc0 100644
--- a/tests/Moq.Tests/ComCompatibilityFixture.cs
+++ b/tests/Moq.Tests/ComCompatibilityFixture.cs
@@ -1,6 +1,9 @@
// Copyright (c) 2007, Clarius Consulting, Manas Technology Solutions,... | Mock.Of of Excel interop classes fails to initialize
I have a project that has a lot of tests on Excel interop classes.
Those were working fine with my current test project (net452, Moq 4.8, Microsoft.Office.Interop.Excel v12.0.4518.1014, NUnit v3.12...)
But after upgrading to Moq 4.14 & Microsoft.Office.Interop.... | > But after upgrading to Moq 4.14 & Microsoft.Office.Interop.Excel v15.0.4795.1000
@killergege, ~~can you tell which of the two updates causes the issue?~~ That must be due to the interop update, because I can reproduce the problem you're seeing with all versions of Moq, going all the way back to 4.0.0. I cannot cur... | 2020-10-13T21:40:02Z | 0.1 | ['Moq.Tests.ComCompatibilityFixture.Can_create_mock_of_Excel_Workbook_using_Mock_Of_1', 'Moq.Tests.ComCompatibilityFixture.Can_create_mock_of_Excel_Workbook_using_Mock_Of_2'] | [] |
ThreeMammals/Ocelot | threemammals__ocelot-1790 | d3a623ee7ae6de00b939fd847cc7cef6d4c89276 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 4a5f1d936..09178e49c 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -4,13 +4,13 @@ orbs:
jobs:
build:
docker:
- - image: mijitt0m/ocelot-build:0.0.9
+ - image: ocelot2/circleci-build:8.21.0
steps:
- chec... | diff --git a/test/Ocelot.AcceptanceTests/CachingTests.cs b/test/Ocelot.AcceptanceTests/CachingTests.cs
index 95f6f5166..b2ef34d6c 100644
--- a/test/Ocelot.AcceptanceTests/CachingTests.cs
+++ b/test/Ocelot.AcceptanceTests/CachingTests.cs
@@ -211,7 +211,7 @@ private void GivenThereIsAServiceRunningOn(string url, int stat... | Ocelot to .NET 8
## Expected Behavior / New Feature
[.NET 8 was launched this week](https://devblogs.microsoft.com/dotnet/announcing-dotnet-8/), so we expect Ocelot to be compatible with .NET 8 as soon as possible. 😸
- [Announcing .NET 8 | .NET Blog](https://devblogs.microsoft.com/dotnet/announcing-dotnet-8/) by G... | ⚠️⚠️⚠️
❗Important❗
Feature branch is [release/net8](https://github.com/ThreeMammals/Ocelot/tree/release/net8). It is created from **main**.
Delivery process is based on Gitflow Hotfix one.
That means, this feature (upgrade) should be delivered first, before [Oct'23](../milestone/1)!
> Tests and examples are targeti... | 2023-11-19T23:55:14Z | 0.1 | [] | ['Ocelot.UnitTests.Responder.HttpContextResponderTests.should_remove_transfer_encoding_header', 'Ocelot.UnitTests.Responder.HttpContextResponderTests.should_ignore_content_if_null', 'Ocelot.UnitTests.Responder.HttpContextResponderTests.should_have_content_length', 'Ocelot.UnitTests.Headers.AddHeadersToResponseTests.sho... |
ThreeMammals/Ocelot | threemammals__ocelot-1789 | d3a623ee7ae6de00b939fd847cc7cef6d4c89276 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 4a5f1d936..cbdcf7c9d 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -4,13 +4,13 @@ orbs:
jobs:
build:
docker:
- - image: mijitt0m/ocelot-build:0.0.9
+ - image: ocelot2/circleci-build:latest
steps:
- chec... | diff --git a/test/Ocelot.AcceptanceTests/CachingTests.cs b/test/Ocelot.AcceptanceTests/CachingTests.cs
index 95f6f5166..b2ef34d6c 100644
--- a/test/Ocelot.AcceptanceTests/CachingTests.cs
+++ b/test/Ocelot.AcceptanceTests/CachingTests.cs
@@ -211,7 +211,7 @@ private void GivenThereIsAServiceRunningOn(string url, int stat... | Ocelot to .NET 8
## Expected Behavior / New Feature
[.NET 8 was launched this week](https://devblogs.microsoft.com/dotnet/announcing-dotnet-8/), so we expect Ocelot to be compatible with .NET 8 as soon as possible. 😸
- [Announcing .NET 8 | .NET Blog](https://devblogs.microsoft.com/dotnet/announcing-dotnet-8/) by G... | null | 2023-11-19T00:44:55Z | 0.1 | [] | ['Ocelot.UnitTests.LoadBalancer.LeastConnectionTests.should_be_able_to_lease_and_release_concurrently', 'Ocelot.UnitTests.LoadBalancer.LeastConnectionTests.should_handle_service_returning_to_available', 'Ocelot.UnitTests.LoadBalancer.LeastConnectionTests.should_serve_from_service_with_least_connections', 'Ocelot.UnitTe... |
ThreeMammals/Ocelot | threemammals__ocelot-1769 | 319e397d4078e6e3496cd925d715cbc3b8c589df | diff --git a/src/Ocelot/Errors/OcelotErrorCode.cs b/src/Ocelot/Errors/OcelotErrorCode.cs
index 9063e7142..f74cdace1 100644
--- a/src/Ocelot/Errors/OcelotErrorCode.cs
+++ b/src/Ocelot/Errors/OcelotErrorCode.cs
@@ -43,5 +43,6 @@ public enum OcelotErrorCode
ConnectionToDownstreamServiceError = 38,
CouldN... | diff --git a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
index 390879fc4..bb1399943 100644
--- a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
+++ b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
@@ -69,6 +69,7 @@
<Pac... | Bad error handling for IOException while reading incoming request body
## Expected Behavior
If an `IOException` happens while reading the incoming request body (in `RequestMapper.MapContent` [here](https://github.com/ThreeMammals/Ocelot/blob/02e5cea7b1bdd3d78cfe1a5bb688383f54a809fc/src/Ocelot/Request/Mapper/RequestM... | I think [413 Payload Too Large](https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/413) is a better error code. What do you guys think?
@TomPallister
>@davidni commented [on Jan 15, 2019](#issue-399093900)
David, thanks for reporting!
I don't see any PRs from you...
Is it still relevant? The issue was crea... | 2023-10-31T13:27:43Z | 0.1 | ['Ocelot.AcceptanceTests.Requester.PayloadTooLargeTests.Should_throw_payload_too_large_exception_using_kestrel', 'Ocelot.UnitTests.Responder.ErrorsToHttpStatusCodeMapperTests.should_return_request_entity_too_large', 'Ocelot.UnitTests.Responder.ErrorsToHttpStatusCodeMapperTests.check_we_have_considered_all_errors_in_the... | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-18694 | b16975cb0402cd10358f17135d25c3dd3aac7ac6 | diff --git a/src/Avalonia.Controls/DataValidationErrors.cs b/src/Avalonia.Controls/DataValidationErrors.cs
index 243032e725c..f11c6210304 100644
--- a/src/Avalonia.Controls/DataValidationErrors.cs
+++ b/src/Avalonia.Controls/DataValidationErrors.cs
@@ -18,7 +18,6 @@ namespace Avalonia.Controls
[PseudoClasses(":err... | diff --git a/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs b/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs
index 67f55055ec8..d13a25f2105 100644
--- a/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs
@@ -421,6 +421,28 @@ pu... | DataValidationErrors not working correctly with Bindings (in AutoCompleteBox control)
### Describe the bug
When using Bindings to synchronize `DataValidationErrors.Errors` for one control with the `DataValidationErrors.Errors` property of another control, the secondary control's `DataValidationErrors.HasErrors` proper... | null | 2025-04-20T13:41:07Z | 0.1 | ['Avalonia.Controls.UnitTests.AutoCompleteBoxTests.Text_Validation_TextBox_Errors_Binding'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-18634 | f42af483c9760dd2d164972b1ea8484dbeb36cfe | diff --git a/src/Avalonia.Controls/ItemCollection.cs b/src/Avalonia.Controls/ItemCollection.cs
index 03f46551c5f..03fed042bec 100644
--- a/src/Avalonia.Controls/ItemCollection.cs
+++ b/src/Avalonia.Controls/ItemCollection.cs
@@ -11,15 +11,10 @@ namespace Avalonia.Controls
/// </summary>
public class ItemColle... | diff --git a/tests/Avalonia.Controls.UnitTests/Primitives/SelectingItemsControlTests.cs b/tests/Avalonia.Controls.UnitTests/Primitives/SelectingItemsControlTests.cs
index 5c1ece224ad..13c6ee50a5b 100644
--- a/tests/Avalonia.Controls.UnitTests/Primitives/SelectingItemsControlTests.cs
+++ b/tests/Avalonia.Controls.UnitTe... | Datagrid ComboBox SelectedItem Show Error
### Describe the bug
// DataType ComboBox ItemsSource,this show OK
public static List<string> DataTypes =>
Enum.GetNames(typeof(DataTypeEnum)).ToList();
// DataType2 ComboBox ... | demo
[DatagridDemo.zip](https://github.com/user-attachments/files/19662338/DatagridDemo.zip)
This is not a bug. The reason is that the binding for `SelectedItem` may complete before the binding for `ItemsSource`, making your initial value setting ineffective. In this case, the `SelectedItem` you set does not exist in t... | 2025-04-12T15:27:20Z | 0.1 | ['Avalonia.Controls.UnitTests.Primitives.SelectingItemsControlTests.Setting_SelectedIndex_Out_Of_Bounds_Without_ItemsSource_Should_Keep_Selection_Until_ItemsSource_Is_Set', 'Avalonia.Controls.UnitTests.Primitives.SelectingItemsControlTests.Setting_SelectedIndex_Without_ItemsSource_Should_Keep_Selection_If_Index_Exists_... | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17326 | fe0b91d5417632721b8733c17a0db709f687734f | diff --git a/src/Avalonia.Base/Input/IInputRoot.cs b/src/Avalonia.Base/Input/IInputRoot.cs
index 2be58472207..c1c5968ebe3 100644
--- a/src/Avalonia.Base/Input/IInputRoot.cs
+++ b/src/Avalonia.Base/Input/IInputRoot.cs
@@ -12,7 +12,7 @@ public interface IInputRoot : IInputElement
/// <summary>
/// Gets ... | diff --git a/tests/Avalonia.Controls.UnitTests/FlyoutTests.cs b/tests/Avalonia.Controls.UnitTests/FlyoutTests.cs
index dad8c3b78e7..d748a709a56 100644
--- a/tests/Avalonia.Controls.UnitTests/FlyoutTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/FlyoutTests.cs
@@ -20,6 +20,8 @@ namespace Avalonia.Controls.UnitTests
{
... | OverlayPopups is True affects the “down” key of the combox
### Describe the bug
.With(new Win32PlatformOptions
{
OverlayPopups = true,
}
'down' keys not working
### To Reproduce
1. .With(new Win32PlatformOptions
... | null | 2024-10-22T15:45:46Z | 0.1 | ['Avalonia.Controls.UnitTests.FlyoutTests.ShowMode_Standard_Attemps_Focus_Flyout_Content', 'Avalonia.Controls.UnitTests.OverlayPopupFlyoutTests.ShowMode_Standard_Attemps_Focus_Flyout_Content', 'Avalonia.Controls.UnitTests.Primitives.PopupTests.Focusable_Controls_In_Popup_Should_Get_Focus', 'Avalonia.Controls.UnitTests.... | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17292 | 9cecb90ba1e681d1783e3a89db4b8d860859550f | diff --git a/api/Avalonia.nupkg.xml b/api/Avalonia.nupkg.xml
index 1edc3b5ec25..f6797ada377 100644
--- a/api/Avalonia.nupkg.xml
+++ b/api/Avalonia.nupkg.xml
@@ -91,4 +91,10 @@
<Left>baseline/netstandard2.0/Avalonia.Controls.dll</Left>
<Right>target/netstandard2.0/Avalonia.Controls.dll</Right>
</Suppression... | diff --git a/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs b/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs
index ed1061e85a9..0fd1e318661 100644
--- a/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Input/AccessKeyHandlerTests.cs
@@ -142,68 ... | Duplicate Accelerator Keys don't work for nested MenuItem Headers
**Describe the bug**
```xaml
<Menu>
<MenuItem Header="_File">
<MenuItem Header="_New Project"/>
<MenuItem Header="_Open Project"/>
<MenuItem Header="_Save Project"/>
</MenuItem>
<MenuItem Header="_Edit">
... | Looking a bit around in the code I guess you'd have to change the [`MenuItemAccessKeyHandler`](https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/MenuItemAccessKeyHandler.cs) and [`AccessText`](https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/Primitives/AccessText.cs) to be... | 2024-10-16T13:02:54Z | 0.1 | ['Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Raise_AccessKey_For_Registered_Access_Key_When_Effectively_Enabled'] | ['Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Raise_AccessKey_For_Registered_Access_Key', 'Avalonia.Base.UnitTests.Input.AccessKeyHandlerTests.Should_Open_MainMenu_On_Alt_KeyUp', 'Avalonia.Base.UnitTests.Input.InputElement_Focus.Focus_Should_Not_Get_Restored_To_Enabled_Control', 'Avalonia.Controls.UnitTe... |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17209 | d3aa0c21e39a759e358fa7c3a90d3422fb19ecbf | diff --git a/src/Avalonia.Base/Media/TextFormatting/BidiReorderer.cs b/src/Avalonia.Base/Media/TextFormatting/BidiReorderer.cs
index 85fea48edb8..0612ecf8e02 100644
--- a/src/Avalonia.Base/Media/TextFormatting/BidiReorderer.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/BidiReorderer.cs
@@ -169,7 +169,7 @@ private sta... | diff --git a/tests/Avalonia.Skia.UnitTests/Media/TextFormatting/TextFormatterTests.cs b/tests/Avalonia.Skia.UnitTests/Media/TextFormatting/TextFormatterTests.cs
index 83c5fc377c8..5ff0a45e390 100644
--- a/tests/Avalonia.Skia.UnitTests/Media/TextFormatting/TextFormatterTests.cs
+++ b/tests/Avalonia.Skia.UnitTests/Media/... | Wrapped RTL text has extra bottom padding
### Describe the bug
Looks like space for one more line is allocated.
### To Reproduce
https://github.com/kerams/font2
### Expected behavior
LTR and RTL wrappe... | null | 2024-10-07T21:13:28Z | 0.1 | [] | ['Avalonia.Skia.UnitTests.Media.TextFormatting.TextFormatterTests.Should_Format_TextLine_With_Non_Text_TextRuns_RightToLeft'] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-15498 | e38edb258d6fe0855a0643ede0ffc18c2a214960 | diff --git a/src/Avalonia.Controls/Selection/ReadOnlySelectionListBase.cs b/src/Avalonia.Controls/Selection/ReadOnlySelectionListBase.cs
new file mode 100644
index 00000000000..f603fd81686
--- /dev/null
+++ b/src/Avalonia.Controls/Selection/ReadOnlySelectionListBase.cs
@@ -0,0 +1,58 @@
+using System;
+using System.Col... | diff --git a/tests/Avalonia.Controls.UnitTests/Selection/SelectionModelTests_Single.cs b/tests/Avalonia.Controls.UnitTests/Selection/SelectionModelTests_Single.cs
index 64236268f8e..f4dbdf54180 100644
--- a/tests/Avalonia.Controls.UnitTests/Selection/SelectionModelTests_Single.cs
+++ b/tests/Avalonia.Controls.UnitTests... | Unable to bind to `SelectionModel.SelectedItems` or `SelectedIndexes`
### Describe the bug
Reported by a customer:
Binding `ItemsControl.ItemsSource` to `SelectionModel.SelectedItems` or `SelectionModel.SelectedIndexes` does not work.
`SelectionModel` raises a `PropertyChanged` event on `SelectedItems` and `Sele... | null | 2024-04-24T11:56:47Z | 0.1 | ['Avalonia.Controls.UnitTests.Selection.SelectionModelTests_Single+SelectedIndexes.CollectionChanged_Is_Raised_When_SelectedIndex_Changes', 'Avalonia.Controls.UnitTests.Selection.SelectionModelTests_Single+SelectedItems.CollectionChanged_Is_Raised_When_SelectedIndex_Changes'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-15493 | d4339e4b0ad37a03363d6b67a7f0cf4b4f676f38 | diff --git a/samples/ControlCatalog/Pages/ToolTipPage.xaml b/samples/ControlCatalog/Pages/ToolTipPage.xaml
index fa40bc1a0fa..8aaed903f36 100644
--- a/samples/ControlCatalog/Pages/ToolTipPage.xaml
+++ b/samples/ControlCatalog/Pages/ToolTipPage.xaml
@@ -77,12 +77,23 @@
</Button>
<Border Grid.Ro... | diff --git a/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs b/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs
index 8dafef7e182..6199a208720 100644
--- a/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/ToolTipTests.cs
@@ -368,6 +368,87 @@ public void New_ToolTip_Replaces_O... | Add Control.ToolTipOpening/ToolTipClosing events
### Is your feature request related to a problem? Please describe.
WPF implements attached `ToolTipService.ToolTipOpening` and `ToolTipClosing` events that are `AddOwner`-ed on `FrameworkElement`, thereby adding [FrameworkElement.ToolTipOpening](https://learn.microsoft.... | null | 2024-04-24T04:13:15Z | 0.1 | ['Avalonia.Controls.UnitTests.ToolTipTests_Popup.ToolTip_Events_Order_Is_Defined', 'Avalonia.Controls.UnitTests.ToolTipTests_Overlay.ToolTip_Events_Order_Is_Defined', 'Avalonia.Controls.UnitTests.ToolTipTests_Popup.ToolTip_Is_Not_Opened_If_Opening_Event_Handled', 'Avalonia.Controls.UnitTests.ToolTipTests_Overlay.ToolTi... | [] |
ardalis/CleanArchitecture | ardalis__cleanarchitecture-918 | 9b93751ebda2b4268847b150fb026bb0fba71b89 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 34d88c6f5..f29e23129 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -15,7 +15,6 @@
<PackageVersion Include="FastEndpoints.ApiExplorer" Version="2.2.0" />
<PackageVersion Include="FastEndpoints.Swagger" Version="5.3... | diff --git a/tests/Clean.Architecture.FunctionalTests/ApiEndpoints/ContributorGetById.cs b/tests/Clean.Architecture.FunctionalTests/ApiEndpoints/ContributorGetById.cs
index cfe4b05c4..4317d275e 100644
--- a/tests/Clean.Architecture.FunctionalTests/ApiEndpoints/ContributorGetById.cs
+++ b/tests/Clean.Architecture.Functi... | Remove FluentAssertions since it's now a commercial product
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
| Will you replace by what ? Thks
Shouldly. It's pretty much a drop in replacement.
For those looking to tackle this issue, this blog post might help: https://blog.nimblepros.com/blogs/getting-started-with-shouldly/ | 2025-02-05T09:56:15Z | 0.1 | ['Clean.Architecture.FunctionalTests.ApiEndpoints.ContributorGetById.ReturnsSeedContributorGivenId1', 'Clean.Architecture.FunctionalTests.ApiEndpoints.ContributorList.ReturnsTwoContributors', 'Clean.Architecture.IntegrationTests.Data.EfRepositoryAdd.AddsContributorAndSetsId', 'Clean.Architecture.IntegrationTests.Data.E... | [] |
JoshClose/CsvHelper | joshclose__csvhelper-2132 | 9848510ed0fc0980bda687882c5ea123b7d7d3ce | diff --git a/src/CsvHelper.Website/input/examples/configuration/attributes/index.md b/src/CsvHelper.Website/input/examples/configuration/attributes/index.md
index 871798f14..41c588d41 100644
--- a/src/CsvHelper.Website/input/examples/configuration/attributes/index.md
+++ b/src/CsvHelper.Website/input/examples/configura... | diff --git a/tests/CsvHelper.Tests/Mappings/Attribute/AllowCommentsTests.cs b/tests/CsvHelper.Tests/Mappings/Attribute/AllowCommentsTests.cs
index e5fb1ebf9..f417c19ba 100644
--- a/tests/CsvHelper.Tests/Mappings/Attribute/AllowCommentsTests.cs
+++ b/tests/CsvHelper.Tests/Mappings/Attribute/AllowCommentsTests.cs
@@ -14,... | New class level attributes are ignored, e.g. DelimiterAttribute
I have been experimenting with the new class level attributes for things like Delimiter, HasHeaderRecord, IgnoreBlankLines, etc. which were introduced in version 30.0.0. However, they don't appear to be working and they are ignored.
```c#
[Delimiter("|")... | You need to either pass the `Type` into the constructor or call `ApplyAttributes`.
```cs
new CsvConfiguration(CultureInfo.InvariantCulture, typeof(Result));
// or
new CsvConfiguration(CultureInfo.InvariantCulture).ApplyAttributes<Result>();
// or
new CsvConfiguration(CultureInfo.InvariantCulture).ApplyAttribute... | 2023-02-25T15:37:45Z | 0.1 | ['CsvHelper.Tests.AttributeMapping.AllowCommentsTests.AllowCommentsTest', 'CsvHelper.Tests.Mappings.Attribute.CacheFieldsTests.ConstructorAttributeTest', 'CsvHelper.Tests.Mappings.Attribute.CountBytesTest.ConstructorAttributeTest', 'CsvHelper.Tests.Mappings.Attribute.DetectColumnCountChangesTests.ConstructorAttributeTe... | ['CsvHelper.Tests.Mappings.ConstructorParameter.CultureInfoAttributeTests.AutoMap_WithCultureInfoAttributes_ConfiguresParameterMaps', 'CsvHelper.Tests.Mappings.ConstructorParameter.CultureInfoAttributeTests.AutoMap_WithCultureInfoAttributes_ConfiguresMemberMaps', 'CsvHelper.Tests.Mappings.ConstructorParameter.CultureIn... |
autofac/Autofac | autofac__autofac-1451 | 07cac9047f4059de2d72834042c9649cbd228085 | diff --git a/src/Autofac/Builder/RegistrationData.cs b/src/Autofac/Builder/RegistrationData.cs
index f14e6bcfb..4e5ba29bf 100644
--- a/src/Autofac/Builder/RegistrationData.cs
+++ b/src/Autofac/Builder/RegistrationData.cs
@@ -17,7 +17,7 @@ public class RegistrationData
private bool _defaultServiceOverridden;
p... | diff --git a/test/Autofac.Specification.Test/Features/StartableTests.cs b/test/Autofac.Specification.Test/Features/StartableTests.cs
index ed3b1ee71..e993e9785 100644
--- a/test/Autofac.Specification.Test/Features/StartableTests.cs
+++ b/test/Autofac.Specification.Test/Features/StartableTests.cs
@@ -168,6 +168,26 @@ pu... | `AutoActivate()` hides a registration's default "self" service
## Describe the Bug
A registration like `builder.Register<A>()` defaults to exposing the typed service `A` on the component.
Adding `AutoActivate()` to the registration hides this default. Since the name `AutoActivate()` doesn't suggest that it has anythi... | I don't think it's by design, I'm guessing we just don't have a test for the issue mentioned. It'd be awesome to get a PR for it if you're able. Thanks!
I don't think it's by design, I'm guessing we just don't have a test for the issue mentioned. It'd be awesome to get a PR for it if you're able. Thanks! | 2025-03-28T01:10:10Z | 0.1 | ['Autofac.Specification.Test.Features.StartableTests.AutoActivate_DoesNotHideDefaultSelfService', 'Autofac.Specification.Test.Features.StartableTests.AutoActivate_RegisterInstanceActivationWorksWhenDefaultServiceOverloaded'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17657 | f4633e210c23ff7fbaec3cf402d03deac5315a68 | diff --git a/src/Avalonia.Base/Matrix.cs b/src/Avalonia.Base/Matrix.cs
index a72710ffd4a..5f5aab4f47f 100644
--- a/src/Avalonia.Base/Matrix.cs
+++ b/src/Avalonia.Base/Matrix.cs
@@ -214,6 +214,21 @@ public static Matrix CreateRotation(double radians)
return new Matrix(cos, sin, -sin, cos, 0, 0);
}
... | diff --git a/tests/Avalonia.Base.UnitTests/MatrixTests.cs b/tests/Avalonia.Base.UnitTests/MatrixTests.cs
index d111c142581..9fccdf25fce 100644
--- a/tests/Avalonia.Base.UnitTests/MatrixTests.cs
+++ b/tests/Avalonia.Base.UnitTests/MatrixTests.cs
@@ -61,6 +61,20 @@ public void Transform_Point_Should_Return_Correct_Value_... | Add Matrix.Rotate(angle, x, y) overload
### Is your feature request related to a problem? Please describe.
This is not a standard css transformation, but a frequently used in svg.
### Describe the solution you'd like
as described.
### Describe alternatives you've considered
_No response_
### Additional context
... | null | 2024-12-01T07:07:57Z | 0.1 | ['Avalonia.Visuals.UnitTests.MatrixTests.Transform_Point_Should_Return_Correct_Value_For_Rotate_Matrix_With_Center_Point'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17638 | 1583de3e33459f174b09307baffbaba4f6987116 | diff --git a/src/Avalonia.Controls/SelectableTextBlock.cs b/src/Avalonia.Controls/SelectableTextBlock.cs
index 8f1248027c5..b0fd78b321e 100644
--- a/src/Avalonia.Controls/SelectableTextBlock.cs
+++ b/src/Avalonia.Controls/SelectableTextBlock.cs
@@ -224,12 +224,14 @@ protected override TextLayout CreateTextLayout(string... | diff --git a/tests/Avalonia.Controls.UnitTests/TextBlockTests.cs b/tests/Avalonia.Controls.UnitTests/TextBlockTests.cs
index 3d7c6e6c1bd..4a7281fae3a 100644
--- a/tests/Avalonia.Controls.UnitTests/TextBlockTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/TextBlockTests.cs
@@ -1,3 +1,4 @@
+using System;
using Avalonia.... | Changing TextBlock.Text placed inside an infinite-sized invisible container doesn't re-measure the TextBlock
### Describe the bug
Inside a container which is infinite on both sides and invisible, changing the `Text` of a `TextBlock`, then making the container visible, doesn't re-measure the TextBlock: the text is effe... | null | 2024-11-28T15:44:21Z | 0.1 | [] | ['Avalonia.Controls.UnitTests.TextBlockTests.TextBlock_TextLines_Should_Be_Empty', 'Avalonia.Controls.UnitTests.TextBlockTests.Calling_Measure_Should_Update_TextLayout', 'Avalonia.Controls.UnitTests.TextBlockTests.DefaultBindingMode_Should_Be_OneWay', 'Avalonia.Controls.UnitTests.TextBlockTests.Changing_InlinesCollecti... |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17465 | b35fd5a890f3b1f94bec19f6f9557a255805cc67 | diff --git a/src/Avalonia.Controls/CalendarDatePicker/CalendarDatePicker.cs b/src/Avalonia.Controls/CalendarDatePicker/CalendarDatePicker.cs
index ec54533f4e1..eaf632039b8 100644
--- a/src/Avalonia.Controls/CalendarDatePicker/CalendarDatePicker.cs
+++ b/src/Avalonia.Controls/CalendarDatePicker/CalendarDatePicker.cs
@@ ... | diff --git a/tests/Avalonia.Controls.UnitTests/CalendarDatePickerTests.cs b/tests/Avalonia.Controls.UnitTests/CalendarDatePickerTests.cs
index c3acf31caa7..013369f102a 100644
--- a/tests/Avalonia.Controls.UnitTests/CalendarDatePickerTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/CalendarDatePickerTests.cs
@@ -1,17 +1... | CustomDateFormatString is not used for text input in CalendarDatePicker
### Describe the bug
The CalendarDatePicker with a CustomDateFormatString seems to display the date correctly but ignores the custom date format when the date is entered by keyboard.
### To Reproduce
1. Create a CalendarDatePicker with CustomDat... | @JokaDev without looking too deep into, I think you may be right. Maybe you can file a PR to fix it? Adding some tests if possible would be great. | 2024-11-10T13:23:01Z | 0.1 | ['Avalonia.Controls.UnitTests.CalendarDatePickerTests.Setting_Date_Manually_With_CustomDateFormatString_Should_Be_Accepted'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17462 | b46126714b72635b6fb699e679a8f103d5449105 | diff --git a/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.cs b/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.cs
index 95ea8f9ece2..b142ce5eb2d 100644
--- a/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.cs
+++ b/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.cs
@@ -812,7 +812,11 @@ privat... | diff --git a/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs b/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs
index 5cc3901cd74..67f55055ec8 100644
--- a/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/AutoCompleteBoxTests.cs
@@ -1,4 +1,4 @@
-using... | AutoCompleteBox loses selection when context menu opened
### Describe the bug
Selection of text get lost when context menu opened.
Moreover, small part of selection (not empty) is expanded to full selection at first time and lost too.
### To Reproduce
1. Write text in AutoCompleteBox
2. Select part of text (or n... | @isergvb if you want to apply a similar fix to that control, a PR is welcome. | 2024-11-09T21:50:54Z | 0.1 | ['Avalonia.Controls.UnitTests.AutoCompleteBoxTests.Opening_Context_Menu_Does_not_Lose_Selection'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17178 | 9d54429c304018540d72eb0a508f79c8088d4182 | diff --git a/src/Avalonia.Controls/SplitView/SplitView.cs b/src/Avalonia.Controls/SplitView/SplitView.cs
index fed0367d122..fd6fd98de69 100644
--- a/src/Avalonia.Controls/SplitView/SplitView.cs
+++ b/src/Avalonia.Controls/SplitView/SplitView.cs
@@ -297,6 +297,7 @@ protected override void OnApplyTemplate(TemplateApplied... | diff --git a/tests/Avalonia.Controls.UnitTests/SplitViewTests.cs b/tests/Avalonia.Controls.UnitTests/SplitViewTests.cs
index 9b43c469ba2..47383fa9ad9 100644
--- a/tests/Avalonia.Controls.UnitTests/SplitViewTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/SplitViewTests.cs
@@ -1,5 +1,7 @@
-using Avalonia.Input;
+using... | SplitView ":open"/":closed" pseudoclasses aren't set on control initialization
### Describe the bug
SplitView control after it initialized does not have `:open` or `:closed` pseudoclass set. Regardless of the value in the `IsPaneOpen` property.
### To Reproduce
Create Window with a SplitView control, set IsPaneOp... | @OccVeneficus if you have an idea how to solve it, a PR is welcome.
@OccVeneficus if you have an idea how to solve it, a PR is welcome. | 2024-10-01T19:21:33Z | 0.1 | ['Avalonia.Controls.UnitTests.SplitViewTests.With_Default_IsPaneOpen_Value_Should_Have_Closed_Pseudo_Class_Set'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17171 | b272283e5057d65617246b9ebf64c4e0e281d88b | diff --git a/src/Avalonia.Base/Collections/AvaloniaDictionaryExtensions.cs b/src/Avalonia.Base/Collections/AvaloniaDictionaryExtensions.cs
index 8c731c188f4..dfd62259e43 100644
--- a/src/Avalonia.Base/Collections/AvaloniaDictionaryExtensions.cs
+++ b/src/Avalonia.Base/Collections/AvaloniaDictionaryExtensions.cs
@@ -70,... | diff --git a/tests/Avalonia.Base.UnitTests/Collections/AvaloniaListTests.cs b/tests/Avalonia.Base.UnitTests/Collections/AvaloniaListTests.cs
index b59f272b0cb..82a9885ddce 100644
--- a/tests/Avalonia.Base.UnitTests/Collections/AvaloniaListTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Collections/AvaloniaListTests.cs
@@ ... | `INotifyCollectionChanged` is implemented inconsistently for `Move` and `Replace` operations.
### Describe the bug
Various `INotifyCollectionChanged.CollectionChanged` event handlers in Avalonia have an off-by-one error and / or fail to correctly respond to multi-item change events. For example, the following event ha... | null | 2024-09-30T17:18:04Z | 0.1 | ['Avalonia.Base.UnitTests.Collections.AvaloniaListTests.Move_Should_Move_One_Item', 'Avalonia.Base.UnitTests.Collections.AvaloniaListTests.MoveRange_Should_Move_One_Item'] | ['Avalonia.Base.UnitTests.Collections.AvaloniaListTests.MoveRange_Can_Move_To_End', 'Avalonia.Base.UnitTests.Collections.AvaloniaListTests.AddRange_Items_Should_Raise_Correct_CollectionChanged', 'Avalonia.Base.UnitTests.Collections.AvaloniaListTests.InsertRange_With_Null_Should_Throw_Exception', 'Avalonia.Base.UnitTest... |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17135 | 432fbe8a9eb2e3c807bf71bed43968efbd5a3dec | diff --git a/src/Avalonia.Controls/VirtualizingStackPanel.cs b/src/Avalonia.Controls/VirtualizingStackPanel.cs
index 7934e0ccc6b..b3d61a9b643 100644
--- a/src/Avalonia.Controls/VirtualizingStackPanel.cs
+++ b/src/Avalonia.Controls/VirtualizingStackPanel.cs
@@ -167,7 +167,7 @@ protected override Size MeasureOverride(Siz... | diff --git a/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs b/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs
index d1ee1662f05..ba7765dabbd 100644
--- a/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTest... | [Bug] VirtualizingStackPanel (horizontal) issue in ListBox when scrolling using arrow keys [11.0.11 -> now][with repro]
### Describe the bug
I noticed a problem in ListBox when selecting items using arrow keys.
My ListBox
I am pressing Right arrow key.
As you can see in the video, once the last items is selec... | @grokys
May be the bug is here? Missing an Orientation check?
Yeah could be a missing orientation check. Should be easy to add. Can you file a PR for it? | 2024-09-26T07:37:49Z | 0.1 | ['Avalonia.Controls.UnitTests.VirtualizingStackPanelTests.ScrollIntoView_Correctly_Scrolls_Right_To_A_Page_Of_Smaller_Items', 'Avalonia.Controls.UnitTests.VirtualizingStackPanelTests.ScrollIntoView_Correctly_Scrolls_Right_To_A_Page_Of_Larger_Items'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-17073 | 85fff4a2320d87236c3f850b5de87129e6587458 | diff --git a/src/Avalonia.Base/Data/Core/BindingExpression.cs b/src/Avalonia.Base/Data/Core/BindingExpression.cs
index abf6f6cb887..635fa3e0960 100644
--- a/src/Avalonia.Base/Data/Core/BindingExpression.cs
+++ b/src/Avalonia.Base/Data/Core/BindingExpression.cs
@@ -512,8 +512,10 @@ private void OnTargetPropertyChanged(o... | diff --git a/tests/Avalonia.Markup.UnitTests/Data/BindingTests.cs b/tests/Avalonia.Markup.UnitTests/Data/BindingTests.cs
index d4a799da6fc..9fb52fee388 100644
--- a/tests/Avalonia.Markup.UnitTests/Data/BindingTests.cs
+++ b/tests/Avalonia.Markup.UnitTests/Data/BindingTests.cs
@@ -667,6 +667,31 @@ public void OneWayToSo... | stack overflow in binding system
### Describe the bug
We are observing a stack overflow, caused by a loop in the binding code. Below are two full iterations of the loop that leads to the stack overflow.
### To Reproduce
This issue is very easy to recreate. Adding a MaskedTextBox to a page bound to a string ... | Interesting. If you disable CompiledBindings for a test, does it disappear?
After adding this to my project file, the result is the same.
` <AvaloniaUseCompiledBindingsByDefault>false</AvaloniaUseCompiledBindingsByDefault>
`
`MaskedTextBox` has not changed very much, so it is doing what it has always done... | 2024-09-20T10:14:11Z | 0.1 | ['Avalonia.Markup.UnitTests.Data.BindingTests.Target_Undoing_Property_Change_During_TwoWay_Binding_Does_Not_Cause_StackOverflow'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-16712 | 228ecc5003c77dd74d2f037eb69daa4102312015 | diff --git a/src/Avalonia.Controls/TextBox.cs b/src/Avalonia.Controls/TextBox.cs
index a627c15765b..b12c23c5975 100644
--- a/src/Avalonia.Controls/TextBox.cs
+++ b/src/Avalonia.Controls/TextBox.cs
@@ -1468,7 +1468,7 @@ protected override void OnKeyDown(KeyEventArgs e)
SetCurrentVa... | diff --git a/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs b/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs
index 1cd42a6c6a1..42e42dd9f6e 100644
--- a/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs
@@ -1492,6 +1492,43 @@ public void Should_Throw_Argumen... | Backspace incorrectly places caret before linebreak when deleting the last character of a line
### Describe the bug
The following video is a single Backspace key press followed by an Enter key press:
https://github.com/user-attachments/assets/51b7adad-bc45-42ad-b148-7397667311c0
Notice that backspace deletes '... | null | 2024-08-16T14:43:48Z | 0.1 | ['Avalonia.Controls.UnitTests.TextBoxTests.Backspace_Should_Delete_Last_Character_In_Line_And_Keep_Caret_On_Same_Line'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-16710 | 21d8cea26bc0175b3a92399754e0587d3b736e91 | diff --git a/src/Avalonia.Controls/TextBoxTextInputMethodClient.cs b/src/Avalonia.Controls/TextBoxTextInputMethodClient.cs
index 0ff857985a4..5d35124c69a 100644
--- a/src/Avalonia.Controls/TextBoxTextInputMethodClient.cs
+++ b/src/Avalonia.Controls/TextBoxTextInputMethodClient.cs
@@ -180,6 +180,11 @@ public override vo... | diff --git a/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs b/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs
index 42e42dd9f6e..30f82533cea 100644
--- a/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/TextBoxTests.cs
@@ -9,11 +9,10 @@
using Avalonia.Headless;
using Aval... | TextBlock unexpectedly deletes first character when using input method auto-complete
### Describe the bug
When using the `auto-complete` feature of an input method (IME) with a `TextBlock` control, the first English character at the beginning of a line is unexpectedly deleted. This behavior occurs consistently and a... | Could you test with https://github.com/AvaloniaUI/Avalonia/pull/16666
> Could you test with #16666
``<PackageReference Include="Avalonia.Android" Version="11.2.999-cibuild0051177-alpha" />``
I tested it on my Android 10 d... | 2024-08-16T13:10:58Z | 0.1 | ['Avalonia.Controls.UnitTests.TextBoxTests.InputMethodClient_SurroundingText_Returns_Empty_For_Empty_Line'] | [] |
AvaloniaUI/Avalonia | avaloniaui__avalonia-16619 | ec655a9f7e8cb53536890112807ddf5d1caae9da | diff --git a/src/Avalonia.Controls/Button.cs b/src/Avalonia.Controls/Button.cs
index dc836a08716..614847ee4e8 100644
--- a/src/Avalonia.Controls/Button.cs
+++ b/src/Avalonia.Controls/Button.cs
@@ -289,8 +289,9 @@ protected override void OnKeyDown(KeyEventArgs e)
OnClick();
e.Ha... | diff --git a/tests/Avalonia.Controls.UnitTests/ButtonTests.cs b/tests/Avalonia.Controls.UnitTests/ButtonTests.cs
index 876adcc28fe..e3b974491aa 100644
--- a/tests/Avalonia.Controls.UnitTests/ButtonTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/ButtonTests.cs
@@ -511,11 +511,39 @@ public void Button_CommandParameter_D... | Button should check `RoutedEventArgs.Source` before handling keys
### Describe the bug
Reported in https://github.com/amwx/FluentAvalonia/issues/591.
Placing a text control into an Expander header does not allow spaces. The cause is the `Button` that is found in the Expander's header (which is part of the template... | null | 2024-08-07T16:19:12Z | 0.1 | ['Avalonia.Controls.UnitTests.ButtonTests.Should_Not_Fire_Click_Event_On_Space_Key_When_It_Is_Not_Focus'] | [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.