language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
bb0811dbf4928e251d897e2572d653680a46cdb1.json
Update preview type tests for array and mutable
types/preview/@ember/array/mutable.d.ts
@@ -1,7 +1,7 @@ -import Mixin from "@ember/object/mixin"; -import MutableEnumerable from "@ember/array/-private/mutable-enumerable"; +import Mixin from '@ember/object/mixin'; +import MutableEnumerable from '@ember/array/-private/mutable-enumerable'; import EmberArray from '@ember/array'; -import Enumerable from "@embe...
true
Other
emberjs
ember.js
bb0811dbf4928e251d897e2572d653680a46cdb1.json
Update preview type tests for array and mutable
types/preview/@ember/array/test/array-proxy.ts
@@ -11,16 +11,16 @@ proxy.set('content', A(['amoeba', 'paramecium'])); proxy.get('firstObject'); // 'amoeba' const overridden = ArrayProxy.create({ - content: A(pets), - objectAtContent(idx: number): string | undefined { - return this.get('content').objectAt(idx)?.toUpperCase(); - }, + content: A(p...
true
Other
emberjs
ember.js
9ca3053f1cc61b184c8f4de0886e7282bed34b03.json
Update preview type tests for arrays/array mixins
types/preview/@ember/array/-private/native-array.d.ts
@@ -13,11 +13,11 @@ type GlobalArray<T> = T[]; * at anytime by calling `Ember.NativeArray.apply(Array.prototype)`. */ interface NativeArray<T> extends GlobalArray<T>, MutableArray<T>, Observable { - /** - * __Required.__ You must implement this method to apply this mixin. - */ - length: number; + /*...
true
Other
emberjs
ember.js
9ca3053f1cc61b184c8f4de0886e7282bed34b03.json
Update preview type tests for arrays/array mixins
types/preview/@ember/array/index.d.ts
@@ -1,66 +1,57 @@ -// Type definitions for non-npm package @ember/array 4.0 -// Project: https://emberjs.com/api/ember/4.0/modules/@ember%2Farray -// Definitions by: Chris Krycho <https://github.com/chriskrycho> -// Dan Freeman <https://github.com/dfreeman> -// James C. Davis <https://gi...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/component/-private/class-names-support.d.ts
@@ -1,25 +1,25 @@ import Mixin from '@ember/object/mixin'; interface ClassNamesSupport { - /** - * A list of properties of the view to apply as class names. If the property is a string value, - * the value of that string will be applied as a class name. - * - * If the value of the property is a B...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/component/-private/view-mixin.d.ts
@@ -1,57 +1,57 @@ import Mixin from '@ember/object/mixin'; interface ViewMixin { - /** - * A list of properties of the view to apply as attributes. If the property - * is a string value, the value of that string will be applied as the value - * for an attribute of the property's name. - */ - a...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/debug/container-debug-adapter.d.ts
@@ -5,7 +5,7 @@ import Resolver from 'ember-resolver'; * with tools that debug Ember such as the Ember Inspector for Chrome and Firefox. */ export default class ContainerDebugAdapter extends Object { - resolver: Resolver; - canCatalogEntriesByType(type: string): boolean; - catalogEntriesByType(type: strin...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/engine/-private/registry-proxy-mixin.d.ts
@@ -6,47 +6,47 @@ import Mixin from '@ember/object/mixin'; * registry functionality. */ interface RegistryProxyMixin extends Owner { - /** - * Given a fullName return the corresponding factory. - */ - resolveRegistration(fullName: string): unknown; - /** - * Unregister a factory. - */ - ...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/engine/test/engine.ts
@@ -1,39 +1,41 @@ import Engine from '@ember/engine'; import EmberObject from '@ember/object'; -const BaseEngine = Engine.extend({ - modulePrefix: 'my-engine', -}); +class BaseEngine extends Engine { + modulePrefix = 'my-engine'; +} -class Obj extends EmberObject.extend({ foo: 'bar' }) {} +class Obj extends E...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/object/-private/action-handler.d.ts
@@ -1,7 +1,8 @@ +import { AnyFn } from 'ember/-private/type-utils'; import type Mixin from '../mixin'; interface ActionsHash { - [index: string]: (...params: any[]) => any; + [index: string]: AnyFn; } /** @@ -24,5 +25,5 @@ interface ActionHandler { */ actions: ActionsHash; } -declare const ActionHandl...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/object/evented.d.ts
@@ -1,60 +1,43 @@ import Mixin from '@ember/object/mixin'; -import { AnyFn, EmberMethod, MethodNamesOf, MethodParams, MethodsOf } from 'ember/-private/type-utils'; +import { AnyFn, EmberMethod } from 'ember/-private/type-utils'; /** * This mixin allows for Ember objects to subscribe to and emit events. */ inte...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/object/observable.d.ts
@@ -5,7 +5,7 @@ import CoreObject from './core'; /** * This mixin provides properties and property observing functionality, core features of the Ember object model. */ -interface Observable { +interface Observable extends CoreObject { /** * Retrieves the value of a property from the object. */ @@ -79,5 ...
true
Other
emberjs
ember.js
a5e36423469108db1b49a9a04d2a752182904054.json
Update preview type tests for many Mixin types
types/preview/@ember/object/promise-proxy-mixin.d.ts
@@ -1,35 +1,35 @@ -import Mixin from "@ember/object/mixin"; -import RSVP from "rsvp"; +import Mixin from '@ember/object/mixin'; +import RSVP from 'rsvp'; /** * A low level mixin making ObjectProxy promise-aware. */ interface PromiseProxyMixin<T> extends RSVP.Promise<T> { - /** - * If the proxied promise ...
true
Other
emberjs
ember.js
920901efa8a9734fdbdf26192ea7cf288d803d2e.json
Update preview type tests for EmberObject.reopen()
types/preview/@ember/object/test/reopen.ts
@@ -1,75 +1,79 @@ -import { assertType } from './lib/assert'; import EmberObject from '@ember/object'; import Mixin from '@ember/object/mixin'; +import { expectTypeOf } from 'expect-type'; -type Person = typeof Person.prototype; -const Person = EmberObject.extend({ - name: '', - sayHello() { - alert(`H...
true
Other
emberjs
ember.js
920901efa8a9734fdbdf26192ea7cf288d803d2e.json
Update preview type tests for EmberObject.reopen()
types/preview/ember/test/reopen.ts
@@ -1,6 +1,5 @@ import Ember from 'ember'; import { expectTypeOf } from 'expect-type'; -import { assertType } from './lib/assert'; class Person extends Ember.Object { name = '';
true
Other
emberjs
ember.js
81655aed415b191188bb9a960fd4ec58ad74c7db.json
Update preview type tests for EmberObject.create()
types/preview/@ember/object/test/create.ts
@@ -1,54 +1,57 @@ -import { assertType } from './lib/assert'; import EmberObject, { computed } from '@ember/object'; -import ComputedProperty from '@ember/object/computed'; +import { expectTypeOf } from 'expect-type'; /** * Zero-argument case */ const o = EmberObject.create(); // create returns an object -ass...
true
Other
emberjs
ember.js
81655aed415b191188bb9a960fd4ec58ad74c7db.json
Update preview type tests for EmberObject.create()
types/preview/ember/test/create.ts
@@ -1,55 +1,57 @@ import Ember from 'ember'; -import { assertType } from './lib/assert'; -import { UnwrapComputedPropertyGetter } from "@ember/object/-private/types"; +import { expectTypeOf } from 'expect-type'; /** * Zero-argument case */ const o = Ember.Object.create(); // create returns an object -assertTy...
true
Other
emberjs
ember.js
71e1e3f5d293f44a5f7e481e02770f4386f88f6d.json
Update preview type tests for Ember.DataAdapter
types/preview/ember/test/data-adapter.ts
@@ -1,52 +1,53 @@ import Ember from 'ember'; +import { expectTypeOf } from 'expect-type'; const da = Ember.DataAdapter.create(); const filters = da.getFilters(); -filters.includes({ name: 'foo', desc: 'bar' }); // $ExpectType boolean +expectTypeOf(filters.includes({ name: 'foo', desc: 'bar' })).toBeBoolean(); /...
false
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/application/namespace.ts
@@ -1,5 +1,5 @@ /** -@module @ember/application +@module @ember/application/namespace */ import {
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/array/proxy.ts
@@ -1,5 +1,5 @@ /** -@module @ember/array +@module @ember/array/proxy */ import {
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/debug/container-debug-adapter.ts
@@ -9,7 +9,7 @@ import type { Resolver } from '@ember/-internals/container'; import Namespace from '@ember/application/namespace'; /** -@module @ember/debug +@module @ember/debug/container-debug-adapter */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/debug/data-adapter.ts
@@ -11,6 +11,10 @@ import type { Cache } from '@glimmer/validator'; import { consumeTag, createCache, getValue, tagFor, untrack } from '@glimmer/validator'; import type ContainerDebugAdapter from '@ember/debug/container-debug-adapter'; +/** +@module @ember/debug/data-adapter +*/ + type RecordColor = 'black' | 'red...
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/object/core.ts
@@ -1,5 +1,5 @@ /** - @module @ember/object + @module @ember/object/core */ import { getFactoryFor, setFactoryFor } from '@ember/-internals/container';
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/object/evented.ts
@@ -4,7 +4,7 @@ import Mixin from '@ember/object/mixin'; export { on } from '@ember/-internals/metal'; /** -@module @ember/object +@module @ember/object/evented */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/object/mixin.ts
@@ -1,5 +1,5 @@ /** -@module @ember/object +@module @ember/object/mixin */ import { INIT_FACTORY } from '@ember/-internals/container'; import type { Meta } from '@ember/-internals/meta';
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/object/observable.ts
@@ -1,5 +1,5 @@ /** -@module @ember/object +@module @ember/object/observable */ import { peekMeta } from '@ember/-internals/meta';
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/object/promise-proxy-mixin.ts
@@ -6,7 +6,7 @@ import type RSVP from 'rsvp'; import type CoreObject from '@ember/object/core'; /** - @module @ember/object + @module @ember/object/promise-proxy-mixin */ function tap<T>(proxy: PromiseProxyMixin<T>, promise: RSVP.Promise<T>) {
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/object/proxy.ts
@@ -1,3 +1,7 @@ +/** +@module @ember/object/proxy +*/ + import { FrameworkObject } from '@ember/object/-internals'; import { _ProxyMixin } from '@ember/-internals/runtime';
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/auto-location.ts
@@ -15,7 +15,7 @@ import { } from './lib/location-utils'; /** -@module @ember/routing +@module @ember/routing/auto-location */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/hash-location.ts
@@ -4,7 +4,7 @@ import type { ILocation as EmberLocation, UpdateCallback } from '@ember/routing/ import { getHash } from './lib/location-utils'; /** -@module @ember/routing +@module @ember/routing/hash-location */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/history-location.ts
@@ -3,7 +3,7 @@ import type { ILocation as EmberLocation, UpdateCallback } from '@ember/routing/ import { getHash } from './lib/location-utils'; /** -@module @ember/routing +@module @ember/routing/history-location */ let popstateFired = false;
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/location.ts
@@ -15,7 +15,7 @@ export interface ILocation { export type UpdateCallback = (url: string) => void; /** -@module @ember/routing +@module @ember/routing/location */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/none-location.ts
@@ -3,7 +3,7 @@ import { assert } from '@ember/debug'; import type { ILocation as EmberLocation, UpdateCallback } from '@ember/routing/location'; /** -@module @ember/routing +@module @ember/routing/none-location */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/route.ts
@@ -70,7 +70,7 @@ export const ROUTE_CONNECTIONS = new WeakMap(); const RENDER = Symbol('render'); /** -@module @ember/routing +@module @ember/routing/route */ /**
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/router-service.ts
@@ -1,3 +1,6 @@ +/** + * @module @ember/routing/router-service + */ import { getOwner } from '@ember/-internals/owner'; import Evented from '@ember/object/evented'; import { assert } from '@ember/debug';
true
Other
emberjs
ember.js
63e01acb5b03ed98d0fe0d27e4581edde72697ba.json
Fix YUIDoc module names
packages/@ember/routing/router.ts
@@ -46,7 +46,7 @@ import type { QueryParams } from 'route-recognizer'; import type { AnyFn, MethodNamesOf, OmitFirst } from '@ember/-internals/utils/types'; /** -@module @ember/routing +@module @ember/routing/router */ function defaultDidTransition<R extends Route>(
true
Other
emberjs
ember.js
6d5fabe48d226a679324ad2b788666179a6ad0e6.json
Move RouterState into @ember/routing
packages/@ember/-internals/glimmer/lib/components/link-to.ts
@@ -1,6 +1,5 @@ import type Route from '@ember/routing/route'; -import type { RouterState } from '@ember/-internals/routing'; -import type { RoutingService } from '@ember/routing/internals'; +import type { RouterState, RoutingService } from '@ember/routing/internals'; import { isSimpleClick } from '@ember/-internals/...
true
Other
emberjs
ember.js
6d5fabe48d226a679324ad2b788666179a6ad0e6.json
Move RouterState into @ember/routing
packages/@ember/-internals/routing/index.ts
@@ -16,7 +16,6 @@ export { default as RouterDSL, DSLCallback } from './lib/system/dsl'; export { EngineRouteInfo } from './lib/system/engines'; export { default as QueryParams } from './lib/system/query_params'; export { RouteInfo, RouteInfoWithAttributes } from './lib/system/route-info'; -export { default as Router...
true
Other
emberjs
ember.js
6d5fabe48d226a679324ad2b788666179a6ad0e6.json
Move RouterState into @ember/routing
packages/@ember/routing/internals.ts
@@ -1 +1,2 @@ +export { default as RouterState } from './lib/router_state'; export { default as RoutingService } from './lib/routing-service';
true
Other
emberjs
ember.js
6d5fabe48d226a679324ad2b788666179a6ad0e6.json
Move RouterState into @ember/routing
packages/@ember/routing/lib/router_state.ts
@@ -1,6 +1,6 @@ import type { ModelFor, TransitionState } from 'router_js'; import type Router from 'router_js'; -import { shallowEqual } from '../utils'; +import { shallowEqual } from '@ember/-internals/routing'; import type Route from '@ember/routing/route'; import type EmberRouter from '@ember/routing/router';
true
Other
emberjs
ember.js
6d5fabe48d226a679324ad2b788666179a6ad0e6.json
Move RouterState into @ember/routing
packages/@ember/routing/lib/routing-service.ts
@@ -9,7 +9,7 @@ import Service from '@ember/service'; import type { ModelFor } from 'router_js'; import type Route from '@ember/routing/route'; import EmberRouter from '@ember/routing/router'; -import type { RouterState } from '@ember/-internals/routing'; +import type { RouterState } from '@ember/routing/internals';...
true
Other
emberjs
ember.js
6d5fabe48d226a679324ad2b788666179a6ad0e6.json
Move RouterState into @ember/routing
packages/@ember/routing/router.ts
@@ -6,12 +6,12 @@ import { getOwner } from '@ember/-internals/owner'; import { BucketCache, RouterDSL as DSL, - RouterState, calculateCacheKey, extractRouteArgs, getActiveTargetName, resemblesURL, } from '@ember/-internals/routing'; +import { RouterState } from '@ember/routing/internals'; import t...
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/@ember/-internals/glimmer/lib/components/link-to.ts
@@ -1,5 +1,6 @@ import type Route from '@ember/routing/route'; -import type { RouterState, RoutingService } from '@ember/-internals/routing'; +import type { RouterState } from '@ember/-internals/routing'; +import type { RoutingService } from '@ember/routing/internals'; import { isSimpleClick } from '@ember/-internals...
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/@ember/-internals/routing/index.ts
@@ -16,7 +16,6 @@ export { default as RouterDSL, DSLCallback } from './lib/system/dsl'; export { EngineRouteInfo } from './lib/system/engines'; export { default as QueryParams } from './lib/system/query_params'; export { RouteInfo, RouteInfoWithAttributes } from './lib/system/route-info'; -export { default as Routin...
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/@ember/engine/index.ts
@@ -11,7 +11,7 @@ import ContainerDebugAdapter from '@ember/debug/container-debug-adapter'; import { get, set } from '@ember/object'; import type { EngineInstanceOptions } from '@ember/engine/instance'; import EngineInstance from '@ember/engine/instance'; -import { RoutingService } from '@ember/-internals/routing'; ...
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/@ember/routing/internals.ts
@@ -0,0 +1 @@ +export { default as RoutingService } from './lib/routing-service';
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/@ember/routing/lib/routing-service.ts
@@ -9,7 +9,7 @@ import Service from '@ember/service'; import type { ModelFor } from 'router_js'; import type Route from '@ember/routing/route'; import EmberRouter from '@ember/routing/router'; -import type RouterState from '../system/router_state'; +import type { RouterState } from '@ember/-internals/routing'; impo...
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/ember-testing/lib/helpers/current_path.ts
@@ -2,7 +2,7 @@ @module ember */ import { get } from '@ember/object'; -import { RoutingService } from '@ember/-internals/routing'; +import { RoutingService } from '@ember/routing/internals'; import type Application from '@ember/application'; import { assert } from '@ember/debug';
true
Other
emberjs
ember.js
c91bd15d61a42feff693444ea250cbf8750f5a1d.json
Move RoutingService into @ember/routing
packages/ember-testing/lib/helpers/current_route_name.ts
@@ -2,7 +2,7 @@ @module ember */ import { get } from '@ember/object'; -import { RoutingService } from '@ember/-internals/routing'; +import { RoutingService } from '@ember/routing/internals'; import type Application from '@ember/application'; import { assert } from '@ember/debug'; /**
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/-internals/container/index.ts
@@ -5,5 +5,5 @@ The public API, specified on the application namespace should be considered the @private */ -export { default as Registry, privatize } from './lib/registry'; +export { default as Registry, Resolver, ResolverClass, privatize } from './lib/registry'; export { default as Container, getFactoryFor, se...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/-internals/glimmer/index.ts
@@ -316,7 +316,7 @@ export { DOMChanges, NodeDOMTreeConstruction, DOMTreeConstruction } from './lib/ // TODO just test these through public API // a lot of these are testing how a problem was solved // rather than the problem was solved -export { default as OutletView } from './lib/views/outlet'; +export { default a...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/application/instance.ts
@@ -8,7 +8,7 @@ import EngineInstance from '@ember/engine/instance'; import type { BootOptions } from '@ember/engine/instance'; import type Application from '@ember/application'; import { renderSettled } from '@ember/-internals/glimmer'; -import type { BootEnvironment } from '@ember/-internals/glimmer/lib/views/outl...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/debug/container-debug-adapter.ts
@@ -5,7 +5,7 @@ import { A as emberA } from '@ember/array'; import { typeOf } from '@ember/-internals/runtime'; import type { Owner } from '@ember/-internals/owner'; import { getOwner } from '@ember/-internals/owner'; -import type { Resolver } from '@ember/-internals/container/lib/registry'; +import type { Resolver ...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/engine/index.ts
@@ -4,6 +4,7 @@ import { canInvoke } from '@ember/-internals/utils'; import Controller from '@ember/controller'; import Namespace from '@ember/application/namespace'; import { Registry } from '@ember/-internals/container'; +import type { ResolverClass } from '@ember/-internals/container'; import DAG from 'dag-map';...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/engine/instance.ts
@@ -9,12 +9,11 @@ import EmberError from '@ember/error'; import { Registry, privatize as P } from '@ember/-internals/container'; import { guidFor } from '@ember/-internals/utils'; import { ENGINE_PARENT, getEngineParent, setEngineParent } from './lib/engine-parent'; -import RegistryProxyMixin from '@ember/-internals...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/@ember/object/compat.ts
@@ -5,7 +5,7 @@ import { isElementDescriptor, setClassicDecorator, } from '@ember/-internals/metal'; -import type { ElementDescriptor } from '@ember/-internals/metal/lib/decorator'; +import type { ElementDescriptor } from '@ember/-internals/metal'; import { assert } from '@ember/debug'; import type { Updatable...
true
Other
emberjs
ember.js
77f4722d01d70c82d4088ab616ceda650a77c582.json
Simplify internals imports
packages/internal-test-helpers/lib/test-resolver.ts
@@ -1,6 +1,6 @@ import { compile } from 'ember-template-compiler'; -import type { Resolver as IResolver } from '@ember/-internals/container/lib/registry'; +import type { Resolver as IResolver } from '@ember/-internals/container'; import type { Factory } from '@ember/-internals/owner'; const DELIMITER = '%';
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/@ember/-internals/glimmer/lib/views/outlet.ts
@@ -1,6 +1,6 @@ import type { Owner } from '@ember/-internals/owner'; import { getOwner } from '@ember/-internals/owner'; -import type { BootOptions } from '@ember/application/instance'; +import type { BootOptions } from '@ember/engine/instance'; import { assert } from '@ember/debug'; import { schedule } from '@emb...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/@ember/application/index.ts
@@ -22,9 +22,9 @@ import { NoneLocation, BucketCache, } from '@ember/-internals/routing'; -import type { BootOptions } from '@ember/application/instance'; import ApplicationInstance from '@ember/application/instance'; import Engine, { buildInitializerMethod } from '@ember/engine'; +import type { BootOptions } ...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/@ember/application/instance.ts
@@ -5,6 +5,7 @@ import { get, set } from '@ember/-internals/metal'; import * as environment from '@ember/-internals/browser-environment'; import EngineInstance from '@ember/engine/instance'; +import type { BootOptions } from '@ember/engine/instance'; import type Application from '@ember/application'; import { rend...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/@ember/application/type-tests/instance.test.ts
@@ -1,8 +1,8 @@ import type { Factory, Owner } from '@ember/-internals/owner'; +import type EngineInstance from '@ember/engine/instance'; +import type { BootOptions } from '@ember/engine/instance'; import Application from '@ember/application'; -import type { BootOptions } from '@ember/application/instance'; import t...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/@ember/engine/instance.ts
@@ -11,13 +11,24 @@ import { ENGINE_PARENT, getEngineParent, setEngineParent } from './lib/engine-pa import RegistryProxyMixin from '@ember/-internals/runtime/lib/mixins/registry_proxy'; import ContainerProxyMixin from '@ember/-internals/runtime/lib/mixins/container_proxy'; import { isFactory } from '@ember/-interna...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/internal-test-helpers/lib/test-cases/abstract-application.ts
@@ -3,8 +3,8 @@ import { compile } from 'ember-template-compiler'; import { ENV } from '@ember/-internals/environment'; import AbstractTestCase from './abstract'; import { runDestroy, runTask, runLoopSettled } from '../run'; +import type { BootOptions } from '@ember/engine/instance'; import type Application from '@...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/internal-test-helpers/lib/test-cases/query-param.ts
@@ -1,4 +1,4 @@ -import type { BootOptions } from '@ember/application/instance'; +import type { BootOptions } from '@ember/engine/instance'; import Controller from '@ember/controller'; import type EmberObject from '@ember/object'; import { NoneLocation } from '@ember/-internals/routing';
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/internal-test-helpers/lib/test-cases/rendering.ts
@@ -10,8 +10,7 @@ import AbstractTestCase from './abstract'; import buildOwner from '../build-owner'; import { runAppend, runDestroy, runTask } from '../run'; import type { Factory } from '@ember/-internals/owner'; -import type { BootOptions } from '@ember/application/instance'; -import type { EngineInstanceOptions ...
true
Other
emberjs
ember.js
b584e5657a86cacb01fa5aa3dd018f9c2f6b0b4d.json
Relocate BootOptions interface
packages/internal-test-helpers/lib/test-cases/router-non-application.ts
@@ -9,9 +9,8 @@ import { ModuleBasedResolver } from '../test-resolver'; import AbstractTestCase from './abstract'; import buildOwner from '../build-owner'; import { runAppend, runDestroy } from '../run'; -import type { EngineInstanceOptions } from '@ember/engine/instance'; +import type { BootOptions, EngineInstanceO...
true
Other
emberjs
ember.js
debe5f7be0ba6df5dfcee4082f10bee28b5f541c.json
Add v4.7.0-beta.1 to CHANGELOG (cherry picked from commit 92284956ad8008fa177666649db698e4fd82394e)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v4.7.0-beta.1 (July 25, 2022) + +- [#20126](https://github.com/emberjs/ember.js/pull/20126) [BUGFIX] Replacing Firefox detection that used a deprecated browser API + ### v4.6.0 (July 25, 2022) - [#20125](https://github.com/emberjs/ember.js/pull/20125) [BUGFIX] Replace depre...
false
Other
emberjs
ember.js
6dbd66eaa82fafcbc443f4f00403deeb7c6f5230.json
Add v4.6.0 to CHANGELOG (cherry picked from commit 4cf212827e5454f1fa720ea0341f8e3c338106bf)
CHANGELOG.md
@@ -1,13 +1,8 @@ # Ember Changelog -### v4.6.0-beta.2 (June 27, 2022) +### v4.6.0 (July 25, 2022) - [#20125](https://github.com/emberjs/ember.js/pull/20125) [BUGFIX] Replace deprecated substr() method with substring() method. -- [#20120](https://github.com/emberjs/ember.js/pull/20120) [BUGFIX] Adjust uniqueId() i...
false
Other
emberjs
ember.js
cc699bd4cd50e808c1c0e95ac10cd60531541c3e.json
Add v4.5.1 to CHANGELOG (cherry picked from commit 6d34f631825acdf9cc0552a2e67b333b0be4445a)
CHANGELOG.md
@@ -9,6 +9,10 @@ No new external changes. +### v4.5.1 (July 25, 2022) + +- [#20120](https://github.com/emberjs/ember.js/pull/20120) [BUGFIX] Adjust uniqueId() implementation to only generate valid selectors. + ### v4.5.0 (June 13, 2022) - [#20052](https://github.com/emberjs/ember.js/pull/20052) / [#20055](http...
false
Other
emberjs
ember.js
e80113647ec9a0dfe4a82ebf80da578669183649.json
[DOCS]: fix inconsistencies in yield example
packages/@ember/-internals/glimmer/index.ts
@@ -162,8 +162,8 @@ ```html <div> - Start Date: July 1st - End Date: July 30th + Start date: July 1st + End date: July 30th </div> ``` @@ -177,7 +177,7 @@ </Banner> ``` - ```app/components/Banner.hbs + ```app/components/banner.hbs <div> {{yield "Hello title" "hello subtitle...
false
Other
emberjs
ember.js
9741caacedb3fec9e82a4752c88345380594571d.json
Add v4.6.0-beta.2 to CHANGELOG (cherry picked from commit 3786bcbbf7745c0b69e3e7c8506138411cf28e9c)
CHANGELOG.md
@@ -1,5 +1,10 @@ # Ember Changelog +### v4.6.0-beta.2 (June 27, 2022) + +- [#20125](https://github.com/emberjs/ember.js/pull/20125) [BUGFIX] Replace deprecated substr() method with substring() method. +- [#20120](https://github.com/emberjs/ember.js/pull/20120) [BUGFIX] Adjust uniqueId() implementation to only genera...
false
Other
emberjs
ember.js
42d018a93e36e0aa41806d3276591c0fe4c14a16.json
Remove browser detection for IE
packages/@ember/-internals/browser-environment/index.ts
@@ -2,8 +2,6 @@ import hasDom from './lib/has-dom'; declare const chrome: unknown; declare const opera: unknown; -declare const MSInputMethodContext: unknown; -declare const documentMode: unknown; export { default as hasDOM } from './lib/has-dom'; export const window = hasDom ? self : null; @@ -12,6 +10,3 @@ ex...
false
Other
emberjs
ember.js
39bd7a6989d4b4fa7c362d61ec694251d2dfe808.json
Fix typo in instance.ts transion -> transition
packages/@ember/application/instance.ts
@@ -248,7 +248,7 @@ class ApplicationInstance extends EngineInstance { Navigate the instance to a particular URL. This is useful in tests, for example, or to tell the app to start at a particular URL. This method returns a promise that resolves with the app instance when the transition - is complete, ...
false
Other
emberjs
ember.js
f8812ee1d756d71cb2f3194ff7ec458dcdbd2d21.json
Application class: convert docs to ES6 syntax
packages/@ember/application/lib/application.ts
@@ -43,11 +43,11 @@ import type { SimpleDocument, SimpleElement } from '@simple-dom/interface'; initialized. ```app/app.js - const App = Application.extend({ + export default class App extends Application { ready() { // your code here } - }) + } ``` Because `Application` ultimately ...
false
Other
emberjs
ember.js
5a77a4312accd672f29b48b73db2b78745335ae7.json
Add v4.6.0-beta.1 to CHANGELOG (cherry picked from commit e0485faba3e56afe1e3e7a20af4e150b6f962877)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v4.6.0-beta.1 (June 13, 2022) + +No new external changes. + ### v4.5.0 (June 13, 2022) - [#20052](https://github.com/emberjs/ember.js/pull/20052) / [#20055](https://github.com/emberjs/ember.js/pull/20055) [FEATURE] Add the default helper manager to implement [RFC #0756](htt...
false
Other
emberjs
ember.js
fa7db213b2f870bce4b153c1167746bff1f6a209.json
Add v4.5.0 to CHANGELOG (cherry picked from commit 311760db432da20977b307b2805e9761b8917228)
CHANGELOG.md
@@ -1,22 +1,18 @@ # Ember Changelog -### v4.4.2 (June 13, 2022) +### v4.5.0 (June 13, 2022) -- [#20114](https://github.com/emberjs/ember.js/pull/20114) [BUGFIX] Fix generated import paths for test setup functions in addons +- [#20052](https://github.com/emberjs/ember.js/pull/20052) / [#20055](https://github.com/em...
false
Other
emberjs
ember.js
c18edfca05598cdc6e683566ac0ffaa64dd9de04.json
Add v4.4.2 to CHANGELOG (cherry picked from commit 0527cdfb1380e566424b57f2764ef01998acb810)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v4.4.2 (June 13, 2022) + +- [#20114](https://github.com/emberjs/ember.js/pull/20114) [BUGFIX] Fix generated import paths for test setup functions in addons + ### v4.5.0-beta.2 (June 6, 2022) - [#20082](https://github.com/emberjs/ember.js/pull/20082) [BUGFIX] Fix blueprint g...
false
Other
emberjs
ember.js
2a06e7dc1895b78759522dda062d1897b016172d.json
Remove internal files in `blueprints-js` folder
blueprints-js/-addon-import.js
@@ -1,48 +0,0 @@ -'use strict'; - -const stringUtil = require('ember-cli-string-utils'); -const path = require('path'); -const inflector = require('inflection'); - -module.exports = { - description: 'Generates an import wrapper.', - - fileMapTokens: function () { - return { - __name__: function (options) { - ...
true
Other
emberjs
ember.js
2a06e7dc1895b78759522dda062d1897b016172d.json
Remove internal files in `blueprints-js` folder
blueprints-js/test-framework-detector.js
@@ -1,60 +0,0 @@ -'use strict'; - -const fs = require('fs'); -const path = require('path'); -const VersionChecker = require('ember-cli-version-checker'); - -module.exports = function (blueprint) { - blueprint.supportsAddon = function () { - return false; - }; - - blueprint.filesPath = function () { - let type;...
true
Other
emberjs
ember.js
75cd214c1165ad9c7bec274031eecb6404658225.json
Add v4.5.0-beta.2 to CHANGELOG (cherry picked from commit 4443f5e554bf6353b7f4a2cda4a842bd47fd75ad)
CHANGELOG.md
@@ -1,5 +1,9 @@ # Ember Changelog +### v4.5.0-beta.2 (June 6, 2022) + +- [#20082](https://github.com/emberjs/ember.js/pull/20082) [BUGFIX] Fix blueprint generation + ### v4.4.1 (May 31, 2022) - [#20082](https://github.com/emberjs/ember.js/pull/20082) [BUGFIX] Fix blueprints publication
false
Other
emberjs
ember.js
a5027fefdcc433eb2ebd50d42fd6b9b5e89d7d01.json
Add updated SAFETY comment to `spaceship` body
packages/@ember/-internals/runtime/lib/compare.ts
@@ -36,6 +36,9 @@ type Compare = -1 | 0 | 1; // `._________`-. `. `.___ // SSt `------'` function spaceship(a: number, b: number): Compare { + // SAFETY: `Math.sign` always returns `-1` for negative, `0` for zero, and `1` + // for pos...
false
Other
emberjs
ember.js
09a73ada1e5140ea0f0179dcbe6245255c336674.json
Convert @ember/test to TS
packages/@ember/test/adapter.js
@@ -1,3 +0,0 @@ -import { Test } from 'ember-testing'; - -export default Test.Adapter;
true
Other
emberjs
ember.js
09a73ada1e5140ea0f0179dcbe6245255c336674.json
Convert @ember/test to TS
packages/@ember/test/adapter.ts
@@ -0,0 +1,3 @@ +import { Adapter } from 'ember-testing'; + +export default Adapter;
true
Other
emberjs
ember.js
09a73ada1e5140ea0f0179dcbe6245255c336674.json
Convert @ember/test to TS
packages/@ember/test/index.ts
@@ -1,10 +1,11 @@ import require, { has } from 'require'; +import { type Test } from 'ember-testing'; -export let registerAsyncHelper; -export let registerHelper; -export let registerWaiter; -export let unregisterHelper; -export let unregisterWaiter; +export let registerAsyncHelper: typeof Test['registerAsyncHelper'...
true
Other
emberjs
ember.js
8c6a1594b72ecb9e0f56161e08c815b76f4bb21a.json
Improve types for array internals
packages/@ember/-internals/metal/lib/array.ts
@@ -1,10 +1,13 @@ -import type { Array as EmberArray, MutableArray, NativeArray } from '@ember/-internals/runtime'; +import type { Array as EmberArray, MutableArray } from '@ember/-internals/runtime'; +import { assert } from '@ember/debug'; import { arrayContentDidChange, arrayContentWillChange } from './array_events'...
true
Other
emberjs
ember.js
8c6a1594b72ecb9e0f56161e08c815b76f4bb21a.json
Improve types for array internals
packages/@ember/-internals/metal/lib/mixin.ts
@@ -672,7 +672,9 @@ export default class Mixin { /** @internal */ keys() { - return _keys(this); + let keys = _keys(this); + assert('[BUG] Missing keys for mixin!', keys); + return keys; } /** @internal */ @@ -739,16 +741,16 @@ function _detect(curMixin: Mixin, targetMixin: Mixin, seen = new...
true
Other
emberjs
ember.js
8c6a1594b72ecb9e0f56161e08c815b76f4bb21a.json
Improve types for array internals
packages/@ember/-internals/runtime/lib/mixins/array.d.ts
@@ -1,110 +0,0 @@ -import type { Mixin } from '@ember/-internals/metal'; -import type { AnyFn } from '@ember/-internals/utils/types'; -import type Enumerable from './enumerable'; -import type MutableEnumerable from './mutable_enumerable'; - -type Value<T, K extends string> = K extends keyof T ? T[K] : unknown; - -inter...
true
Other
emberjs
ember.js
8c6a1594b72ecb9e0f56161e08c815b76f4bb21a.json
Improve types for array internals
packages/@ember/-internals/runtime/lib/mixins/array.ts
@@ -3,7 +3,7 @@ */ import { DEBUG } from '@glimmer/env'; import { PROXY_CONTENT } from '@ember/-internals/metal'; -import { setEmberArray } from '@ember/-internals/utils'; +import { isEmberArray, setEmberArray } from '@ember/-internals/utils'; import { get, set, @@ -22,17 +22,24 @@ import { ENV } from '@ember...
true
Other
emberjs
ember.js
8c6a1594b72ecb9e0f56161e08c815b76f4bb21a.json
Improve types for array internals
packages/@ember/-internals/runtime/lib/system/array_proxy.ts
@@ -16,15 +16,14 @@ import { } from '@ember/-internals/metal'; import { isObject } from '@ember/-internals/utils'; import EmberObject from './object'; -import type EmberArray from '../mixins/array'; -import { isArray, MutableArray } from '../mixins/array'; +import EmberArray, { MutableArray } from '../mixins/array';...
true
Other
emberjs
ember.js
8c6a1594b72ecb9e0f56161e08c815b76f4bb21a.json
Improve types for array internals
packages/@ember/object/lib/computed/reduce_computed_macros.ts
@@ -966,7 +966,7 @@ export function setDiff(setAProperty: string, setBProperty: string) { return emberA(); } if (!isNativeOrEmberArray(setB)) { - return emberA(setA); + return setA; } return setA.filter((x) => setB.indexOf(x) === -1);
true
Other
emberjs
ember.js
127bbf36028a0980c30be6563a054c1c262c1384.json
Correct some types for internals
packages/@ember/-internals/metal/lib/computed.ts
@@ -903,8 +903,8 @@ export function computed( } export function autoComputed( - ...config: [ComputedPropertyObj] -): ComputedDecorator | DecoratorPropertyDescriptor { + ...config: [ComputedPropertyObj | ComputedPropertyGetterFunction] +): ComputedDecorator { // SAFETY: We passed in the impl for this class r...
true
Other
emberjs
ember.js
127bbf36028a0980c30be6563a054c1c262c1384.json
Correct some types for internals
packages/@ember/-internals/runtime/lib/mixins/array.d.ts
@@ -26,27 +26,27 @@ interface EmberArray<T> extends Enumerable { ): NativeArray<U>; mapBy<K extends string>(key: K): NativeArray<Value<T, K>>; filter<Target>( - callback: (this: Target, item: T, index: number, arr: this) => boolean, + callback: (this: Target, item: T, index: number, arr: this) => unknown...
true
Other
emberjs
ember.js
3418c7b9a47cf9cc5fe16000d7388b81976b4601.json
Remove K function
packages/@ember/-internals/glimmer/lib/renderer.ts
@@ -86,6 +86,8 @@ export class DynamicScope implements GlimmerDynamicScope { } } +const NO_OP = () => {}; + // This wrapper logic prevents us from rerendering in case of a hard failure // during render. This prevents infinite revalidation type loops from occuring, // and ensures that errors are not swallowed b...
true
Other
emberjs
ember.js
3418c7b9a47cf9cc5fe16000d7388b81976b4601.json
Remove K function
packages/ember-testing/lib/adapters/adapter.js
@@ -1,9 +1,5 @@ import { Object as EmberObject } from '@ember/-internals/runtime'; -function K() { - return this; -} - /** @module @ember/test */ @@ -25,15 +21,15 @@ export default EmberObject.extend({ @public @method asyncStart */ - asyncStart: K, + asyncStart() {}, /** This callback w...
true
Other
emberjs
ember.js
afdee50cf5c57e05f775799b5c81e3413dba1bbc.json
Remove redundant types
packages/@ember/-internals/glimmer/lib/component.ts
@@ -857,7 +857,7 @@ class Component if (!lazyEventsProcessedForComponentClass.has(proto)) { let lazyEvents = eventDispatcher.lazyEvents; - lazyEvents.forEach((mappedEventName: string | null, event: string) => { + lazyEvents.forEach((mappedEventName, event) => { if (mappedEvent...
false
Other
emberjs
ember.js
474057360405daf9d1bb3d402f5742e27e76c8af.json
Add v4.5.0-beta.1 to CHANGELOG (cherry picked from commit c335315f744fe6921d0a293a48b4f1027cab0cac)
CHANGELOG.md
@@ -1,5 +1,10 @@ # Ember Changelog +### v4.5.0-beta.1 (May 2, 2022) + +- [#20052](https://github.com/emberjs/ember.js/pull/20052) / [#20055](https://github.com/emberjs/ember.js/pull/20055) [FEATURE] Add the default helper manager to implement [RFC #0756](https://github.com/emberjs/rfcs/blob/master/text/0756-helper-d...
false
Other
emberjs
ember.js
d723329ee9ee2dc278ead43f2302ef01b0aa8e9e.json
Add v4.4.0 to CHANGELOG (cherry picked from commit 6ae29cade22cf3caf52e7de9aefcc937de4c1f6f)
CHANGELOG.md
@@ -1,17 +1,17 @@ # Ember Changelog -## v3.28.9 (April 19, 2022) - -- [#20028](https://github.com/emberjs/ember.js/pull/20028) Fix a memory leak in the Router Service class - -### v4.4.0-beta.1 (March 24, 2022) +### v4.4.0 (May 2, 2022) - [#19882](https://github.com/emberjs/ember.js/pull/19882) / [#20005](https:/...
false
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/glimmer/lib/component.ts
@@ -857,7 +857,7 @@ class Component if (!lazyEventsProcessedForComponentClass.has(proto)) { let lazyEvents = eventDispatcher.lazyEvents; - lazyEvents.forEach((mappedEventName: string, event: string) => { + lazyEvents.forEach((mappedEventName: string | null, event: string) => { ...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/glimmer/lib/modifiers/action.ts
@@ -50,15 +50,15 @@ export let ActionHelper = { registerAction(actionState: ActionState) { let { actionId } = actionState; - (ActionManager.registeredActions as Record<string, unknown>)[actionId] = actionState; + ActionManager.registeredActions[actionId] = actionState; return actionId; }, ...
true
Other
emberjs
ember.js
9fb35c41563d450293d991d313bd99f82b4acece.json
Convert view internals to TS
packages/@ember/-internals/views/lib/mixins/action_support.d.ts
@@ -1,8 +0,0 @@ -import Mixin from '@ember/object/mixin'; - -interface ActionSupport { - send(actionName: string, ...args: unknown[]): void; -} -declare const ActionSupport: Mixin; - -export default ActionSupport;
true