instance_id
stringlengths
17
39
repo
stringclasses
8 values
issue_id
stringlengths
14
34
pr_id
stringlengths
14
34
linking_methods
listlengths
1
3
base_commit
stringlengths
40
40
merge_commit
stringlengths
0
40
hints_text
listlengths
0
106
resolved_comments
listlengths
0
119
created_at
timestamp[ns, tz=UTC]
labeled_as
listlengths
0
7
problem_title
stringlengths
7
174
problem_statement
stringlengths
0
55.4k
gold_files
listlengths
0
10
gold_files_postpatch
listlengths
1
10
test_files
listlengths
0
60
gold_patch
stringlengths
220
5.83M
test_patch
stringlengths
386
194k
split_random
stringclasses
3 values
split_time
stringclasses
3 values
issue_start_time
timestamp[ns]
issue_created_at
timestamp[ns, tz=UTC]
issue_by_user
stringlengths
3
21
split_repo
stringclasses
3 values
netty/netty/12445_12467
netty/netty
netty/netty/12445
netty/netty/12467
[ "keyword_pr_to_issue" ]
c18fc2bc68c08805b2553336a3bf02f0c8c50972
7971075bbe9f5509c8b20c0e702ec2affb37d76e
[ "Do you want to make a PR?" ]
[]
2022-06-14T12:39:00Z
[]
FlowControlHandler breaks auto-reading
_FlowControlHandler_ breaks auto-reading (i.e. the channel does not auto-read even though its config has auto-read set to true). This happens when auto-read is turned on when the queue is not empty. The reason is that _FlowControlHandler.read()_ does not pass the call to the _ChannelHandlerContext_ if at least one mess...
[ "handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java" ]
[ "handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java b/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java index 1f7926fdf2f..f316907a7e5 100644 --- a/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java +++ b/handler/src/main/java/io/netty/handler/flow/FlowCon...
null
test
test
2022-06-13T08:44:56
2022-06-06T17:15:26Z
gbrdead
val
netty/netty/12480_12483
netty/netty
netty/netty/12480
netty/netty/12483
[ "keyword_pr_to_issue" ]
b063c211277fcfb4453f24aad3bda8529cf21b8a
f43a9dd0a384eb6226e31648b7168e4fa241527d
[ "These are used by the native code loading. I think it'd be better to have a system property where the classifier set can be directly specified, and then avoid reading the files if that property is present. Then it could also serve a dual purpose of overriding the files in case they produce a wrong classifier set f...
[]
2022-06-17T15:31:45Z
[]
Opt-out from blocking reads of OS files for classifiers
### Expected behavior Less of redundant blocking IO in netty ### Actual behavior On initialization netty does [blocking](https://github.com/netty/netty/blob/c87c911c010c3a34a69e550d52299df20e5fc740/common/src/main/java/io/netty/util/internal/PlatformDependent.java#L231) reads of `/etc/os-release`, `/usr/lib/o...
[ "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[ "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[ "common/src/test/java/io/netty/util/internal/OsClassifiersTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent.java b/common/src/main/java/io/netty/util/internal/PlatformDependent.java index 00310e585ea..cfa61f60406 100644 --- a/common/src/main/java/io/netty/util/internal/PlatformDependent.java +++ b/common/src/main/java/io/netty/util/internal/PlatformDe...
diff --git a/common/src/test/java/io/netty/util/internal/OsClassifiersTest.java b/common/src/test/java/io/netty/util/internal/OsClassifiersTest.java new file mode 100644 index 00000000000..903f5cba226 --- /dev/null +++ b/common/src/test/java/io/netty/util/internal/OsClassifiersTest.java @@ -0,0 +1,121 @@ +/* + * Copyri...
train
test
2022-06-15T10:53:31
2022-06-16T21:52:24Z
mostroverkhov
val
netty/netty/12494_12498
netty/netty
netty/netty/12494
netty/netty/12498
[ "connected" ]
c6c3bc606d4e716cf5a08ab68eb950ebb8f989b1
86d4ee41cd917e7b28a691cca1b1d0720e1d5df6
[ "@gspadotto Are you able to make a build with this and give it a try on your system? https://github.com/netty/netty/pull/12498", "> @gspadotto Are you able to make a build with this and give it a try on your system? #12498\r\n\r\nHi @chrisvest \r\nI'll give it a try even though it's a bit complex for me. \r\nI'l...
[]
2022-06-21T23:31:52Z
[]
Use correct name alias for processor in OSGi Bundle Manifests
https://github.com/netty/netty/blob/f43a9dd0a384eb6226e31648b7168e4fa241527d/transport-native-epoll/pom.xml#L342 **processor** directive value should be "AArch64", not "aarch_64" according to: http://docs.osgi.org/reference/osnames.html See also: https://github.com/netty/netty-tcnative/pull/547 Otherwise yo...
[ "resolver-dns-native-macos/pom.xml", "transport-native-epoll/pom.xml", "transport-native-kqueue/pom.xml" ]
[ "resolver-dns-native-macos/pom.xml", "transport-native-epoll/pom.xml", "transport-native-kqueue/pom.xml" ]
[]
diff --git a/resolver-dns-native-macos/pom.xml b/resolver-dns-native-macos/pom.xml index 40452e4afba..9c27e028344 100644 --- a/resolver-dns-native-macos/pom.xml +++ b/resolver-dns-native-macos/pom.xml @@ -214,7 +214,7 @@ <addDefaultImplementationEntries>true</addDefaultImplementationEntries> ...
null
test
test
2022-06-21T16:35:38
2022-06-21T14:45:42Z
gspadotto
val
netty/netty/12499_12500
netty/netty
netty/netty/12499
netty/netty/12500
[ "keyword_pr_to_issue" ]
c6c3bc606d4e716cf5a08ab68eb950ebb8f989b1
4e439264df0523fb6efce5f8f6c7c7fa74addd07
[]
[ "actually I think this will not work in netty 4.1 due our java version requirement and so you need to handle this kind of stuff differently.", "The rethrowing Throwable? Then we can use `PlatformDependent.throwException` instead.", "Yep... Only works on java8+" ]
2022-06-22T21:07:51Z
[]
ReferenceCountUtil.release(cast) could shade the exception of encode at function write of MessageToMessageEncoder
### Expected behavior ![image](https://user-images.githubusercontent.com/10280338/174937458-9bceea3c-4099-43e7-81c0-0022969f29dc.png) Function `encode` at line 89 is declared to throw exceptions, and then if `ReferenceCountUtil.release(cast)` at line 91 throws an exception too, the exception threw by `encode` will be...
[ "codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java" ]
[]
diff --git a/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java b/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java index eb29eb87fca..4973c9bb0b7 100644 --- a/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java +++ b/codec/src/main/java/io/netty/handler/co...
null
val
test
2022-06-21T16:35:38
2022-06-22T03:47:28Z
sspbh
val
netty/netty/12360_12662
netty/netty
netty/netty/12360
netty/netty/12662
[ "keyword_pr_to_issue" ]
114762840b2d39018e2254883055c8d34e5846f6
731b7c6240ab1944710982217feca6ddc346e620
[ "A `ByteBuf` was unexpectedly released while being worked on by a `ByteToMessageDecoder`.\r\nWhatever class extends the `ByteToMessageDecoder` probably called `release()` on the `in` buffer argument, which it shouldn't do.\r\nThe input buffer is managed by the `ByteToMessageDecoder`, so sub-classes should just adva...
[ "Can a check for **cumulation.refCount() >0** be placed here? This will ensure that only those bytebuf are released whose refCount>0 and if bytebuf already has a refcount of 0, it is already deallocated or can be returned to the object pool. This will prevent IllegalReferenceCount from occurring. \r\nNot sure about...
2022-08-02T22:30:49Z
[]
'io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1'
Hi, We are sending GET requests to our application. We are encountering the issue mentioned below frequently. Dependencies Spring Cloud Gateway - 3.0.3 Spring Boot - 2.5.5 Spring webflux - 5.3.10 Reactor netty - 1.0.11 Netty - 4.1.63.Final OS - Cent OS / Linux ``` {"instant":{"epochSecond":1651180720,"n...
[ "codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java" ]
[]
diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java index 39239ec0e3c..81ee3427ce5 100644 --- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java +++ b/codec/src/main/java/io/netty/handler/codec/ByteT...
null
val
test
2022-07-29T17:25:27
2022-05-05T05:29:24Z
idikshit
val
netty/netty/12671_12682
netty/netty
netty/netty/12671
netty/netty/12682
[ "keyword_pr_to_issue", "connected" ]
9280cdd49a711192c7290a1043397762bd6f245a
ba129384131dc714496947d8227b1a5a9f7a177c
[ "@chrisvest PTAL", "> Caused by: java.lang.IllegalStateException: This allocator has been **closed**.\r\n> \tat io.netty5.buffer.api.internal.Statics.allocatorClosedException(Statics.java:268)\r\n> \tat io.netty5.buffer.api.pool.PooledBufferAllocator.allocate(PooledBufferAllocator.java:316)\r\n> \tat io.netty5...
[]
2022-08-08T21:55:31Z
[]
[netty 5] ByteToMessageDecoder tries to allocate from a closed allocator
### Expected behavior ByteToMessageDecoder shouldn't try to allocate a buffer from a closed allocator. ### Actual behavior ByteToMessageDecoder tries to call decode when a channel becomes inactive which tries to allocate a buffer from a closed buffer allocator: https://gist.github.com/derklaro/38899e5d645adc058785...
[ "buffer/src/main/java/io/netty5/buffer/api/DefaultBufferAllocators.java" ]
[ "buffer/src/main/java/io/netty5/buffer/api/DefaultBufferAllocators.java" ]
[]
diff --git a/buffer/src/main/java/io/netty5/buffer/api/DefaultBufferAllocators.java b/buffer/src/main/java/io/netty5/buffer/api/DefaultBufferAllocators.java index 10329926727..44b7a4fa611 100644 --- a/buffer/src/main/java/io/netty5/buffer/api/DefaultBufferAllocators.java +++ b/buffer/src/main/java/io/netty5/buffer/api/...
null
val
test
2022-08-08T22:32:31
2022-08-06T17:58:23Z
derklaro
val
netty/netty/11020_12732
netty/netty
netty/netty/11020
netty/netty/12732
[ "keyword_pr_to_issue" ]
57dbfb0aeb734164435d2b08e733ba52717e222c
8957a2e36a0d0f794af7556e838dbbf194f58ad0
[ "Never saw this big stack trace. ;/", "make sure you have:\r\n\r\n```\r\n <dependency>\r\n <groupId>io.netty</groupId>\r\n <artifactId>netty-resolver-dns-native-macos</artifactId>\r\n <version>XXX</version>\r\n <classifier>osx-x86_64</classifier>\r\n </dependency>...
[ "```suggestion\r\n + \"incorrect DNS resolutions on MacOS. Check whether you have a dependency on \"\r\n```", "```suggestion\r\n + \"incorrect DNS resolutions on MacOS. Check whether you have a dependency on \"\r\n```", "thanks", "thanks" ]
2022-08-24T07:47:12Z
[]
Unable to load io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider
### Expected behavior Spring Cloud Gateway microservice (api-gateway) should route to appropriate microservice (web) using Eureka Discovery Server microservice (discovery) and return "Hello World". ### Actual behavior ``` 2021-02-12 15:31:29.621 INFO 8598 --- [ main] com.example.demo.ApiGatewayApplicat...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsServerAddressStreamProviders.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsServerAddressStreamProviders.java" ]
[]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsServerAddressStreamProviders.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsServerAddressStreamProviders.java index 8ba95777b87..b9668dd3f5c 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsServerAddressStreamProviders.java +++...
null
train
test
2022-08-23T08:25:07
2021-02-12T04:45:51Z
rodmccutcheon
val
netty/netty/12745_12746
netty/netty
netty/netty/12745
netty/netty/12746
[ "keyword_pr_to_issue" ]
617415ae3eb5cce1b6a4198157ede01b05a5a891
6c81a3fa025f31bc0308d7913f8ecbf540f99247
[ "Thanks for the report. This should be fixed by https://github.com/netty/netty/pull/12746", "Thank you for the quick fix!\r\n" ]
[]
2022-08-26T23:58:59Z
[]
Fallback to PemReader fails when BouncyCastlePemReader encounters an unsupported type
While I'm not completely certain this is a common scenario, we observed this failure on upgrading to Netty `4.1.80` and when using a custom bundle for a private key. From a quick glance, it looks like it should be resolved by ensuring that the input stream passed to the `BouncyCastlePemReader` is a copy, and process...
[ "handler/src/main/java/io/netty/handler/ssl/SslContext.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslContext.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslContext.java b/handler/src/main/java/io/netty/handler/ssl/SslContext.java index efb8e36b4b8..dc898915da7 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslContext.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslContext.java @@ -28,6 +28,7 @@ ...
null
train
test
2022-08-26T13:53:34
2022-08-26T23:07:17Z
argha-c
val
netty/netty/12787_12790
netty/netty
netty/netty/12787
netty/netty/12790
[ "keyword_pr_to_issue" ]
ef4a9dffeb3004a51b89e72330bd309a875f58e3
1440435865aa86a350094881b31005cb232424fc
[ "Thanks for the report." ]
[]
2022-09-09T18:39:30Z
[]
NPE with Paranoid leak detector and using a ByteProcessor on a CompositeBuffer of CompositeBuffer
### Expected behavior No exception ### Actual behavior Getting a NullPointerException ``` Caused by: java.lang.NullPointerException at io.netty.buffer.CompositeByteBuf.toComponentIndex0(CompositeByteBuf.java:930) at io.netty.buffer.CompositeByteBuf.forEachByteAsc0(CompositeByteBuf.java:672) ...
[ "buffer/src/main/java/io/netty/buffer/WrappedCompositeByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/WrappedCompositeByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/WrappedCompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/WrappedCompositeByteBuf.java index faef8f88b2a..5a31a5e9b40 100644 --- a/buffer/src/main/java/io/netty/buffer/WrappedCompositeByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/WrappedCompositeByte...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java index 20567176158..4bb21b15b19 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/Abstr...
train
test
2022-09-09T19:45:15
2022-09-09T13:06:22Z
mederel
val
netty/netty/12798_12799
netty/netty
netty/netty/12798
netty/netty/12799
[ "keyword_pr_to_issue" ]
75982ea652eee022287c0af29ed629be4d0a1bfd
570c5d75bd172fbb2f6f68685326d4acb3978482
[ "Just verified that the validation is fine for Safari but fails with Firefox." ]
[]
2022-09-13T01:27:13Z
[]
Chrome/Firefox send `upgrade-insecure-requests` header
https://github.com/netty/netty/pull/12755 is unfortunately breaking Chrome and Firefox which both (rightly or wrongly) send the `upgrade-insecure-requests` header: ``` [DEBUG|2022-09-13 10:23:29.419|netty-worker1 ||io.netty.handler.codec.http2.Http2FrameCodec] Stream exception thrown for unknown stream 1. io.netty...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java index cf474fce584..9d2bd875be8 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java +++ b/codec-http2/src/main/java/io/netty/h...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoderTest.java index 1b25fea70fc..ec5c4a23ef6 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecod...
val
test
2022-09-12T20:29:08
2022-09-13T00:57:02Z
glennosss
val
netty/netty/12933_12941
netty/netty
netty/netty/12933
netty/netty/12941
[ "keyword_issue_to_pr" ]
dd671fc3e04d037dbfb9c9b3bf5577b4ce90d2a1
ae9b82388e49cdc904e0ef4e81439486105d9d30
[ "\r\nMissing: header-> origin", "Please explain in more detail.", "When the websocketclient connection request header is missing the origin, a null pointer problem will occur", "@amizurov What's your take? Do we need validation to check for the origin header somewhere?", "Now he throws a null pointer. I thi...
[ "This is an odd usage of assertThrows:\r\n\r\n```suggestion\r\n assertInstanceOf(IllegalArgumentException.class, handshakeFuture.cause());\r\n```", "This is an odd usage of assertThrows:\r\n\r\n```suggestion\r\n assertInstanceOf(IllegalArgumentException.class, handshakeFuture.cause());\r\n```\r\n`...
2022-10-31T11:23:19Z
[]
WebSocketClientHandshaker java.lang.NullPointerException
WebSocketClientHandshaker ![1666764902075](https://user-images.githubusercontent.com/10923974/197948891-0bc9490a-8b02-4d0f-bc49-506fcb1a0d11.png)
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java", "codec-http/...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java", "codec-http/...
[ "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java", "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java", "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker08Test.java", ...
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java index e5ff31c6d94..2df036ac0a8 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java index 9d1606f3707..d84c9032c2a 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/websoc...
train
test
2022-10-31T11:40:45
2022-10-26T06:16:21Z
heixiaoma
val
netty/netty/12959_12978
netty/netty
netty/netty/12959
netty/netty/12978
[ "keyword_pr_to_issue" ]
a4c37bc06d16ba2267a3f8cac151f29bd9118aad
ecf489fb75d25d0fd35992d53f2e9bc6d9861e47
[]
[]
2022-11-08T22:14:45Z
[]
Netty's BlockHound integration assumes `FastThreadLocalThread` is always non-blocking
### Expected behavior The motivation is similar to https://github.com/netty/netty/issues/12125 which has already been reported and closed. I'm wondering if `FastThreadLocalThread` can be used for executing blocking tasks while integrating with Netty's `BlockHound` integration. ### Actual behavior Some libra...
[ "common/src/main/java/io/netty/util/concurrent/FastThreadLocalThread.java", "common/src/main/java/io/netty/util/internal/Hidden.java" ]
[ "common/src/main/java/io/netty/util/concurrent/FastThreadLocalThread.java", "common/src/main/java/io/netty/util/internal/Hidden.java" ]
[ "transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java" ]
diff --git a/common/src/main/java/io/netty/util/concurrent/FastThreadLocalThread.java b/common/src/main/java/io/netty/util/concurrent/FastThreadLocalThread.java index dcef6b28fda..9f7184ee9b5 100644 --- a/common/src/main/java/io/netty/util/concurrent/FastThreadLocalThread.java +++ b/common/src/main/java/io/netty/util/c...
diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java index 109543efe14..a005095d821 100644 --- a/transport-blockhound-tests/src/test/java/io/netty/util/intern...
test
test
2022-11-03T14:18:53
2022-11-02T14:07:07Z
jrhee17
val
netty/netty/12981_12988
netty/netty
netty/netty/12981
netty/netty/12988
[ "keyword_pr_to_issue" ]
76296425f4ee199de6dc3e3e03c40173cc5aa7de
ee9bb63aa5382bf9930eb0df4b690286173f126a
[ "I can contribute a fix for this." ]
[ "```suggestion\r\n // Check for dynamic table size updates, which must occur at the beginning:\r\n // https://www.rfc-editor.org/rfc/rfc7541.html#section-4.2\r\n decodeDynamicTableSizeUpdates(in);\r\n```", "```suggestion\r\n // See https://www.rfc-editor.org/rfc/rfc7541...
2022-11-11T09:32:53Z
[]
HPACK dynamic table size update must happen at the beginning of the header block
### Expected behavior HPACK decoder accepts dynamic table size update at the beginning of the block. Cf RFC 7531, section 4.2 ### Actual behavior HPACK decoder tolerates dynamic table size update anywhere in the block `io.netty.handler.codec.http2.HpackDecoder` can be modified to only allow setDynamicTab...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java index ab5fe18d183..8fb6a2635ad 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java +++ b/codec-http2/src/main/java/io/netty/h...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java index 452f4179cee..e376197f12b 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java +++ b/codec-http2/src/test/jav...
val
test
2022-11-11T10:20:41
2022-11-09T15:22:23Z
vietj
val
netty/netty/13003_13004
netty/netty
netty/netty/13003
netty/netty/13004
[ "keyword_pr_to_issue" ]
09ac33766f6c30d445dcdfb4285f589aedf5d7fe
6e935e073fe877a73ef55d5b2df0ba913d52de47
[ "@normanmaurer PTAL" ]
[ "I think this is not correct... this should still be optional otherwise we have it as non optional dependency for handler as well. \r\n\r\nSame its true for the other change in here. " ]
2022-11-16T12:23:20Z
[]
Release Handler-Ssl-Ocsp
Netty [Handler-Ssl-Ocsp](https://github.com/netty/netty/commit/09ac33766f6c30d445dcdfb4285f589aedf5d7fe) was merged but the module is not present in bom.xml. Hence, snapshots are not being deployed.
[ "all/pom.xml", "bom/pom.xml", "handler-ssl-ocsp/pom.xml" ]
[ "all/pom.xml", "bom/pom.xml", "handler-ssl-ocsp/pom.xml" ]
[]
diff --git a/all/pom.xml b/all/pom.xml index 9f22ed3b174..d19dd9e52d4 100644 --- a/all/pom.xml +++ b/all/pom.xml @@ -298,6 +298,11 @@ <artifactId>netty-handler-proxy</artifactId> <scope>compile</scope> </dependency> + <dependency> + <groupId>io.netty</groupId> + <artifactId>netty-handler...
null
train
test
2022-11-15T20:10:44
2022-11-16T12:08:43Z
hyperxpro
val
netty/netty/13018_13021
netty/netty
netty/netty/13018
netty/netty/13021
[ "keyword_pr_to_issue" ]
3bff0bee692b5bcb67f8fe5f900d2e899a7fa1f8
b64a6e22b2f410d3092f4a2e9f8edcf8c51262b2
[ "@chrisvest I investigated the issue and didn't find a behavior change in HashedWheelTimer. I used HashedWheelTimerTest and made several variations of testExecutionOnTime. \r\n\r\nThere might be some subtle change that causes the issue, and we'll just have to deal with that in Pulsar.", "@lhotari After reading yo...
[]
2022-11-27T00:16:58Z
[]
HashedWheelTimer task scheduling behavior changed in 4.1.85
### Expected behavior The expectation is that task scheduling behavior of HashedWheelTimer doesn't change significantly between Netty 4.1.x releases. ### Actual behavior The HashedWheelTimer behavior changed in some way that makes multiple integration tests to fail in Apache Pulsar. The only change in HashedW...
[ "common/src/main/java/io/netty/util/HashedWheelTimer.java" ]
[ "common/src/main/java/io/netty/util/HashedWheelTimer.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/HashedWheelTimer.java b/common/src/main/java/io/netty/util/HashedWheelTimer.java index 126f9998104..8db3ea747e1 100644 --- a/common/src/main/java/io/netty/util/HashedWheelTimer.java +++ b/common/src/main/java/io/netty/util/HashedWheelTimer.java @@ -116,7 +116,6 @@ public ...
null
test
test
2022-11-24T14:34:25
2022-11-25T19:20:42Z
lhotari
val
netty/netty/12000_13099
netty/netty
netty/netty/12000
netty/netty/13099
[ "keyword_pr_to_issue" ]
9541bc17e0c637ec77ccc3d6b67a19a0d024f925
52db529c9daf1017422e3c4a8810da09e66d14a6
[ "Related to https://github.com/spring-cloud/spring-cloud-gateway/issues/2493" ]
[ "I think we still need to ensure we only create a `SSLHandshakeException` if we are really still handshaking.\r\n```suggestion\r\n final Exception exception;\r\n if (handshakePromise.isDone()) {\r\n exception = new ClosedChannelException();\r\n } else {\r\n // Closed befor...
2023-01-05T19:39:01Z
[]
exception when close channel before SSL
### Expected behavior close channel no exception ### Actual behavior 2022/01/13 17:56:07.897 [] [reactor-http-epoll-2] [WARN] i.n.h.s.ApplicationProtocolNegotiationHandler - [id: 0xa03cf599, L:/189.11.24.119:8443 ! R:/189.11.24.38:39277] Failed to select the application-level protocol: java.nio.channels.ClosedChann...
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java", "handler/src/main/java/io/netty/handler/ssl/StacklessSSLHandshakeException.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java index d59b504c709..83ce18e747f 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java @@ -47,6 +47,7 @@ ...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java index 70aef23b602..bd8e0ac79e5 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java @@ ...
train
test
2023-01-23T11:06:24
2022-01-13T13:06:59Z
xingzhang8023
val
netty/netty/10616_13158
netty/netty
netty/netty/10616
netty/netty/13158
[ "keyword_pr_to_issue" ]
315c738b6f2b4a0d69e5e4e6f6188fb6774878bc
79b347234af27f34344fecc2b5651295f3cd3e7c
[ "Can you add instructions for building and running your repro?", "Sorry yes, updated comment.", "@perezd How do you make the repro use a Netty version that's built and installed into the local `~/.m2/` repository? I'm trying to make it use a local `4.1.53.Final-SNAPSHOT` version, but just changing the `NETTY_VE...
[]
2023-01-26T18:53:30Z
[ "graal" ]
native-image compilation of epoll transport fails
### Expected behavior My small repro compiles as a native image and works as expected if I use Nio* family of transports. My expectation was that switching to epoll transport would similarly work. ### Actual behavior If I switch to epoll (linux-x86_64) I get a compilation error: ``` Error: Classes that should ...
[]
[ "transport-classes-epoll/src/main/resources/META-INF/native-image/io.netty/netty-transport-classes-epoll/jni-config.json", "transport-classes-epoll/src/main/resources/META-INF/native-image/io.netty/netty-transport-classes-epoll/native-image.properties", "transport-classes-epoll/src/main/resources/META-INF/nativ...
[]
diff --git a/transport-classes-epoll/src/main/resources/META-INF/native-image/io.netty/netty-transport-classes-epoll/jni-config.json b/transport-classes-epoll/src/main/resources/META-INF/native-image/io.netty/netty-transport-classes-epoll/jni-config.json new file mode 100644 index 00000000000..493b2ed220a --- /dev/null...
null
val
test
2023-01-26T12:13:27
2020-09-28T00:33:12Z
perezd
val
netty/netty/13208_13209
netty/netty
netty/netty/13208
netty/netty/13209
[ "keyword_pr_to_issue" ]
cfcdd93db5fd9af6254144caad68f4ed29a3dc64
1cfe7103fbf7acdc5e21365419e9565955540703
[ "When can this be released ?", "I think in the next 2-3 weeks. " ]
[ "API Breakage", "API Breakage", "API Breakage", "API Breakage", "API Breakage", "API Breakage", "API Breakage", "I know there is API breakage, but I was wondering if we can still afford it given that this interface is pretty recent.", "No, we can't break applications.", "Hmm, then I need to figure...
2023-02-10T09:22:22Z
[]
Display which header failed validation
### Expected behavior Currently if a HeaderValue fails validation we get an IllegalArgumentException which has the message `a header value contains prohibited character {some_invalid_character} at index {index}`. Seeing this in production makes it hard to debug which header is having this problem. ### Actual beha...
[ "codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java" ]
[ "codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java" ]
diff --git a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java index 6abe71be0e2..6ff05fd6acb 100644 --- a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java +++ b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java @@ ...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java index 4cd1beedfe3..77e6fd37629 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java +++ b/codec-http/s...
train
test
2023-02-14T11:05:12
2023-02-10T09:12:50Z
adwsingh
val
netty/netty/13235_13238
netty/netty
netty/netty/13235
netty/netty/13238
[ "keyword_issue_to_pr" ]
24a0ac36ea91d1aee647d738f879ac873892d829
1314ede822a4a94be2446042d4b112649ae9ddc7
[ ">Netty version Used : 1.0.24\r\n\r\n\r\n@adhanoti Is this version, Reactor Netty version?\r\n\r\nIf yes then may be we would better discuss this in Reactor Netty issue tracker", "Thanks. Yes it is reactor netty version.\n\nDo i need to create separate issue?\n\nRegards,\nAshish\n\nOn Tue, Feb 21, 2023 at 12:07 P...
[ "These lines should be moved into the `VALUE_VALIDATOR` on line 86.", "The `VALUE_VALIDATOR` receives only the value. How can we match name `:path` with the value?\r\nhttps://github.com/netty/netty/blob/59aa6e635b9996cf21cd946e64353270679adc73/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Hea...
2023-02-22T08:54:46Z
[]
RFC non complaince : RFC 7540 "Hypertext Transfer Protocol Version 2 (HTTP/2)" https://datatracker.ietf.org/doc/html/rfc7540
**RFC behavior :** RFC7540 Section 8.1.2.3 : "All HTTP/2 requests MUST include exactly one valid value for the ":method", ":scheme", and ":path" pseudo-header field, unless it is a CONNECT request. An HTTP request that omits mandatory pseudo-header fields is malformed." RFC7540 Section 8.1.2.6 "Malformed re...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/HttpConversionUtilTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java index 91a6545b763..60a2925873c 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Headers.java +++ b/codec-http2/src...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java index e376197f12b..f70f528e6ca 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java +++ b/codec-http2/src/test/jav...
train
test
2023-04-03T12:18:53
2023-02-21T06:32:31Z
adhanoti
val
netty/netty/13307_13312
netty/netty
netty/netty/13307
netty/netty/13312
[ "keyword_pr_to_issue" ]
ccc5e01f0444301561f055b02cd7c1f3e875bca7
cd540193b98e1ffb9cdaaf2629e4a6d28665a2c5
[ "Extend the `HttpContentDecompressor` and override the `newContentDecoder` for Snappy and delegate the rest to `super#newContentDecoder`.", "> Extend the `HttpContentDecompressor` and override the `newContentDecoder` for Snappy and delegate the rest to `super#newContentDecoder`.\r\n\r\nThanks for the guidance @hy...
[ "```suggestion\r\n if (SNAPPY.contentEqualsIgnoreCase(contentEncoding)) {\r\n```", "```suggestion\r\n \r\n```", "```suggestion\r\n -22, 104, 101, 108, 108, 111, 44, 32, 119, 111, 114, 108, 100\r\n```", "```suggestion\r\n```", "```suggestion\r\n```", "```suggestion\r\n return n...
2023-03-30T19:36:44Z
[]
Extend decompression of HttpContentDecompressor.java
### Actual behaviour At the moment the [HttpContentDecompressor.java](https://github.com/netty/netty/blob/cf5c467f4ead5ba5e1e36f5c4903af78bd49c35c/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java#LL58C9-L73) support: - deflate - gzip - brotli I wonder if we should extend it ?...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaderValues.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java index d66151d463c..e8e1d909723 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java +++ b/codec-htt...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java index 71ddb15213a..aeca8dcf3c2 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java +++ b/codec-http/s...
val
test
2023-03-29T12:35:58
2023-03-29T13:52:42Z
redcinelli
val
netty/netty/13335_13336
netty/netty
netty/netty/13335
netty/netty/13336
[ "keyword_pr_to_issue" ]
1314ede822a4a94be2446042d4b112649ae9ddc7
de876d197a945e2b3a4a96b90a65c00611b77806
[]
[ "should this be `execute(task, false)`?", "check `SingleThreadEventExecutor::lazyExecute` overridden method:\r\n\r\n```java\r\n @Override\r\n public void lazyExecute(Runnable task) {\r\n lazyExecute0(task);\r\n }\r\n\r\n private void lazyExecute0(@Schedule Runnable task) {\r\n execute(Ob...
2023-04-17T09:51:25Z
[ "cleanup" ]
Deprecates LazyRunnable
https://ionutbalosin.com/2023/03/jvm-performance-comparison-for-jdk-17/#typecheckbenchmark shows how bad currently JITs handle type checking of interfaces not implemented by a concrete type. I've built an [agent](https://github.com/RedHatPerf/type-pollution-agent) that can detect such slow paths and by using it in a...
[ "common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java", "common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java", "transport/src/main/java/io/netty/channel/SingleThreadEventLoop.java" ]
[ "common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java", "common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java", "transport/src/main/java/io/netty/channel/SingleThreadEventLoop.java" ]
[ "common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java" ]
diff --git a/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java index ce6b1ac875f..b32978ee679 100644 --- a/common/src/main/java/io/netty/util/concurrent/AbstractEventExecutor.java +++ b/common/src/main/java/io/netty/util/c...
diff --git a/common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java b/common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java index 8465ea8d3ae..dc12034bcc5 100644 --- a/common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java +++ b/common/src/t...
test
test
2023-04-16T02:01:52
2023-04-17T09:45:03Z
franz1981
val
netty/netty/13337_13338
netty/netty
netty/netty/13337
netty/netty/13338
[ "keyword_issue_to_pr", "keyword_pr_to_issue" ]
1314ede822a4a94be2446042d4b112649ae9ddc7
f2eca0f4e9bed48e6b139c30d626a9368249942f
[ "This is either because you don't have an `HttpRequestDecoder` or a `HttpServerCodec` in your pipeline, or something else in your pipeline dropped the handshake response in the write path.", "If the pipeline checks fail, how can i release the handshake response.", "> If the pipeline checks fail, how can i relea...
[]
2023-04-17T14:42:48Z
[]
WebSocketServerHandshaker.handshake not call ByteBuf.release()
### Expected behavior 2023-02-08 01:32:25.622 [nioEventLoopGroup-3-11-] ERROR io.netty.util.ResourceLeakDetector - LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at: io.netty.buffer...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java" ]
[]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java index 3c3fac5a49c..5271102b7eb 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock...
null
test
test
2023-04-16T02:01:52
2023-04-17T14:02:11Z
fengxuehan
val
netty/netty/13384_13386
netty/netty
netty/netty/13384
netty/netty/13386
[ "keyword_pr_to_issue" ]
af132ffc483f68d06eed746797fff2af652bcd35
91f484371b8db359bab06df691e2d3d0300a4670
[ "You can specify a CNAME cache by calling `DnsNameResolverBuilder.cnameCache(DnsCnameCache)`, specifying `new DefaultDnsCnameCache()` with the desired min/max TTL values. Would this work for you?", "Thanks for the response, Trustin. This would work, but it feels like a workaround as opposed to allowing ttl values...
[]
2023-05-17T06:17:45Z
[]
Unable to supply resolveCache to DnsNameResolverBuilder and use TTL's for other two caches
### Expected behavior If a resolveCache is set in the DnsNameResolverBuilder the min, max and negative TTL fields must be null. However, this means the cname cache and authoritative DNS server cache will be built with default (fallback) TTLs as opposed to a TTL which the user may want to set. I'd expect to be abl...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DefaultAuthoritativeDnsServerCache.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCnameCache.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DefaultAuthoritativeDnsServerCache.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCnameCache.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java" ]
[ "resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverBuilderTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultAuthoritativeDnsServerCache.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultAuthoritativeDnsServerCache.java index c29f7b866b9..b75db05a7da 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultAuthoritativeDnsServerCache...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverBuilderTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverBuilderTest.java new file mode 100644 index 00000000000..bfe7bfb4740 --- /dev/null +++ b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverBuilder...
train
test
2023-05-15T16:00:32
2023-05-16T10:41:26Z
samueldlightfoot
val
netty/netty/13417_13419
netty/netty
netty/netty/13417
netty/netty/13419
[ "keyword_pr_to_issue" ]
c1a6994455cea05c873502416cc34d7d9d9610ad
22ce6d17032c30307840744e5c4c38d7af189673
[ "thanks @violetagg " ]
[]
2023-06-02T13:06:51Z
[]
Domain socket channel local address is null
### Expected behavior The domain socket local address is not null. ### Actual behavior The domain socket local address is null. `QueueDomainSocketChannel#localAddress0()` returns `local` field which has never been set before (other than null at construction time and in `doConnect`). It should reflect the ...
[ "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannel.java", "transport-classes-kqueue/src/main/java/io/netty/channel/kqueue/KQueueDomainSocketChannel.java" ]
[ "transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannel.java", "transport-classes-kqueue/src/main/java/io/netty/channel/kqueue/KQueueDomainSocketChannel.java" ]
[ "testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketAddressesTest.java" ]
diff --git a/transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannel.java b/transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannel.java index 0773e39133a..b72dd69fa5e 100644 --- a/transport-classes-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketC...
diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketAddressesTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketAddressesTest.java index ecab824f887..dce8c082bd1 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketAddressesTest.java +++ b/...
val
test
2023-06-01T14:00:12
2023-06-01T12:41:04Z
vietj
val
netty/netty/13313_13451
netty/netty
netty/netty/13313
netty/netty/13451
[ "keyword_pr_to_issue" ]
22bf43b03999f40459c61b61c453e0989563cc98
dd2c2bbb723c9a10e3efc6d7bc2cc4a4720375e2
[ "Unfortunately, those pictures are not worth even a single word. That's too less information to conclude anything. \r\n\r\nWhat kind of workload is it? How many connections? Are you running blocking operations on EventLoop?", "> Unfortunately, those pictures are not worth even a single word. That's too less infor...
[]
2023-06-15T17:25:21Z
[]
the cpu usage is too high(80%) when run netty server thread named NioEventLoopGroup-3-1
### Expected behavior ### Actual behavior ### Steps to reproduce ### Minimal yet complete reproducer code (or URL to code) int processors = Runtime.getRuntime().availableProcessors(); EventLoopGroup bossGroup = new NioEventLoopGroup(processors*2); EventLoopGroup workerGroup = new NioEventLoopGroup(processor...
[ "codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java" ]
[]
diff --git a/codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java b/codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java index 0dea8857765..68197365602 100644 --- a/codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java +++ b/codec/src/main/java/io/netty/h...
null
train
test
2023-06-14T14:10:36
2023-03-31T03:22:05Z
zzy444626905
val
netty/netty/13321_13451
netty/netty
netty/netty/13321
netty/netty/13451
[ "keyword_issue_to_pr" ]
22bf43b03999f40459c61b61c453e0989563cc98
dd2c2bbb723c9a10e3efc6d7bc2cc4a4720375e2
[ "You can use `ByteBufUtil.indexOf` to implement a faster `DelimiterBasedFrameDecoder.indexOf`, if you're up for doing a PR. There's some finicky behavior that needs to be preserved, though.", "your delimiter is a single char one @zzy444626905 ? if yes, it shouldn't be that cost if you use a recent enough version ...
[]
2023-06-15T17:25:21Z
[]
netty cpu usage is too high when use DelimiterBasedFrameDecoder
"nioEventLoopGroup-3-1" Id=14 cpuUsage=79.15% deltaTime=171ms time=9015ms RUNNABLE at io.netty.handler.codec.DelimiterBasedFrameDecoder.indexOf(DelimiterBasedFrameDecoder.java:314) at io.netty.handler.codec.DelimiterBasedFrameDecoder.decode(DelimiterBasedFrameDecoder.java:236) at io.netty.handler.codec.D...
[ "codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java" ]
[]
diff --git a/codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java b/codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java index 0dea8857765..68197365602 100644 --- a/codec/src/main/java/io/netty/handler/codec/DelimiterBasedFrameDecoder.java +++ b/codec/src/main/java/io/netty/h...
null
val
test
2023-06-14T14:10:36
2023-04-07T00:58:13Z
zzy444626905
val
netty/netty/13328_13452
netty/netty
netty/netty/13328
netty/netty/13452
[ "keyword_pr_to_issue" ]
bf8e77974c4e470be002415ea04ca567ded6d9b7
26a7df3e9a5a4945786a736ad28cb2db62015016
[ "Good find, we'll take a look." ]
[ "should we use `array[i].equals(o)` ?", "imho this would be \"safer\". ", "Changed it to `Objects.equals` in line with the API spec recommendation – it handles `null` values correctly.", "Oh no, that's not available in the older Java versions. Fine." ]
2023-06-15T18:49:43Z
[]
Possible issues with SelectedSelectionKeySet in non-linux operating systems
`SelectedSelectionKeySet` doesn't implement `contains()` method. Or at least it returns always false. This may create issues in non-linux operating systems. To give you more context, in my work, like you do, we try to not produce garbage by replacing `HashSet` with something similar to `SelectedSelectionKeySet`. Act...
[ "transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java" ]
[ "transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java" ]
[ "transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java b/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java index 7117b06029e..b9c72b635cd 100644 --- a/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java +++ b/transport/src/main/java/io/netty/...
diff --git a/transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java b/transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java index 46dde8b575d..9f5bb2c23db 100644 --- a/transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java +++ b/transport/src/test/ja...
val
test
2023-06-15T21:41:12
2023-04-13T14:07:54Z
ramizdundar
val
netty/netty/13536_13539
netty/netty
netty/netty/13536
netty/netty/13539
[ "keyword_pr_to_issue" ]
64c898307de06a49f365093bb823bd4b7966c3d3
a02644415681e6efc233ff77540003a48908dbf4
[]
[ "can you add a comment to explain where these values come from ?", "Does this mean Java < 8 are not supported?", "@hyperxpro good point... maybe we should just add a version check as well. Let me do this " ]
2023-08-09T01:22:31Z
[]
Add support for password-based encryption scheme 2 params (PBES2)
### Expected behavior no exception ### Actual behavior ``` Caused by: java.security.NoSuchAlgorithmException: 1.2.840.113549.1.5.13 SecretKeyFactory not available at javax.crypto.SecretKeyFactory.<init>(SecretKeyFactory.java:122) at javax.crypto.SecretKeyFactory.getInstance(SecretKeyFactory.java:160) at io.ne...
[ "handler/src/main/java/io/netty/handler/ssl/SslContext.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslContext.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslContextTest.java", "handler/src/test/resources/io/netty/handler/ssl/generate-certs.sh", "handler/src/test/resources/io/netty/handler/ssl/rsa_pbes2_enc_pkcs8.key" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslContext.java b/handler/src/main/java/io/netty/handler/ssl/SslContext.java index dc898915da7..a74b18a693c 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslContext.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslContext.java @@ -27,6 +27,7 @@ ...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java b/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java index 6f0cfe9eb79..5f43df24e27 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java @@ ...
train
test
2023-08-18T10:52:19
2023-08-08T03:24:15Z
xiezhaokun
val
netty/netty/13540_13546
netty/netty
netty/netty/13540
netty/netty/13546
[ "keyword_pr_to_issue" ]
6f1646fe3aaa5c53f1f1376e049c71e69030dc40
aa07be47d9d2bbb09b1ca9897575ebc4de6056c0
[ "I have reproduced it and found that the decoded value is **not equal** to the original value whenever the `enableHuffmanEncoding` is true or false. And I found a comment in `HpackEncoder.java`: Only **ASCII** is allowed in http2 headers(https://tools.ietf.org/html/rfc7540#section-8.1.2), so if there exists unexpec...
[ "We cannot directly use `AsciiString.c2b(...)` here because this function does 2 things:\r\n\r\n1. Sanitize the given input char.\r\n2. Cast the sanitized char to a `byte`.\r\n\r\nThen we cast the returned `byte` to `int b`. Overall, we are doing `sanitizedChar.toByte.toInt` and it could yield negative value which ...
2023-08-13T06:41:56Z
[]
Unexpected characters are synthesized by DefaultHttp2HeadersDecoder when Huffman encoding is enabled in HpackEncoder
### What happened? 1. Create a header `DefaultHttp2Headers` with a certain value that exceeds certain size and contain non-ASCII characters, 2. Encode the header using `DefaultHttp2HeadersEncoder`. 3. Decode the encoded header using `DefaultHttp2HeadersDecoder`. 4. If Huffman encoding is enabled in the `HpackDecod...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanEncoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanEncoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackHuffmanTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java index 322898f94a1..8f2d5a4df9f 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java +++ b/codec-http2/src/main/java/io/netty/h...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java index b5f5d6879b8..2a54fbfab9a 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java +++ b/codec-http2/src/test/jav...
val
test
2023-08-10T19:48:40
2023-08-09T07:05:07Z
Lincong
val
netty/netty/13612_13614
netty/netty
netty/netty/13612
netty/netty/13614
[ "keyword_issue_to_pr" ]
709137e8821e84e98646de7b5b5ac1fd84451041
4e17ab6528d7b18236826b75cf55b0cf61b1a129
[ "@fax4ever the `java.lang.ExceptionInInitializerError`should have a cause set... can you add this one as well ?", "> @fax4ever the `java.lang.ExceptionInInitializerError`should have a cause set... can you add this one as well ?\r\n\r\nDebugging the following seems to be the cause:\r\n\r\n``` bash\r\njava.lang.Ill...
[ "We can reuse the `addr` variable here, instead of recreating the `InetSocketAddress` object." ]
2023-09-15T10:33:02Z
[]
Error parsing IPv6 interface Unix resolv.conf
### Expected behavior I have the following `/etc/resolv.conf`: ``` conf # Generated by NetworkManager search localdomain nameserver 10.211.55.1 nameserver fe80::21c:42ff:fe00:18%enp0s5 ``` if I comment the last line, it works! my network interfaces are: ``` bash [fabio@localhost infinispan]$ ip add...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java b/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java index 33f461b47f2..f8eff1740ed 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsSer...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java index 41411baf751..f00035912ee 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolv...
test
test
2023-09-18T23:36:35
2023-09-15T08:50:37Z
fax4ever
val
netty/netty/13515_13695
netty/netty
netty/netty/13515
netty/netty/13695
[ "keyword_pr_to_issue" ]
285ba74f899866ddf3e23a6770c954e350245bd7
2241f829e223f1959e8d04f5c8c4c5612d4d0885
[ "Via local builds I was able to isolate the problematic commit: https://github.com/netty/netty/commit/dc69a943c3682fec16845828cb6d8f0554fad61f\r\n\r\nStill not sure what this breaks - we're using standard PEM format like:\r\n\r\n```\r\n-----BEGIN CERTIFICATE-----\r\n<a bunch of base 64>\r\n-----END CERTIFICATE-----...
[]
2023-11-10T09:00:53Z
[]
SSL certificate parsing issue when upgrading beyond 4.1.78 on Android
### Expected behavior We're running a gRPC server on Android. We use SSL and have certificates that work until version 4.1.79, and we'd like to be able to continue to use them on more recent versions. Looking for hints to debug why this would suddenly start failing. ### Actual behavior Certificates fail to par...
[ "handler/src/main/java/io/netty/handler/ssl/PemReader.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/PemReader.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/PemReader.java b/handler/src/main/java/io/netty/handler/ssl/PemReader.java index 0ee79b71457..33328ea672d 100644 --- a/handler/src/main/java/io/netty/handler/ssl/PemReader.java +++ b/handler/src/main/java/io/netty/handler/ssl/PemReader.java @@ -84,14 +84,21 @@ sta...
null
test
test
2023-11-09T09:43:31
2023-07-26T02:51:59Z
andrewparmet
val
netty/netty/13745_13746
netty/netty
netty/netty/13745
netty/netty/13746
[ "keyword_pr_to_issue" ]
427ace4cdd86cce84e467ec0a8a81ca022ed6f72
7700680138f2310a4d9df51cd0805853c8acdd38
[ "I've verified via https://github.com/franz1981/java-puzzles/commit/e083daa22878511c475135b5863b861471e617a6 that thanks to https://github.com/openjdk/jdk/pull/14375 the type check performed at https://github.com/netty/netty/blob/5155482afc57907a1414994ef5aca79b61ac6999/transport/src/main/java/io/netty/channel/Chan...
[]
2023-12-21T14:06:40Z
[ "improvement" ]
Http 2 type check slow path detected
This is the `MISS` report from a load test running against a HTTP 2 server written in Netty (basically an hello world-like case, really): ``` -------------------------- Miss: -------------------------- 1: io.netty.handler.codec.http2.Http2CodecUtil$SimpleChannelPromiseAggregator Count: 208210860 Types: ...
[ "transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java" ]
[ "transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java" ]
[]
diff --git a/transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java b/transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java index 20a0ba09f7b..33f3d81d8e1 100644 --- a/transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java +++ b/transport/src/main/java/io/...
null
train
test
2023-12-19T22:05:52
2023-12-21T09:13:44Z
franz1981
val
netty/netty/13740_13769
netty/netty
netty/netty/13740
netty/netty/13769
[ "keyword_pr_to_issue" ]
b1947417b7444326965086b951b75f0128cf7085
6c883d620722c12e19561ce1a10b41fadfbd6a60
[ "We are also facing the same issue.", "We are also facing the same issue" ]
[]
2024-01-07T17:58:34Z
[]
Partitioned attribute support in ResponseCookie class
Chrome is going to deprecate third party cookies in near future, and it is mentioned [here](https://developers.google.com/privacy-sandbox/3pcd). We have many integration/leading applications depends on cross site cookies; all those will not work if the third-party cookies are not allowed to use. There are some s...
[ "codec-http/src/main/java/io/netty/handler/codec/http/cookie/ClientCookieDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/cookie/CookieHeaderNames.java", "codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java", "codec-http/src/main/java/io/netty/handler/codec/http/...
[ "codec-http/src/main/java/io/netty/handler/codec/http/cookie/ClientCookieDecoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/cookie/CookieHeaderNames.java", "codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java", "codec-http/src/main/java/io/netty/handler/codec/http/...
[ "codec-http/src/test/java/io/netty/handler/codec/http/cookie/ClientCookieDecoderTest.java", "codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieEncoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ClientCookieDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ClientCookieDecoder.java index e143b319051..8b967507c28 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/ClientCookieDecoder.java +++ b/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ClientCookieDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ClientCookieDecoderTest.java index deb0edbf339..2cf53b59338 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ClientCookieDecoderTest...
train
test
2024-01-16T10:02:14
2023-12-19T08:47:26Z
aramired
val
netty/netty/13788_13789
netty/netty
netty/netty/13788
netty/netty/13789
[ "keyword_pr_to_issue" ]
e2c8a9774728c4855191293d0697a03729477f84
b611fdebdf7787c214732991fb9142662f2583eb
[ "Is this issue (https://github.com/grpc/grpc-java/issues/10830) resolved by this PR? ", "@njimenezotto That issue is completely different than this." ]
[ "Does this work correctly if there are two different messages in the `input` ByteBuffer waiting to be processed? In my minds eye it will skip them both.", "I think you're right, if there's more data already buffered it'll skip all of it. I'm trying to think of an alternative but if the length of the payload doesn...
2024-01-18T05:02:39Z
[]
DefaultHttp2FrameReader does not reset after malformed request comes in
### Expected behavior After a request comes in which causes a stream error, (such as a priority frame with an invalid stream dependency or with an invalid payload length) the following frame must be treated as a new frame. ### Actual behavior After such a malformed request comes in, the following frame after the m...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameReaderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java index dc0857ec6b8..dae497d9bb5 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java +++ b/cod...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameReaderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameReaderTest.java index bfedf0ac619..8ba309cc617 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameReaderTest.ja...
train
test
2024-02-08T10:51:32
2024-01-17T20:50:10Z
isaacrivriv
val