repo stringclasses 37
values | instance_id stringlengths 17 34 | base_commit stringlengths 40 40 | patch stringlengths 291 1.62M | test_patch stringlengths 307 76.5k | problem_statement stringlengths 40 59.9k | hints_text stringlengths 0 149k | created_at stringdate 2018-06-13 17:01:37 2024-12-20 00:40:00 | merged_at stringdate 2018-09-24 06:57:54 2024-12-20 20:16:12 | PASS_TO_PASS stringlengths 2 601k | PASS_TO_FAIL stringclasses 11
values | FAIL_TO_PASS stringlengths 18 605k | FAIL_TO_FAIL stringclasses 60
values | install stringlengths 217 12.7k | test_framework stringclasses 10
values | test_commands stringclasses 10
values | version null | environment_setup_commit null | docker_image_root stringclasses 1
value |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
streamlink/streamlink | streamlink__streamlink-6012 | 6f1413e581392ec140c5a9176f940a928f7ce1d4 | diff --git a/src/streamlink/plugins/kick.py b/src/streamlink/plugins/kick.py
new file mode 100644
index 00000000000..8389ffa5e6b
--- /dev/null
+++ b/src/streamlink/plugins/kick.py
@@ -0,0 +1,190 @@
+"""
+$description Global live-streaming and video hosting social platform owned by Kick Streaming Pty Ltd.
+$url kick.com... | diff --git a/tests/plugins/test_kick.py b/tests/plugins/test_kick.py
new file mode 100644
index 00000000000..3421ea92c5c
--- /dev/null
+++ b/tests/plugins/test_kick.py
@@ -0,0 +1,12 @@
+from streamlink.plugins.kick import Kick
+from tests.plugins import PluginCanHandleUrl
+
+
+class TestPluginCanHandleUrlKick(PluginCan... | Kick.com
### Checklist
- [X] This is a plugin request and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#contributing-to-streamlink)
- [X] [I have checked th... | I'd argue that Kick still violates rule 10 of the [contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#plugin-requests):
> Sites which have no way to determine viewership numbers
> Plugins must not implement websites which are unused or which only have a handful of real/act... | 2024-05-31T16:04:41Z | 2024-06-03T18:26:21Z | [] | [] | ["tests/plugins/test_kick.py::TestPluginCanHandleUrlKick::test_all_named_matchers_have_tests[clip]", "tests/plugins/test_kick.py::TestPluginCanHandleUrlKick::test_all_matchers_match[live]", "tests/plugins/test_kick.py::TestPluginCanHandleUrlKick::test_url_matches_positive_named[NAME=vod URL=https://kick.com/video/VIDEO... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.15.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.6.2", "charset-normalizer==3.3.2", "coverage==7.5.3", "docutils==0.21.2", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-6016 | 6f78ab12df402b801628b4fa1b2071b0a7a01bb2 | diff --git a/src/streamlink/plugins/twitch.py b/src/streamlink/plugins/twitch.py
index 32666d04852..ac73b52e044 100644
--- a/src/streamlink/plugins/twitch.py
+++ b/src/streamlink/plugins/twitch.py
@@ -71,6 +71,15 @@ class TwitchM3U8Parser(M3U8Parser[TwitchM3U8, TwitchHLSSegment, HLSPlaylist]):
__m3u8__: ClassVar[T... | diff --git a/tests/plugins/test_twitch.py b/tests/plugins/test_twitch.py
index 89ea494f900..1d2984a0525 100644
--- a/tests/plugins/test_twitch.py
+++ b/tests/plugins/test_twitch.py
@@ -341,12 +341,12 @@ def test_hls_low_latency_has_prefetch_disable_ads_no_preroll_with_prefetch_ads(s
Seg, Pre = Segment, Segment... | plugins.twitch: incorrect discontinuity tags lead to warnings being spammed
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://git... | This has nothing to do with Twitch. It's a bug in the HLS implementation which warns when there's a stream discontinuity, which is not supported by Streamlink, as two different bitstreams are concatenated. This happens during ad transitions. The warning however is not supposed to be written to the log output every time... | 2024-06-02T20:15:04Z | 2024-06-03T18:25:49Z | ["tests/plugins/test_twitch.py::TestTwitchHLSStream::test_hls_low_latency_no_prefetch", "tests/plugins/test_twitch.py::TestPluginCanHandleUrlTwitch::test_url_matches_groups_unnamed[URL=https://www.twitch.tv/weplaydota/clip/FurryIntelligentDonutAMPEnergyCherry-akPRxv7Y3w58WmFq GROUPS={'subdomain': 'www', 'channel': 'wep... | [] | ["tests/plugins/test_twitch.py::TestTwitchHLSStream::test_hls_incorrect_discontinuity", "tests/plugins/test_twitch.py::TestTwitchHLSStream::test_hls_low_latency_has_prefetch_disable_ads_no_preroll_with_prefetch_ads", "tests/plugins/test_twitch.py::TestTwitchMetadata::test_metadata_clip_no_data[False-https://clips.twitc... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.15.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.6.2", "charset-normalizer==3.3.2", "coverage==7.5.3", "docutils==0.21.2", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5731 | 60fca3485a1a4a2d43dca43e3cfb14dd7cb6ba4a | diff --git a/src/streamlink/plugins/chzzk.py b/src/streamlink/plugins/chzzk.py
new file mode 100644
index 00000000000..dc8d3099279
--- /dev/null
+++ b/src/streamlink/plugins/chzzk.py
@@ -0,0 +1,196 @@
+"""
+$description South Korean live-streaming platform for gaming, entertainment, and other creative content. Owned by... | diff --git a/tests/plugins/test_chzzk.py b/tests/plugins/test_chzzk.py
new file mode 100644
index 00000000000..19701da882d
--- /dev/null
+++ b/tests/plugins/test_chzzk.py
@@ -0,0 +1,11 @@
+from streamlink.plugins.chzzk import Chzzk
+from tests.plugins import PluginCanHandleUrl
+
+
+class TestPluginCanHandleUrlChzzk(Plu... | CHZZK, Naver‘s new Korean streaming plateform
### Checklist
- [X] This is a plugin request and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#contributing-t... | 2023-12-19T15:07:57Z | 2024-05-10T12:01:16Z | [] | [] | ["tests/plugins/test_chzzk.py::TestPluginCanHandleUrlChzzk::test_url_matches_groups_named[NAME=live URL=https://chzzk.naver.com/live/CHANNEL_ID GROUPS={'channel_id': 'CHANNEL_ID'}]", "tests/plugins/test_chzzk.py::TestPluginCanHandleUrlChzzk::test_url_matches_groups_named[NAME=video URL=https://chzzk.naver.com/video/VID... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.15.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.5.1", "docutils==0.21.2", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5932 | f43d0eb4714de529a45dd9161e7774d070699bad | diff --git a/src/streamlink/plugin/api/validate/_validators.py b/src/streamlink/plugin/api/validate/_validators.py
index 69135b74919..e99d305733f 100644
--- a/src/streamlink/plugin/api/validate/_validators.py
+++ b/src/streamlink/plugin/api/validate/_validators.py
@@ -651,4 +651,8 @@ def validator_parse_qsd(*args, **kw... | diff --git a/tests/test_api_validate.py b/tests/test_api_validate.py
index ceff9bc1dde..c328116d27b 100644
--- a/tests/test_api_validate.py
+++ b/tests/test_api_validate.py
@@ -1343,13 +1343,20 @@ def test_success(self):
validate.parse_qsd(),
"foo=bar&foo=baz&qux=quux",
) == {"foo": "... | tests: py311: FAILED tests/test_api_validate.py::TestParseQsdValidator::test_failure
This test failure has started to occur yesterday in the scheduled CI test runners, and it's not just a flaky test:
https://github.com/streamlink/streamlink/actions/runs/8608358511/job/23590572703#step:6:289
> ```
> ===============... | The runner was upgraded to CPython 3.11.9 while the py311 Windows runner is still on 3.11.8.
So this must be an issue with 3.11.9.
https://docs.python.org/release/3.11.9/whatsnew/changelog.html#python-3-11-9
> **gh-116764**: Restore support of None and other false values in [urllib.parse](https://docs.python.org/... | 2024-04-09T19:42:52Z | 2024-04-09T19:45:47Z | ["tests/test_api_validate.py::TestTransformSchema::test_failure_signature", "tests/test_api_validate.py::TestGetItemSchema::test_simple[re.Match]", "tests/test_api_validate.py::TestLengthValidator::test_success[args16-abcd]", "tests/test_api_validate.py::TestLengthValidator::test_failure[args3-value3-Length must be <3,... | [] | ["tests/test_api_validate.py::TestParseQsdValidator::test_failure", "tests/test_api_validate.py::TestValidationError::test_truncate"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.4", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5926 | d396db4588a8adf5ef5ca4e1268b23851cc89fdb | diff --git a/src/streamlink/plugins/mangomolo.py b/src/streamlink/plugins/mangomolo.py
index 186732b6c03..4f6e00dbfb7 100644
--- a/src/streamlink/plugins/mangomolo.py
+++ b/src/streamlink/plugins/mangomolo.py
@@ -24,7 +24,7 @@
)
@pluginmatcher(
name="mediagovkw",
- pattern=re.compile(r"https?://media\.gov\.kw... | diff --git a/tests/plugins/test_mangomolo.py b/tests/plugins/test_mangomolo.py
index d80e8f6f2a3..e34244d9e7e 100644
--- a/tests/plugins/test_mangomolo.py
+++ b/tests/plugins/test_mangomolo.py
@@ -15,8 +15,16 @@ class TestPluginCanHandleUrlMangomolo(PluginCanHandleUrl):
"mediagovkw",
"https://... | plugins.mangomolo: error: No plugin can handle URL
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/stream... | Remove the `www.`
https://github.com/streamlink/streamlink/blob/d396db4588a8adf5ef5ca4e1268b23851cc89fdb/src/streamlink/plugins/mangomolo.py#L27
> [cli][debug] Streamlink: 6.7.2
Outdated. The plugin was updated with the missing `Referer` header in #5923, which isn't part of a stable release yet. | 2024-04-06T22:23:27Z | 2024-04-06T22:26:16Z | ["tests/plugins/test_mangomolo.py::TestPluginCanHandleUrlMangomolo::test_url_matches_positive_named[NAME=mediagovkw URL=https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1]", "tests/plugins/test_mangomolo.py::TestPluginCanHandleUrlMangomolo::test_url_matches_positive_named[NAME=mangomoloplayer URL=https://player.mangomolo... | [] | ["tests/plugins/test_mangomolo.py::TestPluginCanHandleUrlMangomolo::test_url_matches_positive_named[NAME=mediagovkw URL=https://www.media.gov.kw/LiveTV.aspx?PanChannel=KTV1]", "tests/plugins/test_mangomolo.py::TestPluginCanHandleUrlMangomolo::test_url_matches_negative[https://example.com/index.html]", "tests/plugins/te... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.4", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5921 | 20247d4ca52099d36b663e6448d17062bcad89a7 | diff --git a/src/streamlink_cli/utils/formatter.py b/src/streamlink_cli/utils/formatter.py
index 4aa3472cd00..e206ac1fc31 100644
--- a/src/streamlink_cli/utils/formatter.py
+++ b/src/streamlink_cli/utils/formatter.py
@@ -2,17 +2,18 @@
from typing import Optional
from streamlink.utils.formatter import Formatter as _... | diff --git a/tests/cli/utils/test_formatter.py b/tests/cli/utils/test_formatter.py
index bd425e55713..089115e2e30 100644
--- a/tests/cli/utils/test_formatter.py
+++ b/tests/cli/utils/test_formatter.py
@@ -1,6 +1,7 @@
from datetime import datetime
from os.path import sep
from pathlib import Path
+from string import a... | File name too long error when using metadata in output filename
### Checklist
- [X] This is a bug report and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.... | The limitation doesn't come from the max path length but from the max file name length of the underlying file system (in addition to the OS's max path length - which should not be of relevance here).
Most file systems restrict their file name length to 255 bytes, so hardcoding this limitation should be good enough:
... | 2024-04-03T21:17:00Z | 2024-04-04T14:25:37Z | [] | [] | ["tests/cli/utils/test_path.py::test_replace_chars_unprintable[10]", "tests/cli/utils/test_path.py::test_truncate_path[text+ext1 - no truncation]", "tests/cli/utils/test_path.py::test_replace_chars_unprintable[17]", "tests/cli/utils/test_path.py::test_replace_chars_unprintable[21]", "tests/cli/utils/test_path.py::test_... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.4", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5910 | 39961a597e6af4d2084903b4420590de588c139f | diff --git a/src/streamlink/plugins/pluto.py b/src/streamlink/plugins/pluto.py
index 2f0feeb1b0b..ab7fb29ca42 100644
--- a/src/streamlink/plugins/pluto.py
+++ b/src/streamlink/plugins/pluto.py
@@ -13,8 +13,9 @@
from urllib.parse import parse_qsl, urljoin
from uuid import uuid4
+from streamlink.exceptions import Plu... | diff --git a/tests/plugins/test_pluto.py b/tests/plugins/test_pluto.py
index ab6305c56e0..f8a340a3ba7 100644
--- a/tests/plugins/test_pluto.py
+++ b/tests/plugins/test_pluto.py
@@ -5,56 +5,28 @@
class TestPluginCanHandleUrlPluto(PluginCanHandleUrl):
__plugin__ = Pluto
- should_match = [
- "http://www.... | plugins.pluto: Ad filtering not properly working for (some) streams
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.c... | This is the entire filtering logic of the Pluto plugin, which, as you can see, is a simple regex for specific HLS segment URLs when are then skipped in Streamlink's output:
https://github.com/streamlink/streamlink/blame/6.5.0/src/streamlink/plugins/pluto.py#L25-L29
If some ad segments don't get filtered out anymore... | 2024-03-29T16:55:43Z | 2024-04-02T13:46:11Z | ["tests/plugins/test_pluto.py::TestPluginCanHandleUrlPluto::test_url_matches_negative[https://pluto.tv/en/on-demand/movies/600545d1813b2d001b686fa9/details]", "tests/plugins/test_pluto.py::TestPluginCanHandleUrlPluto::test_url_matches_negative[https://example.com/]", "tests/plugins/test_pluto.py::TestPluginCanHandleUrl... | [] | ["tests/plugins/test_pluto.py::TestPluginCanHandleUrlPluto::test_all_matchers_match[live]", "tests/plugins/test_pluto.py::TestPluginCanHandleUrlPluto::test_all_matchers_match[movies]", "tests/plugins/test_pluto.py::TestPluginCanHandleUrlPluto::test_all_named_matchers_have_tests[live]", "tests/plugins/test_pluto.py::Tes... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.4", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5908 | 33879e284c7987c81cce11b3ea06fd99533c395d | diff --git a/src/streamlink/plugins/vkplay.py b/src/streamlink/plugins/vkplay.py
index 0d23aba5267..528bfac9c51 100644
--- a/src/streamlink/plugins/vkplay.py
+++ b/src/streamlink/plugins/vkplay.py
@@ -1,6 +1,6 @@
"""
$description Russian live-streaming platform for gaming and esports, owned by VKontakte.
-$url vkplay... | diff --git a/tests/plugins/test_vkplay.py b/tests/plugins/test_vkplay.py
index d995ee8e328..3bb7377d1b1 100644
--- a/tests/plugins/test_vkplay.py
+++ b/tests/plugins/test_vkplay.py
@@ -6,10 +6,12 @@ class TestPluginCanHandleUrlVKplay(PluginCanHandleUrl):
__plugin__ = VKplay
should_match = [
- "https:... | plugins.vkplay: vkplay.live has moved to another domain (live.vkplay.ru)
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github... | 2024-03-28T17:35:10Z | 2024-03-28T17:38:39Z | ["tests/plugins/test_vkplay.py::TestPluginCanHandleUrlVKplay::test_url_matches_negative[https://vkplay.live/app/settings/external-apps]", "tests/plugins/test_vkplay.py::TestPluginCanHandleUrlVKplay::test_url_matches_negative[https://support.vkplay.ru/vkp_live]", "tests/plugins/test_vkplay.py::TestPluginCanHandleUrlVKpl... | [] | ["tests/plugins/test_vkplay.py::TestPluginCanHandleUrlVKplay::test_url_matches_negative[https://example.com/index.html]", "tests/plugins/test_vkplay.py::TestPluginCanHandleUrlVKplay::test_url_matches_positive_unnamed[https://live.vkplay.ru/CHANNEL]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.4", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5890 | 251fe08f8da8214dafdf094afd80c543b8e2e0fe | diff --git a/src/streamlink/plugins/tv3cat.py b/src/streamlink/plugins/tv3cat.py
index d358ed14c38..40f9f115a16 100644
--- a/src/streamlink/plugins/tv3cat.py
+++ b/src/streamlink/plugins/tv3cat.py
@@ -8,49 +8,75 @@
import logging
import re
+from streamlink.exceptions import NoStreamsError, PluginError
from streaml... | diff --git a/tests/plugins/test_tv3cat.py b/tests/plugins/test_tv3cat.py
index cc6d386a4d1..6783d524e95 100644
--- a/tests/plugins/test_tv3cat.py
+++ b/tests/plugins/test_tv3cat.py
@@ -6,8 +6,22 @@ class TestPluginCanHandleUrlTV3Cat(PluginCanHandleUrl):
__plugin__ = TV3Cat
should_match_groups = [
- (... | plugins.tv3cat: URLs changed
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTR... | 2024-03-13T20:03:53Z | 2024-03-15T20:03:46Z | ["tests/plugins/test_tv3cat.py::TestPluginCanHandleUrlTV3Cat::test_class_name", "tests/plugins/test_tv3cat.py::TestPluginCanHandleUrlTV3Cat::test_url_matches_negative[http://example.com/]", "tests/plugins/test_tv3cat.py::TestPluginCanHandleUrlTV3Cat::test_class_setup", "tests/plugins/test_tv3cat.py::TestPluginCanHandle... | [] | ["tests/plugins/test_tv3cat.py::TestPluginCanHandleUrlTV3Cat::test_all_matchers_match[vod]", "tests/plugins/test_tv3cat.py::TestPluginCanHandleUrlTV3Cat::test_all_matchers_match[live]", "tests/plugins/test_tv3cat.py::TestPluginCanHandleUrlTV3Cat::test_all_named_matchers_have_tests[vod]", "tests/plugins/test_tv3cat.py::... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.4", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5881 | 70d5d4a1085412a382efcaabe1cebac7687c5ff4 | diff --git a/src/streamlink/plugins/ustvnow.py b/src/streamlink/plugins/ustvnow.py
index b14e8005f05..0b4ea1848cd 100644
--- a/src/streamlink/plugins/ustvnow.py
+++ b/src/streamlink/plugins/ustvnow.py
@@ -21,7 +21,7 @@
@pluginmatcher(re.compile(
- r"https?://(?:www\.)?ustvnow\.com/live/(?P<scode>\w+)/-(?P<id>\d... | diff --git a/tests/plugins/test_ustvnow.py b/tests/plugins/test_ustvnow.py
index 7a3d8a9875d..626a2dc7fd3 100644
--- a/tests/plugins/test_ustvnow.py
+++ b/tests/plugins/test_ustvnow.py
@@ -6,7 +6,7 @@ class TestPluginCanHandleUrlUSTVNow(PluginCanHandleUrl):
__plugin__ = USTVNow
should_match = [
- "ht... | plugins.ustvnow: pluginmatcher URL update needed
### Checklist
- [X] This is a plugin issue and not a different kind of issue
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#contributing-to-streamlink)
- [X] [I have checked the list of open and recen... | Is this issue being worked on? Its been over half a year.
Yes, I use it exactly with the changes I made and published on GitHub... I can give you the log if you need it.
1 марта 2024, 04:32:14, от "MajinLugia" ***@***.***>:
Is this issue being worked on? Its been over half a year.
—
Reply to this email directly, vie... | 2024-03-08T16:45:00Z | 2024-03-09T12:02:27Z | ["tests/plugins/test_ustvnow.py::TestPluginCanHandleUrlUSTVNow::test_url_matches_negative[https://example.com/index.html]", "tests/plugins/test_ustvnow.py::TestPluginCanHandleUrlUSTVNow::test_class_setup", "tests/plugins/test_ustvnow.py::TestPluginUSTVNow::test_encrypt_data", "tests/plugins/test_ustvnow.py::TestPluginC... | [] | ["tests/plugins/test_ustvnow.py::TestPluginUSTVNow::test_decrypt_data", "tests/plugins/test_ustvnow.py::TestPluginCanHandleUrlUSTVNow::test_url_matches_positive_unnamed[https://www.ustvnow.com/channel/live/cbs]", "tests/plugins/test_ustvnow.py::TestPluginCanHandleUrlUSTVNow::test_all_matchers_match[#0]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.3", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5869 | e077e2fccdb69a3bc8bfe979b320783568f6ffab | diff --git a/src/streamlink/plugins/bloomberg.py b/src/streamlink/plugins/bloomberg.py
index 2beedc66f78..b7aeb6dfea7 100644
--- a/src/streamlink/plugins/bloomberg.py
+++ b/src/streamlink/plugins/bloomberg.py
@@ -16,14 +16,14 @@
log = logging.getLogger(__name__)
-@pluginmatcher(re.compile(r"""
- https?://(?:www... | diff --git a/tests/plugins/test_bloomberg.py b/tests/plugins/test_bloomberg.py
index 5c113ccf078..35f09dbba8a 100644
--- a/tests/plugins/test_bloomberg.py
+++ b/tests/plugins/test_bloomberg.py
@@ -6,11 +6,22 @@ class TestPluginCanHandleUrlBloomberg(PluginCanHandleUrl):
__plugin__ = Bloomberg
should_match_gr... | plugins.bloomberg: error: unmatched '{' in format spec
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/st... | 2024-02-28T03:18:59Z | 2024-02-28T03:24:26Z | ["tests/plugins/test_bloomberg.py::TestPluginCanHandleUrlBloomberg::test_class_name", "tests/plugins/test_bloomberg.py::TestPluginCanHandleUrlBloomberg::test_url_matches_negative[https://example.com/]", "tests/plugins/test_bloomberg.py::TestPluginCanHandleUrlBloomberg::test_url_matches_negative[http://example.com/]", "... | [] | ["tests/plugins/test_bloomberg.py::TestPluginCanHandleUrlBloomberg::test_all_named_matchers_have_tests[vod]", "tests/plugins/test_bloomberg.py::TestPluginCanHandleUrlBloomberg::test_all_named_matchers_have_tests[live]", "tests/plugins/test_bloomberg.py::TestPluginCanHandleUrlBloomberg::test_all_matchers_match[vod]", "t... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.3", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5852 | 57dacf7bc9ee1f5793f8aa3c715220ded19653f6 | diff --git a/src/streamlink/plugins/mangomolo.py b/src/streamlink/plugins/mangomolo.py
new file mode 100644
index 00000000000..f35a13782a1
--- /dev/null
+++ b/src/streamlink/plugins/mangomolo.py
@@ -0,0 +1,52 @@
+"""
+$description OTT video platform owned by Alpha Technology Group
+$url media.gov.kw
+$type live
+"""
+
... | diff --git a/tests/plugins/test_mangomolo.py b/tests/plugins/test_mangomolo.py
new file mode 100644
index 00000000000..d80e8f6f2a3
--- /dev/null
+++ b/tests/plugins/test_mangomolo.py
@@ -0,0 +1,22 @@
+from streamlink.plugins.mangomolo import Mangomolo
+from tests.plugins import PluginCanHandleUrl
+
+
+class TestPluginC... | media.gov.kw / mangomolo.com plugin request
### Checklist
- [X] This is a plugin request and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#contributing-to-... | 2024-02-21T13:16:52Z | 2024-02-25T08:28:42Z | [] | [] | ["tests/plugins/test_mangomolo.py::TestPluginCanHandleUrlMangomolo::test_url_matches_negative[http://example.com/]", "tests/plugins/test_mangomolo.py::TestPluginCanHandleUrlMangomolo::test_url_matches_positive_named[NAME=mediagovkw URL=https://media.gov.kw/LiveTV.aspx?PanChannel=KTV1]", "tests/plugins/test_mangomolo.py... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.3", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5858 | f205f541ed1497a0c83433e0206e6bce10a2530d | diff --git a/src/streamlink/plugins/ltv_lsm_lv.py b/src/streamlink/plugins/ltv_lsm_lv.py
index 0c37e47edad..95f39d9a5f5 100644
--- a/src/streamlink/plugins/ltv_lsm_lv.py
+++ b/src/streamlink/plugins/ltv_lsm_lv.py
@@ -1,73 +1,42 @@
"""
$description Live TV channels from LTV, a Latvian public, state-owned broadcaster.
... | diff --git a/tests/plugins/test_ltv_lsm_lv.py b/tests/plugins/test_ltv_lsm_lv.py
index d8be7d80667..7a228154e66 100644
--- a/tests/plugins/test_ltv_lsm_lv.py
+++ b/tests/plugins/test_ltv_lsm_lv.py
@@ -6,20 +6,15 @@ class TestPluginCanHandleUrlLtvLsmLv(PluginCanHandleUrl):
__plugin__ = LtvLsmLv
should_match ... | plugins.ltv_lsm_lv: No playable streams found on this URL
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streaml... | 2024-02-24T09:53:21Z | 2024-02-24T10:51:00Z | ["tests/plugins/test_ltv_lsm_lv.py::TestPluginCanHandleUrlLtvLsmLv::test_url_matches_negative[https://example.com/]", "tests/plugins/test_ltv_lsm_lv.py::TestPluginCanHandleUrlLtvLsmLv::test_url_matches_negative[http://example.com/]", "tests/plugins/test_ltv_lsm_lv.py::TestPluginCanHandleUrlLtvLsmLv::test_all_matchers_m... | [] | ["tests/plugins/test_ltv_lsm_lv.py::TestPluginCanHandleUrlLtvLsmLv::test_url_matches_positive_unnamed[https://replay.lsm.lv/ru/efir/ltv7/sporta-studija-aizkulises]", "tests/plugins/test_ltv_lsm_lv.py::TestPluginCanHandleUrlLtvLsmLv::test_url_matches_positive_unnamed[https://replay.lsm.lv/lv/tiesraide/ltv7/sporta-studij... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.3", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5848 | 73db061c1df17e9e8fc02cc23a345895e45dfee8 | diff --git a/src/streamlink/plugins/hiplayer.py b/src/streamlink/plugins/hiplayer.py
index e20ed80aada..6aded6177c2 100644
--- a/src/streamlink/plugins/hiplayer.py
+++ b/src/streamlink/plugins/hiplayer.py
@@ -1,7 +1,6 @@
"""
$description United Arab Emirates CDN hosting live content for various websites in The Middle... | diff --git a/tests/plugins/test_hiplayer.py b/tests/plugins/test_hiplayer.py
index 8c58b207c19..08b439b2264 100644
--- a/tests/plugins/test_hiplayer.py
+++ b/tests/plugins/test_hiplayer.py
@@ -7,6 +7,4 @@ class TestPluginCanHandleUrlHiPlayer(PluginCanHandleUrl):
should_match = [
("alwasatly", "https://a... | plugins.hiplayer: new plugin for kuwait tvs changes
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/st... | https://media.gov.kw is now using a different stream host, namely https://mangomolo.com.
This requires a separate plugin implementation and the hiplayer plugin needs to be updated accordingly with a removal of the unsupported matcher. | 2024-02-20T15:03:24Z | 2024-02-20T15:10:01Z | ["tests/plugins/test_hiplayer.py::TestPluginCanHandleUrlHiPlayer::test_url_matches_positive_named[NAME=alwasatly URL=https://alwasat.ly/live]", "tests/plugins/test_hiplayer.py::TestPluginCanHandleUrlHiPlayer::test_class_name", "tests/plugins/test_hiplayer.py::TestPluginCanHandleUrlHiPlayer::test_url_matches_negative[ht... | [] | ["tests/plugins/test_hiplayer.py::TestPluginCanHandleUrlHiPlayer::test_url_matches_negative[https://example.com/index.html]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.2", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5844 | 61cec0e88e1a49ee09c39b78fa0396c1da3239ea | diff --git a/src/streamlink/session/plugins.py b/src/streamlink/session/plugins.py
index 4526081a769..5ef32d6a97d 100644
--- a/src/streamlink/session/plugins.py
+++ b/src/streamlink/session/plugins.py
@@ -179,7 +179,7 @@ def _load_plugins_from_path(self, path: Union[Path, str]) -> Dict[str, Type[Plug
if lo... | diff --git a/tests/session/test_plugins.py b/tests/session/test_plugins.py
index f7d311e9be9..2b86657bec6 100644
--- a/tests/session/test_plugins.py
+++ b/tests/session/test_plugins.py
@@ -131,6 +131,11 @@ def test_load_path_testplugins(self, caplog: pytest.LogCaptureFixture, session:
assert session.plugins["t... | session.plugins: No longer logs when plugin is overridden
### Checklist
- [X] This is a bug report and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#cont... | 2024-02-20T06:53:45Z | 2024-02-20T06:56:45Z | ["tests/session/test_plugins.py::TestMatchURL::test_no_priority", "tests/session/test_plugins.py::test_set_get_del", "tests/session/test_plugins.py::TestMatchURLLoadLazy::test_load", "tests/session/test_plugins.py::TestLoadPluginsData::test_fallback_load_builtin[no-package-record]", "tests/session/test_plugins.py::test... | [] | ["tests/session/test_plugins.py::TestLoad::test_load_path_testplugins_override_matchers", "tests/session/test_plugins.py::TestMatchURLLoadLazy::test_fail_builtin"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.2", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5822 | ebb49d39e0a6c43c8d9f7a059d01b5f2c9f00399 | diff --git a/src/streamlink/session/plugins.py b/src/streamlink/session/plugins.py
index 554627a9eca..7842a17e066 100644
--- a/src/streamlink/session/plugins.py
+++ b/src/streamlink/session/plugins.py
@@ -1,16 +1,28 @@
+import base64
+import hashlib
+import importlib.metadata
+import json
import logging
import pkguti... | diff --git a/tests/cli/test_main.py b/tests/cli/test_main.py
index 11b8c49ae4d..caaa5836eee 100644
--- a/tests/cli/test_main.py
+++ b/tests/cli/test_main.py
@@ -889,7 +889,7 @@ def test_print_help(self, mock_stdout):
@patch("sys.argv", ["streamlink", "--plugins"])
def test_print_plugins(self, mock_stdout):
... | session: don't load all built-in plugins at once
I've talked about the problem of how Streamlink loads its plugins multiple times, eg. [last year in the proposal for the new plugin matchers](https://github.com/streamlink/streamlink/issues/3814#issuecomment-871722799), but I never opened a dedicated thread for this, so ... | Thanks a lot for this proposal. Using streamlink almost exclusively headless from my raspberry based mediaserver, any performance improvement is highly appreciated.
This sounds very effective for core plugins, as build_py will take care of constructing the json, but what will happen with sideloaded plugins? (ie gene... | 2024-02-11T14:15:25Z | 2024-02-14T12:30:16Z | ["tests/cli/test_main.py::TestCLIMainHandleUrl::test_error[side_effect0-No plugin can handle URL: fakeurl]", "tests/cli/test_main.py::TestCLIMainCreateOutput::test_create_output_no_file_output_options", "tests/cli/test_main.py::TestCLIMainLoggingStreams::test_pipe_json", "tests/cli/test_main.py::TestCLIMainLoggingStrea... | [] | ["tests/session/test_session.py::TestResolveURL::test_resolve_url_no_redirect", "tests/session/test_plugins.py::test_set_get_del", "tests/session/test_session.py::TestStreams::test_stream_types", "tests/session/test_session.py::TestStreams::test_stream_sorting_excludes", "tests/session/test_plugins.py::TestMatchURLLoad... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.1", "docutils==0.20.1", "docutils-stubs==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5827 | 6cb3c023ab207d37a72f9a03911b632e8ed3fb3b | diff --git a/src/streamlink/plugins/foxtr.py b/src/streamlink/plugins/foxtr.py
deleted file mode 100644
index 9ebfec62367..00000000000
--- a/src/streamlink/plugins/foxtr.py
+++ /dev/null
@@ -1,27 +0,0 @@
-"""
-$description Turkish live TV channel owned by Fox Network.
-$url fox.com.tr
-$type live
-"""
-
-import re
-
-f... | diff --git a/tests/plugins/test_foxtr.py b/tests/plugins/test_foxtr.py
deleted file mode 100644
index 542c029b20c..00000000000
--- a/tests/plugins/test_foxtr.py
+++ /dev/null
@@ -1,10 +0,0 @@
-from streamlink.plugins.foxtr import FoxTR
-from tests.plugins import PluginCanHandleUrl
-
-
-class TestPluginCanHandleUrlFoxTR... | plugins.foxtr: name changed to nowtvtr
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob... | 2024-02-13T05:17:42Z | 2024-02-13T13:54:17Z | [] | [] | ["tests/test_plugins.py::TestPlugins::test_exports_plugin[plugin29]", "tests/test_plugins.py::TestPlugins::test_constructor[plugin118]", "tests/stream/test_ffmpegmux.py::TestCommand::test_validate_failure", "tests/plugins/test_youtube.py::TestPluginCanHandleUrlYouTube::test_url_matches_groups_named[NAME=shorthand URL=h... | ["tests/test_api_validate.py::TestParseQsdValidator::test_failure - asse..."] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "brotli==1.1.0", "certifi==2024.2.2", "charset-normalizer==3.3.2", "coverage==7.4.1", "docutils==0.20.1", "docutils-stubs==... | null | ["pytest --tb=no -rA -p no:cacheprovider"] | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5792 | 6fe26dac768b64e3e4d33b51410bb12524860dca | diff --git a/src/streamlink/plugins/aloula.py b/src/streamlink/plugins/aloula.py
index 6d550d2f854..2df74d9d6e1 100644
--- a/src/streamlink/plugins/aloula.py
+++ b/src/streamlink/plugins/aloula.py
@@ -19,14 +19,14 @@
log = logging.getLogger(__name__)
-@pluginmatcher(re.compile(r"""
- https?://(?:www\.)?aloula\.... | diff --git a/tests/plugins/test_aloula.py b/tests/plugins/test_aloula.py
index 1e52bbe21bc..1c96988df29 100644
--- a/tests/plugins/test_aloula.py
+++ b/tests/plugins/test_aloula.py
@@ -6,15 +6,10 @@ class TestPluginCanHandleUrlAloula(PluginCanHandleUrl):
__plugin__ = Aloula
should_match_groups = [
- ... | plugins.aloula: 403 Client Error: Forbidden for url
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/strea... | 2024-01-21T14:57:26Z | 2024-01-21T15:01:22Z | ["tests/plugins/test_aloula.py::TestPluginCanHandleUrlAloula::test_url_matches_negative[https://www.aloula.sa/live/]", "tests/plugins/test_aloula.py::TestPluginCanHandleUrlAloula::test_url_matches_negative[https://www.aloula.sa/en/episode/]", "tests/plugins/test_aloula.py::TestPluginCanHandleUrlAloula::test_url_matches... | [] | ["tests/plugins/test_aloula.py::TestPluginCanHandleUrlAloula::test_all_named_matchers_have_tests[vod]", "tests/plugins/test_aloula.py::TestPluginCanHandleUrlAloula::test_all_matchers_match[vod]", "tests/plugins/test_aloula.py::TestPluginCanHandleUrlAloula::test_all_matchers_match[live]", "tests/plugins/test_aloula.py::... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.3", "certifi==2023.11.17", "charset-normalizer==3.3.2", "coverage==7.4.0", "docutils==0.20.1", "docutils-stubs==0.0.22", "freez... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5774 | 89716761adb198a943da521cb7f7ce00c49aec4d | diff --git a/src/streamlink/plugins/artetv.py b/src/streamlink/plugins/artetv.py
index eaff55a873c..55ea7d9c2cc 100644
--- a/src/streamlink/plugins/artetv.py
+++ b/src/streamlink/plugins/artetv.py
@@ -2,6 +2,7 @@
$description European public service channel promoting culture, including magazine shows, concerts and doc... | diff --git a/tests/plugins/test_artetv.py b/tests/plugins/test_artetv.py
index 62f244c3cf6..40492bb8b9c 100644
--- a/tests/plugins/test_artetv.py
+++ b/tests/plugins/test_artetv.py
@@ -5,30 +5,51 @@
class TestPluginCanHandleUrlArteTV(PluginCanHandleUrl):
__plugin__ = ArteTV
- should_match = [
- # new ... | plugins.artetv: error: Unable to validate response text: ValidationError(dict):
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](http... | 2024-01-14T19:47:24Z | 2024-01-14T20:32:31Z | ["tests/plugins/test_artetv.py::TestPluginCanHandleUrlArteTV::test_class_name", "tests/plugins/test_artetv.py::TestPluginCanHandleUrlArteTV::test_url_matches_negative[http://example.com/]", "tests/plugins/test_artetv.py::TestPluginCanHandleUrlArteTV::test_url_matches_negative[https://www.arte.tv/en/videos/RC-014457/the... | [] | ["tests/plugins/test_artetv.py::TestPluginCanHandleUrlArteTV::test_all_matchers_match[live]", "tests/plugins/test_artetv.py::TestPluginCanHandleUrlArteTV::test_all_named_matchers_have_tests[live]", "tests/plugins/test_artetv.py::TestPluginCanHandleUrlArteTV::test_all_named_matchers_have_tests[vod]", "tests/plugins/test... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.16", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.2", "certifi==2023.11.17", "charset-normalizer==3.3.2", "coverage==7.4.0", "docutils==0.20.1", "docutils-stubs==0.0.22", "freez... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5762 | 27087e0b6d61de4507328e2d29a1801dfb67fa78 | diff --git a/src/streamlink/plugins/vidio.py b/src/streamlink/plugins/vidio.py
index 50b05a46466..11b8ced64a5 100644
--- a/src/streamlink/plugins/vidio.py
+++ b/src/streamlink/plugins/vidio.py
@@ -6,6 +6,7 @@
import logging
import re
from urllib.parse import urlsplit, urlunsplit
+from uuid import uuid4
from strea... | diff --git a/tests/plugins/test_vidio.py b/tests/plugins/test_vidio.py
index 970dd45594b..4fdf269ce45 100644
--- a/tests/plugins/test_vidio.py
+++ b/tests/plugins/test_vidio.py
@@ -12,6 +12,5 @@ class TestPluginCanHandleUrlVidio(PluginCanHandleUrl):
]
should_not_match = [
- "http://www.vidio.com",
- ... | plugins.vidio: 403 Client Error on stream token acquirement
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamli... | 2024-01-08T03:55:07Z | 2024-01-08T03:58:11Z | ["tests/plugins/test_vidio.py::TestPluginCanHandleUrlVidio::test_url_matches_negative[http://example.com/]", "tests/plugins/test_vidio.py::TestPluginCanHandleUrlVidio::test_class_setup", "tests/plugins/test_vidio.py::TestPluginCanHandleUrlVidio::test_url_matches_negative[https://example.com/]", "tests/plugins/test_vidi... | [] | ["tests/plugins/test_vidio.py::TestPluginCanHandleUrlVidio::test_url_matches_negative[https://www.vidio.com/]", "tests/plugins/test_vidio.py::TestPluginCanHandleUrlVidio::test_url_matches_negative[https://example.com/index.html]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.15", "async-generator==1.10", "attrs==23.2.0", "babel==2.14.0", "beautifulsoup4==4.12.2", "certifi==2023.11.17", "charset-normalizer==3.3.2", "coverage==7.4.0", "docutils==0.20.1", "docutils-stubs==0.0.22", "freez... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5725 | bebc2ae181ebccaf6a1b569570bb625383a1e8e2 | diff --git a/src/streamlink/plugins/gulli.py b/src/streamlink/plugins/gulli.py
index e3be0c26f5f..ebd92adbdb0 100644
--- a/src/streamlink/plugins/gulli.py
+++ b/src/streamlink/plugins/gulli.py
@@ -11,79 +11,37 @@
from streamlink.plugin import Plugin, pluginmatcher
from streamlink.plugin.api import validate
from stre... | diff --git a/tests/plugins/test_gulli.py b/tests/plugins/test_gulli.py
index dd9187cd290..5188e5f8ebf 100644
--- a/tests/plugins/test_gulli.py
+++ b/tests/plugins/test_gulli.py
@@ -6,10 +6,22 @@ class TestPluginCanHandleUrlGulli(PluginCanHandleUrl):
__plugin__ = Gulli
should_match = [
- "http://repla... | plugins.gulli: No playable streams found on this URL: https://replay.gulli.fr/Direct
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines]... | 2023-12-15T15:33:06Z | 2023-12-15T16:36:08Z | ["tests/plugins/test_gulli.py::TestPluginCanHandleUrlGulli::test_url_matches_negative[http://example.com/]", "tests/plugins/test_gulli.py::TestPluginCanHandleUrlGulli::test_url_matches_negative[https://example.com/]", "tests/plugins/test_gulli.py::TestPluginCanHandleUrlGulli::test_url_matches_negative[http://replay.gul... | [] | ["tests/plugins/test_gulli.py::TestPluginCanHandleUrlGulli::test_all_matchers_match[vod]", "tests/plugins/test_gulli.py::TestPluginCanHandleUrlGulli::test_all_named_matchers_have_tests[live]", "tests/plugins/test_gulli.py::TestPluginCanHandleUrlGulli::test_all_matchers_match[live]", "tests/plugins/test_gulli.py::TestPl... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.13", "async-generator==1.10", "attrs==23.1.0", "babel==2.14.0", "beautifulsoup4==4.12.2", "certifi==2023.11.17", "charset-normalizer==3.3.2", "coverage==7.3.3", "docutils==0.20.1", "docutils-stubs==0.0.22", "freez... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5708 | e58fe2433c9ac6bff8f7ba0d2f8add2cc242e108 | diff --git a/src/streamlink/plugins/twitch.py b/src/streamlink/plugins/twitch.py
index 3fd35c8c4a8..132c803ec3e 100644
--- a/src/streamlink/plugins/twitch.py
+++ b/src/streamlink/plugins/twitch.py
@@ -487,26 +487,6 @@ def clips(self, clipname):
),
))
- def stream_metadata(self, channel):
- ... | diff --git a/tests/plugins/test_twitch.py b/tests/plugins/test_twitch.py
index 58801420765..8ea89a49d9e 100644
--- a/tests/plugins/test_twitch.py
+++ b/tests/plugins/test_twitch.py
@@ -396,53 +396,6 @@ def test_hls_low_latency_no_ads_reload_time(self):
assert self.thread.reader.worker.playlist_reload_time == p... | plugins.twitch: Returns "Channel is offline" for short period after a stream has started
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines... | This is because their GQL API has a slight delay, same issue with the stream metadata retrieval when polling the stream previously using `--retry-streams` (#4411 and all the linked duplicate threads).
How would you suggest fixing this otherwise? The reason why the API gets checked for the live status now is that jus... | 2023-12-05T23:31:56Z | 2023-12-06T00:00:00Z | ["tests/plugins/test_twitch.py::TestTwitchHLSStream::test_hls_low_latency_no_prefetch", "tests/plugins/test_twitch.py::TestPluginCanHandleUrlTwitch::test_url_matches_groups_unnamed[URL=https://www.twitch.tv/weplaydota/clip/FurryIntelligentDonutAMPEnergyCherry-akPRxv7Y3w58WmFq GROUPS={'subdomain': 'www', 'channel': 'wep... | [] | ["tests/plugins/test_twitch.py::TestTwitchHLSMultivariantResponse::test_multivariant_response[non-json error response]", "tests/plugins/test_twitch.py::TestTwitchMetadata::test_metadata_clip_no_data[False-https://clips.twitch.tv/foo]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.13", "async-generator==1.10", "attrs==23.1.0", "babel==2.13.1", "beautifulsoup4==4.12.2", "certifi==2023.11.17", "charset-normalizer==3.3.2", "coverage==7.3.2", "docutils==0.20.1", "docutils-stubs==0.0.22", "freez... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5704 | 2d751a530b34dc1c4b8710acb76f614fe2145a08 | diff --git a/src/streamlink/plugins/twitch.py b/src/streamlink/plugins/twitch.py
index 9063d6f62ef..3fd35c8c4a8 100644
--- a/src/streamlink/plugins/twitch.py
+++ b/src/streamlink/plugins/twitch.py
@@ -495,8 +495,16 @@ def stream_metadata(self, channel):
)
return self.call(query, schema=validate.Sche... | diff --git a/tests/plugins/test_twitch.py b/tests/plugins/test_twitch.py
index e150277ce06..58801420765 100644
--- a/tests/plugins/test_twitch.py
+++ b/tests/plugins/test_twitch.py
@@ -396,6 +396,53 @@ def test_hls_low_latency_no_ads_reload_time(self):
assert self.thread.reader.worker.playlist_reload_time == p... | plugins.twitch: returns streams while channel is offline
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/... | `--retry-streams` has nothing to do with any implementation of Streamlink's plugins. It's a feature of `streamlink_cli` which keeps fetching streams from the resolved plugin until ones were found.
As you can see in your debug log output, the plugin has successfully returned a list of streams:
> [cli][info] Availabl... | 2023-12-05T08:43:43Z | 2023-12-05T13:12:09Z | ["tests/plugins/test_twitch.py::TestTwitchHLSStream::test_hls_low_latency_no_prefetch", "tests/plugins/test_twitch.py::TestPluginCanHandleUrlTwitch::test_url_matches_groups_unnamed[URL=https://www.twitch.tv/weplaydota/clip/FurryIntelligentDonutAMPEnergyCherry-akPRxv7Y3w58WmFq GROUPS={'subdomain': 'www', 'channel': 'wep... | [] | ["tests/plugins/test_twitch.py::TestTwitchIsLive::test_is_live[is-live]", "tests/plugins/test_twitch.py::TestTwitchIsLive::test_is_live[no-user]", "tests/plugins/test_twitch.py::TestTwitchIsLive::test_is_live[no-stream]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.13", "async-generator==1.10", "attrs==23.1.0", "babel==2.13.1", "beautifulsoup4==4.12.2", "certifi==2023.11.17", "charset-normalizer==3.3.2", "coverage==7.3.2", "docutils==0.20.1", "docutils-stubs==0.0.22", "freez... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5654 | 003debed0ccb062f8de215b85886634283eac04e | diff --git a/src/streamlink/stream/dash/manifest.py b/src/streamlink/stream/dash/manifest.py
index e93fd63f187..a39ead39c76 100644
--- a/src/streamlink/stream/dash/manifest.py
+++ b/src/streamlink/stream/dash/manifest.py
@@ -632,7 +632,10 @@ def segments(self, timestamp: Optional[datetime] = None, **kwargs) -> Iterator... | diff --git a/tests/resources/dash/test_dynamic_segment_list_p1.mpd b/tests/resources/dash/test_dynamic_segment_list_p1.mpd
new file mode 100644
index 00000000000..beb7bb32fa2
--- /dev/null
+++ b/tests/resources/dash/test_dynamic_segment_list_p1.mpd
@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MPD
+ xmlns... | stream.dash: support for dynamic manifests with SegmentLists
### Checklist
- [X] This is a bug report and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#cont... | The full manifest can be found here: https://pastebin.com/mCHDZNUB
Streamlink currently doesn't support dynamic DASH manifests with `SegmentList`s.
The yielded segment list doesn't keep track of the last segment position, so after a manifest reload, it starts from anew.
This is also the reason why it starts from the ... | 2023-11-07T16:38:57Z | 2023-11-08T23:24:01Z | ["tests/stream/test_ffmpegmux.py::TestCommand::test_validate_failure", "tests/test_plugins.py::TestPlugins::test_matchers[showroom]", "tests/plugins/test_youtube.py::TestPluginCanHandleUrlYouTube::test_url_matches_groups_named[NAME=shorthand URL=https://youtu.be/aqz-KE-bpKQ GROUPS={'video_id': 'aqz-KE-bpKQ'}]", "tests/... | [] | ["tests/stream/dash/test_manifest.py::TestMPDParser::test_dynamic_segment_list_continued"] | ["tests/test_api_validate.py::TestParseQsdValidator::test_failure - asse..."] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.13", "async-generator==1.10", "attrs==23.1.0", "babel==2.13.1", "beautifulsoup4==4.12.2", "certifi==2023.7.22", "charset-normalizer==3.3.2", "coverage==7.3.2", "docutils==0.20.1", "docutils-stubs==0.0.22", "freeze... | null | ["pytest --tb=no -rA -p no:cacheprovider"] | null | null | swa-bench:sw.eval |
streamlink/streamlink | streamlink__streamlink-5645 | fd83550d5e4c55b84a2e96de70d0ea54f46eee10 | diff --git a/src/streamlink/plugins/tvp.py b/src/streamlink/plugins/tvp.py
index ba886a14304..980b2f1804a 100644
--- a/src/streamlink/plugins/tvp.py
+++ b/src/streamlink/plugins/tvp.py
@@ -1,7 +1,9 @@
"""
$description Live TV channels and VODs from TVP, a Polish public, state-owned broadcaster.
+$url stream.tvp.pl
+$... | diff --git a/tests/plugins/test_tvp.py b/tests/plugins/test_tvp.py
index d656cc95219..faec6e95098 100644
--- a/tests/plugins/test_tvp.py
+++ b/tests/plugins/test_tvp.py
@@ -7,31 +7,30 @@ class TestPluginCanHandleUrlTVP(PluginCanHandleUrl):
should_match_groups = [
# live
- ("https://stream.tvp.pl"... | plugins.tvp: No playable streams found on www.tvp.info
### Checklist
- [X] This is a [plugin issue](https://streamlink.github.io/plugins.html) and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/st... | 2023-10-31T17:42:38Z | 2023-10-31T17:54:25Z | ["tests/plugins/test_tvp.py::TestPluginCanHandleUrlTVP::test_url_matches_negative[https://example.com/]", "tests/plugins/test_tvp.py::TestPluginCanHandleUrlTVP::test_url_matches_positive_named[NAME=tvp_info URL=https://www.tvp.info/72577058/28092023-0823]", "tests/plugins/test_tvp.py::TestPluginCanHandleUrlTVP::test_ur... | [] | ["tests/plugins/test_tvp.py::TestPluginCanHandleUrlTVP::test_all_matchers_match[default]", "tests/plugins/test_tvp.py::TestPluginCanHandleUrlTVP::test_all_named_matchers_have_tests[default]", "tests/plugins/test_tvp.py::TestPluginCanHandleUrlTVP::test_all_matchers_match[vod]", "tests/plugins/test_tvp.py::TestPluginCanH... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.13", "async-generator==1.10", "attrs==23.1.0", "babel==2.13.1", "beautifulsoup4==4.12.2", "certifi==2023.7.22", "charset-normalizer==3.3.1", "coverage==7.3.2", "docutils==0.20.1", "docutils-stubs==0.0.22", "freeze... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
streamlink/streamlink | streamlink__streamlink-5619 | 25af0f3b35a68ec81b22beacbd12bdfb7e3ed242 | diff --git a/src/streamlink/stream/hls/m3u8.py b/src/streamlink/stream/hls/m3u8.py
index 86aa36ce80b..4542a0bd3df 100644
--- a/src/streamlink/stream/hls/m3u8.py
+++ b/src/streamlink/stream/hls/m3u8.py
@@ -156,8 +156,11 @@ def __init__(self, base_uri: Optional[str] = None):
def create_stream_info(cls, streaminf: Ma... | diff --git a/tests/resources/hls/test_multivariant_bandwidth.m3u8 b/tests/resources/hls/test_multivariant_bandwidth.m3u8
new file mode 100644
index 00000000000..3da715f4864
--- /dev/null
+++ b/tests/resources/hls/test_multivariant_bandwidth.m3u8
@@ -0,0 +1,19 @@
+#EXTM3U
+#EXT-X-MEDIA:TYPE=VIDEO,GROUP-ID="chunked",NAME... | stream.hls: BANDWIDTH=0 raises ValueError: math domain error
### Checklist
- [X] This is a bug report and not [a different kind of issue](https://github.com/streamlink/streamlink/issues/new/choose)
- [X] [I have read the contribution guidelines](https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#cont... | 2023-10-16T14:34:31Z | 2023-10-16T14:44:22Z | ["tests/stream/test_ffmpegmux.py::TestCommand::test_validate_failure", "tests/test_plugins.py::TestPlugins::test_matchers[showroom]", "tests/plugins/test_youtube.py::TestPluginCanHandleUrlYouTube::test_url_matches_groups_named[NAME=shorthand URL=https://youtu.be/aqz-KE-bpKQ GROUPS={'video_id': 'aqz-KE-bpKQ'}]", "tests/... | [] | ["tests/stream/hls/test_m3u8.py::TestHLSPlaylist::test_parse_bandwidth"] | ["tests/test_api_validate.py::TestParseQsdValidator::test_failure - asse..."] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["alabaster==0.7.13", "async-generator==1.10", "attrs==23.1.0", "babel==2.13.0", "beautifulsoup4==4.12.2", "certifi==2023.7.22", "charset-normalizer==3.3.0", "coverage==7.3.2", "docutils==0.20.1", "docutils-stubs==0.0.22", "freeze... | null | ["pytest --tb=no -rA -p no:cacheprovider"] | null | null | swa-bench:sw.eval | |
arrow-py/arrow | arrow-py__arrow-1079 | a2ebb7e20b4897ee7b7bf4676a5ac3e6c0f27f47 | diff --git a/arrow/constants.py b/arrow/constants.py
index d26bc0d8..1189d07c 100644
--- a/arrow/constants.py
+++ b/arrow/constants.py
@@ -110,6 +110,10 @@
"da-dk",
"ml",
"hi",
+ "cs",
+ "cs-cz",
+ "sk",
+ "sk-sk",
"fa",
"fa-ir",
"mr",
diff --git a/arrow/locales.py b/arrow/loca... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index a2f08813..60f3a64b 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -2410,6 +2410,10 @@ def locale_list_no_weeks() -> List[str]:
"da-dk",
"ml",
"hi",
+ "cs",
+ "cs-cz",
+ "sk",
+ "sk-sk",
... | Czech/Slovak Locales Humanize Error When Zero Delta
<!--
Thanks for taking the time to submit this bug report.
Please provide us with a detailed description of the bug and a bit of information about your system.
-->
## Issue Description
The Czech and Slovak locales fail when using Humanize on a delta of zero... | 2021-12-26T07:32:00Z | 2021-12-27T21:07:58Z | ["tests/test_formatter.py::TestFormatterBuiltinFormats::test_atom", "tests/test_parser.py::TestDateTimeParserParse::test_parse_tz_name_zzz[America/Boa_Vista]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Halifax]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone... | [] | ["tests/test_arrow.py::TestArrowDehumanize::test_czech_slovak", "tests/test_arrow.py::TestArrowDehumanize::test_mixed_granularity", "tests/test_arrow.py::TestArrowDehumanize::test_gt_than_10_years", "tests/test_arrow.py::TestArrowDehumanize::test_hours", "tests/test_arrow.py::TestArrowDehumanize::test_weeks", "tests/te... | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits"] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39,310}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy-3.7: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n 3.10: py310\n\n[testenv]\ndeps = -rrequirements-d... | tox -- | null | null | null | swa-bench:sw.eval | |
arrow-py/arrow | arrow-py__arrow-1077 | be57df5a7474dda3f6c16176ad181fa176039f2c | diff --git a/arrow/arrow.py b/arrow/arrow.py
index fef66c10..d7504456 100644
--- a/arrow/arrow.py
+++ b/arrow/arrow.py
@@ -1384,7 +1384,7 @@ def dehumanize(self, input_string: str, locale: str = "en_us") -> "Arrow":
search_string = search_string.format(r"\d+")
# Create search pattern... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index 7cb3b510..a2f08813 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -2373,7 +2373,20 @@ def locale_list_no_weeks() -> List[str]:
"zh-hk",
"nl",
"nl-nl",
+ "be",
+ "be-by",
+ "pl",
+ "pl-pl",
... | Humanize Format Relative Error For Multiple Granularities
<!--
Thanks for taking the time to submit this bug report.
Please provide us with a detailed description of the bug and a bit of information about your system.
-->
## Issue Description
<!--
Replace this comment block with a description of the bug.
... | 2021-12-18T06:36:05Z | 2021-12-18T19:18:51Z | ["tests/test_formatter.py::TestFormatterBuiltinFormats::test_atom", "tests/test_parser.py::TestDateTimeParserParse::test_parse_tz_name_zzz[America/Boa_Vista]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Halifax]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone... | [] | ["tests/test_arrow.py::TestArrowDehumanize::test_mixed_granularity", "tests/test_arrow.py::TestArrowDehumanize::test_gt_than_10_years", "tests/test_arrow.py::TestArrowDehumanize::test_hours", "tests/test_arrow.py::TestArrowDehumanize::test_weeks", "tests/test_arrow.py::TestArrowDehumanize::test_slavic_locales", "tests/... | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits"] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39,310}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy-3.7: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n 3.10: py310\n\n[testenv]\ndeps = -rrequirements-d... | tox -- | null | null | null | swa-bench:sw.eval | |
arrow-py/arrow | arrow-py__arrow-1016 | f7a3aa3225eb646fec9156e8e39dc33750f2a227 | diff --git a/arrow/arrow.py b/arrow/arrow.py
index d6ed7a88..fef66c10 100644
--- a/arrow/arrow.py
+++ b/arrow/arrow.py
@@ -1263,6 +1263,13 @@ def humanize(
return locale.describe(granularity, delta, only_distance=only_distance)
else:
+
+ if not granularity:
+ ... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index 589f9114..4c9ca110 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -2286,6 +2286,13 @@ def test_untranslated_granularity(self, mocker):
with pytest.raises(ValueError):
arw.humanize(later, granularity="week")
+ def test... | Empty List of Granularities For Humanize Doesn't Raise Value Error
<!--
Thanks for taking the time to submit this bug report.
Please provide us with a detailed description of the bug and a bit of information about your system.
-->
## Issue Description
<!--
Replace this comment block with a description of th... | @anishnya yes, I'm able to reproduce. raises IndexError | 2021-08-07T20:55:52Z | 2021-10-24T21:56:07Z | ["tests/test_formatter.py::TestFormatterBuiltinFormats::test_atom", "tests/test_parser.py::TestDateTimeParserParse::test_parse_tz_name_zzz[America/Boa_Vista]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Halifax]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone... | [] | ["tests/test_arrow.py::TestArrowHumanize::test_empty_granularity_list"] | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits"] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39,310}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy-3.7: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n 3.10: py310\n\n[testenv]\ndeps = -rrequirements-d... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-1035 | 80e5947de29b49c52c84c7bce9dedbf5532606fa | diff --git a/arrow/factory.py b/arrow/factory.py
index 5787dcf0..aad4af8b 100644
--- a/arrow/factory.py
+++ b/arrow/factory.py
@@ -9,6 +9,7 @@
import calendar
from datetime import date, datetime
from datetime import tzinfo as dt_tzinfo
+from decimal import Decimal
from time import struct_time
from typing import An... | diff --git a/tests/test_factory.py b/tests/test_factory.py
index 4bb81e87..53bba20d 100644
--- a/tests/test_factory.py
+++ b/tests/test_factory.py
@@ -1,5 +1,6 @@
import time
from datetime import date, datetime
+from decimal import Decimal
import pytest
from dateutil import tz
@@ -263,6 +264,13 @@ def test_one_ar... | Arrow 1.1.1 doesn't support get from decimal, but 0.15.2 support
<!--
Thanks for taking the time to submit this bug report.
Please provide us with a detailed description of the bug and a bit of information about your system.
-->
## Issue Description
Arrow 1.1.1 doesn't support get from decimal, but 0.15.2 su... | @mousehappy Thanks for reporting this in!
I can replicate, 0.16.0 and above fail on parsing a decimal. | 2021-09-05T04:38:39Z | 2021-09-05T05:21:37Z | ["tests/test_formatter.py::TestFormatterBuiltinFormats::test_atom", "tests/test_parser.py::TestDateTimeParserParse::test_parse_tz_name_zzz[America/Boa_Vista]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Halifax]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone... | [] | ["tests/test_factory.py::TestGet::test_one_arg_decimal"] | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits", "(known issu...) [ 9%]"] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39,310}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy-3.7: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n 3.10: py310\n\n[testenv]\ndeps = -rrequirements-d... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-986 | f1df58b321c43bc0caf6c1a669b3f814f9159bbc | diff --git a/arrow/locales.py b/arrow/locales.py
index d445f2e2..7ad396e8 100644
--- a/arrow/locales.py
+++ b/arrow/locales.py
@@ -147,7 +147,7 @@ def describe(
:param only_distance: return only distance eg: "11 seconds" without "in" or "ago" keywords
"""
- humanized = self._format_timeframe(... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index 2dab6ba3..ba251270 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -2266,6 +2266,25 @@ def test_untranslated_granularity(self, mocker):
with pytest.raises(ValueError):
arw.humanize(later, granularity="week")
+ # Bulgar... | Floats in humanize output for languages overriding _format_timeframe
<!--
Thanks for taking the time to submit this bug report.
Please provide us with a detailed description of the
bug and a bit of information about your system.
-->
## Issue Description
Doing humanize on languages that override _format_time... | I would be interested in fixing this issue. Is this still open or has someone else decided to fix it?
Hmm, I must've not pushed my fixes. I have two fixes, one of which breaks some tests due to ints vs floats.
Will push soon.
I can give this a try as well! | 2021-06-06T01:55:05Z | 2021-06-24T03:36:50Z | ["tests/test_formatter.py::TestFormatterBuiltinFormats::test_atom", "tests/test_parser.py::TestDateTimeParserParse::test_parse_tz_name_zzz[America/Boa_Vista]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Halifax]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone... | [] | ["tests/test_arrow.py::TestArrowHumanize::test_no_floats", "tests/test_arrow.py::TestArrowHumanize::test_no_floats_multi_gran"] | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits", "(known issu...) [ 9%]"] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39,310}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy-3.7: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n 3.10: py310\n\n[testenv]\ndeps = -rrequirements-d... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-968 | fe1aaaee3e14ccb256dd2aa74e07c84226cd4b05 | diff --git a/arrow/factory.py b/arrow/factory.py
index 27dea5c5..5787dcf0 100644
--- a/arrow/factory.py
+++ b/arrow/factory.py
@@ -205,14 +205,14 @@ def get(self, *args: Any, **kwargs: Any) -> Arrow:
if len(kwargs) == 1 and tz is None:
arg_count = 3
- # () -> now, @ utc.
+ # () -> ... | diff --git a/tests/test_factory.py b/tests/test_factory.py
index 5e0020d6..4bb81e87 100644
--- a/tests/test_factory.py
+++ b/tests/test_factory.py
@@ -4,6 +4,7 @@
import pytest
from dateutil import tz
+from arrow import Arrow
from arrow.parser import ParserError
from .utils import assert_datetime_equality
@@ -1... | arrow.get(datetime.now()).humanize() == "6 hours ago"
# Issue Description
It looks like `arrow` is doing something weird timezone information when operating `datetime` objects, including `datetime` objects returned by e.g. `dateparser.parse('now')`.
What is the appropriate incantation to get `arrow` and `datetime... | Hey @zachriggle there definitely looks to be some weirdness going on with the tzinfo setting here. I will investigate this further.
Two other points, Arrow objects are never naive, they default to UTC if no tzinfo is provided. Also `arrow.get(dateparser.parse('now'))` is not officially supported but will probably wo... | 2021-04-29T15:56:55Z | 2021-05-03T02:47:57Z | ["tests/test_formatter.py::TestFormatterBuiltinFormats::test_atom", "tests/test_parser.py::TestDateTimeParserParse::test_parse_tz_name_zzz[America/Boa_Vista]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Halifax]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone... | [] | ["tests/test_factory.py::TestGet::test_one_arg_arrow_tzinfo_kwarg", "tests/test_factory.py::TestGet::test_one_arg_date_tzinfo_kwarg", "tests/test_factory.py::TestGet::test_one_arg_iso_calendar_tzinfo_kwarg", "tests/test_factory.py::TestGet::test_one_arg_datetime_tzinfo_kwarg"] | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits", "tests/test_factory.py::TestGet::test_one_arg_dateparser_datetime - reg..."] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy3: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n\n[testenv]\ndeps = -rrequirements.txt\nallowlist_externals ... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-868 | fe9602e2171d49d0d95d775e71f9735c3aaf92e4 | diff --git a/arrow/arrow.py b/arrow/arrow.py
index 4fe954178..f3706b5b2 100644
--- a/arrow/arrow.py
+++ b/arrow/arrow.py
@@ -72,7 +72,7 @@ class Arrow(object):
_SECS_PER_DAY = float(60 * 60 * 24)
_SECS_PER_WEEK = float(60 * 60 * 24 * 7)
_SECS_PER_MONTH = float(60 * 60 * 24 * 30.5)
- _SECS_PER_YEAR = f... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index b0bd20a5e..872edc017 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -1772,11 +1772,12 @@ def test_multiple_granularity(self):
)
== "37 months and 4 weeks"
)
+ # this will change when leap years are impl... | humanize() rounding problem
<!--
Thanks for taking the time to submit this bug report.
Please provide us with a detailed description of the
bug and a bit of information about your system.
-->
## Issue Description
Not sure if this is wanted or a bug. `humanize()` returns "a week ago" for deltas < 7 days.
For ... | It seems that the `humanize` function was originally designed with impreciseness in mind to give ballpark estimates for humanized date/time formats. That said, I think it would be nice to add an `exact` or `precise` keyword argument to allow users to choose which type of functionality they want, and we can adjust the b... | 2020-10-15T19:27:08Z | 2020-11-08T21:38:24Z | ["tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Cancun]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[Indian/Cocos]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[Australia/Queensland]", "tests/test_parser.py::TestDateTi... | ["tests/test_arrow.py::TestArrowHumanize::test_months", "tests/test_arrow.py::TestArrowHumanize::test_months - AssertionError: ..."] | ["tests/test_arrow.py::TestArrowHumanizeTestsWithLocale::test_years", "tests/test_arrow.py::TestArrowHumanize::test_multiple_granularity", "tests/test_arrow.py::TestArrowHumanize::test_years"] | ["tests/test_arrow.py::TestArrowHumanize::test_month known issue with humanize month limits", "tests/test_factory.py::TestGet::test_one_arg_dateparser_datetime - reg..."] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy3: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n\n[testenv]\ndeps = -rrequirements.txt\nallowlist_externals ... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-845 | 80aa80c0ebbffa17bf07ff668a1512653367ae92 | diff --git a/arrow/arrow.py b/arrow/arrow.py
index 8c442c9cb..79b64a459 100644
--- a/arrow/arrow.py
+++ b/arrow/arrow.py
@@ -381,7 +381,7 @@ def range(cls, frame, start, end=None, tz=None, limit=None):
yield current
values = [getattr(current, f) for f in cls._ATTRS]
- current = cl... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index 3268a9ade..6fda5caf3 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -7,6 +7,7 @@
import time
from datetime import date, datetime, timedelta
+import dateutil
import pytest
import pytz
import simplejson as json
@@ -310,6 +311,14 @@ def tes... | Wrong result when a shift involves a DST change.
In paris in 2013, we changed to DST in 2013-03-31 (at 2 AM it was 3 AM), from UTC+1 to UTC+2 (DST)
Here's an example of the issue I have with arrow :
``` python
>>> import arrow, datetime
>>> just_before = arrow.get(datetime.datetime(2013, 03, 31, 1, 50, 45), "Europe... | Interesting. Conversions / shifting around DST are tricky and early on there were a number of problems with this. Will check it out.
The really annoying part is that around DST, when you shift by 1h from 1.30AM, the time difference should be 60 minutes (what you asked for) and the "visual difference" should be 2 hou... | 2020-08-28T15:14:54Z | 2020-09-16T17:10:33Z | ["tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Cancun]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[Indian/Cocos]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[Australia/Queensland]", "tests/test_parser.py::TestDateTi... | [] | ["tests/test_arrow.py::TestArrowShift::test_shift_positive_imaginary", "tests/test_arrow.py::TestArrowRange::test_imaginary", "tests/test_arrow.py::TestArrowAttribute::test_getattr_imaginary", "tests/test_arrow.py::TestArrowShift::test_shift_kiritimati", "tests/test_arrow.py::TestArrowShift::test_shift_negative_imagina... | ["tests/test_util.py::TestUtil::test_iso_gregorian", "tests/test_factory.py::TestGet::test_one_arg_dateparser_datetime - reg..."] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy3: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n\n[testenv]\ndeps = -rrequirements.txt\nallowlist_externals ... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-802 | 90b33b06fc1ff8ad65d824dcaf0183863c8decf7 | diff --git a/arrow/arrow.py b/arrow/arrow.py
index fbf38e11a..2fa030f1a 100644
--- a/arrow/arrow.py
+++ b/arrow/arrow.py
@@ -41,8 +41,9 @@ class Arrow(object):
:param hour: (optional) the hour. Defaults to 0.
:param minute: (optional) the minute, Defaults to 0.
:param second: (optional) the second, Defau... | diff --git a/tests/test_arrow.py b/tests/test_arrow.py
index e08e8fc4a..a740e71fd 100644
--- a/tests/test_arrow.py
+++ b/tests/test_arrow.py
@@ -72,6 +72,17 @@ def test_init_pytz_timezone(self):
assert result._datetime == self.expected
assert_datetime_equality(result._datetime, self.expected, 1)
+ ... | Issue with DST transition
```
>>> t = arrow.get("2019-10-27T02:21:01+03:00")
>>> t
<Arrow [2019-10-27T02:21:01+03:00]>
>>> t.to("Israel")
<Arrow [2019-10-27T01:21:01+03:00]>
```
Note the same tz offset but different hours
Same bug, another appearence:
```
>>> ut = 1572132061
>>> ut == arrow.get(ut).to("I... | What version of python are you on @liosha?
I've checked with Python 2.7.12 and 2.7.16 (Ubuntu)
Hmmm that's interesting, I tested your example on python 3.7.4 and there's no error there that I can see. Could you test on 3.6+ as well?
I think the DST problems with arrow are slowly being fixed with the introduction of ... | 2020-06-08T21:34:45Z | 2020-08-21T20:54:26Z | ["tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[America/Cancun]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[Australia/Queensland]", "tests/test_formatter.py::TestFormatterFormatToken::test_timezone_formatter[Indian/Cocos]", "tests/test_parser.py::TestDateTi... | [] | ["tests/test_arrow.py::TestArrowAttribute::test_getattr_fold", "tests/test_arrow.py::TestArrowConversion::test_to_israel_same_offset", "tests/test_arrow.py::TestArrowConversion::test_chicago_fall", "tests/test_arrow.py::TestArrowConversion::test_to_pacific_then_utc", "tests/test_arrow.py::TestArrowReplace::test_replace... | ["tests/test_util.py::TestUtil::test_iso_gregorian", "tests/test_factory.py::TestGet::test_one_arg_dateparser_datetime - reg..."] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nminversion = 3.18.0\nenvlist = py{py3,36,37,38,39}\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy3: pypy3\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n\n[testenv]\ndeps = -rrequirements.txt\nallowlist_externals ... | tox -- | null | null | null | swa-bench:sw.eval |
arrow-py/arrow | arrow-py__arrow-804 | 0a37fa5643ed2a0fe7714854fc3d91644fc8fb4e | diff --git a/arrow/locales.py b/arrow/locales.py
index 783e64202..b453f82ce 100644
--- a/arrow/locales.py
+++ b/arrow/locales.py
@@ -1061,20 +1061,34 @@ class KoreanLocale(Locale):
timeframes = {
"now": "지금",
- "second": "두 번째",
- "seconds": "{0}몇 초",
+ "second": "1초",
+ "sec... | diff --git a/tests/test_locales.py b/tests/test_locales.py
index 13949ba93..189fa6af3 100644
--- a/tests/test_locales.py
+++ b/tests/test_locales.py
@@ -1108,3 +1108,79 @@ def test_format_relative_past(self):
def test_format_relative_future(self):
result = self.locale._format_relative("saa moja", "hour", ... | Added space to parser
## Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all *appropriate* boxes:
<!-- Check boxes by placing an x in the brackets: [x] -->
- [x] 🧪 Added **tests** for changed code.
- [x] 🛠️ All tests **pass** when run lo... | 2020-06-09T08:41:33Z | 2020-06-16T19:36:10Z | ["tests/test_formatter.py::TestDateTimeFormatterFormatToken::test_timezone_formatter[Europe/Andorra]", "tests/test_formatter.py::TestDateTimeFormatterFormatToken::test_timezone_formatter[Mexico/General]", "tests/test_parser.py::TestDateTimeParserISO::test_YYYY_MM_DDTHH_mm_ss_S", "tests/test_parser.py::TestDateTimeParse... | [] | ["tests/test_locales.py::TestKoreanLocale::test_format_timeframe", "tests/test_locales.py::TestKoreanLocale::test_ordinal_number", "tests/test_locales.py::TestKoreanLocale::test_format_relative"] | ["tests/test_util.py::TestUtil::test_iso_gregorian", "tests/test_factory.py::TestGet::test_one_arg_dateparser_datetime - reg..."] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist = py{py3,27,35,36,37,38,39},lint,docs\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy3: pypy3\n 2.7: py27\n 3.5: py35\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n\n# Configure testing environments\... | tox -- | null | null | null | swa-bench:sw.eval | |
arrow-py/arrow | arrow-py__arrow-792 | 3f9837ea3caa91994b24a50a55d71b49859dbd96 | diff --git a/arrow/locales.py b/arrow/locales.py
index 76544196d..ccbca8b38 100644
--- a/arrow/locales.py
+++ b/arrow/locales.py
@@ -478,8 +478,8 @@ def _ordinal_number(self, n):
return "{}º".format(n)
-class FrenchLocale(Locale):
- names = ["fr", "fr_fr"]
+class FrenchBaseLocale(Locale):
+
past = ... | diff --git a/tests/test_locales.py b/tests/test_locales.py
index 96f34edc7..73d77c5b8 100644
--- a/tests/test_locales.py
+++ b/tests/test_locales.py
@@ -205,6 +205,15 @@ def test_ordinal_number(self):
assert self.locale.ordinal_number(1) == "1er"
assert self.locale.ordinal_number(2) == "2e"
+ def... | fr_CA locale support?
I'd like to request support for Canadian French as a locale option.
If it's similar enough, perhaps we could just add `'fr_ca'` to the existing French locale? If there are differences, maybe we could follow the model of the German language mixin?
Are there any French Canadians who could offe... | hey @bjmc, what are the differences between the languages `french` and `canadian french`? could you specify those so someone could potentially work on it?
Thanks @ramonsaraiva unfortunately, if I knew the differences, I could probably make the changes myself.
I'm hoping some French speakers might be able to chime in... | 2020-05-15T11:08:09Z | 2020-05-15T21:14:53Z | ["tests/test_formatter.py::TestDateTimeFormatterFormatToken::test_timezone_formatter[Europe/Andorra]", "tests/test_formatter.py::TestDateTimeFormatterFormatToken::test_timezone_formatter[Mexico/General]", "tests/test_parser.py::TestDateTimeParserISO::test_YYYY_MM_DDTHH_mm_ss_S", "tests/test_parser.py::TestDateTimeParse... | ["tests/test_util.py::TestUtil::test_iso_gregorian"] | ["tests/test_locales.py::TestFrenchCanadianLocale::test_month_abbreviation"] | ["tests/test_factory.py::TestGet::test_one_arg_dateparser_datetime - reg..."] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist = py{py3,27,35,36,37,38,39},lint,docs\nskip_missing_interpreters = true\n\n[gh-actions]\npython =\n pypy3: pypy3\n 2.7: py27\n 3.5: py35\n 3.6: py36\n 3.7: py37\n 3.8: py38\n 3.9: py39\n\n# Configure testing environments\... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-858 | 180ecc781d893414e9853bf0e33abeb42ba169ef | diff --git a/CHANGES.rst b/CHANGES.rst
index b05d6e03a..5f12719bc 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -16,6 +16,14 @@ Unreleased
can validate multiple valued fields like :class:`~fields.SelectMultipleField`
:pr:`538` :pr:`807`
+- Breaking change: The key for form errors moved from :data:`None` to
+ e... | diff --git a/tests/test_form.py b/tests/test_form.py
index e02e3e626..d64cc2182 100644
--- a/tests/test_form.py
+++ b/tests/test_form.py
@@ -204,7 +204,7 @@ def validate(self):
f = F(a=0, b=1)
assert not f.validate()
assert ["a + b should be even"] == f.form_errors
- assert ["a + b should be even"] ==... | Form field errors not JSON serializable with default Flask JSONProvider
The decision in 3.0 to use None as a dictionary key for holding form level errors #595 has the unfortunate side-effect of not allowing the JSON serializer to sort keys - which is the default set up by Flask.
One gets the error: `TypeError: '<' n... | I don't mind just changing it to `""` or `"__form__"` in a feature release.
Thanks - a comment in #595 suggests '__all__' - same as django - I don't really care - though using anything that could be confused as core python I think would just cause confusion (also - it isn't all errors!). '__form__' seems pretty safe.... | 2024-10-11T14:37:41Z | 2024-10-11T15:29:52Z | ["tests/test_form.py::test_baseform_data_proxy", "tests/test_form.py::test_form_meta_class_meta_reassign", "tests/test_form.py::test_validate", "tests/test_form.py::test_baseform_prefixes", "tests/test_form.py::test_validate_with_extra", "tests/test_form.py::test_baseform_formdata_wrapper_error", "tests/test_form.py::t... | [] | ["tests/test_form.py::test_meta_missing_diamond", "tests/test_form.py::test_form_level_errors"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-765 | 9f9146c8ee2cb2b2e7b3d9bc09ac7e433fd55bb0 | diff --git a/CHANGES.rst b/CHANGES.rst
index 9f2cd01b9..6ff516885 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -16,6 +16,8 @@ Unreleased
- Added shorter format to :class:`~fields.DateTimeLocalField`
defaults :pr:`761`
- Stop support for python 3.7 :pr:`794`
+- Added shorter format to :class:`~fields.WeekF... | diff --git a/tests/fields/test_week.py b/tests/fields/test_week.py
new file mode 100644
index 000000000..527263b90
--- /dev/null
+++ b/tests/fields/test_week.py
@@ -0,0 +1,36 @@
+from datetime import date
+
+from tests.common import DummyPostData
+
+from wtforms.fields import WeekField
+from wtforms.form import Form
+
... | Support fields for week, month and color
Please, support fields for week, month and color. See the example at https://getbootstrap.com/docs/5.1/content/reboot/?optionsRadios=option1#forms
<p>
<label for="week">Example week</label>
<input type="week" id="week">
</p>
<p>... | Hi. Thank you for your contribution. The `MonthField` already exists, even if it was not documented, though it is fixed now.
For the record:
- [The MDN page on week input](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/week)
- [The MDN page on color input](https://developer.mozilla.org/en-US/docs/... | 2023-01-13T15:25:55Z | 2023-07-28T19:13:23Z | [] | [] | ["tests/fields/test_week.py::test_invalid_data", "tests/fields/test_week.py::test_basic"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-694 | 433726339475dddb341cceb234c9b6bf185baefd | diff --git a/CHANGES.rst b/CHANGES.rst
index 6723a9a2e..79ce1bbe6 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -14,6 +14,7 @@ Unreleased
- Support for optgroups in :class:`~fields.SelectField` and
:class:`~fields.SelectMultipleField`. :issue:`656` :pr:`667`
- Minor documentation fix. :issue:`701`
+- Custo... | diff --git a/tests/fields/test_list.py b/tests/fields/test_list.py
index 4df373ea1..d04a5d87c 100644
--- a/tests/fields/test_list.py
+++ b/tests/fields/test_list.py
@@ -103,6 +103,68 @@ class Outside(Form):
assert o.subforms[0].foo.data == "default"
+def test_custom_separator():
+ F = make_form(a=FieldList(... | Changing FormField seperator parameter to non-default breaks iteration over enclosing FieldList
I have a use case for generating a FieldList of a variable number of simple forms each enclosed in a FormField. I have attempted setting the separator parameter of the FormField. Changing FormField separator parameter to non... | I could reproduce the bug:
Snippet working with hyphens:
```python
>>> import wtforms
...
... class DummyPostData(dict):
... def getlist(self, key):
... v = self[key]
... if not isinstance(v, (list, tuple)):
... v = [v]
... return v
...
... class InnerFor... | 2021-05-31T15:40:34Z | 2021-09-09T16:55:40Z | ["tests/fields/test_list.py::test_no_filters", "tests/fields/test_list.py::test_min_max_entries", "tests/fields/test_list.py::test_enclosed_subform", "tests/fields/test_list.py::test_enclosed_subform_custom_name", "tests/fields/test_list.py::test_form", "tests/fields/test_list.py::test_process_prefilled", "tests/fields... | [] | ["tests/fields/test_list.py::test_enclosed_subform_list_separator", "tests/fields/test_list.py::test_errors", "tests/fields/test_list.py::test_custom_separator", "tests/fields/test_list.py::test_enclosed_subform_uniform_separators", "tests/fields/test_list.py::test_enclosed_subform_mixed_separators"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-688 | 32c75649f5d06802c3b4a0a7cbe8c3b43e07b171 | diff --git a/CHANGES.rst b/CHANGES.rst
index 8bb26bc95..c8469910e 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,8 @@ Unreleased
- :meth:`~fields.FormField.populate_obj` always calls :func:`setattr`
:pr:`675`
- WTForms has a new logo. :issue:`569` :pr:`689`
+- Fixed :class:`~fields.RadioField` `rend... | diff --git a/tests/fields/test_radio.py b/tests/fields/test_radio.py
index 863b9330d..e8179721d 100644
--- a/tests/fields/test_radio.py
+++ b/tests/fields/test_radio.py
@@ -102,3 +102,19 @@ def test_required_validator():
form = F(DummyPostData(b=1))
assert form.validate() is False
assert form.c.errors ==... | Field render kwargs are not populated to the inputs of RadioField
In most cases you can control HTML attributes of the rendered fields via keyword arguments to the form field's `__call__` method. This doesn't work right for `RadioField` (or probably anything that uses `FieldList`, where the keyword arguments are consum... | 2021-04-27T21:00:16Z | 2021-05-19T18:28:22Z | ["tests/fields/test_select.py::test_required_validator", "tests/fields/test_selectmultiple.py::test_requried_flag", "tests/fields/test_selectmultiple.py::test_with_data", "tests/fields/test_select.py::test_validate_choices_when_empty", "tests/fields/test_select.py::test_dont_validate_choices", "tests/fields/test_select... | [] | ["tests/fields/test_selectmultiple.py::test_render_kw_preserved", "tests/fields/test_radio.py::test_render_kw_preserved"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval | |
pallets-eco/wtforms | pallets-eco__wtforms-615 | 9cc7c7f4d32c8e69c67460e8b8b2aa5ed411da2e | diff --git a/src/wtforms/fields/core.py b/src/wtforms/fields/core.py
index 331e5d62f..032654546 100644
--- a/src/wtforms/fields/core.py
+++ b/src/wtforms/fields/core.py
@@ -500,7 +500,11 @@ def iter_choices(self):
def __iter__(self):
opts = dict(
- widget=self.option_widget, name=self.name, _... | diff --git a/tests/fields/test_radio.py b/tests/fields/test_radio.py
index 523a71b75..863b9330d 100644
--- a/tests/fields/test_radio.py
+++ b/tests/fields/test_radio.py
@@ -1,3 +1,6 @@
+from tests.common import DummyPostData
+
+from wtforms import validators
from wtforms.fields import RadioField
from wtforms.form imp... | DataRequired and InputRequired do not add required attribute to RadioField objects
When adding a `DataRequired` or `InputRequired` validator to a `RadioField`, the `required` attribute of the `input` tag.
Here's the function I wrote that reveals the problem:
```python
@bp.route('/<string:slug>/survey', met... | I am seeing the same issue.
```python
from wtforms import Form, StringField, RadioField
from wtforms.validators import InputRequired
COLORS = [
('blue', 'Blue'),
('red', 'Red')
]
class MyForm(Form):
name = StringField('name', validators=[InputRequired()])
color = RadioField('color', choi... | 2020-06-01T15:25:35Z | 2021-04-27T20:27:03Z | ["tests/fields/test_select.py::test_required_validator", "tests/fields/test_selectmultiple.py::test_requried_flag", "tests/fields/test_selectmultiple.py::test_with_data", "tests/fields/test_select.py::test_validate_choices_when_empty", "tests/fields/test_select.py::test_dont_validate_choices", "tests/fields/test_select... | [] | ["tests/fields/test_selectmultiple.py::test_required_validator", "tests/fields/test_radio.py::test_required_flag"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-661 | e3e0162d9cc96f608e086bff32f1300ec4a634f5 | diff --git a/CHANGES.rst b/CHANGES.rst
index 929e0310e..0e0ba945a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -41,6 +41,8 @@ Unreleased
- Error messages standardization. :issue:`613` :pr:`620` :pr:`626` :pr:`627`
- :class:`~wtforms.fields.core.SelectMultipleField` `validate_choice`
bugfix. :issue:`606` :pr... | diff --git a/tests/fields/test_selectmultiple.py b/tests/fields/test_selectmultiple.py
index 4fc585653..1d9009b91 100644
--- a/tests/fields/test_selectmultiple.py
+++ b/tests/fields/test_selectmultiple.py
@@ -69,14 +69,15 @@ def choices():
def test_choice_shortcut():
- F = make_form(a=SelectMultipleField(choice... | SelectMultipleField pre_validate expects a tuple list even though a normal list is a valid argument
Due to the patch provided in #605 `SelectMultipleField.pre_validate()` behaves unexpectedly, the method wasn't updated to support a value only list as `choices`.
`pre_validate` expects `choices` to be a list of `(val... | Could reproduce with:
```python
>>> import wtforms
>>> class F(wtforms.Form):
... foo = wtforms.SelectMultipleField(choices=["foo", "bar"])
>>> F(foo=["foo"]).validate()
False
``` | 2020-10-05T13:10:20Z | 2020-10-06T12:19:26Z | ["tests/fields/test_selectmultiple.py::test_with_data", "tests/fields/test_selectmultiple.py::test_coerce_fail", "tests/fields/test_selectmultiple.py::test_validate_choices_when_empty", "tests/fields/test_selectmultiple.py::test_validate_choices_when_none", "tests/fields/test_selectmultiple.py::test_callable_choices", ... | [] | ["tests/fields/test_selectmultiple.py::test_choice_shortcut", "tests/fields/test_selectmultiple.py::test_dont_validate_choices"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-620 | b9e15239eb61a6984c4d00baf720595943c8d76c | diff --git a/src/wtforms/csrf/core.py b/src/wtforms/csrf/core.py
index c0d3c54c5..5172c77d1 100644
--- a/src/wtforms/csrf/core.py
+++ b/src/wtforms/csrf/core.py
@@ -93,4 +93,4 @@ def validate_csrf_token(self, form, field):
:param field: The CSRF token field.
"""
if field.current_token != fiel... | diff --git a/tests/test_csrf.py b/tests/test_csrf.py
index 7852cd70c..8435354ed 100644
--- a/tests/test_csrf.py
+++ b/tests/test_csrf.py
@@ -140,7 +140,7 @@ def test_detailed_expected_values(self):
with TimePin.pin_time(dt(8, 43)):
form = self._test_phase2(self.Pinned, session, token, False)
... | The format of the error messages are not unified (ending period)
In general, some error messages end with a period:
```mo
#: src/wtforms/validators.py:269 src/wtforms/validators.py:294
msgid "This field is required."
msgstr ""
#: src/wtforms/validators.py:327
msgid "Invalid input."
msgstr ""
#: src/wtform... | Thank you for your reporting.
I suppose it would make sense to have periods everywhere. Your PR is welcome! | 2020-06-15T10:31:44Z | 2020-06-15T13:30:34Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_csrf.py::TestSessionCSRF::test_with_time_limit", "tests/test_fields.py::TestSelectField::test_defaults", "tests/test_fields.py::TestLabel::test_auto_label", "tests/test_fields.py::TestField::test_chec... | [] | ["tests/test_fields.py::TestSelectField::test_validate_choices_when_empty", "tests/test_locale_babel.py::TestLocaleDecimal::test_parsing", "tests/test_fields.py::TestMonthField::test_failure", "tests/test_locale_babel.py::TestLocaleDecimal::test_formatting", "tests/test_fields.py::TestDateTimeField::test_basic", "tests... | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-614 | 848d28d67e45cda7a06c4c8ed2768e6a8cb1c016 | diff --git a/CHANGES.rst b/CHANGES.rst
index 50f43a2af..a199f46ee 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -34,7 +34,7 @@ Unreleased
- Render attribute names like ``for_`` and ``class_`` are normalized
consistently so later values override those specified earlier.
:issue:`449`, :pr:`596`
-
+- Flags ... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index f36ce71ed..0986534be 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -119,7 +119,7 @@ class TestFlags:
def test_existing_values(self, flags):
assert flags.required is True
assert "required" in flags
- assert fla... | Use HTML 5 widgets
The HTML 5 widgets are kept in their own section and not used by default, but this distinction doesn't make sense today. "HTML 5" is just "HTML" now. No supported browser doesn't understand those input types, and ones that aren't supported fall back to text anyway.
I already sort of started this b... | 2020-05-31T15:27:12Z | 2020-06-14T22:11:53Z | [] | [] | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_validators.py::test_valid_url_notld_passes[http://foobar:1234/path?query=param&foo=faa]", "tests/test_validators.py::test_bad_url_raises[http://127.0.0/asdf]", "tests/test_validators.py::test_length_m... | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval | |
pallets-eco/wtforms | pallets-eco__wtforms-467 | 848d28d67e45cda7a06c4c8ed2768e6a8cb1c016 | diff --git a/CHANGES.rst b/CHANGES.rst
index 50f43a2af..59f029f5e 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -34,6 +34,7 @@ Unreleased
- Render attribute names like ``for_`` and ``class_`` are normalized
consistently so later values override those specified earlier.
:issue:`449`, :pr:`596`
+- Flags ca... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index f36ce71ed..0986534be 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -119,7 +119,7 @@ class TestFlags:
def test_existing_values(self, flags):
assert flags.required is True
assert "required" in flags
- assert fla... | Allow non-boolean field flags
I want to support more HTML validation attributes, but currently the flags only set their value to `True`. For things like `maxlength`, we need to set the actual value.
My idea is to allow `field_flags` to be a function which returns a dict, deprecating and eventually removing the old t... | This sounds great! A lot of the HTML5 standards can help reduce the minutiae of server side validations.
Any progress on this? Would you accept a pull request?
I'd be happy to review a pull request. Just take that as a given for any open issue that is not under discussion and doesn't have a PR already, no need to ask... | 2019-02-12T00:10:08Z | 2020-06-14T22:08:24Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_validators.py::test_valid_url_notld_passes[http://foobar:1234/path?query=param&foo=faa]", "tests/test_validators.py::test_bad_url_raises[http://127.0.0/asdf]", "tests/test_validators.py::test_length_m... | [] | ["tests/test_validators.py::test_raise_exceptions[ValueError]", "tests/test_fields.py::TestFieldValidatorsTest::test_min_max", "tests/test_fields.py::TestFieldValidatorsTest::test_minlength_maxlength", "tests/test_fields.py::TestFlags::test_existing_values", "tests/test_validators.py::test_input_required", "tests/test_... | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-596 | 3149b38621abaed3f5ded86cb7e7194d043b7329 | diff --git a/CHANGES.rst b/CHANGES.rst
index a33ed92b9..50f43a2af 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -31,6 +31,9 @@ Unreleased
*extra_filters* parameter. :issue:`128` :pr:`592`
- Fields can be passed the ``name`` argument to use a HTML name
different than their Python name. :issue:`205`, :pr:`60... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index a82a3f9b7..f36ce71ed 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -266,6 +266,42 @@ def test_render_kw(self):
'type="text" value="hello">'
)
+ def test_render_special(self):
+ class F(Form):
+ ... | html_params and class and class_
Hello,
I have a form created with model_form of flask_mongoengine.wtf
```python
field_args = {
'bio': {'render_kw':{'class_':"summernote"}},
}
exclude = ['created_at','created_by']
form = model_form(Author,exclude=exclude,field_args=field_args)
```
I... | For flexibility, we'd have to allow names further down the line override the value, rather than combining, so that you can replace values rather than just append.
I could reproduce with:
```python
>>> import wtforms
>>> class F(wtforms.Form):
... foo = wtforms.StringField(render_kw={'class_':'summernote'})... | 2020-04-25T16:23:46Z | 2020-05-31T06:50:56Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_fields.py::TestSelectField::test_validate_choices_when_empty", "tests/test_fields.py::TestSelectField::test_defaults", "tests/test_fields.py::TestLabel::test_auto_label", "tests/test_fields.py::TestFi... | [] | ["tests/test_widgets.py::TestHTMLParams::test_basic", "tests/test_fields.py::TestField::test_render_special", "tests/test_widgets.py::TestHTML5::test_range"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-601 | 730afca617c1808a03009eb4d65fd3497fb4a5ca | diff --git a/CHANGES.rst b/CHANGES.rst
index 5a16f312c..a33ed92b9 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -29,6 +29,8 @@ Unreleased
- Implemented :class:`~wtforms.fields.core.MonthField`. :pr:`530` :pr:`593`
- Filters can be inline. :meth:`form.BaseForm.process` takes a
*extra_filters* parameter. :issu... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index c101be3e0..a82a3f9b7 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -52,8 +52,8 @@ def __init__(self, *args, **kw):
self.__dict__.update(*args, **kw)
-def make_form(_name="F", **fields):
- return type(str(_name), (Form,), fi... | Override field's name attribute?
I need compatibility with some existing HTML that uses dashes in the `name` attribute, but I have yet to find a way to override it with wtforms. [The documentation for `wtforms.fields.core.Field`](https://wtforms.readthedocs.org/en/latest/fields.html?highlight=selectmultiplefield#wtform... | I noticed this is mentioned in #154:
> De-couple attribute names from field names
> Allow users to have fields with names containing "special" characters while still allowing the field to >function, just like SQLAlchemy with attribute vs column names.
> Default case (when attribute name unspecified) is still using att... | 2020-04-30T10:52:04Z | 2020-05-31T06:40:37Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_fields.py::TestSelectField::test_validate_choices_when_empty", "tests/test_fields.py::TestSelectField::test_defaults", "tests/test_fields.py::TestLabel::test_auto_label", "tests/test_fields.py::TestFi... | [] | ["tests/test_locale_babel.py::TestLocaleDecimal::test_parsing", "tests/test_fields.py::TestFieldList::test_enclosed_subform_custom_name", "tests/test_fields.py::TestField::test_meta_attribute", "tests/test_locale_babel.py::TestLocaleDecimal::test_typeerror", "tests/test_fields.py::TestFieldList::test_no_filters", "test... | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-592 | ad3280eeadfbe8dd16c099db312d8ebba4dae376 | diff --git a/CHANGES.rst b/CHANGES.rst
index 4c28ec36b..5a16f312c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -27,6 +27,8 @@ Unreleased
:issue:`603` :pr:`605`
- Forms can have form-level errors. :issue:`55` :pr:`595`
- Implemented :class:`~wtforms.fields.core.MonthField`. :pr:`530` :pr:`593`
+- Filters c... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index c78ed47ee..c101be3e0 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -171,6 +171,38 @@ def test_failure(self):
assert len(form.b.process_errors) == 1
assert not form.validate()
+ def test_extra(self):
+ class F(... | A different approach for `filters`
Hi, first of all, thanks for the useful library.
I want to perform some _cleaning_ in some fields, for example, remove several `\n` in a row or strip some whitespaces. The _cleanest_ way I found so far was to use `filters` in the field definition. This is not bad, but for instance,... | 2020-04-24T10:03:39Z | 2020-05-28T20:50:23Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_fields.py::TestSelectField::test_validate_choices_when_empty", "tests/test_fields.py::TestSelectField::test_defaults", "tests/test_fields.py::TestLabel::test_auto_label", "tests/test_fields.py::TestFi... | [] | ["tests/test_fields.py::TestFilters::test_inline", "tests/test_fields.py::TestFilters::test_extra", "tests/test_webob.py::test_filled"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval | |
pallets-eco/wtforms | pallets-eco__wtforms-595 | 8fee573db08e1db57c4fdafdc94544679fec481b | diff --git a/CHANGES.rst b/CHANGES.rst
index ad5b983b3..5a4f49890 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -25,6 +25,7 @@ Unreleased
:pr:`608`
- Choices shortcut for :class:`~fields.core.SelectMultipleField`.
:issue:`603` :pr:`605`
+- Forms can have form-level errors. :issue:`55` :pr:`595`
Vers... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index 15fb5e11c..cde794501 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -1154,7 +1154,7 @@ def _build_value(self, key, form_input, expected_html, data=unset_value):
data = form_input
if expected_html.startswith("type="):
... | [feature request/question] Form wise errors
On form validation I want to raise errors such as: "at least a field must be filled" which do not belong to one field, but to the form as a whole.
Would it be possible to raise have them on the form? (I'm currently using a hidden field and validating these kind of errors on ... | Well, you could overwrite the form validate method to achieve this behavior but (not so classy), I also would like this feature. Something like django non_field_errors. +1
Is any work being done for this? A perfect use-case for this is in a login-form where you want to tell the user that the combination of the usernam... | 2020-04-24T16:56:19Z | 2020-05-28T16:38:30Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_form.py::TestForm::test_validate_with_extra", "tests/test_fields.py::TestSelectField::test_validate_choices_when_empty", "tests/test_fields.py::TestSelectField::test_defaults", "tests/test_fields.py::... | [] | ["tests/test_form.py::TestMeta::test_missing_diamond", "tests/test_form.py::TestForm::test_form_level_errors"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
pallets-eco/wtforms | pallets-eco__wtforms-605 | d395e3803982cec4a525d55e476c653189290009 | diff --git a/CHANGES.rst b/CHANGES.rst
index a7ecb683c..ad5b983b3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -23,6 +23,8 @@ Unreleased
- :class:`~fields.SelectField`, :class:`~fields.SelectMultipleField` and
:class:`~fields.RadioField` *choices* parameter can be a callable.
:pr:`608`
+- Choices shortc... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index 965b951fd..15fb5e11c 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -486,6 +486,19 @@ def choices():
'<option selected value="bar">bar</option>',
]
+ def test_choice_shortcut(self):
+ F = make_form(
+ ... | Shortcut for SelectMultipleField choices
#526 brought a shortcut for `SelectField` choices, but this does not work with `SelectMultipleField`.
```python
>>> import wtforms
>>> class F(wtforms.Form):
... single = wtforms.SelectField(choices=["foo", "bar", "baz"])
... multiple = wtforms.SelectMultipleField... | 2020-05-16T22:45:41Z | 2020-05-28T16:35:38Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_fields.py::TestSelectField::test_validate_choices_when_empty", "tests/test_fields.py::TestSelectField::test_defaults", "tests/test_fields.py::TestLabel::test_auto_label", "tests/test_fields.py::TestFi... | [] | ["tests/test_fields.py::TestSelectMultipleField::test_choice_shortcut", "tests/test_fields.py::TestHTML5Fields::test_simple", "tests/test_fields.py::TestSelectMultipleField::test_empty_choice[None]"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval | |
pallets-eco/wtforms | pallets-eco__wtforms-551 | 129040ab4d5af83a05ddc7b63f854d48be3d55aa | diff --git a/CHANGES.rst b/CHANGES.rst
index 3ee928e15..5c16afbcd 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -69,6 +69,9 @@ Unreleased
- form.errors is not cached and will update if an error is appended to a field after access. (:pr:`568`)
- :class:`~wtforms.validators.NumberRange` correctly handle *not a num... | diff --git a/tests/test_fields.py b/tests/test_fields.py
index 153202639..c415f3a3b 100644
--- a/tests/test_fields.py
+++ b/tests/test_fields.py
@@ -293,9 +293,9 @@ def pre_validate(self, form):
def post_validate(self, form, stopped):
if self.data == "p":
- raise ValueError("Post")
+ ... | Validators do not raise IndexError when it catches a ValueError
Hi. When a validator accidentally raises a ZeroDivisionError, the is correctly raised, but when a validator accidentally raises a ValueError, an IndexError is raised instead. This makes the debugging a bit more difficult.
Here is a script to reproduce t... | 2020-04-17T17:48:31Z | 2020-04-21T14:19:10Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_validators.py::test_valid_url_notld_passes[http://foobar:1234/path?query=param&foo=faa]", "tests/test_validators.py::test_bad_url_raises[http://127.0.0/asdf]", "tests/test_validators.py::test_length_m... | [] | ["tests/test_validators.py::test_raise_exceptions[ValueError]", "tests/test_validators.py::test_raise_exceptions[ZeroDivisionError]"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval | |
pallets-eco/wtforms | pallets-eco__wtforms-573 | c834aa3a8ace6c06e5c092d7b4a36eca045d846d | diff --git a/docs/crash_course.rst b/docs/crash_course.rst
index cbb617ac5..d2ceb1751 100644
--- a/docs/crash_course.rst
+++ b/docs/crash_course.rst
@@ -151,7 +151,7 @@ console::
...
>>> form = UsernameForm()
>>> form['username']
- <wtforms.fields.StringField object at 0x827eccc>
+ <wtforms.fields.... | diff --git a/docs/conftest.py b/docs/conftest.py
new file mode 100644
index 000000000..b68870f17
--- /dev/null
+++ b/docs/conftest.py
@@ -0,0 +1,7 @@
+import pytest
+import wtforms
+
+
+@pytest.fixture(autouse=True)
+def add_doctest_namespace(doctest_namespace):
+ doctest_namespace["wtforms"] = wtforms
| Field rendering error in the documentation
In the [rendering fields](https://wtforms.readthedocs.io/en/stable/crash_course.html#rendering-fields) paragraph in the crash course, there is this piece of code:
```python
>>> from wtforms import Form, StringField
>>> class SimpleForm(Form):
... content = StringField(... | 2020-04-20T08:30:51Z | 2020-04-20T15:28:36Z | ["tests/test_fields.py::TestHiddenField::test", "tests/test_fields.py::TestLabel::test_escaped_label_text", "tests/test_csrf.py::TestSessionCSRF::test_with_time_limit", "tests/test_validators.py::test_valid_url_notld_passes[http://foobar:1234/path?query=param&foo=faa]", "tests/test_validators.py::test_bad_url_raises[ht... | [] | ["docs/crash_course.rst::crash_course.rst", "docs/fields.rst::fields.rst"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | null | ["tox"] | null | null | swa-bench:sw.eval | |
pallets-eco/wtforms | pallets-eco__wtforms-548 | caeb39aad8dec6ffe4d6f1dc7aa5134c56aed175 | diff --git a/CHANGES.rst b/CHANGES.rst
index a8f47a41f..3ee928e15 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -67,6 +67,8 @@ Unreleased
- :class:`~validators.URL` validator now allows query parameters in the URL. (:pr:`523`, :pr:`524`).
- Updated French and Japanese translations. (:pr:`514`, :pr:`506`)
- f... | diff --git a/tests/test_validators.py b/tests/test_validators.py
index e223c8d7a..a54a0c1ed 100644
--- a/tests/test_validators.py
+++ b/tests/test_validators.py
@@ -1,4 +1,5 @@
# -*- coding: utf-8 -*-
+import decimal
import pytest
import re
@@ -589,6 +590,14 @@ def test_number_range_raises(min_v, max_v, test_v, du... | validators.NumberRange doesn't handle NaN
Validating a `DecimalField` with a `NumberRange` validator throws a `decimal.InvalidOperation` exception when the value of the field is NaN. I would expect validation to fail instead
```
File "/usr/local/lib/python3.6/dist-packages/wtforms/form.py", line 310, in validate
r... | I could reproduce this with both `master` and `2.2-maintenance`.
```python
>>> import wtforms
>>> from tests.common import DummyPostData
>>> class F(wtforms.Form):
... a = wtforms.DecimalField(validators=[wtforms.validators.NumberRange(min=0, max=1)])
>>> F(DummyPostData({"a": "NaN"})).validate()
Tracebac... | 2020-04-17T13:25:53Z | 2020-04-20T15:11:59Z | ["tests/test_validators.py::test_anyof_passes[b-test_list0]", "tests/test_validators.py::test_valid_url_passes[http://192.168.0.1/foobar]", "tests/test_validators.py::test_valid_url_notld_passes[http://foobar:1234/path?query=param&foo=faa]", "tests/test_validators.py::test_bad_url_raises[http://127.0.0/asdf]", "tests/t... | [] | ["tests/test_validators.py::test_number_range_nan[nan]", "tests/test_validators.py::test_regexp_message", "tests/test_validators.py::test_number_range_nan[nan1]"] | [] | {"install": [], "pre_install": ["tee tox.ini <<EOF_1234810234\n[tox]\nenvlist =\n # style\n py{313,312,311,310,39,py3}\n # docs\nskip_missing_interpreters = true\n\n[testenv]\ndeps =\n pytest\n babel\n email_validator\ncommands =\n pytest --color=no -rA -p no:cacheprovider --tb=no --basetemp={envtm... | tox -- | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-16415 | a474e3d67c1a0acfc4f8fa7db2f71de4bd089466 | diff --git a/conan/cli/command.py b/conan/cli/command.py
index 7a074dc7cef..b2b50f1c7ab 100644
--- a/conan/cli/command.py
+++ b/conan/cli/command.py
@@ -98,6 +98,12 @@ def _format(self, parser, info, *args):
formatter(info)
+ def _dispatch_errors(self, info):
+ if info and isinstance(info, dict):... | diff --git a/test/integration/command_v2/test_info_build_order.py b/test/integration/command_v2/test_info_build_order.py
index b735920e185..24ea1642733 100644
--- a/test/integration/command_v2/test_info_build_order.py
+++ b/test/integration/command_v2/test_info_build_order.py
@@ -76,9 +76,9 @@ def test_info_build_order... | [bug] Consistent command results and error messages accross install/create and graph
### What is your suggestion?
When a dependency is `missing` or `invalid`, CLI commands `install`, `create`, etc, will output pertinent error messages and the exit code of the application will be `!=0`, meaning the command failed.
... | 2024-06-06T07:59:48Z | 2024-07-31T14:01:19Z | ["test/integration/command_v2/test_info_build_order.py::test_info_build_order_options", "test/integration/command_v2/test_info_build_order.py::test_info_build_order_configuration", "test/integration/command_v2/test_info_build_order.py::test_info_build_order_merge_multi_product", "test/integration/command_v2/test_info_b... | [] | ["test/integration/command_v2/test_info_build_order.py::TestBuildOrderReduce::test_error_different_orders", "test/integration/command_v2/test_info_build_order.py::test_build_order_missing_package_check_error"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
conan-io/conan | conan-io__conan-16613 | 3c72e2a83b468bb0d18e958c7e160fbb324b146e | diff --git a/conan/tools/gnu/makedeps.py b/conan/tools/gnu/makedeps.py
index c3d0017b988..d02cc353404 100644
--- a/conan/tools/gnu/makedeps.py
+++ b/conan/tools/gnu/makedeps.py
@@ -30,7 +30,9 @@
import textwrap
from jinja2 import Template, StrictUndefined
+from typing import Optional
+from conan.api.output import... | diff --git a/test/integration/toolchains/gnu/test_makedeps.py b/test/integration/toolchains/gnu/test_makedeps.py
index 948174280b1..31fd5d3a6fd 100644
--- a/test/integration/toolchains/gnu/test_makedeps.py
+++ b/test/integration/toolchains/gnu/test_makedeps.py
@@ -30,6 +30,8 @@ def package_info(self):
... | [feature] Add properties to MakeDeps generator
### What is your suggestion?
I would like to access custom properties from GNU Make files generated by the MakeDeps generator. If the receipt defines custom properties in the `package_info()` method then those properties should appear as make variables, too. The pattern o... | On second thought I would drop the replacement of dots with underscores. Dots are valid charactes in GNU Make variable names.
Hi @vajdaz
Thanks for your suggestion
What would be exactly the use case? What kind of information are you propagating from dependencies to the consumers via properties?
The ``properti... | 2024-07-04T20:02:53Z | 2024-07-09T19:59:32Z | ["test/integration/toolchains/gnu/test_makedeps.py::test_makefile_sysroot[sysroot = ['/foo/bar/sysroot']-True-CONAN_SYSROOT_PACKAGE = /foo/bar/sysroot]", "test/integration/toolchains/gnu/test_makedeps.py::test_makedeps_with_editable_layout", "test/integration/toolchains/gnu/test_makedeps.py::test_multiple_include_and_l... | [] | ["test/integration/toolchains/gnu/test_makedeps.py::test_makefile_reference", "test/integration/toolchains/gnu/test_makedeps.py::test_make_with_public_deps_and_component_requires", "test/integration/toolchains/gnu/test_makedeps.py::test_make_dirs_with_abs_path"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-16028 | 2dcaf42727d90421a5e73417c8f970377394237f | diff --git a/conan/tools/build/__init__.py b/conan/tools/build/__init__.py
index 9c77a3f4d5a..0ae8bc5f392 100644
--- a/conan/tools/build/__init__.py
+++ b/conan/tools/build/__init__.py
@@ -6,6 +6,8 @@
from conan.tools.build.flags import cppstd_flag
from conan.tools.build.cppstd import check_max_cppstd, check_min_cpps... | diff --git a/test/integration/command_v2/test_inspect.py b/test/integration/command_v2/test_inspect.py
index 129ee376181..8de7c470ac1 100644
--- a/test/integration/command_v2/test_inspect.py
+++ b/test/integration/command_v2/test_inspect.py
@@ -14,6 +14,7 @@ def test_basic_inspect():
' shared: ... | [feature] The git clone URL is no longer logged.
### Environment details
* Conan version: >= 2.1.0, specifically any version after https://github.com/conan-io/conan/pull/15514
### Steps to reproduce
Any Git(self).clone command will no longer log the URL, instead show `<hidden>`.
### Logs
```
user997@ffaebed0... | Hi @shoeffner
Thanks very much for your feedback.
I am afraid this is not a bug, this was done deliberately, based on 2 things:
- Even if the recommended way is to use git ssh keys or similar, and not URL encoded ones, there was still a relatively high risk and users using URL-encoded auth. Conan must avoid a... | 2024-04-05T13:13:16Z | 2024-06-04T10:18:27Z | ["test/integration/package_id/test_cache_compatibles.py::TestDefaultCompat::test_header_only_build_missing", "test/integration/package_id/test_cache_compatibles.py::TestCacheCompatibles::test_compatible_recipe_reference", "test/integration/toolchains/meson/test_mesontoolchain.py::test_linker_scripts_via_conf", "test/un... | [] | ["test/integration/command_v2/test_inspect.py::test_basic_inspect", "test/integration/command_v2/test_inspect.py::test_requiremens_inspect", "test/integration/toolchains/meson/test_mesontoolchain.py::test_c_std", "test/unittests/client/toolchain/autotools/autotools_toolchain_test.py::test_cstd", "test/unittests/tools/m... | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-16350 | a3d2fbcefe1cbdff55efb085d7c177c3d1e32dc8 | diff --git a/conan/tools/files/files.py b/conan/tools/files/files.py
index 73f0d6d82b2..661b88db3a2 100644
--- a/conan/tools/files/files.py
+++ b/conan/tools/files/files.py
@@ -66,7 +66,7 @@ def rmdir(conanfile, path):
_internal_rmdir(path)
-def rm(conanfile, pattern, folder, recursive=False):
+def rm(conanfil... | diff --git a/test/unittests/tools/files/test_rm.py b/test/unittests/tools/files/test_rm.py
index 75f32fa84cd..b569ac33138 100644
--- a/test/unittests/tools/files/test_rm.py
+++ b/test/unittests/tools/files/test_rm.py
@@ -1,4 +1,5 @@
import os
+import pytest
# Check it is importable from tools
from conan.tools.file... | [feature] Adding support to exclude pattern when removing files with Conan tools
### What is your suggestion?
Greetings!
Following the logic behind of [conan.tools.files.copy](https://docs.conan.io/2/reference/tools/files/basic.html#conan-tools-files-copy), users can exclude an specific pattern of file, avoid extra... | Sure, if this helps recipes, I think this can be added. | 2024-05-28T13:08:51Z | 2024-05-28T14:53:49Z | ["test/unittests/tools/files/test_rm.py::test_remove_files_by_mask_recursively"] | [] | ["test/unittests/tools/files/test_rm.py::test_exclude_pattern_from_remove_list[results2-False]", "test/unittests/tools/files/test_rm.py::test_exclude_pattern_from_remove_list[results2-True]", "test/unittests/tools/files/test_rm.py::test_exclude_pattern_from_remove_list[results0-True]", "test/unittests/tools/files/test_... | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-16103 | 524c4400a59626e1b8f699a9742b0445dfadbdff | diff --git a/conans/client/cmd/uploader.py b/conans/client/cmd/uploader.py
index 65afb5150f5..424e100ff9b 100644
--- a/conans/client/cmd/uploader.py
+++ b/conans/client/cmd/uploader.py
@@ -9,7 +9,8 @@
from conans.paths import (CONAN_MANIFEST, CONANFILE, EXPORT_SOURCES_TGZ_NAME,
EXPORT_TGZ_NA... | diff --git a/conans/test/integration/command/source_test.py b/conans/test/integration/command/source_test.py
index d6e6a83933b..57644154ed2 100644
--- a/conans/test/integration/command/source_test.py
+++ b/conans/test/integration/command/source_test.py
@@ -1,4 +1,5 @@
import os
+import re
import textwrap
import unit... | [feature] show uploaded files size in `conan upload`
<!-- What is your suggestion? Please be as specific as possible! -->
It would be very convenient to provide the size of files which will be upload to specific remote via `conan upload ...` in diagnostic purposes, e.g. sometimes artifacts could be very large and CI c... | It is relatively straightforward to just check the files in the Conan cache in case the upload failed, so not a high priority. We might add it to the output in Conan 2.0, depends on how cluttered the output looks, might be added or not, we will see.
@memsharded was the decision to add it or to not? Should this ticket b... | 2024-04-18T10:11:05Z | 2024-04-18T12:09:09Z | ["conans/test/integration/command/source_test.py::SourceTest::test_apply_patch", "conans/test/integration/command/source_test.py::SourceTest::test_local_source", "conans/test/integration/command/source_test.py::SourceTest::test_source_method_called_again_if_left_dirty", "conans/test/integration/command/source_test.py::... | [] | ["conans/test/integration/command/source_test.py::SourceTest::test_retrieve_exports_sources", "conans/test/integration/command/source_test.py::test_source_python_requires"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-15950 | aa52f656c2ee45b01920ffbc5c8b250e5204c142 | diff --git a/conan/api/subapi/cache.py b/conan/api/subapi/cache.py
index 36068942d28..0875f6fb2a0 100644
--- a/conan/api/subapi/cache.py
+++ b/conan/api/subapi/cache.py
@@ -162,32 +162,49 @@ def restore(self, path):
the_tar.extractall(path=self.conan_api.cache_folder)
the_tar.close()
+ ... | diff --git a/conans/test/integration/command_v2/test_cache_save_restore.py b/conans/test/integration/command_v2/test_cache_save_restore.py
index e178cf240b2..046e0fb0e96 100644
--- a/conans/test/integration/command_v2/test_cache_save_restore.py
+++ b/conans/test/integration/command_v2/test_cache_save_restore.py
@@ -30,... | [bug] conan cache restore produces incorrect folders if run multiple times
### Describe the bug
On Conan 2.2.1 there is an issue if `conan cache restore` is used to attempt to restore the same saved cache multiple times.
I ran into this issue in our internal CI pipelines, where we have multiple parallel builds that... | 2024-03-26T11:34:00Z | 2024-03-27T09:25:37Z | ["conans/test/integration/command_v2/test_cache_save_restore.py::test_cache_save_restore_graph", "conans/test/integration/command_v2/test_cache_save_restore.py::test_cache_save_downloaded_restore", "conans/test/integration/command_v2/test_cache_save_restore.py::test_cache_save_restore_metadata", "conans/test/integratio... | [] | ["conans/test/integration/command_v2/test_cache_save_restore.py::test_cache_save_restore_with_package_file", "conans/test/integration/command_v2/test_cache_save_restore.py::test_cache_save_restore", "conans/test/integration/command_v2/test_cache_save_restore.py::test_cache_save_subfolder"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
conan-io/conan | conan-io__conan-15931 | 937bfcc6385ab88384d13fd7aca325386ad31b97 | diff --git a/conan/tools/system/package_manager.py b/conan/tools/system/package_manager.py
index f1dcfc42cda..70195b09082 100644
--- a/conan/tools/system/package_manager.py
+++ b/conan/tools/system/package_manager.py
@@ -39,7 +39,7 @@ def get_default_tool(self):
os_name = distro.id() or os_name
el... | diff --git a/conans/test/integration/tools/system/package_manager_test.py b/conans/test/integration/tools/system/package_manager_test.py
index dc48198e7cf..6375a18c695 100644
--- a/conans/test/integration/tools/system/package_manager_test.py
+++ b/conans/test/integration/tools/system/package_manager_test.py
@@ -62,6 +6... | [feature] Add support for Pop!_OS to package_manager
### What is your suggestion?
[Pop!_OS](https://pop.system76.com/) is an Ubuntu-based Linux distribution. It would be great if it could be added to the list of distributions that support `apt-get`. Its `distro.id()` is `pop`.
### Have you read the CONTRIBUTING g... | Sure, thanks for the suggestion @jwillikers
That should be an easy one, do you want to submit the contribution yourself?
I can do that. | 2024-03-22T16:40:29Z | 2024-03-22T17:33:48Z | ["conans/test/integration/tools/system/package_manager_test.py::test_tools_update_mode_install[PacMan-pacman -Syyu --noconfirm]", "conans/test/integration/tools/system/package_manager_test.py::test_tools_update_mode_install[Apk-apk update]", "conans/test/integration/tools/system/package_manager_test.py::test_tools_inst... | [] | ["conans/test/integration/tools/system/package_manager_test.py::test_package_manager_distro[pop-apt-get]"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-15710 | e2a6d96e84849a3c91d6c4c3726a328e7e60f974 | diff --git a/conan/tools/apple/xcodetoolchain.py b/conan/tools/apple/xcodetoolchain.py
index 65d9e70e409..5af04498a64 100644
--- a/conan/tools/apple/xcodetoolchain.py
+++ b/conan/tools/apple/xcodetoolchain.py
@@ -57,7 +57,7 @@ def generate(self):
@property
def _cppstd(self):
from conan.tools.build.fl... | diff --git a/conans/test/unittests/client/build/cpp_std_flags_test.py b/conans/test/unittests/client/build/cpp_std_flags_test.py
index d03020afdd2..f9b6cc373bf 100644
--- a/conans/test/unittests/client/build/cpp_std_flags_test.py
+++ b/conans/test/unittests/client/build/cpp_std_flags_test.py
@@ -1,16 +1,17 @@
import u... | [feature] conan v2 tools: Expose `cppstd_flag` function
<!-- What is your suggestion? Please be as specific as possible! -->
- [x] I've read the [CONTRIBUTING guide](https://github.com/conan-io/conan/blob/develop/.github/CONTRIBUTING.md).
This helper is useful in recipes relying on unusual build systems, in order... | 2024-02-20T14:21:35Z | 2024-02-21T15:49:37Z | [] | [] | ["conans/test/unittests/tools/intel/test_intel_cc.py::test_cppstd_flag_if_intel_cc[gnu17-gnu++17]", "conans/test/unittests/client/build/cpp_std_flags_test.py::CompilerFlagsTest::test_mcst_lcc_cppstd_flag", "conans/test/unittests/tools/intel/test_intel_cc.py::test_cppstd_flag_if_intel_cc[gnu03-gnu++03]", "conans/test/un... | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
conan-io/conan | conan-io__conan-15699 | 953035a5262763a26696e490b5aa35086b3e2311 | diff --git a/conan/tools/gnu/get_gnu_triplet.py b/conan/tools/gnu/get_gnu_triplet.py
index 751c1b6639c..5e230218baf 100644
--- a/conan/tools/gnu/get_gnu_triplet.py
+++ b/conan/tools/gnu/get_gnu_triplet.py
@@ -15,7 +15,7 @@ def _get_gnu_triplet(os_, arch, compiler=None):
"needed for os=Wind... | diff --git a/conans/test/unittests/tools/gnu/test_triplets.py b/conans/test/unittests/tools/gnu/test_triplets.py
index a3ddb07cce7..481104ccd59 100644
--- a/conans/test/unittests/tools/gnu/test_triplets.py
+++ b/conans/test/unittests/tools/gnu/test_triplets.py
@@ -5,7 +5,7 @@
@pytest.mark.parametrize("os_, arch, c... | [bug] gnu triplet for os=Linux arch=x86 is suboptimal
### Environment Details (include every applicable attribute)
* Operating System+version: ArchLinux current
* Compiler+version: gcc 11.1.0
* Conan version: Current git head ( 1.24.0-1085-g106e54c9 )
* Python version: Python 3.10.1
### Description
Th... | Can confirm this issue in Conan 2.0.1. The wrong triplet prevents cross-compiling m4/1.4.19 to x86 on Linux. Any updates or work-arounds?
Replying to myself... to work-around this issue, we can override the GNU triplet in a profile for x86:
```
[conf]
tools.gnu:host_triplet=i686-linux-gnu
``` | 2024-02-19T09:25:02Z | 2024-02-19T10:37:13Z | ["conans/test/unittests/tools/gnu/test_triplets.py::test_get_gnu_triplet[iOS-armv7-None-arm-apple-ios]", "conans/test/unittests/tools/gnu/test_triplets.py::test_get_gnu_triplet[Android-armv6-None-arm-linux-androideabi]", "conans/test/unittests/tools/gnu/test_triplets.py::test_get_gnu_triplet[Linux-armv6-None-arm-linux-... | [] | ["conans/test/unittests/tools/gnu/test_triplets.py::test_get_gnu_triplet_on_windows_without_compiler", "conans/test/unittests/tools/gnu/test_triplets.py::test_get_gnu_triplet[Linux-x86-None-i686-linux-gnu]"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-15422 | f08b9924712cf0c2f27b93cbb5206d56d0d824d8 | diff --git a/conan/tools/cmake/presets.py b/conan/tools/cmake/presets.py
index cb11e2174f8..27792af73b9 100644
--- a/conan/tools/cmake/presets.py
+++ b/conan/tools/cmake/presets.py
@@ -6,6 +6,7 @@
from conan.tools.cmake.layout import get_build_folder_custom_vars
from conan.tools.cmake.toolchain.blocks import GenericS... | diff --git a/conans/test/integration/toolchains/cmake/test_cmaketoolchain.py b/conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
index 46f88c732c0..604aaf01d75 100644
--- a/conans/test/integration/toolchains/cmake/test_cmaketoolchain.py
+++ b/conans/test/integration/toolchains/cmake/test_cmaketoolchain.py... | [feature] set jobs parameter in CMakePreset buildPresets to get parallel builds when invoking cmake after conan install
### What is your suggestion?
the generated CMakePresets.json does not contain the "jobs" parameter, making it default to 1 (at least sometimes).
when manually set to a higher number, the cmake build... | Hi @Hailios
Thanks for your suggestion.
I think this could make sense, might be doable, I'll check with the team. | 2024-01-09T13:09:29Z | 2024-01-10T15:04:20Z | ["conans/test/integration/toolchains/cmake/test_cmaketoolchain.py::test_set_linker_scripts", "conans/test/integration/toolchains/cmake/test_cmaketoolchain.py::test_toolchain_cache_variables", "conans/test/integration/toolchains/cmake/test_cmaketoolchain.py::test_cross_build_linux_to_macos", "conans/test/integration/too... | [] | ["conans/test/integration/toolchains/cmake/test_cmaketoolchain.py::test_presets_njobs"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
conan-io/conan | conan-io__conan-15185 | 2e568138707a4d35a53e063a86af2aa6ee2793fb | diff --git a/conans/model/profile.py b/conans/model/profile.py
index abdb5f0bb2f..a06ea9efc4c 100644
--- a/conans/model/profile.py
+++ b/conans/model/profile.py
@@ -30,12 +30,14 @@ def __repr__(self):
return self.dumps()
def serialize(self):
- # TODO: Remove it seems dead
+ def _serialize_... | diff --git a/conans/test/integration/command/test_profile.py b/conans/test/integration/command/test_profile.py
index 8490f435c43..6405319e47a 100644
--- a/conans/test/integration/command/test_profile.py
+++ b/conans/test/integration/command/test_profile.py
@@ -133,9 +133,13 @@ def test_shorthand_syntax():
def test_p... | [bug] `conan profile show` crashes when requesting json output if profile contains a reference.
### Environment details
* Operating System+version: macOS 12.6
* Conan version: 2.0.14
* Python version: 3.11.4
### Steps to reproduce
Issuing `conan profile show -pr:h ourprofile`, we get:
```
[settings]
arch=x8... | 2023-11-27T18:11:51Z | 2023-11-28T14:45:18Z | ["conans/test/integration/command/test_profile.py::test_profile_path", "conans/test/integration/command/test_profile.py::test_profile_path_missing", "conans/test/unittests/model/profile_test.py::ProfileTest::test_apply", "conans/test/unittests/model/profile_test.py::ProfileTest::test_profile_subsettings_update", "conan... | [] | ["conans/test/unittests/model/profile_test.py::test_update_build_requires", "conans/test/integration/command/test_profile.py::test_profile_show_json", "conans/test/unittests/model/profile_test.py::test_profile_serialize"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
conan-io/conan | conan-io__conan-15121 | a12a08dc41ae3138044c65b82ee51eb2ed672e9c | diff --git a/conans/model/conan_file.py b/conans/model/conan_file.py
index d480d37fc7c..c2d009575f8 100644
--- a/conans/model/conan_file.py
+++ b/conans/model/conan_file.py
@@ -318,7 +318,7 @@ def generators_path(self) -> Path:
return Path(self.generators_folder)
def run(self, command, stdout=None, cwd=... | diff --git a/conans/test/functional/conanfile/runner_test.py b/conans/test/functional/conanfile/runner_test.py
index 9144dc4596b..c4180f2aef7 100644
--- a/conans/test/functional/conanfile/runner_test.py
+++ b/conans/test/functional/conanfile/runner_test.py
@@ -56,3 +56,18 @@ def source(self):
client.save({"con... | Have `ConanFile.run()` be able to get `stderr` just like it does for `stdout`
Somestimes recipes call to programs that outùt important info to stderr instead of stdout, and Conan currently provides no good way to fetch that info
_Originally posted by @RubenRBS in https://github.com/conan-io/conan-center-index/pull... | 2023-11-16T16:14:15Z | 2023-11-20T07:07:06Z | ["conans/test/functional/conanfile/runner_test.py::RunnerTest::test_ignore_error", "conans/test/functional/conanfile/runner_test.py::RunnerTest::test_custom_stream_error"] | [] | ["conans/test/functional/conanfile/runner_test.py::RunnerTest::test_runner_capture_output", "conans/test/functional/conanfile/runner_test.py::RunnerTest::test_custom_stream_stderr"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
conan-io/conan | conan-io__conan-15109 | 4614b3abbff15627b3fabdd98bee419721f423ce | diff --git a/conans/client/downloaders/caching_file_downloader.py b/conans/client/downloaders/caching_file_downloader.py
index ed04a1e66b9..4b7914f602f 100644
--- a/conans/client/downloaders/caching_file_downloader.py
+++ b/conans/client/downloaders/caching_file_downloader.py
@@ -49,7 +49,7 @@ def _caching_download(sel... | diff --git a/conans/test/integration/cache/backup_sources_test.py b/conans/test/integration/cache/backup_sources_test.py
index 303a13626f3..fecc60ad043 100644
--- a/conans/test/integration/cache/backup_sources_test.py
+++ b/conans/test/integration/cache/backup_sources_test.py
@@ -185,6 +185,16 @@ def source(self):
... | [bug] conan 2.0.14 regression on core.sources:download_urls
### Environment details
* Operating System+version: ubuntu-22.04
* Compiler+version: gcc11
* Conan version: 2.0.14
* Python version: 3.11.2
### Steps to reproduce
There is a regression from 2.0.13 -> 2.0.14.
We make use of the
`core.sources:downlo... | Hi @jonboan thanks a lot for your report. We've identified the issue and will fix it asap. For now to unblock you until we release the fix, this only reproduces when the `core.sources:download_cache` conf is not set, so you might try setting it to something that works for you (It's usually set to `<CONAN_HOME>/sources`... | 2023-11-15T16:46:07Z | 2023-11-15T22:48:40Z | ["conans/test/integration/cache/backup_sources_test.py::TestDownloadCacheBackupSources::test_download_sources_multiurl", "conans/test/integration/cache/backup_sources_test.py::TestDownloadCacheBackupSources::test_list_urls_miss", "conans/test/integration/cache/backup_sources_test.py::TestDownloadCacheBackupSources::tes... | [] | ["conans/test/integration/cache/backup_sources_test.py::TestDownloadCacheBackupSources::test_source_then_upload_workflow", "conans/test/integration/cache/backup_sources_test.py::TestDownloadCacheBackupSources::test_upload_sources_backup"] | [] | {"install": ["uv pip install -e .", "export PYTHONPATH=$(pwd)"], "pre_install": ["tee pytest.ini <<EOF_1234810234\n[pytest]\nnorecursedirs = \\'.*\\', \\'dist\\', \\'CVS\\', \\'_darcs\\', \\'{arch}\\', \\'*.egg\\', \\'venv\\', \\'assets\\'\ntestpaths = \\'test\\'\naddopts = --color=no -rA --tb=no -p no:cacheprovider\n\... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-16464 | aa9b78bcf5b83595161a633cf4431fc18726776d | diff --git a/src/prefect/server/api/server.py b/src/prefect/server/api/server.py
index f6fa3b587955..3148ceecb71a 100644
--- a/src/prefect/server/api/server.py
+++ b/src/prefect/server/api/server.py
@@ -360,10 +360,13 @@ def create_ui_app(ephemeral: bool) -> FastAPI:
mimetypes.add_type("application/javascript"... | diff --git a/tests/server/test_app.py b/tests/server/test_app.py
index 49c2f652c367..742b7f443031 100644
--- a/tests/server/test_app.py
+++ b/tests/server/test_app.py
@@ -3,6 +3,7 @@
from prefect.server.api.server import create_app
from prefect.settings import (
+ PREFECT_SERVER_API_AUTH_STRING,
PREFECT_SER... | CSRF in combination with basic auth breaks UI
### Bug summary
When enabling CSRF (by `PREFECT_SERVER_CSRF_PROTECTION_ENABLED`) and basic auth (by `PREFECT_API_AUTH_STRING`) on the server, the UI no longer shows any information. After disabling CSRF protection everything works as expected.
It seems this is due to no... | Thank you for the bug report @Fatal705 and for identifying the potential issue; I'm looking into why the auth string isn't respected for that call right now and should have a fix soon. | 2024-12-20T00:40:00Z | 2024-12-20T20:16:12Z | ["tests/server/test_app.py::test_app_generates_correct_api_openapi_schema", "tests/server/test_app.py::test_app_add_csrf_middleware_when_enabled[True]"] | [] | ["tests/server/test_app.py::test_app_add_csrf_middleware_when_enabled[False]", "tests/server/test_app.py::test_app_exposes_ui_settings"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.7.0", "apprise==1.9.1", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.3.0", "babel==2.16.0", "boto3==1.35.8... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-16458 | c29969eda8dd3564ff3fda03f50ce87782e8ceff | diff --git a/flows/load_flows_concurrently.py b/flows/load_flows_concurrently.py
new file mode 100644
index 000000000000..fd4e2b9e1aaa
--- /dev/null
+++ b/flows/load_flows_concurrently.py
@@ -0,0 +1,39 @@
+import asyncio
+
+from prefect import Flow
+from prefect.runner.storage import GitRepository
+
+
+async def load_f... | diff --git a/tests/utilities/test_importtools.py b/tests/utilities/test_importtools.py
index ce9837415298..d95ebc3773d4 100644
--- a/tests/utilities/test_importtools.py
+++ b/tests/utilities/test_importtools.py
@@ -1,3 +1,4 @@
+import asyncio
import importlib.util
import runpy
import sys
@@ -15,6 +16,7 @@
from_... | flow.from_source not threadsafe
### Bug summary
Loading multiple flows concurrently with `flow.from_source` seems to randomly fail. Run the script below to observe the behavior. Sometimes it completes, but other times it errors with `KeyError: '__prefect_loader__'` as shown below.
```py
import asyncio
from pref... | @zzstoatzz running your version didn't make a difference for me. Run it like 10 times in quick succession and you'll randomly see it error out. | 2024-12-19T17:41:39Z | 2024-12-20T18:06:54Z | ["tests/utilities/test_importtools.py::test_import_object_from_module_with_relative_imports_expected_failures[working_directory0-explicit_relative.foobar]", "tests/utilities/test_importtools.py::test_safe_load_namespace_ignores_import_errors", "tests/utilities/test_importtools.py::test_safe_load_namespace_ignores_code_... | [] | ["tests/utilities/test_importtools.py::test_concurrent_script_loading", "tests/utilities/test_importtools.py::test_safe_load_namespace_implicit_relative_imports"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.7.0", "apprise==1.9.1", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.3.0", "babel==2.16.0", "boto3==1.35.8... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-16311 | e5172a082ea3228fb5b81c564961346e368da70f | diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py
index dfbc3c119b6d..4a5a06790a65 100644
--- a/src/prefect/client/orchestration.py
+++ b/src/prefect/client/orchestration.py
@@ -499,6 +499,23 @@ async def read_flow(self, flow_id: UUID) -> Flow:
response = await self._client... | diff --git a/tests/client/test_prefect_client.py b/tests/client/test_prefect_client.py
index fce86c1a8040..b1da96987c2d 100644
--- a/tests/client/test_prefect_client.py
+++ b/tests/client/test_prefect_client.py
@@ -568,6 +568,19 @@ def foo():
assert lookup.name == foo.name
+async def test_create_then_delete_fl... | Prefect Python client does not support flow deletion
### Bug summary
The Prefect REST API supports flow removal via `DELETE` HTTP method on the `/api/flows/{flow_id}` endpoint. However, the Python Prefect client lacks this functionality, making it impossible to remove the flow without patching the client or calling th... | 2024-12-10T14:04:30Z | 2024-12-19T18:40:30Z | ["tests/client/test_prefect_client.py::TestArtifacts::test_read_artifacts_with_latest_filter", "tests/client/test_prefect_client.py::TestClientWorkQueues::test_create_queue_with_settings", "tests/client/test_prefect_client.py::TestSyncClient::test_fixture_is_sync", "tests/client/test_prefect_client.py::TestClientContex... | [] | ["tests/client/test_prefect_client.py::test_create_then_delete_flow"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.6.0", "apprise==1.9.1", "asgi-lifespan==2.1.0", "asttokens==3.0.0", "asyncpg==0.29.0", "attrs==24.3.0", "babel==2.16.0", "boto3==1.35.85", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-16369 | 3abe9d067b0502e15d8963c8612edc10e221254e | diff --git a/src/prefect/tasks.py b/src/prefect/tasks.py
index d4e7d2fbce52..0d6610009847 100644
--- a/src/prefect/tasks.py
+++ b/src/prefect/tasks.py
@@ -474,6 +474,10 @@ def __init__(
if callable(retry_delay_seconds):
self.retry_delay_seconds = retry_delay_seconds(retries)
+ elif not is... | diff --git a/tests/test_tasks.py b/tests/test_tasks.py
index 88cc1c4d086a..06d41abd6423 100644
--- a/tests/test_tasks.py
+++ b/tests/test_tasks.py
@@ -4172,6 +4172,21 @@ def my_flow():
class TestTaskConstructorValidation:
+ async def test_task_cannot_configure_poorly_typed_retry_delay(self):
+ with pytes... | Missconfigured retry_delay_seconds task argument leads to confusing error message
### Bug summary
When the task arg `retry_delay_seconds` is not configured with the correct type, the error message presented is misleading:
```python
from datetime import timedelta
from prefect import get_run_logger, task, flow
@... | 2024-12-12T23:16:53Z | 2024-12-12T23:42:52Z | ["tests/test_tasks.py::TestNestedTasks::test_nested_submitted_async_task", "tests/test_tasks.py::TestResultPersistence::test_logs_warning_on_serialization_error", "tests/test_tasks.py::TestTaskCall::test_task_supports_async_instance_methods[BaseFooModel]", "tests/test_tasks.py::TestTaskMap::test_map_can_take_tuple_as_i... | [] | ["tests/test_tasks.py::TestTaskConstructorValidation::test_task_cannot_configure_poorly_typed_retry_delay"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.7.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.8... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-16328 | b60fc0c3288befd1a052a3743a315374da766ecb | diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py
index a07f2108c95a..d6b834d6bca6 100644
--- a/src/prefect/task_engine.py
+++ b/src/prefect/task_engine.py
@@ -600,6 +600,7 @@ def handle_timeout(self, exc: TimeoutError) -> None:
message=message,
name="TimedOut",
... | diff --git a/tests/test_task_engine.py b/tests/test_task_engine.py
index 185045fb9455..c4f1847b160c 100644
--- a/tests/test_task_engine.py
+++ b/tests/test_task_engine.py
@@ -1511,6 +1511,58 @@ async def foo():
assert run.end_time == failed.timestamp
assert run.total_run_time == failed.timestamp - run... | `TimedOut` task has no duration or end time
### Bug summary
Using the following sample flow to produce a `TimedOut` task and flow, the flow run receives a duration and end time but the task run does not.
```python
from prefect import flow, task
import requests
@task(timeout_seconds=5)
def timeout_task():
... | 2024-12-10T20:12:05Z | 2024-12-12T16:14:54Z | ["tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_sets_end_time_on_crashed", "tests/test_task_engine.py::TestTransactionHooks::test_commit_errors_are_logged", "tests/test_task_engine.py::TestCachePolicy::test_flow_parameter_caching", "tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_doe... | [] | ["tests/test_task_engine.py::TestTaskTimeTracking::test_sync_task_sets_end_time_on_failed_timedout", "tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_sets_end_time_on_failed_timedout"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.7.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.8... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-16308 | 5d1c88e92c7d04ff35dcd2708d8bdc5f4c18f7c5 | diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py
index bfcc6232192a..7afaf385b6c8 100644
--- a/src/prefect/client/orchestration.py
+++ b/src/prefect/client/orchestration.py
@@ -501,6 +501,24 @@ async def read_flow(self, flow_id: UUID) -> Flow:
response = await self._client... | diff --git a/tests/client/test_prefect_client.py b/tests/client/test_prefect_client.py
index 6791adc95855..92f0f43f96cc 100644
--- a/tests/client/test_prefect_client.py
+++ b/tests/client/test_prefect_client.py
@@ -631,6 +631,19 @@ def foo():
assert lookup.name == foo.name
+async def test_create_then_delete_fl... | Prefect Python client does not support flow deletion
### Bug summary
The Prefect REST API supports flow removal via `DELETE` HTTP method on the `/api/flows/{flow_id}` endpoint. However, the Python Prefect client lacks this functionality, making it impossible to remove the flow without patching the client or calling th... | 2024-12-10T13:45:58Z | 2024-12-10T14:00:28Z | ["tests/client/test_prefect_client.py::test_set_then_read_flow_run_state", "tests/client/test_prefect_client.py::test_global_concurrency_limit_read_nonexistent_by_name", "tests/client/test_prefect_client.py::test_create_flow_run_with_state", "tests/client/test_prefect_client.py::test_hello", "tests/client/test_prefect_... | [] | ["tests/client/test_prefect_client.py::test_create_then_delete_flow"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.7.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.7... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-16189 | e037fc60caa071a9ec7fc2380e00795ca3983aa4 | diff --git a/docs/v3/api-ref/rest-api/server/schema.json b/docs/v3/api-ref/rest-api/server/schema.json
index 13571d0144d9..694f7648d060 100644
--- a/docs/v3/api-ref/rest-api/server/schema.json
+++ b/docs/v3/api-ref/rest-api/server/schema.json
@@ -16968,7 +16968,9 @@
"next_page": {
... | diff --git a/tests/blocks/test_core.py b/tests/blocks/test_core.py
index e7d32f3c7247..80a7e2dd75ab 100644
--- a/tests/blocks/test_core.py
+++ b/tests/blocks/test_core.py
@@ -2976,3 +2976,9 @@ def test_dump_json_secrets(self, secret_data):
}
).decode()
)
+
+
+@patch("prefect.block... | Metadata files generated with RayTaskRunner
### Bug summary
## Issue description
I don't know if it's a bug or a desired behavior but some metadata files are generated each time I run my flows locally. That's annoying because the files are generated in my source directory (or from where I run the flows/tasks). I'd li... | Hey @dqueruel-fy - those files are a consequence of persisting task and flow results.
> I've tried to change the server config's PREFECT_LOCAL_STORAGE_PATH to /tmp/result but it didn't help
This setting has an effect at _workflow runtime_ and therefore setting it on the server will have no effect (all server con... | 2024-12-03T18:19:12Z | 2024-12-03T21:28:55Z | ["tests/blocks/test_core.py::TestSyncCompatible::test_block_in_flow_async_test_sync_flow", "tests/blocks/test_core.py::TestTypeDispatch::test_created_block_can_be_saved", "tests/test_context.py::TestHydratedContext::test_empty", "tests/blocks/test_core.py::TestToBlockType::test_to_block_type_with_slug_override", "tests... | [] | ["tests/test_context.py::TestHydratedContext::test_with_settings_context", "tests/test_context.py::TestHydratedContext::test_with_task_run_context_with_custom_result_store", "tests/blocks/test_core.py::test_dunder_new_loads_collections", "tests/test_context.py::TestHydratedContext::test_with_flow_run_context_with_custo... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.6.2.post1", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-16145 | b52c2c9a5d3d3d3e37e09efb73a4764857aa863e | diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py
index 43238d1cbc6c..5accda613f34 100644
--- a/src/prefect/task_engine.py
+++ b/src/prefect/task_engine.py
@@ -427,6 +427,11 @@ def set_state(self, state: State, force: bool = False) -> State:
self.task_run.state = new_state = state
+ ... | diff --git a/tests/test_task_engine.py b/tests/test_task_engine.py
index c6702f6a11de..185045fb9455 100644
--- a/tests/test_task_engine.py
+++ b/tests/test_task_engine.py
@@ -7,7 +7,7 @@
from pathlib import Path
from typing import List, Optional
from unittest import mock
-from unittest.mock import AsyncMock, MagicMo... | Async tasks stays in Pending state until Completed on Windows Client
### Bug summary
This issue is directly related to #15607 . After few hours of trial and error I managed to bring more light to it, at least i hope so.
**My findings indicate that Running state had the same timestamp as Pending state.**
Could... | 2024-11-28T14:08:06Z | 2024-12-03T01:31:14Z | ["tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_sets_end_time_on_crashed", "tests/test_task_engine.py::TestTransactionHooks::test_commit_errors_are_logged", "tests/test_task_engine.py::TestCachePolicy::test_flow_parameter_caching", "tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_doe... | [] | ["tests/test_task_engine.py::TestSyncTaskRunEngine::test_set_task_run_state_duplicated_timestamp", "tests/test_task_engine.py::TestAsyncTaskRunEngine::test_set_task_run_state_duplicated_timestamp", "tests/test_task_engine.py::TestTaskRunsSync::test_task_run_states_with_equal_timestamps", "tests/test_task_engine.py::Tes... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.14.0", "annotated-types==0.7.0", "anyio==4.6.2.post1", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asgiref==3.8.1", "asttokens==3.0.0", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15868 | 3c053dc00f7f97c4c7543d172ebf572b391bc579 | diff --git a/src/prefect/cache_policies.py b/src/prefect/cache_policies.py
index e4caa861c415..8c15ac89823a 100644
--- a/src/prefect/cache_policies.py
+++ b/src/prefect/cache_policies.py
@@ -175,7 +175,7 @@ def compute_key(
keys.append(policy_key)
if not keys:
return None
- ... | diff --git a/tests/test_task_engine.py b/tests/test_task_engine.py
index 76f9dbfa3564..c6702f6a11de 100644
--- a/tests/test_task_engine.py
+++ b/tests/test_task_engine.py
@@ -14,7 +14,7 @@
import pytest
from prefect import Task, flow, tags, task
-from prefect.cache_policies import FLOW_PARAMETERS
+from prefect.cach... | If one of multiple cache policies fails to compute cache key a cached result is still produced
### Bug summary
When using multiple cache policies for a task, if one of them fails to compute a cache key a cache result is still persisted and reused by other task run.
For example if we are using `cache_policy=TASK_SOU... | 2024-10-30T16:30:28Z | 2024-10-30T16:49:10Z | ["tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_sets_end_time_on_crashed", "tests/test_task_engine.py::TestTransactionHooks::test_commit_errors_are_logged", "tests/test_task_engine.py::TestCachePolicy::test_flow_parameter_caching", "tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_doe... | [] | ["tests/test_task_engine.py::TestCachePolicy::test_error_handling_on_cache_policies"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.3", "annotated-types==0.7.0", "anyio==4.6.2.post1", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.52", "botocor... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15773 | d09ef03bef4d2ffa70b8f9f260418ecbbf0926a1 | diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py
index 4e5a417cbf8b..a4c948fb5bc7 100644
--- a/src/prefect/task_engine.py
+++ b/src/prefect/task_engine.py
@@ -185,6 +185,22 @@ def _resolve_parameters(self):
self.parameters = resolved_parameters
+ def _set_custom_task_run_name(self):
... | diff --git a/tests/public/flows/test_flow_with_mapped_tasks.py b/tests/public/flows/test_flow_with_mapped_tasks.py
new file mode 100644
index 000000000000..064f52364cbb
--- /dev/null
+++ b/tests/public/flows/test_flow_with_mapped_tasks.py
@@ -0,0 +1,66 @@
+"""This is a regression test for https://github.com/PrefectHQ/p... | Callabe task name generators (3.0 vs. 2.x)
### Bug summary
I am doing some spike work on migrating our flows from v2.19 to v3.0. In doing this, I have found what appears to be a bug with callabe task name generators. I often use task vars (more specifically, values in a task dictionary arg) for naming task threads... | 2024-10-22T02:10:56Z | 2024-10-23T17:03:44Z | [] | [] | ["tests/public/flows/test_flow_with_mapped_tasks.py::test_flow_with_mapped_tasks"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.3", "annotated-types==0.7.0", "anyio==4.6.2.post1", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.30.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.47", "botocor... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15584 | 1d1b92a79b8972823ae9050d70bf60b7c586aabf | diff --git a/src/prefect/blocks/notifications.py b/src/prefect/blocks/notifications.py
index 4970a2b005b3..df8c6402b12a 100644
--- a/src/prefect/blocks/notifications.py
+++ b/src/prefect/blocks/notifications.py
@@ -294,6 +294,27 @@ def block_initialization(self) -> None:
)
self._start_apprise_client(u... | diff --git a/tests/blocks/test_notifications.py b/tests/blocks/test_notifications.py
index 71f61f82c99e..fa0ffad4440b 100644
--- a/tests/blocks/test_notifications.py
+++ b/tests/blocks/test_notifications.py
@@ -1,6 +1,6 @@
import urllib
from typing import Type
-from unittest.mock import patch
+from unittest.mock impo... | Subject and Body of PagerDuty Automation Appear Concatenated in the Incident Title
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is re... | I dug into this a bit and this looks to be an issue on the apprise side of things. Executing things directly from apprise with:
```
# Assuming our {integration_key} is A1BRTD4JD
# Assuming our {api_key} is TIiajkdnlazkcOXrIdevi7F
# Assuming our {source} is node01.local
# Assuming our {component} is drive_sda
appr... | 2024-10-03T22:10:26Z | 2024-10-09T21:18:29Z | ["tests/blocks/test_notifications.py::TestCustomWebhook::test_timeout_override", "tests/blocks/test_notifications.py::TestAppriseNotificationBlock::test_notify_async[SlackWebhook]", "tests/blocks/test_notifications.py::TestAppriseNotificationBlock::test_notification_can_prevent_restricted_urls[ --SlackWebhook]", "tests... | [] | ["tests/blocks/test_notifications.py::TestPagerDutyWebhook::test_notify_sync_with_subject", "tests/blocks/test_notifications.py::TestPagerDutyWebhook::test_notify_async_with_subject", "tests/blocks/test_notifications.py::TestMicrosoftTeamsWebhook::test_is_picklable"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.3", "annotated-types==0.7.0", "anyio==4.6.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.37", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-15468 | 8ebcefd79839168433fa2080c101221131050e05 | diff --git a/src/prefect/cli/deploy.py b/src/prefect/cli/deploy.py
index cf15c23ab6ee..cfa321482e55 100644
--- a/src/prefect/cli/deploy.py
+++ b/src/prefect/cli/deploy.py
@@ -41,6 +41,7 @@
)
from prefect.cli.root import app, is_interactive
from prefect.client.schemas.actions import DeploymentScheduleCreate
+from pre... | diff --git a/tests/cli/test_deploy.py b/tests/cli/test_deploy.py
index 661494a4ce4a..1f455b62306f 100644
--- a/tests/cli/test_deploy.py
+++ b/tests/cli/test_deploy.py
@@ -276,7 +276,7 @@ async def test_project_deploy(self, project_dir, prefect_client: PrefectClient):
await run_sync_in_worker_thread(
... | Add ability to configure `ConcurrenyOptions` to the CLI
### Describe the current behavior
Currently users can set the the concurrency_limit for a deployment when creating it with the CLI by specifying the limit with and int as so: `deploy "my-deployment -cl 1".
Upcoming work #15291, adds options for handling con... | 2024-09-23T16:00:12Z | 2024-09-24T16:41:46Z | ["tests/cli/test_deploy.py::TestDeployPattern::test_pattern_deploy_nonexistent_deployments_with_existing_deployments[nonexistent-*/nonexistent-*]", "tests/cli/test_deploy.py::TestDeployDockerBuildSteps::test_prompt_build_custom_docker_image_accepted_use_existing_dockerfile_rejected_rename_rejected", "tests/cli/test_dep... | [] | ["tests/cli/test_deploy.py::TestProjectDeploy::test_deploy_with_concurrency_limit_and_options[strategy-only]", "tests/cli/test_deploy.py::TestProjectDeploy::test_deploy_with_concurrency_limit_and_options[limit-and-strategy]", "tests/cli/test_deploy.py::TestDeployingUsingCustomPrefectFile::test_deploying_directory_as_pr... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.3", "annotated-types==0.7.0", "anyio==4.6.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.26", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15402 | 0a5e38ac59b4a861aed89b4b6aaf67bec86778d7 | diff --git a/src/prefect/blocks/webhook.py b/src/prefect/blocks/webhook.py
index 13b477e8c712..0c95428a44b9 100644
--- a/src/prefect/blocks/webhook.py
+++ b/src/prefect/blocks/webhook.py
@@ -11,6 +11,7 @@
# Use a global HTTP transport to maintain a process-wide connection pool for
# interservice requests
_http_trans... | diff --git a/tests/blocks/test_webhook.py b/tests/blocks/test_webhook.py
index a3cbc2143917..9d8679e07eda 100644
--- a/tests/blocks/test_webhook.py
+++ b/tests/blocks/test_webhook.py
@@ -44,19 +44,40 @@ class TestWebhook:
def test_webhook_raises_error_on_bad_request_method(self):
for method in ["GET", "PU... | Allow prefect Webhook to use insecure connections
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe the current beha... | Hi @flepknor, thanks for creating your first issue in Prefect! We've accepted this issue and labeled it as a good first issue for someone to work on, in case you feel so inclined :)
I am new to open source and would like to work on this issue. Can you guide me? @serinamarie
Hey @serinamarie , can you assign me this is... | 2024-09-17T08:26:11Z | 2024-09-19T07:58:49Z | ["tests/blocks/test_webhook.py::TestWebhook::test_webhook_must_not_point_to_restricted_urls[https://172.16.0.1-private address]", "tests/blocks/test_webhook.py::TestWebhook::test_webhook_must_not_point_to_restricted_urls[https://127.0.0.1-private address]", "tests/blocks/test_webhook.py::TestWebhook::test_webhook_must_... | [] | ["tests/blocks/test_webhook.py::TestWebhook::test_insecure_webhook_set", "tests/blocks/test_webhook.py::TestWebhook::test_save_and_load_webhook"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.5.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.23", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-15291 | 8f159b404126d93964a4daace7619bc553fa318c | diff --git a/docs/3.0/api-ref/rest-api/server/schema.json b/docs/3.0/api-ref/rest-api/server/schema.json
index 2e81ac042ad2..399fdd149724 100644
--- a/docs/3.0/api-ref/rest-api/server/schema.json
+++ b/docs/3.0/api-ref/rest-api/server/schema.json
@@ -14593,6 +14593,15 @@
"title": "ConcurrencyLimitCreat... | diff --git a/tests/server/models/test_deployments.py b/tests/server/models/test_deployments.py
index ecefb61aff16..fd7928870486 100644
--- a/tests/server/models/test_deployments.py
+++ b/tests/server/models/test_deployments.py
@@ -244,6 +244,25 @@ async def test_create_deployment_with_updated_by(self, session, flow):
... | Add more ways of handling deployment concurrency
### Describe the current behavior
We can currently pass in an int to `concurrency_limit`, once the limit is reached, additional runs are enqueued and will run when a slot becomes available
### Describe the proposed behavior
When creating a deployment, we should... | 2024-09-09T19:01:08Z | 2024-09-17T14:30:10Z | ["tests/server/models/test_deployments.py::TestDeploymentSchedules::test_can_read_schedules", "tests/server/models/test_deployments.py::TestCreateDeployment::test_create_deployment_with_created_by", "tests/server/models/test_deployments.py::TestScheduledRuns::test_schedule_runs_inserts_in_db", "tests/server/models/test... | [] | ["tests/server/models/test_deployments.py::TestDeploymentSchedules::test_can_delete_all_schedules", "tests/server/models/test_deployments.py::TestCreateDeployment::test_create_deployment_with_concurrency_limit", "tests/server/models/test_deployments.py::TestUpdateDeployment::test_update_deployment_with_concurrency_limi... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.21", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15365 | c75ee81aa74fddac4d78f5f09d299b431b541366 | diff --git a/src/prefect/client/orchestration.py b/src/prefect/client/orchestration.py
index 635fcd72f4ce..858a0e09fbd3 100644
--- a/src/prefect/client/orchestration.py
+++ b/src/prefect/client/orchestration.py
@@ -3132,6 +3132,30 @@ async def read_global_concurrency_limit_by_name(
else:
r... | diff --git a/tests/fixtures/database.py b/tests/fixtures/database.py
index 6ca85e5f7235..82a40cea7f46 100644
--- a/tests/fixtures/database.py
+++ b/tests/fixtures/database.py
@@ -1135,7 +1135,7 @@ def hello(name: str = "world"):
)
)
],
- concurrency_limit=1,... | Fix deployment concurrency limiting GCLs no longer created/updated
### Describe the current behavior
In order to enforce concurrency limits for a deployment (`deployment.concurrency_limit`), a worker uses prefect's `concurrency` helper to implicitly create and use a global concurrency limit under-the-hood.
This ... | Ideally, we want to be able to trust the operation that updates the concurrency limit on the deployment. If we can trust that, then this defensive posture around syncing is less necessary. And we can probably trust it, right? We won't expose the internal limit that manages the deployment's limit, and there is only one ... | 2024-09-12T19:45:04Z | 2024-09-13T00:09:24Z | ["tests/workers/test_base_worker.py::test_worker_with_work_pool", "tests/runner/test_runner.py::TestRunnerDeployment::test_from_entrypoint_raises_on_multiple_schedule_parameters[kwargs2]", "tests/runner/test_runner.py::TestRunnerDeployment::test_from_flow_raises_on_multiple_schedule_parameters[kwargs1]", "tests/runner/... | [] | ["tests/workers/test_base_worker.py::test_worker_with_deployment_concurrency_limit_proposes_awaiting_limit_state_name", "tests/runner/test_runner.py::TestRunner::test_runner_proposes_awaiting_concurrency_limit_state_name", "tests/runner/test_runner.py::TestRunner::test_runner_enforces_deployment_concurrency_limits", "t... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.19", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-15355 | dc2ab702ee50ae172bf5e65e35e5ebf704c7be8b | diff --git a/src/prefect/server/events/triggers.py b/src/prefect/server/events/triggers.py
index 51ceef29adc5..2c722901bab8 100644
--- a/src/prefect/server/events/triggers.py
+++ b/src/prefect/server/events/triggers.py
@@ -83,18 +83,39 @@ async def evaluate(
each automation, and will fire the associated action if ... | diff --git a/tests/events/server/triggers/test_regressions.py b/tests/events/server/triggers/test_regressions.py
index 71bdfc281262..cf3b803de81c 100644
--- a/tests/events/server/triggers/test_regressions.py
+++ b/tests/events/server/triggers/test_regressions.py
@@ -664,3 +664,60 @@ async def test_rapid_fire_events_wit... | A recurring reactive trigger may not fire for events received from the "future"
### Bug summary
This was reported by a Prefect customer with a simple recurring automation like:
```
{
"posture": "Reactive",
"expect": ["some-event"],
"threshold": 1,
"within": 86400
}
```
The idea here is to fire at ... | 2024-09-12T13:46:04Z | 2024-09-12T19:22:41Z | ["tests/events/server/triggers/test_regressions.py::test_same_event_in_expect_and_after_reacts_after_threshold_is_met", "tests/events/server/triggers/test_regressions.py::test_does_not_alert_work_queue_went_healthy", "tests/events/server/triggers/test_regressions.py::test_same_event_in_expect_and_after_proactively_does... | [] | ["tests/events/server/triggers/test_regressions.py::test_reactive_automation_can_trigger_on_events_arriving_in_the_future", "tests/events/server/triggers/test_regressions.py::test_rapid_fire_events_with_a_threshold"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.18", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15349 | 6c4ed2a47da69db1dab47fd646365d540103fc2a | diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py
index 775007c2827d..bb7e3312813c 100644
--- a/src/prefect/task_engine.py
+++ b/src/prefect/task_engine.py
@@ -766,10 +766,10 @@ def call_task_fn(
if transaction.is_committed():
result = transaction.read()
else:
- ... | diff --git a/tests/test_task_engine.py b/tests/test_task_engine.py
index 0c5cf6fb3473..76f9dbfa3564 100644
--- a/tests/test_task_engine.py
+++ b/tests/test_task_engine.py
@@ -13,7 +13,7 @@
import anyio
import pytest
-from prefect import Task, flow, task
+from prefect import Task, flow, tags, task
from prefect.cach... | task running under `with tags` context manager doesn't work as expected with .submit
### Bug summary
I would expect this to respect concurrency limits:
```
from prefect import flow, task, tags
@task()
def my_task(name):
print(f"Hello, I'm task {name}")
@flow()
def my_flow():
with tags("my_tag"):... | Thank you for the bug report! I can recreate.
It looks like the concurrency handling within the engine isn't looking up `TagsContext`. | 2024-09-12T00:27:42Z | 2024-09-12T03:01:03Z | ["tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_sets_end_time_on_crashed", "tests/test_task_engine.py::TestTransactionHooks::test_commit_errors_are_logged", "tests/test_task_engine.py::TestCachePolicy::test_flow_parameter_caching", "tests/test_task_engine.py::TestTaskTimeTracking::test_async_task_doe... | [] | ["tests/test_task_engine.py::TestTaskConcurrencyLimits::test_tag_concurrency_sync_with_tags_context", "tests/test_task_engine.py::TestTaskConcurrencyLimits::test_tag_concurrency_with_tags_context"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.18", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-15251 | 8ecdce468c71dc5b3a967c41fa96d7ab6c42912f | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 25b376157637..a870eba6204a 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -39,7 +39,7 @@ repos:
- id: generate-mintlify-openapi-docs
name: Generating OpenAPI docs for Mintlify
language: system
- e... | diff --git a/tests/records/test_filesystem.py b/tests/records/test_filesystem.py
index 5edc158796e7..edcba65743ac 100644
--- a/tests/records/test_filesystem.py
+++ b/tests/records/test_filesystem.py
@@ -53,23 +53,12 @@ def test_read_write(self, store, result):
async def test_read_locked_key(self, store, result):... | Fix flake `test_read_locked_key - _queue.Empty`
### Bug summary
```
FAILED tests/records/test_filesystem.py::TestFileSystemRecordStore::test_read_locked_key - _queue.Empty
```
### Version info (`prefect version` output)
```Text
» prefect version
Version: 3.0.0rc19+9.g1a73ede315
API version... | 2024-09-05T22:17:00Z | 2024-09-06T17:05:08Z | ["tests/records/test_filesystem.py::TestFileSystemRecordStore::test_exists", "tests/records/test_filesystem.py::TestFileSystemRecordStore::test_acquire_lock_when_previously_holder_timed_out", "tests/records/test_filesystem.py::TestFileSystemRecordStore::test_wait_for_lock_with_timeout", "tests/records/test_filesystem.p... | [] | ["tests/records/test_filesystem.py::TestFileSystemRecordStore::test_supports_serialization_level", "tests/records/test_filesystem.py::TestFileSystemRecordStore::test_read_locked_key"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.14", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15224 | 1f9bed1ec7f1e64a74588f0c245e606b59651ed6 | diff --git a/docs/mint.json b/docs/mint.json
index 7f9ebcda2e55..88b312eeb9bc 100644
--- a/docs/mint.json
+++ b/docs/mint.json
@@ -1261,6 +1261,10 @@
"destination": "/3.0/api-ref/python",
"source": "/latest/api-ref/prefect/:slug*"
},
+ {
+ "destination": "/3.0/api-ref/python",
+ "source"... | diff --git a/tests/cli/test_worker.py b/tests/cli/test_worker.py
index 4164b401c912..080636d581b6 100644
--- a/tests/cli/test_worker.py
+++ b/tests/cli/test_worker.py
@@ -493,7 +493,7 @@ async def test_worker_does_not_run_with_push_pool(push_work_pool):
),
(
"Workers are not r... | Update docs URL for all blocks
Now that integrations docs are colocated with the core docs, we need to update the docs URL with each block to point to the core docs.
| 2024-09-04T19:40:48Z | 2024-09-04T20:50:05Z | ["tests/cli/test_worker.py::TestWorkerSignalForwarding::test_sigint_sends_sigterm", "tests/cli/test_worker.py::test_worker_joins_existing_pool", "tests/cli/test_worker.py::test_start_worker_creates_work_pool_with_base_config", "tests/cli/test_worker.py::test_start_worker_with_limit", "tests/cli/test_worker.py::TestWork... | [] | ["tests/cli/test_worker.py::test_worker_does_not_run_with_push_pool", "tests/cli/test_worker.py::TestWorkerSignalForwarding::test_sigterm_sends_sigterm_then_sigkill"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.9.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.12", "botocore==1.3... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-15128 | 137ff561d9be2171ad0d544f86c9cef67998bccb | diff --git a/src/prefect/engine.py b/src/prefect/engine.py
index c96aa2cc9408..ef3fa7e790ea 100644
--- a/src/prefect/engine.py
+++ b/src/prefect/engine.py
@@ -332,6 +332,18 @@ def enter_flow_run_engine_from_subprocess(flow_run_id: UUID) -> State:
return state
+async def _make_flow_run(
+ flow: Flow, paramet... | diff --git a/tests/test_flows.py b/tests/test_flows.py
index 544245b63220..2fd78739e150 100644
--- a/tests/test_flows.py
+++ b/tests/test_flows.py
@@ -2830,6 +2830,20 @@ def my_flow():
assert state.type == StateType.FAILED
assert my_mock.call_args_list == [call(), call()]
+ def test_on_failure_ho... | Flow failure hook is not called when parameters fail validation
### Bug summary
When a flow run fails at runtime due to a parameter validation error, the defined `on_failure` hook is not called. This can be confusing to users as the flow run is in a failed state but nothing happens. See the MRE below:
```python
fr... | 2024-08-28T23:12:22Z | 2024-08-29T02:09:36Z | ["tests/test_flows.py::TestFlowHooksOnFailure::test_on_failure_hooks_work_with_sync_and_async[create_hook-create_hook]", "tests/test_flows.py::TestFlow::test_param_description_from_docstring", "tests/test_flows.py::TestDecorator::test_invalid_run_name", "tests/test_flows.py::TestFlowWithOptions::test_with_options_can_u... | [] | ["tests/test_flows.py::TestFlowHooksOnFailure::test_on_failure_hooks_run_on_bad_parameters"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.9", "botocore==1.35... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-14980 | b884702c966783ad638ce1709c5c368f15a164aa | diff --git a/src/prefect/blocks/core.py b/src/prefect/blocks/core.py
index d262f9403b7f..cac9e8172bb5 100644
--- a/src/prefect/blocks/core.py
+++ b/src/prefect/blocks/core.py
@@ -150,7 +150,11 @@ def _collect_secret_fields(
_collect_secret_fields(f"{name}.{field_name}", field.annotation, secrets)
... | diff --git a/tests/blocks/test_system.py b/tests/blocks/test_system.py
index d9404532f0ea..548af56b8239 100644
--- a/tests/blocks/test_system.py
+++ b/tests/blocks/test_system.py
@@ -1,18 +1,43 @@
import pendulum
+import pytest
+from pydantic import Secret as PydanticSecret
from pydantic import SecretStr
+from pydant... | Generic Secure Block
### Describe the current behavior
There is currently no generic block that can be used to store user defined keys can values in a secure way. All the current blocks are system specific, which may not match or work with home grown systems that the user already has in place.
### Describe the propos... | Hey @Bryan-Meier and thank you for the request! It makes sense to me. For my own understanding I'd like to offer up two alternatives and see if either of them appeal to you - either way I'm happy to support a `SecretDict` type `Block`, this is more to better understand patterns around `Block`s that we can improve.
... | 2024-08-16T19:34:57Z | 2024-08-26T18:20:02Z | [] | [] | ["tests/blocks/test_system.py::test_secret_block[string]", "tests/blocks/test_system.py::test_datetime", "tests/blocks/test_system.py::test_secret_block_with_pydantic_secret[secret_list]", "tests/blocks/test_system.py::test_secret_block[dict]", "tests/blocks/test_system.py::test_secret_block_with_pydantic_secret[secret... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.6", "botocore==1.35... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-15011 | e50160f59a8a1b10712a1f0b79d528d8f272484b | diff --git a/src/prefect/blocks/core.py b/src/prefect/blocks/core.py
index c6a0b8e584ef..d262f9403b7f 100644
--- a/src/prefect/blocks/core.py
+++ b/src/prefect/blocks/core.py
@@ -128,7 +128,9 @@ def _is_subclass(cls, parent_cls) -> bool:
Checks if a given class is a subclass of another class. Unlike issubclass,
... | diff --git a/tests/blocks/test_core.py b/tests/blocks/test_core.py
index af350a4943da..7001d9fc89d4 100644
--- a/tests/blocks/test_core.py
+++ b/tests/blocks/test_core.py
@@ -2,7 +2,7 @@
import json
import warnings
from textwrap import dedent
-from typing import Any, Dict, List, Type, Union
+from typing import Any, ... | Block register race condition for Block with field as list[Block]
### Bug summary
Defining blocks as shown below:
```python
from prefect.blocks.core import Block
class MyBlockB(Block):
color: str
class MyBlockA(Block):
inner_blocks: list[MyBlockB]
```
will result in the following traceback fo... | Good catch @GalLadislav! I believe that Blocks in lists, dicts, and tuples not being registered is an oversight. It looks like your suggestion would fix the issue, so it'd be great if you could submit a PR!
Thank you for your quick response. I will submit the PR asap. | 2024-08-19T22:48:11Z | 2024-08-21T14:52:07Z | ["tests/blocks/test_core.py::TestAPICompatibility::test_save_block_from_flow", "tests/blocks/test_core.py::TestAPICompatibility::test_from_block_document", "tests/blocks/test_core.py::TestAPICompatibility::test_save_protected_block_with_new_block_schema_version", "tests/blocks/test_core.py::TestSyncCompatible::test_blo... | [] | ["tests/blocks/test_core.py::TestRegisterBlockTypeAndSchema::test_register_nested_block_list", "tests/blocks/test_core.py::TestDumpSecrets::test_dump_json_secrets", "tests/blocks/test_core.py::TestRegisterBlockTypeAndSchema::test_register_nested_block_type_nested", "tests/blocks/test_core.py::TestRegisterBlockTypeAndSc... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.35.3", "botocore==1.35... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14923 | 318eaf2e7e335e75c9bb98337040f0dd14a4157e | diff --git a/src/prefect/workers/base.py b/src/prefect/workers/base.py
index 7ece104c426b..f92bae1c4a0e 100644
--- a/src/prefect/workers/base.py
+++ b/src/prefect/workers/base.py
@@ -981,7 +981,12 @@ async def _get_configuration(
deployment_vars = deployment.job_variables or {}
flow_run_vars = flow_... | diff --git a/tests/workers/test_base_worker.py b/tests/workers/test_base_worker.py
index 02c8567d46b5..a68c0a55db05 100644
--- a/tests/workers/test_base_worker.py
+++ b/tests/workers/test_base_worker.py
@@ -30,7 +30,7 @@
)
from prefect.flows import flow
from prefect.server import models
-from prefect.server.schemas.... | Job variables should use a deep merge rather than shallow merge of dictionaries
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is ... | Hi @EldhoKSuresh. Thank you for raising. Currently, if any environment variables are defined in a work pool they are all overwritten at deployment creation time if any environment variables are provided. At least that's the expected behavior - although, perhaps not the ideal behavior.
I'm going to make the title fo... | 2024-08-14T00:52:30Z | 2024-08-14T16:27:47Z | ["tests/workers/test_base_worker.py::TestCancellation::test_worker_cancel_run_without_infrastructure_support_for_kill[Cancelling]", "tests/workers/test_base_worker.py::test_worker_with_work_pool", "tests/workers/test_base_worker.py::TestWorkerProperties::test_defaults", "tests/workers/test_base_worker.py::TestPrepareFo... | [] | ["tests/workers/test_base_worker.py::test_env_merge_logic_is_deep", "tests/workers/test_base_worker.py::test_worker_last_polled_health_check"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.34.161", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14932 | 0117fe53ef5b38ecc272162b2921b09b43a6b207 | diff --git a/src/prefect/workers/base.py b/src/prefect/workers/base.py
index fdce809e30ae..b3ee5a1f4c3a 100644
--- a/src/prefect/workers/base.py
+++ b/src/prefect/workers/base.py
@@ -930,7 +930,12 @@ async def _get_configuration(
deployment_vars = deployment.job_variables or {}
flow_run_vars = flow_... | diff --git a/tests/workers/test_base_worker.py b/tests/workers/test_base_worker.py
index 97a1fc9407e6..7a91d6b6b530 100644
--- a/tests/workers/test_base_worker.py
+++ b/tests/workers/test_base_worker.py
@@ -18,7 +18,7 @@
)
from prefect.flows import flow
from prefect.server import models
-from prefect.server.schemas.... | Job variables should use a deep merge rather than shallow merge of dictionaries
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is ... | Hi @EldhoKSuresh. Thank you for raising. Currently, if any environment variables are defined in a work pool they are all overwritten at deployment creation time if any environment variables are provided. At least that's the expected behavior - although, perhaps not the ideal behavior.
I'm going to make the title fo... | 2024-08-14T16:04:43Z | 2024-08-14T16:24:07Z | ["tests/workers/test_base_worker.py::test_job_configuration_from_template_and_overrides[template2-overrides2-expected2]", "tests/workers/test_base_worker.py::test_base_worker_gets_job_configuration_when_syncing_with_backend_with_just_job_config", "tests/workers/test_base_worker.py::test_worker_with_work_pool", "tests/w... | [] | ["tests/workers/test_base_worker.py::TestBaseWorkerStart::test_start_executes_flow_runs", "tests/workers/test_base_worker.py::test_env_merge_logic_is_deep"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.34.161", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14920 | 95da8e96f8d7e70b4c5cc450679c33782493f7c1 | diff --git a/src/prefect/infrastructure/kubernetes.py b/src/prefect/infrastructure/kubernetes.py
index 2962dc214f97..c718fca5f30c 100644
--- a/src/prefect/infrastructure/kubernetes.py
+++ b/src/prefect/infrastructure/kubernetes.py
@@ -586,7 +586,7 @@ def _shortcut_customizations(self) -> JsonPatch:
... | diff --git a/tests/infrastructure/test_kubernetes_job.py b/tests/infrastructure/test_kubernetes_job.py
index be6b68e5efbb..f679dc6fa15a 100644
--- a/tests/infrastructure/test_kubernetes_job.py
+++ b/tests/infrastructure/test_kubernetes_job.py
@@ -153,6 +153,14 @@ def test_building_a_job_is_idempotent():
assert fir... | Error on KubernetesJob.publish_as_work_pool()
### Bug summary
This code, which is supposed to publish the KubernetesJob configuration as work pool, creates an error instead.
```python
from prefect.infrastructure import KubernetesJob
KubernetesJob.load("my-k8s-job").publish_as_work_pool()
```
The error is as f... | 2024-08-13T22:06:56Z | 2024-08-14T00:31:05Z | ["tests/infrastructure/test_kubernetes_job.py::test_sanitizes_user_label_keys[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa... | [] | ["tests/infrastructure/test_kubernetes_job.py::test_building_a_job_with_null_command", "tests/infrastructure/test_kubernetes_job.py::test_generate_work_pool_base_job_template[custom]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.2.0", "babel==2.16.0", "boto3==1.34.161", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-14839 | 67774d3c3ce59f02b2416c3d50590ce6aae8f002 | diff --git a/src/prefect/runner/storage.py b/src/prefect/runner/storage.py
index bf56f0baddcc..69ab4dd21767 100644
--- a/src/prefect/runner/storage.py
+++ b/src/prefect/runner/storage.py
@@ -285,6 +285,10 @@ def to_pull_step(self) -> Dict:
"branch": self._branch,
}
}
+ if s... | diff --git a/tests/runner/test_storage.py b/tests/runner/test_storage.py
index ec23c9b7ec7a..5b6e2a3975c2 100644
--- a/tests/runner/test_storage.py
+++ b/tests/runner/test_storage.py
@@ -468,6 +468,21 @@ def test_to_pull_step_with_block_credentials(self):
result = repo.to_pull_step()
assert re... | GitRepository Submodule Clone Issue
### Bug summary
We are currently working with Prefect and encountered a bug related to the GitRepository class, specifically regarding the inclusion of submodules during the repository pull process. Our GitHub repository is structured in a way that it has one submodule (a reposito... | Hi @Punit-Solanki - thank you for the issue! Does your submodule have an `__init__.py` file in its root? If not, could you try adding it and see if that resolves it? What I'm wondering is whether this is a problem with the `git clone --recurse-submodules` or a problem with the import mechanics.
Hi @cicdw - Thank you fo... | 2024-08-04T21:36:32Z | 2024-08-05T15:19:40Z | ["tests/runner/test_storage.py::TestGitRepository::TestCredentialFormatting::test_git_clone_with_bitbucket_access_token[credentials1]", "tests/runner/test_storage.py::TestCreateStorageFromSource::test_create_git_storage[https://github.com/user/repo.git-GitRepository]", "tests/runner/test_storage.py::TestGitRepository::... | [] | ["tests/runner/test_storage.py::TestBlockStorageAdapter::test_eq_method_different_type", "tests/runner/test_storage.py::TestGitRepository::TestToPullStep::test_to_pull_step_with_submodules"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.1.0", "babel==2.15.0", "boto3==1.34.154", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14837 | 934982e5969c1fd7721c06bbbb12b651ea0f2409 | diff --git a/docs/3.0rc/resources/upgrade-prefect-3.mdx b/docs/3.0rc/resources/upgrade-prefect-3.mdx
index e6703604596a..a3156560190d 100644
--- a/docs/3.0rc/resources/upgrade-prefect-3.mdx
+++ b/docs/3.0rc/resources/upgrade-prefect-3.mdx
@@ -333,4 +333,65 @@ print(my_flow()) # Output: Failed(message='Flow failed due ... | diff --git a/tests/public/flows/test_previously_awaited_methods.py b/tests/public/flows/test_previously_awaited_methods.py
index 854927ee1b46..997d3c6be1ac 100644
--- a/tests/public/flows/test_previously_awaited_methods.py
+++ b/tests/public/flows/test_previously_awaited_methods.py
@@ -1,60 +1,23 @@
-from prefect impor... | How to get original task return value from AsyncCompatProxy after using submit() in Prefect 3.
### Bug summary
I encountered an issue when using submit to trigger tasks in Prefect 3.0.0rc13. The result() method returns an object that appears to be a string, but its type is not str, which leads to a TypeError when tryi... | Thanks for the issue @zsio!
As you've discovered, 3.0 uses [`wrapt`](https://wrapt.readthedocs.io/en/master/index.html) to provide compatibility and warnings when using `await` with previously awaitable methods. I learned from the wrapt docs that there are some caveats when using their [`ObjectProxy` with primitive ... | 2024-08-02T19:53:52Z | 2024-08-05T15:19:26Z | [] | [] | ["tests/public/flows/test_previously_awaited_methods.py::test_awaiting_previously_async_task_methods_fail[map-args1]", "tests/public/flows/test_previously_awaited_methods.py::test_awaiting_previously_async_task_methods_fail[submit-args0]"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.1.0", "babel==2.15.0", "boto3==1.34.154", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14840 | 934982e5969c1fd7721c06bbbb12b651ea0f2409 | diff --git a/src/prefect/runner/storage.py b/src/prefect/runner/storage.py
index 426c7d2d5aeb..8a77b044482d 100644
--- a/src/prefect/runner/storage.py
+++ b/src/prefect/runner/storage.py
@@ -280,6 +280,10 @@ def to_pull_step(self) -> Dict:
"branch": self._branch,
}
}
+ if s... | diff --git a/tests/runner/test_storage.py b/tests/runner/test_storage.py
index ccde6a80be34..333761c69319 100644
--- a/tests/runner/test_storage.py
+++ b/tests/runner/test_storage.py
@@ -470,6 +470,21 @@ async def test_to_pull_step_with_block_credentials(self):
result = repo.to_pull_step()
ass... | GitRepository Submodule Clone Issue
### Bug summary
We are currently working with Prefect and encountered a bug related to the GitRepository class, specifically regarding the inclusion of submodules during the repository pull process. Our GitHub repository is structured in a way that it has one submodule (a reposito... | Hi @Punit-Solanki - thank you for the issue! Does your submodule have an `__init__.py` file in its root? If not, could you try adding it and see if that resolves it? What I'm wondering is whether this is a problem with the `git clone --recurse-submodules` or a problem with the import mechanics.
Hi @cicdw - Thank you fo... | 2024-08-04T21:37:48Z | 2024-08-05T14:13:57Z | ["tests/runner/test_storage.py::TestGitRepository::TestCredentialFormatting::test_git_clone_with_bitbucket_access_token[credentials1]", "tests/runner/test_storage.py::TestCreateStorageFromSource::test_create_git_storage[https://github.com/user/repo.git-GitRepository]", "tests/runner/test_storage.py::TestGitRepository::... | [] | ["tests/runner/test_storage.py::TestBlockStorageAdapter::test_eq_method_different_type", "tests/runner/test_storage.py::TestGitRepository::TestToPullStep::test_to_pull_step_with_submodules"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==24.1.0", "babel==2.15.0", "boto3==1.34.154", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14789 | b3c9a7129f9a406da68a98c231a0e28b64642de8 | diff --git a/src/prefect/concurrency/asyncio.py b/src/prefect/concurrency/asyncio.py
index d390607092ae..30ab7f0a4d34 100644
--- a/src/prefect/concurrency/asyncio.py
+++ b/src/prefect/concurrency/asyncio.py
@@ -62,7 +62,12 @@ async def main():
await resource_heavy()
```
"""
+ if not names:
+ ... | diff --git a/tests/concurrency/test_concurrency_asyncio.py b/tests/concurrency/test_concurrency_asyncio.py
index e3ce4f00b018..767e7ae65ffd 100644
--- a/tests/concurrency/test_concurrency_asyncio.py
+++ b/tests/concurrency/test_concurrency_asyncio.py
@@ -365,6 +365,33 @@ async def resource_heavy():
}
+@pytest.... | Global concurency utilities should return early if no limit names are given
### Describe the current behavior
Calling `concurrency()` with an empty list makes an API call that fails because no names were given.
### Describe the proposed behavior
The `concurrency` utility should return early if no limit names ... | 2024-07-29T23:24:22Z | 2024-07-30T15:56:48Z | ["tests/concurrency/test_concurrency_sync.py::test_rate_limit_emits_events", "tests/concurrency/test_concurrency_asyncio.py::test_concurrency_emits_events", "tests/concurrency/test_concurrency_asyncio.py::test_concurrency_creates_new_limits_if_requested", "tests/concurrency/test_concurrency_asyncio.py::test_concurrency... | [] | ["tests/concurrency/test_concurrency_asyncio.py::test_concurrency_without_limit_names[names0]", "tests/concurrency/test_concurrency_sync.py::test_concurrency_without_limit_names_sync[None]", "tests/concurrency/test_concurrency_asyncio.py::test_rate_limit_without_limit_names[names0]", "tests/concurrency/test_concurrency... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==23.2.0", "babel==2.15.0", "boto3==1.34.151", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval | |
PrefectHQ/prefect | PrefectHQ__prefect-14771 | 717dcffc6fb73de431b52a8bd2e3770a05c98ffe | diff --git a/src/prefect/blocks/notifications.py b/src/prefect/blocks/notifications.py
index 58b984106df8..debd2fab7fb3 100644
--- a/src/prefect/blocks/notifications.py
+++ b/src/prefect/blocks/notifications.py
@@ -129,14 +129,37 @@ class MicrosoftTeamsWebhook(AppriseNotificationBlock):
_documentation_url = "https... | diff --git a/tests/blocks/test_notifications.py b/tests/blocks/test_notifications.py
index 3ac124f97e63..e90bacaecbe1 100644
--- a/tests/blocks/test_notifications.py
+++ b/tests/blocks/test_notifications.py
@@ -12,6 +12,7 @@
CustomWebhookNotificationBlock,
DiscordWebhook,
MattermostWebhook,
+ Microsof... | Prefect Teams Notification Block Broken Due to Transition to 'Workflows'
### First check
- [x] I used the GitHub search to find a similar issue and didn't find it.
- [x] I added a descriptive title to this issue.
- [x] I searched the Prefect documentation for this issue.
- [x] I checked that this issue is related to P... | Another vote for this. As a workaround I've been able to get flow run notifications working again via Workflows with the following steps:
1. Create a workflow in Teams using [this template](https://make.powerautomate.com/environments/Default-34d75f81-2748-425c-b290-d6c44ff6c053/galleries/public/templates/d271a6f01c254... | 2024-07-26T16:33:33Z | 2024-07-27T16:36:05Z | ["tests/blocks/test_notifications.py::TestCustomWebhook::test_user_agent_override", "tests/blocks/test_notifications.py::TestPagerDutyWebhook::test_notify_sync", "tests/blocks/test_notifications.py::TestCustomWebhook::test_timeout_override", "tests/blocks/test_notifications.py::TestAppriseNotificationBlock::test_notify... | [] | ["tests/blocks/test_notifications.py::TestMicrosoftTeamsWebhook::test_notify_async", "tests/blocks/test_notifications.py::TestMicrosoftTeamsWebhook::test_notify_sync", "tests/blocks/test_notifications.py::TestMicrosoftTeamsWebhook::test_is_picklable"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.1", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==23.2.0", "babel==2.15.0", "boto3==1.34.149", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14746 | e430486c3521676f5e491aab654ec1f58447d538 | diff --git a/src/prefect/task_engine.py b/src/prefect/task_engine.py
index 70c4718e687f..01bb93b6f573 100644
--- a/src/prefect/task_engine.py
+++ b/src/prefect/task_engine.py
@@ -126,8 +126,7 @@ def state(self) -> State:
raise ValueError("Task run is not set")
return self.task_run.state
- @pr... | diff --git a/tests/test_task_engine.py b/tests/test_task_engine.py
index c69bf8b8a7e2..1e003eaac834 100644
--- a/tests/test_task_engine.py
+++ b/tests/test_task_engine.py
@@ -935,6 +935,92 @@ async def test_flow():
"Completed",
]
+ async def test_task_passes_failed_state_to_retry_fn(self):
+ ... | @task(retry_condition_fn=...) unable to catch Exceptions (3.0rc11)
### Bug summary
I'm following the tutorial here on [the prefect 3.0rc docs regarding custom retry behavior](https://docs-3.prefect.io/3.0rc/develop/write-tasks#custom-retry-behavior), and wish to add a custom retry_condition_fn for my task. I'd like to... | It seems that another use has encountered this problem as reported in the [Slack #marvin-in-the-wild thread](https://prefect-community.slack.com/archives/C03D12TE9HQ/p1717750633885309).
Thanks for the thorough issue writeup @jameswu1991 ! I'll give this a look and let you know what I uncover - in the meantime I have a ... | 2024-07-24T21:22:15Z | 2024-07-24T21:38:23Z | ["tests/test_task_engine.py::TestRunTask::test_run_task_with_client_provided_uuid[True]", "tests/test_task_engine.py::TestTaskTimeTracking::test_sync_task_sets_start_time_on_running[False]", "tests/test_task_engine.py::TestTaskRunsAsync::test_with_kwargs[False]", "tests/test_task_engine.py::TestTaskRetries::test_async_... | [] | ["tests/test_task_engine.py::TestTaskRetries::test_task_passes_failed_state_to_retry_fn_sync[False]", "tests/test_task_engine.py::TestTaskRetries::test_task_passes_failed_state_to_retry_fn[True]", "tests/test_task_engine.py::TestTaskRetries::test_task_passes_failed_state_to_retry_fn_sync[True]", "tests/test_task_engine... | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==23.2.0", "babel==2.15.0", "boto3==1.34.148", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
PrefectHQ/prefect | PrefectHQ__prefect-14718 | b0231f1c75de1a0f3ff9fef02ad8b9913123bef9 | diff --git a/docs/3.0rc/api-ref/rest-api/server/schema.json b/docs/3.0rc/api-ref/rest-api/server/schema.json
index 9a0a745ca51a..855c4413560f 100644
--- a/docs/3.0rc/api-ref/rest-api/server/schema.json
+++ b/docs/3.0rc/api-ref/rest-api/server/schema.json
@@ -15990,6 +15990,18 @@
"type": "object... | diff --git a/tests/server/orchestration/api/test_deployments.py b/tests/server/orchestration/api/test_deployments.py
index 854ed60faa14..82fafa1b5068 100644
--- a/tests/server/orchestration/api/test_deployments.py
+++ b/tests/server/orchestration/api/test_deployments.py
@@ -2843,6 +2843,29 @@ async def test_create_flow... | Ability to skip parameter validation when creating flow run from deployment
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar request and didn't find it.
- [X] I searched the Prefect documentation for this feature.
### Prefect Version
2.x
### Describe ... | Thanks for submitting this @jbnitorum! We'll think about how to best support this.
Why not use a tag for this? Parameters aren't really intended to be used for metadata in this way. If you want your flows to take generic parameters you may also be able to use `**kwargs` — we could probably expand support for that if it... | 2024-07-23T18:35:55Z | 2024-07-23T20:53:59Z | ["tests/server/orchestration/api/test_deployments.py::TestReadDeployments::test_read_deployments_sort", "tests/server/orchestration/api/test_deployments.py::TestCreateFlowRunFromDeployment::test_create_flow_run_basic_parameters", "tests/server/orchestration/api/test_deployments.py::TestSetScheduleActive::test_set_sched... | [] | ["tests/server/orchestration/api/test_deployments.py::TestCreateFlowRunFromDeployment::test_create_flow_run_respects_per_run_validation_flag", "tests/server/orchestration/api/test_deployments.py::TestGetDeploymentWorkQueueCheck::test_well_formed_response"] | [] | {"install": ["uv pip install -e ."], "pre_install": [], "python": "3.12", "pip_packages": ["aiosqlite==0.20.0", "alembic==1.13.2", "annotated-types==0.7.0", "anyio==4.4.0", "apprise==1.8.0", "asgi-lifespan==2.1.0", "asttokens==2.4.1", "asyncpg==0.29.0", "attrs==23.2.0", "babel==2.15.0", "boto3==1.34.147", "botocore==1.... | pytest --tb=no -rA -p no:cacheprovider | null | null | null | swa-bench:sw.eval |
mitmproxy/mitmproxy | mitmproxy__mitmproxy-7066 | b08acf4ab8d51405563123793e644c0c2aa52c6e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c33b602f45..13ed1a16c6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,8 @@
## Unreleased: mitmproxy next
+- Fix a crash on startup when mitmproxy is unable to determine the OS' DNS servers
+ ([#7066](https://github.com/mitmproxy/mitmproxy/pull/7066), @errorx... | diff --git a/test/mitmproxy/addons/test_dns_resolver.py b/test/mitmproxy/addons/test_dns_resolver.py
index 97cc9d7276..6786868e7d 100644
--- a/test/mitmproxy/addons/test_dns_resolver.py
+++ b/test/mitmproxy/addons/test_dns_resolver.py
@@ -1,6 +1,7 @@
import socket
import mitmproxy_rs
+import pytest
from mitmprox... | 【10.4.1】 mitm start failed: failed to get dns servers
#### Problem Description
After upgrading to 10.4.1 from 10.3.1, the mitm program could not be loaded.
#### Steps to reproduce the behavior:
1. **pipx** --upgrade mitmproxy
2. start mitmproxy
3.
#### System Information
Paste the output of "mitmproxy --v... | Which OS are you on?
`
(base) root@ttg-virtual-machine:~# uname -a
Linux ttg-virtual-machine 5.4.0-181-generic #201-Ubuntu SMP Thu Mar 28 15:39:01 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
`
When I downgraded the app version to 10.3.1, everything went back to normal.
> Which OS are you on?
Ubuntu 20.04.6 LTS
Thanks... | 2024-08-01T16:10:17Z | 2024-08-01T19:54:16Z | [] | [] | ["test/mitmproxy/addons/test_dns_resolver.py::test_ignores_reverse_mode", "test/mitmproxy/addons/test_dns_resolver.py::test_resolver", "test/mitmproxy/addons/test_dns_resolver.py::test_dns_request"] | [] | {"install": ["uv pip install -e ."], "pre_install": ["tee pyproject.toml <<EOF_1234810234\n[project]\nname = \"mitmproxy\"\ndescription = \"An interactive, SSL/TLS-capable intercepting proxy for HTTP/1, HTTP/2, and WebSockets.\"\nreadme = \"README.md\"\nrequires-python = \">=3.10\"\nlicense = {file=\"LICENSE\"}\nauthor... | tox -e py -- | null | null | null | swa-bench:sw.eval |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.