repo string | pull_number int64 | instance_id string | issue_numbers list | base_commit string | patch string | test_patch string | problem_statement string | hints_text string | created_at timestamp[ns, tz=UTC] | version float64 |
|---|---|---|---|---|---|---|---|---|---|---|
apollographql/apollo-client | 8,372 | apollographql__apollo-client-8372 | [
"8370"
] | 175321b1aedbd21daa82f93ddddadfbd4fcaeb37 | diff --git a/src/cache/inmemory/writeToStore.ts b/src/cache/inmemory/writeToStore.ts
--- a/src/cache/inmemory/writeToStore.ts
+++ b/src/cache/inmemory/writeToStore.ts
@@ -1,4 +1,4 @@
-import { SelectionSetNode, FieldNode } from 'graphql';
+import { SelectionSetNode, FieldNode, SelectionNode } from 'graphql';
import { ... | diff --git a/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap b/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap
--- a/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap
+++ b/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap
@@ -34,6 +34,70 @@ Object {
}
`;
... | Cache does not merge fragments correctly
**Intended outcome:**
Complex fragment merges work as though they were all specified in a single large query
**Actual outcome:**
Fragment merges can result in the cache dropping fields, which ends up returning an empty value from useQuery when ``returnPartialData`` is off, ... | 2021-06-11T22:38:24Z | 3.4 | |
apollographql/apollo-client | 7,581 | apollographql__apollo-client-7581 | [
"7509"
] | 00284d20f8038367dbb9b63790f2aaad0389813e | diff --git a/src/react/hooks/useReactiveVar.ts b/src/react/hooks/useReactiveVar.ts
--- a/src/react/hooks/useReactiveVar.ts
+++ b/src/react/hooks/useReactiveVar.ts
@@ -5,11 +5,18 @@ export function useReactiveVar<T>(rv: ReactiveVar<T>): T {
const value = rv();
// We don't actually care what useState thinks the val... | diff --git a/src/react/hooks/__tests__/useReactiveVar.test.tsx b/src/react/hooks/__tests__/useReactiveVar.test.tsx
--- a/src/react/hooks/__tests__/useReactiveVar.test.tsx
+++ b/src/react/hooks/__tests__/useReactiveVar.test.tsx
@@ -1,4 +1,4 @@
-import React from "react";
+import React, { useEffect } from "react";
impor... | When React.StrictMode wraps ApolloProvider or is in the same component as ApolloProvider. Using useEffect with async await and reactive variables will not work.
**Intended outcome:**
For [example](https://codesandbox.io/s/wispy-cherry-e1t9d?file=/src/index.js), click good button, the console output look like this.
... | 2021-01-14T17:55:22Z | 3.3 | |
apollographql/apollo-client | 7,657 | apollographql__apollo-client-7657 | [
"7593"
] | 541d333c524c0d1384e1d51c81d1c5cf668ac2e8 | diff --git a/src/cache/inmemory/inMemoryCache.ts b/src/cache/inmemory/inMemoryCache.ts
--- a/src/cache/inmemory/inMemoryCache.ts
+++ b/src/cache/inmemory/inMemoryCache.ts
@@ -20,7 +20,7 @@ import {
import { StoreReader } from './readFromStore';
import { StoreWriter } from './writeToStore';
import { EntityStore, supp... | diff --git a/src/cache/inmemory/__tests__/cache.ts b/src/cache/inmemory/__tests__/cache.ts
--- a/src/cache/inmemory/__tests__/cache.ts
+++ b/src/cache/inmemory/__tests__/cache.ts
@@ -2658,6 +2658,104 @@ describe("ReactiveVar and makeVar", () => {
expect(spy).toBeCalledWith(cache);
});
+ it("should recall for... | Reactive vars stop broadcasting changes to cache when query became inactive and active again (e.g. via navigation)
**Intended outcome:**
Changes made to local state managed with reactive variables should trigger update on every active query that depends on that variable. No matter if that was previously deactivated.
... | @WojciechKulpa Thanks for the reproduction. I'll take a look at this soon (this week).
Any updates on this? We are facing the same issue and are looking forward to a fix for that! :)
@benjamn Cool if I re-assign this to myself? There's another issue related to reactive vars (#7609) that I'm going to look into, so might... | 2021-02-04T23:28:02Z | 3.3 |
apollographql/apollo-client | 7,146 | apollographql__apollo-client-7146 | [
"7145",
"6154"
] | 92094fa18edf52ce1c63e57e39c4e64fda150132 | diff --git a/src/core/ObservableQuery.ts b/src/core/ObservableQuery.ts
--- a/src/core/ObservableQuery.ts
+++ b/src/core/ObservableQuery.ts
@@ -620,6 +620,10 @@ once, rather than every time you call fetchMore.`);
},
};
+ public hasObservers() {
+ return this.observers.size > 0;
+ }
+
private tearDownQu... | diff --git a/src/core/__tests__/QueryManager/index.ts b/src/core/__tests__/QueryManager/index.ts
--- a/src/core/__tests__/QueryManager/index.ts
+++ b/src/core/__tests__/QueryManager/index.ts
@@ -3506,9 +3506,18 @@ describe('QueryManager', () => {
}
}
`;
-
- const queryManager = mockQuery... | `resetStore` fetches `watchQuery` that has never been subscribed to
**Intended outcome:**
Calling ApolloClient.resetStore() should not execute queries that are not actively subscribed to.
**Actual outcome:**
Calling ApolloClient.resetStore() causes a `watchQuery` that has been assigned to a variable but _never sub... |
This is affecting me as well, I arrived at the same conclusion as op, reFetchObservableQueries is not respecting the skip options.
[The official guide here](https://www.apollographql.com/docs/react/v3.0-beta/networking/authentication/#reset-store-on-logout) recommends calling `client.resetStore()` on user logout, b... | 2020-10-10T22:22:54Z | 3.2 |
apollographql/apollo-client | 7,075 | apollographql__apollo-client-7075 | [
"7071"
] | 91299ccb5ce089e2a358dc983f342944a4974035 | diff --git a/src/cache/inmemory/writeToStore.ts b/src/cache/inmemory/writeToStore.ts
--- a/src/cache/inmemory/writeToStore.ts
+++ b/src/cache/inmemory/writeToStore.ts
@@ -284,6 +284,15 @@ export class StoreWriter {
}
if (process.env.NODE_ENV !== "production") {
+ const hasSelectionSet = (storeFie... | diff --git a/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap b/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap
--- a/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap
+++ b/src/cache/inmemory/__tests__/__snapshots__/writeToStore.ts.snap
@@ -1,5 +1,39 @@
// Jest Snapshot v1... | Merge warnings reported for JSONObject custom scalar
**Intended outcome:**
My understanding is that all scalar values (custom or otherwise) should be treated opaquely and replaced when updating. Such updates should not trigger a data loss merge warning.
**Actual outcome:**
When merging objects containing fields of... | 2020-09-25T17:18:16Z | 3.3 | |
apollographql/apollo-client | 7,055 | apollographql__apollo-client-7055 | [
"7040"
] | 8d77510e1eee197442c4c56410c2a5d8d00b9eda | diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts
--- a/src/core/QueryManager.ts
+++ b/src/core/QueryManager.ts
@@ -972,7 +972,8 @@ export class QueryManager<TStore> {
if (process.env.NODE_ENV !== 'production' &&
isNonEmptyArray(diff.missing) &&
- !equal(data, {})) {
+ ... | diff --git a/src/core/__tests__/QueryManager/index.ts b/src/core/__tests__/QueryManager/index.ts
--- a/src/core/__tests__/QueryManager/index.ts
+++ b/src/core/__tests__/QueryManager/index.ts
@@ -5228,5 +5228,107 @@ describe('QueryManager', () => {
expect(queryManager['inFlightLinkObservables'].size).toBe(0)
... | returnPartialData usage leads to "Missing cache result fields" warning
We are upgrading from 2.x to 3.2.0. Everything is upgraded and working as expected but in a few situations we have query pattern where we...
1. Load a list of a given type in a list view
2. have a detail view that loads single records from the l... | @andykent Totally agree with this! We'll get this fixed soon, but for now I can assure you these are indeed just warnings, so you don't need to do anything about them. Sorry for the annoyance.
@benjamn Great news, thanks for the confirmation. | 2020-09-22T19:30:12Z | 3.2 |
apollographql/apollo-client | 6,587 | apollographql__apollo-client-6587 | [
"5877"
] | 0c0821f425b93a21b38704f624e1e5df846e4d03 | diff --git a/src/react/data/QueryData.ts b/src/react/data/QueryData.ts
--- a/src/react/data/QueryData.ts
+++ b/src/react/data/QueryData.ts
@@ -279,18 +279,6 @@ export class QueryData<TData, TVariables> extends OperationData {
return;
}
- // If we skipped previously, `previousResult.data` is... | diff --git a/src/react/hooks/__tests__/useQuery.test.tsx b/src/react/hooks/__tests__/useQuery.test.tsx
--- a/src/react/hooks/__tests__/useQuery.test.tsx
+++ b/src/react/hooks/__tests__/useQuery.test.tsx
@@ -2069,4 +2069,45 @@ describe('useQuery Hook', () => {
}).then(resolve, reject);
});
});
+
+ descri... | [3.0-beta] Changing skip to true on a hook ignores results from "fast" data sources
In a situation where:
- we use a hook with `skip: true`
- we switch the `skip` to false
- the link responds without a delay (it may be a Promise, but it cannot use `setTimeout`) - like a caching mechanism, mock, etc.
**Intended ou... | 2020-07-13T13:46:55Z | 3 | |
apollographql/apollo-client | 6,710 | apollographql__apollo-client-6710 | [
"6659",
"6659"
] | cabe6bb6b056e554f1209ca7ba2199f49be18060 | diff --git a/src/core/ObservableQuery.ts b/src/core/ObservableQuery.ts
--- a/src/core/ObservableQuery.ts
+++ b/src/core/ObservableQuery.ts
@@ -18,15 +18,9 @@ import {
WatchQueryOptions,
FetchMoreQueryOptions,
SubscribeToMoreOptions,
- ErrorPolicy,
} from './watchQueryOptions';
-import { QueryStoreValue } fro... | diff --git a/src/core/__tests__/ObservableQuery.ts b/src/core/__tests__/ObservableQuery.ts
--- a/src/core/__tests__/ObservableQuery.ts
+++ b/src/core/__tests__/ObservableQuery.ts
@@ -1176,6 +1176,7 @@ describe('ObservableQuery', () => {
},
loading: true,
networkStatus: Netwo... | v3.0: loading: true for first render always, even if all data is available in cache
<!--
Thanks for filing an issue on Apollo Client!
Please make sure that you include the following information to ensure that your issue is actionable.
If you don't follow the template, your issue may end up being closed wit... | 2020-07-27T17:17:33Z | 3.1 | |
apollographql/apollo-client | 6,589 | apollographql__apollo-client-6589 | [
"6122"
] | b5407a3a7a0b92cde72de31253f1da78da430ddf | diff --git a/src/react/data/QueryData.ts b/src/react/data/QueryData.ts
--- a/src/react/data/QueryData.ts
+++ b/src/react/data/QueryData.ts
@@ -412,7 +412,13 @@ export class QueryData<TData, TVariables> extends OperationData {
const { data, loading, error } = this.previousData.result;
if (!loading) {
- ... | diff --git a/src/react/hooks/__tests__/useQuery.test.tsx b/src/react/hooks/__tests__/useQuery.test.tsx
--- a/src/react/hooks/__tests__/useQuery.test.tsx
+++ b/src/react/hooks/__tests__/useQuery.test.tsx
@@ -1798,6 +1798,27 @@ describe('useQuery Hook', () => {
expect(renderCount).toBe(3);
}).then(resolve... | Function in onCompleted fires when skip is true
Hi all, I'm experiencing the same issue as reported here by @xiaoyu-tamu:
https://github.com/apollographql/react-apollo/issues/3814
I believe it was reported in the wrong place (under the old react-apollo repo), so I am reposting here for visibility.
**Intended out... | Yeah, can verify it's still happening on 3.0.0-beta.31
Hi, I am also experiencing this issue.
**Versions**
apollo-client: 2.6.8
@apollo/react-hooks: 3.1.5
Same here with @apollo/react-hooks 3.1.5
It is still in `@apollo/client` 3.0.0-beta.44 | 2020-07-14T00:57:26Z | 3 |
apollographql/apollo-client | 6,691 | apollographql__apollo-client-6691 | [
"6685"
] | 7989d5e98bd8b07c60c7f731abcc34e8636ef1fc | diff --git a/src/cache/inmemory/policies.ts b/src/cache/inmemory/policies.ts
--- a/src/cache/inmemory/policies.ts
+++ b/src/cache/inmemory/policies.ts
@@ -198,12 +198,13 @@ export const defaultDataIdFromObject = (
_id !== void 0 ? { _id } :
void 0;
}
- const idValue = id || _id;
- if (idVal... | diff --git a/src/cache/inmemory/__tests__/__snapshots__/policies.ts.snap b/src/cache/inmemory/__tests__/__snapshots__/policies.ts.snap
--- a/src/cache/inmemory/__tests__/__snapshots__/policies.ts.snap
+++ b/src/cache/inmemory/__tests__/__snapshots__/policies.ts.snap
@@ -1,5 +1,55 @@
// Jest Snapshot v1, https://goo.gl... | A __typename of Query leads to incorrect caching
<!--
Thanks for filing an issue on Apollo Client!
Please make sure that you include the following information to ensure that your issue is actionable.
If you don't follow the template, your issue may end up being closed without anyone looking at it carefully... | 2020-07-23T23:48:04Z | 3.1 | |
apollographql/apollo-client | 6,448 | apollographql__apollo-client-6448 | [
"6307",
"6444"
] | 67796e597baf20aac0ac7a6bd4345e9f1bb84662 | diff --git a/src/core/QueryInfo.ts b/src/core/QueryInfo.ts
--- a/src/core/QueryInfo.ts
+++ b/src/core/QueryInfo.ts
@@ -165,7 +165,10 @@ export class QueryInfo {
this.variables =
this.networkStatus =
this.networkError =
- this.graphQLErrors = void 0;
+ this.graphQLErrors =
+ this.lastWatch =
+ ... | diff --git a/src/core/__tests__/QueryManager/index.ts b/src/core/__tests__/QueryManager/index.ts
--- a/src/core/__tests__/QueryManager/index.ts
+++ b/src/core/__tests__/QueryManager/index.ts
@@ -36,6 +36,7 @@ import observableToPromise, {
import subscribeAndCount from '../../../utilities/testing/subscribeAndCount';
i... | Fetching data again and again if more queries without id executed
The problem started after upgrading from beta 45 to beta 48 and is related to missing `id` in queries.
**Intended outcome:**
I have two components, displaying a list of items, each has its own query. The queries are very similar and differ only in q... | Ran into the same issue. I've narrowed it down to being introduced in `v3.0.0-beta.46`.
@vhenzl Can you try this?
```ts
new InMemoryCache({
typePolicies: {
// Assuming the __typename for the viewer object is "Viewer":
Viewer: {
// This means the Viewer object is a singleton whose identity
... | 2020-06-16T17:01:37Z | 3 |
apollographql/apollo-client | 6,353 | apollographql__apollo-client-6353 | [
"6305"
] | 75caa44265a540eaef844fdff41a3c4075842d97 | diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts
--- a/src/core/QueryManager.ts
+++ b/src/core/QueryManager.ts
@@ -836,6 +836,24 @@ export class QueryManager<TStore> {
context = {},
} = options;
+ if (fetchPolicy === "cache-and-network" ||
+ fetchPolicy === "network-only") {
+ ... | diff --git a/src/core/__tests__/ObservableQuery.ts b/src/core/__tests__/ObservableQuery.ts
--- a/src/core/__tests__/ObservableQuery.ts
+++ b/src/core/__tests__/ObservableQuery.ts
@@ -933,15 +933,29 @@ describe('ObservableQuery', () => {
});
describe('refetch', () => {
- type TFQO = QueryManager<any>["fetchQu... | Cache-and-network should not make a network call when watched cached items change via subscription/mutation
*This is new behavior as of beta .46 and has prevented us from moving past .45 (most likely a result of https://github.com/apollographql/apollo-client/pull/6221).*
**Intended outcome:**
A query with `fetchPol... | The problem also occurs with the `"network-only"` fetch policy. Whenever the cache is updated (either manually or by a mutation), the query is refetched. | 2020-05-28T23:57:44Z | 3 |
apollographql/apollo-client | 5,116 | apollographql__apollo-client-5116 | [
"5733",
"5733"
] | 854b1c4c86326d5873c27edb3a897ef1f7f72f44 | diff --git a/config/dangerfile.ts b/config/dangerfile.ts
deleted file mode 100644
--- a/config/dangerfile.ts
+++ /dev/null
@@ -1,120 +0,0 @@
-const { includes } = require('lodash');
-const fs = require('fs');
-
-// Setup
-const github = danger.github;
-const pr = github.pr;
-const commits = github.commits;
-const modif... | diff --git a/docs/source/development-testing/testing.mdx b/docs/source/development-testing/testing.mdx
--- a/docs/source/development-testing/testing.mdx
+++ b/docs/source/development-testing/testing.mdx
@@ -1,21 +1,21 @@
---
title: Testing React components
-description: Have peace of mind when using React Apollo in p... | v3.0.0-beta.16 mutating local state is not reflected in all components with useQuery
**Intended outcome:**
Store local state in apollo cache and when updating the local state then all components that have a useQuery against that data will be updated.
**Actual outcome:**
It appears only the first subscriber to the ... | 2019-08-01T15:31:55Z | 2.6 | |
apollographql/apollo-client | 4,765 | apollographql__apollo-client-4765 | [
"3660",
"3660"
] | a87d28b44f2d4d4320a08d74daddb905b600aa10 | diff --git a/packages/apollo-client/src/data/queries.ts b/packages/apollo-client/src/data/queries.ts
--- a/packages/apollo-client/src/data/queries.ts
+++ b/packages/apollo-client/src/data/queries.ts
@@ -151,13 +151,14 @@ export class QueryStore {
}
public markQueryResultClient(queryId: string, complete: boolean... | diff --git a/packages/apollo-client/src/core/__tests__/fetchPolicies.ts b/packages/apollo-client/src/core/__tests__/fetchPolicies.ts
--- a/packages/apollo-client/src/core/__tests__/fetchPolicies.ts
+++ b/packages/apollo-client/src/core/__tests__/fetchPolicies.ts
@@ -21,6 +21,7 @@ import subscribeAndCount from '../../ut... | FetchPolicy `cache-and-network` always uses networkStatus = 1 regardless of cache hit
<!--
Thanks for filing an issue on Apollo Client!
Please make sure that you include the following information to ensure that your issue is actionable.
If you don't follow the template, your issue may end up being closed w... | This is quite similar to an [issue I raised a while ago](https://github.com/apollographql/react-apollo/issues/447) - I actually [wrote a PR](https://github.com/apollographql/apollo-client/pull/1607) to address this, but it got lost in 2.0 limbo. It's definitely important to solve!
For anyone dealing with this PITA bug,... | 2019-04-30T17:39:25Z | 0.4 |
apollographql/apollo-client | 3,956 | apollographql__apollo-client-3956 | [
"3947"
] | b082c8b23e791cfdca0fc0680a33ec542beb0a68 | diff --git a/packages/apollo-client/src/core/QueryManager.ts b/packages/apollo-client/src/core/QueryManager.ts
--- a/packages/apollo-client/src/core/QueryManager.ts
+++ b/packages/apollo-client/src/core/QueryManager.ts
@@ -996,7 +996,7 @@ export class QueryManager<TStore> {
const lastResult = observableQuery.getLa... | diff --git a/packages/apollo-client/src/core/__tests__/QueryManager/index.ts b/packages/apollo-client/src/core/__tests__/QueryManager/index.ts
--- a/packages/apollo-client/src/core/__tests__/QueryManager/index.ts
+++ b/packages/apollo-client/src/core/__tests__/QueryManager/index.ts
@@ -2336,6 +2336,87 @@ describe('Quer... | [QueryManager] getCurrentQueryResult behavior appears inconsistent
From what I can tell the return value of `getCurrentQueryResult` is inconsistent.
This is a bit tricky to explain, so I've annotated the method below in a vein attempt to convey what I believe I'm observing.
```javascript
// Copied from QueryM... | I hope what I've provided is clear; happy to provide more details or help patch. | 2018-09-27T18:33:46Z | 1.3 |
apollographql/apollo-client | 3,580 | apollographql__apollo-client-3580 | [
"3576"
] | e0ba90671e241184f12ce86370e0e3d84bc73552 | diff --git a/packages/apollo-client/src/__mocks__/mockLinks.ts b/packages/apollo-client/src/__mocks__/mockLinks.ts
--- a/packages/apollo-client/src/__mocks__/mockLinks.ts
+++ b/packages/apollo-client/src/__mocks__/mockLinks.ts
@@ -8,11 +8,15 @@ import {
import { print } from 'graphql/language/printer';
+interface ... | diff --git a/packages/apollo-client/src/core/__tests__/QueryManager/index.ts b/packages/apollo-client/src/core/__tests__/QueryManager/index.ts
--- a/packages/apollo-client/src/core/__tests__/QueryManager/index.ts
+++ b/packages/apollo-client/src/core/__tests__/QueryManager/index.ts
@@ -4362,6 +4362,85 @@ describe('Quer... | Mutation component ignores context headers for refetchQueries
**Intended outcome:**
Queries specified as string array to the `refetchQueries` option of a mutation call should have headers included as specified by the `context` prop of the `Mutation` component.
**Actual outcome:**
The mutation uses the auth headers... | Confirmed 🐛 - thanks for reporting this @jonaskello!
If anyone is interested in helping out with this, the following just needs to be updated to add the `mutate` functions passed in `context` param:
https://github.com/apollographql/apollo-client/blob/ef32c3250e51f55c328fef5e3e45d59397d92206/packages/apollo-clien... | 2018-06-13T14:45:17Z | 0.1 |
apollographql/apollo-client | 2,710 | apollographql__apollo-client-2710 | [
"2709"
] | b1e389560d32c01bcb680514fc7f5dd8d94f2646 | diff --git a/packages/apollo-utilities/src/storeUtils.ts b/packages/apollo-utilities/src/storeUtils.ts
--- a/packages/apollo-utilities/src/storeUtils.ts
+++ b/packages/apollo-utilities/src/storeUtils.ts
@@ -164,6 +164,8 @@ export type Directives = {
};
};
+const KNOWN_DIRECTIVES: string[] = ['connection', 'includ... | diff --git a/packages/apollo-cache-inmemory/src/__tests__/readFromStore.ts b/packages/apollo-cache-inmemory/src/__tests__/readFromStore.ts
--- a/packages/apollo-cache-inmemory/src/__tests__/readFromStore.ts
+++ b/packages/apollo-cache-inmemory/src/__tests__/readFromStore.ts
@@ -165,6 +165,38 @@ describe('reading from t... | Support custom directives in InMemory Cache
**Intended outcome:**
I would like to add custom directive support to "apollo-cache-inmemory". More precisely fix it to prevent corrupted cache.
If you are not familiar with custom directives you can checkout my new module: [graphql-directive](https://github.com/smooth-co... | 2017-12-10T22:19:56Z | 1.1 | |
apollographql/apollo-client | 2,362 | apollographql__apollo-client-2362 | [
"2293"
] | 7aa8cff98ea0428e8736e7b87662000f128beb57 | diff --git a/packages/apollo-cache-inmemory/src/fragmentMatcher.ts b/packages/apollo-cache-inmemory/src/fragmentMatcher.ts
--- a/packages/apollo-cache-inmemory/src/fragmentMatcher.ts
+++ b/packages/apollo-cache-inmemory/src/fragmentMatcher.ts
@@ -30,7 +30,7 @@ export class HeuristicFragmentMatcher implements FragmentMa... | diff --git a/packages/apollo-cache-inmemory/src/__tests__/diffAgainstStore.ts b/packages/apollo-cache-inmemory/src/__tests__/diffAgainstStore.ts
--- a/packages/apollo-cache-inmemory/src/__tests__/diffAgainstStore.ts
+++ b/packages/apollo-cache-inmemory/src/__tests__/diffAgainstStore.ts
@@ -95,7 +95,7 @@ describe('diffi... | Proposal: opening up the cache-inmemory implementation [apollo-client@2.0]
Hi apollo-client devs! Such an _amazing_ job with the 2.0 release so far, kudos. 💥
We've decided to port our setup over to Apollo 💛, but our needs are such that we want to integrate it with our custom `Observable` cache for storing the nor... | I'm all for this! The external API provided by Apollo Cache should be able to stay the same and the internals change as needed! Let's try it out!
@niieani @jbaxleyiii If we would abstract data's setter and getter it would be super easy to use normalized cache in `@ngrx/store` :ng: :+1: .
I forked Apollo's `InMemoryCa... | 2017-10-20T17:56:43Z | 1 |
apollographql/apollo-client | 2,345 | apollographql__apollo-client-2345 | [
"2309"
] | 4de051188d04351816e4034b2d75238e1ecdb783 | diff --git a/packages/apollo-cache/src/cache.ts b/packages/apollo-cache/src/cache.ts
--- a/packages/apollo-cache/src/cache.ts
+++ b/packages/apollo-cache/src/cache.ts
@@ -48,6 +48,10 @@ export abstract class ApolloCache<TSerialized> implements DataProxy {
public transformDocument(document: DocumentNode): DocumentNod... | diff --git a/packages/apollo-client/src/core/__tests__/ObservableQuery.ts b/packages/apollo-client/src/core/__tests__/ObservableQuery.ts
--- a/packages/apollo-client/src/core/__tests__/ObservableQuery.ts
+++ b/packages/apollo-client/src/core/__tests__/ObservableQuery.ts
@@ -783,6 +783,69 @@ describe('ObservableQuery', ... | Enable cache implementations to modify document before transmission to links
Per a Slack conversation with @jbaxleyiii.
As cache implementations become more sophisticated, it will be helpful to allow end users to signal cache-specific behaviors via directives in the GraphQL document. (A simple, popular example would... | 2017-10-19T23:46:30Z | 0.2 | |
apollographql/apollo-client | 1,801 | apollographql__apollo-client-1801 | [
"1779",
"1779"
] | 1fd04704958bc126c0c5a373d2a6f123aba64de1 | diff --git a/src/ApolloClient.ts b/src/ApolloClient.ts
--- a/src/ApolloClient.ts
+++ b/src/ApolloClient.ts
@@ -65,7 +65,7 @@ import {
} from './core/watchQueryOptions';
import {
- storeKeyNameFromFieldNameAndArgs,
+ getStoreKeyName,
} from './data/storeUtils';
import {
@@ -222,7 +222,7 @@ export default class... | diff --git a/test/client.ts b/test/client.ts
--- a/test/client.ts
+++ b/test/client.ts
@@ -2554,8 +2554,137 @@ describe('client', () => {
return withWarning(() => client.query({ query }), /Missing field description/);
});
+
+ it('runs a query with the connection directive and writes it to the store key defin... | Adjusting the store in order to squash pagination results via Relay's @connection directive.
I am using the Relay convention for pagination as described [here](http://dev.apollodata.com/react/pagination.html#relay-cursors). Coming from Relay Modern, there is a directive called `@connection`. It contains a key which Rel... | You won't need to worry about that provided you are using fetchMore -> updateQuery to update your cursor or in your case first/after. The query will get stored in redux with the new key name based on the variables, but the data will flow down to the original query. That said, the readQuery/writeQuery is the spot that... | 2017-06-16T21:57:42Z | 1.3 |
apollographql/apollo-client | 1,664 | apollographql__apollo-client-1664 | [
"1334"
] | 8f362ae8f1f8026adf287dacc93b3ba42b57d259 | diff --git a/src/ApolloClient.ts b/src/ApolloClient.ts
--- a/src/ApolloClient.ts
+++ b/src/ApolloClient.ts
@@ -136,6 +136,7 @@ export default class ApolloClient implements DataProxy {
private devToolsHookCb: Function;
private proxy: DataProxy | undefined;
private fragmentMatcher: FragmentMatcherInterface;
+ p... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -1711,6 +1711,7 @@ describe('QueryManager', () => {
});
describe('polling queries', () => {
+
it('allows you to poll queries', () => {
const query = gql`
query fetchLuke($id: St... | Unhandled promise rejection when error in polling query on SSR
**How to reproduce the issue:**
1. Setup SSR
2. Setup query polling:
```js
export default graphql('query Samples { ... }', {
options: {
pollInterval: 5000,
forceFetch: true,
notifyOnNetworkStatusChange: true
}
})(... | The only "fix" for this I've came up is to turn off polling on SSR:
```js
const isBrowser = typeof window !== 'undefined';
export default graphql(SamplesQuery, {
options: function() {
return isBrowser
? {
pollInterval: 5000,
forceFetch: true,
... | 2017-05-05T23:31:57Z | 1.2 |
apollographql/apollo-client | 1,540 | apollographql__apollo-client-1540 | [
"1524"
] | d09e57335499d531cbc2ed741fda703d36be98ff | diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts
--- a/src/core/QueryManager.ts
+++ b/src/core/QueryManager.ts
@@ -989,7 +989,7 @@ export class QueryManager {
if (queryOptions.reducer) {
return createStoreReducer(
queryOptions.reducer,
- queryOptions.query,
+ ... | diff --git a/test/mutationResults.ts b/test/mutationResults.ts
--- a/test/mutationResults.ts
+++ b/test/mutationResults.ts
@@ -13,33 +13,58 @@ import { ObservableQuery } from '../src/core/ObservableQuery';
import gql from 'graphql-tag';
describe('mutation results', () => {
+
const query = gql`
query todoLis... | Getting Store Errors after upgrading to v1.0.0
Since upgrading from a previous release candidate (rc6), I am now getting errors when running _**ALL**_ of my create/delete mutations, regardless of what data they mutate I always get the same error:
```
Allergen.jsx:38 Error: Error: Store error: the application attemp... | Rolling `apollo-client` back to `v1.0.0-rc.6` makes it all work again... I'll continue testing the versions in between to try to narrow the issue down...
However I can confirm that `v1.0.0-rc.7` breaks all my mutations. So the issue was likely introduced there.
I'm starting to think that it might be related to the `... | 2017-04-04T08:19:15Z | 1 |
apollographql/apollo-client | 1,661 | apollographql__apollo-client-1661 | [
"1551"
] | 2723963239e978e6fe7907fabe01a4c007fd3c82 | diff --git a/src/data/readFromStore.ts b/src/data/readFromStore.ts
--- a/src/data/readFromStore.ts
+++ b/src/data/readFromStore.ts
@@ -275,7 +275,8 @@ function addPreviousResultToIdValues (value: any, previousResult: any): any {
// using the private `ID_KEY` property that is added in `resultMapper`.
if (Array... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -1201,6 +1201,24 @@ describe('QueryManager', () => {
});
});
+ it('can handle null values in arrays (#1551)', (done) => {
+ const query = gql`{ list { value } }`;
+ const data = { list: [ n... | Query result not delivered to component if array contains null values
I have an issue where my query works in Graphiql in my browser, but wont work for me in my React Native app.
This is a condensed version of the query:
``` query getTeam($teamId: String!, $gameweek: Int!) {
team(_id: $teamId) {
_id
... | Here's a gist of the code: https://gist.github.com/elie222/cb1b594e3b91f7d860454c5a9594823e
What do you mean by "doesn't work"? Does it simply silently fail? What props does your component receive, if any? Are any errors or warnings printed?
This is the result I receive when I request `history`:
<img width="177" alt... | 2017-05-05T21:52:27Z | 1.2 |
apollographql/apollo-client | 1,492 | apollographql__apollo-client-1492 | [
"947"
] | 8f9bb91c3145db36b9135ee3bb0048ea761ee860 | diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts
--- a/src/core/QueryManager.ts
+++ b/src/core/QueryManager.ts
@@ -37,7 +37,10 @@ import {
import {
checkDocument,
getQueryDefinition,
+ getOperationDefinition,
getOperationName,
+ getDefaultValues,
+ getMutationDefinition,
} from '../queries... | diff --git a/test/ApolloClient.ts b/test/ApolloClient.ts
--- a/test/ApolloClient.ts
+++ b/test/ApolloClient.ts
@@ -103,6 +103,40 @@ describe('ApolloClient', () => {
});
});
+ it('will read some data from the store with default values', () => {
+ const client = new ApolloClient({
+ initialState: {
+ ... | Add support for GraphQL variables default values
Spec: https://facebook.github.io/graphql/#sec-Language.Variables
More info: https://medium.com/the-graphqlhub/graphql-tour-variables-58c6abd10f56
| @iki sure, we'll implement it some time. I would give this relatively low priority at the moment though, because I think default values for variables are most useful on the server. On the client, I think it's just as convenient to provide that default value yourself in the component that issues the query. But maybe you... | 2017-03-25T11:23:46Z | 1 |
apollographql/apollo-client | 1,270 | apollographql__apollo-client-1270 | [
"1266"
] | 449a96e70f0b232272cc6d7921322dff2e5af98d | diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts
--- a/src/core/QueryManager.ts
+++ b/src/core/QueryManager.ts
@@ -877,14 +877,16 @@ export class QueryManager {
private getExtraReducers(): ApolloReducer[] {
return Object.keys(this.observableQueries).map( obsQueryId => {
- const queryOpti... | diff --git a/test/ObservableQuery.ts b/test/ObservableQuery.ts
--- a/test/ObservableQuery.ts
+++ b/test/ObservableQuery.ts
@@ -782,6 +782,66 @@ describe('ObservableQuery', () => {
}
});
});
+
+ it('applies query reducers with correct variables', (done) => {
+ const queryManager = ... | Variables in reducer for query always use the original variables
**Intended outcome:**
After setVariables, the reducers should re-run with the new variables for the query.
**Actual outcome:**
reducers always run with original variables.
**How to reproduce the issue:**
```
query = apollo.watchQuery(query: q, v... | 2017-02-07T19:31:06Z | 0.8 | |
apollographql/apollo-client | 1,169 | apollographql__apollo-client-1169 | [
"1168"
] | 389d87aabb6a7ddd553319ba932af09616a7b12f | diff --git a/src/ApolloClient.ts b/src/ApolloClient.ts
--- a/src/ApolloClient.ts
+++ b/src/ApolloClient.ts
@@ -44,6 +44,10 @@ import {
Observable,
} from './util/Observable';
+import {
+ isProduction,
+} from './util/environment';
+
import {
WatchQueryOptions,
SubscriptionOptions,
@@ -225,7 +229,7 @@ expo... | diff --git a/test/environment.ts b/test/environment.ts
new file mode 100644
--- /dev/null
+++ b/test/environment.ts
@@ -0,0 +1,77 @@
+import { assert } from 'chai';
+
+import { isEnv, isProduction, isDevelopment, isTest } from '../src/util/environment';
+
+describe('environment', () => {
+ let keepEnv: string;
+
+ be... | Avoid using process.env.NODE_ENV
There's no such thing in a browser
| 2017-01-12T16:40:42Z | 0.7 | |
apollographql/apollo-client | 1,095 | apollographql__apollo-client-1095 | [
"1074",
"999"
] | 735ee9b49a834e5db65e60a90148f65acd7fd82e | diff --git a/rollup.config.js b/rollup.config.js
new file mode 100644
--- /dev/null
+++ b/rollup.config.js
@@ -0,0 +1,19 @@
+export default {
+ entry: 'lib/src/index.js',
+ dest: 'lib/apollo.umd.js',
+ format: 'umd',
+ sourceMap: true,
+ moduleName: 'apollo',
+ onwarn
+};
+
+function onwarn(message) {
+ const su... | diff --git a/test/ObservableQuery.ts b/test/ObservableQuery.ts
--- a/test/ObservableQuery.ts
+++ b/test/ObservableQuery.ts
@@ -215,7 +215,7 @@ describe('ObservableQuery', () => {
const variables2 = { first: 1 };
- const observable: ObservableQuery = mockWatchQuery({
+ const observable: ObservableQu... | Circular dependencies
```
store.js -> optimistic-data/store.js -> store.js
core/ObservableQuery.js -> core/QueryManager.js -> scheduler/scheduler.js -> core/ObservableQuery.js
core/QueryManager.js -> scheduler/scheduler.js -> core/QueryManager.js
optimistic-data/store.js -> store.js -> optimistic-data/store.js
sch... | 2016-12-25T04:03:07Z | 0.6 | |
apollographql/apollo-client | 1,069 | apollographql__apollo-client-1069 | [
"1074"
] | 6f679c392d421039c2c95ae226fd83d25a84a59a | diff --git a/rollup.config.js b/rollup.config.js
new file mode 100644
--- /dev/null
+++ b/rollup.config.js
@@ -0,0 +1,15 @@
+function globals(mod) {
+ if (mod.indexOf('lodash/') === 0) return '_';
+}
+
+export default {
+ entry: 'lib/src/index.js',
+ dest: 'lib/apollo.umd.js',
+ format: 'umd',
+ sourceMap: true,
+... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -36,13 +36,13 @@ import ApolloClient, {
import {
ApolloQueryResult,
-} from '../src/core/QueryManager';
+} from '../src/core/types';
import { createStore, combineReducers, applyMiddleware } from 'r... | Circular dependencies
```
store.js -> optimistic-data/store.js -> store.js
core/ObservableQuery.js -> core/QueryManager.js -> scheduler/scheduler.js -> core/ObservableQuery.js
core/QueryManager.js -> scheduler/scheduler.js -> core/QueryManager.js
optimistic-data/store.js -> store.js -> optimistic-data/store.js
sch... | 2016-12-20T14:11:30Z | 0.5 | |
apollographql/apollo-client | 1,054 | apollographql__apollo-client-1054 | [
"902"
] | 0f7d80268db1d4e566df624e73c5902a51e389af | diff --git a/src/core/ObservableQuery.ts b/src/core/ObservableQuery.ts
--- a/src/core/ObservableQuery.ts
+++ b/src/core/ObservableQuery.ts
@@ -366,6 +366,11 @@ export class ObservableQuery extends Observable<ApolloQueryResult> {
const retQuerySubscription = {
unsubscribe: () => {
+ if (this.observe... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -535,7 +535,7 @@ describe('QueryManager', () => {
});
});
- it('allows you to subscribe twice to the one query', (done) => {
+ it('allows you to subscribe twice to one query', (done) => {
c... | Question about stopped queries and potential bug
I have two views in my app and each view is wrapped in Apollo component. Every time I switch between these two view a new query is being created for a component I switch to and the query for the component being switched away from is stopped. So when switching 20 times be... | @yurigenin If the queries are stopped, they should be removed from the `queries` part of the store. If that's not the case, then I think it's a bug and we should fix it. You could make a PR if you want!
Just to confirm: you are switching components and seeing more and more queries in your store with the Redux devtools... | 2016-12-17T14:31:53Z | 0.5 |
apollographql/apollo-client | 683 | apollographql__apollo-client-683 | [
"678"
] | 3f5e15f58551478988150b9600589719dba5b7ba | diff --git a/src/data/diffAgainstStore.ts b/src/data/diffAgainstStore.ts
--- a/src/data/diffAgainstStore.ts
+++ b/src/data/diffAgainstStore.ts
@@ -2,7 +2,7 @@ import isArray = require('lodash.isarray');
import isNull = require('lodash.isnull');
import isObject = require('lodash.isobject');
import has = require('loda... | diff --git a/test/readFromStore.ts b/test/readFromStore.ts
--- a/test/readFromStore.ts
+++ b/test/readFromStore.ts
@@ -172,7 +172,9 @@ describe('reading from the store', () => {
deepNestedObj: {
stringField: 'This is a deep string',
numberField: 7,
+ nullField: null,
} as StoreObj... | Getting "Can't find field" errors on null fields (even if the field is nullable)
Since 0.4.16.
Once a mutation comes back and its results are reinjected into the store via `updateQueries`
```
Can't find field cursor on result object $ROOT_QUERY.connection({"id":"xxx"}).nodeChildren({"id":"root","limit":40,"cursor":nu... | This error should happen on `master` - can you submit a failing test as a PR?
Working on it 😉 !
Harder to reproduce than expected. Seems like I have to throw fragments in the mix!
OK, maybe it's a result of that deep-assign PR for fragments then? That's the only relevant change I can think of.
Urr, I'm based on an... | 2016-09-20T20:59:37Z | 0.4 |
apollographql/apollo-client | 581 | apollographql__apollo-client-581 | [
"567"
] | 919340626a40eb1a96b9b4a1e035694d8cac2302 | diff --git a/src/index.ts b/src/index.ts
--- a/src/index.ts
+++ b/src/index.ts
@@ -299,6 +299,10 @@ export default class ApolloClient {
}));
};
+ public resetStore() {
+ this.queryManager.resetStore();
+ };
+
private setStore(store: ApolloStore) {
// ensure existing store has apolloReducer
i... | diff --git a/test/client.ts b/test/client.ts
--- a/test/client.ts
+++ b/test/client.ts
@@ -1594,4 +1594,14 @@ describe('client', () => {
done();
});
});
+
+ it('has a resetStore method which calls QueryManager', (done) => {
+ const client = new ApolloClient();
+ client.queryManager = {
+ rese... | resetStore method disappeared
There used to be a `resetStore` method inside the `ApolloClient` but that seems to have disappeared altogether due to some merge.
Should be an easy fix: the `resetStore` method inside `ApolloClient` should just call the `resetStore` method inside `this.queryManager`. Probably a test to go... | Whoever does this should also figure out when it disappeared because that will help us prevent similar "accidents" in the future. Also curious to know why this wasn't caught by a test.
I would guess we have a test for the `QueryManager` version but not the `ApolloClient` version.
Was it definitely called `resetStore`... | 2016-08-24T01:43:15Z | 0.4 |
apollographql/apollo-client | 493 | apollographql__apollo-client-493 | [
"490"
] | 0c91cb1555e637c12dbfcdcae31f553da7421784 | diff --git a/src/batching/queryMerging.ts b/src/batching/queryMerging.ts
--- a/src/batching/queryMerging.ts
+++ b/src/batching/queryMerging.ts
@@ -49,6 +49,10 @@ import {
Request,
} from '../networkInterface';
+import {
+ resultKeyNameFromField,
+} from '../data/storeUtils';
+
import assign = require('lodash.as... | diff --git a/test/queryMerging.ts b/test/queryMerging.ts
--- a/test/queryMerging.ts
+++ b/test/queryMerging.ts
@@ -788,4 +788,54 @@ describe('Query merging', () => {
const mergedRequest = mergeRequests([{query: query1}, {query: query2}]);
assert.equal(print(mergedRequest.query), print(expQuery));
});
+
+ ... | Renaming queries not working with batching
If I send the following query in a request that is batched with other queries...
```
query getActivity {
activities: lookActivities(skip: 0, limit: 10) {
_id
type
owner {
_id
name
}
}
}
```
...it will give me the following error:
![image](htt... | 2016-08-01T20:54:41Z | 0.4 | |
apollographql/apollo-client | 465 | apollographql__apollo-client-465 | [
"458"
] | f33998bb05c2349eb563403027fb0f1166b9a9f8 | diff --git a/src/QueryManager.ts b/src/QueryManager.ts
--- a/src/QueryManager.ts
+++ b/src/QueryManager.ts
@@ -237,29 +237,39 @@ export class QueryManager {
resultBehaviors: [...resultBehaviors, ...updateQueriesResultBehaviors],
});
- return this.networkInterface.query(request)
- .then((result) =>... | diff --git a/test/client.ts b/test/client.ts
--- a/test/client.ts
+++ b/test/client.ts
@@ -1462,4 +1462,71 @@ describe('client', () => {
assert.equal(query.definitions, initialDefinitions);
});
});
+
+ it('should pass a network error correctly on a mutation', (done) => {
+ const mutation = gql`
+ ... | ApolloError not thrown when receiving mutation result with GraphQL errors
ApolloError is not thrown when the result of a mutation contains errors. Haven't tested with queries yet so I don't know if this is only a problem for mutations.
Example:
``` js
client.mutate({
mutation: gql`
mutation update($input: Profi... | 2016-07-25T20:54:41Z | 0.4 | |
apollographql/apollo-client | 445 | apollographql__apollo-client-445 | [
"434",
"445"
] | f3c1306a9b22e84b5ed995a9f69d7d4fbe541a6d | diff --git a/src/QueryManager.ts b/src/QueryManager.ts
--- a/src/QueryManager.ts
+++ b/src/QueryManager.ts
@@ -699,11 +699,6 @@ export class QueryManager {
});
this.removeFetchQueryPromise(requestId);
- if (result.errors) {
- reject(new ApolloError({
- ... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -2611,7 +2611,7 @@ describe('QueryManager', () => {
});
});
- it('should reject a fetchQuery promise given a network error', (done) => {
+ it('should reject a query promise given a network error... | Several error reporting issues
I think there may be several issues here; this is prompted from [a discussion with @Poincare in Slack](https://apollostack.slack.com/archives/general/p1469029558000617) These may be separate issues; let me know if you'd prefer separate open issues for each.
# Issues
1. `render` error repo... | @dahjelle is this example something we can clone and run locally?
I put it in [this GitHub repo](https://github.com/dahjelle/apolloerror-example). Should be fairly straightforward to get it going (but, then again, it's the stack I'm used to :-) ).
Nice, I dig the mocked network interface! This could be a great way to... | 2016-07-21T18:50:26Z | 0.4 |
apollographql/apollo-client | 313 | apollographql__apollo-client-313 | [
"223"
] | 7577a3deece753e235bdf5360757b84dda6ba1cc | diff --git a/gql.js b/gql.js
--- a/gql.js
+++ b/gql.js
@@ -1,4 +1,2 @@
-/* We are placing this file in the root to enable npm-link development
- * Currently, gql resides in a submodule and is not able to be imported when linked
- */
-module.exports = require('./lib/src/gql');
+// This is here for backcompat, even thoug... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -15,7 +15,7 @@ import {
addTypenameToSelectionSet,
} from '../src/queries/queryTransform';
-import gql from '../src/gql';
+import gql from 'graphql-tag';
import {
assert,
diff --git a/test/batch... | Decide on a more elegant solution to make `gql` work with npm link
To fix the current `npm-link` issue, where the module `apollo-client/gql` cannot be found, we will place `gql.js` in the root of the repo and redirect it to `lib/src/`gql.js`.
After a deep discussion about separate modules or not, we decided to go ahea... | I also ran into the same issue when importing from `writeToStore` and `readFromStore` in relation to #180. Hopefully not nearly as important long-term as `gql`, but I thought it worth mentioning anyway.
@stubailo when do you think we can get the hacky version in. Again if you just wanna write down what you want, im su... | 2016-06-24T21:40:37Z | 0.3 |
apollographql/apollo-client | 201 | apollographql__apollo-client-201 | [
"193"
] | 021ee1feb3858266233edd0566f216ba739122a0 | diff --git a/src/QueryManager.ts b/src/QueryManager.ts
--- a/src/QueryManager.ts
+++ b/src/QueryManager.ts
@@ -195,6 +195,7 @@ export class QueryManager {
rootId: queryStoreValue.query.id,
selectionSet: queryStoreValue.query.selectionSet,
variables: queryStoreValue.variables... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -689,6 +689,80 @@ describe('QueryManager', () => {
});
});
+ it('supports returnPartialData #193', () => {
+ const primeQuery = gql`
+ query primeQuery {
+ people_one(id: 1) {
+ ... | Partial data return prematurely fails (watchQuery)
Hey folks,
Getting following error, when using `returnPartialData` with `watchQuery` (looks like it's trying to get the data from Store, before it's available)
```
store.js:11Caught an exception! Error: Can't find field posts on object [object Object].(…)
```
| This is a pretty bad bug! Thanks for the report, we should get it fixed ASAP.
Oops, looks like we have exactly 0 unit tests for `returnPartialData`. That explains why that broke...
| 2016-05-11T02:44:49Z | 0.3 |
apollographql/apollo-client | 200 | apollographql__apollo-client-200 | [
"199"
] | a50182d2ef9c7bb5c8bc6dc942b58527447541a4 | diff --git a/src/gql.ts b/src/gql.ts
--- a/src/gql.ts
+++ b/src/gql.ts
@@ -4,13 +4,21 @@ import {
Document,
} from 'graphql';
+const cache: {[queryString: string]: Document} = {};
+
function parseDocument(doc: string): Document {
+ if (cache[doc]) {
+ return cache[doc];
+ }
+
const parsed = parse(doc);
... | diff --git a/test/gql.ts b/test/gql.ts
new file mode 100644
--- /dev/null
+++ b/test/gql.ts
@@ -0,0 +1,13 @@
+import { assert } from 'chai';
+
+import gql from '../src/gql';
+
+describe('gql', () => {
+ it('parses queries', () => {
+ assert.equal(gql`{ testQuery }`.kind, 'Document');
+ });
+
+ it('returns the sam... | Memoize gql
Since `gql` now creates a new object every time it parses, that breaks `react-apollo` change detection. We should make the same queries `===` each other, like the original strings do.
| 2016-05-11T02:34:02Z | 0.3 | |
apollographql/apollo-client | 140 | apollographql__apollo-client-140 | [
"137"
] | a9ea8a2a1128ba569b96846fb18fa51d24f33005 | diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,21 @@
+'use strict';
+
+module.exports = function (grunt) {
+ grunt.initConfig({
+ tslint: {
+ options: {
+ // can be a configuration object or a filepath to tslint.json
+ configuration: grun... | diff --git a/test/client.ts b/test/client.ts
--- a/test/client.ts
+++ b/test/client.ts
@@ -24,7 +24,7 @@ import {
import {
createNetworkInterface,
- NetworkInterface,
+ HTTPNetworkInterface,
} from '../src/networkInterface';
import mockNetworkInterface from './mocks/mockNetworkInterface';
@@ -67,12 +67,12 @... | Linter doesn't lint subdirs
| 2016-04-21T19:18:44Z | 0.1 | |
apollographql/apollo-client | 111 | apollographql__apollo-client-111 | [
"109"
] | f40e87e634663f7c79b510c13cf733d913e4729b | diff --git a/src/QueryManager.ts b/src/QueryManager.ts
--- a/src/QueryManager.ts
+++ b/src/QueryManager.ts
@@ -39,10 +39,15 @@ import {
printQueryFromDefinition,
} from './queryPrinting';
+import {
+ IdGetter,
+} from './data/extensions';
+
export class QueryManager {
private networkInterface: NetworkInterfa... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -12,6 +12,7 @@ import {
} from '../src/store';
import {
+ IdGetter,
getIdField,
} from '../src/data/extensions';
@@ -456,7 +457,97 @@ describe('QueryManager', () => {
},
variabl... | Query diffing with variables
It looks like the `minimizedQueryString` in QueryManager doesn't account for named queries, and therefore variables:
``` js
const query = {
query,
variables,
forceFetch: false,
}
apolloClient.query(query)
.then((result) => {
// yada yada
});
```
If the original query was:
... | Ooh, that's awkward. OK, maybe we need to pass around variable type definitions wherever we have `SelectionSetWithRoot` instances.
BTW - we want to do an initial open source launch next Tuesday, so keep the bugs coming and I'll try to fix them ASAP!
@stubailo will do. Thanks!
| 2016-04-14T23:02:39Z | 0 |
apollographql/apollo-client | 133 | apollographql__apollo-client-133 | [
"131"
] | 4252eb1ded1de4f3c2e0cf06e09ad946be510b70 | diff --git a/src/QueryManager.ts b/src/QueryManager.ts
--- a/src/QueryManager.ts
+++ b/src/QueryManager.ts
@@ -67,7 +67,7 @@ export class ObservableQuery extends Observable<GraphQLResult> {
}
export interface QuerySubscription extends Subscription {
- refetch();
+ refetch(variables?: any): void;
}
export inte... | diff --git a/test/QueryManager.ts b/test/QueryManager.ts
--- a/test/QueryManager.ts
+++ b/test/QueryManager.ts
@@ -301,6 +301,82 @@ describe('QueryManager', () => {
});
});
+ it('allows you to refetch queries with new variables', (done) => {
+ const query = `
+ {
+ people_one(id: 1) {
+ ... | Refetch query with new variables at runtime
Hey @stubailo @jbaxleyiii
Relay provides an option in the component called [setvariables](https://facebook.github.io/relay/docs/api-reference-relay-container.html#setvariables) to change the variables on runtime. Does apollo client support this yet? I see `refetch` function... | If you want to pass new variables you can just unsubscribe from the previous query and start a new one.
`react-apollo` makes this really convenient: You can easily pass in a prop from outside, or put your state in Redux. The `mapQueriesToProps` option takes in `ownProps` and `state`, which can be used as variables in ... | 2016-04-20T16:34:22Z | 0.1 |
eclipse-vertx/vert.x | 5,347 | eclipse-vertx__vert.x-5347 | [
"5290"
] | 99cb7e32a65f2d860af6a37fa66568ac388fd838 | diff --git a/vertx-core/src/main/java/io/vertx/core/http/impl/HttpUtils.java b/vertx-core/src/main/java/io/vertx/core/http/impl/HttpUtils.java
--- a/vertx-core/src/main/java/io/vertx/core/http/impl/HttpUtils.java
+++ b/vertx-core/src/main/java/io/vertx/core/http/impl/HttpUtils.java
@@ -40,6 +40,8 @@
import java.io.Fil... | diff --git a/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java b/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java
--- a/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java
+++ b/vertx-core/src/test/java/io/vertx/tests/net/NetTest.java
@@ -91,6 +91,7 @@
import static io.vertx.test.http.HttpTestBase.... | Missing peer host and port info in SSLEngine for server SslHandler
### Version
4.4.9
### Context
We have a customized key manager that extends `X509ExtendedKeyManager` that want to override the `public String chooseEngineServerAlias(String keyType, Principal[] issuers, SSLEngine engine)` method to choose the s... | @ben1222 can you provide a reproducer for this using the vertx tests so we are covered, that would help
@vietj I tried to create a unit test under `Http1xTLSTest`:
```java
public class Http1xTLSTest extends HttpTLSTest {
private static final Logger LOG = LogManager.getLogger(Http1xTLSTest.class);
@Test
pub... | 2024-10-08T06:17:37Z | 4.4 |
eclipse-vertx/vert.x | 5,273 | eclipse-vertx__vert.x-5273 | [
"5272"
] | d837b49bc346fb37d30dd2f72cf0b0d5976df6a1 | diff --git a/vertx-core/src/main/java/io/vertx/core/impl/HAManager.java b/vertx-core/src/main/java/io/vertx/core/impl/HAManager.java
--- a/vertx-core/src/main/java/io/vertx/core/impl/HAManager.java
+++ b/vertx-core/src/main/java/io/vertx/core/impl/HAManager.java
@@ -373,6 +373,8 @@ private void checkQuorum() {
... | diff --git a/vertx-core/src/test/java/io/vertx/tests/ha/HAQuorumTest.java b/vertx-core/src/test/java/io/vertx/tests/ha/HAQuorumTest.java
new file mode 100644
--- /dev/null
+++ b/vertx-core/src/test/java/io/vertx/tests/ha/HAQuorumTest.java
@@ -0,0 +1,90 @@
+package io.vertx.tests.ha;
+
+import io.vertx.core.DeploymentOp... | HAManager couldn't see quorum if during its initialization cluster manager has all nodes joined already
### Version
4.5.7
### Context
My app is based on Vert.x with embedded Hazelcast cluster manager. When I run several instances of the app with HA mode enabled some instances cannot deploy HA verticles, and l... | 2024-08-03T10:06:36Z | 4.4 | |
eclipse-vertx/vert.x | 5,137 | eclipse-vertx__vert.x-5137 | [
"5136"
] | 582d864dc61f566844d7d7150da0c9dc52ac7f01 | diff --git a/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java b/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
--- a/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
@@ -467,7 +467,10 @@ HttpClientRequest createRequest(HttpConn... | diff --git a/src/test/java/io/vertx/core/http/HttpTest.java b/src/test/java/io/vertx/core/http/HttpTest.java
--- a/src/test/java/io/vertx/core/http/HttpTest.java
+++ b/src/test/java/io/vertx/core/http/HttpTest.java
@@ -60,8 +60,10 @@
import java.util.function.*;
import java.util.stream.IntStream;
+import static io.... | HttpClient drops original proxy on redirect
### Version
Which version(s) did you encounter this bug ?
`>= 4.x`
### Context
`RequestOptions` allows us to set a proxy per request, but upon redirect the original proxy gets lost
It also affects `WebClient`.
### Do you have a reproducer?
I have added test... | 2024-02-28T07:35:54Z | 4.4 | |
eclipse-vertx/vert.x | 4,904 | eclipse-vertx__vert.x-4904 | [
"4900"
] | 9cdc623860749f1b22482120f392ac34829e61b5 | diff --git a/src/main/java/io/vertx/core/impl/TaskQueue.java b/src/main/java/io/vertx/core/impl/TaskQueue.java
--- a/src/main/java/io/vertx/core/impl/TaskQueue.java
+++ b/src/main/java/io/vertx/core/impl/TaskQueue.java
@@ -16,6 +16,7 @@
import java.util.LinkedList;
import java.util.concurrent.Executor;
+import java... | diff --git a/src/test/java/io/vertx/core/impl/TaskQueueTest.java b/src/test/java/io/vertx/core/impl/TaskQueueTest.java
new file mode 100644
--- /dev/null
+++ b/src/test/java/io/vertx/core/impl/TaskQueueTest.java
@@ -0,0 +1,34 @@
+package io.vertx.core.impl;
+
+import org.assertj.core.api.Assertions;
+import org.junit.T... | TasksQueue doesn't remove entry from tasks on RejectedExecutionException
### Version
`master` branch.
### Context
I had a look at the code when analyzing a problem in the 4.4.x after I configured a thread pool with a limited backlog which would reject executions eventually.
I found that the code in `master`... | 2023-10-12T07:58:56Z | 4.4 | |
eclipse-vertx/vert.x | 5,346 | eclipse-vertx__vert.x-5346 | [
"5290"
] | ba4c372ba8f3259033ba2b0156d1d1acc7a12bc3 | diff --git a/src/main/java/io/vertx/core/http/impl/HttpServerWorker.java b/src/main/java/io/vertx/core/http/impl/HttpServerWorker.java
--- a/src/main/java/io/vertx/core/http/impl/HttpServerWorker.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpServerWorker.java
@@ -129,7 +129,7 @@ public void accept(Channel ch, Ss... | diff --git a/src/test/java/io/vertx/core/http/HttpTLSTest.java b/src/test/java/io/vertx/core/http/HttpTLSTest.java
--- a/src/test/java/io/vertx/core/http/HttpTLSTest.java
+++ b/src/test/java/io/vertx/core/http/HttpTLSTest.java
@@ -27,8 +27,10 @@
import java.security.interfaces.RSAPrivateKey;
import java.util.*;
impo... | Missing peer host and port info in SSLEngine for server SslHandler
### Version
4.4.9
### Context
We have a customized key manager that extends `X509ExtendedKeyManager` that want to override the `public String chooseEngineServerAlias(String keyType, Principal[] issuers, SSLEngine engine)` method to choose the s... | @ben1222 can you provide a reproducer for this using the vertx tests so we are covered, that would help
@vietj I tried to create a unit test under `Http1xTLSTest`:
```java
public class Http1xTLSTest extends HttpTLSTest {
private static final Logger LOG = LogManager.getLogger(Http1xTLSTest.class);
@Test
pub... | 2024-10-08T06:16:25Z | 4.5 |
eclipse-vertx/vert.x | 4,616 | eclipse-vertx__vert.x-4616 | [
"4610"
] | 0e77586f55f258dfd4e24f7ffd6d59bcb5b25406 | diff --git a/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java b/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java
--- a/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java
+++ b/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java
@@ -288,6 +288,7 @@ private void chec... | diff --git a/src/test/java/io/vertx/core/parsetools/JsonParserTest.java b/src/test/java/io/vertx/core/parsetools/JsonParserTest.java
--- a/src/test/java/io/vertx/core/parsetools/JsonParserTest.java
+++ b/src/test/java/io/vertx/core/parsetools/JsonParserTest.java
@@ -96,21 +96,30 @@ public void testParseEmptyArray() {
... | JsonParser: endHandler called before exceptionHandler
### Version
Vert.x 4.3.8
### Context
JsonParser may now report errors with a call to exceptionHandler after endHandler is called.
In 4.3.7 and earlier releases endHandler was guaranteed to be last callback if the document was valid.
With new behavior... | 2023-02-20T15:03:11Z | 4.3 | |
eclipse-vertx/vert.x | 4,597 | eclipse-vertx__vert.x-4597 | [
"4338"
] | 7f87fab4de9a967eb57d5dff44c3f4b425ffd3f6 | diff --git a/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java b/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java
--- a/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java
+++ b/src/main/java/io/vertx/core/parsetools/impl/JsonParserImpl.java
@@ -12,6 +12,7 @@
package io.vertx.c... | diff --git a/src/test/java/io/vertx/core/parsetools/JsonParserTest.java b/src/test/java/io/vertx/core/parsetools/JsonParserTest.java
--- a/src/test/java/io/vertx/core/parsetools/JsonParserTest.java
+++ b/src/test/java/io/vertx/core/parsetools/JsonParserTest.java
@@ -113,6 +113,35 @@ public void parseUnfinished() {
... | Inconsistent error handling with JsonParser
### Version
4.2.6
### Context
I use the JsonParser class to handle a stream of JSON comming from a client request (code follows). When an error is present in the JSON (wrong integer value, additional comma etc ...) everything works as expected, exception handler is c... | 2023-02-01T15:27:10Z | 4.3 | |
eclipse-vertx/vert.x | 4,485 | eclipse-vertx__vert.x-4485 | [
"4484"
] | e3100d67bcbe85665f7147bcc48ce6a4720367db | diff --git a/src/main/java/io/vertx/core/http/impl/EndpointKey.java b/src/main/java/io/vertx/core/http/impl/EndpointKey.java
--- a/src/main/java/io/vertx/core/http/impl/EndpointKey.java
+++ b/src/main/java/io/vertx/core/http/impl/EndpointKey.java
@@ -13,6 +13,8 @@
import io.vertx.core.net.ProxyOptions;
import io.vert... | diff --git a/src/test/java/io/vertx/core/http/Http1xProxyTest.java b/src/test/java/io/vertx/core/http/Http1xProxyTest.java
--- a/src/test/java/io/vertx/core/http/Http1xProxyTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xProxyTest.java
@@ -17,13 +17,19 @@
import io.vertx.core.net.ProxyOptions;
import io.vertx.... | HTTP client pool proxy aware
The HTTP client pool discrimines connection by their host (and SSL) since proxy used to be configured at the client level. Since we allow proxy settings on a request, we should handle proxy settings in the client pool, providing dynamic proxy configuration for environment that use rolling p... | 2022-09-15T14:23:04Z | 4.3 | |
eclipse-vertx/vert.x | 4,423 | eclipse-vertx__vert.x-4423 | [
"4422"
] | 0bdaecf62dbb14421d0277fbfe3c90a47812f538 | diff --git a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
--- a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
+++ b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
@@ -57,25 +57,25 @@ public EventBusImpl(VertxInternal... | diff --git a/src/test/java/io/vertx/core/eventbus/EventBusInterceptorTest.java b/src/test/java/io/vertx/core/eventbus/EventBusInterceptorTest.java
--- a/src/test/java/io/vertx/core/eventbus/EventBusInterceptorTest.java
+++ b/src/test/java/io/vertx/core/eventbus/EventBusInterceptorTest.java
@@ -147,7 +147,7 @@ public vo... | EventBus inbound interceptors are never removed
Since `4.3.0`, `EventBus` interceptors are managed with `AtomicReferenceFieldUpdater`.
But `io.vertx.core.eventbus.impl.EventBusImpl#removeInboundInterceptor` uses the wrong instance:
https://github.com/eclipse-vertx/vert.x/blob/a8d9a164df16c4f2f5eed5f176a5570c46f30... | 2022-06-28T14:15:56Z | 4.3 | |
eclipse-vertx/vert.x | 4,413 | eclipse-vertx__vert.x-4413 | [
"4405"
] | 428f2fd0966057eb9f0e83f70ada8dc08c092a0a | diff --git a/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java b/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java
--- a/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java
+++ b/src/main/java/io/vertx/core/http/impl/WebSocketImplBase.java
@@ -563,7 +563,7 @@ void closeConnection() {
... | diff --git a/src/test/java/io/vertx/core/TimerTest.java b/src/test/java/io/vertx/core/TimerTest.java
--- a/src/test/java/io/vertx/core/TimerTest.java
+++ b/src/test/java/io/vertx/core/TimerTest.java
@@ -460,7 +460,7 @@ public void testRaceWhenTimerCreatedOutsideEventLoop() {
for (int i = 0;i < numThreads;i++) {
... | IllegalStateException on vertx.close: easy to reproduce
### Questions
Vert.x raises an unhandled IllegalStateException on every vertx.close.
```
java.lang.IllegalStateException: null
at io.vertx.core.impl.CloseFuture.add(CloseFuture.java:56)
at io.vertx.core.impl.ContextInternal.addCloseHook(ContextInternal.... | 2022-06-20T13:16:23Z | 4.3 | |
eclipse-vertx/vert.x | 4,377 | eclipse-vertx__vert.x-4377 | [
"4376"
] | 9037e3f8d5db4bcc2f0e3e89c84fe9ee48b36bce | diff --git a/src/main/java/io/vertx/core/impl/AbstractContext.java b/src/main/java/io/vertx/core/impl/AbstractContext.java
--- a/src/main/java/io/vertx/core/impl/AbstractContext.java
+++ b/src/main/java/io/vertx/core/impl/AbstractContext.java
@@ -18,6 +18,7 @@
import io.vertx.core.impl.launcher.VertxCommandLauncher;
... | diff --git a/src/test/java/io/vertx/core/TimerTest.java b/src/test/java/io/vertx/core/TimerTest.java
--- a/src/test/java/io/vertx/core/TimerTest.java
+++ b/src/test/java/io/vertx/core/TimerTest.java
@@ -12,11 +12,14 @@
package io.vertx.core;
import io.vertx.core.impl.ContextInternal;
+import io.vertx.core.impl.Vert... | Timers created outside event loop might not fire
When a timer is created from a non vertx thread, there can be a race with the timer task that executes before the internal timer task is added to the vertx timeout map. When it happens, the timer will not execute since this check is to check whether the task was cancelle... | 2022-05-17T08:18:37Z | 4.3 | |
eclipse-vertx/vert.x | 4,311 | eclipse-vertx__vert.x-4311 | [
"3856"
] | d39c319c92ea6b24a00256efba65253cf6e4c366 | diff --git a/src/main/java/io/vertx/core/file/AsyncFile.java b/src/main/java/io/vertx/core/file/AsyncFile.java
--- a/src/main/java/io/vertx/core/file/AsyncFile.java
+++ b/src/main/java/io/vertx/core/file/AsyncFile.java
@@ -12,6 +12,7 @@
package io.vertx.core.file;
import io.vertx.codegen.annotations.Fluent;
+import... | diff --git a/src/test/java/io/vertx/core/file/FileSystemTest.java b/src/test/java/io/vertx/core/file/FileSystemTest.java
--- a/src/test/java/io/vertx/core/file/FileSystemTest.java
+++ b/src/test/java/io/vertx/core/file/FileSystemTest.java
@@ -31,6 +31,7 @@
import java.io.File;
import java.io.IOException;
+import ja... | filesystem api: expose file locking operations
The `lock` and `tryLock` methods of `AsynchronousFileChannel` should be made available for `AsyncFile` wrappers, so one can perform proper file locking operations.
| Hi @panchmp , @vietj is this still open for the grab ?
yes it is.
On Fri, Apr 2, 2021 at 5:10 PM Shay Dratler ***@***.***>
wrote:
> Hi @panchmp <https://github.com/panchmp> , @vietj
> <https://github.com/vietj> is this still open for the grab ?
>
> —
> You are receiving this because you were mentioned.
> Reply to th... | 2022-03-15T18:23:03Z | 4.2 |
eclipse-vertx/vert.x | 4,307 | eclipse-vertx__vert.x-4307 | [
"4304"
] | 56eb506bf9d1380c863b955cac18976aea58f94b | diff --git a/src/main/java/io/vertx/core/eventbus/EventBusOptions.java b/src/main/java/io/vertx/core/eventbus/EventBusOptions.java
--- a/src/main/java/io/vertx/core/eventbus/EventBusOptions.java
+++ b/src/main/java/io/vertx/core/eventbus/EventBusOptions.java
@@ -173,6 +173,10 @@ public EventBusOptions(JsonObject json) ... | diff --git a/src/test/java/io/vertx/core/VertxOptionsTest.java b/src/test/java/io/vertx/core/VertxOptionsTest.java
--- a/src/test/java/io/vertx/core/VertxOptionsTest.java
+++ b/src/test/java/io/vertx/core/VertxOptionsTest.java
@@ -314,6 +314,14 @@ public void testDefaultJsonOptions() {
assertEquals(def.getBlockedT... | clusterPublicPort in EventBusOptions should be ignored in toJson() result if it is the default value
### Questions
`-1` is the default value of `clusterPublicPort` in `EventBusOptions`, but setting this default value will fail:
```java
@Test
public void testEventBusOptions() {
VertxOptions vertxOpt... | 2022-03-14T14:08:19Z | 4.2 | |
eclipse-vertx/vert.x | 4,225 | eclipse-vertx__vert.x-4225 | [
"4224"
] | 73c58bed36ee4a8892a397e789ddbd592bfc489f | diff --git a/src/main/java/io/vertx/core/net/impl/pool/PoolWaiter.java b/src/main/java/io/vertx/core/net/impl/pool/PoolWaiter.java
--- a/src/main/java/io/vertx/core/net/impl/pool/PoolWaiter.java
+++ b/src/main/java/io/vertx/core/net/impl/pool/PoolWaiter.java
@@ -53,6 +53,7 @@ default void onConnect(PoolWaiter<C> waiter... | diff --git a/src/test/java/io/vertx/core/net/impl/pool/ConnectionPoolTest.java b/src/test/java/io/vertx/core/net/impl/pool/ConnectionPoolTest.java
--- a/src/test/java/io/vertx/core/net/impl/pool/ConnectionPoolTest.java
+++ b/src/test/java/io/vertx/core/net/impl/pool/ConnectionPoolTest.java
@@ -632,10 +632,15 @@ public ... | Pool waiter list removal does not check correctly the waiter is in the list
The pool implementation checks incorrectly whether the waiter is enqueued in the list leading to an incorrect waiter list size.
| 2022-01-03T21:04:55Z | 4.2 | |
eclipse-vertx/vert.x | 4,191 | eclipse-vertx__vert.x-4191 | [
"4187"
] | 774940f67a148d790174fe538505541ea1171382 | diff --git a/src/main/java/io/vertx/core/http/impl/CookieImpl.java b/src/main/java/io/vertx/core/http/impl/CookieImpl.java
--- a/src/main/java/io/vertx/core/http/impl/CookieImpl.java
+++ b/src/main/java/io/vertx/core/http/impl/CookieImpl.java
@@ -26,17 +26,26 @@
public class CookieImpl implements ServerCookie {
p... | diff --git a/src/test/java/io/vertx/core/http/HttpTest.java b/src/test/java/io/vertx/core/http/HttpTest.java
--- a/src/test/java/io/vertx/core/http/HttpTest.java
+++ b/src/test/java/io/vertx/core/http/HttpTest.java
@@ -23,6 +23,7 @@
import io.vertx.core.file.AsyncFile;
import io.vertx.core.http.impl.CookieImpl;
impo... | addCookie method does not replace existing cookie (from browser) and fails when calling RoutingContext.cookieMap()
### Version
4.2.1
### Context
We were using (in version 3.9.9) HttpServerResponse.addCookie to set cookie irrespective of whether the cookie was already present (came from browser) and when we ite... | It would be good to have setCookie or replaceCookie method that would have the previous semantics (add or replace by cookie name) for convenience
@narras-oss I'm not following the error:
```java
@Test
public void testReplaceCookie() throws Exception {
// receive a HTTP request with a cookie header with v... | 2021-12-08T11:05:33Z | 4.2 |
eclipse-vertx/vert.x | 4,172 | eclipse-vertx__vert.x-4172 | [
"4175",
"3361"
] | ace996489c931bdc0a48ed76b2e676d7159551eb | diff --git a/src/main/generated/io/vertx/core/http/HttpClientOptionsConverter.java b/src/main/generated/io/vertx/core/http/HttpClientOptionsConverter.java
--- a/src/main/generated/io/vertx/core/http/HttpClientOptionsConverter.java
+++ b/src/main/generated/io/vertx/core/http/HttpClientOptionsConverter.java
@@ -150,6 +15... | diff --git a/src/test/java/io/vertx/core/http/Http1xTest.java b/src/test/java/io/vertx/core/http/Http1xTest.java
--- a/src/test/java/io/vertx/core/http/Http1xTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xTest.java
@@ -13,6 +13,7 @@
import io.netty.channel.Channel;
import io.netty.channel.ChannelHandler;
+i... | HTTP client fixed event loop pool
HTTP client uses event loops provided by actual requests to assign connection event-loops. In some case it is desirable to have the client use its own event loop as a pool, like when it is shared between verticles or statically.
Shared HttpClient support
A few Vert.x clients (e.g. JDBC... |
keep in mind this is not in the 4.0 priority list and I want us to focus on 4.0 priority tasks. | 2021-11-18T10:51:32Z | 4.2 |
eclipse-vertx/vert.x | 4,164 | eclipse-vertx__vert.x-4164 | [
"4163"
] | 0e6526c5eb4355a35014eca2162591453cff4111 | diff --git a/src/main/java/io/vertx/core/Vertx.java b/src/main/java/io/vertx/core/Vertx.java
--- a/src/main/java/io/vertx/core/Vertx.java
+++ b/src/main/java/io/vertx/core/Vertx.java
@@ -660,6 +660,12 @@ default <T> Future<T> executeBlocking(Handler<Promise<T>> blockingCodeHandler) {
@CacheReturn
boolean isNative... | diff --git a/src/test/java/io/vertx/core/datagram/DatagramTest.java b/src/test/java/io/vertx/core/datagram/DatagramTest.java
--- a/src/test/java/io/vertx/core/datagram/DatagramTest.java
+++ b/src/test/java/io/vertx/core/datagram/DatagramTest.java
@@ -27,6 +27,7 @@
import io.vertx.test.core.TestUtils;
import io.vertx.... | Support IO_URING transport
I'm implementing support for https://github.com/netty/netty-incubator-transport-io_uring on Vert-x `Transport`, see https://github.com/franz1981/vert.x/tree/4.2.1_iouring for some initial experiment.
| 2021-11-09T16:52:53Z | 4.3 | |
eclipse-vertx/vert.x | 4,160 | eclipse-vertx__vert.x-4160 | [
"4158"
] | 0a5f619617468ada84ffb7bd2379ace4b519ec5b | diff --git a/src/main/java/io/vertx/core/http/impl/Http1xClientConnection.java b/src/main/java/io/vertx/core/http/impl/Http1xClientConnection.java
--- a/src/main/java/io/vertx/core/http/impl/Http1xClientConnection.java
+++ b/src/main/java/io/vertx/core/http/impl/Http1xClientConnection.java
@@ -1040,17 +1040,6 @@ public... | diff --git a/src/test/java/io/vertx/core/http/Http1xMetricsTest.java b/src/test/java/io/vertx/core/http/Http1xMetricsTest.java
--- a/src/test/java/io/vertx/core/http/Http1xMetricsTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xMetricsTest.java
@@ -10,10 +10,31 @@
*/
package io.vertx.core.http;
+import io.ve... | HTTP/1.1 client metric is reset for allocated but non sent requests
The client calls the HTTP client metrics SPI for HTTP/1.1 requests which have been allocated but not yet sent: every request that is created by `HttpClient#request` that has not yet been sent calls back the SPI when it should not.
| 2021-11-03T07:48:40Z | 4.1 | |
eclipse-vertx/vert.x | 4,134 | eclipse-vertx__vert.x-4134 | [
"4132"
] | ec94331134e7f1d14979fb9bbbaa5ef8a5f0f116 | diff --git a/src/main/generated/io/vertx/core/eventbus/EventBusOptionsConverter.java b/src/main/generated/io/vertx/core/eventbus/EventBusOptionsConverter.java
--- a/src/main/generated/io/vertx/core/eventbus/EventBusOptionsConverter.java
+++ b/src/main/generated/io/vertx/core/eventbus/EventBusOptionsConverter.java
@@ -1... | diff --git a/src/test/java/io/vertx/core/net/NetTest.java b/src/test/java/io/vertx/core/net/NetTest.java
--- a/src/test/java/io/vertx/core/net/NetTest.java
+++ b/src/test/java/io/vertx/core/net/NetTest.java
@@ -1169,40 +1169,96 @@ public void testReconnectAttemptsNotEnough() {
}
@Test
- public void testServerI... | Provide read/write idle timeout granularity for TCP options
| 2021-10-12T19:37:41Z | 4.2 | |
eclipse-vertx/vert.x | 4,080 | eclipse-vertx__vert.x-4080 | [
"4069"
] | 3789ea19c7be717f7a744a6fedb27455cfe1cd8e | diff --git a/src/main/java/io/vertx/core/impl/VertxImpl.java b/src/main/java/io/vertx/core/impl/VertxImpl.java
--- a/src/main/java/io/vertx/core/impl/VertxImpl.java
+++ b/src/main/java/io/vertx/core/impl/VertxImpl.java
@@ -1079,11 +1079,12 @@ class SharedWorkerPool extends WorkerPool {
@Override
void close() ... | diff --git a/src/test/java/io/vertx/core/VertxTest.java b/src/test/java/io/vertx/core/VertxTest.java
--- a/src/test/java/io/vertx/core/VertxTest.java
+++ b/src/test/java/io/vertx/core/VertxTest.java
@@ -21,6 +21,9 @@
import io.vertx.core.net.NetClientOptions;
import io.vertx.core.net.NetSocket;
import io.vertx.test.... | Deadlock when closing Vertx and WorkerExecutor concurrently
I met a deadlock issue recently on Vertx version 4.1.1 and after investigated and looked into the VertxImpl, CloseFuture, WorkerExecutorImpl, it looks like the deadlock happened in Vertx, please take a look:
In my case, the deadlock issue is hit when the `v... | thanks, do you have a reproducer ?
Hi @vietj ,
I tried write a test case to illustrate the issue, the code loops 100 times but it usually hit the issue in less than 10 iterations on my environment:
```java
@Test
public void testVertx() throws InterruptedException {
Logger LOG = LogManager.getLogger();
... | 2021-08-25T13:22:30Z | 4.1 |
eclipse-vertx/vert.x | 4,125 | eclipse-vertx__vert.x-4125 | [
"4124"
] | 8c7795a4d89b1381334e77136e95fc8263bcf9a0 | diff --git a/src/main/java/io/vertx/core/http/impl/HttpServerFileUploadImpl.java b/src/main/java/io/vertx/core/http/impl/HttpServerFileUploadImpl.java
--- a/src/main/java/io/vertx/core/http/impl/HttpServerFileUploadImpl.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpServerFileUploadImpl.java
@@ -76,7 +76,9 @@ pri... | diff --git a/src/test/java/io/vertx/core/http/HttpServerFileUploadTest.java b/src/test/java/io/vertx/core/http/HttpServerFileUploadTest.java
--- a/src/test/java/io/vertx/core/http/HttpServerFileUploadTest.java
+++ b/src/test/java/io/vertx/core/http/HttpServerFileUploadTest.java
@@ -10,7 +10,6 @@
*/
package io.vertx.... | Server File Upload counts the upload twice if client provides content length header
Source: https://github.com/vert-x3/vertx-web/issues/1928
| 2021-10-08T09:36:37Z | 4.2 | |
eclipse-vertx/vert.x | 4,053 | eclipse-vertx__vert.x-4053 | [
"3436"
] | 0eb1310277d09908d4ce4025db16f9d39c6431db | diff --git a/src/main/java/io/vertx/core/datagram/impl/DatagramSocketImpl.java b/src/main/java/io/vertx/core/datagram/impl/DatagramSocketImpl.java
--- a/src/main/java/io/vertx/core/datagram/impl/DatagramSocketImpl.java
+++ b/src/main/java/io/vertx/core/datagram/impl/DatagramSocketImpl.java
@@ -25,6 +25,7 @@
import io.... | diff --git a/src/test/java/io/vertx/core/datagram/DatagramTest.java b/src/test/java/io/vertx/core/datagram/DatagramTest.java
--- a/src/test/java/io/vertx/core/datagram/DatagramTest.java
+++ b/src/test/java/io/vertx/core/datagram/DatagramTest.java
@@ -13,19 +13,21 @@
import io.netty.buffer.ByteBuf;
import io.netty.buf... | `listenMulticastGroup` doesn't work with a null NetworkInterface
### Version
At least vertx 3.8.3-3.9.1
### Context
`listenMulticastGroup` throws a NullPointerException when it is called with the `listenMulticastGroup(string multicastAddress, Handler<AsyncResult<DatagramSocket>> handler)` signature.
### Do ... | see also https://github.com/eclipse-vertx/vert.x/issues/3540
yes that one fails, the socket is not able to get a network interface from the local address | 2021-08-05T08:53:37Z | 4.1 |
eclipse-vertx/vert.x | 4,037 | eclipse-vertx__vert.x-4037 | [
"4036"
] | d07329c92ce9b981a9425d2d0a3187554414a9bf | diff --git a/src/main/generated/io/vertx/core/VertxOptionsConverter.java b/src/main/generated/io/vertx/core/VertxOptionsConverter.java
--- a/src/main/generated/io/vertx/core/VertxOptionsConverter.java
+++ b/src/main/generated/io/vertx/core/VertxOptionsConverter.java
@@ -31,6 +31,11 @@ static void fromJson(Iterable<java... | diff --git a/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java b/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java
--- a/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java
+++ b/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java
@@ -30,7 +30,7 @@ public static BenchmarkContext ... | Remove legacy TCCL check log
This log is not really helpful, in addition it is possible to disable TCCL and have a TCCL set to the non system classloader.
| 2021-07-27T08:27:34Z | 4.1 | |
eclipse-vertx/vert.x | 3,946 | eclipse-vertx__vert.x-3946 | [
"1946"
] | ac2028b85a6afe2ef5f7bdfacf1d3ec18979a615 | diff --git a/src/main/java/io/vertx/core/http/impl/Http1xConnectionBase.java b/src/main/java/io/vertx/core/http/impl/Http1xConnectionBase.java
--- a/src/main/java/io/vertx/core/http/impl/Http1xConnectionBase.java
+++ b/src/main/java/io/vertx/core/http/impl/Http1xConnectionBase.java
@@ -119,17 +119,17 @@ public HttpConn... | diff --git a/src/test/java/io/vertx/core/http/Http2Test.java b/src/test/java/io/vertx/core/http/Http2Test.java
--- a/src/test/java/io/vertx/core/http/Http2Test.java
+++ b/src/test/java/io/vertx/core/http/Http2Test.java
@@ -930,4 +930,36 @@ public void testAppendToHttpChunks() throws Exception {
}));
await();
... | How to capture http request in vertx?
A code like this not works
But this works.
Anyone ca... | vertx http client has a proxy settings on its own - did you try use those instead of setting the system properties? something like:
```java
vertx.createHttpClient(new HttpClientOptions()
.setProxyOptions(new ProxyOptions()
.setPort(9999).setHost("localhost")))
```
this works in 3.4.1 but not works... | 2021-05-25T21:08:58Z | 4.1 |
eclipse-vertx/vert.x | 3,913 | eclipse-vertx__vert.x-3913 | [
"1937"
] | 6e2a1dac65c280d071da9339e78687e09c7dd449 | diff --git a/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java b/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java
--- a/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java
+++ b/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java
@@ -14,20 +14,19 @@
import io.netty.hand... | diff --git a/src/test/java/io/vertx/core/http/Http1xServerFileUploadTest.java b/src/test/java/io/vertx/core/http/Http1xServerFileUploadTest.java
--- a/src/test/java/io/vertx/core/http/Http1xServerFileUploadTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xServerFileUploadTest.java
@@ -17,7 +17,6 @@
*/
public cl... | Request for a new ContextImpl that mimics a Worker Context but allows multiple queues
I have run into the following issue in the past before using Vert.x and now that I am using it as well. I really like the functionality that a Worker Context provides: A separate thread that runs tasks in the order they were submitted... | hi, do you have an actual use case for this ?
Yes. I need to process several messages on a worker context but those messages can be categorized and there is no need for messages of category A to be processed sequentially with messages of category B, but all messages for category A/B need to be processed in order.. Thin... | 2021-05-06T22:07:58Z | 4 |
eclipse-vertx/vert.x | 3,853 | eclipse-vertx__vert.x-3853 | [
"3823"
] | 5a120ee42bc278044b290e0411764050f80f9a6c | diff --git a/src/main/java/io/vertx/core/json/JsonArray.java b/src/main/java/io/vertx/core/json/JsonArray.java
--- a/src/main/java/io/vertx/core/json/JsonArray.java
+++ b/src/main/java/io/vertx/core/json/JsonArray.java
@@ -12,11 +12,13 @@
package io.vertx.core.json;
import io.vertx.core.buffer.Buffer;
+import io.ve... | diff --git a/src/test/java/io/vertx/core/json/JsonArrayTest.java b/src/test/java/io/vertx/core/json/JsonArrayTest.java
--- a/src/test/java/io/vertx/core/json/JsonArrayTest.java
+++ b/src/test/java/io/vertx/core/json/JsonArrayTest.java
@@ -21,6 +21,7 @@
import java.math.BigInteger;
import java.time.Instant;
import ja... | Implementation of JSON RFCs introduced inconsistency to Json{Object|Array} API
### Version
Vert.x 4.0.0
### Context
The implementation of the JSON RFCs (#3197) removed the type checking from methods JsonObject.put(String, Object) and JsonArray.add(int, Object) in order to allow future POJO mappings. Neverthele... | do you mean https://github.com/riemenschneider/JSONObjectTest as reproducer ? | 2021-03-12T08:28:23Z | 4 |
eclipse-vertx/vert.x | 3,800 | eclipse-vertx__vert.x-3800 | [
"3799"
] | f05a5e29be3c10f413d08970c45d3044423e47f0 | diff --git a/src/main/java/io/vertx/core/impl/VertxBuilder.java b/src/main/java/io/vertx/core/impl/VertxBuilder.java
--- a/src/main/java/io/vertx/core/impl/VertxBuilder.java
+++ b/src/main/java/io/vertx/core/impl/VertxBuilder.java
@@ -18,6 +18,7 @@
import io.vertx.core.net.impl.transport.Transport;
import io.vertx.co... | diff --git a/src/test/benchmarks/io/vertx/core/impl/VertxExecutorService.java b/src/test/benchmarks/io/vertx/core/impl/VertxExecutorService.java
--- a/src/test/benchmarks/io/vertx/core/impl/VertxExecutorService.java
+++ b/src/test/benchmarks/io/vertx/core/impl/VertxExecutorService.java
@@ -11,6 +11,8 @@
package io.v... | VertxThread factory
A runtime embedding might want to have Vert.x uses a specific subclass of `VertxThread`. This is a port of https://github.com/eclipse-vertx/vert.x/pull/3749 using the Vert.x 4 service provider mechanism and with a simplification of the factory responsibility.
| 2021-02-10T12:53:46Z | 4 | |
eclipse-vertx/vert.x | 3,764 | eclipse-vertx__vert.x-3764 | [
"3760"
] | 8b23acadbe45b5057997ca3f64989a37d0752e29 | diff --git a/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java b/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java
--- a/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java
+++ b/src/main/java/io/vertx/core/http/impl/Http1xServerRequest.java
@@ -13,12 +13,14 @@
import io.netty.ha... | diff --git a/src/test/java/io/vertx/core/http/Http2ServerTest.java b/src/test/java/io/vertx/core/http/Http2ServerTest.java
--- a/src/test/java/io/vertx/core/http/Http2ServerTest.java
+++ b/src/test/java/io/vertx/core/http/Http2ServerTest.java
@@ -649,7 +649,7 @@ public void testPostFileUpload() throws Exception {
... | Form upload attribute might get corrupted
The current server form upload processing will create the form multi-map when the HTTP server request ends. Some attributes might use `ByteBuf` that can be recycled by the request decoder overwriting the attribute value. We should capture the request form attribute value as a s... | 2021-01-25T12:46:10Z | 4 | |
eclipse-vertx/vert.x | 3,754 | eclipse-vertx__vert.x-3754 | [
"3753"
] | a7b7214c58b85703613cd658c7f32d339a842566 | diff --git a/src/main/java/io/vertx/core/impl/future/CompositeFutureImpl.java b/src/main/java/io/vertx/core/impl/future/CompositeFutureImpl.java
--- a/src/main/java/io/vertx/core/impl/future/CompositeFutureImpl.java
+++ b/src/main/java/io/vertx/core/impl/future/CompositeFutureImpl.java
@@ -17,6 +17,7 @@
import io.vert... | diff --git a/src/test/java/io/vertx/core/CompositeFutureTest.java b/src/test/java/io/vertx/core/CompositeFutureTest.java
--- a/src/test/java/io/vertx/core/CompositeFutureTest.java
+++ b/src/test/java/io/vertx/core/CompositeFutureTest.java
@@ -509,4 +509,10 @@ public void testCompositeFutureMulti() {
p2.complete(4)... | CompositeFuture toString gives stack overflow for completed composite future
### Version
4.0.0
### Context
I get a stack overflow exception while logging a completed CompositeFuture
### Do you have a reproducer?
Yes:
```
import io.vertx.core.CompositeFuture;
import static io.vertx.core.Future.succeede... | does it happen also with vertx 3 ?
No - it works with 3.9.5
The issue seems to be that the .value of CompositeFutureImpl is a reference to the composite future itself, giving a recursive call.
I would suggest overriding toString to show the count and size instead e.g. CompositeFutureImpl( 2/5 completed)? But that mig... | 2021-01-21T16:27:25Z | 4 |
eclipse-vertx/vert.x | 3,718 | eclipse-vertx__vert.x-3718 | [
"3714"
] | 6e8a672768eb5f148def804233c7015c1bdb1765 | diff --git a/src/main/generated/io/vertx/core/DeploymentOptionsConverter.java b/src/main/generated/io/vertx/core/DeploymentOptionsConverter.java
new file mode 100644
--- /dev/null
+++ b/src/main/generated/io/vertx/core/DeploymentOptionsConverter.java
@@ -0,0 +1,125 @@
+package io.vertx.core;
+
+import io.vertx.core.jso... | diff --git a/src/test/java/io/vertx/core/http/WebSocketTest.java b/src/test/java/io/vertx/core/http/WebSocketTest.java
--- a/src/test/java/io/vertx/core/http/WebSocketTest.java
+++ b/src/test/java/io/vertx/core/http/WebSocketTest.java
@@ -2846,8 +2846,17 @@ public void testClientCloseHandshake() {
}
@Test
- pu... | WebSocket server connection close timeout
When a WebSocket is closed by the server, it sends a close frame and waits until it receives the echo close frame to close the TCP connection. We should have a timeout to close the TCP connection to prevent a server from keeping a WebSocket without receiving a close frame.
... | 2020-12-18T10:22:17Z | 3.9 | |
eclipse-vertx/vert.x | 3,663 | eclipse-vertx__vert.x-3663 | [
"3662"
] | 048d63e2539deb18b21c667e3c2b1e2375ca0506 | diff --git a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
--- a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
+++ b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
@@ -236,7 +236,6 @@ public MessageImpl createMessage(... | diff --git a/src/test/java/io/vertx/core/eventbus/ClusteredEventBusTestBase.java b/src/test/java/io/vertx/core/eventbus/ClusteredEventBusTestBase.java
--- a/src/test/java/io/vertx/core/eventbus/ClusteredEventBusTestBase.java
+++ b/src/test/java/io/vertx/core/eventbus/ClusteredEventBusTestBase.java
@@ -23,6 +23,9 @@
im... | Clustered consumer keeps local registration when unregistered
A method name was changed in `EventBusImpl` but not updated in `ClusteredEventBus` while re-working the clustering SPI.
This might have happened while rebasing #3132 on `master`.
The bug was not caught because we didn't have a test for unregistration.
... | 2020-11-23T10:58:58Z | 4 | |
eclipse-vertx/vert.x | 3,657 | eclipse-vertx__vert.x-3657 | [
"3656"
] | c6ff7eeab6764b517bf0b1faab180261c836ce28 | diff --git a/src/main/java/io/vertx/core/file/impl/FileResolver.java b/src/main/java/io/vertx/core/file/impl/FileResolver.java
--- a/src/main/java/io/vertx/core/file/impl/FileResolver.java
+++ b/src/main/java/io/vertx/core/file/impl/FileResolver.java
@@ -22,7 +22,6 @@
import java.net.URL;
import java.util.Enumeration... | diff --git a/src/test/fileresolver/dir with spaces/files.jar b/src/test/fileresolver/dir with spaces/files.jar
new file mode 100644
Binary files /dev/null and b/src/test/fileresolver/dir with spaces/files.jar differ
diff --git a/src/test/fileresolver/files.jar b/src/test/fileresolver/files.jar
new file mode 100644
Bina... | File resolver should replace the file separator before parent file class loader lookup
The `FileResolver` replaces the file separator for a `ClassLoader` lookup however it does not do it for the parent file `ClassLoader` leading to issues on Windows.
| 2020-11-19T07:26:45Z | 4 | |
eclipse-vertx/vert.x | 3,604 | eclipse-vertx__vert.x-3604 | [
"3600"
] | 4dd98060cf9a6e6fac9411e029f6625a14894b3f | diff --git a/src/main/java/io/vertx/core/impl/DeploymentManager.java b/src/main/java/io/vertx/core/impl/DeploymentManager.java
--- a/src/main/java/io/vertx/core/impl/DeploymentManager.java
+++ b/src/main/java/io/vertx/core/impl/DeploymentManager.java
@@ -561,7 +561,7 @@ private void doDeploy(String identifier,
... | diff --git a/src/test/java/io/vertx/core/DeploymentTest.java b/src/test/java/io/vertx/core/DeploymentTest.java
--- a/src/test/java/io/vertx/core/DeploymentTest.java
+++ b/src/test/java/io/vertx/core/DeploymentTest.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2011-2017 Contributors to the Eclipse Foundation
+ * Copyright ... | Vertx.deployVerticle(…); calls completion handler on different context
I'm using `io.vertx:vertx-core:3.9.3` and I have some code in a *Verticle* that looks similar to this:
```java
assert Vertx.currentContext() == context;
vertx.deployVerticle(someVerticle, new DeploymentOptions().setWorker(true), result -> {
... | Thanks for the report, this looks like a bug.
When invoked from a verticle, the context of the deploy callback should be
the same as of the verticle, regardless of the result
Le lun. 12 oct. 2020 à 12:12, Johannes Spangenberg <notifications@github.com>
a écrit :
> I'm using io.vertx:vertx-core:3.9.3 and I have some ... | 2020-10-14T15:19:20Z | 3.9 |
eclipse-vertx/vert.x | 3,607 | eclipse-vertx__vert.x-3607 | [
"3606"
] | 2ca9508da3df7b7bc0581c354e3ddceb562a438a | diff --git a/src/main/java/io/vertx/core/DeploymentOptions.java b/src/main/java/io/vertx/core/DeploymentOptions.java
--- a/src/main/java/io/vertx/core/DeploymentOptions.java
+++ b/src/main/java/io/vertx/core/DeploymentOptions.java
@@ -45,6 +45,7 @@ public class DeploymentOptions {
private int instances;
private L... | diff --git a/src/test/java/io/vertx/core/DeploymentTest.java b/src/test/java/io/vertx/core/DeploymentTest.java
--- a/src/test/java/io/vertx/core/DeploymentTest.java
+++ b/src/test/java/io/vertx/core/DeploymentTest.java
@@ -1590,6 +1590,41 @@ private void testIsolationGroup(String group1, String group2, int count1, int ... | Verticle deployment class loader
Verticle deployment has been using the implicit thread context classloader for the `VerticleFactory` and the `io.vertx.core.Context` class loader. This classloader is used indirectly by code that needs to resolve file in some places (e.g `HttpServerResponse#sendFile(String)`). Until now... | 2020-10-19T14:25:30Z | 4 | |
eclipse-vertx/vert.x | 3,559 | eclipse-vertx__vert.x-3559 | [
"3560"
] | 26651deb950b67d68e417032460bead1e694233a | diff --git a/src/main/java/io/vertx/core/buffer/impl/BufferImpl.java b/src/main/java/io/vertx/core/buffer/impl/BufferImpl.java
--- a/src/main/java/io/vertx/core/buffer/impl/BufferImpl.java
+++ b/src/main/java/io/vertx/core/buffer/impl/BufferImpl.java
@@ -72,11 +72,11 @@ public BufferImpl() {
}
BufferImpl(int in... | diff --git a/src/test/java/io/vertx/core/buffer/impl/VertxBufferTest.java b/src/test/java/io/vertx/core/buffer/impl/VertxBufferTest.java
new file mode 100644
--- /dev/null
+++ b/src/test/java/io/vertx/core/buffer/impl/VertxBufferTest.java
@@ -0,0 +1,76 @@
+/*
+ * Copyright (c) 2011-2020 Contributors to the Eclipse Foun... | Optimize heap buffers
Heap `Buffer` created with `Unpooled.buffer(...)` are instrumented and maintain a reference counting. This reference counting requires to wrap the current `ByteBuf` duplicate with an unreleasable wrapper so that the returned duplicate will not affect the actual `ByteBuf` hold by `BufferImpl`.
W... | 2020-09-06T20:40:25Z | 4 | |
eclipse-vertx/vert.x | 3,428 | eclipse-vertx__vert.x-3428 | [
"3427"
] | 6a92a49b07ee95cf7dfc2cc7a3e0ab9c51eb385f | diff --git a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
--- a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
+++ b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
@@ -523,13 +523,14 @@ private <T> void deliverToHandl... | diff --git a/src/test/java/io/vertx/core/eventbus/EventBusRegistrationRaceTest.java b/src/test/java/io/vertx/core/eventbus/EventBusRegistrationRaceTest.java
--- a/src/test/java/io/vertx/core/eventbus/EventBusRegistrationRaceTest.java
+++ b/src/test/java/io/vertx/core/eventbus/EventBusRegistrationRaceTest.java
@@ -10,8 ... | Ensure EventBusMetrics message schedule event is called before the event-loop action
The `EventBusMetrics#scheduleMessage` method was changed to be called on the event-loop in order to avoid incorrect counter in metrics implementations (that needed to compensate and correct the counter value) when a message consumer is... | 2020-05-26T07:35:41Z | 3.9 | |
eclipse-vertx/vert.x | 3,418 | eclipse-vertx__vert.x-3418 | [
"3417"
] | 2bdf94b30016036cb5833b53ffb9f834f62ad5a6 | diff --git a/src/main/java/io/vertx/core/Context.java b/src/main/java/io/vertx/core/Context.java
--- a/src/main/java/io/vertx/core/Context.java
+++ b/src/main/java/io/vertx/core/Context.java
@@ -276,6 +276,6 @@ static boolean isOnVertxThread() {
void addCloseHook(Closeable hook);
@GenIgnore(GenIgnore.PERMITTED_... | diff --git a/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java b/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java
--- a/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java
+++ b/src/test/benchmarks/io/vertx/core/impl/BenchmarkContext.java
@@ -21,11 +21,16 @@ public class BenchmarkContext... | Resource lifecycle improvements
The core client lifecycle (`HttpClient` and `NetClient`) is correctly not bound to the Vert.x instance, i.e some clients might be not closed after a Vert.x instance is closed. This can raise an issue when a client is closed afterward and the related resources (event-loop) are not availab... | 2020-05-19T10:24:02Z | 4 | |
eclipse-vertx/vert.x | 3,384 | eclipse-vertx__vert.x-3384 | [
"3382"
] | 82231fdce30ed9bda18352e55588243e24614a8a | diff --git a/src/main/java/io/vertx/core/http/HttpConnection.java b/src/main/java/io/vertx/core/http/HttpConnection.java
--- a/src/main/java/io/vertx/core/http/HttpConnection.java
+++ b/src/main/java/io/vertx/core/http/HttpConnection.java
@@ -116,21 +116,25 @@ default HttpConnection goAway(long errorCode, int lastStrea... | diff --git a/src/test/java/io/vertx/core/http/Http1xTest.java b/src/test/java/io/vertx/core/http/Http1xTest.java
--- a/src/test/java/io/vertx/core/http/Http1xTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xTest.java
@@ -4748,4 +4748,116 @@ public void testAsyncPipelinedRequestDequeuing() throws Exception {
... | HTTP/1.x client connection shutdown
HTTP/2 supports a graceful connection shutdown that relies on go away frames. We can provide a degraded support for HTTP/1.x for client connection that will have a similar effect since the client initiates the requests.
A HTTP/1.x client connection shutdown evicts the connection f... | 2020-04-22T08:43:28Z | 3.9 | |
eclipse-vertx/vert.x | 3,247 | eclipse-vertx__vert.x-3247 | [
"3246"
] | 5c1354f3bb7f2e64d89d56741995efd644cf02bf | diff --git a/src/main/java/io/vertx/core/http/HttpClientRequest.java b/src/main/java/io/vertx/core/http/HttpClientRequest.java
--- a/src/main/java/io/vertx/core/http/HttpClientRequest.java
+++ b/src/main/java/io/vertx/core/http/HttpClientRequest.java
@@ -99,20 +99,6 @@ public interface HttpClientRequest extends WriteSt... | diff --git a/src/test/java/io/vertx/core/http/Http1xTest.java b/src/test/java/io/vertx/core/http/Http1xTest.java
--- a/src/test/java/io/vertx/core/http/Http1xTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xTest.java
@@ -3826,7 +3826,7 @@ public void testUnknownContentLengthIsSetToZeroWithHTTP_1_0() throws Except... | HttpMethod is an interface
In Vert.x 2 and 3, the `HttpMethod` is declared as an enum. This leashes the extensibility of HTTP and prevents modelling other HTTP methods with this type unless using `HttpMethod#OTHER` in addition with the `rawMethod` attribute on `HttpServerRequest` and `HttpClientRequest`.
We can turn... | 2020-01-07T13:40:44Z | 4 | |
eclipse-vertx/vert.x | 3,197 | eclipse-vertx__vert.x-3197 | [
"3171"
] | ab1464c8dfb6a0f927e68a426bf22405323aabce | diff --git a/src/main/java/io/vertx/core/impl/ConversionHelper.java b/src/main/java/io/vertx/core/impl/ConversionHelper.java
--- a/src/main/java/io/vertx/core/impl/ConversionHelper.java
+++ b/src/main/java/io/vertx/core/impl/ConversionHelper.java
@@ -15,11 +15,11 @@
import io.vertx.core.json.JsonArray;
import io.vert... | diff --git a/src/test/java/io/vertx/core/ConversionHelperTest.java b/src/test/java/io/vertx/core/ConversionHelperTest.java
--- a/src/test/java/io/vertx/core/ConversionHelperTest.java
+++ b/src/test/java/io/vertx/core/ConversionHelperTest.java
@@ -21,12 +21,12 @@
import java.math.BigInteger;
import java.util.ArrayList... | Feature Request: JsonArray.add(int index, Object value)
this is easy to add and is available in most json libs
PS: and for JsonArray.set(int index, Object value)
methods add and set have the same semantics as in java's List
| we might have `JsonArray` extends `List` in v4
If JsonArray extends List, add method is not going to be fluent (it's not going to return itself) because the signature will not be compatible with List interface. I mean, `JsonArray add(Object value)`is not going to be posible anymore. Is this acceptable?
I can work on... | 2019-11-15T10:42:55Z | 4 |
eclipse-vertx/vert.x | 3,101 | eclipse-vertx__vert.x-3101 | [
"3099"
] | 0af61a3ed8f60d666030e8873295cdb8a1cecebc | diff --git a/src/main/java/io/vertx/core/buffer/Buffer.java b/src/main/java/io/vertx/core/buffer/Buffer.java
--- a/src/main/java/io/vertx/core/buffer/Buffer.java
+++ b/src/main/java/io/vertx/core/buffer/Buffer.java
@@ -17,12 +17,12 @@
import io.vertx.codegen.annotations.GenIgnore;
import io.vertx.codegen.annotations.... | diff --git a/src/test/java/io/vertx/core/json/JacksonDatabindTest.java b/src/test/java/io/vertx/core/json/JacksonDatabindTest.java
new file mode 100644
--- /dev/null
+++ b/src/test/java/io/vertx/core/json/JacksonDatabindTest.java
@@ -0,0 +1,113 @@
+/*
+ * Copyright (c) 2014 Red Hat, Inc. and others
+ *
+ * This program... | Vert.x should run base operations without requiring Jackson
In some scenario where Vert.x is embedded and used for base operation such as HTTP server and HTTP client, Jackson should not be required as long as there is no actual JSON operation such as encoding or decoding involved.
In this case, users can exclude Jac... | 2019-09-09T07:35:37Z | 3.8 | |
eclipse-vertx/vert.x | 3,016 | eclipse-vertx__vert.x-3016 | [
"2982"
] | 9b85c1cc79d12b78587a41c9df8015ef32f2c014 | diff --git a/src/main/java/io/vertx/core/http/StreamResetException.java b/src/main/java/io/vertx/core/http/StreamResetException.java
--- a/src/main/java/io/vertx/core/http/StreamResetException.java
+++ b/src/main/java/io/vertx/core/http/StreamResetException.java
@@ -23,7 +23,7 @@ public class StreamResetException exten... | diff --git a/src/test/java/io/vertx/core/http/Http1xTest.java b/src/test/java/io/vertx/core/http/Http1xTest.java
--- a/src/test/java/io/vertx/core/http/Http1xTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xTest.java
@@ -2883,12 +2883,8 @@ public void testRecyclePipelinedConnection() throws Exception {
clien... | HTTP Client - Deadlock
Sometimes, it appears that some eventloops are blocked while doing some http client relative stuff (Vert.x 3.7.0)
Here is a threaddump:
```
"vert.x-eventloop-thread-0" #10 prio=5 os_prio=0 tid=0x00007f55410b0000 nid=0x855f waiting for monitor entry [0x00007f54fb771000]
java.lang.Thread... | yes it shall be pretty hard.
I think the main issue lies in:
```
synchronized (this) {
tryComplete();
s.endRequest();
if ((handler = completionHandler) == null) {
return;
}
}
```
the `endRequest()` call should not be in the block.
it also likely mea... | 2019-07-02T09:34:15Z | 3.7 |
eclipse-vertx/vert.x | 2,929 | eclipse-vertx__vert.x-2929 | [
"1674"
] | 510dd4b81f9df9fd3c7e2b07776e9ad977707276 | diff --git a/src/main/java/examples/CoreExamples.java b/src/main/java/examples/CoreExamples.java
--- a/src/main/java/examples/CoreExamples.java
+++ b/src/main/java/examples/CoreExamples.java
@@ -15,6 +15,8 @@
import io.vertx.core.buffer.Buffer;
import io.vertx.core.dns.AddressResolverOptions;
import io.vertx.core.fi... | diff --git a/src/test/java/io/vertx/core/http/Http1xProxyTest.java b/src/test/java/io/vertx/core/http/Http1xProxyTest.java
new file mode 100644
--- /dev/null
+++ b/src/test/java/io/vertx/core/http/Http1xProxyTest.java
@@ -0,0 +1,142 @@
+/*
+ * Copyright (c) 2011-2017 Contributors to the Eclipse Foundation
+ *
+ * This ... | Support UNIX Domain Sockets in HttpClient
Netty already supports DomainSockets/DomainChannels, so I was hoping it might be possible to implement support (via HttpOptions/SocketOptions) to support UNIX Domain sockets (AF_UNIX)??? We do this quite often for secured APIs across docker containers. We mount the socket file ... | @InfoSec812 where is this unix+http:// format described ?
I actually talked about this last week with someone because of the docker client use case
see https://github.com/vert-x3/issues/issues/188 also
ah but it's you :-)
so it's expected to be discussed at F2F meeting next week, is that something you could contri... | 2019-05-01T18:51:11Z | 3.7 |
eclipse-vertx/vert.x | 2,883 | eclipse-vertx__vert.x-2883 | [
"2873"
] | bdd603e6fd13fe1d9b8398be72d2c4c18854d93e | diff --git a/src/main/java/io/vertx/core/Starter.java b/src/main/java/io/vertx/core/Starter.java
--- a/src/main/java/io/vertx/core/Starter.java
+++ b/src/main/java/io/vertx/core/Starter.java
@@ -211,7 +211,7 @@ private Vertx startVertx(boolean clustered, boolean ha, Args args) {
CountDownLatch latch = new CountD... | diff --git a/src/test/java/io/vertx/core/CreateVertxTest.java b/src/test/java/io/vertx/core/CreateVertxTest.java
--- a/src/test/java/io/vertx/core/CreateVertxTest.java
+++ b/src/test/java/io/vertx/core/CreateVertxTest.java
@@ -12,10 +12,8 @@
package io.vertx.core;
import io.vertx.test.core.VertxTestBase;
-import or... | Deprecate EventBusOptions delegates in VertxOptions
We had a 2 days effort because the API is misleading:
VertxOptions options = new VertxOptions()
.setClustered(true)
.setClusterHost("10.x.y.z")
.setClusterPort(60000);
System.out.println(options);
options
.setEventBusOptions(new EventBusOptio... | @gofabian I agree with you this should be changed in vertx 4 and perhaps we need to remove the top level setters on VertxOptions
we do have something similar with metrics and file system options
+1
I believe this was added because initially we didn't have the -options arg
on the command line (externalized options).
... | 2019-03-19T15:34:49Z | 3.6 |
eclipse-vertx/vert.x | 2,726 | eclipse-vertx__vert.x-2726 | [
"2725"
] | 3f5b55b80093d79775fb8b5cc2f00410aee2ef6e | diff --git a/src/main/java/io/vertx/core/impl/launcher/commands/BareCommand.java b/src/main/java/io/vertx/core/impl/launcher/commands/BareCommand.java
--- a/src/main/java/io/vertx/core/impl/launcher/commands/BareCommand.java
+++ b/src/main/java/io/vertx/core/impl/launcher/commands/BareCommand.java
@@ -29,6 +29,7 @@
im... | diff --git a/src/test/java/io/vertx/core/LauncherTest.java b/src/test/java/io/vertx/core/LauncherTest.java
--- a/src/test/java/io/vertx/core/LauncherTest.java
+++ b/src/test/java/io/vertx/core/LauncherTest.java
@@ -651,6 +651,17 @@ public void testConfigureClusterHostPortFromCommandLine() throws Exception {
assert... | Configure cluster public host and port from command line
Currently, it's only possible to configure cluster public host and port with sysprops.
This will help having a consistent user experience (cluster host and port can be configured via the command line).
| 2018-11-20T14:44:18Z | 3.6 | |
eclipse-vertx/vert.x | 2,723 | eclipse-vertx__vert.x-2723 | [
"2722"
] | 25565f6a69af53dbe4ff92e41d115a4188de11ee | diff --git a/src/main/java/io/vertx/core/http/impl/HttpHandlers.java b/src/main/java/io/vertx/core/http/impl/HttpHandlers.java
--- a/src/main/java/io/vertx/core/http/impl/HttpHandlers.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpHandlers.java
@@ -25,16 +25,19 @@
*/
public class HttpHandlers {
+ final Http... | diff --git a/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java b/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java
--- a/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java
+++ b/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java
@@ -2... | Close all shared TCP based servers when Vert.x is closing
When closing Vert.x, only the first shared server is closed and not the other servers, which actually does not close the server, since the other shared servers are not closed and prevent closing to happen.
On Vert.x close we should instead close all the serve... | 2018-11-20T09:11:04Z | 3.6 | |
eclipse-vertx/vert.x | 2,724 | eclipse-vertx__vert.x-2724 | [
"1720"
] | 4ab19ce106dd4bca6da52529c6bac7a6a8935d02 | diff --git a/src/main/java/io/vertx/core/http/impl/HttpServerResponseImpl.java b/src/main/java/io/vertx/core/http/impl/HttpServerResponseImpl.java
--- a/src/main/java/io/vertx/core/http/impl/HttpServerResponseImpl.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpServerResponseImpl.java
@@ -13,8 +13,10 @@
import ... | diff --git a/src/test/java/io/vertx/core/http/Http1xTest.java b/src/test/java/io/vertx/core/http/Http1xTest.java
--- a/src/test/java/io/vertx/core/http/Http1xTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xTest.java
@@ -31,6 +31,7 @@
import org.junit.Test;
import java.io.File;
+import java.io.RandomAccessFil... | Socket idle-closed in middle of slowly progressing sendFile() response
I tried streaming music to a music player from vertx using `sendFile()`, but the connection is closed after the time given idleTimeout (I have 60 seconds) set in HttpServerOptions has passed after the request started.
I tracked the socket closing... | can you run wireshark to monitor the TCP activity over the wire ?
it could be also that lot of data is sent to the client at once and it buffers more than 60 seconds of music and then the buffer is full which cause no data to be sent.
Ok wireshark showed a lot of data at the beginning and then got throttled by "tcp w... | 2018-11-20T12:50:35Z | 3.6 |
eclipse-vertx/vert.x | 2,631 | eclipse-vertx__vert.x-2631 | [
"2607"
] | 62023b832614a6257b88639e3419f42a8136e9b8 | diff --git a/src/main/java/io/vertx/core/http/impl/Http2ServerConnection.java b/src/main/java/io/vertx/core/http/impl/Http2ServerConnection.java
--- a/src/main/java/io/vertx/core/http/impl/Http2ServerConnection.java
+++ b/src/main/java/io/vertx/core/http/impl/Http2ServerConnection.java
@@ -34,6 +34,8 @@
import java.ne... | diff --git a/src/test/java/io/vertx/core/http/Http1xTest.java b/src/test/java/io/vertx/core/http/Http1xTest.java
--- a/src/test/java/io/vertx/core/http/Http1xTest.java
+++ b/src/test/java/io/vertx/core/http/Http1xTest.java
@@ -3835,66 +3835,55 @@ public void testSendFileFailsWhenClientClosesConnection() throws Exceptio... | Extra chunk for request with no content.
The following code produces an extra 0 end trailer chunk that makes HTTP clients parse it as a second invalid response:
```java
Vertx vertx = Vertx.vertx();
HttpServer server = vertx.createHttpServer();
server.requestStream().toObservable().subscribe(req -> {
Sys... | taht should be easy to fix
1xx code should not contain response body
I found the following conditions where the spec forbids a body:
```
(status >= 100 && status < 200)
|| status == Status.NO_CONTENT.getStatusCode()
|| status == Status.NOT_MODIFIED.getStatusCode()
```
currently I do have:
```
boole... | 2018-09-19T08:14:33Z | 3.5 |
eclipse-vertx/vert.x | 2,458 | eclipse-vertx__vert.x-2458 | [
"2456"
] | 47d15d66dcd56381ee07754545258d3c48537784 | diff --git a/src/main/java/io/vertx/core/dns/impl/DnsClientImpl.java b/src/main/java/io/vertx/core/dns/impl/DnsClientImpl.java
--- a/src/main/java/io/vertx/core/dns/impl/DnsClientImpl.java
+++ b/src/main/java/io/vertx/core/dns/impl/DnsClientImpl.java
@@ -82,11 +82,14 @@ public DnsClientImpl(VertxInternal vertx, DnsClie... | diff --git a/src/test/java/io/vertx/test/core/DNSTest.java b/src/test/java/io/vertx/test/core/DNSTest.java
--- a/src/test/java/io/vertx/test/core/DNSTest.java
+++ b/src/test/java/io/vertx/test/core/DNSTest.java
@@ -110,6 +110,36 @@ public void testResolveA() throws Exception {
dnsServer.stop();
}
+ @Test
+ ... | DNS client should support calling a DNS server over IpV6
Step to reproduce:
`vertx.createDnsClient(53, "2001:4860:4860::8888").lookup4("vertx.io", res -> {});
`
=> the result fails with the following exception: 'java.net.SocketException: Address family not supported by protocol'
Expected: The DnsClient should be ... | 2018-05-16T15:33:07Z | 3.5 | |
eclipse-vertx/vert.x | 2,392 | eclipse-vertx__vert.x-2392 | [
"1531",
"1531"
] | 47bc80cd615dab4c5980e4d6d0015f64f4d41d81 | diff --git a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
--- a/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
+++ b/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java
@@ -28,6 +28,7 @@
import io.vertx.core.eventbus.Repl... | diff --git a/src/test/benchmarks/io/vertx/benchmarks/ConcurrentCyclicSequenceBenchmark.java b/src/test/benchmarks/io/vertx/benchmarks/ConcurrentCyclicSequenceBenchmark.java
new file mode 100644
--- /dev/null
+++ b/src/test/benchmarks/io/vertx/benchmarks/ConcurrentCyclicSequenceBenchmark.java
@@ -0,0 +1,65 @@
+/*
+ * Co... | Possible concurrency issue in Event Bus
It looks like, there is possible concurrency issue in Event Bus, when we're adding and removing local registrations.
**addLocalRegistration**: https://github.com/eclipse/vert.x/blob/5338f6353a49a4e7e9a6350e4878bcc5f11028a0/src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.j... | 2018-04-16T09:06:31Z | 3.5 | |
eclipse-vertx/vert.x | 2,366 | eclipse-vertx__vert.x-2366 | [
"2365"
] | 354abf0332a5218959c32f237b622bdfcd26faae | diff --git a/src/main/java/io/vertx/core/http/impl/Http1xServerConnection.java b/src/main/java/io/vertx/core/http/impl/Http1xServerConnection.java
--- a/src/main/java/io/vertx/core/http/impl/Http1xServerConnection.java
+++ b/src/main/java/io/vertx/core/http/impl/Http1xServerConnection.java
@@ -81,7 +81,6 @@ public clas... | diff --git a/src/test/java/io/vertx/test/core/Http1xTest.java b/src/test/java/io/vertx/test/core/Http1xTest.java
--- a/src/test/java/io/vertx/test/core/Http1xTest.java
+++ b/src/test/java/io/vertx/test/core/Http1xTest.java
@@ -1233,6 +1233,33 @@ public void testPipeliningLimit() throws Exception {
await();
}
... | HTTP server connection keeps processing pending pipelined requests when connection closed
Currently the HTTP server keeps processing pipelined HTTP messages when the connection is closed during the processing of a request and there are pending HTTP request in the server pipeline (i.e the response has not been sent). Th... | 2018-04-04T04:46:16Z | 3.5 | |
eclipse-vertx/vert.x | 2,309 | eclipse-vertx__vert.x-2309 | [
"2263"
] | 37d66d54317958c6c0b59436410f336f09a935fd | diff --git a/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java b/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
--- a/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
@@ -11,8 +11,23 @@
package io.vertx.core.http.impl;
-imp... | diff --git a/src/test/java/io/vertx/test/core/HttpTest.java b/src/test/java/io/vertx/test/core/HttpTest.java
--- a/src/test/java/io/vertx/test/core/HttpTest.java
+++ b/src/test/java/io/vertx/test/core/HttpTest.java
@@ -644,7 +644,7 @@ private void testURIAndPath(String uri, String path) {
@Test
public void test... | HttpClientImple DEFAULT_HANDLER uses uri.getQuery instead of getRawQuery when extract redirection uri from response location header
Hi,
I found that Vertx HttpClient DEFAULT_HANDLER uses java.net.URI.getQuery instead of getRawQuery when extracts a redirection uri from response location header.
Even Vertx HttpU... | I don't think there is a specific reason to getQuery. If you provide a
patch with a test which fails before the fix and passes after, it would
most certainly be merged.
2018-01-08 4:56 GMT+01:00 Jaehee Ahn <notifications@github.com>:
> Hi,
>
> I found that Vertx HttpClient DEFAULT_HANDLER uses java.net.URI.getQuery
>... | 2018-01-30T16:26:08Z | 3.5 |
eclipse-vertx/vert.x | 2,354 | eclipse-vertx__vert.x-2354 | [
"2353"
] | 087d9f48420ff657ca67cd6a36ce76c845abcac2 | diff --git a/src/main/java/io/vertx/core/buffer/Buffer.java b/src/main/java/io/vertx/core/buffer/Buffer.java
--- a/src/main/java/io/vertx/core/buffer/Buffer.java
+++ b/src/main/java/io/vertx/core/buffer/Buffer.java
@@ -19,6 +19,7 @@
import io.vertx.core.ServiceHelper;
import io.vertx.core.json.JsonArray;
import io.v... | diff --git a/src/test/java/io/vertx/test/core/LocalSharedDataTest.java b/src/test/java/io/vertx/test/core/LocalSharedDataTest.java
--- a/src/test/java/io/vertx/test/core/LocalSharedDataTest.java
+++ b/src/test/java/io/vertx/test/core/LocalSharedDataTest.java
@@ -15,11 +15,13 @@
import io.vertx.core.json.JsonArray;
im... | There is no proper way to store mutable objects in a local map
It is possible only for JsonObject, byte array and some other copyable objects known to vert.x.
It would be usefull to have mechanism to store mutable user objects in a local map if they can be copied.
| 2018-03-22T16:22:32Z | 3.5 | |
eclipse-vertx/vert.x | 2,209 | eclipse-vertx__vert.x-2209 | [
"2218"
] | fb75176407134802a23cb1f165dc0743ba308f9e | diff --git a/src/main/java/io/vertx/core/http/HttpClientRequest.java b/src/main/java/io/vertx/core/http/HttpClientRequest.java
--- a/src/main/java/io/vertx/core/http/HttpClientRequest.java
+++ b/src/main/java/io/vertx/core/http/HttpClientRequest.java
@@ -328,7 +328,7 @@ default boolean reset() {
* <p/>
* <ul>
... | diff --git a/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java b/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java
--- a/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java
+++ b/src/test/benchmarks/io/vertx/benchmarks/HttpServerHandlerBenchmark.java
@@ -1... | HttpClientResponse executed on the a different context thread when resumed outside of its context
I am trying to load the body of an HTTP request. However, in the data handler, I need to do stuff that is asynchronous. So I pause the stream at the beginning of the handler, and resume it when I'm done doing my asynchrono... | 2017-11-15T17:16:32Z | 3.5 | |
eclipse-vertx/vert.x | 2,108 | eclipse-vertx__vert.x-2108 | [
"1741"
] | 1591487a2f941e354cb9bb8419fc8a946defa216 | diff --git a/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBus.java b/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBus.java
--- a/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBus.java
+++ b/src/main/java/io/vertx/core/eventbus/impl/clustered/ClusteredEventBu... | diff --git a/src/test/java/io/vertx/test/core/RecordParserTest.java b/src/test/java/io/vertx/test/core/RecordParserTest.java
--- a/src/test/java/io/vertx/test/core/RecordParserTest.java
+++ b/src/test/java/io/vertx/test/core/RecordParserTest.java
@@ -19,14 +19,21 @@
import io.vertx.core.Handler;
import io.vertx.core.... | RecordParser implement ReadStream<Buffer>
That way we can trivially pump files or other ReadStream sources through it.
pump(asyncFile, recordParser)
| good idea, would you mind to contribute it ? | 2017-08-31T10:06:21Z | 3.5 |
eclipse-vertx/vert.x | 2,083 | eclipse-vertx__vert.x-2083 | [
"2059"
] | 7869b43c83e033f2f9ebfb247100b283e65105d5 | diff --git a/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java b/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
--- a/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
+++ b/src/main/java/io/vertx/core/http/impl/HttpClientImpl.java
@@ -153,7 +153,7 @@ public HttpClientImpl(VertxInternal vertx... | diff --git a/src/test/java/io/vertx/test/core/WebsocketTest.java b/src/test/java/io/vertx/test/core/WebsocketTest.java
--- a/src/test/java/io/vertx/test/core/WebsocketTest.java
+++ b/src/test/java/io/vertx/test/core/WebsocketTest.java
@@ -27,11 +27,25 @@
import io.vertx.core.Vertx;
import io.vertx.core.VertxOptions;
... | WebSocket request options not honored
```java
HttpClient client = vertx.createHttpClient(new HttpClientOptions());
RequestOptions options = new RequestOptions()
.setHost("ws.cex.io")
.setPort(443)
.setSsl(true)
.setURI("/ws");
client.websocket(options, ws -> {
});
``... | This code works
```java
HttpClient client = vertx.createHttpClient(new HttpClientOptions()
.setDefaultHost("ws.cex.io")
.setDefaultPort(443)
.setSsl(true));
client.websocket("/ws", ws -> {
});
``` | 2017-07-31T17:33:57Z | 3.4 |
eclipse-vertx/vert.x | 2,074 | eclipse-vertx__vert.x-2074 | [
"1375"
] | 71bf69e90d81a23ee658043c7cae8829939b6cee | diff --git a/src/main/java/io/vertx/core/impl/VertxImpl.java b/src/main/java/io/vertx/core/impl/VertxImpl.java
--- a/src/main/java/io/vertx/core/impl/VertxImpl.java
+++ b/src/main/java/io/vertx/core/impl/VertxImpl.java
@@ -204,19 +204,17 @@ private void createAndStartEventBus(VertxOptions options, Handler<AsyncResult<V... | diff --git a/src/test/java/io/vertx/test/core/ClusteredEventBusStartFailureTest.java b/src/test/java/io/vertx/test/core/ClusteredEventBusStartFailureTest.java
new file mode 100644
--- /dev/null
+++ b/src/test/java/io/vertx/test/core/ClusteredEventBusStartFailureTest.java
@@ -0,0 +1,54 @@
+/*
+ * Copyright (c) 2011-2017... | Vertx.clusteredVertx() handler not called if cannot bind to address
When starting clustered vetx instance:
``` java
Vertx.clusteredVertx(
new VertxOptions()
.setClustered(true)
.setClusterHost("127.0.0.1")
.setClusterPort(9999),
result ->
{
System... | would you mind to contribute a test for this and possibly a fix ?
| 2017-07-26T17:14:41Z | 3.4 |
eclipse-vertx/vert.x | 2,073 | eclipse-vertx__vert.x-2073 | [
"1486"
] | 71bf69e90d81a23ee658043c7cae8829939b6cee | diff --git a/src/main/generated/io/vertx/core/file/OpenOptionsConverter.java b/src/main/generated/io/vertx/core/file/OpenOptionsConverter.java
--- a/src/main/generated/io/vertx/core/file/OpenOptionsConverter.java
+++ b/src/main/generated/io/vertx/core/file/OpenOptionsConverter.java
@@ -27,6 +27,9 @@
public class OpenO... | diff --git a/src/test/java/io/vertx/test/core/FileSystemTest.java b/src/test/java/io/vertx/test/core/FileSystemTest.java
--- a/src/test/java/io/vertx/test/core/FileSystemTest.java
+++ b/src/test/java/io/vertx/test/core/FileSystemTest.java
@@ -1162,11 +1162,9 @@ public void testWriteStreamAppend() throws Exception {
... | Allow AsyncFile's to be opened in append mode
Appending to a file requires three steps:
1. Open the file with `FileSystem.open()` with an `OpenOptions` object on which `setTruncateExisting(false)` and `setWrite(true)` have been called.
2. Get the file properties with `FileSystem.props()`
3. Call `setWritePos()` on the ... | 2017-07-26T16:39:07Z | 3.4 | |
eclipse-vertx/vert.x | 2,064 | eclipse-vertx__vert.x-2064 | [
"2027"
] | 349ddf91172dafaf16ed6639469ba80aa75d204c | diff --git a/src/main/java/io/vertx/core/http/impl/ServerConnection.java b/src/main/java/io/vertx/core/http/impl/ServerConnection.java
--- a/src/main/java/io/vertx/core/http/impl/ServerConnection.java
+++ b/src/main/java/io/vertx/core/http/impl/ServerConnection.java
@@ -43,6 +43,7 @@
import io.vertx.core.AsyncResult;
... | diff --git a/src/test/java/io/vertx/test/core/Http1xTest.java b/src/test/java/io/vertx/test/core/Http1xTest.java
--- a/src/test/java/io/vertx/test/core/Http1xTest.java
+++ b/src/test/java/io/vertx/test/core/Http1xTest.java
@@ -3397,7 +3397,7 @@ public void testInvalidTrailerInHttpServerRequest() throws Exception {
... | HttpServerRequest exception handler is not called when the connection is closed
`HttpServerRequest` extends `ReadStream<Buffer>`. When there is an ongoing file upload and the connection closes abruptly, the exception handler on the `HttpServerRequest` should be called to signal that the stream an error occured
| note : works with HTTP/2 not HTTP/1.x | 2017-07-20T13:34:27Z | 3.4 |
eclipse-vertx/vert.x | 2,017 | eclipse-vertx__vert.x-2017 | [
"2012"
] | bf199bc643c400e11018ffb79f87d8a351da97e0 | diff --git a/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java b/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java
--- a/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java
+++ b/src/main/java/io/vertx/core/file/impl/AsyncFileImpl.java
@@ -148,11 +148,15 @@ private synchronized AsyncFile doWrite(Buff... | diff --git a/src/test/java/io/vertx/test/core/FileSystemTest.java b/src/test/java/io/vertx/test/core/FileSystemTest.java
--- a/src/test/java/io/vertx/test/core/FileSystemTest.java
+++ b/src/test/java/io/vertx/test/core/FileSystemTest.java
@@ -53,8 +53,10 @@
import java.util.HashSet;
import java.util.List;
import jav... | Race condition in AsyncFileImpl writesOutstanding
If an AsyncFileImpl is written to from a thread different to the context that created then the long counter writesOutstanding can get into an invalid state. This is because the counter is updated from both the caller's thread and also on the context when a write is comp... | a couple of questions:
- can you tell the unsynchronized write that happens ? is it the handler passed to the doWrite method that seems unsynchronized when called back
- is the atomicity of the long necessary ?
- could it be fixed using synchronized instead or setting the field as volatile ?
```
context... | 2017-06-11T19:34:15Z | 3.4 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.