repo
stringclasses
1 value
instance_id
stringlengths
22
24
problem_statement
stringlengths
24
24.1k
patch
stringlengths
0
1.9M
test_patch
stringclasses
1 value
created_at
stringdate
2022-11-25 05:12:07
2025-10-09 08:44:51
hints_text
stringlengths
11
235k
base_commit
stringlengths
40
40
test_instructions
stringlengths
0
232k
patch_line_additions
listlengths
0
217
patch_line_deletions
listlengths
0
218
file_extensions
listlengths
0
7
total_file_changes
int64
0
293
juspay/hyperswitch
juspay__hyperswitch-1123
Bug: [FEATURE] Implement `MerchantConnectorAccountInterface` for `MockDb` Spin off from #172. Refer to the parent issue for more information
diff --git a/crates/router/src/db/merchant_connector_account.rs b/crates/router/src/db/merchant_connector_account.rs index 997cc130c7d..05507593808 100644 --- a/crates/router/src/db/merchant_connector_account.rs +++ b/crates/router/src/db/merchant_connector_account.rs @@ -1,5 +1,6 @@ use common_utils::ext_traits::{Asy...
2023-05-23T22:38:06Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the databas...
7ef011ad737257fc83f7a43d16f1bf4ac54336ae
[ { "file_path": "crates/router/src/db/merchant_connector_account.rs", "lines": [ "use storage_models::merchant_connector_account::MerchantConnectorAccountUpdateInternal;\n", " merchant_connector_account: MerchantConnectorAccountUpdateInternal,\n", " merchant_connector_account:...
[ { "file_path": "crates/router/src/db/merchant_connector_account.rs", "lines": [ " merchant_connector_account: storage::MerchantConnectorAccountUpdateInternal,\n", " merchant_connector_account: storage::MerchantConnectorAccountUpdateInternal,\n", " // safety: only used for ...
[ "rs" ]
2
juspay/hyperswitch
juspay__hyperswitch-1121
Bug: [BUG] A connector side failure still executes mandate procedure ### Bug Description Consider a scenario where, we are creating a mandate, and there was a failure at the connector side, even in that case the mandate is created. The bug prominently affects `single_use` mandate. Where, in the recurring payment, ...
diff --git a/crates/router/src/core/mandate.rs b/crates/router/src/core/mandate.rs index a5afa04d348..c07a6499349 100644 --- a/crates/router/src/core/mandate.rs +++ b/crates/router/src/core/mandate.rs @@ -134,82 +134,85 @@ pub async fn mandate_procedure<F, FData>( where FData: MandateBehaviour, { - match resp...
2023-05-11T08:25:16Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description Consider a scenario where, we are creating a mandate, and there was a failure at the connector side...
cef8914372fa051f074e89fc76b76c6aee0d7bca
Postman and Manual
[ { "file_path": "crates/router/src/core/mandate.rs", "lines": [ " match resp.response {\n", " Err(_) => {}\n", " Ok(_) => match resp.request.get_mandate_id() {\n", " Some(mandate_id) => {\n", " let mandate_id = &mandate_id.mandate_id;\n...
[ { "file_path": "crates/router/src/core/mandate.rs", "lines": [ " match resp.request.get_mandate_id() {\n", " Some(mandate_id) => {\n", " let mandate_id = &mandate_id.mandate_id;\n", " let mandate = state\n", " .store\n", " ...
[ "rs" ]
1
juspay/hyperswitch
juspay__hyperswitch-1116
Bug: [FEATURE] Implement `EventInterface` for `MockDb` Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information.
diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs index ee9cd03e692..a260f016dc8 100644 --- a/crates/router/src/db.rs +++ b/crates/router/src/db.rs @@ -85,6 +85,7 @@ pub struct MockDb { redis: Arc<redis_interface::RedisConnectionPool>, api_keys: Arc<Mutex<Vec<storage::ApiKey>>>, cards_info: ...
2023-05-28T17:49:36Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API co...
597ec16907a83ce228228b8c00e329495ade117b
[ { "file_path": "crates/router/src/db.rs", "lines": [ " events: Arc<Mutex<Vec<storage::Event>>>,\n", " events: Default::default(),\n" ] }, { "file_path": "crates/router/src/db/events.rs", "lines": [ " event: storage::EventNew,\n", " let mut ...
[ { "file_path": "crates/router/src/db/events.rs", "lines": [ " _event: storage::EventNew,\n", " // [#172]: Implement function for `MockDb`\n", " Err(errors::StorageError::MockDbError)?\n", " _event_id: String,\n", " _event: storage::EventUpdate...
[ "rs" ]
2
juspay/hyperswitch
juspay__hyperswitch-1172
Bug: feat(connector):[Authorizedotnet] Capture flow for Authorizedotnet Manual Capture Flow for Authorizedotnet
diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs index 3e443286773..83e96138833 100644 --- a/crates/router/src/connector/authorizedotnet.rs +++ b/crates/router/src/connector/authorizedotnet.rs @@ -3,6 +3,7 @@ mod transformers; use std::fmt::Debug; +use co...
2023-05-15T20:46:20Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> This PR modifies following changes 1)add capture flow to auth...
919c03e679c4ebbb138509da52a18bface7ba319
<img width="1311" alt="Screenshot 2023-05-16 at 2 11 42 AM" src="https://github.com/juspay/hyperswitch/assets/121822803/7bd1769a-57a3-4de6-a096-71e410864d05">
[ { "file_path": "crates/router/src/connector/authorizedotnet.rs", "lines": [ "use common_utils::{crypto, ext_traits::ByteSliceExt};\n", " db::StorageInterface,\n", " services::{self, ConnectorIntegration},\n", " api::{self, ConnectorCommon, ConnectorCommonExt},\n", ...
[ { "file_path": "crates/router/src/connector/authorizedotnet.rs", "lines": [ " services::{self, logger},\n", " api::{self, ConnectorCommon},\n", " services::ConnectorIntegration<\n", "impl\n", " services::ConnectorIntegration<\n", " api::Session,\n",...
[ "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-1113
Bug: [FEATURE] mandate type to be sent by the `merchant` ### Feature Description In the current scenario, the `mandate type` object has to be sent in the `confirm` call. But this decision has to be taken by the `Merchant` during the `payments_create` call. So we should allow the merchant to pass mandate type and th...
diff --git a/Cargo.lock b/Cargo.lock index fb22127838b..da0033c8336 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3000,7 +3000,7 @@ dependencies = [ [[package]] name = "opentelemetry" version = "0.18.0" -source = "git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#4...
2023-05-17T13:40:22Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description **Current Implementation** In order to create a mandate, the merchant has to provide both `mandate...
2d49ce56de5ed314aa099f3ce4aa569b3e22b561
![Screenshot 2023-05-17 at 7 08 08 PM](https://github.com/juspay/hyperswitch/assets/51093026/ddb9e158-3093-4747-8d19-6953e05403c9) This is the initial payment with `confirm: false` ![Screenshot 2023-05-17 at 7 09 04 PM](https://github.com/juspay/hyperswitch/assets/51093026/6f6d69e8-f0a7-4ef6-9970-eeaf4aabadff) This ...
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0a...
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b...
[ "sql", "rs", "lock" ]
21
juspay/hyperswitch
juspay__hyperswitch-1102
Bug: [BUG] Validate payment method type in payments request against given payment method data for non-card flows ### Bug Description The payments flow currently does not validate the payment method type given in the payments request against the given payment method data for non-card flows. ### Expected Behavior T...
diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs index 25450aaf22c..74e1791b051 100644 --- a/crates/router/src/core/payments/helpers.rs +++ b/crates/router/src/core/payments/helpers.rs @@ -37,6 +37,7 @@ use crate::{ types::{self, AsyncLift}, }, ...
2023-05-23T08:58:21Z
## Type of Change - [x] Bugfix - [x] New feature ## Description Added the following checks for non-card flows : 1. Check if `payment_method_type` is specified. 2. Check if the specified `payment_method_type` corresponds to the parent `payment_method`. 3. Check if the specified `payment_method_data` corre...
7f947169feac9d15616cc2b1a2aacdfa80f219bf
[ { "file_path": "crates/router/src/core/payments/helpers.rs", "lines": [ " transformers::ForeignInto,\n", " utils::when(\n", " !matches!(\n", " req.payment_method,\n", " Some(api_enums::PaymentMethod::Card) | None\n", " ) && (r...
[]
[ "rs" ]
1
juspay/hyperswitch
juspay__hyperswitch-1115
Bug: [FEATURE] Implement `ReverseLookupInterface` for `MockDb` Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information.
diff --git a/Cargo.lock b/Cargo.lock index 50e5e015a9b..a30738c69da 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -297,6 +297,12 @@ version = "1.0.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe" +[[package]] +name = "adl...
2023-09-11T07:22:06Z
Implement the missing implementation of `MockDb` for `ReverseLookup` Closes #1115 ## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe you...
a81bfe28edd7fc543af19b9546cbe30492716c97
[ { "file_path": "Cargo.lock", "lines": [ "[[package]]\n", "name = \"adler32\"\n", "version = \"1.2.0\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"aae1277d39aeec15cb388266ecc24b11c80469deae6067e17a1a7aa9e5c1f234\"\n", "\n", ...
[ { "file_path": "Cargo.lock", "lines": [ " \"frunk\",\n", " \"frunk_core\",\n", " \"strum\",\n", " \"rustix\",\n", " \"syn 2.0.18\",\n", "version = \"0.1.68\"\n", "checksum = \"b9ccdd8f2a161be9bd5c023df56f1b2a0bd1d83872ae53b71a84a12c9bf6e842\"\n", " \"syn 2.0.1...
[ "rs", "lock" ]
4
juspay/hyperswitch
juspay__hyperswitch-1091
Bug: [FEATURE] add support for filtering in `payments_session` ### Feature Description After supporting multiple connector accounts through `business_label` , `business_country` and `business_sub_label`, PaymentsSession flow ( creating session tokens - wallets ) should filter based on this. ### Possible Implementa...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index b3c7c031c5e..8e12da732bb 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -838,7 +838,8 @@ pub async fn list_payment_methods( ...
2023-05-11T11:58:25Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Refactoring ## Description <!-- Describe your changes in detail --> - This PR refactors the get connector function of `PaymentsSession` operation to use idiomatic rust. - Add business country and business label filtering. <!-- Provide l...
f790099368ed6ed73ecc729cb18b85e0c6b5f809
Tested manually. - Create payments - Create session token - With `wallets` fields as empty list <img width="1195" alt="Screenshot 2023-05-11 at 6 27 48 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/2bae4c34-92d5-49ef-9aa2-80c31800052e"> - With `wallets` field as `google_pay` only <im...
[ { "file_path": "crates/router/src/core/payment_methods/cards.rs", "lines": [ " let filtered_mcas =\n", " helpers::filter_mca_based_on_business_details(all_mcas, payment_intent.as_ref());\n" ] }, { "file_path": "crates/router/src/core/payments.rs", "lines": [ " ...
[ { "file_path": "crates/router/src/core/payment_methods/cards.rs", "lines": [ " let filtered_mcas = filter_mca_based_on_business_details(all_mcas, payment_intent.as_ref());\n", "fn filter_mca_based_on_business_details(\n", " merchant_connector_accounts: Vec<\n", " storage...
[ "rs" ]
13
juspay/hyperswitch
juspay__hyperswitch-1095
Bug: [FEATURE] Setting up process tracker to schedule email ### Feature description - Since expiry of the api_key would start right from its creation, while creating an api_key, insert a db entry into process_tracker table with new process_tracker workflow `ApiKeyExpiryWorkflow` and write logic for sending email b...
diff --git a/crates/common_utils/src/ext_traits.rs b/crates/common_utils/src/ext_traits.rs index 82553f41bc5..fec0446b161 100644 --- a/crates/common_utils/src/ext_traits.rs +++ b/crates/common_utils/src/ext_traits.rs @@ -8,7 +8,10 @@ use masking::{ExposeInterface, Secret, Strategy}; use quick_xml::de; use serde::{Des...
2023-05-22T18:00:04Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> When an api_key is about to expire, we are currently not notify...
6ec6272f2acae6d5cb5e3120b2dbcc87ae2875ec
Manually. For testing purpose, I scheduled an email 3, 2 and 1 minutes prior to api_key expiry. Api-key creation with expiry set - ![api_key](https://github.com/juspay/hyperswitch/assets/70657455/54363761-4974-419b-a090-fcd205a70fb8) Email-1 scheduled 3 minutes prior to expiry - ![1](https://github.com/j...
[ { "file_path": "crates/common_utils/src/ext_traits.rs", "lines": [ "use crate::{\n", " crypto,\n", " errors::{self, CustomResult},\n", "};\n", "impl<E: ValueExt + Clone> ValueExt for crypto::Encryptable<E> {\n", " fn parse_value<T>(self, type_name: &'static str) ...
[ { "file_path": "crates/common_utils/src/ext_traits.rs", "lines": [ "use crate::errors::{self, CustomResult};\n" ] }, { "file_path": "crates/router/src/configs/settings.rs", "lines": [ "#[derive(Debug, Deserialize, Clone, Default)]\n" ] }, { "file_path": "crates/router...
[ "rs" ]
10
juspay/hyperswitch
juspay__hyperswitch-1067
Bug: [FEATURE] Add BNPL for Nuvei payment processor Add Buy Now Pay Later support for Nuvei
diff --git a/crates/router/src/connector/nuvei/transformers.rs b/crates/router/src/connector/nuvei/transformers.rs index 1653ecdc849..4fc70bba81d 100644 --- a/crates/router/src/connector/nuvei/transformers.rs +++ b/crates/router/src/connector/nuvei/transformers.rs @@ -177,6 +177,10 @@ pub enum AlternativePaymentMethodT...
2023-05-08T21:15:52Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> add payment methods like klarna, afterpay support for Nuvei con...
aa610c49f5a24e3e858515d9dfe0872d43251ee5
Since Nuvei is a closed connector, couldn't test it successfully as it needs enabling the payment method - Klarna and AfterPay. <img width="1276" alt="Screenshot 2023-05-09 at 2 14 08 AM" src="https://user-images.githubusercontent.com/70575890/236936491-ade451cc-8816-4303-b07a-beeb9c6ca457.png"> <img width="1250"...
[ { "file_path": "crates/router/src/connector/nuvei/transformers.rs", "lines": [ " #[serde(rename = \"apmgw_Afterpay\")]\n", " AfterPay,\n", " #[serde(rename = \"apmgw_Klarna\")]\n", " Klarna,\n", "fn get_pay_later_info<F>(\n", " payment_method_type: Alternat...
[]
[ "rs" ]
1
juspay/hyperswitch
juspay__hyperswitch-1094
Bug: [FEATURE] Implement email service implement an email service to OSS. The integration allows us to send emails to our merchants directly from our OSS and helps us to enhance the application experience. Use AWS SES (Simple Email Service) service to develop and build email communications.
diff --git a/Cargo.lock b/Cargo.lock index b504c3db426..da0033c8336 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -598,9 +598,9 @@ dependencies = [ [[package]] name = "aws-credential-types" -version = "0.55.1" +version = "0.55.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f4232d372...
2023-05-15T09:27:00Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Integrate an email service to OSS. The integration allows us to...
ea9814531880584435c122b3e32e9883e4518fd2
Manual
[ { "file_path": "Cargo.lock", "lines": [ "version = \"0.55.2\"\n", "checksum = \"4cb57ac6088805821f78d282c0ba8aec809f11cbee10dda19a97b03ab040ccc2\"\n", "version = \"0.55.2\"\n", "checksum = \"9c5f6f84a4f46f95a9bb71d9300b73cd67eb868bc43ae84f66ad34752299f4ac\"\n", "version = \"0.5...
[ { "file_path": "Cargo.lock", "lines": [ "version = \"0.55.1\"\n", "checksum = \"f4232d3729eefc287adc0d5a8adc97b7d94eefffe6bbe94312cc86c7ab6b06ce\"\n", "version = \"0.55.1\"\n", "checksum = \"87f04ab03b3f1cca91f7cccaa213056d732accb14e2e65debfacc1d28627d162\"\n", "version = \"0.5...
[ "toml", "lock", "rs" ]
9
juspay/hyperswitch
juspay__hyperswitch-1088
Bug: feat: in memory cache for merchant account and merchant connector account
diff --git a/crates/common_utils/src/errors.rs b/crates/common_utils/src/errors.rs index de776954e71..ba324e0b260 100644 --- a/crates/common_utils/src/errors.rs +++ b/crates/common_utils/src/errors.rs @@ -27,7 +27,7 @@ pub enum ParsingError { /// Validation errors. #[allow(missing_docs)] // Only to prevent warnings...
2023-05-09T09:47:09Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> Added accounts in memory cache static. This also seperates publisher key through `CacheKind` enum so the publisher publishes the key into the channel in the form of `{cachekind...
fee0e9dadd2e20c5c75dcee50de0e53f4e5e6deb
Manual
[ { "file_path": "crates/common_utils/src/errors.rs", "lines": [ "#[derive(Debug, thiserror::Error, Clone)]\n" ] }, { "file_path": "crates/redis_interface/src/errors.rs", "lines": [ " #[error(\"Failed while receiving message from publisher\")]\n", " OnMessageError,\n" ...
[ { "file_path": "crates/common_utils/src/errors.rs", "lines": [ "#[derive(Debug, thiserror::Error)]\n" ] }, { "file_path": "crates/router/src/cache.rs", "lines": [ "use std::{any::Any, sync::Arc};\n", "pub static CONFIG_CACHE: Lazy<Cache> = Lazy::new(|| Cache::new(CACHE_TTL,...
[ "rs" ]
8
juspay/hyperswitch
juspay__hyperswitch-1118
Bug: [BUG] docs: `amount` and `currency` are optional in OpenAPI docs ### Bug Description The error ```json { "error": { "type": "invalid_request", "message": "Missing required param: currency", "code": "IR_04" } } ``` Is thrown when creating a payment with no fields in t...
diff --git a/Cargo.lock b/Cargo.lock index b504c3db426..6cb3e124104 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2970,7 +2970,7 @@ dependencies = [ [[package]] name = "opentelemetry" version = "0.18.0" -source = "git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#4...
2023-05-17T10:15:11Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> This PR will allow us to specify which fields are mandatory in `PaymentsRequest` for a particular flow. A new macro is added called `PolymorphicSchema` ( Name is open for disc...
07e0fcbe06107e8be532b4e9a1e1a1ef6efba68e
Manually. Generate the openapi file and check if fields are marked as mandatory.
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0a...
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b...
[ "json", "rs", "lock" ]
16
juspay/hyperswitch
juspay__hyperswitch-1061
Bug: [Feature] Bank redirect support (IDeal, Giropay) for worldline This issue is regarding Bank redirect(Ideal ,Giropay) support for worldline
diff --git a/Cargo.lock b/Cargo.lock index 3ef85ac8f6a..a310cff5c1a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2968,7 +2968,7 @@ dependencies = [ [[package]] name = "opentelemetry" version = "0.18.0" -source = "git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44...
2023-05-05T14:16:07Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> This PR has following changes 1)Bank Redirects (Ideal and gi...
3fe24b3255039d6a5dff59203ffcfd024ff0d60b
**tested existing card payment** <img width="871" alt="Screenshot 2023-05-05 at 7 14 48 PM" src="https://user-images.githubusercontent.com/121822803/236483230-2eebf35a-ccf1-4661-ab59-4bc8becc34f2.png"> **tested bank redirects using postman** **Giropay** <img width="1285" alt="Screenshot 2023-05-05 at 4 59 1...
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b...
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0a...
[ "rs", "lock" ]
3
juspay/hyperswitch
juspay__hyperswitch-1053
Bug: [ENHANCEMENT] Add `id` field in `MerchantConnectorAccountNotFound` error type ### Feature Description A `MerchantConnectorAccountNotFound` will occur when using `merchant_id` and `merchant_connector_id` to select a row from the `merchant_connector_account` table if there is no row in the table that matches t...
diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs index f1099a09da8..cec4b738039 100644 --- a/crates/router/src/compatibility/stripe/errors.rs +++ b/crates/router/src/compatibility/stripe/errors.rs @@ -88,8 +88,8 @@ pub enum StripeErrorCode { #[error(e...
2023-05-09T17:17:29Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Add `id` field to `MerchantConnectorAccountNotFound`, Send `co...
3fe24b3255039d6a5dff59203ffcfd024ff0d60b
[ { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " #[error(error_type = StripeErrorType::InvalidRequestError, code = \"resource_missing\", message = \"Merchant connector account with id '{id}' does not exist in our records\")]\n", " MerchantConnectorAccountNotF...
[ { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " #[error(error_type = StripeErrorType::InvalidRequestError, code = \"resource_missing\", message = \"No such merchant connector account\")]\n", " MerchantConnectorAccountNotFound,\n", " errors::...
[ "rs" ]
4
juspay/hyperswitch
juspay__hyperswitch-1042
Bug: [FEATURE] replace manual implementation using `from_str` function of strum ### Feature Description In the `convert_connector` function the manual implementation of converting the connector from string can be replaced using the `from_str` function provided by `strum` ### Possible Implementation Use `from_str...
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index 476d121eec5..be33941e033 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -567,7 +567,6 @@ pub enum MandateStatus { Clone, Copy, Debug, - Default, Eq, PartialEq, ToSchem...
2023-05-04T13:23:42Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> - fixes #1042 - added test cases for type conversions ### ...
bc5497f03ab7fde585e7c57815f55cf7b4b8d475
- added 3 unit tests supporting the change
[ { "file_path": "crates/router/src/types/api.rs", "lines": [ " match enums::Connector::from_str(connector_name) {\n", " Ok(name) => match name {\n", " enums::Connector::Aci => Ok(Box::new(&connector::Aci)),\n", " enums::Connector::Adyen ...
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ " Default,\n", " Applepay,\n", " #[default]\n", " Dummy,\n", " Signifyd,\n" ] }, { "file_path": "crates/router/src/types/api.rs", "lines": [ " match connector_name {\n", ...
[ "rs" ]
5
juspay/hyperswitch
juspay__hyperswitch-1035
Bug: [BUG] panic on RedisPoolConnection close. ### Bug Description Currently the RedisPoolConnection close panics on [this line](https://github.com/juspay/hyperswitch/blob/ed99655ebc11d53f4b2ffcb8c0eb9ef6b56f32c4/crates/router/src/bin/router.rs#L47). The root cause of this issue is `Arc::get_mut` throws None when...
diff --git a/crates/drainer/src/main.rs b/crates/drainer/src/main.rs index c9a8533a43f..a8b63e14477 100644 --- a/crates/drainer/src/main.rs +++ b/crates/drainer/src/main.rs @@ -33,6 +33,5 @@ async fn main() -> DrainerResult<()> { ) .await?; - store.close().await; Ok(()) } diff --git a/crates/draine...
2023-05-04T12:03:35Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix ## Description <!-- Describe your changes in detail --> This fixes #1035 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you do...
68360d4d6a31d8d7361c83021ca3049780d6d0a3
Manual
[ { "file_path": "crates/redis_interface/src/lib.rs", "lines": [ "impl Drop for RedisConnectionPool {\n", " fn drop(&mut self) {\n", " let rt = tokio::runtime::Handle::current();\n", " rt.block_on(self.close_connections())\n", " }\n", "}\n", "\n" ...
[ { "file_path": "crates/drainer/src/main.rs", "lines": [ " store.close().await;\n" ] }, { "file_path": "crates/drainer/src/services.rs", "lines": [ "\n", " #[allow(clippy::expect_used)]\n", " pub async fn close(mut self: Arc<Self>) {\n", " Arc::ge...
[ "rs" ]
8
juspay/hyperswitch
juspay__hyperswitch-1066
Bug: [FEATURE] Add Bank redirects for Paypal payment processor Add Bank redirect support for Paypal
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index 0d1b3f8f9b6..248525fcc40 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -665,3 +665,13 @@ pub struct TokenizedBankTransferValue1 { pub struct TokenizedBankTran...
2023-05-10T10:07:42Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Add bank redirects - Ideal, Eps, Giropay, and Sofort for Paypal...
f5c0544e5a6f990b3d475146c9faab8350b5047a
Tested using postman. <img width="1264" alt="Screenshot 2023-05-10 at 2 54 12 PM" src="https://github.com/juspay/hyperswitch/assets/70575890/4959d087-59eb-446e-8d16-d8300a48fe4a"> <img width="1240" alt="Screenshot 2023-05-10 at 2 55 11 PM" src="https://github.com/juspay/hyperswitch/assets/70575890/0cfbd9f7-a745-4...
[ { "file_path": "crates/api_models/src/payment_methods.rs", "lines": [ "\n", "#[derive(Debug, serde::Serialize, serde::Deserialize)]\n", "pub struct TokenizedBankRedirectValue1 {\n", " pub data: payments::BankRedirectData,\n", "}\n", "\n", "#[derive(Debug, serde::...
[ { "file_path": "crates/router/src/connector/paypal.rs", "lines": [ " Some(diesel_models::enums::PaymentMethod::Wallet) => {\n", " diesel_models::enums::PaymentMethod::Wallet => {\n", " diesel_models::enums::PaymentMethod::Wallet => Ok(format!(\n", " ...
[ "rs", "json" ]
9
juspay/hyperswitch
juspay__hyperswitch-1028
Bug: [FEATURE]:Payments of statuses like requires_payment_method, requires_capture, requires_confirmation, requires_action can be cancelled ### Feature Description When trying the below curl, getting the following error ``` curl --location 'https://sandbox.hyperswitch.io/payments/pay_GqU4LxURmOgj4W9iZXeG/cance...
diff --git a/crates/router/src/core/payments/operations/payment_cancel.rs b/crates/router/src/core/payments/operations/payment_cancel.rs index f589b61745d..9c613cf782a 100644 --- a/crates/router/src/core/payments/operations/payment_cancel.rs +++ b/crates/router/src/core/payments/operations/payment_cancel.rs @@ -53,6 +5...
2023-05-02T10:50:27Z
requires_payment_method, requires_capture, requires_confirmation, requires_action ## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description Previously while can...
736a236651523b7f72ff95ad9223f4dda875301a
Tested it by using postman as now we are able to cancel the payment in all those cases.
[ { "file_path": "crates/router/src/core/payments/operations/payment_cancel.rs", "lines": [ " helpers::validate_payment_status_against_not_allowed_statuses(\n", " &payment_intent.status,\n", " &[\n", " enums::IntentStatus::Failed,\n", "...
[ { "file_path": "crates/router/src/core/payments/operations/payment_cancel.rs", "lines": [ " match payment_intent.status {\n", " status if status != enums::IntentStatus::RequiresCapture => {\n", " Err(errors::ApiErrorResponse::InvalidRequestData {\n", ...
[ "rs" ]
2
juspay/hyperswitch
juspay__hyperswitch-1039
Bug: [FEATURE] Use proxy exclusion instead of a separate proxied client ### Feature Description Currently we provide the option for proxying all external requests made to Connectors. We also use reqwest clients to make API calls to basilisk/locker or other utilities. Recently we started reusing the `reqwest::Cli...
diff --git a/config/config.example.toml b/config/config.example.toml index eb30435d5f8..821e854c9fa 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -23,11 +23,10 @@ certificate = "/path/to/certificate.pem" # Proxy server configuration for connecting to payment gateways. # Don't define the ...
2024-12-29T12:26:39Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> This PR refactors the logic for excluding specific HTTP / HTT...
dbe0cd4d2c368293bec22e2e83571a90b8ce3ee3
Locally, by setting up [`mitmproxy`](https://mitmproxy.org) as a proxy for outgoing HTTP and HTTPS traffic. I also set up our card vault locally to simulate an internal service running close to the application. I ran `mitmproxy` using the command: ```shell mitmweb --listen-port 8090 --web-port 8091 ``` A...
[ { "file_path": "config/config.example.toml", "lines": [ "# http_url = \"http proxy url\" # Proxy all HTTP traffic via this proxy\n", "# https_url = \"https proxy url\" # Proxy all HTTPS traffic via this proxy\n", "idle_pool_connection_timeout = 90 ...
[ { "file_path": "config/config.example.toml", "lines": [ "# http_url = \"http proxy url\" # Proxy all HTTP traffic via this proxy\n", "# https_url = \"https proxy url\" # Proxy all HTTPS traffic via this proxy\n", "idle_pool_connection_timeout = 90 # Timeout for idle pool connections (def...
[ "toml", "rs" ]
10
juspay/hyperswitch
juspay__hyperswitch-1023
Bug: [BUG] : `connector_name` in `MerchantConnectorCreate` accepts any value ### Bug Description When creating a merchant connector account, the `connector_name` field is of string type. This would mean that any value can be passed to that field. There is no check done to validate whether the connector name given, ...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index e7164a2493f..895b137679c 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -391,8 +391,8 @@ pub struct MerchantConnectorCreate { #[schema(value_type = ConnectorType, example = "payment_processor")] ...
2023-07-06T12:59:54Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description When creating a merchant connector account, the connector_name field is of string type. This would mean t...
d5891ecbd4a110e3885d6504194f7c7811a413d3
Used Postman Call Payment Connector - Create to test the changes Testing with a random connector and <img width="1514" alt="Screenshot 2023-07-06 at 6 45 53 PM" src="https://github.com/juspay/hyperswitch/assets/41580413/16c4f694-0422-4c08-b7d9-08eec169b6ff"> a supported connector: <img width="1514" alt="Screenshot...
[ { "file_path": "crates/api_models/src/admin.rs", "lines": [ " #[schema(value_type = Connector, example = \"stripe\")]\n", " pub connector_name: api_enums::Connector,\n" ] }, { "file_path": "crates/router/src/core/admin.rs", "lines": [ " &req.connector_name.to_s...
[ { "file_path": "crates/api_models/src/admin.rs", "lines": [ " #[schema(example = \"stripe\")]\n", " pub connector_name: String,\n" ] }, { "file_path": "crates/router/src/core/admin.rs", "lines": [ " &req.connector_name,\n", " connector_name: req.co...
[ "rs", "json" ]
3
juspay/hyperswitch
juspay__hyperswitch-1045
Bug: Implement verify flow for Adyen Implement Verify flow for the connectors. Verify flow makes sure if the card is valid or not for future payments like mandate etc.
diff --git a/config/development.toml b/config/development.toml index ad0b5891d23..3ef6509f46f 100644 --- a/config/development.toml +++ b/config/development.toml @@ -229,7 +229,7 @@ stripe = { long_lived_token = false, payment_method = "wallet", payment_method_t checkout = { long_lived_token = false, payment_method = "...
2023-05-03T20:12:21Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [X] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Add mandate support for gpay, apple_pay and klarna Closes #104...
5c5c3ef3831991ccfefd9b0561f5eac976ed2191
<img width="1123" alt="Screen Shot 2023-05-04 at 1 27 01 AM" src="https://user-images.githubusercontent.com/20727598/236036746-0811f3e0-99c3-4096-9a9d-17e4305d7346.png">
[ { "file_path": "config/development.toml", "lines": [ "connector_list = \"bluesnap,stripe\"\n" ] }, { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " errors::ApiErrorResponse::MandateUpdateFailed\n", " | errors::ApiErrorRes...
[ { "file_path": "config/development.toml", "lines": [ "connector_list = \"bluesnap, stripe\"\n" ] }, { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " errors::ApiErrorResponse::InternalServerError => Self::InternalServerError, // not a stri...
[ "toml", "rs" ]
23
juspay/hyperswitch
juspay__hyperswitch-1000
Bug: [FEATURE] Client Secret Expiry ### Feature Description We need to implement a TTL (Time to Live) for client secret so that once it expires there can be certain restriction on Payment Intent and even no further actions on Intent too. ### Possible Implementation Possible implementation is to create a field in...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index df245fbfad5..52524aea8c3 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -75,6 +75,10 @@ pub struct MerchantAccountCreate { #[cfg(not(feature = "multiple_mca"))] #[schema(value_type = Option<...
2023-04-22T07:29:20Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [x] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description We have added a new Optional field in MerchantAccount table i.e intent_fulfillment_time that will set by ...
9240e16ae4e4f4092a7f64f09ba1fcb058e0cdcf
Written 3 tests which verifies 1. Client secret is itself mismatching or not from req and from payment intent. 2. intent_filfillment_time once expired should throw error. 3. intent_fulfillment_time not expired should pass the test.
[ { "file_path": "crates/api_models/src/admin.rs", "lines": [ " ///Will be used to expire client secret after certain amount of time to be supplied in seconds\n", " ///(900) for 15 mins\n", " #[schema(example = 900)]\n", " pub intent_fulfillment_time: Option<u32>,\n", ...
[ { "file_path": "crates/router/src/core/admin.rs", "lines": [ "\n" ] }, { "file_path": "crates/router/src/core/cards_info.rs", "lines": [ " helpers::verify_client_secret(\n", " merchant_account.storage_scheme,\n", " &merchant_account.merchant_id,\n" ...
[ "sql", "rs" ]
21
juspay/hyperswitch
juspay__hyperswitch-1011
Bug: [FEATURE] Making CVV optional field for payments flow ### Feature Description CVV should be Optional and should only be passed for first time payment else depending upon use cases we don't need to pass the CVV. It gets handeled by the conntector itslef ### Possible Implementation We need to make the CVV fi...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 3740c996ed3..a8c69d04e52 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -520,6 +520,7 @@ pub enum PaymentMethodData { BankRedirect(BankRedirectData), BankDebit(BankDebitData), ...
2023-05-02T18:25:25Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [X] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> For Recurring mandate payments we don't need payment_method_dat...
3d05e50abcb92fe7e6c4472faafc03fb70920048
[ { "file_path": "crates/api_models/src/payments.rs", "lines": [ " MandatePayment,\n", " MandatePayment {},\n", " PaymentMethodData::MandatePayment => Self::MandatePayment {},\n", " MandatePayment,\n", " PaymentMethodData::MandatePayment => Self::Ma...
[ { "file_path": "crates/router/src/connector/aci/transformers.rs", "lines": [ " api::PaymentMethodData::Crypto(_) | api::PaymentMethodData::BankDebit(_) => {\n" ] }, { "file_path": "crates/router/src/connector/authorizedotnet/transformers.rs", "lines": [ " ap...
[ "rs" ]
7
juspay/hyperswitch
juspay__hyperswitch-997
Bug: [FEATURE] Implement `ConfigInterface` for `MockDb` Spin out from #172. Please refer to that issue for more information.
diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs index 0694b5a3020..0bc43e6d567 100644 --- a/crates/router/src/db.rs +++ b/crates/router/src/db.rs @@ -98,6 +98,7 @@ impl StorageInterface for Store {} #[derive(Clone)] pub struct MockDb { addresses: Arc<Mutex<Vec<storage::Address>>>, + configs: Ar...
2023-07-02T10:03:22Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API co...
47cd08a0b07d457793d376b6cca3143011426f22
[ { "file_path": "crates/router/src/db.rs", "lines": [ " configs: Arc<Mutex<Vec<storage::Config>>>,\n", " configs: Default::default(),\n" ] }, { "file_path": "crates/router/src/db/configs.rs", "lines": [ "use storage_models::configs::ConfigUpdateInternal;\n", ...
[ { "file_path": "crates/router/src/db/configs.rs", "lines": [ " _config: storage::ConfigNew,\n", " // [#172]: Implement function for `MockDb`\n", " Err(errors::StorageError::MockDbError)?\n", " _key: &str,\n", " // [#172]: Implement function fo...
[ "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-996
Bug: [FEATURE] Implement `ApiKeyInterface` for `MockDb` Spin out from #172. Please refer to that issue for more information.
diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs index 89d51908cdf..2b55db74a62 100644 --- a/crates/router/src/db.rs +++ b/crates/router/src/db.rs @@ -82,6 +82,7 @@ pub struct MockDb { processes: Arc<Mutex<Vec<storage::ProcessTracker>>>, connector_response: Arc<Mutex<Vec<storage::ConnectorRespon...
2023-05-09T22:50:45Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Stores API keys in a vector in `MockDB`. ### Additional Chan...
32a3722f073c3ea22220abfa62034e476ee8acef
Wrote a unit test (included in the PR, but ignored). It passes locally if I make some unrelated changes to allow the test to run without needing redis, but I have it ignored for now because of that (the tests can probably be removed too, they arent vital just wanted to verify it worked)
[ { "file_path": "crates/router/src/db.rs", "lines": [ " api_keys: Arc<Mutex<Vec<storage::ApiKey>>>,\n", " api_keys: Default::default(),\n" ] }, { "file_path": "crates/router/src/db/api_keys.rs", "lines": [ " api_key: storage::ApiKeyNew,\n", " ...
[ { "file_path": "crates/router/src/db/api_keys.rs", "lines": [ " _api_key: storage::ApiKeyNew,\n", " // [#172]: Implement function for `MockDb`\n", " Err(errors::StorageError::MockDbError)?\n", " _merchant_id: String,\n", " _key_id: String,\n",...
[ "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-995
Bug: [FEATURE] add a route that will invalidate cache ### Feature Description Currently we don't have any way to manually invalidate cache that's stored in redis and in-memory, Add a route that given a key will invalidate both of redis and inmemory cache. ### Possible Implementation So the in memory cache current...
diff --git a/crates/drainer/src/utils.rs b/crates/drainer/src/utils.rs index c06615759f1..7ba10185952 100644 --- a/crates/drainer/src/utils.rs +++ b/crates/drainer/src/utils.rs @@ -96,11 +96,14 @@ pub async fn make_stream_available( stream_name_flag: &str, redis: &redis::RedisConnectionPool, ) -> errors::Dra...
2023-05-09T21:42:02Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description A new route to invalidate the in-memory cache and redis ### Additional Changes - [ ] This PR modi...
3e64321bfd25cfeb6b02b70188c8e08b3cd4bfcc
A unit test is added to test the in-memory cache and postman script used for redis cache.
[ { "file_path": "crates/drainer/src/utils.rs", "lines": [ " match redis.delete_key(stream_name_flag).await {\n", " Ok(redis::DelReply::KeyDeleted) => Ok(()),\n", " Ok(redis::DelReply::KeyNotDeleted) => {\n", " logger::error!(\"Tried to unlock a stream which...
[ { "file_path": "crates/drainer/src/utils.rs", "lines": [ " redis\n", " .delete_key(stream_name_flag)\n", " .await\n", " .map_err(DrainerError::from)\n", " .into_report()\n" ] }, { "file_path": "crates/redis_interface/src/commands.rs", ...
[ "rs" ]
14
juspay/hyperswitch
juspay__hyperswitch-988
Bug: [FEATURE] Add a Filter for Payment Methods Visibility only if It allows the requested capture Method ### Feature Description There should be only those Payment Methods Visible in **Payments Method's list** that supports the applied **Capture type**. For a concise **example** If Merchant has provided for man...
diff --git a/config/development.toml b/config/development.toml index 07a005ae9a2..7ba940bc582 100644 --- a/config/development.toml +++ b/config/development.toml @@ -177,9 +177,33 @@ ideal = { country = "NL", currency = "EUR" } [pm_filters.braintree] paypal = { currency = "AUD,BRL,CAD,CNY,CZK,DKK,EUR,HKD,HUF,ILS,JPY...
2023-04-26T12:59:19Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description We are adding a filter for the payment methods list that whenever the capture method on payment_intent is...
9240e16ae4e4f4092a7f64f09ba1fcb058e0cdcf
When we will make the payment create in manual mode we will won't get the cards available as it don't supports manual capture <img width="1728" alt="Screenshot 2023-04-26 at 18 26 15" src="https://user-images.githubusercontent.com/61520228/234581609-917e425a-fc8a-458e-a38a-fb94cbf8ed37.png">
[ { "file_path": "config/development.toml", "lines": [ "credit = { not_available_flows = {capture_method=\"manual\"} }\n", "debit = { not_available_flows = {capture_method=\"manual\"} }\n", "credit = { not_available_flows = {capture_method=\"manual\"} }\n", "debit = { not_available_f...
[ { "file_path": "crates/router/src/configs/settings.rs", "lines": [ "pub struct PaymentMethodFilters(pub HashMap<PaymentMethodFilterKey, CurrencyCountryFilter>);\n", "pub struct CurrencyCountryFilter {\n" ] }, { "file_path": "crates/router/src/core/payment_methods/cards.rs", "line...
[ "toml", "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-1018
Bug: [Documentation] Update Readme link ### Feature Description - [x] Replace stale link in the readme file #1019 ### Possible Implementation NA ### Have you spent some time to check if this feature request has been raised before? - [X] I checked and didn't find similar issue ### Have you read the...
diff --git a/README.md b/README.md index 89f6e94f4df..128c39a3ec7 100644 --- a/README.md +++ b/README.md @@ -259,7 +259,7 @@ Get updates on HyperSwitch development and chat with the community: - Join our [Slack workspace][slack]. - Ask and explore our [GitHub Discussions][github-discussions]. -[blog]: https://blog....
2023-04-28T06:24:07Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [x] Documentation - [ ] CI/CD ## Description Update the link to hyperswitch blog. The link was broken ### Additional Changes - [ ] This PR mod...
897250ebc3ee57392aae7e2e926d8c635ac9fc4f
Not applicable
[ { "file_path": "README.md", "lines": [ "[blog]: https://hyperswitch.io/blog\n" ] } ]
[ { "file_path": "README.md", "lines": [ "[blog]: https://blog.hyperswitch.io\n" ] } ]
[ "md" ]
1
juspay/hyperswitch
juspay__hyperswitch-961
Bug: [FEATURE] Refactor Stripe compatibility routes ### Feature Description Use `web::resource` to specify the paths in [`/crates/router/src/compatibility/stripe/app.rs`](https://github.com/juspay/hyperswitch/blob/main/crates/router/src/compatibility/stripe/app.rs) ### Possible Implementation Refer this file http...
diff --git a/crates/router/src/compatibility/stripe/app.rs b/crates/router/src/compatibility/stripe/app.rs index 898ffc0aee2..24abb90b423 100644 --- a/crates/router/src/compatibility/stripe/app.rs +++ b/crates/router/src/compatibility/stripe/app.rs @@ -7,14 +7,34 @@ pub struct PaymentIntents; impl PaymentIntents { ...
2023-04-28T08:21:27Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> - fixes #961 ### Additional Changes - [ ] This PR modifi...
36cc13d44bb61b840195e1a24f1bebdb0115d13b
- run cargo check on the entire project - format the code
[ { "file_path": "crates/router/src/compatibility/stripe/app.rs", "lines": [ " let mut route = web::scope(\"/payment_intents\").app_data(web::Data::new(state));\n", " #[cfg(feature = \"olap\")]\n", " {\n", " route = route.service(web::resource(\"/list\")...
[ { "file_path": "crates/router/src/compatibility/stripe/app.rs", "lines": [ " web::scope(\"/payment_intents\")\n", " .app_data(web::Data::new(state))\n", " .service(payment_intents_retrieve_with_gateway_creds)\n", " .service(payment_intents_crea...
[ "rs" ]
5
juspay/hyperswitch
juspay__hyperswitch-954
Bug: [FEATURE] Implement `AddressInterface` for `MockDb` Spin out from #172. Please refer to that issue for more information.
diff --git a/Cargo.lock b/Cargo.lock index fb22127838b..44a48169ffd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -876,6 +876,7 @@ version = "0.55.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "22d2a2bcc16e5c4d949ffd2b851da852b9bbed4bb364ed4ae371b42137ca06d9" dependencies = [ + "aws-sm...
2023-04-24T23:25:58Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API co...
8947e1c9dba3585c3d998110b53747cbc1007bc2
[ { "file_path": "Cargo.lock", "lines": [ " \"aws-smithy-eventstream\",\n" ] }, { "file_path": "crates/router/src/db.rs", "lines": [ " addresses: Arc<Mutex<Vec<storage::Address>>>,\n", " addresses: Default::default(),\n" ] }, { "file_path": "crates/r...
[ { "file_path": "crates/router/src/db/address.rs", "lines": [ " _address_id: &str,\n", " // [#172]: Implement function for `MockDb`\n", " Err(errors::StorageError::MockDbError)?\n", " _address_id: String,\n", " _address: storage::AddressUpdate,...
[ "rs", "lock" ]
4
juspay/hyperswitch
juspay__hyperswitch-984
Bug: [BUG] Remove default values for created_at and modified_at from the database # Context Currently we are setting `created_at` and `modified_at` in the database during insert through Posgresql `now()` function which gives the current time according to the current time zone. But when we modify the data we pass `c...
diff --git a/crates/router/src/types/domain/address.rs b/crates/router/src/types/domain/address.rs index d69343cc798..8b88cf229cc 100644 --- a/crates/router/src/types/domain/address.rs +++ b/crates/router/src/types/domain/address.rs @@ -115,6 +115,7 @@ impl behaviour::Conversion for Address { message: ...
2023-04-26T11:13:10Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix ## Description <!-- Describe your changes in detail --> This closes #984 ### Additional Changes - [x] This PR modifies the database schema <!-- Provide links to the files with corresponding changes. Following are the paths wh...
83d2871b4bded0a84e068e7a456d3dfeed7d642a
Manual
[ { "file_path": "crates/router/src/types/domain/address.rs", "lines": [ " let now = date_time::now();\n", " created_at: now,\n", " modified_at: now,\n" ] }, { "file_path": "crates/router/src/types/domain/customer.rs", "lines": [ " date_t...
[ { "file_path": "crates/router/src/types/domain/customer.rs", "lines": [ " pii,\n", " modified_at: Some(common_utils::date_time::now()),\n" ] }, { "file_path": "crates/router/src/types/domain/merchant_key_store.rs", "lines": [ " custom_serde,\n" ] ...
[ "sql", "rs" ]
12
juspay/hyperswitch
juspay__hyperswitch-967
Bug: [FEATURE] unix timestamp to primitive date time ### Feature Description add a deserialization logic to convert unix timestamp to primitive date time so that there will no need to timestamp conversion in connectors ### Possible Implementation need to implement a new trait which has implementations of conver...
diff --git a/crates/api_models/src/disputes.rs b/crates/api_models/src/disputes.rs index 8dc56fba940..da3463185d7 100644 --- a/crates/api_models/src/disputes.rs +++ b/crates/api_models/src/disputes.rs @@ -31,11 +31,14 @@ pub struct DisputeResponse { /// Reason code of dispute sent by connector pub connector_r...
2023-04-19T08:01:57Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Implemented Dispute Webhooks for Stripe <!-- Describe your changes in detail --> ### Additional Changes - [x] This PR modifies the...
897250ebc3ee57392aae7e2e926d8c635ac9fc4f
I tested this change manually Out going webhook to merchant <img width="1144" alt="Screenshot 2023-04-19 at 1 15 10 PM" src="https://user-images.githubusercontent.com/83439957/233008843-1fba37a8-7908-4232-8e19-df7d2ae7cd5b.png">
[ { "file_path": "crates/api_models/src/disputes.rs", "lines": [ " #[serde(with = \"common_utils::custom_serde::iso8601::option\")]\n", " pub challenge_required_by: Option<PrimitiveDateTime>,\n", " #[serde(with = \"common_utils::custom_serde::iso8601::option\")]\n", " pub c...
[ { "file_path": "crates/api_models/src/disputes.rs", "lines": [ " pub challenge_required_by: Option<String>,\n", " pub created_at: Option<String>,\n", " pub updated_at: Option<String>,\n" ] }, { "file_path": "crates/router/src/connector/adyen.rs", "lines": [ "...
[ "sql", "rs" ]
14
juspay/hyperswitch
juspay__hyperswitch-920
Bug: [FEATURE] Add Refund Sync route in Stripe compatibility ### Feature Description There is a refund sync route https://github.com/juspay/hyperswitch/blob/573a4d384ee6a9d72648ab537804799a3993e1e8/crates/router/src/routes/app.rs#L184 A similar route needs to be added in the compatibility layer in this file - h...
diff --git a/Cargo.lock b/Cargo.lock index 40c8891825e..99a37d53a60 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3846,7 +3846,7 @@ checksum = "bcec881020c684085e55a25f7fd888954d56609ef363479dc5a1305eb0d40cab" dependencies = [ "proc-macro2", "quote", - "syn 2.0.11", + "syn 2.0.15", ] [[package]] diff --git a/cr...
2023-04-22T09:12:25Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> This PR is based on the issue #920 to add refund sync with gate...
85c7629061ebbe5c9e0393f138af9b8876c3643d
[ { "file_path": "Cargo.lock", "lines": [ " \"syn 2.0.15\",\n" ] }, { "file_path": "crates/router/src/compatibility/stripe/app.rs", "lines": [ " .service(refund_retrieve_with_gateway_creds)\n" ] }, { "file_path": "crates/router/src/compatibility/stripe/refund...
[ { "file_path": "Cargo.lock", "lines": [ " \"syn 2.0.11\",\n" ] } ]
[ "rs", "lock" ]
3
juspay/hyperswitch
juspay__hyperswitch-938
Bug: [FEATURE] Nexinets support for auth & capture, bank redirects and paypal ### Feature Description - [x] Authorize, Capture, Void ThreeDS and non ThreeDS cards #898 - [x] Bank redirects : ideal, sofort, eps and Giropay #898 - [x] Wallet : Paypal redirection #898 - [x] Refund, Psync and Rsync #898 ### Possibl...
diff --git a/connector-template/mod.rs b/connector-template/mod.rs index 75f2f02c027..f7653f16189 100644 --- a/connector-template/mod.rs +++ b/connector-template/mod.rs @@ -303,6 +303,7 @@ impl .headers(types::PaymentsCaptureType::get_headers( self, req, connectors, ...
2023-04-17T13:01:49Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Adding following features to connector Nexinets 1) Authorize ,Capture ,Void ,Refund, Psy...
0df224479416533579dd6d96e7f0dd9c246b739c
Integration Tests <img width="1024" alt="Screenshot 2023-04-17 at 4 27 37 PM" src="https://user-images.githubusercontent.com/121822803/232481485-37ac635f-2500-4d89-8d18-b74fffcfbf12.png"> **3ds test cards** 1)friction less flow : 4111111111111111 2)challenge flow : 4000007000000031 Intiate 3ds transaction...
[ { "file_path": "connector-template/mod.rs", "lines": [ " .body(types::PaymentsCaptureType::get_request_body(self, req)?)\n" ] }, { "file_path": "crates/api_models/src/enums.rs", "lines": [ " Nexinets,\n", " Nexinets,\n" ] }, { "file_path": "...
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ " // Nexinets, added as template code for future use\n", " // Nexinets, added as template code for future use\n" ] }, { "file_path": "crates/router/src/connector/nexinets.rs", "lines": [ " types::P...
[ "rs" ]
11
juspay/hyperswitch
juspay__hyperswitch-924
Bug: [FEATURE] move env vars in selenium test to toml config file ### Feature Description Currently all the dynamic variable in crates/router/tests/connectors/selenium.rs are taken as **ENV** vars which can be moved to sample_auth.toml file which will list all the variables. ### Possible Implementation move all t...
diff --git a/crates/api_models/src/webhooks.rs b/crates/api_models/src/webhooks.rs index 15df7da9ee9..a17fc86c311 100644 --- a/crates/api_models/src/webhooks.rs +++ b/crates/api_models/src/webhooks.rs @@ -15,7 +15,6 @@ pub enum IncomingWebhookEvent { EventNotSupported, SourceChargeable, SourceTransaction...
2023-05-22T05:10:38Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [X] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Closes #924 ### Additional Changes - [ ] This PR modifie...
2ede8ade8cff56443d8712518c64de7d952f4a0c
<img width="1147" alt="Screen Shot 2023-05-26 at 9 06 21 PM" src="https://github.com/juspay/hyperswitch/assets/20727598/2421e56c-0cc2-4eac-a886-33f3071e048c"> <img width="966" alt="Screen Shot 2023-05-22 at 10 18 54 AM" src="https://github.com/juspay/hyperswitch/assets/20727598/3ea3ac09-8e30-4e40-bedb-4a32a4f92e5f...
[ { "file_path": "crates/router/src/connector/nuvei/transformers.rs", "lines": [ " pub url_details: Option<UrlDetails>,\n", "}\n", "\n", "#[derive(Debug, Serialize, Default)]\n", "#[serde(rename_all = \"camelCase\")]\n", "pub struct UrlDetails {\n", " pub succes...
[ { "file_path": "crates/api_models/src/webhooks.rs", "lines": [ " ChargeSucceeded,\n", " IncomingWebhookEvent::ChargeSucceeded => Self::Payment,\n" ] }, { "file_path": "crates/router/src/connector/nuvei/transformers.rs", "lines": [ " NuveiTransaction...
[ "toml", "rs" ]
13
juspay/hyperswitch
juspay__hyperswitch-932
Bug: [DOCUMENTATION] Updating the readme for dashboard visibility ### Feature Description Sandbox dashboard is one step away for new users landing on Github page. Hence increasing the visibility of app.hyperswitch.io ### Possible Implementation Sandbox dashboard is one step away for new users landing on Github ...
diff --git a/README.md b/README.md index c477ed15aa9..89f6e94f4df 100644 --- a/README.md +++ b/README.md @@ -52,21 +52,24 @@ Using HyperSwitch, you can: ## Quick Start Guide -You have three options to try out HyperSwitch: -1. [Try it in our Sandbox Environment](/docs/try_sandbox.md): Fast and easy to +<a href="h...
2023-04-20T12:56:15Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Adding a button linking to dashboard <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the da...
afeb83194f0772e7550c5d4a6ed4ba16216d2a28
[ { "file_path": "README.md", "lines": [ "<a href=\"https://app.hyperswitch.io\"><img src=\"./docs/imgs/signup-to-hs.svg\" height=\"35\"></a>\n", "\n", "Ways to get started with Hyperswitch:\n", "\n", "1. Try it in our Sandbox Environment: Fast and easy to\n", " No code o...
[ { "file_path": "README.md", "lines": [ "You have three options to try out HyperSwitch:\n", "1. [Try it in our Sandbox Environment](/docs/try_sandbox.md): Fast and easy to\n", " No code or setup required in your system.\n", "2. Try our React Demo App: A simple demo of integrating Hy...
[ "md" ]
1
juspay/hyperswitch
juspay__hyperswitch-916
Bug: [FEATURE] Checkout.com support for Applepay, Googlepay and Webhooks ### Feature Description Scope: - [ ] Add support for Applepay, Googlepay digital wallets #875 - [ ] Enable tokenization for respective Googlepay/ Applepay endpoint to make wallet payment #875 - [ ] Webhook support for asynchronous payment...
diff --git a/config/development.toml b/config/development.toml index 1a335764d67..49c7c91c53d 100644 --- a/config/development.toml +++ b/config/development.toml @@ -181,3 +181,4 @@ apple_pay = { country = "AU,CN,HK,JP,MO,MY,NZ,SG,TW,AM,AT,AZ,BY,BE,BG,HR,CY,CZ,D [tokenization] stripe = { long_lived_token = false, pa...
2023-04-13T11:24:26Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [X] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> - Added Wallets ( GooglePay, ApplePay ) and Webhooks support for [checkout](https://www.checkou...
573a4d384ee6a9d72648ab537804799a3993e1e8
Introduced all the basic unit tests, `Rsync` is ignored as it is throwing error from connector side although working in Postman. `ApplePay` is not tested due to token availability issue. ![Screenshot 2023-04-13 at 4 38 36 PM](https://user-images.githubusercontent.com/55536657/231742922-03afe2dd-edc5-478f-bf5c-d...
[ { "file_path": "config/development.toml", "lines": [ "checkout = { long_lived_token = false, payment_method = \"wallet\"}\n" ] }, { "file_path": "crates/router/src/connector/checkout.rs", "lines": [ "use common_utils::{crypto, ext_traits::ByteSliceExt};\n", "use super::util...
[ { "file_path": "crates/router/src/connector/checkout.rs", "lines": [ "use super::utils::RefundsRequestData;\n", " headers, services,\n", " api::{self, ConnectorCommon},\n", " format!(\"Bearer {}\", auth.api_key),\n", " services::ConnectorIntegration<\n",...
[ "toml", "rs" ]
7
juspay/hyperswitch
juspay__hyperswitch-940
Bug: [FEATURE] Mandates for alternate payment methods via Stripe ### Feature Description **Scope:** Implementation of - [ ] Applepay recurring payments via Stripe connector - [ ] Googlepay recurring payments via Stripe connector ### Possible Implementation Recurring payments for Applepay and Googlepay needs t...
diff --git a/config/development.toml b/config/development.toml index 4ecd69879cf..b684c497652 100644 --- a/config/development.toml +++ b/config/development.toml @@ -225,8 +225,8 @@ credit = {currency = "USD"} debit = {currency = "USD"} [tokenization] -stripe = { long_lived_token = false, payment_method = "wallet" }...
2023-05-03T12:58:07Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [X] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Closes #940 ### Additional Changes - [ ] This PR modifi...
35196493c4509a6f9f1c202bf8b8a6aa7605346b
<img width="1160" alt="Screen Shot 2023-05-04 at 2 54 18 AM" src="https://user-images.githubusercontent.com/20727598/236053199-e91a6c42-828a-4579-867e-84c9f7ad0ec4.png">
[ { "file_path": "config/development.toml", "lines": [ "stripe = { long_lived_token = false, payment_method = \"wallet\", payment_method_type = { type = \"disable_only\", list = \"google_pay\" } }\n", "checkout = { long_lived_token = false, payment_method = \"wallet\"}\n" ] }, { "file_...
[ { "file_path": "config/development.toml", "lines": [ "stripe = { long_lived_token = false, payment_method = \"wallet\" }\n", "checkout = { long_lived_token = false, payment_method = \"wallet\" }\n" ] }, { "file_path": "crates/api_models/src/payments.rs", "lines": [ " Con...
[ "sql", "toml", "rs" ]
32
juspay/hyperswitch
juspay__hyperswitch-899
Bug: [ENHANCEMENT] Add connector_label field in error type ### Feature Description A `DuplicateMerchantConnectorAccount` will occur when inserting a row in the `merchant_connector_account` table if there is a row that already exists with the same merchant_id and connector_label. The connector_label is created by Hy...
diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs index 766aadd2128..f1099a09da8 100644 --- a/crates/router/src/compatibility/stripe/errors.rs +++ b/crates/router/src/compatibility/stripe/errors.rs @@ -103,8 +103,8 @@ pub enum StripeErrorCode { #[error...
2023-05-03T18:07:23Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [x] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> This PR adds the connector_label to the message of the Duplicat...
36cc13d44bb61b840195e1a24f1bebdb0115d13b
[ { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " #[error(error_type = StripeErrorType::InvalidRequestError, code = \"token_already_used\", message = \"The merchant connector account with the specified connector_label '{connector_label}' already exists in our records\"...
[ { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " #[error(error_type = StripeErrorType::InvalidRequestError, code = \"token_already_used\", message = \"duplicate merchant_connector_account\")]\n", " DuplicateMerchantConnectorAccount,\n", " err...
[ "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-838
Bug: [FEATURE] Add support for Bank Debits payment method ### Feature Description ### Problem statement Bank Debits enables merchants to directly pull funds from the customers' bank accounts once the customers provide authorization for the same. It is primarily used for recurring transactions/mandates and for large...
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index f7985c1fc42..43c341dcd67 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -409,11 +409,14 @@ pub enum PaymentExperience { #[serde(rename_all = "snake_case")] #[strum(serialize_all = "snake_case")] pu...
2023-04-18T07:35:31Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> This PR will add support for creating payments using `bank_debits` payment method. This has been implemented for stripe. Mandate details have to passed for all the payment me...
3e2a7eaed2e830b419964e486757c022a0ebca63
- ACH bank debit <img width="844" alt="Screenshot 2023-04-18 at 12 43 41 PM" src="https://user-images.githubusercontent.com/48803246/232700078-0e6670df-810e-4aa0-ad50-c9988f676714.png"> - Microdeposit verification for ACH <img alt="Screenshot 2023-04-18 at 12 45 26 PM" src = "https://user-images.githubusercontent....
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ " Ach,\n", " Bacs,\n", " Becs,\n", " Sepa,\n", " BankDebit,\n" ] }, { "file_path": "crates/api_models/src/payments.rs", "lines": [ "#[derive(serde::Deserialize, serde::Serialize, De...
[ { "file_path": "crates/api_models/src/payments.rs", "lines": [ "#[derive(Debug, Clone, Eq, PartialEq, serde::Deserialize, serde::Serialize, ToSchema)]\n", "#[derive(Setter, Clone, Default, Debug, Eq, PartialEq, serde::Serialize)]\n" ] }, { "file_path": "crates/router/src/connector/ac...
[ "rs" ]
8
juspay/hyperswitch
juspay__hyperswitch-915
Bug: [FEATURE] Nuvei support for bank redirects ### Feature Description **Scope:** - [x] Add support for EPS, Sofort, Giropay, Ideal #870 ### Possible Implementation Bank redirects as a payment method is already supported by payments core. This change will be an extension of the feature without changes in the c...
diff --git a/Cargo.lock b/Cargo.lock index 94d137885dc..40c8891825e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -226,7 +226,7 @@ dependencies = [ "serde_urlencoded", "smallvec", "socket2", - "time", + "time 0.3.20", "url", ] @@ -338,7 +338,7 @@ dependencies = [ "serde", "serde_json", "strum", - "time",...
2023-04-13T00:09:41Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [X] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> 1. Add support for bank redirect Eps, Sofort, Giropay, Ideal 2. Add UI tests for redirection flo...
3e2a7eaed2e830b419964e486757c022a0ebca63
<img width="1132" alt="Screen Shot 2023-04-13 at 4 04 18 AM" src="https://user-images.githubusercontent.com/20727598/231612357-875adfe1-a9b6-4b6c-83a6-25ebeab7de5f.png">
[ { "file_path": "Cargo.lock", "lines": [ " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"js-sys\",\n", " \"time 0.1.43\",\n", " \"wasm-bindgen\",\n", " \"time 0.3.20\",\n", " \"t...
[ { "file_path": "Cargo.lock", "lines": [ " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", ...
[ "toml", "rs", "lock" ]
12
juspay/hyperswitch
juspay__hyperswitch-756
Bug: [FEATURE] Addition of Client Secret Validation in Payment Methods API. ### Feature Description With the current workflow the clientSecret essentially gets verified at the very end during confirm payment. What we basically want to do however is to make sure to not show the SDK or throw the appropriate errors wh...
diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs index 6886be1f2e0..144c14e2736 100644 --- a/crates/router/src/compatibility/stripe/errors.rs +++ b/crates/router/src/compatibility/stripe/errors.rs @@ -406,7 +406,8 @@ impl From<errors::ApiErrorResponse> for...
2023-03-16T14:27:23Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> If there is no client secret in payment_intent then it has expired, so if we receive a client secret in request and there is no client secret in payment intent then the client...
5b5557b71d84de67fbda2d0eb09a947eee2823d0
- Create a successful payment - Call payment_method list which fails saying client secret is invalid
[ { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " errors::ApiErrorResponse::ClientSecretNotGiven\n", " | errors::ApiErrorResponse::ClientSecretExpired => Self::ClientSecretNotFound,\n" ] }, { "file_path": "crates/router/src/core/err...
[ { "file_path": "crates/router/src/compatibility/stripe/errors.rs", "lines": [ " errors::ApiErrorResponse::ClientSecretNotGiven => Self::ClientSecretNotFound,\n" ] }, { "file_path": "crates/router/src/core/errors/api_error_response.rs", "lines": [ " \"Cli...
[ "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-851
Bug: [FEATURE] Use the newtype pattern for phone numbers ### Feature Description This issue covers one of the problems mentioned in #119, about using [the newtype pattern](https://rust-unofficial.github.io/patterns/patterns/behavioural/newtype.html) for phone numbers. The requirement is that phone numbers must be v...
diff --git a/Cargo.lock b/Cargo.lock index ff777f8f625..05c45938fd4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -264,7 +264,7 @@ dependencies = [ "serde_urlencoded", "smallvec", "socket2", - "time 0.3.21", + "time 0.3.22", "url", ] @@ -388,7 +388,7 @@ dependencies = [ "serde", "serde_json", "strum", - ...
2023-05-28T10:08:23Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> * Used the phonenumber crate to validate the phonenumber * Imp...
6c0d136cee106fc25fbcf63e4bbc01b28baa1519
[ { "file_path": "Cargo.lock", "lines": [ " \"time 0.3.22\",\n", " \"time 0.3.22\",\n", "version = \"0.7.3\"\n", "checksum = \"8868f09ff8cea88b079da74ae569d9b8c62a23c68c746240b704ee6f7525c89c\"\n", " \"time 0.3.22\",\n", " \"time 0.3.22\",\n", " \"time 0.3.22\",\n", ...
[ { "file_path": "Cargo.lock", "lines": [ " \"time 0.3.21\",\n", " \"time 0.3.21\",\n", "version = \"0.7.2\"\n", "checksum = \"8da52d66c7071e2e3fa2a1e5c6d088fec47b593032b254f5e980de8ea54454d6\"\n", " \"time 0.3.21\",\n", " \"time 0.3.21\",\n", " \"time 0.3.21\",\n", ...
[ "toml", "lock", "rs" ]
5
juspay/hyperswitch
juspay__hyperswitch-726
Bug: [FEATURE] Create a dummy connector for internal and external testing of payments and refunds flows ### Feature Description A dummy test connector needs to be created with the ability to process all the payment methods available on Hyperswitch. This dummy connector will be useful for internal and external tes...
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index ae13a34d103..f391f3a3a60 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -596,9 +596,17 @@ pub enum Connector { Dummy, Iatapay, #[cfg(feature = "dummy_connector")] - #[serde(rename = ...
2023-05-12T00:13:39Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> Add multiple dummy connectors and enable dummy connector by def...
fee0e9dadd2e20c5c75dcee50de0e53f4e5e6deb
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ " #[serde(rename = \"dummyconnector1\")]\n", " #[strum(serialize = \"dummyconnector1\")]\n", " DummyConnector1,\n", " #[cfg(feature = \"dummy_connector\")]\n", " #[serde(rename = \"dummyconnector2\")]\n"...
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ " #[serde(rename = \"dummyconnector\")]\n", " #[strum(serialize = \"dummyconnector\")]\n", " DummyConnector,\n", " #[serde(rename = \"dummyconnector\")]\n", " #[strum(serialize = \"dummyconnector\")]\n",...
[ "toml", "rs" ]
6
juspay/hyperswitch
juspay__hyperswitch-626
Bug: [BUG] Unclear Database error messages ### Bug Description Any database errors are reported as ``` DatabaseError: An unknown error occurred ``` These do not give any info over the type of errors that could exist, this leads to longer debug times for the most trivial/simplistic errors. Partly this seems ...
diff --git a/Cargo.lock b/Cargo.lock index 51271d4b794..af78a030121 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -305,9 +305,9 @@ dependencies = [ [[package]] name = "anyhow" -version = "1.0.68" +version = "1.0.69" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "2cb2f989d18dd141ab8ae82...
2023-03-05T12:14:55Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> This PR uses the `Debug` implementation instead of `Display` implementation for printing error ty...
a8da583bca943039bec3be3bf0eb0eda2db778d6
<details> <summary>Scenario 1: Column missing from database table</summary> <pre> 2023-03-05T11:48:49.205284Z ERROR router::services::api: error: {"error":{"type":"api","message":"Something went wrong","code":"HE_00"}} ├╴at crates/router/src/services/api.rs:448:42 │ ├─▶ {"error":{"type":"server_not_availabl...
[ { "file_path": "Cargo.lock", "lines": [ "version = \"1.0.69\"\n", "checksum = \"224afbd727c3d6e4b90103ece64b8d1b67fbb1973b1046c2281eed3f3803f800\"\n", "version = \"0.3.1\"\n", "checksum = \"5f00447f331c7f726db5b8532ebc9163519eed03c6d7c8b73c90b3ff5646ac85\"\n" ] }, { "file...
[ { "file_path": "Cargo.lock", "lines": [ "version = \"1.0.68\"\n", "checksum = \"2cb2f989d18dd141ab8ae82f64d1a8cdd37e0840f73a406896cf5e99502fab61\"\n", "version = \"0.2.4\"\n", "checksum = \"859d224e04b2d93d974c08e375dac9b8d1a513846e44c6666450a57b1ed963f9\"\n", " \"owo-colors\",...
[ "toml", "lock", "rs" ]
9
juspay/hyperswitch
juspay__hyperswitch-607
Bug: [FEATURE] Validate card security codes and expiration month/year ### Feature Description As of now, we don't perform any validations on card security codes (CVC/CVV/CID code) and card expiration month and year. It'd be great if the following validations can be done: 1. Card security code must be 3 or 4 di...
diff --git a/Cargo.lock b/Cargo.lock index d065e56825f..3e9de17d58d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1148,6 +1148,18 @@ dependencies = [ "serde", ] +[[package]] +name = "cards" +version = "0.1.0" +dependencies = [ + "common_utils", + "error-stack", + "masking", + "serde", + "serde_json", + "time", +] +...
2023-04-13T11:14:23Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Add basic validations for card security codes (CVC/CVV/CID code) and card expiration month and year. This logic resides in a new crate call...
897250ebc3ee57392aae7e2e926d8c635ac9fc4f
run `cargo test --cards`
[ { "file_path": "Cargo.lock", "lines": [ "[[package]]\n", "name = \"cards\"\n", "version = \"0.1.0\"\n", "dependencies = [\n", " \"common_utils\",\n", " \"error-stack\",\n", " \"masking\",\n", " \"serde\",\n", " \"serde_json\",\n", " \"time\",\n", ...
[ { "file_path": "Cargo.lock", "lines": [ "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44b90202fd744598db8b0ace5b8f0bad7ec45658\"\n", "source = \"git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b...
[ "toml", "lock", "rs" ]
5
juspay/hyperswitch
juspay__hyperswitch-608
Bug: [FEATURE] Use newtype pattern for email addresses ### Feature Description This issue covers one of the problems mentioned in #119, about using [the newtype pattern](https://rust-unofficial.github.io/patterns/patterns/behavioural/newtype.html) for email addresses. The requirement is that email addresses must ...
diff --git a/Cargo.lock b/Cargo.lock index 321e402c34a..82cc4015a53 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1305,6 +1305,7 @@ version = "0.1.0" dependencies = [ "async-trait", "bytes", + "diesel", "error-stack", "fake", "futures", diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin...
2023-03-31T09:58:21Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> - This fixes #608 - Added testcases ### Additional Changes - [ ] This PR modifies the dat...
36cc13d44bb61b840195e1a24f1bebdb0115d13b
- ran `cargo test` - Added 2 unit testcases for validation of implemented code - ![img](https://user-images.githubusercontent.com/44920607/229088949-12df2834-8778-44fc-94a5-fbaadbe3d6ad.png)
[ { "file_path": "Cargo.lock", "lines": [ " \"diesel\",\n" ] }, { "file_path": "crates/api_models/src/admin.rs", "lines": [ " pub primary_email: Option<pii::Email>,\n", " pub secondary_email: Option<pii::Email>,\n" ] }, { "file_path": "crates/api_models/src/...
[ { "file_path": "crates/api_models/src/admin.rs", "lines": [ " pub primary_email: Option<Secret<String, pii::Email>>,\n", " pub secondary_email: Option<Secret<String, pii::Email>>,\n" ] }, { "file_path": "crates/api_models/src/customers.rs", "lines": [ " pub email: ...
[ "toml", "rs", "lock" ]
30
juspay/hyperswitch
juspay__hyperswitch-804
Bug: [FEATURE]: add support for three letter and numeric country codes ### Feature Description We are currently using two_letter country codes internally since majority of connectors accept only two_letter codes, there may arise a situation where some connector will accept only three_letter country codes or numeric...
diff --git a/.typos.toml b/.typos.toml index a91e8732e08..57cfce73ef1 100644 --- a/.typos.toml +++ b/.typos.toml @@ -2,19 +2,21 @@ check-filename = true [default.extend-identifiers] +BA = "BA" # Bosnia and Herzegovina country code flate2 = "flate2" +FO = "FO" # Faroe Islands (the) country code payment_vas = "pa...
2023-04-04T09:12:24Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [x] Enhancement - [x] Refactoring - [x] Dependency updates ## Description fixes #804 ### Additional Changes - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/env...
f26a632cdb4073e7cef012503c668e27d4abc7ee
Added multiple test cases covering maximum scenarios Tested with `cargo test` with all OK passed
[ { "file_path": ".typos.toml", "lines": [ "BA = \"BA\" # Bosnia and Herzegovina country code\n", "FO = \"FO\" # Faroe Islands (the) country code\n", "SOM = \"SOM\" # Somalia country code\n", "THA = \"THA\" # Thailand country code\n" ] }, { "file_path": "Cargo.lock", ...
[ { "file_path": ".typos.toml", "lines": [ "FO = \"FO\" # Faroe Islands (the) country code\n", "BA = \"BA\" # Bosnia and Herzegovina country code\n" ] }, { "file_path": "Cargo.lock", "lines": [ "version = \"1.0.94\"\n", "checksum ...
[ "toml", "lock", "rs" ]
4
juspay/hyperswitch
juspay__hyperswitch-606
Bug: [FEATURE] Validate card numbers when accepting payment method information ### Feature Description As of now, we just pass the card information to the payment processor without performing any form of validation on the provided card number. It'd be great if the card number could have been validated on our end ...
diff --git a/Cargo.lock b/Cargo.lock index 82cc4015a53..3ef85ac8f6a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -364,6 +364,7 @@ name = "api_models" version = "0.1.0" dependencies = [ "actix-web", + "cards", "common_enums", "common_utils", "error-stack", @@ -1154,9 +1155,11 @@ version = "0.1.0" dependencies ...
2023-04-14T16:34:00Z
Fixes #606 ## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> The PR adds a new crate called `cards`. Which currently just has a single module na...
736a236651523b7f72ff95ad9223f4dda875301a
Tests for successful and failing CC number validation have been added.
[ { "file_path": "Cargo.lock", "lines": [ " \"cards\",\n", " \"luhn\",\n", " \"thiserror\",\n", "[[package]]\n", "name = \"digits_iterator\"\n", "version = \"0.1.0\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"af8345...
[ { "file_path": "Cargo.lock", "lines": [ "version = \"0.4.1\"\n", "checksum = \"ae8970b36c66498d8ff1d66685dc86b91b29db0c7739899012f63a63814b4b28\"\n" ] }, { "file_path": "connector-template/test.rs", "lines": [ "// Creates a payment with empty card number.\n", "#[actix...
[ "toml", "rs", "lock" ]
79
juspay/hyperswitch
juspay__hyperswitch-488
Bug: [FEATURE] add payment methods afterpay, klarna, affirm for adyen connector ### Feature Description Support for payment methods afterpay, klarna and affirm should be added for adyen connector ### Possible Implementation Implementation is similar to card payment method. Newly adding payment method should suppo...
diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs index 8a6dde9c4a3..f126a75f43c 100644 --- a/crates/router/src/connector/adyen.rs +++ b/crates/router/src/connector/adyen.rs @@ -561,7 +561,7 @@ impl services::ConnectorIntegration<api::Execute, types::RefundsData, types::Ref )...
2023-02-07T11:42:53Z
Fixes #470 , #488 ## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description add payment methods like affirm, klarna, afterpay support for adyen connector ### Additional Changes - [ ] Th...
2310e12bf719f0099a0809b7f5aa439725012e7e
<img width="659" alt="Screenshot 2023-02-08 at 8 23 37 PM" src="https://user-images.githubusercontent.com/20727986/217565196-f07c79ce-fbda-4f5c-b162-4481ad848923.png">
[ { "file_path": "crates/router/src/connector/adyen.rs", "lines": [ " \"{}v68/payments/{}/refunds\",\n" ] }, { "file_path": "crates/router/src/connector/adyen/transformers.rs", "lines": [ "use masking::PeekInterface;\n", " connector::utils::{self, PaymentsReques...
[ { "file_path": "crates/router/src/connector/adyen.rs", "lines": [ " \"{}v68/payments/{}/reversals\",\n" ] }, { "file_path": "crates/router/src/connector/adyen/transformers.rs", "lines": [ " pii, services,\n", " utils::OptionExt,\n", " payment_type:...
[ "toml", "rs" ]
7
juspay/hyperswitch
juspay__hyperswitch-603
Bug: [FEATURE] Remove special characters from payment attempt ID ### Feature Description Remove special characters from payment attempt_id For some gateways like expresscheckout where attempt_id can be passed as reference to txn, special characters limit the possibility of integrating the apis where such refere...
diff --git a/crates/router/src/core/payments/operations/payment_create.rs b/crates/router/src/core/payments/operations/payment_create.rs index 450572adaa8..74b316e041a 100644 --- a/crates/router/src/core/payments/operations/payment_create.rs +++ b/crates/router/src/core/payments/operations/payment_create.rs @@ -420,7 +...
2023-02-16T13:43:04Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Refactoring ## Description <!-- Describe your changes in detail --> Since we are passing the attempt id as reference to few connectors, some might not accept special characters. ## Motivation and Context <!-- Why is this change required...
e6408276b5ef27e9f93069181a07f204b99ac7e1
<img width="669" alt="Screenshot 2023-02-16 at 7 12 09 PM" src="https://user-images.githubusercontent.com/48803246/219380739-52329e40-7532-40d8-a2ae-634f7abf06e3.png">
[ { "file_path": "crates/router/src/core/payments/operations/payment_create.rs", "lines": [ " attempt_id: Uuid::new_v4().simple().to_string(),\n" ] }, { "file_path": "crates/router/src/core/payments/operations/payment_method_validate.rs", "lines": [ " attempt_...
[ { "file_path": "crates/router/src/core/payments/operations/payment_create.rs", "lines": [ " attempt_id: Uuid::new_v4().to_string(),\n" ] }, { "file_path": "crates/router/src/core/payments/operations/payment_method_validate.rs", "lines": [ " attempt_id: Uuid:...
[ "rs" ]
2
juspay/hyperswitch
juspay__hyperswitch-468
Bug: [FEATURE] add tests for stripe connector ### Feature Description As part of adding unit tests to existing connectors we are adding test for stripe ### Possible Implementation add a test file for stripe connector in the crates/router/tests folder ### Have you spent some time to check if this feature request ...
diff --git a/crates/router/tests/connectors/connector_auth.rs b/crates/router/tests/connectors/connector_auth.rs index cd696c9e0b4..01505e6a01e 100644 --- a/crates/router/tests/connectors/connector_auth.rs +++ b/crates/router/tests/connectors/connector_auth.rs @@ -12,6 +12,7 @@ pub(crate) struct ConnectorAuthentication...
2023-01-27T13:45:52Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [X] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> This PR adds tests for stripe connector. ### Additional Changes - [ ] This PR modifies the ...
9e420d511dcda08110d41db9afb205881f161c91
<img width="942" alt="Screenshot 2023-01-27 at 6 51 43 PM" src="https://user-images.githubusercontent.com/20727598/215100275-0c858b8e-5dad-4779-bbf9-4b5b385b308a.png">
[ { "file_path": "crates/router/tests/connectors/connector_auth.rs", "lines": [ " pub stripe: Option<HeaderKey>,\n" ] }, { "file_path": "crates/router/tests/connectors/main.rs", "lines": [ "mod stripe;\n" ] }, { "file_path": "crates/router/tests/connectors/stripe.rs"...
[ { "file_path": "crates/router/tests/connectors/utils.rs", "lines": [ "use std::{fmt::Debug, marker::PhantomData, thread::sleep, time::Duration};\n", " payment_data.unwrap_or_else(|| types::PaymentsAuthorizeData {\n", " ..PaymentAuthorizeType::default().0\n", ...
[ "rs" ]
4
juspay/hyperswitch
juspay__hyperswitch-470
Bug: [FEATURE] add tests for adyen connector ### Feature Description As part of adding unit tests to existing connectors we are adding test for adyen ### Possible Implementation add a test file for adyen connector in the crates/router/tests folder ### Have you spent some time to check if this feature request has...
diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs index 8a6dde9c4a3..f126a75f43c 100644 --- a/crates/router/src/connector/adyen.rs +++ b/crates/router/src/connector/adyen.rs @@ -561,7 +561,7 @@ impl services::ConnectorIntegration<api::Execute, types::RefundsData, types::Ref )...
2023-02-07T11:42:53Z
Fixes #470 , #488 ## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description add payment methods like affirm, klarna, afterpay support for adyen connector ### Additional Changes - [ ] Th...
2310e12bf719f0099a0809b7f5aa439725012e7e
<img width="659" alt="Screenshot 2023-02-08 at 8 23 37 PM" src="https://user-images.githubusercontent.com/20727986/217565196-f07c79ce-fbda-4f5c-b162-4481ad848923.png">
[ { "file_path": "crates/router/src/connector/adyen.rs", "lines": [ " \"{}v68/payments/{}/refunds\",\n" ] }, { "file_path": "crates/router/src/connector/adyen/transformers.rs", "lines": [ "use masking::PeekInterface;\n", " connector::utils::{self, PaymentsReques...
[ { "file_path": "crates/router/src/connector/adyen.rs", "lines": [ " \"{}v68/payments/{}/reversals\",\n" ] }, { "file_path": "crates/router/src/connector/adyen/transformers.rs", "lines": [ " pii, services,\n", " utils::OptionExt,\n", " payment_type:...
[ "toml", "rs" ]
7
juspay/hyperswitch
juspay__hyperswitch-478
Bug: [FEATURE] add unit tests for non 3DS, wallets & webhooks in connector tests ### Feature Description Unit tests should be added in the connector tests for cards Non 3DS, Wallets & Webhooks. ### Possible Implementation Unit tests for cards Non 3ds, Wallets & webhooks should be added to the template file ...
diff --git a/Cargo.lock b/Cargo.lock index 94d137885dc..40c8891825e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -226,7 +226,7 @@ dependencies = [ "serde_urlencoded", "smallvec", "socket2", - "time", + "time 0.3.20", "url", ] @@ -338,7 +338,7 @@ dependencies = [ "serde", "serde_json", "strum", - "time",...
2023-04-13T00:09:41Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [X] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> 1. Add support for bank redirect Eps, Sofort, Giropay, Ideal 2. Add UI tests for redirection flo...
3e2a7eaed2e830b419964e486757c022a0ebca63
<img width="1132" alt="Screen Shot 2023-04-13 at 4 04 18 AM" src="https://user-images.githubusercontent.com/20727598/231612357-875adfe1-a9b6-4b6c-83a6-25ebeab7de5f.png">
[ { "file_path": "Cargo.lock", "lines": [ " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"time 0.3.20\",\n", " \"js-sys\",\n", " \"time 0.1.43\",\n", " \"wasm-bindgen\",\n", " \"time 0.3.20\",\n", " \"t...
[ { "file_path": "Cargo.lock", "lines": [ " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", " \"time\",\n", ...
[ "toml", "rs", "lock" ]
12
juspay/hyperswitch
juspay__hyperswitch-501
Bug: [FEATURE] Allow rotating and revoking API keys ### Feature Description As of now, the `merchant_account` table has an `api_key` field which restricts a merchant account to only have one API key. Furthermore, there are no mechanisms in place to revoke and regenerate API keys. To improve the convenience of rotat...
diff --git a/Cargo.lock b/Cargo.lock index f192fbfe685..0e45915379f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -329,6 +329,18 @@ version = "1.1.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "3f907281554a3d0312bb7aab855a8e0ef6cbf1614d06de54105039ca8b34460e" +[[package]] +name = "arr...
2023-02-06T14:36:35Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> This PR implements the endpoints to create, retrieve, update, revoke and list API keys. - As ...
ac30313ff113383653b9d9af8c35432636f38392
I have added a few unit tests where database accesses are not involved. I'll attach invocations of the APIs via `curl` to give an idea of how they look. - Create API Key: ```shell curl --location --request POST 'http://localhost:8080/api_keys' \ --header 'Content-Type: application/json' \ --head...
[ { "file_path": "Cargo.lock", "lines": [ "[[package]]\n", "name = \"arrayref\"\n", "version = \"0.3.6\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"a4c527152e37cf757a3f78aae5a06fbeefdb07ccc535c980a3208ee3060dd544\"\n", "\n", ...
[ { "file_path": "crates/router/src/consts.rs", "lines": [ "// General purpose base64 engine\n", "\n" ] }, { "file_path": "crates/router/src/core/admin.rs", "lines": [ " env::{self, Env},\n", " let id = Uuid::new_v4().simple();\n", " match env::which() {\...
[ "json", "toml", "sql", "rs", "lock" ]
35
juspay/hyperswitch
juspay__hyperswitch-585
Bug: Bank Redirects via stripe Support `bank_redirects` through stripe.
diff --git a/.typos.toml b/.typos.toml index e17306e1915..4e663dc448c 100644 --- a/.typos.toml +++ b/.typos.toml @@ -5,6 +5,7 @@ check-filename = true flate2 = "flate2" payment_vas = "payment_vas" PaymentVas = "PaymentVas" +HypoNoeLbFurNiederosterreichUWien = "HypoNoeLbFurNiederosterreichUWien" [default.extend-wo...
2023-02-09T18:07:10Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> Support EPS, Giropay and iDeal through stripe ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please...
301736fc25bc80f5f0da68377d16ab68132b8839
- EPS ![Screenshot 2023-02-09 at 11 35 37 PM](https://user-images.githubusercontent.com/48803246/217899840-c0b0d17d-cc58-40b2-a028-9ae9ae9d38b8.png) - Giropay ![Screenshot 2023-02-09 at 11 36 01 PM](https://user-images.githubusercontent.com/48803246/217899910-319fad85-de9d-4a35-81bc-489f98758611.png) - iDeal ...
[ { "file_path": ".typos.toml", "lines": [ "HypoNoeLbFurNiederosterreichUWien = \"HypoNoeLbFurNiederosterreichUWien\"\n" ] }, { "file_path": "Cargo.lock", "lines": [ "version = \"3.1.1\"\n", "checksum = \"87ef547a81796eb2dfe9b345aba34c2e08391a0502493711395b36dd64052b69\"\n", ...
[ { "file_path": "Cargo.lock", "lines": [ "version = \"3.1.0\"\n", "checksum = \"0dff3fc64a176e0d4398c71b0f2c2679ff4a723c6ed8fcc68dfe5baa00665388\"\n", "[[package]]\n", "name = \"nom8\"\n", "version = \"0.2.0\"\n", "source = \"registry+https://github.com/rust-lang/crates.io...
[ "json", "sql", "toml", "rs", "lock" ]
92
juspay/hyperswitch
juspay__hyperswitch-467
Bug: [FEATURE] Add more default tests to the connector template ### Feature Description For card payment method default unit tests should be generated while adding a connector using add_connector script. ### Possible Implementation Add more test cases in connector-template/test.rs file, So that default test cases...
diff --git a/connector-template/test.rs b/connector-template/test.rs index 2efaabcd5b2..5926584c526 100644 --- a/connector-template/test.rs +++ b/connector-template/test.rs @@ -1,4 +1,3 @@ -use futures::future::OptionFuture; use masking::Secret; use router::types::{self, api, storage::enums}; @@ -7,9 +6,10 @@ use c...
2023-01-27T10:51:45Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description For card payment method default unit tests should be generated while adding a connector using add_connector script. ### Additional Cha...
d1ab46238e61b74a91ca1ca9f93795d86f83a578
Tested by creating a new connector. As expected new test cases were generated in the test file.
[ { "file_path": "connector-template/test.rs", "lines": [ "#[derive(Clone, Copy)]\n", "struct {{project-name | downcase | pascal_case}}Test;\n", "impl ConnectorActions for {{project-name | downcase | pascal_case}}Test {}\n", "impl utils::Connector for {{project-name | downcase | pascal...
[ { "file_path": "connector-template/test.rs", "lines": [ "use futures::future::OptionFuture;\n", "struct {{project-name | downcase | pascal_case}};\n", "impl ConnectorActions for {{project-name | downcase | pascal_case}} {}\n", "impl utils::Connector for {{project-name | downcase | pa...
[ "rs" ]
2
juspay/hyperswitch
juspay__hyperswitch-323
Bug: feat: List payment method API access needs to be enabled using client secret for SDK calls ### Description Need to enable access for list payment methods API using client secret for SDK calls. This will help SDK show only those payment methods that are enabled by the merchant on their dashboard. We would...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index 6556f043f1b..96b5bc02d04 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -71,7 +71,7 @@ pub struct ListPaymentMethodRequest { pub client_secret: Option<Stri...
2023-01-10T07:23:12Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Filter payment methods based on the current payment that's happening to only show relevant paymen...
b090e421e4880d156fa17048bf63c8f4d4b40395
<img width="1728" alt="image" src="https://user-images.githubusercontent.com/43412619/211487264-9eebeb0f-d221-44a3-9619-a061c038f6aa.png">
[ { "file_path": "crates/api_models/src/payment_methods.rs", "lines": [ " pub amount: Option<i64>,\n", " pub minimum_amount: Option<i64>,\n", " pub maximum_amount: Option<i64>,\n" ] }, { "file_path": "crates/router/src/core/payment_methods/cards.rs", "lines": [ ...
[ { "file_path": "crates/api_models/src/payment_methods.rs", "lines": [ " pub amount: Option<i32>,\n", " pub minimum_amount: Option<i32>,\n", " pub maximum_amount: Option<i32>,\n" ] }, { "file_path": "crates/router/src/core/payment_methods/cards.rs", "lines": [ ...
[ "rs" ]
6
juspay/hyperswitch
juspay__hyperswitch-451
Bug: [FEATURE] return all the `missing_fields` in a request ### Feature Description During address validation, It would be a good experience to have all the missing fields returned at once instead of making many requests to know the missing fields. Referring the discussion here https://github.com/juspay/hypers...
diff --git a/.gitignore b/.gitignore index ced4be3d728..a8e6412fb1a 100644 --- a/.gitignore +++ b/.gitignore @@ -256,3 +256,5 @@ loadtest/*.tmp/ # Nix output result* + +.idea/ diff --git a/Cargo.lock b/Cargo.lock index 99a37d53a60..f9c1f539918 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -107,6 +107,44 @@ dependenci...
2023-04-20T14:57:39Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> On address field validation return all the mandatory fields having a null or empty values. ###...
897250ebc3ee57392aae7e2e926d8c635ac9fc4f
[ { "file_path": ".gitignore", "lines": [ "\n", ".idea/\n" ] }, { "file_path": "Cargo.lock", "lines": [ "[[package]]\n", "name = \"actix-multipart\"\n", "version = \"0.6.0\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "c...
[ { "file_path": "Cargo.lock", "lines": [ " \"time 0.1.43\",\n", " \"infer\",\n", "version = \"0.1.43\"\n", "checksum = \"ca8a50ef2360fbd1eeb0ecd46795a87a19024eb4b53c5dc916ca1fd95fe62438\"\n" ] }, { "file_path": "crates/common_utils/Cargo.toml", "lines": [ "signal...
[ "gitignore", "toml", "lock", "rs" ]
9
juspay/hyperswitch
juspay__hyperswitch-308
Bug: fix(connector): convert PII data into connector request without peeking the info - Currently we are sending the PII information to each connector request by peeking the information and pass it as plain text, instead of doing it in the compile time Serde should handle this process while serialising the data so w...
diff --git a/crates/masking/src/secret.rs b/crates/masking/src/secret.rs index a5ab4103f52..96411d4632b 100644 --- a/crates/masking/src/secret.rs +++ b/crates/masking/src/secret.rs @@ -59,6 +59,28 @@ where masking_strategy: PhantomData, } } + + /// Zip 2 secrets with the same masking strat...
2023-02-24T11:08:47Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [X] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Closes #308 ### Additional Changes - [ ] This PR modifies the database schema - [ ] This ...
aaf372505c000d2d795b41998b39b269f8467a52
[ { "file_path": "crates/masking/src/secret.rs", "lines": [ "\n", " /// Zip 2 secrets with the same masking strategy into one\n", " pub fn zip<OtherSecretValue>(\n", " self,\n", " other: Secret<OtherSecretValue, MaskingStrategy>,\n", " ) -> Secret<(Se...
[ { "file_path": "crates/router/src/connector/aci/transformers.rs", "lines": [ " pii::PeekInterface,\n", " pub card_number: String,\n", " pub card_holder: String,\n", " pub card_expiry_month: String,\n", " pub card_expiry_year: String,\n", " pub card_cvv: ...
[ "rs" ]
15
juspay/hyperswitch
juspay__hyperswitch-281
Bug: fix: Ephemeral key throwing internal server error
diff --git a/crates/redis_interface/src/commands.rs b/crates/redis_interface/src/commands.rs index 58d61225221..5626fd878b1 100644 --- a/crates/redis_interface/src/commands.rs +++ b/crates/redis_interface/src/commands.rs @@ -246,6 +246,25 @@ impl super::RedisConnectionPool { .await } + #[instrume...
2023-01-04T06:52:55Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> This fixes the Internal server error while trying to set ephemeral key on sanbox. ### Addition...
0559f480960fd07e21b655d538ad85eac918f46d
[ { "file_path": "crates/redis_interface/src/commands.rs", "lines": [ " #[instrument(level = \"DEBUG\", skip(self))]\n", " pub async fn serialize_and_set_multiple_hash_field_if_not_exist<V>(\n", " &self,\n", " kv: &[(&str, V)],\n", " field: &str,\n", ...
[ { "file_path": "crates/router/src/db/ephemeral_key.rs", "lines": [ " use common_utils::{date_time, ext_traits::StringExt};\n", " use redis_interface::MsetnxReply;\n", " utils,\n", " let secret_key = new.secret.to_string();\n", " let id_key = n...
[ "rs" ]
2
juspay/hyperswitch
juspay__hyperswitch-347
Bug: feat(connector): add support for affirm and afterpay/clearpay through stripe ### Feature Description Add support for creating payments through affirm and afterpay/clearpay through stripe. The api contract changes will be as follows - afterpay/clearpay ```json { "payment_method": "pay_later", "paymen...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index ddbf7325fd6..fc761d2851d 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -321,14 +321,20 @@ pub struct CCard { #[derive(Eq, PartialEq, Clone, Debug, serde::Deserialize, serde::Serialize,...
2023-01-20T17:58:30Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> This PR will support creating pay_later payments using `afterpay_clearpay` as the issuer through stripe. This is a redirection flow. ## Motivation and Context <!-- Why is...
ecd0ca53b90908aed2be4989c1d9d924cb896a8d
- Create a payment with `payment_method_data` as `pay_later` and body as ```json { "payment_method_data": { "pay_later": { "afterpay_clearpay_redirect": { "issuer_name": "afterpay_clearpay", "billing_email": "example@juspay.in", "billing_name": "Juspay" } } ...
[ { "file_path": "crates/api_models/src/payments.rs", "lines": [ "pub enum KlarnaIssuer {\n", " Klarna,\n", "pub enum AffirmIssuer {\n", " Affirm,\n", "}\n", "\n", "#[derive(Eq, PartialEq, Clone, Debug, serde::Deserialize, serde::Serialize, ToSchema)]\n", ...
[ { "file_path": "crates/api_models/src/payments.rs", "lines": [ "pub enum KlarnaRedirectIssuer {\n", " Stripe,\n", "pub enum KlarnaSdkIssuer {\n", " Klarna,\n", " issuer_name: KlarnaRedirectIssuer,\n", " /// The issuer name of the redirect\n", " ...
[ "rs", "json" ]
6
juspay/hyperswitch
juspay__hyperswitch-262
Bug: refactor(adyen): Use enums instead of strings for statuses As of now, we use string literals for matching on status codes returned by Adyen. They need to be replaced by enums instead. 3 instances I could find are: https://github.com/juspay/orca/blob/7348d76cad8f52548f84c6a606fb177e7ca3620e/crates/router/s...
diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs index cd0bf7ffd52..b0d3e5acd34 100644 --- a/crates/router/src/connector/adyen/transformers.rs +++ b/crates/router/src/connector/adyen/transformers.rs @@ -73,6 +73,25 @@ struct AdyenBrowserInfo { java_...
2023-01-08T13:44:29Z
Fixes #262 ## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [x] Refactoring - [ ] Dependency updates ## Description Used enums instead of strings for statuses for Adyen. ## Motivation and Context <!-- Why is this change required...
74f6d0025e34c26dd0ff429baed0b90dd02edb64
[ { "file_path": "crates/router/src/connector/adyen/transformers.rs", "lines": [ "#[derive(Debug, Clone, Serialize, Deserialize)]\n", "pub enum AdyenStatus {\n", " Authorised,\n", " Refused,\n", " Cancelled,\n", " RedirectShopper,\n", "}\n", "\n", ...
[ { "file_path": "crates/router/src/connector/adyen/transformers.rs", "lines": [ "#[derive(Debug, Clone, Serialize, Deserialize)]\n", " result_code: String,\n", "#[derive(Debug, Clone, Serialize, Deserialize)]\n", " result_code: String,\n", " let result = response.result...
[ "rs" ]
1
juspay/hyperswitch
juspay__hyperswitch-242
Bug: Support Wechatpay Scan and Pay
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 4538ae2d140..5124b0064d9 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -298,6 +298,7 @@ pub enum StripeWallet { Ap...
2023-05-04T09:35:14Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description Implemented Wechatpay digital wallet, payment method for Stripe. ### Additional Changes - [ ] Thi...
bc4ac529aa981150de6882d425bd274bc6272e30
I tested it using Postman <img width="1728" alt="Screenshot 2023-05-04 at 2 37 58 PM" src="https://user-images.githubusercontent.com/131388445/236166786-0f534d8f-1073-4b9d-b14f-e3537ef3fe8e.png"> <img width="1728" alt="Screenshot 2023-05-04 at 2 38 01 PM" src="https://user-images.githubusercontent.com/131388445/23616...
[ { "file_path": "crates/router/src/connector/stripe/transformers.rs", "lines": [ " WechatpayPayment(WechatpayPayment),\n", "#[derive(Debug, Eq, PartialEq, Serialize)]\n", "pub struct WechatpayPayment {\n", " #[serde(rename = \"payment_method_types[]\")]\n", " pub paymen...
[ { "file_path": "crates/router/src/connector/stripe/transformers.rs", "lines": [ "\n", " | StripePaymentMethodOptions::Sepa {}\n", " | StripePaymentMethodOptions::Alipay {} => None,\n", " pub payment_intent: String,\n", " pub payment_intent_cl...
[ "rs" ]
1
juspay/hyperswitch
juspay__hyperswitch-253
Bug: Need mapping for merchant_id passed in request to locke_id passed to EC 1. While creating merchant_account , locker_id needs to be assigned to the merchant 2. In case like swiggy, swiggy_instamart same locker_id needs to be assigned as they are the same and all payment_method can be used across there product ...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 398888e140d..084d8bf93d3 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -24,6 +24,7 @@ pub struct CreateMerchantAccount { pub redirect_to_merchant_with_http_post: Option<bool>, pub metadata:...
2023-01-03T16:12:40Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix - [ ] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Add locker_id to merchant_account which shall be passed to legacy locker use merchant_id::customer_id in place of customer_id if the locke...
c36764060e8c3bdf150964fc10f68ebab22a4b2f
[ { "file_path": "crates/api_models/src/admin.rs", "lines": [ " pub locker_id: Option<String>,\n" ] }, { "file_path": "crates/router/src/core/admin.rs", "lines": [ " locker_id: req.locker_id,\n", " locker_id: merchant_account.locker_id,\n", " loc...
[ { "file_path": "crates/router/src/core/mandate.rs", "lines": [ " mandates::MandateResponse::from_db_mandate(state, mandate).await?,\n", " response_vec.push(mandates::MandateResponse::from_db_mandate(state, mandate).await?);\n", " &resp.merchant_id,\n" ...
[ "sql", "rs" ]
32
juspay/hyperswitch
juspay__hyperswitch-233
Bug: Add Worldline for card payments
diff --git a/Cargo.lock b/Cargo.lock index 3812b1bb856..b14223062dc 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3015,6 +3015,7 @@ dependencies = [ "once_cell", "rand 0.8.5", "redis_interface", + "regex", "reqwest", "ring", "router_derive", diff --git a/config/Development.toml b/config/Development.toml inde...
2023-01-13T11:35:43Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Adding support for [worldline](https://epayments-api.developer-ingenico.com/?paymentPlatform=GLOBALCOLLECT) payment gateway Payment Meth...
d01634891e77373fa8d44f1c5a20cbcbbba688fd
Added unit tests for mentioned payment flows <img width="1128" alt="Screenshot 2023-01-13 at 4 58 59 PM" src="https://user-images.githubusercontent.com/20727986/212310910-f840a6fd-4704-4aa7-9464-a13edf9b615c.png"> <img width="866" alt="Screenshot 2023-01-16 at 1 07 51 PM" src="https://user-images.githubuserconten...
[ { "file_path": "Cargo.lock", "lines": [ " \"regex\",\n" ] }, { "file_path": "config/Development.toml", "lines": [ "[connectors.worldline]\n", "base_url = \"https://eu.sandbox.api-ingenico.com/\"\n", "\n" ] }, { "file_path": "crates/api_models/src/enums.rs"...
[ { "file_path": "crates/router/src/connector.rs", "lines": [ " worldpay::Worldpay,\n" ] } ]
[ "toml", "lock", "rs" ]
15
juspay/hyperswitch
juspay__hyperswitch-270
Bug: Add Worldpay for card payments
diff --git a/Cargo.lock b/Cargo.lock index bd50a78cc66..83398231577 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -88,7 +88,7 @@ dependencies = [ "mime", "percent-encoding", "pin-project-lite", - "rand", + "rand 0.8.5", "sha1", "smallvec", "tracing", @@ -263,7 +263,7 @@ version = "0.7.6" source = "registry+h...
2023-01-02T20:52:29Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [X] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Adding support for [worldpay](https://developer.worldpay.com/) payment gateway Updated connector...
c3368d9f8b0381b982d8defd7fa004c3d3b87da4
Added unit tests for mentioned payment flows. We currently don't have a sandbox account for Worldpay so testing is done with the help of [wiremock](https://docs.rs/wiremock/latest/wiremock/). <img width="911" alt="Screenshot 2023-01-03 at 12 23 43 AM" src="https://user-images.githubusercontent.com/20727598/210277024...
[ { "file_path": "Cargo.lock", "lines": [ " \"rand 0.8.5\",\n", " \"getrandom 0.2.8\",\n", "[[package]]\n", "name = \"assert-json-diff\"\n", "version = \"2.0.2\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"47e4f2b81832e728...
[ { "file_path": "Cargo.lock", "lines": [ " \"rand\",\n", " \"getrandom\",\n", " \"rand\",\n", " \"rand\",\n", " \"rand\",\n", " \"wasi\",\n", " \"wasi\",\n", " \"rand\",\n", " \"rand\",\n", " \"rand\",\n", " \"rand_chacha\",\n", " \"rand...
[ "md", "toml", "rs", "lock", "sh" ]
31
juspay/hyperswitch
juspay__hyperswitch-249
Bug: Facilitating dispute management Dispute occurs when a customer files a chargeback claim to the bank stating that the payment was not intended. While cardholders often have extended dispute filing periods of 60-120 days after the transaction or order delivery, merchants, on the other hand, must deal with shorter...
diff --git a/crates/api_models/src/disputes.rs b/crates/api_models/src/disputes.rs index 8b137891791..e60a6a44fde 100644 --- a/crates/api_models/src/disputes.rs +++ b/crates/api_models/src/disputes.rs @@ -1 +1,38 @@ +use masking::Serialize; +use utoipa::ToSchema; +use super::enums::{DisputeStage, DisputeStatus}; + +#...
2023-03-20T07:10:27Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Added support for incoming dispute webhooks. ### Additional Changes - [x] This PR modifies the database schema - [ ] This PR modif...
b15b8f7b432833423e49c16a61952e085b344771
Manually Tested Webhook Request <img width="1256" alt="image" src="https://user-images.githubusercontent.com/99009240/226270250-5f8926dd-cba5-4a52-81c7-48c679ec9110.png"> DB Entry <img width="763" alt="image" src="https://user-images.githubusercontent.com/99009240/226270204-d9c4403d-d20c-4085-bd0b-6a434bd9c4ba.pn...
[ { "file_path": "crates/api_models/src/disputes.rs", "lines": [ "use masking::Serialize;\n", "use utoipa::ToSchema;\n", "use super::enums::{DisputeStage, DisputeStatus};\n", "\n", "#[derive(Default, Clone, Debug, Serialize, ToSchema)]\n", "pub struct DisputeResponse {\n", ...
[ { "file_path": "crates/api_models/src/webhooks.rs", "lines": [ "use crate::{enums as api_enums, payments, refunds};\n" ] }, { "file_path": "crates/router/src/compatibility/stripe/webhooks.rs", "lines": [ "use api_models::webhooks::{self as api};\n" ] }, { "file_path":...
[ "sql", "rs" ]
28
juspay/hyperswitch
juspay__hyperswitch-236
Bug: Add NMI for card payments
diff --git a/Cargo.lock b/Cargo.lock index a310cff5c1a..c701a355ebb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1318,6 +1318,7 @@ dependencies = [ "nanoid", "once_cell", "proptest", + "quick-xml", "rand 0.8.5", "regex", "ring", @@ -3368,6 +3369,16 @@ version = "2.0.1" source = "registry+https://github.com...
2023-03-20T09:14:31Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Added support for NMI connector that supports the following payment flows: - Verify - Authorize...
a2527b5b2af0a72422e1169f0827b6c55e21d673
update-time: 15 April 2023, Saturday 21:04 <img width="610" alt="image" src="https://user-images.githubusercontent.com/69745008/232234442-e3791a88-3def-4e7d-b28a-fe613aaeb6f6.png"> <img width="1195" alt="Screen Shot 2023-04-26 at 2 32 11 AM" src="https://user-images.githubusercontent.com/20727986/234403252-20d5ac23...
[ { "file_path": "Cargo.lock", "lines": [ " \"quick-xml\",\n", "[[package]]\n", "name = \"quick-xml\"\n", "version = \"0.28.2\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"0ce5e73202a820a31f8a0ee32ada5e21029c81fd9e3ebf668a40832e...
[ { "file_path": "crates/router/src/connector.rs", "lines": [ "pub mod mollie;\n", "\n", " multisafepay::Multisafepay, nexinets::Nexinets, nuvei::Nuvei, opennode::Opennode,\n" ] }, { "file_path": "crates/router/src/types.rs", "lines": [ "\n" ] }, { "file_...
[ "toml", "lock", "rs" ]
20
juspay/hyperswitch
juspay__hyperswitch-232
Bug: Add Shift4 for card payments
diff --git a/config/Development.toml b/config/Development.toml index 32c328baa11..bc2b912fa37 100644 --- a/config/Development.toml +++ b/config/Development.toml @@ -38,7 +38,7 @@ locker_decryption_key2 = "" [connectors.supported] wallets = ["klarna","braintree","applepay"] -cards = ["stripe","adyen","authorizedotne...
2022-12-21T11:19:49Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [X] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> - Adding support for [shift4](https://www.shift4.com/) payment gateway - Updated connector templ...
7274fd70c6bb4051a0af97da087c4e10bf62fdb9
Added units tests for authorize, capture and refund flows. <img width="934" alt="Screenshot 2022-12-21 at 4 24 49 PM" src="https://user-images.githubusercontent.com/20727598/208892758-ae62a963-c087-46fb-8a49-e9fc74fb3e06.png">
[ { "file_path": "config/Development.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\",\"aci\",\"shift4\"]\n", "[connectors.shift4]\n", "base_url = \"https://api.shift4.com/\"\n", "\n" ] }, { "file_path": "config/config.example....
[ { "file_path": "config/Development.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\",\"aci\"]\n" ] }, { "file_path": "config/docker_compose.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\...
[ "sh", "conf", "toml", "rs" ]
24
juspay/hyperswitch
juspay__hyperswitch-237
Bug: Add PayU for card payments
diff --git a/config/Development.toml b/config/Development.toml index c5b1911913f..06b4d544c0a 100644 --- a/config/Development.toml +++ b/config/Development.toml @@ -85,6 +85,8 @@ base_url = "https://api.shift4.com/" [connectors.worldpay] base_url = "http://localhost:9090/" +[connectors.payu] +base_url = "https://se...
2023-01-11T10:05:56Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [X] New feature ## Description <!-- Describe your changes in detail --> - Adding support for [payU](https://developers.payu.com/en/overview.html) payment gateway - Updated connector creation script **Payment Method:** card, GooglePay, ApplePay...
89a1cd088591acc70abcc00ea863e0f108da45a6
Added unit tests for mentioned payment flows. <img width="786" alt="Screenshot 2023-01-11 at 3 34 52 PM" src="https://user-images.githubusercontent.com/55536657/211777225-0f0b47bc-edb5-4b59-ae65-6d6fd6188baa.png">
[ { "file_path": "config/Development.toml", "lines": [ "[connectors.payu]\n", "base_url = \"https://secure.snd.payu.com/api/\"\n" ] }, { "file_path": "crates/api_models/src/enums.rs", "lines": [ " Payu,\n" ] }, { "file_path": "crates/router/src/configs/settings...
[ { "file_path": "crates/router/src/configs/settings.rs", "lines": [ " pub klarna: ConnectorParams,\n", " pub globalpay: ConnectorParams,\n", " pub applepay: ConnectorParams,\n" ] }, { "file_path": "crates/router/src/connector.rs", "lines": [ " klarna::Klarn...
[ "toml", "rs" ]
14
juspay/hyperswitch
juspay__hyperswitch-271
Bug: Add Rapyd for card payments
diff --git a/config/Development.toml b/config/Development.toml index e0315b066fc..761156a9a37 100644 --- a/config/Development.toml +++ b/config/Development.toml @@ -82,6 +82,9 @@ base_url = "https://apitest.cybersource.com/" [connectors.shift4] base_url = "https://api.shift4.com/" +[connectors.rapyd] +base_url = "h...
2023-01-12T07:12:12Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Integrating Rapyd Card transaction flow (no_three_ds, refund) ### Additional Changes - [ ] This PR modifies the database schema - ...
9fbe7384271584024c691252e577834ed0ebb878
Doing No-3ds, Separate authorize + capture transaction with rapyd <img width="1533" alt="Screenshot 2023-01-16 at 9 05 12 PM" src="https://user-images.githubusercontent.com/118727120/212717259-38015cfc-52ac-437c-bb7d-9f9008cae12b.png">
[ { "file_path": "config/Development.toml", "lines": [ "[connectors.rapyd]\n", "base_url = \"https://sandboxapi.rapyd.net\"\n", "\n", "\n" ] }, { "file_path": "config/config.example.toml", "lines": [ "[connectors.rapyd]\n", "base_url = \"https://sandboxapi.r...
[ { "file_path": "crates/router/src/configs/defaults.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\", \"cybersource\", \"fiserv\"]\n" ] }, { "file_path": "crates/router/src/connector.rs", "lines": [ " globalpay::Globalpay, klarna::...
[ "toml", "rs" ]
15
juspay/hyperswitch
juspay__hyperswitch-230
Bug: Add Global Payments for card payments
diff --git a/Cargo.lock b/Cargo.lock index 6aa461e603f..d8e14809b27 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -378,6 +378,19 @@ dependencies = [ "futures-core", ] +[[package]] +name = "async-compression" +version = "0.3.15" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "942c7cd7ae...
2023-01-09T09:42:31Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [X] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> - Adding support for [globalpay](https://www.globalpayments.com/en-ap) payment gateway - Updated...
1e04719ac328a56a9c632fe677bff049f19febf8
Added unit tests for mentioned payment flows. <img width="929" alt="Screenshot 2023-01-09 at 2 24 22 PM" src="https://user-images.githubusercontent.com/20727598/211273191-847a0acd-84db-473a-a051-2bc0686f1946.png">
[ { "file_path": "Cargo.lock", "lines": [ "[[package]]\n", "name = \"async-compression\"\n", "version = \"0.3.15\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"942c7cd7ae39e91bde4820d74132e9862e62c2f386c3aa90ccf55949f5bad63a\"\n", ...
[ { "file_path": "config/Development.toml", "lines": [ "wallets = [\"klarna\", \"braintree\", \"applepay\"]\n", "cards = [\"stripe\", \"adyen\", \"authorizedotnet\", \"checkout\", \"braintree\", \"aci\", \"shift4\", \"cybersource\", \"worldpay\"]\n" ] }, { "file_path": "config/config.e...
[ "sh", "toml", "lock", "rs" ]
26
juspay/hyperswitch
juspay__hyperswitch-231
Bug: Add Paypal for card payments
diff --git a/config/Development.toml b/config/Development.toml index 2989e035c65..25110882c8d 100644 --- a/config/Development.toml +++ b/config/Development.toml @@ -67,6 +67,7 @@ cards = [ "mollie", "multisafepay", "nuvei", + "paypal", "payu", "shift4", "stripe", @@ -106,6 +107,7 @@ kla...
2023-03-15T06:02:32Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Updating support for [Paypal](https://www.paypal.com/) payment gateway Payment Method: card Supported payment flows: Authorize Captur...
11df843610947d14da036f6f737dfb6f9abdae9b
<img width="972" alt="Screenshot 2023-03-15 at 4 02 29 AM" src="https://user-images.githubusercontent.com/70575890/225219741-08e2be3c-e126-4098-b528-b578fbc0e452.png">
[ { "file_path": "config/Development.toml", "lines": [ " \"paypal\",\n", "paypal.base_url = \"https://www.sandbox.paypal.com/\"\n" ] }, { "file_path": "config/config.example.toml", "lines": [ "paypal.base_url = \"https://www.sandbox.paypal.com/\" \n", " \"checkout...
[ { "file_path": "config/config.example.toml", "lines": [ " \"stripe\",\n", " \"checkout\",\n", " \"globalpay\",\n" ] }, { "file_path": "crates/router/src/connector.rs", "lines": [ " payu::Payu, rapyd::Rapyd, shift4::Shift4, stripe::Stripe, trustpay::Trustpa...
[ "toml", "rs" ]
19
juspay/hyperswitch
juspay__hyperswitch-228
Bug: Add Cybersource for card payments
diff --git a/config/Development.toml b/config/Development.toml index bc2b912fa37..f14f2300065 100644 --- a/config/Development.toml +++ b/config/Development.toml @@ -38,7 +38,7 @@ locker_decryption_key2 = "" [connectors.supported] wallets = ["klarna","braintree","applepay"] -cards = ["stripe","adyen","authorizedotne...
2022-12-15T07:20:40Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Adding Authorize call for `Cybersource` connector <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR mo...
e7579a4819358001768d2c6a5b04e10f8810e24f
Ran it and checked in cybersource sandbox.
[ { "file_path": "config/Development.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\",\"aci\",\"shift4\",\"cybersource\"]\n", "[connectors.cybersource]\n", "base_url = \"https://apitest.cybersource.com/\"\n", "\n" ] }, { "file_...
[ { "file_path": "config/Development.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\",\"aci\",\"shift4\"]\n" ] }, { "file_path": "config/config.example.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\...
[ "toml", "rs" ]
26
juspay/hyperswitch
juspay__hyperswitch-229
Bug: Add Fiserv for card payments
diff --git a/config/Development.toml b/config/Development.toml index 06b4d544c0a..fa61e28810c 100644 --- a/config/Development.toml +++ b/config/Development.toml @@ -43,7 +43,7 @@ locker_decryption_key2 = "" [connectors.supported] wallets = ["klarna","braintree","applepay"] -cards = ["stripe","adyen","authorizedotne...
2022-12-31T22:07:16Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description Authorize and capture flow Todo: Issue for optimising the encoding process in header and body #370 ### Additional Changes - [ ] Thi...
f0b89dda7b4fefbdd5e590dd79898ab0571f948b
Added unit tests for mentioned payment flows. <img width="784" alt="Screenshot 2023-01-13 at 7 43 38 PM" src="https://user-images.githubusercontent.com/55536657/212340057-35e12934-a1a8-4ca6-b411-729d27d6e357.png">
[ { "file_path": "config/Development.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\",\"aci\",\"shift4\",\"cybersource\", \"worldpay\", \"globalpay\", \"fiserv\"]\n", "[connectors.fiserv]\n", "base_url = \"https://cert.api.fiservapps.com/\"\n", ...
[ { "file_path": "config/Development.toml", "lines": [ "cards = [\"stripe\",\"adyen\",\"authorizedotnet\",\"checkout\",\"braintree\",\"aci\",\"shift4\",\"cybersource\", \"worldpay\", \"globalpay\"]\n" ] }, { "file_path": "config/docker_compose.toml", "lines": [ "cards = [\"stripe\"...
[ "toml", "rs" ]
18
juspay/hyperswitch
juspay__hyperswitch-115
Bug: Eliminate Lack of Diagnostics Information because of macro panicking Proc macro should not panic. When proc macro panics, it will be the only error message returned by the rust compiler. Instead, in case of errors, proc macro should emit compile_error!() to communicate error to the user. This will allow other ...
diff --git a/crates/router_derive/src/lib.rs b/crates/router_derive/src/lib.rs index 8f9015d484c..e1e04d0b818 100644 --- a/crates/router_derive/src/lib.rs +++ b/crates/router_derive/src/lib.rs @@ -427,5 +427,6 @@ pub fn api_error_derive(input: proc_macro::TokenStream) -> proc_macro::TokenStre /// used by `diesel`. #[...
2023-01-10T09:48:05Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [x] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Use compile_error in proc macros instead of panic. ### Additional Changes - [ ] This PR mod...
76ad42cc307491bb8599cde6e0edfb0a0b6b7c02
manual.
[ { "file_path": "crates/router_derive/src/lib.rs", "lines": [ " let input = syn::parse_macro_input!(input as syn::DeriveInput);\n", " macros::operation_derive_inner(input).unwrap_or_else(|err| err.to_compile_error().into())\n" ] }, { "file_path": "crates/router_derive/src/macros...
[ { "file_path": "crates/router_derive/src/lib.rs", "lines": [ " macros::operation_derive_inner(input)\n" ] }, { "file_path": "crates/router_derive/src/macros/operation.rs", "lines": [ "use syn::{self, parse_macro_input, DeriveInput, Lit, Meta, MetaNameValue, NestedMeta};\n", ...
[ "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-122
Bug: Use `frunk` deriving mechanisms to reduce boilerplate https://github.com/juspay/orca/blob/dddc9eaf1430adcd1293933e726c2f4f296c805b/crates/router/src/types/transformers.rs#L5-L14 Why not just use [frunk](https://crates.io/crates/frunk)? Here's an example: ```rust use frunk::LabelledGeneric; #[derive(L...
diff --git a/Cargo.lock b/Cargo.lock index 2d426b834c6..bb6e24c2b93 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -312,6 +312,8 @@ name = "api_models" version = "0.1.0" dependencies = [ "common_utils", + "frunk", + "frunk_core", "masking", "router_derive", "serde", @@ -1302,6 +1304,70 @@ dependencies = [ "url...
2022-12-13T14:47:21Z
## Type of Change - [x] Refactoring ## Motivation and Context Closes #122 ## How did you test it? Manual, compiler-guided. ## Checklist - [x] I formatted the code `cargo +nightly fmt` - [x] I addressed lints thrown by `cargo clippy` - [x] I reviewed submitted code
7f0d8e8286ea959614d9481e710d69f4ee9d30de
Manual, compiler-guided.
[ { "file_path": "Cargo.lock", "lines": [ " \"frunk\",\n", " \"frunk_core\",\n", "[[package]]\n", "name = \"frunk\"\n", "version = \"0.4.1\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"a89c703bf50009f383a0873845357cc400a95...
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ "#[derive(Clone, Copy, Debug, Default, Eq, PartialEq, strum::Display, strum::EnumString)]\n" ] }, { "file_path": "crates/api_models/src/payments.rs", "lines": [ "#[derive(Default, Clone, Debug, Eq, PartialEq, serde::Dese...
[ "toml", "lock", "rs" ]
9
juspay/hyperswitch
juspay__hyperswitch-185
Bug: feat: Get a Token with expiry for any connector payment flow `GlobalPayments` and `Paypal` are to connectors that require tokens to make any call to their Api's. These tokens have an expiry as well. Need feature to get the token for any of the connector flows to proceed with the payment.
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index ec38f147dda..1bd75a634fc 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -527,6 +527,12 @@ pub enum Connector { Worldpay, } +impl Connector { + pub fn supports_access_token(&self) -> bool { ...
2023-01-18T11:50:56Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] New feature ## Description <!-- Describe your changes in detail --> This PR will add the support for creating the access token for connectors which need it. ## Motivation and Context <!-- Why is this change required? What problem does ...
d761e52c35022b2137978a6d04bea3b5756d875f
Manual, Compiler guided.
[ { "file_path": "crates/api_models/src/enums.rs", "lines": [ "impl Connector {\n", " pub fn supports_access_token(&self) -> bool {\n", " matches!(self, Self::Globalpay)\n", " }\n", "}\n", "\n" ] }, { "file_path": "crates/router/src/connector/aci.rs...
[ { "file_path": "crates/router/src/connector/braintree.rs", "lines": [ " logger::debug!(payment_sync_response=?res);\n", " logger::debug!(braintreepayments_create_response=?response);\n" ] }, { "file_path": "crates/router/src/core/payments.rs", "lines": [ " ...
[ "rs" ]
38
juspay/hyperswitch
juspay__hyperswitch-110
Bug: Use `serde_repr` for serializing enums as u8 https://github.com/juspay/orca/blob/56d153d8f7c2c75391799cf14280c448df97842f/crates/router/src/connector/authorizedotnet/transformers.rs#L219-L227 Instead of such renaming, it would be more properly to use `#[repr(u8)]` here: ```rust #[derive(Serialize_repr, De...
diff --git a/Cargo.lock b/Cargo.lock index ad690392c9f..1605c94366b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2651,6 +2651,7 @@ dependencies = [ "serde_json", "serde_path_to_error", "serde_qs", + "serde_repr", "serde_urlencoded", "storage_models", "structopt", @@ -2910,6 +2911,17 @@ dependencies = [ "t...
2022-12-13T09:43:00Z
## Type of Chang - [x] Refactoring ## Motivation and Context Closes #110. ## Checklist - [x] I formatted the code `cargo +nightly fmt` - [x] I addressed lints thrown by `cargo clippy` - [x] I reviewed submitted code
6bf99048673c9a8f02dfe6f061226da03fc1aadb
[ { "file_path": "Cargo.lock", "lines": [ " \"serde_repr\",\n", "[[package]]\n", "name = \"serde_repr\"\n", "version = \"0.1.9\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"1fe39d9fbb0ebf5eb2c7cb7e2a47e4f462fad1379f1166b8ae49ad9...
[ { "file_path": "crates/router/src/connector/authorizedotnet/transformers.rs", "lines": [ "#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]\n", " #[serde(rename = \"1\")]\n", " Approved,\n", " #[serde(rename = \"2\")]\n", " Declined,\n", ...
[ "toml", "lock", "rs" ]
3
juspay/hyperswitch
juspay__hyperswitch-217
Bug: [FEATURE] Schedule webhook for retry ## Description Refactor webhooks core to add retry logic in webhooks core. Currently, we store information about whether we have sent a webhook or not, improving on this we can implement retry logic to make this more reliable
diff --git a/.typos.toml b/.typos.toml index 40acb130589..2d2e165544a 100644 --- a/.typos.toml +++ b/.typos.toml @@ -2,6 +2,7 @@ check-filename = true [default.extend-identifiers] +"ABD" = "ABD" # Aberdeenshire, UK ISO 3166-2 code BA = "BA" # Bosnia and Herzegovina country code CAF = "CAF" # Central African Re...
2024-02-27T08:30:01Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> This PR adds support for automatically retrying outgoing webhoo...
9917dd065444d66628039b19df7cd8e7d5c107db
As of now, outgoing webhooks are supported for payments, refunds, disputes and mandates. I've extensively tested payments outgoing webhooks for the different cases, and done a sanity testing on disputes and refunds webhooks to verify that they are retried in case the initial delivery attempt fails. Incoming mandate...
[ { "file_path": ".typos.toml", "lines": [ "\"ABD\" = \"ABD\" # Aberdeenshire, UK ISO 3166-2 code\n" ] }, { "file_path": "crates/api_models/src/webhooks.rs", "lines": [ " #[serde(default, with = \"custom_serde::iso8601\")]\n" ] }, { "file_path": "crates/diesel_model...
[ { "file_path": "crates/api_models/src/webhooks.rs", "lines": [ " #[serde(default, with = \"custom_serde::iso8601\")]\n" ] }, { "file_path": "crates/router/src/compatibility/wrap.rs", "lines": [ " Ok(api::ApplicationResponse::PaymenkLinkForm(boxed_payment_link_data)) => ...
[ "toml", "rs" ]
27
juspay/hyperswitch
juspay__hyperswitch-108
Bug: Consider adding `#![forbid(unsafe_code)]` [Here](https://github.com/juspay/orca/blob/main/crates/router/src/lib.rs) and in any other crate roots it's better to declare `#![forbid(unsafe_code)]` as we do in `masking` crate. This will ease a life of readers and auditors a lot, and will require quite a reasoning f...
diff --git a/crates/api_models/src/lib.rs b/crates/api_models/src/lib.rs index e5a864c7a45..84453c1d08a 100644 --- a/crates/api_models/src/lib.rs +++ b/crates/api_models/src/lib.rs @@ -1,3 +1,4 @@ +#![forbid(unsafe_code)] pub mod admin; pub mod bank_accounts; pub mod cards; diff --git a/crates/common_utils/src/lib.r...
2022-12-13T09:55:21Z
## Motivation and Context Closes #108 ## How did you test it? Manual, compiler-guided. ## Checklist - [x] I formatted the code `cargo +nightly fmt` - [x] I addressed lints thrown by `cargo clippy` - [x] I reviewed submitted code
6bf99048673c9a8f02dfe6f061226da03fc1aadb
Manual, compiler-guided.
[ { "file_path": "crates/api_models/src/lib.rs", "lines": [ "#![forbid(unsafe_code)]\n" ] }, { "file_path": "crates/common_utils/src/lib.rs", "lines": [ "#![forbid(unsafe_code)]\n" ] }, { "file_path": "crates/redis_interface/src/lib.rs", "lines": [ "#![forbid(...
[ { "file_path": "crates/router_derive/src/lib.rs", "lines": [ "\n" ] } ]
[ "rs" ]
6
juspay/hyperswitch
juspay__hyperswitch-107
Bug: Use `subtle` crate for constant-time comparison Usual comparison is not safe in cryptography as is lazy (fail-fast) and makes the code potentially vulnerable to timing attacks: https://www.chosenplaintext.ca/articles/beginners-guide-constant-time-cryptography.html. Use crates like `subtle` for constant-time co...
diff --git a/Cargo.lock b/Cargo.lock index 9e107e0a17d..9efade25962 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1808,6 +1808,7 @@ dependencies = [ "diesel", "serde", "serde_json", + "subtle", "zeroize", ] @@ -3053,6 +3054,12 @@ dependencies = [ "syn", ] +[[package]] +name = "subtle" +version = "2.4.1" ...
2022-12-06T21:11:47Z
## Type of Change - [x] Refactoring ## Motivation and Context Apply suggestions from code review #65 Closes #107 ## Checklist - [x] I formatted the code `cargo +nightly fmt` - [x] I addressed lints thrown by `cargo clippy` - [x] I reviewed submitted code
fc670ea0dad3dc8ce3549cb8888952070d2f4396
[ { "file_path": "Cargo.lock", "lines": [ " \"subtle\",\n", "[[package]]\n", "name = \"subtle\"\n", "version = \"2.4.1\"\n", "source = \"registry+https://github.com/rust-lang/crates.io-index\"\n", "checksum = \"6bdef32e8150c2a081110b42772ffe7d7c9032b606bc226c8260fd97e097660...
[ { "file_path": "crates/common_utils/src/pii.rs", "lines": [ " f.write_str(&format!(\n", " \"{}{}\",\n", " &val_str[..6],\n", " \"*\".repeat(val_str.len() - 6)\n", " ))\n", " f.write_str(&format!(\n", " ))\...
[ "toml", "rs", "lock", "md" ]
16
juspay/hyperswitch
juspay__hyperswitch-189
Bug: feat: Add connectors param to the get_headers method Allow `ConnectorIntegration::get_headers()` to accept `connectors` parameter so that we can set `Host` headers. requirement came for `Cybersource` #154
diff --git a/crates/router/src/connector/aci.rs b/crates/router/src/connector/aci.rs index 5b7569e9c69..eae5292ace5 100644 --- a/crates/router/src/connector/aci.rs +++ b/crates/router/src/connector/aci.rs @@ -92,6 +92,7 @@ impl fn get_headers( &self, req: &types::PaymentsSyncRouterData, + ...
2022-12-30T14:08:37Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [x] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> Some connectors requires endpoint URL and other connector related configs to build headers. To su...
bfc68581644ef90f9a3aec992ba4ea03ad517263
cargo test --package router --test connectors -- shift4 ![Screenshot 2022-12-30 at 7 10 55 PM](https://user-images.githubusercontent.com/20727986/210076872-95152336-13b1-45f9-b01f-c0d167e45e35.png)
[ { "file_path": "crates/router/src/connector/aci.rs", "lines": [ " _connectors: &settings::Connectors,\n", " .headers(types::PaymentsSyncType::get_headers(self, req, connectors)?)\n", " _connectors: &settings::Connectors,\n", " .headers(type...
[ { "file_path": "crates/router/src/connector/aci.rs", "lines": [ " .headers(types::PaymentsSyncType::get_headers(self, req)?)\n", " .headers(types::PaymentsAuthorizeType::get_headers(self, req)?)\n", " .headers(types::PaymentsVoidType::get_header...
[ "rs" ]
12
juspay/hyperswitch
juspay__hyperswitch-106
Bug: Use `#[automatically_derived]` for all derivations Consider to mark any new code/items, generated by procedural macros, with the `#[automatically_derived]` attribute. This makes code style linters to omit the generated code and doesn't report redundant warnings. Example: https://github.com/cucumber-rs/cucumb...
diff --git a/crates/router_derive/src/lib.rs b/crates/router_derive/src/lib.rs index 7bb020f3c13..cba0ef30129 100644 --- a/crates/router_derive/src/lib.rs +++ b/crates/router_derive/src/lib.rs @@ -176,6 +176,7 @@ pub fn setter(input: proc_macro::TokenStream) -> proc_macro::TokenStream { } }); let out...
2022-12-13T10:04:46Z
## Motivation and Context Closes #106 ## How did you test it? Manual, compiler-guided ## Checklist - [x] I formatted the code `cargo +nightly fmt` - [x] I addressed lints thrown by `cargo clippy` - [x] I reviewed submitted code
16cc0a4b38029447e18a20ddc856bd6fd3069a4c
Manual, compiler-guided
[ { "file_path": "crates/router_derive/src/lib.rs", "lines": [ " #[automatically_derived]\n" ] }, { "file_path": "crates/router_derive/src/macros.rs", "lines": [ " #[automatically_derived]\n" ] }, { "file_path": "crates/router_derive/src/macros/api_error.rs", ...
[]
[ "rs" ]
5
juspay/hyperswitch
juspay__hyperswitch-193
Bug: Use `Self` instead of type names in `impl` blocks Set up `clippy` to warn on [`clippy::use_self`](https://rust-lang.github.io/rust-clippy/master/#use_self) and address the lints thrown. (Originated from https://github.com/juspay/orca/pull/190#discussion_r1054060076)
diff --git a/connector-template/transformers.rs b/connector-template/transformers.rs index f379e016d71..34ac1e95892 100644 --- a/connector-template/transformers.rs +++ b/connector-template/transformers.rs @@ -90,12 +90,12 @@ impl Default for RefundStatus { } } -impl From<self::RefundStatus> for enums::RefundSta...
2022-12-21T10:36:04Z
## Description use Self alias wherever necessary to avoid repetition ## Motivation and Context This PR closes #193 ## Checklist - [x] I formatted the code `cargo +nightly fmt` - [x] I addressed lints thrown by `cargo clippy` - [x] I reviewed submitted code
57366f3304121b9f7dd8b4afa1ae002822c292e5
[ { "file_path": "connector-template/transformers.rs", "lines": [ "impl From<RefundStatus> for enums::RefundStatus {\n", " fn from(item: RefundStatus) -> Self {\n", " RefundStatus::Succeeded => Self::Success,\n", " RefundStatus::Failed => Self::Failure,\n", ...
[ { "file_path": "connector-template/transformers.rs", "lines": [ "impl From<self::RefundStatus> for enums::RefundStatus {\n", " fn from(item: self::RefundStatus) -> Self {\n", " self::RefundStatus::Succeeded => enums::RefundStatus::Success,\n", " self::RefundS...
[ "rs" ]
28
juspay/hyperswitch
juspay__hyperswitch-69
Bug: Feat: Ability to accept 3 values in ConnectorAuthType Currently we support max 2 values from keys.conf / db ```rust pub enum ConnectorAuthType { HeaderKey { api_key: String }, BodyKey { api_key: String, key1: String }, } ``` I'm trying to integrate Cybersource, it requires [`http signatures`](h...
diff --git a/crates/router/src/types.rs b/crates/router/src/types.rs index da5a6dcfbe3..06a1dbca5d5 100644 --- a/crates/router/src/types.rs +++ b/crates/router/src/types.rs @@ -213,8 +213,18 @@ pub struct ResponseRouterData<Flow, R, Request, Response> { #[derive(Debug, Clone, serde::Deserialize)] #[serde(tag = "auth_...
2022-12-07T12:00:47Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates ## Description This will allow us to accept 3 keys for a connector. Generally Public key, Private key and the merchant id. <!-- Describe your changes ...
21f3d5760959ecd82652b4024562654bcd404e26
[ { "file_path": "crates/router/src/types.rs", "lines": [ " HeaderKey {\n", " api_key: String,\n", " },\n", " BodyKey {\n", " api_key: String,\n", " key1: String,\n", " },\n", " SignatureKey {\n", " api_key: Strin...
[ { "file_path": "crates/router/src/types.rs", "lines": [ " HeaderKey { api_key: String },\n", " BodyKey { api_key: String, key1: String },\n" ] } ]
[ "rs" ]
1
juspay/hyperswitch
juspay__hyperswitch-16
Bug: Extend PR template to include config files directory paths This is to educate PR authors to look for config files at different places if their changes affect them.
2022-11-25T05:12:07Z
Closes #16
75ce0df41516696b18b39f693c29b8f1f105112b
[]
[]
[]
0
juspay/hyperswitch
juspay__hyperswitch-97
Bug: Make KV storage flow more generic Model the KV storage flow as a series of common operations (For example, `set in redis -> get sql query -> push query to redis stream`) and define generic utilities that perform these operations for all KV-enabled storage interfaces (as opposed to rewriting code).
diff --git a/crates/router/src/db/payment_attempt.rs b/crates/router/src/db/payment_attempt.rs index 3fb453d35be..8881682448f 100644 --- a/crates/router/src/db/payment_attempt.rs +++ b/crates/router/src/db/payment_attempt.rs @@ -315,7 +315,7 @@ impl PaymentAttemptInterface for MockDb { mod storage { use common_ut...
2023-02-03T10:47:35Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Refactoring ## Description <!-- Describe your changes in detail --> Use a generic function to push sql queries into drainer stream. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open...
9381a37f8f623deff46045156355a59a1fd02ee3
Manual
[ { "file_path": "crates/router/src/db/payment_attempt.rs", "lines": [ " use redis_interface::HsetnxReply;\n", " self.push_to_drainer_stream::<PaymentAttempt>(\n", " redis_entry,\n", " }\n", ...
[ { "file_path": "crates/router/src/db/payment_attempt.rs", "lines": [ " use redis_interface::{HsetnxReply, RedisEntryId};\n", " utils::storage_partitioning::KvStorePartition,\n", " let stream_name = self.get_drainer_stream_name(&PaymentAttempt::shard_key...
[ "rs" ]
4
juspay/hyperswitch
juspay__hyperswitch-227
Bug: Sync Open API specifications with latest additions The Open API specification needs to be updated to sync with: - [x] newly implemented APIs such as `/session` and `/verify` - [x] the addition/ changes in parameters of existing APIs shall also be modified in the specifications - [x] payment `status` fields...
diff --git a/openapi/open_api_spec.yaml b/openapi/open_api_spec.yaml index dc995b199d0..6728a7244e8 100644 --- a/openapi/open_api_spec.yaml +++ b/openapi/open_api_spec.yaml @@ -1,4610 +1,4603 @@ openapi: "3.0.1" info: - version: "0.2" - title: Juspay Router - API Documentation - x-logo: - url: "https:...
2022-12-29T14:26:38Z
## Type of Change <!-- Put an `x` in the boxes that apply --> - [x] Bugfix - [ ] New feature - [ ] Enhancement - [x] Refactoring - [ ] Dependency updates ## Description <!-- Describe your changes in detail --> (If you're reviewing, it's better to follow changes in each commit, except for the first one. F...
8535cecd7d2d73fc77f1dc05116128d083d49440
N/A
[ { "file_path": "openapi/open_api_spec.yaml", "lines": [ " version: \"0.2\"\n", " title: Juspay Router - API Documentation\n", " x-logo:\n", " url: \"https://fresheropenings.com/wp-content/uploads/2019/09/Juspay-off-campus-drive-2019.png\"\n", " altText: \"Juspay logo\"...
[ { "file_path": "openapi/open_api_spec.yaml", "lines": [ " version: \"0.2\"\n", " title: Juspay Router - API Documentation\n", " x-logo:\n", " url: \"https://fresheropenings.com/wp-content/uploads/2019/09/Juspay-off-campus-drive-2019.png\"\n", " altText: \...
[ "yaml", "json" ]
2
juspay/hyperswitch
juspay__hyperswitch-21
Bug: Rename `PaymentsRequestSyncData` struct to `PaymentsSyncData`. Rename the struct `PaymentsRequestSyncData` to `PaymentsSyncData`. Use this pattern `<Feature>Data`. And rename PaymentsRouterSyncData struct to PaymentsSyncRouterData. Pattern - `<Feature>RouterData` And rename the field name called `reques...
diff --git a/connector-template/mod.rs b/connector-template/mod.rs index 5651a6b04c3..c7f3a22094b 100644 --- a/connector-template/mod.rs +++ b/connector-template/mod.rs @@ -69,7 +69,7 @@ impl types::PaymentsRequestData, types::PaymentsResponseData, > for {{project-name | downcase | pascal_case}} ...
2022-11-30T09:06:18Z
## Type of Change - [x] Refactoring ## Description Rename the payment request router data with respective feature data, as suggesed [here](https://github.com/juspay/orca/pull/7#discussion_r1032366000) ### Additional Changes N.A ## Motivation and Context This PR closes #21 ## How did you test it? ...
5a5ac61d011d16153c317bde574055dc058190e6
[ { "file_path": "connector-template/mod.rs", "lines": [ " fn get_headers(&self, _req: &types::PaymentsAuthorizeRouterData) -> CustomResult<Vec<(String, String)>,errors::ConnectorError> {\n", " fn get_url(&self, _req: &types::PaymentsAuthorizeRouterData) -> CustomResult<String,errors::Connec...
[ { "file_path": "connector-template/mod.rs", "lines": [ " fn get_headers(&self, _req: &types::PaymentsRouterData) -> CustomResult<Vec<(String, String)>,errors::ConnectorError> {\n", " fn get_url(&self, _req: &types::PaymentsRouterData) -> CustomResult<String,errors::ConnectorError> {\n", ...
[ "rs" ]
29