repo stringclasses 20
values | pull_number float64 116 189k | instance_id stringlengths 17 34 | issue_numbers stringlengths 7 27 | base_commit stringlengths 40 40 | patch stringlengths 294 136k | test_patch stringlengths 405 47.1k | problem_statement stringlengths 148 24k | hints_text stringlengths 1 33.2k ⌀ | created_at stringdate 2016-08-20 07:52:07 2024-07-18 05:28:29 | language stringclasses 4
values | Dockerfile stringlengths 486 3.42k | P2P stringlengths 2 224k | F2P stringlengths 14 9.06k | F2F stringclasses 23
values | test_command stringlengths 27 951 | task_category stringclasses 3
values | is_no_nodes bool 2
classes | is_func_only bool 2
classes | is_class_only bool 2
classes | is_mixed bool 2
classes | num_func_changes int64 0 238 | num_class_changes int64 0 26 | num_nodes int64 0 264 | is_single_func bool 2
classes | is_single_class bool 2
classes | modified_nodes stringlengths 2 42.2k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
sveltejs/svelte | 3,702 | sveltejs__svelte-3702 | ['3588'] | 565931dff957545bf1b8a9ea57cfc097ed1a7e83 | diff --git a/src/compiler/compile/render_dom/wrappers/DebugTag.ts b/src/compiler/compile/render_dom/wrappers/DebugTag.ts
--- a/src/compiler/compile/render_dom/wrappers/DebugTag.ts
+++ b/src/compiler/compile/render_dom/wrappers/DebugTag.ts
@@ -59,21 +59,19 @@ export default class DebugTagWrapper extends Wrapper {
.... | diff --git a/test/js/samples/debug-no-dependencies/_config.js b/test/js/samples/debug-no-dependencies/_config.js
new file mode 100644
--- /dev/null
+++ b/test/js/samples/debug-no-dependencies/_config.js
@@ -0,0 +1,5 @@
+export default {
+ options: {
+ dev: true
+ }
+};
\ No newline at end of file
diff --git a/test/js/... | Compile error: Nested loops with index broke after 3.9.1
**Describe the bug**
You can see the exact same weird parsing behavior in the example below
**Logs**
Generated code is wrong, for instance when using `{@debug paneIndex}` it generates this:
` is still the culprit, as you said, though.
Turns out my issue was some sort of race condition.
... | 2019-10-13 06:16:05+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', 'ssr class-shortcut-with-class', 'ssr ... | ['js debug-no-dependencies'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/compile/render_dom/wrappers/DebugTag.ts->program->class_declaration:DebugTagWrapper->method_definition:render"] |
sveltejs/svelte | 3,749 | sveltejs__svelte-3749 | ['3595'] | 8d7d0ff7dd7b248ca6d9b6b4cac098430c6e6ffa | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@
* Allow exiting a reactive block early with `break $` ([#2828](https://github.com/sveltejs/svelte/issues/2828))
* Check attributes have changed before setting them to avoid image flicker ([#3579](https://github.com/sveltejs... | diff --git a/test/runtime/samples/if-block-compound-outro-no-dependencies/_config.js b/test/runtime/samples/if-block-compound-outro-no-dependencies/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/if-block-compound-outro-no-dependencies/_config.js
@@ -0,0 +1,3 @@
+export default {
+ html: `blah ... | Malformed generated code in a situation I can't describe
**Describe the bug**
For
```svelte
{#if $foo}
{:else}
{#if bar()}
<Baz/>
{/if}
{/if}
```
or alternatively
```svelte
{#if $foo}
{:else if bar()}
<Baz/>
{/if}
```
Svelte generates code like `if ((show_if == null) || ) show_if = !!(bar(... | An equivalent bug seems to be currently present in that branch. I'm getting an error about reducing an empty array [here](https://github.com/sveltejs/svelte/blob/d731766f3488bab42f14ad264f7092b592b937e3/src/compiler/compile/render_dom/wrappers/shared/changed.ts#L6), but at least a compile-time exception is better than ... | 2019-10-19 17:00:06+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', 'ssr class-shortcut-with-class', 'ssr ... | ['runtime if-block-compound-outro-no-dependencies ', 'runtime if-block-compound-outro-no-dependencies (with hydration)'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/compiler/compile/render_dom/wrappers/IfBlock.ts->program->class_declaration:IfBlockWrapper->method_definition:render_compound", "src/compiler/compile/render_dom/wrappers/IfBlock.ts->program->class_declaration:IfBlockWrapper->method_definition:render_compound_with_outros"] |
sveltejs/svelte | 3,949 | sveltejs__svelte-3949 | ['3948'] | 39bbac4393d2845989601e216a5d0b4579e1983f | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
# Svelte changelog
+## Unreleased
+
+* Add `aria-hidden="true"` to objects generated when adding resize-listeners, to improve accessibility ([#3948](https://github.com/sveltejs/svelte/issues/3948))
+
## 3.14.1
* Deconf... | diff --git a/test/runtime/samples/binding-width-height-a11y/_config.js b/test/runtime/samples/binding-width-height-a11y/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/binding-width-height-a11y/_config.js
@@ -0,0 +1,8 @@
+export default {
+ async test({ assert, target }) {
+ const object = tar... | bind:offsetWidth causes accessibility failure
**Describe the bug**
When using `bind:offsetWidth` on an element, an <object> element is added to the dom, but does not include any accessibility information.
**To Reproduce**
Add `bind:offsetWidth` to any element
**Expected behavior**
The element should be rendere... | Good catch.
Would `aria-hidden=true` be better here? That would remove it completely from the accessibility API while `role=none` will expose it but remove any semantic meaning.
Ahh yeah. I agree. That seems like the better solution. Thanks! | 2019-11-18 14:51:31+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', ... | ['runtime binding-width-height-a11y (with hydration)', 'runtime binding-width-height-a11y '] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/runtime/internal/dom.ts->program->function_declaration:add_resize_listener"] |
sveltejs/svelte | 4,146 | sveltejs__svelte-4146 | ['1277'] | fb6d570b921d0de764b20913020f81b1c16aa7f4 | diff --git a/src/compiler/compile/css/Selector.ts b/src/compiler/compile/css/Selector.ts
--- a/src/compiler/compile/css/Selector.ts
+++ b/src/compiler/compile/css/Selector.ts
@@ -63,9 +63,13 @@ export default class Selector {
});
}
- transform(code: MagicString, attr: string) {
+ transform(code: MagicString, att... | diff --git a/test/css/samples/preserve-specificity/expected.css b/test/css/samples/preserve-specificity/expected.css
new file mode 100644
--- /dev/null
+++ b/test/css/samples/preserve-specificity/expected.css
@@ -0,0 +1 @@
+a.svelte-xyz b c span.svelte-xyz{color:red;font-size:2em;font-family:'Comic Sans MS'}.foo.svelte... | Encapsulated CSS specificity bug
This is possibly a bit of an edge case, and it's something that can easily be worked around, but it's a bug nonetheless:
https://gist.github.com/giuseppeg/d37644d8d9d5004b15c5c48e66f632aa
```html
<div>
<div>
<div>
<span>
Big red Comic Sans
</span>
... | Hey is this the same problem? https://svelte.technology/repl?version=2.15.2&gist=e2a175d700754f4464c6e853585f1101 | 2019-12-23 03:28:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', ... | ['css preserve-specificity'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | false | false | true | 8 | 3 | 11 | false | false | ["src/compiler/compile/css/Stylesheet.ts->program->class_declaration:Rule->method_definition:transform", "src/compiler/compile/css/Selector.ts->program->class_declaration:Selector->method_definition:get_amount_class_specificity_increased", "src/compiler/compile/css/Stylesheet.ts->program->class_declaration:Rule->method... |
sveltejs/svelte | 4,288 | sveltejs__svelte-4288 | ['1733'] | e4460e38ba58d5209514f0fa93dc61b6bb1ebb54 | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
## Unreleased
+* Fix removing attributes during hydration ([#1733](https://github.com/sveltejs/svelte/issues/1733))
* Disallow two-way binding to a variable declared by an `{#await}` block ([#4012](https://github.com/sv... | diff --git a/test/hydration/samples/element-attribute-removed/_before.html b/test/hydration/samples/element-attribute-removed/_before.html
--- a/test/hydration/samples/element-attribute-removed/_before.html
+++ b/test/hydration/samples/element-attribute-removed/_before.html
@@ -1 +1 @@
-<div class='foo'></div>
\ No new... | Hydrating element removes every other attribute
I'm new to Svelte so it's entirely possible i'm missing something basic. I'm seeing some weird behavior around the hydration feature. Attributes on the element being hydrated are removed and I'm not sure why.
For example, given this markup:
```html
<span id="rehydr... | Thought I would have a good chunk of open source time to look into this today. So far I've only had time to add a failing test. Maybe helpful to someone?
https://github.com/sveltejs/svelte/compare/master...sammynave:multiple-attr-hydration?expand=1
I do believe the hydration feature is meant to be used with SSR, not a... | 2020-01-20 15:37:21+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', ... | ['hydration element-attribute-removed'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/runtime/internal/dom.ts->program->function_declaration:claim_element"] |
sveltejs/svelte | 4,332 | sveltejs__svelte-4332 | ['4314'] | 70d17950880e56f78c0a919b41ad2a356a9e37ff | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
## Unreleased
* Fix code generation error with adjacent inline and block comments ([#4312](https://github.com/sveltejs/svelte/issues/4312))
+* Fix detection of unused CSS selectors that begin with a `:global()` but contai... | diff --git a/test/css/samples/global-with-unused-descendant/_config.js b/test/css/samples/global-with-unused-descendant/_config.js
new file mode 100644
--- /dev/null
+++ b/test/css/samples/global-with-unused-descendant/_config.js
@@ -0,0 +1,24 @@
+export default {
+ warnings: [{
+ code: 'css-unused-selector',
+ end: ... | :global(...) .child selector is given svelte- suffix if there is a variable class name in the html
If there is an element with a `class={someVariable}` attribute in the markup, `:global(body) .className` child selectors get suffixed, and therefore don't apply to child components.
For example, if you have a parent co... | I do think there's a bug here, but I don't think it's what you're saying it is.
`.purple :global(.text)` is the selector that you should be using to refer to `.text` elements in any descendant of this component's `.purple` elements. This selector works with or without the `span` you mention.
`:global(.purple) .te... | 2020-01-27 23:02:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', ... | ['css global-with-unused-descendant'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/compile/css/Selector.ts->program->class_declaration:Selector->method_definition:constructor"] |
sveltejs/svelte | 4,454 | sveltejs__svelte-4454 | ['4323'] | b8bf3643d4590fee3afe5aae733e2ccc4547c110 | diff --git a/src/compiler/compile/render_dom/index.ts b/src/compiler/compile/render_dom/index.ts
--- a/src/compiler/compile/render_dom/index.ts
+++ b/src/compiler/compile/render_dom/index.ts
@@ -259,6 +259,9 @@ export default function dom(
inject_state;
if (has_invalidate) {
args.push(x`$$props`, x`$$invalidate... | diff --git a/test/js/samples/debug-hoisted/expected.js b/test/js/samples/debug-hoisted/expected.js
--- a/test/js/samples/debug-hoisted/expected.js
+++ b/test/js/samples/debug-hoisted/expected.js
@@ -50,6 +50,12 @@ function create_fragment(ctx) {
function instance($$self, $$props, $$invalidate) {
let obj = { x: 5 };
... | Unknown prop using export let and export function
Maybe a bug in this REPL: https://svelte.dev/repl/79aa242f7e6d4af684099868189d3cb4?version=3.18.0
If you click on button "toggle modal" in console you should have this warning:
`"<Form> was created with unknown prop 'saveForm'"`
If you remove from `Form.svelte`... | This looks like a bug, since `saveForm` is indeed declared, and `removeThis` should have no bearing on it. I'm going to mark it as such.
However, if you're trying to bind a variable through three layers of components like this I'd recommend using a store, since we're probably abusing bindings a bit using the current... | 2020-02-24 08:54:00+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', ... | ['js debug-no-dependencies', 'js loop-protect', 'runtime dev-warning-unknown-props-2 (with hydration)', 'runtime dev-warning-unknown-props-2 ', 'js debug-hoisted'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/compile/render_dom/index.ts->program->function_declaration:dom"] |
sveltejs/svelte | 4,558 | sveltejs__svelte-4558 | ['4549'] | ec3589e31425c54cda3c5f6a80b89eb3aaa7bd52 | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
* Allow `<svelte:self>` to be used in a slot ([#2798](https://github.com/sveltejs/svelte/issues/2798))
* Expose object of unknown props in `$$restProps` ([#2930](https://github.com/sveltejs/svelte/issues/2930))
+* Fix upd... | diff --git a/test/runtime/samples/each-block-keyed-else/_config.js b/test/runtime/samples/each-block-keyed-else/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/each-block-keyed-else/_config.js
@@ -0,0 +1,37 @@
+export default {
+ props: {
+ animals: ['alpaca', 'baboon', 'capybara'],
+ foo: 's... | Keyed {#each} block's {:else} statement is rendering when it shouldn't
**Describe the bug**
Keyed {#each} block's {:else} statement is rendering when it shouldn't (if the array was empty initially).
Keyed {#each} block's {:else} statement is not rendering when it should (if the array had values initially).
**To Re... | This can probably be combined with #4536.
> This can probably be combined with #4536.
Agreed - after noticing that one, I played with it more and found that whether it renders the :else depends entirely on whether the array was populated initially or not. It will always render if array had no value to start, and wi... | 2020-03-14 13:16:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with hydration)', 'runtime attribute-dynamic-quotemarks ', ... | ['runtime each-block-keyed-else (with hydration)', 'runtime each-block-keyed-else '] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["src/compiler/compile/render_dom/wrappers/EachBlock.ts->program->class_declaration:EachBlockWrapper->method_definition:render_unkeyed", "src/compiler/compile/render_dom/wrappers/EachBlock.ts->program->class_declaration:EachBlockWrapper", "src/compiler/compile/render_dom/wrappers/EachBlock.ts->program->class_declaratio... |
sveltejs/svelte | 5,452 | sveltejs__svelte-5452 | ['5449'] | 6e0cd9bcbf75645481557da23703eb051f7cec3f | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
## Unreleased
+* Fix destructuring into store values ([#5449](https://github.com/sveltejs/svelte/issues/5449))
* Fix erroneous `missing-declaration` warning with `use:obj.method` ([#5451](https://github.com/sveltejs/sve... | diff --git a/test/runtime/samples/reactive-assignment-in-complex-declaration-with-store-2/_config.js b/test/runtime/samples/reactive-assignment-in-complex-declaration-with-store-2/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/reactive-assignment-in-complex-declaration-with-store-2/_config.js
... | Destructuring into a store doesn't work since 3.26
**Describe the bug**
Please look at the repl code to see what's going on.
I'm trying to destructure two properties into stores which fails for the second value. It works for the first though.
**To Reproduce**
https://svelte.dev/repl/ee374115fae74168916e62549aa751... | Looks like the values are in there, just not destructured - https://svelte.dev/repl/17214fd2d84c4a44a6322f790886ff4f?version=3.26.0
I feel like this relates to https://github.com/sveltejs/svelte/issues/5437 and https://github.com/sveltejs/svelte/issues/5412 | 2020-09-24 10:27:03+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with ... | ['runtime reactive-assignment-in-complex-declaration-with-store-2 (with hydration)', 'runtime reactive-assignment-in-complex-declaration-with-store-2 '] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/compile/render_dom/invalidate.ts->program->function_declaration:invalidate"] |
sveltejs/svelte | 5,616 | sveltejs__svelte-5616 | ['5456'] | 99000ef42ebc7c725ed5958fe92c17f6b255f59e | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
## Unreleased
* Add a typed `SvelteComponent` interface ([#5431](https://github.com/sveltejs/svelte/pull/5431))
+* Support spread into `<slot>` props ([#5456](https://github.com/sveltejs/svelte/issues/5456))
* Fix settin... | diff --git a/test/runtime/samples/component-slot-spread/Nested.svelte b/test/runtime/samples/component-slot-spread/Nested.svelte
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/component-slot-spread/Nested.svelte
@@ -0,0 +1,7 @@
+<script>
+ export let obj;
+ export let c;
+ export let d;
+</script>
+
+<sl... | Pass arbitrary properties to slot
<!--
If you'd like to propose an implementation for a large new feature or change then please create an RFC:
https://github.com/sveltejs/rfcs
-->
**Is your feature request related to a problem? Please describe.**
I have run into cases where it would be nice to be able to pass ar... | I have wished for this as well...
Similarly, it could be useful to have a catch-all for the `let:` directive
```svelte
<Component let:$$lets>
<slot {...$$lets} />
</Component>
``` | 2020-10-30 11:16:55+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with ... | ['runtime component-slot-spread ', 'ssr component-slot-spread', 'runtime component-slot-spread (with hydration)'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Feature | false | true | false | false | 7 | 0 | 7 | false | false | ["src/compiler/compile/render_dom/wrappers/Element/index.ts->program->class_declaration:ElementWrapper->method_definition:add_spread_attributes", "src/compiler/compile/nodes/Slot.ts->program->class_declaration:Slot->method_definition:constructor", "src/compiler/compile/utils/get_slot_data.ts->program->function_declarat... |
sveltejs/svelte | 5,850 | sveltejs__svelte-5850 | ['5815'] | 9cc21e3c0998365cc295f3eb6af21ca69197c671 | diff --git a/CHANGELOG.md b/CHANGELOG.md
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
* Rework SSR store handling to subscribe and unsubscribe as in DOM mode ([#3375](https://github.com/sveltejs/svelte/issues/3375), [#3582](https://github.com/sveltejs/svelte/issues/3582), [#3636](https://github.com/sveltejs... | diff --git a/test/runtime/samples/transition-js-await-block-outros/_config.js b/test/runtime/samples/transition-js-await-block-outros/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/transition-js-await-block-outros/_config.js
@@ -0,0 +1,174 @@
+let fulfil;
+
+export default {
+ props: {
+ prom... | Each data is duplicated when using transitions in await syntax
**Describe the bug**
I try to use transitions in each of my data ({#each}) that I get after my Promise resolves. But when I re-assign it to the variable that holds the Promise, the displayed data actually increases.
Discord link => https://discord.com/c... | https://svelte.dev/repl/99c98342054542ca9c9a82f97c0f200c?version=3.31.0
after playing around in the repl
i've known a few things
- `#each` doesn't cause this ( no `#each` in above repl )
- `out` transition does
try changing `transition:name` to `in:name`(no issue) or `out:name`(this one does)
current behavior(to... | 2021-01-02 05:08:11+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with ... | ['runtime transition-js-await-block-outros ', 'runtime transition-js-await-block-outros (with hydration)'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/runtime/internal/await_block.ts->program->function_declaration:handle_promise->function_declaration:update"] |
sveltejs/svelte | 5,875 | sveltejs__svelte-5875 | ['5516'] | 8180c5dd6c6278f88a5ac82aecc3a2d1a5572c51 | diff --git a/src/compiler/parse/state/tag.ts b/src/compiler/parse/state/tag.ts
--- a/src/compiler/parse/state/tag.ts
+++ b/src/compiler/parse/state/tag.ts
@@ -376,7 +376,7 @@ function read_attribute(parser: Parser, unique_names: Set<string>) {
if (type === 'Binding' && directive_name !== 'this') {
check_unique... | diff --git a/test/parser/samples/action-duplicate/input.svelte b/test/parser/samples/action-duplicate/input.svelte
new file mode 100644
--- /dev/null
+++ b/test/parser/samples/action-duplicate/input.svelte
@@ -0,0 +1 @@
+<input use:autofocus use:autofocus>
\ No newline at end of file
diff --git a/test/parser/samples/ac... | Using an action twice throws "same attribute" error
https://svelte.dev/repl/01a14375951749dab9579cb6860eccde?version=3.29.0
```ts
<script>
function action(){}
</script>
<div use:action use:action />
```
```
Attributes need to be unique (5:16)
```
| Do you want to have the same script run twice on the node?
@peopledrivemecrazy @antony I have a similar question: Is it possible to use an action twice on the same node? I have written a small animation function that looks something like this:
```html
<div use:animate={{trigger: scrollY, opactiy: {start: 0, end: 20... | 2021-01-11 10:01:52+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'validate prop-slot', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'ssr each-block-else', 'runtime transition-js-each-block-outro (with hydration)', 'runtime whitespace-normal (with ... | ['parse action-duplicate'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/parse/state/tag.ts->program->function_declaration:read_attribute"] |
sveltejs/svelte | 6,414 | sveltejs__svelte-6414 | ['6386'] | 17c5402e311d7224aa8c11d979c9b32cb950883f | diff --git a/src/compiler/compile/render_dom/Renderer.ts b/src/compiler/compile/render_dom/Renderer.ts
--- a/src/compiler/compile/render_dom/Renderer.ts
+++ b/src/compiler/compile/render_dom/Renderer.ts
@@ -3,7 +3,7 @@ import { CompileOptions, Var } from '../../interfaces';
import Component from '../Component';
impor... | diff --git a/test/runtime/samples/bitmask-overflow-if-2/_config.js b/test/runtime/samples/bitmask-overflow-if-2/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/bitmask-overflow-if-2/_config.js
@@ -0,0 +1,23 @@
+// `bitmask-overflow-if` tests the case where the if condition is made of first 32 v... | Slot prop not update when transition finished
**Describe the bug**
If a transition happens on an element that contains a slot which has a prop, the slot prop does not properly update if it is rendered again immediately after the transition ends.
**To Reproduce**
https://svelte.dev/repl/773209884de04140b5e07e1cff49... | Did you try like this?
```
function blink() {
transitioning = true;
setTimeout(() => {
test = 'bar1';
transitioning = false;
}, 500); // if timeout value > duration time and slot prop `test` value will be 'bar'.
}
```
@kaisermann Yes, it is my solution currently. It is a workaround and doesn't solve the... | 2021-06-20 14:51:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'runtime each-block-random-permute (with hydration from ssr rendered html)', 'ssr each-block-else', 'runtime transition-js-each-block-out... | ['runtime transition-js-slot-3 ', 'runtime bitmask-overflow-if-2 (with hydration from ssr rendered html)', 'runtime transition-js-slot-fallback ', 'runtime transition-js-slot-fallback (with hydration from ssr rendered html)', 'runtime transition-js-slot-fallback (with hydration)', 'runtime bitmask-overflow-if-2 ', 'run... | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | false | false | true | 8 | 2 | 10 | false | false | ["src/compiler/compile/render_dom/Renderer.ts->program->class_declaration:Renderer->method_definition:get_initial_dirty->method_definition:type", "src/compiler/compile/render_dom/Renderer.ts->program->class_declaration:Renderer->method_definition:get_initial_dirty->method_definition:elements", "src/compiler/compile/ren... |
sveltejs/svelte | 6,458 | sveltejs__svelte-6458 | ['4551'] | b662c7fd41b3b778ea1ae80b0a4d86c239ffcfe7 | diff --git a/src/compiler/compile/render_ssr/handlers/Element.ts b/src/compiler/compile/render_ssr/handlers/Element.ts
--- a/src/compiler/compile/render_ssr/handlers/Element.ts
+++ b/src/compiler/compile/render_ssr/handlers/Element.ts
@@ -119,9 +119,11 @@ export default function(node: Element, renderer: Renderer, optio... | diff --git a/test/runtime/samples/apply-directives-in-order/_config.js b/test/runtime/samples/apply-directives-in-order/_config.js
--- a/test/runtime/samples/apply-directives-in-order/_config.js
+++ b/test/runtime/samples/apply-directives-in-order/_config.js
@@ -9,7 +9,7 @@ export default {
`,
ssrHtml: `
- <inpu... | Input type range bound value 0 is omitted from ssr
**Describe the bug**
The range element with a bound value 0 is omitted from server side rendering. This leads to the range input jumping(from default location) after client side js takes over. This issue seems to stem from 0 being a falsy value in Javascript.
**T... | I guess the issue is located here
https://github.com/sveltejs/svelte/blob/a66437b3c15e735139f9afb2ec25e3e1c612cd82/src/compiler/compile/render_ssr/handlers/Element.ts#L125-L127
https://github.com/sveltejs/svelte/blob/a66437b3c15e735139f9afb2ec25e3e1c612cd82/src/runtime/internal/ssr.ts#L130-L132
Would it be eno... | 2021-06-27 07:54:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'vars vars-report-full-script, generate: false', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'runtime each-block-random-permute (with hydration from ssr rendered html)', 'ssr each-b... | ['ssr binding-select-initial-value', 'ssr component-binding-store', 'ssr store-invalidation-while-update-2', 'ssr bindings-global-dependency', 'ssr binding-select-late-2', 'ssr each-block-destructured-default-binding', 'ssr binding-select-multiple', 'ssr binding-circular', 'ssr store-invalidation-while-update-1', 'ssr ... | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | [] |
sveltejs/svelte | 6,525 | sveltejs__svelte-6525 | ['6462'] | 33307a54c86daf45aa49f4cfaeef2ab07ff37ed0 | diff --git a/src/compiler/compile/Component.ts b/src/compiler/compile/Component.ts
--- a/src/compiler/compile/Component.ts
+++ b/src/compiler/compile/Component.ts
@@ -272,6 +272,14 @@ export default class Component {
} else {
let name = node.name.slice(1);
+ if (compile_options.hydratable) {
+... | diff --git a/test/js/samples/hydrated-void-element/expected.js b/test/js/samples/hydrated-void-element/expected.js
--- a/test/js/samples/hydrated-void-element/expected.js
+++ b/test/js/samples/hydrated-void-element/expected.js
@@ -8,7 +8,7 @@ import {
detach,
element,
init,
- insert,
+ insert_hydration,
noop,
... | Svelte "hello world" increased by 4.37kB (~59%) between Svelte 3.37.0 and 3.38.0
### Describe the bug
First off, thank you for maintaining Svelte. It's one of my favorite JavaScript frameworks for its ease-of-use, small bundle size, and runtime performance.
Unfortunately it seems that the baseline bundle size has i... | Yep I think it would probably make sense to have dumb versions of the claim functions that are used when hydration is not enabled at compile time.
I count around 4521 letters in the diff (quite close to 11.79K - 7.42K) with around 1719 characters from comments. So I guess this is the bundle size for debug builds, right... | 2021-07-13 14:39:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'vars vars-report-full-script, generate: false', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'runtime each-block-random-permute (with hydration from ssr rendered html)', 'ssr each-b... | ['js src-attribute-check', 'js hydrated-void-element'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Refactoring | false | false | false | true | 14 | 2 | 16 | false | false | ["src/runtime/internal/dom.ts->program->class_declaration:HtmlTag->method_definition:m", "src/runtime/internal/dom.ts->program->function_declaration:append_hydration", "src/runtime/internal/dom.ts->program->function_declaration:insert", "src/runtime/internal/dom.ts->program->class_declaration:HtmlTagHydration", "src/ru... |
sveltejs/svelte | 6,564 | sveltejs__svelte-6564 | ['6270'] | 63f592e7133bbb5730ceb61ca8184854fed52edb | diff --git a/src/compiler/parse/state/mustache.ts b/src/compiler/parse/state/mustache.ts
--- a/src/compiler/parse/state/mustache.ts
+++ b/src/compiler/parse/state/mustache.ts
@@ -290,16 +290,24 @@ export default function mustache(parser: Parser) {
const await_block_shorthand = type === 'AwaitBlock' && parser.eat('... | diff --git a/test/runtime/samples/await-catch-no-expression/_config.js b/test/runtime/samples/await-catch-no-expression/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/await-catch-no-expression/_config.js
@@ -0,0 +1,47 @@
+let fulfil;
+
+let thePromise = new Promise(f => {
+ fulfil = f;
+});
+
... | feature request: `{#await promise then}`
<!--
If you'd like to propose an implementation for a large new feature or change then please create an RFC:
https://github.com/sveltejs/rfcs
-->
**Is your feature request related to a problem? Please describe.**
If you have a promise whose resolve value you don't care ab... | A thought on the semantics of this, I think `{#await promise}` would make more sense than `{#await promise then}`. The `then` here doesn't have any significance in this case and could be omitted.
I'm pretty sure we need the `then`, because without it Svelte would interpret it as when the promise is pending.
I don't thi... | 2021-07-24 03:17:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'vars vars-report-full-script, generate: false', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'runtime each-block-random-permute (with hydration from ssr rendered html)', 'ssr each-b... | ['ssr await-catch-no-expression', 'runtime await-then-no-expression (with hydration from ssr rendered html)', 'ssr await-then-no-expression', 'runtime await-then-no-expression (with hydration)', 'runtime await-catch-no-expression (with hydration)', 'runtime await-then-no-expression ', 'runtime await-catch-no-expression... | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/parse/state/mustache.ts->program->function_declaration:mustache"] |
sveltejs/svelte | 6,759 | sveltejs__svelte-6759 | ['6753'] | cfc880bb31b09df50ea6619e71afa7f969d2c4d0 | diff --git a/src/runtime/internal/Component.ts b/src/runtime/internal/Component.ts
--- a/src/runtime/internal/Component.ts
+++ b/src/runtime/internal/Component.ts
@@ -124,7 +124,7 @@ export function init(component, options, instance, create_fragment, not_equal, p
on_disconnect: [],
before_update: [],
after_upd... | diff --git a/test/runtime/samples/constructor-prefer-passed-context/ChildComponent.svelte b/test/runtime/samples/constructor-prefer-passed-context/ChildComponent.svelte
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/constructor-prefer-passed-context/ChildComponent.svelte
@@ -0,0 +1,6 @@
+<script>
+ impor... | Bug when passing `getAllContexts()` to `new Component({ context })`
### Describe the bug
Some contexts are unexplicably removed from the map object when passing it to `new Component()`.
From #6447 it seems like this was it's intended usage.
### Reproduction
https://svelte.dev/repl/178ba9c6c46a43b9bcd8376262... | It seems like the context you pass in is completely ignored, which is because of this line:
https://github.com/sveltejs/svelte/blob/dad02847718084df495c7272c9e0d0f122d99c27/src/runtime/internal/Component.ts#L127
which would need to be changed to give preference to `options.context`, something like this:
` cont... | 2021-09-22 20:28:44+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'vars vars-report-full-script, generate: false', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'runtime each-block-random-permute (with hydration from ssr rendered html)', 'ssr each-b... | ['runtime constructor-prefer-passed-context (with hydration)', 'ssr constructor-prefer-passed-context', 'runtime constructor-prefer-passed-context ', 'runtime constructor-prefer-passed-context (with hydration from ssr rendered html)'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/runtime/internal/Component.ts->program->function_declaration:init", "src/runtime/internal/ssr.ts->program->function_declaration:create_ssr_component->function_declaration:$$render"] |
sveltejs/svelte | 6,941 | sveltejs__svelte-6941 | ['6914', '6914'] | 4018b548f3e7728e7bec1b3e13a5f0d59b0342cd | diff --git a/src/compiler/compile/render_dom/wrappers/Element/Attribute.ts b/src/compiler/compile/render_dom/wrappers/Element/Attribute.ts
--- a/src/compiler/compile/render_dom/wrappers/Element/Attribute.ts
+++ b/src/compiler/compile/render_dom/wrappers/Element/Attribute.ts
@@ -10,6 +10,21 @@ import handle_select_value... | diff --git a/test/js/samples/input-value/expected.js b/test/js/samples/input-value/expected.js
--- a/test/js/samples/input-value/expected.js
+++ b/test/js/samples/input-value/expected.js
@@ -2,12 +2,14 @@
import {
SvelteComponent,
append,
+ attr,
detach,
element,
init,
insert,
listen,
noop,
+ run_all,
... | Cursor jumps to end in search box in Safari
### Describe the bug
The cursor in a search box (`input[type="search"]`) with a two-way value binding jumps to the end when typing in Safari. I don't know my way around the Svelte code base, but looking at previous cursor issues, I think `'search`' would have to be added to... | Yup, looking at #4179 where this code was originally added, this sounds like a reasonable suggestion. Are there other text-like input `type`s we should also be handling? Or, would it be better to just exclude all of the `type`s that _aren't_ text-like, which might make this a little more future-proof?
Yup, looking at #... | 2021-11-19 08:53:24+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'vars vars-report-full-script, generate: false', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydration)', 'runtime each-block-random-permute (with hydration from ssr rendered html)', 'ssr each-b... | ['js input-value'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/compile/render_dom/wrappers/Element/Attribute.ts->program->class_declaration:AttributeWrapper->method_definition:get_dom_update_conditions"] |
sveltejs/svelte | 7,422 | sveltejs__svelte-7422 | ['7408'] | 5f020cc91e2c19ae88e92ae9ce3695d980a7e144 | diff --git a/src/compiler/compile/render_dom/wrappers/KeyBlock.ts b/src/compiler/compile/render_dom/wrappers/KeyBlock.ts
--- a/src/compiler/compile/render_dom/wrappers/KeyBlock.ts
+++ b/src/compiler/compile/render_dom/wrappers/KeyBlock.ts
@@ -36,6 +36,7 @@ export default class KeyBlockWrapper extends Wrapper {
nam... | diff --git a/test/runtime/samples/key-block-component-slot/Component1.svelte b/test/runtime/samples/key-block-component-slot/Component1.svelte
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/key-block-component-slot/Component1.svelte
@@ -0,0 +1 @@
+<slot/>
diff --git a/test/runtime/samples/key-block-compo... | Impossible to pass key blocks through slots
### Describe the bug
I'm trying to use a key block to rerender a component based on a condition, but I noticed that if a component is nested it looks like it doesn't actually get re-rendered
### Reproduction
https://svelte.dev/repl/990bc381eae748a2822c3d07304d14c2?version=... | @alextana Interestingly, if you pass the `key` into the nested component as a prop, it works as you expect it to: https://svelte.dev/repl/28bfa9addc014a8586ea88a03ed1e80e?version=3.46.5
Yeah, that's interesting and it works well enough for me to close this, thanks a lot @kindoflew :)
even if it's possible when it's pas... | 2022-04-06 15:31:16+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote re... | ['runtime prop-without-semicolon ', 'ssr sigil-expression-function-body', 'runtime if-block-else ', 'vars vars-report-full-script, generate: false', 'runtime inline-style-directive-and-style-attr-merged (with hydration from ssr rendered html)', 'runtime immutable-nested ', 'runtime await-then-destruct-array (with hydra... | ['runtime key-block-component-slot ', 'runtime key-block-component-slot (with hydration from ssr rendered html)', 'runtime key-block-component-slot (with hydration)'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/compiler/compile/render_dom/wrappers/KeyBlock.ts->program->class_declaration:KeyBlockWrapper->method_definition:constructor"] |
prettier/prettier | 14,400 | prettier__prettier-14400 | ['13197'] | 6905b39ec7bc6ed38732e26ceced5b57677e2600 | diff --git a/changelog_unreleased/html/14400.md b/changelog_unreleased/html/14400.md
new file mode 100644
index 000000000000..7d9accfd49ed
--- /dev/null
+++ b/changelog_unreleased/html/14400.md
@@ -0,0 +1,38 @@
+#### Format `<script>` inside SVG (#14400 by @fisker)
+
+<!-- prettier-ignore -->
+```html
+<!-- Input -->
+... | diff --git a/tests/config/utils/check-parsers.js b/tests/config/utils/check-parsers.js
index 166b37619f6f..a8def844d115 100644
--- a/tests/config/utils/check-parsers.js
+++ b/tests/config/utils/check-parsers.js
@@ -46,7 +46,10 @@ const categoryParsers = new Map([
"handlebars",
{ parsers: ["glimmer"], verifyPa... | Script in SVG is incorrectly formatted when using HTML parser
<!--
BEFORE SUBMITTING AN ISSUE:
1. Search for your issue on GitHub: https://github.com/prettier/prettier/issues
A large number of opened issues are duplicates of existing issues.
If someone has already opened an issue for what you are exper... | null | 2023-02-22 12:55:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/format/html/svg/embeded/jsfmt.spec.js->format'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/format/html/svg/svg.html tests/config/utils/check-parsers.js tests/format/html/svg/embeded/__snapshots__/jsfmt.spec.js.snap tests/format/html/svg/embeded/svg.svg tests/format/html/svg/embeded/jsfmt.spec.js tests/format... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/language-html/utils/index.js->program->function_declaration:isScriptLikeTag"] |
prettier/prettier | 12,930 | prettier__prettier-12930 | ['12926'] | 3147244f55e6e0aafd2cc6fa5875f7c8cfa8e4e3 | diff --git a/changelog_unreleased/typescript/12930.md b/changelog_unreleased/typescript/12930.md
new file mode 100644
index 000000000000..9c6fde5af05a
--- /dev/null
+++ b/changelog_unreleased/typescript/12930.md
@@ -0,0 +1,19 @@
+#### fix formatting for typescript Enum with computed members (#12930 by @HosokawaR)
+
+<!... | diff --git a/tests/format/typescript/enum/__snapshots__/jsfmt.spec.js.snap b/tests/format/typescript/enum/__snapshots__/jsfmt.spec.js.snap
index 82de64f80d39..0a37faedb892 100644
--- a/tests/format/typescript/enum/__snapshots__/jsfmt.spec.js.snap
+++ b/tests/format/typescript/enum/__snapshots__/jsfmt.spec.js.snap
@@ -1... | Syntax error after formatting when using computed key in TypeScript enum
**Prettier 2.6.2**
[Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuECCuBbABAQS8AHSiywG0BLAakoF0iBfEAGhAgAcZzoBnZUAQwBOgiAHcACkIS8U-ADaj+AT14sARoP5gA1nBgBlfhjgAZclDjIAZvO5x1mnXv1st5gObIYgtPdQY1OAATIOCTfih3NH53OAAxCEEMfhhOSOQQfjQ... | null | 2022-05-27 08:36:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/format/typescript/enum/jsfmt.spec.js->multiline.ts format', '/testbed/tests/format/typescript/enum/jsfmt.spec.js->enum.ts [babel-ts] format', '/testbed/tests/format/typescript/enum/jsfmt.spec.js->enum.ts format', '/testbed/tests/format/typescript/enum/jsfmt.spec.js->computed-members.ts [babel-ts] forma... | ['/testbed/tests/format/typescript/enum/jsfmt.spec.js->computed-members.ts format'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/format/typescript/enum/computed-members.ts tests/format/typescript/enum/__snapshots__/jsfmt.spec.js.snap tests/format/typescript/enum/jsfmt.spec.js --json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/language-js/print/typescript.js->program->function_declaration:printTypescript"] |
prettier/prettier | 11,637 | prettier__prettier-11637 | ['11635'] | 5909f5b3f191a0a32f759e1f4378477d3b90e28e | diff --git a/changelog_unreleased/scss/11637.md b/changelog_unreleased/scss/11637.md
new file mode 100644
index 000000000000..424a5534787b
--- /dev/null
+++ b/changelog_unreleased/scss/11637.md
@@ -0,0 +1,21 @@
+#### Improve `with (...)` formatting (#11637 by @sosukesuzuki)
+
+<!-- prettier-ignore -->
+```scss
+// Inpu... | diff --git a/tests/format/scss/configuration/__snapshots__/jsfmt.spec.js.snap b/tests/format/scss/configuration/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..2acdbfd02d9d
--- /dev/null
+++ b/tests/format/scss/configuration/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,94 @@
+// Jest Snapshot v... | Weird wrapping for SCSS @use rules
<!--
BEFORE SUBMITTING AN ISSUE:
1. Search for your issue on GitHub: https://github.com/prettier/prettier/issues
A large number of opened issues are duplicates of existing issues.
If someone has already opened an issue for what you are experiencing,
you do not ne... | hm, both looks good...
I think the indent should not be there @alexander-akait
But it is also inconsistent with the SCSS map wrapping which does not wrap the opening parentheses to the next line | 2021-10-08 14:58:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/format/scss/configuration/jsfmt.spec.js->use.scss - {"trailingComma":"none"} format', '/testbed/tests/format/scss/configuration/jsfmt.spec.js->use.scss format'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/format/scss/configuration/jsfmt.spec.js tests/format/scss/configuration/__snapshots__/jsfmt.spec.js.snap tests/format/scss/quotes/__snapshots__/jsfmt.spec.js.snap tests/format/scss/configuration/use.scss --json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/language-css/printer-postcss.js->program->function_declaration:genericPrint", "src/language-css/utils.js->program->function_declaration:isConfigurationNode"] |
prettier/prettier | 11,000 | prettier__prettier-11000 | ['10964'] | c8133f8afabbfa0b6a8f88da8a37c8e79d9f5671 | diff --git a/changelog_unreleased/cli/11000.md b/changelog_unreleased/cli/11000.md
new file mode 100644
index 000000000000..64e1d3d58f69
--- /dev/null
+++ b/changelog_unreleased/cli/11000.md
@@ -0,0 +1,17 @@
+#### Fix failure on dir with trailing slash (#11000 by @fisker)
+
+<!-- prettier-ignore -->
+```console
+$ ls
+... | diff --git a/tests/integration/__tests__/__snapshots__/patterns-dirs.js.snap b/tests/integration/__tests__/__snapshots__/patterns-dirs.js.snap
index 1ef92eb65958..8be8bd58f651 100644
--- a/tests/integration/__tests__/__snapshots__/patterns-dirs.js.snap
+++ b/tests/integration/__tests__/__snapshots__/patterns-dirs.js.sn... | CLI fails when passed a dir with trailing slash: `prettier dir/`
**Environments:**
- Prettier Version: 2.3.0
- Running Prettier via: CLI
- Runtime: Node.js v14
- Operating System: Linux (WSL 2 w/ Debian buster)
- Prettier plugins (if any): No plugins
**Steps to reproduce:**
Run `npx prettier code/` with a ... | null | 2021-06-01 01:43:09+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ["/testbed/tests/integration/__tests__/patterns-dirs.js->2: prettier dir1 'dir2/**/*' (write)", '/testbed/tests/integration/__tests__/patterns-dirs.js->Trailing slash 5: prettier .//dir2/..//./dir1// (write)', "/testbed/tests/integration/__tests__/patterns-dirs.js->2: prettier dir1 'dir2/**/*' (stdout)", "/testbed/test... | ['/testbed/tests/integration/__tests__/patterns-dirs.js->Trailing slash 1: prettier ./ (stdout)', '/testbed/tests/integration/__tests__/patterns-dirs.js->Trailing slash run in sub dir 2: prettier ../ (stdout)', '/testbed/tests/integration/__tests__/patterns-dirs.js->Trailing slash 5: prettier .//dir2/..//./dir1// (stde... | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/integration/__tests__/patterns-dirs.js tests/integration/__tests__/__snapshots__/patterns-dirs.js.snap --json | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | [] |
prettier/prettier | 9,850 | prettier__prettier-9850 | ['3009'] | 19a8df2f572f1bc4504cebe0614f45f868b786fa | diff --git a/changelog_unreleased/javascript/9850.md b/changelog_unreleased/javascript/9850.md
new file mode 100644
index 000000000000..313a6c192eaf
--- /dev/null
+++ b/changelog_unreleased/javascript/9850.md
@@ -0,0 +1,31 @@
+#### Fix extra semicolon added to ignored directives (#9850 by @fisker)
+
+<!-- prettier-igno... | diff --git a/tests/js/ignore/semi/__snapshots__/jsfmt.spec.js.snap b/tests/js/ignore/semi/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..e836b8979c5e
--- /dev/null
+++ b/tests/js/ignore/semi/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,62 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+expor... | prettier-ignore causes an extra semicolon
**Prettier 1.12.1**
[Playground link](https://prettier.io/playground/#%7B%22content%22%3A%22%2F%2F%20prettier-ignore%5Cn%5Ct'some%20text'%3B%22%2C%22options%22%3A%7B%22ast%22%3Afalse%2C%22bracketSpacing%22%3Atrue%2C%22doc%22%3Afalse%2C%22jsxBracketSameLine%22%3Afalse%2C%22outp... | The indentation isn't supposed to be preserved, but the extra semicolon is a bug. | 2020-12-09 03:22:04+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js - {"semi":false} [flow] format', '/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js - {"semi":false} [meriyah] format', '/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js - {"semi":false} [espree] format', '/testbed/tests/js/ignore/semi/jsfmt.s... | ['/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js [flow] format', '/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js [typescript] format', '/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js [meriyah] format', '/testbed/tests/js/ignore/semi/jsfmt.spec.js->directive.js format', '/testbed/tests/j... | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/js/ignore/semi/__snapshots__/jsfmt.spec.js.snap tests/js/ignore/semi/jsfmt.spec.js tests/js/ignore/semi/directive.js --json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/language-js/printer-estree.js->program->function_declaration:printPathNoParens", "src/language-js/print/block.js->program->function_declaration:printBlock"] |
prettier/prettier | 8,777 | prettier__prettier-8777 | ['8773'] | d07267184278fcc3fa0fb57628653f9b6daed607 | diff --git a/src/main/ast-to-doc.js b/src/main/ast-to-doc.js
index 7d861c258595..ebf9471d5cd8 100644
--- a/src/main/ast-to-doc.js
+++ b/src/main/ast-to-doc.js
@@ -89,6 +89,26 @@ function printAstToDoc(ast, options, alignmentSize = 0) {
return doc;
}
+function printPrettierIgnoredNode(node, options) {
+ const {
+... | diff --git a/tests/markdown/broken-plugins/__snapshots__/jsfmt.spec.js.snap b/tests/markdown/broken-plugins/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..c571208bc17f
--- /dev/null
+++ b/tests/markdown/broken-plugins/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,19 @@
+// Jest Snapshot v1, htt... | Prettier doesn't throw an error for not printed comments with `prettier-ignore` comment
If input includes `prettier-ignore` comment, Prettier doesn't throw an error for not printed comments. I'm not sure it depends on languages.
(The below example code uses #7126 bug.)
**Prettier 2.0.5**
[Playground link](https://... | This is expected. `prettier-ignore` leads to outputting a portion of the input file instead of printing AST nodes, so the comments in the AST remain marked as not printed.
I thought this is not expected because `prettier-ignore` comment affects to other than its target node. At least I think users will be confused.
I m... | 2020-07-17 02:41:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/misc/errors/broken-plugin/jsfmt.spec.js->snippet: #0 error test'] | ['/testbed/tests/vue/broken-plugins/jsfmt.spec.js->missing-comments.vue format', '/testbed/tests/markdown/broken-plugins/jsfmt.spec.js->missing-comments.md format'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/misc/errors/typescript/__snapshots__/jsfmt.spec.js.snap tests/vue/broken-plugins/__snapshots__/jsfmt.spec.js.snap tests_config/prettier-plugins/prettier-plugin-missing-comments/index.js tests/misc/errors/broken-plugin/... | Bug Fix | false | true | false | false | 7 | 0 | 7 | false | false | ["src/main/multiparser.js->program->function_declaration:textToDoc", "src/main/comments.js->program->function_declaration:ensureAllCommentsPrinted", "src/main/ast-to-doc.js->program->function_declaration:printPrettierIgnoredNode", "src/main/core.js->program->function_declaration:attachComments", "src/main/core.js->prog... |
prettier/prettier | 8,046 | prettier__prettier-8046 | ['8041'] | 19545e049ea424273fb6d647eefd1787d998b333 | diff --git a/changelog_unreleased/typescript/pr-8046.md b/changelog_unreleased/typescript/pr-8046.md
new file mode 100644
index 000000000000..0b19f0bb9018
--- /dev/null
+++ b/changelog_unreleased/typescript/pr-8046.md
@@ -0,0 +1,19 @@
+#### Fix the `babel-ts` parser so that it emits a proper syntax error for `(a:b)` ([... | diff --git a/tests/misc/errors/babel-ts/__snapshots__/jsfmt.spec.js.snap b/tests/misc/errors/babel-ts/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..f7efaedf67d4
--- /dev/null
+++ b/tests/misc/errors/babel-ts/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,8 @@
+// Jest Snapshot v1, https://goo.g... | babel-ts crashes on `(a:b)`
**Prettier 2.0.4**
[Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAKAhkgRgShAGhAgAcYBLaAZ2VHQCc6IB3ABXoWpXQBsn0BPaoSx10YANZwYAZWJiyUAObIYdAK5xCACxgBbbgHUtZeJTlg40jibIA3E-2ThKQkAspw6MFqMW70yABmPB6EAFaUAB4AQqISUtLounAAMgpwQSGaIBGR0gqK3HAAimoQ8JncoSBydB50TljoWHDcALQwrsR0Cj... | null | 2020-04-13 21:39:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/misc/errors/babel-ts/jsfmt.spec.js->issue-8041.ts error test'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/misc/errors/babel-ts/__snapshots__/jsfmt.spec.js.snap tests/misc/errors/babel-ts/issue-8041.ts tests/misc/errors/babel-ts/jsfmt.spec.js --json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/language-js/parser-babel.js->program->function_declaration:rethrowSomeRecoveredErrors", "src/language-js/parser-babel.js->program->function_declaration:tryCombinations"] |
prettier/prettier | 6,604 | prettier__prettier-6604 | ['6603'] | affa24ce764bd14ac087abeef0603012f5c635d6 | diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
index b6e4f385e5e0..6db041af81cb 100644
--- a/CHANGELOG.unreleased.md
+++ b/CHANGELOG.unreleased.md
@@ -742,6 +742,29 @@ Previously, the flag was not applied on html attributes.
<div class='a-class-name'></div>
```
+#### TypeScript: Fix incorrectly remo... | diff --git a/tests/typescript_conditional_types/__snapshots__/jsfmt.spec.js.snap b/tests/typescript_conditional_types/__snapshots__/jsfmt.spec.js.snap
index 6bf4a520de1f..34f70876e92b 100644
--- a/tests/typescript_conditional_types/__snapshots__/jsfmt.spec.js.snap
+++ b/tests/typescript_conditional_types/__snapshots__/... | [TypeScript] Prettier incorrectly removes double parentheses around types
**Prettier 1.18.2**
[Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEB6VACAwhATruMGAHVgE8AHODAFQEYMBeDABgzgA94oATAZwwAKBp278MAJgwYA-BgDMGJBgAsASlkYArEowA2UugwAhAK4BzUjErV6AfQBGFpq3ZcE4wcLdiBUzYrK6hpyOsoGUIaYOPiEJORUtFLMgmyiHgI... | null | 2019-10-04 11:17:15+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/typescript_intersection/jsfmt.spec.js->intersection-parens.ts'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/typescript_intersection/__snapshots__/jsfmt.spec.js.snap tests/typescript_union/__snapshots__/jsfmt.spec.js.snap tests/typescript_union/inlining.ts tests/typescript_intersection/jsfmt.spec.js tests/typescript_keyof/key... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/language-js/needs-parens.js->program->function_declaration:needsParens"] |
prettier/prettier | 5,025 | prettier__prettier-5025 | ['5023'] | 93e8b15311cc88d30eadf8a34acbc062d0965f2b | diff --git a/src/language-markdown/printer-markdown.js b/src/language-markdown/printer-markdown.js
index b6e66b2f85f9..a65a876f992a 100644
--- a/src/language-markdown/printer-markdown.js
+++ b/src/language-markdown/printer-markdown.js
@@ -345,24 +345,37 @@ function genericPrint(path, options, print) {
return con... | diff --git a/tests/markdown_footnoteDefinition/__snapshots__/jsfmt.spec.js.snap b/tests/markdown_footnoteDefinition/__snapshots__/jsfmt.spec.js.snap
index bb602780742c..7df73e3e7c01 100644
--- a/tests/markdown_footnoteDefinition/__snapshots__/jsfmt.spec.js.snap
+++ b/tests/markdown_footnoteDefinition/__snapshots__/jsfm... | Markdown footnotes formatted incorrectly with long lines
In markdown, for footnotes that have more characters than the column width, prettier breaks the footnote reference apart into a new line. This makes the footnote not generate properly using kramdown, as the new line after the reference block and colon makes the f... | null | 2018-08-29 05:36:14+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/markdown_footnoteDefinition/jsfmt.spec.js->long.md - markdown-verify', '/testbed/tests/markdown_footnoteDefinition/jsfmt.spec.js->multiline.md - markdown-verify', '/testbed/tests/markdown_footnoteDefinition/jsfmt.spec.js->simple.md - markdown-verify', '/testbed/tests/markdown_footnoteDefinition/jsfmt.s... | ['/testbed/tests/markdown_footnoteDefinition/jsfmt.spec.js->long.md - markdown-verify'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/markdown_footnoteDefinition/long.md tests/markdown_footnoteDefinition/jsfmt.spec.js tests/markdown_footnoteDefinition/__snapshots__/jsfmt.spec.js.snap --json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/language-markdown/printer-markdown.js->program->function_declaration:genericPrint"] |
prettier/prettier | 4,667 | prettier__prettier-4667 | ['4446'] | 4a16319470cfb929799783118ad78afcf99461d2 | diff --git a/src/config/resolve-config.js b/src/config/resolve-config.js
index 229caf3d5fdd..c8f0f43433ab 100644
--- a/src/config/resolve-config.js
+++ b/src/config/resolve-config.js
@@ -48,6 +48,17 @@ function _resolveConfig(filePath, opts, sync) {
mergeOverrides(Object.assign({}, result), filePath)
);
+... | diff --git a/tests_integration/__tests__/config-resolution.js b/tests_integration/__tests__/config-resolution.js
index 25a610e533a9..d78a55eb84ae 100644
--- a/tests_integration/__tests__/config-resolution.js
+++ b/tests_integration/__tests__/config-resolution.js
@@ -226,3 +226,12 @@ test("API resolveConfig.sync removes... | Support relative paths for plugin and pluginSearchDir in config files
Context: https://github.com/prettier/prettier/pull/4192#discussion_r186809767
| null | 2018-06-11 16:20:55+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests_integration/__tests__/config-resolution.js->resolves configuration from external files and overrides by extname (stderr)', '/testbed/tests_integration/__tests__/config-resolution.js->CLI overrides take precedence (stdout)', '/testbed/tests_integration/__tests__/config-resolution.js->API resolveConfig.s... | ['/testbed/tests_integration/__tests__/config-resolution.js->API resolveConfig resolves relative path values based on config filepath'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests_integration/cli/config/resolve-relative/.prettierrc tests_integration/__tests__/config-resolution.js --json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["src/config/resolve-config.js->program->function_declaration:_resolveConfig"] |
prettier/prettier | 3,723 | prettier__prettier-3723 | ['3440'] | bef646d4a4d2df9a7e1e06ea5dd28380475f624c | diff --git a/src/language-css/printer-postcss.js b/src/language-css/printer-postcss.js
index 794ae803508c..b2d4afdb4649 100644
--- a/src/language-css/printer-postcss.js
+++ b/src/language-css/printer-postcss.js
@@ -30,7 +30,13 @@ function genericPrint(path, options, print) {
switch (n.type) {
case "css-root":... | diff --git a/tests/css_empty_file/__snapshots__/jsfmt.spec.js.snap b/tests/css_empty_file/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..11ebcf01b744
--- /dev/null
+++ b/tests/css_empty_file/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+expor... | Ignore empty scss files instead of writing a newline?
<!-- BUGGY OR UGLY? Please use this template.
Tip! Don't write this stuff manually.
1. Go to https://prettier.io/playground
2. Paste your code and set options
3. Press the "Report issue" button in the lower right
-->
**Prettier 1.9.1**
[Playground lin... | Prettier makes sure that all files it formats ends with a single newline. Why would you want an exception for SCSS files with only a comment in it?
There is no comment in it. That was from the issue template in this repo. There is literally nothing in it. It's not that I want an exception for SCSS. I'm pointing out an ... | 2018-01-11 19:50:32+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/css_empty_file/jsfmt.spec.js->single-space.css - css-verify', '/testbed/tests/css_empty_file/jsfmt.spec.js->empty-file.css - css-verify'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/css_empty_file/__snapshots__/jsfmt.spec.js.snap tests/empty/empty-file.js tests/css_empty_file/single-space.css tests/css_empty_file/jsfmt.spec.js tests/empty/__snapshots__/jsfmt.spec.js.snap tests/empty/single-space.j... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/language-css/printer-postcss.js->program->function_declaration:genericPrint"] |
prettier/prettier | 3,515 | prettier__prettier-3515 | ['3513'] | d1c97b362219d62669145bb6bdd66a4be5423257 | diff --git a/.eslintrc.yml b/.eslintrc.yml
index acdb41232d14..16d29312800b 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -12,7 +12,6 @@ rules:
import/no-extraneous-dependencies:
- error
- devDependencies: ["tests*/**", "scripts/**"]
- no-console: off
no-else-return: error
no-inner-declarations: err... | diff --git a/tests_integration/__tests__/__snapshots__/debug-check.js.snap b/tests_integration/__tests__/__snapshots__/debug-check.js.snap
index 28cc9e705f08..fe8de3792793 100644
--- a/tests_integration/__tests__/__snapshots__/debug-check.js.snap
+++ b/tests_integration/__tests__/__snapshots__/debug-check.js.snap
@@ -6... | CLI’s `--write` option does not respect `--loglevel`
When Prettier runs with `--write` option and `--loglevel` option, Prettier always outputs filename and duration to STDOUT even if `--loglevel silent`. Combining these 2 options means ”I want override files, but don’t want (some) messages”. So Prettier should look `lo... | null | 2017-12-18 08:56:56+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests_integration/__tests__/loglevel.js->do not show warnings with --loglevel error', "/testbed/tests_integration/__tests__/loglevel.js->--write with --loglevel=silent doesn't log filenames (stderr)", "/testbed/tests_integration/__tests__/loglevel.js->--write with --loglevel=silent doesn't log filenames (sta... | ["/testbed/tests_integration/__tests__/loglevel.js->--write with --loglevel=silent doesn't log filenames (stdout)"] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests_integration/__tests__/__snapshots__/debug-check.js.snap tests_integration/__tests__/__snapshots__/loglevel.js.snap tests_integration/__tests__/loglevel.js tests_integration/__tests__/__snapshots__/early-exit.js.snap --... | Bug Fix | false | true | false | false | 7 | 0 | 7 | false | false | ["src/cli-logger.js->program->function_declaration:shouldLog", "src/cli-util.js->program->function_declaration:logResolvedConfigPathOrDie", "src/cli-logger.js->program->function_declaration:createLogger", "src/cli-util.js->program->function_declaration:formatFiles", "src/cli-util.js->program->function_declaration:listD... |
prettier/prettier | 3,436 | prettier__prettier-3436 | ['3403'] | 69f6ee78296d96e264c195ad273fed99da8911c5 | diff --git a/src/printer.js b/src/printer.js
index fe7b38c0b6f0..aa1bb8eff062 100644
--- a/src/printer.js
+++ b/src/printer.js
@@ -2286,6 +2286,7 @@ function genericPrintNoParens(path, options, print, args) {
// | C
const parent = path.getParentNode();
+
// If there's a leading comment, the paren... | diff --git a/tests/flow_intersection/__snapshots__/jsfmt.spec.js.snap b/tests/flow_intersection/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..afd19f195b31
--- /dev/null
+++ b/tests/flow_intersection/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,20 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP... | Closing parenthesis of multi-line intersection/union type
**Prettier 1.9.0**
[Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEMCeAHOACAyjAQ3mwF5tgAdKbG7AZwAsCAnOAEwAVmItn0lsBKGioBfbADJsACiq1sAH3LY2ASzphmqgLaqoQmAIogAYgHkzxgNzYAZhAgChabKLm0lwFes069BoxAAIQBBACVrbAAjFidhV3caT28NLV19WEDQgC1ImIAvOJdxKgBK... | null | 2017-12-07 15:23:00+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/flow_intersection/jsfmt.spec.js->intersection.js - babylon-verify'] | ['/testbed/tests/flow_intersection/jsfmt.spec.js->intersection.js - flow-verify'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/flow_intersection/intersection.js tests/typescript_union/union-parens.ts tests/typescript_union/__snapshots__/jsfmt.spec.js.snap tests/flow_intersection/__snapshots__/jsfmt.spec.js.snap tests/flow_intersection/jsfmt.sp... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/printer.js->program->function_declaration:genericPrintNoParens"] |
prettier/prettier | 666 | prettier__prettier-666 | ['617'] | 6632b95497423ed07ddaee8035abed99aaf5a777 | diff --git a/src/comments.js b/src/comments.js
index d97dae762510..94b093057690 100644
--- a/src/comments.js
+++ b/src/comments.js
@@ -157,9 +157,11 @@ function attach(comments, ast, text) {
addDanglingComment(ast, comment);
}
} else if (util.hasNewline(text, locEnd(comment))) {
- // There is ... | diff --git a/tests/conditional/__snapshots__/jsfmt.spec.js.snap b/tests/conditional/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..688b109568d5
--- /dev/null
+++ b/tests/conditional/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,71 @@
+exports[`test comments.js 1`] = `
+"var inspect = 4 === util... | Ternary comments are not stable
```js
var inspect = (4 === util.inspect.length ?
// node <= 0.8.x
function (v, colors) {
return util.inspect(v, void 0, void 0, colors);
} :
// node > 0.8.x
function (v, colors) {
return util.inspect(v, { colors: colors });
}
);
```
turns into
```js
... | Another case:
```js
const extractTextPluginOptions = shouldUseRelativeAssetPaths
// Making sure that the publicPath goes back to to build folder.
? { publicPath: Array(cssFilename.split('/').length).join('../') } :
{};
```
becomes
```js
const extractTextPluginOptions = shouldUseRelativeAssetPaths
... | 2017-02-11 19:41:34+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/conditional/jsfmt.spec.js->comments.js'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/conditional/jsfmt.spec.js tests/conditional/comments.js tests/conditional/__snapshots__/jsfmt.spec.js.snap --json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/comments.js->program->function_declaration:handleConditionalExpressionComments", "src/comments.js->program->function_declaration:attach"] |
prettier/prettier | 661 | prettier__prettier-661 | ['654'] | ec6ffbe063a19ae05f211bd26e7fcfcf33ba85bc | diff --git a/README.md b/README.md
index 39fd19e3f7ef..d408e978661f 100644
--- a/README.md
+++ b/README.md
@@ -148,6 +148,10 @@ prettier.format(source, {
// Controls the printing of spaces inside object literals
bracketSpacing: true,
+ // If true, puts the `>` of a multi-line jsx element at the end of
+ // th... | diff --git a/tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap b/tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..0d19c4878476
--- /dev/null
+++ b/tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,48 @@
+exports[`test last_line.js 1`] = `
+"<SomeHighlyConfig... | JSX opening element closing tag gets moved to a new line
If you have a line of JSX that is over printWidth, something like:
```js
const El = (<span width="1" height="2">x</span>)
```
For the sake of reproducing the issue assume the printWidth is set to 20 but this reproduces anytime the line needs to break for ... | This is intentional, but there have been [discussions](https://github.com/jlongster/prettier/issues/467#issuecomment-275230393) before about it. There's a PR where we decided to do it but I can't find it.
The second code block in my opinion is a log harder to read. The attributes line up perfectly with `x` and it's ... | 2017-02-11 04:41:51+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/jsx_last_line/jsfmt.spec.js->last_line.js'] | ['/testbed/tests/jsx_last_line/jsfmt.spec.js->last_line.js'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/jsx_last_line/last_line.js tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap tests/jsx_last_line/jsfmt.spec.js --json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["src/printer.js->program->function_declaration:genericPrintNoParens"] |
prettier/prettier | 459 | prettier__prettier-459 | ['325'] | 6e68f7495fba705c4d1e58e63efb5a41dea2df7d | diff --git a/src/printer.js b/src/printer.js
index 28990dde8b65..70bcb708f02c 100644
--- a/src/printer.js
+++ b/src/printer.js
@@ -51,9 +51,12 @@ function genericPrint(path, options, printPath) {
// responsible for printing node.decorators.
!util.getParentExportDeclaration(path)
) {
+ const separato... | diff --git a/tests/decorators/__snapshots__/jsfmt.spec.js.snap b/tests/decorators/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..7f0de6828c6c
--- /dev/null
+++ b/tests/decorators/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,64 @@
+exports[`test mobx.js 1`] = `
+"import {observable} from \"mobx... | Decorators for MobX put on separate lines
I understand that class decorators are usually put on their own line above the class, however the standard style with MobX annotations within a class is to put them on the same line as what they annotate. [Example](https://mobx.js.org/refguide/observable-decorator.html):
![s... | We could maybe do it if there is a only 1 and it's decorating a property. I'm not sure about getters or functions. I thought the standard style was to put them on top. | 2017-01-25 16:48:37+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | ['/testbed/tests/decorators/jsfmt.spec.js->redux.js'] | ['/testbed/tests/decorators/jsfmt.spec.js->multiple.js', '/testbed/tests/decorators/jsfmt.spec.js->mobx.js'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/decorators/redux.js tests/decorators/__snapshots__/jsfmt.spec.js.snap tests/decorators/multiple.js tests/decorators/mobx.js tests/decorators/jsfmt.spec.js --json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/printer.js->program->function_declaration:genericPrint"] |
prettier/prettier | 361 | prettier__prettier-361 | ['360'] | 237e6f44bc75269b96b31541c4a06ad293a591dd | diff --git a/src/printer.js b/src/printer.js
index 014bcfe52576..f64476940c9a 100644
--- a/src/printer.js
+++ b/src/printer.js
@@ -1841,6 +1841,12 @@ function printExportDeclaration(path, options, print) {
decl.specifiers[0].type === "ExportBatchSpecifier"
) {
parts.push("*");
+ } else i... | diff --git a/tests/export_extension/__snapshots__/jsfmt.spec.js.snap b/tests/export_extension/__snapshots__/jsfmt.spec.js.snap
new file mode 100644
index 000000000000..93c8b8099e5d
--- /dev/null
+++ b/tests/export_extension/__snapshots__/jsfmt.spec.js.snap
@@ -0,0 +1,8 @@
+exports[`test export.js 1`] = `
+"export * as ... | Export extension syntax not formatted correctly
Code using the [export extensions transform](https://babeljs.io/docs/plugins/transform-export-extensions/) is not formatted correctly.
When running prettier on one of my projects, the following:
```js
export reducer from './reducer'
```
was formatted as:
```... | Thanks, this looks like a bug.
Repro case:
https://jlongster.github.io/prettier/#%7B%22content%22%3A%22export%20reducer1%20from%20'.%2Freducer'%3B%5Cnexport%20%7B%20reducer2%20%7D%20from%20'.%2Freducer'%3B%22%2C%22options%22%3A%7B%22printWidth%22%3A80%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Afalse%2C%22trailingC... | 2017-01-21 03:13:35+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi
RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
# Clean u... | [] | ['/testbed/tests/export_extension/jsfmt.spec.js->export.js'] | [] | . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/export_extension/jsfmt.spec.js tests/export_extension/export.js tests/export_extension/__snapshots__/jsfmt.spec.js.snap --json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/printer.js->program->function_declaration:printExportDeclaration"] |
serverless/serverless | 8,159 | serverless__serverless-8159 | ['7008'] | 56aa5aa15abed64db6758aecd8c27719928b5a14 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 77c99fa11b9..6680fc31cca 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -994,6 +994,22 @@ functions:
You can then access the query string `https://example.com/dev/... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index acfde4b271a..c1ab20a1c2e 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Allow for the removal of default request mapping templates
Currently [default request mapping templates are created ](https://github.com/serverless/serverless/blob/v1.58.0/lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js#L189) both for application/json and application/x-www-form-urlencoded. T... | Indeed there seem no way to override that.
Some kind of fix would be to allow `null` for configuration properties placed in `resources.Resources` and translate them to deletions.
We welcome PR on that
My personal opinion is that application/x-www-form-urlencoded is not a particularly useful default anyway. It se... | 2020-08-31 20:08:28+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should add method responses for different status codes', '#compileMethods() should set api key as not required if private property is not specified', '#compileMethods() should include operation id as OperationNam... | ['#compileMethods() when dealing with request configuration should delete the default "application/x-www-form-urlencoded" template if it\'s overriden with null'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js->program->method_definition:getIntegrationRequestTemplates"] |
serverless/serverless | 7,617 | serverless__serverless-7617 | ['7565'] | 2e56dea5652540cf5d82c9d35a999c8c921fa020 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index 27922e7c8a7..6fb8754769b 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -22,6 +22,7 @@ layout: Doc
- [Enabling CORS](#enabling-cors)
- [HTTP Endpoints wit... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index d455fadb2b8..c5cf31d0c54 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Ability to set OperationName of an AWS API Gateway Method
# Feature Proposal
It would be nice to be able to set OperationName field of an AWS API Gateway Method as shown in the description below.
## Description
<!-- Please use https://forum.serverless.com, StackOverflow or other forums for Q&A -->
<!-- Please... | @ThunderLust102 The field is for assigning user-friendly name to an AWS API gateway resource method.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-method.html#cfn-apigateway-method-operationname
@jcortega thanks for proposal. Makes sense. I would name it `operationId` to mat... | 2020-04-23 16:55:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should add method responses for different status codes', '#compileMethods() should set api key as not required if private property is not specified', '#compileMethods() when dealing with request configuration sho... | ['#compileMethods() should include operation id as OperationName when it is set'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.js->program->method_definition:compileMethods"] |
serverless/serverless | 7,587 | serverless__serverless-7587 | ['7586'] | 7479a9ae82b44fb06de3ab84094b18e8f72affc4 | diff --git a/lib/plugins/aws/info/getResourceCount.js b/lib/plugins/aws/info/getResourceCount.js
index abe00ac4c15..6dda2c8a7cf 100644
--- a/lib/plugins/aws/info/getResourceCount.js
+++ b/lib/plugins/aws/info/getResourceCount.js
@@ -4,16 +4,19 @@ const BbPromise = require('bluebird');
const _ = require('lodash');
m... | diff --git a/lib/plugins/aws/info/getResourceCount.test.js b/lib/plugins/aws/info/getResourceCount.test.js
index 2dfa0baba44..89ace1fba7e 100644
--- a/lib/plugins/aws/info/getResourceCount.test.js
+++ b/lib/plugins/aws/info/getResourceCount.test.js
@@ -131,6 +131,7 @@ describe('#getResourceCount()', () => {
expe... | Resources count displayed by sls info shows max of 100.
# Bug Report
The resource count # show by sls info will max out at 100.
The Cloudformation listStackResources API call is paginated and
https://github.com/serverless/serverless/blob/7479a9ae82b44fb06de3ab84094b18e8f72affc4/lib/plugins/aws/info/getResourc... | null | 2020-04-17 01:36:15+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | [] | ['#getResourceCount() attach resourceCount to this.gatheredData after listStackResources call'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/info/getResourceCount.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/info/getResourceCount.js->program->method_definition:getResourceCount"] |
serverless/serverless | 7,374 | serverless__serverless-7374 | ['7369'] | 8518000d4fbf3a6cf0a6e2f81bd6421e017a1b5f | diff --git a/lib/utils/fs/fileExistsSync.js b/lib/utils/fs/fileExistsSync.js
index 147300e7b51..e11066ef26b 100644
--- a/lib/utils/fs/fileExistsSync.js
+++ b/lib/utils/fs/fileExistsSync.js
@@ -4,7 +4,7 @@ const fse = require('./fse');
function fileExistsSync(filePath) {
try {
- const stats = fse.lstatSync(file... | diff --git a/lib/utils/fs/fileExistsSync.test.js b/lib/utils/fs/fileExistsSync.test.js
index e6e3b6e85df..ca075cc322e 100644
--- a/lib/utils/fs/fileExistsSync.test.js
+++ b/lib/utils/fs/fileExistsSync.test.js
@@ -2,6 +2,7 @@
const path = require('path');
const expect = require('chai').expect;
+const fse = require('... | serverlessrc keeps changing
# Bug Report
Seems like every time I do anything with serverless, it changes my `~/.serverlessrc`
## Description
I have all my rc files in source control, and I want this one in source control as well because I want to set `trackingDisabled`. Annoyingly, every time I do anything wit... | @c0d3d thanks for reporting. That's indeed weird.
I do not observe such behavior on my side. Does it happen after you toggle some settings, or every time even if you do not touch the file?
If so, can you describe the flow (which commands force file to be recreated), and say which version of `serverless` exactly y... | 2020-02-21 16:54:16+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ["#fileExistsSync() When reading a symlink to a file should detect if the file doesn't exist", "#fileExistsSync() When reading a symlink to a file should detect if the file doesn't exist w/ symlink to dir", '#fileExistsSync() When reading a file should detect if a file exists', "#fileExistsSync() When reading a symlink... | ['#fileExistsSync() When reading a symlink to a file should detect if the file exists'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/utils/fs/fileExistsSync.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/utils/fs/fileExistsSync.js->program->function_declaration:fileExistsSync"] |
serverless/serverless | 7,277 | serverless__serverless-7277 | ['7276'] | c09f71897a67fe8ec98d460075f0f02b397f8ee5 | diff --git a/docs/providers/aws/events/sns.md b/docs/providers/aws/events/sns.md
index 556153b7791..6bb43ba99ec 100644
--- a/docs/providers/aws/events/sns.md
+++ b/docs/providers/aws/events/sns.md
@@ -149,7 +149,7 @@ functions:
## Setting a redrive policy
-This event definition creates an SNS topic that sends mess... | diff --git a/lib/plugins/aws/package/compile/events/sns/index.test.js b/lib/plugins/aws/package/compile/events/sns/index.test.js
index b2ddabc7fc7..e17a6045c55 100644
--- a/lib/plugins/aws/package/compile/events/sns/index.test.js
+++ b/lib/plugins/aws/package/compile/events/sns/index.test.js
@@ -597,7 +597,7 @@ describ... | Redrive Policy not properly referencing queue
## Description
Recentely, I have been able to test serverless 1.62 which includes the option to use redriverPolicy for sns events. However, when I submited a PR for that feature, I overlooked the param specificacion format on the queuePolicy that is created. To be mo... | null | 2020-01-31 13:22:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileSNSEvents #compileSNSEvents() should throw an error when arn object and no topicName are given as object properties', 'AwsCompileSNSEvents #compileSNSEvents() should throw an error if SNS event type is not a string or an object', 'AwsCompileSNSEvents #compileSNSEvents() should throw an error when invalid im... | ['AwsCompileSNSEvents #compileSNSEvents() should link topic to corresponding dlq when redrivePolicy is defined with resource ref', 'AwsCompileSNSEvents #compileSNSEvents() should link topic to corresponding dlq when redrivePolicy is defined by arn string'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sns/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/lib/naming.js->program->method_definition:getTopicDLQPolicyLogicalId", "lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents"] |
serverless/serverless | 7,102 | serverless__serverless-7102 | ['7059'] | 0618e0d899e80e56d7f22e9bfbcc6d512848db05 | diff --git a/commitlint.config.js b/commitlint.config.js
index 472acb4709b..9686e039632 100644
--- a/commitlint.config.js
+++ b/commitlint.config.js
@@ -8,7 +8,11 @@ module.exports = {
'footer-max-line-length': [2, 'always', 72],
'header-max-length': [2, 'always', 72],
'scope-case': [2, 'always', 'start-... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index 16950dcb33b..81e733f73cb 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Provisioned Concurrency Does Not Work As Described
# Bug Report
Provisioned Concurrency was recently added in Serverless v1.59 and described in detail in this blog post: https://serverless.com/blog/aws-lambda-provisioned-concurrency/
The blog post makes the claim that enabling provisioned concurrency is as easy a... | @AndrewBarba great thanks for reporting that issue
We will shortly (hopefully tomorrow) publish an update that fix the behavior in a framework (to make blog post accurate).
Thank you really appreciate it
@medikoo Would the fix you guys are making need to be applied/supported on all event types? Example, the API for ... | 2019-12-17 15:36:02+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', '#compileMethods() should set api key as not required if private property is... | ['AwsCompileFunctions #compileFunctions() should set function declared provisioned concurrency limit', '#awsCompilePermissions() should setup permissions for an alias in case of provisioned function', '#awsCompilePermissions() should create limited permission resource scope to REST API with restApiId provided', '#awsCo... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.test.js lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Bug Fix | false | true | false | false | 10 | 0 | 10 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js->program->method_definition:compilePermissions", "lib/plugins/aws/lib/naming.js->program->method_definition:getLambdaProvisionedConcurrencyAliasLogicalId", "lib/plugins/aws/lib/naming.js->program->method_definition:getCodeDeployApplicationLogicalId"... |
serverless/serverless | 6,987 | serverless__serverless-6987 | ['6949'] | 05eec837ec20ec0d321b3592e5440d126de9c218 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index aa43826ed8f..a78d3331297 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -1494,6 +1494,22 @@ provider:
In your Lambda function you need to ensure that the correct... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index a4481719073..16950dcb33b 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Request with binary media returns 500
# Bug Report
## Description
When using `binaryMediaTypes` in combination with lambda non-proxy integration, then a 500 error is always returned. When using the lambda proxy integration (as given here: #6063 ) everything works fine.
The only workaround I found is to manually ... | It was not related to permissions after all. Instead, it was caused by the missing [contentHandling](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apitgateway-method-integration.html#cfn-apigateway-method-integration-contenthandling) property.
Workaround:
```
resources:
Resource... | 2019-11-20 21:18:42+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should add method responses for different status codes', '#compileMethods() should set api key as not required if private property is not specified', '#compileMethods() when dealing with request configuration sho... | ['#compileMethods() should use defined content-handling behavior', '#compileMethods() when dealing with request configuration should use defined content-handling behavior', '#compileMethods() should add integration responses for different status codes'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js->program->method_definition:getIntegrationResponses", "lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js->program->method_definition:getMethodIntegration"] |
serverless/serverless | 6,869 | serverless__serverless-6869 | ['6782'] | 18852ec34bbe1bdd9457c563e21e53cab3dc2fcd | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 6076cbeda8d..08078cf12ba 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -46,6 +46,9 @@ You can define your own variable syntax (regex) if it conflicts with CloudFormat
- [... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 5162f0ee4b5..6bf869b3ac6 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -2378,6 +2378,70 @@ module.exports = {
});
});
+ describe('#getValueStrToBool()', () => {
+ const errMessage = 'Unexpe... | The always restApi logs enable when using an SSM parameter in the configuration.
# Bug Report
## Description
<!-- Please use https://forum.serverless.com, StackOverflow or other forums for Q&A -->
<!-- Please answer ALL the question below. Otherwise we probably have to close the issue due to missing information ... | There are lots of non-string configuration (boolean or numeric) in severless framework, and unfortunately most of them does not accept string value from `$opt` or `$ssm`...
It is recommended to [use `$file` variable and use booleans/numbers in those files](https://github.com/serverless/serverless/pull/6561#issuecomm... | 2019-10-21 23:23:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached ... | ['Variables #getValueStrToBool() regex for empty input', 'Variables #getValueStrToBool() false (string) should return false (boolean)', 'Variables #getValueStrToBool() 0 (string) should return false (boolean)', 'Variables #getValueStrToBool() regex for "true" input', 'Variables #getValueStrToBool() regex for "0" input'... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | false | false | true | 2 | 1 | 3 | false | false | ["lib/classes/Variables.js->program->class_declaration:Variables", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueStrToBool", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:constructor"] |
serverless/serverless | 6,842 | serverless__serverless-6842 | ['6841'] | 6e5572350549e1277eebb5952dc01b45a96a8957 | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.js b/lib/plugins/aws/package/lib/mergeIamTemplates.js
index 2d97671ad03..c302e496f42 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.js
@@ -192,12 +192,14 @@ module.exports = {
violationsF... | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
index b7da9693183..7e7d898b585 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
@@ -513,10 +513,28 @@ describe('#mergeI... | Support NotAction and NotResource
# Feature Proposal
## Description
<!-- Please use https://forum.serverless.com, StackOverflow or other forums for Q&A -->
<!-- Please answer ALL the question below. Otherwise we probably have to close the issue due to missing information -->
Currently Serverless refuses to bu... | null | 2019-10-15 22:59:22+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should ensure IAM policies when service contains only canonically named functions', '#mergeIamTemplates() should add managed policy arns', '#mergeIamTemplates() should add default role if one of the function... | ['#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Action field', '#mergeIamTemplates() should throw error if a custom IAM policy statement does not have a Resource field', '#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#m... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:validateStatements"] |
serverless/serverless | 6,827 | serverless__serverless-6827 | ['6266'] | aba4e09c7be7e1c89b14728428f0f1a3bf9ccbbb | diff --git a/docs/providers/aws/events/cloudwatch-log.md b/docs/providers/aws/events/cloudwatch-log.md
index d5021973b7d..e6e385cc599 100644
--- a/docs/providers/aws/events/cloudwatch-log.md
+++ b/docs/providers/aws/events/cloudwatch-log.md
@@ -26,6 +26,8 @@ functions:
- cloudwatchLog: '/aws/lambda/hello'
```
... | diff --git a/lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js b/lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js
index 9161f09dcc1..7803c51814b 100644
--- a/lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js
+++ b/lib/plugins/aws/package/compile/events/cloudWatchLog/i... | Using 2 or more "CloudWatchLog event handlers" for the same lambda fails to create correct permissions
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check out and follow our ... | As a workaround I found serverless@1.35.1 to be the latest version which does not suffer from this bug. | 2019-10-13 18:15:52+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should respect "filter" variable', 'AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should set an empty string for FilterPattern statement when "filter" variable is not given', 'AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should r... | ['AwsCompileCloudWatchLogEvents #compileCloudWatchLogEvents() should create a longest-common suffix of logGroup to minimize scope'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/cloudWatchLog/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/cloudWatchLog/index.js->program->class_declaration:AwsCompileCloudWatchLogEvents->method_definition:longestCommonSuffix"] |
serverless/serverless | 6,534 | serverless__serverless-6534 | ['6262'] | d4c8bc1450d31275596b26bb7464a6f1b28392af | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.js b/lib/plugins/aws/package/lib/mergeIamTemplates.js
index 945312b6987..e96534ec1eb 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.js
@@ -90,23 +90,13 @@ module.exports = {
.Resources[th... | diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
index 09447f64157..b7da9693183 100644
--- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js
@@ -127,7 +127,7 @@ describe('#mergeIam... | Wider `logs:CreateLogStream`/`logs:PutLogEvents` permissions in policy for Lambda functions with manual names (v1.45.1)
<!--
1. If you have a question and not a bug report please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This bug may have already been documented
3. Check ou... | This was done to avoid a hard AWS limit of the size of a single role.
We can make the least-privileged permission as an option if some users find the wider troublesome.
Another option is to have each function to have its own role, but the statements added via the `iamRoleStatements` would need to be duplicated o... | 2019-08-13 12:33:01+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should ensure IAM policies when service contains only canonically named functions', '#mergeIamTemplates(... | ['#mergeIamTemplates() should ensure IAM policies for custom and canonically named functions', '#mergeIamTemplates() should ensure IAM policies when service contains only custom named functions'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:merge"] |
serverless/serverless | 6,447 | serverless__serverless-6447 | ['6436'] | 866cc82cb070a4c928ea7521103ca62263b52d65 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index bea7daeeed6..36968bb06da 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,13 @@
+# 1.48.4 (2019-07-25)
+
+- [Add note for supported version of existing bucket feature](https://github.com/serverless/serverless/pull/6435)
+- [Support in interactive flow for SFE provid... | diff --git a/lib/plugins/aws/lib/validate.test.js b/lib/plugins/aws/lib/validate.test.js
index 64dee4c92db..0a0a5e2aeea 100644
--- a/lib/plugins/aws/lib/validate.test.js
+++ b/lib/plugins/aws/lib/validate.test.js
@@ -33,6 +33,7 @@ describe('#validate', () => {
awsPlugin.serverless.setProvider('aws', provider);
... | `sls package` is demanding a default profile since the latest version?
# This is a Bug Report
Since the last update `sls package` requires a default profile to be set in the aws config ( or `--aws-profile` to be given ).
Not sure why the decision was made to require the aws profile even during packaging, or if th... | I have similar issue, local invocation was working fine in 1.48.2 but breaks in 1.48.3 because of profile:
We install serverless globally
```
$ yarn global add serverless
yarn global v1.17.3
[1/4] Resolving packages...
warning serverless > json-refs > path-loader > superagent@3.8.3: Please note that v5.0.1+ of su... | 2019-07-25 12:47:43+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#validate #validate() should succeed if inside service (servicePath defined)', '#validate #validate() should use the service.provider region if present', '#validate #validate() should throw error if not inside service (servicePath not defined)', '#validate #validate() should default to "dev" if stage is not provided'... | ['#validate #validate() should not check the metadata service if not using a command that needs creds'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/lib/validate.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/validate.js->program->method_definition:validate"] |
serverless/serverless | 6,366 | serverless__serverless-6366 | ['3676'] | dfe6e071612bcb80b14a87f862c33f1620a62d0c | diff --git a/docs/providers/aws/events/sns.md b/docs/providers/aws/events/sns.md
index 738f5e9b4b8..fdc442a166b 100644
--- a/docs/providers/aws/events/sns.md
+++ b/docs/providers/aws/events/sns.md
@@ -62,6 +62,7 @@ functions:
```
Or with intrinsic CloudFormation function like `Fn::Join` or `Fn::GetAtt`.
+**Note:** ... | diff --git a/lib/plugins/aws/package/compile/events/sns/index.test.js b/lib/plugins/aws/package/compile/events/sns/index.test.js
index c312459c48c..18b72af715e 100644
--- a/lib/plugins/aws/package/compile/events/sns/index.test.js
+++ b/lib/plugins/aws/package/compile/events/sns/index.test.js
@@ -11,9 +11,12 @@ describe... | Cross region SNS trigger
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
4. Fil... | Thanks for opening @matthisk 👍
🤔 right now Serverless assumes that everything will be deployed into one region. @eahefnawy do you have any idea if there's a possible solution / workaround available for this?
I have the same problem. I need to subscribe to an us-east-1 ARN for the AWS marketplace but my whole inf... | 2019-07-12 01:44:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileSNSEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileSNSEvents #compileSNSEvents() should throw an error when arn object and no topicName are given as object properties', 'AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when only arn is given a... | ['AwsCompileSNSEvents #compileSNSEvents() should create a cross region subscription when SNS topic arn in a different region than provider'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sns/index.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:constructor", "lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents"] |
serverless/serverless | 6,261 | serverless__serverless-6261 | ['6017', '6017'] | 61f31b22e2062d2fd622779c6ed2364d79da3058 | diff --git a/docs/providers/aws/guide/plugins.md b/docs/providers/aws/guide/plugins.md
index fc52aafb206..c8414137f4f 100644
--- a/docs/providers/aws/guide/plugins.md
+++ b/docs/providers/aws/guide/plugins.md
@@ -63,9 +63,7 @@ custom:
## Service local plugin
-If you are working on a plugin or have a plugin that is... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index e00c4fd2b6f..bd7a0e56cc0 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -803,11 +803,13 @@ describe('PluginManager', () => {
describe('#loadServicePlugins()', () => {
beforeEach(fu... | Load plugin from path
<!--
1. If you have a question and not a feature request please ask first at http://forum.serverless.com
2. Please check if an issue already exists. This feature may have already been requested
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBU... | 2019-06-17 10:05:07+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['PluginManager #run() should throw an error when the given command is a container', 'PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #validateOptions() should throw an error if a customValidation is not met', 'PluginManager #run... | ['PluginManager #loadServicePlugins() should load the service plugins'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadPlugins"] | |
serverless/serverless | 5,860 | serverless__serverless-5860 | ['3495'] | a4b87a1c50599151a28c0286ede775ecbe1673ae | diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md
index 9a3ae2266e3..ecdfe09ed48 100644
--- a/docs/providers/aws/guide/functions.md
+++ b/docs/providers/aws/guide/functions.md
@@ -28,6 +28,8 @@ provider:
memorySize: 512 # optional, in MB, default is 1024
timeout: 10 # opti... | diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js
index 389204db18d..722285ba24e 100644
--- a/lib/plugins/aws/package/compile/functions/index.test.js
+++ b/lib/plugins/aws/package/compile/functions/index.test.js
@@ -1286,6 +1286,267 @@ describ... | Add support for AWS x-ray on AWS Lambda
AWS has added support for `X-ray` on `Lambda`: https://aws.amazon.com/blogs/aws/aws-x-ray-update-general-availability-including-lambda-integration/
would be a nice feature the enable that support from within the `serverless.yml` file by allowing to set the required `enable act... | Not sure if it can be set via CloudFormation. But using the api/cli the option is called `tracingConfig` and has two options `Active` or `PassThrough`
http://docs.aws.amazon.com/lambda/latest/dg/API_TracingConfig.html
Unfortunately,CloudFormation not support X-ray on Lambda for now yet...
http://docs.aws.amazon.com/A... | 2019-02-21 14:00:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileFunctions #compileFunctions() when using onError config should reject if config is provided as a number', 'AwsCompileFunctions #compileFunctions() should overwrite a provider level environment config when function config is given', 'AwsCompileFunctions #compileFunctions() should add an ARN function role', '... | ['AwsCompileFunctions #compileFunctions() when using tracing config should prefer a function tracing config over a provider config', 'AwsCompileFunctions #compileFunctions() when using tracing config should use a the provider wide tracing config if provided', 'AwsCompileFunctions #compileFunctions() when using tracing ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"] |
serverless/serverless | 5,842 | serverless__serverless-5842 | ['5838'] | 838ab11c16cba1689eff32448cb40bb81582af20 | diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md
index 677e6c68144..71a846240b9 100644
--- a/docs/providers/aws/guide/variables.md
+++ b/docs/providers/aws/guide/variables.md
@@ -274,6 +274,37 @@ custom:
In this example, the serverless variable will contain the decrypted val... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index f49356cc1b5..e0df9382ef1 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -1956,7 +1956,51 @@ module.exports = {
})
.finally(() => ssmStub.restore());
});
-
+ describe('Referencing... | Secrets manager JSON not accessible
The documentation does not show how to access secrets from aws secrets manager stored in JSON. Is there an ETA to add this ability? If you have many secrets its very cost prohibitive to have 1 secret to 1 plain text value.
| @claygorman
[${ssm} is a syntax to refer AWS Systems Manager Parameter Store](https://serverless.com/framework/docs/providers/aws/guide/variables/#reference-variables-using-the-ssm-parameter-store).
Parameter Store supports [String, StringList and SecureString](https://docs.aws.amazon.com/ja_jp/systems-manager/lates... | 2019-02-17 08:18:30+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Va... | ['Variables #getValueFromSsm() Referencing to AWS SecretsManager should parse value as json if returned value is json-like'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromSsm"] |
serverless/serverless | 5,775 | serverless__serverless-5775 | ['5398'] | 8c53de83bf62a4e1f66821e0321abb996880b5bd | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index b5f6f406f37..aa52ac7a246 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -294,7 +294,7 @@ class Variables {
this.variableSyntax,
(context, contents) => contents.trim()
);
- if (!cleaned.match(/".*"/)) {
... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index a90b7c2bf56..97f8a527b13 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -786,7 +786,7 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shoul... | Fallback value for unset variable is removing spaces
# This is a Bug Report
## Description
For bug reports:
* What went wrong?
Given the following variable fallback:
```yaml
events:
- schedule: ${env:SCHEDULE, 'rate(2 hours)'}
```
If env `SCHEDULE` is not set I got this error when I run `sls depl... | The culprit:
https://github.com/serverless/serverless/blob/33b7784bad10347767d447dd1c650e0d90931d49/lib/classes/Variables.js#L267-L271
If I just remove `.replace(/\s/g, '')` at line 71 and run tests nothing is broken but I'm afraid that this could have some side effect that tests are not covering?
Can I open a P... | 2019-02-02 13:51:45+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Variables #prepopulateService dependent service rejections should reject CloudFormation variables in profile values', 'Variables #prepopulateService basic population tests should populate variables in profile values', 'Variables fallback should fallback if ${opt} syntax fail to populate but fallback is provided', 'Va... | ['Variables #populateObject() significant variable usage corner cases should preserve whitespace in single-quote literal fallback'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:cleanVariable"] |
serverless/serverless | 5,640 | serverless__serverless-5640 | ['4959'] | 660804d4a6e471825e291a26413bbbf2cb365dc9 | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index f508aa038b8..7bd1a2ed99a 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -21,7 +21,7 @@ class Service {
this.provider = {
stage: 'dev',
region: 'us-east-1',
- variableSyntax: '\\${([ ~:a-zA-Z0-9._@\'",\\-\\/\\... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 877e266ffd8..4358494e138 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -31,7 +31,7 @@ describe('Service', () => {
expect(serviceInstance.provider).to.deep.equal({
stage: 'dev',
region: '... | Asterisk in default variable value leads to value interpreted as string and not interpolated
```allowedOrigin: ${opt:allowedOrigin, 'beta.blabla.net'}```
works fine
```allowedOrigin: ${opt:allowedOrigin, '*.blabla.net'}```
doesnt work
in second case allowedOrigin will be interpreted as a string e.g. its value w... | It looks like the regex's used to match on the `${opt: this.that, 'def'}` pattern are not allowing the character `*`.
Are there any considerations in allowing/not allowing `*` in variable syntax?
I can take this issue if no one else has begun work. | 2018-12-31 15:53:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Service #validate() stage name validation should not throw an error after variable population if http event is present and\n the populated stage contains only alphanumeric, underscore and hyphen', 'Service #update() should update service instance data', 'Variables #prepopulateService basic population tests... | ['Service #constructor() should construct with defaults'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/print/print.test.js lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/print/print.js->program->class_declaration:Print->method_definition:adorn", "lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor"] |
serverless/serverless | 5,571 | serverless__serverless-5571 | ['5558'] | fa4ef1159a36355799bba0ace606d3625dd1c24e | diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js
index 6411f043f70..084f275a5bb 100644
--- a/lib/classes/Variables.js
+++ b/lib/classes/Variables.js
@@ -268,7 +268,7 @@ class Variables {
return match.replace(
this.variableSyntax,
(context, contents) => contents.trim()
- ).replace(/... | diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js
index 19c68a8e324..2c65f39a4db 100644
--- a/lib/classes/Variables.test.js
+++ b/lib/classes/Variables.test.js
@@ -634,6 +634,16 @@ describe('Variables', () => {
return serverless.variables.populateObject(service.custom)
.shou... | schedule from file with default value removes space
# This is a Bug Report
## Description
* What went wrong?
I ran `serverless deploy --stage custom`. The serverless.yml refers to files like `serverless.prod.config.json` depending on the stage name.
I have a variable schedule, it's running faster on acceptance ... | Confirmed in [dschep-bug-repos/sls-5558](https://github.com/dschep-bug-repos/sls-5558). Seems spaces are stripped from any literal defaults. That's not good 😢
See the workaround branch of that repo for a fix. The change for your service would be:
```yaml
custom:
defaultAppleReciptsToUpdateSchedule: rate(3 hours)... | 2018-12-06 12:38:58+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the... | ['Variables #populateObject() significant variable usage corner cases should preserve whitespace in literal fallback'] | ['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:cleanVariable"] |
serverless/serverless | 4,192 | serverless__serverless-4192 | ['3204'] | a43ffcb4de11f56637b3e85683d78ea5d53d0c4d | diff --git a/docs/providers/aws/cli-reference/deploy.md b/docs/providers/aws/cli-reference/deploy.md
index bf05e94d060..e00d262cadc 100644
--- a/docs/providers/aws/cli-reference/deploy.md
+++ b/docs/providers/aws/cli-reference/deploy.md
@@ -23,6 +23,7 @@ serverless deploy
- `--region` or `-r` The region in that stage ... | diff --git a/lib/classes/PluginManager.test.js b/lib/classes/PluginManager.test.js
index bab03ad6698..b784c58ddf6 100644
--- a/lib/classes/PluginManager.test.js
+++ b/lib/classes/PluginManager.test.js
@@ -1,6 +1,6 @@
'use strict';
-const expect = require('chai').expect;
+const chai = require('chai');
let PluginMana... | UX Improvement: Make deploy function easier
Can't tell you how many times I type `sls deploy -f functionName` and forget the word function... and then have to wait for the whole stack to update.
Can we alias `sls deploy -f functionName` to `sls deploy function -f functionName` as a quick UX win?
So if a user typ... | I always mistake the same too..
+1
This could be an interesting UX win. I will say I've retrained my muscle memory around some bash aliases... `alias sdf="serverless deploy --function $1"` then I can just `sdf functionName`. Saved me some time here and there.
Nice idea! 👍
IMHO nested commands (more than one level... | 2017-09-01 10:26:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['PluginManager #spawn() when invoking an entrypoint should succeed', 'PluginManager #run() when using a promise based hook function when running a simple command should run the simple command', 'PluginManager #run() should throw an error when the given command is an entrypoint', 'PluginManager #spawn() should spawn en... | ['PluginManager #spawn() when invoking a command should terminate the hook chain if requested'] | ['Deploy "before:deploy:deploy" hook "before each" hook for "should run the validation"', 'PluginManager #updateAutocompleteCacheFile() "after each" hook for "should update autocomplete cache file"', 'PluginManager Plugin / CLI integration "before each" hook for "should expose a working integration between the CLI and ... | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/PluginManager.test.js lib/plugins/aws/info/index.test.js lib/plugins/deploy/deploy.test.js --reporter json | Feature | false | false | false | true | 4 | 1 | 6 | false | false | ["lib/plugins/deploy/deploy.js->program->class_declaration:Deploy->method_definition:constructor->pair:[]", "lib/classes/PluginManager.js->program->class_declaration:TerminateHookChain->method_definition:constructor", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:spawn", "li... |
serverless/serverless | 3,804 | serverless__serverless-3804 | ['2888'] | 6a9e99656d3288fc797cbf9dcf7003b7b23e4413 | diff --git a/docs/providers/aws/guide/deploying.md b/docs/providers/aws/guide/deploying.md
index 2550bd36282..e412ccc1ad8 100644
--- a/docs/providers/aws/guide/deploying.md
+++ b/docs/providers/aws/guide/deploying.md
@@ -61,6 +61,9 @@ The Serverless Framework translates all syntax in `serverless.yml` to a single A
s... | diff --git a/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js b/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js
index dedac9f6c1e..9f6d0180990 100644
--- a/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js
+++ b/lib/plugins/aws/deploy/lib/uploadArtifacts.test.js
@@ -59,6 +59,37 @@ describe('uploadArtifacts', () =... | Deploy fails when using deploymentBucket / SSE support
I'm trying to use `serverless deploy` with a pre-existing bucket for the deployment package. When I add the `deploymentBucket` value in the provider I get the following error: **self signed certificate in certificate chain**
If I remove `deploymentBucket` the ... | I think this might be caused by the requirement on our buckets for server side encryption. I'll try and test later with a bucket without this policy.
```
{
"Sid": "DenyNoEncryption",
"Effect": "Deny",
"Principal": {
"AWS": "*"
},
... | 2017-06-16 07:21:01+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsProvider #getCredentials() should get credentials when profile is provied via --aws-profile option', 'AwsProvider #getCredentials() should not set credentials if profile is not set', 'AwsProvider #constructor() when checking for the deploymentBucket config should do nothing if the deploymentBucket config is not us... | ['AwsProvider #constructor() when checking for the deploymentBucket config should save the object and use the name for the deploymentBucket if provided', 'AwsProvider #constructor() when checking for the deploymentBucket config should save the object and nullify the name if it is not provided', 'AwsProvider #getCredent... | ['uploadArtifacts #uploadZipFile() should upload to a bucket with server side encryption bucket policy', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'uploadArtifacts #uploadArtifacts() should run promise chain in order', 'uploadArtifacts #uploadFunction... | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/uploadArtifacts.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json | Feature | false | false | false | true | 6 | 1 | 7 | false | false | ["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:constructor", "lib/plugins/aws/deploy/lib/uploadArtifacts.js->program->function_declaration:setServersideEncryptionOptions", "lib/classes/Service.js->program->class_declaration:Service", "lib/classes/Service.js->program... |
serverless/serverless | 3,799 | serverless__serverless-3799 | ['3773', '3773'] | fa6b32ce5e1258b656c6729ad024cd85d4a006d0 | diff --git a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js b/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js
index d94063701c0..76f0a4c054c 100644
--- a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js
+++ b/lib/plugins/aws/package/compile/events/cognitoUserPool/index.js... | diff --git a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js b/lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js
index 6ec9a6c2805..a67e80bb712 100644
--- a/lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js
+++ b/lib/plugins/aws/package/compile/events/cognitoUs... | Support for Cognito User Pool Triggers isn't working.
# This is a Bug Report
## Description
Support for Cognito User Pool Triggers isn't working.
For bug reports:
* What went wrong?
Cannot link lamda to cognito user pool triggers
* What did you expect should have happened?
Cognito user pool triggers should hav... | Thanks for opening @keshavkaul 👍
The `<pool id>` you're describing here should be the resource logical id for your Cognito user pool. Serverless will create this one for you.
Do you try to re-use an existing one here? What have you put in there (what's your `<pool id>`)?
Additionally could you maybe share th... | 2017-06-14 23:28:53+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileCognitoUserPoolEvents #compileCognitoUserPoolEvents() should throw an error if the "trigger" property is invalid', 'AwsCompileCognitoUserPoolEvents #compileCognitoUserPoolEvents() should not create resources when CUP events are not given', 'AwsCompileCognitoUserPoolEvents #compileCognitoUserPoolEvents() sho... | ['AwsCompileCognitoUserPoolEvents #mergeWithCustomResources() should merge custom resources found in Resources', 'AwsCompileCognitoUserPoolEvents #mergeWithCustomResources() should merge `DependsOn` clauses correctly if being overridden from Resources', 'AwsCompileCognitoUserPoolEvents #mergeWithCustomResources() does ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/cognitoUserPool/index.test.js --reporter json | Bug Fix | false | false | false | true | 5 | 1 | 6 | false | false | ["lib/plugins/aws/package/compile/events/cognitoUserPool/index.js->program->class_declaration:AwsCompileCognitoUserPoolEvents", "lib/plugins/aws/package/compile/events/cognitoUserPool/index.js->program->class_declaration:AwsCompileCognitoUserPoolEvents->method_definition:constructor", "lib/plugins/aws/package/compile/e... |
serverless/serverless | 3,534 | serverless__serverless-3534 | ['3362'] | c868e63d76fc5e2d74ad1a77364ba1025a5c5837 | diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md
index a903d6d2ec5..255f5466f99 100644
--- a/docs/providers/aws/events/apigateway.md
+++ b/docs/providers/aws/events/apigateway.md
@@ -14,11 +14,16 @@ layout: Doc
To create HTTP endpoints as Event sources for your AWS Lambd... | diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
index 5123e7813ed..8116320acad 100644
--- a/lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/package/compil... | Support HTTP Proxy Api Gateway Integration Type
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/... | +
Is there any update on this?
@Alex-Mann thanks for your comment.
We're currently waiting for some more feedback on this issue. Best is to always leave a 👍 as a reaction so that we can see which issues are highly appreciated. | 2017-04-27 23:42:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#validate() should throw an error when an invalid integration type was provided', '#validate() should validate the http events "method" property', '#compileMethods() when dealing with request configuration should be possible to overwrite default request templates', '#compileMethods() should add fall back headers and ... | ['#validate() should support LAMBDA integration', '#validate() should support HTTP_PROXY integration', '#validate() should accept AWS_IAM as authorizer', '#validate() should support MOCK integration', '#compileMethods() should support HTTP integration type with custom request options', '#validate() should support HTTP ... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/method/index.test.js --reporter json | Feature | false | true | false | false | 8 | 0 | 8 | false | false | ["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/package/compile/events/apiGateway/lib/permissions.js->program->method_definition:compilePermissions", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition... |
serverless/serverless | 3,457 | serverless__serverless-3457 | ['3142'] | fea269947104889165e3ebb0f64638921caf2052 | diff --git a/lib/plugins/aws/package/compile/events/stream/index.js b/lib/plugins/aws/package/compile/events/stream/index.js
index a0bb4ab366b..695d88f18f8 100644
--- a/lib/plugins/aws/package/compile/events/stream/index.js
+++ b/lib/plugins/aws/package/compile/events/stream/index.js
@@ -136,6 +136,8 @@ class AwsCompil... | diff --git a/lib/plugins/aws/package/compile/events/stream/index.test.js b/lib/plugins/aws/package/compile/events/stream/index.test.js
index 0ebc32de75e..d3b455df06c 100644
--- a/lib/plugins/aws/package/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/package/compile/events/stream/index.test.js
@@ -136,6 +136,... | Serverless fails to deploy service with a kinesis stream event: Unresolved resource dependencies [IamPolicyLambdaExecution] in the Resources block of the template
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so the... | Hey @aashish004 thanks for reporting.
We're currently working on fixes for the stream support in those PRs here:
- https://github.com/serverless/serverless/pull/3111
- https://github.com/serverless/serverless/pull/3083
- https://github.com/serverless/serverless/pull/3141
Those will be merged the upcoming day... | 2017-04-12 03:56:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role reference is set in provider', 'AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given should allow specifying DynamoDB and Kinesis streams as CFN reference types', 'AwsCompileStreamEvents #compileStream... | ['AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role name reference is set in function', 'AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role name reference is set in provider'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/stream/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/package/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"] |
serverless/serverless | 3,187 | serverless__serverless-3187 | ['3088'] | 53c96088a2f15c72173536ab94428c8ea5f4b7d2 | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js
index aa5cbe4bd0e..e8e040b2bf0 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js
index 95e0630871c..5123e7813ed 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js
+++ b/lib/plugins/aws/deploy/compile/ev... | Multiple claims for authorizer break body mapping template
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/b... | Temporary Fix: when the second claim is removed (```- name```) it works fine.
It's not a fix if you have to remove something you need :wink:. The temporary fix is to update the body mapping template after a deploy (which would then enable access to all claim fields).
I guess you're right, but since for my solution I d... | 2017-02-03 18:33:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#compileMethods() when dealing with request configuration should setup a default "application/x-www-form-urlencoded" template', '#compileMethods() should add CORS origins to method only when CORS is enabled', '#compileMethods() should add integration responses for different status codes', '#compileMethods() when deal... | ['#compileMethods() should set multiple claims for a cognito user pool', '#compileMethods() should properly set claims for custom properties inside the cognito user pool'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/method/index.js->program->method_definition:compileMethods"] |
serverless/serverless | 3,095 | serverless__serverless-3095 | ['3094'] | 356a3d596653e3a37bbc81f054e899961b38bd58 | diff --git a/lib/plugins/aws/deploy/compile/events/iot/index.js b/lib/plugins/aws/deploy/compile/events/iot/index.js
index 0d6b01f0740..2c56cedd06b 100644
--- a/lib/plugins/aws/deploy/compile/events/iot/index.js
+++ b/lib/plugins/aws/deploy/compile/events/iot/index.js
@@ -55,12 +55,13 @@ class AwsCompileIoTEvents {
... | diff --git a/lib/plugins/aws/deploy/compile/events/iot/index.test.js b/lib/plugins/aws/deploy/compile/events/iot/index.test.js
index aa345a7944e..44e9c756139 100644
--- a/lib/plugins/aws/deploy/compile/events/iot/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/iot/index.test.js
@@ -95,7 +95,7 @@ describe('Aws... | Multi-line values in IoT event
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
... | it's reproducible on my machine, will fix and send PR. | 2017-01-14 06:44:52+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileIoTEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileIoTEvents #awsCompileIoTEvents() should respect "sqlVersion" variable', 'AwsCompileIoTEvents #awsCompileIoTEvents() should throw an error if iot event type is not an object', 'AwsCompileIoTEvents #awsCompile... | ['AwsCompileIoTEvents #awsCompileIoTEvents() should respect variables if multi-line variables is given'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/iot/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/iot/index.js->program->class_declaration:AwsCompileIoTEvents->method_definition:compileIoTEvents"] |
serverless/serverless | 2,952 | serverless__serverless-2952 | ['2508', '2508'] | f78fee916ddc48a69277f0940d4d89e219cbdaee | diff --git a/lib/plugins/aws/deploy/compile/events/stream/index.js b/lib/plugins/aws/deploy/compile/events/stream/index.js
index 41dab7cc4e0..d18b53fc1b5 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/index.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/index.js
@@ -17,6 +17,27 @@ class AwsCompileStre... | diff --git a/lib/plugins/aws/deploy/compile/events/stream/index.test.js b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
index a07c1600049..8e4d61f1388 100644
--- a/lib/plugins/aws/deploy/compile/events/stream/index.test.js
+++ b/lib/plugins/aws/deploy/compile/events/stream/index.test.js
@@ -275,6 +275,9 @@... | Maximum policy size of 10240 bytes exceeded for role
# This is a Bug Report
## Description
### What went wrong?
I tried to deploy a function that listens to 50+ DynamoDB streams. The deploy hung for around 5-10min before eventually failing.
### What did you expect should have happened?
The function should have deploy... | I tried to get around the issue by manually creating a new IAM role [as described in the docs](https://serverless.com/framework/docs/providers/aws/iam/#using-existing-iam-role), but now I get a different error:
```
Stack Trace --------------------------------------------
TypeError: Cannot read property 'Properties'... | 2016-12-15 00:09:40+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['AwsCompileStreamEvents #compileStreamEvents() should not create event source mapping when stream events are not given', 'AwsCompileStreamEvents #compileStreamEvents() should not throw error or merge role statements if default policy is not present', 'AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB strea... | ['AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given should add the necessary IAM role statements', 'AwsCompileStreamEvents #compileStreamEvents() when a Kinesis stream ARN is given should add the necessary IAM role statements'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/stream/index.test.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"] |
serverless/serverless | 2,945 | serverless__serverless-2945 | ['2132'] | 5a3e0c2bcaff15d77c925995693379967da42d80 | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
index a85c8518ba9..ff4844bed3c 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.js
@@ -6,6 +6,11 @@ const path = require('path');
module.export... | diff --git a/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js b/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
index 3dadf19a7f2..982380095e7 100644
--- a/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
+++ b/lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js
@@ -114,7 +114,6 @@ describe('#mergeIamTemp... | Warn when incorrect format for additional IAM Role Statements causes them not to be included
# Bug Report
## Description
When using a `$ref` to include additional IAM Role Statements for a service, if the `$ref`'d file is not in the correct format (i.e. an array including more role statements), the role statements you... | Thanks for reporting, sorry for the delay on answering, this should definitely be fixed through some validation.
| 2016-12-14 12:14:57+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#mergeIamTemplates() should not merge there are no functions', '#mergeIamTemplates() should add a CloudWatch LogGroup resource', '#mergeIamTemplates() should merge IamPolicyLambdaExecution template into the CloudFormation template', "#mergeIamTemplates() should update IamPolicyLambdaExecution with each function's log... | ['#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Action field', '#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should throw error if a custom IAM policy statement does not have an Effect field', '#me... | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/lib/mergeIamTemplates.test.js --reporter json | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:validateStatements", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:merge", "lib/plugins/aws/deploy/lib/mergeIamTemplates.js->program->method_definition:mergeIamTemplates"] |
serverless/serverless | 2,842 | serverless__serverless-2842 | ['2828'] | a949cd95c437a2de612a0b74b0074cd712e6d84b | diff --git a/lib/classes/Service.js b/lib/classes/Service.js
index 871ab8822e8..eca7aa75713 100644
--- a/lib/classes/Service.js
+++ b/lib/classes/Service.js
@@ -86,6 +86,12 @@ class Service {
throw new SError(errorMessage);
}
+ if (Array.isArray(serverlessFile.resources)) {
+ serve... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 91b0baf049a..3c833624acc 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -169,6 +169,37 @@ describe('Service', () => {
});
});
+ it('should merge resources given as an array', () => {
+ const... | Include Multiple Resource Files
# This is a Feature Proposal
## Description
This feature enables multiple resource files to be included in the 'Resources' section. This enables larger services to include sub resource files independantly. One resource file can be broken up a number to enable better independant man... | null | 2016-12-02 00:40:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Service #load() should throw error if frameworkVersion is not satisfied', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should return an array of function names in Service', 'Service #constructor() should at... | ['Service #load() should merge resources given as an array'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/classes/Service.js->program->class_declaration:Service->method_definition:load"] |
serverless/serverless | 2,576 | serverless__serverless-2576 | ['2383'] | 5d4003dbad6f3bd07d98ff5d835ddbaa6b093724 | diff --git a/lib/plugins/aws/lib/monitorStack.js b/lib/plugins/aws/lib/monitorStack.js
index 3c3e49e8c53..5abe556460f 100644
--- a/lib/plugins/aws/lib/monitorStack.js
+++ b/lib/plugins/aws/lib/monitorStack.js
@@ -45,23 +45,24 @@ module.exports = {
data.StackEvents.reverse().forEach((event) => {
... | diff --git a/lib/plugins/aws/tests/monitorStack.js b/lib/plugins/aws/tests/monitorStack.js
index c820f27a9b9..4e1ce49cd67 100644
--- a/lib/plugins/aws/tests/monitorStack.js
+++ b/lib/plugins/aws/tests/monitorStack.js
@@ -302,6 +302,63 @@ describe('monitorStack', () => {
});
});
+ it('should keep monito... | Can't deploy with master branch: "Cannot read property 'endsWith' of null"
<!--
1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com
2. Please check if an issue already exists so there are no duplicates
3. Check out and follow our Guidelines: https://github.com/serverless... | @bobby-brennan thanks for reporting!
It think I know what introduced the bug (a recent update to the `monitorStack` method). Will work on a fix!
BTW. Stack deployment should still work if you omit the `--verbose`/ `-v` flag.
@bobby-brennan could you provide your `serverless.yml` and a step-by-step list on how to rep... | 2016-10-31 09:32:59+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['monitorStack #monitorStack() should keep monitoring until DELETE_COMPLETE or stack not found catch', 'monitorStack #monitorStack() should keep monitoring until DELETE_COMPLETE stack status', 'monitorStack #monitorStack() should catch describeStackEvents error if stack was not in deleting state', 'monitorStack #monito... | ['monitorStack #monitorStack() should keep monitoring when 1st ResourceType is not "AWS::CloudFormation::Stack"'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/tests/monitorStack.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/lib/monitorStack.js->program->method_definition:monitorStack"] |
serverless/serverless | 2,434 | serverless__serverless-2434 | ['2418'] | cf927bf8a68496f762a55e5222415c808aa6087b | diff --git a/lib/Serverless.js b/lib/Serverless.js
index 61675bad987..376cd871965 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -84,6 +84,9 @@ class Serverless {
// (https://github.com/serverless/serverless/issues/2041)
this.variables.populateService(this.pluginManager.cliOptions);
+ // valid... | diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js
index 2a9ce568d60..a5844275313 100644
--- a/lib/classes/Service.test.js
+++ b/lib/classes/Service.test.js
@@ -392,21 +392,32 @@ describe('Service', () => {
YAML.dump(serverlessYml));
const serverless = new Serverless({ servicePath:... | Function event configuration can't be moved to a separate file anymore
# This is a Bug Report
## Description
We used to be able to specify a "file variable" for function event configuration, which was quite useful for a service with multiple handlers. This allowed each handler to be in their own directory, along with ... | Actually, on second thought, I could just change the check to look for an array OR a string using the variable syntax. That should be relatively easy given the variable syntax pattern is available in Service.js
I'll give that a crack when I get back from work
| 2016-10-18 11:05:31+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Service #load() should throw error if frameworkVersion is not satisfied', 'Service #load() should support Serverless file with a .yaml extension', 'Service #getFunction() should return function object', 'Service #getAllFunctions() should return an array of function names in Service', 'Service #constructor() should at... | ["Service #load() should throw error if a function's event is not an array or a variable"] | ['Service #load() should not throw error if functions property is missing'] | . /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js --reporter json | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["lib/classes/Service.js->program->class_declaration:Service", "lib/Serverless.js->program->class_declaration:Serverless->method_definition:run", "lib/classes/Service.js->program->class_declaration:Service->method_definition:load", "lib/classes/Service.js->program->class_declaration:Service->method_definition:validate"... |
serverless/serverless | 2,014 | serverless__serverless-2014 | ['2024'] | dcb30fb1395d37fb0580bc287bfd21959c532144 | diff --git a/docs/02-providers/aws/events/01-apigateway.md b/docs/02-providers/aws/events/01-apigateway.md
index 3f777ee870d..c1551a3f9fd 100644
--- a/docs/02-providers/aws/events/01-apigateway.md
+++ b/docs/02-providers/aws/events/01-apigateway.md
@@ -324,6 +324,62 @@ module.exports.hello = (event, context, cb) => {
... | diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js
index fe62ba805f0..948a68d0e24 100644
--- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js
+++ b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/me... | Setting up cors for same endpoint only merges Methods, but not headers and origins
<!--
1. Please check if an issue already exists so there are no duplicates
2. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md
3. Fill out the whole template so we have a good over... | null | 2016-09-04 22:35:18+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['#compileMethods() when dealing with request configuration should setup a default "application/x-www-form-urlencoded" template', '#compileMethods() when dealing with request configuration should throw an error if the provided config is not an object', '#compileMethods() when dealing with request configuration should b... | ['#compileMethods() should add multiple response templates for a custom response codes', '#compileMethods() should merge all preflight origins, method, and headers for a path', '#compileMethods() should add custom response codes', '#compileMethods() should add integration responses for different status codes'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/methods.js --reporter json | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["lib/plugins/aws/deploy/compile/events/apiGateway/lib/methods.js->program->method_definition:compileMethods"] |
serverless/serverless | 1,910 | serverless__serverless-1910 | ['1902'] | 67644f72843e558d5d407a40480e3ca011a3a6ce | diff --git a/lib/plugins/create/create.js b/lib/plugins/create/create.js
index 4d77a7c3c70..84e8d0212e7 100644
--- a/lib/plugins/create/create.js
+++ b/lib/plugins/create/create.js
@@ -36,6 +36,10 @@ class Create {
usage: 'The path where the service should be created (e.g. --path my-service)',
... | diff --git a/lib/plugins/create/tests/create.js b/lib/plugins/create/tests/create.js
index 9082070676f..11775a50301 100644
--- a/lib/plugins/create/tests/create.js
+++ b/lib/plugins/create/tests/create.js
@@ -48,6 +48,23 @@ describe('Create', () => {
expect(() => create.create()).to.throw(Error);
});
+ ... | Add --name option to create plugin
##### Feature Request:
With `serverless create -t aws-nodejs --name my_service` you should be able to automatically overwrite the name of the created service
##### Benefits:
- Make it easier for users to set the name and not run into an issue when the name is set to the default name
... | null | 2016-08-20 07:52:07+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN cur=$(git symbolic-ref --quiet --short HEAD); git for-each-ref --format='%(refname)' refs | awk -v cur="$cur" '$0... | ['Create #create() should generate scaffolding for "aws-java-gradle" template', 'Create #create() should create a renamed service in the directory if using the "path" option', 'Create #constructor() should have commands', 'Create #create() should generate scaffolding for "aws-java-maven" template', 'Create #create() sh... | ['Create #create() should create a custom renamed service in the directory if using the "path" and "name" option', 'Create #create() should overwrite the name for the service if user passed name'] | [] | . /usr/local/nvm/nvm.sh && npx mocha lib/plugins/create/tests/create.js --reporter json | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["lib/plugins/create/create.js->program->class_declaration:Create->method_definition:constructor", "lib/plugins/create/create.js->program->class_declaration:Create->method_definition:create"] |
microsoft/vscode | 106,767 | microsoft__vscode-106767 | ['106573'] | 8ce35fa28dedbb1b0e78c1bff26ab53d1e702868 | diff --git a/src/vs/editor/contrib/suggest/completionModel.ts b/src/vs/editor/contrib/suggest/completionModel.ts
--- a/src/vs/editor/contrib/suggest/completionModel.ts
+++ b/src/vs/editor/contrib/suggest/completionModel.ts
@@ -56,6 +56,7 @@ export class CompletionModel {
private _refilterKind: Refilter;
private _fi... | diff --git a/src/vs/editor/contrib/suggest/test/suggestModel.test.ts b/src/vs/editor/contrib/suggest/test/suggestModel.test.ts
--- a/src/vs/editor/contrib/suggest/test/suggestModel.test.ts
+++ b/src/vs/editor/contrib/suggest/test/suggestModel.test.ts
@@ -815,6 +815,9 @@ suite('SuggestModel - TriggerAndCancelOracle', fu... | Completions which use spaces are broken after updating from July to August version
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also pleas... | I am a maintainer of LaTeX-Workshop. I confirm that the same version of the extension is used with vscode `1.49` and `1.48.2`.
The list of suggestions are `completionItem`s with undefined `filterText ` and `range` attributes. In both version, invoking `document.getWordRangeAtPosition(vscode.window.activeTextEditor.s... | 2020-09-15 13:59:29+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['SuggestModel - Context Context - shouldAutoTrigger', 'SuggestModel - TriggerAndCancelOracle trigger - on type', 'SuggestModel - TriggerAndCancelOracle #17400: Keep filtering suggestModel.ts after space', "SuggestModel - TriggerAndCancelOracle Intellisense Completion doesn't respect space after equal sign (.html file)... | ['SuggestModel - TriggerAndCancelOracle Trigger (full) completions when (incomplete) completions are already active #99504'] | ['ID getMac', 'Unexpected Errors & Loader Errors should not have unexpected errors'] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/suggest/test/suggestModel.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 4 | 1 | 5 | false | false | ["src/vs/editor/contrib/suggest/suggestModel.ts->program->class_declaration:SuggestModel->method_definition:_onNewContext", "src/vs/editor/contrib/suggest/completionModel.ts->program->class_declaration:CompletionModel->method_definition:_createCachedState", "src/vs/editor/contrib/suggest/completionModel.ts->program->cl... |
microsoft/vscode | 108,964 | microsoft__vscode-108964 | ['96545', '96545', '96545'] | 13b3c937dc5e3816c79bdd2cdf2cdf6f9c727b75 | diff --git a/src/vs/editor/contrib/snippet/snippetSession.ts b/src/vs/editor/contrib/snippet/snippetSession.ts
--- a/src/vs/editor/contrib/snippet/snippetSession.ts
+++ b/src/vs/editor/contrib/snippet/snippetSession.ts
@@ -114,7 +114,7 @@ export class OneSnippet {
const range = this._editor.getModel().getDecorati... | diff --git a/src/vs/editor/contrib/snippet/test/snippetSession.test.ts b/src/vs/editor/contrib/snippet/test/snippetSession.test.ts
--- a/src/vs/editor/contrib/snippet/test/snippetSession.test.ts
+++ b/src/vs/editor/contrib/snippet/test/snippetSession.test.ts
@@ -561,6 +561,26 @@ suite('SnippetSession', function () {
... | Snippet tab stop selection issue
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sur... | Took a look at this but don't know how to fix it.
I think the error is in the decoration range calculation inside intervalTree.
This line :arrow_down: is being executed with `insertingCnt` being the length of the transformed text (`}`)
changing the decorarion range from `fff` to `fff}`
https://github.com/microsoft/... | 2020-10-20 03:55:34+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['SnippetSession adjust selection (overwrite[Before|After])', 'SnippetSession snippets, insert shorter snippet into non-empty selection', 'SnippetSession snippets, selections & typing', 'SnippetSession snippets, just text', 'SnippetSession snippets, merge', 'SnippetSession snippets, transform example', 'SnippetSession ... | ['SnippetSession snippets, transform adjacent to previous placeholder'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/snippet/test/snippetSession.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/contrib/snippet/snippetSession.ts->program->class_declaration:OneSnippet->method_definition:move"] |
microsoft/vscode | 109,750 | microsoft__vscode-109750 | ['109709'] | cf4b5a703f581944f308b9a6f1e8b386059caef1 | diff --git a/src/vs/platform/configuration/common/configurationRegistry.ts b/src/vs/platform/configuration/common/configurationRegistry.ts
--- a/src/vs/platform/configuration/common/configurationRegistry.ts
+++ b/src/vs/platform/configuration/common/configurationRegistry.ts
@@ -227,9 +227,9 @@ class ConfigurationRegist... | diff --git a/src/vs/platform/configuration/test/common/configurationRegistry.test.ts b/src/vs/platform/configuration/test/common/configurationRegistry.test.ts
new file mode 100644
--- /dev/null
+++ b/src/vs/platform/configuration/test/common/configurationRegistry.test.ts
@@ -0,0 +1,53 @@
+/*----------------------------... | configurationDefaults contribution changes JSON auto-complete behavior
Reported originally by @JacksonKearl where GitLens seemed to be breaking JSON auto-complete behavior -- causing an extra `"` being added at the end.
![recording (16)](https://user-images.githubusercontent.com/641685/97644218-2495ba00-1a20-11eb-94... |
That JSON extension has `[json]` configurationDefault for the `editor.suggest.insertMode` setting:
https://github.com/microsoft/vscode/blob/master/extensions/json-language-features/package.json#L109
That configurationDefault is lost when the gitlens extension also makes a `[json]` configurationDefault
The bu... | 2020-10-30 16:37:02+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ['ConfigurationRegistry configuration defaults - overrides defaults', 'ConfigurationRegistry configuration override', 'Unexpected Errors & Loader Errors should not have unexpected errors'] | ['ConfigurationRegistry configuration override defaults - merges defaults'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/configuration/test/common/configurationRegistry.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/platform/configuration/common/configurationRegistry.ts->program->class_declaration:ConfigurationRegistry->method_definition:registerDefaultConfigurations"] |
microsoft/vscode | 110,094 | microsoft__vscode-110094 | ['72177'] | 8c76afad6ccf861d1ea08df4bb9f83839e0e0cd0 | diff --git a/src/vs/editor/common/controller/cursor.ts b/src/vs/editor/common/controller/cursor.ts
--- a/src/vs/editor/common/controller/cursor.ts
+++ b/src/vs/editor/common/controller/cursor.ts
@@ -531,7 +531,7 @@ export class Cursor extends Disposable {
}
const closeChar = m[1];
- const autoClosingPairsCa... | diff --git a/src/vs/editor/test/browser/controller/cursor.test.ts b/src/vs/editor/test/browser/controller/cursor.test.ts
--- a/src/vs/editor/test/browser/controller/cursor.test.ts
+++ b/src/vs/editor/test/browser/controller/cursor.test.ts
@@ -4660,7 +4660,7 @@ suite('autoClosingPairs', () => {
'v|ar |c = \'|asd\';... | auto closing pairs with conflicting patterns problems
```
Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
```
Steps to Reproduce:
1. Create two a... | Another example is `[<SomeAttribute>]` in F#, where typing `[<` produces `>]]` where the closing bracket is doubled up because `[]` is also a bracket.
As you can see, the first `[` crea... | 2020-11-06 16:35:03+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ["Editor Controller - Regression tests Bug #18293:[regression][editor] Can't outdent whitespace line", "Editor Controller - Cursor issue #17011: Shift+home/end now go to the end of the selection start's line, not the selection's end", 'Editor Controller - Cursor move up', 'Editor Controller - Cursor Configuration remov... | ['autoClosingPairs issue #27937: Trying to add an item to the front of a list is cumbersome', 'autoClosingPairs issue #53357: Over typing ignores characters after backslash', 'autoClosingPairs quote', 'autoClosingPairs configurable open parens', 'autoClosingPairs issue #72177: multi-character autoclose with conflicting... | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/controller/cursor.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 15 | 3 | 18 | false | false | ["src/vs/editor/common/controller/cursorTypeOperations.ts->program->class_declaration:TypeOperations", "src/vs/editor/common/controller/cursorTypeOperations.ts->program->class_declaration:TypeOperations->method_definition:compositionEndWithInterceptors", "src/vs/editor/common/controller/cursorTypeOperations.ts->program... |
microsoft/vscode | 113,837 | microsoft__vscode-113837 | ['113404', '113404'] | bd5c20448c598534e94e741c31e03775380db98a | diff --git a/src/vs/base/common/filters.ts b/src/vs/base/common/filters.ts
--- a/src/vs/base/common/filters.ts
+++ b/src/vs/base/common/filters.ts
@@ -467,7 +467,7 @@ function isSeparatorAtPos(value: string, index: number): boolean {
if (index < 0 || index >= value.length) {
return false;
}
- const code = value.... | diff --git a/src/vs/base/test/common/filters.test.ts b/src/vs/base/test/common/filters.test.ts
--- a/src/vs/base/test/common/filters.test.ts
+++ b/src/vs/base/test/common/filters.test.ts
@@ -534,6 +534,11 @@ suite('Filters', () => {
assert.ok(Boolean(match));
});
+ test('Wrong highlight after emoji #113404', fun... | Wrong highlight if there are duplicate strings in completion item
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the ... | (Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
- [Onclick div it will show outer div boundary instead of current div (#70316)](https://www.github.com/microsoft/vscode/issues/70316) <!-- score: 0.544 -->
- [Emmet expression with a... | 2021-01-05 16:42:16+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:12-bullseye
RUN apt-get update && apt-get install -y \
git \
xvfb \
libxtst6 \
libxss1 \
libgtk-3-0 \
libnss3 \
libasound2 \
libx11-dev \
libxkbfile-dev \
pkg-config \
libsecret-1-dev \
libgbm-dev \
libgbm1 \
python \
ma... | ["Filters Vscode 1.12 no longer obeys 'sortText' in completion items (from language server), #26096", 'Filters Unexpected suggestion scoring, #28791', 'Filters HTML closing tag proposal filtered out #38880', 'Filters PrefixFilter - ignore case', 'Filters matchesSubString', 'Filters fuzzyScore', 'Filters fuzzyScore, man... | ['Filters Wrong highlight after emoji #113404'] | [] | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/filters.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/base/common/filters.ts->program->function_declaration:isSeparatorAtPos"] |
microsoft/vscode | 122,991 | microsoft__vscode-122991 | ['99629'] | b023cacd25dbcb68a04b6d164169b79467f454e1 | diff --git a/src/vs/base/common/strings.ts b/src/vs/base/common/strings.ts
--- a/src/vs/base/common/strings.ts
+++ b/src/vs/base/common/strings.ts
@@ -1082,3 +1082,81 @@ function getGraphemeBreakRawData(): number[] {
}
//#endregion
+
+/**
+ * Computes the offset after performing a left delete on the given string,
+... | diff --git a/src/vs/editor/test/browser/controller/cursor.test.ts b/src/vs/editor/test/browser/controller/cursor.test.ts
--- a/src/vs/editor/test/browser/controller/cursor.test.ts
+++ b/src/vs/editor/test/browser/controller/cursor.test.ts
@@ -2642,6 +2642,55 @@ suite('Editor Controller - Regression tests', () => {
... | Bug: Emoji modifiers in text treated separately when using backspace
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using t... | Since about 6 months, we have implemented Unicode's grapheme break rules. So it is not possible to place the cursor inside emojis. A Delete (Fn+Backspace) before the emoji will remove the entire grapheme. But Backspace will only delete one code point at a time. We have made the decision to behave like this due to it be... | 2021-05-05 09:22:05+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/*
WORKDIR /testbed
COPY... | ["Editor Controller - Regression tests Bug #18293:[regression][editor] Can't outdent whitespace line", "Editor Controller - Cursor issue #17011: Shift+home/end now go to the end of the selection start's line, not the selection's end", 'Editor Controller - Cursor move up', 'autoClosingPairs issue #27937: Trying to add a... | ['Editor Controller - Regression tests issue #99629: Emoji modifiers in text treated separately when using backspace (ZWJ sequence)', 'Editor Controller - Regression tests issue #99629: Emoji modifiers in text treated separately when using backspace'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/controller/cursor.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 7 | 0 | 7 | false | false | ["src/vs/base/common/strings.ts->program->function_declaration:getOffsetBeforeLastEmojiComponent", "src/vs/editor/common/controller/cursorDeleteOperations.ts->program->class_declaration:DeleteOperations->method_definition:getPositionAfterDeleteLeft", "src/vs/base/common/strings.ts->program->function_declaration:getLeft... |
microsoft/vscode | 123,294 | microsoft__vscode-123294 | ['121438', '121438'] | 133ae5ecee8b5bdb1e6257a44c2e1b5368905669 | diff --git a/src/vs/editor/common/modes/linkComputer.ts b/src/vs/editor/common/modes/linkComputer.ts
--- a/src/vs/editor/common/modes/linkComputer.ts
+++ b/src/vs/editor/common/modes/linkComputer.ts
@@ -154,7 +154,7 @@ function getClassifier(): CharacterClassifier<CharacterClass> {
if (_classifier === null) {
_cla... | diff --git a/src/vs/editor/test/common/modes/linkComputer.test.ts b/src/vs/editor/test/common/modes/linkComputer.test.ts
--- a/src/vs/editor/test/common/modes/linkComputer.test.ts
+++ b/src/vs/editor/test/common/modes/linkComputer.test.ts
@@ -230,4 +230,25 @@ suite('Editor Modes - Link Computer', () => {
' http:... | VSCode fails to recognize URLs containing the characters 【】
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and... | @alexdima in [this commit](https://github.com/microsoft/vscode/commit/7018ffce0bf2873bfd71ead5612b974b475bcffc#diff-47ef45cdeef86c6a54aa67b5c25a970fea5fa4e134160e377aefe0e589906ca9R51) "【" was explicitly marked as url termination character. I don't know why though. Shall I just remove it?
@hediet Thanks for pointing ou... | 2021-05-07 14:22:47+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/*
WORKDIR /testbed
COPY... | ['Editor Modes - Link Computer issue #86358: URL wrong recognition pattern', 'Editor Modes - Link Computer issue #62278: "Ctrl + click to follow link" for IPv6 URLs', 'Editor Modes - Link Computer issue #70254: bold links dont open in markdown file using editor mode with ctrl + click', 'Unexpected Errors & Loader Error... | ['Editor Modes - Link Computer issue #121438: Link detection stops at【...】', 'Editor Modes - Link Computer issue #121438: Link detection stops at “...”', 'Editor Modes - Link Computer issue #121438: Link detection stops at《...》'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/modes/linkComputer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/common/modes/linkComputer.ts->program->function_declaration:getClassifier"] |
microsoft/vscode | 127,071 | microsoft__vscode-127071 | ['127035'] | 498aea6ba28a98d2b23a3d66940e94260533b37d | diff --git a/src/vs/base/browser/ui/tree/asyncDataTree.ts b/src/vs/base/browser/ui/tree/asyncDataTree.ts
--- a/src/vs/base/browser/ui/tree/asyncDataTree.ts
+++ b/src/vs/base/browser/ui/tree/asyncDataTree.ts
@@ -881,6 +881,10 @@ export class AsyncDataTree<TInput, T, TFilterData = void> implements IDisposable
asyn... | diff --git a/src/vs/base/test/browser/ui/tree/asyncDataTree.test.ts b/src/vs/base/test/browser/ui/tree/asyncDataTree.test.ts
--- a/src/vs/base/test/browser/ui/tree/asyncDataTree.test.ts
+++ b/src/vs/base/test/browser/ui/tree/asyncDataTree.test.ts
@@ -435,4 +435,45 @@ suite('AsyncDataTree', function () {
assert.dee... | TreeItem State None to Expanded
Issue Type: <b>Bug</b>
We, [Cloud Code](https://github.com/GoogleCloudPlatform/cloud-code-vscode) have a use case where a TreeItem could transition from `vscode.TreeItemCollapsibleState.None` to `vscode.TreeItemCollapsibleState.Expanded`. Currently, this functionality doesn't seem to ... | null | 2021-06-24 10:33:40+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/*
WORKDIR /testbed
COPY... | ['AsyncDataTree issue #67722 - once resolved, refreshed collapsed nodes should only get children when expanded', 'AsyncDataTree issues #84569, #82629 - rerender', 'AsyncDataTree issue #80098 - concurrent refresh and expand', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'AsyncDataTree resolved ... | ['AsyncDataTree issue #127035 - tree should react to collapseByDefault toggles'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/browser/ui/tree/asyncDataTree.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/base/browser/ui/tree/asyncDataTree.ts->program->class_declaration:AsyncDataTree->method_definition:setChildren"] |
microsoft/vscode | 132,628 | microsoft__vscode-132628 | ['132516', '132516'] | f463e76080ad42270645090c8e13d6768dc7cd06 | diff --git a/src/vs/editor/contrib/inlineCompletions/inlineCompletionsModel.ts b/src/vs/editor/contrib/inlineCompletions/inlineCompletionsModel.ts
--- a/src/vs/editor/contrib/inlineCompletions/inlineCompletionsModel.ts
+++ b/src/vs/editor/contrib/inlineCompletions/inlineCompletionsModel.ts
@@ -204,6 +204,10 @@ export c... | diff --git a/src/vs/editor/contrib/inlineCompletions/test/inlineCompletionsProvider.test.ts b/src/vs/editor/contrib/inlineCompletions/test/inlineCompletionsProvider.test.ts
--- a/src/vs/editor/contrib/inlineCompletions/test/inlineCompletionsProvider.test.ts
+++ b/src/vs/editor/contrib/inlineCompletions/test/inlineCompl... | Inline-suggestion appearing at previous cursor location
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Sug... | Please let me know soon if we should release this with our Recovery Release tomorrow!
Thanks for your lightning fast fix, @hediet! 🍾 🥳 Releasing this quickly would be awesome - it's a quite distracting glitch!
@johanrosenkilde can you verify that the issue is fixed in todays insider build?
Please let me know soon if... | 2021-09-08 08:18:18+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
# Update apt sources to use the archive for Debian Buster
RUN sed -i -e 's/deb.debian.org/archive.debian.org/g' \
-e '/buster-updates/d' /etc/apt/sources.list
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 ... | ['Inline Completions Calling the provider is debounced', 'Inline Completions inlineCompletionToGhostText Whitespace (indentation)', 'Inline Completions Next/previous', 'Inline Completions Ghost text is shown automatically when configured', 'Inline Completions Forward stability', 'Inline Completions No race conditions',... | ['Inline Completions Do not reuse cache from previous session (#132516)'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/inlineCompletions/test/inlineCompletionsProvider.test.ts src/vs/editor/contrib/inlineCompletions/test/utils.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/contrib/inlineCompletions/inlineCompletionsModel.ts->program->class_declaration:InlineCompletionsSession->method_definition:constructor"] |
microsoft/vscode | 135,197 | microsoft__vscode-135197 | ['61070'] | a993ada9300a531c09dfa6a1be772b1abc1492ad | diff --git a/src/vs/editor/common/controller/cursorTypeOperations.ts b/src/vs/editor/common/controller/cursorTypeOperations.ts
--- a/src/vs/editor/common/controller/cursorTypeOperations.ts
+++ b/src/vs/editor/common/controller/cursorTypeOperations.ts
@@ -598,7 +598,7 @@ export class TypeOperations {
}
// Do n... | diff --git a/src/vs/editor/test/browser/controller/cursor.test.ts b/src/vs/editor/test/browser/controller/cursor.test.ts
--- a/src/vs/editor/test/browser/controller/cursor.test.ts
+++ b/src/vs/editor/test/browser/controller/cursor.test.ts
@@ -4878,6 +4878,18 @@ suite('autoClosingPairs', () => {
model.undo();
}
+... | Backticks not auto-closing for tagged template literals
Issue Type: <b>Bug</b>
When working with tagged template literals in JS and JSX (styled-components is my use case), the backticks used to auto-close when typed, but that recently changed. The big issue though is that if you go into a multi-line literal, and the... | (Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
- [PHP syntax highlighting breaks with backticks (#59545)](https://www.github.com/Microsoft/vscode/issues/59545) <!-- score: 0.498 -->
<!-- potential_duplicates_comment -->
It seems ... | 2021-10-16 01:17:33+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/*
WORKDIR /testbed
COPY... | ["Editor Controller - Regression tests Bug #18293:[regression][editor] Can't outdent whitespace line", "Editor Controller - Cursor issue #17011: Shift+home/end now go to the end of the selection start's line, not the selection's end", 'Editor Controller - Cursor move up', 'Undo stops there is a single undo stop for con... | ['autoClosingPairs issue #61070: backtick (`) should auto-close after a word character', 'Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/controller/cursor.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/common/controller/cursorTypeOperations.ts->program->class_declaration:TypeOperations->method_definition:_getAutoClosingPairClose"] |
microsoft/vscode | 135,805 | microsoft__vscode-135805 | ['26393', '26393'] | 7d8f55ebb1b7ccb084f7e6969b6926519c5c80c3 | diff --git a/src/vs/editor/contrib/multicursor/multicursor.ts b/src/vs/editor/contrib/multicursor/multicursor.ts
--- a/src/vs/editor/contrib/multicursor/multicursor.ts
+++ b/src/vs/editor/contrib/multicursor/multicursor.ts
@@ -70,7 +70,10 @@ export class InsertCursorAbove extends EditorAction {
return;
}
- co... | diff --git a/src/vs/editor/contrib/multicursor/test/multicursor.test.ts b/src/vs/editor/contrib/multicursor/test/multicursor.test.ts
--- a/src/vs/editor/contrib/multicursor/test/multicursor.test.ts
+++ b/src/vs/editor/contrib/multicursor/test/multicursor.test.ts
@@ -16,6 +16,31 @@ import { IStorageService } from 'vs/pl... | Multiple cursors + Word wrap
The current behaviour in VSCode with `"editor.wordWrap": "on" ` is like this:
But I would prefer an option for this
, this can be implemented from an extension.
Is anybody intending to do anything about this, extension or otherwise? @alexandrudima seems to imply that the current behavior is by design, but I believe it is literally useless. Additional cursors positioned in par... | 2021-10-25 20:23:23+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/*
WORKDIR /testbed
COPY... | ['Multicursor selection Find state disassociation enters mode', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Multicursor selection AddSelectionToNextFindMatchAction starting with all collapsed selections on different words', 'Multicur... | ['Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running', 'Multicursor issue #26393: Multiple cursors + Word wrap'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/multicursor/test/multicursor.test.ts --reporter json --no-sandbox --exit | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["src/vs/editor/contrib/multicursor/multicursor.ts->program->class_declaration:InsertCursorBelow->method_definition:run", "src/vs/editor/contrib/multicursor/multicursor.ts->program->class_declaration:InsertCursorAbove->method_definition:run"] |
microsoft/vscode | 136,347 | microsoft__vscode-136347 | ['116939'] | 4bbec283c36a51cf80f9b77c7a81c140a76a363b | diff --git a/src/vs/editor/browser/viewParts/lines/viewLines.css b/src/vs/editor/browser/viewParts/lines/viewLines.css
--- a/src/vs/editor/browser/viewParts/lines/viewLines.css
+++ b/src/vs/editor/browser/viewParts/lines/viewLines.css
@@ -14,6 +14,11 @@
100% { background-color: none }
}*/
+.mtkcontrol {
+ color: r... | diff --git a/src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts b/src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts
--- a/src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts
+++ b/src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts
@@ -2114,6 +2114,38 @@ suite('viewLineRendere... | Important control characters aren't rendered when "editor.renderControlCharacters" is set, possibly leading users astray
Issue Type: <b>Bug</b>
### Problem
Imagine you're looking at some code in VS Code:
```
function transferBalance(sender_id, recipient_id, amount, currency) { ⋯ }
transferBalance(5678,677... | Duplicate of #58252
There are some extension suggestions in https://github.com/microsoft/vscode/issues/58252#issuecomment-557023217 you can give a try.
> Duplicate of #58252
I don't think this is a duplicate. That issue is about invisible characters, which are different than control characters. For example, a non... | 2021-11-03 11:58:31+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:14
RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/*
WORKDIR /testbed
COPY... | ['viewLineRenderer.renderLine 2 createLineParts render whitespace - 2 leading tabs', 'viewLineRenderer.renderLine issue #21476: Does not split large tokens when ligatures are on', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'viewLineR... | ["viewLineRenderer.renderLine 2 issue #116939: Important control characters aren't rendered"] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/viewLayout/viewLineRenderer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["src/vs/editor/common/viewLayout/viewLineRenderer.ts->program->function_declaration:_renderLine", "src/vs/editor/common/viewLayout/viewLineRenderer.ts->program->function_declaration:isControlCharacter", "src/vs/editor/common/viewLayout/viewLineRenderer.ts->program->function_declaration:resolveRenderLineInput", "src/vs... |
microsoft/vscode | 148,971 | microsoft__vscode-148971 | ['140733'] | 2dff5deef71fed71f039f8064e4e6deb818b1e3d | diff --git a/src/vs/base/browser/markdownRenderer.ts b/src/vs/base/browser/markdownRenderer.ts
--- a/src/vs/base/browser/markdownRenderer.ts
+++ b/src/vs/base/browser/markdownRenderer.ts
@@ -130,30 +130,17 @@ export function renderMarkdown(markdown: IMarkdownString, options: MarkdownRende
if (href === text) { // raw... | diff --git a/src/vs/base/test/browser/markdownRenderer.test.ts b/src/vs/base/test/browser/markdownRenderer.test.ts
--- a/src/vs/base/test/browser/markdownRenderer.test.ts
+++ b/src/vs/base/test/browser/markdownRenderer.test.ts
@@ -148,7 +148,7 @@ suite('MarkdownRenderer', () => {
mds.appendMarkdown(`[$(zap)-link](#... | Markdown Render VSCode Command Link
Issue Type: <b>Bug</b>
Hello,
Regarding the `MarkdownString`, in Markdown this:
`[Name](link)`
Renders a link. In a VS Code Extension, this is also possible:
`[Run It](command:pkg.command)`
Creating a link to run a command.
One would think creating an actual anch... | can i take this?
I think they'd be happy if you created a PR.
For completeness: `data-href` works:
`<a data-href="command:pkg.command">Run It</a>`
but the cursor does not change to a hand icon like if `href` was populated.
> I think they'd be happy if you created a PR.
>
> For completeness: `data-href` wo... | 2022-05-06 22:49:58+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['MarkdownRenderer Images image width from title params', 'MarkdownRenderer supportHtml Should not include scripts even when supportHtml=true', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'MarkdownRenderer ThemeIcons Support Off rende... | ['MarkdownRenderer ThemeIcons Support On render icon in table', 'MarkdownRenderer ThemeIcons Support On render icon in link', 'MarkdownRenderer Should render command links in trusted strings', 'MarkdownRenderer Should not render command links by default'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/browser/markdownRenderer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/base/browser/markdownRenderer.ts->program->function_declaration:renderMarkdown"] |
microsoft/vscode | 149,380 | microsoft__vscode-149380 | ['149283'] | 5b8bd1c45ca3041a2a947e499d2db21c0a2df20d | diff --git a/src/vs/workbench/contrib/debug/node/terminals.ts b/src/vs/workbench/contrib/debug/node/terminals.ts
--- a/src/vs/workbench/contrib/debug/node/terminals.ts
+++ b/src/vs/workbench/contrib/debug/node/terminals.ts
@@ -120,6 +120,10 @@ export function prepareCommand(shell: string, args: string[], cwd?: string, ... | diff --git a/src/vs/workbench/contrib/debug/test/node/terminals.test.ts b/src/vs/workbench/contrib/debug/test/node/terminals.test.ts
new file mode 100644
--- /dev/null
+++ b/src/vs/workbench/contrib/debug/test/node/terminals.test.ts
@@ -0,0 +1,76 @@
+/*-------------------------------------------------------------------... | Some terminal launch config args are double-escaped
Run this launch config
```json
{
"type": "node",
"request": "launch",
"name": "Run",
"runtimeVersion": "16.4.0",
"program": "${file}",
"console": "integratedTerminal",
"args": [">", "> hello.txt"]
},
```
This creates a file ... | null | 2022-05-12 17:49:46+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['Debug - prepareCommand cmd', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Debug - prepareCommand cmd - do not escape > and <', 'Debug - prepareCommand powershell - do not escape > and <', 'Unexpected Errors & Loader Errors should no... | ['Debug - prepareCommand bash', 'Debug - prepareCommand bash - do not escape > and <'] | ['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/debug/test/node/terminals.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/contrib/debug/node/terminals.ts->program->function_declaration:prepareCommand"] |
microsoft/vscode | 153,121 | microsoft__vscode-153121 | ['152773'] | 1a599e2d1792630bc7c53232404d83214acb88f4 | diff --git a/src/vs/editor/common/viewModel/monospaceLineBreaksComputer.ts b/src/vs/editor/common/viewModel/monospaceLineBreaksComputer.ts
--- a/src/vs/editor/common/viewModel/monospaceLineBreaksComputer.ts
+++ b/src/vs/editor/common/viewModel/monospaceLineBreaksComputer.ts
@@ -411,7 +411,7 @@ function createLineBreaks... | diff --git a/src/vs/editor/test/common/viewModel/monospaceLineBreaksComputer.test.ts b/src/vs/editor/test/common/viewModel/monospaceLineBreaksComputer.test.ts
--- a/src/vs/editor/test/common/viewModel/monospaceLineBreaksComputer.test.ts
+++ b/src/vs/editor/test/common/viewModel/monospaceLineBreaksComputer.test.ts
@@ -1... | Word wrap algorithm behaves differently with bracket followed by comma
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitti... | Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!
Updated per the bot's suggestion, issue remains. | 2022-06-24 14:02:10+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['Editor ViewModel - MonospaceLineBreaksComputer issue #33366: Word wrap algorithm behaves differently around punctuation', 'Editor ViewModel - MonospaceLineBreaksComputer issue #75494: surrogate pairs', 'Editor ViewModel - MonospaceLineBreaksComputer MonospaceLineBreaksComputer - WrappingIndent.DeepIndent', 'Tests are... | ['Editor ViewModel - MonospaceLineBreaksComputer MonospaceLineBreaksComputer', 'Editor ViewModel - MonospaceLineBreaksComputer issue #152773: Word wrap algorithm behaves differently with bracket followed by comma'] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/viewModel/monospaceLineBreaksComputer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/vs/editor/common/viewModel/monospaceLineBreaksComputer.ts->program->function_declaration:createLineBreaks", "src/vs/editor/common/viewModel/monospaceLineBreaksComputer.ts->program->function_declaration:canBreak"] |
microsoft/vscode | 153,857 | microsoft__vscode-153857 | ['151631'] | 88ffbc7a7a81a926c7969ad7428e2ffc54370f42 | diff --git a/src/vs/editor/common/languages/linkComputer.ts b/src/vs/editor/common/languages/linkComputer.ts
--- a/src/vs/editor/common/languages/linkComputer.ts
+++ b/src/vs/editor/common/languages/linkComputer.ts
@@ -258,15 +258,15 @@ export class LinkComputer {
case CharCode.CloseCurlyBrace:
chClass =... | diff --git a/src/vs/editor/test/common/modes/linkComputer.test.ts b/src/vs/editor/test/common/modes/linkComputer.test.ts
--- a/src/vs/editor/test/common/modes/linkComputer.test.ts
+++ b/src/vs/editor/test/common/modes/linkComputer.test.ts
@@ -258,4 +258,11 @@ suite('Editor Modes - Link Computer', () => {
'https://s... | Link parsing stoped where comments include a single quote
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-... | I can verify the reported behavior, but don't know what is correct to do. | 2022-06-30 20:07:37+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['Editor Modes - Link Computer issue #86358: URL wrong recognition pattern', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Editor Modes - Link Computer issue #150905: Colon after bare hyperlink is treated as its part', 'Editor Modes - ... | ['Editor Modes - Link Computer issue #151631: Link parsing stoped where comments include a single quote '] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/modes/linkComputer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/common/languages/linkComputer.ts->program->class_declaration:LinkComputer->method_definition:computeLinks"] |
microsoft/vscode | 157,682 | microsoft__vscode-157682 | ['157634'] | 651361e0aa7e628a99a8f6383797b58c0915c636 | diff --git a/src/vs/editor/contrib/codeAction/browser/codeAction.ts b/src/vs/editor/contrib/codeAction/browser/codeAction.ts
--- a/src/vs/editor/contrib/codeAction/browser/codeAction.ts
+++ b/src/vs/editor/contrib/codeAction/browser/codeAction.ts
@@ -72,7 +72,7 @@ class ManagedCodeActionSet extends Disposable implement... | diff --git a/src/vs/editor/contrib/codeAction/test/browser/codeAction.test.ts b/src/vs/editor/contrib/codeAction/test/browser/codeAction.test.ts
--- a/src/vs/editor/contrib/codeAction/test/browser/codeAction.test.ts
+++ b/src/vs/editor/contrib/codeAction/test/browser/codeAction.test.ts
@@ -119,9 +119,9 @@ suite('CodeAc... | Suggested code action should put update imports first
I feel this is a regression.
| null | 2022-08-09 17:34:23+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['CodeAction getCodeActions should not return source code action by default', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'CodeAction getCodeActions should forward... | ['CodeAction CodeActions are sorted by type, #38623'] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/codeAction/test/browser/codeAction.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/contrib/codeAction/browser/codeAction.ts->program->class_declaration:ManagedCodeActionSet->method_definition:codeActionsComparator"] |
microsoft/vscode | 160,342 | microsoft__vscode-160342 | ['108885'] | 440e61ffab2ba257f30852940fdce18a48a168ea | diff --git a/src/vs/workbench/contrib/files/browser/views/explorerView.ts b/src/vs/workbench/contrib/files/browser/views/explorerView.ts
--- a/src/vs/workbench/contrib/files/browser/views/explorerView.ts
+++ b/src/vs/workbench/contrib/files/browser/views/explorerView.ts
@@ -108,6 +108,11 @@ export function getContext(f... | diff --git a/src/vs/workbench/contrib/files/test/browser/explorerView.test.ts b/src/vs/workbench/contrib/files/test/browser/explorerView.test.ts
--- a/src/vs/workbench/contrib/files/test/browser/explorerView.test.ts
+++ b/src/vs/workbench/contrib/files/test/browser/explorerView.test.ts
@@ -34,7 +34,7 @@ suite('Files - ... | Unselecting selection among multi-selection and pressing DEL delete latest unselected item
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Al... | (Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
- [Allow un-selecting an item in a contributed tree (#48754)](https://www.github.com/microsoft/vscode/issues/48754) <!-- score: 0.507 -->
<!-- potential_duplicates_comment -->
Yeah t... | 2022-09-07 18:35:50+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['Files - ExplorerView decoration provider', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Files - ExplorerView compressed navigation controller', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'Unexpected Error... | ['Files - ExplorerView getContext'] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/files/test/browser/explorerView.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/contrib/files/browser/views/explorerView.ts->program->function_declaration:getContext"] |
microsoft/vscode | 164,396 | microsoft__vscode-164396 | ['161573'] | f5fdf679b8d22a0dd0dcb6fd8e3bc96bbeb99f75 | diff --git a/src/vs/editor/common/services/modelService.ts b/src/vs/editor/common/services/modelService.ts
--- a/src/vs/editor/common/services/modelService.ts
+++ b/src/vs/editor/common/services/modelService.ts
@@ -770,6 +770,7 @@ export class ModelSemanticColoring extends Disposable {
private _currentDocumentRespons... | diff --git a/src/vs/editor/test/common/services/modelService.test.ts b/src/vs/editor/test/common/services/modelService.test.ts
--- a/src/vs/editor/test/common/services/modelService.test.ts
+++ b/src/vs/editor/test/common/services/modelService.test.ts
@@ -5,7 +5,7 @@
import * as assert from 'assert';
import { CharCo... | onDidChangeSemanticTokens doesn't consistently trigger provideDocumentSemanticTokens
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode... | The logic on our side is to [listen to change events coming in from semantic tokens providers](https://github.com/microsoft/vscode/blob/8e1235ee25e3aad3598ab58016c071b5596b826a/src/vs/editor/common/services/modelService.ts#L817) and then we schedule a request for semantic tokens [**if one is not currently running**](ht... | 2022-10-23 19:54:23+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['ModelService generated4', 'ModelService does replacements', 'ModelService does not maintain undo for same resource and different content', 'ModelService setValue should clear undo stack', 'ModelSemanticColoring DocumentSemanticTokens should be pick the token provider with actual items', 'ModelService _computeEdits no... | ["ModelSemanticColoring issue #161573: onDidChangeSemanticTokens doesn't consistently trigger provideDocumentSemanticTokens"] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/services/modelService.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | false | false | true | 3 | 1 | 4 | false | false | ["src/vs/editor/common/services/modelService.ts->program->class_declaration:ModelSemanticColoring->method_definition:_setDocumentSemanticTokens", "src/vs/editor/common/services/modelService.ts->program->class_declaration:ModelSemanticColoring->method_definition:_fetchDocumentSemanticTokensNow", "src/vs/editor/common/se... |
microsoft/vscode | 168,752 | microsoft__vscode-168752 | ['119696'] | f63eaa61fb7e4599824574add2e29ae5e677cf77 | diff --git a/src/vs/editor/common/languages/linkComputer.ts b/src/vs/editor/common/languages/linkComputer.ts
--- a/src/vs/editor/common/languages/linkComputer.ts
+++ b/src/vs/editor/common/languages/linkComputer.ts
@@ -155,12 +155,12 @@ function getClassifier(): CharacterClassifier<CharacterClass> {
_classifier = ne... | diff --git a/src/vs/editor/test/common/modes/linkComputer.test.ts b/src/vs/editor/test/common/modes/linkComputer.test.ts
--- a/src/vs/editor/test/common/modes/linkComputer.test.ts
+++ b/src/vs/editor/test/common/modes/linkComputer.test.ts
@@ -26,38 +26,29 @@ function myComputeLinks(lines: string[]): ILink[] {
return ... | URLs in CSV document not split by field
Issue Type: <b>Bug</b>
When editing a CSV document, automatically-detected URLs (aka option+click to open) are often conjoined with the start of the following field. I presume the URL detection heuristic for plain text documents is reused for CSV documents. I propose that URLs... | null | 2022-12-10 23:43:22+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['Editor Modes - Link Computer issue #86358: URL wrong recognition pattern', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Editor Modes - Link Computer issue #150905: Colon after bare hyperlink is treated as its part', 'Editor Modes - ... | ["Editor Modes - Link Computer issue #119696: Links shouldn't include commas"] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/modes/linkComputer.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/editor/common/languages/linkComputer.ts->program->function_declaration:getClassifier"] |
microsoft/vscode | 173,585 | microsoft__vscode-173585 | ['173325'] | fcafbd6df382036c665b63a2c08e6154bfbbd289 | diff --git a/src/vs/base/common/keybindings.ts b/src/vs/base/common/keybindings.ts
--- a/src/vs/base/common/keybindings.ts
+++ b/src/vs/base/common/keybindings.ts
@@ -94,7 +94,7 @@ export class KeyCodeChord implements Modifiers {
const shift = this.shiftKey ? '1' : '0';
const alt = this.altKey ? '1' : '0';
con... | diff --git a/src/vs/base/test/common/keybindings.test.ts b/src/vs/base/test/common/keybindings.test.ts
new file mode 100644
--- /dev/null
+++ b/src/vs/base/test/common/keybindings.test.ts
@@ -0,0 +1,18 @@
+/*---------------------------------------------------------------------------------------------
+ * Copyright (c)... | keyboard shortcuts: wrong interpretations of special keys (e.g. `[Equal]` is mistaken for `V`)
Type: <b>Bug</b>
1. Update VS Code (for me, it was from `1.74.1` to `1.75`)
2. User defined keybindings using scan codes (e.g. `[Equal]` or `[Semicolon]`) are interpreted incorrectly
![Screenshot from 2023-02-03 17-18-... | related: https://stackoverflow.com/questions/75336265/vscode-says-equal-key-is-v-keyboard-layout-messed-up
I think this is not only `ctrl+v` but I have other keybindings stopped working just after this upgrade.
> I think this is not only `ctrl+v` but I have other keybindings stopped working just after this upgrade.
... | 2023-02-06 16:24:42+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running', 'Unexpected Errors & Loader Errors should not hav... | ['keyCodes issue #173325: wrong interpretations of special keys (e.g. [Equal] is mistaken for V)'] | ['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and... | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/keybindings.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/vs/base/common/keybindings.ts->program->class_declaration:ScanCodeChord->method_definition:getHashCode", "src/vs/base/common/keybindings.ts->program->class_declaration:KeyCodeChord->method_definition:getHashCode"] |
microsoft/vscode | 177,084 | microsoft__vscode-177084 | ['176756'] | 384b03f26310fc3c4ea86156b7c6aefb431d594f | diff --git a/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts b/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
--- a/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
+++ b/src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
@@ -451,7 +451,7 @@ const ter... | diff --git a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts b/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts
--- a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts
+++ b/src/vs/workbench/contrib/term... | v1.76.x - terminal ctrl-click code-line lookup regexp fails
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and... | This actually works fine for me when there's no line number:
| 2023-03-14 13:23:27+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
# Clean up git history
RUN git remote | xargs -r -n1 git remote remove
RUN... | ['TerminalLinkParsing getLinkSuffix `foo, line 339`', 'TerminalLinkParsing getLinkSuffix `foo, line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `foo: line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `"foo" on line 339,\xa0column 12`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a ... | ['TerminalLinkParsing detectLinks should exclude pipe characters from link paths with suffixes'] | [] | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --reporter json --no-sandbox --exit | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | [] |
microsoft/vscode | 189,223 | microsoft__vscode-189223 | ['189222'] | 9a281018181dca942cc46c03f9795be00912e38d | diff --git a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalWordLinkDetector.ts b/src/vs/workbench/contrib/terminalContrib/links/browser/terminalWordLinkDetector.ts
--- a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalWordLinkDetector.ts
+++ b/src/vs/workbench/contrib/terminalContrib/lin... | diff --git a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalWordLinkDetector.test.ts b/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalWordLinkDetector.test.ts
--- a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalWordLinkDetector.test.ts
+++ b/src/vs/workben... | Powerline symbols should not be included in links
When using a powerline prompt:
We should not be allowing the powerline symbols to be links (ctrl+hover):
![image](https://github.com/microsoft/vscode/assets/219331... | null | 2023-07-29 12:13:30+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 18.8.0 && rm -rf node_modules && npx playwright install --with-deps chromium webkit && yarn install
RUN chmod +x ./scripts/test.sh
RUN . $NVM_DIR/nvm.sh && nvm alias default 18.8.0 && nvm use default
# Clean up git history... | ['Workbench - TerminalWordLinkDetector should link words as defined by wordSeparators " "', 'Workbench - TerminalWordLinkDetector should remove trailing colon in the link results', 'Workbench - TerminalWordLinkDetector should support multiple link results', 'Workbench - TerminalWordLinkDetector does not return any link... | ['Workbench - TerminalWordLinkDetector should ignore powerline symbols \\ue0b9', 'Workbench - TerminalWordLinkDetector should ignore powerline symbols \\ue0b7', 'Workbench - TerminalWordLinkDetector should ignore powerline symbols \\ue0b6', 'Workbench - TerminalWordLinkDetector should ignore powerline symbols \\ue0be',... | [] | . /usr/local/nvm/nvm.sh && nvm use 18.8.0 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalWordLinkDetector.test.ts --reporter json --no-sandbox --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/vs/workbench/contrib/terminalContrib/links/browser/terminalWordLinkDetector.ts->program->class_declaration:TerminalWordLinkDetector->method_definition:_refreshSeparatorCodes"] |
angular/angular | 37,561 | angular__angular-37561 | ['35733'] | f7997256fc23e202e08df39997afd360d202f9f1 | diff --git a/packages/core/src/render3/di.ts b/packages/core/src/render3/di.ts
--- a/packages/core/src/render3/di.ts
+++ b/packages/core/src/render3/di.ts
@@ -657,16 +657,31 @@ export function ɵɵgetFactoryOf<T>(type: Type<any>): FactoryFn<T>|null {
*/
export function ɵɵgetInheritedFactory<T>(type: Type<any>): (type:... | diff --git a/packages/core/test/render3/providers_spec.ts b/packages/core/test/render3/providers_spec.ts
--- a/packages/core/test/render3/providers_spec.ts
+++ b/packages/core/test/render3/providers_spec.ts
@@ -6,10 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/
-import {Component as _Compo... | Too much recursion because of @Injectable conflicts with other decorators
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, ... | I have a similar error after upgrading to 9.0.4/0.900.4:
```
Compiling @angular/… : es2015 as esm2015
chunk {} runtime.689ba4fd6cadb82c1ac2.js (runtime) 1.45 kB [entry] [rendered]
chunk {1} main.9d65be46ac259c9df33b.js (main) 700 kB [initial] [rendered]
chunk {2} polyfills.da2c6c4849ef9aea9de5.js (polyfills) 3... | 2020-06-12 20:02:28+00:00 | TypeScript | FROM public.ecr.aws/docker/library/node:10-buster
EXPOSE 4000 4200 4433 5000 8080 9876
USER root
RUN echo 'deb http://archive.debian.org/debian buster main' > /etc/apt/sources.list && \
echo 'deb http://archive.debian.org/debian-security buster/updates main' >> /etc/apt/sources.list && \
echo 'Acquire::Check-V... | ['/packages/localize/src/tools/test/translate/integration:integration', '/packages/core/test/bundling/injection:symbol_test', '/packages/compiler/test/selector:selector', '/packages/platform-browser/test:testing_circular_deps_test', '/packages/compiler/test:circular_deps_test', '/packages/compiler-cli/src/ngtsc/scope/t... | ['/packages/core/test/render3:render3'] | ['/packages/platform-browser-dynamic/test:test_web_chromium', '/packages/platform-browser/test:test_web_chromium', '/packages/platform-webworker/test:test_web_chromium', '/packages/http/test:test_web_chromium', '/packages/core/test/bundling/hello_world:test', '/packages/core/test/bundling/todo:test', '/packages/common/... | bazel test packages/core/test/render3 --keep_going --test_output=summary --test_summary=short --noshow_progress | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["packages/core/src/render3/di.ts->program->function_declaration:\u0275\u0275getInheritedFactory"] |
mui/material-ui | 11,451 | mui__material-ui-11451 | ['11432'] | 04fae47c2a876f38aacfae866d220ddcbb7358ef | diff --git a/packages/material-ui/src/ListItem/ListItem.js b/packages/material-ui/src/ListItem/ListItem.js
--- a/packages/material-ui/src/ListItem/ListItem.js
+++ b/packages/material-ui/src/ListItem/ListItem.js
@@ -78,6 +78,7 @@ class ListItem extends React.Component {
disabled,
disableGutters,
div... | diff --git a/packages/material-ui/src/ListItem/ListItem.test.js b/packages/material-ui/src/ListItem/ListItem.test.js
--- a/packages/material-ui/src/ListItem/ListItem.test.js
+++ b/packages/material-ui/src/ListItem/ListItem.test.js
@@ -158,4 +158,15 @@ describe('<ListItem />', () => {
assert.strictEqual(wrapper.h... | MenuItem doesn't respect focusVisibleClassName
Related to #10976.
The changes in #10976 work awesome for the `Switch`, however it looks like the `MenuItem`'s `focusVisibleClassName` prop doesn't work as expected. Passing a `focusVisibleClassName` to the item works great from a typing perspective, but they don't see... | @ianschmitz Correct, we need to merge the classnames in
https://github.com/mui-org/material-ui/blob/e99f23e85f9f0241a08165b435cd4d51f696ac12/packages/material-ui/src/ListItem/ListItem.js#L108 | 2018-05-17 18:47:56+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/ListItem/ListItem.test.js-><ListItem /> secondary action should accet a button property', 'packages/material-ui/src/ListItem/ListItem.test.js-><ListItem /> should disable the gutters', 'packages/material-ui/src/ListItem/ListItem.test.js-><ListItem /> should render a li', 'packages/material-ui... | ['packages/material-ui/src/ListItem/ListItem.test.js-><ListItem /> prop: focusVisibleClassName should merge the class names'] | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/ListItem/ListItem.test.js --reporter /testbed/custom-reporter.js --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["packages/material-ui/src/ListItem/ListItem.js->program->class_declaration:ListItem->method_definition:render"] |
mui/material-ui | 11,858 | mui__material-ui-11858 | ['11834'] | 4acfb8da9fb5fc258871aa5a55788fa37208babc | diff --git a/.size-limit.js b/.size-limit.js
--- a/.size-limit.js
+++ b/.size-limit.js
@@ -27,7 +27,7 @@ module.exports = [
name: 'The size of all the modules of material-ui.',
webpack: true,
path: 'packages/material-ui/build/index.js',
- limit: '94.9 KB',
+ limit: '95.0 KB',
},
{
name: ... | diff --git a/packages/material-ui/src/ListItemText/ListItemText.test.js b/packages/material-ui/src/ListItemText/ListItemText.test.js
--- a/packages/material-ui/src/ListItemText/ListItemText.test.js
+++ b/packages/material-ui/src/ListItemText/ListItemText.test.js
@@ -213,4 +213,27 @@ describe('<ListItemText />', () => {... | Getting ListItemText to inherit color is a pain
<!--- Provide a general summary of the issue in the Title above -->
<!--
Thank you very much for contributing to Material-UI by creating an issue! ❤️
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should lo... | > I have to do:
You also have to add `disableTypography `.
Ah, I hadn't even tried, I was just guessing. So it takes even more text to do.
As a side note, I wish there were some magic way to reference the JSS class name for the `ListItemText` and `Typography` within the styles for my sidebar...then I could overrid... | 2018-06-14 14:37:15+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/ListItemText/ListItemText.test.js-><ListItemText /> prop: primary should use the children prop as primary node', 'packages/material-ui/src/ListItemText/ListItemText.test.js-><ListItemText /> should render with the user and root classes', 'packages/material-ui/src/ListItemText/ListItemText.tes... | ['packages/material-ui/src/ListItemText/ListItemText.test.js-><ListItemText /> should pass secondaryTypographyProps to secondary Typography component', 'packages/material-ui/src/ListItemText/ListItemText.test.js-><ListItemText /> should pass primaryTypographyProps to primary Typography component'] | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/ListItemText/ListItemText.test.js --reporter /testbed/custom-reporter.js --exit | Feature | false | true | false | false | 1 | 0 | 1 | true | false | ["packages/material-ui/src/ListItemText/ListItemText.js->program->function_declaration:ListItemText"] |
mui/material-ui | 11,987 | mui__material-ui-11987 | ['4489'] | 09896d42e6206984a54272cc2059c49a7aa9d54f | diff --git a/.size-limit.js b/.size-limit.js
--- a/.size-limit.js
+++ b/.size-limit.js
@@ -27,7 +27,7 @@ module.exports = [
name: 'The size of all the modules of material-ui.',
webpack: true,
path: 'packages/material-ui/build/index.js',
- limit: '94.8 KB',
+ limit: '94.9 KB',
},
{
name: ... | diff --git a/packages/material-ui/src/SvgIcon/SvgIcon.test.js b/packages/material-ui/src/SvgIcon/SvgIcon.test.js
--- a/packages/material-ui/src/SvgIcon/SvgIcon.test.js
+++ b/packages/material-ui/src/SvgIcon/SvgIcon.test.js
@@ -2,20 +2,26 @@
import React from 'react';
import { assert } from 'chai';
-import { createS... | SVG Icons: Unable to Supply <defs> Element
Although the SVG font icons support a `children` prop, I am unable to pass in a `defs` element to define a custom linear gradient. I.e.:
```jsx
import Stars from 'material-ui/svg-icons/action/stars';
<Stars
children={
<defs... | @joncursi The pre-built icons don't currently support children, as the path for the icon itself is the `SvgIcon` children.
```jsx
import React from 'react';
import pure from 'recompose/pure';
import SvgIcon from '../../SvgIcon';
let ActionStars = (props) => (
<SvgIcon {...props}>
<path d="M11.99 2C6.47... | 2018-06-26 21:45:58+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/SvgIcon/SvgIcon.test.js-><SvgIcon /> prop: color should render with the error color', 'packages/material-ui/src/SvgIcon/SvgIcon.test.js-><SvgIcon /> prop: color should render with the primary class', 'packages/material-ui/src/SvgIcon/SvgIcon.test.js-><SvgIcon /> prop: color should render with... | ['packages/material-ui/src/SvgIcon/SvgIcon.test.js-><SvgIcon /> prop: component should render component before path'] | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/SvgIcon/SvgIcon.test.js --reporter /testbed/custom-reporter.js --exit | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["packages/material-ui/src/SvgIcon/SvgIcon.js->program->function_declaration:SvgIcon", "docs/src/pages/style/icons/SvgIcons.js->program->function_declaration:SvgIcons"] |
mui/material-ui | 12,236 | mui__material-ui-12236 | ['12216'] | 18aa6293ad8b67dc8a323db19117c93efa966c7c | diff --git a/packages/material-ui/src/styles/withTheme.d.ts b/packages/material-ui/src/styles/withTheme.d.ts
--- a/packages/material-ui/src/styles/withTheme.d.ts
+++ b/packages/material-ui/src/styles/withTheme.d.ts
@@ -3,6 +3,7 @@ import { ConsistentWith } from '..';
export interface WithTheme {
theme: Theme;
+ ... | diff --git a/packages/material-ui/src/styles/withTheme.test.js b/packages/material-ui/src/styles/withTheme.test.js
--- a/packages/material-ui/src/styles/withTheme.test.js
+++ b/packages/material-ui/src/styles/withTheme.test.js
@@ -1,11 +1,18 @@
import React from 'react';
import { assert } from 'chai';
+import { spy }... | [withWidth] Add innerRef property
<!--- Provide a general summary of the feature in the Title above -->
<!--
Thank you very much for contributing to Material-UI by creating an issue! ❤️
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this... | @itelo You can use the [RootRef](https://material-ui.com/api/root-ref/) component for this use case. Regarding the `innerRef` property. My hope is that it can be legacy with #10825.
The `withTheme` higher-order component could take advantage of it too.
@oliviertassinari can you give an example of how to use the RootRef... | 2018-07-22 15:42:00+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/withWidth/withWidth.test.js->withWidth server side rendering should not render the children as the width is unknown', 'packages/material-ui/src/withWidth/withWidth.test.js->withWidth option: withTheme should forward the theme', 'packages/material-ui/src/withWidth/withWidth.test.js->withWidth ... | ['packages/material-ui/src/withWidth/withWidth.test.js->withWidth prop: innerRef should provide a ref on the inner component', 'packages/material-ui/src/styles/withTheme.test.js->withTheme prop: innerRef should provide a ref on the inner component'] | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/withWidth/withWidth.test.js packages/material-ui/src/styles/withTheme.test.js --reporter /testbed/custom-reporter.js --exit | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["packages/material-ui/src/withWidth/withWidth.js->program->class_declaration:WithWidth->method_definition:render", "packages/material-ui/src/styles/withTheme.js->program->class_declaration:WithTheme->method_definition:render"] |
mui/material-ui | 12,303 | mui__material-ui-12303 | ['11618'] | f432f8a733514b3fa83718102d78f1311cb19de0 | diff --git a/docs/src/pages/demos/selection-controls/CheckboxesGroup.js b/docs/src/pages/demos/selection-controls/CheckboxesGroup.js
--- a/docs/src/pages/demos/selection-controls/CheckboxesGroup.js
+++ b/docs/src/pages/demos/selection-controls/CheckboxesGroup.js
@@ -1,4 +1,6 @@
import React from 'react';
+import PropT... | diff --git a/packages/material-ui/src/FormControlLabel/FormControlLabel.test.js b/packages/material-ui/src/FormControlLabel/FormControlLabel.test.js
--- a/packages/material-ui/src/FormControlLabel/FormControlLabel.test.js
+++ b/packages/material-ui/src/FormControlLabel/FormControlLabel.test.js
@@ -55,6 +55,15 @@ descri... | How to position Switch label to the left of the switch?
- [x] This is a v1.x issue (v0.x is no longer maintained).
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
[The examples here](https://material-ui.com/demos/selectio... | `FormControlLabel` wasn't designed with this use case in mind. You would need to write custom CSS to get this behavior.
I have added the `waiting for users upvotes` tag. I'm closing the issue as I'm not sure people are looking for such abstraction. So please upvote this issue if you are. We will prioritize our effort b... | 2018-07-27 17:03:10+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/FormControlLabel/FormControlLabel.test.js-><FormControlLabel /> with muiFormControl context disabled should have the disabled class', 'packages/material-ui/src/FormControlLabel/FormControlLabel.test.js-><FormControlLabel /> prop: disabled should disable everything 1', 'packages/material-ui/sr... | ['packages/material-ui/src/FormControlLabel/FormControlLabel.test.js-><FormControlLabel /> prop: labelPlacement should disable have the `start` class'] | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/FormControlLabel/FormControlLabel.test.js --reporter /testbed/custom-reporter.js --exit | Feature | false | false | false | true | 3 | 1 | 4 | false | false | ["packages/material-ui/src/FormControlLabel/FormControlLabel.js->program->function_declaration:FormControlLabel", "docs/src/pages/demos/selection-controls/CheckboxesGroup.js->program->class_declaration:CheckboxesGroup", "docs/src/pages/demos/selection-controls/RadioButtonsGroup.js->program->class_declaration:RadioButto... |
mui/material-ui | 12,406 | mui__material-ui-12406 | ['12247'] | cbc6828c93df70b897366f0c6d0b17da681d1b89 | diff --git a/.size-limit.js b/.size-limit.js
--- a/.size-limit.js
+++ b/.size-limit.js
@@ -27,7 +27,7 @@ module.exports = [
name: 'The size of all the modules of material-ui.',
webpack: true,
path: 'packages/material-ui/build/index.js',
- limit: '95.7 KB',
+ limit: '95.8 KB',
},
{
name: ... | diff --git a/packages/material-ui/src/Input/Textarea.test.js b/packages/material-ui/src/Input/Textarea.test.js
--- a/packages/material-ui/src/Input/Textarea.test.js
+++ b/packages/material-ui/src/Input/Textarea.test.js
@@ -28,7 +28,7 @@ describe('<Textarea />', () => {
let mount;
before(() => {
- shallow = c... | 1.4.1 Texfield multiline jest snapshot tests broken
When upgrading to 1.4.1 all our snapshot tests including a `<TextField multiline />` are broken due to `Error: Uncaught [TypeError: Cannot read property 'scrollHeight' of null]`.
We had similar issues in the past which were related to refs + react-test-renderer, but ... | @sakulstra I have removed some defensive checks that looks very much like dead code to me in #12238 and #12239. I doubt the root of the issue is on Material-UI. The component can be mounted just fine on a browser environment.
I am having this issue as well. The issue is caused by the `syncHeightWithShadow` function ins... | 2018-08-04 01:10:21+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/Input/Textarea.test.js-><Textarea /> height behavior should respect the rowsMax property', 'packages/material-ui/src/Input/Textarea.test.js-><Textarea /> height behavior should update the height when the value change', 'packages/material-ui/src/Input/Textarea.test.js-><Textarea /> prop: texta... | ['packages/material-ui/src/Input/Textarea.test.js-><Textarea /> should change its height when the height of its shadows changes', 'packages/material-ui/src/Input/Textarea.test.js-><Textarea /> prop: onChange should be call the callback', 'packages/material-ui/src/Input/Textarea.test.js-><Textarea /> should render 3 tex... | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/Input/Textarea.test.js --reporter /testbed/custom-reporter.js --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["packages/material-ui/src/Input/Textarea.js->program->class_declaration:Textarea->method_definition:syncHeightWithShadow"] |
mui/material-ui | 12,968 | mui__material-ui-12968 | ['12965'] | ea462822d9881478efcf08829a60e3ff818f5d2d | diff --git a/docs/src/pages/demos/text-fields/ComposedTextField.js b/docs/src/pages/demos/text-fields/ComposedTextField.js
--- a/docs/src/pages/demos/text-fields/ComposedTextField.js
+++ b/docs/src/pages/demos/text-fields/ComposedTextField.js
@@ -1,10 +1,13 @@
import React from 'react';
+import ReactDOM from 'react-do... | diff --git a/packages/material-ui/src/OutlinedInput/NotchedOutline.test.js b/packages/material-ui/src/OutlinedInput/NotchedOutline.test.js
--- a/packages/material-ui/src/OutlinedInput/NotchedOutline.test.js
+++ b/packages/material-ui/src/OutlinedInput/NotchedOutline.test.js
@@ -48,7 +48,7 @@ describe('<NotchedOutline /... | Demo do not explain that FilledInput and OutlinedInput are needed instead of Input when you want Filled/Outlined textfields
- [x] This is not a v0.x issue. <!-- (v0.x is no longer maintained) -->
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this ... | There is a `FilledInput` and `OutlinedInput` for this use case. We should update the demos in the documentation. | 2018-09-23 09:41:32+00:00 | TypeScript | FROM polybench_typescript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util
RUN echo 'var mocha = require("mocha");' > cust... | ['packages/material-ui/src/OutlinedInput/NotchedOutline.test.js-><NotchedOutline /> should be a fieldset', 'packages/material-ui/src/OutlinedInput/NotchedOutline.test.js-><NotchedOutline /> should pass props'] | ['packages/material-ui/src/OutlinedInput/NotchedOutline.test.js-><NotchedOutline /> should set alignment rtl'] | [] | . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/OutlinedInput/NotchedOutline.test.js --reporter /testbed/custom-reporter.js --exit | Bug Fix | false | false | false | true | 4 | 1 | 5 | false | false | ["packages/material-ui/src/TextField/TextField.js->program->class_declaration:TextField->method_definition:render", "docs/src/pages/demos/text-fields/ComposedTextField.js->program->class_declaration:ComposedTextField->method_definition:render", "packages/material-ui/src/OutlinedInput/NotchedOutline.js->program->functio... |
Subsets and Splits
Unique Repositories in Test
Lists unique repository names from the dataset, providing a basic overview of the repositories present.
Filtered RocketMQ Offset Issues
The query filters specific entries based on multiple criteria, providing a basic overview of relevant issues but without deeper analysis or insights.
Filtered Test Cases for Gson 2.10
The query filters specific entries based on detailed conditions, providing limited insight but useful for finding exact matches in the dataset.