repo
stringclasses
21 values
pull_number
float64
88
192k
instance_id
stringlengths
16
34
issue_numbers
stringlengths
6
20
base_commit
stringlengths
40
40
patch
stringlengths
266
270k
test_patch
stringlengths
350
165k
problem_statement
stringlengths
38
24k
hints_text
stringlengths
1
33.2k
created_at
stringdate
2016-01-11 17:37:29
2024-10-18 14:52:41
language
stringclasses
4 values
Dockerfile
stringlengths
100
3.03k
P2P
stringlengths
2
216k
F2P
stringlengths
11
10.5k
F2F
stringclasses
26 values
test_command
stringlengths
27
5.49k
task_category
stringclasses
3 values
is_no_nodes
bool
2 classes
is_func_only
bool
2 classes
is_class_only
bool
2 classes
is_mixed
bool
2 classes
num_func_changes
int64
0
238
num_class_changes
int64
0
70
num_nodes
int64
0
264
is_single_func
bool
2 classes
is_single_class
bool
2 classes
modified_nodes
stringlengths
2
42.2k
prettier/prettier
6,604
prettier__prettier-6604
['6603']
affa24ce764bd14ac087abeef0603012f5c635d6
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index b6e4f385e5e0..6db041af81cb 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -742,6 +742,29 @@ Previously, the flag was not applied on html attributes. <div class='a-class-name'></div> ``` +#### TypeScript: Fix incorrectly remo...
diff --git a/tests/typescript_conditional_types/__snapshots__/jsfmt.spec.js.snap b/tests/typescript_conditional_types/__snapshots__/jsfmt.spec.js.snap index 6bf4a520de1f..34f70876e92b 100644 --- a/tests/typescript_conditional_types/__snapshots__/jsfmt.spec.js.snap +++ b/tests/typescript_conditional_types/__snapshots__/...
[TypeScript] Prettier incorrectly removes double parentheses around types **Prettier 1.18.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEB6VACAwhATruMGAHVgE8AHODAFQEYMBeDABgzgA94oATAZwwAKBp278MAJgwYA-BgDMGJBgAsASlkYArEowA2UugwAhAK4BzUjErV6AfQBGFpq3ZcE4wcLdiBUzYrK6hpyOsoGUIaYOPiEJORUtFLMgmyiHgI...
null
2019-10-04 11:17:15+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/typescript_intersection/jsfmt.spec.js->intersection-parens.ts']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/typescript_intersection/__snapshots__/jsfmt.spec.js.snap tests/typescript_union/__snapshots__/jsfmt.spec.js.snap tests/typescript_union/inlining.ts tests/typescript_intersection/jsfmt.spec.js tests/typescript_keyof/key...
Bug Fix
false
true
false
false
1
0
1
true
false
["src/language-js/needs-parens.js->program->function_declaration:needsParens"]
prettier/prettier
5,432
prettier__prettier-5432
['5431']
d4c248bb0b404952eceba84615144b618be5e04d
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js index 98e05a4c573a..b774c475433e 100644 --- a/src/language-js/printer-estree.js +++ b/src/language-js/printer-estree.js @@ -1203,7 +1203,9 @@ function printPathNoParens(path, options, print, args) { concat([ ...
diff --git a/tests/flow/declare_export/__snapshots__/jsfmt.spec.js.snap b/tests/flow/declare_export/__snapshots__/jsfmt.spec.js.snap index f2bb4d339e7a..7fd252daa7cf 100644 --- a/tests/flow/declare_export/__snapshots__/jsfmt.spec.js.snap +++ b/tests/flow/declare_export/__snapshots__/jsfmt.spec.js.snap @@ -182,7 +182,9 ...
Extra indentation in generic parameter **Prettier 1.15.1** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEcAeAHCAnGACAS1jmwDMBDMOPAMQggB0o8914oATAZzwCFzsAHiYsWAZQgBbOABloAcwAqATwxwANCNGKIvbHHIBrGUQ1aAfHmBbSBOABsOSPFACukgEYkA3EwC+IOogEBgwBNBcyKAC2BAA7gAKAgiRKOQAbhAEHIEgHtiUhnAwYhiURPLIMNiuGiAAFjCS9...
Blames to 1234ceb1d627f9fb535481b3a169cab46f45732e / #5244 which I guess introduces a double indentation here. cc @aquibm
2018-11-10 04:09:54+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/interface/jsfmt.spec.js->break.js - typescript-verify']
['/testbed/tests/interface/jsfmt.spec.js->break.js - flow-verify', '/testbed/tests/interface/jsfmt.spec.js->module.js - flow-verify', '/testbed/tests/interface/jsfmt.spec.js->module.js - typescript-verify']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/interface/__snapshots__/jsfmt.spec.js.snap tests/flow_method/__snapshots__/jsfmt.spec.js.snap tests/flow/poly_overload/decls/__snapshots__/jsfmt.spec.js.snap tests/flow/interface/__snapshots__/jsfmt.spec.js.snap tests/...
Bug Fix
false
true
false
false
2
0
2
false
false
["src/language-js/printer-estree.js->program->function_declaration:identity", "src/language-js/printer-estree.js->program->function_declaration:printPathNoParens"]
prettier/prettier
5,083
prettier__prettier-5083
['5082']
b020a5606f007956f12f4cce483e74819a1ae689
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js index 9ee0c68983c0..4e7f9476af38 100644 --- a/src/language-js/printer-estree.js +++ b/src/language-js/printer-estree.js @@ -5529,6 +5529,13 @@ function classChildNeedsASIProtection(node) { return; } + if ( + node.static || ...
diff --git a/tests/no-semi-typescript/__snapshots__/jsfmt.spec.js.snap b/tests/no-semi-typescript/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..b75f2ba1ffad --- /dev/null +++ b/tests/no-semi-typescript/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,51 @@ +// Jest Snapshot v1, https://goo.gl/fbA...
--no-semi got ignored on typescript indexed class property annotation **Prettier 1.14.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuc0DOMAEBrAQgVwDNC4AnTAXkwGUBPAWwCMIAbACgHJGiTSOBKADpRIUDDgDyxNHCxU6TVpwjTZA4cLAsAhmjSYASnG0ATMpmDDMmAA6kAlgDdt8TAG08PMgF0kmAsTmAPRBmAA8ALQRmAAWZHBWtg7Orh5ShDIwvph...
Minimal repro: **Prettier 1.14.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAucAbAhgZ0wAgGIQQ7AA6UOOARugE5I4CCZFADjQJYBu68OA2tQBeAXTIBfEABoQEFjHbRMyULRoQA7gAVaCJSnScI7ACZSQlGujABrODADKLK+ygBzZDBoBXONJeY4GhhNS1cAW3RkADN0VADpACtMAA8AIUsbO3t0MLgAGRc4aNj4kCcaAJpkEBgATxY4TDAOOTM2FxgAdRMYAAtkAA4AB...
2018-09-12 01:47:07+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/no-semi-typescript/jsfmt.spec.js->no-semi.ts - typescript-verify']
['/testbed/tests/no-semi-typescript/jsfmt.spec.js->no-semi.ts - typescript-verify']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/no-semi-typescript/__snapshots__/jsfmt.spec.js.snap tests/no-semi-typescript/no-semi.ts tests/no-semi-typescript/jsfmt.spec.js --json
Bug Fix
false
true
false
false
1
0
1
true
false
["src/language-js/printer-estree.js->program->function_declaration:classChildNeedsASIProtection"]
prettier/prettier
5,015
prettier__prettier-5015
['5009']
58d34bb8447695f257ca307c8670d43277ddb6e3
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js index 025dae381ad0..53bc85efe050 100644 --- a/src/language-js/printer-estree.js +++ b/src/language-js/printer-estree.js @@ -5204,7 +5204,9 @@ function printBinaryishExpressions( } const shouldInline = shouldInlineLogicalExpre...
diff --git a/tests/comments/__snapshots__/jsfmt.spec.js.snap b/tests/comments/__snapshots__/jsfmt.spec.js.snap index 5e6bdde5118e..d094b02bede0 100644 --- a/tests/comments/__snapshots__/jsfmt.spec.js.snap +++ b/tests/comments/__snapshots__/jsfmt.spec.js.snap @@ -35,6 +35,153 @@ const foo = { `; +exports[`binary-ex...
Pipe operator with comment problem **Prettier 1.14.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAdKcAeAHCAnGAAgBM4AzAQwFcAbIgYQgFtcNZ1DCB6LwgHwB8hAEZ4KUMAAsAFNjwRsAUQCO0gOQBLAM4AlOBWIBPNQBpClGlrgBKM3gSk8AOQgxJGqAHNrHfkMhQGGAw0r6cYPYU8ADKMHhUwVT2xNFwNHDB+NLAYZyE2noGhia5AL62vtYA3OggJiAKMBrQWsi...
Thanks for opening an issue @sylvainbaronnet! Can you fill out the “expected behavior” section of the issue? Sure, I did it Hey @j-f1 , I'd love to start contributing to Prettier :) And this sounds like a quite doable task, so I'd like to take on this! However, it'd be quite cool to have some help from a maintainer he...
2018-08-24 14:24:52+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/comments_pipeline_own_line/jsfmt.spec.js->pipeline_own_line.js - babylon-verify']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/comments/__snapshots__/jsfmt.spec.js.snap tests/comments_pipeline_own_line/__snapshots__/jsfmt.spec.js.snap tests/comments_pipeline_own_line/jsfmt.spec.js tests/comments_pipeline_own_line/pipeline_own_line.js tests/com...
Bug Fix
false
true
false
false
1
0
1
true
false
["src/language-js/printer-estree.js->program->function_declaration:printBinaryishExpressions"]
prettier/prettier
4,667
prettier__prettier-4667
['4446']
4a16319470cfb929799783118ad78afcf99461d2
diff --git a/src/config/resolve-config.js b/src/config/resolve-config.js index 229caf3d5fdd..c8f0f43433ab 100644 --- a/src/config/resolve-config.js +++ b/src/config/resolve-config.js @@ -48,6 +48,17 @@ function _resolveConfig(filePath, opts, sync) { mergeOverrides(Object.assign({}, result), filePath) ); +...
diff --git a/tests_integration/__tests__/config-resolution.js b/tests_integration/__tests__/config-resolution.js index 25a610e533a9..d78a55eb84ae 100644 --- a/tests_integration/__tests__/config-resolution.js +++ b/tests_integration/__tests__/config-resolution.js @@ -226,3 +226,12 @@ test("API resolveConfig.sync removes...
Support relative paths for plugin and pluginSearchDir in config files Context: https://github.com/prettier/prettier/pull/4192#discussion_r186809767
null
2018-06-11 16:20:55+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests_integration/__tests__/config-resolution.js->resolves configuration from external files and overrides by extname (stderr)', '/testbed/tests_integration/__tests__/config-resolution.js->CLI overrides take precedence (stdout)', '/testbed/tests_integration/__tests__/config-resolution.js->API resolveConfig.s...
['/testbed/tests_integration/__tests__/config-resolution.js->API resolveConfig resolves relative path values based on config filepath']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests_integration/cli/config/resolve-relative/.prettierrc tests_integration/__tests__/config-resolution.js --json
Feature
false
true
false
false
1
0
1
true
false
["src/config/resolve-config.js->program->function_declaration:_resolveConfig"]
prettier/prettier
3,903
prettier__prettier-3903
['3847', '7028']
00d2299bcec94f558810dc5ca8fee358d345cefe
diff --git a/changelog_unreleased/javascript/pr-3903.md b/changelog_unreleased/javascript/pr-3903.md new file mode 100644 index 000000000000..0c3a33437355 --- /dev/null +++ b/changelog_unreleased/javascript/pr-3903.md @@ -0,0 +1,48 @@ +#### Always add a space after the `function` keyword ([#3903](https://github.com/pre...
diff --git a/tests/async/__snapshots__/jsfmt.spec.js.snap b/tests/async/__snapshots__/jsfmt.spec.js.snap index 8d17a0847eef..7c8419d7ac54 100644 --- a/tests/async/__snapshots__/jsfmt.spec.js.snap +++ b/tests/async/__snapshots__/jsfmt.spec.js.snap @@ -18,13 +18,13 @@ class X { } =====================================...
Space after function keyword in anonymous functions **NOTE: This issue is raised due to confusion in #1139.** This issue is _only_ about _anonymous_ functions: ```js const identity = function (value) { // ^ space here return value; } ``` (Prettier currently does _not_ put a space t...
why not provide a `--space-before-function-paren` option @allex please read https://prettier.io/docs/en/option-philosophy.html +1 for space after `function` keyword. [Crockford supports this](https://crockford.com/javascript/code.html): > If a function literal is anonymous, there should be one space between the word...
2018-02-06 11:39:51+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/generator/jsfmt.spec.js->anonymous.js - flow-verify', '/testbed/tests/generator/jsfmt.spec.js->anonymous.js - typescript-verify']
['/testbed/tests/generator/jsfmt.spec.js->anonymous.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/preserve_line/__snapshots__/jsfmt.spec.js.snap tests/yield/__snapshots__/jsfmt.spec.js.snap tests/flow/facebookisms/__snapshots__/jsfmt.spec.js.snap tests/flow/indexer/__snapshots__/jsfmt.spec.js.snap tests/flow/get-de...
Feature
false
true
false
false
2
0
2
false
false
["src/language-js/printer-estree.js->program->function_declaration:printFunctionDeclaration", "src/language-js/printer-estree.js->program->function_declaration:printPathNoParens"]
prettier/prettier
3,775
prettier__prettier-3775
['3615']
105914e45ce7557df34964c4e002ffa3dc97764e
diff --git a/package.json b/package.json index f2bf29b947b4..91a2b5bc5970 100644 --- a/package.json +++ b/package.json @@ -36,6 +36,7 @@ "graphql": "0.12.3", "ignore": "3.3.7", "jest-docblock": "21.3.0-beta.11", + "json-stable-stringify": "1.0.1", "leven": "2.1.0", "mem": "1.1.0", "mini...
diff --git a/tests_integration/__tests__/__snapshots__/plugin-options.js.snap b/tests_integration/__tests__/__snapshots__/plugin-options.js.snap new file mode 100644 index 000000000000..ba4e3b5d6ca0 --- /dev/null +++ b/tests_integration/__tests__/__snapshots__/plugin-options.js.snap @@ -0,0 +1,39 @@ +// Jest Snapshot v...
Support options in external plugins #3433 moved the definition of options to our internal parsers but there's still a bit of work to support external plugins defining new options: Use cases: - [x] This should include the options contributed by plugins: ```bash prettier --plugin @prettier/plugin-python --he...
I don't believe #3433 did that. I believe it just exposed (via some code duplication) plugin options in `getSupportInfo()`. At the moment, all options other than the ones in `cli/constant` get dropped: https://github.com/prettier/prettier/blob/6c0dd745185bfd20bb3b554dd591b8ef0b480748/src/cli/util.js#L628-L642 In ...
2018-01-20 07:33:47+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests_integration/__tests__/plugin-options.js->external options from config file should work (write)', '/testbed/tests_integration/__tests__/plugin-options.js->external options from config file should work (status)', '/testbed/tests_integration/__tests__/plugin-options.js->show detailed external option with ...
['/testbed/tests_integration/__tests__/plugin-options.js->external options from config file should work (stderr)', '/testbed/tests_integration/__tests__/plugin-options.js->external options from CLI should work (stderr)', '/testbed/tests_integration/__tests__/plugin-options.js->show detailed external option with `--help...
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests_integration/__tests__/__snapshots__/support-info.js.snap tests_integration/plugins/options/config.json tests_integration/runPrettier.js tests_integration/__tests__/early-exit.js tests_integration/__tests__/plugin-optio...
Feature
false
true
false
false
40
0
40
false
false
["src/cli/util.js->program->function_declaration:pushContextPlugins", "src/cli/util.js->program->function_declaration:normalizeContextArgv", "src/cli/util.js->program->function_declaration:createOptionUsage", "src/cli/util.js->program->function_declaration:getOptionsOrDie", "src/cli/util.js->program->function_declarati...
prettier/prettier
3,616
prettier__prettier-3616
['3550']
6c0dd745185bfd20bb3b554dd591b8ef0b480748
diff --git a/src/language-js/printer-estree.js b/src/language-js/printer-estree.js index 09fbf017a517..fd52d8d2caa8 100644 --- a/src/language-js/printer-estree.js +++ b/src/language-js/printer-estree.js @@ -3285,6 +3285,9 @@ function printFunctionParams(path, print, options, expandArg, printTypeParams) { !fun.rest...
diff --git a/tests/flow_function_parentheses/__snapshots__/jsfmt.spec.js.snap b/tests/flow_function_parentheses/__snapshots__/jsfmt.spec.js.snap index f193c2ffba24..995d58e33472 100644 --- a/tests/flow_function_parentheses/__snapshots__/jsfmt.spec.js.snap +++ b/tests/flow_function_parentheses/__snapshots__/jsfmt.spec.j...
Arrow parens are not preserved in `FunctionTypeAnnotation`s when using "always" arrow parens option **Prettier 1.9.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEMCeAHOACAyhAWzgBVMcBebYAHSm2wGdC4YALASygHMlsAKKAFcCAIzgAnAJTZyAPmxDRE2gF8A3LRAAaEBAwx20BslABDceIgB3AArmExlKYA2V02mM7TDGMgBmLgxwOiLip...
Actually, it's just flow, not typescript.
2017-12-31 14:21:24+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/flow_function_parentheses/jsfmt.spec.js->single.js - flow-verify', '/testbed/tests/flow_function_parentheses/jsfmt.spec.js->single.js - babylon-verify', '/testbed/tests/flow_function_parentheses/jsfmt.spec.js->test.js - flow-verify', '/testbed/tests/flow_function_parentheses/jsfmt.spec.js->test.js - ba...
['/testbed/tests/flow_function_parentheses/jsfmt.spec.js->single.js - flow-verify', '/testbed/tests/flow_function_parentheses/jsfmt.spec.js->test.js - flow-verify']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/flow_function_parentheses/jsfmt.spec.js tests/flow_function_parentheses/__snapshots__/jsfmt.spec.js.snap --json
Bug Fix
false
true
false
false
1
0
1
true
false
["src/language-js/printer-estree.js->program->function_declaration:printFunctionParams"]
prettier/prettier
3,405
prettier__prettier-3405
['3402']
e09359d2428bdac40c30cd6a82c92a627d1e1d05
diff --git a/src/multiparser.js b/src/multiparser.js index 70a770cbb234..7476186a7261 100644 --- a/src/multiparser.js +++ b/src/multiparser.js @@ -26,12 +26,11 @@ function printSubtree(path, print, options) { function parseAndPrint(text, partialNextOptions, parentOptions) { const nextOptions = Object.assign({}, par...
diff --git a/tests/multiparser_markdown_js/__snapshots__/jsfmt.spec.js.snap b/tests/multiparser_markdown_js/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..4c94e48eeed8 --- /dev/null +++ b/tests/multiparser_markdown_js/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,30 @@ +// Jest Snapshot v1, htt...
1.9: Trailing comma not adding in code blocks in markdown **Prettier 1.9.0** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEBidACAyhAtnDACzgEMATASygHMAdKegA2YCsBnetvOAMQFcoYGBWgBhEgBsJACnoYMAMwgQANHIwAjEgCc1UeUohbd6rvniEq1AEqkpATwAy0agEEoZABIkK2+3vkzOBhLGgBRCTY4AM1tUgBrADkIAHd6AEoAbiZmehAVEAgAB2Fo...
https://github.com/prettier/prettier/blob/e09359d2428bdac40c30cd6a82c92a627d1e1d05/src/multiparser.js#L32 I think it's using the wrong object here @lydell (should fall back to parent options)
2017-12-05 12:29:08+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/multiparser_markdown_js/jsfmt.spec.js->trailing-comma.md - markdown-verify']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/multiparser_markdown_js/__snapshots__/jsfmt.spec.js.snap tests/multiparser_markdown_js/trailing-comma.md tests/multiparser_markdown_js/jsfmt.spec.js --json
Bug Fix
false
true
false
false
1
0
1
true
false
["src/multiparser.js->program->function_declaration:parseAndPrint"]
prettier/prettier
3,382
prettier__prettier-3382
['3351']
d80728b5fffd7d0e970b90444c41c18eb2798a6a
diff --git a/src/comments.js b/src/comments.js index bd1cbf83a5cc..260b0a17de08 100644 --- a/src/comments.js +++ b/src/comments.js @@ -638,6 +638,9 @@ function handleMethodNameComments(text, enclosingNode, precedingNode, comment) { enclosingNode && precedingNode.type === "Decorator" && (enclosingNode.typ...
diff --git a/tests/decorator_comments/__snapshots__/jsfmt.spec.js.snap b/tests/decorator_comments/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..de47bc62fbac --- /dev/null +++ b/tests/decorator_comments/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,16 @@ +// Jest Snapshot v1, https://goo.gl/fbA...
Typescript: decorator + readonly + comment leads to un-compilable code <!-- BUGGY OR UGLY? Please use this template. Tip! Don't write this stuff manually. 1. Go to https://prettier.io/playground 2. Paste your code and set options 3. Press the "Report issue" button in the lower right --> **Prettier 1.8.2**...
Same thing for flow, too. **Prettier 1.8.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAucAbAhgZ0wAgMoQC2cMAFgJZQDmOwO9DjT9AOlPQAICCUUEM6eMQAUASmYTmbegHoZAFQDyAEUU4A7uVSoc5GDgBGAJzjoA1pMbScmATHJgcAByMQncIzACeSHFyNG6F4APLZGlFQAfGwAvtZsIAA0IG720JjIoFgwyABm6KiYcMnG6GBmJHhOZRHIMEYArsUgACYQYHkFRcm...
2017-12-03 02:50:15+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/decorator_comments/jsfmt.spec.js->comments.js - typescript-verify']
['/testbed/tests/decorator_comments/jsfmt.spec.js->comments.js - babylon-verify']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/decorator_comments/__snapshots__/jsfmt.spec.js.snap tests/typescript_decorators/__snapshots__/jsfmt.spec.js.snap tests/decorator_comments/comments.js tests/typescript_decorators/decorators-comments.js tests/decorator_c...
Bug Fix
false
true
false
false
1
0
1
true
false
["src/comments.js->program->function_declaration:handleMethodNameComments"]
prettier/prettier
871
prettier__prettier-871
['863']
205458a8d12ab39a8ad0bb0e815e017481108f2e
diff --git a/src/printer.js b/src/printer.js index f21327d701c2..2b60cf1732e5 100644 --- a/src/printer.js +++ b/src/printer.js @@ -187,18 +187,12 @@ function genericPrintNoParens(path, options, print) { case "ParenthesizedExpression": return concat(["(", path.call(print, "expression"), ")"]); case "Ass...
diff --git a/tests/assignment/__snapshots__/jsfmt.spec.js.snap b/tests/assignment/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..69f93fe46867 --- /dev/null +++ b/tests/assignment/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,22 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`binaryis...
Suboptimal line-breaking with complex parenthesized expressions See the attached screenshots. It'd be nice if the parenthesized expressions were treated like a chunk unless it broke some other rule. At evaluation time we'd need some way of recursively unchunking parenthesized expressions until all rules pass. ![a](h...
prettier never puts \n after `=` today but there are cases like this one where it would be really useful for readability. Another related issue: https://github.com/prettier/prettier/issues/866
2017-03-03 18:37:52+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/assignment/jsfmt.spec.js->binaryish.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/binary-expressions/__snapshots__/jsfmt.spec.js.snap tests/assignment_comments/__snapshots__/jsfmt.spec.js.snap tests/assignment/jsfmt.spec.js tests/assignment/__snapshots__/jsfmt.spec.js.snap tests/assignment/binaryish...
Refactoring
false
true
false
false
2
0
2
false
false
["src/printer.js->program->function_declaration:genericPrintNoParens", "src/printer.js->program->function_declaration:printAssignment"]
prettier/prettier
842
prettier__prettier-842
['159']
205458a8d12ab39a8ad0bb0e815e017481108f2e
diff --git a/src/printer.js b/src/printer.js index f21327d701c2..aeb4e6785241 100644 --- a/src/printer.js +++ b/src/printer.js @@ -631,20 +631,29 @@ function genericPrintNoParens(path, options, print) { return concat(parts); case "CallExpression": { - // We detect calls on member lookups and possibly...
diff --git a/tests/it/__snapshots__/jsfmt.spec.js.snap b/tests/it/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..c04167500a4d --- /dev/null +++ b/tests/it/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,81 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`it.js 1`] = ` +"// Shouldn't bre...
Custom testing frameworks style Is there a way to support long strings for test frameworks? Currently the following code: ```js describe('my test suite', () => { it('does something really long and complicated so I have to write a very long name for the test', () => { console.log('hello!'); }); ...
> …and I’m not sure ( , ) => { ... } is valid JavaScript, but maybe I’m wrong? There's a bug about this already (sorry, not sure which one, I'm mainly following PRs right now) I'm open to this if other people run into this as well. I'd like to get at least a few people 👍 these patterns so we don't implement a t...
2017-03-01 17:35:02+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/it/jsfmt.spec.js->it.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/it/jsfmt.spec.js tests/it/it.js tests/it/__snapshots__/jsfmt.spec.js.snap --json
Feature
false
true
false
false
1
0
1
true
false
["src/printer.js->program->function_declaration:genericPrintNoParens"]
prettier/prettier
661
prettier__prettier-661
['654']
ec6ffbe063a19ae05f211bd26e7fcfcf33ba85bc
diff --git a/README.md b/README.md index 39fd19e3f7ef..d408e978661f 100644 --- a/README.md +++ b/README.md @@ -148,6 +148,10 @@ prettier.format(source, { // Controls the printing of spaces inside object literals bracketSpacing: true, + // If true, puts the `>` of a multi-line jsx element at the end of + // th...
diff --git a/tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap b/tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..0d19c4878476 --- /dev/null +++ b/tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,48 @@ +exports[`test last_line.js 1`] = ` +"<SomeHighlyConfig...
JSX opening element closing tag gets moved to a new line If you have a line of JSX that is over printWidth, something like: ```js const El = (<span width="1" height="2">x</span>) ``` For the sake of reproducing the issue assume the printWidth is set to 20 but this reproduces anytime the line needs to break for ...
This is intentional, but there have been [discussions](https://github.com/jlongster/prettier/issues/467#issuecomment-275230393) before about it. There's a PR where we decided to do it but I can't find it. The second code block in my opinion is a log harder to read. The attributes line up perfectly with `x` and it's ...
2017-02-11 04:41:51+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/jsx_last_line/jsfmt.spec.js->last_line.js']
['/testbed/tests/jsx_last_line/jsfmt.spec.js->last_line.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/jsx_last_line/last_line.js tests/jsx_last_line/__snapshots__/jsfmt.spec.js.snap tests/jsx_last_line/jsfmt.spec.js --json
Feature
false
true
false
false
1
0
1
true
false
["src/printer.js->program->function_declaration:genericPrintNoParens"]
prettier/prettier
602
prettier__prettier-602
['536']
6b74de3716aeeef14171efc980ba44cccd1c9bc4
diff --git a/src/fast-path.js b/src/fast-path.js index 53ef717c2742..d4dbca3a3b9d 100644 --- a/src/fast-path.js +++ b/src/fast-path.js @@ -497,6 +497,11 @@ FPp.needsParens = function(assumeExpressionContext) { return name === "object" && parent.object === node; } + case "StringLiteral": + if (...
diff --git a/tests/expression_statement/__snapshots__/jsfmt.spec.js.snap b/tests/expression_statement/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..54a281bd1d24 --- /dev/null +++ b/tests/expression_statement/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,18 @@ +exports[`test no_regression.js 1`...
Changes ExpressionStatement into Directive Input: ```js ("use strict") ``` Output: ```js "use strict"; ``` ... which has changed the meaning of the code. Expected: ```js ("use strict"); ``` Found by reading [shift-codegen-js' source code](https://github.com/shapesecurity/shift-codegen-js/blob...
null
2017-02-04 16:31:25+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
['/testbed/tests/expression_statement/jsfmt.spec.js->no_regression.js']
['/testbed/tests/expression_statement/jsfmt.spec.js->use_strict.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/expression_statement/use_strict.js tests/expression_statement/jsfmt.spec.js tests/expression_statement/__snapshots__/jsfmt.spec.js.snap tests/expression_statement/no_regression.js --json
Bug Fix
true
false
false
false
0
0
0
false
false
[]
prettier/prettier
418
prettier__prettier-418
['411']
2a0e7b575caee6f25aa9ee43189ca427e5361003
diff --git a/src/fast-path.js b/src/fast-path.js index 0220b0ac2be4..1f9d015409aa 100644 --- a/src/fast-path.js +++ b/src/fast-path.js @@ -323,8 +323,13 @@ FPp.needsParens = function(assumeExpressionContext) { return true; } - case "AwaitExpression": case "YieldExpression": + if (parent...
diff --git a/tests/yield/__snapshots__/jsfmt.spec.js.snap b/tests/yield/__snapshots__/jsfmt.spec.js.snap new file mode 100644 index 000000000000..68d2aaeb07b6 --- /dev/null +++ b/tests/yield/__snapshots__/jsfmt.spec.js.snap @@ -0,0 +1,16 @@ +exports[`test conditional.js 1`] = ` +"function* f() { + a = (yield) ? 1 : 1;...
Missing parenthesis around yield in conditional ```js function* f() { a = (yield) ? null : null; } ``` outputs ```js function* f() { a = yield ? null : null; } ``` which is invalid https://jlongster.github.io/prettier/#%7B%22content%22%3A%22function*%20f()%20%7B%5Cn%20%20a%20%3D%20(yield)%20%3F%...
null
2017-01-23 02:32:29+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/yield/jsfmt.spec.js->conditional.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/yield/conditional.js tests/yield/__snapshots__/jsfmt.spec.js.snap tests/yield/jsfmt.spec.js --json
Bug Fix
true
false
false
false
0
0
0
false
false
[]
prettier/prettier
300
prettier__prettier-300
['222']
51991448782f217fc72d9a9e6a0c6e966330be5e
diff --git a/src/pp.js b/src/pp.js index df76dae4e0e3..f3874d6880b9 100644 --- a/src/pp.js +++ b/src/pp.js @@ -324,19 +324,17 @@ function print(w, doc) { } case MODE_BREAK: - if (out.length > 0) { - const lastString = out[out.length - 1]; - - if (...
diff --git a/tests/disjoint-union-perf/__snapshots__/jsfmt.spec.js.snap b/tests/disjoint-union-perf/__snapshots__/jsfmt.spec.js.snap index 70682e9d2791..b7e4583e3b23 100644 --- a/tests/disjoint-union-perf/__snapshots__/jsfmt.spec.js.snap +++ b/tests/disjoint-union-perf/__snapshots__/jsfmt.spec.js.snap @@ -84,7 +84,7 @@...
Trailing whitespace ```js export type Result<T, V> =[ ] // trailing whitespace | { kind: "not-test-editor1" } | { kind: "not-test-editor2" }; ``` https://jlongster.github.io/prettier/#%7B%22content%22%3A%22export%20type%20Result%3CT%2C%20V%3E%20%3D%5Cn%20%20%7C%20%7B%20kind%3A%20%5C%22not-test-editor1%5C%22%...
null
2017-01-18 19:08:53+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi RUN . $NVM_DIR/nvm.sh && nvm alias default 20.16.0 && nvm use default
[]
['/testbed/tests/trailing_whitespace/jsfmt.spec.js->trailing.js']
[]
. /usr/local/nvm/nvm.sh && nvm use 20.16.0 && npm pkg set scripts.lint="echo noop" && yarn test tests/dom/__snapshots__/jsfmt.spec.js.snap tests/trailing_whitespace/trailing.js tests/typeapp_perf/__snapshots__/jsfmt.spec.js.snap tests/trailing_whitespace/jsfmt.spec.js tests/trailing_whitespace/__snapshots__/jsfmt.spec....
Bug Fix
false
true
false
false
1
0
1
true
false
["src/pp.js->program->function_declaration:print"]
serverless/serverless
10,120
serverless__serverless-10120
['9293']
b4ff87dc81286b8123830f20bccfb3aa320e4ccd
diff --git a/lib/plugins/aws/package/compile/events/eventBridge/index.js b/lib/plugins/aws/package/compile/events/eventBridge/index.js index eabd940700a..a4c808e4e64 100644 --- a/lib/plugins/aws/package/compile/events/eventBridge/index.js +++ b/lib/plugins/aws/package/compile/events/eventBridge/index.js @@ -408,7 +408,...
diff --git a/test/unit/lib/plugins/aws/package/compile/events/eventBridge/index.test.js b/test/unit/lib/plugins/aws/package/compile/events/eventBridge/index.test.js index 18e347ff3ff..05efff529bf 100644 --- a/test/unit/lib/plugins/aws/package/compile/events/eventBridge/index.test.js +++ b/test/unit/lib/plugins/aws/pack...
Feature Request: use intrinsic functions in eventbridge detail pattern <!-- ⚠️⚠️ Acknowledge ALL below remarks --> <!-- ⚠️⚠️ Request may not be processed if it doesn't meet outlined criteria --> <!-- ⚠️⚠️ Search existing issues to avoid creating duplicates --> <!-- ⚠️⚠️ Plugin enhancements should be proposed at p...
Hello @DaveLo, thanks for reporting and linking to an article from AWS. I believe it might be a "leftover" from a still supported custom-resource backed support for EventBridge integration. Looking at one of the examples from the article it seems like CF supports intrinsic functions for patterns without issues, which s...
2021-10-20 05:13:34+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['EventBridgeEvents using native CloudFormation when event bus is created as a part of the stack should correctly set State when disabled on a created rule', 'EventBridgeEvents using native CloudFormation when event bus is created as a part of the stack should create a rule that depends on created EventBus', 'EventBrid...
['EventBridgeEvents using native CloudFormation when event bus is created as a part of the stack should correctly set EventPattern on a created rule']
[]
. /usr/local/nvm/nvm.sh && npx mocha test/unit/lib/plugins/aws/package/compile/events/eventBridge/index.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/eventBridge/index.js->program->class_declaration:AwsCompileEventBridgeEvents->method_definition:compileWithCloudFormation"]
serverless/serverless
8,638
serverless__serverless-8638
['6923']
a8be1d1776a26b033d821d70e99ad654a39a4158
diff --git a/docs/providers/aws/guide/deploying.md b/docs/providers/aws/guide/deploying.md index 15a70b8ee00..e36bf60444a 100644 --- a/docs/providers/aws/guide/deploying.md +++ b/docs/providers/aws/guide/deploying.md @@ -78,6 +78,9 @@ The Serverless Framework translates all syntax in `serverless.yml` to a single A -...
diff --git a/test/unit/lib/plugins/aws/package/lib/generateCoreTemplate.test.js b/test/unit/lib/plugins/aws/package/lib/generateCoreTemplate.test.js index a1e7d1ed333..c1383285d34 100644 --- a/test/unit/lib/plugins/aws/package/lib/generateCoreTemplate.test.js +++ b/test/unit/lib/plugins/aws/package/lib/generateCoreTemp...
Deploy fails with error 'An error occurred: ServerlessDeploymentBucketPolicy - The bucket policy already exists on bucket...'' # Bug Report Deploy fails with error 'An error occurred: ServerlessDeploymentBucketPolicy - The bucket policy already exists on bucket...'' ## Description <!-- Please use https://forum.s...
Roll back to version 1.55.1 and everything works fine as before. @webstruck thanks for report. I imagine it's caused because given policy was added manually, when service was deployed with pre 1.56.0 version (?) As now this policy is configured by the framework automatically, I believe to recover you should remove t...
2020-12-17 13:24:17+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#generateCoreTemplate() should explicitly disable S3 Transfer Acceleration, if requested', '#generateCoreTemplate() should exclude AccelerateConfiguration for govcloud region', '#generateCoreTemplate() should reject non-HTTPS requests to the deployment bucket', '#generateCoreTemplate() should enable S3 Block Public A...
['#generateCoreTemplate() should not create ServerlessDeploymentBucketPolicy resource if requested']
[]
. /usr/local/nvm/nvm.sh && npx mocha test/unit/lib/plugins/aws/package/lib/generateCoreTemplate.test.js --reporter json
Feature
false
true
false
false
2
0
2
false
false
["lib/plugins/aws/provider.js->program->class_declaration:AwsProvider->method_definition:constructor", "lib/plugins/aws/package/lib/generateCoreTemplate.js->program->method_definition:generateCoreTemplate"]
serverless/serverless
7,668
serverless__serverless-7668
['7652']
48a16854a94e15e06a4e54275d1792cfeb8e0586
diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md index 25564bf79c2..f46ddcbdb0b 100644 --- a/docs/providers/aws/events/apigateway.md +++ b/docs/providers/aws/events/apigateway.md @@ -329,6 +329,20 @@ functions: cacheControl: 'max-age=600, s-maxage=600, proxy-re...
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js index b7969863843..6f2e0191fe4 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js +++ b/lib/plugins/aws/package/compile/events/api...
CORS header values must be provided as an array - Allow Any Headers I've seen examples of how to setup cors like below: ``` functions: getProduct: handler: handler.getProduct events: - http: path: product/{id} method: get cors: origin: '*' # <-- Spec...
> Is there a way I can configure this to allow any headers? probably via `- '*'`. Anyway PR that allows to non-array format is definitely welcome! I can work on this one if it's still available
2020-05-04 14:24:55+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#validate() should throw if cors headers are not an array or a string', '#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() throw error if authorizer property is not a string or object', '#...
['#validate() should accept cors headers as a single string value']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getCors"]
serverless/serverless
7,623
serverless__serverless-7623
['7477']
2e56dea5652540cf5d82c9d35a999c8c921fa020
diff --git a/docs/providers/aws/events/http-api.md b/docs/providers/aws/events/http-api.md index 45e0fb55699..8aa3edb238a 100644 --- a/docs/providers/aws/events/http-api.md +++ b/docs/providers/aws/events/http-api.md @@ -194,3 +194,15 @@ provider: ``` In such case no API and stage resources are created, therefore e...
diff --git a/lib/plugins/aws/package/compile/events/httpApi/index.test.js b/lib/plugins/aws/package/compile/events/httpApi/index.test.js index c93d3dd4435..ce75ad980b6 100644 --- a/lib/plugins/aws/package/compile/events/httpApi/index.test.js +++ b/lib/plugins/aws/package/compile/events/httpApi/index.test.js @@ -76,6 +7...
Allow setting payloadFormatVersion = 2.0 for AWS API Gateway (v2/httpApi) lambda functions # Feature Proposal It would be good if we could change the `payloadFormatVersion` property for AWS API Gateway HTTP Integrations to the newer 2.0 format without having to manually change this via the AWS console. ## Descrip...
Also just to mention that trying to manually override this via a `resources.extensions` section results in this error currently: ``` Error: Properties: Sorry, extending the PayloadFormatVersion resource attribute at this point is not supported. Feel free to propose support for it in the Framework issue tracker: htt...
2020-04-24 09:05:26+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['HttpApiEvents Cors Object configuration #2 Should respect allowedHeaders', 'HttpApiEvents External HTTP API Should not configure stage resource', 'HttpApiEvents Catch-all endpoints Should configure API resource', 'HttpApiEvents Cors Object configuration #2 Should respect allowedMethods', 'HttpApiEvents Specific endpo...
['HttpApiEvents Payload format version Should set payload format version']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/httpApi/index.test.js --reporter json
Feature
true
false
false
false
0
0
0
false
false
[]
serverless/serverless
7,031
serverless__serverless-7031
['7030']
f1d2d0038c650f9629fbec76cede42e289290f8a
diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js index dce68f18bfb..ed368256431 100644 --- a/lib/plugins/aws/provider/awsProvider.js +++ b/lib/plugins/aws/provider/awsProvider.js @@ -284,7 +284,8 @@ class AwsProvider { if (options && !_.isUndefined(options.region))...
diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js index 401adfb03d9..24d25c5a94a 100644 --- a/lib/plugins/aws/provider/awsProvider.test.js +++ b/lib/plugins/aws/provider/awsProvider.test.js @@ -283,6 +283,41 @@ describe('AwsProvider', () => { }); }); ...
AWS - ability to request DynamoDB.DocumentClient in a plugin # Feature Proposal ## Description <!-- Please use https://forum.serverless.com, StackOverflow or other forums for Q&A --> <!-- Please answer ALL the question below. Otherwise we probably have to close the issue due to missing information --> 1. What...
null
2019-11-30 02:51:07+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsProvider #request() using the request cache should resolve to the same response with multiple parallel requests', 'AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload',...
['AwsProvider #request() should handle subclasses']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"]
serverless/serverless
7,024
serverless__serverless-7024
['7019']
83a486dbf0b1ef5ff020c0a281cd34c67623e1ba
diff --git a/docs/providers/aws/events/streams.md b/docs/providers/aws/events/streams.md index 17d89c9413a..835de5c3b6d 100644 --- a/docs/providers/aws/events/streams.md +++ b/docs/providers/aws/events/streams.md @@ -108,3 +108,23 @@ functions: arn: arn:aws:kinesis:region:XXXXXX:stream/foo batchWi...
diff --git a/lib/plugins/aws/package/compile/events/stream/index.test.js b/lib/plugins/aws/package/compile/events/stream/index.test.js index 7701870c117..f3c129491dd 100644 --- a/lib/plugins/aws/package/compile/events/stream/index.test.js +++ b/lib/plugins/aws/package/compile/events/stream/index.test.js @@ -731,6 +731,...
Expose new ParallelizationFactor option for Kinesis streams Add support for the new Kinesis config option ParallelizationFactor which allows you to scale the concurrency of a shard up to 10 (currently set to 1). More info here: https://aws.amazon.com/blogs/compute/new-aws-lambda-scaling-controls-for-kinesis-and-dyna...
@michael-ar thanks for request! PR is definitely very welcome
2019-11-28 12:19:39+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsCompileStreamEvents #compileStreamEvents() when a DynamoDB stream ARN is given fails if keys other than Fn::GetAtt/ImportValue/Join are used for dynamic stream ARN', 'AwsCompileStreamEvents #compileStreamEvents() should not throw error if custom IAM role is set in provider', 'AwsCompileStreamEvents #compileStreamE...
['AwsCompileStreamEvents #compileStreamEvents() when a Kinesis stream ARN is given should create event source mappings when a Kinesis stream ARN is given']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/stream/index.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/stream/index.js->program->class_declaration:AwsCompileStreamEvents->method_definition:compileStreamEvents"]
serverless/serverless
6,945
serverless__serverless-6945
['6944']
bedd0fc9ea4905abb80ea3e02f6ea6dbeef0c97b
diff --git a/docs/providers/azure/cli-reference/create.md b/docs/providers/azure/cli-reference/create.md index c2de7ca0efa..46b625789f8 100644 --- a/docs/providers/azure/cli-reference/create.md +++ b/docs/providers/azure/cli-reference/create.md @@ -48,6 +48,7 @@ To see a list of available templates run `serverless crea...
diff --git a/lib/plugins/create/create.test.js b/lib/plugins/create/create.test.js index b8ec520ca54..de956e19288 100644 --- a/lib/plugins/create/create.test.js +++ b/lib/plugins/create/create.test.js @@ -588,6 +588,25 @@ describe('Create', () => { }); }); + it('should generate scaffolding for "azure-p...
Add azure-python template to CLI # Feature Proposal ## Description Make azure-python template available through the CLI with `sls create -t azure-python` Similar or dependent issues: - #6822
I can open a PR for this matter. Thanks @AlexandreSi for request. Yes PR with that will be highly welcome.
2019-11-08 17:12:32+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['Create #create() should generate scaffolding for "aws-python3" template', 'Create #create() should set servicePath based on cwd', 'Create #create() should generate scaffolding for "aws-provided" template', 'Create #create() should generate scaffolding for "google-python" template', 'Create #create() should generate s...
['Create #create() should generate scaffolding for "azure-python" template']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/create/create.test.js --reporter json
Feature
true
false
false
false
0
0
0
false
false
[]
serverless/serverless
6,871
serverless__serverless-6871
['6595']
8d5f6b889fa87999f37603040e09ecf6371caf76
diff --git a/lib/plugins/aws/customResources/index.js b/lib/plugins/aws/customResources/index.js index b3b9b4f99cc..3b84d4663ce 100644 --- a/lib/plugins/aws/customResources/index.js +++ b/lib/plugins/aws/customResources/index.js @@ -86,78 +86,83 @@ function addCustomResourceToService(awsProvider, resourceName, iamRoleS...
diff --git a/lib/plugins/aws/customResources/index.test.js b/lib/plugins/aws/customResources/index.test.js index ceb5a328dfd..639f25cd881 100644 --- a/lib/plugins/aws/customResources/index.test.js +++ b/lib/plugins/aws/customResources/index.test.js @@ -221,6 +221,119 @@ describe('#addCustomResourceToService()', () => {...
Support custom role setting for custom resources # This is a Bug Report ## Description - What went wrong? We use our own role which is specified at the provider level. This role is used for every lambda. Since we added the Eventbridge event to a Lambda it fails to try to create a custom role (which it shou...
@gordianberger thanks for that report. > Since we added the Eventbridge event to a Lambda it fails to try to create a custom role (which it should not do since we use our predefined one). Why exactly it fails? Relying on custom resources is expected to work seamlessly with custom role setting > Custom-resource...
2019-10-22 15:16:33+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#addCustomResourceToService() should add one IAM role and the custom resources to the service', '#addCustomResourceToService() should setup CloudWatch Logs when logs.frameworkLambda is true', '#addCustomResourceToService() should throw when an unknown custom resource is used', "#addCustomResourceToService() should en...
['#addCustomResourceToService() Should not setup new IAM role, when cfnRole is provided']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/customResources/index.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/customResources/index.js->program->function_declaration:addCustomResourceToService"]
serverless/serverless
6,534
serverless__serverless-6534
['6262']
d4c8bc1450d31275596b26bb7464a6f1b28392af
diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.js b/lib/plugins/aws/package/lib/mergeIamTemplates.js index 945312b6987..e96534ec1eb 100644 --- a/lib/plugins/aws/package/lib/mergeIamTemplates.js +++ b/lib/plugins/aws/package/lib/mergeIamTemplates.js @@ -90,23 +90,13 @@ module.exports = { .Resources[th...
diff --git a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js index 09447f64157..b7da9693183 100644 --- a/lib/plugins/aws/package/lib/mergeIamTemplates.test.js +++ b/lib/plugins/aws/package/lib/mergeIamTemplates.test.js @@ -127,7 +127,7 @@ describe('#mergeIam...
Wider `logs:CreateLogStream`/`logs:PutLogEvents` permissions in policy for Lambda functions with manual names (v1.45.1) <!-- 1. If you have a question and not a bug report please ask first at http://forum.serverless.com 2. Please check if an issue already exists. This bug may have already been documented 3. Check ou...
This was done to avoid a hard AWS limit of the size of a single role. We can make the least-privileged permission as an option if some users find the wider troublesome. Another option is to have each function to have its own role, but the statements added via the `iamRoleStatements` would need to be duplicated o...
2019-08-13 12:33:01+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#mergeIamTemplates() should throw an error describing all problematics custom IAM policy statements', '#mergeIamTemplates() should not add the default role if all functions have an ARN role', '#mergeIamTemplates() should ensure IAM policies when service contains only canonically named functions', '#mergeIamTemplates(...
['#mergeIamTemplates() should ensure IAM policies for custom and canonically named functions', '#mergeIamTemplates() should ensure IAM policies when service contains only custom named functions']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/lib/mergeIamTemplates.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/lib/mergeIamTemplates.js->program->method_definition:merge"]
serverless/serverless
6,445
serverless__serverless-6445
['6444']
b6bfe19795520dbd4361d76e6b2805c7a19eecb4
diff --git a/docs/providers/aws/events/sns.md b/docs/providers/aws/events/sns.md index fdc442a166b..b255c12aa4c 100644 --- a/docs/providers/aws/events/sns.md +++ b/docs/providers/aws/events/sns.md @@ -80,7 +80,20 @@ functions: topicName: MyCustomTopic ``` -**Note:** If an `arn` string is specified but not...
diff --git a/lib/plugins/aws/package/compile/events/sns/index.test.js b/lib/plugins/aws/package/compile/events/sns/index.test.js index 18b72af715e..46fbc64d09d 100644 --- a/lib/plugins/aws/package/compile/events/sns/index.test.js +++ b/lib/plugins/aws/package/compile/events/sns/index.test.js @@ -327,7 +327,7 @@ describ...
Cross account SNS Trigger # This is a Bug Report ## Description We create topics with the same name in all regions and all accounts and have one Lambda function to handle all events. When trying to deploy lambda function subscribing to an SNS topic with the same name but in a different account the CloudFormation ...
null
2019-07-25 11:00:09+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsCompileSNSEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileSNSEvents #compileSNSEvents() should throw an error when arn object and no topicName are given as object properties', 'AwsCompileSNSEvents #compileSNSEvents() should create SNS topic when only arn is given a...
['AwsCompileSNSEvents #compileSNSEvents() should create two SNS topic subsriptions for ARNs with the same topic name in two regions when different topicName parameters are specified', 'AwsCompileSNSEvents #compileSNSEvents() should override SNS topic subsription CF resource name when arn and topicName are given as obje...
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/sns/index.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/sns/index.js->program->class_declaration:AwsCompileSNSEvents->method_definition:compileSNSEvents"]
serverless/serverless
6,345
serverless__serverless-6345
['6346']
650d55da741837ce8ea5ebe2ab957c9b71dcab21
diff --git a/lib/classes/CLI.js b/lib/classes/CLI.js index 80299ddf43a..4e26e801733 100644 --- a/lib/classes/CLI.js +++ b/lib/classes/CLI.js @@ -209,6 +209,12 @@ class CLI { this.consoleLog(chalk.yellow.underline('Framework')); this.consoleLog(chalk.dim('* Documentation: https://serverless.com/framework/docs/...
diff --git a/lib/classes/Error.test.js b/lib/classes/Error.test.js index 43b10139415..47938e8b14b 100644 --- a/lib/classes/Error.test.js +++ b/lib/classes/Error.test.js @@ -110,6 +110,20 @@ describe('Error', () => { expect(message).to.have.string('SLS_DEBUG=*'); }); + it('should hide warnings if SLS_WA...
Allow warnings to be hidden <!-- 1. If you have a question and not a feature request please ask first at http://forum.serverless.com 2. Please check if an issue already exists. This feature may have already been requested 3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/master/CO...
null
2019-07-08 16:34:27+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['Error #logError() should capture the exception and exit the process with 1 if errorReporter is setup', 'Error #logError() should not print stack trace without SLS_DEBUG', 'ServerlessError #constructor() should have stack trace', 'ServerlessError #constructor() should store name', 'Error #logError() should notify abou...
['Error #logError() should hide warnings if SLS_WARNING_DISABLE is defined']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/Error.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/classes/CLI.js->program->class_declaration:CLI->method_definition:generateMainHelp"]
serverless/serverless
6,192
serverless__serverless-6192
['6185']
e7f37596dca8151d1f4a82e95a151ded3bc3db2e
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js index 08e13da2fc8..2b6ced95f33 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js +++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/val...
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js index 43f20c7f7c6..a0e692af1a6 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js +++ b/lib/plugins/aws/package/compile/events/api...
Cannot read property 'length' of undefined when defining a string authorizer <!-- 1. If you have a question and not a bug report please ask first at http://forum.serverless.com 2. Please check if an issue already exists. This bug may have already been documented 3. Check out and follow our Guidelines: https://github...
I would like to suggest to make both checks, `claims && claims.length > 0`, in the change from: https://github.com/serverless/serverless/commit/9b4ec28a1e377cf1163ab153e99b5afd18727038#diff-a15f3a24289528534cb043857ccac565 Thanks for opening @camilosampedro 👍 🤔 this seems to be related to https://github.com/server...
2019-05-30 07:18:39+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',...
['#validate() should not throw when using a cognito string authorizer']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer"]
serverless/serverless
6,121
serverless__serverless-6121
['6103']
572dd8761c0c8283e50b960a66712669b0daf0df
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js index 9fde97c462b..08e13da2fc8 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js +++ b/lib/plugins/aws/package/compile/events/apiGateway/lib/val...
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js index e8fb9792993..a24bc784821 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js +++ b/lib/plugins/aws/package/compile/events/api...
Deploy fails with "Cognito claims can only be filtered when using the lambda integration type" after updating to 1.42.0 <!-- 1. If you have a question and not a bug report please ask first at http://forum.serverless.com 2. Please check if an issue already exists. This bug may have already been documented 3. Check ou...
It is caused by https://github.com/serverless/serverless/pull/6000 We had to stick with 1.41.1 for deployments for now. 👽 Sorry about that I will look into it.
2019-05-10 17:18:35+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',...
['#validate() should not throw if an cognito claims are empty arrays with a lambda proxy']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer"]
serverless/serverless
6,063
serverless__serverless-6063
['2797']
b383221d4319b53c8ef2b9c54c64e3df9395154d
diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md index 79e83da85fd..42f669955d9 100644 --- a/docs/providers/aws/events/apigateway.md +++ b/docs/providers/aws/events/apigateway.md @@ -47,6 +47,7 @@ layout: Doc - [Share Authorizer](#share-authorizer) - [Resource Policy]...
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js index f881289f466..559d825d549 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js +++ b/lib/plugins/aws/package/compile/events/apiGat...
Support New AWS APIGW Binary Responses # This is a Feature Proposal ## Description Previously, AWS API Gateway did not support binary responses, making it impossible to return images from your serverless API. Now they do (see https://aws.amazon.com/blogs/compute/binary-support-for-api-integrations-with-amazon-api...
Does it mean we will be able to gzip response? My team is eagerly anticipating this feature in Serverless. We have an image resizing service that currently needs to proxy responses through a traditional server to return images... 😫 Does anybody know of a workaround we could use until this is added to Serverless? T...
2019-04-29 11:32:58+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#compileRestApi() should compile correctly if apiKeySourceType property is HEADER', '#compileRestApi() should compile correctly if apiKeySourceType property is AUTHORIZER', '#compileRestApi() throw error if endpointType property is not a string', '#compileRestApi() should compile if endpointType property is PRIVATE',...
['#compileRestApi() should set binary media types if defined at the apiGateway provider config level', '#compileRestApi() should create a REST API resource with resource policy', '#compileRestApi() should create a REST API resource']
['#compileRestApi() should throw error if minimumCompressionSize is not an integer', '#compileRestApi() should throw error if minimumCompressionSize is greater than 10485760', '#compileRestApi() throw error if apiKeySourceType is not HEADER or AUTHORIZER', '#compileRestApi() should throw error if minimumCompressionSize...
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/events/apiGateway/lib/restApi.js->program->method_definition:compileRestApi"]
serverless/serverless
6,051
serverless__serverless-6051
['5025']
dc7413cee4392946253b153e6bf4d32d074bd8b5
diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md index 444a824c873..d15e2d07baa 100644 --- a/docs/providers/aws/events/apigateway.md +++ b/docs/providers/aws/events/apigateway.md @@ -42,6 +42,7 @@ layout: Doc - [Using Status Codes](#using-status-codes) - [Cust...
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js index a01f5b03392..b5be8d52fe1 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js +++ b/lib/plugins/aws/package/compile/events/api...
Support VPC - Link For feature proposals: This feature makes it possible to restrict access to api-gateway and make the solution only internally available. https://aws.amazon.com/about-aws/whats-new/2017/11/amazon-api-gateway-supports-endpoint-integrations-with-private-vpcs/?nc1=h_ls Advantage: Security Enhancem...
This is a duplication of #5052, closing. A vpc-link is not the same thing as a Private API Gateway. A Private API gateway is in a VPC and is not publicly accessible, it is only accessible from within its VPC. [Private endpoints](https://aws.amazon.com/blogs/compute/introducing-amazon-api-gateway-private-endpoints/...
2019-04-25 18:41:34+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#validate() should process cors options', '#validate() should throw if an cognito claims are being with a lambda proxy', '#validate() should set authorizer defaults', '#validate() should process request parameters for HTTP_PROXY integration', '#validate() throw error if authorizer property is not a string or object',...
['#validate() should support HTTP_PROXY integration with VPC_LINK connection type', '#validate() should throw an error when connectionId is not provided with VPC_LINK', '#validate() should throw an error when connectionType is invalid']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/validate.test.js --reporter json
Feature
false
true
false
false
3
0
3
false
false
["lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_definition:validate", "lib/plugins/aws/package/compile/events/apiGateway/lib/method/integration.js->program->method_definition:getMethodIntegration", "lib/plugins/aws/package/compile/events/apiGateway/lib/validate.js->program->method_d...
serverless/serverless
5,982
serverless__serverless-5982
['5935']
10b7d722502d65b0f628d3f23929f0a450ec6cbd
diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md index 63ebd290228..9f21501e7fa 100644 --- a/docs/providers/aws/events/apigateway.md +++ b/docs/providers/aws/events/apigateway.md @@ -280,7 +280,7 @@ functions: maxAge: 86400 ``` -If you are using CloudFront o...
diff --git a/lib/plugins/aws/info/display.test.js b/lib/plugins/aws/info/display.test.js index fac3a1969ca..76e5bdb9d43 100644 --- a/lib/plugins/aws/info/display.test.js +++ b/lib/plugins/aws/info/display.test.js @@ -79,12 +79,16 @@ describe('#display()', () => { }); it('should display API keys if given', () =>...
Enable Setting Amazon API Gateway API Key Value # This is a Feature Proposal ## Description Finally, AWS added support for defining API Key value using CloudFront. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-apikey.html#cfn-apigateway-apikey-value This will help in th...
I can take this one Great! Thanks @laardee :+1:
2019-03-30 22:05:29+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#getApiKeyValues() should resolve if API key names are not available', '#display() should display general service info', '#display() should display a warning if 150+ resources', '#display() should display https endpoints if given', '#display() should display wss endpoint if given', '#display() should not display any ...
['#compileUsagePlanKeys() should support api key notation', '#compileApiKeys() when using usage plan notation should support usage plan notation', '#compileApiKeys() throw error if an apiKey is not a valid object', '#compileUsagePlanKeys() when using usage plan notation should support usage plan notation', '#display() ...
['#getApiKeyValues() should add API Key values to this.gatheredData if API key names are available', '#getApiKeyValues() should resolve if AWS does not return API key values']
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/apiKeys.test.js lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlanKeys.test.js lib/plugins/aws/info/getApiKeyValues.test.js lib/plugins/aws/info/display.test.js --reporter json
Feature
false
true
false
false
6
0
6
false
false
["lib/plugins/aws/package/compile/events/apiGateway/lib/apiKeys.js->program->function_declaration:createApiKeyResource", "lib/plugins/aws/info/display.js->program->method_definition:displayApiKeys", "lib/plugins/aws/package/compile/events/apiGateway/lib/usagePlanKeys.js->program->method_definition:compileUsagePlanKeys"...
serverless/serverless
5,639
serverless__serverless-5639
['4737']
6c861055af46e95f0232a2eabf7d5d9d8e535fa3
diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js index 149828fc74b..1b4cc8655e1 100644 --- a/lib/plugins/aws/provider/awsProvider.js +++ b/lib/plugins/aws/provider/awsProvider.js @@ -19,6 +19,8 @@ const constants = { providerName: 'aws', }; +const validAPIGatewayStage...
diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js index 8fe4e5958ff..c2952fe88e4 100644 --- a/lib/plugins/aws/provider/awsProvider.test.js +++ b/lib/plugins/aws/provider/awsProvider.test.js @@ -90,6 +90,54 @@ describe('AwsProvider', () => { delete process.en...
Confusing error messages when creating stages with special characters # This is a Bug Report ## Description * What went wrong? Confusing error messages when creating stages sls deploy --stage local-bot ... Serverless Error --------------------------------------- An error occurred: Api...
Hi @benswinburne , thanks for bringing this up. It is indeed confusing. The correct solution here would be to disallow hyphens `-` and underscores `_` from Serverless stage names or transform the underscore in the CF stack name to a hyphen, because (1) CF stack names cannot contain underscores (2) APIG stage nam...
2018-12-30 13:56:28+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsProvider #constructor() certificate authority - file should set AWS ca and cafile', 'AwsProvider #canUseS3TransferAcceleration() should return true when CLI option is provided for S3.upload', 'AwsProvider #constructor() deploymentBucket configuration should do nothing if not defined', 'AwsProvider #getStage() shou...
['AwsProvider #constructor() validation on construction should throw an error if stage contains hyphen and http events are present']
['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv...
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:constructor"]
serverless/serverless
5,602
serverless__serverless-5602
['5600']
e53455a7433ec79843886eee1eacb9a8f67c84ce
diff --git a/lib/plugins/package/lib/packageService.js b/lib/plugins/package/lib/packageService.js index 9f7bda935ec..47fc525c7a3 100644 --- a/lib/plugins/package/lib/packageService.js +++ b/lib/plugins/package/lib/packageService.js @@ -188,7 +188,7 @@ module.exports = { params.include.forEach((pattern) => { ...
diff --git a/lib/plugins/package/lib/zipService.test.js b/lib/plugins/package/lib/zipService.test.js index 39cedf31ff2..562663229aa 100644 --- a/lib/plugins/package/lib/zipService.test.js +++ b/lib/plugins/package/lib/zipService.test.js @@ -1012,6 +1012,30 @@ describe('zipService', () => { }); }); + it...
Parent paths no longer working for package inclusions/exclusions <!-- 1. If you have a question and not a bug report please ask first at http://forum.serverless.com 2. Please check if an issue already exists. This bug may have already been documented 3. Check out and follow our Guidelines: https://github.com/serverl...
That's likely a regression caused by #5574. Any chance you could take a look at this @MacMcIrish? Would it be possible to have all the includes on [this line](https://github.com/MacMcIrish/serverless/blob/23c37b7543238e4a98ab605c2cf8146a3095bcce/lib/plugins/package/lib/packageService.js#L191) with out causing the perfo...
2018-12-16 02:03:16+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['zipService #zip() should keep file permissions', 'zipService #zip() should zip a whole service (without include / exclude usage)', 'zipService #zip() should re-include files using include config', 'zipService #excludeDevDependencies() should resolve when opted out of dev dependency exclusion', 'zipService #zip() shou...
['zipService #zip() should include files even if outside working dir']
['zipService #excludeDevDependencies() when dealing with Node.js runtimes should return excludes and includes if a exec Promise is rejected', 'zipService #excludeDevDependencies() when dealing with Node.js runtimes should fail silently and continue if "npm ls" call throws an error', 'zipService #excludeDevDependencies(...
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/package/lib/zipService.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/package/lib/packageService.js->program->method_definition:resolveFilePathsFromPatterns"]
serverless/serverless
5,579
serverless__serverless-5579
['5154']
8e79ada47b9d9d685d7395e31b427f4b0cc059db
diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md index 88ab0f39f58..125887922bf 100644 --- a/docs/providers/aws/guide/variables.md +++ b/docs/providers/aws/guide/variables.md @@ -155,6 +155,45 @@ functions: ``` In that case, the framework will fetch the values of those `funct...
diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js index 2c65f39a4db..7a3f27cf91f 100644 --- a/lib/classes/Variables.test.js +++ b/lib/classes/Variables.test.js @@ -1521,6 +1521,37 @@ module.exports = { .finally(() => cfStub.restore()); }); + it('should get variable from Cloud...
${cf} for another region I have a serverless.yml that needs to reference the cloudformation output of another stack in another region. How can I solve this? This useful when using lambda@edge (which is only supported in us-east-1)
null
2018-12-08 11:56:09+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getCredentials() should not set credentials if credentials has empty string values', 'Variables #popula...
['AwsProvider #request() should request to the specified region if region in options set', 'Variables #getValueFromCf() should get variable from CloudFormation of different region']
['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o...
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json
Feature
false
true
false
false
3
0
3
false
false
["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromCf", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:constructor"]
serverless/serverless
5,509
serverless__serverless-5509
['5400']
fbd9b46ef913d270f062b1c89d62ef3367342984
diff --git a/docs/providers/aws/events/apigateway.md b/docs/providers/aws/events/apigateway.md index 3449c6a836c..62f2f50e0ea 100644 --- a/docs/providers/aws/events/apigateway.md +++ b/docs/providers/aws/events/apigateway.md @@ -981,6 +981,7 @@ provider: apiGateway: restApiId: xxxxxxxxxx # REST API resource ID....
diff --git a/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js b/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js index 98be9ee278e..a3354e05d09 100644 --- a/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js +++ b/lib/plugins/aws/package/compile/even...
Support API Gateway stage deployment description # This is a Feature Proposal ## Description Currently, [API Gateway deployment](https://github.com/serverless/serverless/blob/master/lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.js#L14) only support **RestApiId** and **StageName** property. I...
null
2018-11-20 14:59:20+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#compileDeployment() should add service endpoint output']
['#compileDeployment() should create a deployment resource', '#compileDeployment() should create a deployment resource with description']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.test.js --reporter json
Feature
false
false
false
true
2
1
3
false
false
["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:getApiGatewayDescription", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/package/compile/events/apiGateway/lib/deployment.js->program->method_definition:compileDeplo...
serverless/serverless
5,224
serverless__serverless-5224
['5216', '5205']
bee4e25a3b21feed5c42705f083f589e6c7940d0
diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js index 8baa423b699..6411f043f70 100644 --- a/lib/classes/Variables.js +++ b/lib/classes/Variables.js @@ -301,7 +301,7 @@ class Variables { * @returns {Promise[]} Promises for the eventual populated values of the given matches */ populateMatches(...
diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js index 3d6cce0ba7d..19c68a8e324 100644 --- a/lib/classes/Variables.test.js +++ b/lib/classes/Variables.test.js @@ -600,6 +600,40 @@ describe('Variables', () => { return serverless.variables.populateObject(service.custom) .shou...
Variable resolution broken in 1.30.0 # This is a Bug Report ## Description For bug reports: * What went wrong? Variable are being replaced several times in CFN generation. `Resource: "arn:aws:dynamodb:${opt:region, self:provider.region}:*:table/${self:provider.environment.SURFACES_TABLE}"` is becomin...
We're experiencing the same issue after upgrading to Serverless 1.30. We avoided this problem replacing `${opt:region, self:provider.region}` with `${self:provider.region}` since we deploy only in one region. We also experienced the same problem using `${opt:stage, self:provider.stage}`, replaced again with `${self:p...
2018-08-17 01:44:48+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['Variables #populateObject() significant variable usage corner cases should handle deep variables regardless of recursion into custom variableSyntax', 'Variables #splitByComma should return a undelimited string', 'Variables #prepopulateService dependent service non-interference must leave the dependent services in the...
['Variables #populateObject() significant variable usage corner cases should handle embedded deep variable replacements in overrides', 'Variables #populateObject() significant variable usage corner cases should deal with overwites that reference embedded deep references']
['Variables #getValueFromSource() caching should only call getValueFromFile once, returning the cached value otherwise', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #getValueFromSource() caching should only call getValueFromS3 once, returning the cached value o...
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json
Bug Fix
false
false
false
true
3
1
4
false
false
["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:splitAndGet", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:overwrite", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:populateMatches", "lib/classes/Variables.js-...
serverless/serverless
4,794
serverless__serverless-4794
['4752']
dfb36b8503f4d60de413dffc660ff1b4e31ec80c
diff --git a/lib/plugins/aws/provider/awsProvider.js b/lib/plugins/aws/provider/awsProvider.js index 64a090d3027..0db9baf44dd 100644 --- a/lib/plugins/aws/provider/awsProvider.js +++ b/lib/plugins/aws/provider/awsProvider.js @@ -275,7 +275,7 @@ class AwsProvider { req.send(cb); }); return promise...
diff --git a/lib/plugins/aws/provider/awsProvider.test.js b/lib/plugins/aws/provider/awsProvider.test.js index 914f110b845..48fc28b2d32 100644 --- a/lib/plugins/aws/provider/awsProvider.test.js +++ b/lib/plugins/aws/provider/awsProvider.test.js @@ -452,6 +452,82 @@ describe('AwsProvider', () => { .catch(() => ...
AWS deploy fails with empty error message if S3.headObject responds with 403 # This is a (minor) Bug Report ## Description Deployment to AWS fails without any error message if the used IAM role is not allowed to upload to the existing S3 Bucket defined in `serverless.yml`, i.e. the AWS CLI responds with 403 for `...
Hi @jpbackman . I tagged the "minor bug report" as enhancement 😄 as it does not disable existing functionality. However, emitting `null` as error message is not a really good behavior.
2018-03-02 17:40:44+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsProvider values #getValues should return an array of values given paths to them', 'AwsProvider #canUseS3TransferAcceleration() should return false when CLI option is provided but not an S3 upload', 'AwsProvider #getProfile() should use provider in lieu of options and config', 'AwsProvider #getCredentials() should ...
['AwsProvider #request() should default to error code if error message is non-existent']
['AwsProvider #constructor() should have no AWS logger', 'AwsProvider #getAccountInfo() should return the AWS account id and partition', 'AwsProvider #getAccountId() should return the AWS account id', 'AwsProvider #getServerlessDeploymentBucketName() should return the name of the serverless deployment bucket', 'AwsProv...
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/provider/awsProvider.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider->method_definition:request"]
serverless/serverless
4,448
serverless__serverless-4448
['4435']
aaabb92005d5dfe9ac1018af2b2e0396ebd954ff
diff --git a/lib/classes/Variables.js b/lib/classes/Variables.js index a3fb07a7e22..3c69a151692 100644 --- a/lib/classes/Variables.js +++ b/lib/classes/Variables.js @@ -235,8 +235,10 @@ class Variables { referencedFileRelativePath : path.join(this.serverless.config.servicePath, referencedFileRelativeP...
diff --git a/lib/classes/Variables.test.js b/lib/classes/Variables.test.js index d6c5e2b762f..203ace06c1d 100644 --- a/lib/classes/Variables.test.js +++ b/lib/classes/Variables.test.js @@ -638,19 +638,19 @@ describe('Variables', () => { it('should get undefined if non existing file and the second argument is true'...
Error when file referenced in serverless.yml does not exist # Bug Report ## Description When deploying and referencing an `env` file variable in `serverless.yml` that doesn't exist, the build fails. * What went wrong? I get the error: `ENOENT: no such file or directory, realpath '/foo/bar/repo/.env.yml'`...
Thanks @antpuleo2586 for reporting :+1: That would be a bug, so we should add a test which reproduces it ,then fix it. +1 ran into this with my CI/CD pipeline after upgrading to 1.24 with numerous stacks with default overridable params. This is urgent IMHO, please fix ASAP. I also wonder what "feature" actually...
2017-11-06 11:57:36+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['Variables #warnIfNotFound() should log if variable has empty object value.', 'Variables #getValueFromSource() should throw error if referencing an invalid source', 'Variables #populateVariable() should populate string variables as sub string', 'Variables #populateVariable() should populate number variables as sub str...
['Variables #getValueFromFile() should get undefined if non existing file and the second argument is true']
['Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #populateService() should call populateProperty method', 'Variables #getValueFromSsm() should get variable from Ssm using regular-st...
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/Variables.test.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/classes/Variables.js->program->class_declaration:Variables->method_definition:getValueFromFile"]
serverless/serverless
4,097
serverless__serverless-4097
['4072']
f52a09095c128355316b9e0e3a8d5e7c69b57cb0
diff --git a/docs/providers/aws/guide/variables.md b/docs/providers/aws/guide/variables.md index 81fb191168c..37d263411d6 100644 --- a/docs/providers/aws/guide/variables.md +++ b/docs/providers/aws/guide/variables.md @@ -273,6 +273,7 @@ provider: stage: dev custom: myStage: ${opt:stage, self:provider.stage} + m...
diff --git a/lib/classes/Service.test.js b/lib/classes/Service.test.js index df73074f367..44981dca100 100644 --- a/lib/classes/Service.test.js +++ b/lib/classes/Service.test.js @@ -31,7 +31,7 @@ describe('Service', () => { expect(serviceInstance.provider).to.deep.equal({ stage: 'dev', region: '...
Variable system improvement: Add ability to use strings as default value If you set the default value of a variable as a string, an error is thrown. This should be perfectly value though. (unless there is something I am missing) ```yml service: name: getting-started provider: name: aws environment: ...
I literally tried to do this yesterday! Big :thumbsup:!
2017-08-16 01:49:24+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['Service #update() should update service instance data', 'Variables #getValueFromFile() should populate an entire variable exported by a javascript file', 'Variables #getValueFromFile() should throw if property exported by a javascript file is not a function', 'Service #getAllEventsInFunction() should return an array ...
['Service #constructor() should construct with defaults']
['Variables #populateProperty() should call overwrite if overwrite syntax provided', 'Variables #getValueFromSource() should call getValueFromOptions if referencing an option', 'Variables #populateService() should call populateProperty method', 'Variables #getValueFromSource() should call getValueFromFile if referencin...
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/Service.test.js lib/classes/Variables.test.js --reporter json
Feature
false
false
false
true
5
1
6
false
false
["lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat", "lib/classes/Service.js->program->class_declaration:Service->method_definition:constructor", "lib/classes/Variables.js->program->class_declaration:Variables->method_definition:constructor", "lib/classes/Variables.js->program->class_de...
serverless/serverless
3,642
serverless__serverless-3642
['3639']
f4f2cf99af27098bd0444bc7b918e0d468a65ec6
diff --git a/docs/providers/aws/cli-reference/invoke-local.md b/docs/providers/aws/cli-reference/invoke-local.md index 56a6ee99a26..53fb5526c43 100644 --- a/docs/providers/aws/cli-reference/invoke-local.md +++ b/docs/providers/aws/cli-reference/invoke-local.md @@ -24,6 +24,13 @@ serverless invoke local --function funct...
diff --git a/lib/plugins/aws/invokeLocal/index.test.js b/lib/plugins/aws/invokeLocal/index.test.js index c0e5d51726c..63001f2102f 100644 --- a/lib/plugins/aws/invokeLocal/index.test.js +++ b/lib/plugins/aws/invokeLocal/index.test.js @@ -241,6 +241,7 @@ describe('AwsInvokeLocal', () => { expect(process.env.AWS_...
Expose a `IS_LOCAL` environment variable if running via `sls invoke local` # This is a Feature Proposal ## Description When testing code locally it is sometimes important to know whether the code is ran locally or in the AWS Lambda environment. The three main reasons for us are: * Typically we enable long stack ...
I like this! Are there any potential downsides/clashes this can run into? Also, eventually we will need to support this in multiple runtimes (Python, Java etc). Any thoughts on how we can achieve this?
2017-05-18 09:00:48+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsInvokeLocal #constructor() should set an empty options object if no options are given', 'AwsInvokeLocal #constructor() should have hooks', 'AwsInvokeLocal #loadEnvVars() it should load provider env vars', 'AwsInvokeLocal #loadEnvVars() it should overwrite provider env vars', 'AwsInvokeLocal #constructor() should s...
['AwsInvokeLocal #loadEnvVars() it should load default lambda env vars']
['AwsInvokeLocal #extendedValidate() it should parse a yaml file if file path is provided', 'AwsInvokeLocal #extendedValidate() should keep data if it is a simple string', 'AwsInvokeLocal #constructor() should run promise chain in order', 'AwsInvokeLocal #extendedValidate() it should parse file if relative file path is...
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/invokeLocal/index.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/invokeLocal/index.js->program->class_declaration:AwsInvokeLocal->method_definition:loadEnvVars"]
serverless/serverless
3,609
serverless__serverless-3609
['2982']
dd7909d055bc6cc8333cbfc93f9cee5f204e9454
diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md index 24c470008bc..ce8c4ea862b 100644 --- a/docs/providers/aws/guide/functions.md +++ b/docs/providers/aws/guide/functions.md @@ -300,3 +300,32 @@ provider: ``` These versions are not cleaned up by serverless, so make sure yo...
diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js index f4e88847b4f..dd5cbbab8a3 100644 --- a/lib/plugins/aws/package/compile/functions/index.test.js +++ b/lib/plugins/aws/package/compile/functions/index.test.js @@ -534,6 +534,196 @@ describe(...
Support for Lambda Function DeadLetterConfig (SQS|SNS) <!-- 1. If you have a question and not a bug/feature request please ask it at http://forum.serverless.com 2. Please check if an issue already exists so there are no duplicates 3. Check out and follow our Guidelines: https://github.com/serverless/serverless/blob/...
We need to wait for CF support for DLQ. FYI I've created a plugin for this that will work until CF supports `DeadLetterConfig` https://github.com/gmetzker/serverless-plugin-lambda-dead-letter https://www.npmjs.com/package/serverless-plugin-lambda-dead-letter #### DeadLetter Queue Use the `deadLetter.sqs` to cr...
2017-05-12 12:41:26+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment co...
['AwsCompileFunctions #compileFunctions() when using onError config when IamRoleLambdaExecution is used should throw an informative error message if a SQS arn is provided', 'AwsCompileFunctions #compileFunctions() when using onError config should throw an error if config is provided as an object', 'AwsCompileFunctions ...
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"]
serverless/serverless
3,548
serverless__serverless-3548
['3490']
cc941f8171cfd9d27c4df759b9e5e15e96ef0d24
diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md index 818be4bb781..24c470008bc 100644 --- a/docs/providers/aws/guide/functions.md +++ b/docs/providers/aws/guide/functions.md @@ -263,6 +263,26 @@ functions: TABLE_NAME: tableName2 ``` +## Tags + +Using the `tags` confi...
diff --git a/lib/plugins/aws/package/compile/functions/index.test.js b/lib/plugins/aws/package/compile/functions/index.test.js index 0b60b03e084..f4e88847b4f 100644 --- a/lib/plugins/aws/package/compile/functions/index.test.js +++ b/lib/plugins/aws/package/compile/functions/index.test.js @@ -487,6 +487,53 @@ describe('...
Add support for Lambda tagging # This is a Feature Proposal ## Description AWS has recently introduced Lambda tagging support which makes it possible to group Lambda functions and e.g. search by groups in the console. The framework should support Lambda tagging. Here are the corresponding docs: http://docs.aws...
One thing to keep in mind is that it's AWS specific, although one could argument that lots of function properties are currently AWS specific too. Personally, I don't see much value there > One thing to keep in mind is that it's AWS specific We could prefix the parameter with `aws-tag` (which is proposed strategy ...
2017-05-03 07:37:13+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should create a function resource with environment co...
['AwsCompileFunctions #compileFunctions() should create a function resource with tags']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/package/compile/functions/index.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/package/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"]
serverless/serverless
3,217
serverless__serverless-3217
['3211']
d98dfa3e07089a8242ea4a0f3a3726e6834581ec
diff --git a/RELEASE_CHECKLIST.md b/RELEASE_CHECKLIST.md index b7bb9bffe45..1badec74e36 100644 --- a/RELEASE_CHECKLIST.md +++ b/RELEASE_CHECKLIST.md @@ -6,8 +6,6 @@ This checklist should be worked through when releasing a new Serverless version. - [ ] Look through all open issues and PRs (if any) of that milestone and...
diff --git a/lib/classes/CLI.test.js b/lib/classes/CLI.test.js index 3a1d6b326ab..92a65b98fb5 100644 --- a/lib/classes/CLI.test.js +++ b/lib/classes/CLI.test.js @@ -9,7 +9,10 @@ const CLI = require('../../lib/classes/CLI'); const os = require('os'); const fse = require('fs-extra'); const exec = require('child_proces...
Deprecation Notices To keep everyone aware of the upcoming breaking changes, we're going to focus on providing accurate deprecation notices in the CLI for any upcoming breaking change. The goal of those warnings is to just give a quick heads up for what's coming, but not how to migrate, which fits more in a migration g...
Looks good! How do we deal with the list of deprecation warnings? E.g. if I run Serverless v1.2 (assuming that deprecation warnings were around then) do I see the list with deprecation warnings from 1.3 to the upcoming release? Or just the latest one? Furthermore we might want to display what version the user is ...
2017-02-09 10:09:22+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['CLI #displayHelp() should return true when the "-h" parameter is given', 'CLI Integration tests should print command --help to stdout', 'CLI #displayHelp() should return true when the "--version" parameter is given', 'CLI #setLoadedPlugins() should set the loadedPlugins array with the given plugin instances', 'CLI #c...
['CLI #logBreakingChanges() should not log breaking changes when the "disable environment variable" is set', 'CLI #logBreakingChanges() should log breaking changes when they are provided', 'CLI #logBreakingChanges() should not log breaking changes when they are not provided']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/CLI.test.js --reporter json
Feature
false
false
false
true
2
1
3
false
false
["lib/classes/CLI.js->program->class_declaration:CLI", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:constructor", "lib/classes/CLI.js->program->class_declaration:CLI->method_definition:logBreakingChanges"]
serverless/serverless
3,125
serverless__serverless-3125
['1825']
1f7ee353215435fe56d3fab3852dc3d4deb57d0e
diff --git a/lib/plugins/aws/deploy/compile/functions/index.js b/lib/plugins/aws/deploy/compile/functions/index.js index 3c1fe204f02..af68e37d211 100644 --- a/lib/plugins/aws/deploy/compile/functions/index.js +++ b/lib/plugins/aws/deploy/compile/functions/index.js @@ -158,8 +158,6 @@ class AwsCompileFunctions { ...
diff --git a/lib/plugins/aws/deploy/compile/functions/index.test.js b/lib/plugins/aws/deploy/compile/functions/index.test.js index 267f61f0d9a..cb38684b667 100644 --- a/lib/plugins/aws/deploy/compile/functions/index.test.js +++ b/lib/plugins/aws/deploy/compile/functions/index.test.js @@ -887,18 +887,10 @@ describe('Aws...
Refactor for the CLI function arns outputs We should refactor the CLI function ARN outputs like @nicka has done with the endpoints in #1794. This way we can reduce the number of outputs in the CloudFormation template.
null
2017-01-20 13:38:51+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsProvider #getCredentials() should not set credentials if profile is not set', 'AwsProvider #getRegion() should prefer config over provider in lieu of options', '#naming() #normalizePath() should normalize each part of the resource path and remove non-alpha-numeric characters', 'AwsCompileFunctions #compileRole() a...
['AwsProvider #getServerlessDeploymentBucketName() #getAccountId() should return the AWS account id', 'AwsCompileFunctions #compileFunctions() should create corresponding function output and version objects', 'AwsCompileFunctions #compileFunctions() should not create function output objects when "versionFunctions" is f...
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/index.test.js lib/plugins/aws/lib/naming.test.js lib/plugins/aws/info/getStackInfo.test.js lib/plugins/aws/provider/awsProvider.test.js --reporter json
Refactoring
false
false
false
true
6
2
8
false
false
["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:cfOutputDescriptionTemplate", "lib/plugins/aws/provider/awsProvider.js->program->class_declaration:AwsProvider", "lib/plugins/aws/lib/naming.js->program->method_definition:getLambdaOutputLogicalIdRegex...
serverless/serverless
2,910
serverless__serverless-2910
['2832']
ca1c6de6d86fc4258387de5790e097993728f59e
diff --git a/docs/providers/aws/events/schedule.md b/docs/providers/aws/events/schedule.md index 4dc7e6d0303..b5e32a024d9 100644 --- a/docs/providers/aws/events/schedule.md +++ b/docs/providers/aws/events/schedule.md @@ -46,3 +46,15 @@ functions: enabled: false inputPath: '$.stageVariables' ``` +...
diff --git a/lib/plugins/aws/deploy/compile/events/schedule/index.test.js b/lib/plugins/aws/deploy/compile/events/schedule/index.test.js index 91eea1e7376..de02c20f895 100644 --- a/lib/plugins/aws/deploy/compile/events/schedule/index.test.js +++ b/lib/plugins/aws/deploy/compile/events/schedule/index.test.js @@ -101,6 +...
CloudWatchEvent rule name and description fields ``` functions: run: handler: handler.run events: - schedule: rate: rate(10 minutes) enabled: false name: "I want my own name prefix here" description: "I want my own description here" ``` When deploying l...
Currently it's not supported. Any immediate plans on this? It makes hard to read the rules/metadata, especially in cases with 1000s of rules.
2016-12-10 04:52:23+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsCompileScheduledEvents #constructor() should set the provider variable to an instance of AwsProvider', 'AwsCompileScheduledEvents #compileScheduledEvents() should not create corresponding resources when scheduled events are not given', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect input varia...
['AwsCompileScheduledEvents #compileScheduledEvents() should respect name variable', 'AwsCompileScheduledEvents #compileScheduledEvents() should respect description variable']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/schedule/index.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/deploy/compile/events/schedule/index.js->program->class_declaration:AwsCompileScheduledEvents->method_definition:compileScheduledEvents"]
serverless/serverless
2,748
serverless__serverless-2748
['2673']
ffadf3da18475179aa622b5df6391b17e66e4f1a
diff --git a/docs/providers/aws/guide/functions.md b/docs/providers/aws/guide/functions.md index 6ead0c38da8..81166a2054b 100644 --- a/docs/providers/aws/guide/functions.md +++ b/docs/providers/aws/guide/functions.md @@ -220,19 +220,38 @@ Then, when you run `serverless deploy`, VPC configuration will be deployed along ...
diff --git a/lib/plugins/aws/deploy/compile/functions/tests/index.js b/lib/plugins/aws/deploy/compile/functions/tests/index.js index 7bb65192602..10792eca604 100644 --- a/lib/plugins/aws/deploy/compile/functions/tests/index.js +++ b/lib/plugins/aws/deploy/compile/functions/tests/index.js @@ -360,6 +360,170 @@ describe(...
Design Environment Variable Support # This is a Feature Proposal ## Description As environment variables are an often requested feature for Serverless and AWS I want to start the design process, so we can start with implementing support for Environment Variables when they become ready at AWS at some point in the ...
Great, if you need some help let me know. Cheers It would be great if there was an easy way to add a reference to a function for when you are invoking them. @flomotlik that looks great. How will this support external secrets? i.e. database password, JWT secret Right now they're built into the code package. But idea...
2016-11-20 00:16:13+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['AwsCompileFunctions #compileFunctions() should default to the nodejs4.3 runtime when no provider runtime is given', 'AwsCompileFunctions #compileFunctions() should prefer function declared role over provider declared role', 'AwsCompileFunctions #compileFunctions() should throw if no individual artifact', 'AwsCompileF...
['AwsCompileFunctions #compileFunctions() should create a function resource with provider level environment config', 'AwsCompileFunctions #compileFunctions() should throw an error if environment variable has invalid name', 'AwsCompileFunctions #compileFunctions() should create a function resource with function level en...
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/functions/tests/index.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/deploy/compile/functions/index.js->program->class_declaration:AwsCompileFunctions->method_definition:compileFunction"]
serverless/serverless
2,624
serverless__serverless-2624
['2610']
56c6c105e0dbf388307a74f6c9dd310f36ef2191
diff --git a/lib/classes/Utils.js b/lib/classes/Utils.js index 13e6fe3e187..420a33b5d20 100644 --- a/lib/classes/Utils.js +++ b/lib/classes/Utils.js @@ -184,6 +184,20 @@ class Utils { userId = this.readFileSync(statsEnabledFilePath).toString(); } + // filter out the whitelisted options + con...
diff --git a/lib/classes/Utils.test.js b/lib/classes/Utils.test.js index 4fc73b85d89..5e3f57e48ee 100644 --- a/lib/classes/Utils.test.js +++ b/lib/classes/Utils.test.js @@ -12,16 +12,17 @@ const Serverless = require('../../lib/Serverless'); const testUtils = require('../../tests/utils'); const serverlessVersion = req...
Whitelist and store options for slstats command # This is a Feature Proposal ## Description Some options such as `--help`, `--disable` or `--enable` should be whitelisted and stored alongside the corresponding command. This way we can e.g. see when the `--help` option is used for a specific command. /cc @world...
null
2016-11-04 09:31:14+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['Utils #findServicePath() should detect if the CWD is not a service directory', 'Utils #readFileSync() should read a file synchronously', 'Utils #fileExistsSync() When reading a file should detect if a file exists', 'Utils #generateShortId() should generate a shortId for the given length', 'Utils #logStat() should re-...
['Utils #logStat() should filter out whitelisted options', 'Utils #logStat() should send the gathered information']
['Utils #writeFileDir() should create a directory for the path of the given file']
. /usr/local/nvm/nvm.sh && npx mocha lib/classes/Utils.test.js --reporter json
Feature
false
true
false
false
1
0
1
true
false
["lib/classes/Utils.js->program->class_declaration:Utils->method_definition:logStat"]
serverless/serverless
2,588
serverless__serverless-2588
['2587']
5b8aacf4d8caf3dc35063c28c269d8a09645cb1a
diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js index 9dc087e83b0..99a99502c4e 100644 --- a/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js +++ b/lib/plugins/aws/deploy/compile/events/apiGateway/lib/validat...
diff --git a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js b/lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js index 39a7b479a61..f7fa2860679 100644 --- a/lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js +++ b/lib/plugins/aws/deploy/compile/events/apiGateway/tests...
resultTtlInSeconds defaults to 300 when set to 0 # This is a Bug Report ## Description * What went wrong? `resultTtlInSeconds` defaults to 300 when set to 0. This is oviously due to [this line](https://github.com/serverless/serverless/blob/f817933909cb524dcde729348bf229ae355e15ac/lib/plugins/aws/deploy/comp...
Yup thats a bug that needs to be resolved. Thanks
2016-11-01 23:58:08+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['#validate() should throw if an authorizer is an empty object', '#validate() should validate the http events object syntax method is case insensitive', '#validate() should accept an authorizer as a string', '#validate() should validate the http events string syntax method is case insensitive', '#validate() should acce...
['#validate() should accept authorizer config when resultTtlInSeconds is 0']
[]
. /usr/local/nvm/nvm.sh && npx mocha lib/plugins/aws/deploy/compile/events/apiGateway/tests/validate.js --reporter json
Bug Fix
false
true
false
false
1
0
1
true
false
["lib/plugins/aws/deploy/compile/events/apiGateway/lib/validate.js->program->method_definition:getAuthorizer"]
serverless/serverless
1,670
serverless__serverless-1670
['1521']
11fcea1331b4393e152cd81c4458d493f147f34a
diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js index 8bd9d73ea10..714fdab3365 100644 --- a/lib/classes/PluginManager.js +++ b/lib/classes/PluginManager.js @@ -129,13 +129,15 @@ class PluginManager { } addPlugin(Plugin) { - this.loadCommands(Plugin); + const pluginInstance = new P...
diff --git a/tests/classes/PluginManager.js b/tests/classes/PluginManager.js index 7dc65d6f4f7..79bfa8008b3 100644 --- a/tests/classes/PluginManager.js +++ b/tests/classes/PluginManager.js @@ -410,7 +410,8 @@ describe('PluginManager', () => { describe('#loadCommands()', () => { it('should load the plugin comm...
Plugins Are Being Loaded Twice ##### Serverless Framework Version: V.1 Alpha 1 ##### Operating System: OSX 10.11.2 ##### Expected Behavior: - Plugins should be loaded once, causing hooks and all else to be set only once. ##### Actual Behavior: - Plugins are loaded twice - This is because they are each instantiated twi...
Thanks for reporting! This is really not intended behavior. Will look into it ASAP.
2016-07-26 09:05:02+00:00
JavaScript
FROM polybench_javascript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && rm -rf node_modules && npm install --force
['PluginManager #loadAllPlugins() should load only core plugins when no service plugins are given', 'PluginManager #run() when using provider specific plugins should run only the providers plugins (if the provider is specified)', 'PluginManager #setCliCOmmands() should set the cliCommands array', 'PluginManager #constr...
['PluginManager #loadCommands() should load the plugin commands']
[]
. /usr/local/nvm/nvm.sh && npx mocha tests/classes/PluginManager.js --reporter json
Refactoring
false
true
false
false
2
0
2
false
false
["lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:addPlugin", "lib/classes/PluginManager.js->program->class_declaration:PluginManager->method_definition:loadCommands"]
microsoft/vscode
110,255
microsoft__vscode-110255
['88703', '88703']
5ce31a6e8b4feeb1079985aff2d1dce34dcd6876
diff --git a/src/vs/workbench/services/preferences/common/preferencesValidation.ts b/src/vs/workbench/services/preferences/common/preferencesValidation.ts --- a/src/vs/workbench/services/preferences/common/preferencesValidation.ts +++ b/src/vs/workbench/services/preferences/common/preferencesValidation.ts @@ -92,10 +92...
diff --git a/src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts b/src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts --- a/src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts +++ b/src/vs/workbench/services/preferences/test/common/pre...
Errors on fields with URI format not reported in Settings UI Found this issue while trying to set java.format.settings.url's format to uri (or uri-reference), in order to fix https://github.com/redhat-developer/vscode-java/issues/1237 <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.42.0-ins...
I guess we are missing that validation, also, the type of that setting should be `["string", "null"]` if the default is "null". ``` "type": "string", "description": "Specifies the url or file path to the [Eclipse formatter xml settings](https://github.com/redhat-developer/vscode-java/wiki/Forma...
2020-11-09 19:30:17+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:12-bullseye RUN apt-get update && apt-get install -y \ git \ xvfb \ libxtst6 \ libxss1 \ libgtk-3-0 \ libnss3 \ libasound2 \ libx11-dev \ libxkbfile-dev \ pkg-config \ libsecret-1-dev \ libgbm-dev \ libgbm1 \ python \ ma...
['Preferences Validation array of enums', 'Preferences Validation getInvalidTypeError', 'Preferences Validation pattern with error message', 'Preferences Validation integer type correctly adds a validation', 'Preferences Validation string max min length work', 'Preferences Validation min-max items array', 'Preferences ...
['Preferences Validation uri checks work']
[]
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/preferences/test/common/preferencesValidation.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/workbench/services/preferences/common/preferencesValidation.ts->program->function_declaration:getStringValidators"]
microsoft/vscode
114,208
microsoft__vscode-114208
['37570', '37570']
67f9988bdc476e99eedd50ae083ec3d90eb38604
diff --git a/src/vs/editor/contrib/snippet/snippetVariables.ts b/src/vs/editor/contrib/snippet/snippetVariables.ts --- a/src/vs/editor/contrib/snippet/snippetVariables.ts +++ b/src/vs/editor/contrib/snippet/snippetVariables.ts @@ -43,6 +43,7 @@ export const KnownSnippetVariableNames: { [key: string]: true } = Object.fr...
diff --git a/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts b/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts --- a/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts +++ b/src/vs/editor/contrib/snippet/test/snippetVariables.test.ts @@ -15,6 +15,7 @@ import { mock } from 'vs/base/test/...
Add relative directory/filepath support to snippets - VSCode Version: Code 1.17.1 (1e9d36539b0ae51ac09b9d4673ebea4e447e5353, 2017-10-10T14:24:41.632Z) - OS Version: Windows_NT ia32 6.3.9600 Currently, snippets allow you to resolve the current directory or filepath with `TM_DIRECTORY` and `TM_FILEPATH` respectively....
We have added [*Variable Transformations*](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_variable-transforms) for thing like this. Please give it a try I'm not sure how that would help in this case. If `TM_DIRECTORY` resolves to `C:\dev\projects\my_projects\secret_projects\secret_project1\features\secr...
2021-01-12 13:56:19+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:12-bullseye RUN apt-get update && apt-get install -y \ git \ xvfb \ libxtst6 \ libxss1 \ libgtk-3-0 \ libnss3 \ libasound2 \ libx11-dev \ libxkbfile-dev \ pkg-config \ libsecret-1-dev \ libgbm-dev \ libgbm1 \ python \ ma...
['Snippet Variables Resolver Snippet transforms do not handle regex with alternatives or optional matches, #36089', 'Snippet Variables Resolver editor variables, selection', 'Snippet Variables Resolver TextmateSnippet, resolve variable', 'Snippet Variables Resolver TextmateSnippet, resolve variable with default', 'Snip...
['Snippet Variables Resolver Add RELATIVE_FILEPATH snippet variable #114208']
[]
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/snippet/test/snippetVariables.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
1
0
1
true
false
["src/vs/editor/contrib/snippet/snippetVariables.ts->program->class_declaration:ModelBasedVariableResolver->method_definition:resolve"]
microsoft/vscode
118,226
microsoft__vscode-118226
['112032']
f7ff53d7b06a2ce14ff503dc2290b487d9162429
diff --git a/src/vs/editor/browser/services/openerService.ts b/src/vs/editor/browser/services/openerService.ts --- a/src/vs/editor/browser/services/openerService.ts +++ b/src/vs/editor/browser/services/openerService.ts @@ -166,7 +166,7 @@ export class OpenerService implements IOpenerService { // check with contribut...
diff --git a/src/vs/editor/test/browser/services/openerService.test.ts b/src/vs/editor/test/browser/services/openerService.test.ts --- a/src/vs/editor/test/browser/services/openerService.test.ts +++ b/src/vs/editor/test/browser/services/openerService.test.ts @@ -127,6 +127,20 @@ suite('OpenerService', function () { ...
Debug Console Linker automatically decodes link Issue Type: <b>Bug</b> When debugging code and a link has a URI encode clinking the link in the debug console will auto decode the URL. This causes issues as some APIs expect the paramaters to be URI encoded. When just logging links to the terminal it doesn't do that...
This is a fair request. Code pointer https://github.com/microsoft/vscode/blob/cf8ed37206e161a30151defa4fc9ea58c32335bc/src/vs/workbench/contrib/debug/browser/linkDetector.ts#L36 PR's to fix this are welcome. I put a code pointer... @isidorn Do you think terminal's behavior is correct or debug's behavior is correct....
2021-03-05 16:15:37+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['OpenerService delegate to editorService, scheme:///fff#123,123', 'OpenerService links validated by validators go to openers', 'OpenerService links invalidated by first validator do not continue validating', 'OpenerService links are protected by validators', 'Unexpected Errors & Loader Errors should not have unexpecte...
["OpenerService links aren't manipulated before being passed to validator: PR #118226"]
[]
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/services/openerService.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/editor/browser/services/openerService.ts->program->class_declaration:OpenerService->method_definition:open"]
microsoft/vscode
122,796
microsoft__vscode-122796
['122255', '122255']
c8bd5b211acd8055a81654dcf40367f422bc22e0
diff --git a/src/vs/editor/contrib/snippet/snippetParser.ts b/src/vs/editor/contrib/snippet/snippetParser.ts --- a/src/vs/editor/contrib/snippet/snippetParser.ts +++ b/src/vs/editor/contrib/snippet/snippetParser.ts @@ -388,11 +388,11 @@ export class FormatString extends Marker { } private _toPascalCase(value: str...
diff --git a/src/vs/editor/contrib/snippet/test/snippetParser.test.ts b/src/vs/editor/contrib/snippet/test/snippetParser.test.ts --- a/src/vs/editor/contrib/snippet/test/snippetParser.test.ts +++ b/src/vs/editor/contrib/snippet/test/snippetParser.test.ts @@ -655,6 +655,7 @@ suite('SnippetParser', () => { assert.stri...
The pascalCase snippet formatter fails to process numbers <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-S...
2021-05-01 17:27:42+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['SnippetParser Parser, escaped', 'SnippetParser Snippet order for placeholders, #28185', 'SnippetParser parser, parent node', 'SnippetParser Parser, placeholder transforms', 'SnippetParser TextmateSnippet#offset', 'SnippetParser No way to escape forward slash in snippet format section #37562', 'SnippetParser Parser, o...
['SnippetParser Transform -> FormatString#resolve']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/snippet/test/snippetParser.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/editor/contrib/snippet/snippetParser.ts->program->class_declaration:FormatString->method_definition:_toPascalCase"]
microsoft/vscode
123,112
microsoft__vscode-123112
['121125', '121125']
2000f36fdefb06321db6ceaa893e9b7e92e0f466
diff --git a/src/vs/editor/common/modes/supports/onEnter.ts b/src/vs/editor/common/modes/supports/onEnter.ts --- a/src/vs/editor/common/modes/supports/onEnter.ts +++ b/src/vs/editor/common/modes/supports/onEnter.ts @@ -64,7 +64,12 @@ export class OnEnterSupport { reg: rule.previousLineText, text: previousLi...
diff --git a/src/vs/editor/test/common/modes/supports/onEnter.test.ts b/src/vs/editor/test/common/modes/supports/onEnter.test.ts --- a/src/vs/editor/test/common/modes/supports/onEnter.test.ts +++ b/src/vs/editor/test/common/modes/supports/onEnter.test.ts @@ -47,6 +47,40 @@ suite('OnEnter', () => { testIndentAction('...
onEnterRules works one in two times <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- �...
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: - [Add support for capture groups in onEnterRules (#17281)](https://www.github.com/microsoft/vscode/issues/17281) <!-- score: 0.586 --> <!-- potential_duplicates_comment --> (Experim...
2021-05-06 11:44:04+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['OnEnter uses brackets', 'OnEnter uses regExpRules', 'Unexpected Errors & Loader Errors should not have unexpected errors']
['OnEnter Issue #121125: onEnterRules with global modifier']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/modes/supports/onEnter.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/editor/common/modes/supports/onEnter.ts->program->class_declaration:OnEnterSupport->method_definition:onEnter"]
microsoft/vscode
124,621
microsoft__vscode-124621
['124279', '124279']
8ccc1243fc062396f987fd471ddc1700fb866f77
diff --git a/src/vs/workbench/common/notifications.ts b/src/vs/workbench/common/notifications.ts --- a/src/vs/workbench/common/notifications.ts +++ b/src/vs/workbench/common/notifications.ts @@ -619,13 +619,17 @@ export class NotificationViewItem extends Disposable implements INotificationVie } updateSeverity(sev...
diff --git a/src/vs/workbench/test/common/notifications.test.ts b/src/vs/workbench/test/common/notifications.test.ts --- a/src/vs/workbench/test/common/notifications.test.ts +++ b/src/vs/workbench/test/common/notifications.test.ts @@ -10,6 +10,7 @@ import { INotification, Severity, NotificationsFilter } from 'vs/platfo...
Codespaces progress notification makes links not clickable https://user-images.githubusercontent.com/35271042/119018546-08705080-b951-11eb-8505-0e063aa81629.mp4 1. Create a new codespaces using the vscode repo 2. Try clicking on the logs link 3. :bug: Unable to click on the link Upon inspecting the DOM, it ap...
Following up upstream first... @bpasero what do you think about not rerendering the notification message if the content didn't change between calls to report? In the codespaces extension I send fake progress updates quickly to smooth out the progress bar, and you can't click a link if it updates at the moment you are c...
2021-05-25 23:41:06+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['Notifications Service', 'Notifications Items', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'Notifications Model']
['Notifications Items - does not fire changed when message did not change (content, severity)']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/test/common/notifications.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
2
0
2
false
false
["src/vs/workbench/common/notifications.ts->program->class_declaration:NotificationViewItem->method_definition:updateMessage", "src/vs/workbench/common/notifications.ts->program->class_declaration:NotificationViewItem->method_definition:updateSeverity"]
microsoft/vscode
127,257
microsoft__vscode-127257
['113992']
4cd4fd9a0b30e4fbc2a719707288ccec2fcf7e9f
diff --git a/src/vs/editor/contrib/snippet/snippet.md b/src/vs/editor/contrib/snippet/snippet.md --- a/src/vs/editor/contrib/snippet/snippet.md +++ b/src/vs/editor/contrib/snippet/snippet.md @@ -91,7 +91,7 @@ variable ::= '$' var | '${' var }' | '${' var transform '}' transform ::= '/' regex '/' ...
diff --git a/src/vs/editor/contrib/snippet/test/snippetParser.test.ts b/src/vs/editor/contrib/snippet/test/snippetParser.test.ts --- a/src/vs/editor/contrib/snippet/test/snippetParser.test.ts +++ b/src/vs/editor/contrib/snippet/test/snippetParser.test.ts @@ -656,6 +656,8 @@ suite('SnippetParser', () => { assert.stri...
camelcase snippet variable format <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> I see the gr...
Just FYI, I believe pascalcase is also supported but undocumented. > Just FYI, I believe pascalcase is also supported but undocumented. The docs were updated to include `/pascalcase` in https://github.com/microsoft/vscode-docs/pull/4434
2021-06-27 13:21:22+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['SnippetParser Parser, escaped', 'SnippetParser Snippet order for placeholders, #28185', 'SnippetParser parser, parent node', 'SnippetParser Parser, placeholder transforms', 'SnippetParser TextmateSnippet#offset', 'SnippetParser No way to escape forward slash in snippet format section #37562', 'SnippetParser Parser, o...
['SnippetParser Transform -> FormatString#resolve']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/snippet/test/snippetParser.test.ts --reporter json --no-sandbox --exit
Feature
false
false
false
true
2
1
3
false
false
["src/vs/editor/contrib/snippet/snippetParser.ts->program->class_declaration:FormatString", "src/vs/editor/contrib/snippet/snippetParser.ts->program->class_declaration:FormatString->method_definition:resolve", "src/vs/editor/contrib/snippet/snippetParser.ts->program->class_declaration:FormatString->method_definition:_t...
microsoft/vscode
128,931
microsoft__vscode-128931
['128930']
3c0f268745ec4de8b6e1b6a2cd2dac88a578b54d
diff --git a/extensions/emmet/src/balance.ts b/extensions/emmet/src/balance.ts --- a/extensions/emmet/src/balance.ts +++ b/extensions/emmet/src/balance.ts @@ -67,8 +67,17 @@ function getRangeToBalanceOut(document: vscode.TextDocument, rootNode: HtmlFlatN return offsetRangeToSelection(document, nodeToBalance.start, n...
diff --git a/src/vs/editor/contrib/bracketMatching/test/bracketMatching.test.ts b/src/vs/editor/contrib/bracketMatching/test/bracketMatching.test.ts --- a/src/vs/editor/contrib/bracketMatching/test/bracketMatching.test.ts +++ b/src/vs/editor/contrib/bracketMatching/test/bracketMatching.test.ts @@ -112,11 +112,11 @@ sui...
Select to Matching Bracket direction should be end position to start position. <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describ...
null
2021-07-18 04:00:50+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['bracket matching issue #43371: argument to not select brackets', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'bracket matching Jump to next bracket', 'bracket matching issue #183: jump to matching bracket position', 'bracket matching issue #1772: jump to enclosing brackets']
['bracket matching Select to next bracket', 'bracket matching issue #45369: Select to Bracket with multicursor']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/bracketMatching/test/bracketMatching.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
2
0
2
false
false
["extensions/emmet/src/balance.ts->program->function_declaration:getRangeToBalanceOut", "src/vs/editor/contrib/bracketMatching/bracketMatching.ts->program->class_declaration:BracketMatchingController->method_definition:selectToBracket"]
microsoft/vscode
130,088
microsoft__vscode-130088
['98682']
f944203712c5acab228e1c3bfe38ef3a2d26a7b7
diff --git a/src/bootstrap-fork.js b/src/bootstrap-fork.js --- a/src/bootstrap-fork.js +++ b/src/bootstrap-fork.js @@ -16,7 +16,7 @@ const bootstrapNode = require('./bootstrap-node'); bootstrapNode.removeGlobalNodeModuleLookupPaths(); // Enable ASAR in our forked processes -bootstrap.enableASARSupport(undefined, fa...
diff --git a/src/vs/base/test/common/network.test.ts b/src/vs/base/test/common/network.test.ts --- a/src/vs/base/test/common/network.test.ts +++ b/src/vs/base/test/common/network.test.ts @@ -7,12 +7,11 @@ import * as assert from 'assert'; import { URI } from 'vs/base/common/uri'; import { FileAccess, Schemas } from '...
Remove dependency on node require for startup code path Refs https://github.com/microsoft/vscode/issues/92164 **Things to do:** * [x] V8 cached options support (needs Electron patch) @deepak1556 * [x] :runner: validate no performance regressions * [x] remove traces of node cached data (e.g. cleanup from shared p...
Another topic that is directly related to the startup path is code caching. Currently we rely on https://nodejs.org/api/vm.html#vm_script_createcacheddata to create the cache data and use for scripts required via node. In the sandbox case, we will have to rely on the code caching from blink. The cache data created in b...
2021-08-04 07:36:58+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['network FileAccess: web', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'network FileAccess: remote URIs', 'network FileAccess: query and fragment is kept if URI is already of same scheme (native)']
['network FileAccess: moduleId (native)', 'network FileAccess: query and fragment is dropped (native)', 'network FileAccess: URI (native)']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/network.test.ts --reporter json --no-sandbox --exit
Refactoring
false
false
false
true
14
2
16
false
false
["src/main.js->program->function_declaration:configureCommandlineSwitchesSync", "src/bootstrap.js->program->function_declaration:enableASARSupport", "src/vs/base/common/network.ts->program->class_declaration:FileAccessImpl->method_definition:asBrowserUri", "src/vs/base/common/network.ts->program->class_declaration:File...
microsoft/vscode
132,041
microsoft__vscode-132041
['132034']
b6a7847b1d6be302f579ef39d2b9ab891d92eed6
diff --git a/package.json b/package.json --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "code-oss-dev", "version": "1.60.0", - "distro": "a60fae6331fa2ff607b18e7b1b20ef0db02430d2", + "distro": "0ea9111ff3b92a2070f03c531e3af26435112451", "author": { "name": "Microsoft Corporation" },...
diff --git a/src/vs/workbench/services/extensions/test/common/extensionManifestPropertiesService.test.ts b/src/vs/workbench/services/extensions/test/common/extensionManifestPropertiesService.test.ts --- a/src/vs/workbench/services/extensions/test/common/extensionManifestPropertiesService.test.ts +++ b/src/vs/workbench/...
Remove web extension kind Remove web extension kind
null
2021-09-01 10:01:12+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:14 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['ExtensionManifestPropertiesService - ExtensionUntrustedWorkspaceSupportType test extension workspace trust request when workspace trust is disabled', 'ExtensionManifestPropertiesService - ExtensionKind simple declarative => ui, workspace, web', 'ExtensionManifestPropertiesService - ExtensionKind only browser => web',...
['ExtensionManifestPropertiesService - ExtensionKind extension cannot opt into web', 'ExtensionManifestPropertiesService - ExtensionKind extension cannot opt into web only']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/extensions/test/common/extensionManifestPropertiesService.test.ts --reporter json --no-sandbox --exit
Refactoring
false
true
false
false
1
0
1
true
false
["src/vs/workbench/services/extensions/common/extensionManifestPropertiesService.ts->program->class_declaration:ExtensionManifestPropertiesService->method_definition:getConfiguredExtensionKind"]
microsoft/vscode
146,962
microsoft__vscode-146962
['144736']
d215bada5eabe56781024a2c943d53ffb18f16a4
diff --git a/extensions/shellscript/package.json b/extensions/shellscript/package.json --- a/extensions/shellscript/package.json +++ b/extensions/shellscript/package.json @@ -76,7 +76,13 @@ { "language": "shellscript", "scopeName": "source.shell", - "path": "./syntaxes/shell-unix-bash.tm...
diff --git a/src/vs/editor/test/common/model/bracketPairColorizer/tokenizer.test.ts b/src/vs/editor/test/common/model/bracketPairColorizer/tokenizer.test.ts --- a/src/vs/editor/test/common/model/bracketPairColorizer/tokenizer.test.ts +++ b/src/vs/editor/test/common/model/bracketPairColorizer/tokenizer.test.ts @@ -27,8 ...
Use textmate grammar token kind to exclude unbalanced brackets from being colorized When a bracket is marked as comment, string or regexp token, it is not considered for bracket pair matching. It would be great to have a `non-bracket` token, so that we can use `<` ... `>` in languages such as TypeScript or rust, where ...
I like the idea of taking advantage of parsing result. However, I wonder if it's reliable to use TextMate-based tokenization. TextMate grammar has serious limitations, and cannot correctly express many languages, like C++, TypeScript, HTML, and Markdown. For example, we **have to compile** the whole project first to...
2022-04-06 22:43:41+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'Bracket Pair Colorizer - Tokenizer Basic']
['Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/model/bracketPairColorizer/tokenizer.test.ts src/vs/editor/test/common/model/tokensStore.test.ts src/vs/editor/test/common/model/textModelWithTok...
Feature
false
true
false
false
6
0
6
false
false
["src/vs/editor/common/tokens/contiguousTokensStore.ts->program->function_declaration:getDefaultMetadata", "src/vs/workbench/services/textMate/common/TMGrammarFactory.ts->program->class_declaration:TMGrammarFactory->method_definition:createGrammar", "src/vs/workbench/services/textMate/browser/abstractTextMateService.ts...
microsoft/vscode
148,563
microsoft__vscode-148563
['145773']
7051cd2f106fb1e7ebdf64b8a736dc880ab22bd2
diff --git a/src/vs/workbench/common/editor/editorGroupModel.ts b/src/vs/workbench/common/editor/editorGroupModel.ts --- a/src/vs/workbench/common/editor/editorGroupModel.ts +++ b/src/vs/workbench/common/editor/editorGroupModel.ts @@ -567,7 +567,7 @@ export class EditorGroupModel extends Disposable { kind: GroupMod...
diff --git a/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts b/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts --- a/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts +++ b/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts @@ -2232,6 +2232,40 @...
Tab object `isPinned` not correctly updated after pinning tab Testing #145585 1. Pin a tab 2. `onDidChangeTab` event fires but tab object has `isPinned` set to false, also `isPreview` is set to true
@lramos15 😞 this would have been a wonderful case for integration test. I think we really need to cover tabs API with an extensive set of tests given it is so easy to test. Here is a test that fails before your change and succeeds after: ```ts test('Tabs - verify pinned state', async () => { const [docA] =...
2022-05-02 14:08:08+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['EditorGroupModel Single Group, Single Editor - persist', 'EditorGroupModel Multiple Editors - Pinned and Active', 'EditorGroupModel Multiple Editors - real user example', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'EditorGroupModel...
['EditorGroupModel Sticky/Unsticky Editors sends correct editor index']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
3
0
3
false
false
["src/vs/workbench/common/editor/editorGroupModel.ts->program->class_declaration:EditorGroupModel->method_definition:doUnstick", "src/vs/workbench/common/editor/editorGroupModel.ts->program->class_declaration:EditorGroupModel->method_definition:moveEditor", "src/vs/workbench/common/editor/editorGroupModel.ts->program->...
microsoft/vscode
148,751
microsoft__vscode-148751
['147363']
c08941b87c2218df5538ae6d3bb48393eca8168b
diff --git a/src/vs/base/browser/markdownRenderer.ts b/src/vs/base/browser/markdownRenderer.ts --- a/src/vs/base/browser/markdownRenderer.ts +++ b/src/vs/base/browser/markdownRenderer.ts @@ -152,7 +152,7 @@ export function renderMarkdown(markdown: IMarkdownString, options: MarkdownRende .replace(/>/g, '&gt;') ...
diff --git a/src/vs/base/test/browser/markdownRenderer.test.ts b/src/vs/base/test/browser/markdownRenderer.test.ts --- a/src/vs/base/test/browser/markdownRenderer.test.ts +++ b/src/vs/base/test/browser/markdownRenderer.test.ts @@ -148,7 +148,7 @@ suite('MarkdownRenderer', () => { mds.appendMarkdown(`[$(zap)-link](#...
"Don't show again" action is not clickable / doesn't work This message right here: <img width="474" alt="image" src="https://user-images.githubusercontent.com/32465942/163148022-f0455cde-552d-44ad-a512-235a644b24da.png"> When i click on "Don't show again", it doesn't really work: as soon as i navigate to that input...
`git bisect` says this regressed with https://github.com/microsoft/vscode/commit/69d1ad8c65c9fa412fdf9f29abaab1f950be447f.
2022-05-04 23:29:50+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['MarkdownRenderer Images image width from title params', 'MarkdownRenderer supportHtml Should not include scripts even when supportHtml=true', 'MarkdownRenderer Sanitization Should not render images with unknown schemes', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clea...
['MarkdownRenderer ThemeIcons Support On render icon in link', 'MarkdownRenderer ThemeIcons Support On render icon in table']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/browser/markdownRenderer.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/base/browser/markdownRenderer.ts->program->function_declaration:renderMarkdown"]
microsoft/vscode
149,380
microsoft__vscode-149380
['149283']
5b8bd1c45ca3041a2a947e499d2db21c0a2df20d
diff --git a/src/vs/workbench/contrib/debug/node/terminals.ts b/src/vs/workbench/contrib/debug/node/terminals.ts --- a/src/vs/workbench/contrib/debug/node/terminals.ts +++ b/src/vs/workbench/contrib/debug/node/terminals.ts @@ -120,6 +120,10 @@ export function prepareCommand(shell: string, args: string[], cwd?: string, ...
diff --git a/src/vs/workbench/contrib/debug/test/node/terminals.test.ts b/src/vs/workbench/contrib/debug/test/node/terminals.test.ts new file mode 100644 --- /dev/null +++ b/src/vs/workbench/contrib/debug/test/node/terminals.test.ts @@ -0,0 +1,76 @@ +/*-------------------------------------------------------------------...
Some terminal launch config args are double-escaped Run this launch config ```json { "type": "node", "request": "launch", "name": "Run", "runtimeVersion": "16.4.0", "program": "${file}", "console": "integratedTerminal", "args": [">", "> hello.txt"] }, ``` This creates a file ...
null
2022-05-12 17:49:46+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Debug - prepareCommand cmd', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Debug - prepareCommand cmd - do not escape > and <', 'Debug - prepareCommand powershell - do not escape > and <', 'Unexpected Errors & Loader Errors should no...
['Debug - prepareCommand bash', 'Debug - prepareCommand bash - do not escape > and <']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/debug/test/node/terminals.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/workbench/contrib/debug/node/terminals.ts->program->function_declaration:prepareCommand"]
microsoft/vscode
150,052
microsoft__vscode-150052
['143832']
8d15d2f9d00c6487d5afb54d7437dfc98a5647b6
diff --git a/src/vs/workbench/contrib/terminal/browser/links/terminalLinkOpeners.ts b/src/vs/workbench/contrib/terminal/browser/links/terminalLinkOpeners.ts --- a/src/vs/workbench/contrib/terminal/browser/links/terminalLinkOpeners.ts +++ b/src/vs/workbench/contrib/terminal/browser/links/terminalLinkOpeners.ts @@ -170,7...
diff --git a/src/vs/workbench/contrib/terminal/test/browser/links/terminalLinkOpeners.test.ts b/src/vs/workbench/contrib/terminal/test/browser/links/terminalLinkOpeners.test.ts --- a/src/vs/workbench/contrib/terminal/test/browser/links/terminalLinkOpeners.test.ts +++ b/src/vs/workbench/contrib/terminal/test/browser/lin...
Terminal cwd seems to be behind a command At least, that's what it seems like. Testing https://github.com/microsoft/vscode/issues/141502 with Powershell 7 1. Follow the setup for `a` and `b`. 2. Open vscode in folder `a` 3. In the terminal, `cd ../b` 4. In the terminal, _type out_ `echo foo.txt` without hitting e...
Ah this is because the command doesn't get fully registered until it finishes, same root cause as https://github.com/microsoft/vscode/issues/143704 This works but the opened file has a strange breadcrumb: ![image](https://user-images.githubusercontent.com/30305945/160063694-a049d701-f175-4409-8766-3af87f52f8f3.png) ...
2022-05-20 19:52:46+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Workbench - TerminalLinkOpeners TerminalSearchLinkOpener macOS/Linux should apply the cwd to the link only when the file exists and cwdDetection is enabled', 'Unexpected Errors & Loader Er...
['Workbench - TerminalLinkOpeners TerminalSearchLinkOpener Windows should apply the cwd to the link only when the file exists and cwdDetection is enabled']
['Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing ...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminal/test/browser/links/terminalLinkOpeners.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/workbench/contrib/terminal/browser/links/terminalLinkOpeners.ts->program->class_declaration:TerminalSearchLinkOpener->method_definition:_getExactMatch"]
microsoft/vscode
152,802
microsoft__vscode-152802
['151933']
3997bb78d8007a964633e0680cd1ce95b8df1be9
diff --git a/src/vs/platform/terminal/node/terminalEnvironment.ts b/src/vs/platform/terminal/node/terminalEnvironment.ts --- a/src/vs/platform/terminal/node/terminalEnvironment.ts +++ b/src/vs/platform/terminal/node/terminalEnvironment.ts @@ -118,6 +118,9 @@ export function getShellIntegrationInjection( const shell =...
diff --git a/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts b/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts --- a/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts +++ b/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts @@ -33,7 +33,10 @@ suite('platform - term...
Allow running shell integration scripts inside an rc file Currently shell integration scripts source rc/profile files here for example: https://github.com/microsoft/vscode/blob/b8b2e9c7f72442617cc43b915d33479fa911247b/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh#L8-L25 When using a man...
null
2022-06-21 22:05:20+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['platform - terminalEnvironment getShellIntegrationInjection bash should override args should not modify args when shell integration is disabled', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'platform - terminalEnvironment getShellIn...
['platform - terminalEnvironment getShellIntegrationInjection pwsh should override args when no logo array - case insensitive', 'platform - terminalEnvironment getShellIntegrationInjection zsh should override args should incorporate login arg when array', 'platform - terminalEnvironment getShellIntegrationInjection bas...
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/terminal/test/node/terminalEnvironment.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
1
0
1
true
false
["src/vs/platform/terminal/node/terminalEnvironment.ts->program->function_declaration:getShellIntegrationInjection"]
microsoft/vscode
155,261
microsoft__vscode-155261
['154582']
1cd90cceddf3c413673963ab6f154d2ff294b17c
diff --git a/src/vs/platform/contextkey/common/contextkey.ts b/src/vs/platform/contextkey/common/contextkey.ts --- a/src/vs/platform/contextkey/common/contextkey.ts +++ b/src/vs/platform/contextkey/common/contextkey.ts @@ -53,6 +53,7 @@ export interface IContextKeyExprMapper { mapSmallerEquals(key: string, value: any...
diff --git a/src/vs/platform/contextkey/test/common/contextkey.test.ts b/src/vs/platform/contextkey/test/common/contextkey.test.ts --- a/src/vs/platform/contextkey/test/common/contextkey.test.ts +++ b/src/vs/platform/contextkey/test/common/contextkey.test.ts @@ -179,6 +179,21 @@ suite('ContextKeyExpr', () => { asser...
Support "not in" context key expression We have this `in` keyword: https://code.visualstudio.com/api/references/when-clause-contexts#in-conditional-operator It seems impossible to do `not in`. I need this for https://github.com/microsoft/vscode-jupyter/issues/10595 (continuation of https://github.com/microsoft/vscod...
null
2022-07-15 02:27:44+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['ContextKeyExpr evaluate', 'ContextKeyExpr ContextKeyExpr.equals', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'ContextKeyExpr issue #129625: Removes duplicated terms in AND expressions', 'ContextKeyExpr negate', 'ContextKeyExpr Grea...
['ContextKeyExpr ContextKeyNotInExpr']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/contextkey/test/common/contextkey.test.ts --reporter json --no-sandbox --exit
Feature
false
false
false
true
13
1
14
false
false
["src/vs/platform/contextkey/common/contextkey.ts->program->class_declaration:ContextKeyNotInExpr", "src/vs/platform/contextkey/common/contextkey.ts->program->class_declaration:ContextKeyNotInExpr->method_definition:cmp", "src/vs/platform/contextkey/common/contextkey.ts->program->method_definition:_deserializeOne", "sr...
microsoft/vscode
156,733
microsoft__vscode-156733
['156440']
dbae720630e5996cc4d05c14649480a19b077d78
diff --git a/src/vs/code/electron-sandbox/issue/issueReporterModel.ts b/src/vs/code/electron-sandbox/issue/issueReporterModel.ts --- a/src/vs/code/electron-sandbox/issue/issueReporterModel.ts +++ b/src/vs/code/electron-sandbox/issue/issueReporterModel.ts @@ -34,6 +34,7 @@ export interface IssueReporterData { experime...
diff --git a/src/vs/code/test/electron-sandbox/issue/testReporterModel.test.ts b/src/vs/code/test/electron-sandbox/issue/testReporterModel.test.ts --- a/src/vs/code/test/electron-sandbox/issue/testReporterModel.test.ts +++ b/src/vs/code/test/electron-sandbox/issue/testReporterModel.test.ts @@ -34,6 +34,7 @@ undefined ...
Sandbox: Enable on Insiders by default
null
2022-07-31 05:09:09+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['IssueReporter sets defaults to include all data', 'IssueReporter should normalize GitHub urls', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'IssueReporter should...
['IssueReporter should supply mode if applicable', 'IssueReporter serializes remote information when data is provided', 'IssueReporter serializes model skeleton when no data is provided', 'IssueReporter serializes experiment info when data is provided', 'IssueReporter serializes Linux environment information when data ...
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/code/test/electron-sandbox/issue/testReporterModel.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
4
0
4
false
false
["src/vs/platform/windows/electron-main/window.ts->program->class_declaration:CodeWindow->method_definition:constructor", "src/vs/workbench/electron-sandbox/parts/dialogs/dialogHandler.ts->program->class_declaration:NativeDialogHandler->method_definition:about", "src/vs/code/electron-sandbox/issue/issueReporterModel.ts...
microsoft/vscode
158,371
microsoft__vscode-158371
['157489']
9759525167327f6279d85065e4e3bf9c1fadef41
diff --git a/src/vs/platform/editor/common/editor.ts b/src/vs/platform/editor/common/editor.ts --- a/src/vs/platform/editor/common/editor.ts +++ b/src/vs/platform/editor/common/editor.ts @@ -166,11 +166,6 @@ export enum EditorResolution { */ PICK, - /** - * Disables editor resolving. - */ - DISABLED, - /** ...
diff --git a/src/vs/workbench/services/editor/test/browser/editorService.test.ts b/src/vs/workbench/services/editor/test/browser/editorService.test.ts --- a/src/vs/workbench/services/editor/test/browser/editorService.test.ts +++ b/src/vs/workbench/services/editor/test/browser/editorService.test.ts @@ -4,7 +4,7 @@ *--...
Remove `EditorResolution.DISABLED` Now that the editor resolver is no longer doing any work when passing in an instance of `EditorInput` I think we should remove `EditorResolution.DISABLED`. If the intent of a component is to force open a text editor, it can still use the ID of the default association.
null
2022-08-17 13:40:43+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running', 'Unexpected Errors & Loader Errors should not hav...
['PreferencesService options are preserved when calling openEditor']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/preferences/test/browser/preferencesService.test.ts src/vs/workbench/test/browser/parts/editor/editor.test.ts src/vs/workbench/services/editor/te...
Refactoring
false
true
false
false
12
0
12
false
false
["src/vs/workbench/api/common/extHostTypeConverters.ts->program->function_declaration:from", "src/vs/workbench/services/workingCopy/common/workingCopyBackupTracker.ts->program->method_definition:restoreBackups", "src/vs/workbench/contrib/welcomeWalkthrough/browser/editor/editorWalkThrough.ts->program->class_declaration...
microsoft/vscode
159,031
microsoft__vscode-159031
['156874']
c27c1638ecc4077a49958cd3ffacbe4e24a2a320
diff --git a/src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts b/src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts --- a/src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts +++ b/src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts @@ -12,6 +12,7 @@ import ...
diff --git a/src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts b/src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts --- a/src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts +++ b/src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts @@ -105,12 +105,1...
Sticky Scroll is slow for large files * it would be good if rendering the sticky scroll would not iterate over all the ranges * you can try with https://github.com/microsoft/TypeScript/blob/main/src/compiler/checker.ts * idea we discussed: * when creating the ranges, capture the parent index for each one of them ...
null
2022-08-24 09:36:57+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Sticky Scroll Tests issue #157180: Render the correct line corresponding to the scope definition', 'Sticky Scroll Tests issue #156268 : Do not reveal sticky lines when they are in a folded...
['Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running', 'Sticky Scroll Tests Testing the function getCandidateStickyLinesIntersecting']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts --reporter json --no-sandbox --exit
Refactoring
false
false
false
true
3
2
5
false
false
["src/vs/editor/contrib/stickyScroll/browser/stickyScrollWidget.ts->program->class_declaration:StickyScrollWidget", "src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts->program->class_declaration:StickyLineCandidateProvider->method_definition:getCandidateStickyLinesIntersectingFromOutline", "src/vs/edit...
microsoft/vscode
159,554
microsoft__vscode-159554
['121322']
0ddb3aef528d970c8371db1fc89775ddcaa61e1b
diff --git a/src/vs/workbench/common/editor/editorInput.ts b/src/vs/workbench/common/editor/editorInput.ts --- a/src/vs/workbench/common/editor/editorInput.ts +++ b/src/vs/workbench/common/editor/editorInput.ts @@ -262,12 +262,9 @@ export abstract class EditorInput extends AbstractEditorInput { // Untyped inputs: go...
diff --git a/src/vs/workbench/test/browser/parts/editor/editorInput.test.ts b/src/vs/workbench/test/browser/parts/editor/editorInput.test.ts --- a/src/vs/workbench/test/browser/parts/editor/editorInput.test.ts +++ b/src/vs/workbench/test/browser/parts/editor/editorInput.test.ts @@ -10,6 +10,7 @@ import { URI } from 'vs...
Webviews should use onWillMoveEditor Currently Webviews (and by extension custom editors) require the input to know what group they're being opened in to handle the moving of the webview without a re-render. I recently added `onWillMoveEditor` for notebooks to handle this case. This should be adopted to remove the depe...
@lramos15 I looked into this but it seemed like adopting onWillMoveEditor would actually complicate the webview code (we'd have to move the webview into a pool where it can then be adopted by another editor?) Does webviews not adopting this block your work in any way? > Does webviews not adopting this block your wor...
2022-08-30 12:25:13+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'EditorInput untyped matches', 'EditorInput Untpyed inputs properly match TextResourceEditorInput', 'Unexpected Errors...
['EditorInput Untyped inputs properly match UntitledTextEditorInput', 'EditorInput Untyped inputs properly match FileEditorInput', 'EditorInput Untyped inputs properly match DiffEditorInput', 'EditorInput Untyped inputs properly match MergeEditorInput']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/test/browser/parts/editor/editorInput.test.ts src/vs/workbench/test/browser/workbenchTestServices.ts --reporter json --no-sandbox --exit
Refactoring
false
true
false
false
6
0
6
false
false
["src/vs/workbench/common/editor/editorInput.ts->program->method_definition:matches", "src/vs/workbench/services/editor/common/editorGroupFinder.ts->program->function_declaration:isOpened", "src/vs/workbench/services/editor/common/editorGroupFinder.ts->program->function_declaration:isActive", "src/vs/workbench/contrib/...
microsoft/vscode
159,670
microsoft__vscode-159670
['157611']
d00804ec9b15b4a8ee064f601de1aa4a31510e55
diff --git a/src/vs/platform/terminal/node/terminalEnvironment.ts b/src/vs/platform/terminal/node/terminalEnvironment.ts --- a/src/vs/platform/terminal/node/terminalEnvironment.ts +++ b/src/vs/platform/terminal/node/terminalEnvironment.ts @@ -184,7 +184,7 @@ export function getShellIntegrationInjection( newArgs = [...
diff --git a/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts b/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts --- a/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts +++ b/src/vs/platform/terminal/test/node/terminalEnvironment.test.ts @@ -4,6 +4,7 @@ *----------------------...
The terminal cannot be opened when multiple users use remote-ssh Type: <b>Bug</b> The terminal cannot be opened when multiple users use remote-ssh When I used Remote-SSH today, I found that the terminal could not be opened. After checking the log, I found the following error output: ``` [2022-08-09 15:52:42.302] [r...
EDIT: I found the log... ~~It looks like~~ I encountered the same problem. When upgrading to 1.70 the zsh shell only opens for the first remote user... You can find the error log in `OUTPUT` of `Log (Remote Server)`, as shown below. <img width="1099" alt="" src="https://user-images.githubusercontent.com/3369516...
2022-08-31 13:25:03+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['platform - terminalEnvironment getShellIntegrationInjection bash should override args should not modify args when shell integration is disabled', 'platform - terminalEnvironment getShellIntegrationInjection pwsh should override args when undefined, []', 'Tests are using suiteSetup and setup correctly assertCleanState...
['platform - terminalEnvironment getShellIntegrationInjection zsh should override args should incorporate login arg when array', 'platform - terminalEnvironment getShellIntegrationInjection zsh should override args when undefined, []']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/platform/terminal/test/node/terminalEnvironment.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/platform/terminal/node/terminalEnvironment.ts->program->function_declaration:getShellIntegrationInjection"]
microsoft/vscode
161,597
microsoft__vscode-161597
['161593']
a6278ba6889f56ac2c39a3397b9568c5b0b71075
diff --git a/src/vs/workbench/contrib/terminal/browser/terminal.ts b/src/vs/workbench/contrib/terminal/browser/terminal.ts --- a/src/vs/workbench/contrib/terminal/browser/terminal.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminal.ts @@ -921,7 +921,7 @@ export interface ITerminalContextualActionOptions { com...
diff --git a/src/vs/workbench/contrib/terminal/test/browser/contextualActionAddon.test.ts b/src/vs/workbench/contrib/terminal/test/browser/contextualActionAddon.test.ts --- a/src/vs/workbench/contrib/terminal/test/browser/contextualActionAddon.test.ts +++ b/src/vs/workbench/contrib/terminal/test/browser/contextualActio...
Change terminal quick fix exit code checking to simple fail and success Windows exit codes normally act differently, I suggest we just check success and fail instead of specific exit codes. Alternatively we could just do this on Windows, it's not worth the effort imo though as it's added complexity (eg. we need to make...
null
2022-09-23 12:58:38+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['ContextualActionAddon registerCommandFinishedListener & getMatchActions gitCreatePr returns undefined when failure exit status', 'ContextualActionAddon registerCommandFinishedListener & getMatchActions freePort returns undefined when output does not match', 'ContextualActionAddon registerCommandFinishedListener & get...
['ContextualActionAddon registerCommandFinishedListener & getMatchActions gitPushSetUpstream returns undefined when matching exit status', 'ContextualActionAddon registerCommandFinishedListener & getMatchActions gitSimilarCommand returns undefined when matching exit status']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminal/test/browser/contextualActionAddon.test.ts --reporter json --no-sandbox --exit
Refactoring
false
true
false
false
4
0
4
false
false
["src/vs/workbench/contrib/terminal/browser/xterm/contextualActionAddon.ts->program->function_declaration:getMatchActions", "src/vs/workbench/contrib/terminal/browser/terminalBaseContextualActions.ts->program->function_declaration:gitSimilarCommand", "src/vs/workbench/contrib/terminal/browser/terminalBaseContextualActi...
microsoft/vscode
164,226
microsoft__vscode-164226
['159995']
33e94dc8445a44a5af610fdcce7ff5291d6a8863
diff --git a/src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/bracketPairsTree.ts b/src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/bracketPairsTree.ts --- a/src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/bracketPairsTree.ts +++ b/src/vs/editor/common/mo...
diff --git a/src/vs/editor/test/common/model/bracketPairColorizer/getBracketPairsInRange.test.ts b/src/vs/editor/test/common/model/bracketPairColorizer/getBracketPairsInRange.test.ts --- a/src/vs/editor/test/common/model/bracketPairColorizer/getBracketPairsInRange.test.ts +++ b/src/vs/editor/test/common/model/bracketPa...
editor.bracketPairColorization.independentColorPoolPerBracketType stopped working after update <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/micros...
This is weird, we didn't change anything there. It works if you downgrade to the previous version of VS Code? Yse, I have met the same problem after updating to 1.71.0 Same problem here on 1.71.0 on Windows 10. Same issue here with both typescript and html templates.... All brackets regardless of nesting are all y...
2022-10-21 08:47:38+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Bracket Pair Colorizer - getBracketPairsInRange Basic 2', 'Bracket Pair Colorizer - getBracketPairsInRange Basic Empty', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Bracket Pair Colorizer - getBracketPairsInRange Basic 1', 'Unexpec...
['Bracket Pair Colorizer - getBracketPairsInRange getBracketsInRange']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/common/model/bracketPairColorizer/getBracketPairsInRange.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
2
0
2
false
false
["src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/bracketPairsTree.ts->program->class_declaration:BracketPairsTree->method_definition:getBracketsInRange", "src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/bracketPairsTree.ts->program->function_declaration:collectBrackets"]
microsoft/vscode
165,197
microsoft__vscode-165197
['165190']
d810d86c4cc295ad5b575b6c6528446cf3bf6f23
diff --git a/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts b/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts --- a/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts +++ b/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts @@ -120,7 +120,7 @@ class VariableResolver { } ...
diff --git a/src/vs/workbench/contrib/terminal/test/browser/quickFixAddon.test.ts b/src/vs/workbench/contrib/terminal/test/browser/quickFixAddon.test.ts --- a/src/vs/workbench/contrib/terminal/test/browser/quickFixAddon.test.ts +++ b/src/vs/workbench/contrib/terminal/test/browser/quickFixAddon.test.ts @@ -61,7 +61,7 @@...
improve terminal quick fix telemetry
null
2022-11-01 20:55:11+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['QuickFixAddon registerCommandFinishedListener & getMatchActions gitCreatePr returns actions when expected unix exit code', 'QuickFixAddon registerCommandFinishedListener & getMatchActions gitCreatePr returns undefined when output does not match', 'Tests are using suiteSetup and setup correctly assertCleanState - chec...
['QuickFixAddon registerCommandFinishedListener & getMatchActions gitTwoDashes returns undefined when matching exit status', 'QuickFixAddon gitPush - multiple providers returns actions when expected unix exit code', 'QuickFixAddon registerCommandFinishedListener & getMatchActions gitPushSetUpstream returns actions when...
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminal/test/browser/quickFixAddon.test.ts --reporter json --no-sandbox --exit
Feature
false
false
false
true
6
2
8
false
false
["src/vs/workbench/contrib/terminal/browser/xterm/quickFixAddon.ts->program->class_declaration:TerminalQuickFixAddon->method_definition:_registerCommandHandlers", "src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts->program->class_declaration:VerifiedTask", "src/vs/workbench/contrib/terminal/browser/xterm/qui...
microsoft/vscode
166,853
microsoft__vscode-166853
['166611']
e2c3da79cf0e45637ba5ee61fb9bfd626030908b
diff --git a/src/vs/workbench/services/views/browser/viewDescriptorService.ts b/src/vs/workbench/services/views/browser/viewDescriptorService.ts --- a/src/vs/workbench/services/views/browser/viewDescriptorService.ts +++ b/src/vs/workbench/services/views/browser/viewDescriptorService.ts @@ -54,8 +54,8 @@ export class Vi...
diff --git a/src/vs/workbench/services/views/test/browser/viewDescriptorService.test.ts b/src/vs/workbench/services/views/test/browser/viewDescriptorService.test.ts --- a/src/vs/workbench/services/views/test/browser/viewDescriptorService.test.ts +++ b/src/vs/workbench/services/views/test/browser/viewDescriptorService.t...
Views location is not getting updated when switching profiles - In my default profile with gitlens installed, move 3 gitlens views to a new view container (in secondary side bar) - Create an empty profile - Switch back to default profile - 🐛 gitlens view are back in SCM instead of in their new view container CC...
null
2022-11-21 12:38:39+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['ViewDescriptorService orphan view containers', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'ViewDescriptorService orphan views', 'ViewDescriptorService move views to existing containers', 'Unexpected Errors & Loader Errors assertCle...
['ViewDescriptorService storage change also updates locations even if views do not exists and views are registered later']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/services/views/test/browser/viewDescriptorService.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
false
false
true
1
1
2
false
false
["src/vs/workbench/services/views/browser/viewDescriptorService.ts->program->class_declaration:ViewDescriptorService->method_definition:onDidViewCustomizationsStorageChange", "src/vs/workbench/services/views/browser/viewDescriptorService.ts->program->class_declaration:ViewDescriptorService"]
microsoft/vscode
168,788
microsoft__vscode-168788
['125481']
14f54b128dd5955db7a69e0aac760731d343e54b
diff --git a/src/vs/editor/common/cursorCommon.ts b/src/vs/editor/common/cursorCommon.ts --- a/src/vs/editor/common/cursorCommon.ts +++ b/src/vs/editor/common/cursorCommon.ts @@ -135,8 +135,8 @@ export class CursorConfiguration { this._electricChars = null; this.shouldAutoCloseBefore = { - quote: this._getSho...
diff --git a/src/vs/editor/test/browser/controller/cursor.test.ts b/src/vs/editor/test/browser/controller/cursor.test.ts --- a/src/vs/editor/test/browser/controller/cursor.test.ts +++ b/src/vs/editor/test/browser/controller/cursor.test.ts @@ -4997,13 +4997,13 @@ suite('Editor Controller', () => { const autoCloseP...
Automatic curly brace closure with f-strings in python <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Can the addition of the closing...
Please add more details, e.g. a code sample. apologies - I actually had but for some reason the main body of text wasn't posted. please see a below a code example - thank you. `print(f'the answer is: {')` This is the current way in which the curly brace is interpreted in an f string. As you can see when you ente...
2022-12-11 18:28:39+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Editor Controller issue #3071: Investigate why undo stack gets corrupted', 'Editor Controller issue #36090: JS: editor.autoIndent seems to be broken', "Editor Controller - Cursor issue #17011: Shift+home/end now go to the end of the selection start's line, not the selection's end", 'Editor Controller - Cursor move up...
['Editor Controller autoClosingPairs - open parens: default']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/controller/cursor.test.ts --reporter json --no-sandbox --exit
Feature
false
false
false
true
6
1
7
false
false
["src/vs/editor/common/cursorCommon.ts->program->class_declaration:CursorConfiguration->method_definition:_getLanguageDefinedShouldAutoClose", "src/vs/editor/common/languages/supports/characterPair.ts->program->class_declaration:CharacterPairSupport->method_definition:getAutoCloseBeforeSet", "src/vs/editor/common/curso...
microsoft/vscode
169,916
microsoft__vscode-169916
['169816']
3fbea4d4f927a11ff0d643da7ee403b53f6f0a67
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts b/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts --- a/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService....
diff --git a/src/vs/workbench/contrib/extensions/test/electron-browser/extensionsViews.test.ts b/src/vs/workbench/contrib/extensions/test/electron-browser/extensionsViews.test.ts --- a/src/vs/workbench/contrib/extensions/test/electron-browser/extensionsViews.test.ts +++ b/src/vs/workbench/contrib/extensions/test/electr...
`ExtensionsWorkbenchService.updateActivity` is slow during startup Fishing at the CPU profiler on startup, I noticed that `ExtensionsWorkbenchService.updateActivity()` is quite slow at 18ms on my machine during startup. I’m running from `main` from source: ![image](https://user-images.githubusercontent.com/5047891/2...
null
2022-12-23 11:15:31+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['ExtensionEnablementService Test test canChangeEnablement return true when the remote ui extension is disabled by kind', 'ExtensionEnablementService Test test disable an extension for workspace again should return a falsy promise', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registrie...
['ExtensionsViews Tests Test @recommended:all query', 'ExtensionsViews Tests Test @recommended query']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/extensions/test/electron-browser/extensionsViews.test.ts --reporter json --no-sandbox --exit
Refactoring
false
false
false
true
10
1
11
false
false
["src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts->program->class_declaration:ExtensionsWorkbenchService->method_definition:onDidChangeRunningExtensions", "src/vs/workbench/contrib/extensions/browser/extensionsWorkbenchService.ts->program->class_declaration:ExtensionsWorkbenchService->method_d...
microsoft/vscode
171,718
microsoft__vscode-171718
['171230']
17611434105562ae944231d6f7b440aa2af7edc6
diff --git a/src/vs/base/common/processes.ts b/src/vs/base/common/processes.ts --- a/src/vs/base/common/processes.ts +++ b/src/vs/base/common/processes.ts @@ -108,7 +108,7 @@ export function sanitizeProcessEnvironment(env: IProcessEnvironment, ...preserve }, {} as Record<string, boolean>); const keysToRemove = [ ...
diff --git a/src/vs/base/test/common/processes.test.ts b/src/vs/base/test/common/processes.test.ts --- a/src/vs/base/test/common/processes.test.ts +++ b/src/vs/base/test/common/processes.test.ts @@ -19,7 +19,7 @@ suite('Processes', () => { VSCODE_DEV: 'x', VSCODE_IPC_HOOK: 'x', VSCODE_NLS_CONFIG: 'x', - V...
Doing `code <file>` from integrated terminal in portable mode uses wrong user data Does this issue occur when all extensions are disabled?: No <!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be ...
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.3. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! Happens on the latest version as well: ![image](https://user-images.githubusercontent.com/3...
2023-01-19 12:15:23+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running', 'Unexpected Errors & Loader Errors should not hav...
['Processes sanitizeProcessEnvironment']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/processes.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/base/common/processes.ts->program->function_declaration:sanitizeProcessEnvironment"]
microsoft/vscode
174,679
microsoft__vscode-174679
['174163']
2d67c6fae3cf94da9558103994395ab28bc14110
diff --git a/src/vs/workbench/common/editor/editorGroupModel.ts b/src/vs/workbench/common/editor/editorGroupModel.ts --- a/src/vs/workbench/common/editor/editorGroupModel.ts +++ b/src/vs/workbench/common/editor/editorGroupModel.ts @@ -551,6 +551,7 @@ export class EditorGroupModel extends Disposable { } const ed...
diff --git a/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts b/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts --- a/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts +++ b/src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts @@ -2124,7 +2124,7 @@...
`activeEditorIsPinned` is not set when editor is auto-pinned by `workbench.action.moveEditorLeftInGroup` Type: <b>Bug</b> workbench.action.moveEditorLeftInGroup will automatically pin an editor if the editor to its left is pinned. When this happens activeEditorIsPinned is not updated and set to true. This context is...
Open for help, investigation, suggested fixes, PR.
2023-02-17 14:13:42+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['EditorGroupModel Single Group, Single Editor - persist', 'EditorGroupModel Multiple Editors - Pinned and Active', 'EditorGroupModel Multiple Editors - real user example', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'EditorGroupModel...
['EditorGroupModel moving editor sends sticky event when sticky changes']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/test/browser/parts/editor/editorGroupModel.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/workbench/common/editor/editorGroupModel.ts->program->class_declaration:EditorGroupModel->method_definition:moveEditor"]
microsoft/vscode
175,682
microsoft__vscode-175682
['174330']
02a84efd329eb06690145f2e322f3fbb147da3c6
diff --git a/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts b/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts --- a/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts +++ b/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts @@ -75,7 +75,7 @@ function mergeNonNu...
diff --git a/src/vs/workbench/contrib/terminal/test/common/terminalEnvironment.test.ts b/src/vs/workbench/contrib/terminal/test/common/terminalEnvironment.test.ts --- a/src/vs/workbench/contrib/terminal/test/common/terminalEnvironment.test.ts +++ b/src/vs/workbench/contrib/terminal/test/common/terminalEnvironment.test....
Empty environment variables passed to vs code are unset <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Sug...
I'm seeing the variable make it to the debugger, eg here in the debug console, it's in `process.env` <img width="133" alt="image" src="https://user-images.githubusercontent.com/323878/219070553-ab88e1b4-e94d-4a2c-81fc-6502b0c7df05.png"> But I'm not seeing it in the terminal. @Tyriar @meganrogge does one of the ter...
2023-02-28 18:06:55+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['Workbench - TerminalEnvironment shouldSetLangEnvVariable on', 'Workbench - TerminalEnvironment getLangEnvVariable should set language variant based on full locale', "Workbench - TerminalEnvironment getCwd should fall back for relative a custom cwd that doesn't have a workspace", 'Workbench - TerminalEnvironment addTe...
['Workbench - TerminalEnvironment createTerminalEnvironment should retain variables equal to the empty string']
['Disk File Service writeFile - locked files and unlocking', 'Disk File Service writeFile (stream) - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile - locked files and unlocking throws error when missing capability', 'Disk File Service writeFile (stream) - locked files and...
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminal/test/common/terminalEnvironment.test.ts --reporter json --no-sandbox --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts->program->function_declaration:mergeNonNullKeys"]
microsoft/vscode
178,291
microsoft__vscode-178291
['171880']
619a4b604aa8f09b3a5eec61114a9dd65648ae83
diff --git a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts b/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts --- a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts +++ b/src/vs/workbench/contrib/terminalContrib/links/browser/term...
diff --git a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts b/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --- a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts +++ b/src/vs/workbench/contrib/term...
terminal doesn't recognize filename and line number <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. -...
yeah looks like we don't support that case atm, though this one comes close https://github.com/microsoft/vscode/blob/5dbb41f91d0f33f72746b3ad55ef9cccda59364a/src/vs/workbench/contrib/terminal/browser/links/terminalLocalLinkDetector.ts#L60 <!-- 6d457af9-96bd-47a8-a0e8-ecf120dfffc1 --> This feature request is now a ca...
2023-03-24 23:41:30+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:16 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev libgbm-dev libgbm1 && rm -rf /var/lib/apt/lists/* WORKDIR /testbed COPY...
['TerminalLinkParsing getLinkSuffix `foo, line 339`', 'TerminalLinkParsing getLinkSuffix `foo, line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `foo: line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `"foo" on line 339,\xa0column 12`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a ...
['TerminalLinkParsing detectLinks should detect 3 suffix links on a single line ` "foo", lines 339-340 foo\xa0339:12 "foo" on line 339,\xa0column 12 `', 'TerminalLinkParsing removeLinkSuffix `"foo", line 339, character 12`', 'TerminalLinkParsing detectLinkSuffixes `"foo", line 339, characters 12-13`', 'TerminalLinkPars...
[]
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
3
0
3
false
false
["src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts->program->function_declaration:l", "src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts->program->function_declaration:generateLinkSuffixRegex", "src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkP...
microsoft/vscode
178,513
microsoft__vscode-178513
['178326']
5f328ba75d0bc66fa741290fd16cace977083871
diff --git a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts b/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts --- a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts +++ b/src/vs/workbench/contrib/terminalContrib/links/browser/term...
diff --git a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts b/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --- a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts +++ b/src/vs/workbench/contrib/term...
exclude "<" and ">" from file path detection <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> E...
This actually works fine for me: ![image](https://user-images.githubusercontent.com/2193314/228026926-a615ce3f-7b0d-4978-92ab-578192c808f3.png) Is nakata/main.go relative to the current working directory? Weird... 🤔 No. The actual file I want to go is at `./cmd/nakama/main.go` but it was compiled as `nakama`, s...
2023-03-28 17:52:27+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['TerminalLinkParsing getLinkSuffix `foo, line 339`', 'TerminalLinkParsing getLinkSuffix `foo, line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `foo: line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `"foo" on line 339,\xa0column 12`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a ...
['TerminalLinkParsing detectLinks "<>" should exclude bracket characters from link paths [Linux]', 'TerminalLinkParsing detectLinks "<>" should exclude bracket characters from link paths [macOS]']
[]
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --reporter json --no-sandbox --exit
Feature
true
false
false
false
0
0
0
false
false
[]
microsoft/vscode
178,694
microsoft__vscode-178694
['178460']
d4d0d2a3e438a3e97f57b6f8a9c4d5348949d0b5
diff --git a/src/vs/base/common/history.ts b/src/vs/base/common/history.ts --- a/src/vs/base/common/history.ts +++ b/src/vs/base/common/history.ts @@ -118,6 +118,7 @@ interface HistoryNode<T> { export class HistoryNavigator2<T> { + private valueSet: Set<T>; private head: HistoryNode<T>; private tail: HistoryNo...
diff --git a/src/vs/base/test/common/history.test.ts b/src/vs/base/test/common/history.test.ts --- a/src/vs/base/test/common/history.test.ts +++ b/src/vs/base/test/common/history.test.ts @@ -3,7 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *----------------...
Use only unique commit messages for auto-complete <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestio...
null
2023-03-30 15:10:19+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
['History Navigator previous returns previous element', 'Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'History Navigator adding an existing item changes the order', 'History Navigator next returns object if the current position is not t...
['History Navigator 2 replaceLast - existing value', 'History Navigator 2 add - existing value']
[]
. /usr/local/nvm/nvm.sh && nvm use 16.20.2 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/base/test/common/history.test.ts --reporter json --no-sandbox --exit
Feature
false
false
false
true
5
1
6
false
false
["src/vs/base/common/history.ts->program->class_declaration:HistoryNavigator2->method_definition:add", "src/vs/base/common/history.ts->program->class_declaration:HistoryNavigator2", "src/vs/base/common/history.ts->program->class_declaration:HistoryNavigator2->method_definition:constructor", "src/vs/base/common/history....
microsoft/vscode
179,884
microsoft__vscode-179884
['176783']
00e3acf1ee6bdfef8d4d71b899af743cfe0f182c
diff --git a/src/vs/workbench/contrib/extensions/browser/workspaceRecommendations.ts b/src/vs/workbench/contrib/extensions/browser/workspaceRecommendations.ts --- a/src/vs/workbench/contrib/extensions/browser/workspaceRecommendations.ts +++ b/src/vs/workbench/contrib/extensions/browser/workspaceRecommendations.ts @@ -3...
diff --git a/src/vs/workbench/contrib/extensions/test/electron-sandbox/extensionRecommendationsService.test.ts b/src/vs/workbench/contrib/extensions/test/electron-sandbox/extensionRecommendationsService.test.ts --- a/src/vs/workbench/contrib/extensions/test/electron-sandbox/extensionRecommendationsService.test.ts +++ b...
Let's remove request to marketplace for workspace recommendations 1. Open a repo that has some workspace recommendations (like vscode) 2. Notice that we are sending a request to the Marketplace on VS Code startup 3. This request is not actually needed. We send it just to check if the recommended extension names are v...
null
2023-04-13 14:39:33+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 18.8.0 && rm -rf node_modules && npx playwright install --with-deps chromium webkit && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 18.8.0 && nvm use default
['ExtensionEnablementService Test test canChangeEnablement return true when the remote ui extension is disabled by kind', 'Experiment Service Simple Experiment Test', 'ExtensionEnablementService Test test disable an extension for workspace again should return a falsy promise', 'ExtensionEnablementService Test test canC...
['ExtensionRecommendationsService Test ExtensionRecommendationsService: Prompt for valid workspace recommendations']
[]
. /usr/local/nvm/nvm.sh && nvm use 18.8.0 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/extensions/test/electron-sandbox/extensionRecommendationsService.test.ts --reporter json --no-sandbox --exit
Refactoring
false
true
false
false
2
0
2
false
false
["src/vs/workbench/contrib/extensions/browser/workspaceRecommendations.ts->program->class_declaration:WorkspaceRecommendations->method_definition:validateExtensions", "src/vs/workbench/contrib/extensions/browser/workspaceRecommendations.ts->program->class_declaration:WorkspaceRecommendations->method_definition:construc...
microsoft/vscode
181,517
microsoft__vscode-181517
['181479']
39b572dfae38593a48094ed3d5ae7d22ae91b12c
diff --git a/src/vs/editor/browser/services/abstractCodeEditorService.ts b/src/vs/editor/browser/services/abstractCodeEditorService.ts --- a/src/vs/editor/browser/services/abstractCodeEditorService.ts +++ b/src/vs/editor/browser/services/abstractCodeEditorService.ts @@ -585,7 +585,7 @@ export const _CSS_MAP: { [prop: s...
diff --git a/src/vs/editor/test/browser/services/decorationRenderOptions.test.ts b/src/vs/editor/test/browser/services/decorationRenderOptions.test.ts --- a/src/vs/editor/test/browser/services/decorationRenderOptions.test.ts +++ b/src/vs/editor/test/browser/services/decorationRenderOptions.test.ts @@ -41,7 +41,7 @@ sui...
Gutter icon is no longer centered in 1.78 Create decoration with `gutterIconSize` set to `50%`. Example [Error Lens](https://marketplace.visualstudio.com/items?itemName=usernamehw.errorlens): ```js "errorLens.gutterIconsEnabled": true, "errorLens.gutterIconSet": "circle", "errorLens.gutterIconSize": "50%", ``...
null
2023-05-04 13:37:10+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 18.8.0 && rm -rf node_modules && npx playwright install --with-deps chromium webkit && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 18.8.0 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors should not have unexpected errors', 'Decoration Render Options theme color', 'Unexpected Errors & Loader Errors assertCleanState - check that registries a...
['Decoration Render Options css properties', 'Decoration Render Options css properties, gutterIconPaths']
[]
. /usr/local/nvm/nvm.sh && nvm use 18.8.0 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/editor/test/browser/services/decorationRenderOptions.test.ts --reporter json --no-sandbox --exit
Bug Fix
true
false
false
false
0
0
0
false
false
[]
microsoft/vscode
182,669
microsoft__vscode-182669
['182565']
fe16f26a406d6c889a7801739cc658e8778c149c
diff --git a/src/vs/workbench/contrib/search/browser/search.contribution.ts b/src/vs/workbench/contrib/search/browser/search.contribution.ts --- a/src/vs/workbench/contrib/search/browser/search.contribution.ts +++ b/src/vs/workbench/contrib/search/browser/search.contribution.ts @@ -41,7 +41,6 @@ import 'vs/workbench/co...
diff --git a/src/vs/workbench/contrib/search/test/browser/searchModel.test.ts b/src/vs/workbench/contrib/search/test/browser/searchModel.test.ts --- a/src/vs/workbench/contrib/search/test/browser/searchModel.test.ts +++ b/src/vs/workbench/contrib/search/test/browser/searchModel.test.ts @@ -500,7 +500,7 @@ suite('Search...
remove experimental flag for notebook search for open notebooks Should be fairly complete after this iteration. The flag has been on by default on insiders for more than a month now.
null
2023-05-16 19:16:33+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 18.8.0 && rm -rf node_modules && npx playwright install --with-deps chromium webkit && yarn install RUN chmod +x ./scripts/test.sh RUN . $NVM_DIR/nvm.sh && nvm alias default 18.8.0 && nvm use default
['Tests are using suiteSetup and setup correctly assertCleanState - check that registries are clean at the start of test running', 'Unexpected Errors & Loader Errors assertCleanState - check that registries are clean and objects are disposed at the end of test running', 'Unexpected Errors & Loader Errors should not hav...
['SearchModel Search Model: Search adds to results', 'SearchModel Search Model: Search can return notebook results', 'SearchModel Search Model: Search reports telemetry on search completed', 'SearchModel Search Model: Search reports timed telemetry on search when progress is not called', 'SearchModel Search Model: Sear...
[]
. /usr/local/nvm/nvm.sh && nvm use 18.8.0 && yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/search/test/browser/searchModel.test.ts src/vs/workbench/contrib/search/test/browser/searchTestCommon.ts src/vs/workbench/contrib/search/test/brows...
Feature
false
true
false
false
9
0
9
false
false
["src/vs/workbench/contrib/search/browser/searchModel.ts->program->class_declaration:FileMatch->method_definition:createMatches", "src/vs/workbench/contrib/search/browser/searchModel.ts->program->class_declaration:SearchModel->method_definition:doSearch", "src/vs/workbench/contrib/search/browser/searchWidget.ts->progra...
microsoft/vscode
190,351
microsoft__vscode-190351
['190350']
2d9cc42045edf3458acbddf3d645bba993f82696
diff --git a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts b/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts --- a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts +++ b/src/vs/workbench/contrib/terminalContrib/links/browser/term...
diff --git a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts b/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --- a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts +++ b/src/vs/workbench/contrib/term...
Support GNU style file:line.column links The [Sail compiler]() outputs file:line links that follow [this GNU convention](https://www.gnu.org/prep/standards/html_node/Errors.html): ``` Warning: Redundant case sail-riscv/model/riscv_sys_control.sail:206.6-7: 206 | _ => false | ^ ``` This doesn't c...
null
2023-08-13 09:34:39+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:18 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev && rm -rf /var/lib/apt/lists/* WORKDIR /testbed RUN npx playwright install --wi...
['TerminalLinkParsing getLinkSuffix `foo, line 339`', 'TerminalLinkParsing getLinkSuffix `foo, line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `foo: line 339, column 12`', 'TerminalLinkParsing getLinkSuffix `"foo" on line 339,\xa0column 12`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a ...
['TerminalLinkParsing getLinkSuffix `foo:339.12`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a single line ` foo:339:12 foo:339.12 foo 339 `', 'TerminalLinkParsing removeLinkSuffix `"foo",339.12`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a single line ` "foo",339.12 "foo"...
[]
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
1
0
1
true
false
["src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts->program->function_declaration:generateLinkSuffixRegex"]
microsoft/vscode
191,602
microsoft__vscode-191602
['190350']
07a6890a7b8117fa22b69286423288eb69fa3607
diff --git a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts b/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts --- a/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts +++ b/src/vs/workbench/contrib/terminalContrib/links/browser/term...
diff --git a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts b/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --- a/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts +++ b/src/vs/workbench/contrib/term...
Support GNU style file:line.column links The [Sail compiler]() outputs file:line links that follow [this GNU convention](https://www.gnu.org/prep/standards/html_node/Errors.html): ``` Warning: Redundant case sail-riscv/model/riscv_sys_control.sail:206.6-7: 206 | _ => false | ^ ``` This doesn't c...
Doesn't seem to work, see `echo src/vs/workbench/contrib/snippets/browser/snippetsFile.ts:70.30-36` <img width="825" alt="Screenshot 2023-08-29 at 14 41 05" src="https://github.com/microsoft/vscode/assets/1794099/e659e1a2-69b9-4e3c-8687-123fc4e0fbf9"> The PR intentionally left that out: > so I've opted for the ...
2023-08-29 12:53:09+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:18 RUN apt-get update && apt-get install -y git xvfb libxtst6 libxss1 libgtk-3-0 libnss3 libasound2 libx11-dev libxkbfile-dev pkg-config libsecret-1-dev && rm -rf /var/lib/apt/lists/* WORKDIR /testbed RUN npx playwright install --wi...
["TerminalLinkParsing detectLinkSuffixes `'foo',339.12`", 'TerminalLinkParsing getLinkSuffix `foo, line 339`', 'TerminalLinkParsing getLinkSuffix `foo, line 339, column 12`', "TerminalLinkParsing removeLinkSuffix `'foo',339.12`", 'TerminalLinkParsing getLinkSuffix `foo: line 339, column 12`', 'TerminalLinkParsing getLi...
['TerminalLinkParsing getLinkSuffix `foo 339.12-341.14`', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a single line ` foo 339.12 foo 339.12-14 foo 339.12-341.14 `', 'TerminalLinkParsing detectLinks should detect 3 suffix links on a single line ` foo 339:12 foo 339.12 foo 339.12-14 `', 'TerminalLink...
[]
yarn compile ; xvfb-run --auto-servernum --server-args='-screen 0 1024x768x24' ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts --reporter json --no-sandbox --exit
Feature
false
true
false
false
1
0
1
true
false
["src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts->program->function_declaration:generateLinkSuffixRegex"]
angular/angular
37,484
angular__angular-37484
['36882']
f0f319b1d64112979a414829355fe8d4ff95f64e
diff --git a/packages/compiler-cli/ngcc/index.ts b/packages/compiler-cli/ngcc/index.ts --- a/packages/compiler-cli/ngcc/index.ts +++ b/packages/compiler-cli/ngcc/index.ts @@ -12,7 +12,7 @@ import {AsyncNgccOptions, NgccOptions, SyncNgccOptions} from './src/ngcc_options export {ConsoleLogger} from './src/logging/cons...
diff --git a/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts b/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts --- a/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts +++ b/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts @@ -14,6 +14,7 @@ import {Folder, MockFileSystem, runInEachFileSy...
ngcc: do not parse tsconfig.json more than once # 🐞 bug report ### Affected Package The issue is caused by package @angular/compiler-cli ### Is this a regression? <!-- Did this behavior use to work in the previous version? --> <!-- ✍️--> Yes, the previous version in which this bug was not present was: 8.2...
Thanks for creating this issue @mpk - I hope to look into it later this week. Is this a duplicate of https://github.com/angular/angular/issues/36272? > Is this a duplicate of #36272? Not really. There are a number of reasons why the build can be slow at 0%. This is one particular reason. @mpk - I would like to...
2020-06-08 09:42:33+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 10.24.1 && rm -rf node_modules && npm install -g @bazel/bazelisk && yarn install && node scripts/webdriver-manager-update.js && node --preserve-symlinks --preserve-symlinks-main ./tools/postinstall-patches.js RUN . $NVM_...
['/packages/localize/src/tools/test/translate/integration:integration', '/packages/core/test/bundling/injection:symbol_test', '/packages/compiler/test/selector:selector', '/packages/platform-browser/test:testing_circular_deps_test', '/packages/compiler/test:circular_deps_test', '/packages/compiler-cli/src/ngtsc/scope/t...
['/packages/compiler-cli/ngcc/test:test']
['/packages/platform-browser-dynamic/test:test_web_chromium', '/packages/platform-browser/test:test_web_chromium', '/packages/platform-webworker/test:test_web_chromium', '/packages/http/test:test_web_chromium', '/packages/core/test/bundling/hello_world:test', '/packages/core/test/bundling/todo:test', '/packages/common/...
. /usr/local/nvm/nvm.sh && nvm use 10.24.1 && bazel test packages/compiler-cli/ngcc/test:test --keep_going --test_output=summary --test_summary=short --noshow_progress
Bug Fix
false
true
false
false
3
0
3
false
false
["packages/compiler-cli/ngcc/src/ngcc_options.ts->program->function_declaration:getTsConfig", "packages/compiler-cli/ngcc/src/ngcc_options.ts->program->function_declaration:getSharedSetup", "packages/compiler-cli/ngcc/src/ngcc_options.ts->program->function_declaration:clearTsConfigCache"]
angular/angular
37,561
angular__angular-37561
['35733']
f7997256fc23e202e08df39997afd360d202f9f1
diff --git a/packages/core/src/render3/di.ts b/packages/core/src/render3/di.ts --- a/packages/core/src/render3/di.ts +++ b/packages/core/src/render3/di.ts @@ -657,16 +657,31 @@ export function ɵɵgetFactoryOf<T>(type: Type<any>): FactoryFn<T>|null { */ export function ɵɵgetInheritedFactory<T>(type: Type<any>): (type:...
diff --git a/packages/core/test/render3/providers_spec.ts b/packages/core/test/render3/providers_spec.ts --- a/packages/core/test/render3/providers_spec.ts +++ b/packages/core/test/render3/providers_spec.ts @@ -6,10 +6,10 @@ * found in the LICENSE file at https://angular.io/license */ -import {Component as _Compo...
Too much recursion because of @Injectable conflicts with other decorators <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅 Oh hi there! 😄 To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, ...
I have a similar error after upgrading to 9.0.4/0.900.4: ``` Compiling @angular/… : es2015 as esm2015 chunk {} runtime.689ba4fd6cadb82c1ac2.js (runtime) 1.45 kB [entry] [rendered] chunk {1} main.9d65be46ac259c9df33b.js (main) 700 kB [initial] [rendered] chunk {2} polyfills.da2c6c4849ef9aea9de5.js (polyfills) 3...
2020-06-12 20:02:28+00:00
TypeScript
FROM public.ecr.aws/docker/library/node:10-buster EXPOSE 4000 4200 4433 5000 8080 9876 USER root RUN apt-get update && apt-get install -y git python3 chromium chromium-driver firefox-esr xvfb && rm -rf /var/lib/apt/lists/* RUN npm install -g @bazel/bazelisk WORKDIR /testbed COPY . . RUN yarn...
['/packages/localize/src/tools/test/translate/integration:integration', '/packages/core/test/bundling/injection:symbol_test', '/packages/compiler/test/selector:selector', '/packages/platform-browser/test:testing_circular_deps_test', '/packages/compiler/test:circular_deps_test', '/packages/compiler-cli/src/ngtsc/scope/t...
['/packages/core/test/render3:render3']
['/packages/platform-browser-dynamic/test:test_web_chromium', '/packages/platform-browser/test:test_web_chromium', '/packages/platform-webworker/test:test_web_chromium', '/packages/http/test:test_web_chromium', '/packages/core/test/bundling/hello_world:test', '/packages/core/test/bundling/todo:test', '/packages/common/...
bazel test packages/core/test/render3 --keep_going --test_output=summary --test_summary=short --noshow_progress
Bug Fix
false
true
false
false
1
0
1
true
false
["packages/core/src/render3/di.ts->program->function_declaration:\u0275\u0275getInheritedFactory"]
mui/material-ui
7,444
mui__material-ui-7444
['1168', '1168']
d3dcda1a55afeb7ade33d9fa659afef15b163255
diff --git a/src/List/List.js b/src/List/List.js --- a/src/List/List.js +++ b/src/List/List.js @@ -75,7 +75,7 @@ type Props = DefaultProps & { class List extends Component<DefaultProps, Props, void> { props: Props; static defaultProps: DefaultProps = { - component: 'div', + component: 'ul', dense: fal...
diff --git a/test/integration/MenuList.spec.js b/test/integration/MenuList.spec.js --- a/test/integration/MenuList.spec.js +++ b/test/integration/MenuList.spec.js @@ -29,7 +29,7 @@ function assertMenuItemFocused(wrapper, tabIndexed) { items.forEach((item, index) => { if (index === tabIndexed) { - assert....
[Lists] Change List and ListItem to use ul and li We are looking through the semantics of our website, which uses Material-UI, and we discovered that list items in Material UI doesn't use `<ul>` and `<li>` (ie https://github.com/callemall/material-ui/blob/master/src/lists/list-item.jsx#L298). Does anybody know why this...
@bweggersen That's a good question :) We should probably change it to use `ul` and `li`. +1 let's keep the semantic of webpages structure correct. @bweggersen @cgestes are either of you interested in taking this up in a PR? @oliviertassinari @newoga @mbrookes Let's discuss this too. I think using `ul` and `li` migh...
2017-07-16 18:48:33+00:00
TypeScript
FROM node:6 WORKDIR /testbed COPY . . RUN yarn install # Create custom reporter file RUN echo 'var mocha = require("mocha");' > custom-reporter.js && echo 'var path = require("path");' >> custom-reporter.js && echo 'function CustomReporter(runner) {' >> custom-reporter.js && echo ' mocha.reporters.Base.ca...
['test/integration/MenuList.spec.js-><MenuList> integration keyboard controls and tabIndex manipulation should have the first item tabIndexed', 'test/integration/MenuList.spec.js-><MenuList> integration keyboard controls and tabIndex manipulation - preselected item should have the 2nd item tabIndexed', 'test/integratio...
['test/integration/MenuList.spec.js-><MenuList> integration keyboard controls and tabIndex manipulation should focus the third item', 'test/integration/MenuList.spec.js-><MenuList> integration keyboard controls and tabIndex manipulation - preselected item should select/focus the second item', 'test/integration/MenuList...
[]
yarn cross-env NODE_ENV=test mocha test/integration/MenuList.spec.js --reporter /testbed/custom-reporter.js --exit
Refactoring
false
false
true
false
0
2
2
false
false
["src/List/List.js->program->class_declaration:List", "src/List/ListItem.js->program->class_declaration:ListItem"]
mui/material-ui
11,446
mui__material-ui-11446
['11329']
4c8a0c7a255033e126dfb28b3bb1a25a99a0babf
diff --git a/packages/material-ui/src/StepLabel/StepLabel.d.ts b/packages/material-ui/src/StepLabel/StepLabel.d.ts --- a/packages/material-ui/src/StepLabel/StepLabel.d.ts +++ b/packages/material-ui/src/StepLabel/StepLabel.d.ts @@ -2,6 +2,7 @@ import * as React from 'react'; import { StandardProps } from '..'; import ...
diff --git a/packages/material-ui/src/StepLabel/StepLabel.test.js b/packages/material-ui/src/StepLabel/StepLabel.test.js --- a/packages/material-ui/src/StepLabel/StepLabel.test.js +++ b/packages/material-ui/src/StepLabel/StepLabel.test.js @@ -44,8 +44,9 @@ describe('<StepLabel />', () => { }); it('renders <...
[Feature Request] StepIcon should be more customizable Hello, folks! I'm having a problem in customize the component __StepIcon__ inside of __StepLabel__ specifically in line __86__, component is like this in the last version of material-ui-next __(v1.0.0-beta.47)__: ``` {icon && ( <span clas...
@lucas-viewup Thanks for opening this issue. I'm not sure to fully understand your problem. What are you trying to achieve precisely? This would help me evaluate the best solution. Thanks for feedback, @oliviertassinari! The problem I'm trying to solve is style the __StepIcon__ without modify the __behaviour__ of icon ...
2018-05-17 12:20:38+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/StepLabel/StepLabel.test.js-><StepLabel /> prop: classes should set iconContainer', 'packages/material-ui/src/StepLabel/StepLabel.test.js-><StepLabel /> prop: completed renders <StepIcon> with the prop completed set to true', 'packages/material-ui/src/StepLabel/StepLabel.test.js-><StepLabel /...
['packages/material-ui/src/StepLabel/StepLabel.test.js-><StepLabel /> label content renders <StepIcon>']
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/StepLabel/StepLabel.test.js --reporter /testbed/custom-reporter.js --exit
Feature
false
true
false
false
1
0
1
true
false
["packages/material-ui/src/StepLabel/StepLabel.js->program->function_declaration:StepLabel"]
mui/material-ui
11,825
mui__material-ui-11825
['8379']
98168a2c749d8da2376d6a997145e3622df71bff
diff --git a/packages/material-ui/src/Tabs/Tabs.js b/packages/material-ui/src/Tabs/Tabs.js --- a/packages/material-ui/src/Tabs/Tabs.js +++ b/packages/material-ui/src/Tabs/Tabs.js @@ -143,7 +143,7 @@ class Tabs extends React.Component { const children = this.tabs.children[0].children; if (children.length...
diff --git a/packages/material-ui/src/Tabs/Tabs.test.js b/packages/material-ui/src/Tabs/Tabs.test.js --- a/packages/material-ui/src/Tabs/Tabs.test.js +++ b/packages/material-ui/src/Tabs/Tabs.test.js @@ -246,6 +246,19 @@ describe('<Tabs />', () => { ); }); + it('should accept any value as selected...
[Tabs] Tab indicator in Tabs behaves wrong when tabs are dynamically changed - [x] I have searched the [issues](https://github.com/callemall/material-ui/issues) of this repository and believe that this is not a duplicate. ## Expected Behavior The tab indicator must always show the selected tab ## Current Behavio...
We might want to change this logic: https://github.com/callemall/material-ui/blob/438dd7f7fc14f504f0e385fef1719ee6674fa3ca/src/Tabs/Tabs.js#L164-L167 @oliviertassinari Would it be too bad performance to remove the if statement arround :-) ? I would really like to contribute but is relativly new in the open source w...
2018-06-12 06:22:54+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/Tabs/Tabs.test.js-><Tabs /> prop: value indicator should let the selected <Tab /> render the indicator', 'packages/material-ui/src/Tabs/Tabs.test.js-><Tabs /> prop: value indicator should render the indicator', 'packages/material-ui/src/Tabs/Tabs.test.js-><Tabs /> prop: centered should render...
['packages/material-ui/src/Tabs/Tabs.test.js-><Tabs /> prop: value indicator should accept any value as selected tab value']
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/Tabs/Tabs.test.js --reporter /testbed/custom-reporter.js --exit
Bug Fix
false
false
false
true
1
1
2
false
false
["packages/material-ui/src/Tabs/Tabs.js->program->class_declaration:Tabs", "packages/material-ui/src/Tabs/Tabs.js->program->class_declaration:Tabs->method_definition:render"]
mui/material-ui
12,389
mui__material-ui-12389
['12275']
8013fdd36d40980ebb8f116f20e2843b781c0c39
diff --git a/packages/material-ui/src/styles/createGenerateClassName.js b/packages/material-ui/src/styles/createGenerateClassName.js --- a/packages/material-ui/src/styles/createGenerateClassName.js +++ b/packages/material-ui/src/styles/createGenerateClassName.js @@ -56,14 +56,13 @@ export default function createGenerat...
diff --git a/packages/material-ui/src/styles/createGenerateClassName.test.js b/packages/material-ui/src/styles/createGenerateClassName.test.js --- a/packages/material-ui/src/styles/createGenerateClassName.test.js +++ b/packages/material-ui/src/styles/createGenerateClassName.test.js @@ -58,12 +58,13 @@ describe('createG...
dangerouslyUseGlobalCSS not working <!--- Provide a general summary of the issue in the Title above --> I did a little debugging to figure out why `dangerouslyUseGlobalCSS` is not working, and it seems that `styleSheet.options.classNamePrefix` is undefined. My app was created with create-react-app, so this might be a ...
@grigored Please provide a full reproduction test case. This would help a lot 👷 . A repository would be perfect. Thank you! @oliviertassinari Thanks for the quick reply. Here's a sample repo to demonstrate the problem: [https://github.com/grigored/dangerouslyUseGlobalCS](https://github.com/grigored/dangerouslyUseGlob...
2018-08-02 19:49:23+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/styles/createGenerateClassName.test.js->createGenerateClassName should escape parenthesis', 'packages/material-ui/src/styles/createGenerateClassName.test.js->createGenerateClassName formatting production should warn', 'packages/material-ui/src/styles/createGenerateClassName.test.js->createGen...
['packages/material-ui/src/styles/createGenerateClassName.test.js->createGenerateClassName options: dangerouslyUseGlobalCSS should use a global class name']
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/styles/createGenerateClassName.test.js --reporter /testbed/custom-reporter.js --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["packages/material-ui/src/styles/createGenerateClassName.js->program->function_declaration:createGenerateClassName"]
mui/material-ui
13,582
mui__material-ui-13582
['13577']
a2c35232889603e3f2c5930403a4df1a90a37ece
diff --git a/.size-limit.js b/.size-limit.js --- a/.size-limit.js +++ b/.size-limit.js @@ -22,7 +22,7 @@ module.exports = [ name: 'The size of the @material-ui/core modules', webpack: true, path: 'packages/material-ui/build/index.js', - limit: '94.1 KB', + limit: '94.2 KB', }, { name: 'T...
diff --git a/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js b/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js --- a/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js +++ b/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelS...
[Accordion] onBlur event for Summary doesn't fire <!--- Provide a general summary of the issue in the Title above --> <!-- Thank you very much for contributing to Material-UI by creating an issue! ❤️ To avoid duplicate issues we ask you to check off the following list. --> <!-- Checked checkbox should ...
@crpc Well spotted! It's definitely a bug. We are overriding the user's onBlur property: https://github.com/mui-org/material-ui/blob/83adb95e594d7799b5f399a824f0d72f749ba349/packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js#L130-L132 without calling it when needed: https://github.com/mui-org/m...
2018-11-13 03:46:03+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js-><ExpansionPanelSummary /> when expanded should have expanded class', 'packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js-><ExpansionPanelSummary /> handleBlur() should unset focused state', 'packages/material-ui/sr...
['packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js-><ExpansionPanelSummary /> handleFocusVisible() should set focused state', 'packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js-><ExpansionPanelSummary /> event callbacks should fire event callbacks']
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.test.js --reporter /testbed/custom-reporter.js --exit
Bug Fix
false
false
false
true
1
1
2
false
false
["packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js->program->class_declaration:ExpansionPanelSummary->method_definition:render", "packages/material-ui/src/ExpansionPanelSummary/ExpansionPanelSummary.js->program->class_declaration:ExpansionPanelSummary"]
mui/material-ui
13,743
mui__material-ui-13743
['13733']
d8a71892231d3fbfac42c2e2e8631591d25f825a
diff --git a/packages/material-ui/src/Modal/ModalManager.js b/packages/material-ui/src/Modal/ModalManager.js --- a/packages/material-ui/src/Modal/ModalManager.js +++ b/packages/material-ui/src/Modal/ModalManager.js @@ -124,7 +124,7 @@ class ModalManager { const containerIdx = findIndexOf(this.data, item => item.mo...
diff --git a/packages/material-ui/src/Modal/Modal.test.js b/packages/material-ui/src/Modal/Modal.test.js --- a/packages/material-ui/src/Modal/Modal.test.js +++ b/packages/material-ui/src/Modal/Modal.test.js @@ -1,6 +1,7 @@ import React from 'react'; import { assert } from 'chai'; import { spy, stub } from 'sinon'; +...
[Dialog] Simultaneously closing multiple dialogs throws an error - [x] This is not a v0.x issue. - [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Expected Behavior 🤔 Both dialog boxes should close, with no error. #...
![image](https://user-images.githubusercontent.com/1369559/49218162-5e935700-f3d8-11e8-8b98-3d578d2e112b.png) it throws here https://github.com/oliviertassinari/material-ui/blob/840738330c85c6d7a2f313432c21401082e687a4/packages/material-ui/src/Modal/ModalManager.js#L53 since `data.style` is `undefined` and prob...
2018-11-29 23:32:56+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/Modal/Modal.test.js-><Modal /> prop: onRendered should fire', 'packages/material-ui/src/Modal/Modal.test.js-><Modal /> backdrop should render a backdrop component into the portal before the modal content', 'packages/material-ui/src/Modal/Modal.test.js-><Modal /> handleDocumentKeyDown() should...
['packages/material-ui/src/Modal/Modal.test.js-><Modal /> two modal at the same time should open and close']
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/Modal/Modal.test.js --reporter /testbed/custom-reporter.js --exit
Bug Fix
false
true
false
false
1
0
1
true
false
["packages/material-ui/src/Modal/ModalManager.js->program->class_declaration:ModalManager->method_definition:mount"]
mui/material-ui
13,789
mui__material-ui-13789
['13648']
42c60e9848696ebc167d87e1743222e758d0213e
diff --git a/.size-limit.js b/.size-limit.js --- a/.size-limit.js +++ b/.size-limit.js @@ -22,7 +22,7 @@ module.exports = [ name: 'The size of the @material-ui/core modules', webpack: true, path: 'packages/material-ui/build/index.js', - limit: '94.5 KB', + limit: '94.6 KB', }, { name: 'T...
diff --git a/packages/material-ui/src/Dialog/Dialog.test.js b/packages/material-ui/src/Dialog/Dialog.test.js --- a/packages/material-ui/src/Dialog/Dialog.test.js +++ b/packages/material-ui/src/Dialog/Dialog.test.js @@ -129,15 +129,11 @@ describe('<Dialog />', () => { wrapper.setProps({ onClose }); const...
[Dialog] onBackdropClick event fires when draggable item released on it If Dialog contains any draggable component (e.g. sortable list from [react-sortable-hoc](https://clauderic.github.io/react-sortable-hoc/)) and this component have been dragging and has released over 'backdrop zone' then onBackdropClick event fires....
This happens for any MUI Dialog in chrome and is reproducible on the demo page: https://material-ui.com/demos/dialogs/. Just mouse down on a dialog, move your mouse off and when you mouse up the Dialog will close @oliviertassinari looking at bootstrap they seem to handle this using: ``` $(this._dialog).on(Event.MO...
2018-12-04 00:39:42+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/Dialog/Dialog.test.js-><Dialog /> should be open by default', 'packages/material-ui/src/Dialog/Dialog.test.js-><Dialog /> prop: fullScreen false should not render fullScreen', 'packages/material-ui/src/Dialog/Dialog.test.js-><Dialog /> prop: fullWidth should set `fullWidth` class if specified...
['packages/material-ui/src/Dialog/Dialog.test.js-><Dialog /> backdrop should store the click target on mousedown', 'packages/material-ui/src/Dialog/Dialog.test.js-><Dialog /> backdrop should clear click target on successful backdrop click', 'packages/material-ui/src/Dialog/Dialog.test.js-><Dialog /> backdrop should not...
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/Dialog/Dialog.test.js --reporter /testbed/custom-reporter.js --exit
Bug Fix
false
false
false
true
1
1
2
false
false
["packages/material-ui/src/Dialog/Dialog.js->program->class_declaration:Dialog->method_definition:render", "packages/material-ui/src/Dialog/Dialog.js->program->class_declaration:Dialog"]
mui/material-ui
13,828
mui__material-ui-13828
['13713']
fb3a64f045ba5e2bb4255b792a9a7e506f9d510d
diff --git a/packages/material-ui/src/LinearProgress/LinearProgress.d.ts b/packages/material-ui/src/LinearProgress/LinearProgress.d.ts --- a/packages/material-ui/src/LinearProgress/LinearProgress.d.ts +++ b/packages/material-ui/src/LinearProgress/LinearProgress.d.ts @@ -13,6 +13,8 @@ export type LinearProgressClassKey ...
diff --git a/packages/material-ui/src/LinearProgress/LinearProgress.test.js b/packages/material-ui/src/LinearProgress/LinearProgress.test.js --- a/packages/material-ui/src/LinearProgress/LinearProgress.test.js +++ b/packages/material-ui/src/LinearProgress/LinearProgress.test.js @@ -25,9 +25,10 @@ describe('<LinearProgr...
[LinearProgress] Add more classes keys <!--- Provide a general summary of the feature in the Title above --> There are some useful classes that could be easily added along with a potential class rename to avoid confusion <!-- Thank you very much for contributing to Material-UI by creating an issue! ❤️ To ...
@szrharrison I'm proposing the following approach: - We add the `indeterminate` and `determinate` style rules (classes) to the root element, applied when the right variant property is provided. - `query` is already applied on the root element, no need to change anything. - You can already use the `bar` style rule to...
2018-12-05 22:39:42+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/LinearProgress/LinearProgress.test.js-><LinearProgress /> should render for the primary color', 'packages/material-ui/src/LinearProgress/LinearProgress.test.js-><LinearProgress /> should render with the user and root classes', 'packages/material-ui/src/LinearProgress/LinearProgress.test.js-><...
['packages/material-ui/src/LinearProgress/LinearProgress.test.js-><LinearProgress /> should set width of bar1 on determinate variant', 'packages/material-ui/src/LinearProgress/LinearProgress.test.js-><LinearProgress /> should render with determinate classes for the primary color', 'packages/material-ui/src/LinearProgre...
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/LinearProgress/LinearProgress.test.js --reporter /testbed/custom-reporter.js --exit
Feature
false
true
false
false
1
0
1
true
false
["packages/material-ui/src/LinearProgress/LinearProgress.js->program->function_declaration:LinearProgress"]
mui/material-ui
13,899
mui__material-ui-13899
['12390']
64714e6b367632e3acb973ef3ae2a28eed25aadd
diff --git a/docs/src/pages/style/color/ColorDemo.js b/docs/src/pages/style/color/ColorDemo.js --- a/docs/src/pages/style/color/ColorDemo.js +++ b/docs/src/pages/style/color/ColorDemo.js @@ -43,7 +43,7 @@ const styles = theme => ({ function ColorDemo(props) { const { classes, data, theme } = props; - const prima...
diff --git a/packages/material-ui/src/styles/createPalette.test.js b/packages/material-ui/src/styles/createPalette.test.js --- a/packages/material-ui/src/styles/createPalette.test.js +++ b/packages/material-ui/src/styles/createPalette.test.js @@ -216,11 +216,21 @@ describe('createPalette()', () => { }); it('sho...
Make theme.palette.augmentColor() pure **We love the theme object, but starting to see how it could be extended.** • In most cases, a primary, secondary, error and grey color palette will support most applications. • I am having to add custom colors to the theme to cover a warning situation. Rather than extend t...
@designjudo Here is how we handle the problem on our product. Material-UI is exposing the `theme.palette.augmentColor` function for this use case. The API isn't perfect (mutable) nor it's documented yet 🙈. So, you should be able to add a warning color into your palette like this: ```jsx import { createMuiTheme } fr...
2018-12-13 18:02:00+00:00
TypeScript
FROM polybench_typescript_base WORKDIR /testbed COPY . . RUN . /usr/local/nvm/nvm.sh && nvm use 14.21.3 && rm -rf node_modules && yarn install && yarn add -D -W --ignore-engines @types/prop-types @types/react-dom @types/sinon @types/chai @types/chai-dom @types/format-util RUN echo 'var mocha = require("mocha");' > cust...
['packages/material-ui/src/styles/createPalette.test.js->createPalette() should create a material design palette according to spec', 'packages/material-ui/src/styles/createPalette.test.js->createPalette() augmentColor should throw when the input is invalid', 'packages/material-ui/src/styles/createPalette.test.js->creat...
['packages/material-ui/src/styles/createPalette.test.js->createPalette() should calculate light and dark colors if not provided']
[]
. /usr/local/nvm/nvm.sh && nvm use 14.21.3 && yarn cross-env NODE_ENV=test mocha packages/material-ui/src/styles/createPalette.test.js --reporter /testbed/custom-reporter.js --exit
Feature
false
true
false
false
7
0
7
false
false
["packages/material-ui/src/styles/createPalette.js->program->function_declaration:createPalette->function_declaration:augmentColor", "packages/material-ui/src/styles/createPalette.js->program->function_declaration:createPalette", "packages/material-ui/src/styles/createPalette.js->program->function_declaration:createPal...