Spaces:
Build error
Build error
File size: 27,460 Bytes
c8e832f | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 | python inference.py --model gpt-3.5-turbo --base-url "http://localhost:8000/v1"
python inference.py --model gemini-2.0-flash --base-url "https://generativelanguage.googleapis.com/openai/"
python inference.py --model deepseek-chat --base-url "https://api.deepseek.com"# Python Env Project Guide
This document explains how to work with the `python_env` project end to end:
1. What the environment is trying to do
2. How the current code is structured
3. How each route works
4. How to test each route manually
5. How to use the inference script
6. How to prepare data so an RL or agent-training setup can learn more effectively
7. How the project maps to the hackathon functional requirements
The goal is practical: after reading this file, you should be able to start the server, hit every route, understand what each response means, run the baseline, and know what data to collect next.
## 1. Project Goal
This environment simulates a real software engineering workflow: Python code review.
An agent is given Python code and must:
- detect correctness bugs
- detect security risks
- detect maintainability problems
- detect obvious performance issues
- optionally suggest improved code
This is a valid real-world environment because code review is an actual human task used in engineering teams every day.
## 2. High-Level Architecture
The project has four main parts:
- `models.py`
Defines the typed Pydantic models for actions, observations, evaluations, config, health, and direct-review payloads.
- `server/code_review_environment.py`
Implements the environment logic: `reset()`, `step()`, reward shaping, task progression, hints, history, and grading integration.
- `server/task_bank.py`, `server/grading.py`, `server/static_review.py`
These files define the benchmark tasks, deterministic graders, and direct static review rules.
- `server/app.py`
Exposes both:
- OpenEnv-compatible endpoints such as `/reset`, `/step`, `/state`, `/schema`, `/ws`
- custom REST endpoints such as `/health`, `/tasks`, `/review`, `/config`, `/history`
- `inference.py`
Runs an OpenAI-compatible model against the environment and writes a reproducible report.
## 3. File-by-File Understanding
### `models.py`
Important models:
- `ReviewFinding`
One code-review issue found by the agent.
Fields:
- `title`
- `line`
- `category`
- `severity`
- `rationale`
- `recommendation`
- `rule_id`
- `PythonReviewAction`
What the agent sends to the environment.
Fields:
- `operation`
- `findings`
- `patched_code`
- `note`
- `PythonReviewObservation`
What the environment returns back.
Fields:
- `task`
- `instructions`
- `feedback`
- `submitted_findings`
- `hints_used`
- `attempts_remaining`
- `evaluation`
- `score`
- `review_time_ms`
- inherited OpenEnv fields such as `reward`, `done`, `metadata`
- `TaskEvaluation`
Deterministic grading output.
Fields:
- `matched_reference_ids`
- `matched_findings`
- `total_findings`
- `false_positives`
- `duplicate_findings`
- `weighted_recall`
- `patch_score`
- `score`
- `passed`
### `server/task_bank.py`
Contains the benchmark tasks.
Current tasks:
1. `py-review-easy`
Detect unsafe `eval` and division-by-zero risk.
2. `py-review-medium`
Detect mutable default list, quadratic membership check, and bare `except`.
3. `py-review-hard`
Detect `shell=True` command injection, stale cache bug, and shared output file risk.
Each task contains:
- code to review
- hints
- reference findings
- pass threshold
### `server/grading.py`
This is the benchmark grader.
It compares submitted findings to hidden reference findings and computes:
- weighted recall
- penalties for false positives
- penalties for duplicates
- optional patch quality score
- final score in `0.0` to `1.0`
This makes the task deterministic and reproducible, which is important for hackathon judging.
### `server/static_review.py`
This powers the `/review` endpoint for arbitrary code snippets.
It uses AST inspection to detect:
- `eval` / `exec`
- mutable default arguments
- `shell=True`
- bare `except`
- list-membership-inside-loop performance smell
- syntax errors
- `print()` used in application logic
This is not the task grader. It is the direct-review helper.
### Reward System
The reward system is **dynamic and multi-component**, designed to provide meaningful feedback at every step of the agent's learning process.
#### Reward Architecture
The system computes rewards using **6 independent components**:
1. **Progress Reward** (max +0.25)
- Awarded when the agent improves the score from one step to the next
- Formula: `min(PROGRESS_SCALE * score_delta, 0.25)`
- Encourages continuous improvement
2. **Syntax Reward** (max +0.35)
- One-time bonus awarded for fixing syntax errors (first time compiling)
- Applied once per episode when code transitions from uncompilable to compilable
- Acknowledges the critical first step of making code valid
3. **Test Reward** (max +0.20)
- Based on improvement in test pass rate
- Computed as: `min(TEST_PASS_REWARD_SCALE * test_improvement_fraction, 0.20)`
- Rewards incremental progress on passing more tests
4. **Quality Reward** (max +0.15)
- Based on AST-detected code quality metrics
- Rewards improvements in code structure, readability, and best practices
- Uses deterministic grader feedback
5. **Stagnation Penalty** (−0.10)
- Applied when the agent takes action but code doesn't change
- Encourages the agent to edit the code rather than analyze repeatedly
- Configurable via `STAGNATION_PENALTY` constant
6. **Regression Penalty** (scale −0.20)
- Applied when score decreases from previous step
- Formula: `REGRESSION_PENALTY_SCALE * abs(score_delta)`
- Discourages actions that make code worse
#### Reward Constants
Defined at the top of `server/env.py`:
```python
SYNTAX_FIX_BONUS = 0.35 # One-time syntax reward
TEST_PASS_REWARD_SCALE = 0.30 # Per test improvement
QUALITY_BONUS_SCALE = 0.15 # Code quality improvement
PROGRESS_SCALE = 0.25 # Score improvement
COMPLETION_BONUS = 0.50 # Full correctness bonus
INVALID_ACTION_PENALTY = 0.15 # For unsupported actions
STAGNATION_PENALTY = 0.10 # For unchanged code
REGRESSION_PENALTY_SCALE = 0.20 # For score decline
TIMEOUT_PENALTY = 0.15 # For execution timeout
```
#### Final Reward Computation
The final reward is:
```
total = progress + syntax + test + quality - stagnation - regression
final_reward = clamp(total, -1.0, +1.0)
```
The result is always between −1.0 and +1.0, providing bounded, interpretable feedback.
#### RewardDetails: Transparent Feedback
Every reward is returned as a `RewardDetails` object with these fields:
- `value`: The scalar reward for this step
- `syntax_reward`: Contribution from syntax fixes
- `test_reward`: Contribution from test improvements
- `quality_bonus`: Contribution from code quality
- `progress_delta`: Contribution from score improvement
- `stagnation_penalty`: Penalty for unchanged code
- `regression_penalty`: Penalty for score decline
- `prev_score` / `curr_score`: Score before and after the action
- `code_changed`: Whether the action modified the code
- `reason`: Human-readable explanation of the reward
This transparency is crucial for:
- Debugging agent behavior
- Understanding what drives reward
- Tuning the constants
- Training supervised models on reward components
#### Why This Design Helps Agents Learn
1. **Non-Constant**: Different actions produce different rewards, enabling meaningful gradient signals
2. **Progressive**: Early bonuses (syntax) are high; later improvements are smaller, promoting efficiency
3. **Transparent**: Detailed component breakdown helps agents understand what matters
4. **Bounded**: Clamping to [−1, 1] prevents reward hacking and explosion
5. **Balanced**: Positive and negative signals teach precision and recall together
### `server/code_review_environment.py`
This is the environment core.
Main methods:
- `reset()`
Rotates to the next task, resets episode state, and returns the initial observation.
- `step(action)`
Accepts a `PythonReviewAction`, grades it, shapes reward, updates history, and returns the new observation.
- `direct_review(code, context)`
Calls the static reviewer for arbitrary code.
- `list_tasks()`
Returns public descriptors for all tasks.
- `grade_task_submission(task_id, findings, patched_code)`
Grades a proposed submission against the deterministic rubric without stepping through an episode.
### `server/app.py`
This file wires everything to FastAPI and OpenEnv.
Important note:
- OpenEnv endpoints are managed through `create_app(PythonEnvironment, PythonReviewAction, PythonReviewObservation)`
- custom routes such as `/health`, `/tasks`, `/review`, `/history`, `/config` use a singleton `python_env`
That means:
- `/reset` and `/step` are served by OpenEnv session handling
- `/review`, `/tasks`, `/config`, `/history` are served by the singleton helper instance
This is fine for startup and manual testing, but if you want one fully unified state model later, you should refactor custom routes to read from the same managed environment/session layer.
## 4. Route-by-Route Guide
### OpenEnv Routes
These are important for validation and agents.
#### `POST /reset`
Purpose:
- starts a new episode
- rotates to the next benchmark task
- returns an initial observation
Use this when:
- you want to start evaluating an agent on a task
#### `POST /step`
Purpose:
- submit agent actions
- get reward, observation, and done flag
Use this when:
- manually simulating agent steps
- testing reward shaping and grading
#### `GET /state`
Purpose:
- returns current OpenEnv session state, typically `episode_id` and `step_count`
Use this when:
- debugging session behavior
#### `GET /schema`
Purpose:
- shows the action/observation schema expected by OpenEnv
Use this when:
- debugging payload formats
- verifying OpenEnv compatibility
#### `WS /ws`
Purpose:
- persistent lower-latency session transport for clients
Use this when:
- building actual agent loops with the `EnvClient`
### Custom REST Routes
#### `GET /health`
Purpose:
- quick health check for Docker and Hugging Face Spaces
Use this when:
- checking whether the server is alive
- validating deployment health
#### `GET /tasks`
Purpose:
- returns the three benchmark task descriptors
Use this when:
- reviewing available tasks
- building curriculum/eval metadata
#### `GET /tasks/{task_id}`
Purpose:
- returns one task descriptor
Use this when:
- inspecting a task before submitting findings
#### `POST /tasks/{task_id}/grade`
Purpose:
- grade a proposed set of findings against the deterministic task rubric
Use this when:
- validating benchmark grading directly
- building offline evaluation sets
#### `POST /review`
Purpose:
- run direct static review on arbitrary Python code
Use this when:
- testing the static analyzer
- building training examples
- verifying that common issues are caught
#### `GET /history`
Purpose:
- returns the singleton environment history
Use this when:
- checking what the custom singleton environment has processed
Note:
- this history is not the same as OpenEnv session history from `/step`
#### `DELETE /history`
Purpose:
- clears the singleton history
Use this when:
- resetting the custom review log before a test run
#### `GET /config`
Purpose:
- inspect config values such as penalties and task order
#### `PUT /config`
Purpose:
- update the environment config
Use this when:
- testing different reward penalties or task order
## 5. Manual Testing: Step by Step
Start the server:
```powershell
uvicorn server.app:app --reload --host 0.0.0.0 --port 8000
```
Open the docs:
```text
http://127.0.0.1:8000/docs
```
That is the easiest manual route explorer.
### Test 1: Health
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/health" -Method Get
```
Expected:
- `status` should be `ok`
- `task_count` should be `3`
### Test 2: List Tasks
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/tasks" -Method Get
```
Expected:
- three tasks
- each task has `task_id`, `difficulty`, `title`, `objective`, `code`
### Test 3: Get One Task
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/tasks/py-review-easy" -Method Get
```
### Test 4: Direct Static Review
```powershell
$body = @{
code = @"
def load_settings(config_text):
return eval(config_text)
"@
} | ConvertTo-Json
Invoke-RestMethod -Uri "http://127.0.0.1:8000/review" `
-Method Post `
-Body $body `
-ContentType "application/json"
```
Expected:
- at least one issue
- one issue should have `rule_id = "avoid-eval"`
### Test 5: Reset Episode
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/reset" `
-Method Post `
-Body "{}" `
-ContentType "application/json"
```
Expected:
- an observation with a `task`
- `done = false`
- `reward = 0`
### Test 6: Submit Partial Findings To `/step`
```powershell
$body = @{
operation = "submit_findings"
findings = @(
@{
title = "Avoid eval on untrusted configuration data"
line = 2
category = "security"
severity = "critical"
rationale = "eval can execute attacker-controlled code."
recommendation = "Use json.loads or ast.literal_eval."
rule_id = "avoid-eval"
}
)
patched_code = $null
note = "First pass review"
} | ConvertTo-Json -Depth 5
Invoke-RestMethod -Uri "http://127.0.0.1:8000/step" `
-Method Post `
-Body $body `
-ContentType "application/json"
```
Expected:
- positive reward
- improved `score`
- feedback mentioning a matched rubric item
### Test 7: Request A Hint
```powershell
$body = @{
operation = "request_hint"
findings = @()
patched_code = $null
note = "Need help"
} | ConvertTo-Json -Depth 5
Invoke-RestMethod -Uri "http://127.0.0.1:8000/step" `
-Method Post `
-Body $body `
-ContentType "application/json"
```
Expected:
- small negative reward
- feedback containing `Hint 1: ...`
### Test 8: Finalize A Full Submission
```powershell
$body = @{
operation = "finalize"
findings = @(
@{
title = "Avoid eval on untrusted configuration data"
line = 2
category = "security"
severity = "critical"
rationale = "eval can execute attacker-controlled code."
recommendation = "Use json.loads or ast.literal_eval."
rule_id = "avoid-eval"
},
@{
title = "Default count of zero causes a division by zero"
line = 5
category = "bug"
severity = "warning"
rationale = "count defaults to zero and division crashes."
recommendation = "Validate count before dividing."
rule_id = "division-by-zero-default"
}
)
patched_code = $null
note = "Final review"
} | ConvertTo-Json -Depth 6
Invoke-RestMethod -Uri "http://127.0.0.1:8000/step" `
-Method Post `
-Body $body `
-ContentType "application/json"
```
Expected:
- `done = true`
- `evaluation.passed = true`
- `score` near or above task threshold
### Test 9: Inspect State
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/state" -Method Get
```
### Test 10: Inspect Schemas
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/schema" -Method Get
```
### Test 11: Grade A Task Without Running An Episode
```powershell
$body = @{
operation = "submit_findings"
findings = @(
@{
title = "shell=True with interpolated input allows command injection"
line = 10
category = "security"
severity = "critical"
rationale = "The command string includes user input and runs via shell."
recommendation = "Pass args as a list and keep shell=False."
rule_id = "shell-true-command-injection"
}
)
patched_code = $null
note = "Offline grader test"
} | ConvertTo-Json -Depth 6
Invoke-RestMethod -Uri "http://127.0.0.1:8000/tasks/py-review-hard/grade" `
-Method Post `
-Body $body `
-ContentType "application/json"
```
### Test 12: Config Read And Update
Read:
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/config" -Method Get
```
Update:
```powershell
$body = @{
task_order = @("py-review-easy", "py-review-medium", "py-review-hard")
max_steps_per_task = 4
hint_penalty = 0.05
false_positive_penalty = 0.08
duplicate_penalty = 0.03
patch_bonus_multiplier = 0.2
max_history_entries = 50
} | ConvertTo-Json
Invoke-RestMethod -Uri "http://127.0.0.1:8000/config" `
-Method Put `
-Body $body `
-ContentType "application/json"
```
### Test 13: History
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/history" -Method Get
```
Clear:
```powershell
Invoke-RestMethod -Uri "http://127.0.0.1:8000/history" -Method Delete
```
## 6. How To Test Using The Inference Script
The inference script is for model-vs-environment evaluation.
### Required Variables
```powershell
$env:API_BASE_URL="https://api.openai.com/v1"
$env:MODEL_NAME="gpt-4.1-mini"
$env:OPENAI_API_KEY="your_key_here"
```
If you want it to hit your local server instead of launching Docker:
```powershell
$env:ENV_BASE_URL="http://127.0.0.1:8000"
```
Optional:
```powershell
$env:MAX_TASKS="3"
$env:MAX_STEPS="3"
$env:INFERENCE_REPORT_PATH="inference_results.json"
```
Run:
```powershell
python inference.py
```
What it does:
1. connects to the environment
2. resets through up to 3 tasks
3. sends task code and feedback to the model
4. expects strict JSON findings back
5. submits them through `step()`
6. logs score and reward per step
7. writes a final report JSON file
### How To Interpret The Output
Focus on:
- `mean_score`
Overall average benchmark score
- per-task `score`
How well the model solved each task
- `passed`
Whether score met that task’s threshold
- step logs
Show whether the model is improving over trajectory or getting stuck
If the model keeps returning empty findings:
- improve the system prompt
- reduce task ambiguity
- add examples of desired findings
- ensure the model endpoint supports the chosen format well
## 7. How To Build Better Training Data
If you want an RL environment to actually learn, the biggest bottleneck is data quality.
You need more than just three final benchmark tasks. You need trajectories, partial attempts, and failure examples.
### Data Types You Should Collect
#### A. Gold Task Rubrics
For each task, store:
- code snippet
- hidden reference findings
- severity
- category
- expected line numbers
- good recommendations
This is already partially represented by `server/task_bank.py`.
#### B. Positive Demonstrations
Create solved examples where the review is high quality.
Each example should include:
- task code
- one or more strong findings
- strong rationales
- strong recommendations
- optional patch
- final score
This helps supervised warm-start and behavior cloning.
#### C. Partial Trajectories
This is important for RL.
Store intermediate attempts like:
- first attempt finds one issue
- second attempt adds another issue
- third attempt finalizes
This is what teaches agents to improve over time, not just emit one final perfect answer.
#### D. Negative Examples
You should also store:
- false positives
- irrelevant complaints
- duplicate findings
- hallucinated issues
- weak recommendations
Why:
- the reward function penalizes these
- the model must learn precision, not just recall
#### E. Hint Usage Examples
Store trajectories where:
- the agent requests a hint
- then improves its findings
This teaches policy behavior around when hints are worth the penalty.
#### F. Patch Examples
For tasks where patch quality matters, store:
- original code
- weak patch
- good patch
- patch score
This helps the model learn that code edits should remove actual problems, not just change formatting.
## 8. Recommended Dataset Format
Use JSONL so it is easy to stream and train on.
### Benchmark Task Record
```json
{
"task_id": "py-review-easy",
"difficulty": "easy",
"code": "def load_settings(config_text):\n return eval(config_text)",
"reference_findings": [
{
"rule_id": "avoid-eval",
"line": 2,
"category": "security",
"severity": "critical"
}
]
}
```
### Trajectory Record
```json
{
"task_id": "py-review-medium",
"episode_id": "abc123",
"steps": [
{
"observation_feedback": "Review the Python snippet.",
"action": {
"operation": "submit_findings",
"findings": [
{
"title": "Mutable default argument leaks state",
"line": 1,
"category": "bug",
"severity": "warning"
}
]
},
"reward": 0.35,
"score": 0.35
},
{
"observation_feedback": "Matched 1 new rubric item(s): mutable-default-list",
"action": {
"operation": "finalize",
"findings": [
{
"title": "Mutable default argument leaks state",
"line": 1,
"category": "bug",
"severity": "warning"
},
{
"title": "Bare except hides failures",
"line": 12,
"category": "maintainability",
"severity": "warning"
}
]
},
"reward": 0.27,
"score": 0.62
}
]
}
```
## 9. How To Make RL Learn Better
### A. Add More Tasks
Three tasks are enough for the minimum requirement, but not enough for strong training.
You should expand with:
- file I/O bugs
- API misuse
- SQL injection
- unsafe deserialization
- concurrency issues
- caching mistakes
- resource leaks
- logic edge cases
Target:
- 50 to 200 deterministic tasks
- grouped by difficulty and domain
### B. Add More Partial Reward Signals
Current reward is already better than binary success/fail, but you can improve it.
Possible additions:
- small bonus when the first critical issue is found early
- higher reward for critical issues than style issues
- bonus when rationale quality is high
- bonus when recommendation mentions a correct mitigation pattern
- penalty if line numbers are missing when they should be known
### C. Improve Context In Observation
Right now the observation already gives:
- task metadata
- previous feedback
- submitted findings
- attempts remaining
You can improve learning further by including:
- a short list of matched findings so far
- a short list of remaining categories not yet covered
- normalized review rubric hints without leaking answers
- last action summary
This helps the agent reason about what it already did and what is still missing.
### D. Separate Training Tasks From Benchmark Tasks
Important:
- training tasks should be large and varied
- benchmark tasks should stay hidden and fixed
Do not train directly on the same exact benchmark set you plan to judge on.
### E. Add Preference Data
You can train preference models on:
- strong vs weak findings
- precise vs vague recommendations
- useful vs noisy patches
This is valuable for ranking quality beyond exact rubric matches.
## 10. Functional Requirements Mapping
Here is how your environment should be judged against the stated requirements.
### Requirement: Real-World Task Simulation
Status:
- satisfied in direction
Why:
- code review is a genuine engineering task
How to improve further:
- expand beyond tiny snippets into multi-function modules
- include operational and maintainability review, not just security lints
### Requirement: OpenEnv Spec Compliance
Status:
- mostly implemented in code
Implemented pieces:
- typed action model
- typed observation model
- `reset()`
- `step()`
- `state`
- `openenv.yaml`
- FastAPI/OpenEnv routes
What you still need to verify:
- `openenv validate`
- schema compatibility under your installed OpenEnv version
### Requirement: Minimum 3 Tasks With Agent Graders
Status:
- implemented
You have:
- easy
- medium
- hard
- deterministic grader returning `0.0` to `1.0`
### Requirement: Meaningful Reward Function
Status:
- implemented
Current reward signals:
- new rubric matches
- false positive penalties
- duplicate penalties
- hint penalties
- patch bonus
- finalize pass bonus
### Requirement: Baseline Inference Script
Status:
- implemented
Current `inference.py`:
- uses OpenAI client
- reads env vars
- runs tasks
- writes report
What to verify:
- actual runtime under 20 minutes
- reproducible output with your chosen model endpoint
### Requirement: HF Spaces + Docker
Status:
- code is prepared
You still need to verify:
- `docker build -f server/Dockerfile .`
- local container startup
- `openenv push`
- `/health` returns 200 on the deployed Space
## 11. Recommended Manual Validation Checklist
Before submission, run these in order:
1. Start server locally
2. Hit `/health`
3. Hit `/docs`
4. Test `/tasks`
5. Test `/review` with unsafe examples
6. Test `/reset`
7. Test `/step` with partial findings
8. Test `/step` with finalize
9. Test `/tasks/{task_id}/grade`
10. Run `pytest`
11. Run `openenv validate`
12. Run `python inference.py`
13. Build Docker image
14. Deploy to Hugging Face Space
15. Re-test `/health` and `/reset` on the live Space
## 12. Suggested Immediate Next Steps
If you want the environment to become stronger quickly, do this next:
1. Add 10 to 20 more benchmark-style tasks in `server/task_bank.py`
2. Save solved and failed trajectories as JSONL files under a new `dataset/` directory
3. Refactor custom route state so `/history` and OpenEnv `/step` share one coherent session story
4. Run `openenv validate`
5. Run `inference.py` against your local server and inspect the report
## 13. Quick Commands Summary
Start server:
```powershell
uvicorn server.app:app --reload --host 0.0.0.0 --port 8000
```
Open docs:
```text
http://127.0.0.1:8000/docs
```
Run example tests:
```powershell
python -m pytest tests -q
```
Run inference locally:
```powershell
$env:API_BASE_URL="https://api.openai.com/v1"
$env:MODEL_NAME="gpt-4.1-mini"
$env:OPENAI_API_KEY="your_key"
$env:ENV_BASE_URL="http://127.0.0.1:8000"
python inference.py
```
Validate OpenEnv:
```powershell
openenv validate
```
Build Docker:
```powershell
docker build -t python_env-env:latest -f server/Dockerfile .
```
Deploy:
```powershell
openenv push
```
|