refactor: remove unused routes and clean up API endpoints

server/app.py

@@ -2,9 +2,8 @@ from __future__ import annotations
 
 import os
 from pathlib import Path
-from typing import Iterable
 
-from fastapi import FastAPI, HTTPException, Query
+from fastapi import FastAPI, HTTPException
 from fastapi.responses import RedirectResponse
 from openenv.core import create_fastapi_app
 from dotenv import load_dotenv
@@ -14,7 +13,7 @@ from llmserve_env.task_catalog import get_action_schema, get_task_catalog
 from server.baseline_inference import create_local_runner, run_baseline_suite
 from server.grader import GraderEngine
 from server.llmserve_environment import LLMServeEnvironment
-from server.schemas import GraderRequest, ResetRequest, StepRequest
+from server.schemas import GraderRequest
 from server.session_manager import SessionManager
 from server.web_ui import create_web_app
 
@@ -38,20 +37,7 @@ def get_env() -> LLMServeEnvironment:
     return shared_env
 
 
-def _remove_routes(app: FastAPI, paths: Iterable[str]) -> None:
-    blocked = set(paths)
-    app.router.routes[:] = [route for route in app.router.routes if getattr(route, "path", None) not in blocked]
-
-
 def _register_extra_routes(app: FastAPI) -> FastAPI:
-    def _resolve_env(session_id: str | None) -> LLMServeEnvironment:
-        if not session_id:
-            return shared_env
-        try:
-            return session_manager.get(session_id)
-        except KeyError as exc:
-            raise HTTPException(status_code=404, detail=str(exc)) from exc
-
     @app.get("/")
     def root() -> RedirectResponse:
         return RedirectResponse(url="/web", status_code=307)
@@ -69,40 +55,6 @@ def _register_extra_routes(app: FastAPI) -> FastAPI:
             "active_sessions": session_manager.count(),
         }
 
-    @app.post("/reset")
-    def reset(payload: ResetRequest) -> dict[str, object]:
-        session_id, env = session_manager.create(
-            task_id=payload.task_id,
-            seed=payload.seed,
-            episode_id=payload.episode_id,
-        )
-        observation = env.observations[-1]
-
-        return {
-            "session_id": session_id,
-            "observation": observation.model_dump(mode="json"),
-            "reward": observation.reward,
-            "done": observation.done,
-            "metadata": observation.metadata,
-        }
-
-    @app.post("/step")
-    def step(payload: StepRequest) -> dict[str, object]:
-        env = _resolve_env(payload.session_id)
-        observation = env.step(payload.action)
-        return {
-            "session_id": payload.session_id or env.state.episode_id,
-            "observation": observation.model_dump(mode="json"),
-            "reward": observation.reward,
-            "done": observation.done,
-            "metadata": observation.metadata,
-        }
-
-    @app.get("/state")
-    def state(session_id: str | None = Query(default=None)) -> dict[str, object]:
-        env = _resolve_env(session_id)
-        return env.state.model_dump(mode="json")
-
     @app.post("/grader")
     def grade(payload: GraderRequest | None = None) -> dict[str, object]:
         if payload and payload.episode_log is not None:
@@ -154,7 +106,6 @@ def create_application(enable_web: bool = True) -> FastAPI:
         ServeAction,
         ServeObservation,
     )
-    _remove_routes(app, {"/reset", "/step", "/state"})
     if enable_web:
         app = create_web_app(app, session_manager, shared_env)
     return _register_extra_routes(app)

tests/test_api.py

@@ -1,11 +1,12 @@
 from __future__ import annotations
 
 import asyncio
+import os
 import pytest
 from fastapi import HTTPException
+from fastapi.testclient import TestClient
 
 from server.app import create_application, shared_env
-from server.schemas import ResetRequest, StepRequest
 
 
 def _route_map():
@@ -34,6 +35,16 @@ def test_session_routes_are_not_duplicated() -> None:
     assert paths.count("/state") == 1
 
 
+def test_reset_endpoint_accepts_empty_json_body() -> None:
+    os.environ.setdefault("MPLCONFIGDIR", "/tmp")
+    client = TestClient(create_application(enable_web=False))
+    response = client.post("/reset", json={})
+    assert response.status_code == 200
+    payload = response.json()
+    assert payload["observation"]["task_id"] == "static_workload"
+    assert payload["observation"]["step_index"] == 0
+
+
 def test_health_endpoint_direct() -> None:
     data = _call(_route_map()["/health"])
     status = data["status"] if isinstance(data, dict) else data.status
@@ -64,32 +75,3 @@ def test_baseline_endpoint_direct() -> None:
 def test_demo_redirects_to_web() -> None:
     response = _call(_route_map()["/demo"])
     assert response.headers["location"] == "/web"
-
-
-def test_http_session_advances_across_multiple_steps() -> None:
-    routes = _route_map()
-    reset_endpoint = routes["/reset"]
-    step_endpoint = routes["/step"]
-    state_endpoint = routes["/state"]
-
-    reset_payload = _call(reset_endpoint, ResetRequest(task_id="bursty_workload", seed=42))
-    session_id = reset_payload["session_id"]
-    assert session_id
-    assert reset_payload["observation"]["step_index"] == 0
-
-    action = {
-        "batch_cap": 32,
-        "kv_budget_fraction": 1.0,
-        "speculation_depth": 0,
-        "quantization_tier": "FP16",
-        "prefill_decode_split": False,
-        "priority_routing": False,
-    }
-    first_payload = _call(step_endpoint, StepRequest(session_id=session_id, action=action))
-    second_payload = _call(step_endpoint, StepRequest(session_id=session_id, action=action))
-    assert first_payload["observation"]["step_index"] == 1
-    assert second_payload["observation"]["step_index"] == 2
-    assert first_payload["reward"] != second_payload["reward"]
-
-    state_payload = _call(state_endpoint, session_id=session_id)
-    assert state_payload["step_count"] == 2