File size: 56,416 Bytes
8ede856 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 | """Tests for astr_main_agent module."""
import os
from unittest.mock import AsyncMock, MagicMock, patch
import pytest
from astrbot.core import astr_main_agent as ama
from astrbot.core.agent.mcp_client import MCPTool
from astrbot.core.agent.tool import FunctionTool, ToolSet
from astrbot.core.conversation_mgr import Conversation
from astrbot.core.message.components import File, Image, Plain, Reply
from astrbot.core.platform.astr_message_event import AstrMessageEvent
from astrbot.core.platform.platform_metadata import PlatformMetadata
from astrbot.core.provider import Provider
from astrbot.core.provider.entities import ProviderRequest
@pytest.fixture
def mock_provider():
"""Create a mock provider."""
provider = MagicMock(spec=Provider)
provider.provider_config = {
"id": "test-provider",
"modalities": ["image", "tool_use"],
}
provider.get_model.return_value = "gpt-4"
return provider
@pytest.fixture
def mock_context():
"""Create a mock Context."""
ctx = MagicMock()
ctx.get_config.return_value = {}
ctx.conversation_manager = MagicMock()
ctx.persona_manager = MagicMock()
ctx.persona_manager.personas_v3 = []
ctx.persona_manager.resolve_selected_persona = AsyncMock(
return_value=(None, None, None, False)
)
ctx.get_llm_tool_manager.return_value = MagicMock()
ctx.subagent_orchestrator = None
return ctx
@pytest.fixture
def mock_event():
"""Create a mock AstrMessageEvent."""
platform_meta = PlatformMetadata(
id="test_platform",
name="test_platform",
description="Test platform",
)
message_obj = MagicMock()
message_obj.message = [Plain(text="Hello")]
message_obj.sender = MagicMock(user_id="user123", nickname="TestUser")
message_obj.group_id = None
message_obj.group = None
event = MagicMock(spec=AstrMessageEvent)
event.message_str = "Hello"
event.message_obj = message_obj
event.platform_meta = platform_meta
event.session_id = "session123"
event.unified_msg_origin = "test_platform:private:session123"
event.get_extra.return_value = None
event.get_platform_name.return_value = "test_platform"
event.get_platform_id.return_value = "test_platform"
event.get_group_id.return_value = None
event.get_sender_name.return_value = "TestUser"
event.trace = MagicMock()
event.plugins_name = None
return event
@pytest.fixture
def mock_conversation():
"""Create a mock conversation."""
conv = MagicMock(spec=Conversation)
conv.cid = "conv-id"
conv.persona_id = None
conv.history = "[]"
return conv
@pytest.fixture
def sample_config():
"""Create a sample MainAgentBuildConfig."""
module = ama
return module.MainAgentBuildConfig(
tool_call_timeout=60,
streaming_response=True,
file_extract_enabled=True,
file_extract_prov="moonshotai",
file_extract_msh_api_key="test-api-key",
)
def _new_mock_conversation(cid: str = "conv-id") -> MagicMock:
conv = MagicMock(spec=Conversation)
conv.cid = cid
conv.persona_id = None
conv.history = "[]"
return conv
def _setup_conversation_for_build(conv_mgr, cid: str = "conv-id") -> MagicMock:
conv_mgr.get_curr_conversation_id = AsyncMock(return_value=None)
conv_mgr.new_conversation = AsyncMock(return_value=cid)
conversation = _new_mock_conversation(cid=cid)
conv_mgr.get_conversation = AsyncMock(return_value=conversation)
return conversation
class TestMainAgentBuildConfig:
"""Tests for MainAgentBuildConfig dataclass."""
def test_config_initialization(self):
"""Test MainAgentBuildConfig initialization with defaults."""
module = ama
config = module.MainAgentBuildConfig(tool_call_timeout=60)
assert config.tool_call_timeout == 60
assert config.tool_schema_mode == "full"
assert config.provider_wake_prefix == ""
assert config.streaming_response is True
assert config.sanitize_context_by_modalities is False
assert config.kb_agentic_mode is False
assert config.file_extract_enabled is False
assert config.llm_safety_mode is True
def test_config_with_custom_values(self):
"""Test MainAgentBuildConfig with custom values."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=120,
tool_schema_mode="skills-like",
provider_wake_prefix="/",
streaming_response=False,
kb_agentic_mode=True,
file_extract_enabled=True,
computer_use_runtime="sandbox",
add_cron_tools=False,
)
assert config.tool_call_timeout == 120
assert config.tool_schema_mode == "skills-like"
assert config.provider_wake_prefix == "/"
assert config.streaming_response is False
assert config.kb_agentic_mode is True
assert config.file_extract_enabled is True
assert config.computer_use_runtime == "sandbox"
assert config.add_cron_tools is False
class TestSelectProvider:
"""Tests for _select_provider function."""
def test_select_provider_by_id(self, mock_event, mock_context, mock_provider):
"""Test selecting provider by ID from event extra."""
module = ama
mock_event.get_extra.side_effect = lambda k: (
"test-provider" if k == "selected_provider" else None
)
mock_context.get_provider_by_id.return_value = mock_provider
result = module._select_provider(mock_event, mock_context)
assert result == mock_provider
mock_context.get_provider_by_id.assert_called_once_with("test-provider")
def test_select_provider_not_found(self, mock_event, mock_context):
"""Test selecting provider when ID is not found."""
module = ama
mock_event.get_extra.side_effect = lambda k: (
"non-existent" if k == "selected_provider" else None
)
mock_context.get_provider_by_id.return_value = None
result = module._select_provider(mock_event, mock_context)
assert result is None
def test_select_provider_invalid_type(self, mock_event, mock_context):
"""Test selecting provider when result is not a Provider instance."""
module = ama
mock_event.get_extra.side_effect = lambda k: (
"invalid" if k == "selected_provider" else None
)
mock_context.get_provider_by_id.return_value = "not a provider"
result = module._select_provider(mock_event, mock_context)
assert result is None
def test_select_provider_fallback(self, mock_event, mock_context, mock_provider):
"""Test provider selection fallback to using provider."""
module = ama
mock_event.get_extra.return_value = None
mock_context.get_using_provider.return_value = mock_provider
result = module._select_provider(mock_event, mock_context)
assert result == mock_provider
mock_context.get_using_provider.assert_called_once_with(
umo=mock_event.unified_msg_origin
)
def test_select_provider_fallback_error(self, mock_event, mock_context):
"""Test provider selection when fallback raises ValueError."""
module = ama
mock_event.get_extra.return_value = None
mock_context.get_using_provider.side_effect = ValueError("Test error")
result = module._select_provider(mock_event, mock_context)
assert result is None
class TestGetSessionConv:
"""Tests for _get_session_conv function."""
@pytest.mark.asyncio
async def test_get_session_conv_existing(
self, mock_event, mock_context, mock_conversation
):
"""Test getting existing conversation."""
module = ama
conv_mgr = mock_context.conversation_manager
conv_mgr.get_curr_conversation_id = AsyncMock(return_value="existing-conv-id")
conv_mgr.get_conversation = AsyncMock(return_value=mock_conversation)
result = await module._get_session_conv(mock_event, mock_context)
assert result == mock_conversation
conv_mgr.get_curr_conversation_id.assert_called_once_with(
mock_event.unified_msg_origin
)
conv_mgr.get_conversation.assert_called_once_with(
mock_event.unified_msg_origin, "existing-conv-id"
)
@pytest.mark.asyncio
async def test_get_session_conv_create_new(self, mock_event, mock_context):
"""Test creating new conversation when none exists."""
module = ama
conv_mgr = mock_context.conversation_manager
conv_mgr.get_curr_conversation_id = AsyncMock(return_value=None)
conv_mgr.new_conversation = AsyncMock(return_value="new-conv-id")
mock_conversation = MagicMock(spec=Conversation)
mock_conversation.cid = "new-conv-id"
mock_conversation.persona_id = None
mock_conversation.history = "[]"
conv_mgr.get_conversation = AsyncMock(return_value=mock_conversation)
result = await module._get_session_conv(mock_event, mock_context)
assert result == mock_conversation
conv_mgr.new_conversation.assert_called_once_with(
mock_event.unified_msg_origin, mock_event.get_platform_id()
)
@pytest.mark.asyncio
async def test_get_session_conv_retry(self, mock_event, mock_context):
"""Test retrying conversation creation after failure."""
module = ama
conv_mgr = mock_context.conversation_manager
conv_mgr.get_curr_conversation_id = AsyncMock(return_value="conv-id")
conv_mgr.get_conversation = AsyncMock(return_value=None)
conv_mgr.new_conversation = AsyncMock(return_value="retry-conv-id")
mock_conversation = MagicMock(spec=Conversation)
mock_conversation.cid = "retry-conv-id"
mock_conversation.persona_id = None
mock_conversation.history = "[]"
conv_mgr.get_conversation.side_effect = [None, mock_conversation]
result = await module._get_session_conv(mock_event, mock_context)
assert result == mock_conversation
assert conv_mgr.new_conversation.call_count == 1
assert conv_mgr.get_conversation.call_count == 2
@pytest.mark.asyncio
async def test_get_session_conv_failure(self, mock_event, mock_context):
"""Test RuntimeError when conversation creation fails."""
module = ama
conv_mgr = mock_context.conversation_manager
conv_mgr.get_curr_conversation_id = AsyncMock(return_value=None)
conv_mgr.new_conversation = AsyncMock(return_value="new-conv-id")
conv_mgr.get_conversation = AsyncMock(return_value=None)
with pytest.raises(RuntimeError, match="无法创建新的对话。"):
await module._get_session_conv(mock_event, mock_context)
class TestApplyKb:
"""Tests for _apply_kb function."""
@pytest.mark.asyncio
async def test_apply_kb_without_agentic_mode(self, mock_event, mock_context):
"""Test applying knowledge base in non-agentic mode."""
module = ama
req = ProviderRequest(prompt="test question", system_prompt="System prompt")
config = module.MainAgentBuildConfig(
tool_call_timeout=60, kb_agentic_mode=False
)
with patch(
"astrbot.core.astr_main_agent.retrieve_knowledge_base",
AsyncMock(return_value="KB result"),
):
await module._apply_kb(mock_event, req, mock_context, config)
assert "[Related Knowledge Base Results]:" in req.system_prompt
assert "KB result" in req.system_prompt
@pytest.mark.asyncio
async def test_apply_kb_with_agentic_mode(self, mock_event, mock_context):
"""Test applying knowledge base in agentic mode."""
module = ama
req = ProviderRequest(prompt="test question")
config = module.MainAgentBuildConfig(tool_call_timeout=60, kb_agentic_mode=True)
await module._apply_kb(mock_event, req, mock_context, config)
assert req.func_tool is not None
@pytest.mark.asyncio
async def test_apply_kb_no_prompt(self, mock_event, mock_context):
"""Test applying knowledge base when prompt is None."""
module = ama
req = ProviderRequest(prompt=None, system_prompt="System")
config = module.MainAgentBuildConfig(
tool_call_timeout=60, kb_agentic_mode=False
)
await module._apply_kb(mock_event, req, mock_context, config)
assert req.system_prompt == "System"
@pytest.mark.asyncio
async def test_apply_kb_no_result(self, mock_event, mock_context):
"""Test applying knowledge base when no result is returned."""
module = ama
req = ProviderRequest(prompt="test", system_prompt="System")
config = module.MainAgentBuildConfig(
tool_call_timeout=60, kb_agentic_mode=False
)
with patch(
"astrbot.core.astr_main_agent.retrieve_knowledge_base",
AsyncMock(return_value=None),
):
await module._apply_kb(mock_event, req, mock_context, config)
assert req.system_prompt == "System"
@pytest.mark.asyncio
async def test_apply_kb_with_existing_tools(self, mock_event, mock_context):
"""Test applying knowledge base with existing toolset."""
module = ama
existing_tools = ToolSet()
req = ProviderRequest(prompt="test", func_tool=existing_tools)
config = module.MainAgentBuildConfig(tool_call_timeout=60, kb_agentic_mode=True)
await module._apply_kb(mock_event, req, mock_context, config)
assert req.func_tool is not None
class TestApplyFileExtract:
"""Tests for _apply_file_extract function."""
@pytest.mark.asyncio
async def test_file_extract_basic(self, mock_event, sample_config):
"""Test basic file extraction."""
module = ama
mock_file = MagicMock(spec=File)
mock_file.name = "test.pdf"
mock_file.get_file = AsyncMock(return_value="/path/to/test.pdf")
mock_event.message_obj.message = [mock_file]
req = ProviderRequest(prompt="Summarize")
with patch(
"astrbot.core.astr_main_agent.extract_file_moonshotai"
) as mock_extract:
mock_extract.return_value = "File content"
await module._apply_file_extract(mock_event, req, sample_config)
assert len(req.contexts) == 1
assert "File Extract Results" in req.contexts[0]["content"]
@pytest.mark.asyncio
async def test_file_extract_no_files(self, mock_event, sample_config):
"""Test file extraction when no files present."""
module = ama
mock_event.message_obj.message = [Plain(text="Hello")]
req = ProviderRequest(prompt="Hello")
await module._apply_file_extract(mock_event, req, sample_config)
assert len(req.contexts) == 0
@pytest.mark.asyncio
async def test_file_extract_in_reply(self, mock_event, sample_config):
"""Test file extraction from reply chain."""
module = ama
mock_file = MagicMock(spec=File)
mock_file.name = "reply.pdf"
mock_file.get_file = AsyncMock(return_value="/path/to/reply.pdf")
mock_reply = MagicMock(spec=Reply)
mock_reply.chain = [mock_file]
mock_event.message_obj.message = [mock_reply]
req = ProviderRequest(prompt="Summarize")
with patch(
"astrbot.core.astr_main_agent.extract_file_moonshotai"
) as mock_extract:
mock_extract.return_value = "Reply content"
await module._apply_file_extract(mock_event, req, sample_config)
assert len(req.contexts) == 1
@pytest.mark.asyncio
async def test_file_extract_no_prompt(self, mock_event, sample_config):
"""Test file extraction when prompt is empty."""
module = ama
mock_file = MagicMock(spec=File)
mock_file.name = "test.pdf"
mock_file.get_file = AsyncMock(return_value="/path/to/test.pdf")
mock_event.message_obj.message = [mock_file]
req = ProviderRequest(prompt=None)
with patch(
"astrbot.core.astr_main_agent.extract_file_moonshotai"
) as mock_extract:
mock_extract.return_value = "Content"
await module._apply_file_extract(mock_event, req, sample_config)
assert req.prompt == "总结一下文件里面讲了什么？"
@pytest.mark.asyncio
async def test_file_extract_no_api_key(self, mock_event):
"""Test file extraction when no API key is configured."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
file_extract_enabled=True,
file_extract_msh_api_key="",
)
mock_file = MagicMock(spec=File)
mock_file.name = "test.pdf"
mock_file.get_file = AsyncMock(return_value="/path/to/test.pdf")
mock_event.message_obj.message = [mock_file]
req = ProviderRequest(prompt="Summarize")
await module._apply_file_extract(mock_event, req, config)
assert len(req.contexts) == 0
class TestEnsurePersonaAndSkills:
"""Tests for _ensure_persona_and_skills function."""
@pytest.mark.asyncio
async def test_ensure_persona_from_session(self, mock_event, mock_context):
"""Test applying persona from session service config."""
module = ama
persona = {"name": "test-persona", "prompt": "You are helpful."}
mock_context.persona_manager.personas_v3 = [persona]
mock_context.persona_manager.resolve_selected_persona = AsyncMock(
return_value=("test-persona", persona, "test-persona", False)
)
mock_event.trace = MagicMock(record=MagicMock())
req = ProviderRequest()
req.conversation = MagicMock(persona_id=None)
await module._ensure_persona_and_skills(req, {}, mock_context, mock_event)
assert "You are helpful." in req.system_prompt
@pytest.mark.asyncio
async def test_ensure_persona_from_conversation(self, mock_event, mock_context):
"""Test applying persona from conversation setting."""
module = ama
persona = {"name": "conv-persona", "prompt": "Custom persona."}
mock_context.persona_manager.personas_v3 = [persona]
mock_context.persona_manager.resolve_selected_persona = AsyncMock(
return_value=("conv-persona", persona, None, False)
)
req = ProviderRequest()
req.conversation = MagicMock(persona_id="conv-persona")
await module._ensure_persona_and_skills(req, {}, mock_context, mock_event)
assert "Custom persona." in req.system_prompt
@pytest.mark.asyncio
async def test_ensure_persona_none_explicit(self, mock_event, mock_context):
"""Test that [%None] persona is explicitly set to no persona."""
module = ama
mock_context.persona_manager.personas_v3 = []
mock_context.persona_manager.resolve_selected_persona = AsyncMock(
return_value=("[%None]", None, None, False)
)
req = ProviderRequest()
req.conversation = MagicMock(persona_id="[%None]")
await module._ensure_persona_and_skills(req, {}, mock_context, mock_event)
assert "Persona Instructions" not in req.system_prompt
@pytest.mark.asyncio
async def test_ensure_tools_from_persona(self, mock_event, mock_context):
"""Test applying tools from persona."""
module = ama
mock_tool = MagicMock()
mock_tool.name = "test_tool"
mock_tool.active = True
persona = {"name": "persona", "prompt": "Test", "tools": ["test_tool"]}
mock_context.persona_manager.personas_v3 = [persona]
mock_context.persona_manager.resolve_selected_persona = AsyncMock(
return_value=("persona", persona, None, False)
)
tmgr = mock_context.get_llm_tool_manager.return_value
tmgr.get_func.return_value = mock_tool
req = ProviderRequest()
req.conversation = MagicMock(persona_id="persona")
await module._ensure_persona_and_skills(req, {}, mock_context, mock_event)
assert req.func_tool is not None
class TestDecorateLlmRequest:
"""Tests for _decorate_llm_request function."""
@pytest.mark.asyncio
async def test_decorate_llm_request_basic(
self, mock_event, mock_context, sample_config
):
"""Test basic LLM request decoration."""
module = ama
req = ProviderRequest(prompt="Hello", system_prompt="System")
await module._decorate_llm_request(mock_event, req, mock_context, sample_config)
assert req.prompt == "Hello"
assert req.system_prompt == "System"
@pytest.mark.asyncio
async def test_decorate_llm_request_with_prefix(self, mock_event, mock_context):
"""Test LLM request decoration with prompt prefix."""
module = ama
req = ProviderRequest(prompt="Hello")
config = module.MainAgentBuildConfig(
tool_call_timeout=60, provider_settings={"prompt_prefix": "AI: "}
)
with patch.object(mock_context, "get_config") as mock_get_config:
mock_get_config.return_value = {}
await module._decorate_llm_request(mock_event, req, mock_context, config)
assert req.prompt == "AI: Hello"
@pytest.mark.asyncio
async def test_decorate_llm_request_prefix_with_placeholder(
self, mock_event, mock_context
):
"""Test prompt prefix with {{prompt}} placeholder."""
module = ama
req = ProviderRequest(prompt="Hello")
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
provider_settings={"prompt_prefix": "AI {{prompt}} - Please respond:"},
)
with patch.object(mock_context, "get_config") as mock_get_config:
mock_get_config.return_value = {}
await module._decorate_llm_request(mock_event, req, mock_context, config)
assert req.prompt == "AI Hello - Please respond:"
@pytest.mark.asyncio
async def test_decorate_llm_request_no_conversation(self, mock_event, mock_context):
"""Test decoration when no conversation exists."""
module = ama
req = ProviderRequest(prompt="Hello")
req.conversation = None
config = module.MainAgentBuildConfig(tool_call_timeout=60)
with patch.object(mock_context, "get_config") as mock_get_config:
mock_get_config.return_value = {}
await module._decorate_llm_request(mock_event, req, mock_context, config)
assert req.prompt == "Hello"
class TestModalitiesFix:
"""Tests for _modalities_fix function."""
def test_modalities_fix_image_not_supported(self, mock_provider):
"""Test modality fix when image is not supported."""
module = ama
mock_provider.provider_config = {"modalities": ["text"]}
req = ProviderRequest(prompt="Hello", image_urls=["/path/to/image.jpg"])
module._modalities_fix(mock_provider, req)
assert "[图片]" in req.prompt
assert req.image_urls == []
def test_modalities_fix_tool_not_supported(self, mock_provider):
"""Test modality fix when tool is not supported."""
module = ama
mock_provider.provider_config = {"modalities": ["text", "image"]}
req = ProviderRequest(prompt="Hello")
req.func_tool = ToolSet()
req.func_tool.add_tool(
FunctionTool(
name="dummy_tool",
description="dummy",
parameters={"type": "object", "properties": {}},
)
)
module._modalities_fix(mock_provider, req)
assert req.func_tool is None
def test_modalities_fix_all_supported(self, mock_provider):
"""Test modality fix when all features are supported."""
module = ama
mock_provider.provider_config = {"modalities": ["image", "tool_use"]}
tool_set = ToolSet()
tool_set.add_tool(
FunctionTool(
name="dummy_tool",
description="dummy",
parameters={"type": "object", "properties": {}},
)
)
req = ProviderRequest(
prompt="Hello",
image_urls=["/path/to/image.jpg"],
func_tool=tool_set,
)
module._modalities_fix(mock_provider, req)
assert req.prompt == "Hello"
assert len(req.image_urls) == 1
assert req.func_tool is not None
class TestSanitizeContextByModalities:
"""Tests for _sanitize_context_by_modalities function."""
def test_sanitize_no_op(self, mock_provider):
"""Test sanitize when disabled or modalities support everything."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60, sanitize_context_by_modalities=False
)
mock_provider.provider_config = {"modalities": ["image", "tool_use"]}
req = ProviderRequest(contexts=[{"role": "user", "content": "Hello"}])
module._sanitize_context_by_modalities(config, mock_provider, req)
assert len(req.contexts) == 1
def test_sanitize_removes_tool_messages(self, mock_provider):
"""Test sanitize removes tool messages when tool_use not supported."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60, sanitize_context_by_modalities=True
)
mock_provider.provider_config = {"modalities": ["image"]}
req = ProviderRequest(
contexts=[
{"role": "user", "content": "Hello"},
{"role": "tool", "content": "Tool result"},
]
)
module._sanitize_context_by_modalities(config, mock_provider, req)
assert len(req.contexts) == 1
assert req.contexts[0]["role"] == "user"
def test_sanitize_removes_tool_calls(self, mock_provider):
"""Test sanitize removes tool_calls from assistant messages."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60, sanitize_context_by_modalities=True
)
mock_provider.provider_config = {"modalities": ["image"]}
req = ProviderRequest(
contexts=[
{
"role": "assistant",
"content": "Response",
"tool_calls": [{"name": "tool"}],
}
]
)
module._sanitize_context_by_modalities(config, mock_provider, req)
assert "tool_calls" not in req.contexts[0]
def test_sanitize_removes_image_blocks(self, mock_provider):
"""Test sanitize removes image blocks when image not supported."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60, sanitize_context_by_modalities=True
)
mock_provider.provider_config = {"modalities": ["tool_use"]}
req = ProviderRequest(
contexts=[
{
"role": "user",
"content": [
{"type": "text", "text": "Hello"},
{"type": "image_url", "url": "image.jpg"},
],
}
]
)
module._sanitize_context_by_modalities(config, mock_provider, req)
assert len(req.contexts[0]["content"]) == 1
assert req.contexts[0]["content"][0]["type"] == "text"
class TestPluginToolFix:
"""Tests for _plugin_tool_fix function."""
def test_plugin_tool_fix_none_plugins(self, mock_event):
"""Test plugin tool fix when no plugins specified."""
module = ama
req = ProviderRequest(func_tool=ToolSet())
mock_event.plugins_name = None
module._plugin_tool_fix(mock_event, req)
assert req.func_tool is not None
def test_plugin_tool_fix_filters_by_plugin(self, mock_event):
"""Test plugin tool fix filters tools by enabled plugins."""
module = ama
mcp_tool = MagicMock(spec=MCPTool)
mcp_tool.name = "mcp_tool"
plugin_tool = MagicMock()
plugin_tool.name = "plugin_tool"
plugin_tool.handler_module_path = "test_plugin"
plugin_tool.active = True
tool_set = ToolSet()
tool_set.add_tool(mcp_tool)
tool_set.add_tool(plugin_tool)
req = ProviderRequest(func_tool=tool_set)
mock_event.plugins_name = ["test_plugin"]
with patch("astrbot.core.astr_main_agent.star_map") as mock_star_map:
mock_plugin = MagicMock()
mock_plugin.name = "test_plugin"
mock_plugin.reserved = False
mock_star_map.get.return_value = mock_plugin
module._plugin_tool_fix(mock_event, req)
assert "mcp_tool" in req.func_tool.names()
assert "plugin_tool" in req.func_tool.names()
def test_plugin_tool_fix_mcp_preserved(self, mock_event):
"""Test that MCP tools are always preserved."""
module = ama
mcp_tool = MagicMock(spec=MCPTool)
mcp_tool.name = "mcp_tool"
mcp_tool.active = True
tool_set = ToolSet()
tool_set.add_tool(mcp_tool)
req = ProviderRequest(func_tool=tool_set)
mock_event.plugins_name = ["other_plugin"]
with patch("astrbot.core.astr_main_agent.star_map"):
module._plugin_tool_fix(mock_event, req)
assert "mcp_tool" in req.func_tool.names()
class TestBuildMainAgent:
"""Tests for build_main_agent function."""
@pytest.mark.asyncio
async def test_build_main_agent_basic(
self, mock_event, mock_context, mock_provider
):
"""Test basic main agent building."""
module = ama
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.return_value = mock_provider
mock_context.get_config.return_value = {}
conv_mgr = mock_context.conversation_manager
_setup_conversation_for_build(conv_mgr)
with (
patch("astrbot.core.astr_main_agent.AgentRunner") as mock_runner_cls,
patch("astrbot.core.astr_main_agent.AstrAgentContext"),
):
mock_runner = MagicMock()
mock_runner.reset = AsyncMock()
mock_runner_cls.return_value = mock_runner
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(tool_call_timeout=60),
)
assert result is not None
assert isinstance(result, module.MainAgentBuildResult)
@pytest.mark.asyncio
async def test_build_main_agent_no_provider(self, mock_event, mock_context):
"""Test building main agent when no provider is available."""
module = ama
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.side_effect = ValueError("No provider")
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(tool_call_timeout=60),
)
assert result is None
@pytest.mark.asyncio
async def test_build_main_agent_with_wake_prefix(
self, mock_event, mock_context, mock_provider
):
"""Test building main agent with wake prefix."""
module = ama
mock_event.message_str = "/command"
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.return_value = mock_provider
mock_context.get_config.return_value = {}
conv_mgr = mock_context.conversation_manager
_setup_conversation_for_build(conv_mgr)
with (
patch("astrbot.core.astr_main_agent.AgentRunner") as mock_runner_cls,
patch("astrbot.core.astr_main_agent.AstrAgentContext"),
):
mock_runner = MagicMock()
mock_runner.reset = AsyncMock()
mock_runner_cls.return_value = mock_runner
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(
tool_call_timeout=60, provider_wake_prefix="/"
),
)
assert result is not None
@pytest.mark.asyncio
async def test_build_main_agent_no_wake_prefix(
self, mock_event, mock_context, mock_provider
):
"""Test building main agent without matching wake prefix."""
module = ama
mock_event.message_str = "hello"
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.return_value = mock_provider
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(
tool_call_timeout=60, provider_wake_prefix="/"
),
)
assert result is None
@pytest.mark.asyncio
async def test_build_main_agent_with_images(
self, mock_event, mock_context, mock_provider
):
"""Test building main agent with image attachments."""
module = ama
mock_image = MagicMock(spec=Image)
mock_image.convert_to_file_path = AsyncMock(return_value="/path/to/image.jpg")
mock_event.message_obj.message = [mock_image]
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.return_value = mock_provider
mock_context.get_config.return_value = {}
conv_mgr = mock_context.conversation_manager
_setup_conversation_for_build(conv_mgr)
with (
patch("astrbot.core.astr_main_agent.AgentRunner") as mock_runner_cls,
patch("astrbot.core.astr_main_agent.AstrAgentContext"),
):
mock_runner = MagicMock()
mock_runner.reset = AsyncMock()
mock_runner_cls.return_value = mock_runner
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(tool_call_timeout=60),
)
assert result is not None
@pytest.mark.asyncio
async def test_build_main_agent_no_prompt_no_images(
self, mock_event, mock_context, mock_provider
):
"""Test building main agent returns None when no prompt or images."""
module = ama
mock_event.message_str = ""
mock_event.message_obj.message = []
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.return_value = mock_provider
mock_context.get_config.return_value = {}
conv_mgr = mock_context.conversation_manager
_setup_conversation_for_build(conv_mgr)
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(tool_call_timeout=60),
)
assert result is None
@pytest.mark.asyncio
async def test_build_main_agent_apply_reset_false(
self, mock_event, mock_context, mock_provider
):
"""Test building main agent without applying reset."""
module = ama
mock_context.get_provider_by_id.return_value = None
mock_context.get_using_provider.return_value = mock_provider
mock_context.get_config.return_value = {}
conv_mgr = mock_context.conversation_manager
_setup_conversation_for_build(conv_mgr)
with (
patch("astrbot.core.astr_main_agent.AgentRunner") as mock_runner_cls,
patch("astrbot.core.astr_main_agent.AstrAgentContext"),
):
mock_runner = MagicMock()
mock_runner.reset = AsyncMock()
mock_runner_cls.return_value = mock_runner
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(tool_call_timeout=60),
apply_reset=False,
)
assert result is not None
assert result.reset_coro is not None
mock_runner.reset.assert_called_once()
result.reset_coro.close()
@pytest.mark.asyncio
async def test_build_main_agent_with_existing_request(
self, mock_event, mock_context, mock_provider
):
"""Test building main agent with existing ProviderRequest."""
module = ama
existing_req = ProviderRequest(prompt="Existing prompt")
mock_event.get_extra.side_effect = lambda k: (
existing_req if k == "provider_request" else None
)
with (
patch("astrbot.core.astr_main_agent.AgentRunner") as mock_runner_cls,
patch("astrbot.core.astr_main_agent.AstrAgentContext"),
):
mock_runner = MagicMock()
mock_runner.reset = AsyncMock()
mock_runner_cls.return_value = mock_runner
result = await module.build_main_agent(
event=mock_event,
plugin_context=mock_context,
config=module.MainAgentBuildConfig(tool_call_timeout=60),
provider=mock_provider,
req=existing_req,
)
assert result is not None
assert result.provider_request == existing_req
class TestHandleWebchat:
"""Tests for _handle_webchat function."""
@pytest.mark.asyncio
async def test_handle_webchat_generates_title(self, mock_event):
"""Test generating title for webchat session without display name."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="What is machine learning?")
prov = MagicMock(spec=Provider)
llm_response = MagicMock()
llm_response.completion_text = "Machine Learning Introduction"
prov.text_chat = AsyncMock(return_value=llm_response)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_db.get_platform_session_by_id.assert_called_once_with(
"webchat-session-123"
)
mock_db.update_platform_session.assert_called_once_with(
session_id="webchat-session-123",
display_name="Machine Learning Introduction",
)
@pytest.mark.asyncio
async def test_handle_webchat_no_user_prompt(self, mock_event):
"""Test that title generation is skipped when no user prompt."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt=None)
prov = MagicMock(spec=Provider)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
await module._handle_webchat(mock_event, req, prov)
prov.text_chat.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_empty_user_prompt(self, mock_event):
"""Test that title generation is skipped when user prompt is empty."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="")
prov = MagicMock(spec=Provider)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
await module._handle_webchat(mock_event, req, prov)
prov.text_chat.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_session_already_has_display_name(self, mock_event):
"""Test that title generation is skipped when session already has display name."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="What is AI?")
prov = MagicMock(spec=Provider)
mock_session = MagicMock()
mock_session.display_name = "Existing Title"
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
await module._handle_webchat(mock_event, req, prov)
prov.text_chat.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_no_session_found(self, mock_event):
"""Test that title generation is skipped when session is not found."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="What is AI?")
prov = MagicMock(spec=Provider)
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=None)
await module._handle_webchat(mock_event, req, prov)
prov.text_chat.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_llm_returns_none_title(self, mock_event):
"""Test that title is not updated when LLM returns <None>."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="hi")
prov = MagicMock(spec=Provider)
llm_response = MagicMock()
llm_response.completion_text = "<None>"
prov.text_chat = AsyncMock(return_value=llm_response)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_db.update_platform_session.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_llm_returns_empty_title(self, mock_event):
"""Test that title is not updated when LLM returns empty string."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="hello")
prov = MagicMock(spec=Provider)
llm_response = MagicMock()
llm_response.completion_text = " "
prov.text_chat = AsyncMock(return_value=llm_response)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_db.update_platform_session.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_llm_returns_none_response(self, mock_event):
"""Test handling when LLM returns None response."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="test question")
prov = MagicMock(spec=Provider)
prov.text_chat = AsyncMock(return_value=None)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_db.update_platform_session.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_llm_returns_no_completion_text(self, mock_event):
"""Test handling when LLM response has no completion_text."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="test question")
prov = MagicMock(spec=Provider)
llm_response = MagicMock()
llm_response.completion_text = None
prov.text_chat = AsyncMock(return_value=llm_response)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_db.update_platform_session.assert_not_called()
@pytest.mark.asyncio
async def test_handle_webchat_strips_title_whitespace(self, mock_event):
"""Test that generated title has whitespace stripped."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="What is Python?")
prov = MagicMock(spec=Provider)
llm_response = MagicMock()
llm_response.completion_text = " Python Programming Guide "
prov.text_chat = AsyncMock(return_value=llm_response)
mock_session = MagicMock()
mock_session.display_name = None
with patch("astrbot.core.db_helper") as mock_db:
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_db.update_platform_session.assert_called_once_with(
session_id="webchat-session-123",
display_name="Python Programming Guide",
)
@pytest.mark.asyncio
async def test_handle_webchat_provider_exception_is_handled(self, mock_event):
"""Test that provider exception during title generation is handled."""
module = ama
mock_event.session_id = "platform!webchat-session-123"
req = ProviderRequest(prompt="What is Python?")
prov = MagicMock(spec=Provider)
prov.text_chat = AsyncMock(side_effect=RuntimeError("provider failed"))
mock_session = MagicMock()
mock_session.display_name = None
with (
patch("astrbot.core.db_helper") as mock_db,
patch("astrbot.core.astr_main_agent.logger") as mock_logger,
):
mock_db.get_platform_session_by_id = AsyncMock(return_value=mock_session)
mock_db.update_platform_session = AsyncMock()
await module._handle_webchat(mock_event, req, prov)
mock_logger.exception.assert_called_once()
mock_db.update_platform_session.assert_not_called()
class TestApplyLlmSafetyMode:
"""Tests for _apply_llm_safety_mode function."""
def test_apply_llm_safety_mode_system_prompt_strategy(self):
"""Test applying safety mode with system_prompt strategy."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
llm_safety_mode=True,
safety_mode_strategy="system_prompt",
)
req = ProviderRequest(prompt="Test", system_prompt="Original prompt")
module._apply_llm_safety_mode(config, req)
assert "You are running in Safe Mode" in req.system_prompt
assert "Original prompt" in req.system_prompt
def test_apply_llm_safety_mode_prepends_safety_prompt(self):
"""Test that safety prompt is prepended before original system prompt."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
safety_mode_strategy="system_prompt",
)
req = ProviderRequest(prompt="Test", system_prompt="My custom prompt")
module._apply_llm_safety_mode(config, req)
assert req.system_prompt.startswith("You are running in Safe Mode")
assert "My custom prompt" in req.system_prompt
def test_apply_llm_safety_mode_with_none_system_prompt(self):
"""Test applying safety mode when original system_prompt is None."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
safety_mode_strategy="system_prompt",
)
req = ProviderRequest(prompt="Test", system_prompt=None)
module._apply_llm_safety_mode(config, req)
assert "You are running in Safe Mode" in req.system_prompt
def test_apply_llm_safety_mode_unsupported_strategy(self):
"""Test that unsupported strategy logs warning and does nothing."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
safety_mode_strategy="unsupported_strategy",
)
req = ProviderRequest(prompt="Test", system_prompt="Original")
with patch("astrbot.core.astr_main_agent.logger") as mock_logger:
module._apply_llm_safety_mode(config, req)
mock_logger.warning.assert_called_once()
assert (
"Unsupported llm_safety_mode strategy"
in mock_logger.warning.call_args[0][0]
)
assert req.system_prompt == "Original"
def test_apply_llm_safety_mode_empty_system_prompt(self):
"""Test applying safety mode when original system_prompt is empty."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
safety_mode_strategy="system_prompt",
)
req = ProviderRequest(prompt="Test", system_prompt="")
module._apply_llm_safety_mode(config, req)
assert "You are running in Safe Mode" in req.system_prompt
class TestApplySandboxTools:
"""Tests for _apply_sandbox_tools function."""
def test_apply_sandbox_tools_creates_toolset_if_none(self):
"""Test that ToolSet is created when func_tool is None."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={},
)
req = ProviderRequest(prompt="Test", func_tool=None)
module._apply_sandbox_tools(config, req, "session-123")
assert req.func_tool is not None
assert isinstance(req.func_tool, ToolSet)
def test_apply_sandbox_tools_adds_required_tools(self):
"""Test that all required sandbox tools are added."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={},
)
req = ProviderRequest(prompt="Test", func_tool=None)
module._apply_sandbox_tools(config, req, "session-123")
tool_names = req.func_tool.names()
assert "astrbot_execute_shell" in tool_names
assert "astrbot_execute_ipython" in tool_names
assert "astrbot_upload_file" in tool_names
assert "astrbot_download_file" in tool_names
def test_apply_sandbox_tools_adds_sandbox_prompt(self):
"""Test that sandbox mode prompt is added to system_prompt."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={},
)
req = ProviderRequest(prompt="Test", system_prompt="Original prompt")
module._apply_sandbox_tools(config, req, "session-123")
assert "sandboxed environment" in req.system_prompt
def test_apply_sandbox_tools_with_shipyard_booter(self, monkeypatch):
"""Test sandbox tools with shipyard booter configuration."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={
"booter": "shipyard",
"shipyard_endpoint": "https://shipyard.example.com",
"shipyard_access_token": "test-token",
},
)
req = ProviderRequest(prompt="Test", func_tool=None)
monkeypatch.delenv("SHIPYARD_ENDPOINT", raising=False)
monkeypatch.delenv("SHIPYARD_ACCESS_TOKEN", raising=False)
module._apply_sandbox_tools(config, req, "session-123")
assert os.environ.get("SHIPYARD_ENDPOINT") == "https://shipyard.example.com"
assert os.environ.get("SHIPYARD_ACCESS_TOKEN") == "test-token"
def test_apply_sandbox_tools_shipyard_missing_endpoint(self):
"""Test that shipyard config is skipped when endpoint is missing."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={
"booter": "shipyard",
"shipyard_endpoint": "",
"shipyard_access_token": "test-token",
},
)
req = ProviderRequest(prompt="Test", func_tool=None)
with patch("astrbot.core.astr_main_agent.logger") as mock_logger:
module._apply_sandbox_tools(config, req, "session-123")
mock_logger.error.assert_called_once()
assert (
"Shipyard sandbox configuration is incomplete"
in mock_logger.error.call_args[0][0]
)
def test_apply_sandbox_tools_shipyard_missing_access_token(self):
"""Test that shipyard config is skipped when access token is missing."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={
"booter": "shipyard",
"shipyard_endpoint": "https://shipyard.example.com",
"shipyard_access_token": "",
},
)
req = ProviderRequest(prompt="Test", func_tool=None)
with patch("astrbot.core.astr_main_agent.logger") as mock_logger:
module._apply_sandbox_tools(config, req, "session-123")
mock_logger.error.assert_called_once()
def test_apply_sandbox_tools_preserves_existing_toolset(self):
"""Test that existing tools are preserved when adding sandbox tools."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={},
)
existing_toolset = ToolSet()
existing_tool = MagicMock()
existing_tool.name = "existing_tool"
existing_toolset.add_tool(existing_tool)
req = ProviderRequest(prompt="Test", func_tool=existing_toolset)
module._apply_sandbox_tools(config, req, "session-123")
assert "existing_tool" in req.func_tool.names()
assert "astrbot_execute_shell" in req.func_tool.names()
def test_apply_sandbox_tools_appends_to_existing_system_prompt(self):
"""Test that sandbox prompt is appended to existing system prompt."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={},
)
req = ProviderRequest(prompt="Test", system_prompt="Base prompt")
module._apply_sandbox_tools(config, req, "session-123")
assert req.system_prompt.startswith("Base prompt")
assert "sandboxed environment" in req.system_prompt
def test_apply_sandbox_tools_with_none_system_prompt(self):
"""Test that sandbox prompt is applied when system_prompt is None."""
module = ama
config = module.MainAgentBuildConfig(
tool_call_timeout=60,
computer_use_runtime="sandbox",
sandbox_cfg={},
)
req = ProviderRequest(prompt="Test", system_prompt=None)
module._apply_sandbox_tools(config, req, "session-123")
assert isinstance(req.system_prompt, str)
assert "sandboxed environment" in req.system_prompt
|