Spaces:

overthelex
/

lmaf

Running

App Files Files Community

Lexai

vovkes222 Claude Opus 4.6 commited on about 6 hours ago

Commit

4b7d391

unverified ·

1 Parent(s): 2114c64

feat(ci): add test suite and run tests in CI before deploy (#7)

Browse files

36 tests covering ConsultationState, Config, and app construction.
CI now runs pytest on ubuntu-latest before deploy-prod and sync-hf.

Co-authored-by: overthelex <mcvovkes@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Files changed (5) hide show

.github/workflows/deploy.yml +19 -0
tests/conftest.py +5 -0
tests/test_app.py +35 -0
tests/test_config.py +66 -0
tests/test_state.py +154 -0

.github/workflows/deploy.yml CHANGED Viewed

@@ -10,8 +10,26 @@ concurrency:
   cancel-in-progress: false
 jobs:
   deploy-prod:
     name: Deploy to prod
     runs-on: [self-hosted, local]
     timeout-minutes: 10
     steps:
@@ -45,6 +63,7 @@ jobs:
   sync-hf:
     name: Sync to HuggingFace Space
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:

   cancel-in-progress: false
 jobs:
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+      - name: Install dependencies
+        run: pip install -r requirements.txt pytest
+      - name: Run tests
+        run: python -m pytest tests/ -v
   deploy-prod:
     name: Deploy to prod
+    needs: test
     runs-on: [self-hosted, local]
     timeout-minutes: 10
     steps:
   sync-hf:
     name: Sync to HuggingFace Space
+    needs: test
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:

tests/conftest.py ADDED Viewed

	@@ -0,0 +1,5 @@

+import sys
+from pathlib import Path
+sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
+sys.path.insert(0, str(Path(__file__).parent.parent))

tests/test_app.py ADDED Viewed

	@@ -0,0 +1,35 @@

+"""Tests for Gradio app construction."""
+from pathlib import Path
+import pytest
+gradio = pytest.importorskip("gradio")
+def test_architecture_html_exists():
+    path = Path(__file__).parent.parent / "architecture.html"
+    assert path.exists(), "architecture.html not found"
+    content = path.read_text()
+    assert "lmaf-arch" in content
+    assert "<script>" in content
+    assert "d3" in content
+def test_architecture_html_is_valid_document():
+    path = Path(__file__).parent.parent / "architecture.html"
+    content = path.read_text()
+    assert content.strip().startswith("<!DOCTYPE html>")
+    assert "</html>" in content
+def test_app_builds():
+    import app
+    demo = app.build_app()
+    assert demo is not None
+def test_app_has_iframe_srcdoc():
+    import app
+    assert "iframe" in app.ARCHITECTURE_HTML
+    assert "srcdoc" in app.ARCHITECTURE_HTML

tests/test_config.py ADDED Viewed

	@@ -0,0 +1,66 @@

+"""Tests for Config."""
+import os
+import tempfile
+from pathlib import Path
+from unittest.mock import patch
+import pytest
+from lmaf.core.config import Config
+class TestConfig:
+    def test_defaults(self):
+        config = Config()
+        assert config.max_iterations == 15
+        assert config.critic_every_n == 3
+        assert config.max_consecutive_failures == 3
+        assert "eu.anthropic" in config.default_model
+    def test_model_for_default(self):
+        config = Config()
+        assert config.model_for("surveyor") == config.default_model
+    def test_model_for_override(self):
+        config = Config(model_overrides={"surveyor": "custom-model"})
+        assert config.model_for("surveyor") == "custom-model"
+        assert config.model_for("planner") == config.default_model
+    def test_from_yaml(self):
+        with tempfile.NamedTemporaryFile(suffix=".yaml", mode="w", delete=False) as f:
+            f.write("max_iterations: 5\ncritic_every_n: 2\n")
+            path = Path(f.name)
+        config = Config.from_yaml(path)
+        assert config.max_iterations == 5
+        assert config.critic_every_n == 2
+        path.unlink()
+    def test_from_yaml_ignores_unknown_fields(self):
+        with tempfile.NamedTemporaryFile(suffix=".yaml", mode="w", delete=False) as f:
+            f.write("max_iterations: 10\nunknown_field: true\n")
+            path = Path(f.name)
+        config = Config.from_yaml(path)
+        assert config.max_iterations == 10
+        path.unlink()
+    def test_from_env(self):
+        env = {
+            "AWS_REGION": "us-east-1",
+            "AWS_ACCESS_KEY_ID": "test-key",
+            "AWS_SECRET_ACCESS_KEY": "test-secret",
+            "SECONDLAYER_API_KEY": "sl-key",
+        }
+        with patch.dict(os.environ, env, clear=False):
+            config = Config.from_env()
+            assert config.aws_region == "us-east-1"
+            assert config.aws_access_key_id == "test-key"
+            assert config.secondlayer_api_key == "sl-key"
+    def test_from_env_defaults(self):
+        with patch.dict(os.environ, {}, clear=True):
+            config = Config.from_env()
+            assert config.aws_region == ""
+            assert config.secondlayer_api_url == "https://legal.org.ua/api"

tests/test_state.py ADDED Viewed

	@@ -0,0 +1,154 @@

+"""Tests for ConsultationState and its data structures."""
+import json
+import tempfile
+from pathlib import Path
+import pytest
+from lmaf.state.research_state import (
+    ConsultationState,
+    Critique,
+    CritiqueStatus,
+    HypothesisStatus,
+    LegalEvidence,
+    LegalHypothesis,
+    LegalStrategy,
+    RQStatus,
+    ResearchQuestion,
+    Severity,
+)
+class TestConsultationState:
+    def test_empty_state(self):
+        state = ConsultationState()
+        assert state.client_question == ""
+        assert state.hypotheses == []
+        assert state.evidence == []
+        assert state.questions == []
+        assert state.critiques == []
+        assert state.iteration == 0
+    def test_add_hypothesis(self):
+        state = ConsultationState()
+        h = state.add_hypothesis("Позовна давність становить 3 роки", iteration=1)
+        assert h.id == "H-001"
+        assert h.status == HypothesisStatus.WORKING
+        assert len(state.hypotheses) == 1
+    def test_add_multiple_hypotheses(self):
+        state = ConsultationState()
+        state.add_hypothesis("First")
+        state.add_hypothesis("Second")
+        state.add_hypothesis("Third")
+        assert len(state.hypotheses) == 3
+        assert state.hypotheses[2].id == "H-003"
+    def test_add_evidence(self):
+        state = ConsultationState()
+        ev = state.add_evidence(
+            type="case_law",
+            source="edrsr",
+            summary="Рішення ВС щодо строків давності",
+            citation="Справа №757/12345/22",
+        )
+        assert ev.id == "EV-001"
+        assert ev.type == "case_law"
+        assert not ev.refuted
+    def test_add_question(self):
+        state = ConsultationState()
+        rq = state.add_question("Чи застосовується ст. 625 ЦК?", iteration=2)
+        assert rq.id == "RQ-001"
+        assert rq.status == RQStatus.OPEN
+    def test_add_critique(self):
+        state = ConsultationState()
+        c = state.add_critique(
+            type="strategy",
+            severity=Severity.HIGH,
+            summary="Не враховано зустрічний позов",
+        )
+        assert c.id == "CR-001"
+        assert c.status == CritiqueStatus.ACTIVE
+    def test_open_questions(self):
+        state = ConsultationState()
+        q1 = state.add_question("Open question")
+        q2 = state.add_question("Resolved question")
+        q2.status = RQStatus.RESOLVED
+        assert len(state.open_questions()) == 1
+        assert state.open_questions()[0].id == q1.id
+    def test_active_critiques(self):
+        state = ConsultationState()
+        c1 = state.add_critique(type="strategy", summary="Active")
+        c2 = state.add_critique(type="reasoning", summary="Resolved")
+        c2.status = CritiqueStatus.RESOLVED
+        assert len(state.active_critiques()) == 1
+        assert state.active_critiques()[0].id == c1.id
+    def test_working_hypotheses(self):
+        state = ConsultationState()
+        h1 = state.add_hypothesis("Working")
+        h2 = state.add_hypothesis("Established")
+        h2.status = HypothesisStatus.ESTABLISHED
+        assert len(state.working_hypotheses()) == 1
+        assert len(state.established_hypotheses()) == 1
+    def test_serialization_roundtrip(self):
+        state = ConsultationState()
+        state.client_question = "Тестове питання"
+        state.jurisdiction = "civil"
+        state.survey_summary = "Огляд правового ландшафту"
+        state.strategy = LegalStrategy(
+            approach="Аналіз строків давності",
+            legal_domains=["цивільне право"],
+            key_questions=["Який строк?"],
+        )
+        state.add_hypothesis("Гіпотеза 1", iteration=1)
+        state.add_evidence(type="legislation", citation="ст. 257 ЦК")
+        state.add_question("Питання 1")
+        state.add_critique(type="completeness", summary="Прогалина")
+        with tempfile.NamedTemporaryFile(suffix=".json", delete=False) as f:
+            path = Path(f.name)
+        state.save(path)
+        loaded = ConsultationState.load(path)
+        assert loaded.client_question == "Тестове питання"
+        assert loaded.jurisdiction == "civil"
+        assert loaded.strategy.approach == "Аналіз строків давності"
+        assert len(loaded.hypotheses) == 1
+        assert len(loaded.evidence) == 1
+        assert len(loaded.questions) == 1
+        assert len(loaded.critiques) == 1
+        path.unlink()
+    def test_to_dict(self):
+        state = ConsultationState()
+        state.client_question = "Test"
+        d = state.to_dict()
+        assert isinstance(d, dict)
+        assert d["client_question"] == "Test"
+class TestLegalEvidence:
+    def test_short(self):
+        ev = LegalEvidence(id="EV-001", citation="ст. 625 ЦК", summary="Пеня за прострочення")
+        assert "EV-001" in ev.short()
+        assert "ст. 625 ЦК" in ev.short()
+    def test_defaults(self):
+        ev = LegalEvidence()
+        assert ev.refuted is False
+        assert ev.iteration is None
+class TestLegalHypothesis:
+    def test_short(self):
+        h = LegalHypothesis(id="H-001", statement="Позов обгрунтований", status=HypothesisStatus.WORKING)
+        assert "H-001" in h.short()
+        assert "working" in h.short()