fix(popup.js): async sidePanel.open, add CRITICAL severity count, show session_id source

extension/popup.js

@@ -1,6 +1,10 @@
 /**
- * ClauseGuard — Popup Script
+ * ClauseGuard — Popup Script v4.3
  * Shows user status (logged in / guest), scan results, usage.
+ *
+ * FIXED v4.3: sidePanel.open() is properly awaited.
+ * FIXED v4.3: CRITICAL severity is now counted and displayed.
+ * FIXED v4.3: Shows scan source ("Legal-BERT" / "Local") accurately.
  */
 
 document.addEventListener("DOMContentLoaded", async () => {
@@ -78,16 +82,17 @@ document.addEventListener("DOMContentLoaded", async () => {
     try { await chrome.tabs.sendMessage(tab.id, { type: "TRIGGER_SCAN" }); } catch {} window.close();
   });
 
-  // Details
+  // FIX v4.3: Properly await async sidePanel.open() so errors are caught
   const btnDetails = document.getElementById("btn-details");
-  if (btnDetails) btnDetails.addEventListener("click", () => {
-    try { chrome.sidePanel.open({ tabId: tab.id }); } catch {} window.close();
+  if (btnDetails) btnDetails.addEventListener("click", async () => {
+    try { await chrome.sidePanel.open({ tabId: tab.id }); } catch(e) { console.warn("sidePanel.open failed:", e); }
+    window.close();
   });
 
   // Login button
   const btnLogin = document.getElementById("btn-login");
   if (btnLogin) btnLogin.addEventListener("click", () => {
-    chrome.tabs.create({ url: "https://clauseguardweb.netlify.app/auth/login" }); // Update with your actual URL
+    chrome.tabs.create({ url: "https://clauseguardweb.netlify.app/auth/login" });
   });
 });
 
@@ -110,15 +115,20 @@ function showResults(results) {
     bar.className = "bar-fill " + (results.risk_score >= 60 ? "bar-red" : results.risk_score >= 30 ? "bar-amber" : "bar-green");
   }
 
-  const counts = { HIGH: 0, MEDIUM: 0, LOW: 0 };
-  (results.results || []).forEach(r => (r.categories || []).forEach(c => { if (counts[c.severity] !== undefined) counts[c.severity]++; }));
-  if (el("c-high")) el("c-high").textContent = counts.HIGH;
+  // FIX v4.3: Count CRITICAL severity too (backend can return it)
+  const counts = { CRITICAL: 0, HIGH: 0, MEDIUM: 0, LOW: 0 };
+  (results.results || []).forEach(r => (r.categories || []).forEach(c => {
+    if (counts[c.severity] !== undefined) counts[c.severity]++;
+    else counts.MEDIUM++; // Unknown severities default to MEDIUM
+  }));
+  // Merge CRITICAL into HIGH for display (popup only has 3 columns)
+  if (el("c-high")) el("c-high").textContent = counts.CRITICAL + counts.HIGH;
   if (el("c-med")) el("c-med").textContent = counts.MEDIUM;
   if (el("c-low")) el("c-low").textContent = counts.LOW;
 
   // Show source indicator
   const src = el("scan-source");
-  if (src) src.textContent = results.source === "api" ? "Legal-BERT" : results.source === "local" ? "Local" : "";
+  if (src) src.textContent = results.source === "api" ? "Legal-BERT" : results.source === "local" ? "Local (offline)" : "";
 }
 
 function updateUsage(usage) {