Update app.py

app.py

@@ -129,34 +129,36 @@ def generate_tutor_output(subject: str, difficulty: str, student_input: str) ->
             if enhanced_topic:
                 break
         
-        # Enhanced prompt with explicit JSON requirement
+        # Strengthened prompt to ensure all sections are generated
         if enhanced_topic:
             logging.debug(f"Using enhanced topic: {enhanced_topic}")
             prompt = f"""
-            You are an expert tutor specializing in {enhanced_topic} at the {difficulty} level. The student has asked about: "{student_input}"
-            Provide your response as a valid JSON object with the following keys and content:
-            - "lesson": A comprehensive lesson (3-4 paragraphs) based on national educational standards, including historical context.
+            You are an expert tutor specializing in {enhanced_topic} at the {difficulty} level. The student has asked: "{student_input}"
+            Generate a detailed response as a valid JSON object with exactly these keys and content:
+            - "lesson": A comprehensive lesson (3-4 paragraphs, at least 200 words) based on national educational standards, including historical context.
             - "example": A detailed step-by-step example problem with a full solution, formatted as:
                 - "Example Problem:" followed by the question
                 - "Step 1:", "Step 2:", etc., each on a new line
                 - "Answer:" with the final solution
-            - "real_world_problem": A challenging real-world application of this concept.
-            - "quiz": A short quiz with 3 multiple-choice questions (e.g., "1. Question text\n   a) option1\n   b) option2\n   c) option3\nCorrect answer: a").
-            Return only the JSON object, enclosed in ```json``` markers, with no additional text outside the markers.
+            - "real_world_problem": A challenging real-world application of this concept (at least 100 words).
+            - "quiz": A short quiz with 3 multiple-choice questions, each formatted as:
+                - "1. Question text\n   a) option1\n   b) option2\n   c) option3\n   Correct answer: a"
+            Ensure all sections are fully populated with relevant content. Return only the JSON object, enclosed in ```json``` markers, with no additional text outside the markers.
             """
         else:
             logging.debug(f"Using general subject: {subject_lower}")
             prompt = f"""
-            You are an expert tutor in {subject_lower} at the {difficulty} level. The student has provided: "{student_input}"
-            Provide your response as a valid JSON object with the following keys and content:
-            - "lesson": A descriptive, engaging lesson (3-4 paragraphs) on the topic.
+            You are an expert tutor in {subject_lower} at the {difficulty} level. The student has asked: "{student_input}"
+            Generate a detailed response as a valid JSON object with exactly these keys and content:
+            - "lesson": A descriptive, engaging lesson (3-4 paragraphs, at least 200 words) on the topic.
             - "example": An example problem with a full solution, formatted as:
                 - "Example Problem:" followed by the question
                 - "Step 1:", "Step 2:", etc., each on a new line
                 - "Answer:" with the final solution
-            - "real_world_problem": A real-world problem solvable using the lesson concepts.
-            - "quiz": A short quiz with 3 multiple-choice questions (e.g., "1. Question text\n   a) option1\n   b) option2\n   c) option3\nCorrect answer: a").
-            Return only the JSON object, enclosed in ```json``` markers, with no additional text outside the markers.
+            - "real_world_problem": A real-world problem solvable using the lesson concepts (at least 100 words).
+            - "quiz": A short quiz with 3 multiple-choice questions, each formatted as:
+                - "1. Question text\n   a) option1\n   b) option2\n   c) option3\n   Correct answer: a"
+            Ensure all sections are fully populated with relevant content. Return only the JSON object, enclosed in ```json``` markers, with no additional text outside the markers.
             """
         
         # Model selection with fallback
@@ -175,7 +177,7 @@ def generate_tutor_output(subject: str, difficulty: str, student_input: str) ->
             messages=[
                 {
                     "role": "system",
-                    "content": f"You are the world's best AI tutor, renowned for your ability to explain complex concepts clearly and engagingly. Your expertise in {subject_lower} is unparalleled, and you tailor your teaching to {difficulty} level students. Always return responses as valid JSON enclosed in ```json``` markers.",
+                    "content": f"You are the world's best AI tutor, renowned for your ability to explain complex concepts clearly and engagingly. Your expertise in {subject_lower} is unparalleled, and you tailor your teaching to {difficulty} level students. Always return a complete response with all requested sections as a valid JSON object enclosed in ```json``` markers.",
                 },
                 {
                     "role": "user",
@@ -183,7 +185,7 @@ def generate_tutor_output(subject: str, difficulty: str, student_input: str) ->
                 }
             ],
             model=target_model,
-            max_tokens=2000,
+            max_tokens=4000,  # Increased to ensure full response
         )
         
         response_content = completion.choices[0].message.content
@@ -203,7 +205,7 @@ def generate_tutor_output(subject: str, difficulty: str, student_input: str) ->
             logging.warning("No JSON markers found in response")
             result = None
         
-        # Fallback parsing if JSON extraction fails
+        # Improved fallback parsing if JSON extraction fails
         if not result:
             logging.debug("Falling back to text parsing")
             sections = {
@@ -218,36 +220,40 @@ def generate_tutor_output(subject: str, difficulty: str, student_input: str) ->
                 line = line.strip()
                 if not line or line.startswith('```'):
                     continue
-                if "Lesson:" in line or line.startswith("1."):
+                # More flexible section detection
+                if any(kw in line.lower() for kw in ["lesson", "1.", "overview", "introduction"]):
                     current_section = "lesson"
                     sections[current_section] += line.replace("Lesson:", "").replace("1.", "").strip() + "\n"
-                elif "Example:" in line or line.startswith("2."):
+                elif any(kw in line.lower() for kw in ["example", "2.", "problem", "solution"]):
                     current_section = "example"
                     sections[current_section] += line.replace("Example:", "").replace("2.", "").strip() + "\n"
-                elif "Real-World Application:" in line or "Real-World Problem:" in line or line.startswith("3."):
+                elif any(kw in line.lower() for kw in ["real-world", "application", "3.", "practical"]):
                     current_section = "real_world_problem"
                     sections[current_section] += line.replace("Real-World Application:", "").replace("Real-World Problem:", "").replace("3.", "").strip() + "\n"
-                elif "Quiz:" in line or line.startswith("4."):
+                elif any(kw in line.lower() for kw in ["quiz", "4.", "question", "test"]):
                     current_section = "quiz"
                     sections[current_section] += line.replace("Quiz:", "").replace("4.", "").strip() + "\n"
                 elif current_section:
                     sections[current_section] += line + "\n"
             
+            # Log parsed sections for debugging
+            logging.debug(f"Parsed sections: {sections}")
+            
             # Check if any section was populated
             if any(sections.values()):
                 result = sections
             else:
                 result = {
-                    "lesson": "Failed to parse lesson content",
-                    "example": "Failed to parse example content",
-                    "real_world_problem": "Failed to parse real-world application content",
-                    "quiz": "Failed to parse quiz content"
+                    "lesson": "Failed to generate lesson content",
+                    "example": "Failed to generate example content",
+                    "real_world_problem": "Failed to generate real-world application content",
+                    "quiz": "Failed to generate quiz content"
                 }
         
-        # Ensure all keys are present
+        # Ensure all keys are present and non-empty
         for key in ["lesson", "example", "real_world_problem", "quiz"]:
-            if key not in result:
-                result[key] = f"No {key.replace('_', ' ')} provided"
+            if key not in result or not result[key].strip():
+                result[key] = f"No {key.replace('_', ' ')} provided - generation incomplete"
         
         return result