Spaces:
Runtime error
Runtime error
File size: 10,107 Bytes
e36381e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 | """Ground-truth check β objective verification beyond reviewer opinion.
When task produces code, run external validators:
- Python: ast.parse (syntax) + optional ruff / mypy / pytest
- TypeScript/JS: tsc / eslint (if available)
- Terraform: terraform validate + tfsec (if available)
- CloudFormation: cfn-lint (if available)
- Shell: bash -n (syntax) + shellcheck (if available)
- JSON/YAML: parse check
Reviewer opinion + ground-truth = double check. Review says pass BUT compile
fails β overrides to fail.
Output: {"verdict": "pass|fail", "checks": [...], "blocking_failure": bool}
"""
from __future__ import annotations
import ast
import json
import re
import shutil
import subprocess
import tempfile
from pathlib import Path
from typing import Optional
CODE_BLOCK_RE = re.compile(r"```(\w+)?\n(.*?)```", re.DOTALL)
def extract_code_blocks(text: str) -> list[tuple[str, str]]:
"""Return list of (language, content) pairs from markdown fenced blocks."""
blocks = []
for m in CODE_BLOCK_RE.finditer(text):
lang = (m.group(1) or "").lower().strip()
content = m.group(2).strip()
if content:
blocks.append((lang, content))
return blocks
def _have(cmd: str) -> bool:
return shutil.which(cmd) is not None
def _run(cmd: list[str], stdin: Optional[str] = None, timeout: int = 30) -> tuple[int, str]:
try:
r = subprocess.run(
cmd, input=stdin, capture_output=True, text=True, timeout=timeout
)
return r.returncode, (r.stdout + r.stderr)[:2000]
except subprocess.TimeoutExpired:
return -1, "timeout"
except OSError as e:
return -1, str(e)
# ----------------------------------------------------------------------
# Per-language checkers
# ----------------------------------------------------------------------
def check_python(code: str) -> list[dict]:
out = []
# 1. syntax
try:
ast.parse(code)
out.append({"tool": "python-syntax", "pass": True, "msg": "syntactically valid"})
except SyntaxError as e:
out.append({"tool": "python-syntax", "pass": False,
"msg": f"SyntaxError: {e}", "blocking": True})
return out # no point in running linters
# 2. ruff (if installed)
if _have("ruff"):
with tempfile.NamedTemporaryFile("w", suffix=".py", delete=False) as f:
f.write(code)
path = f.name
try:
rc, output = _run(["ruff", "check", "--select=E,F", "--output-format=concise", path])
passed = rc == 0
out.append({"tool": "ruff", "pass": passed,
"msg": output[:500] if output else "clean"})
finally:
Path(path).unlink(missing_ok=True)
# 3. mypy (if installed, non-blocking)
if _have("mypy"):
with tempfile.NamedTemporaryFile("w", suffix=".py", delete=False) as f:
f.write(code)
path = f.name
try:
rc, output = _run(["mypy", "--no-error-summary", "--ignore-missing-imports", path])
out.append({"tool": "mypy", "pass": rc == 0, "msg": output[:500]})
finally:
Path(path).unlink(missing_ok=True)
return out
def check_typescript(code: str) -> list[dict]:
out = []
if not _have("npx") and not _have("tsc"):
return [{"tool": "typescript", "pass": True, "msg": "tsc/npx not installed β skipped"}]
with tempfile.NamedTemporaryFile("w", suffix=".ts", delete=False) as f:
f.write(code)
path = f.name
try:
cmd = (["tsc", "--noEmit", "--allowJs", "--target", "ES2022",
"--moduleResolution", "node", path] if _have("tsc")
else ["npx", "-y", "--package=typescript", "--",
"tsc", "--noEmit", "--target", "ES2022", path])
rc, output = _run(cmd, timeout=60)
out.append({"tool": "tsc", "pass": rc == 0,
"msg": output[:600] if output else "clean",
"blocking": rc != 0})
finally:
Path(path).unlink(missing_ok=True)
return out
def check_shell(code: str) -> list[dict]:
out = []
# bash -n (syntax only β no execution). Use file path; stdin parser is lenient.
with tempfile.NamedTemporaryFile("w", suffix=".sh", delete=False) as f:
f.write(code)
path = f.name
try:
rc, output = _run(["bash", "-n", path])
finally:
Path(path).unlink(missing_ok=True)
out.append({"tool": "bash-syntax", "pass": rc == 0, "msg": output or "valid",
"blocking": rc != 0})
if _have("shellcheck"):
with tempfile.NamedTemporaryFile("w", suffix=".sh", delete=False) as f:
f.write(code)
path = f.name
try:
rc, output = _run(["shellcheck", "-f", "gcc", path])
# shellcheck returns nonzero for warnings β non-blocking
out.append({"tool": "shellcheck", "pass": rc == 0, "msg": output[:500]})
finally:
Path(path).unlink(missing_ok=True)
return out
def check_terraform(code: str) -> list[dict]:
out = []
if not _have("terraform"):
return [{"tool": "terraform", "pass": True, "msg": "terraform not installed β skipped"}]
with tempfile.TemporaryDirectory() as d:
Path(d, "main.tf").write_text(code)
rc, output = _run(["terraform", "-chdir=" + d, "init", "-backend=false", "-input=false"], timeout=60)
if rc != 0:
out.append({"tool": "terraform-init", "pass": False, "msg": output[:500],
"blocking": True})
return out
rc, output = _run(["terraform", "-chdir=" + d, "validate"])
out.append({"tool": "terraform-validate", "pass": rc == 0,
"msg": output[:500] if output else "clean",
"blocking": rc != 0})
if _have("tfsec"):
rc, output = _run(["tfsec", d, "--no-color"])
out.append({"tool": "tfsec", "pass": rc == 0, "msg": output[:500]})
return out
def check_cloudformation(code: str) -> list[dict]:
if not _have("cfn-lint"):
return [{"tool": "cfn-lint", "pass": True, "msg": "cfn-lint not installed β skipped"}]
with tempfile.NamedTemporaryFile("w", suffix=".yaml", delete=False) as f:
f.write(code)
path = f.name
try:
rc, output = _run(["cfn-lint", path])
return [{"tool": "cfn-lint", "pass": rc == 0, "msg": output[:500],
"blocking": rc != 0}]
finally:
Path(path).unlink(missing_ok=True)
def check_json(code: str) -> list[dict]:
try:
json.loads(code)
return [{"tool": "json-parse", "pass": True, "msg": "valid JSON"}]
except json.JSONDecodeError as e:
return [{"tool": "json-parse", "pass": False, "msg": str(e), "blocking": True}]
def check_yaml(code: str) -> list[dict]:
try:
import yaml # type: ignore
except ImportError:
return [{"tool": "yaml-parse", "pass": True, "msg": "pyyaml not installed β skipped"}]
try:
yaml.safe_load(code)
return [{"tool": "yaml-parse", "pass": True, "msg": "valid YAML"}]
except yaml.YAMLError as e:
return [{"tool": "yaml-parse", "pass": False, "msg": str(e)[:300], "blocking": True}]
LANG_CHECKERS = {
"python": check_python, "py": check_python,
"typescript": check_typescript, "ts": check_typescript,
"javascript": check_typescript, "js": check_typescript,
"bash": check_shell, "sh": check_shell, "shell": check_shell,
"terraform": check_terraform, "hcl": check_terraform, "tf": check_terraform,
"cloudformation": check_cloudformation, "yaml": check_yaml, "yml": check_yaml,
"json": check_json,
}
# ----------------------------------------------------------------------
# Orchestrator
# ----------------------------------------------------------------------
def check(work_product: str) -> dict:
"""Extract code blocks + run checkers. Returns aggregate verdict.
Returns:
{
"has_code": bool,
"verdict": "pass" | "fail",
"blocking_failure": bool,
"checks": [{tool, pass, msg, blocking?}, ...],
"blocks_checked": int,
}
"""
blocks = extract_code_blocks(work_product)
all_checks: list[dict] = []
has_code = False
for lang, content in blocks:
checker = LANG_CHECKERS.get(lang)
if not checker:
continue
has_code = True
results = checker(content)
for r in results:
r["language"] = lang
all_checks.extend(results)
blocking_failure = any(c.get("blocking") and not c.get("pass") for c in all_checks)
# Only blocking checks determine pass/fail. Non-blocking (warn) tools like
# mypy or shellcheck can fail without sinking the verdict.
blocking_passed = all(c.get("pass") for c in all_checks if c.get("blocking"))
any_blocking = any(c.get("blocking") for c in all_checks)
if not has_code:
return {
"has_code": False,
"verdict": "pass", # nothing to check β don't block review
"blocking_failure": False,
"checks": [],
"blocks_checked": 0,
}
if blocking_failure:
verdict = "fail"
elif not any_blocking:
# no blocking checks ran (e.g. tools missing) β warn
verdict = "warn"
else:
# all blocking checks passed β non-blocking may still complain, but ship it
any_non_blocking_failed = any(
not c.get("pass") and not c.get("blocking") for c in all_checks
)
verdict = "warn" if any_non_blocking_failed else "pass"
return {
"has_code": True,
"verdict": verdict,
"blocking_failure": blocking_failure,
"checks": all_checks,
"blocks_checked": len(blocks),
}
if __name__ == "__main__":
import sys
if len(sys.argv) > 1:
text = Path(sys.argv[1]).read_text()
else:
text = sys.stdin.read()
result = check(text)
print(json.dumps(result, indent=2))
|