Spaces:
Running
Running
File size: 10,188 Bytes
877add7 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 | #!/usr/bin/env python3
"""Acceptance checks for required files, artifacts, and submission readiness."""
from __future__ import annotations
import json
import os
from pathlib import Path
import re
import sys
ROOT = Path(__file__).resolve().parents[1]
if str(ROOT) not in sys.path:
sys.path.insert(0, str(ROOT))
REQUIRED_FILES = [
"openenv.yaml",
"__init__.py",
"client.py",
"models.py",
"server/__init__.py",
"server/app.py",
"app/env/env_core.py",
"app/env/fastapi_app.py",
"app/env/client.py",
"app/agents/orchestrator.py",
"app/training/grpo_trl.py",
"scripts/train_grpo_trl.py",
"scripts/evaluate_policy_ablations.py",
"scripts/merge_adapters_safe.py",
"scripts/test_inference_postsave.py",
"scripts/deploy_space.sh",
"scripts/bootstrap_openenv.sh",
"docs/training.md",
"docs/deployment.md",
"docs/evaluation.md",
"docs/submission_checklist.md",
]
REQUIRED_ARTIFACTS = [
"data/processed/normalized_drugs.parquet",
"data/processed/drug_classes.parquet",
"data/processed/interactions.parquet",
"data/processed/burden_rules.yaml",
"data/processed/taper_rules.yaml",
"data/processed/substitution_rules.yaml",
"data/processed/retrieval_corpus.jsonl",
"data/processed/graph_edges.parquet",
"data/processed/patients_synthetic.parquet",
"data/processed/provenance_manifest.json",
"data/processed/feature_dictionary.json",
"data/scenarios/scenarios_easy.jsonl",
"data/scenarios/scenarios_medium.jsonl",
"data/scenarios/scenarios_hard.jsonl",
"outputs/reports/benchmark_report.json",
"outputs/reports/baselines.json",
]
REQUIRED_SUBMISSION_ENV_VARS = [
"POLYGUARD_SUBMISSION_GITHUB_URL",
"POLYGUARD_SUBMISSION_HF_SPACE_URL",
"POLYGUARD_SUBMISSION_COLAB_URL",
"POLYGUARD_SUBMISSION_VIDEO_OR_BLOG_URL",
]
REQUIRED_README_MARKERS = [
"Problem Statement",
"Environment",
"Capabilities",
"Tasks",
"Reward Model / Evaluation Logic",
"Post-Training Strategy",
"GitHub Repo URL",
"HF Space URL",
"Colab Notebook URL",
"YouTube Video URL",
"Hugging Face Blog URL",
]
PLACEHOLDER_PATTERNS = [
"your-username",
"your-hf-username",
"your-colab-id",
"your-video-id",
"your-polyguard-post",
"https://github.com/...",
"https://huggingface.co/spaces/...",
"https://colab.research.google.com/...",
]
REAL_LINK_MARKERS = {
"github": "https://github.com/",
"hf_space": "https://huggingface.co/spaces/",
"colab": "https://colab.research.google.com/",
"youtube": "https://www.youtube.com/",
"hf_blog": "https://huggingface.co/blog/",
}
ACCEPTED_SFT_BACKENDS = {"trl_unsloth", "trl_transformers"}
ACCEPTED_GRPO_BACKENDS = {"trl_unsloth", "trl_transformers", "trl_grpo", "unsloth_grpo"}
REQUIRED_TRACKED_RESULT_ASSETS = [
"docs/results/avg_reward.png",
"docs/results/policy_stack_avg_reward.png",
]
URL_RE = re.compile(r"https?://[^\s)]+")
def _missing(root: Path, rel_paths: list[str], require_non_empty: bool = False) -> list[str]:
missing: list[str] = []
for rel in rel_paths:
path = root / rel
if not path.exists():
missing.append(rel)
continue
if require_non_empty and path.is_file() and path.stat().st_size == 0:
missing.append(rel)
return missing
def _readme_checks(root: Path) -> dict[str, list[str]]:
readme = root / "README.md"
if not readme.exists():
return {"missing_markers": REQUIRED_README_MARKERS, "missing_links": ["README.md missing"]}
text = readme.read_text(encoding="utf-8")
missing_markers = [marker for marker in REQUIRED_README_MARKERS if marker not in text]
found_links = URL_RE.findall(text)
missing_links = []
if len(found_links) < 4:
missing_links.append("fewer than 4 URLs found in README")
return {
"missing_markers": missing_markers,
"missing_links": missing_links,
}
def _read_json(root: Path, rel: str) -> dict:
path = root / rel
if not path.exists():
return {}
try:
payload = json.loads(path.read_text(encoding="utf-8"))
except json.JSONDecodeError:
return {}
return payload if isinstance(payload, dict) else {}
def _readme_text(root: Path) -> str:
path = root / "README.md"
if not path.exists():
return ""
return path.read_text(encoding="utf-8")
def _readme_placeholder_failures(text: str) -> list[str]:
if any(pattern in text for pattern in PLACEHOLDER_PATTERNS):
return ["README placeholder links present"]
return []
def _readme_has_real_submission_links(text: str) -> bool:
required = ["github", "hf_space", "colab"]
story = "youtube" in REAL_LINK_MARKERS and REAL_LINK_MARKERS["youtube"] in text
story = story or REAL_LINK_MARKERS["hf_blog"] in text
return all(REAL_LINK_MARKERS[key] in text for key in required) and story
def _env_link_checks(strict: bool, readme_text: str = "") -> list[str]:
missing: list[str] = []
readme_has_real_links = _readme_has_real_submission_links(readme_text)
for key in REQUIRED_SUBMISSION_ENV_VARS:
value = os.getenv(key, "").strip()
if strict and not readme_has_real_links:
if not value or not value.startswith("http"):
missing.append(key)
return missing
def _strict_training_checks(root: Path) -> list[str]:
failures: list[str] = []
sft = _read_json(root, "outputs/reports/sft_trl_run.json")
sft_status = str(sft.get("status", ""))
sft_backend = str(sft.get("backend", ""))
sft_artifact = str(sft.get("artifact_path", "") or "")
sft_examples = int(sft.get("examples_used", 0) or 0)
if sft_status != "ok":
failures.append("SFT report status is not ok")
if sft_backend not in ACCEPTED_SFT_BACKENDS:
failures.append("SFT report uses fallback backend")
if not sft_artifact:
failures.append("SFT artifact path is empty or missing")
if sft_examples <= 0:
failures.append("SFT report has no training examples")
grpo = _read_json(root, "outputs/reports/grpo_trl_run.json")
grpo_status = str(grpo.get("status", ""))
grpo_backend = str(grpo.get("backend", ""))
grpo_artifact = str(grpo.get("artifact_path", "") or "")
if grpo_status != "ok":
failures.append("GRPO report status is not ok")
if grpo_backend not in ACCEPTED_GRPO_BACKENDS:
failures.append("GRPO report uses fallback backend")
if not grpo_artifact:
failures.append("GRPO artifact path is empty or missing")
postsave = _read_json(root, "outputs/reports/postsave_inference.json")
if str(postsave.get("model_source", "")) == "fallback_policy":
failures.append("post-save inference uses fallback policy")
if postsave.get("model_load_error"):
failures.append("post-save inference has model load error")
improvement = _read_json(root, "outputs/reports/improvement_report.json")
if improvement.get("improved") is not True:
failures.append("improvement report is not positive")
return failures
def _strict_asset_checks(root: Path) -> list[str]:
failures: list[str] = []
missing_assets = _missing(root, REQUIRED_TRACKED_RESULT_ASSETS, require_non_empty=True)
if missing_assets:
failures.append("tracked result assets missing")
hf_verify = _read_json(root, "docs/results/hf_space_verification.json")
if hf_verify.get("passed") is not True:
failures.append("HF deployment verification missing")
return failures
def _strict_submission_checks(root: Path, readme_text: str) -> list[str]:
failures: list[str] = []
failures.extend(_readme_placeholder_failures(readme_text))
if not _readme_has_real_submission_links(readme_text):
failures.append("README real submission links missing")
failures.extend(_strict_training_checks(root))
failures.extend(_strict_asset_checks(root))
return list(dict.fromkeys(failures))
def run_checks(root: Path = ROOT, strict_submission_links: bool = False) -> dict[str, object]:
missing_files = _missing(root, REQUIRED_FILES)
missing_artifacts = _missing(root, REQUIRED_ARTIFACTS, require_non_empty=True)
readme_check = _readme_checks(root)
readme_text = _readme_text(root)
missing_submission_env = _env_link_checks(strict=strict_submission_links, readme_text=readme_text)
strict_submission_failures = (
_strict_submission_checks(root, readme_text=readme_text) if strict_submission_links else []
)
summary: dict[str, object] = {
"missing_files": missing_files,
"missing_artifacts": missing_artifacts,
"missing_readme_markers": readme_check["missing_markers"],
"missing_readme_links": readme_check["missing_links"],
"strict_submission_links": strict_submission_links,
"missing_submission_env": missing_submission_env,
"strict_submission_failures": strict_submission_failures,
"submission_ready": False,
"status": "ok",
}
has_failures = bool(
missing_files
or missing_artifacts
or readme_check["missing_markers"]
or readme_check["missing_links"]
or missing_submission_env
or strict_submission_failures
)
summary["submission_ready"] = strict_submission_links and not has_failures
if has_failures:
summary["status"] = "fail"
return summary
def main() -> None:
root = Path(__file__).resolve().parents[1]
strict_submission_links = os.getenv("POLYGUARD_ENFORCE_SUBMISSION_LINKS", "false").lower() in {
"1",
"true",
"yes",
"on",
}
summary = run_checks(root=root, strict_submission_links=strict_submission_links)
out = root / "outputs" / "reports" / "acceptance_gate.json"
out.parent.mkdir(parents=True, exist_ok=True)
out.write_text(json.dumps(summary, ensure_ascii=True, indent=2), encoding="utf-8")
if summary["status"] == "fail":
raise SystemExit(f"acceptance_gate_failed: {summary}")
print("acceptance_gate_ok")
if __name__ == "__main__":
main()
|