fix: fallback model upload storage when /data is unavailable

app/main.py

@@ -447,23 +447,40 @@ def _phase_model_dirs() -> list[Path]:
                 p = (REPO_ROOT / p).resolve()
             configured.append(p)
 
-    data_root_raw = (os.getenv("OPENENV_DATA_DIR") or "/data/openenv_rl").strip()
-    data_root = Path(data_root_raw)
-    if not data_root.is_absolute():
+    data_root_raw = (os.getenv("OPENENV_DATA_DIR") or "").strip()
+    data_root = Path(data_root_raw) if data_root_raw else None
+    if data_root is not None and not data_root.is_absolute():
         data_root = (REPO_ROOT / data_root).resolve()
 
+    persistence_root = getattr(persistence, "data_dir", None)
+    if isinstance(persistence_root, Path):
+        persistence_root = persistence_root.resolve()
+
     repo_base = REPO_ROOT / "results" / "best_model"
-    data_base = data_root / "results" / "best_model"
 
     candidates = [
         *configured,
-        data_base / "phase1",
-        data_base / "phase2",
-        data_root / "best_model" / "phase1",
-        data_root / "best_model" / "phase2",
         repo_base / "phase1",
         repo_base / "phase2",
     ]
+    if data_root is not None:
+        candidates.extend(
+            [
+                data_root / "results" / "best_model" / "phase1",
+                data_root / "results" / "best_model" / "phase2",
+                data_root / "best_model" / "phase1",
+                data_root / "best_model" / "phase2",
+            ]
+        )
+    if persistence_root is not None:
+        candidates.extend(
+            [
+                persistence_root / "results" / "best_model" / "phase1",
+                persistence_root / "results" / "best_model" / "phase2",
+                persistence_root / "best_model" / "phase1",
+                persistence_root / "best_model" / "phase2",
+            ]
+        )
 
     # Preserve order, remove duplicates.
     deduped: list[Path] = []
@@ -490,11 +507,45 @@ def _discover_phase12_zip_models() -> list[Path]:
 
 
 def _model_storage_base_dir() -> Path:
-    data_root_raw = (os.getenv("OPENENV_DATA_DIR") or "/data/openenv_rl").strip()
-    data_root = Path(data_root_raw)
-    if not data_root.is_absolute():
-        data_root = (REPO_ROOT / data_root).resolve()
-    return data_root / "results" / "best_model"
+    candidate_roots: list[Path] = []
+
+    configured_root = (os.getenv("OPENENV_DATA_DIR") or "").strip()
+    if configured_root:
+        p = Path(configured_root)
+        if not p.is_absolute():
+            p = (REPO_ROOT / p).resolve()
+        candidate_roots.append(p)
+
+    persistence_root = getattr(persistence, "data_dir", None)
+    if isinstance(persistence_root, Path):
+        candidate_roots.append(persistence_root.resolve())
+
+    candidate_roots.extend(
+        [
+            (REPO_ROOT / "outputs" / "persist").resolve(),
+            Path("/tmp/openenv_rl").resolve(),
+        ]
+    )
+
+    seen: set[str] = set()
+    unique_roots: list[Path] = []
+    for root in candidate_roots:
+        key = str(root)
+        if key in seen:
+            continue
+        seen.add(key)
+        unique_roots.append(root)
+
+    last_exc: Exception | None = None
+    for root in unique_roots:
+        try:
+            base_dir = root / "results" / "best_model"
+            base_dir.mkdir(parents=True, exist_ok=True)
+            return base_dir
+        except OSError as exc:
+            last_exc = exc
+            continue
+    raise RuntimeError(f"No writable model storage directory found. last_error={last_exc!r}")
 
 
 def _phase_from_model_path(path: Path) -> int:
@@ -2009,9 +2060,21 @@ async def api_rl_model_upload(
         )
 
     safe_name = Path(name).name
-    base_dir = _model_storage_base_dir()
+    try:
+        base_dir = _model_storage_base_dir()
+    except RuntimeError as exc:
+        raise HTTPException(
+            status_code=status.HTTP_503_SERVICE_UNAVAILABLE,
+            detail=str(exc),
+        ) from exc
     target_dir = base_dir / f"phase{phase}"
-    target_dir.mkdir(parents=True, exist_ok=True)
+    try:
+        target_dir.mkdir(parents=True, exist_ok=True)
+    except OSError as exc:
+        raise HTTPException(
+            status_code=status.HTTP_503_SERVICE_UNAVAILABLE,
+            detail=f"Failed to initialize upload directory: {exc}",
+        ) from exc
     target_path = target_dir / safe_name
 
     total = 0