Bổ sung phân chia/quản lý session cho UI

app.py

@@ -7,6 +7,7 @@ import asyncio
 from typing import Dict, List, Any, Optional, Callable
 from dataclasses import dataclass, field
 import os
+import uuid
 
 
 API_BASE_URL = "https://sale-agent-m179.onrender.com"
@@ -15,6 +16,7 @@ API_BASE_URL = "https://sale-agent-m179.onrender.com"
 @dataclass
 class ConversationState:
     """Data class to hold conversation state"""
+    session_id: Optional[str] = None
     specs_advantages: Dict[str, Any] = field(default_factory=dict)
     solution_packages: List[str] = field(default_factory=list)
     raw_documents: Optional[Dict[str, Any]] = None
@@ -24,6 +26,7 @@ class ConversationState:
     
     def reset(self):
         """Reset state to initial values"""
+        self.session_id = None
         self.specs_advantages = {}
         self.solution_packages = []
         self.raw_documents = None
@@ -33,34 +36,58 @@ class ConversationState:
 
 
 class StateManager:
-    """Manages conversation state operations"""
+    """Manages conversation state operations with per-session isolation"""
+    
+    # CLASS-LEVEL session storage for isolation between different browser sessions
+    _session_states: Dict[str, ConversationState] = {}
+    
+    @staticmethod
+    def get_or_create_session_state(session_id: str) -> ConversationState:
+        """Get existing session state or create new one"""
+        if session_id not in StateManager._session_states:
+            state = ConversationState()
+            state.session_id = session_id
+            StateManager._session_states[session_id] = state
+            print(f"🆕 Created new session state for: {session_id}")
+        else:
+            print(f"🔄 Retrieved existing session state for: {session_id}")
+        
+        return StateManager._session_states[session_id]
     
     @staticmethod
-    def create_initial_state() -> ConversationState:
-        """Create initial conversation state"""
-        return ConversationState()
+    def cleanup_session(session_id: str):
+        """Clean up session state when user disconnects"""
+        if session_id in StateManager._session_states:
+            del StateManager._session_states[session_id]
+            print(f"🗑️ Cleaned up session state for: {session_id}")
     
     @staticmethod
     async def clear_chat_state(state: ConversationState):
         """Clear all conversation history and reset state via API"""
-        try:
-            requests.post(f"{API_BASE_URL}/clear_memory",
-                          json={"reset_cache": True, "reset_model": False})
-        except Exception as e:
-            print(f"Warning: clear_memory failed: {e}")
+        if state.session_id is not None and API_BASE_URL:
+            try:
+                requests.post(f"{API_BASE_URL}/clear_memory",
+                              json={"reset_cache": True, "reset_model": False, "session_id": state.session_id})
+            except Exception as e:
+                print(f"Warning: clear_memory failed: {e}")
         
-        # Reset state
+        # Reset state but keep session_id
+        session_id = state.session_id
         state.reset()
+        state.session_id = session_id
     
     @staticmethod
     def change_model(state: ConversationState, model_name: str):
         """Change the selected model"""
-        try:
-            requests.post(f"{API_BASE_URL}/set_model",
-                          json={"model_name": model_name})
+        if API_BASE_URL:
+            try:
+                requests.post(f"{API_BASE_URL}/set_model",
+                              json={"model_name": model_name})
+                state.selected_model = model_name
+            except Exception as e:
+                print(f"Warning: set_model failed: {e}")
+        else:
             state.selected_model = model_name
-        except Exception as e:
-            print(f"Warning: set_model failed: {e}")
     
     @staticmethod
     def toggle_product_model_search(state: ConversationState):
@@ -78,9 +105,15 @@ class ChatService:
         image_path: Optional[str] = None
     ) -> str:
         """Handle chat responses with image support"""
-        print(f"🔄 === DEBUG STATE ===\n Chat request with model: {state.selected_model}, Product Model Search: {state.product_model_search}")
+        print(f"🔄 === DEBUG STATE ===\n Chat request with model: {state.selected_model}, Product Model Search: {state.product_model_search}, Session ID: {state.session_id}")
         start = time.perf_counter()
         
+        if not API_BASE_URL:
+            return "Error: API_BASE_URL not configured"
+        
+        if not state.session_id:
+            return "Error: Session ID not initialized"
+        
         # Call API
         try:
             if image_path:
@@ -88,13 +121,15 @@ class ChatService:
                     files = {"image": f}
                     data = {
                         "message": message,
-                        "product_model_search": str(state.product_model_search).lower()
+                        "product_model_search": str(state.product_model_search).lower(),
+                        "session_id": state.session_id
                     }
                     resp = requests.post(
                         f"{API_BASE_URL}/chat_with_image", files=files, data=data, timeout=120)
             else:
                 payload = {
                     "message": message,
+                    "session_id": state.session_id,
                     "debug": "Normal",
                     "product_model_search": state.product_model_search
                 }
@@ -123,7 +158,7 @@ class ChatService:
         state.raw_documents = raw_documents
         state.outputs = outputs
 
-        # Filter products based on query - FIX: Call static method correctly
+        # Filter products based on query
         if state.specs_advantages is not None:
             ChatService.get_specific_product_from_query(message, state)
 
@@ -154,6 +189,7 @@ class ChatService:
         
             state.specs_advantages = new_specs_advantages
 
+
 class DisplayService:
     """Handles display-related operations"""
     
@@ -310,7 +346,6 @@ class UIService:
     @staticmethod
     def create_action_buttons(state: ConversationState):
         """Create persistent action buttons"""
-        # Determine the product search button text and icon
         search_status = "🔍 Tìm theo mã sản phẩm (Đang tắt)" if not state.product_model_search else "🔍 Tìm theo mã sản phẩm (Đang bật)"
         
         return [
@@ -360,16 +395,57 @@ class UIService:
         return msg
 
 
-# Application state - using dependency injection pattern
-app_state = StateManager.create_initial_state()
+# HELPER FUNCTIONS: Session management with proper error handling
+def ensure_session_state() -> Optional[ConversationState]:
+    """Ensure session state exists, create if not"""
+    try:
+        session_id = cl.user_session.get("session_id")
+        
+        if not session_id:
+            # Tạo session ID mới nếu không có
+            session_id = str(uuid.uuid4())
+            cl.user_session.set("session_id", session_id)
+            print(f"🔄 Created fallback session ID: {session_id}")
+        
+        return StateManager.get_or_create_session_state(session_id)
+        
+    except Exception as e:
+        print(f"⚠️ Error ensuring session state: {e}")
+        return None
+
+
+def get_current_session_state() -> Optional[ConversationState]:
+    """Get current session state using Chainlit's session system"""
+    try:
+        # Use Chainlit's user session to get unique session ID
+        chainlit_session_id = cl.user_session.get("session_id")  # Fixed: added key parameter
+        
+        if chainlit_session_id:
+            return StateManager.get_or_create_session_state(chainlit_session_id)
+        else:
+            print("⚠️ No Chainlit session ID found")
+            return None
+    except Exception as e:
+        print(f"⚠️ Error getting session state: {e}")
+        return None
 
 
 @cl.on_chat_start
 async def on_chat_start():
     """Initialize the chat session"""
-    await StateManager.clear_chat_state(app_state)
+    # Generate unique session ID for this browser tab/session
+    session_id = str(uuid.uuid4())
+    
+    # Store session ID in Chainlit's user session
+    cl.user_session.set("session_id", session_id)
+    
+    # Get or create session state
+    app_state = StateManager.get_or_create_session_state(session_id)
+    
+    # await StateManager.clear_chat_state(app_state)
+    
     await cl.Message(
-        content="🛍️ **RangDong Sales Agent**\n\nXin chào! Tôi có thể giúp bạn tìm kiếm và tư vấn sản phẩm RangDong. Hãy thử các câu hỏi mẫu:\n\n- Tìm sản phẩm bình giữ nhiệt dung tích dưới 2 lít\n- Tìm sản phẩm ổ cắm thông minh\n- Tư vấn cho tôi đèn học chống cận cho con gái của tôi học lớp 6",
+        content=f"🛍️ **RangDong Sales Agent** (Session: {session_id[:8]}...)\n\nXin chào! Tôi có thể giúp bạn tìm kiếm và tư vấn sản phẩm RangDong. Hãy thử các câu hỏi mẫu:\n\n- Tìm sản phẩm bình giữ nhiệt dung tích dưới 2 lít\n- Tìm sản phẩm ổ cắm thông minh\n- Tư vấn cho tôi đèn học chống cận cho con gái của tôi học lớp 6",
         author="assistant"
     ).send()
     
@@ -382,9 +458,33 @@ async def on_chat_start():
     ).send()
 
 
+@cl.on_chat_end
+async def on_chat_end():
+    """Clean up when chat session ends"""
+    try:
+        # Fixed: get session_id with specific key
+        session_id = cl.user_session.get("session_id")
+        
+        if session_id:
+            # Get or create session state
+            app_state = StateManager.get_or_create_session_state(session_id)
+            await StateManager.clear_chat_state(app_state)
+            StateManager.cleanup_session(session_id)
+
+    except Exception as e:
+        print(f"⚠️ Error during cleanup: {e}")
+    
+
+
+# ACTION CALLBACKS - All use ensure_session_state() for better reliability
 @cl.action_callback("show_specs")
 async def on_show_specs(action):
     """Handle show specifications action"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     specs_content = DisplayService.show_specs(app_state)
     await UIService.send_message_with_buttons(specs_content, app_state, author="assistant")
 
@@ -392,6 +492,11 @@ async def on_show_specs(action):
 @cl.action_callback("show_advantages")
 async def on_show_advantages(action):
     """Handle show advantages action"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     adv_content = DisplayService.show_advantages(app_state)
     await UIService.send_message_with_buttons(adv_content, app_state, author="assistant")
 
@@ -399,6 +504,11 @@ async def on_show_advantages(action):
 @cl.action_callback("show_packages")
 async def on_show_packages(action):
     """Handle show packages action"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     pkg_content = DisplayService.show_solution_packages(app_state)
     await UIService.send_message_with_buttons(pkg_content, app_state, author="assistant")
 
@@ -406,6 +516,11 @@ async def on_show_packages(action):
 @cl.action_callback("toggle_product_search")
 async def on_toggle_product_search(action):
     """Handle toggle product model search action"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     StateManager.toggle_product_model_search(app_state)
     
     status_message = (
@@ -422,15 +537,18 @@ async def on_toggle_product_search(action):
 @cl.action_callback("change_model")
 async def on_change_model(action):
     """Handle model change action"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     models = ["Gemini 2.0 Flash", "Gemini 2.5 Flash Lite", "Gemini 2.0 Flash Lite"]
     
-    # Create model selection actions
     model_actions = [
         cl.Action(name=f"select_model_{i}", value=model, label=model, payload={"model": model})
         for i, model in enumerate(models)
     ]
     
-    # Add back button to return to main actions
     model_actions.append(
         cl.Action(name="back_to_main", value="back", label="🔙 Quay lại", payload={"action": "back"})
     )
@@ -445,6 +563,11 @@ async def on_change_model(action):
 @cl.action_callback("back_to_main")
 async def on_back_to_main(action):
     """Handle back to main menu action"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     actions = UIService.create_action_buttons(app_state)
     await cl.Message(
         content="📋 **Menu chính**\n\nSử dụng các nút bên dưới để:", 
@@ -455,18 +578,33 @@ async def on_back_to_main(action):
 
 @cl.action_callback("select_model_0")
 async def on_select_model_0(action):
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     StateManager.change_model(app_state, "Gemini 2.0 Flash")
     await UIService.send_message_with_buttons("✅ Đã chuyển sang **Gemini 2.0 Flash**", app_state, author="assistant")
 
 
 @cl.action_callback("select_model_1")
 async def on_select_model_1(action):
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     StateManager.change_model(app_state, "Gemini 2.5 Flash Lite")
     await UIService.send_message_with_buttons("✅ Đã chuyển sang **Gemini 2.5 Flash Lite**", app_state, author="assistant")
 
 
 @cl.action_callback("select_model_2")
 async def on_select_model_2(action):
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+        
     StateManager.change_model(app_state, "Gemini 2.0 Flash Lite")
     await UIService.send_message_with_buttons("✅ Đã chuyển sang **Gemini 2.0 Flash Lite**", app_state, author="assistant")
 
@@ -474,6 +612,11 @@ async def on_select_model_2(action):
 @cl.on_message
 async def main(message: cl.Message):
     """Main message handler"""
+    app_state = ensure_session_state()
+    if app_state is None:
+        await cl.Message(content="Error: Session state not found", author="assistant").send()
+        return
+    
     # Handle images if present
     image_path = None
     if message.elements:
@@ -485,11 +628,11 @@ async def main(message: cl.Message):
     # Show typing animation
     typing_msg = await UIService.create_typing_animation()
     
-    # Get response from API - injecting state as dependency
+    # Get response from API
     response = await ChatService.respond_to_chat(app_state, message.content, image_path)
     
     # Update the typing message with final response and buttons
     typing_msg.content = response
     typing_msg.actions = UIService.create_action_buttons(app_state)
-    typing_msg.author = "assistant"  # Ensure author is set
+    typing_msg.author = "assistant"
     await typing_msg.update()