Fix 1: profiler.py — remove silent fallback, loud warning when onnx_tool missing

neurogolf_solver/profiler.py

@@ -1,5 +1,11 @@
 #!/usr/bin/env python3
-"""Static profiling for ONNX models."""
+"""Static profiling for ONNX models.
+
+Uses neurogolf_utils.score_network() (onnx_tool) when available — this is
+the ONLY scoring that matches Kaggle. The static fallback is approximate
+and prints a WARNING. If onnx_tool returns (None, None, None), the model
+is REJECTED — do not submit it.
+"""
 
 import onnx
 from onnx import numpy_helper
@@ -11,19 +17,36 @@ try:
 except ImportError:
     HAS_ONNX_TOOL = False
 
+_WARNED_NO_ONNX_TOOL = False
+
 
 def score_network(path):
-    """Score network using official tool or fallback."""
+    """Score network. Returns (macs, memory, params) or (None, None, None).
+    
+    If onnx_tool is available: uses official scorer. (None,None,None) = REJECTED.
+    If onnx_tool is NOT available: uses static fallback with WARNING.
+    """
+    global _WARNED_NO_ONNX_TOOL
     if HAS_ONNX_TOOL:
+        # Official scorer — trust its result. Do NOT catch exceptions silently.
         try:
-            return _score_network_official(path)
-        except:
-            pass
-    return _static_profile(path)
+            result = _score_network_official(path)
+        except Exception as e:
+            print(f"WARNING: onnx_tool score_network failed on {path}: {e}")
+            return None, None, None
+        return result
+    else:
+        if not _WARNED_NO_ONNX_TOOL:
+            print("WARNING: onnx_tool not installed. Scores are APPROXIMATE and may not match Kaggle.")
+            print("WARNING: Models that fail onnx_tool profiling will be REJECTED on Kaggle.")
+            print("WARNING: Run neurogolf_utils.verify_network() in a Kaggle notebook before submitting.")
+            _WARNED_NO_ONNX_TOOL = True
+        return _static_profile(path)
 
 
 def _static_profile(path):
-    """Static profiling fallback."""
+    """Static profiling fallback. APPROXIMATE — does not match Kaggle scoring.
+    Only used when onnx_tool is not installed."""
     try:
         model = onnx.load(path)
     except:
@@ -49,7 +72,9 @@ def _static_profile(path):
                         nbytes += a.nbytes
                     except:
                         pass
-        if nd.op_type in BANNED_OPS:
+        # Banned op check — UPPERCASE to match Kaggle
+        if nd.op_type.upper() in {op.upper() for op in BANNED_OPS}:
+            print(f"WARNING: Banned op '{nd.op_type}' found in {path}")
             return None, None, None
         if nd.op_type == 'Conv' and len(nd.input) >= 2 and nd.input[1] in tensors:
             w = tensors[nd.input[1]]