Fix: --strict_score default False (warnings only), --strict_size default True (halt on oversized)

neurogolf_solver/main.py

@@ -27,8 +27,10 @@ except ImportError:
 
 def check_all_models(output_dir, strict_size, strict_score):
     """Check all .onnx files for size limit and scoreability.
-    If strict and any fail, exit immediately."""
-    problems = []
+    strict_size=True → halt on oversized files.
+    strict_score=False → warn on unscorable but don't halt."""
+    size_problems = []
+    score_problems = []
     for f in sorted(os.listdir(output_dir)):
         if not f.endswith('.onnx'):
             continue
@@ -36,25 +38,31 @@ def check_all_models(output_dir, strict_size, strict_score):
         fsize = os.path.getsize(fpath)
 
         if fsize > MAX_ONNX_FILESIZE:
-            problems.append((f, f"OVERSIZED: {fsize:,} bytes ({fsize/1024:.1f} KB) > {MAX_ONNX_FILESIZE:,}"))
+            size_problems.append((f, fsize))
 
         macs, memory, params = score_network(fpath)
         if macs is None or memory is None or params is None:
-            problems.append((f, "UNSCORABLE: score_network returned (None, None, None) — Kaggle will reject"))
+            score_problems.append(f)
 
-    if problems:
+    if size_problems:
         print(f"\n{'!'*70}")
-        print(f"PROBLEMS FOUND: {len(problems)} .onnx files will be REJECTED by Kaggle:")
-        for f, msg in problems:
-            print(f"  {f}: {msg}")
+        print(f"FATAL: {len(size_problems)} .onnx files exceed 1.44MB limit:")
+        for f, sz in size_problems:
+            print(f"  {f}: {sz:,} bytes ({sz/1024:.1f} KB)")
         print(f"{'!'*70}")
-        if strict_size or strict_score:
-            print("Stopping. Fix these models before submitting.")
+        if strict_size:
             sys.exit(1)
-    else:
-        print(f"\nAll .onnx files pass size and score checks.")
 
-    return problems
+    if score_problems:
+        print(f"\nWARNING: {len(score_problems)} .onnx files unscorable by onnx_tool:")
+        for f in score_problems:
+            print(f"  {f}")
+        if strict_score:
+            print("Stopping (--strict_score is on).")
+            sys.exit(1)
+
+    if not size_problems and not score_problems:
+        print(f"\nAll .onnx files pass size and score checks.")
 
 
 def main():
@@ -67,8 +75,8 @@ def main():
     parser.add_argument('--tasks', type=str, default='', help='Comma-separated task numbers')
     parser.add_argument('--device', type=str, default='auto', choices=['auto', 'cpu', 'cuda'])
     parser.add_argument('--use_wandb', action='store_true', help='Enable W&B logging')
-    parser.add_argument('--strict_size', type=bool, default=True, help='Stop if any .onnx > 1.44MB (default: True)')
-    parser.add_argument('--strict_score', type=bool, default=True, help='Stop if any model unscorable (default: True)')
+    parser.add_argument('--strict_size', type=bool, default=True, help='Halt if any .onnx > 1.44MB (default: True)')
+    parser.add_argument('--strict_score', type=bool, default=False, help='Halt if any model unscorable (default: False)')
     args = parser.parse_args()
 
     providers = get_providers(args.device)