Upload alpha_factory/infra/factor_store.py with huggingface_hub

alpha_factory/infra/factor_store.py

@@ -1,5 +1,5 @@
 """
-Factor Store — DuckDB + Parquet persistence for all alphas.
+Factor Store — DuckDB persistence for all alphas.
 Single source of truth for every alpha ever submitted.
 """
 import duckdb
@@ -80,6 +80,8 @@ class FactorStore:
         iteration: int = 1,
     ):
         """Insert a new alpha candidate (before BRAIN results arrive)."""
+        # NOTE: All SQL uses parameterized queries (? placeholders) to prevent injection.
+        # The expression field is user-controlled (from LLM output) but is passed as a param.
         self.conn.execute("""
             INSERT OR REPLACE INTO alphas (alpha_id, expression, neutralization, decay,
                 fields_used, operators_used, archetype, theme, anomaly_tag,
@@ -91,17 +93,24 @@ class FactorStore:
 
     def update_metrics(self, alpha_id: str, metrics: BrainMetrics, fitness_score: float):
         """Update alpha with BRAIN simulation results."""
-        self.conn.execute("""
-            UPDATE alphas SET
-                sharpe_full = ?, sharpe_is = ?, sharpe_os = ?,
-                fitness_brain = ?, turnover = ?, returns_total = ?,
-                max_drawdown = ?, yearly_sharpe = ?, yearly_returns = ?,
-                margin_pct = ?, fitness_score = ?
-            WHERE alpha_id = ?
-        """, [metrics.sharpe_full, metrics.sharpe_is, metrics.sharpe_os,
-              metrics.fitness, metrics.turnover, metrics.returns,
-              metrics.max_drawdown, metrics.yearly_sharpe, metrics.yearly_returns,
-              metrics.margin_pct, fitness_score, alpha_id])
+        # Wrap in transaction for atomicity
+        self.conn.execute("BEGIN TRANSACTION")
+        try:
+            self.conn.execute("""
+                UPDATE alphas SET
+                    sharpe_full = ?, sharpe_is = ?, sharpe_os = ?,
+                    fitness_brain = ?, turnover = ?, returns_total = ?,
+                    max_drawdown = ?, yearly_sharpe = ?, yearly_returns = ?,
+                    margin_pct = ?, fitness_score = ?
+                WHERE alpha_id = ?
+            """, [metrics.sharpe_full, metrics.sharpe_is, metrics.sharpe_os,
+                  metrics.fitness, metrics.turnover, metrics.returns,
+                  metrics.max_drawdown, metrics.yearly_sharpe, metrics.yearly_returns,
+                  metrics.margin_pct, fitness_score, alpha_id])
+            self.conn.execute("COMMIT")
+        except Exception:
+            self.conn.execute("ROLLBACK")
+            raise
 
     def update_verdict(self, alpha_id: str, verdict: Verdict, memo: str = ""):
         """Set the final verdict for an alpha."""
@@ -144,8 +153,11 @@ class FactorStore:
 
     def count_consecutive_kills(self) -> int:
         """Count consecutive kills from most recent (for kill switch)."""
+        # Use rowid as tiebreaker for deterministic ordering when timestamps are equal
         results = self.conn.execute("""
-            SELECT verdict FROM alphas ORDER BY submitted_at DESC LIMIT 50
+            SELECT verdict FROM alphas
+            ORDER BY submitted_at DESC, rowid DESC
+            LIMIT 50
         """).fetchall()
         count = 0
         for r in results: