inserting prefix truncation to the process input func

debug.py

@@ -0,0 +1,14 @@
+from transformers import AutoTokenizer
+from datasets import load_dataset
+
+def main():
+    tokenizer = AutoTokenizer.from_pretrained("t5-base")
+    # dataset = load_dataset("tau/fs",name="summ_screen_fd", max_source_length=512, tokenizer=tokenizer, prompt="Summary:")
+    ssfd_debug = load_dataset("/Users/yuvalkirstain/repos/fs", name="summ_screen_fd_debug", max_source_length=512,
+                              tokenizer=tokenizer)
+    arxiv_debug = load_dataset("/Users/yuvalkirstain/repos/fs", name="arxiv_debug", max_source_length=512,
+                               tokenizer=tokenizer, prompt="Summarize the above:")
+
+
+if __name__ == '__main__':
+    main()

fs.py

@@ -4,6 +4,8 @@
 
 import json
 import os
+from abc import abstractmethod
+
 import datasets
 from datasets import load_dataset
 from transformers import AutoTokenizer  # TODO comment out when getting rid of __main__:
@@ -120,11 +122,17 @@ class ScrollsConfig(FSConfig):
         self.validation_file = "validation.jsonl"
         self.test_file = "test.jsonl"
 
-        self.input_key = "input"
+        self.input_key = "input"  # TODO I think that we should keep the original fields
         self.output_key = "output"
         self.id_key = "pid"
         self.redundant_fields = [self.input_key, self.output_key, "id"]
 
+    def process_input(self, s):
+        prefix = s.strip()
+        suffix = "\nSummarize the above:"
+        prefix = _truncate_prefix(prefix, suffix, self.max_source_length, self.tokenizer)
+        return prefix + suffix
+
 
 class ArxivConfig(FSConfig):
     def __init__(self, **kwargs):
@@ -141,11 +149,28 @@ class ArxivConfig(FSConfig):
         self.redundant_fields = [self.input_key, self.output_key, self.id_key, 'labels', 'section_names', 'sections']
 
     def process_input(self, s):
-        return ' '.join(s)
+        prefix = ' '.join(s)
+        suffix = "\nSummarize the above:"
+        prefix = _truncate_prefix(prefix, suffix, self.max_source_length, self.tokenizer)
+        return prefix + suffix
 
     def process_output(self, s):
         # TODO remove "<S>" and "</S>" ?
-        return self.process_input(s)
+        return ' '.join(s).replace("<S>", "").replace("</S>", "")
+
+
+def _truncate_prefix(prefix, suffix, max_source_length, tokenizer):
+    encoded_input = tokenizer.encode(prefix + suffix)
+
+    while len(encoded_input) > max_source_length:
+        overflow = len(encoded_input) - max_source_length
+        tokenized_prefix = tokenizer.encode(prefix, add_special_tokens=False)
+        if overflow > 0:
+            tokenized_prefix = tokenized_prefix[:-overflow]
+        prefix = tokenizer.decode(tokenized_prefix, skip_special_tokens=False).strip()
+        encoded_input = tokenizer.encode(prefix + suffix)
+
+    return prefix
 
 
 class Fs(datasets.GeneratorBasedBuilder):
@@ -240,24 +265,9 @@ class Fs(datasets.GeneratorBasedBuilder):
             for line in f:
                 row = json.loads(line)
 
-                prefix = self.config.process_input(row[self.config.input_key])
-                suffix = "\n" + self.config.prompt
-                encoded_input = tokenizer.encode(prefix + suffix)
-
-                n_truncations = 0
-                while len(encoded_input) > max_source_length:
-                    overflow = len(encoded_input) - max_source_length
-                    tokenized_prefix = tokenizer.encode(prefix, add_special_tokens=False)
-                    if overflow > 0:
-                        tokenized_prefix = tokenized_prefix[:-overflow]
-                    n_truncations += 1
-                    prefix = tokenizer.decode(tokenized_prefix, skip_special_tokens=False).strip()
-                    encoded_input = tokenizer.encode(prefix + suffix)
-
                 row["pid"] = row[self.config.id_key]
-                row["source"] = prefix + suffix
-                target = row[self.config.output_key]
-                row["target"] = self.config.process_output(target)
+                row["source"] = self.config.process_input(row[self.config.input_key])
+                row["target"] = self.config.process_output(row[self.config.output_key])
 
                 self.config.remove_redundant_fields(row)
                 yield row["pid"], row
@@ -265,17 +275,3 @@ class Fs(datasets.GeneratorBasedBuilder):
 
 def _get_task_name_from_data_url(data_url):
     return data_url.split("/")[-1].split(".")[0]
-
-
-if __name__ == '__main__':
-    tokenizer = AutoTokenizer.from_pretrained("t5-base")
-    # dataset = load_dataset("tau/fs",name="summ_screen_fd", max_source_length=512, tokenizer=tokenizer, prompt="Summary:")
-    ssfd_debug = load_dataset("/Users/uri/Projects/fs/fs.py", name="summ_screen_fd_debug", max_source_length=512,
-                              tokenizer=tokenizer)
-    arxiv_debug = load_dataset("/Users/uri/Projects/fs/fs.py", name="arxiv_debug", max_source_length=512,
-                               tokenizer=tokenizer, prompt="Summarize the above:")
-    x = 5
-#    builder = Scrolls("scrolls", "summ_screen_fd")
-#    builder.download_and_prepare()
-#    dataset = builder.as_dataset("validation")
-#    x = 5