Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-10T05:21:34.436Z Electron: 19.1.9 Chromium: 102.0.5005.194 16.14.2 V8: 10.2.154.23-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes Steps to Reproduce: an existing workspace folder with git a few branches with commits to switch branches list of branches does not display the recent branches on top the same workspace folder in vscode stable and the order is as expected

this._sourceControl.commitTemplate = commitTemplate; // Execute cancellable long-running operations <del> const config = workspace.getConfiguration('git'); let sort = config.get<'alphabetically' | 'committerdate'>('branchSortOrder') || 'alphabetically'; if (sort !== 'alphabetically' && sort !== 'committerdate') { sort = 'alphabetically'; } </del> const [resourceGroups, refs] = await Promise.all([ this.getStatus(cancellationToken), <del> this.repository.getRefs({ sort }, cancellationToken)]); </del> <ins> this.getRefs({}, cancellationToken)]); </ins> this._refs = refs!; this._updateResourceGroupsState(resourceGroups);


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0 insider OS Version: Windows 11 Version 10.0. Build Steps to Reproduce: perfectly clean VSCode Insider version any folder and create/open .md file like this: Preview to the side ! on the second title (L5) then vertical white line appears on the left ! I click on the secound line, the top title is highlighted normally ! when I directly click on the first line, the vertical line doesn't appear !

return (documentVersion: number) => { if (!cachedElements || documentVersion !== cachedVersion) { cachedVersion = documentVersion; <del> cachedElements = [{ element: document.body, line: 0 }]; </del> <ins> cachedElements = [{ element: document.body, line: -1 }]; </ins> for (const element of document.getElementsByClassName(codeLineClass)) { const line = +element.getAttribute('data-line')!; if (isNaN(line)) {


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

} switch (e.data.type) { <del> case 'setScale': </del> <ins> case 'setScale': { </ins> updateScale(e.data.scale); break; <del> case 'setActive': </del> <ins> } case 'setActive': { </ins> setActive(e.data.value); break; <del> case 'zoomIn': </del> <ins> } case 'zoomIn': { </ins> zoomIn(); break; <del> case 'zoomOut': </del> <ins> } case 'zoomOut': { </ins> zoomOut(); break; <ins> } case 'copyImage': { copyImage(); break; } </ins> } }); <ins> document.addEventListener('copy', () => { copyImage(); }); async function copyImage() { try { await navigator.clipboard.write([new ClipboardItem({ 'image/png': fetch(image.src).then(request => request.blob()) })]); } catch (e) { console.error(e); } } </ins> }());


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

"command": "imagePreview.zoomOut", "title": "%command.zoomOut%", "category": "Image Preview" <ins> }, { "command": "imagePreview.copyImage", "title": "%command.copyImage%", "category": "Image Preview" </ins> } ], "menus": {


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

"command": "imagePreview.zoomOut", "when": "activeCustomEditorId == 'imagePreview.previewEditor'", "group": "1_imagePreview" <ins> }, { "command": "imagePreview.copyImage", "when": "false" } ], "webview/context": [ { "command": "imagePreview.copyImage", "when": "webviewId == 'imagePreview.previewEditor'" </ins> } ] }


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

"customEditor.imagePreview.displayName": "Image Preview", "customEditor.videoPreview.displayName": "Video Preview", "command.zoomIn": "Zoom in", <del> "command.zoomOut": "Zoom out" </del> <ins> "command.zoomOut": "Zoom out", "command.copyImage": "Copy" </ins> }


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

<meta http-equiv="Content-Security-Policy" content="default-src 'none'; img-src data: ${cspSource}; media-src ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';"> <meta id="settings" data-settings="${escapeAttribute(JSON.stringify(settings))}">

${vscode.l10n.t("An error occurred while loading the audio file.")}


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

} } <ins> public copyImage() { if (this.previewState === PreviewState.Active) { this.webviewEditor.reveal(); this.webviewEditor.webview.postMessage({ type: 'copyImage' }); } } </ins> protected override updateState() { super.updateState();


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

<link rel="stylesheet" href="${escapeAttribute(this.extensionResource('media', 'imagePreview.css'))}" type="text/css" media="screen" nonce="${nonce}">  <meta http-equiv="Content-Security-Policy" content="default-src 'none'; img-src data: ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';">   <meta http-equiv="Content-Security-Policy" content="default-src 'none'; img-src data: ${cspSource}; connect-src ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';">  <meta id="image-preview-settings" data-settings="${escapeAttribute(JSON.stringify(settings))}">

${vscode.l10n.t("An error occurred while loading the image.")}


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

previewManager.activePreview?.zoomOut(); })); <ins> disposables.push(vscode.commands.registerCommand('imagePreview.copyImage', () => { previewManager.activePreview?.copyImage(); })); </ins> return vscode.Disposable.from(...disposables); }


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.74.3 (on ) OS Version: Linux, Gnome, Chrome Steps to Reproduce: an image in the media-preview extension click on the image and select copy to paste the image somewhere Nothing happens. Also note that Cut and Paste make no sense here as menu items. I assume that these are just the default context menu options from - perhaps these should be removed entirely from the preview extension and we could manually implement copy?
Hey I would like to work on this issue.
assign this to me
Are these the correct steps to reproduce the issue? I'm unable to verify it on my mac. Can you provide more information? I previewed the image and then copied and pasted it. <img width="950" alt="image" src="https://user-"
I would like to wokr on this issue.
I would like to try solving this issue.
You right-click an image and select "copy", then you click a folder in VSCode's explorer and select "paste". The image should be pasted into that folder but it doesn't.
I would like to work on this issuse. here, I tried to copy and paste (Ctrl+v) it. But it doesn't work. https://user-
After a day of researching, I think I can explain why this issue happens. Basically in the core webview module (see ), three default context menu actions (cut, copy and paste) are to the menu, which are accessible throughout all webviews, and happens to be one of them, so after you right-click anywhere in a image previewer, you will be able to see these three actions. After you clicks one of these actions, the editor will post an message to the image previewer, telling it to cut, copy or paste. If there is a correspondent listener for this perpose, the image will be actually cut, copied, pasted, but unfortunately there is no such listeners defined. This problem has existed for quite a bit of time. The original modification that cause this problem is from here . It is origianlly meant to allow users to copy selected text within an extension's README page. There is also a closed issue that describe such issue in . Personally I think providing action cut, copy and paste for all webviews is a little bit hasty, since there are not universally required for each webview, and even some of them need, the subject to be copied may vary from different webviews, or even different places in a same webview. I can solve it by disabling the default actions first (there is a option to achieve this), then let image previewer to implement its own copy and cut functionality, but I think this is rather a quick and sloppy solution. There should be another better way to solve this issue.
What about adding a handler :
Here's what I tried VSC insiders without any extensions Open a folder with a .png file Open the png file in vscode Right click and select Paste into folder in vscode = does not work Paste into markdown cell in vscode = does not work What am i doing wrong?
Pasting image data into folders isn't supported by VS Code. Pasting into a notebook cells works fine for me though. To verify though you can also paste into an external image editor

<meta http-equiv="Content-Security-Policy" content="default-src 'none'; img-src data: ${cspSource}; media-src ${cspSource}; script-src 'nonce-${nonce}'; style-src ${cspSource} 'nonce-${nonce}';"> <meta id="settings" data-settings="${escapeAttribute(JSON.stringify(settings))}">

${vscode.l10n.t("An error occurred while loading the video file.")}


Question:
Type: <bBug</ba TS file at the language status item in the status bar Bug The bracket icon is instead rendered as a pie chart icon <img width="222" alt="Screenshot 2023-01-18 at 1 28 37 PM" src="https://user-"VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-18T08:53:10.224Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Looks like the id for got duplicated:

italic: register('italic', 0xeb0d), jersey: register('jersey', 0xeb0e), json: register('json', 0xeb0f), <ins> bracket: register('bracket', 0xeb0f), </ins> kebabVertical: register('kebab-vertical', 0xeb10), key: register('key', 0xeb11), law: register('law', 0xeb12),


Question:
Type: <bBug</ba TS file at the language status item in the status bar Bug The bracket icon is instead rendered as a pie chart icon <img width="222" alt="Screenshot 2023-01-18 at 1 28 37 PM" src="https://user-"VS Code version: Code - Insiders 1.75.0-insider (Universal) (, 2023-01-18T08:53:10.224Z) OS version: Darwin x64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Looks like the id for got duplicated:

graphLine: register('graph-line', 0xebe2), graphScatter: register('graph-scatter', 0xebe3), pieChart: register('pie-chart', 0xebe4), <del> bracket: register('bracket', 0xebe4), </del> bracketDot: register('bracket-dot', 0xebe5), bracketError: register('bracket-error', 0xebe6), lockSmall: register('lock-small', 0xebe7),


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

} /** <ins> * A regex that extracts the link suffix which contains line and column information. The link suffix * must terminate at the end of line. */ const linkSuffixRegexEol = new Lazy<RegExp>(() => generateLinkSuffixRegex(true)); /** </ins> * A regex that extracts the link suffix which contains line and column information. */ <del> const linkSuffixRegexEol = new Lazy<RegExp>(() => { </del> <ins> const linkSuffixRegex = new Lazy<RegExp>(() => generateLinkSuffixRegex(false)); function generateLinkSuffixRegex(eolOnly: boolean) { </ins> let ri = 0; let ci = 0; function l(): string {


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

return `(?<col${ci++}>d+)`; } <ins> const eolSuffix = eolOnly ? '$' : ''; </ins> // The comments in the regex below use real strings/numbers for better readability, here's // the legend: // - Path = foo


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

// foo:339 // foo:339:12 // foo 339 <del> // foo 339:12                    [#140780] </del> <ins> // foo 339:12                        [#140780] </ins> // "foo",339 // "foo",339:12 <del> `(?::| |['"],)${l()}(:${c()})?$`, // The quotes below are optional [#171652] // "foo", line 339                [#40468] </del> <ins> `(?::| |['"],)${l()}(:${c()})?` + eolSuffix, // The quotes below are optional     [#171652] // "foo", line 339                   [#40468] </ins> // "foo", line 339, col 12 // "foo", line 339, column 12 // "foo":line 339


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

// "foo" on line 339, col 12 // "foo" on line 339, column 12 // "foo" line 339 column 12 <del> `['"]?(?:,? |: ?| on )line ${l()}(,? col(?:umn)? ${c()})?$`, // foo(339) // foo(339,12) // foo(339, 12) // foo (339) //   ... // foo: (339) //   ... `:? ?[[(]${l()}(?:, ?${c()})?[])]$`, ]; const suffixClause = lineAndColumnRegexClauses // Join all clauses together .join('|') // Convert spaces to allow the non-breaking space char (ascii 160) .replace(/ /g, `[${'u00A0'} ]`); return new RegExp(`(${suffixClause})`); }); const linkSuffixRegex = new Lazy<RegExp>(() => { let ri = 0; let ci = 0; function l(): string { return `(?<row${ri++}>d+)`; } function c(): string { return `(?<col${ci++}>d+)`; } const lineAndColumnRegexClauses = [ // foo:339 // foo:339:12 // foo 339 // foo 339:12                    [#140780] // "foo",339 // "foo",339:12 `(?::| |['"],)${l()}(:${c()})?`, // The quotes below are optional [#171652] // foo, line 339                [#40468] // foo, line 339, col 12 // foo, line 339, column 12 // "foo":line 339 // "foo":line 339, col 12 // "foo":line 339, column 12 // "foo": line 339 // "foo": line 339, col 12 // "foo": line 339, column 12 // "foo" on line 339 // "foo" on line 339, col 12 // "foo" on line 339, column 12 // "foo" line 339 column 12 `['"]?(?:,? |: ?| on )line ${l()}(,? col(?:umn)? ${c()})?`, </del> <ins> // "foo", line 339, character 12     [#171880] // "foo", line 339, characters 12-13 [#171880] // "foo", lines 339-340              [#171880] `['"]?(?:,? |: ?| on )lines? ${l()}(?:-d+)?(?:,? (?:col(?:umn)?|characters?) ${c()}(?:-d+)?)?` + eolSuffix, </ins> // foo(339) // foo(339,12) // foo(339, 12)


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

//   ... // foo: (339) //   ... <del> `:? ?[[(]${l()}(?:, ?${c()})?[])]`, </del> <ins> `:? ?[[(]${l()}(?:, ?${c()})?[])]` + eolSuffix, </ins> ]; const suffixClause = lineAndColumnRegexClauses


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

// Convert spaces to allow the non-breaking space char (ascii 160) .replace(/ /g, `[${'u00A0'} ]`); <del> return new RegExp(`(${suffixClause})`, 'g'); }); </del> <ins> return new RegExp(`(${suffixClause})`, eolOnly ? undefined : 'g'); } </ins> /** * Removes the optional link suffix which contains line and column information.


Question:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --originally posted here: when using the OCaml ecosystem (in my example ) the errors can't be clicked on in the terminal: <img width="736" alt="Screenshot 2023-01-19 at 10 06 47 PM" src="https://user-"I often can't click on the file because it isn't relative to where I am, and when I can click it doesn't get me to the line number. I'm not sure how other languages do it but I don't remember having that problem in other ecosystems. I'm also not sure how to fix it. I believe the terminal / vscode will detect filename:linenumber all the time, but the "File "", line 588, characters 50-75" is not recognized.
yeah looks like we don't support that case atm, though this one comes close
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
The situation is pretty good on Insiders after the many link changes that have gone in since December: ! Keeping this open to also match the part and ideally select the actual range in this case.
what's Insiders? EDIT: the beta,
I'm enjoying the improvement, but the pattern still doesn't work, e.g.: Thanks!
is that a real example or did you make up the characters part? I'm not sure what multi-line and multi-character means exactly
Forking proper multi-line support to , we should be able to support the simple case of just going to the first line easily in the one.
Thank you for your work! It's a real example, just going to the first line is good enough for me! The meaning of is "in the selection within file F, spanning from line N1, character/column C1 to line N2, character/column C2" (subject to off-by-one errors, I don't remember how the characters are counted).
Oh ok, that makes sense
FYI the row/col end part of the link should work when is merged

{ link: 'foo: [339,12]', prefix: undefined, suffix: ': [339,12]', hasRow: true, hasCol: true }, { link: 'foo: [339, 12]', prefix: undefined, suffix: ': [339, 12]', hasRow: true, hasCol: true }, <ins> // OCaml-style { link: '"foo", line 339, character 12', prefix: '"', suffix: '", line 339, character 12', hasRow: true, hasCol: true }, { link: '"foo", line 339, characters 12-13', prefix: '"', suffix: '", line 339, characters 12-13', hasRow: true, hasCol: true }, { link: '"foo", lines 339-340', prefix: '"', suffix: '", lines 339-340', hasRow: true, hasCol: false }, </ins> // Non-breaking space { link: 'foou00A0339:12', prefix: undefined, suffix: 'u00A0339:12', hasRow: true, hasCol: true }, { link: '"foo" on line 339,u00A0column 12', prefix: '"', suffix: '" on line 339,u00A0column 12', hasRow: true, hasCol: true },


Question:
Click on an error: <img width="595" alt="image" src="https://user-"
What I see when running from sources: !
in insiders. try with "Notification Tester" extension.
The problem is that the css rule that adds the icon color looses against the color from the list. !
Fix in

/* Icons */ .monaco-workbench > .notifications-toasts .codicon.codicon-error { <del> color: var(--vscode-notificationsErrorIcon-foreground); </del> <ins> color: var(--vscode-notificationsErrorIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-toasts .codicon.codicon-warning { <del> color: var(--vscode-notificationsWarningIcon-foreground); </del> <ins> color: var(--vscode-notificationsWarningIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-toasts .codicon.codicon-info { <del> color: var(--vscode-notificationsInfoIcon-foreground); </del> <ins> color: var(--vscode-notificationsInfoIcon-foreground) !important; </ins> }


Question:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.
also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"

"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.19", </del> <ins> "xterm": "5.2.0-beta.20", </ins> "xterm-addon-canvas": "0.4.0-beta.7", "xterm-addon-search": "0.11.0", "xterm-addon-serialize": "0.9.0", "xterm-addon-unicode11": "0.5.0", "xterm-addon-webgl": "0.15.0-beta.4", <del> "xterm-headless": "5.2.0-beta.19", </del> <ins> "xterm-headless": "5.2.0-beta.20", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },


Question:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.
also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"

"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.2.0-beta.19", </del> <ins> "xterm": "5.2.0-beta.20", </ins> "xterm-addon-canvas": "0.4.0-beta.7", "xterm-addon-search": "0.11.0", "xterm-addon-unicode11": "0.5.0",


Question:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.
also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"

resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm@5.2.0-beta.19: version "5.2.0-beta.19" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm@5.2.0-beta.20: version "5.2.0-beta.20" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins>


Question:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.
also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"

resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm-headless@5.2.0-beta.19: version "5.2.0-beta.19" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.19.tgz#7603ffe76d42882bf72820791f8d2ba2074d7ace" integrity sha512-MKaObf5tdeEPXfRyhWkvNbiJ4oE57rL4eDV68iXm/0yYHgW3oQf3QO1d4SMGIxWYVx70AulY6EP2VswuInXImg== xterm@5.2.0-beta.19: version "5.2.0-beta.19" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm-headless@5.2.0-beta.20: version "5.2.0-beta.20" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.20.tgz#5827ac8977b5ae3246cc217dccdd6eaeac01b66e" integrity sha512-D1y4CIRvA8Izo7tAWShbyKTnxVteAy+N1j9Q+xvzcVxsGA4DLa8U7Gr2KXs3e/cjgkDcVHbbYCn7iWEyNTFvWw== xterm@5.2.0-beta.20: version "5.2.0-beta.20" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins> yallist@^4.0.0: version "4.0.0"


Question:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.
also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"

resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm-headless@5.2.0-beta.19: version "5.2.0-beta.19" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.19.tgz#7603ffe76d42882bf72820791f8d2ba2074d7ace" integrity sha512-MKaObf5tdeEPXfRyhWkvNbiJ4oE57rL4eDV68iXm/0yYHgW3oQf3QO1d4SMGIxWYVx70AulY6EP2VswuInXImg== xterm@5.2.0-beta.19: version "5.2.0-beta.19" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm-headless@5.2.0-beta.20: version "5.2.0-beta.20" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.20.tgz#5827ac8977b5ae3246cc217dccdd6eaeac01b66e" integrity sha512-D1y4CIRvA8Izo7tAWShbyKTnxVteAy+N1j9Q+xvzcVxsGA4DLa8U7Gr2KXs3e/cjgkDcVHbbYCn7iWEyNTFvWw== xterm@5.2.0-beta.20: version "5.2.0-beta.20" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins> y18n@^3.2.1: version "3.2.2"


Question:
Testing No matter whether I use or set it to some other keybinding, I cannot seem to invoke this command with a keyboard shortcut--only from the command palette.
I cannot repro on mac, windows, or linux, could you pls run and provide me with the logs? The terminal has to be focused btw for it to work
Yeah the terminal was focused in my testing. Weirdly enough, seems to work now--definitely wasn't working before though.
I've run into this as well. Here's the output when turned on Toggle Keyboard Shortcuts Troubleshooting: 2023-01-24 19:45:48.902 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:48.925 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:48.925 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.404 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.405 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.405 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.435 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.482 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.483 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.513 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.514 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.514 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.544 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.545 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.545 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.577 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.577 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.578 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.608 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.608 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.609 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.641 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.642 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.642 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.643 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.643 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.673 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.673 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.674 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.674 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.675 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.703 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.703 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.704 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.735 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.736 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.736 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.767 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.768 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.768 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.798 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.799 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.799 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.844 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.844 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.845 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.845 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.845 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.877 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.877 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.878 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.878 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.879 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.907 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.908 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.909 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.909 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.910 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.916 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.917 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:49.917 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.063 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.063 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:50.063 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.483 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:50.484 [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys.
This was on my Surface with Windows 11. I wonder if it has to do with needing to press the Windows function key to get my F1 key? I need to do Shift + Function + F1 as without the Function key, F1 is the screen dimmer. Alt+Function+F1 works for showing the regular accessibility help. I wonder what that code is doing to work?
This is expected as to use , the function key needs to be activated. in the terminal does funny things on Windows/Linux, which is why we went with instead here
On Windows, when I set the keybinding to , it's not a valid chord and the result from the keybinding service is . That's true even when I set the weight for our action to be greater than workbench contrib. It doesn't work even when I set . Thus, we need to stick with here and the function key has to be used before pressing . !
shift+f1 isn't working for me

primary: KeyMod.Alt | KeyCode.F1, weight: KeybindingWeight.WorkbenchContrib, linux: { <del> primary: KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Shift | KeyCode.F1] }, win: { primary: KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Shift | KeyCode.F1] </del> <ins> primary: KeyMod.Alt | KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Alt | KeyCode.F1] </ins> }, when: TerminalContextKeys.focus }