Question:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !

quickPick.activeItems = activeItems; }, this); <del> const pick = await new Promise<KernelQuickPickItem | undefined>((resolve, reject) => { </del> <ins> const pick = await new Promise<{ selected: KernelQuickPickItem | undefined; items: KernelQuickPickItem[] }>((resolve, reject) => { </ins> quickPick.onDidAccept(() => { const item = quickPick.selectedItems[0]; if (item) { <del> resolve(item); </del> <ins> resolve({ selected: item, items: quickPick.items as KernelQuickPickItem[] }); </ins> } else { <del> resolve(undefined); </del> <ins> resolve({ selected: undefined, items: quickPick.items as KernelQuickPickItem[] }); </ins> } quickPick.hide();


Question:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !

kernelDetectionTaskListener.dispose(); kernelChangeEventListener.dispose(); quickPick.dispose(); <del> resolve(undefined); </del> <ins> resolve({ selected: undefined, items: quickPick.items as KernelQuickPickItem[] }); </ins> }); quickPick.show(); }); <del> if (pick) { return await this._handleQuickPick(editor, pick); </del> <ins> if (pick.selected) { return await this._handleQuickPick(editor, pick.selected, pick.items); </ins> } return false;


Question:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !

scopedContextKeyService: IContextKeyService ): QuickPickInput<KernelQuickPickItem>[]; <del> protected async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem) { </del> <ins> protected async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem, quickPickItems: KernelQuickPickItem[]): Promise<boolean> { </ins> if (isKernelPick(pick)) { const newKernel = pick.kernel; this._selecteKernel(editor.textModel, newKernel);


Question:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !

}; } <del> protected override async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem): Promise<boolean> { </del> <ins> protected override async _handleQuickPick(editor: IActiveNotebookEditor, pick: KernelQuickPickItem, items: KernelQuickPickItem[]): Promise<boolean> { </ins> if (pick.id === 'selectAnother') { <del> return this.displaySelectAnotherQuickPick(editor); </del> <ins> return this.displaySelectAnotherQuickPick(editor, items.length === 1 && items[0] === pick); </ins> } <del> return super._handleQuickPick(editor, pick); </del> <ins> return super._handleQuickPick(editor, pick, items); </ins> } <del> private async displaySelectAnotherQuickPick(editor: IActiveNotebookEditor) { </del> <ins> private async displaySelectAnotherQuickPick(editor: IActiveNotebookEditor, kernelListEmpty: boolean) { </ins> const notebook: NotebookTextModel = editor.textModel; const disposables = new DisposableStore(); return new Promise<boolean>(resolve => { // select from kernel sources const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>(); <del> quickPick.title = localize('selectAnotherKernel', "Select Another Kernel"); </del> <ins> quickPick.title = kernelListEmpty ? localize('select', "Select Kernel") : localize('selectAnotherKernel', "Select Another Kernel"); </ins> quickPick.busy = true; quickPick.buttons = [this._quickInputService.backButton]; quickPick.show();


Question:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !

disposables.add(quickPick.onDidTriggerButton(button => { if (button === this._quickInputService.backButton) { quickPick.hide(); <del> resolve(this.showQuickPick(editor)); </del> <ins> resolve(this.showQuickPick(editor, undefined, true)); </ins> } })); disposables.add(quickPick.onDidAccept(async () => {


Question:
Testing microsoft/vscode-jupyter Open a new window where no kernels have been used Open the kernel picker, get the kernel source picker Click the back button The quick pick flashes closed/opened and shows the source picker again
Was trying the MRU out with my new machine and ran into the same thing. Just adding a few more comments: The progress bar makes it look like the process to find kernels just hangs I'd expect to see like the old experience feels unfinished--it's my first time picking a kernel for this project so I expect it to tell me to just !

} resolve(true); } else { <del> return resolve(this.displaySelectAnotherQuickPick(editor)); </del> <ins> return resolve(this.displaySelectAnotherQuickPick(editor, false)); </ins> } } else if (isKernelPick(quickPick.selectedItems[0])) { await this._selecteKernel(notebook, quickPick.selectedItems[0].kernel);


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

const allRepositoriesLabel = l10n.t('All Repositories'); const allRepositoriesQuickPickItem: QuickPickItem = { label: allRepositoriesLabel }; <del> const repositoriesQuickPickItems: QuickPickItem[] = Array.from(this.model.unsafeRepositories.values()).sort().map(r => new UnsafeRepositoryItem(r)); </del> <ins> const repositoriesQuickPickItems: QuickPickItem[] = Array.from(this.model.unsafeRepositories.keys()).sort().map(r => new UnsafeRepositoryItem(r)); </ins> quickpick.items = this.model.unsafeRepositories.size === 1 ? [...repositoriesQuickPickItems] : [...repositoriesQuickPickItems, { label: '', kind: QuickPickItemKind.Separator }, allRepositoriesQuickPickItem];


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

if (repositoryItem.label === allRepositoriesLabel) { // All Repositories <del> unsafeRepositories.push(...this.model.unsafeRepositories.values()); </del> <ins> unsafeRepositories.push(...this.model.unsafeRepositories.keys()); </ins> } else { // One Repository unsafeRepositories.push((repositoryItem as UnsafeRepositoryItem).path);


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

for (const unsafeRepository of unsafeRepositories) { // Mark as Safe <del> await this.git.addSafeDirectory(unsafeRepository); </del> <ins> await this.git.addSafeDirectory(this.model.unsafeRepositories.get(unsafeRepository)!); </ins> // Open Repository await this.model.openRepository(unsafeRepository);


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

} async addSafeDirectory(repositoryPath: string): Promise<void> { <del> // safe.directory only supports paths with `/` as separator repositoryPath = repositoryPath.replaceAll('', '/'); </del> await this.exec(repositoryPath, ['config', '--global', '--add', 'safe.directory', repositoryPath]); return; }


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

constructor(public readonly repository: Repository, public readonly index: number) { } } <del> class UnsafeRepositorySet extends Set<string> { </del> <ins> /** * Key   - normalized path used in user interface * Value - path extracted from the output of the `git status` command *         used when calling `git config --global --add safe.directory` */ class UnsafeRepositoryMap extends Map<string, string> { </ins> constructor() { super(); this.updateContextKey(); } <del> override add(value: string): this { const result = super.add(value); </del> <ins> override set(key: string, value: string): this { const result = super.set(key, value); </ins> this.updateContextKey(); return result; } <del> override delete(value: string): boolean { const result = super.delete(value); </del> <ins> override delete(key: string): boolean { const result = super.delete(key); </ins> this.updateContextKey(); return result;


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

private showRepoOnHomeDriveRootWarning = true; private pushErrorHandlers = new Set<PushErrorHandler>(); <del> private _unsafeRepositories = new UnsafeRepositorySet(); get unsafeRepositories(): Set<string> { </del> <ins> private _unsafeRepositories = new UnsafeRepositoryMap(); get unsafeRepositories(): Map<string, string> { </ins> return this._unsafeRepositories; }


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

repository.status(); // do not await this, we want SCM to know about the repo asap } catch (ex) { // Handle unsafe repository <del> const match = /^fatal: detected dubious ownership in repository at '([^']+)'$/m.exec(ex.stderr); if (match && match.length === 2) { </del> <ins> const match = /^fatal: detected dubious ownership in repository at '([^']+)'[sS]*git config --global --add safe.directory '?([^'n]+)'?$/m.exec(ex.stderr); if (match && match.length === 3) { </ins> const unsafeRepositoryPath = path.normalize(match[1]); this.logger.trace(`Unsafe repository: ${unsafeRepositoryPath}`);


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A, extensions are required. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.74.0 (user setup) Commit: Date: 2022-12-05T16:38:16.075Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: No Steps to Reproduce: a network UNC based workspace with a GIT repository that is not currently marked safe. the process to mark the repository safe via the new feature. The repository still will not work. Looking at the .gitconfig file will show that the UNC path was to the safe directory list without the needed prefix.
do you mind sharing the exact output when running inside the unsafe repository as well as the exact path that is being to the file? I am asking as we are currently extracting the path from the output of the command so the issue could be upstream. Thank you!
Here is an example ... I've removed details such as the SID's for security: Note the suggested command to add the path to the safe.directory list includes the needed prefix, but its possible that this is something specific to 'Git for Windows'? This is my personal documents folder via Folder Redirection, its stored on a network path, and since I am the systems administrator, my files are all owned by the administrator, thus ALL my repositories no matter where they are, are considered unsafe. :(
thank you very much! I was extracting the path from the first line of the output which is not correct. Will work on a fix.
You might also note, GIT seems to also flip back and forth as to whether the server in the UNC path should be all capitalized or all lowercase. Don't know if it is something VSCode is doing that causes that, but it can change its mind between two sessions even though the case of the path doesn't change from what I can see in VSCode. This causes an already marked safe repository to be marked unsafe, which is exactly what happened here.
could you please expand on that? Are you seeing this casing issue in the git output window or VS Code UI?
Depends on where you look. So far today, VSCode's Explorer is indicating the path's server portion as uppercase and the source control is also reporting the server portion as uppercase (hover over a repository), so they are agreeing, but next week or next month, it will switch and they won't agree, and it usually is GIT that has changed, not what VSCode shows in the Explorer view. (Explorer view) ! (source control view) ! I've been trying to track this down for a long while, and now the safe-repository mechanism also gets tripped up in this.
thanks for the example. I would suggest that you keep an eye out for any discrepancies on the casing of the path and file a separate issue when it occurs again. As far as this particular issue goes, the fix will be available with the Insiders release next week.

this.showUnsafeRepositoryNotification(); } <del> this._unsafeRepositories.add(unsafeRepositoryPath); </del> <ins> this._unsafeRepositories.set(unsafeRepositoryPath, match[2]); </ins> return; }


Question:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting. See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.

registerSimpleEditorSettingMigration('autoIndent', [[false, 'advanced'], [true, 'full']]); registerSimpleEditorSettingMigration('matchBrackets', [[true, 'always'], [false, 'never']]); registerSimpleEditorSettingMigration('renderFinalNewline', [[true, 'on'], [false, 'off']]); <ins> registerSimpleEditorSettingMigration('cursorSmoothCaretAnimation', [[true, 'on'], [false, 'off']]); </ins> registerEditorSettingMigration('autoClosingBrackets', (value, read, write) => { if (value === false) {


Question:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting. See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.

private _readOnly: boolean; private _cursorBlinking: TextEditorCursorBlinkingStyle; private _cursorStyle: TextEditorCursorStyle; <del> private _cursorSmoothCaretAnimation: boolean; </del> <ins> private _cursorSmoothCaretAnimation: 'off' | 'explicit' | 'on'; </ins> private _selectionIsEmpty: boolean; private _isComposingInput: boolean;


Question:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting. See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.

private _onCursorPositionChanged(position: Position, secondaryPositions: Position[], reason: CursorChangeReason): void { const pauseAnimation = ( this._secondaryCursors.length !== secondaryPositions.length <del> || reason !== CursorChangeReason.Explicit </del> <ins> || (this._cursorSmoothCaretAnimation === 'explicit' && reason !== CursorChangeReason.Explicit) </ins> ); this._primaryCursor.onCursorPositionChanged(position, pauseAnimation); this._updateBlinking();


Question:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting. See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.

_cursorBlinkingStyleFromString, { description: nls.localize('cursorBlinking', "Control the cursor animation style.") } )), <del> cursorSmoothCaretAnimation: register(new EditorBooleanOption( EditorOption.cursorSmoothCaretAnimation, 'cursorSmoothCaretAnimation', false, { description: nls.localize('cursorSmoothCaretAnimation', "Controls whether the smooth caret animation should be enabled.") } </del> <ins> cursorSmoothCaretAnimation: register(new EditorStringEnumOption( EditorOption.cursorSmoothCaretAnimation, 'cursorSmoothCaretAnimation', 'off' as 'off' | 'explicit' | 'on', ['off', 'explicit', 'on'] as const, { enumDescriptions: [ nls.localize('cursorSmoothCaretAnimation.off', "Smooth caret animation is disabled."), nls.localize('cursorSmoothCaretAnimation.explicit', "Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture."), nls.localize('cursorSmoothCaretAnimation.on', "Smooth caret animation is always enabled.") ], description: nls.localize('cursorSmoothCaretAnimation', "Controls whether the smooth caret animation should be enabled.") } </ins> )), cursorStyle: register(new EditorEnumOption( EditorOption.cursorStyle, 'cursorStyle',


Question:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting. See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.

mouseStyle?: 'text' | 'default' | 'copy'; /** * Enable smooth caret animation. <del> * Defaults to false. </del> <ins> * Defaults to 'off'. </ins> */ <del> cursorSmoothCaretAnimation?: boolean; </del> <ins> cursorSmoothCaretAnimation?: 'off' | 'explicit' | 'on'; </ins> /** * Control the cursor style, either 'block' or 'line'. * Defaults to 'line'.


Question:
Type: <bBug</bthe set to the cursor around with arrows. Animation is there. something. Animation is not there. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-12T05:36:38.306Z) OS version: Darwin arm64 22.1.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ better-comments3.0.2 vscode-nginx-conf0.1.3 ng-template15.0.2 vscode-tailwindcss0.9.1 better-toml0.3.2 npm-intellisense1.4.3 vscode-eslint2.3.0 vscode-quick-select0.2.9 xml2.5.1 gitlens13.1.1 scroll-faster0.2.2 prettier-vscode9.10.3 vscode-jest-runner0.4.59 auto-rename-tag0.1.10 shell-format7.2.2 macros1.2.1 vscode-pull-request-github0.57. vscode-postfix-ts1.11.3 Angular213.0.0 center-editor-window2.3.0 graphql-for-vscode1.15.3 vscode-clangd0.1.23 ts-error-translator0.5.1 dotenv1.0.1 vscode-docker1.23.1 black-formatter2022.7. isort2022.9. python2022.21. vscode-pylance2022.12.21 vscode-typescript-next5.0. vsliveshare1.0.5788 prisma4.7.1 vscode-yaml1.10.1 better-pageup-pagedown0.0.1 rust-analyzer0.4.1316 vs-code-prettier-eslint5.0.4 justfile2.1.0 vscode-scss-formatter2.4.4 shellcheck0.29.1 vscode-input-sequence0.2.0 errorlens3.6.0 vscode-lldb1.8.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Maybe related to /assign
This was an intentional change to disable the animation when typing/deleting. See
okay, that makes perfect sense. closing.
Also having the same issue. Has there been a fix?
We have intentionally removed animating the cursor when typing for which explicitly asks us to do that. But I think some folks actually prefered the old behavior of animating also when typing?
Yes, I love the animating when typing.
A good common ground could be that it becomes a setting to also have the caret animated while typing
I've pushed a change where there will be 3 possible values for : off: Smooth caret animation is disabled explicit: Smooth caret animation is enabled only when the user moves the cursor with an explicit gesture. This should cover users who don't want it like in issue on: Smooth caret animation is always enabled
thank you for the changes. I noticed now cursorSmoothCaretAnimation is turned on by default and can't be turned off at all. Looks like a bug.
see which is already fixed.

contextmenu: IEditorOption<EditorOption.contextmenu, boolean>; copyWithSyntaxHighlighting: IEditorOption<EditorOption.copyWithSyntaxHighlighting, boolean>; cursorBlinking: IEditorOption<EditorOption.cursorBlinking, TextEditorCursorBlinkingStyle>; <del> cursorSmoothCaretAnimation: IEditorOption<EditorOption.cursorSmoothCaretAnimation, boolean>; </del> <ins> cursorSmoothCaretAnimation: IEditorOption<EditorOption.cursorSmoothCaretAnimation, 'on' | 'off' | 'explicit'>; </ins> cursorStyle: IEditorOption<EditorOption.cursorStyle, TextEditorCursorStyle>; cursorSurroundingLines: IEditorOption<EditorOption.cursorSurroundingLines, number>; cursorSurroundingLinesStyle: IEditorOption<EditorOption.cursorSurroundingLinesStyle, 'default' | 'all'>;


Question:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified

} private get profilesVisibilityPreference(): boolean { <del> return this.userDataProfilesService.isEnabled() && this.storageService.getBoolean(ProfilesActivityActionViewItem.PROFILES_VISIBILITY_PREFERENCE_KEY, StorageScope.PROFILE, this.userDataProfilesService.profiles.length > 1); </del> <ins> return this.userDataProfilesService.isEnabled() && this.storageService.getBoolean(ProfilesActivityActionViewItem.PROFILES_VISIBILITY_PREFERENCE_KEY, StorageScope.PROFILE, true); </ins> } private set profilesVisibilityPreference(value: boolean) {


Question:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified

import { ContextKeyExpr, IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IProductService } from 'vs/platform/product/common/productService'; import { Registry } from 'vs/platform/registry/common/platform'; <del> import { IUserDataProfilesService, PROFILES_ENABLEMENT_CONFIG } from 'vs/platform/userDataProfile/common/userDataProfile'; </del> <ins> import { IUserDataProfile, IUserDataProfilesService, PROFILES_ENABLEMENT_CONFIG } from 'vs/platform/userDataProfile/common/userDataProfile'; </ins> import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { RenameProfileAction } from 'vs/workbench/contrib/userDataProfile/browser/userDataProfileActions';


Question:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified

import { CancellationToken } from 'vs/base/common/cancellation'; import { URI } from 'vs/base/common/uri'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace'; </del> <ins> import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; </ins> import { IWorkspaceTagsService } from 'vs/workbench/contrib/tags/common/workspaceTags'; import { getErrorMessage } from 'vs/base/common/errors'; <ins> const SelectProfileSubMenu = new MenuId('SelectProfile'); </ins> export class UserDataProfilesWorkbenchContribution extends Disposable implements IWorkbenchContribution { private readonly currentProfileContext: IContextKey<string>;


Question:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified

private registerActions(): void { this.registerManageProfilesSubMenu(); <ins> this.registerSelectProfileSubMenu(); this.registerProfilesActions(); this._register(this.userDataProfilesService.onDidChangeProfiles(() => this.registerProfilesActions())); </ins> this.registerCurrentProfilesActions(); this._register(Event.any(this.userDataProfileService.onDidChangeCurrentProfile, this.userDataProfileService.onDidUpdateCurrentProfile)(() => this.registerCurrentProfilesActions())); } private registerManageProfilesSubMenu(): void { <del> MenuRegistry.appendMenuItem(MenuId.GlobalActivity, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu, group: '5_settings', when: PROFILES_ENABLEMENT_CONTEXT, order: 1 }); </del> MenuRegistry.appendMenuItem(MenuId.MenubarPreferencesMenu, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu,


Question:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified

when: PROFILES_ENABLEMENT_CONTEXT, order: 1 }); <del> MenuRegistry.appendMenuItem(MenuId.AccountsContext, <ISubmenuItem>{ title: PROFILES_TTILE, submenu: ManageProfilesSubMenu, group: '1_settings', </del> <ins> } private registerSelectProfileSubMenu(): IDisposable { const that = this; return MenuRegistry.appendMenuItem(ManageProfilesSubMenu, <ISubmenuItem>{ get title() { return localize('profile', "Profile ({0})", that.userDataProfileService.currentProfile.name); }, submenu: SelectProfileSubMenu, group: '0_profiles', </ins> when: PROFILES_ENABLEMENT_CONTEXT, }); } <del> private readonly currentprofileActionsDisposable = this._register(new MutableDisposable<DisposableStore>()); private registerCurrentProfilesActions(): void { this.currentprofileActionsDisposable.value = new DisposableStore(); this.currentprofileActionsDisposable.value.add(this.registerSwitchProfileForCurrentWindowAction()); this.currentprofileActionsDisposable.value.add(this.registerUpdateCurrentProfileShortNameAction()); this.currentprofileActionsDisposable.value.add(this.registerRenameCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerExportCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerImportProfileAction()); </del> <ins> private readonly profilesDisposable = this._register(new MutableDisposable<DisposableStore>()); private registerProfilesActions(): void { this.profilesDisposable.value = new DisposableStore(); for (const profile of this.userDataProfilesService.profiles) { this.profilesDisposable.value.add(this.registerProfileEntryAction(profile)); } </ins> } <del> private registerSwitchProfileForCurrentWindowAction(): IDisposable { </del> <ins> private registerProfileEntryAction(profile: IUserDataProfile): IDisposable { </ins> const that = this; <del> return registerAction2(class SwitchProfileForCurrentWindowAction extends Action2 { </del> <ins> return registerAction2(class ProfileEntryAction extends Action2 { </ins> constructor() { super({ <del> id: 'workbench.profiles.actions.switchProfile', title: { value: localize('switch profile for current', "Switch Profile ({0})...", that.userDataProfileService.currentProfile.name), original: `Switch Profile (${that.workspaceContextService.getWorkbenchState() === WorkbenchState.EMPTY ? localize('window', "Window") : localize('current workspace', "Workspace")})...` }, category: PROFILES_CATEGORY, f1: true, precondition: ContextKeyExpr.and(PROFILES_ENABLEMENT_CONTEXT, HAS_PROFILES_CONTEXT), </del> <ins> id: `workbench.profiles.actions.profileEntry.${profile.id}`, title: profile.name, toggled: ContextKeyExpr.equals(CURRENT_PROFILE_CONTEXT.key, profile.id), </ins> menu: [ { <del> id: ManageProfilesSubMenu, </del> <ins> id: SelectProfileSubMenu, </ins> group: '0_profiles', when: PROFILES_ENABLEMENT_CONTEXT, }


Question:
We have noticed in the user study that users interact with profiles in different ways and they do not find the indication of active profile super useful. We should also be aware of all the Menus that profiles are present in right now in addition to the Profile activity bar item are confusing. Main menu Account activity bar item Gear activity bar item
After discussing in today's stand up we agreed upon having its own space for profiles and therefore we wanted to show profile indicator and drop the actions in accounts and gear menus. We shall investigate on how to make this profile indicator appealing to users -
Looks great -verified

}); } async run(accessor: ServicesAccessor) { <del> const quickInputService = accessor.get(IQuickInputService); const currentProfile = that.userDataProfileService.currentProfile; const result = await quickInputService.pick(that.userDataProfilesService.profiles.map(profile => ({ id: profile.id, label: currentProfile.id === profile.id ? `$(check) ${profile.name}` : profile.name, profile })), { placeHolder: localize('switch profile', "Switch Profile") }); if (result?.profile) { that.userDataProfileManagementService.switchProfile(result?.profile); </del> <ins> if (that.userDataProfileService.currentProfile.id !== profile.id) { return that.userDataProfileManagementService.switchProfile(profile); </ins> } } }); } <ins> private readonly currentprofileActionsDisposable = this._register(new MutableDisposable<DisposableStore>()); private registerCurrentProfilesActions(): void { this.currentprofileActionsDisposable.value = new DisposableStore(); this.currentprofileActionsDisposable.value.add(this.registerUpdateCurrentProfileShortNameAction()); this.currentprofileActionsDisposable.value.add(this.registerRenameCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerExportCurrentProfileAction()); this.currentprofileActionsDisposable.value.add(this.registerImportProfileAction()); } </ins> private registerUpdateCurrentProfileShortNameAction(): IDisposable { const that = this; return registerAction2(class UpdateCurrentProfileShortName extends Action2 {


Question: Example block quote in the extensions page. <img width="375" alt="image" src="https://user-"

"tab.unfocusedHoverBackground": "#6e76811a", "terminal.foreground": "#ffffffc5", "terminal.inactiveSelectionBackground": "#E5EBF1", <del> "textBlockQuote.background": "#010409", </del> <ins> "textBlockQuote.background": "#f8f8f8", </ins> "textBlockQuote.border": "#0000001a", "textCodeBlock.background": "#6e768166", "textLink.activeForeground": "#005FB8",


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider OS Version: Linux Hello, IMHO, the block cursor could use a different background. Default Dark+ Experimental (v2): ! ! Default Dark+: ! ! Default Dark+ Experimental (v2): with some cursor background color. For ex: ! ! ! ! Edit (one more option) (with color set to 's value, giving inverted cursor effect) ! ! Thanks

"editor.background": "#1f1f1f", "editor.findMatchBackground": "#9e6a03", "editor.foreground": "#ffffffd3", <del> "editorCursor.foreground": "#0078d4", </del> "editorGroup.border": "#ffffff17", "editorGroupHeader.tabsBackground": "#181818", "editorGroupHeader.tabsBorder": "#ffffff15",


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider OS Version: Linux Hello, IMHO, the block cursor could use a different background. Default Dark+ Experimental (v2): ! ! Default Dark+: ! ! Default Dark+ Experimental (v2): with some cursor background color. For ex: ! ! ! ! Edit (one more option) (with color set to 's value, giving inverted cursor effect) ! ! Thanks

"editor.foreground": "#000000e4", "editor.inactiveSelectionBackground": "#E5EBF1", "editor.selectionHighlightBackground": "#ADD6FF80", <del> "editorCursor.foreground": "#005FB8", </del> "editorGroup.border": "#0000001a", "editorGroupHeader.tabsBackground": "#f8f8f8", "editorGroupHeader.tabsBorder": "#0000001a",


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

super(); } <ins> private _activeProvideLinkRequests: Map<number, Promise<TerminalLink[]>> = new Map(); </ins> async provideLinks(bufferLineNumber: number, callback: (links: ILink[] | undefined) => void) { <del> this._activeLinks?.forEach(l => l.dispose()); this._activeLinks = await this._provideLinks(bufferLineNumber); </del> <ins> let activeRequest = this._activeProvideLinkRequests.get(bufferLineNumber); if (activeRequest) { await activeRequest; callback(this._activeLinks); return; } if (this._activeLinks) { for (const link of this._activeLinks) { link.dispose(); } } activeRequest = this._provideLinks(bufferLineNumber); this._activeProvideLinkRequests.set(bufferLineNumber, activeRequest); this._activeLinks = await activeRequest; this._activeProvideLinkRequests.delete(bufferLineNumber); </ins> callback(this._activeLinks); }


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.1.0-beta.87", "xterm-addon-canvas": "0.3.0-beta.35", </del> <ins> "xterm": "5.2.0-beta.2", "xterm-addon-canvas": "0.4.0-beta.1", </ins> "xterm-addon-search": "0.11.0-beta.7", <del> "xterm-addon-serialize": "0.9.0-beta.3", </del> <ins> "xterm-addon-serialize": "0.9.0", </ins> "xterm-addon-unicode11": "0.5.0-beta.5", <del> "xterm-addon-webgl": "0.14.0-beta.50", "xterm-headless": "5.1.0-beta.87", </del> <ins> "xterm-addon-webgl": "0.15.0-beta.1", "xterm-headless": "5.2.0-beta.2", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "8.0.0", <del> "xterm": "5.1.0-beta.87", "xterm-addon-canvas": "0.3.0-beta.35", </del> <ins> "xterm": "5.2.0-beta.2", "xterm-addon-canvas": "0.4.0-beta.1", </ins> "xterm-addon-search": "0.11.0-beta.7", "xterm-addon-unicode11": "0.5.0-beta.5", <del> "xterm-addon-webgl": "0.14.0-beta.50" </del> <ins> "xterm-addon-webgl": "0.15.0-beta.1" </ins> } }


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-8.0.0.tgz#2c7a3b1163ef0441097e0b5d6389cd5504b59e5d" integrity sha512-AFbieoL7a5LMqcnOF04ji+rpXadgOXnZsxQr//r83kLPr7biP7am3g9zbaZIaBGwBRWeSvoMD4mgPdX3e4NWBg== <del> xterm-addon-canvas@0.3.0-beta.35: version "0.3.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version "0.4.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7"


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version "0.14.0-beta.50" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version "0.15.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version "5.2.0-beta.2" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins>


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f" integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8= <del> xterm-addon-canvas@0.3.0-beta.35: version "0.3.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version "0.4.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== <del> xterm-addon-serialize@0.9.0-beta.3: version "0.9.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0-beta.3.tgz#bb4ed416db5748bcbe55a4b6d4c2151368fdae74" integrity sha512-LaFuowtdxNdeuLm+KmtsoR4mgPOLu/I9k0hlWXbzAd1okJhthwMH4Y6cuL0/pFk1AclP5s+L42glv8PV0GnVsg== </del> <ins> xterm-addon-serialize@0.9.0: version "0.9.0" resolved "https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0.tgz#3eee5f5c34b16e48891ec59b213716bab2354bf4" integrity sha512-qJju2YJFh8c8pbtCYtHaG7gDDHBpDJ4a4JQZvOzuiMxOjgeM1oCnFNjbhzMuK/fOUa59FmvIUGQyqn3WL9q7qw== </ins> xterm-addon-unicode11@0.5.0-beta.5: version "0.5.0-beta.5" resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version "0.14.0-beta.50" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version "0.15.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm-headless@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.87.tgz#6eb3114bbe006088ce1aab063f14ce87b93c1001" integrity sha512-/LEyLBkyAMy5r2iGur1CW0UsCGu1oEuskAccokbwOGS5Ad/uPZUDQUAuCmfSSX3gauz5TBqBPLYIRdY0u0DEJg== </del> <ins> xterm-headless@5.2.0-beta.2: version "5.2.0-beta.2" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.2.tgz#db8d4cc45a2bba062622d7784a2264030aa7d56d" integrity sha512-aP3+K47bJu5AkdtekML5LZZUh/zAkDc5ONNFgQ+7eUBh7RkFy3JYRuaG5Nj3LbdkUMjWqQZXzc3BW5Vo9KQNgA== </ins> <del> xterm@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version "5.2.0-beta.2" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins> yallist@^4.0.0: version "4.0.0"


Question:
I was resolving a conflict for with 500 file paths showing up in the terminal as a result and noticed how typing became very slow. Kudos to auto profiling, we have a trace:
Terminal output: !
This was caused by , it may fixable on the VS Code side though.
Repro: vscode repo : over a link and keep it there into the terminal ! ! ! !
Something is not getting disposed, I verified that the number of times each link detector is called increases
!
Can repro upstream:

dependencies: object-keys "~0.4.0" <del> xterm-addon-canvas@0.3.0-beta.35: version "0.3.0-beta.35" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.3.0-beta.35.tgz#2f85f9df9b109d51a8ce08a6023db747f4d060d5" integrity sha512-chk/+FaUPEAC33Mt6PDLbUWlzDCCoXBWJvKykMfhZF0vCm8GqpJc3z6R9jdcZcNCPUhmmv5psRTYun6oy5TvBQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.1: version "0.4.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.1.tgz#f2742b88cd3eb1840b9e7f986c4bfe31e0f4684f" integrity sha512-EfjaN0ujHJ4D8CsVpBig3xPvfRhbzAyOh8piAbNpePZmTpBzc2OQQQvEeklPriKVNDv28WbmY0Zzl5tgYM7vwg== </ins> xterm-addon-search@0.11.0-beta.7: version "0.11.0-beta.7" resolved "https://registry.yarnpkg.com/xterm-addon-search/-/xterm-addon-search-0.11.0-beta.7.tgz#d90bcbe9e8f9238c18ba6145bd7ec2f8e3240052" integrity sha512-i/c774V0/Eon3BIFRsRR3OjKTnMGkccBo12yDkOa40tnAD4aa8FjspE3bxW/Hh1mUEhCSgBSLnMDlK/GwnUC+g== <del> xterm-addon-serialize@0.9.0-beta.3: version "0.9.0-beta.3" resolved "https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0-beta.3.tgz#bb4ed416db5748bcbe55a4b6d4c2151368fdae74" integrity sha512-LaFuowtdxNdeuLm+KmtsoR4mgPOLu/I9k0hlWXbzAd1okJhthwMH4Y6cuL0/pFk1AclP5s+L42glv8PV0GnVsg== </del> <ins> xterm-addon-serialize@0.9.0: version "0.9.0" resolved "https://registry.yarnpkg.com/xterm-addon-serialize/-/xterm-addon-serialize-0.9.0.tgz#3eee5f5c34b16e48891ec59b213716bab2354bf4" integrity sha512-qJju2YJFh8c8pbtCYtHaG7gDDHBpDJ4a4JQZvOzuiMxOjgeM1oCnFNjbhzMuK/fOUa59FmvIUGQyqn3WL9q7qw== </ins> xterm-addon-unicode11@0.5.0-beta.5: version "0.5.0-beta.5" resolved "https://registry.yarnpkg.com/xterm-addon-unicode11/-/xterm-addon-unicode11-0.5.0-beta.5.tgz#6992a6f56349e67b903201d52b1ad41ba3469d93" integrity sha512-MaqnU34WTHCUAo7moB4KhynGn03RckI0JJ8E/gXe96EzuCP6bVJIKSc5pc9iFeLF4BX1SuemOqIHYl2Q3u3NTA== <del> xterm-addon-webgl@0.14.0-beta.50: version "0.14.0-beta.50" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.14.0-beta.50.tgz#e52a7fd1776c214163e15fcabedf1f0b51f75445" integrity sha512-UF8+hBYplKxuOK5ZzLBhbC7cFOqTx0vkcK1dw8mmqL0x8v1lwfz2eRxiqokkC4bDVq3CAKlul1IuEF9cQs5sZQ== </del> <ins> xterm-addon-webgl@0.15.0-beta.1: version "0.15.0-beta.1" resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.1.tgz#bc3f784c3c467a70542b8a9a8998dbe996287796" integrity sha512-8f4cNXG0+dBMqp+Nvk/ZQ8Wo8s4/KbF24b2VTHTt8DuY5QXt4wSA6+NEdnABV98VYDoHl+KfXl9yyFqkcJYr8Q== </ins> <del> xterm-headless@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.1.0-beta.87.tgz#6eb3114bbe006088ce1aab063f14ce87b93c1001" integrity sha512-/LEyLBkyAMy5r2iGur1CW0UsCGu1oEuskAccokbwOGS5Ad/uPZUDQUAuCmfSSX3gauz5TBqBPLYIRdY0u0DEJg== </del> <ins> xterm-headless@5.2.0-beta.2: version "5.2.0-beta.2" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-5.2.0-beta.2.tgz#db8d4cc45a2bba062622d7784a2264030aa7d56d" integrity sha512-aP3+K47bJu5AkdtekML5LZZUh/zAkDc5ONNFgQ+7eUBh7RkFy3JYRuaG5Nj3LbdkUMjWqQZXzc3BW5Vo9KQNgA== </ins> <del> xterm@5.1.0-beta.87: version "5.1.0-beta.87" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.1.0-beta.87.tgz#a4bb442b73e82941f87819f6db7810949536c891" integrity sha512-0cR7TUfAUH6Z1CVzVCm2CnFs7slqro2nf11yjrWvZyxEoGb34rNWvcnvIq2L5Xzv+gvHbl8jDO8yj5nyxQvUCA== </del> <ins> xterm@5.2.0-beta.2: version "5.2.0-beta.2" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.2.tgz#67369235a54f41179922e662df40ff4c7c974787" integrity sha512-MRAdWRfV80ae0Q3Caq/mfmCwnZZZ89Z8i/sAleio5g5dpsst9IXc0zeFpPnOvUWmtVy5P1LbfU9YCy47449DWw== </ins> y18n@^3.2.1: version "3.2.2"


Question:
Light Theme the Extensions view the Extension item in the list -all letters turn black, the contrast is not good !
Looks like these buttons are inheriting the codicon styling, and as a result, the color. I removed it from Light+ V2 to reset it back to null. Ideally this button wouldn't use codicon styling cc

"keybindingLabel.foreground": "#000000e4", "list.activeSelectionBackground": "#e8e8e8", "list.activeSelectionForeground": "#000000", <del> "list.activeSelectionIconForeground": "#000000", </del> "list.hoverBackground": "#f2f2f2", "menu.border": "#D4D4D4", "notebook.cellBorderColor": "#E8E8E8",


Question:
<img width="1754" alt="iShot2022-12-2811 40 36" src="https://user-"
Easy repro: ! ! Likely Windows only.
It's an encoding issue in pwsh's shell integration cwd detection
No, my MacBook has this problem too.
yep the fix was for pwsh on all platforms
Updated 1.74.3 today, but found that this bug still exists, do you want to wait for the next version to fix it?
the fix is in 1.75.0 (insiders only atm)
Thanks.

function Global:__VSCode-Escape-Value([string]$value) { # NOTE: In PowerShell v6.1+, this can be written `$value -replace '…', { … }` instead of `[regex]::Replace`. # Replace any non-alphanumeric characters. <del> [regex]::Replace($value, '[^a-zA-Z0-9]', { param($match) # Backslashes must be doubled. if ($match.Value -eq '') { '' } else { # Any other characters are encoded as their UTF-8 hex values. -Join ( [System.Text.Encoding]::UTF8.GetBytes($match.Value) | ForEach-Object { 'x{0:x2}' -f $_ } ) } </del> <ins> [regex]::Replace($value, '[n;]', { param($match) # Encode the (ascii) matches as `x<hex>` -Join ( [System.Text.Encoding]::UTF8.GetBytes($match.Value) | ForEach-Object { 'x{0:x2}' -f $_ } ) </ins> }) }


Question:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies

return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const focus = e.index; if (typeof focus === 'undefined') {


Question:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies

this.list.setSelection([focus], e.browserEvent); } <del> e.browserEvent.preventDefault(); </del> this._onPointer.fire(e); }


Question:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies

return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const focus = this.list.getFocus(); this.list.setSelection(focus, e.browserEvent); <del> e.browserEvent.preventDefault(); </del> } private changeSelection(e: IListMouseEvent<T> | IListTouchEvent<T>): void {


Question:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies

return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> const node = e.element; if (!node) {


Question:
When opening as quickpick with , the latest Insiders builds only handle click events on the checkbox and not on the row item. In Stable, clicking on the row works as expected. This sounds very similar to and might have the same cause. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure, probably yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider, Commit: OS Version: Windows11(.963), macOS Ventura 13.1; using the VS Code in the web Steps to Reproduce: a quick pick UI with multiple selection options Try to click a row and observe that the selection doesn't change on the checkbox and observe the selection does change This bug was observed with the Codespaces extension, but should happen for any extension/UI using multi-select quick picks.
can you update to the latest Insiders from today and try again?
Sure! It's still broken with the latest insiders: Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-09T05:30:04.983Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes https://user- Here's Stable for comparison: https://user-
Yes, more fallout from , apologies

return; } <del> if (e.browserEvent.defaultPrevented) { return; } </del> super.onDoubleClick(e); } }


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-10T05:21:34.436Z Electron: 19.1.9 Chromium: 102.0.5005.194 16.14.2 V8: 10.2.154.23-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes Steps to Reproduce: an existing workspace folder with git a few branches with commits to switch branches list of branches does not display the recent branches on top the same workspace folder in vscode stable and the order is as expected

} async getRefs(query: RefQuery = {}, cancellationToken?: CancellationToken): Promise<Ref[]> { <del> return await this.run(Operation.GetRefs, () => { return this.repository.getRefs(query, cancellationToken); }); </del> <ins> const config = workspace.getConfiguration('git'); let defaultSort = config.get<'alphabetically' | 'committerdate'>('branchSortOrder'); if (defaultSort !== 'alphabetically' && defaultSort !== 'committerdate') { defaultSort = 'alphabetically'; } query = { ...query, sort: query?.sort ?? defaultSort }; return await this.run(Operation.GetRefs, () => this.repository.getRefs(query, cancellationToken)); </ins> } async getRemoteRefs(remote: string, opts?: { heads?: boolean; tags?: boolean }): Promise<Ref[]> {