data_type
large_stringclasses
3 values
source
large_stringclasses
29 values
code
large_stringlengths
98
49.4M
filepath
large_stringlengths
5
161
message
large_stringclasses
234 values
commit
large_stringclasses
234 values
subject
large_stringclasses
418 values
critique
large_stringlengths
101
1.26M
metadata
dict
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
The crash memory exclude of crashk_res and crashk_cma memory on powerpc are almost identical to the generic crash_exclude_core_ranges(). By introducing the architecture-specific arch_crash_exclude_mem_range() function with a default implementation of crash_exclude_mem_range(), and using crash_exclude_mem_range_guarded...
{ "author": "Jinjie Ruan <ruanjinjie@huawei.com>", "date": "Thu, 26 Feb 2026 21:04:35 +0800", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
From: Sourabh Jain <sourabhjain@linux.ibm.com> During a memory hot-remove event, the elfcorehdr is rebuilt to exclude the removed memory. While updating the crash memory ranges for this operation, the crash memory ranges array can become unsorted. This happens because remove_mem_range() may split a memory range into t...
{ "author": "Jinjie Ruan <ruanjinjie@huawei.com>", "date": "Thu, 26 Feb 2026 21:04:33 +0800", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
Commit 35c18f2933c5 ("Add a new optional ",cma" suffix to the crashkernel= command line option") and commit ab475510e042 ("kdump: implement reserve_crashkernel_cma") added CMA support for kdump crashkernel reservation. Crash kernel memory reservation wastes production resources if too large, risks kdump failure if too...
{ "author": "Jinjie Ruan <ruanjinjie@huawei.com>", "date": "Thu, 26 Feb 2026 21:04:36 +0800", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
The crash memory alloc, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, handling them in the crash core would eliminate a lot of duplication, so do them in the common code. To achieve the above goal, three architecture-specific functions are intr...
{ "author": "Jinjie Ruan <ruanjinjie@huawei.com>", "date": "Thu, 26 Feb 2026 21:04:34 +0800", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
Commit 35c18f2933c5 ("Add a new optional ",cma" suffix to the crashkernel= command line option") and commit ab475510e042 ("kdump: implement reserve_crashkernel_cma") added CMA support for kdump crashkernel reservation. This allows the kernel to dynamically allocate contiguous memory for crash dumping when needed, rathe...
{ "author": "Jinjie Ruan <ruanjinjie@huawei.com>", "date": "Thu, 26 Feb 2026 21:04:37 +0800", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
On 26/02/26 18:34, Jinjie Ruan wrote: update_crash_elfcorehdr() in arch/powerpc/kexec/crash.c still calls crash_exclude_mem_range_guarded(), causing a build failure. ld: arch/powerpc/kexec/crash.o: in function `update_crash_elfcorehdr': /root/linux/arch/powerpc/kexec/crash.c:454: undefined reference to `crash_exclu...
{ "author": "Sourabh Jain <sourabhjain@linux.ibm.com>", "date": "Fri, 27 Feb 2026 20:13:56 +0530", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
The crash memory allocation, and the exclude of crashk_res, crashk_low_res and crashk_cma memory are almost identical across different architectures, This patch set handle them in crash core in a general way, which eliminate a lot of duplication code. And add support for crashkernel CMA reservation for arm64 and riscv...
null
null
null
[PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation
Resend of: https://lore.kernel.org/all/19cf18b5-362d-4ff2-8b85-e2e72809250c@linux.ibm.com/ On 26/02/26 18:34, Jinjie Ruan wrote: update_crash_elfcorehdr() in arch/powerpc/kexec/crash.c still calls crash_exclude_mem_range_guarded(), causing a build failure. ld: arch/powerpc/kexec/crash.o: in function `update_crash_...
{ "author": "Sourabh Jain <sourabhjain@linux.ibm.com>", "date": "Fri, 27 Feb 2026 20:20:34 +0530", "is_openbsd": false, "thread_id": "20260226130437.1867658-1-ruanjinjie@huawei.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v4 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert Atmel system registers binding to YAML format. Acked-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../devicetree/bindings/arm/atmel-sysregs.txt | 5 --- .../bindings/arm/microchip,sama7g5-chipid.yaml | 41 ++++++++++++++++++++++ 2 files changed...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Fri, 27 Feb 2026 15:14:31 +0000", "is_openbsd": false, "thread_id": "20260227-arm-microchip-v4-0-7e2ae1c5b5d6@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v4 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert Atmel Periodic interval timer (PIT) binding to YAML format. Acked-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../bindings/arm/atmel,at91sam9260-pit.yaml | 49 ++++++++++++++++++++++ .../devicetree/bindings/arm/atmel-sysregs.txt | 6 --- 2 ...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Fri, 27 Feb 2026 15:14:32 +0000", "is_openbsd": false, "thread_id": "20260227-arm-microchip-v4-0-7e2ae1c5b5d6@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v4 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert Atmel Periodic interval timer of 64bit (PIT64b) binding to YAML format. Changes during conversion: - Add missing compatible "microchip,sama7g5-pit64b" along with a fallback compatible "microchip,sam9x60-pit64b". Acked-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Akhila YS <akhilayalmati@gmail.c...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Fri, 27 Feb 2026 15:14:33 +0000", "is_openbsd": false, "thread_id": "20260227-arm-microchip-v4-0-7e2ae1c5b5d6@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v4 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert System Timer binding to YAML format. Changes during conversion: - Add "#address-cells" and "#size-cells" to the properties and required as watchdog is defined as a child node to the timer parent node. - Define watchdog as a pattern property along with unit address in examples. Acked-by: Conor Dooley <conor...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Fri, 27 Feb 2026 15:14:34 +0000", "is_openbsd": false, "thread_id": "20260227-arm-microchip-v4-0-7e2ae1c5b5d6@gmail.com.mbox.gz" }
lkml_critique
lkml
Convert various legacy .txt bindings for Microchip (formerly Atmel) AT91/SAMA family system peripherals to proper YAML schemas. This includes: - CHIPID (SoC ID register block) - PIT (Period Interval Timer, old style) - PIT64B (64-bit Period Interval Timer, newer parts) - ST (System Timer, including watchdog subnode) -...
null
null
null
[PATCH v4 0/5] dt-bindings: Microchip/Atmel AT91/SAMA system peripherals: convert to YAML
Convert RAMC SDRAM/DDR controller binding to YAML format. Signed-off-by: Akhila YS <akhilayalmati@gmail.com> --- .../bindings/arm/atmel,at91rm9200-sdramc.yaml | 66 ++++++++++++++++++++++ .../devicetree/bindings/arm/atmel-sysregs.txt | 20 ------- 2 files changed, 66 insertions(+), 20 deletions(-) diff --g...
{ "author": "Akhila YS <akhilayalmati@gmail.com>", "date": "Fri, 27 Feb 2026 15:14:35 +0000", "is_openbsd": false, "thread_id": "20260227-arm-microchip-v4-0-7e2ae1c5b5d6@gmail.com.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
diff --git a/Documentation/ABI/testing/sysfs-driver-intel-xe-sriov b/Documentation/ABI/testing/sysfs-driver-intel-xe-sriov index 2fd7e9b7bacc..7f5ef9eada53 100644 --- a/Documentation/ABI/testing/sysfs-driver-intel-xe-sriov +++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-sriov @@ -119,7 +119,7 @@ Description: ...
{ "author": "Greg Kroah-Hartman <gregkh@linuxfoundation.org>", "date": "Thu, 26 Feb 2026 15:14:57 -0800", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
On Thu, Feb 26, 2026 at 11:46:02PM -0500, Kris Karas (Bug Reporting) wrote: Ick, not good. Can you do 'git bisect' to find the problem commit? As you have a pretty reliable reproducer it should go pretty fast. But first, does 7.0-rc1 work or also crash the same way? thanks, greg k-h
{ "author": "Greg KH <gregkh@linuxfoundation.org>", "date": "Thu, 26 Feb 2026 20:56:59 -0800", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
GregKH wrote: Just tried 6.19.4 (and 6.18.14) and am getting a repeatable Oops right when networking is initialized, likely when nft is loading its ruleset from /etc/nftables/*.conf Once the nft Oops triggers, other processes start to throw errors with memory allocate/free, resulting very quickly in an unusable sy...
{ "author": "\"Kris Karas (Bug Reporting)\" <bugs-a21@moonlit-rail.com>", "date": "Thu, 26 Feb 2026 23:46:02 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
Greg KH wrote: Sure, I'll start a bisect. In the meantime... Appears OK. I'm typing this on the affected system, running 7.0-rc1, and even with a couple manual network restarts, it seems fine. Likely it's an issue with the backport to 6.x. Kris
{ "author": "\"Kris Karas (Bug Reporting)\" <bugs-a21@moonlit-rail.com>", "date": "Fri, 27 Feb 2026 00:27:33 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
Greg KH wrote: Bisect complete (from 6.19.3 to 6.19.4) [snip] Kris P.S. I ran the bisect from 7.0-rc1, so many reboots there, and it is fine. The bug only seems to affect 6.x
{ "author": "\"Kris Karas (Bug Reporting)\" <bugs-a21@moonlit-rail.com>", "date": "Fri, 27 Feb 2026 01:26:11 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
On Fri, 2026-02-27 at 01:26 -0500, Kris Karas (Bug Reporting) wrote: In my case, 7.0-rc1 also boots just fine, but when attempting to load the nftables rules, nft gives an error and rules are not loaded. The same rules work fine in 6.19.3. Do you anything similar? Linux version 7.0.0-rc1-custom-1-00124-g3f4a08e644...
{ "author": "Genes Lists <lists@sapience.com>", "date": "Fri, 27 Feb 2026 07:09:00 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
On Fri, 2026-02-27 at 07:09 -0500, Genes Lists wrote: Sorry for noise, not kernel related. Resolved by updated userspace. Resolved by rebuilding userspace nftables on 6.19.4.  I used git head for all. nft rules now load without error using: - nftables commit de904e22faa2e450d0d4802e1d9bc22013044f93 - libmnl co...
{ "author": "Genes Lists <lists@sapience.com>", "date": "Fri, 27 Feb 2026 08:18:52 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
On Fri, Feb 27, 2026 at 08:18:52AM -0500, Genes Lists wrote: Yet 7.0-rc1 worked just fine? That feels wrong...
{ "author": "Greg KH <gregkh@linuxfoundation.org>", "date": "Fri, 27 Feb 2026 08:32:07 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
On Fri, 2026-02-27 at 08:32 -0500, Greg KH wrote: Sorry if was not clear.  Only 6.19.4 has kernel crash.  The summary is:  - 7.0-rc1 - no kernel issues     boots fine and does not crash when nftables is invoked.       But, It has an nft error and fails to load rules with older nftables userspace.     Same rules l...
{ "author": "Genes Lists <lists@sapience.com>", "date": "Fri, 27 Feb 2026 08:59:28 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
I'm announcing the release of the 6.19.4 kernel. All users of the 6.19 kernel series must upgrade. The updated 6.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.19.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=li...
null
null
null
Linux 6.19.4
On Fri, 2026-02-27 at 08:59 -0500, Genes Lists wrote: ... ... I confirm that  6.19.4 plus git cherry-pick f175b46d9134f708358b5404730c6dfa200fbf3c works fine and resolves the crash in nf_tables_abort_release seen in 6.19.4. gene
{ "author": "Genes Lists <lists@sapience.com>", "date": "Fri, 27 Feb 2026 09:44:45 -0500", "is_openbsd": false, "thread_id": "2026022657-clambake-mountable-8175@gregkh.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Hi all, the XOR library used for the RAID5 parity is a bit of a mess right now. The main file sits in crypto/ despite not being cryptography and not using the crypto API, with the generic implementations sitting in include/asm-generic and the arch implementations sitting in an asm/ header in theory. The latter doesn'...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:12 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Most of the optimized xor_blocks versions require FPU/vector registers, which generally are not supported in interrupt context. Both callers already are in user context, so enforce this at the highest level. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/xor.c | 2 ++ 1 file changed, 2 insertions(+) diff ...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:13 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
xor_blocks can't be called from interrupt context, so remove the handling for that. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/arm/include/asm/xor.h | 41 +++++++++++--------------------------- 1 file changed, 12 insertions(+), 29 deletions(-) diff --git a/arch/arm/include/asm/xor.h b/arch/arm/include/as...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:14 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Drop the pretty confusing historic XOR_TRY_TEMPLATES and XOR_SELECT_TEMPLATE, and instead let the architectures provide a arch_xor_init that calls either xor_register to register candidates or xor_force to force a specific implementation. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/alpha/include/asm/xor.h ...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:20 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Keep xor.h for the public API, and split the struct xor_block_template definition that is only needed by the xor.ko core and architecture-specific optimizations into a separate xor_impl.h header. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/arm/lib/xor-neon.c | 1 + arch/s390/lib/xor.c | 2...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:19 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the ifdef'ery doesn't do anything. With our without this, the time travel mode should work fine on CPUs that support AVX2, as the AVX2 implementation is forced in this case, and won't work otherwise. Signed-off-by: Christoph Hellwig <hch@lst.de> ---...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:15 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Update the to of file comment to be correct and non-redundant, and drop the unused BH_TRACE define. Signed-off-by: Christoph Hellwig <hch@lst.de> --- lib/raid/xor/xor-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/raid/xor/xor-core.c b/lib/raid/xor/xor-core.c index 864f3604e867..28...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:17 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/loongarch/include/asm/xor.h | 24 ++---------- arch/loongarch/include/asm/xor_simd.h | 34 ---------------- arch/loonga...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:25 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in the main xor.ko instead of building a separate module for it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/arm/include/asm/xor.h | 190 +----------------- arch/arm/lib/Makefile | 5 - lib/raid/xor/Makefile...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:23 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in the main xor.ko instead of building a separate module for it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/arm64/include/asm/xor.h | 58 +------------------ arch/arm64/lib/Makefile | 6 -- lib/raid/xor/Makefile...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:24 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Originally, the XOR code benchmarked all algorithms at load time, but it has since then been hacked multiple times to allow forcing an algorithm, and then commit 524ccdbdfb52 ("crypto: xor - defer load time benchmark to a later time") changed the logic to a two-step process or registration and benchmarking, but only wh...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:18 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/riscv/include/asm/xor.h | 54 +------------------ arch/riscv/lib/Makefile | 1 - lib/raid/xor/Makefile...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:27 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/powerpc/include/asm/xor.h | 17 +---- arch/powerpc/include/asm/xor_altivec.h | 22 ------ arch/powerpc/lib/Makefile ...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:26 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in xor.ko instead of unconditionally building it into the main kernel image. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/s390/lib/Makefile | 2 +- lib/raid/xor/Makefile | 1 + {arch/s390/lib => lib/raid/xor/s390...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:29 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Replace use of the loop around xor_blocks with the easier to use xor_gen API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/async_tx/async_xor.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c index 2c499654a36c...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:34 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
xor_blocks is very annoying to use, because it is limited to 4 + 1 sources / destinations, has an odd argument order and is completely undocumented. Lift the code that loops around it from btrfs and async_tx/async_xor into common code under the name xor_gen and properly document it. Signed-off-by: Christoph Hellwig <...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:33 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Use the new xor_gen helper instead of open coding the loop around xor_blocks. This helper is very similar to the existing run_xor helper in btrfs, except that the destination buffer is passed explicitly. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/btrfs/raid56.c | 27 ++++----------------------- 1 file chan...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:35 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Remove the inner xor_block_templates, and instead have two separate actual template that call into the neon-enabled compilation unit. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/arm64/include/asm/xor.h | 13 ++-- lib/raid/xor/arm64/xor-neon-glue.c | 95 +++++++++++++++--------------- lib/raid/xor/arm...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:31 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR into lib/raid and include it it in xor.ko instead of always building it into the main kernel image. This also splits the sparc64 code into separate files for the two implementations. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/sparc/include/asm/asm-prototypes.h | 1 - arch/s...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:28 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Avoid the indirect call for xor_generation by using a static_call. Signed-off-by: Christoph Hellwig <hch@lst.de> --- lib/raid/xor/xor-32regs.c | 2 +- lib/raid/xor/xor-core.c | 29 ++++++++++++++--------------- lib/raid/xor/xor_impl.h | 4 ++++ 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/li...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:37 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the generic implementations from asm-generic/xor.h to per-implementaion .c files in lib/raid. Note that this would cause the second xor_block_8regs instance created by arch/arm/lib/xor-neon.c to be generated instead of discarded as dead code, so add a NO_TEMPLATE symbol to disable it for this case. Signed-off-by...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:21 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR code out of line into lib/raid. Note that the giant inline assembly block might be better off as a separate assembly source file now, but I'll leave that to the alpha maintainers. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/alpha/include/asm/xor.h | 853 +----------------------------...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:22 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the optimized XOR code out of line into lib/raid. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/x86/include/asm/xor.h | 518 ++---------------- arch/x86/include/asm/xor_64.h | 32 -- lib/raid/xor/Makefile | 8 + .../xor_avx.h => lib/raid/xor/...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:30 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Move the asm/xor.h headers to lib/raid/xor/$(SRCARCH)/xor_arch.h and include/linux/raid/xor_impl.h to lib/raid/xor/xor_impl.h so that the xor.ko module implementation is self-contained in lib/raid/. As this remove the asm-generic mechanism a new kconfig symbol is added to indicate that a architecture-specific implemen...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:32 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
Currently the high-level xor code chunks up all operations into small units for only up to 1 + 4 vectors, and passes it to four different methods. This means the FPU/vector context is entered and left a lot for wide stripes, and a lot of indirect expensive indirect calls are performed. Switch to passing the entire ge...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Thu, 26 Feb 2026 07:10:36 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, Feb 26, 2026, at 16:10, Christoph Hellwig wrote: Acked-by: Arnd Bergmann <arnd@arndb.de> # for asm-generic The #include is slightly ugly, but I see it gets better in a later patch, and is clearly worth it either way. The rest of the series looks good to me as well. I had a brief look at each patch, but nothi...
{ "author": "\"Arnd Bergmann\" <arnd@arndb.de>", "date": "Thu, 26 Feb 2026 16:40:21 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, 26 Feb 2026 07:10:12 -0800 Christoph Hellwig <hch@lst.de> wrote: Thanks, I'll add this to mm.git's mm-nonmm-unstable tree for some testing in linux-next.
{ "author": "Andrew Morton <akpm@linux-foundation.org>", "date": "Thu, 26 Feb 2026 10:20:37 -0800", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
----- Ursprüngliche Mail ----- IIRC Johannes added XOR_SELECT_TEMPLATE() here to skip the template selection logic because it didn't work with time travel mode. Johannes, can you please test whether this change does not break time travel mode? Thanks, //richard
{ "author": "Richard Weinberger <richard@nod.at>", "date": "Thu, 26 Feb 2026 22:45:26 +0100 (CET)", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, Feb 26, 2026 at 10:45:26PM +0100, Richard Weinberger wrote: I'm pretty sure that was the intent, but as I wrote above it worked and still works on AVX-supporting CPUs by chance, and already doesn't on older CPUs, and unless my git blaming went wrong someewhere already didn't when this was originally added.
{ "author": "hch <hch@lst.de>", "date": "Thu, 26 Feb 2026 23:00:38 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, 2026-02-26 at 22:45 +0100, Richard Weinberger wrote: It does work, even if it reports nonsense (as you'd expect): xor: measuring software checksum speed prefetch64-sse : 12816000 MB/sec sse : 12816000 MB/sec xor: using function: prefetch64-sse (12816000 MB/sec) I think it works now because...
{ "author": "Johannes Berg <johannes@sipsolutions.net>", "date": "Fri, 27 Feb 2026 08:39:47 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, Feb 26, 2026 at 07:10:29AM -0800, Christoph Hellwig wrote: FWIW: Acked-by: Heiko Carstens <hca@linux.ibm.com> However, I just had a look at the s390 implementation and just saw that the inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", and "p2" are input operands, while all three of the...
{ "author": "Heiko Carstens <hca@linux.ibm.com>", "date": "Fri, 27 Feb 2026 10:09:59 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Fri, Feb 27, 2026 at 10:09:59AM +0100, Heiko Carstens wrote: Two comments on that: I thin kin the long run simply moving the implementation to a pure assembly file might be easier to maintain. Also with this series you can now optimize for more than 5 stripes, which should be the mormal case. I'll try to make sur...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Fri, 27 Feb 2026 15:13:11 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, Feb 26, 2026 at 07:10:13AM -0800, Christoph Hellwig wrote: Your changelog makes it sound like you want: WARN_ON_ONCE(!in_task()); But perhaps something like so: lockdep_assert_preempt_enabled(); Would do? That ensures we are in preemptible context, which is much the same. That also ensures the cost of th...
{ "author": "Peter Zijlstra <peterz@infradead.org>", "date": "Fri, 27 Feb 2026 15:24:55 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
Move the RAID XOR code to lib/raid/ as it has nothing to do with the crypto API. Signed-off-by: Christoph Hellwig <hch@lst.de> --- crypto/Kconfig | 2 -- crypto/Makefile | 1 - lib/Kconfig | 1 + lib/Makefile | 2 +...
null
null
null
[PATCH 04/25] xor: move to lib/raid/
On Thu, Feb 26, 2026 at 07:10:30AM -0800, Christoph Hellwig wrote: I gotta ask, why lib/raid/xor/$arch/ instead of something like arch/$arch/lib/xor ?
{ "author": "Peter Zijlstra <peterz@infradead.org>", "date": "Fri, 27 Feb 2026 15:30:16 +0100", "is_openbsd": false, "thread_id": "20260227143606.GI1282955@noisy.programming.kicks-ass.net.mbox.gz" }
lkml_critique
lkml
The driver currently sets bit 0 of USB_PHY_CFG1 (PLL_EN) during PHY initialization. According to the M31 EUSB2 PHY hardware documentation, this bit is intended only for test/debug scenarios and does not control mission mode operation. Keeping PLL_EN asserted causes the PHY to draw additional current during USB bus susp...
null
null
null
[PATCH] phy: qcom: m31-eusb2: clear PLL_EN during init
On 2/17/26 9:11 PM, Elson Serrao wrote: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Wed, 18 Feb 2026 11:58:50 +0100", "is_openbsd": false, "thread_id": "177220617425.330302.16212600767917338005.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
The driver currently sets bit 0 of USB_PHY_CFG1 (PLL_EN) during PHY initialization. According to the M31 EUSB2 PHY hardware documentation, this bit is intended only for test/debug scenarios and does not control mission mode operation. Keeping PLL_EN asserted causes the PHY to draw additional current during USB bus susp...
null
null
null
[PATCH] phy: qcom: m31-eusb2: clear PLL_EN during init
On Tue, 17 Feb 2026 12:11:30 -0800, Elson Serrao wrote: Applied, thanks! [1/1] phy: qcom: m31-eusb2: clear PLL_EN during init commit: 520a98bdf7ae0130e22d8adced3d69a2e211b41f Best regards, -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:59:34 +0530", "is_openbsd": false, "thread_id": "177220617425.330302.16212600767917338005.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
The EDID parsing code initially introduced the DRM_COLOR_FORMAT_* defines to represent the sink capabilities. Since a given sink could support multiple formats, it was first defined as a bitmask. However, the core and drivers have since leveraged those defines to represent both the supported formats but also the curre...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:40 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:41 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:42 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:43 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:44 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:45 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:46 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:47 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:48 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:49 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:50 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that we introduced a new drm_output_color_format enum to represent what DRM_COLOR_FORMAT_* bits were representing, we can switch to the new enum. The main different is that while DRM_COLOR_FORMAT_ was a bitmask, drm_output_color_format is a proper enum. However, the enum was done is such a way than DRM_COLOR_FORMA...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:51 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Now that all users of DRM_COLOR_FORMAT_* defines have been converted to the new enum, we can get rid of those defines. Signed-off-by: Maxime Ripard <mripard@kernel.org> --- include/drm/drm_connector.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h ind...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:52 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
The hdmi_colorspace enum was defined to represent the colorspace value of the HDMI infoframes. It was later used by some HDMI drivers to express the output format they should be setting up. During the introduction of the HDMI helpers, it then was used to represent it in the drm_connector_hdmi_state structure. However...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Tue, 24 Feb 2026 11:58:53 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Tue, 24 Feb 2026, Maxime Ripard <mripard@kernel.org> wrote: You could avoid the include by forward declaring the enum, which is not strictly standard C but allowed by both GCC and Clang, and quite useful in reducing header dependencies. BR, Jani. -- Jani Nikula, Intel
{ "author": "Jani Nikula <jani.nikula@linux.intel.com>", "date": "Tue, 24 Feb 2026 14:43:37 +0200", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Tue, 24 Feb 2026, Maxime Ripard <mripard@kernel.org> wrote: I like this. I eyeballed through the series, but did not spend enough time to call it detailed review. Acked-by: Jani Nikula <jani.nikula@intel.com> -- Jani Nikula, Intel
{ "author": "Jani Nikula <jani.nikula@linux.intel.com>", "date": "Tue, 24 Feb 2026 14:44:57 +0200", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Tue, Feb 24, 2026 at 11:58:49AM +0100, Maxime Ripard wrote: For the first patch in the series that introduces the enum and this one: Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ sour...
{ "author": "Liviu Dudau <liviu.dudau@arm.com>", "date": "Wed, 25 Feb 2026 16:12:08 +0000", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Tuesday, 24 February 2026 11:58:53 Central European Standard Time Maxime Ripard wrote: Almost unrelated nit: we might want to also `fmt < 0 ||` here, since the base type of enums is a signed int. I almost caught myself using this function as a way to quickly check if a supplied color format property from userspace ...
{ "author": "Nicolas Frattaroli <nicolas.frattaroli@collabora.com>", "date": "Wed, 25 Feb 2026 18:03:00 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Wednesday, 25 February 2026 18:03:00 Central European Standard Time Nicolas Frattaroli wrote: Gah, disregard this, I just realised that this enum shouldn't be used as the one in the property anyway, because of AUTO, as you already pointed out in your reply to my series as well.
{ "author": "Nicolas Frattaroli <nicolas.frattaroli@collabora.com>", "date": "Wed, 25 Feb 2026 18:21:46 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Di, 2026-02-24 at 11:58 +0100, Maxime Ripard wrote: s/different/difference/ Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
{ "author": "Philipp Zabel <p.zabel@pengutronix.de>", "date": "Thu, 26 Feb 2026 09:58:24 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Di, 2026-02-24 at 11:58 +0100, Maxime Ripard wrote: Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
{ "author": "Philipp Zabel <p.zabel@pengutronix.de>", "date": "Thu, 26 Feb 2026 09:59:38 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Di, 2026-02-24 at 11:58 +0100, Maxime Ripard wrote: Can we move this? Either up, directly after drm_output_color_format, or down, directly before color_formats. I think 8d70f395e6cb ("drm: Add support for a panel-orientation connector property, v6") didn't separate the two on purpose. Maybe s/YCrCb/YCbCr/ for co...
{ "author": "Philipp Zabel <p.zabel@pengutronix.de>", "date": "Thu, 26 Feb 2026 10:12:02 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Tuesday, 24 February 2026 11:58:53 Central European Standard Time Maxime Ripard wrote: I don't think this will work as-is. drm_bridge_connector_init calls this function assuming hdmi_colorspace bitmasks in supported_formats. This may have slipped through the conversion; the synopsys dw-hdmi-qp core (separate from ...
{ "author": "Nicolas Frattaroli <nicolas.frattaroli@collabora.com>", "date": "Thu, 26 Feb 2026 17:24:05 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Hi On Thu, Feb 26, 2026 at 05:24:05PM +0100, Nicolas Frattaroli wrote: Yeah, you're right I missed the conversion in drm_bridge_connector_init. It should be fixed now. For this one, did you identify anything more than the comment in dw_hdmi_qp_plat_data? I couldn't find any user of HDMI_COLORSPACE_* left for the dw...
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Fri, 27 Feb 2026 09:29:05 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Hi Philipp On Thu, Feb 26, 2026 at 10:12:02AM +0100, Philipp Zabel wrote: I'm not sure it's worth it, the last patch in this series will remove these so it's not going to stick around either. Yep, definitely. I'll update it. Maxime
{ "author": "Maxime Ripard <mripard@kernel.org>", "date": "Fri, 27 Feb 2026 09:38:13 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
On Friday, 27 February 2026 09:29:05 Central European Standard Time Maxime Ripard wrote: Nope, it's really just the comment. My series will obviously need adjusting since it makes use of that member, but that's part of my rebase. So far, there don't seem to be any users that set the member, so it's just the comment do...
{ "author": "Nicolas Frattaroli <nicolas.frattaroli@collabora.com>", "date": "Fri, 27 Feb 2026 13:46:50 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
Hi, This series creates an enum to represent the output color format as an enum instead of a bitmask, and consolidate the HDMI helpers to use the new enum. This should make Nicolas' work easier. It has been build tested, and passes kunit tests. Let me know what you think, Maxime --- Maxime Ripard (14): drm/c...
null
null
null
[PATCH 00/14] drm: Create drm_output_color_format enum
Hi Maxime, On Fr, 2026-02-27 at 09:38 +0100, Maxime Ripard wrote: [...] [...] I agree it's not, I just didn't look as far as patch 13. regards Philipp
{ "author": "Philipp Zabel <p.zabel@pengutronix.de>", "date": "Fri, 27 Feb 2026 16:10:39 +0100", "is_openbsd": false, "thread_id": "20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
This patch set adds support for standard ethtool statistics - rmon, eth-ctrl, eth-mac and pause - to dpaa2-mac and its users dpaa2-eth and dpaa2-switch. The first patch extends the firmware APIs related to MAC counters and adds dpmac_get_statistics() which can be used to retrieve multiple counter values through a sing...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Wed, 25 Feb 2026 17:06:43 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
Even though pause frame statistics are not exported through the same ethtool command, there is no point in adding another helper just for them. Extent the ethtool_std_stats_get() function so that we are able to interrogate using the same helper all the standard statistics. Signed-off-by: Ioana Ciornei <ioana.ciornei@n...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Wed, 25 Feb 2026 17:06:47 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
Take advantage of all the newly added MAC counters available through the MC API and export them through the standard statistics structures - rmon, eth-ctrl, eth-mac and pause. A new version based feature is added into dpaa2-mac - DPAA2_MAC_FEATURE_STANDARD_STATS - and based on the two memory zones needed for gathering...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Wed, 25 Feb 2026 17:06:46 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
Extend the dpmac_counter_id enum with the newly added counters which can be interrogated through the MC firmware. Also add the dpmac_get_statistics() API which can be used to retrieve multiple MAC counters through a single firmware command. Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- .../net/ethernet/fre...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Wed, 25 Feb 2026 17:06:44 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
Add a new selftest - ethtool_std_stats.sh - which validates the eth-ctrl, eth-mac and pause standard statistics exported by an interface. Not all counters can be validated in software, especially those that are keeping track of errors. Counters such as SingleCollisionFrames, FrameCheckSequenceErrors etc are not tested ...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Wed, 25 Feb 2026 17:06:48 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Wed, Feb 25, 2026 at 05:06:48PM +0200, Ioana Ciornei wrote: Hi Ioana Thanks for the test! Do we actually expect errors when running such a test? How many times have you run this test and seen any of the error counters be anything other than 0? Which do you think is more likely: 1) A real error happens 2) Bug i...
{ "author": "Andrew Lunn <andrew@lunn.ch>", "date": "Thu, 26 Feb 2026 00:38:58 +0100", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Thu, Feb 26, 2026 at 12:38:58AM +0100, Andrew Lunn wrote: No, we don't expect any errors with this test and I didn't see any error counters incremenent in the tens of times that I ran the selftest. But, to be fair, I was not looking for them thoroughly through testing. I would say that having a driver bug is much...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Thu, 26 Feb 2026 09:03:32 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Thu, Feb 26, 2026 at 09:03:32AM +0200, Ioana Ciornei wrote: I am back with a bit more information. The counters which were not checked in this version can be grouped in two categories: - Error counters such as: u64 FrameCheckSequenceErrors; u64 AlignmentErrors; u64 FramesLostDueToIntMACXmitError; u64 CarrierS...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Thu, 26 Feb 2026 14:19:33 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
Great. How about, fail the test if any are greater than 1% of the number of packets transmitted/received? My _guess_ is, if you have 1% packet loss, networking is not going to be happy anyway. It probably means you have one end doing Half duplex and the other Full. That is a typical configuration error you see causin...
{ "author": "Andrew Lunn <andrew@lunn.ch>", "date": "Thu, 26 Feb 2026 14:31:26 +0100", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Wed, 25 Feb 2026 17:06:48 +0200 Ioana Ciornei wrote: Argh, at some point we should probably decide whether we have a preference on which "library" / set of env vars we use under drivers/net/hw. Adding Petr to CC. The existing tests under drivers/net/hw which source forwarding/lib.sh pre-date the "NIC setup" desc...
{ "author": "Jakub Kicinski <kuba@kernel.org>", "date": "Thu, 26 Feb 2026 18:22:23 -0800", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Thu, 26 Feb 2026 16:18:21 +0200 Ioana Ciornei wrote: FWIW the expectation is that the test should be able to run even on systems / boards with a single interface. So the control traffic (communicating with the traffic generator) will run over the same interface as the test. 1% error is unachievable. I'd only check ...
{ "author": "Jakub Kicinski <kuba@kernel.org>", "date": "Thu, 26 Feb 2026 18:25:11 -0800", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net: dpaa2-mac: retrieve MAC statistics in one firmware command The latest MC firmware version added...
{ "author": "Jakub Kicinski <kuba@kernel.org>", "date": "Thu, 26 Feb 2026 18:26:13 -0800", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Thu, Feb 26, 2026 at 06:25:11PM -0800, Jakub Kicinski wrote: Really? I didn't know of that expectation at all. I did take ethtool_rmon.sh as an example and that selftest as well takes NUM_NETIFS=2 and does check for both a lower bound and upper bound that takes into account a 1% deviance from the target. How woul...
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Fri, 27 Feb 2026 09:34:28 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Thu, Feb 26, 2026 at 06:26:13PM -0800, Jakub Kicinski wrote: (...) Yes, that is indeed true. Thanks for catching it! Ioana
{ "author": "Ioana Ciornei <ioana.ciornei@nxp.com>", "date": "Fri, 27 Feb 2026 12:37:56 +0200", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }
lkml_critique
lkml
The latest MC firmware version added a new command to retrieve all DPMAC counters in a single firmware call. Use this new command, when possible, in dpaa2-mac as well. In order to use the dpmac_get_statistics() API, two DMA memory areas are used: one to transmit what counters the driver is requesting and one to receiv...
null
null
null
[PATCH net-next 2/5] net: dpaa2-mac: retrieve MAC statistics in one firmware command
On Fri, Feb 27, 2026 at 09:34:28AM +0200, Ioana Ciornei wrote: Just to add to this, for the 1% i was referring to counters for collisions. If the control traffic is causing collisions the system it just as wrongly configured as generated traffic causing collisions. For 'everyday' systems, i doubt Half Duplex is ever ...
{ "author": "Andrew Lunn <andrew@lunn.ch>", "date": "Fri, 27 Feb 2026 15:17:02 +0100", "is_openbsd": false, "thread_id": "87ms0ufc0p.fsf@nvidia.com.mbox.gz" }